[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Dec 7 17:26:40 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 58020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58020&action=edit
Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds

This patch replace the different calls to GetReservesFromBorrowernumber
with a calls to Koha::Patron->get_holds.
In some places we need to get a restricted set of holds, that's why we
process a search on this holds returned by ->get_holds (on the found
status for instance).

The changes are quite trivial and reading the diff should be enough to
catch bugs.

Test plan:
I would suggest to test this patch with patches from bug 17736 and bug 17737,
to place different kind of holds (biblio and item level, future and
past).
Then do a whole workflow to detect bug, view a record, delete record,
order, place a hold on an item which has been ordered, etc.
The hold's informations should always be the same without or without
these patches.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list