[Koha-bugs] [Bug 17758] New: SIP checkin does not handle holds correctly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17758

            Bug ID: 17758
           Summary: SIP checkin does not handle holds correctly
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: boutrosboutrosboutros at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

We have been investingating some strange behaviour from our SIP transactions:

Given a biblio with to items x1 & x2, and two holds on the biblo.
- Checkin (via SIP) x1 on the pickup branch - hold is filled and notified in
SIP message.
- Checkin (via SIP) x2 on another branch - get notified of hold again, but this
time the hold is swapped so that now item x2 fullfils the hold, and x1 is again
available.

If do the same transactions in the web-interface - no error occurs.

I belive bug #14695 is the origin of this behaviour. If you look at commit
https://github.com/Koha-Community/Koha/commit/6e76e342cb6ac6036738d79418ff068ad84346cc
which changes the signature of ModReserveAffect (without updating the
documentation btw) but fails to update the corresponding usage of it in the
SIP::ILS::Transaction::Checkin.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.