[Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 58271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58271&action=edit
[SIGNED-OFF] Bug 17783: Optimize Koha::IssuingRules->get_effective_issuing_rule

This patch modifies method get_effective_issuing_rule in Koha::IssuingRules
aiming to optimize the search for matching issuing rule.

Before this patch, in worst case scenario, we have had to make a SELECT query
eight times. This will have a negative impact on performance where-ever we need
to find matching issuing rule multiple times, if the search is not directly
matching an issuing rule on the first query.

This patch makes get_effective_issuing_rule have a stable performance on both
best and worst case, whereas the old method was really fast on the best case
and really slow on the worst case.

However, this patch slightly lowers the performance for best case, where
matching
issuing rule is found instantly before (branchcode, categorycode and itemtype
all
are specifically defined in issuing rules). For all other cases this patch
offers
a performance improvement.

To test:
1. Run t/db_dependent/Koha/IssuingRules.t and compare the results with previous
   tests.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.