[Koha-bugs] [Bug 17783] Optimize Koha::IssuingRules->get_effective_issuing_rule
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Dec 20 16:37:32 CET 2016
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17783
Josef Moravec <josef.moravec at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #58300|0 |1
is obsolete| |
--- Comment #13 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 58304
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58304&action=edit
[SIGNED-OFF] Bug 17783: Prevent crash when providing an undefined value
When calling the proposed version of get_effective_issuing_rule with undefined
parameter values, a following crash occurs:
SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: SQL::Abstract before
v1.75
used to generate incorrect SQL when the -IN operator was given an
undef-containing
list: !!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based version of
SQL::Abstract will emit the logically correct SQL instead of raising this
exception) at /home/ubuntu/kohaclone/Koha/Objects.pm line 182
This patch adds a test to cover this problem and fixes the issue.
To test:
1. Run t/db_dependent/Koha/IsssuingRules.t
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list