[Koha-bugs] [Bug 17447] Housekeeping: Tidy up misc/batchRebuildItemsTables.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Dec 22 20:29:58 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 56578
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56578
Bug 17447: Housekeeping: Tidy up misc/batchRebuildItemsTables.pl

Review of attachment 56578:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17447&attachment=56578)
-----------------------------------------------------------------

::: misc/batchRebuildItemsTables.pl
@@ +35,3 @@
>  my $starttime = gettimeofday;
>  my @errors;
>  my %opt;

Is this even used?

@@ +43,4 @@
>      'where:s' => \$where,
>  ) or pod2usage(2);
>  
> +pod2usage(1) if $help || ( !$confirm && !$test_parameter );

Tweaks and whitespace changes should be separate commits to make it easier to
check.
git diff -w origin/master pointed out this and a couple others.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list