[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Dec 30 16:41:28 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58524|0                           |1
        is obsolete|                            |

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 58530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58530&action=edit
Bug 17447: Remove unused vars from batchRebuildItemsTables.pl

Variables $extkey not used, %opt not used.
Variables $tmptest[...] not used, calling _build_tag_directory useless.
The script now does not only print help if you specify -t.
Sub defnonull tidied.
Rearranged modules, removed Dumper.

Test plan:
[1] Run the script with -t flag. The script should not only print usage
    statement, but should do a dry run. (Test this on a small database,
    or pass an additional where clause.)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

NOTE: Fixed %opt in my followup.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list