[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #13)
> Created attachment 58533 [details] [review]
> Bug 17447: %opt is unused
> 
> Deleted the line.
> perlcritic -4 before and after.
> Before there are issues. After there is not.
> 
> Also, changed function to not rely on implicit return value
> of last line, but explicitly stated a return. And operator
> changed, due to precedence issues.
> 
> Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Thx Mark.
I am sure to have deleted the opt line, but pretty sure now too that i did not
commit that last change ;)
The change in defnonull is fine with me, but the QAer may also remove it
completely. We could just say something like pref(merge) || 0.

-- 
You are receiving this mail because:
You are watching all bug changes.