From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 01:42:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 00:42:03 +0000 Subject: [Koha-bugs] [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | Change sponsored?|--- |Sponsored --- Comment #2 from Aleisha Amohia --- Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 02:08:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 01:08:46 +0000 Subject: [Koha-bugs] [Bug 15711] New: Deleting patroncard images has unexpected behaviour and is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711 Bug ID: 15711 Summary: Deleting patroncard images has unexpected behaviour and is broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: 1) Go to Tools -> Patron Card Creator -> Manage Images. Upload an image if you do not already have something uploaded 2) Without checking any boxes, click the 'Delete selected' box 3) A box will pop up saying 'Please select image(s) to delete', as expected. Click 'OK' 4) Another pop-up saying 'Are you sure you want to delete image(s): undefined?' This is unexpected and shouldn't be showing up if nothing has been selected. 5) Click 'OK' - This also doesn't work (image isn't deleted) and gives an error 'WARNING: An error has occurred. Please ask your system administrator to check the error log for more details.' 6) Check the box next to an image and click 'Delete selected', then 'OK'. You get the WARNING error again and the image isn't deleted. This is broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 02:18:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 01:18:17 +0000 Subject: [Koha-bugs] [Bug 15709] Koha website main navigation looks funny In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15709 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |FIXED --- Comment #1 from Liz Rea --- Fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 02:18:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 01:18:41 +0000 Subject: [Koha-bugs] [Bug 15710] Kohacon 2015 is missing in the list of Kohacons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15710 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |FIXED --- Comment #1 from Liz Rea --- Fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 02:49:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 01:49:45 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #6 from Srdjan Jankovic --- I have no specific plan for this. Existing code change should be transparent and is mainly in two core files C4:Context: * in the way it is used (initialised and imported) * the way sysprefs are cached * default cache is now stored in context rather than being a singleton Koha::Database: * new_schema() now takes optional context param There's a number of files which have as a consequence all Koha::Cache->get_instance calls replaced with C4::Context->cache Arguably I should have replaced Koha::Database->[new()]->schema calls with C4::Context->schema, to get it in line with the cache change, (and maybe I will), but that would mean changing every file. Besides Koha::Database->new()->schema hurts your eyes and soul much more than C4::Context->schema so we may feel some pressure to change the way we are using the database handle. I assume all relevant functionality is covered in the tests, and tests passing with MEMCACHED_SERVERS set is a good starting point. Otherwise what I tried was * going to (many) pages, checking that context is loaded properly, and the database connection is ok * checking that sysprefs caching works I can only suggest checking other pages which use cache. The change is not deployed on our test/demo sites yet, but will be shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 03:40:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 02:40:30 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 --- Comment #22 from David Cook --- (In reply to Mirko Tietgen from comment #21) > I assume Robin is not going to work on this any longer? As far as I know, Robin isn't working on Koha at all anymore, so that's probably a safe assumption. I'm sure Chris Cormack or Liz Rea would be able to confirm that though (or Robin if he's still lurking). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 03:44:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 02:44:15 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #94 from David Cook --- (In reply to Marcel de Rooy from comment #93) > (In reply to David Cook from comment #92) > > Just a FYI for people testing out permanent uploads. > > > > If you're using "/tmp" as the "upload_path", you might want to check if > > you're using "PrivateTmp". > > David: I would not recommend to user /tmp for permanent uploads. Note that > File::Spec->tmpdir is also used for *temporary* uploads. > The default for permanent uploads in Debian packaging is > /var/lib/koha/instance/uploads. That's why I said: 'Of course, you'd never actually use "/tmp" for storing a file permanently, as "/tmp" should be deleted when your server next reboots (or if some other clean-up job is running).' Yeah, I don't use Debian packages, as I run Koha on openSUSE, and I don't think there's any default path. By default, it's just empty, so up to the user to decide where to put it. In my case, it would probably be, "instance/var/uploads". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 04:53:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 03:53:19 +0000 Subject: [Koha-bugs] [Bug 6419] link to reports from other pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 06:53:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 05:53:00 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 06:53:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 05:53:53 +0000 Subject: [Koha-bugs] [Bug 6419] link to reports from other pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 08:33:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 07:33:41 +0000 Subject: [Koha-bugs] [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47485|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 47486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47486&action=edit Bug 15706: Changing to circulate_remaining_permissions I have only changed this in the includes for the tabs at the top. Dependent on Bug 12051 as that patch adds extra tabs to the top which would need to be changed later To test: 1) Apply Bug 12051 first, then this patch 2) Ensure that Check Out/Check In/Renew tabs still work as they should 3) Check patch for errors or pages I've missed Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 08:34:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 07:34:27 +0000 Subject: [Koha-bugs] [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 09:03:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 08:03:45 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #203 from Marcel de Rooy --- Great work! Detail for patch: Use Template::Stash::AutoEscaping to use the html filter Note that this still needs attention in terms of (Debian) packaging. At first glance this module does not seem to be available in a Debian package. Obviously, new perl dependencies should preferably be available already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 09:18:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 08:18:25 +0000 Subject: [Koha-bugs] [Bug 15712] New: Could not find opac-search.xml in /opt/koha/opac/cgi-bin/opac/ at /opt/koha/lib/C4/Search.pm line 611 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15712 Bug ID: 15712 Summary: Could not find opac-search.xml in /opt/koha/opac/cgi-bin/opac/ at /opt/koha/lib/C4/Search.pm line 611 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: kishepee at hotmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 47487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47487&action=edit OPAC search error screen shoot I am having an error with such displaying"Could not find Could not find opac-search.xml in /opt/koha/opac/cgi-bin/opac/ at /opt/koha/lib/C4/Search.pm line 611" error with installed koha 3.04.02.000. I can make search on Staff Client but on OPAC this error appeared ....any idea any one?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 09:20:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 08:20:58 +0000 Subject: [Koha-bugs] [Bug 15712] Could not find opac-search.xml in /opt/koha/opac/cgi-bin/opac/ at /opt/koha/lib/C4/Search.pm line 611 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15712 Mohammad Rasool changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kishepee at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 09:39:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 08:39:53 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47197|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 47488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47488&action=edit Bug 15645 - In transit holds do not show as in transit on request.pl A hold in transit will simply appear as an unfilled hold! Test Plan: 1) Place a hold for pickup at a different location 2) Capture that hold for a patron 3) Note you do not see the in transit status on request.pl 4) Apply this patch 5) Refresh the page 6) The hold should now show as in transit! Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 09:40:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 08:40:12 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 09:43:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 08:43:27 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:19:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 09:19:50 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33789|0 |1 is obsolete| | --- Comment #35 from Julian Maurice --- Created attachment 47489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47489&action=edit Bug 13321: Rename variables Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:20:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 09:20:03 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33790|0 |1 is obsolete| | --- Comment #36 from Julian Maurice --- Created attachment 47490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47490&action=edit Bug 13321: use the populate_with_prices where needed Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:20:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 09:20:17 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33791|0 |1 is obsolete| | --- Comment #37 from Julian Maurice --- Created attachment 47491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47491&action=edit Bug 13321: Fix the prices calculation method Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:20:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 09:20:31 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33792|0 |1 is obsolete| | --- Comment #38 from Julian Maurice --- Created attachment 47492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47492&action=edit Bug 13321: Tax and prices calculation - DB Changes Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:20:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 09:20:41 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34432|0 |1 is obsolete| | --- Comment #39 from Julian Maurice --- Created attachment 47493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47493&action=edit Bug 13321: Csv export - Display rrp and ecost with and without taxes Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:20:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 09:20:51 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35165|0 |1 is obsolete| | --- Comment #40 from Julian Maurice --- Created attachment 47494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47494&action=edit Bug 13321: Fix unitprice rounding Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:21:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 09:21:13 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33793|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:27:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 09:27:05 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli at cineca.it | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:33:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 09:33:51 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33869|0 |1 is obsolete| | --- Comment #12 from Julian Maurice --- Created attachment 47495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47495&action=edit Bug 13323: Tax rate can change on receiving - DB changes Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:34:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 09:34:02 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33870|0 |1 is obsolete| | --- Comment #13 from Julian Maurice --- Created attachment 47496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47496&action=edit Bug 13323: Tax rate can change on receiving Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:34:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 09:34:18 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33871|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:36:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 09:36:04 +0000 Subject: [Koha-bugs] [Bug 13324] [DEPENDS_ON_13321] The fund values must be based on tax included values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33795|0 |1 is obsolete| | --- Comment #10 from Julian Maurice --- Created attachment 47497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47497&action=edit Bug 13324: The fund values should be based on tax included values Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:50:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 09:50:42 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #14 from Julian Maurice --- All patches rebased on master. Also, sandbox 17 has been updated with those patches: http://pro.test17.biblibre.com/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 11:14:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 10:14:11 +0000 Subject: [Koha-bugs] [Bug 15516] RFC: Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46392|0 |1 is obsolete| | --- Comment #4 from Julian Maurice --- Created attachment 47498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47498&action=edit Bug 15516: Allow to reserve first available item from a group of titles Added missing atomicupdate file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 11:15:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 10:15:47 +0000 Subject: [Koha-bugs] [Bug 15681] Improve visibility of place hold option when checking out an item already checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |veron at veron.ch --- Comment #1 from Jonathan Druart --- Yes, I completely agree. I have asked when QAing bug 1983, and was not really convinced by the answer. But let it pass anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 11:32:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 10:32:32 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #67 from Jonathan Druart --- Nick, it's much more better, but there is something wrong. The change to C4::Members::GetBorrowersToExpunge is not consistent: we expect the subroutine behaves the same for patron list than for other params. For instance, the category_code != 'S' and the guarantor tests are not done if patron list is passed. Moreover, it's not obvious that the patron_list_id is independent from other params. I'd say you should join the patron_list_patrons when the param is given. There is also a lack of tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 11:47:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 10:47:32 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #15 from Julian Maurice --- Created attachment 47499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47499&action=edit Bug 13323: QA fix (trailing whitespace) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 12:27:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 11:27:51 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #204 from Jonathan Druart --- New test added to the QA script: commit a9ddabb936a0a1539d01992908b3e6484b6d6466 The html filter is not needed anymore (see bug 13618) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 12:38:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 11:38:46 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Barry Cannon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47385|0 |1 is obsolete| | --- Comment #5 from Barry Cannon --- Created attachment 47500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47500&action=edit Corrects problem with https sites accessing google jackets This patch adds prefix variable to the google-jackets.js file. This detects the current URL prefix and uses that to connect to google to retrieve images. Test Plan: 1) Enable Google Jackets 2) Ensure the Koha OPAC instance is configued to use HTTPS 3) Confirm Google jackets display correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 12:52:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 11:52:35 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #22 from Jonathan Druart --- Comment on attachment 47407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47407 Bug 15343 - Allow user to set password on opac-memberentry.pl Review of attachment 47407: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15343&attachment=47407) ----------------------------------------------------------------- There is a third case to check: if the password contain leading or trailing whitespaces, see bug 14509. ::: C4/Members.pm @@ +2482,5 @@ > $borrower{'cardnumber'} = fixup_cardnumber(); > > my $borrowernumber = AddMember(%borrower); > > + return ( $borrowernumber, $borrower{'password'} ); Why do you return the password? You should compare the hashed password (Koha::AuthUtils::hash_password) in the test. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ +60,5 @@ > [% IF field == "email" %]
  • Contact information: primary email address
    • [% END %] > [% IF field == "emailpro" %]
  • Contact information: secondary email address
    • [% END %] > [% IF field == "B_email" %]
  • Alternate address information: email address
    • [% END %] > + [% IF field == "password_match" %]
  • Passwords do not match! password
    • [% END %] > + [% IF field == "password_invalid" %]
  • Password does not meet minium requirements! password
    • [% END %] typo minimum. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 12:52:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 11:52:42 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:14:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 12:14:05 +0000 Subject: [Koha-bugs] [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- With a patron without circulate_remaining_permissions, but another subperm of circulate, I get 2 inputs on the mainpage: Enter patron card number or partial name: [+] Enter patron card number or partial name: And 2 tabs Search patrons Search the catalog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:17:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 12:17:45 +0000 Subject: [Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #9 from Jonathan Druart --- ping Nick? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:39:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 12:39:51 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:39:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 12:39:54 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 --- Comment #6 from Fr?d?ric Demians --- Created attachment 47501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47501&action=edit Bug 14523 - Google jackets being blocked when OPAC using HTTPS Get the protocol of the current URL. This results is the correct prefix being used to serve the google jackets regarless of koha apache server setup. Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:40:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 12:40:33 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47500|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:45:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 12:45:26 +0000 Subject: [Koha-bugs] [Bug 15713] New: Restart zebra when rotating logfiles Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15713 Bug ID: 15713 Summary: Restart zebra when rotating logfiles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:07:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 13:07:50 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:08:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 13:08:40 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:08:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 13:08:43 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47488|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 47502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47502&action=edit Bug 15645 - In transit holds do not show as in transit on request.pl A hold in transit will simply appear as an unfilled hold! Test Plan: 1) Place a hold for pickup at a different location 2) Capture that hold for a patron 3) Note you do not see the in transit status on request.pl 4) Apply this patch 5) Refresh the page 6) The hold should now show as in transit! Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:10:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 13:10:11 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- The code in this area (found/wait/transit) is really confusing. When you read it, this patch does not make sense, but the variable names are not correct in the pl/template and finally it fixes the issue! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:13:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 13:13:24 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 --- Comment #5 from Jonathan Druart --- Created attachment 47503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47503&action=edit Bug 15645: Remove the confusing wait var and use found instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:14:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 13:14:01 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #6 from Jonathan Druart --- Kyle, could you have a look at my follow-up please? It seems that it fixes the confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:25:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 13:25:15 +0000 Subject: [Koha-bugs] [Bug 15713] Restart zebra when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15713 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:25:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 13:25:18 +0000 Subject: [Koha-bugs] [Bug 15713] Restart zebra when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15713 --- Comment #1 from Marcel de Rooy --- Created attachment 47504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47504&action=edit Bug 15713: Restart zebra when rotating logfiles Somehow, it may happen that Zebra keeps writing to the old rotated logfile with extension .log.1. I must add that although I saw that happen (a new log was created and was empty, while Zebra kept writing to log.1 for weeks), I cannot reproduce it every time. By stopping the zebra server in prerotate and starting it again in postrotate, this should not happen at all. In practice, this implies that your Zebra server is restarted once a week. Note: The existing sharedscripts directive makes sure that these actions are not executed for all individual logfiles but once for all matching logfiles (even when running multiple instances). Test plan: [1] Apply the change in koha-common.logrotate to the file /etc/logrotate.d/koha-common. [2] Run logrotate -f /etc/logrotate.conf (forcing a logrotate). [3] Check in zebra-error.log that your zebra server was stopped ('killed by signal 15'). [4] Verify that your Zebra server runs (read: has been restarted). (Do a search..) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:25:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 13:25:34 +0000 Subject: [Koha-bugs] [Bug 15713] Restart zebra when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15713 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:36:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 13:36:27 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:36:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 13:36:30 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46396|0 |1 is obsolete| | --- Comment #49 from Owen Leonard --- Created attachment 47505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47505&action=edit [SIGNED-OFF] Bug 15206 - Show patron's age under date of birth in memberentry.pl Test plan: Create or edit a patron (members/memberentry.pl), enter a date of birth (for a new patron), patron'a age should be shown under Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:36:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 13:36:40 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47301|0 |1 is obsolete| | --- Comment #50 from Owen Leonard --- Created attachment 47506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47506&action=edit [SIGNED-OFF] Bug 15206 - Make CalculateAge a reusable function Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:08:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 14:08:13 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #23 from Owen Leonard --- Kyle I would like to look at this again. Can you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:25:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 14:25:14 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:34:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 14:34:58 +0000 Subject: [Koha-bugs] [Bug 15714] New: Remove zebra.log from debian scripts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 Bug ID: 15714 Summary: Remove zebra.log from debian scripts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Scripts koha-start-zebra (as well as koha-stop-zebra) refer to zebra.log. But they also use zebra-output.log and zebra-error.log. The scripts do not correctly use the stdout, stderr and output options from daemon. Either you use output (for both) or you use stdout and stderr. Patch forthcoming. Will also make it possible to add log level "log" to zebrasrv -v to include requests in the zebra-output.log (optionally via koha-conf). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:35:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 14:35:12 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:51:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 14:51:25 +0000 Subject: [Koha-bugs] [Bug 13302] Use CSS3 ellipsis for email address in staff client patron sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13302 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:51:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 14:51:27 +0000 Subject: [Koha-bugs] [Bug 13302] Use CSS3 ellipsis for email address in staff client patron sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13302 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33693|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 47507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47507&action=edit Bug 13302 [Revised] Use CSS3 ellipsis for email address in staff client patron sidebar This patch replaces the email address text overflow solution implemented by Bug 3256 with a CSS3 technique: text-overflow: ellipsis https://developer.mozilla.org/en-US/docs/Web/CSS/text-overflow To test, apply the patch and clear your browser cache. Edit the primary email address of a patron so that it is very long. View that patron in the staff client (on the checkout or details page, for instance) and confirm that the email address is truncated with "..." Confirm that the link and the title attribute of the link contain the correct, full email address. Revision uses a percentage instead of a fixed width for email display in the sidebar to accommodate varying sidebar widths. Also added: Handling of all email addresses displayed on the patron detail page. Although email addresses in the body of that page were not in the scope of the original patch, it's a good improvement to include those as well. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:52:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 14:52:25 +0000 Subject: [Koha-bugs] [Bug 13302] Use CSS3 ellipsis for email address in staff client patron sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13302 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:52:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 14:52:25 +0000 Subject: [Koha-bugs] [Bug 13212] Use CSS3 ellipsis instead of FacetLabelTruncationLength In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13212 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13302 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:04:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:04:22 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- On bug 14571, we always use https for the amazon images, it would make sense to do the same here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:04:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:04:37 +0000 Subject: [Koha-bugs] [Bug 13212] Use CSS3 ellipsis instead of FacetLabelTruncationLength In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13212 --- Comment #3 from Owen Leonard --- This works, but I don't think it's the right place to use this CSS3 feature. I think it's important for libraries to be able to choose to display the full facet using FacetLabelTruncationLength if they want to, without resorting to custom CSS rules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:04:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:04:38 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:06:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:06:00 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14523 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:06:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:06:00 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14571 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:12:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:12:51 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #8 from Owen Leonard --- I suspect Bug 13618 has caused a conflict with these patches now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:17:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:17:43 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 --- Comment #8 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #7) > On bug 14571, we always use https for the amazon images, it would make sense > to do the same here. You're correct. If Google Books is requested exclusively in https, it works. If the OPAC is HTTP, there isn't 'mixed content' error. And if the OPAC is HTTPS, there isn't anymore 'mixed content' error since OPAC and Google Books are requested with https. Barry: would you mind modifying your patch to request Google Books in https, whatever the OPAC protocol? I can do it if you prefer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:17:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:17:51 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:32:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:32:45 +0000 Subject: [Koha-bugs] [Bug 15715] New: Import authorities from z39.50 hangs on import of authority record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15715 Bug ID: 15715 Summary: Import authorities from z39.50 hangs on import of authority record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl On master I cannot import an authority record via z39.50 To recreate" 1 - Go to Administration->Authorities 2 - Click 'New from Z39.50" 3 - Search and find a record 4 - Click 'Import' 5 - Pop-up closes but import doesn't proceed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:34:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:34:22 +0000 Subject: [Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #7 from Sophie MEYNIEUX --- It seems to have the same pb on Hold(s) tab -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:36:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:36:13 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 --- Comment #9 from Barry Cannon --- My very first patch on this thread, 40988, did exactly that! Can that be re-used? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:46:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:46:48 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:46:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:46:51 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46651|0 |1 is obsolete| | --- Comment #31 from Nick Clemens --- Created attachment 47508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47508&action=edit Bug 15358: Attempt to fix authorities merge This is a quick fix, and I'm quite sure there are other bugs hiding... but I managed to display both authority in tabs and merge them. The result preview requires at least one click on checkboxes to show up, I haven't looked at this issue yet. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:46:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:46:58 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46652|0 |1 is obsolete| | --- Comment #32 from Nick Clemens --- Created attachment 47509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47509&action=edit Bug 15358: Build result preview after page load Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:47:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:47:03 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46653|0 |1 is obsolete| | --- Comment #33 from Nick Clemens --- Created attachment 47510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47510&action=edit Bug 15358: Authorities merge - submit only result record This patch removes parts of form that should not be submitted just before submit. The same is done on biblio merge. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:47:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:47:59 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #34 from Nick Clemens --- Retesting I couldn't recreate that error, seems to have been in my records, but I reloaded since then and all tests I tried worked fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:52:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:52:30 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:52:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:52:33 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47501|0 |1 is obsolete| | --- Comment #10 from Fr?d?ric Demians --- Created attachment 47511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47511&action=edit Bug 14523 - Google jackets being blocked when OPAC using HTTPS This patch changes the Google jackets URL to use HTTPS instead of HTTP. Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:53:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:53:07 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 --- Comment #11 from Fr?d?ric Demians --- (In reply to Barry Cannon from comment #9) > My very first patch on this thread, 40988, did exactly that! Can that be > re-used? Yes! Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:59:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 15:59:17 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #3 from H?ctor Eduardo Castro Avalos --- Maybe a better test plan for example: To reproduce the issue: -Choose a bib record and copy the date in 005 field -search under Date/time-last-modified:20160201094709.0 -No results found To test: 1. apply patch 2. reindex 3. search for dtlm:DATE and date-time-last-modified:DATE 4. confirm that you get results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:00:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:00:37 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47398|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 47512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47512&action=edit [SIGNED-OFF]Bug 15694: Add aliases for date/time last modified This patch will add indexes for Date/time-last-modified. To test: 1. apply patch 2. reindex 3. search for dtlm:DATE and date-time-last-modified:DATE 4. confirm that you get results Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:01:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:01:21 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:03:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:03:09 +0000 Subject: [Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 --- Comment #8 from Fr?d?ric Demians --- (In reply to Sophie MEYNIEUX from comment #7) > It seems to have the same pb on Hold(s) tab Which version? Is it solved on 3.20.8? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:06:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:06:02 +0000 Subject: [Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:06:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:06:04 +0000 Subject: [Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 --- Comment #10 from Nick Clemens --- Created attachment 47513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47513&action=edit Bug 15699 [QA followup] - Only display firstname if present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:07:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:07:29 +0000 Subject: [Koha-bugs] [Bug 15716] New: Unnecessary parenthesis in check-in transfer message Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15716 Bug ID: 15716 Summary: Unnecessary parenthesis in check-in transfer message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Bug 15355 introduced a typo in the message which is displayed when a check-in triggers a transfer: " Print slip )" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:07:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:07:29 +0000 Subject: [Koha-bugs] [Bug 15355] Translatability: Fix issues on check in page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15355 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15716 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:09:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:09:38 +0000 Subject: [Koha-bugs] [Bug 15716] Unnecessary parenthesis in check-in transfer message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15716 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:09:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:09:40 +0000 Subject: [Koha-bugs] [Bug 15716] Unnecessary parenthesis in check-in transfer message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15716 --- Comment #1 from Owen Leonard --- Created attachment 47514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47514&action=edit Bug 15716 - Unnecessary parenthesis in check-in transfer message This patch removes a stray ")" from the check-in template. To test, check in an item which belongs to another library. The "Print slip" link should not have a ")" after it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:21:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:21:13 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:21:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:21:16 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47096|0 |1 is obsolete| | Attachment #47097|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 47515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47515&action=edit Bug 15632: Koha::Patron::Messages - Remove GetMessages This subroutine just retrieved the messages given some parameters. Some job should not have been done in this subroutine. It was called only 3 times, in circ/circulation.pl and opac-user.pl. Basically it was used to retrieved the message to displaye for a given patron ($borrowernumber) at the OPAC (B) or Staff (L). For the 3 calls, the 2 parameters $borrowernumber and $type (message_type) were passed, the "%" trick at the beginning of the subroutine was useless. Moreover, the date formatting should be done on the TT side, not in subroutine. The can_delete flag was set if the branchcode given in parameter was the same as the one of the message. This has been delegated to the template. Indeed the can_delete was not valid, since it must depend on the AllowAllMessageDeletion pref. The test is now: IF message.branchcode == branch OR Koha.Preference('AllowAllMessageDeletion'') There is not specific test plan for this patch, the changes have already been tested in previous patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:21:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:21:34 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #10 from Jonathan Druart --- Created attachment 47516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47516&action=edit Bug 15632: Koha::Patron::Messages - Remove tests The messages related tests in t/db_dependent/Members.t are not deprecated and can be removed. Test plan: git grep AddMessage git grep DeleteMessage git grep GetMessagesCount git grep GetMessages should not return any result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:26:55 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #35 from Jonathan Druart --- (In reply to Nick Clemens from comment #34) > Retesting I couldn't recreate that error, seems to have been in my records, > but I reloaded since then and all tests I tried worked fine. You error was about control field (<10), did you try that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:31:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:31:40 +0000 Subject: [Koha-bugs] [Bug 5515] Leading 'and' in search never returns a result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5515 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:32:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:32:35 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:32:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:32:39 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47410|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 47517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47517&action=edit Bug 15697 - Unnecessary comma between title and subtitle on opac-detail.pl To test: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping (or ensure it exists) Field name: subtitle MARC field: 245 MARC subfield: b 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" 5 - Apply patch 6 - View the record again and note the comma is no longer present. Note: this patch removes the comma only for MARC21 where subtitle is not repeatable. UNIMARC seems to be repeatable and does not include punctuation so I believe this may be needed there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:35:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:35:36 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #12 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:39:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:39:43 +0000 Subject: [Koha-bugs] [Bug 15693] Unnecessary punctuation mark when check-in an item in a library other than the home branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15693 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #4 from H?ctor Eduardo Castro Avalos --- *** Bug 15716 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:39:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:39:43 +0000 Subject: [Koha-bugs] [Bug 15716] Unnecessary parenthesis in check-in transfer message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15716 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #2 from H?ctor Eduardo Castro Avalos --- Hi Owen Exist another patch with status PASS QA *** This bug has been marked as a duplicate of bug 15693 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:41:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:41:28 +0000 Subject: [Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #7 from Julian Maurice --- This bug does not concern stable versions, changing status to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:45:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:45:15 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #8 from Julian Maurice --- This bug does not concern stable versions, changing status to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:45:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:45:15 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Bug 15358 depends on bug 15578, which changed state. Bug 15578 Summary: Authority tests skip and hide a bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:46:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:46:36 +0000 Subject: [Koha-bugs] [Bug 12442] Query... variables should be defined within loop in Search.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12442 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:46:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:46:42 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #17 from Julian Maurice --- This bug does not concern stable versions, changing status to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:46:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:46:42 +0000 Subject: [Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Bug 15581 depends on bug 15568, which changed state. Bug 15568 Summary: Circ rules are not displayed anymore https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:47:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:47:16 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46997|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 47518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47518&action=edit [SIGNED-OFF] Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (1) For consistency, the branchcodes method of Koha::LibraryCategory should be named libraries. At the moment, there is only one occurrence, in admin/branches.pl Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:47:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:47:22 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46998|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 47519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47519&action=edit [SIGNED-OFF] Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (2) C4::Branch::GetBranchesInCategory can be replaced with Koha::LibraryCategory->libraries Test plan: 1/ Define some 1+ group of libraries with 1+ libraries each 2/ Go on the advanced search (OPAC and Staff) and select a group of libraries 3/ The result should be consistent and only include record from these libraries Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:47:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:47:30 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46999|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 47520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47520&action=edit [SIGNED-OFF] Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (3) C4::Branch::GetBranchesInCategory is not used anymore and can be removed. Test plan: git grep GetBranchesInCategory should not return any result. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:47:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:47:39 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47000|0 |1 is obsolete| | --- Comment #10 from Owen Leonard --- Created attachment 47521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47521&action=edit [SIGNED-OFF] Bug 15629: Koha::Libraries - Remove GetBranchDetail C4::Branch::GetBranchDetail retrieved library infos, it could be easily replaced with Koha::Libraries->find When this change needs other big changes, the unblessed method is called, to manipulate a hashref (as before) instead of a Koha::Library object (for instance when $library is sent to GetPreparedLetter). Test plan: 1/ Print a basket group, the library names should be correctly displayed. 2/ Enable emailLibrarianWhenHoldIsPlaced and place a hold, a HOLDPLACED notice will be generated (focus on the library name) 3/ Edit a patron and change his/her library 4/ Generate the advanced notices (misc/cronjobs/advance_notices.pl) and have a look at the generated notices 5/ Same of overdues notices 6/ Set IndependentBranches and use a non superlibrarian user to place a hold. The "pickup at" should be correctly filled. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:47:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:47:45 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47001|0 |1 is obsolete| | --- Comment #11 from Owen Leonard --- Created attachment 47522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47522&action=edit [SIGNED-OFF] Bug 15629: Koha::Libraries - Remove ModBranch This subroutine was only used in tests to add/update a library. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:48:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:48:43 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:48:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:48:45 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47522|0 |1 is obsolete| | --- Comment #12 from Owen Leonard --- Created attachment 47523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47523&action=edit [SIGNED-OFF] Bug 15629: Koha::Libraries - Remove GetBranchInfo C4::Branch::GetBranchInfo was only used once in opac/opac-suggestions.pl The occurrence can easily be replaced by a call to Koha::Libraries->find Test plan: 1/ Create a suggestion for library A 2/ Enable OPACViewOthersSuggestions 3/ Use a patron from library B to see the suggestions 4/ The "Suggested for" value should be correctly filled with the library A name. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:49:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:49:01 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47002|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:51:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:51:05 +0000 Subject: [Koha-bugs] [Bug 15601] TestBuilder tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15601 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- This bug does not concern stable versions, changing status to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:53:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:53:51 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #36 from Nick Clemens --- I merged records with control fields and was able to mix and match from separate records with no issue. I tried creating subfields in control fields in MarcEdit but had no success -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:56:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:56:13 +0000 Subject: [Koha-bugs] [Bug 11569] Typo in userpermissions.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11569 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:57:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:57:20 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #9 from Julian Maurice --- This bug does not concern stable versions, changing status to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:58:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:58:43 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Owen Leonard --- This is not working for me. When I try to add a message on the circulation page it does not get saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:59:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 16:59:17 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 18:00:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 17:00:05 +0000 Subject: [Koha-bugs] [Bug 15616] Spelling mistake in opac-account.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15616 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Julian Maurice --- This bug does not concern stable versions, changing status to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 18:13:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 17:13:44 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 18:13:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 17:13:47 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47517|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 47524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47524&action=edit [SIGNED-OFF]Bug 15697: Unnecessary comma between title and subtitle on opac-detail.pl To test: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping (or ensure it exists) Field name: subtitle MARC field: 245 MARC subfield: b 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" 5 - Apply patch 6 - View the record again and note the comma is no longer present. Note: this patch removes the comma only for MARC21 where subtitle is not repeatable. UNIMARC seems to be repeatable and does not include punctuation so I believe this may be needed there. Signed-off-by: Hector Castro Works as described. Comma removed from title of the window and breadcrumb section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 18:20:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 17:20:42 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 18:20:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 17:20:45 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #12 from Jonathan Druart --- Created attachment 47525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47525&action=edit Bug 15632: Koha::Patron::Messages - (follow-up) Remove AddMessage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 18:22:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 17:22:05 +0000 Subject: [Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47274|0 |1 is obsolete| | --- Comment #4 from Julian Maurice --- Created attachment 47526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47526&action=edit Bug 15564 - Display "print slip" option when returning an item which is in a rotating collection Rebased on master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 18:22:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 17:22:05 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #13 from Jonathan Druart --- (In reply to Owen Leonard from comment #11) > This is not working for me. When I try to add a message on the circulation > page it does not get saved. Hum, indeed. Sorry about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 18:23:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 17:23:40 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #2 from Alex Arnaud --- Created attachment 47527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47527&action=edit Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 18:26:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 17:26:03 +0000 Subject: [Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 --- Comment #5 from Julian Maurice --- Comment on attachment 47526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47526 Bug 15564 - Display "print slip" option when returning an item which is in a rotating collection Review of attachment 47526: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15564&attachment=47526) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ +137,4 @@ >

    Please transfer item to: [% collectionBranch %]

    >

    [% itembarcode %]: [% title %]

    >

    This item is part of a rotating collection.

    > +

    Print slip

    Here 'returnbranch' is used whereas 'collectionBranch' is used 3 lines above. Is it intended ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 19:30:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 18:30:27 +0000 Subject: [Koha-bugs] [Bug 15182] make test fails immediately on 3.22.00-beta due to missing Crypt::GCrypt which is optional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15182 Federico Leva changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |federicoleva at tiscali.it --- Comment #26 from Federico Leva --- The fix is good, with koha-3.22.01 in Fedora 23 I didn't install the non-required dependencies mentioned above and I confirm everything works. However the logs are a bit spammy, which is a bit confusing if loading NorwegianPatronDB isn't required: Members.pm: Unable to load Koha::NorwegianPatronDB at /usr/share/perl5/vendor_perl/C4/Members.pm line 46.: /usr/share/koha/intranet/cgi-bin/tools/manage-marc-import.pl, referer: http://46.101.193.160/cgi-bin/koha/tools/stage-marc-import.pl There is a perl-Crypt-GCrypt-1.26-1 package in fedora 24 repos, 2 others work with cpanm and another is installed by default. HTH https://github.com/nemobis/beic-koha/commit/cae9809897377f36218d34c2595e7637e8a3bfd6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 20:25:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 19:25:46 +0000 Subject: [Koha-bugs] [Bug 15717] New: Installer: Step 3 has
    showing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717 Bug ID: 15717 Summary: Installer: Step 3 has
    showing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Sample patron types and categories: Type: Categories: Adult patron - default patron type PT - Patron ST - Student BH - Homebound Child - patron with a guarantor K - Kid J - Juvenile YA - Young Adult Organization - patron is an institution, not a person ILL - Inter-library Loan SC - School L - Library Professional - a member of an organization (organization is guarantor) T - Teacher S - Staff B - Board Imagine that all bunched up with
    's instead of actual line feeds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 20:30:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 19:30:02 +0000 Subject: [Koha-bugs] [Bug 15717] Installer: Step 3 has
    showing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 20:30:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 19:30:05 +0000 Subject: [Koha-bugs] [Bug 15717] Installer: Step 3 has
    showing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717 --- Comment #1 from M. Tompsett --- Created attachment 47528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47528&action=edit Bug 15717: Installer: Step 3 has
    showing The step to install optional/mandatory things is broken with many
    's instead of line breaks. TEST PLAN --------- 1) Back up database 2) Drop database 3) Create empty database 4) Run web installer -- Notice that step 3 has ugly
    's at the last part of step 3. 5) Apply patch 6) Repeat steps 2-4 -- Notice the
    's are now nice line breaks. NOTE: No promises of perfect positioning! 7) Run koha qa test tools. 8) Restore database -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 20:30:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 19:30:24 +0000 Subject: [Koha-bugs] [Bug 15717] Installer: Step 3 has
    showing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 20:33:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 19:33:44 +0000 Subject: [Koha-bugs] [Bug 15717] Installer: Step 3 has
    showing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717 --- Comment #2 from M. Tompsett --- NOTE: I suspect it has to do with Template::Stash::AutoEscaping from bug 13618. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 20:34:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 19:34:20 +0000 Subject: [Koha-bugs] [Bug 15717] Installer: Step 3 has
    showing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717 --- Comment #3 from M. Tompsett --- NOTE: I had to cpan2deb Template::Stash::AutoEscaping to get my master to work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 20:57:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 19:57:10 +0000 Subject: [Koha-bugs] [Bug 15717] Installer: Step 3 has
    showing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 20:57:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 19:57:12 +0000 Subject: [Koha-bugs] [Bug 15717] Installer: Step 3 has
    showing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47528|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 47529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47529&action=edit Bug 15717: Installer: Step 3 has
    showing The step to install optional/mandatory things is broken with many
    's instead of line breaks. TEST PLAN --------- 1) Back up database 2) Drop database 3) Create empty database 4) Run web installer -- Notice that step 3 has ugly
    's at the last part of step 3. 5) Apply patch 6) Repeat steps 2-4 -- Notice the
    's are now nice line breaks. NOTE: No promises of perfect positioning! 7) Run koha qa test tools. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:32:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 20:32:24 +0000 Subject: [Koha-bugs] [Bug 15718] New: Need more information for items that don't successfully batch checkout Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15718 Bug ID: 15718 Summary: Need more information for items that don't successfully batch checkout Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 47530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47530&action=edit batch checkout failed list I'm testing the new batch checkout feature in 3.22, and am trying to throw every possible non-standard status at it to see if it hiccups. So far, so good. If an item won't check out because it's of a non-loanable item type or not for loan status or over a circ rule threshold, the batch checkout screen displays somewhat helpful text for why something won't batch check out. However, after you've pressed the confirm Checkout button, if items cannot be be checked out due to different reasons, the list of non-checked out items displays on the screen, but you aren't told anywhere on the screen that these are the items that DIDN'T check out in the batch check out process. The information column that had populated on the previous screen is now blank. (see attached screenshot) To recreate: 1. Enable batch checkout and applicable patron categories 2. Using a patron with a category set in step 1, attempt to batch checkout several materials, including two materials that wouldn't normally check out anyway (example: not for loan status or non-loanable item type, or over checkout limit numbers). 3. Once the items are submitted for batch checkout, note that (at least) two items that can't be checked out have information listed in the information column. 4. Confirm the batch checkouts. 5. Note that the screen that appears does not indicate the item list is for those that failed the batch checkout process. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 22:07:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 21:07:27 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #23 from Nick Clemens --- (In reply to Jonathan Druart from comment #22) > > + return ( $borrowernumber, $borrower{'password'} ); > > Why do you return the password? This was already done before my change. The password is returned in the case of an auto generated password so that the patron may know their password. I suppose it does not need to be captured and displayed if a password is submitted, but in the other case I think it must remain Will work on that and the others ASAP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 22:34:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 21:34:47 +0000 Subject: [Koha-bugs] [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 22:34:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 21:34:51 +0000 Subject: [Koha-bugs] [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47486|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 47531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47531&action=edit Bug 15706: Changing to circulate_remaining_permissions I have only changed this in the includes for the tabs at the top. Dependent on Bug 12051 as that patch adds extra tabs to the top which would need to be changed later To test: 1) Apply Bug 12051 first, then this patch 2) Ensure that Check Out/Check In/Renew tabs still work as they should 3) Check patch for errors or pages I've missed Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 23:06:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 22:06:27 +0000 Subject: [Koha-bugs] [Bug 15712] Could not find opac-search.xml in /opt/koha/opac/cgi-bin/opac/ at /opt/koha/lib/C4/Search.pm line 611 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15712 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Katrin Fischer --- Hi Mohammed, 3.04 is very old by now and no longer maintained. So any bugs found won't be fixed as there are no new releases for that version. I think a better place to get help for your problem is the mailing list, but you should consider updating to a more current version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 23:27:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 22:27:06 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 23:37:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 22:37:05 +0000 Subject: [Koha-bugs] [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 --- Comment #6 from Aleisha Amohia --- Created attachment 47532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47532&action=edit Bug 15706: Forgot to attach the change I made! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 23:43:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 22:43:40 +0000 Subject: [Koha-bugs] [Bug 15717] Installer: Step 3 has
    showing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 00:37:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 23:37:26 +0000 Subject: [Koha-bugs] [Bug 15719] New: Silence warning in C4/Language.pm during web install Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Bug ID: 15719 Summary: Silence warning in C4/Language.pm during web install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This problem was discovered the hard way: Drop DB Create DB Webinstaller run until the screen says: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. The error log file will contain an error about splitting an uninitialized value. Apply the patch Drop DB Create DB Webinstaller run until the screen says: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. The error log file will not contain that error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 00:37:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 23:37:45 +0000 Subject: [Koha-bugs] [Bug 15719] Silence warning in C4/Language.pm during web install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 00:41:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 23:41:30 +0000 Subject: [Koha-bugs] [Bug 15719] Silence warning in C4/Language.pm during web install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 --- Comment #1 from M. Tompsett --- Created attachment 47533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47533&action=edit Bug 15719: Silence warning in C4/Language.pm during web install Test empty database case. TEST PLAN --------- 1) prove -v t/Languages.t -- success (because test case is missing) 2) Apply this patch 3) prove -v t/Languages.t -- success, but warning printed. 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 00:41:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 23:41:37 +0000 Subject: [Koha-bugs] [Bug 15719] Silence warning in C4/Language.pm during web install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 --- Comment #2 from M. Tompsett --- Created attachment 47534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47534&action=edit Bug 15719: Silence warning in C4/Language.pm during web install This problem was discovered the hard way: - Drop DB - Create DB - Webinstaller run until the screen is: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. -- The error log file will end with an error about splitting an uninitialized value. TEST PLAN --------- 0) First patch already applied 1) prove -v t/Languages.t -- success, but warn prints 2) Apply this patch 3) prove -v t/Languages.t -- success without warning messages 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 00:42:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2016 23:42:10 +0000 Subject: [Koha-bugs] [Bug 15719] Silence warning in C4/Language.pm during web install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 01:22:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 00:22:48 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 01:27:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 00:27:31 +0000 Subject: [Koha-bugs] [Bug 15719] Silence warning in C4/Language.pm during web install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 01:28:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 00:28:05 +0000 Subject: [Koha-bugs] [Bug 15717] Installer: Step 3 has
    showing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 01:39:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 00:39:42 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #12 from Bob Birchall --- (In reply to Kyle M Hall from comment #0) > We should enable TT syntax for slips and notices. This could work side by > side with the existing syntax parser for a release or two before we > officially remove our bespoke parsing code for slips and notices, giving > libraries ample time to switch over. I endorse the comments by Jonathan and Katrin that libraries must be able to edit their own notices. They need a simple interface in which to do that and good documentation. I'm also concerned about the potential cost of this change, for a support company and also for any large consortium that has notices defined separately by branch. If every notice in use at every client needs at best examination and at worst to be re-written, that's a bit daunting. Is that the implication? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 03:29:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 02:29:36 +0000 Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 03:29:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 02:29:42 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 04:46:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 03:46:30 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Sounds like a great idea. I noticed a little while ago that the Zebra log settings weren't optimal on Debian, so I'd be happy to test something. Especially happy about the added log level, as that will make it easier to troubleshoot Zebra on Debian... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 05:03:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 04:03:23 +0000 Subject: [Koha-bugs] [Bug 15713] Restart zebra when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15713 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- Looks good at a glance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 05:24:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 04:24:44 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #51 from M. Tompsett --- Comment on attachment 39803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39803 Bug 12357 - Enhancements to RIS and BibTeX exporting Review of attachment 39803: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12357&attachment=39803) ----------------------------------------------------------------- ::: C4/Ris.pm @@ +1016,4 @@ > ## return unaltered if already utf-8 > return @_; > } > + elsif (my $uniout eq "t") { This runs with warns, but where is uniout defined?! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 08:00:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 07:00:43 +0000 Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15406 CC| |katrin.fischer at bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406 [Bug 15406] Very SLOW OAI server performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 08:00:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 07:00:43 +0000 Subject: [Koha-bugs] [Bug 15406] Very SLOW OAI server performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15342 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 [Bug 15342] Performance 3.22 - Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 08:10:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 07:10:32 +0000 Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|critical |normal --- Comment #5 from Katrin Fischer --- While this is needed for libraries with original script that use 880 for cataloguing, I think it's not a critical bug. Koha hasn't supported this so far, although it would be nice if it would. With DOM and the recently added options for conditional indexing it should be finally possible to make this work nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 08:13:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 07:13:23 +0000 Subject: [Koha-bugs] [Bug 15406] Very SLOW OAI server performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 08:44:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 07:44:20 +0000 Subject: [Koha-bugs] [Bug 15406] Very SLOW OAI server performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15106 Status|NEW |In Discussion --- Comment #1 from Fr?d?ric Demians --- Bug 15106 contains the solution. Especially, an index must be added to biblioitems/deletebiblioitems timestamp field: KEY `timestamp_bibno` (`timestamp`, `biblionumber`) You can confirm that this solution works for you by altering your DB schema: ALTER TABLE biblioitems ADD KEY `timestamp_bibno` (`timestamp`, `biblionumber`); ALTER TABLE deletedbiblioitems ADD KEY `timestamp_bibno` (`timestamp`, `biblionumber`) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15106 [Bug 15106] Batch Patron Modification Performance Improvement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 08:44:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 07:44:20 +0000 Subject: [Koha-bugs] [Bug 15106] Batch Patron Modification Performance Improvement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15106 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15406 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406 [Bug 15406] Very SLOW OAI server performance -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:12:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 09:12:01 +0000 Subject: [Koha-bugs] [Bug 15713] Restart zebra when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15713 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47504|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 47535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47535&action=edit Bug 15713: Restart zebra when rotating logfiles Somehow, it may happen that Zebra keeps writing to the old rotated logfile with extension .log.1. I must add that although I saw that happen (a new log was created and was empty, while Zebra kept writing to log.1 for weeks), I cannot reproduce it every time. By stopping the zebra server in prerotate and starting it again in postrotate, this should not happen at all. In practice, this implies that your Zebra server is restarted once a week. Note: The existing sharedscripts directive makes sure that these actions are not executed for all individual logfiles but once for all matching logfiles (even when running multiple instances). Test plan: [1] Apply the change in koha-common.logrotate to the file /etc/logrotate.d/koha-common. [2] Run logrotate -f /etc/logrotate.conf (forcing a logrotate). [3] Check in zebra-error.log that your zebra server was stopped ('killed by signal 15'). [4] Verify that your Zebra server runs (read: has been restarted). (Do a search..) Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:12:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 09:12:17 +0000 Subject: [Koha-bugs] [Bug 15713] Restart zebra when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15713 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:17:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 09:17:53 +0000 Subject: [Koha-bugs] [Bug 15406] Very SLOW OAI server performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #1) > Bug 15106 contains the solution. Must be a typo, bug 15106 is about batch patron modification. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:22:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 09:22:23 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #52 from Jonathan Druart --- (In reply to M. Tompsett from comment #51) > Comment on attachment 39803 [details] [review] > Bug 12357 - Enhancements to RIS and BibTeX exporting > > Review of attachment 39803 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Ris.pm > @@ +1016,4 @@ > > ## return unaltered if already utf-8 > > return @_; > > } > > + elsif (my $uniout eq "t") { > > This runs with warns, but where is uniout defined?! On the same line... Please open a new bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:22:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 09:22:55 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #8 from Holger Mei?ner --- (In reply to bondiurbano from comment #2) > "No renewal before" is an optional setting so it could be absent in the > rule. Yes, but bug 14101 introduced a fallback. If the setting is absent (undef) then automatic renewal works just like "No renewal before" was zero. Do you get different results with undef and zero?? > Automatic_renewals.pl must be executed BEFORE the item date_due > expires. I think this cannot be done with a cron job running just once or a few times per day. Due date might be any time of the day, especially with hourly loans. > Otherwise it will be a due item and so OverduesBlockRenewing will > block it. Yes, but I suppose that is exactly what should happen, if the patron has both automatic and manual loans and some of the manual loans are overdue? But I see the problem! It should renew if ONLY automatic renewals are overdue! So maybe that's the solution. Check if all overdue loans are automatic, then override the block? I need to think about it some more, but does think this makes sense? :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:24:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 09:24:11 +0000 Subject: [Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 --- Comment #9 from Sophie MEYNIEUX --- In 3.20.7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:27:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 09:27:09 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #53 from Jonathan Druart --- Note that uniout is an argument of the original script http://sourceforge.net/p/refdb/code/HEAD/tree/refdb/trunk/scripts/marc2ris.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:43:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 09:43:37 +0000 Subject: [Koha-bugs] [Bug 15717] Installer: Step 3 has
    showing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:43:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 09:43:40 +0000 Subject: [Koha-bugs] [Bug 15717] Installer: Step 3 has
    showing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47529|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 47536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47536&action=edit Bug 15717: Installer: Step 3 has
    showing The step to install optional/mandatory things is broken with many
    's instead of line breaks. TEST PLAN --------- 1) Back up database 2) Drop database 3) Create empty database 4) Run web installer -- Notice that step 3 has ugly
    's at the last part of step 3. 5) Apply patch 6) Repeat steps 2-4 -- Notice the
    's are now nice line breaks. NOTE: No promises of perfect positioning! 7) Run koha qa test tools. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:43:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 09:43:54 +0000 Subject: [Koha-bugs] [Bug 15717] Installer: Step 3 has
    showing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:43:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 09:43:54 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15717 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717 [Bug 15717] Installer: Step 3 has
    showing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:50:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 09:50:35 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #24 from Jonathan Druart --- (In reply to Nick Clemens from comment #23) > (In reply to Jonathan Druart from comment #22) > > > + return ( $borrowernumber, $borrower{'password'} ); > > > > Why do you return the password? > > This was already done before my change. Ha yes, I misread the diff! Fix not needed :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:01:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:01:07 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:01:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:01:11 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47508|0 |1 is obsolete| | Attachment #47509|0 |1 is obsolete| | Attachment #47510|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart --- Created attachment 47537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47537&action=edit Bug 15358: Attempt to fix authorities merge This is a quick fix, and I'm quite sure there are other bugs hiding... but I managed to display both authority in tabs and merge them. The result preview requires at least one click on checkboxes to show up, I haven't looked at this issue yet. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:01:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:01:19 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #38 from Jonathan Druart --- Created attachment 47538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47538&action=edit Bug 15358: Build result preview after page load Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:01:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:01:23 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #39 from Jonathan Druart --- Created attachment 47539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47539&action=edit Bug 15358: Authorities merge - submit only result record This patch removes parts of form that should not be submitted just before submit. The same is done on biblio merge. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:07:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:07:00 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #40 from Jonathan Druart --- Julian, I have found a bug when testing: I a non-repeatable subfield is added when a repeatable field is added, there is no warning. If I click on the subfield, I get "The subfield is non-repeatable and already exists in the destination record. Therefore, you cannot add it." and it is not added to the destination record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:08:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:08:43 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:18:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:18:56 +0000 Subject: [Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 --- Comment #10 from Fr?d?ric Demians --- (In reply to Sophie MEYNIEUX from comment #9) > In 3.20.7 Try upgrading to 3.20.8, and confirm it solves the issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:20:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:20:26 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15406 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406 [Bug 15406] Very SLOW OAI server performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:20:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:20:26 +0000 Subject: [Koha-bugs] [Bug 15106] Batch Patron Modification Performance Improvement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15106 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15406 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406 [Bug 15406] Very SLOW OAI server performance -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:20:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:20:26 +0000 Subject: [Koha-bugs] [Bug 15406] Very SLOW OAI server performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15106 |15108 --- Comment #3 from Fr?d?ric Demians --- Yes, sorry. It's bug 15108. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15106 [Bug 15106] Batch Patron Modification Performance Improvement https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 [Bug 15108] OAI-PMH provider improvements -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:24:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:24:42 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:24:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:24:45 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47505|0 |1 is obsolete| | Attachment #47506|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart --- Created attachment 47540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47540&action=edit Bug 15206 - Show patron's age under date of birth in memberentry.pl Test plan: Create or edit a patron (members/memberentry.pl), enter a date of birth (for a new patron), patron'a age should be shown under Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:24:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:24:51 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #52 from Jonathan Druart --- Created attachment 47541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47541&action=edit Bug 15206 - Make CalculateAge a reusable function Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:24:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:24:55 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #53 from Jonathan Druart --- Created attachment 47542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47542&action=edit Bug 15206: Make strings translatable Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:25:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:25:48 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #54 from Jonathan Druart --- Maybe "display_age" is a better function name than "write_age", I let the RM cut. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:27:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:27:54 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47537|0 |1 is obsolete| | Attachment #47538|0 |1 is obsolete| | Attachment #47539|0 |1 is obsolete| | --- Comment #41 from Julian Maurice --- Created attachment 47543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47543&action=edit Bug 15358: Fix authorities merge Bug 8064 (Merge several biblio records) change some code used in both biblios and authorities merge tool without updating the authorities merge tool. This patch fixes that. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:28:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:28:18 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #42 from Julian Maurice --- All 3 patches squashed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:30:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:30:57 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #43 from Julian Maurice --- (In reply to Jonathan Druart from comment #40) > Julian, I have found a bug when testing: > I a non-repeatable subfield is added when a repeatable field is added, there > is no warning. > If I click on the subfield, I get "The subfield is non-repeatable and > already exists in the destination record. Therefore, you cannot add it." and > it is not added to the destination record. I think it's normal behaviour if I understand correctly. The subfield is not repeatable in its own field, but here you add a new field in the destination record, so it's valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:31:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:31:31 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:31:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:31:33 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47511|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 47544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47544&action=edit Bug 14523 - Google jackets being blocked when OPAC using HTTPS This patch changes the Google jackets URL to use HTTPS instead of HTTP. Test Plan: 1) Enable Google Jackets 2) Ensure the Koha OPAC instance is configued to use HTTPS 3) Confirm Google jackets display correctly. Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:31:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:31:45 +0000 Subject: [Koha-bugs] [Bug 15721] New: About page does not display Apache version Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 Bug ID: 15721 Summary: About page does not display Apache version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org The About page does not display the Apache version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:47:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:47:22 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Nicole, I think the files biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl need to be updated when a zebra index is added/deleted/modified. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:51:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:51:02 +0000 Subject: [Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:51:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:51:05 +0000 Subject: [Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47423|0 |1 is obsolete| | Attachment #47513|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 47545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47545&action=edit Bug 15699 - Course reserves instructors should be in form "Surname, Firstname" for sorting purposes This patch changes the order of the name fields and adds a span class around each in case of library wanting to customize further To test: 1 - Enable course reserves 2 - Add some courses with instrcutors 3 - Note they are of form "Firstname Surname" 4 - Apply patch 5 - Note the change 6 - Note span tags 7 - Note you can hide firstname by adding to intranet user js: $(".instr_firstname, instr_separator").hide(); Sing-off note: This patch displays the names as advertised on cgi-bin/koha/opac-course-reserves.pl Sorting the names would need some more actions but seems not to be intended by this patch. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:51:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:51:11 +0000 Subject: [Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 --- Comment #12 from Jonathan Druart --- Created attachment 47546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47546&action=edit Bug 15699 [QA followup] - Only display firstname if present Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:52:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:52:42 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 --- Comment #1 from Marc V?ron --- Created attachment 47547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47547&action=edit Bug 15721: About page does not display Apache version This patch changes about.pl to get version information from C4::Context where applicable and fixes missing display of the Apache version e.g. for Apache/2.2.22 To test: - Without patch, open about page in staff client - Remember contents of tab 'Server information' (e.g. make a screenshot) - Apply patch - Verify, that the About page displays the same information as before rsp. additionally displays Apache version if it was missing without patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:53:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 10:53:42 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 12:09:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 11:09:03 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 --- Comment #12 from Jonathan Druart --- Comment on attachment 47303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47303 BZ 7728 adding unit test Review of attachment 47303: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7728&attachment=47303) ----------------------------------------------------------------- 1/ Should not we update the histenddate if it has been set? 2/ Could we imagine fixing existing DB entries? ::: t/db_dependent/Serials/ReNewSubscription.t @@ +40,5 @@ > + > +#my $mContext = new Test::MockModule('C4::Context'); > +#$mContext->mock( 'userenv', sub { > +# return { branch => $library->{branchcode} }; > +#}); Useless commented lines, please remove. @@ +94,5 @@ > +# Actual testing starts here! > + > +# Renew the subscription and check that enddate has not been set > +ReNewSubscription($subscription->{subscriptionid},'',"2016-01-01",'','',12,''); > +my @history = Koha::Subscription::Histories->search( {subscriptionid => $subscription->{subscriptionid} } ); use Koha::Subscription::Histories->find( $subscription->{subscriptionid} ) when you already have the primary key. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 12:09:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 11:09:16 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 12:12:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 11:12:21 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- What about NORMARC? I guess it micmics MARC21. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 12:19:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 11:19:26 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart --- Olli, Could you provide a rebased patch? It seems that bug 15406 would need the second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 12:21:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 11:21:11 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #44 from Jonathan Druart --- (In reply to Julian Maurice from comment #43) > (In reply to Jonathan Druart from comment #40) > > Julian, I have found a bug when testing: > > I a non-repeatable subfield is added when a repeatable field is added, there > > is no warning. > > If I click on the subfield, I get "The subfield is non-repeatable and > > already exists in the destination record. Therefore, you cannot add it." and > > it is not added to the destination record. > > I think it's normal behaviour if I understand correctly. The subfield is not > repeatable in its own field, but here you add a new field in the destination > record, so it's valid. Indeed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 12:34:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 11:34:06 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #13 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #12) > Olli, Could you provide a rebased patch? > It seems that bug 15406 would need the second patch. And this part of the 1st patch: diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql index e9d836c..c2eec84 100644 --- a/installer/data/mysql/kohastructure.sql +++ b/installer/data/mysql/kohastructure.sql @@ -209,6 +209,7 @@ CREATE TABLE `biblioitems` ( -- information related to bibliographic records in KEY `isbn` (`isbn`(255)), KEY `issn` (`issn`(255)), KEY `publishercode` (`publishercode`), + KEY `timestamp_bibno` (`timestamp`, `biblionumber`), CONSTRAINT `biblioitems_ibfk_1` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8; @@ -866,7 +867,8 @@ CREATE TABLE `deletedbiblioitems` ( -- information about bibliographic records t KEY `bibnoidx` (`biblionumber`), KEY `itemtype_idx` (`itemtype`), KEY `isbn` (`isbn`(255)), - KEY `publishercode` (`publishercode`) + KEY `publishercode` (`publishercode`), + KEY `timestamp_bibno` (`timestamp`, `biblionumber`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 12:49:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 11:49:09 +0000 Subject: [Koha-bugs] [Bug 15713] Restart zebra when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15713 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 12:49:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 11:49:12 +0000 Subject: [Koha-bugs] [Bug 15713] Restart zebra when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15713 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47535|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 47548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47548&action=edit Bug 15713: Restart zebra when rotating logfiles Somehow, it may happen that Zebra keeps writing to the old rotated logfile with extension .log.1. I must add that although I saw that happen (a new log was created and was empty, while Zebra kept writing to log.1 for weeks), I cannot reproduce it every time. By stopping the zebra server in prerotate and starting it again in postrotate, this should not happen at all. In practice, this implies that your Zebra server is restarted once a week. Note: The existing sharedscripts directive makes sure that these actions are not executed for all individual logfiles but once for all matching logfiles (even when running multiple instances). Test plan: [1] Apply the change in koha-common.logrotate to the file /etc/logrotate.d/koha-common. [2] Run logrotate -f /etc/logrotate.conf (forcing a logrotate). [3] Check in zebra-error.log that your zebra server was stopped ('killed by signal 15'). [4] Verify that your Zebra server runs (read: has been restarted). (Do a search..) Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 13:08:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 12:08:57 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #9 from bondiurbano --- (In reply to Holger Mei?ner from comment #8) > (In reply to bondiurbano from comment #2) > > "No renewal before" is an optional setting so it could be absent in the > > rule. > > Yes, but bug 14101 introduced a fallback. If the setting is absent (undef) > then automatic renewal works just like "No renewal before" was zero. Do you > get different results with undef and zero?? > > > Automatic_renewals.pl must be executed BEFORE the item date_due > > expires. > I think this cannot be done with a cron job running just once or a few times > per day. Due date might be any time of the day, especially with hourly loans. > > > Otherwise it will be a due item and so OverduesBlockRenewing will > > block it. > Yes, but I suppose that is exactly what should happen, if the patron has > both automatic and manual loans and some of the manual loans are overdue? > > But I see the problem! It should renew if ONLY automatic renewals are > overdue! So maybe that's the solution. Check if all overdue loans are > automatic, then override the block? > > I need to think about it some more, but does think this makes sense? :) Hi Holger! I will check the fallback. Give a couple of days...I think that the fallback definition is right. But I will check. Meanwhile you can see my attached PDF. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 13:10:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 12:10:06 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 13:26:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 12:26:16 +0000 Subject: [Koha-bugs] [Bug 13302] Use CSS3 ellipsis for email address in staff client patron sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13302 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47507|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 47549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47549&action=edit Bug 13302 [Revised] Use CSS3 ellipsis for email address in staff client patron sidebar This patch replaces the email address text overflow solution implemented by Bug 3256 with a CSS3 technique: text-overflow: ellipsis https://developer.mozilla.org/en-US/docs/Web/CSS/text-overflow To test, apply the patch and clear your browser cache. Edit the primary email address of a patron so that it is very long. View that patron in the staff client (on the checkout or details page, for instance) and confirm that the email address is truncated with "..." Confirm that the link and the title attribute of the link contain the correct, full email address. Revision uses a percentage instead of a fixed width for email display in the sidebar to accommodate varying sidebar widths. Also added: Handling of all email addresses displayed on the patron detail page. Although email addresses in the body of that page were not in the scope of the original patch, it's a good improvement to include those as well. Signed-off-by: Owen Leonard Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 13:28:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 12:28:24 +0000 Subject: [Koha-bugs] [Bug 13302] Use CSS3 ellipsis for email address in staff client patron sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13302 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 13:31:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 12:31:36 +0000 Subject: [Koha-bugs] [Bug 14134] Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45420|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 47550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47550&action=edit Bug 14134 - Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set If ExpireReservesMaxPickUpDelay is enabled, the "holds over" tab becomes useless. It would be nice if the "holds over" tab would display *tomorrow's* "holds over" so the librarian can see what will be automatically canceled over night. Test Plan: 1) Apply this patch 2) Enable ExpireReservesMaxPickUpDelay 3) Note the "holds over" list now displays holds that will have been waiting more than the number of days defined in ReservesMaxPickUpDelay as of tomorrow. Signed-off-by: Jason Burds Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 13:31:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 12:31:53 +0000 Subject: [Koha-bugs] [Bug 14134] Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 13:34:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 12:34:16 +0000 Subject: [Koha-bugs] [Bug 15677] Misconfigured anonymous patron allows checkouts to multiple patrons. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #4 from Jonathan Druart --- Please confirm. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 14:12:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 13:12:42 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47527|0 |1 is obsolete| | --- Comment #3 from Alex Arnaud --- Created attachment 47551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47551&action=edit Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. >From staff interface, place several item-level holds for the same user on the same record at once: - check that you are warned if you exceed "Holds per record (count)" (circulation rules) for this record, - check also maxReserves system preference. >From opac, place several item-level and record level holds for the same user on the same record at once: - check that can't exceed "Holds per record (count)" for this record, - check also maxReserves system preference. Do the same in OPAC and staff by selecting several record (multi-hold). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 14:12:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 13:12:48 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #4 from Alex Arnaud --- Created attachment 47552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47552&action=edit Bz 15565 - CSS changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 14:17:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 13:17:32 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 14:23:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 13:23:06 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #57 from Owen Leonard --- Applying: Bug 14695 - Warn librarian if max_holds_per_record is reached fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 14695 - Warn librarian if max_holds_per_record is reached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 14:31:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 13:31:38 +0000 Subject: [Koha-bugs] [Bug 14770] Use $9 in GetMarcSeries to build search link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14770 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 14:39:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 13:39:21 +0000 Subject: [Koha-bugs] [Bug 8985] Add script to batch modify issuing rule hard due dates. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8985 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 14:56:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 13:56:07 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47522|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 15:02:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 14:02:06 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #13 from Jonathan Druart --- Created attachment 47553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47553&action=edit Bug 15629: Fix tests - Koha::Library does not have ->categories but ->get_categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 15:10:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 14:10:06 +0000 Subject: [Koha-bugs] [Bug 15722] New: Patron search cannot deal with special characters in fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15722 Bug ID: 15722 Summary: Patron search cannot deal with special characters in fields Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The patron search for a library was failing to return and was hung on "processing" what I found was that the patron's email address had a tab and a space at the end. When these were outputted in the json template members/tables/members_results.tt my browser ( chrome ) was unable to process the data giving a syntax error. I found this be recreating the query and calling svc/member/search directly from my browser. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 15:10:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 14:10:22 +0000 Subject: [Koha-bugs] [Bug 15722] Patron search cannot deal with hidden characters ( tabs ) in fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15722 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron search cannot deal |Patron search cannot deal |with special characters in |with hidden characters ( |fields |tabs ) in fields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 15:33:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 14:33:07 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 15:33:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 14:33:10 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 --- Comment #5 from Nick Clemens --- Created attachment 47554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47554&action=edit Bug 15697 - [QA Followup] Apply change to NORMARC This patch switches from UNLESS MARC21 to IF UNIMARC - this way changes apply to MARC21 and NORMARC and UNIMARC remains unaffected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 15:34:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 14:34:10 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 --- Comment #6 from Nick Clemens --- (In reply to Jonathan Druart from comment #4) > What about NORMARC? I guess it micmics MARC21. I wasn't certain so erred on leaving as is. Updated patch to use IF UNIMARC instead of UNLESS MARC21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 15:38:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 14:38:40 +0000 Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 15:38:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 14:38:42 +0000 Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36578|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 47555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47555&action=edit Bug 13795: Delete unused columns from statistics table The following 4 fields are never used in the statistics table: associatedborrower other proccode usercode This patch removes them. To test: * check the database and make sure columns are gone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 16:07:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 15:07:53 +0000 Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #7 from M. Tompsett --- I made it apply, but Bernardo Gonzalez Kriegel raises a valid problem in comment #5. $ git grep associatedborrower -- There is mention of it in installer/data/mysql/backfill_statistics.pl Is this script used at all? Obviously people aren't going to need it after upgrading from 2.x to 3.x versions. Perhaps safe to remove? Perhaps backfill_statistics.pl needs a rewrite? other is used in C4::Circulation::AddIssue related to SIP mode. In C4/Accounts.pm and C4/Circulation.pm (only places to use UpdateStats), the following fields are used: branch type amount other itemnumber itemtype borrowernumber ccode accountno schema says that usercode and associatedborrower is unused. Looking at C4/Stats.pm it becomes painfully clear (painful, because they shouldn't have renamed the field like that) that accountno is proccode. I wonder if people are expecting it to be longer than varchar(4). I would resubmit this modified with: 1) Just usercode and associatedborrower removed 2) an atomic update instead of a updatedatabase.pl (https://wiki.koha-community.org/wiki/Database_updates) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 16:18:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 15:18:52 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45846|0 |1 is obsolete| | --- Comment #14 from M. Tompsett --- Created attachment 47556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47556&action=edit Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 16:19:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 15:19:05 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45937|0 |1 is obsolete| | --- Comment #16 from M. Tompsett --- Created attachment 47558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47558&action=edit Bug 14272: Show single news item (OPAC) This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nees item heading should be clickable. * When clicked only that item should be shown. * When 'news_id' is present, only a single news item should show. * The breadcrumb should say 'News item' after 'Home'. Updates: * Renamed URL parameter and local variables with 'news_' prefix. * Fixed Search-And-Replace error; 'news_news_id' => 'news_id' * Added breadcrumb for viewing single news item. * Updated OPAC to use new GetNewsToDisplay parameters * Fixed template formatting and calling of GetNewsToDisplay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 16:19:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 15:19:00 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45935|0 |1 is obsolete| | --- Comment #15 from M. Tompsett --- Created attachment 47557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47557&action=edit Bug 14272: Show single news item (backend) Updates: * Date formatting added to get_opac_new() * Proper filtering by way of GetNewsToDisplay Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 16:19:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 15:19:41 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #17 from M. Tompsett --- I did not sign this off. I rebased it to apply cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 16:21:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 15:21:25 +0000 Subject: [Koha-bugs] [Bug 14209] opacserialdefaulttab ignored with bibs having items <1 or >50 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14209 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Assignee|oleonard at myacpl.org |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 16:35:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 15:35:43 +0000 Subject: [Koha-bugs] [Bug 15385] News archive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45871|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 47559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47559&action=edit Bug 15385: News archive Adds ability to new old, expired news items in an archive. Test plan: * Add several news items, some of which should have an expired date. * Go to Global system preferences, Enable 'NewsArchiveEnabled'. * Go to the OPAC main page. The non-expired news should be shown. * A link should be shown in the lower right-hand side of the page, "Archived news". Click it. ALL news items should be shown. * Go back to Global system preferences, Disable 'NewsArchiveEnabled'. * No 'Archived news' link should be shown on the OPAC main page. * If you manually add '?id=all' to the OPAC main page URL, the standard page should be shown and the parameter ignored. Updates: * Renamed 'id' to 'news_id' (from update in 14272) * Added breadcrumbs Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 16:39:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 15:39:32 +0000 Subject: [Koha-bugs] [Bug 15385] News archive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- I did not sign off. I merely rebased till it applied nicely. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 16:39:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 15:39:40 +0000 Subject: [Koha-bugs] [Bug 15723] New: Add preview marc in authority results authorities-home.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15723 Bug ID: 15723 Summary: Add preview marc in authority results authorities-home.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 47560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47560&action=edit authority search Hi, In a results list of authorities , it would be great to have a Marc preview of each notice. We could then check quickly the authorities to merge. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 16:55:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 15:55:02 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 16:55:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 15:55:04 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #6 from H?ctor Eduardo Castro Avalos --- Created attachment 47561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47561&action=edit Bug 15694: (followup)Update DOM index filter definitions Update for MARC21 biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl To test follow the previus test plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 17:00:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 16:00:31 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #7 from H?ctor Eduardo Castro Avalos --- (In reply to Jonathan Druart from comment #5) > Nicole, > I think the files biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl > need to be updated when a zebra index is added/deleted/modified. Hi Jonathan and Nicole This really works without update the files. My question is why? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 17:04:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 16:04:27 +0000 Subject: [Koha-bugs] [Bug 14738] Rancor - Advanced Search usability problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14738 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 17:09:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 16:09:40 +0000 Subject: [Koha-bugs] [Bug 15704] split up 264 index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from H?ctor Eduardo Castro Avalos --- Hi Nicole At first glance I thought it was Katrin who file this bug, but I was wrong. What do you think about comment 1, or could you propose something at this point? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 17:17:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 16:17:16 +0000 Subject: [Koha-bugs] [Bug 15724] New: Add possibility to export notice in marc format in z39.50 results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15724 Bug ID: 15724 Summary: Add possibility to export notice in marc format in z39.50 results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, Preview marc of a notice exist in a Z39.50 list result, but it would be great to have a way to export file in format marc. This file can then be processed in MarcEdit. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 17:26:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 16:26:31 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #2 from H?ctor Eduardo Castro Avalos --- This only happen in gitfied installations, /home/myuser/kohaclone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 17:27:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 16:27:26 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47547|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 47562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47562&action=edit [SIGNED-OFF]Bug 15721: About page does not display Apache version This patch changes about.pl to get version information from C4::Context where applicable and fixes missing display of the Apache version e.g. for Apache/2.2.22 To test: - Without patch, open about page in staff client - Remember contents of tab 'Server information' (e.g. make a screenshot) - Apply patch - Verify, that the About page displays the same information as before rsp. additionally displays Apache version if it was missing without patch. Signed-off-by: Hector Castro Works as described -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 17:27:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 16:27:24 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 18:11:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 17:11:19 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 18:20:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 17:20:30 +0000 Subject: [Koha-bugs] [Bug 13668] Creator of an SQL report shoudl be NULL when the staff patron is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #8 from Jonathan Druart --- Need to think about it (merge deletedborrowers with borrowers table). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 18:20:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 17:20:51 +0000 Subject: [Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849 --- Comment #4 from Jonathan Druart --- Need to think about it (merge deletedborrowers with borrowers table). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 18:20:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 17:20:59 +0000 Subject: [Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 19:27:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 18:27:45 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #14 from Marc V?ron --- I get an error in circ/del_message.pl line 26: Can't locate Koha/Patrons/Messages.pm in @INC (@INC contains: /usr/share/kohaclone /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /usr/share/kohaclone/circ/del_message.pl line 26. BEGIN failed--compilation aborted at /usr/share/kohaclone/circ/del_message.pl line 26. The line should read use Koha::Patron::Messages; ( instead of use Koha::Patrons::Messages; ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 19:55:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 18:55:55 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42418|0 |1 is obsolete| | --- Comment #34 from M. Tompsett --- Created attachment 47563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47563&action=edit [Signed-off] Bug 12426: Allow resending of messages from the notices tab in the patron account This patch adds a link 'Resend' under a notice in 'failed' status in the Patron's Notices tab. By clicking the link, we will request notices.pl with parameter "resendnotice=XXXXX" where XXXXX is message_id. In notices.pl, we then check whether the given message is actually in 'failed' status. If so, we use the C4::Letters::ResendMessage(123) to change the status of the message into 'pending'. This way it will be processed again by the cronjob process_message_queue.pl. To test, find/create a Patron that has failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the failed message 4. Observe that there is nothing for resending the failed message 5. Apply patch. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 19:56:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 18:56:03 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42512|0 |1 is obsolete| | --- Comment #35 from M. Tompsett --- Created attachment 47564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47564&action=edit Bug 12426: Simplify the code adding a new subroutine GetMessage The C4::Letters module does not have a GetMessage subroutine, which could be quite useful. This patch adds it and simplifies the code added by the previous patch. It also adds a few tests and fixes POD typos. Note that ResendNotice only resends failed messages. This will avoid to resend already sent messages (using an url from the browser history for instance). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 19:56:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 18:56:09 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42621|0 |1 is obsolete| | --- Comment #36 from M. Tompsett --- Created attachment 47565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47565&action=edit Bug 12426: Allow resend for sent messages This patch allows to resend both sent and failed messages. With messages in 'sent' status, we have to be careful not to accidentally send sent messages again. With the previous patch using GET request, this was likely to happen because of browser storing the GET parameters. This patch changes request method from GET to POST. Instead of a simple link, we now have a form element. In notices.pl we redirect back to notices.pl, because with POST there is a risk of resending the message accidentally by form resubmission at refresh. To test, find/create a Patron that has sent or failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the sent or failed message 4. Observe that there is nothing for resending the sent or failed message 5. Apply the patches. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 20:02:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 19:02:53 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Patch doesn't apply |Needs Signoff --- Comment #37 from M. Tompsett --- Except for moving the $op line, this is a rebase, which applies. I have not signed off. The sign off change is identical, so I left it marked as such. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 20:03:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 19:03:01 +0000 Subject: [Koha-bugs] [Bug 12239] Errors loading script under https in chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12239 --- Comment #3 from Owen Leonard --- Is this bug still valid? I don't see any errors when I look at our OPAC in Chrome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 20:04:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 19:04:06 +0000 Subject: [Koha-bugs] [Bug 13527] Mixed content warnings in results and detail with Google images on https In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13527 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 14523 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 20:04:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 19:04:06 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #13 from Owen Leonard --- *** Bug 13527 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 20:18:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 19:18:15 +0000 Subject: [Koha-bugs] [Bug 13420] sorting on volume number is not sorting right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Karl Holten changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org --- Comment #6 from Karl Holten --- Created attachment 47566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47566&action=edit Screenshot of bug in context in the staff view While the duplicate bug has been marked as fixed, I am not entirely clear on if that bug will address this issue, so I will update this ticket. Attached is a screenshot of the bug in context in the staff view. The OPAC view sorts in a similar way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 20:18:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 19:18:56 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #18 from Owen Leonard --- At this time I guess my preferences is for the "error" instances to be corrected. It would be nice to find a good example of where all three messages ('message', 'alert', and a new 'error' type) could be shown to be useful in one workflow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 20:35:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 19:35:07 +0000 Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 Karl Holten changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 20:44:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 19:44:16 +0000 Subject: [Koha-bugs] [Bug 15551] checked out items not showing on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551 Karl Holten changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org --- Comment #2 from Karl Holten --- (In reply to Katrin Fischer from comment #1) > Hm, I am not sure about this - the new change should only avoid showing > items which actually haven't been checked in - like items not checked out > when performing the check in. > > Also - I don't think it ever showed other items checked out by the patron? > Maybe they just followed the link from the checked in item? That should > still work, if the patch you are referring didn't cause a bug. Our institutions preferred being able to see other items checked out by the same patron. Two institutions reported this issue to us after our update to 3.20, so it was definitely something that was present and that staff were using that went away. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 20:58:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 19:58:14 +0000 Subject: [Koha-bugs] [Bug 15416] Warns on Guided Reports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |In Discussion --- Comment #2 from H?ctor Eduardo Castro Avalos --- Hi Aleisha I can't reproduce the issue, could you please confirm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 21:01:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 20:01:32 +0000 Subject: [Koha-bugs] [Bug 15416] Warns on Guided Reports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416 --- Comment #3 from Aleisha Amohia --- This is still valid for me on version 3.23 of Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 21:16:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 20:16:39 +0000 Subject: [Koha-bugs] [Bug 15054] Get items from database instead of search engine in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15054 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |hector.hecaxmmx at gmail.com --- Comment #4 from H?ctor Eduardo Castro Avalos --- Hi Fridolin Sorry but fail in Merge step, could you please rebase/fix, I think IMHO your patch is a good solution. The problem you describe is very annoying. Applying: Bug 15054 - Get items from database instead of search engine in search results Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Search.pm CONFLICT (content): Merge conflict in C4/Search.pm Failed to merge in the changes. Patch failed at 0001 Bug 15054 - Get items from database instead of search engine in search results When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 21:53:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 20:53:11 +0000 Subject: [Koha-bugs] [Bug 15551] checked out items not showing on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551 --- Comment #3 from Katrin Fischer --- I am really confused by this - I am pretty sure the table below the checkin input field only showed items scanned. Could they mean the link back to the patron record by chance, that was accessible from lines in the table? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 21:59:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 20:59:34 +0000 Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 21:59:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 20:59:36 +0000 Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46760|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47567&action=edit [SIGNED-OFF]Bug 15415: Warn when creating a new print profile This warn is hard-coded in Profile.pm sub get_attr { my $self = shift; if (_check_params(@_) eq 1) { return -1; } my ($attr) = @_; if (exists($self->{$attr})) { return $self->{$attr}; } else { warn sprintf('%s is currently undefined.', $attr); <-- THIS LINE return -1; } } So I have removed this line because I don't think it's really necessary. To test: 1) Go to Tools -> Patron Card Creator -> New printer profile 2) Notice warn 3) Apply patch 4) Refresh page 5) Confirm warn is gone and page still works as expected Signed-off-by: Hector Castro Warn is gone and working correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 22:00:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 21:00:07 +0000 Subject: [Koha-bugs] [Bug 15416] Warns on Guided Reports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416 --- Comment #4 from H?ctor Eduardo Castro Avalos --- (In reply to Aleisha Amohia from comment #3) > This is still valid for me on version 3.23 of Koha Pardon me I didn't know that i needed to consult the log files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 22:04:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 21:04:08 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 22:04:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 21:04:24 +0000 Subject: [Koha-bugs] [Bug 15416] Warns on Guided Reports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 22:04:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 21:04:26 +0000 Subject: [Koha-bugs] [Bug 15416] Warns on Guided Reports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46761|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 47568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47568&action=edit [SIGNED-OFF]Bug 15416: Warns on guided_reports.pl Initialising $phase variable to be '' if not defined. To test: 1) Go to Reports -> Guided Reports Wizard 2) Notice warns 3) Apply patch 4) Refresh page 5) Confirm warns are gone and page still works as it should Signed-off-by: Hector Castro Warns are gone. Page still works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 22:04:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 21:04:46 +0000 Subject: [Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15473 Status|Needs Signoff |Patch doesn't apply --- Comment #8 from M. Tompsett --- bug 15473 conflicts with this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 22:04:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 21:04:42 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 22:04:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 21:04:46 +0000 Subject: [Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14539 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 22:27:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 21:27:28 +0000 Subject: [Koha-bugs] [Bug 15551] checked out items not showing on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 22:49:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 21:49:51 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 22:50:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 21:50:44 +0000 Subject: [Koha-bugs] [Bug 15531] Add support for standing orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 22:50:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2016 21:50:46 +0000 Subject: [Koha-bugs] [Bug 15531] Add support for standing orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 --- Comment #4 from Jesse Weaver --- Created attachment 47569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47569&action=edit Bug 15531: (followup) Use a quantity of 1, not null, for standing orders This seems to cause fewer problems with the existing acquisitions code. Test plan is unchanged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 04:10:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 03:10:45 +0000 Subject: [Koha-bugs] [Bug 15683] Inconsistent population of lastreneweddate between AddRenewal and AddIssue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15683 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 04:12:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 03:12:32 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 04:21:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 03:21:58 +0000 Subject: [Koha-bugs] [Bug 15725] New: Merge permission Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15725 Bug ID: 15725 Summary: Merge permission Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl It would be nice if Koha had a permission to limit access to the merge records option (Merge selected button) on the addbooks.pl search results page and the virtualshelves/shelves.pl page (lists). This is especially important in a consortial catalog environment where many people have cataloging permissions, but most probably shouldn't have the ability to merge records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 04:36:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 03:36:55 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 04:38:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 03:38:08 +0000 Subject: [Koha-bugs] [Bug 15441] columns_settings.pl: Circulation issues-table - cannot toggle checkin column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15441 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 04:39:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 03:39:18 +0000 Subject: [Koha-bugs] [Bug 15441] columns_settings.pl: Circulation issues-table - cannot toggle checkin column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15441 --- Comment #1 from Heather Braum --- +1 to Chad's suggestion. We have had to hide this column for years with JQuery for the reasons Chad explains. It would be great to hide it through the new columns configuration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 04:45:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 03:45:39 +0000 Subject: [Koha-bugs] [Bug 15726] New: columns_settings.pl: add option for circulation rules column configuration Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726 Bug ID: 15726 Summary: columns_settings.pl: add option for circulation rules column configuration Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The circulation rules table is so big, you have to scroll across two full laptop screens. If you know a column is not being used by any location, it would be nice to be able to control the visibility of the columns through the new columns_settings.pl option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 06:04:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 05:04:31 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 --- Comment #28 from David Cook --- I think that this was working for a time, but it appears that some bots may have wised up... I'm noticing spam coming through once again, which I assume means that someone is having their bot ignore the "negcap" field or fields that are located off screen. Both would be easy to do. We're going to look at blocking some IP addresses to start, but this one is a distributed spamming of the system so that will likely only be partially successful. I have a couple curl commands that I could use to easily spam opac-suggestions.pl... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 06:13:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 05:13:21 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 --- Comment #29 from David Cook --- You know... we could do a text-based positive captcha. That should be accessible. Something like... "write the third word from the previous paragraph in the following box". A human should be able to understand that instruction, and it should require fairly sophisticated natural language processing for a bot to figure out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 06:13:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 05:13:40 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 --- Comment #30 from David Cook --- Ideally, it wouldn't always be the third word. It would sometimes be the first word or the last word of the paragraph. Something like that... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 07:01:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 06:01:29 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 --- Comment #31 from Christopher Vella --- Potentially the bot could be trying input forms at random, or more advanced and only reading through the visible elements of the page. Rather than go down the positive captcha route yet. We could attempt to make this negcaptcha smarter. One idea could be to IP ban any user who submits content to that form (I don't see any reason why a normal user would). We could also have the field name randomise per instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 07:54:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 06:54:09 +0000 Subject: [Koha-bugs] [Bug 15516] RFC: Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47498|0 |1 is obsolete| | --- Comment #5 from Julian Maurice --- Created attachment 47570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47570&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 07:54:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 06:54:28 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|RFC: Allow to reserve first |Allow to reserve first |available item from a group |available item from a group |of titles |of titles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 09:19:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 08:19:03 +0000 Subject: [Koha-bugs] [Bug 15727] New: Add 385$a - Audience to MARC21 detail pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15727 Bug ID: 15727 Summary: Add 385$a - Audience to MARC21 detail pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be nice if Koha showed information about the audience from 385$a on the detail pages in staff and OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 10:24:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 09:24:57 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47094|0 |1 is obsolete| | Attachment #47095|0 |1 is obsolete| | Attachment #47515|0 |1 is obsolete| | Attachment #47516|0 |1 is obsolete| | Attachment #47525|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 47571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47571&action=edit Bug 15632: Koha::Patron::Messages - Remove DeleteMessage The DeleteMessage just deleted and logged if needed. This is now be done by Koha::Patron::Message->delete. Test plan: 1/ Go on the "check out" page of a patron 2/ Delete some messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 10:25:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 09:25:09 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #17 from Jonathan Druart --- Created attachment 47573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47573&action=edit Bug 15632: Koha::Patron::Messages - Remove GetMessages This subroutine just retrieved the messages given some parameters. Some job should not have been done in this subroutine. It was called only 3 times, in circ/circulation.pl and opac-user.pl. Basically it was used to retrieved the message to displaye for a given patron ($borrowernumber) at the OPAC (B) or Staff (L). For the 3 calls, the 2 parameters $borrowernumber and $type (message_type) were passed, the "%" trick at the beginning of the subroutine was useless. Moreover, the date formatting should be done on the TT side, not in subroutine. The can_delete flag was set if the branchcode given in parameter was the same as the one of the message. This has been delegated to the template. Indeed the can_delete was not valid, since it must depend on the AllowAllMessageDeletion pref. The test is now: IF message.branchcode == branch OR Koha.Preference('AllowAllMessageDeletion'') There is not specific test plan for this patch, the changes have already been tested in previous patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 10:25:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 09:25:15 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #18 from Jonathan Druart --- Created attachment 47574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47574&action=edit Bug 15632: Koha::Patron::Messages - Remove tests The messages related tests in t/db_dependent/Members.t are not deprecated and can be removed. Test plan: git grep AddMessage git grep DeleteMessage git grep GetMessagesCount git grep GetMessages should not return any result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 10:25:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 09:25:03 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #16 from Jonathan Druart --- Created attachment 47572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47572&action=edit Bug 15632: Koha::Patron::Messages - Remove GetMessagesCount The GetMessageCount subroutine was only used once, in opac-user.pl, to know if some messages will be displayed. Test plan: 1/ Create messages to display at the OPAC for a patron 2/ Logged this patron in at the OPAC, you should see the messages displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 10:25:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 09:25:19 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #19 from Jonathan Druart --- Created attachment 47575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47575&action=edit Bug 15632: Koha::Patron::Messages - (follow-up) Remove AddMessage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 11:49:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 10:49:25 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #205 from Julian Maurice --- (In reply to Marcel de Rooy from comment #203) > Note that this still needs attention in terms of (Debian) packaging. > At first glance this module does not seem to be available in a Debian > package. I started packaging this module. ITP bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813574 Git repo: https://anonscm.debian.org/cgit/pkg-perl/packages/libtemplate-stash-autoescaping-perl.git/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 11:55:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 10:55:24 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #32 from Marc V?ron --- The self registration ( cgi-bin/koha/opac-memberentry.pl ) has already a text based captcha with a random string: "Please type the following characters into the preceding box: ODXZX" I think it would be good to re-use technique/code at all places where we have 'human user input'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 12:09:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 11:09:40 +0000 Subject: [Koha-bugs] [Bug 15551] checked out items not showing on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 12:42:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 11:42:09 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #19 from Jonathan Druart --- So, for instance: 1/ on admin/cities, delete one city, you will get an 'alert': "Are you sure you want to delete this stuff?" 2/ on admin/branches, delete one library, not linked to anything. You won't get an 'alert', but a 'fieldset' (fixme, not consistent). 3/ on admin/branches, delete one library linked to a patron. You will get an 'error' "This library cannot be deleted." 4/ on admin/branches, create a library with an existing branchcode. You will get an 'error' "An error occurred when adding this library. The branchcode might already exist." The last one is definitely an error, the patron has lost his form. And as I said previously, it should be caught when editing the form. 1/ and 2/ should have the same behavior (which one? we usually use 'alert') 3/ is between the 'alert' and the 'error', it's more an info actually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:10:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:10:31 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #206 from Marcel de Rooy --- (In reply to Julian Maurice from comment #205) > I started packaging this module. > ITP bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813574 > Git repo: > https://anonscm.debian.org/cgit/pkg-perl/packages/libtemplate-stash- > autoescaping-perl.git/ Great! Thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:20:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:20:03 +0000 Subject: [Koha-bugs] [Bug 13302] Use CSS3 ellipsis for email address in staff client patron sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13302 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:20:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:20:06 +0000 Subject: [Koha-bugs] [Bug 13302] Use CSS3 ellipsis for email address in staff client patron sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13302 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47549|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 47576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47576&action=edit Bug 13302 [Revised] Use CSS3 ellipsis for email address in staff client patron sidebar This patch replaces the email address text overflow solution implemented by Bug 3256 with a CSS3 technique: text-overflow: ellipsis https://developer.mozilla.org/en-US/docs/Web/CSS/text-overflow To test, apply the patch and clear your browser cache. Edit the primary email address of a patron so that it is very long. View that patron in the staff client (on the checkout or details page, for instance) and confirm that the email address is truncated with "..." Confirm that the link and the title attribute of the link contain the correct, full email address. Revision uses a percentage instead of a fixed width for email display in the sidebar to accommodate varying sidebar widths. Also added: Handling of all email addresses displayed on the patron detail page. Although email addresses in the body of that page were not in the scope of the original patch, it's a good improvement to include those as well. Signed-off-by: Owen Leonard Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:24:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:24:16 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:24:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:24:18 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47524|0 |1 is obsolete| | Attachment #47554|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 47577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47577&action=edit Bug 15697: Unnecessary comma between title and subtitle on opac-detail.pl To test: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping (or ensure it exists) Field name: subtitle MARC field: 245 MARC subfield: b 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" 5 - Apply patch 6 - View the record again and note the comma is no longer present. Note: this patch removes the comma only for MARC21 where subtitle is not repeatable. UNIMARC seems to be repeatable and does not include punctuation so I believe this may be needed there. Signed-off-by: Hector Castro Works as described. Comma removed from title of the window and breadcrumb section Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:24:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:24:23 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 --- Comment #8 from Jonathan Druart --- Created attachment 47578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47578&action=edit Bug 15697 - [QA Followup] Apply change to NORMARC This patch switches from UNLESS MARC21 to IF UNIMARC - this way changes apply to MARC21 and NORMARC and UNIMARC remains unaffected Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:25:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:25:48 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 --- Comment #9 from Jonathan Druart --- Joubu: magnuse: could you confirm my comment on bug 15697 comment 4 about NORMARC please? magnuse: Joubu: the qa followup looks good. and yes, marc21 and normarc are very similar in most regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:29:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:29:47 +0000 Subject: [Koha-bugs] [Bug 15416] Warns on Guided Reports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:29:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:29:50 +0000 Subject: [Koha-bugs] [Bug 15416] Warns on Guided Reports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47568|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 47579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47579&action=edit Bug 15416: Warns on guided_reports.pl Initialising $phase variable to be '' if not defined. To test: 1) Go to Reports -> Guided Reports Wizard 2) Notice warns 3) Apply patch 4) Refresh page 5) Confirm warns are gone and page still works as it should Signed-off-by: Hector Castro Warns are gone. Page still works as expected Signed-off-by: Jonathan Druart Amended patch: -my $phase = $input->param('phase'); -$phase //= ''; +my $phase = $input->param('phase') // ''; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:30:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:30:46 +0000 Subject: [Koha-bugs] [Bug 15416] Warns on Guided Reports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com Patch complexity|--- |Trivial patch Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:40:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:40:04 +0000 Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Aleisha, I am not sure to understand the point of this warning, but I would prefer to keep it. I think the problem comes from the script patroncards/edit-profile.pl: 93 $template->param(profile_id => $profile->get_attr('profile_id')) if $profile->get_attr('profile_id') > 0; The get_attr method should not be called if we are adding a new profile. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:40:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:40:26 +0000 Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:42:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:42:44 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47091|0 |1 is obsolete| | --- Comment #20 from Marc V?ron --- Created attachment 47580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47580&action=edit Bug 15632: Koha::Patron::Messages - Add new classes The following 4 CRUD subroutines in C4::Members: - AddMessage - DeleteMessage - GetMessagesCount - GetMessages could be replaced with a new package based on Koha::Objets. This patchset will add the 2 Koha::Patron::Message[s] classes, then use it to replace the different calls to these subroutine. It will slightly reduce the size of C4::Members Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:43:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:43:51 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47092|0 |1 is obsolete| | --- Comment #21 from Marc V?ron --- Created attachment 47581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47581&action=edit Bug 15632: Koha::Patron::Messages - Be sure add and delete will log If the pref BorrowersLog is on, the store and delete method should log into the action_logs table. Easy to do by overloading them. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:44:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:44:44 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- Marc, I have not tested your patch, but looking at commit 16d7ba09f3705e56ae03beda1dd15111f2583de9 Bug 13486: Apache version empty in about page if Apache 2.4 it might be wrong with apache 2.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:44:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:44:53 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47093|0 |1 is obsolete| | --- Comment #22 from Marc V?ron --- Created attachment 47582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47582&action=edit Bug 15632: Koha::Patron::Messages - Remove AddMessage The AddMessage subroutine just 1. checked if all the parameters were passed 2. inserted the message in the DB 3. logged the action if needed These 3 jobs are now done by the overloaded store method of Koha::Patron::Message. Test plan: 1/ Go on the "check out" page of a patron 2/ Add different new messages Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:45:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:45:47 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47571|0 |1 is obsolete| | --- Comment #23 from Marc V?ron --- Created attachment 47583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47583&action=edit Bug 15632: Koha::Patron::Messages - Remove DeleteMessage The DeleteMessage just deleted and logged if needed. This is now be done by Koha::Patron::Message->delete. Test plan: 1/ Go on the "check out" page of a patron 2/ Delete some messages Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:46:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:46:27 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47572|0 |1 is obsolete| | --- Comment #24 from Marc V?ron --- Created attachment 47584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47584&action=edit Bug 15632: Koha::Patron::Messages - Remove GetMessagesCount The GetMessageCount subroutine was only used once, in opac-user.pl, to know if some messages will be displayed. Test plan: 1/ Create messages to display at the OPAC for a patron 2/ Logged this patron in at the OPAC, you should see the messages displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:47:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:47:17 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47573|0 |1 is obsolete| | --- Comment #25 from Marc V?ron --- Created attachment 47585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47585&action=edit Bug 15632: Koha::Patron::Messages - Remove GetMessages This subroutine just retrieved the messages given some parameters. Some job should not have been done in this subroutine. It was called only 3 times, in circ/circulation.pl and opac-user.pl. Basically it was used to retrieved the message to displaye for a given patron ($borrowernumber) at the OPAC (B) or Staff (L). For the 3 calls, the 2 parameters $borrowernumber and $type (message_type) were passed, the "%" trick at the beginning of the subroutine was useless. Moreover, the date formatting should be done on the TT side, not in subroutine. The can_delete flag was set if the branchcode given in parameter was the same as the one of the message. This has been delegated to the template. Indeed the can_delete was not valid, since it must depend on the AllowAllMessageDeletion pref. The test is now: IF message.branchcode == branch OR Koha.Preference('AllowAllMessageDeletion'') There is not specific test plan for this patch, the changes have already been tested in previous patches. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:48:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:48:15 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47574|0 |1 is obsolete| | --- Comment #26 from Marc V?ron --- Created attachment 47586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47586&action=edit Bug 15632: Koha::Patron::Messages - Remove tests The messages related tests in t/db_dependent/Members.t are not deprecated and can be removed. Test plan: git grep AddMessage git grep DeleteMessage git grep GetMessagesCount git grep GetMessages should not return any result. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:49:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:49:13 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47575|0 |1 is obsolete| | --- Comment #27 from Marc V?ron --- Created attachment 47587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47587&action=edit Bug 15632: Koha::Patron::Messages - (follow-up) Remove AddMessage Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:49:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:49:45 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 13:59:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 12:59:43 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 --- Comment #5 from Marc V?ron --- Hi Jonathan, I removed the check for versions from about.pl and I use C4::Context::get_versions() instead. So C4::Context::get_versions() would give wrong results? - Or what is precisely the reason to fail the patch? Anyway, it fixes for me the issue on current master and on a 3.22 installation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 14:09:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 13:09:43 +0000 Subject: [Koha-bugs] [Bug 15551] checked out items not showing on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551 --- Comment #4 from Owen Leonard --- I'm confused by this too. I agree that Bug 14821 seems like a regression, and I would love to see it turned into a preference. However, it doesn't have anything to do with showing what other items a patron has checked out, and that is not something Koha has ever done on the check-in page. If the issue has come up after updating to 3.20 then I suspect this is a communication issue and Bug 14821 is what is really being discussed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 14:17:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 13:17:17 +0000 Subject: [Koha-bugs] [Bug 15728] New: Hide component parts from search result Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15728 Bug ID: 15728 Summary: Hide component parts from search result Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: larit at student.uef.fi QA Contact: testopia at bugs.koha-community.org Add an option to hide component parts from search results. When searching for a song, we may want to see album results only (albums where the song appears). This option would help the process of seeing if a song is on an album that is available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 14:17:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 13:17:58 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13486 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 14:17:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 13:17:58 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15721 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 14:53:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 13:53:35 +0000 Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition module could order by email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:04:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:04:13 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #38 from Marc V?ron --- Created attachment 47588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47588&action=edit Bug 12426: Allow resending of messages from the notices tab in the patron account This patch adds a link 'Resend' under a notice in 'failed' status in the Patron's Notices tab. By clicking the link, we will request notices.pl with parameter "resendnotice=XXXXX" where XXXXX is message_id. In notices.pl, we then check whether the given message is actually in 'failed' status. If so, we use the C4::Letters::ResendMessage(123) to change the status of the message into 'pending'. This way it will be processed again by the cronjob process_message_queue.pl. To test, find/create a Patron that has failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the failed message 4. Observe that there is nothing for resending the failed message 5. Apply patch. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:04:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:04:45 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47563|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:05:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:05:31 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47564|0 |1 is obsolete| | --- Comment #39 from Marc V?ron --- Created attachment 47589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47589&action=edit Bug 12426: Simplify the code adding a new subroutine GetMessage The C4::Letters module does not have a GetMessage subroutine, which could be quite useful. This patch adds it and simplifies the code added by the previous patch. It also adds a few tests and fixes POD typos. Note that ResendNotice only resends failed messages. This will avoid to resend already sent messages (using an url from the browser history for instance). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:10:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:10:40 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47565|0 |1 is obsolete| | --- Comment #40 from Marc V?ron --- Created attachment 47590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47590&action=edit Bug 12426: Allow resend for sent messages This patch allows to resend both sent and failed messages. With messages in 'sent' status, we have to be careful not to accidentally send sent messages again. With the previous patch using GET request, this was likely to happen because of browser storing the GET parameters. This patch changes request method from GET to POST. Instead of a simple link, we now have a form element. In notices.pl we redirect back to notices.pl, because with POST there is a risk of resending the message accidentally by form resubmission at refresh. To test, find/create a Patron that has sent or failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the sent or failed message 4. Observe that there is nothing for resending the sent or failed message 5. Apply the patches. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status Tested all patches together. Wors as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:12:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:12:14 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:18:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:18:55 +0000 Subject: [Koha-bugs] [Bug 14616] Introducing Koha::Object subclasses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14616 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:20:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:20:03 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42532|0 |1 is obsolete| | --- Comment #22 from R?mi Mayrand-Provencher --- Created attachment 47591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47591&action=edit Bug 8612 - System preference to have custom fields in export csv basket This patch allows the user use a CSV export profile to create the fields to export the basket as CSV in a basket page. To test: 1) Apply the patch; 2) Create a CSV export profile - type sql - Home ? Tools ? CSV export profiles ex: biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno 3) Create a new basket and add an order to the basket 4) Validate: the text "Select CSV profile:" and a dropdown in the basket view 5) In the new dropdown, select the CSV export profile created 6) Validate the CSV file. 7) Do the same validation with a closed basket. a) close the basket b) View the basket c) validate that there is a dropdown d) test it with an export Signed-off-by: Josef Moravec Works as expected for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:20:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:20:09 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42533|0 |1 is obsolete| | --- Comment #23 from R?mi Mayrand-Provencher --- Created attachment 47592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47592&action=edit Bug 8612 - Cleans basket.tt by using TT blocks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:20:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:20:16 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42534|0 |1 is obsolete| | --- Comment #24 from R?mi Mayrand-Provencher --- Created attachment 47593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47593&action=edit Bug 8612 - Clean basket.pl getting rid of subroutines with sql query and use GetBasketAsCSV instead GetBasketAsCSV now has a new argument the profile_csv_id, when this param is defined, it loads the profile_content, searches the value of the predefined fields and assembles the data to create the output of the csv file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:21:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:21:18 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #25 from R?mi Mayrand-Provencher --- Fixed conflicts and changed icons to font awesome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:26:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:26:26 +0000 Subject: [Koha-bugs] [Bug 8985] Add script to batch modify issuing rule hard due dates. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8985 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:28:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:28:00 +0000 Subject: [Koha-bugs] [Bug 8985] Add script to batch modify issuing rule hard due dates. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8985 --- Comment #6 from Kyle M Hall --- Rolling hard due dates plugin has made this script unecessary: https://github.com/bywatersolutions/koha-plugin-rolling-hard-due-dates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:30:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:30:53 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #58 from Kyle M Hall --- (In reply to Owen Leonard from comment #57) > Applying: Bug 14695 - Warn librarian if max_holds_per_record is reached > fatal: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 14695 - Warn librarian if max_holds_per_record is > reached I had no problem applying this patch set to master! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:34:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:34:51 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #13 from Kyle M Hall --- (In reply to Bob Birchall from comment #12) > (In reply to Kyle M Hall from comment #0) > > We should enable TT syntax for slips and notices. This could work side by > > side with the existing syntax parser for a release or two before we > > officially remove our bespoke parsing code for slips and notices, giving > > libraries ample time to switch over. > > I endorse the comments by Jonathan and Katrin that libraries must be able to > edit their own notices. They need a simple interface in which to do that > and good documentation. > > I'm also concerned about the potential cost of this change, for a support > company and also for any large consortium that has notices defined > separately by branch. If every notice in use at every client needs at best > examination and at worst to be re-written, that's a bit daunting. Is that > the implication? The current plan is to make this work with minimal or no changes! You can check out the mailing list thread for the on-going discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:47:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:47:55 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:47:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:47:58 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45038|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 47594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47594&action=edit Bug 11360 - Disable barcode field and submit button when a hold is found At the moment when scanning in returns, it can be easy to miss a hold trap due to the fact that the barcode and submit are still active and the barcode field is focused on. A librarian who is focused on scanning can easily scan another item and pass over the form, which is equivalent to clicking the "ignore" button. Test Plan: 1) Apply this patch 2) Trap a hold, note the new modal 3) Check the hold in a second time 4) Note the new modal 5) For each modal, test each button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:50:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:50:04 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47503|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 47595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47595&action=edit Bug 15645: Remove the confusing wait var and use found instead Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:50:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:50:32 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 --- Comment #8 from Kyle M Hall --- (In reply to Jonathan Druart from comment #6) > Kyle, could you have a look at my follow-up please? > It seems that it fixes the confusion. Looks good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:55:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:55:34 +0000 Subject: [Koha-bugs] [Bug 15729] New: SIP server allows checkin of reserved item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15729 Bug ID: 15729 Summary: SIP server allows checkin of reserved item Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: bc at interleaf.ie QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com At present the SIP server will allow an item to be returned even if there is an outstanding hold on it. Some libraries do not see this as an issue and run reports for reserves before re-shelving. However, some prefer to have the item denied at the selfservice unit and force the borrower to return the item to the desk. With this in mind there should be a SIP systempreference which allows libraries to specify if a reserved item should be permitted to be checked in via the selfservice unit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:55:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:55:46 +0000 Subject: [Koha-bugs] [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:55:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:55:48 +0000 Subject: [Koha-bugs] [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47532|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 47596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47596&action=edit Bug 15706: Forgot to attach the change I made! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 15:58:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 14:58:35 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 --- Comment #10 from Kyle M Hall --- (In reply to Marc V?ron from comment #8) > (In reply to Kyle M Hall from comment #7) > > (In reply to Jonathan Druart from comment #6) > > > Should not we take 0 into account? > > > > I agree. Allowing 0 would mean a patron must have no fines in order to renew > > items. I think allowing 0 makes sense. It would also be good to note in the > > system preference description that leaving it empty will disable the feature > > ( i.e. patrons will always be able to renew items, no matter how much they > > owe in fines ). > > ...and maybe the wording should reflect the >0 and 0 cases (with and without > displaying the limit), and in a translatable way (sentence not split by > tags). You mean the wording displayed to the patron, correct? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 16:06:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 15:06:03 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 16:06:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 15:06:06 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 --- Comment #2 from Marcel de Rooy --- Created attachment 47597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47597&action=edit Bug 15714: Add get_loglevels to koha-functions.sh Preparing for including different log levels in koha-start-zebra. Note that the default response is none,fatal,warn; this is equal to the options passed to zebrasrv in koha-start-zebra (for now). Test plan: [1] Run on the command line: source koha-functions.sh [2] Type get_loglevels [your_instance] By default, you should see: none,fatal,warn [3] Add this line to your koha-conf: how,are,you [4] Run get_loglevels [your_instance] again. Remove the nonsense log levels again.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 16:06:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 15:06:10 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 --- Comment #3 from Marcel de Rooy --- Created attachment 47598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47598&action=edit Bug 15714: Remove zebra.log and add loglevels The file zebra.log is actually not used, because daemon's --output parameter sends all message to zebra-output (making that stdout goes there too and --stdout does nothing). We do not need any differentiation (if any at all) here; behavior does not change. Note: zebra-error will only contain the daemon's error messages and not the zebra error messages! So you will probably only find messages about stopping zebra in zebra-error. The loglevels are by default none,fatal,warn and can be changed via the zebra_loglevels config variable (read by koha-functions.sh). If you remove 'none', you will have request-messages in the log. You can also keep 'none' and add 'request' to achieve something similar (undocumented however). Some of the parameters passed to daemon when stopping zebra are superfluous and have been removed. Test plan: [1] Remove the file zebra.log. Look at last lines in zebra-error and zebra-output. [2] Remove zebra_loglevels from koha-conf (if present). Start/restart Zebra. Search to verify if Zebra runs. Stop Zebra and check zebra-error for a new line (killed by signal 15). [3] Add fatal,warn in koha-conf:zebra_loglevels (do not include 'none'). Start Zebra. Check zebra-output for a line "[log] zebra_start". Do a search and check zebra-output for lines with "[request]". [4] Verify that zebra.log did not appear again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 16:06:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 15:06:14 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 --- Comment #4 from Marcel de Rooy --- Created attachment 47599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47599&action=edit Bug 15714: Add zebra_loglevels to koha-conf.xml This patch adds a commented zebra_loglevels line to the config file. Behavior does not change, but an admin can easily edit the variable. Test plan: Nothing really changed. But if you are not so sure about that, apply the change to /etc/koha/koha-conf-site.xml.in and run koha-create. Check that the new koha-conf contains the line and is not messed up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 16:07:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 15:07:21 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove zebra.log from |Remove zebra.log from |debian scripts |debian scripts and add | |optional log levels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 16:19:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 15:19:11 +0000 Subject: [Koha-bugs] [Bug 15036] Closing and reopening a basket should not alter status of completed orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036 --- Comment #12 from Katrin Fischer --- A note for later: Should we also include a database update to recalculate the status affected correctly? The initial SQL when the feature was introduced could give some ideas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 16:21:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 15:21:51 +0000 Subject: [Koha-bugs] [Bug 15551] checked out items not showing on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551 --- Comment #5 from Karl Holten --- I think you're both right about my issue being a miscommunication between us and staff. One of our libraries couldn't recall this problem, and another said they had an issue where clicking "Show Checkouts" didn't make items display and Koha just said "loading continue to scan barcodes", which is not the same thing as what is discussed in this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 16:24:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 15:24:54 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 --- Comment #11 from Marc V?ron --- (In reply to Kyle M Hall from comment #10) > (In reply to Marc V?ron from comment #8) > > (In reply to Kyle M Hall from comment #7) > > > (In reply to Jonathan Druart from comment #6) > > > > Should not we take 0 into account? > > > > > > I agree. Allowing 0 would mean a patron must have no fines in order to renew > > > items. I think allowing 0 makes sense. It would also be good to note in the > > > system preference description that leaving it empty will disable the feature > > > ( i.e. patrons will always be able to renew items, no matter how much they > > > owe in fines ). > > > > ...and maybe the wording should reflect the >0 and 0 cases (with and without > > displaying the limit), and in a translatable way (sentence not split by > > tags). > > You mean the wording displayed to the patron, correct? Yes, correct :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 16:28:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 15:28:09 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 --- Comment #20 from Kyle M Hall --- Created attachment 47600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47600&action=edit Bug 15675 [QA Followup] - Close out accruing fines that are not really accruing, add issue_id to accruing fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 16:28:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 15:28:26 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 16:32:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 15:32:23 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47600|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 47601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47601&action=edit Bug 15675 [QA Followup] - Close out accruing fines that are not really accruing, add issue_id to accruing fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 16:58:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 15:58:19 +0000 Subject: [Koha-bugs] [Bug 15730] New: 500 error on returns.pl if barcode doesn't exist Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730 Bug ID: 15730 Summary: 500 error on returns.pl if barcode doesn't exist Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a librarian enters a barcode that does not match an item in the database, a 500 error will be displayed instead of the "No item with barcode" message. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 16:58:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 15:58:24 +0000 Subject: [Koha-bugs] [Bug 15730] 500 error on returns.pl if barcode doesn't exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 16:59:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 15:59:41 +0000 Subject: [Koha-bugs] [Bug 15730] 500 error on returns.pl if barcode doesn't exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 16:59:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 15:59:43 +0000 Subject: [Koha-bugs] [Bug 15730] 500 error on returns.pl if barcode doesn't exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730 --- Comment #1 from Kyle M Hall --- Created attachment 47602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47602&action=edit Bug 15730 - 500 error on returns.pl if barcode doesn't exist If a librarian enters a barcode that does not match an item in the database, a 500 error will be displayed instead of the "No item with barcode" message. Test Plan: 1) Enter an invalid barcode on returns.pl 2) Note the 500 error 3) Apply this patch 4) Repeat setp 1 5) Note the "No item with barcode" message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:04:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:04:57 +0000 Subject: [Koha-bugs] [Bug 15731] New: C4::Reports::Guided::build_authorised_value_list is not used Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Bug ID: 15731 Summary: C4::Reports::Guided::build_authorised_value_list is not used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org ...and can be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:06:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:06:48 +0000 Subject: [Koha-bugs] [Bug 15731] C4::Reports::Guided::build_authorised_value_list is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:06:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:06:50 +0000 Subject: [Koha-bugs] [Bug 15731] C4::Reports::Guided::build_authorised_value_list is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 --- Comment #1 from Jonathan Druart --- Created attachment 47603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47603&action=edit Bug 15731: Remove C4::Reports::Guided::build_authorised_value_list This subroutine has been added by commit 42acfbf75b7bb4ee53c6a6f035e258a0b522ce10 Bug 7993: Save reports with Group/Subgroup hierarchy But it has never been used (or git grep cheats me). Test plan: 1/ git grep build_authorised_value_list should not return any result 2/ Create a report, execute it Everything should work fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:11:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:11:40 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:11:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:11:43 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46992|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 47604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47604&action=edit bug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha.Preference instead Test Plan: 1) Apply this patch 2) Go to circulation.pl 3) Ensure you can still override renewal limits with pref enabled 4) Ensure you can not override renewal limits with pref disabled 5) Go to moremember.pl 6) Repeat steps 3-4 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:11:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:11:50 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 --- Comment #13 from Kyle M Hall --- Created attachment 47605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47605&action=edit Bug 12920 [QA Followup] - Show override option below checkouts table when allowed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:23:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:23:02 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 --- Comment #12 from Kyle M Hall --- (In reply to Marc V?ron from comment #11) > (In reply to Kyle M Hall from comment #10) > > (In reply to Marc V?ron from comment #8) > > > (In reply to Kyle M Hall from comment #7) > > > > (In reply to Jonathan Druart from comment #6) > > > > > Should not we take 0 into account? > > > > > > > > I agree. Allowing 0 would mean a patron must have no fines in order to renew > > > > items. I think allowing 0 makes sense. It would also be good to note in the > > > > system preference description that leaving it empty will disable the feature > > > > ( i.e. patrons will always be able to renew items, no matter how much they > > > > owe in fines ). > > > > > > ...and maybe the wording should reflect the >0 and 0 cases (with and without > > > displaying the limit), and in a translatable way (sentence not split by > > > tags). > > > > You mean the wording displayed to the patron, correct? > > Yes, correct :-) The template already deals with that. I think the translatability should be in a separate bug since we don't need to modify the template for the fines amount. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:23:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:23:34 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:25:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:25:39 +0000 Subject: [Koha-bugs] [Bug 15732] New: Remove accountno column from accountlines Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15732 Bug ID: 15732 Summary: Remove accountno column from accountlines Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org How that we have accountlines_id, accountno is superfluous. We should remove it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:35:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:35:40 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47227|0 |1 is obsolete| | --- Comment #59 from Alex Arnaud --- Created attachment 47606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47606&action=edit Bug 14695 - Update database Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:35:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:35:49 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47228|0 |1 is obsolete| | --- Comment #60 from Alex Arnaud --- Created attachment 47607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47607&action=edit Bug 14695 - Update DB Schema file Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:35:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:35:57 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47229|0 |1 is obsolete| | --- Comment #61 from Alex Arnaud --- Created attachment 47608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47608&action=edit Bug 14695 - Add new circulation rule Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:36:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:36:05 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47230|0 |1 is obsolete| | --- Comment #62 from Alex Arnaud --- Created attachment 47609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47609&action=edit Bug 14695 - Tidy C4::Reserves::CanItemBeReserved Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:36:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:36:13 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47231|0 |1 is obsolete| | --- Comment #63 from Alex Arnaud --- Created attachment 47610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47610&action=edit Bug 14695 - Add ability to place multiple item holds on a given record per patron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:36:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:36:19 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47232|0 |1 is obsolete| | --- Comment #64 from Alex Arnaud --- Created attachment 47611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47611&action=edit Bug 14695 [QA Followup] - Filling one hold fills all of them Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:36:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:36:27 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47233|0 |1 is obsolete| | --- Comment #65 from Alex Arnaud --- Created attachment 47612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47612&action=edit Bug 14695 [QA Followup] - Make existing unit tests pass * Removes tests no longer needed * Updates rules to work with existing tests * Fixes code issues revealed by unit tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:36:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:36:33 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47234|0 |1 is obsolete| | --- Comment #66 from Alex Arnaud --- Created attachment 47613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47613&action=edit Bug 14695 [QA Followup] - Fix clearing of all holds by patron at checkout Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:36:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:36:40 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47355|0 |1 is obsolete| | --- Comment #67 from Alex Arnaud --- Created attachment 47614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47614&action=edit Bug 14695 - Warn librarian if max_holds_per_record is reached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 17:36:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 16:36:47 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47372|0 |1 is obsolete| | --- Comment #68 from Alex Arnaud --- Created attachment 47615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47615&action=edit Bug 14695 - Don't use holds_to_place_count when checking an item. This fix the following bug: If you select 2 in "Holds to place (count)" and finally check an item, so you get 2 holds for the same item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 18:04:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 17:04:18 +0000 Subject: [Koha-bugs] [Bug 15732] Remove accountno column from accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15732 --- Comment #1 from Kyle M Hall --- We should also move to using Koha::Account::Line(s) for db crud. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 18:04:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 17:04:24 +0000 Subject: [Koha-bugs] [Bug 15732] Remove accountno column from accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15732 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15675 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 [Bug 15675] Add issue_id column to accountlines and use it for updating fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 18:04:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 17:04:24 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15732 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15732 [Bug 15732] Remove accountno column from accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 18:08:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 17:08:59 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46539|0 |1 is obsolete| | Attachment #46540|0 |1 is obsolete| | Attachment #46541|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall --- Created attachment 47616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47616&action=edit Squash patches for readability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 18:09:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 17:09:28 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47616|Squash patches for |Bug 9805 - Lost items are description|readability |un-lost if returned, but | |not if renewed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 18:59:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 17:59:37 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 18:59:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 17:59:40 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47616|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall --- Created attachment 47617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47617&action=edit Bug 9805 - Lost items are un-lost if returned, but not if renewed. If an item has a lost status, that status is removed when the item is returned. However, it is not removed if the item is renewed. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Browse to the circ rules 4) Note the "Renew lost?" and "Renewal marks lost found" rules 5) Set and test each of the rules both ways for the rules for all libraries 6) Repeat but for a specific branch this time Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 18:59:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 17:59:48 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 --- Comment #32 from Kyle M Hall --- Created attachment 47618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47618&action=edit Bug 9805 - Update Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 18:59:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 17:59:52 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 --- Comment #33 from Kyle M Hall --- Created attachment 47619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47619&action=edit Bug 9805 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 19:02:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 18:02:22 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #25 from Nicole C. Engard --- I have another example here. If a child become adult their stats go to adults even though they were children at the time. I'd love to see this patch rebased/fixed for current Koha if possible. Nicole -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:01:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:01:09 +0000 Subject: [Koha-bugs] [Bug 15733] New: Audio Alerts issues in master Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 Bug ID: 15733 Summary: Audio Alerts issues in master Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In master there is a JSON error thrown when AudioAlerts are enabled. When checking in I get: SyntaxError: JSON.parse: expected property name or '}' at line 1 column 3 of the JSON data This does not happen in 3.22 Also (in master and 3.22) single quotes audio selector break ability to edit an alert -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:02:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:02:33 +0000 Subject: [Koha-bugs] [Bug 15733] Audio Alerts issues in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:36:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:36:53 +0000 Subject: [Koha-bugs] [Bug 15734] New: Audio Alerts issues in master Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Bug ID: 15734 Summary: Audio Alerts issues in master Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org >From Nick: In master there is a JSON error thrown when AudioAlerts are enabled. When checking in I get: SyntaxError: JSON.parse: expected property name or '}' at line 1 column 3 of the JSON data This does not happen in 3.22 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:37:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:37:03 +0000 Subject: [Koha-bugs] [Bug 15733] Audio Alerts issues in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 [Bug 15734] Audio Alerts issues in master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:37:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:37:03 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts issues in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15733 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 [Bug 15733] Audio Alerts issues in master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:37:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:37:20 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts issues in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:37:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:37:53 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |aleishaamohia at hotmail.com --- Comment #16 from Aleisha Amohia --- Applying: Bug 13707 - 2. Adding a new column datereceived for items and biblioitems. Value accessors. fatal: sha1 information is lacking or useless (C4/Biblio.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 13707 - 2. Adding a new column datereceived for items and biblioitems. Value accessors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:40:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:40:06 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts issues in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:40:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:40:08 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts issues in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 --- Comment #1 from Kyle M Hall --- Created attachment 47620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47620&action=edit Bug 15734 - Audio Alerts issues in master In master there is a JSON error thrown when AudioAlerts are enabled. This is caused by changes in master from bug 13618. Test Plan: 1) Enable audio alerts 2) Note audio alerts don't work 3) Apply this patch 4) Note audio alerts now work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:40:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:40:16 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #53 from Aleisha Amohia --- Applying: Bug 7957: Routing lists enhancements fatal: sha1 information is lacking or useless (C4/Items.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7957: Routing lists enhancements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:40:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:40:46 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Audio Alerts issues in |Audio Alerts broken |master | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:41:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:41:29 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47620|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 47621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47621&action=edit Bug 15734 - Audio Alerts broken In master there is a JSON error thrown when AudioAlerts are enabled. This is caused by changes in master from bug 13618. Test Plan: 1) Enable audio alerts 2) Note audio alerts don't work 3) Apply this patch 4) Note audio alerts now work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:43:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:43:08 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:43:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:43:41 +0000 Subject: [Koha-bugs] [Bug 15735] New: Audio Alerts editor broken by use of of single quotes in editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Bug ID: 15735 Summary: Audio Alerts editor broken by use of of single quotes in editor Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Single quotes audio selector break ability to edit an alert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:43:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:43:48 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:44:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:44:00 +0000 Subject: [Koha-bugs] [Bug 15733] Audio Alerts issues in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:44:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:44:00 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15733 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 [Bug 15733] Audio Alerts issues in master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:44:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:44:05 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:59:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:59:32 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 20:59:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 19:59:34 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 --- Comment #1 from Kyle M Hall --- Created attachment 47622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47622&action=edit Bug 15735 - Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 21:04:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 20:04:05 +0000 Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |remi.mayrand-provencher at inL | |ibro.com --- Comment #3 from R?mi Mayrand-Provencher --- Test plan : 1)Select an existing patron that doesn't have an oustanding fine 3)Check out a book for this patron 2)Click the "Restriction" tab 3)Click "Add manual restriction" 4)Write any comment and leave expiration date blank 5)Check in the book that you checked out at step 2 6)Validate the warning message. Then you can redo these steps and change the date at step 4 to see different messages at step 6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 21:15:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 20:15:03 +0000 Subject: [Koha-bugs] [Bug 15736] New: Items should be shown in checked-in items list regardless of whether checked out - regression from 14821 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Bug ID: 15736 Summary: Items should be shown in checked-in items list regardless of whether checked out - regression from 14821 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com For some libraries, the checked-in items list operates more as a 'transaction list' and the ability to check in an item to see it's status, or to see which items from a stack have been checked in, etc. is necessary for daily workflow. Bug 14821 removed all items from list that weren't checked out - there should be a system preference to determine this behaviour (and I would argue showing them would be the default) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 21:15:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 20:15:47 +0000 Subject: [Koha-bugs] [Bug 15736] Items should be shown in checked-in items list regardless of whether checked out - regression from 14821 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |nick at bywatersolutions.com, | |oleonard at myacpl.org Priority|P5 - low |P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 21:16:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 20:16:02 +0000 Subject: [Koha-bugs] [Bug 15736] Items should be shown in checked-in items list regardless of whether checked out - regression from 14821 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15551 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 21:16:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 20:16:02 +0000 Subject: [Koha-bugs] [Bug 15551] checked out items not showing on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15736 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 21:16:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 20:16:39 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47622|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 47623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47623&action=edit Bug 15735 - Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 21:16:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 20:16:51 +0000 Subject: [Koha-bugs] [Bug 15551] checked out items not showing on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551 --- Comment #6 from Nick Clemens --- I have opened a new bug for the 'regression' from 14821 - see bug 15736 I believe this bug is unrelated and can be closed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 21:19:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 20:19:00 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 21:36:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 20:36:26 +0000 Subject: [Koha-bugs] [Bug 15551] checked out items not showing on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #7 from Barton Chittenden --- I think that I was conflating two different issues when I opened this bug. Closing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 23:01:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 22:01:47 +0000 Subject: [Koha-bugs] [Bug 14872] Reminder to update SMSnumber when primary phone is updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14872 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 23:01:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 22:01:51 +0000 Subject: [Koha-bugs] [Bug 14872] Reminder to update SMSnumber when primary phone is updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14872 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42841|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia --- Created attachment 47624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47624&action=edit Bug 14872: Reminder to update SMSnumber when primary phone is updated Since SMS number (smsalertnumber) and primary phone are separated, it would be useful to remind patron to update his/her SMS number when making changes to primary phone. This can easily be forgotten, especially in OPAC where the two fields are in different page (opac-memberentry.pl vs opac-messaging.pl). This patch adds a reminder in the "hint"-div that activates whenever phone field gets input (and phone-smsalertnumber do not match). To test: 1. Enable SMSSendDriver and EnhancedMessagingPreferences system preferences 2. Navigate to OPAC -> your personal details 3. Input something to primary phone. You should not be notified at all 4. Navigate to Intra -> Patron -> Edit 5. Repeat step 3 6. Apply patch 7. Refresh Opac -> your personal details and Intra -> Patron -> Edit 8. Input something to primary phone and observe you will be notified to also update SMS number. Signed-off-by: Aleisha Fixed a small merge conflict in opac-memberentry.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 23:29:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 22:29:47 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42627|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia --- Created attachment 47625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47625&action=edit Bug 13757 - Make patron attributes editable in the OPAC (2/2) This patch makes attributes marked as OPAC-editable editable from the OPAC. NOTE: This needs to be extended to work with the modifications system, and thus only works for new patrons. Test plan: 1) Create attributes that cover the spectrum of possible attribute types; repeatable, unique, dropdown, etc. 2) Verify that all of these attributes are correctly validated and saved. Aleisha's update: Fixed a merge conflict and a warn "Argument "" isn't numeric in numeric gt (>) at /usr/share/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt line 336." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 3 23:31:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 22:31:54 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|Needs Signoff |Failed QA --- Comment #7 from Aleisha Amohia --- Hi, I can't sign-off on this Any changes I make to my patron attribute type (ie unchecking the display box or checking the editing box) don't actually change. I'll check or uncheck the box and click save and it will say it's been modified, but if I go in to edit it again my changes were forgotten. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 00:01:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 23:01:50 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 00:01:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 23:01:53 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46564|0 |1 is obsolete| | --- Comment #16 from Aleisha Amohia --- Created attachment 47626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47626&action=edit Bug 15374 - Translatability: Fix issues on OPAC summary page Fix several issues on opac-user.tt with sentences splitted by tags, leading to odd translations. Additionally, fix a broken link that should point to opac-account.pl To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions (Amended to add price formatting in fines tab label) Can see the warning message now :) signing off Signed-off-by: Aleisha Amended to make patches apply and correct BORROWER_INF -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 00:02:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 23:02:10 +0000 Subject: [Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 00:04:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 23:04:31 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #45 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 00:06:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 23:06:44 +0000 Subject: [Koha-bugs] [Bug 15737] New: Patron userid lost during test for duplicate users Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15737 Bug ID: 15737 Summary: Patron userid lost during test for duplicate users Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If you create a new patron record and manually assign a unique cardnumber (userid in the borrowers table) and Koha identifies a possible duplicate record, clicking OK to create the user as a new user causes the manually-assigned userid to be replaced with the user's firstname.lastname. The manually entered userid should be remembered (as long as it is genuinely unique). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 00:08:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 23:08:11 +0000 Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and volumne information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|Failed QA |Needs Signoff --- Comment #5 from Aleisha Amohia --- Setting this back to Needs Signoff so someone else can test because it works fine for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 00:17:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 23:17:46 +0000 Subject: [Koha-bugs] [Bug 15311] Let libraries set text to display when OpacMaintenance = on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 00:17:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 23:17:49 +0000 Subject: [Koha-bugs] [Bug 15311] Let libraries set text to display when OpacMaintenance = on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45719|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia --- Created attachment 47627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47627&action=edit 0001-Bug-15311-Let-libraries-set-text-to-display-when-Opa.patch Added new systempreference OpacMaintenanceNotice. When OpacMaintenance is ON the HTML contents of OpacMaintenanceNotice will be displayed. Enabling OpacMaintenance is all that is required to enable this preference. If OpacMaintenanceNotice is undefined, the default (original) notice will appear when OpacMaintenance is enabled. To test: - Enable OpacMaintenance systempreference - Observe the default maintenance message when OPAC is viewed - Edit OpacMaintenanceNotice systempreference, adding custom HTML - Observe the custom HTML appear on the opac - Remove OpacMaintenanceNotice (mindful of orphaned spaces etc.) - Observe the default opac notice appears in the opac - Disable OpacMaintenance - Observce opac is back online Moving code to atomic update and fixing merge conflict Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 00:43:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 23:43:32 +0000 Subject: [Koha-bugs] [Bug 15738] New: Summary page says item has no fines, but Fines tab says otherwise Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15738 Bug ID: 15738 Summary: Summary page says item has no fines, but Fines tab says otherwise Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Issuing an item to a user gives instant $5 fine. On the OPAC next to the item it says there are no fines attached to the item, but in the Fines tab you can clearly see there are fines. See attachment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 00:44:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Feb 2016 23:44:07 +0000 Subject: [Koha-bugs] [Bug 15738] Summary page says item has no fines, but Fines tab says otherwise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15738 --- Comment #1 from Aleisha Amohia --- Created attachment 47628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47628&action=edit Shows problem on opac-user.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 01:13:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 00:13:13 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #1 from Liz Rea --- should set a flock like we did for zebra. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 01:15:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 00:15:34 +0000 Subject: [Koha-bugs] [Bug 15684] Fix encoding issues with quote upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #9 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 02:28:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 01:28:38 +0000 Subject: [Koha-bugs] [Bug 15622] Spelling mistake in printfreercpt.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15622 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |aleishaamohia at hotmail.com --- Comment #6 from Aleisha Amohia --- Changing back to Signed Off, other instances of this typo are fixed in other bugs which have been Pushed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 02:43:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 01:43:31 +0000 Subject: [Koha-bugs] [Bug 15739] New: Saving a new printer profile does not work Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15739 Bug ID: 15739 Summary: Saving a new printer profile does not work Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org If you leave either the Printer Name or Paper Bin field empty (ie only putting something in one of those fields and leaving the other empty) then you will get a software error upon clicking Save Can't call method "save" without a package or object reference at /home/vagrant/kohaclone/patroncards/edit-profile.pl line 72. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 03:39:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 02:39:35 +0000 Subject: [Koha-bugs] [Bug 15730] 500 error on returns.pl if barcode doesn't exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 03:39:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 02:39:38 +0000 Subject: [Koha-bugs] [Bug 15730] 500 error on returns.pl if barcode doesn't exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47602|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 47629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47629&action=edit [SIGNED-OFF] Bug 15730 - 500 error on returns.pl if barcode doesn't exist If a librarian enters a barcode that does not match an item in the database, a 500 error will be displayed instead of the "No item with barcode" message. Test Plan: 1) Enter an invalid barcode on returns.pl 2) Note the 500 error 3) Apply this patch 4) Repeat setp 1 5) Note the "No item with barcode" message Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 03:49:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 02:49:36 +0000 Subject: [Koha-bugs] [Bug 15739] Saving a new printer profile does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15739 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Chris Nighswonger --- Granted the error trapping here and feedback to the user leaves much to be desired, however, the behavior is as expected. Looking here: http://tinyurl.com/z3t845z will show that what we do is run a parameter check when asked to create a new Profile object. If all required parameters are not passed in, rather than returning a new object, -1 is returned which causes the attempt to invoke the save method to fail. Its old code, and I never go back to adding proper error trapping. It really should not return -1 in any case. In light of that, this bug should probably be closed RESOLVED WORKSFORME and another opened which addresses error trapping in the labels/patroncards code in general. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 04:57:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 03:57:05 +0000 Subject: [Koha-bugs] [Bug 15740] New: Add Ability to Group Item Types in Staff Advanced Search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15740 Bug ID: 15740 Summary: Add Ability to Group Item Types in Staff Advanced Search Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org Bug 10937 added ability to group item types in advanced search. This only appears to work in the OPAC so far, unless I'm missing something. Could it be added for the staff side advanced search? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 04:57:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 03:57:05 +0000 Subject: [Koha-bugs] [Bug 10937] Advanced search: Hide itemtypes from search form & Group itemtypes together into one search option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15740 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 06:18:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 05:18:44 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 --- Comment #33 from Mason James --- (In reply to Mason James from comment #27) > Hmm, I think I've found a small bug here, patch coming... update: i added the patch to a new SEC bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15035 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 06:20:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 05:20:06 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 --- Comment #34 from Mason James --- (In reply to David Cook from comment #28) > I think that this was working for a time, but it appears that some bots may > have wised up... > hiya, are you running this follow-up patch? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15035 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 06:42:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 05:42:43 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mirko at abunchofthings.net --- Comment #3 from Mirko Tietgen --- fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 07:01:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 06:01:39 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 --- Comment #4 from John.Seymour at nal.gov.au --- Created attachment 47630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47630&action=edit Patch to control.ini to add or dependency to libapache2-mpm-itk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 07:03:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 06:03:44 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 --- Comment #5 from John.Seymour at nal.gov.au --- This patch fixes the dependency problem by adding libapache2-mpm-itk as an or dependency for apache2-mpm-itk. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 07:08:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 06:08:29 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #207 from Mirko Tietgen --- Created attachment 47631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47631&action=edit libtemplate-stash-autoescaping-perl_0.0303-1_all.deb I built a package in Jessie, maybe it is useful for others too. It's attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 07:46:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 06:46:43 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 07:50:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 06:50:43 +0000 Subject: [Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 07:53:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 06:53:07 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 07:55:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 06:55:22 +0000 Subject: [Koha-bugs] [Bug 13718] Paying fines references non-existent function on submit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13718 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 08:01:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 07:01:22 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #4 from Mason James --- (In reply to H?ctor Eduardo Castro Avalos from comment #3) > (In reply to Nick Clemens from comment #2) > > I'll fix it up as soon as possible, Nick. > > Thanks for testing. Hi, I recently tested this patch on Koha-3.20.6, the patch applied and works well! :) But I discovered a small display bug, after this patch... The 264 subfields are not repeated, as expected https://www.oclc.org/bibformats/en/2xx/264.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 08:04:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 07:04:46 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 --- Comment #5 from Katrin Fischer --- Hi Mason, can you give an example? I noticed on our 3.22 test installaton that the label seems to be repeated for each 264 without this patch already. Wonder if this is the same issue you noticed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 08:25:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 07:25:54 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 --- Comment #6 from Mason James --- Created attachment 47632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47632&action=edit a pic of 264x display bug in OPAC, where repeated 264x subfields are not displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 08:28:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 07:28:54 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 --- Comment #7 from Mason James --- (In reply to Katrin Fischer from comment #5) > Hi Mason, can you give an example? I noticed on our 3.22 test installaton > that the label seems to be repeated for each 264 without this patch already. > Wonder if this is the same issue you noticed? oops... i'm testing on a 3.20.6 Koha here. i'll try to confirm on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 09:17:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 08:17:52 +0000 Subject: [Koha-bugs] [Bug 15726] columns_settings.pl: add option for circulation rules column configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|normal |enhancement Version|3.22 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 09:21:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 08:21:13 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42427|0 |1 is obsolete| | --- Comment #54 from Julian Maurice --- Created attachment 47633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47633&action=edit Bug 7957: Routing lists enhancements - Manage several routing list per subscription - Export a routing list as CSV Test plan: Run the updatedatabase.pl script Existing routing lists should have been imported in a routing list named 'import' >From the serials-home.pl page: 1 Make a search, in the results list you have a column 'Actions' that should contain a "New/Edit routing list" link" (if not, consider setting RoutingSerials syspref). If the subscription doesn't have a routing list, you should have a 'New routing list' link. Otherwise you have an 'Edit routing lists (X)' link, where X is the number of routing lists. 2 Choose a subscription which have no routing lists and click on 'New routing list' 3 You are on the routing list creation page. Enter a title for the routing list and click on 'Save'. 4 The routing list has been created and now you are on the routing list modification page. The behaviour of this page is quite the same as before. A sensible change is that reordering borrowers doesn't reload the page each time you make a change. 5 Click on 'Save' to finish routing list modifications. 6 Now you are on the routing lists management page. You can edit a routing list by clicking on its title, preview it, export it, and delete it by clicking on the corresponding link. 7 Click on 'Preview'. 8 You will be asked to choose a serial. Pick the one you want to print the routing list for and click on 'Continue'. 9 If RoutingListAddReserves is OFF, the routing list is displayed and you just have to click on 'Print'. If the syspref is ON, you will have to click on 'Confirm and print', an alert will show telling you that holds will be placed on the serial you chose. Click 'OK' and you will be able to print the slip. Now check if the holds have been placed. (It works only if an item is attached to this serial). 10 Go back to the routing lists management page (routinglists.pl) and click on 'Export'. Download the CSV and check that it contains correct data. >From serials-collection.pl page: 11 In the serials list, click on 'Print list'. 12 You will be asked to choose a routing list. Pick one and click on 'Continue'. 13 ... (same behaviour as above) Try to add and delete routing lists to show if links are correctly updated in serials-home.pl, serials-collection.pl and subscription-detail.pl Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 09:21:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 08:21:18 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42428|0 |1 is obsolete| | --- Comment #55 from Julian Maurice --- Created attachment 47634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47634&action=edit Bug 7957: Add unit tests for new subroutines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 09:21:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 08:21:23 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42429|0 |1 is obsolete| | --- Comment #56 from Julian Maurice --- Created attachment 47635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47635&action=edit Bug 7957: Redirect after creating a new routing list This avoids creating the same list multiple times when reloading the page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 09:22:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 08:22:03 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #57 from Julian Maurice --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 09:26:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 08:26:22 +0000 Subject: [Koha-bugs] [Bug 15733] Audio Alerts issues in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 09:26:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 08:26:25 +0000 Subject: [Koha-bugs] [Bug 15733] Audio Alerts issues in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 --- Comment #1 from Jonathan Druart --- Created attachment 47636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47636&action=edit Bug 15733: Fix audio alerts Bug 13618 has broken the audio alerts. Test plan: Enable the AudioAlerts pref Check an item in Without this patch, there is a js error With this patch applied, the error is gone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 09:27:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 08:27:38 +0000 Subject: [Koha-bugs] [Bug 15733] Audio Alerts issues in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13618, 11431 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 [Bug 11431] Custom notification sounds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 09:27:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 08:27:38 +0000 Subject: [Koha-bugs] [Bug 11431] Custom notification sounds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15733 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 [Bug 15733] Audio Alerts issues in master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 09:27:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 08:27:38 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15733 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 [Bug 15733] Audio Alerts issues in master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 09:40:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 08:40:20 +0000 Subject: [Koha-bugs] [Bug 14821] Don't show item in checked in list, when it wasn't checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15736 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 [Bug 15736] Items should be shown in checked-in items list regardless of whether checked out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 09:40:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 08:40:20 +0000 Subject: [Koha-bugs] [Bug 15736] Items should be shown in checked-in items list regardless of whether checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Items should be shown in |Items should be shown in |checked-in items list |checked-in items list |regardless of whether |regardless of whether |checked out - regression |checked out |from 14821 | Depends on| |14821 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 [Bug 14821] Don't show item in checked in list, when it wasn't checked in -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 09:40:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 08:40:43 +0000 Subject: [Koha-bugs] [Bug 15736] Items should be shown in checked-in items list regardless of whether checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 --- Comment #1 from Jonathan Druart --- Do you have a suggestion for the pref name? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 10:02:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 09:02:14 +0000 Subject: [Koha-bugs] [Bug 15718] Need more information for items that don't successfully batch checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15718 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- To explain: I have checked out my_barcode_981 #not for loan FDSQQSDFQSD # does not exist my_barcode_9810 my_barcode_9810 On the first screen, I get: Batch checkout confirmation for Joubu (42) Barcode Title Information [x] my_barcode_981 my_title_98, by donald my_barcode_981 Item is normally not for loan . FDSQQSDFQSD The barcode was not found FDSQQSDFQSD 00113102951663 Une cuisine grande comme le monde 00113102951663 [x] my_barcode_9810 my_title_98, by donald my_barcode_9810 Too many checked out. Please confirm checkout Line 3 (00113102951663) has been checked out at this point Line 2 is not selectable: the barcode does not exist. So yes, for the next step, we will process only the 2 items that have failed (we force the checkout). On the next screen, we will get: Barcode Title Information my_barcode_981 my_title_98, by donald my_barcode_981 my_barcode_9810 my_title_98, by donald my_barcode_9810 I agree it's not obvious, but I don't know what I could do to clarify the screen. Any suggestions? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 10:02:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 09:02:59 +0000 Subject: [Koha-bugs] [Bug 15718] Need more information for items that don't successfully batch checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15718 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master Depends on| |11759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 [Bug 11759] Batch checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 10:02:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 09:02:59 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15718 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15718 [Bug 15718] Need more information for items that don't successfully batch checkout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 10:18:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 09:18:49 +0000 Subject: [Koha-bugs] [Bug 15730] 500 error on returns.pl if barcode doesn't exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 10:18:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 09:18:56 +0000 Subject: [Koha-bugs] [Bug 15730] 500 error on returns.pl if barcode doesn't exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47629|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 47637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47637&action=edit Bug 15730 - 500 error on returns.pl if barcode doesn't exist If a librarian enters a barcode that does not match an item in the database, a 500 error will be displayed instead of the "No item with barcode" message. Test Plan: 1) Enter an invalid barcode on returns.pl 2) Note the 500 error 3) Apply this patch 4) Repeat setp 1 5) Note the "No item with barcode" message Signed-off-by: Aleisha Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 10:19:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 09:19:21 +0000 Subject: [Koha-bugs] [Bug 15730] 500 error on returns.pl if barcode doesn't exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14828 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 [Bug 14828] Move the item types related code to Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 10:19:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 09:19:21 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15730 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730 [Bug 15730] 500 error on returns.pl if barcode doesn't exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 11:21:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 10:21:07 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #3 from Jonathan Druart --- *** Bug 15733 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 11:21:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 10:21:07 +0000 Subject: [Koha-bugs] [Bug 15733] Audio Alerts issues in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 15734 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 11:51:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 10:51:18 +0000 Subject: [Koha-bugs] [Bug 15741] New: Incorrect rounding in total fines calculations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741 Bug ID: 15741 Summary: Incorrect rounding in total fines calculations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: abl at biblos.pk.edu.pl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Our librarians discovered recently that recording payments for some specific fine amounts (64.60, for example) are not working properly - they are getting errors like: You must pay a value less than or equal to 64.60 It's not just 64.60, same thing happens for: 1.14 1.36 1.39 1.57 1.59 1.61 1.64 1.66 1.68 1.82 1.84 1.86 1.89 1.91 1.93 2.01 2.03 2.28 2.47 2.53 2.72 2.78 2.97 ... 32.30 64.10 64.60 65.10 128.20 128.70 129.20 129.70 130.20 130.70 ... and so on. This error seems to be caused by incorrect rounding in C4::Members::GetMemberAccountRecords(). To replicate: 1) Create manual invoice for 64.60 (or 1.14, 1.36, ...) 2) Try to pay it using "Pay amount" or "Pay selected" buttons As a temporary workaround, one may: - pay such amount in 2+ steps (eg. 64.00 + 0.60) - pay individual fines using 'Pay' button[s] on the left but, at first glance at least, an underlying problem for this error may possibly have some more severe consequences than just minor troubles with making payments - eg., if patron has 12+ fines (or credits) of such kind, total account balance calculation may be wrong as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 11:54:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 10:54:40 +0000 Subject: [Koha-bugs] [Bug 15741] Incorrect rounding in total fines calculations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=3166 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 11:54:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 10:54:40 +0000 Subject: [Koha-bugs] [Bug 3166] Fines are summing off by 1 penny due to rounding issue when summing. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3166 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15741 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 11:55:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 10:55:07 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #9 from Julian Maurice --- Actually those patches are needed for bug 15358. Reopening... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 11:55:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 10:55:08 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Bug 15358 depends on bug 15578, which changed state. Bug 15578 Summary: Authority tests skip and hide a bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 11:55:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 10:55:16 +0000 Subject: [Koha-bugs] [Bug 15741] Incorrect rounding in total fines calculations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=3379 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 11:55:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 10:55:16 +0000 Subject: [Koha-bugs] [Bug 3379] Rounding error for fines total in C4::Members::GetMemberAccountRecords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3379 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15741 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 11:55:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 10:55:19 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 11:55:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 10:55:29 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 11:55:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 10:55:37 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 11:55:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 10:55:45 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 12:02:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 11:02:03 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #10 from Julian Maurice --- Created attachment 47638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47638&action=edit [3.22.x] Bug 15578: Insert authority records before processing tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 12:02:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 11:02:08 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #11 from Julian Maurice --- Created attachment 47639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47639&action=edit [3.22.x] Bug 15578: Make sure all params will be taken into account when instantiating The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. Test plan: Apply the first patch, launch tests => Fail Apply the second patch, launch tests => \o/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 12:04:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 11:04:19 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #12 from Julian Maurice --- Original patches don't apply well on 3.22.x, so here are the patches for 3.22. If someone else can test and signoff them, that would be great :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 12:15:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 11:15:04 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #46 from Julian Maurice --- Created attachment 47640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47640&action=edit [3.22.x] Bug 15358: Fix authorities merge Bug 8064 (Merge several biblio records) change some code used in both biblios and authorities merge tool without updating the authorities merge tool. This patch fixes that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 12:16:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 11:16:01 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #47 from Julian Maurice --- Patch for 3.22.x is slightly different from original patch. I would like to see it tested on 3.22 before I push it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 12:17:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 11:17:01 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #48 from Julian Maurice --- Note that it requires [3.22.x] patches from bug 15578 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 12:22:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 11:22:58 +0000 Subject: [Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 12:29:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 11:29:19 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 [Bug 15734] Audio Alerts broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 12:29:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 11:29:19 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 12:30:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 11:30:03 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 12:41:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 11:41:11 +0000 Subject: [Koha-bugs] [Bug 15684] Fix encoding issues with quote upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #10 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 13:41:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 12:41:44 +0000 Subject: [Koha-bugs] [Bug 15718] Need more information for items that don't successfully batch checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15718 --- Comment #2 from Heather Braum --- Johnathan, what about something as simple as adding a table title for that screen, "items that didn't check out" or in the information column for each item, "item didn't check out?" Is that possible? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 13:48:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 12:48:40 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Items should be shown in |Add a preference to control |checked-in items list |whether all items should be |regardless of whether |shown in checked-in items |checked out |list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 14:19:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 13:19:53 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47640|0 |1 is obsolete| | --- Comment #49 from Josef Moravec --- Created attachment 47641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47641&action=edit [Signed-off] Bug 15358: Fix authorities merge Bug 8064 (Merge several biblio records) change some code used in both biblios and authorities merge tool without updating the authorities merge tool. This patch fixes that. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 14:20:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 13:20:32 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47641|[Signed-off] Bug 15358: Fix |[Signed-off] [3.22.x] Bug description|authorities merge |15358: Fix authorities | |merge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 14:24:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 13:24:36 +0000 Subject: [Koha-bugs] [Bug 15742] New: Unnecessary loop in j2a cronjob Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 Bug ID: 15742 Summary: Unnecessary loop in j2a cronjob Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org If no branchcode is given, all the libraries are retrieved and the same query (so without using the libraries loop) is executed for each library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 14:27:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 13:27:35 +0000 Subject: [Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 14:27:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 13:27:37 +0000 Subject: [Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 --- Comment #1 from Jonathan Druart --- Created attachment 47642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47642&action=edit Bug 15742: Remove unnecessary loop in j2a cronjob If no branchcode is given, all the libraries are retrieved and the same query (so without using the libraries loop) is executed for each library. Test plan: Use the j2a.pl cronjob to change the category of a child patron If a branchcode is passed to the script, only the children from this branchcode should be updated. But if it is not passed, all children of the DB should be updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 15:00:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 14:00:43 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 --- Comment #4 from Kyle M Hall --- (In reply to Mirko Tietgen from comment #3) > fatal: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc). Forgot to mark this bug as dependent on 15734! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 15:27:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 14:27:14 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 --- Comment #8 from H?ctor Eduardo Castro Avalos --- Hi All I will try to work in this patch as soon as possible. I need to do a little of time. Thank you for keep testing, Mason. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 15:47:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 14:47:41 +0000 Subject: [Koha-bugs] [Bug 15731] C4::Reports::Guided::build_authorised_value_list is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 15:47:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 14:47:43 +0000 Subject: [Koha-bugs] [Bug 15731] C4::Reports::Guided::build_authorised_value_list is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47603|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47643&action=edit [SIGNED-OFF]Bug 15731: Remove C4::Reports::Guided::build_authorised_value_list This subroutine has been added by commit 42acfbf75b7bb4ee53c6a6f035e258a0b522ce10 Bug 7993: Save reports with Group/Subgroup hierarchy But it has never been used (or git grep cheats me). Test plan: 1/ git grep build_authorised_value_list should not return any result 2/ Create a report, execute it Everything should work fine. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 15:56:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 14:56:25 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 15:56:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 14:56:28 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47621|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 47644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47644&action=edit [SIGNED-OFF]Bug 15734: Audio Alerts broken In master there is a JSON error thrown when AudioAlerts are enabled. This is caused by changes in master from bug 13618. Test Plan: 1) Enable audio alerts 2) Note audio alerts don't work 3) Apply this patch 4) Note audio alerts now work Signed-off-by: Hector Castro Works as described -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 16:05:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 15:05:25 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47623|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 47645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47645&action=edit [SIGNED-OFF]Bug 15735: Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert Signed-off-by: Hector Castro Bug 15734 applied on top. Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 16:05:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 15:05:23 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 16:29:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 15:29:21 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 17:10:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 16:10:40 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 --- Comment #25 from Jonathan Druart --- (In reply to Kyle M Hall from comment #22) > No other patches in process modify member-password.pl, now would be > a great time to tidy it! Yes, bug 15407 was there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 17:16:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 16:16:57 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47098|0 |1 is obsolete| | Attachment #47099|0 |1 is obsolete| | Attachment #47100|0 |1 is obsolete| | Attachment #47101|0 |1 is obsolete| | Attachment #47102|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 47646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47646&action=edit Bug 15407: Koha::Patron::Categories - remove sql queries in some pl and pm This patch replaces sql queries done in some pl script and in C4::Reports::Guided. Since we have now a Koha::Patron::Categories module, we should use it where it is possible. Test plan: - Prerequisite: Be sure you have several patron categories created, with different option enabled, and limit some to certain libraries. - On the 'Circulation and fine rules' admin page (admin/smart-rules.pl), all the patron categories should be displayed (even the ones limited to another library), ordered by description. Try to add/update existing rules. - On the overdue rules page (tools/overduerules.pl), all the patron categories with overduenoticerequired set should be displayed. Try to add/update existing rules. - On the following reports: reports/borrowers_stats.pl reports/issues_avg_stats.pl The patron categories should be displayed. Note that there is an inconsistency with these 2 reports: the patron categories limited to other libraries are displayed on them, when they are not on the other reports. This should certainly be fixed (on another bug report). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 17:17:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 16:17:01 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #19 from Jonathan Druart --- Created attachment 47647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47647&action=edit Bug 15407: Koha::Patron::Categories - replace C4::Category->all The C4::Category module contained only 1 method to return the patron categories available for the logged in user. The new method Koha::Patron::Categories->search_limited does exactly the same thing (see tests) and must be used in place of it. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. - On the 'Item circulation alerts' admin page (admin/item_circulation_alerts.pl), modify the settings for check-in and checkout (NOTE: Should not we display all patron categories on this page? If yes, it must be done in another bug report to ease backporting it). - Search for patrons in the admin (budget) and acquisition (order) module. - On the patron home page (search form in the header) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 17:17:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 16:17:08 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #21 from Jonathan Druart --- Created attachment 47649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47649&action=edit Bug 15407: Koha::Patron::Categories - replace GetBorrowercategoryList C4::Members::GetBorrowercategoryList returned all the patron categories, ordered by description. This can be done using the search method of the Koha::Patron::Categories module. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by description. - On the "patron attribute types" admin page (admin/patron-attr-types.pl). - On the "Batch patron deletion/anonymization" (tools/cleanborrowers.pl), the dropdown list should be filled correctly. - On the import patron tool - On the following report: reports/reserves_stats.pl Confirm that the patron categories are displayed and that the report still works as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 17:17:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 16:17:11 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #22 from Jonathan Druart --- Created attachment 47650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47650&action=edit Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType This unnecessary complicated subroutine returned an arrayref and an hashref of the patron categories available for the logged in user, for a given category_type, ordered by categorycode. This can now be done with the search_limited method. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by categorycode. - Add/edit a patron, change his/her patron category value. - On the 3 following reports: reports/bor_issues_top.pl reports/borrowers_out.pl reports/cat_issues_top.pl The display for these 3 reports are different than the 2 from the first patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by categorycode and the ones limited to other libraries are not displayed (should certainly be fixed). Note that the big part of this patch has already been tested before (update child related: CATCODE_MULTI). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 17:17:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 16:17:04 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #20 from Jonathan Druart --- Created attachment 47648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47648&action=edit Bug 15407: Koha::Patron::Categories - replace GetBorrowercategory The purpose of C4::Members::GetBorrowercategory was to return the patron category for a given categorycode. This can be done easily with the Koha::Patron::Categories->find method. Test plan: - Same prerequisite as before - Edit a guarantor and confirm the information will be updated for his/her guarantee(s). - Update a child to adult patron (Note: Should not we hide the patron categories limited to others libraries? If yes, it must be done on another bug report). There is a special behavior if there is only 1 adult category, the user does not need to select a category. So the same as before with only 1 adult patron category. - Import a patron with a category_code which does not exist. You should be warned. - Modify some patron using the batch patron modification tool. The patron category descriptions should correctly be displayed. Note that the overduerules page has already been tested in a previous patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 17:17:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 16:17:26 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #23 from Jonathan Druart --- Just a rebase against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 17:29:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 16:29:10 +0000 Subject: [Koha-bugs] [Bug 10708] make fine receipt customizable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7595 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 17:29:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 16:29:10 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10708 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 17:30:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 16:30:55 +0000 Subject: [Koha-bugs] [Bug 10708] make fine receipt customizable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 17:30:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 16:30:55 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 [Bug 10708] make fine receipt customizable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 17:50:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 16:50:53 +0000 Subject: [Koha-bugs] [Bug 10708] make fine receipt customizable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #4 from vimal kumar --- sure it is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 17:52:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 16:52:19 +0000 Subject: [Koha-bugs] [Bug 15743] New: Allow plugins to embed Perl modules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15743 Bug ID: 15743 Summary: Allow plugins to embed Perl modules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Actually if a plugin comes with several .pm files, they are all treated as separate plugins, and Koha::Plugins die if one of these modules doesn't contain a 'new' subroutine. Can't locate object method "new" via package "Koha::Plugin::XXX::YYY::..." (perhaps you forgot to load "Koha::Plugin::XXX::YYY::..."?) at /home/koha/src/Koha/Plugins.pm line 66. It may be useful to have several .pm files to organize code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 17:53:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 16:53:22 +0000 Subject: [Koha-bugs] [Bug 15743] Allow plugins to embed Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15743 --- Comment #1 from Julian Maurice --- Created attachment 47651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47651&action=edit Bug 15743: Allow plugins to embed Perl modules This patch allows plugins to embed Perl modules by ignoring Perl modules in plugins directory that don't inherit from Koha::Plugins::Base -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 17:53:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 16:53:31 +0000 Subject: [Koha-bugs] [Bug 15743] Allow plugins to embed Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15743 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 18:00:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 17:00:09 +0000 Subject: [Koha-bugs] [Bug 15743] Allow plugins to embed Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15743 --- Comment #2 from Julian Maurice --- Test plan: 0. Enable plugins 1. Create the smallest valid Perl module (the 'package' line and the '1;' line are enough) in your plugins directory 2. In Koha, go to /cgi-bin/koha/plugins/plugins-home.pl, you should see the error message 3. Apply patch 4. Refresh /cgi-bin/koha/plugins/plugins-home.pl, you should have no error messages, and no new plugins in the table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 18:09:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 17:09:46 +0000 Subject: [Koha-bugs] [Bug 11556] Send any notice to any patron (or all patrons) on demand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11556 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 18:43:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 17:43:08 +0000 Subject: [Koha-bugs] [Bug 15744] New: GlobalSys: UsageStatsLibraryType German Text 2x "Firmenbibliothek" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15744 Bug ID: 15744 Summary: GlobalSys: UsageStatsLibraryType German Text 2x "Firmenbibliothek" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: mail at norbert-baum.de QA Contact: testopia at bugs.koha-community.org The Global Sys Parameter UsageStatsLibraryType have two same german items for different english items "Firmenbibliothek" for "corporate" and "govermment" But Govermment is wrong thx norbert -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 18:44:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 17:44:06 +0000 Subject: [Koha-bugs] [Bug 15744] GlobalSys: UsageStatsLibraryType German Text 2x "Firmenbibliothek" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15744 Norbert Baum changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |3.22 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 18:44:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 17:44:49 +0000 Subject: [Koha-bugs] [Bug 15744] GlobalSys: UsageStatsLibraryType German Text 2x "Firmenbibliothek" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15744 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 18:46:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 17:46:47 +0000 Subject: [Koha-bugs] [Bug 15744] GlobalSys: UsageStatsLibraryType German Text 2x "Firmenbibliothek" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15744 Norbert Baum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mail at norbert-baum.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 20:29:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 19:29:33 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47271|0 |1 is obsolete| | --- Comment #13 from Marc V?ron --- Created attachment 47652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47652&action=edit 14930 - Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature To Test - Borrower has some fines and checkouts - Leave OPACFineNoRenewals empty/blank - Try to renew items in the OPAC - notice error message - Add a big value to OpacFineNoRenewals - notice renewals work Leaving the OPACFineNoRenewals empty will disable the feature. Patch works as expected.(Amended to format the commit message and to remove a warn on line 112 / MV) Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 20:30:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 19:30:33 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47466|0 |1 is obsolete| | --- Comment #14 from Marc V?ron --- Created attachment 47653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47653&action=edit Bug 14930 [QA Followup] - Allow OpacFineNoRenewals to be 0 Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 20:31:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 19:31:00 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 20:38:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 19:38:32 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 --- Comment #15 from Marc V?ron --- (...) > The template already deals with that. I think the translatability should be > in a separate bug since we don't need to modify the template for the fines > amount. Ah, there was already a bug for the translatability: Bug 15374 - Translatability: Fix issues on OPAC summary page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 20:39:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 19:39:27 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #17 from Marc V?ron --- Does not apply... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 20:41:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 19:41:35 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 20:42:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 19:42:30 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14930 --- Comment #18 from Marc V?ron --- Should be fixed on top of 14930 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 20:42:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 19:42:30 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15374 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 [Bug 15374] Translatability: Fix issues on OPAC summary page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 20:45:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 19:45:05 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 20:45:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 19:45:07 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 --- Comment #1 from Kyle M Hall --- Created attachment 47654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47654&action=edit Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each other It appears that the LocalHoldsPriority feature and the Holds Queue are fundamentally at odds with each other. The problem appears to be that both are attempting to choose the best way to fill holds. When you are using the holds queue and you check in an item that has been selected by the holds queue builder, that part of Koha where the LocalHoldsPriority feature lives doesn't get to see all the holds in order to pick the best one. Instead only the hold selected by the holds queue builder is returned so to the LocalHoldsPriority feature, that is only one hold to pick from! Test Plan: 1) Apply this patch 2) prove t/db_dependent/HoldsQueue.t 3) All tests should pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 20:54:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 19:54:32 +0000 Subject: [Koha-bugs] [Bug 13420] sorting on volume number is not sorting right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 20:58:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 19:58:04 +0000 Subject: [Koha-bugs] [Bug 15737] Patron userid lost during test for duplicate users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15737 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 21:00:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 20:00:03 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47626|0 |1 is obsolete| | --- Comment #19 from Marc V?ron --- Comment on attachment 47626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47626 Bug 15374 - Translatability: Fix issues on OPAC summary page Oh, the latest patch contains merge markers (<<<<<<< HEAD etc) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 21:01:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 20:01:08 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46564|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 21:17:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 20:17:03 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47654|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 47655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47655&action=edit Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each other It appears that the LocalHoldsPriority feature and the Holds Queue are fundamentally at odds with each other. The problem appears to be that both are attempting to choose the best way to fill holds. When you are using the holds queue and you check in an item that has been selected by the holds queue builder, that part of Koha where the LocalHoldsPriority feature lives doesn't get to see all the holds in order to pick the best one. Instead only the hold selected by the holds queue builder is returned so to the LocalHoldsPriority feature, that is only one hold to pick from! Test Plan: 1) Apply this patch 2) prove t/db_dependent/HoldsQueue.t 3) All tests should pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 21:58:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 20:58:27 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46564|0 |1 is obsolete| | --- Comment #20 from Marc V?ron --- Created attachment 47656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47656&action=edit Bug 15374 - Translatability: Fix issues on OPAC summary page Fix several issues on opac-user.tt with sentences splitted by tags, leading to odd translations. Additionally, fix a broken link that should point to opac-account.pl To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions (Amended to add price formatting in fines tab label) Can see the warning message now :) signing off Signed-off-by: Aleisha (Amended to make patches apply, see comment #12) Signed-off-by: Aleisha (Amended to make it apply and to fix BORROWER.INF -> BORROWER->INFO. Needs new sign-off. / MV) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 21:59:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 20:59:21 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 22:16:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 21:16:14 +0000 Subject: [Koha-bugs] [Bug 14406] When adding messages in patron account, only first name is shown in pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14406 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 22:18:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 21:18:51 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #21 from Aleisha Amohia --- Applying: Bug 15374 - Translatability: Fix issues on OPAC summary page fatal: sha1 information is lacking or useless (opac/opac-user.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 15374 - Translatability: Fix issues on OPAC summary page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 22:21:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 21:21:24 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 22:23:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 21:23:22 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 22:26:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 21:26:18 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #11 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 22:30:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 21:30:07 +0000 Subject: [Koha-bugs] [Bug 15628] Remove get_branchinfos_of vestiges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15628 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 22:39:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 21:39:34 +0000 Subject: [Koha-bugs] [Bug 15743] Allow plugins to embed Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15743 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 22:39:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 21:39:36 +0000 Subject: [Koha-bugs] [Bug 15743] Allow plugins to embed Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15743 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47651|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 47657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47657&action=edit [SIGNED-OFF] Bug 15743: Allow plugins to embed Perl modules This patch allows plugins to embed Perl modules by ignoring Perl modules in plugins directory that don't inherit from Koha::Plugins::Base TEST PLAN --------- 1) Edit koha-conf.xml to have enable_plugins set to 1, and the pluginsdir set to a particular path. 2) Create a dummy plugin file. (e.g. {that path}/Koha/Plugin/Kaboom.pm) --- BEGIN Kaboom.pm --- package Koha::Plugin::Kaboom; use Modern::Perl; our $VERSION = '1'; 1; --- END Kaboom.pm --- 3) Sign in to staff client 4) Reports -> Report plugins -- commented line version explodes. 5) Apply patch 6) Reports -> Report plugins -- commented line version works. -- the ?method= portion in the address bar prevents you from seeing that the plugin is actually considered, because various methods are not defined. Delete that portion of the URL, and you should see a thin empty second row appear. 7) run koha qa tests Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 22:50:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 21:50:52 +0000 Subject: [Koha-bugs] [Bug 15574] Better wording for error message when adding tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15574 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 23:00:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 22:00:43 +0000 Subject: [Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 --- Comment #2 from M. Tompsett --- Comment on attachment 47642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47642 Bug 15742: Remove unnecessary loop in j2a cronjob Review of attachment 47642: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15742&attachment=47642) ----------------------------------------------------------------- YIKES! Good catch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 23:35:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 22:35:31 +0000 Subject: [Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 --- Comment #3 from M. Tompsett --- Comment on attachment 47642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47642 Bug 15742: Remove unnecessary loop in j2a cronjob Review of attachment 47642: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15742&attachment=47642) ----------------------------------------------------------------- ::: misc/cronjobs/j2a.pl @@ -178,4 @@ > } else { print "Updated $res patrons\n"; } > } else { # branch was not supplied, processing all branches > $verbose and print "Looking in all branches for patrons to update from $fromcat to $tocat that were born before $itsyourbirthday\n"; > - foreach my $branchcode (@branches) { What's scarier is I added: print "PROCESSING $branchcode\n"; "PROCESSING HASH(0x3645b50)" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 23:37:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 22:37:21 +0000 Subject: [Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 23:37:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 22:37:24 +0000 Subject: [Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47642|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 47658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47658&action=edit [SIGNED-OFF] Bug 15742: Remove unnecessary loop in j2a cronjob If no branchcode is given, all the libraries are retrieved and the same query (so without using the libraries loop) is executed for each library. Test plan: Use the j2a.pl cronjob to change the category of a child patron If a branchcode is passed to the script, only the children from this branchcode should be updated. But if it is not passed, all children of the DB should be updated. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 23:38:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 22:38:55 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 23:38:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 22:38:59 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47633|0 |1 is obsolete| | --- Comment #58 from Aleisha Amohia --- Created attachment 47659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47659&action=edit [SIGNED-OFF] Bug 7957: Routing lists enhancements - Manage several routing list per subscription - Export a routing list as CSV Test plan: Run the updatedatabase.pl script Existing routing lists should have been imported in a routing list named 'import' >From the serials-home.pl page: 1 Make a search, in the results list you have a column 'Actions' that should contain a "New/Edit routing list" link" (if not, consider setting RoutingSerials syspref). If the subscription doesn't have a routing list, you should have a 'New routing list' link. Otherwise you have an 'Edit routing lists (X)' link, where X is the number of routing lists. 2 Choose a subscription which have no routing lists and click on 'New routing list' 3 You are on the routing list creation page. Enter a title for the routing list and click on 'Save'. 4 The routing list has been created and now you are on the routing list modification page. The behaviour of this page is quite the same as before. A sensible change is that reordering borrowers doesn't reload the page each time you make a change. 5 Click on 'Save' to finish routing list modifications. 6 Now you are on the routing lists management page. You can edit a routing list by clicking on its title, preview it, export it, and delete it by clicking on the corresponding link. 7 Click on 'Preview'. 8 You will be asked to choose a serial. Pick the one you want to print the routing list for and click on 'Continue'. 9 If RoutingListAddReserves is OFF, the routing list is displayed and you just have to click on 'Print'. If the syspref is ON, you will have to click on 'Confirm and print', an alert will show telling you that holds will be placed on the serial you chose. Click 'OK' and you will be able to print the slip. Now check if the holds have been placed. (It works only if an item is attached to this serial). 10 Go back to the routing lists management page (routinglists.pl) and click on 'Export'. Download the CSV and check that it contains correct data. >From serials-collection.pl page: 11 In the serials list, click on 'Print list'. 12 You will be asked to choose a routing list. Pick one and click on 'Continue'. 13 ... (same behaviour as above) Try to add and delete routing lists to show if links are correctly updated in serials-home.pl, serials-collection.pl and subscription-detail.pl Signed-off-by: Paola Rossi Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 23:42:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 22:42:10 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47659|0 |1 is obsolete| | --- Comment #59 from Aleisha Amohia --- Created attachment 47660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47660&action=edit [SIGNED-OFF] Bug 7957: Routing lists enhancements - Manage several routing list per subscription - Export a routing list as CSV Test plan: Run the updatedatabase.pl script Existing routing lists should have been imported in a routing list named 'import' >From the serials-home.pl page: 1 Make a search, in the results list you have a column 'Actions' that should contain a "New/Edit routing list" link" (if not, consider setting RoutingSerials syspref). If the subscription doesn't have a routing list, you should have a 'New routing list' link. Otherwise you have an 'Edit routing lists (X)' link, where X is the number of routing lists. 2 Choose a subscription which have no routing lists and click on 'New routing list' 3 You are on the routing list creation page. Enter a title for the routing list and click on 'Save'. 4 The routing list has been created and now you are on the routing list modification page. The behaviour of this page is quite the same as before. A sensible change is that reordering borrowers doesn't reload the page each time you make a change. 5 Click on 'Save' to finish routing list modifications. 6 Now you are on the routing lists management page. You can edit a routing list by clicking on its title, preview it, export it, and delete it by clicking on the corresponding link. 7 Click on 'Preview'. 8 You will be asked to choose a serial. Pick the one you want to print the routing list for and click on 'Continue'. 9 If RoutingListAddReserves is OFF, the routing list is displayed and you just have to click on 'Print'. If the syspref is ON, you will have to click on 'Confirm and print', an alert will show telling you that holds will be placed on the serial you chose. Click 'OK' and you will be able to print the slip. Now check if the holds have been placed. (It works only if an item is attached to this serial). 10 Go back to the routing lists management page (routinglists.pl) and click on 'Export'. Download the CSV and check that it contains correct data. >From serials-collection.pl page: 11 In the serials list, click on 'Print list'. 12 You will be asked to choose a routing list. Pick one and click on 'Continue'. 13 ... (same behaviour as above) Try to add and delete routing lists to show if links are correctly updated in serials-home.pl, serials-collection.pl and subscription-detail.pl Signed-off-by: Paola Rossi Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 23:42:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 22:42:23 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47634|0 |1 is obsolete| | --- Comment #60 from Aleisha Amohia --- Created attachment 47661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47661&action=edit [SIGNED-OFF] Bug 7957: Add unit tests for new subroutines Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 23:42:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 22:42:51 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47660|0 |1 is obsolete| | --- Comment #61 from Aleisha Amohia --- Created attachment 47662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47662&action=edit [SIGNED-OFF] Bug 7957: Routing lists enhancements - Manage several routing list per subscription - Export a routing list as CSV Test plan: Run the updatedatabase.pl script Existing routing lists should have been imported in a routing list named 'import' >From the serials-home.pl page: 1 Make a search, in the results list you have a column 'Actions' that should contain a "New/Edit routing list" link" (if not, consider setting RoutingSerials syspref). If the subscription doesn't have a routing list, you should have a 'New routing list' link. Otherwise you have an 'Edit routing lists (X)' link, where X is the number of routing lists. 2 Choose a subscription which have no routing lists and click on 'New routing list' 3 You are on the routing list creation page. Enter a title for the routing list and click on 'Save'. 4 The routing list has been created and now you are on the routing list modification page. The behaviour of this page is quite the same as before. A sensible change is that reordering borrowers doesn't reload the page each time you make a change. 5 Click on 'Save' to finish routing list modifications. 6 Now you are on the routing lists management page. You can edit a routing list by clicking on its title, preview it, export it, and delete it by clicking on the corresponding link. 7 Click on 'Preview'. 8 You will be asked to choose a serial. Pick the one you want to print the routing list for and click on 'Continue'. 9 If RoutingListAddReserves is OFF, the routing list is displayed and you just have to click on 'Print'. If the syspref is ON, you will have to click on 'Confirm and print', an alert will show telling you that holds will be placed on the serial you chose. Click 'OK' and you will be able to print the slip. Now check if the holds have been placed. (It works only if an item is attached to this serial). 10 Go back to the routing lists management page (routinglists.pl) and click on 'Export'. Download the CSV and check that it contains correct data. >From serials-collection.pl page: 11 In the serials list, click on 'Print list'. 12 You will be asked to choose a routing list. Pick one and click on 'Continue'. 13 ... (same behaviour as above) Try to add and delete routing lists to show if links are correctly updated in serials-home.pl, serials-collection.pl and subscription-detail.pl Signed-off-by: Paola Rossi Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 23:42:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 22:42:57 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47661|0 |1 is obsolete| | --- Comment #62 from Aleisha Amohia --- Created attachment 47663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47663&action=edit [SIGNED-OFF] Bug 7957: Add unit tests for new subroutines Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 23:43:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 22:43:07 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47635|0 |1 is obsolete| | --- Comment #63 from Aleisha Amohia --- Created attachment 47664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47664&action=edit [SIGNED-OFF] Bug 7957: Redirect after creating a new routing list This avoids creating the same list multiple times when reloading the page Signed-off-by: Aleisha Have made a couple of small changes to your patch. 1) "There is no routing lists for this subscription" -> changed to "There are no" 2) When I click Preview and choose a serial (up to Step 9 in test plan), there is a link to another system preference which I assume$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 4 23:44:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 22:44:48 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #64 from Aleisha Amohia --- (In reply to Aleisha Amohia from comment #63) > Created attachment 47664 [details] [review] > [SIGNED-OFF] Bug 7957: Redirect after creating a new routing list > > This avoids creating the same list multiple times when reloading the > page > > Signed-off-by: Aleisha > > Have made a couple of small changes to your patch. > 1) "There is no routing lists for this subscription" -> changed to "There > are no" > 2) When I click Preview and choose a serial (up to Step 9 in test plan), > there is a link to another system preference which I assume$ ...which I assume is where the text comes from. Have changed this in syspref.sql to take the tags out around the syspref because html tags won't show up nicely in a sql file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 00:21:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 23:21:43 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 --- Comment #22 from Marc V?ron --- Hi Aleisha, I just re-tested. PThe patch applies fine on top of Bug 14930. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 00:30:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 23:30:33 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #23 from Aleisha Amohia --- (In reply to Marc V?ron from comment #22) > Hi Aleisha, > > I just re-tested. PThe patch applies fine on top of Bug 14930. Oops I completely forgot to apply the dependency (silly me). Will retest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 00:48:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Feb 2016 23:48:03 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #24 from Aleisha Amohia --- There are a couple of problems with the patch. When the user has too many fines, there is no message on the summary page to say the user is blocked from check outs. Also, small typo: When the account has a restriction, the message says "If shows your account to be clear", which doesn't make sense. Perhaps change to "If your account is shown to be clear"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 01:16:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 00:16:55 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|Needs Signoff |Failed QA --- Comment #3 from Aleisha Amohia --- t/db_dependent/HoldsQueue.t .. 1/27 # Failed test 'Holds queue giving priority to patron who's home library matches item's home library' # at t/db_dependent/HoldsQueue.t line 333. # got: 'cdoBnBl' # expected: 'pkSI5p' # Failed test 'Holds queue giving priority to patron who's home library matches item's holding library' # at t/db_dependent/HoldsQueue.t line 350. # got: 'cdoBnBl' # expected: 'pkSI5p' # Failed test 'Holds queue giving priority to patron who's home library matches item's holding library' # at t/db_dependent/HoldsQueue.t line 367. # got: 'cdoBnBl' # expected: 'pkSI5p' # Failed test 'Holds queue giving priority to patron who's home library matches item's holding library' # at t/db_dependent/HoldsQueue.t line 384. # got: 'cdoBnBl' # expected: 'pkSI5p' # Failed test 'Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled' # at t/db_dependent/HoldsQueue.t line 492. # got: '1' # expected: '0' # Looks like you failed 5 tests of 27. t/db_dependent/HoldsQueue.t .. Dubious, test returned 5 (wstat 1280, 0x500) Failed 5/27 subtests Test Summary Report ------------------- t/db_dependent/HoldsQueue.t (Wstat: 1280 Tests: 27 Failed: 5) Failed tests: 22-25, 27 Non-zero exit status: 5 Files=1, Tests=27, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.13 cusr 0.09 csys = 1.26 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 01:29:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 00:29:15 +0000 Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|Needs Signoff |Failed QA --- Comment #4 from Aleisha Amohia --- I don't get any kind of message after checking in the book at step 5/6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 01:45:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 00:45:14 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aleishaamohia at hotmail.com --- Comment #26 from Aleisha Amohia --- This didn't work properly for me - I selected the pipe | as my CSV separator and copied your data from step 2 but the CSV file did not separate my files on pipes and separated on commas instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 01:56:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 00:56:15 +0000 Subject: [Koha-bugs] [Bug 15531] Add support for standing orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aleishaamohia at hotmail.com --- Comment #5 from Aleisha Amohia --- Tests failed: StandingOrders.t CancelReceipt.t OrderUsers.t Also I can still see the quantity field there, just can't change it Otherwise everything else seems to work well and will be happy to sign off once those few things are fixed up :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 02:10:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 01:10:56 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #18 from Aleisha Amohia --- (In reply to M. Tompsett from comment #14) > Created attachment 47556 [details] [review] > Bug 14272: Show single news item (tests) > > Updates tests to match the modified NewsChannels module. > > Sponsored-by: Halland County Library The tests fail: t/db_dependent/NewsChannels.t .. 1/12 # Category CAT1 not found, inserting # Borrower BRWR1 not found, inserting # Failed test 'got back expected news item via get_opac_new - ID 1' # at t/db_dependent/NewsChannels.t line 131. # Structures begin differing at: # $got->{newdate} = Does not exist # $expected->{newdate} = '01/01/2000' # Failed test 'got back expected news item via get_opac_new - ID 2' # at t/db_dependent/NewsChannels.t line 158. # Structures begin differing at: # $got->{newdate} = Does not exist # $expected->{newdate} = '01/01/2000' # Looks like you failed 2 tests of 12. t/db_dependent/NewsChannels.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/12 subtests Test Summary Report ------------------- t/db_dependent/NewsChannels.t (Wstat: 512 Tests: 12 Failed: 2) Failed tests: 8-9 Non-zero exit status: 2 Files=1, Tests=12, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.59 cusr 0.04 csys = 0.65 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 02:18:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 01:18:09 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47556|0 |1 is obsolete| | --- Comment #19 from Aleisha Amohia --- Created attachment 47665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47665&action=edit Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 02:18:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 01:18:36 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47665|0 |1 is obsolete| | --- Comment #20 from Aleisha Amohia --- Created attachment 47666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47666&action=edit Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 02:19:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 01:19:00 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47666|0 |1 is obsolete| | --- Comment #21 from Aleisha Amohia --- Created attachment 47667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47667&action=edit Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 02:19:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 01:19:42 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47667|0 |1 is obsolete| | --- Comment #22 from Aleisha Amohia --- Created attachment 47668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47668&action=edit Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 02:20:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 01:20:04 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47668|0 |1 is obsolete| | --- Comment #23 from Aleisha Amohia --- Created attachment 47669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47669&action=edit Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 02:20:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 01:20:11 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47557|0 |1 is obsolete| | --- Comment #24 from Aleisha Amohia --- Created attachment 47670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47670&action=edit [SIGNED-OFF] Bug 14272: Show single news item (backend) Updates: * Date formatting added to get_opac_new() * Proper filtering by way of GetNewsToDisplay Sponsored-by: Halland County Library Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 02:20:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 01:20:36 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47669|0 |1 is obsolete| | --- Comment #25 from Aleisha Amohia --- Created attachment 47671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47671&action=edit Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 02:20:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 01:20:41 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47670|0 |1 is obsolete| | --- Comment #26 from Aleisha Amohia --- Created attachment 47672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47672&action=edit [SIGNED-OFF] Bug 14272: Show single news item (backend) Updates: * Date formatting added to get_opac_new() * Proper filtering by way of GetNewsToDisplay Sponsored-by: Halland County Library Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 02:20:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 01:20:50 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47558|0 |1 is obsolete| | --- Comment #27 from Aleisha Amohia --- Created attachment 47673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47673&action=edit [SIGNED-OFF] Bug 14272: Show single news item (OPAC) This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nees item heading should be clickable. * When clicked only that item should be shown. * When 'news_id' is present, only a single news item should show. * The breadcrumb should say 'News item' after 'Home'. Updates: * Renamed URL parameter and local variables with 'news_' prefix. * Fixed Search-And-Replace error; 'news_news_id' => 'news_id' * Added breadcrumb for viewing single news item. * Updated OPAC to use new GetNewsToDisplay parameters * Fixed template formatting and calling of GetNewsToDisplay Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 02:22:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 01:22:36 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #28 from Aleisha Amohia --- Sorry for all the comments, git kept timing out >.< so annoying! Won't change this to Signed Off as those tests don't pass, but will sign off once they're fixed to pass! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 02:30:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 01:30:47 +0000 Subject: [Koha-bugs] [Bug 15385] News archive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15385 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 02:30:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 01:30:50 +0000 Subject: [Koha-bugs] [Bug 15385] News archive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15385 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47559|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia --- Created attachment 47674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47674&action=edit [SIGNED-OFF] Bug 15385: News archive Adds ability to new old, expired news items in an archive. Test plan: * Add several news items, some of which should have an expired date. * Go to Global system preferences, Enable 'NewsArchiveEnabled'. * Go to the OPAC main page. The non-expired news should be shown. * A link should be shown in the lower right-hand side of the page, "Archived news". Click it. ALL news items should be shown. * Go back to Global system preferences, Disable 'NewsArchiveEnabled'. * No 'Archived news' link should be shown on the OPAC main page. * If you manually add '?id=all' to the OPAC main page URL, the standard page should be shown and the parameter ignored. Updates: * Renamed 'id' to 'news_id' (from update in 14272) * Added breadcrumbs Sponsored-By: Halland County Library Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 05:42:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 04:42:58 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |vimal0212 at gmail.com --- Comment #5 from vimal kumar --- "Always show checkouts immediately" is an annoying feature for library professionals in circulation desk. This feature is against the "Five Laws of Library Science" Save the Time of the reader!! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 05:44:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 04:44:41 +0000 Subject: [Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- Hey Kyle, I've had the same issue when doing matching. Since it has no documentation, I've left it in Koha, but I've created a "none" or "raw" normalizer which skips C4::Matcher::_normalize, as it was butchering URLs... You can see the signed off patch at: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 06:02:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 05:02:35 +0000 Subject: [Koha-bugs] [Bug 15745] New: C4::Matcher gets CCL parsing error if term contains ? (question mark) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 Bug ID: 15745 Summary: C4::Matcher gets CCL parsing error if term contains ? (question mark) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org I was using C4::Matcher via the record matching rules during an import, and I kept getting the following error: "CCL parsing error (10014) Embedded truncation not supported ZOOM". Query: id-other,st-urx=http://www.skovdenyheter.se?p=38004 I wondered why it was trying to do "embedded truncation" when it shouldn't have been doing any truncation by default... so I thought about wrapping the whole term in double quotation marks. Sure enough, the following worked and didn't produce an error: id-other,st-urx="http://www.skovdenyheter.se?p=38004" You can notice this same problem elsewhere when using CCL. Most noticeably directly with yaz-client: Z> find ti=test? CCL ERROR: Right truncation not supported Z> find ti="test?" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 4, setno 2 SearchResult-1: term=test cnt=4 records returned: 0 Elapsed: 0.000816 Also consider the following: Z> find kw,rt=tes* CCL ERROR: Right truncation not supported Z> find kw="tes*" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 0, setno 23 SearchResult-1: term=tes cnt=0 records returned: 0 Elapsed: 0.000679 Z> find kw,rt="tes*" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 6, setno 24 SearchResult-1: term=tes cnt=6 records returned: 0 Elapsed: 0.001049 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 06:02:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 05:02:50 +0000 Subject: [Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 07:07:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 06:07:48 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44792|0 |1 is obsolete| | --- Comment #64 from David Cook --- Created attachment 47675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47675&action=edit Bug 10662 - Build OAI-PMH Harvesting Client _QUICK AND TENTATIVE TEST PLAN_ In the following steps replace "/home/user" with whatever your Koha dev install is _CONFIGURATION_ 1) Add something like the following to your koha-conf.xml after and before unix:/home/user/koha-dev/var/run/icarus.sock /home/user/koha-dev/var/run/icarus.pid /home/user/koha-dev/var/log/icarus.log Koha::Icarus::Task::Enqueue::OAIPMH::Biblio Koha::Icarus::Task::Dequeue::OAIPMH::Biblio Koha::Icarus::Task::Test 30 2) Apply Bugzilla patches 15555, 15541, 15745, then 10662 3) Upgrade your Koha dev install so that it uses new Zebra configuration files; try something like the following: perl Makefile.PL --prev-install-log "$INSTALL_LOG" make make test make upgrade 4) Run upgrade database: perl installer/data/mysql/updatedatabase.pl 4) Set PERL5LIB to include /home/user/koha (i.e. path to your C4 and Koha module directories) export PERL5LIB=/home/user/koha 5) Activate Icarus using the following command: perl /home/user/koha/misc/bin/icarusd.pl -f /home/user/koha-dev/etc/koha-conf.xml NOTE: It will send output to your terminal window. To write to the log file, you can daemonize by adding the "-d" or "--daemon" options. 6) In Koha, create a record matching rule: Code = OAI Match threshold = 100 Record type = Bibliographic Search index = control-number Score = 100 Tag = 001 Search index = id-other,st-urx Score = 100 Tag = 024 Subfields = a Normalization rule = raw _USER DOWNLOAD TASK_ 7a) Go to http://KOHA/cgi-bin/koha/admin/saved_tasks.pl 7b) Click "New saved task" 7c) Leave it on "Koha::Icarus::Task::Enqueue::OAIPMH::Biblio" and click "Next" 7d) Choose a "Start time" in the past using the calendar pop-up 7e) Choose a "Repeat interval" of at least 30 seconds (for initial troubleshooting purposes) 7f) Choose a URL of an OAI-PMH repository that you want to harvest (also include a username, password, and realm if necessary) 7g) Fill out your OAI-PMH repositories as you like 7h) Fill out "Queue" with something like file:///home/user/koha/icarus_test 7i) Click "Save" 8a) Check that the Icarus dashboard has a "Status" of "Online" 8b) Click "Send to Icarus" next to your new saved task entry 8c) A task should now appear under "Active Icarus tasks"; click "Start" 8d) Go back to your terminal to check the Icarus server output (or 'tail -f' the log if you daemonized) 8e) You should notice activity; you can also check /home/user/koha/icarus_test to see if records are being downloaded and stored there _USER IMPORT TASK_ 9a) Go back to http://KOHA/cgi-bin/koha/admin/saved_tasks.pl 9b) Click "New saved task" 9c) Choose Koha::Icarus::Task::Dequeue::OAIPMH::Biblio, and click "Next" 9d) Repeat the same steps for "Start time" and "Repeat interval" as these are common to all tasks 9e) "Queue" should be the same as before, so try your path of file:///home/user/koha/icarus_test 9f) Provide a username and password for the API authentication; you should be able to use the default URL 9g) You should be able to trust the "Import target parameters" URL 9h) Write "OAI" for "Record matching rule code", if you added it earlier in the configuration steps 9i) Leave the "Action..." defaults... 9j) Change "Filter" to "file:///home/user/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/OAI2MARC21slim.xsl" 9k) Follow the same steps as above for sending the task to Icarus and telling Icarus to start it 9l) You can either watch Icarus's server output, or look at http://KOHA/cgi-bin/koha/tools/manage-marc-import.pl, or look directly at your database's "import_oai" and "biblio" tables to see how records are imported to Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 07:08:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 06:08:15 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44793|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 07:11:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 06:11:33 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #65 from David Cook --- Hi all: Here's a rough draft of what I've been working on. It still needs some fixes, some improvements, and quite a bit of polishing. I'm hoping to do most of that over the next couple of weeks, but I thought I'd post this now as my wife is 35 weeks pregnant, and you never know when babies will be born... In terms of bare bones functionality, it should all be there. Feel free to add comments about things you'd like to see (like parameters or names for Active Icarus Tasks), and I'll hopefully incorporate that feedback into my finishing work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 07:16:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 06:16:09 +0000 Subject: [Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 07:16:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 06:16:11 +0000 Subject: [Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 --- Comment #1 from David Cook --- Created attachment 47676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47676&action=edit Bug 15745 - C4::Matcher gets CCL parsing error if term contains ? (question mark) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 07:16:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 06:16:33 +0000 Subject: [Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 --- Comment #2 from David Cook --- I'll write a better description and test plan next week when I have more time... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 07:24:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 06:24:12 +0000 Subject: [Koha-bugs] [Bug 15311] Let libraries set text to display when OpacMaintenance = on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mirko at abunchofthings.net --- Comment #11 from Mirko Tietgen --- (In reply to Aleisha Amohia from comment #10) > Sponsored-by: Catalyst IT Was that on purpose? Claiming a patch somebody else wrote to be sponsored by Catalyst because you fixed a conflict does not seem like a nice move. In fact support companies do not really put that line in for their own stuff, just for things sponsored by third parties. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 07:37:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 06:37:21 +0000 Subject: [Koha-bugs] [Bug 15311] Let libraries set text to display when OpacMaintenance = on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 --- Comment #12 from Aleisha Amohia --- (In reply to Mirko Tietgen from comment #11) > (In reply to Aleisha Amohia from comment #10) > > > Sponsored-by: Catalyst IT > > Was that on purpose? Claiming a patch somebody else wrote to be sponsored by > Catalyst because you fixed a conflict does not seem like a nice move. In > fact support companies do not really put that line in for their own stuff, > just for things sponsored by third parties. No I'm sorry that was a complete accident! I was trying to get in to the habit of adding it and did it without thinking! Sorry it looks so bad I did not mean to claim the patch :( I'll remove it when I get in to work on Tuesday -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 08:00:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 07:00:31 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42178|0 |1 is obsolete| | --- Comment #9 from H?ctor Eduardo Castro Avalos --- Created attachment 47677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47677&action=edit Bug 14304: RDA: Intranet display link in XSLT for 264 field to reflect Zebra indexing This patch add display link in XSLT for 264 for bug 14198 and reflect the Zebra indexing 'Provider' in detail page for Intranet. Test plan 1) Update zebra index if no Provider: index exist 2) Do a search by Provider: 3) Goto detail page for a record with 264 4) Look that there no display link for 264 field. 5) Apply the patch 6) Reload the page, notice about the link, click the link an confirm the new index Provider works fine 7) Test with multiple records with 260 and 264, if you prefer follow test plan for bug 14734 8) Access an RCAA2 record just with 260 field 9) Notice that 260 has been updated with Provider index too. NOTE: The intention of Provider index -according with documentation- is to collect multiples fields including 260, 264, 270, and 257 Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 08:05:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 07:05:56 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 --- Comment #10 from H?ctor Eduardo Castro Avalos --- I will send the OPAC's patch afterwards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 08:41:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 07:41:25 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 --- Comment #25 from Marc V?ron --- Hmm, testing... Seems OK to me... - Syspref OpacRenewalAllowed: Allow - Syspref OPACFineNoRenewals: 2 - Patron has fines: Total due: 5.01 - Log-in to Opac with patron, go to 'your summary' Result: "Please note: You cannot renew your books online. Reason: Your fines exceed 2.00. Please pay your fines if you wish to renew your books. Go to your account page" OK - Syspref OPACFineNoRenewals: 10 - Patron has fines: Total due: 5.01 - Refresh 'your summary' Result: No message OK - Syspref OPACFineNoRenewals: 10 - Add manual fine for patron (10). Now total due is: 15.01 - Refresh 'your summary' Result: "Please note: You cannot renew your books online. Reason: Your fines exceed 10.00. Please pay your fines if you wish to renew your books. Go to your account page" OK - Syspref OPACFineNoRenewals: 0 - Patron has fines: Total due: 15.01 - Refresh 'your summary' Result: "Please note: You cannot renew your books online. Reason: You have fines. Please pay your fines if you wish to renew your books. Go to your account page" OK - Syspref OPACFineNoRenewals: (empty) - Refresh 'your summary' Result: No message OK - Syspref OPACFineNoRenewals: xyndjeksfjasdf (non-numeric, is not validated by syspref form) - Refresh 'your summary' Result: No message OK - Syspref OPACFineNoRenewals: (one space char) (non-numeric, is not validated by syspref form) - Refresh 'your summary' Result: No message OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 08:48:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 07:48:03 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47656|0 |1 is obsolete| | --- Comment #26 from Marc V?ron --- Created attachment 47678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47678&action=edit Bug 15374 - Translatability: Fix issues on OPAC summary page Fix several issues on opac-user.tt with sentences splitted by tags, leading to odd translations. Additionally, fix a broken link that should point to opac-account.pl To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions (Amended to add price formatting in fines tab label) Can see the warning message now :) signing off Signed-off-by: Aleisha (Amended to make patches apply, see comment #12) Signed-off-by: Aleisha (Amended to make it apply and to fix BORROWER.INF -> BORROWER->INFO. Needs new sign-off. / MV) (Amended to fix typo from comment #24 / mv) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 08:54:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 07:54:38 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #27 from Marc V?ron --- Hi Aleisha, Thank you very much for continuous testing. I could not reproduce your issue from comment #24, see my tests in comment #25. If I missed something, please provide information on how you got your result. I attached a patch with fixed wording. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 09:45:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 08:45:05 +0000 Subject: [Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 09:45:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 08:45:08 +0000 Subject: [Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46181|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 47679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47679&action=edit Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline' Koha::Logger allows us to split up logging to separate files based on the interface. However, right now the interface is limited to just 'opac' or 'intranet'. We should extend this to allow the interface to also be set to 'sip' for SIP server logging, and to 'commandline' for cronjobs and all other command line scripts. Signed-off-by: Chris Does what it says on the tin Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 09:45:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 08:45:12 +0000 Subject: [Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 --- Comment #5 from Marcel de Rooy --- Created attachment 47680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47680&action=edit Bug 14751: [QA Follow-up] Unit tests for interface method Added some descriptions in Context.t and added two tests for sip and commandline. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 09:45:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 08:45:22 +0000 Subject: [Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 09:46:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 08:46:38 +0000 Subject: [Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 10:23:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 09:23:58 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #24 from Marc V?ron --- Just a note: Testing, went through test plans from comment #1 and #2, both OK. #3 points 1-3 are OK Will later try to find time for more testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 10:24:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 09:24:52 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply --- Comment #24 from Marcel de Rooy --- >From the discussion above, I would conclude that the author did not yet provide answers to questions raised. The code looks reasonable but does not apply anymore. >From a functional perspective, it is hard to say (at first glance) if [a] this approach with a new pref, [b] the approach of comment19 with bug 12802, [c] yet another solution (perhaps linked to editing guarantor/guarantee record), would be the best way to go. I have my doubts on approach b btw. I would rather leave the guarantor stuff outside firstvalidemail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 10:46:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 09:46:12 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 10:46:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 09:46:15 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47306|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 47681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47681&action=edit Bug 15662: String and translatability fix to Label Creator To test: 1) Go to Tools -> Label Creator -> New label batch 2) Add an item 3) Click 'Remove selected items' button. Confirm message now reads "Please select at least one label to delete." 4) Click 'Remove duplicates' button. Confirm message now reads "Duplicate item(s) removed from batch number X: Y", all in bold. Signed-off-by: Hector Castro Rewording Ok for translatability purpose Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 10:46:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 09:46:46 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |m.de.rooy at rijksmuseum.nl Assignee|cnighswonger at foundations.ed |aleishaamohia at hotmail.com |u | QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 10:49:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 09:49:06 +0000 Subject: [Koha-bugs] [Bug 15622] Spelling mistake in printfreercpt.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15622 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 10:49:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 09:49:09 +0000 Subject: [Koha-bugs] [Bug 15622] Spelling mistake in printfreercpt.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15622 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47080|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 47682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47682&action=edit 15622 - Spelling mistake in printfeercpt.pl writen -> written Search the file for writen, when not found change sucsessful Signed-off-by: Mirko Tietgen Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 10:50:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 09:50:25 +0000 Subject: [Koha-bugs] [Bug 15622] Spelling mistake in printfreercpt.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15622 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 10:57:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 09:57:44 +0000 Subject: [Koha-bugs] [Bug 15731] C4::Reports::Guided::build_authorised_value_list is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 10:57:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 09:57:46 +0000 Subject: [Koha-bugs] [Bug 15731] C4::Reports::Guided::build_authorised_value_list is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47643|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 47683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47683&action=edit Bug 15731: Remove C4::Reports::Guided::build_authorised_value_list This subroutine has been added by commit 42acfbf75b7bb4ee53c6a6f035e258a0b522ce10 Bug 7993: Save reports with Group/Subgroup hierarchy But it has never been used (or git grep cheats me). Test plan: 1/ git grep build_authorised_value_list should not return any result 2/ Create a report, execute it Everything should work fine. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 10:58:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 09:58:13 +0000 Subject: [Koha-bugs] [Bug 15731] C4::Reports::Guided::build_authorised_value_list is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 11:45:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 10:45:48 +0000 Subject: [Koha-bugs] [Bug 15746] New: A random library is used to record an individual payment Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15746 Bug ID: 15746 Summary: A random library is used to record an individual payment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Patrons Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 11:53:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 10:53:00 +0000 Subject: [Koha-bugs] [Bug 15746] A random library is used to record an individual payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15746 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 11:53:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 10:53:03 +0000 Subject: [Koha-bugs] [Bug 15746] A random library is used to record an individual payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15746 --- Comment #1 from Jonathan Druart --- Created attachment 47684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47684&action=edit Bug 15746: Do not record individual payments with randomly picked libraries When a payment is made individualy, the library used to record this payment is randomly picked from the library list. This is because C4::Branch::GetBranch looks at 1. the $branch variable sent by the template, wich does not exist, then 2. the branchname cookie, which does not exist neither, then 3. get the first branchcode from a list of keys (non ordered). To reproduce: - Create a manual invoice for a patron (members/maninvoice.pl?borrowernumber=XXXX) - Pay this fine using the "Pay" button of the corresponding line from the members/pay.pl?borrowernumber=XXXX page Look at the statistics table: select * from statistics order by datetime desc limit 10; The branch value of the first line might not correspond to the library you were using to pay the payment. Test plan: Apply this patch, repeat the steps above and confirm that the library picked is now the one used to pay. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 11:59:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 10:59:33 +0000 Subject: [Koha-bugs] [Bug 15746] A random library is used to record an individual payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15746 --- Comment #2 from Jonathan Druart --- Created attachment 47685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47685&action=edit Bug 15746: Same fix for "write off" Same fix as before for the "Write off" button next to the "Pay" button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 12:43:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 11:43:33 +0000 Subject: [Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 12:43:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 11:43:36 +0000 Subject: [Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47658|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 47686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47686&action=edit Bug 15742: Remove unnecessary loop in j2a cronjob If no branchcode is given, all the libraries are retrieved and the same query (so without using the libraries loop) is executed for each library. Test plan: Use the j2a.pl cronjob to change the category of a child patron If a branchcode is passed to the script, only the children from this branchcode should be updated. But if it is not passed, all children of the DB should be updated. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 12:43:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 11:43:45 +0000 Subject: [Koha-bugs] [Bug 15742] Unnecessary loop in j2a cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15742 --- Comment #6 from Kyle M Hall --- Created attachment 47687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47687&action=edit Bug 15742 [QA Followup] - Tidy script Script does not appear to have any other modifying patches at this time based on bz splitter. This is a perfect time to clean up this script! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 13:13:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 12:13:37 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 13:13:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 12:13:40 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47261|0 |1 is obsolete| | Attachment #47263|0 |1 is obsolete| | Attachment #47264|0 |1 is obsolete| | Attachment #47266|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 47688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47688&action=edit Bug 15285: Upgrade DataTables to 1.10.10 The ColVis DataTables plugin is now retired. We need to upgrade the plugin to 1.10.10 and use the column visibility module for Buttons. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 13:13:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 12:13:48 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #19 from Kyle M Hall --- Created attachment 47689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47689&action=edit Bug 15285: Update common files This patch moves the Button area all tables which does not redefine the dom/sDom DT parameter. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 13:13:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 12:13:50 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #20 from Kyle M Hall --- Created attachment 47690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47690&action=edit Bug 15285: Update for 3 specific tables The checkouts, currency and items lost tables redefine the dom/sDom and the older C(olvis) should be replaced with the current B(utton). Test plan: To test the whole patch set, you will have to test the 4 tables impacted by this patch as well as the others using the columns settings. The additem has specific code and should be tested keeping that in mind. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 13:13:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 12:13:53 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #21 from Kyle M Hall --- Created attachment 47691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47691&action=edit Bug 15285: Fix conflict with the treetable plugin The tables using the treetable plugin don't display correctly (with JS error). The lazy way to fix it is to redefine the dom of the table and remove the button area (B). Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 13:30:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 12:30:57 +0000 Subject: [Koha-bugs] [Bug 15737] Patron userid lost during test for duplicate users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15737 Emma Perks changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emma.perks at heartofengland.n | |hs.uk --- Comment #1 from Emma Perks --- PIN numbers in the duplicate records are also affected by this bug and are subject to changing automatically. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 13:33:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 12:33:36 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 13:33:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 12:33:39 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46310|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 47692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47692&action=edit Bug 15471: Add column settings and filters to Holds queue table Add column visibility menu using DataTables Buttons Add a text filter on top of each column Also extend page width so that the large table is better centered Depends on bug 15285 Test plan 1. Go to Holds queue page (circ/view_holdsqueue.pl) 2. Check that table sorting and filtering work well and that you can hide each column 3. Go to Admin > Configure columns and change the settings for this table (Circulation > view_holdsqueue > holds-table). Verify that the settings work by going again to the Holds queue page 4. Check that filters continue to work after hiding some columns Tested on top of 15285, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 13:33:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 12:33:54 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 --- Comment #9 from Kyle M Hall --- Created attachment 47693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47693&action=edit Bug 15471 [QA Followup] - Fix error causing visibility button to not display Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 13:42:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 12:42:30 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 13:42:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 12:42:33 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47257|0 |1 is obsolete| | Attachment #47258|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 47694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47694&action=edit Bug 14244: viewing a bib item's circ history requires circulation permissions On issuehistory.pl you have: flagsrequired => { circulate => "circulate_remaining_permissions" }, But that really doesn't make sense. People should be able to view the history of circulation without having permission to circulate items themselves This patch changes the required permissions from circulate to catalogue. Test Plan: 1. Login as user without the circulate_remaining_permissions 2. Attempt to view Circulation History of an Item 3. Does not work 4. Apply Patch 5. Attempt to view circulation history with a user that has access to the staff side. 6. Can view circulation history now Signed-off-by: Nicole Engard Signed-off-by: Jonathan Druart Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 13:42:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 12:42:41 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 --- Comment #21 from Kyle M Hall --- Created attachment 47695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47695&action=edit Bug 14244: Does not display patron's info in the checkout history if not authorised The librarian needs CAN_user_circulate_circulate_remaining_permissions to see the checkouts patron's information. Test plan: The "Patron" column of the checkout history page should only be displayed of you have the circulate > circulate_remaining_permissions permission. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 13:48:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 12:48:03 +0000 Subject: [Koha-bugs] [Bug 15743] Allow plugins to embed Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15743 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 13:48:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 12:48:05 +0000 Subject: [Koha-bugs] [Bug 15743] Allow plugins to embed Perl modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15743 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47657|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 47696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47696&action=edit Bug 15743: Allow plugins to embed Perl modules This patch allows plugins to embed Perl modules by ignoring Perl modules in plugins directory that don't inherit from Koha::Plugins::Base TEST PLAN --------- 1) Edit koha-conf.xml to have enable_plugins set to 1, and the pluginsdir set to a particular path. 2) Create a dummy plugin file. (e.g. {that path}/Koha/Plugin/Kaboom.pm) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 14:16:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 13:16:27 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #6 from Owen Leonard --- Which reader do you want to save time for? The reader who wants to see the list of checkouts right away or the reader who wants to have the page load quickly when there are hundreds of checkouts? The point of this bug is to make a new preference so you can have it either leave things the way they are now or return them to the way things were before the changes made by Bug 12550. A preference is the only way to give options to the various needs different librarians have expressed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 14:16:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 13:16:33 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 14:32:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 13:32:58 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|maxime.beaulieu at inlibro.com |remi.mayrand-provencher at inL | |ibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 14:33:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 13:33:36 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|maxime.beaulieu at inlibro.com |remi.mayrand-provencher at inL | |ibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 14:34:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 13:34:03 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|maxime.beaulieu at inlibro.com |remi.mayrand-provencher at inL | |ibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 14:34:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 13:34:43 +0000 Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|genevieve.plantin at inlibro.c |remi.mayrand-provencher at inL |om |ibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 14:59:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 13:59:22 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 14:59:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 13:59:25 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47388|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 47697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47697&action=edit Bug 15465 - Created README.md file for github Signed-off-by: Mirko Tietgen Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 14:59:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 13:59:32 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 --- Comment #9 from Kyle M Hall --- Created attachment 47698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47698&action=edit Bug 15465 [QA Followup] - Update wording, switch logo, add links * Changed wording to not be github-centric * Added suggested links * Switched to more traditional logo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 15:01:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 14:01:07 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47698|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 47699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47699&action=edit Bug 15465 [QA Followup] - Update wording, switch logo, add links * Changed wording to not be github-centric * Added suggested links * Switched to more traditional logo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 15:02:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 14:02:55 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #11 from Kyle M Hall --- Whoever controls the Koha github account should also disable the wiki and bugtracker features for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 15:05:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 14:05:46 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #12 from Mirko Tietgen --- Added Mason because I think he runs the github page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 15:28:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 14:28:14 +0000 Subject: [Koha-bugs] [Bug 15441] columns_settings.pl: Circulation issues-table - cannot toggle checkin column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15441 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 15:34:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 14:34:39 +0000 Subject: [Koha-bugs] [Bug 15554] Organize entries in ccl.properties In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15554 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 15:35:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 14:35:02 +0000 Subject: [Koha-bugs] [Bug 11461] Added functionality for batch Z39.50 searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11461 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 15:41:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 14:41:50 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 15:45:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 14:45:44 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 15:45:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 14:45:47 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 --- Comment #11 from H?ctor Eduardo Castro Avalos --- Created attachment 47700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47700&action=edit Bug 14304: RDA: OPAC display link in XSLT for 264 field to reflect Zebra indexing This patch add display link in XSLT for field 264/bug 14198 and reflect the Zebra index 'Provider' in detail page for OPAC screen. To test: follow previous test plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 15:46:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 14:46:35 +0000 Subject: [Koha-bugs] [Bug 15747] New: Auth.pm flooding error log with "CGI::param called in list context" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 Bug ID: 15747 Summary: Auth.pm flooding error log with "CGI::param called in list context" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org In my error log for the staff client: CGI::param called in list context from package C4::Auth line 401, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. >From the OPAC error log: CGI::param called in list context from package C4::Auth line 399, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 15:48:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 14:48:41 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #14 from Kyle M Hall --- Created attachment 47701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47701&action=edit Bug 15629 [QA Followup] * Use ->id instead of ->branchcode when possible to eliminate use of that nomenclature * Fix bad use of ->branchcode to ->{branchcode} for unblessed hashref version of Koha::Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 15:56:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 14:56:20 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 --- Comment #12 from H?ctor Eduardo Castro Avalos --- Hi The patches are ready to be tested Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 16:26:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 15:26:40 +0000 Subject: [Koha-bugs] [Bug 15748] New: Koha offline circulation Firefox addon saves transactions in incorrect timezone Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15748 Bug ID: 15748 Summary: Koha offline circulation Firefox addon saves transactions in incorrect timezone Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: contribs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org It looks like the KOCT Firefox addon uses GMT as the time zone for transactions. Could it get the local time automatically? If not it should be a setting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 16:26:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 15:26:58 +0000 Subject: [Koha-bugs] [Bug 15748] Koha offline circulation Firefox addon saves transactions in incorrect timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15748 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 16:34:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 15:34:42 +0000 Subject: [Koha-bugs] [Bug 15746] A random library is used to record an individual payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15746 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 16:34:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 15:34:44 +0000 Subject: [Koha-bugs] [Bug 15746] A random library is used to record an individual payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15746 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47684|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 47702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47702&action=edit [SIGNED-OFF]Bug 15746: Do not record individual payments with randomly picked libraries When a payment is made individualy, the library used to record this payment is randomly picked from the library list. This is because C4::Branch::GetBranch looks at 1. the $branch variable sent by the template, wich does not exist, then 2. the branchname cookie, which does not exist neither, then 3. get the first branchcode from a list of keys (non ordered). To reproduce: - Create a manual invoice for a patron (members/maninvoice.pl?borrowernumber=XXXX) - Pay this fine using the "Pay" button of the corresponding line from the members/pay.pl?borrowernumber=XXXX page Look at the statistics table: select * from statistics order by datetime desc limit 10; The branch value of the first line might not correspond to the library you were using to pay the payment. Test plan: Apply this patch, repeat the steps above and confirm that the library picked is now the one used to pay. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 16:34:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 15:34:52 +0000 Subject: [Koha-bugs] [Bug 15746] A random library is used to record an individual payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15746 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47685|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 47703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47703&action=edit [SIGNED-OFF]Bug 15746: Same fix for "write off" Same fix as before for the "Write off" button next to the "Pay" button. Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 16:45:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 15:45:44 +0000 Subject: [Koha-bugs] [Bug 15749] New: Add library menu to OPAC header Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749 Bug ID: 15749 Summary: Add library menu to OPAC header Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: chad at pennmanor.net QA Contact: testopia at bugs.koha-community.org Our librarians requested the ability to search a specific library from the opac without requiring a patron to login or setup filters. We have a number of young patrons and the current process is rather cumbersome. I have some code that creates a Library menu in the opac header. It allows for an anonymous patron to select a library from the menu and have their search results automatically filtered. I have been working with Kyle Hall and the rest of the ByWater team to cleanup some of our modifications for potential inclusion upstream. A patch is coming... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 16:53:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 15:53:57 +0000 Subject: [Koha-bugs] [Bug 15749] Add library menu to OPAC header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749 --- Comment #1 from chad at pennmanor.net --- Created attachment 47704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47704&action=edit Add branch selector to the opac header Display a dropdown to select a branch on the opac. Used to limit the searches to a branch with out requiring a login or advanced filters. QA Followup from kyle at bywatersolutions.com * Change "Buildings" to "Libraries", add span with class for easy changing * Fix use of tabs * Update license version * Add "Clear selection" option * Remove use of TT markup inside HTML tags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 16:59:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 15:59:20 +0000 Subject: [Koha-bugs] [Bug 15749] Add library menu to OPAC header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749 --- Comment #2 from chad at pennmanor.net --- Test Plan: - Enable SearchMyLibraryFirst syspref - Visit the opac. You should see a "Libraries" menu in the header - Select a library from the menu. - Your search results should be limited to the library - Select "Clear Selection" from the menu to restore the default behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:02:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:02:43 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:02:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:02:46 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #25 from Nick Clemens --- Created attachment 47705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47705&action=edit Bug 15343 [QA Followup] * Check for leading/trailing spaces in password * Check hashed password in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:06:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:06:28 +0000 Subject: [Koha-bugs] [Bug 15749] Add library menu to OPAC header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |enhancement Assignee|oleonard at myacpl.org |chad at pennmanor.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:21:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:21:14 +0000 Subject: [Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:22:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:22:11 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:22:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:22:13 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47518|0 |1 is obsolete| | Attachment #47519|0 |1 is obsolete| | Attachment #47520|0 |1 is obsolete| | Attachment #47521|0 |1 is obsolete| | Attachment #47522|0 |1 is obsolete| | Attachment #47523|0 |1 is obsolete| | Attachment #47553|0 |1 is obsolete| | Attachment #47701|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 47706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47706&action=edit Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (1) For consistency, the branchcodes method of Koha::LibraryCategory should be named libraries. At the moment, there is only one occurrence, in admin/branches.pl Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:22:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:22:21 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #16 from Kyle M Hall --- Created attachment 47707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47707&action=edit Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (2) C4::Branch::GetBranchesInCategory can be replaced with Koha::LibraryCategory->libraries Test plan: 1/ Define some 1+ group of libraries with 1+ libraries each 2/ Go on the advanced search (OPAC and Staff) and select a group of libraries 3/ The result should be consistent and only include record from these libraries Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:22:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:22:23 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #17 from Kyle M Hall --- Created attachment 47708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47708&action=edit Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (3) C4::Branch::GetBranchesInCategory is not used anymore and can be removed. Test plan: git grep GetBranchesInCategory should not return any result. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:22:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:22:26 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #18 from Kyle M Hall --- Created attachment 47709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47709&action=edit Bug 15629: Koha::Libraries - Remove GetBranchDetail C4::Branch::GetBranchDetail retrieved library infos, it could be easily replaced with Koha::Libraries->find When this change needs other big changes, the unblessed method is called, to manipulate a hashref (as before) instead of a Koha::Library object (for instance when $library is sent to GetPreparedLetter). Test plan: 1/ Print a basket group, the library names should be correctly displayed. 2/ Enable emailLibrarianWhenHoldIsPlaced and place a hold, a HOLDPLACED notice will be generated (focus on the library name) 3/ Edit a patron and change his/her library 4/ Generate the advanced notices (misc/cronjobs/advance_notices.pl) and have a look at the generated notices 5/ Same of overdues notices 6/ Set IndependentBranches and use a non superlibrarian user to place a hold. The "pickup at" should be correctly filled. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:22:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:22:28 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #19 from Kyle M Hall --- Created attachment 47710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47710&action=edit Bug 15629: Koha::Libraries - Remove ModBranch This subroutine was only used in tests to add/update a library. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:22:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:22:31 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #20 from Kyle M Hall --- Created attachment 47711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47711&action=edit Bug 15629: Koha::Libraries - Remove GetBranchInfo C4::Branch::GetBranchInfo was only used once in opac/opac-suggestions.pl The occurrence can easily be replaced by a call to Koha::Libraries->find Test plan: 1/ Create a suggestion for library A 2/ Enable OPACViewOthersSuggestions 3/ Use a patron from library B to see the suggestions 4/ The "Suggested for" value should be correctly filled with the library A name. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:22:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:22:33 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #21 from Kyle M Hall --- Created attachment 47712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47712&action=edit Bug 15629: Fix tests - Koha::Library does not have ->categories but ->get_categories Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:22:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:22:36 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #22 from Kyle M Hall --- Created attachment 47713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47713&action=edit Bug 15629 [QA Followup] * Use ->id instead of ->branchcode when possible to eliminate use of that nomenclature * Fix bad use of ->branchcode to ->{branchcode} for unblessed hashref version of Koha::Library Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:29:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:29:37 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 --- Comment #4 from Kyle M Hall --- (In reply to Aleisha Amohia from comment #3) Aleisha, all the tests pass on my test server. Can you try running the tests on a clean installation of Koha with just the default data installed? If they pass for you that way, it means I need to fix my db assumptions for my unit tests. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:34:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:34:59 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 --- Comment #7 from vimal kumar --- (In reply to Owen Leonard from comment #6) > Which reader do you want to save time for? The reader who wants to see the > list of checkouts right away or the reader who wants to have the page load > quickly when there are hundreds of checkouts? The point of this bug is to > make a new preference so you can have it either leave things the way they > are now or return them to the way things were before the changes made by Bug > 12550. A preference is the only way to give options to the various needs > different librarians have expressed. After check out, library professionals have the tendency to check the list of books checked out. If the list hide , they have to click on the checkbox of ("Always show checkouts immediately"). when the library professional open Check out of a particular user, he has to click on "Always show checkouts immediately" option. this process is time consuming when good number of reader in que to check out the books. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:39:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:39:18 +0000 Subject: [Koha-bugs] [Bug 15749] Add library menu to OPAC header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749 --- Comment #3 from Owen Leonard --- Created attachment 47714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47714&action=edit Screenshot of interface idea Is this "needs signoff?" My apologies if these comments are premature: Functionally this looks like it's working well. I think the interface needs some more thought though. Some comments: - I think the use of the "home" icon is potentially confusing, especially at narrow browser widths (and therefore mobile screens). I think many users would assume that a home icon means a home link. - There is nothing to indicate to the user what the menu does. That's a very big problem. My initial impression is that this is more like a setting, and should be treated more like a setting. It's also contextual information, like the display of the logged-in user's name. So it needs to orient the user and convey that it is a setting which can be modified. It might work better if we move it over to the right. See attached screenshot. Changing the text could give the user some idea about what it's for. The default state might be "Searching all libraries." For that matter, the "Clear selection" button might also say "Search all libraries." I'm not sure how to incorporate that into the display when the user is logged in. Maybe put it in a drop-down menu triggered by the logged-in user's name? A split button where the default action is a link to opac-user.pl? I'm not sure what the right solution is, but I think this needs more thought. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 17:46:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 16:46:17 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 --- Comment #8 from Owen Leonard --- (In reply to vimal kumar from comment #7) > when the library professional open Check out of a particular user, he has to > click on "Always show checkouts immediately" option. this process is time > consuming It sounds to me like this bug is exactly what you want: A way to make it so that "Always show checkouts immediately" is globally enabled without a checkbox. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 19:35:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 18:35:30 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #10 from bondiurbano --- (In reply to Holger Mei?ner from comment #8) > (In reply to bondiurbano from comment #2) > > "No renewal before" is an optional setting so it could be absent in the > > rule. > > Yes, but bug 14101 introduced a fallback. If the setting is absent (undef) > then automatic renewal works just like "No renewal before" was zero. Do you > get different results with undef and zero?? > > > Automatic_renewals.pl must be executed BEFORE the item date_due > > expires. > I think this cannot be done with a cron job running just once or a few times > per day. Due date might be any time of the day, especially with hourly loans. > > > Otherwise it will be a due item and so OverduesBlockRenewing will > > block it. > Yes, but I suppose that is exactly what should happen, if the patron has > both automatic and manual loans and some of the manual loans are overdue? > > But I see the problem! It should renew if ONLY automatic renewals are > overdue! So maybe that's the solution. Check if all overdue loans are > automatic, then override the block? > > I need to think about it some more, but does think this makes sense? :) Holger, I've attached a PDF file with 3 days test. Hope this helps. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 19:36:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 18:36:57 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #11 from bondiurbano --- Created attachment 47715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47715&action=edit No renewal before test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 19:58:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 18:58:49 +0000 Subject: [Koha-bugs] [Bug 15750] New: Koha offline circulation Firefox addon does not prompt to clear old entries Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15750 Bug ID: 15750 Summary: Koha offline circulation Firefox addon does not prompt to clear old entries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: contribs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: fridolin.somers at biblibre.com, koha-bugs at lists.koha-community.org, testopia at bugs.koha-community.org If this description is up to date: https://lists.katipo.co.nz/public/koha/2012-May/032825.html ...when I open the KOCT for the first time in a browser session (?) I should be prompted to clear old transactions. I don't find this to be the case. I get no prompt. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 20:05:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 19:05:29 +0000 Subject: [Koha-bugs] [Bug 15751] New: Koha offline circulation Firefox addon does not update last seen date for check-ins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751 Bug ID: 15751 Summary: Koha offline circulation Firefox addon does not update last seen date for check-ins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: contribs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: fridolin.somers at biblibre.com, koha-bugs at lists.koha-community.org, testopia at bugs.koha-community.org When I check in something using the KOCT the last seen date is not updated. It does update the last seen date upon checkout, for what it's worth. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 20:53:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 19:53:54 +0000 Subject: [Koha-bugs] [Bug 15752] New: Automatically switch patron during circulation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Bug ID: 15752 Summary: Automatically switch patron during circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: chad at pennmanor.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Our library staff requested that koha automatically switch patrons when a patron barcode is scanned into the item barcode field during circulation. They frequently have large number of kids line up to checkout books and wanted this feature to speed up the process. I have implemented a patch that enables this functionality. To test: - Disable the autoswitchpatron system preference. - Go to the "Check out" section of a patron "circ/circulation.pl" - Enter a patron barcode into item barcode field. - You should get a message about the barcode not being found - Enable autoswitchpatron preference - Enter a patron barcode into the item barcode field - You should be redirected to that patron's circulation page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 20:57:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 19:57:49 +0000 Subject: [Koha-bugs] [Bug 12688] Better IntranetNav In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12688 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com Resolution|--- |WORKSFORME Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 21:00:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 20:00:26 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch patron during circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #1 from chad at pennmanor.net --- Created attachment 47716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47716&action=edit Bug 15752 - Automatically switch patron during circulation With this syspref enabled scanning a patron barcode into the item barcode field during circulation will redirect you to the patron's circulation page. This allows circulation with only a barcode scanner. Testing: - Enable the AutoSwitchPatron syspref - Navigate to a patron's check out screen - Enter a patron barcode into the "Enter item barcode" field Result - Browser should be redirected to the entered patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 21:13:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 20:13:39 +0000 Subject: [Koha-bugs] [Bug 7967] Z39.50 client should negotiate encoding with server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 21:19:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 20:19:39 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |In Discussion --- Comment #19 from M. Tompsett --- (In reply to Marcel de Rooy from comment #18) > Bug 14544 also introduces a Koha::Exceptions module. > Has there been any interaction between the authors about the road to follow? This patch still applies, but there is no "t/Exceptions.t" test file. I think this should be required for a sign off, in addition to answering Marcel's question, since that bug (14544) has been pushed to master. Changing status to 'In Discussion' (to be doomed for all eternity! -- since that is what most 'In Discussion' bugs do) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 21:28:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 20:28:03 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #191 from Nick Clemens --- Hi all, I just got the elastic branch setup on kohadevbox and am eager to do some testing, I am just wondering if there is anywhere specific we are poking yet, or just a general 'try to break it'/'figure out what it doesn't do' Searching definitely feels faster, even on a 100 record db. I do same to be able to switch between zebra and elastic with an issue once they are up and running which is very useful In just poking for now I spot 2 things: 1 - I don't seem to able to edit/add records. I get an error: Can't locate object method "field" via package "..folowed by full marcxml for record 2 - Searching doesn't automatically truncate/stem. i.e. to search 'Char' and get 'Charles' I have to search for 'Char*' and when I do highligthing doesn't work I am excited to do more testing, just want to know what the goals are to get this in shape to make it in to Koha so I can focus on hitting those pieces. -Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 5 23:27:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 22:27:48 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #9 from M. Tompsett --- Please rebase. Also, opac minified CSS is going to conflict regularly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 00:14:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 23:14:01 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46215|0 |1 is obsolete| | --- Comment #41 from Indranil Das Gupta --- Created attachment 47717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47717&action=edit Bug 14097: Fixed missing test cases Fixed AllowPkiAuth issue caused by 15101. Added missing AudioAlerts TEST PLAN --------- 1) prove -v t/db_dependent/UsageStats.t -- should pass after applying patch 2) Run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 00:17:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 23:17:00 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 00:34:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 23:34:06 +0000 Subject: [Koha-bugs] [Bug 15753] New: String update in the README for qa-test-tools Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15753 Bug ID: 15753 Summary: String update in the README for qa-test-tools Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Command-line Utilities Assignee: indradg at gmail.com Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Line no. 25 in the README should read as "$ sudo apt-get install codespell" instead of "$ apt-get install codespell" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 00:41:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 23:41:29 +0000 Subject: [Koha-bugs] [Bug 15753] String update in the README for qa-test-tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15753 --- Comment #1 from Indranil Das Gupta --- Created attachment 47718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47718&action=edit Bug 15753: String update in the README for qa-test-tools Trivial string patch. Adds "sudo" to "$ apt-get install codespell" on line number 25 of the README file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 00:42:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 23:42:24 +0000 Subject: [Koha-bugs] [Bug 15753] String update in the README for qa-test-tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15753 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 00:51:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Feb 2016 23:51:51 +0000 Subject: [Koha-bugs] [Bug 15753] String update in the README for qa-test-tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15753 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 01:05:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 00:05:54 +0000 Subject: [Koha-bugs] [Bug 15719] Silence warning in C4/Language.pm during web install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 01:27:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 00:27:51 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 03:28:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 02:28:05 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #14 from Bob Birchall --- (In reply to Kyle M Hall from comment #13) > The current plan is to make this work with minimal or no changes! You can > check out the mailing list thread for the on-going discussion. For me, the discussion has led to a great outcome. I'm happy for this to proceed. Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 04:16:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 03:16:44 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47717|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 04:25:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 03:25:48 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46212|0 |1 is obsolete| | --- Comment #42 from Indranil Das Gupta --- Created attachment 47719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47719&action=edit Bug 14097 - Correct noise under Debian The first four patches do not create any noise under Ubuntu 14.04 LTS. Running on Debian Jessie: [SNIP] keys on reference is experimental at t/db_dependent/UsageStats.t line 88. keys on reference is experimental at t/db_dependent/UsageStats.t line 106. keys on reference is experimental at t/db_dependent/UsageStats.t line 119. keys on reference is experimental at t/db_dependent/UsageStats.t line 136. keys on reference is experimental at t/db_dependent/UsageStats.t line 153. keys on reference is experimental at t/db_dependent/UsageStats.t line 162. keys on reference is experimental at t/db_dependent/UsageStats.t line 587. [SNIP] Instead of having 'keys $foo->{bar}', 'keys %{$foo->{bar}}' was used. TEST PLAN --------- 1) On a DEBIAN system (Jessie gives above messages) apply the first 4 patches interactively. 2) $ prove t/db_dependent/UsageStats.t -- trigger noise like above. 3) apply this patch 4) $ prove t/db_dependent/UsageStats.t -- no noise triggered. 5) koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 04:27:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 03:27:51 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46213|0 |1 is obsolete| | --- Comment #43 from Indranil Das Gupta --- Created attachment 47720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47720&action=edit Bug 14097 : Avoid issue if the number of syspref shared is modified Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 04:29:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 03:29:09 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46214|0 |1 is obsolete| | --- Comment #44 from Indranil Das Gupta --- Created attachment 47721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47721&action=edit Bug 14097 : Changing AddReserve prototype call In response of Joubu comment #19 Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 04:34:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 03:34:34 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47717|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 04:41:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 03:41:43 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47719|0 |1 is obsolete| | --- Comment #45 from Indranil Das Gupta --- Created attachment 47722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47722&action=edit Bug 14097 - Correct noise under Debian The first four patches do not create any noise under Ubuntu 14.04 LTS. Running on Debian Jessie: [SNIP] keys on reference is experimental at t/db_dependent/UsageStats.t line 88. keys on reference is experimental at t/db_dependent/UsageStats.t line 106. keys on reference is experimental at t/db_dependent/UsageStats.t line 119. keys on reference is experimental at t/db_dependent/UsageStats.t line 136. keys on reference is experimental at t/db_dependent/UsageStats.t line 153. keys on reference is experimental at t/db_dependent/UsageStats.t line 162. keys on reference is experimental at t/db_dependent/UsageStats.t line 587. [SNIP] Instead of having 'keys $foo->{bar}', 'keys %{$foo->{bar}}' was used. TEST PLAN --------- 1) On a DEBIAN system (Jessie gives above messages) apply the first 4 patches interactively. 2) $ prove t/db_dependent/UsageStats.t -- trigger noise like above. 3) apply this patch 4) $ prove t/db_dependent/UsageStats.t -- no noise triggered. 5) koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 04:43:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 03:43:10 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47720|0 |1 is obsolete| | --- Comment #46 from Indranil Das Gupta --- Created attachment 47723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47723&action=edit Bug 14097 : Avoid issue if the number of syspref shared is modified Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 04:54:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 03:54:27 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47722|0 |1 is obsolete| | --- Comment #47 from Indranil Das Gupta --- Created attachment 47724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47724&action=edit Bug 14097 - Correct noise under Debian The first four patches do not create any noise under Ubuntu 14.04 LTS. Running on Debian Jessie: [SNIP] keys on reference is experimental at t/db_dependent/UsageStats.t line 88. keys on reference is experimental at t/db_dependent/UsageStats.t line 106. keys on reference is experimental at t/db_dependent/UsageStats.t line 119. keys on reference is experimental at t/db_dependent/UsageStats.t line 136. keys on reference is experimental at t/db_dependent/UsageStats.t line 153. keys on reference is experimental at t/db_dependent/UsageStats.t line 162. keys on reference is experimental at t/db_dependent/UsageStats.t line 587. [SNIP] Instead of having 'keys $foo->{bar}', 'keys %{$foo->{bar}}' was used. TEST PLAN --------- 1) On a DEBIAN system (Jessie gives above messages) apply the first 4 patches interactively. 2) $ prove t/db_dependent/UsageStats.t -- trigger noise like above. 3) apply this patch 4) $ prove t/db_dependent/UsageStats.t -- no noise triggered. 5) koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 04:55:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 03:55:51 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47723|0 |1 is obsolete| | --- Comment #48 from Indranil Das Gupta --- Created attachment 47725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47725&action=edit Bug 14097 : Avoid issue if the number of syspref shared is modified Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 04:57:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 03:57:15 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47721|0 |1 is obsolete| | --- Comment #49 from Indranil Das Gupta --- Created attachment 47726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47726&action=edit Bug 14097 : Changing AddReserve prototype call In response of Joubu comment #19 Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 04:58:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 03:58:31 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47717|0 |1 is obsolete| | --- Comment #50 from Indranil Das Gupta --- Created attachment 47727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47727&action=edit Bug 14097: Fixed missing test cases Fixed AllowPkiAuth issue caused by 15101. Added missing AudioAlerts TEST PLAN --------- 1) prove -v t/db_dependent/UsageStats.t -- should pass after applying patch 2) Run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 12:30:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 11:30:12 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 12:30:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 11:30:15 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47479|0 |1 is obsolete| | Attachment #47480|0 |1 is obsolete| | Attachment #47481|0 |1 is obsolete| | Attachment #47482|0 |1 is obsolete| | Attachment #47483|0 |1 is obsolete| | Attachment #47484|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 47728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47728&action=edit Bug 15707 - Add Treegrid library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 12:30:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 11:30:24 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #8 from Kyle M Hall --- Created attachment 47729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47729&action=edit Bug 15707 - Update DB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 12:30:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 11:30:27 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #9 from Kyle M Hall --- Created attachment 47730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47730&action=edit Bug 15707 - Add new modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 12:30:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 11:30:29 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #10 from Kyle M Hall --- Created attachment 47731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47731&action=edit Bug 15707 - Add editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 12:30:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 11:30:31 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #11 from Kyle M Hall --- Created attachment 47732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47732&action=edit Bug 15707 - Add and update schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 12:30:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 11:30:33 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #12 from Kyle M Hall --- Created attachment 47733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47733&action=edit Bug 15707 - Add TreeGrid library to about page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 12:30:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 11:30:36 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #13 from Kyle M Hall --- Created attachment 47734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47734&action=edit Bug 15707 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 20:59:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 19:59:04 +0000 Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #62 from Magnus Enger --- Will this patch make it possible to configure LDAPS? I'm an LDAP noob, but working with a customer I have managed to get LDAPS working, by changing line 109 of C4/Auth_with_ldap.pm +109 from this: my $db = Net::LDAP->new(\@hosts); to this: my $db = Net::LDAP->new(\@hosts, version => 3, scheme => 'ldaps', port => 123, capath => '/usr/ssl/certs'); As far as I can tell, this patch does not touch that line, but I might be missing something... If this patch does not make LDAPS configurable, and if noone objects loudly, I'll do a patch on another bug that makes it possible to set version, scheme, port and capath in koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 6 21:17:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Feb 2016 20:17:28 +0000 Subject: [Koha-bugs] [Bug 12015] google map of branches and availability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12015 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 7 21:25:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Feb 2016 20:25:00 +0000 Subject: [Koha-bugs] [Bug 7152] Koha should make it easy for librarians to attach covers using Open Library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7152 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 7 21:26:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Feb 2016 20:26:16 +0000 Subject: [Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 7 21:26:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Feb 2016 20:26:38 +0000 Subject: [Koha-bugs] [Bug 9500] GetNormalizedISBN only ever checks the first populated ISBN field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9500 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 7 21:31:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Feb 2016 20:31:28 +0000 Subject: [Koha-bugs] [Bug 15715] Import authorities from z39.50 hangs on import of authority record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15715 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 02:15:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 01:15:20 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 --- Comment #35 from David Cook --- (In reply to Mason James from comment #34) > hiya, are you running this follow-up patch? > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15035 Alas, I don't have access to see that security bug :/. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 02:18:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 01:18:14 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 --- Comment #36 from David Cook --- (In reply to Christopher Vella from comment #31) > Potentially the bot could be trying input forms at random, or more advanced > and only reading through the visible elements of the page. > Yeah, I think there are a few different things it could be. I'd love to know what data is being sent exactly. > Rather than go down the positive captcha route yet. We could attempt to make > this negcaptcha smarter. Totally agree. I'm absolutely on board for that. > One idea could be to IP ban any user who submits > content to that form (I don't see any reason why a normal user would). I'm not sure I understand what you mean here. When the user fills out the form, their browser would be POSTing the data to the Koha server, so it would be something a normal user would do. > We could also have the field name randomise per instance. Maybe. I'd be interested to see how other people are solving this problem out in the world. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 08:35:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 07:35:02 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 --- Comment #37 from Katrin Fischer --- (In reply to David Cook from comment #35) > (In reply to Mason James from comment #34) > > hiya, are you running this follow-up patch? > > > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15035 > > Alas, I don't have access to see that security bug :/. Fixed :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 09:00:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 08:00:10 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Marcel de Rooy --- Let's get this one moving.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 09:14:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 08:14:01 +0000 Subject: [Koha-bugs] [Bug 15749] Add library menu to OPAC header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #4 from Zeno Tajoli --- Why don't use 'OpacAddMastheadLibraryPulldown' sys pref ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 10:33:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 09:33:40 +0000 Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13799 |15126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 [Bug 15126] REST?API: Use newer version of Swagger2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 10:33:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 09:33:40 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13903 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 [Bug 13903] Add API routes to list, create, update, delete reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 10:33:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 09:33:40 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13903 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 [Bug 13903] Add API routes to list, create, update, delete reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 12:15:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 11:15:22 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #15 from Jonathan Druart --- Switch to "In discussion' according to the ML thread. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 12:16:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 11:16:28 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 12:16:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 11:16:31 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47644|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 47735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47735&action=edit Bug 15734: Audio Alerts broken In master there is a JSON error thrown when AudioAlerts are enabled. This is caused by changes in master from bug 13618. Test Plan: 1) Enable audio alerts 2) Note audio alerts don't work 3) Apply this patch 4) Note audio alerts now work Signed-off-by: Hector Castro Works as described Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 12:19:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 11:19:23 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 12:19:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 11:19:26 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47645|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 47736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47736&action=edit Bug 15735: Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert Signed-off-by: Hector Castro Bug 15734 applied on top. Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 12:26:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 11:26:28 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #6 from Jonathan Druart --- Marc, On bug 13486, Tomas removed `apache2 -V`, to use `apache2clt -v` instead. Your patch restores the behavior prior to bug 13486: C4::Context::get_versions does not call apache2ctl. Tomas, any ideas what is the best way to fix this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 13:00:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 12:00:22 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 13:00:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 12:00:22 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 [Bug 15734] Audio Alerts broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 13:02:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 12:02:19 +0000 Subject: [Koha-bugs] [Bug 15754] New: html tags displayed when editing frameworks Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 Bug ID: 15754 Summary: html tags displayed when editing frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 13618 When editing subfields the "repeatable", "mandatory" and "is url" checkboxes are not displayed: the input html tag is displayed instead. Caused by bug 13618. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 13:02:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 12:02:19 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15754 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 [Bug 15754] html tags displayed when editing frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 13:03:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 12:03:58 +0000 Subject: [Koha-bugs] [Bug 15754] html tags displayed when editing frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 13:04:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 12:04:01 +0000 Subject: [Koha-bugs] [Bug 15754] html tags displayed when editing frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 --- Comment #1 from Jonathan Druart --- Created attachment 47737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47737&action=edit Bug 15754: Fix regression on editing framework subfields When editing subfields the "repeatable", "mandatory" and "is url" checkboxes are not displayed: the input html tag is displayed instead. Caused by bug 13618. Test plan: Edit subfields and confirm the bug. Apply the patch and confirm that you are not able to check/uncheck checkboxes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 13:07:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 12:07:07 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #208 from Julian Maurice --- Package accepted into Debian unstable: https://packages.debian.org/sid/libtemplate-stash-autoescaping-perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 13:46:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 12:46:01 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #8 from Jonathan Druart --- It does not work for me with only the first patch applied. The changes need to be made for normarc and unimarc as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 13:52:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 12:52:15 +0000 Subject: [Koha-bugs] [Bug 15749] Add library menu to OPAC header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749 --- Comment #5 from chad at pennmanor.net --- (In reply to Zeno Tajoli from comment #4) > Why don't use 'OpacAddMastheadLibraryPulldown' sys pref ? It has been a number of years since our librarians requested this feature but I think their concern with OpacAddMastheadLibaryPulldown was that it doesn't remember your search selection. If you click the Koha icon that takes you back to the home screen it defaults you to all libraries. The other advantage of this patch is the libraries can create shortcuts to the opac that sets the filter. For example they bookmark https://library.pennmanor.net/cgi-bin/koha/opac-setbranch.pl?newbranch=HAM At the time you couldn't do DNS subdomains to specific libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 14:00:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 13:00:19 +0000 Subject: [Koha-bugs] [Bug 15755] New: Default item type is not marked as "All" in circulation rules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755 Bug ID: 15755 Summary: Default item type is not marked as "All" in circulation rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 15354 Bug 15354 did not fix correctly the issue with the item type display. The default item type '*' should be "All", at the moment nothing is displayed in the column. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 [Bug 15354] item types aren't showing in default hold policies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 14:00:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 13:00:19 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755 [Bug 15755] Default item type is not marked as "All" in circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 14:02:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 13:02:36 +0000 Subject: [Koha-bugs] [Bug 15755] Default item type is not marked as "All" in circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 14:02:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 13:02:39 +0000 Subject: [Koha-bugs] [Bug 15755] Default item type is not marked as "All" in circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755 --- Comment #1 from Jonathan Druart --- Created attachment 47738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47738&action=edit Bug 15755: Display default item type as "All" in circ rules Bug 15354 did not fix correctly the issue with the item type display. The default item type '*' should be "All", at the moment nothing is displayed in the column. Test plan: 1/ Define a rule for default item types (All/*) and for specific item types. 2/ Translate some item type descriptions used in previous step 3/ Default item type should be "All" and correct translations should be displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 14:44:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 13:44:34 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #20 from Olli-Antti Kivilahti --- (In reply to M. Tompsett from comment #19) > (In reply to Marcel de Rooy from comment #18) > > Bug 14544 also introduces a Koha::Exceptions module. > > Has there been any interaction between the authors about the road to follow? > > This patch still applies, but there is no "t/Exceptions.t" test file. I > think this should be required for a sign off, in addition to answering > Marcel's question, since that bug (14544) has been pushed to master. > Changing status to 'In Discussion' (to be doomed for all eternity! -- since > that is what most 'In Discussion' bugs do) Hi! See the attached opendocument presentation about the pros and cons of the two different approaches. If you like this approach, sign off this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 14:53:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 13:53:04 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 --- Comment #14 from Olli-Antti Kivilahti --- Hi! We are upgrading our KohaSuomi branch (with 300 custom commits) built on top of Koha 3.16 to master this summer. I heard that it is "impossible". Looking forward to doing it with our soon-to-be continuous integration environment :) When this is ready, this patch is also rebased. Feel free to do it sooner. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 14:57:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 13:57:48 +0000 Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 --- Comment #12 from Olli-Antti Kivilahti --- Hi! We are targeting to upgrade our Koha to master this summer and rebase this feature. Send me an email if you need this feature and we will share the latest code for you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 14:58:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 13:58:31 +0000 Subject: [Koha-bugs] [Bug 9525] group floating rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #18 from Olli-Antti Kivilahti --- Hi! This feature work really well :) :) :) We are going to rebase it this summer (hopefully) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 14:59:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 13:59:08 +0000 Subject: [Koha-bugs] [Bug 15756] New: Some tests for haspermission in C4::Auth Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 Bug ID: 15756 Summary: Some tests for haspermission in C4::Auth Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 14:59:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 13:59:27 +0000 Subject: [Koha-bugs] [Bug 15756] Some tests for haspermission in C4::Auth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |ASSIGNED Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 15:01:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 14:01:39 +0000 Subject: [Koha-bugs] [Bug 15756] Some tests for haspermission in C4::Auth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 15:01:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 14:01:41 +0000 Subject: [Koha-bugs] [Bug 15756] Some tests for haspermission in C4::Auth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 --- Comment #1 from Marcel de Rooy --- Created attachment 47739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47739&action=edit Bug 15756: Some tests for haspermission in C4::Auth Test plan: Run this new test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 15:05:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 14:05:39 +0000 Subject: [Koha-bugs] [Bug 14748] REST API Testing framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14748 --- Comment #6 from Olli-Antti Kivilahti --- Hi! This depends on the authentication system of the REST API which was under much scrutiny last time I checked. Bug 13920 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 15:09:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 14:09:13 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15756 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 [Bug 15756] Some tests for haspermission in C4::Auth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 15:09:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 14:09:13 +0000 Subject: [Koha-bugs] [Bug 15756] Some tests for haspermission in C4::Auth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14686 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 [Bug 14686] New menu option and permission for file uploading -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 15:11:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 14:11:44 +0000 Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 --- Comment #25 from Olli-Antti Kivilahti --- (In reply to M. Tompsett from comment #22) > *ping* Is this moving forward? Don't know about the Koha-community, but we are constantly improving this feature and it works really well in practice (albeit a bit slowly). All our web-testing scripts are based on this feature and together with the Permission system rewrite We have code to rapidly deploy and receive a bunch of serials as well, but we haven't shared it yet. Also this code is for Koha 3.16. This all is aimed to enable doing web-testing in Koha in an effortless way. Bug 14536 - PageObject-pattern base implementation We are targeting to migrate to a "possibly" rolling update cycle with the Koha-community versions this summer. And these modern testing features hopefully will help us gain confidence in our codebase and enable following the community branches in semi-real time. Time will tell. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 15:13:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 14:13:35 +0000 Subject: [Koha-bugs] [Bug 12923] Improve error logging for advance_notices.pl; Show borrowernumber when no letter of type is found and force utf8 output. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12923 --- Comment #9 from Olli-Antti Kivilahti --- Happy new year to you too! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 15:14:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 14:14:26 +0000 Subject: [Koha-bugs] [Bug 15757] New: Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Bug ID: 15757 Summary: Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com A library reported recently that an item with circulation period set to 0 for all patron categories with a few exceptions set was checked out and was given a checkout period of 21 days. This comes from the last lines in the GetLoanLength subroutine: 1475 # if no rule is set => 21 days (hardcoded) 1476 return { 1477 issuelength => 21, 1478 renewalperiod => 21, 1479 lengthunit => 'days', 1480 }; 1481 This should fire a1475 # if no rule is set => 21 days (hardcoded) 1476 return { 1477 issuelength => 21, 1478 renewalperiod => 21, 1479 lengthunit => 'days', 1480 }; 1481 warning and/or stop the checkout rather than defaulting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 15:48:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 14:48:20 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 --- Comment #7 from Marc V?ron --- Hi Jonathan, I think that in that case C4::Context::get_versions should be fixed in a separate bug that blocks this Bug 15271. Note: I do not touch C4::Context::get_versions, but I use it to remove code duplication. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 16:27:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 15:27:00 +0000 Subject: [Koha-bugs] [Bug 15293] Move the C4::Branch related code to Koha::Libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 16:27:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 15:27:00 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 16:27:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 15:27:00 +0000 Subject: [Koha-bugs] [Bug 15758] New: Move the C4::Branch related code to Koha::Libraries - part 4 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Bug ID: 15758 Summary: Move the C4::Branch related code to Koha::Libraries - part 4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 15629 Blocks: 15293 This fourth and last part will remove: - GetBranchName - GetBranchesLoop - GetBranches - GetBranch will move mybranch and onlymine to C4::Context and finally remove all occurrences of C4::Branch. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 [Bug 15293] Move the C4::Branch related code to Koha::Libraries https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 16:38:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 15:38:18 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Karl Holten changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 16:53:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 15:53:02 +0000 Subject: [Koha-bugs] [Bug 15759] New: Allow Koha::Object derived objects to be used as hashrefs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 Bug ID: 15759 Summary: Allow Koha::Object derived objects to be used as hashrefs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org On occasion, bugs in Koha have been revealed to be a mis-use of Koha::Object. This seems to be due to our long standing use of hashrefs for data in Koha. For instance, a developer may accidentally write: my $borrowernumber = $borrower->{borrowernumber}; instead of my $borrowernumber = $borrower->borrowernumber; Since our object is a blessed hashref, this does not cause an error. Instead, we just access that key of the hashref, which is almost certainly undefined. With some extra code in Koha/Object.pm, we can allow hashref-like use of our Objects, which will not only prevent these errors, but allow drop-in use of Koha::Objects where we currently use hashrefs! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 16:53:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 15:53:08 +0000 Subject: [Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 16:54:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 15:54:33 +0000 Subject: [Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 16:54:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 15:54:35 +0000 Subject: [Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 --- Comment #1 from Kyle M Hall --- Created attachment 47740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47740&action=edit Bug 15759 - Allow Koha::Object derived objects to be used as hashrefs On occasion, bugs in Koha have been revealed to be a mis-use of Koha::Object. This seems to be due to our long standing use of hashrefs for data in Koha. For instance, a developer may accidentally write: my $borrowernumber = $borrower->{borrowernumber}; instead of my $borrowernumber = $borrower->borrowernumber; Since our object is a blessed hashref, this does not cause an error. Instead, we just access that key of the hashref, which is almost certainly undefined. With some extra code in Koha/Object.pm, we can allow hashref-like use of our Objects, which will not only prevent these errors, but allow drop-in use of Koha::Objects where we currently use hashrefs! Test Plan: 1) Apply this patch 2) prove t/db_dependent/Borrower.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 17:02:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 16:02:15 +0000 Subject: [Koha-bugs] [Bug 9964] Add plugins management link to the Administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9964 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #4 from Julian Maurice --- I believe those changes already have been pushed as part of bug 12412. Can we close this one ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 17:02:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 16:02:19 +0000 Subject: [Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 17:03:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 16:03:06 +0000 Subject: [Koha-bugs] [Bug 15760] New: sql injection in poac-shelves.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15760 Bug ID: 15760 Summary: sql injection in poac-shelves.pl Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: hblancoca at gmail.com QA Contact: testopia at bugs.koha-community.org In a security analisys with accunetix software can detect that opac-shelves.pl permit sql injection attack, an example can be the following: URL encoded GET input sortfield was set to if(now()=sysdate(),sleep(0),0)/*'XOR(if(now()=sysdate(),sleep(0),0))OR'"XOR(if(now()=sysdate(),sleep(0),0))OR"*/ URL encoded GET input sortfield was set to 1,(select case when (3*2*1=6 AND 000227=000227) then 1 else 1*(select table_name from information_schema.tables)end)=1 I believe that is needed to sanitize all variables in that script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 17:03:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 16:03:19 +0000 Subject: [Koha-bugs] [Bug 15760] sql injection in opac-shelves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15760 Humberto Blanco changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|sql injection in |sql injection in |poac-shelves.pl |opac-shelves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 17:07:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 16:07:05 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #9 from H?ctor Eduardo Castro Avalos --- (In reply to Jonathan Druart from comment #8) > It does not work for me with only the first patch applied. > The changes need to be made for normarc and unimarc as well. Hi Jonathan It seems to be that NORMARC does not use this index. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 17:20:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 16:20:28 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #10 from H?ctor Eduardo Castro Avalos --- Created attachment 47741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47741&action=edit Bug 15694: (followup)Update DOM index for UNIMARC/biblios Update for UNIMARC biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl To test follow the first test plan in UNIMARC environment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 17:26:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 16:26:10 +0000 Subject: [Koha-bugs] [Bug 15754] html tags displayed when editing frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 17:26:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 16:26:13 +0000 Subject: [Koha-bugs] [Bug 15754] html tags displayed when editing frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47737|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47742&action=edit [SIGNED-OFF]Bug 15754: Fix regression on editing framework subfields When editing subfields the "repeatable", "mandatory" and "is url" checkboxes are not displayed: the input html tag is displayed instead. Caused by bug 13618. Test plan: Edit subfields and confirm the bug. Apply the patch and confirm that you are not able to check/uncheck checkboxes. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 17:32:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 16:32:18 +0000 Subject: [Koha-bugs] [Bug 15756] Some tests for haspermission in C4::Auth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 17:32:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 16:32:21 +0000 Subject: [Koha-bugs] [Bug 15756] Some tests for haspermission in C4::Auth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47739|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47743&action=edit [SIGNED-OFF]Bug 15756: Some tests for haspermission in C4::Auth Test plan: Run this new test. Signed-off-by: Hector Castro All tests successful. koha-qa.pl run OK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 17:40:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 16:40:29 +0000 Subject: [Koha-bugs] [Bug 15719] Silence warning in C4/Language.pm during web install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 17:40:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 16:40:31 +0000 Subject: [Koha-bugs] [Bug 15719] Silence warning in C4/Language.pm during web install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47533|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 47744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47744&action=edit [SIGNED-OFF]Bug 15719: Silence warning in C4/Language.pm during web install Test empty database case. TEST PLAN --------- 1) prove -v t/Languages.t -- success (because test case is missing) 2) Apply this patch 3) prove -v t/Languages.t -- success, but warning printed. 4) run koha qa test tools Signed-off-by: Hector Castro Works as advertised. QA test tools rus OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 17:40:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 16:40:46 +0000 Subject: [Koha-bugs] [Bug 15719] Silence warning in C4/Language.pm during web install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47534|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 47745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47745&action=edit Bug 15719: Silence warning in C4/Language.pm during web install This problem was discovered the hard way: - Drop DB - Create DB - Webinstaller run until the screen is: We are ready to do some basic configuration. Please install basic configuration settings to continue the installation. -- The error log file will end with an error about splitting an uninitialized value. TEST PLAN --------- 0) First patch already applied 1) prove -v t/Languages.t -- success, but warn prints 2) Apply this patch 3) prove -v t/Languages.t -- success without warning messages 4) run koha qa test tools Signed-off-by: Hector Castro Works as described. QA test tools run OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 17:46:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 16:46:20 +0000 Subject: [Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 17:47:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 16:47:43 +0000 Subject: [Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 8 18:32:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Feb 2016 17:32:39 +0000 Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 --- Comment #1 from Jonathan Druart --- Created attachment 47746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47746&action=edit Bug 15758: Koha::Libraries - Remove GetBranchName This is the fourth and last patch set to remove C4::Branch. The real purpose of this patch is to standardise and refactor some code which is related to the libraries selection/display. Its unconfessed purpose is to remove the C4::Branch package. Before this patch set, only 6 subroutines still existed in the C4::Branch package: - GetBranchName - GetBranchesLoop - mybranch - onlymine - GetBranches - GetBranch GetBranchName basically returns the branchname for a given branchcode. The branchname is only used for a display purpose and we don't need to retrieve it in package or pl scripts (unless for a few exceptions). We have a `Branches` template plugin with a `GetName` method which does exactly this job. To achieve this removal, we will use this template plugin and delete the GetBranchName from pl and pm files. The `Branches.all()` will now select the library of the logged in user if no `selected` parameter has been passed. This new behavior could cause regressions, for instance there are some places where we do not want an option preselected (batch item modification for instance), keep that in mind when testing. GetBranchesLoop took 3 parameters: $branch and $onlymine. The first one was used to set a "selected" flag, for a display purpose: select an option in the libraries dropdown lists. The second one was useless: If not passed or set to 0, the `C4::Branch::onlymine` subroutine was called. This onlymine flag was use to know if the logged in user was able to see other libraries infos. A patron can see the infos from other libraries if IndependentBranches is not set OR if he has the superlibrarian permission. Prior to this patch set, the "onlymine test" was done on different places (neworderempty.pl, additem.pl, holidays.pl, etc.), including the Branches TT plugin. In this patch set, this test is only done on one place (C4::Context::only_my_library, code moved from C4::Branch::onlymine). To accomplish the same job as this subroutine, we just need to call the `Branches.all()` method from the `Branches` TT plugin. It already accepts a `selected` parameter to set a flag on the option to select. To avoid the repetitive [% IF selected %]
    . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 17:31:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 16:31:00 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 --- Comment #1 from Owen Leonard --- Created attachment 47858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47858&action=edit Bug 15784 - Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert"
    . This patch modifies the confirmation markup to match the standard. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 17:30:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 16:30:58 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 17:36:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 16:36:20 +0000 Subject: [Koha-bugs] [Bug 11498] Prevent bypassing sco timeout with print dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11498 --- Comment #2 from Marc V?ron --- Created attachment 47859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47859&action=edit Bug 11498 - Prevent bypassing sco timeout with print dialog This patch prevents bypassing the self check timeout with the print dialog. To test: - Set syspref 'WebVasedSelfCheck' to 'Enable' - Set syspref 'SelfCheckoutReceivePrompt' to 'Show' - Set syspref 'SelfCheckTimeout' to 20 seconds - Apply patch - Go to SCO page (/cgi-bin/koha/sco/sco-main.pl) - Enter card number - Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears. - Confirm printing without waiting 20 seconds => Result: Print slip, SCO page shows 'Please enter your card number' - Enter card number again - Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears. - Wait > 20 seconds (value of SelfCheckTimeout) and then confirm. => Result: Message appears "Timeout while waiting for print confirmation" - Click on OK. => Result: Self checkout page refreshes (shows 'Please enter your card number') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 17:37:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 16:37:02 +0000 Subject: [Koha-bugs] [Bug 11498] Prevent bypassing sco timeout with print dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11498 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 17:49:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 16:49:52 +0000 Subject: [Koha-bugs] [Bug 15567] Update API to allow multiple holds for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15567 --- Comment #1 from Alex Arnaud --- Created attachment 47860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47860&action=edit Bug 15567 - Allow to place multiple at once via RESTFUL Test plan: Same tests than Bug 15565 but via RESTFUL -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 17:51:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 16:51:36 +0000 Subject: [Koha-bugs] [Bug 15567] Update API to allow multiple holds for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15567 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 18:11:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 17:11:20 +0000 Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #4 from Marc V?ron --- Testing on current master: Staff member with circulate_remaining_permissions is able to print slip and quick slip only. To print summary, borrowers permission has to be set. (members-toolbar.inc line 160) Question: Should a staff member with circulate_remaining_permissions be able to print the summary? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 18:11:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 17:11:57 +0000 Subject: [Koha-bugs] [Bug 3288] Transit prompt not immediately triggered after hold is canceled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3288 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 18:12:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 17:12:25 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #8 from Owen Leonard --- (In reply to M. Tompsett from comment #5) > I pity people who actually use this regularly, because unless someone has > broken their skull open to actually get it to work, it is an awful piece of > software. This comment isn't helpful and is profoundly disrespectful to those who have spent time working on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 18:12:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 17:12:42 +0000 Subject: [Koha-bugs] [Bug 15748] Koha offline circulation Firefox addon saves transactions in incorrect timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15748 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 15764 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 18:12:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 17:12:42 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #9 from Owen Leonard --- *** Bug 15748 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 18:22:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 17:22:48 +0000 Subject: [Koha-bugs] [Bug 15730] 500 error on returns.pl if barcode doesn't exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 18:26:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 17:26:50 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47832|0 |1 is obsolete| | --- Comment #10 from Owen Leonard --- Created attachment 47861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47861&action=edit [SIGNED-OFF] Bug 15764: Fix timestamp sent by KOCT KOCT plugin send UTC timestamp, it should be converted to local timezone Test plan: 1. Install latest version of KOCT and configure it https://addons.mozilla.org/fr/firefox/addon/koct/ https://wiki.koha-community.org/wiki/Offline_circulation_firefox_plugin 2. Use it to do a checkout and a checkin. See that timestamps are UTC. 3. Click on "Commit to Koha" under "Log" tab 4. Wait for all operations to be processed 5. In Koha, go to Circulation > Offline circulation and check the timestamps were correctly converted to the Koha server's timezone 6. Process the pending operations and see that timestamps are still correct 7. Repeat step 2 8. Now click on "Apply directly" 9. Check the timestamps are correct in Koha NOTE: I could not get "Commit to Koha" to work for me, but I did confirm this corrected behaviour with "Apply directly". Signed-off-by: Mark Tompsett Signed-off-by: Owen Leonard Using the "commit to Koha" option works fine for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 18:41:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 17:41:18 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #25 from Jonathan Druart --- (In reply to Mirko Tietgen from comment #23) > In master, creating authorities from z39.50 runs forever now, see 15715. Is > that a side effect of these patches? For the record, bug 15715 is not linked at all to this patchset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 18:44:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 17:44:41 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #17 from Marc V?ron --- Sorry, patch does not apply: Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Installer/PerlDependencies.pm CONFLICT (content): Merge conflict in C4/Installer/PerlDependencies.pm Auto-merging C4/Auth.pm Failed to merge in the changes. Additionally, I think that the new function in C4/Auth.pm would need some testing in t/db_dependent/Auth.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 19:01:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 18:01:34 +0000 Subject: [Koha-bugs] [Bug 15765] Request to replace borrowernumber list by cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15765 --- Comment #4 from Chris Nighswonger --- Created attachment 47862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47862&action=edit Attempt to add a non-existent borrower number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 19:01:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 18:01:54 +0000 Subject: [Koha-bugs] [Bug 15765] Request to replace borrowernumber list by cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15765 --- Comment #5 from Chris Nighswonger --- (In reply to Heinrich Hartl from comment #2) > I tried to make > clear that a borrower number entered is not yet validated (existing > borrower?). For this reason borrower numbers are no better than barcodes, > both need validation. Maybe I'm misunderstanding what you mean by "not validated" in the context above. But the way in which borrowers are added to a batch is by selecting them from patron search results. Because of this, one cannot add a "non-existent" borrower number to a batch. If you attempt to add an "invalid" borrower number via cgi call such as this: cgi-bin/koha/patroncards/edit-batch.pl?borrower_number=10000&batch_id=738&op=add The script will return an error like the one on the attached screen shot. However, adding the patron barcode to the batch display should be straightforward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 19:22:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 18:22:16 +0000 Subject: [Koha-bugs] [Bug 15785] New: Use Font Awesome icons in confirmation dialogs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Bug ID: 15785 Summary: Use Font Awesome icons in confirmation dialogs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Created attachment 47863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47863&action=edit Screenshot showing the kind of dialog to be modified Some (non-JavaScript) dialogs in Koha show a pair of Yes/No buttons styled with "approve"/"deny" classes which use image files for the icon. These could instead be styled using Font Awesome icons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 19:24:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 18:24:57 +0000 Subject: [Koha-bugs] [Bug 15778] desired feature: Patron property "needs patron card (re)print" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15778 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 19:32:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 18:32:23 +0000 Subject: [Koha-bugs] [Bug 15786] New: specify a default framework on a per-login basis Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15786 Bug ID: 15786 Summary: specify a default framework on a per-login basis Change sponsored?: Seeking cosponsors Product: Koha Version: master Hardware: All URL: http://devs.bywatersolutions.com/projects/default-fram eworks/ OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Goal of development: To be able to specify a default framework on a per-login basis Work to be done: 1) Add new field ?frameworkcode? to table ?borrowers? 2) Revail in the patron editor as ?Preferred framework? 3) Make the selected framework the default for new records 4) If editing existing record that does not match preferred framework, pop up confirmation dialog asking/warning to switch to new framework Looking for sponsors here: http://devs.bywatersolutions.com/projects/default-frameworks/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 19:35:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 18:35:29 +0000 Subject: [Koha-bugs] [Bug 15787] New: Show and export itemnumber and biblionumber via the item search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15787 Bug ID: 15787 Summary: Show and export itemnumber and biblionumber via the item search Change sponsored?: Seeking cosponsors Product: Koha Version: master Hardware: All URL: http://devs.bywatersolutions.com/projects/item-search/ OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Show and export itemnumber and biblionumber via the item search in the staff client. Work to be done : Add columns for itemnumber and biblionumber to results of item search Add columns for itemnumber and biblionumber to csv export of results of item search Make columns customizable using the column admin Looking for sponsors here: http://devs.bywatersolutions.com/projects/item-search/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 19:46:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 18:46:19 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 --- Comment #18 from Kyle M Hall --- Created attachment 47864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47864&action=edit Bug 14575 [QA Followup] - Make the use of TT a controllable switch, hide it behind a syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 19:46:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 18:46:45 +0000 Subject: [Koha-bugs] [Bug 14575] OPACURLOpenInNewWindow should apply to item-level urls too In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14575 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #47864|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 19:47:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 18:47:06 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #16 from Kyle M Hall --- Created attachment 47865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47865&action=edit Bug 14757 [QA Followup] - Make the use of TT a controllable switch, hide it behind a syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 19:48:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 18:48:53 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 19:48:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 18:48:56 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47865|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 47866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47866&action=edit Bug 14757 [QA Followup] - Make the use of TT a controllable switch, hide it behind a syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 19:49:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 18:49:02 +0000 Subject: [Koha-bugs] [Bug 15788] New: Split borrowers permission into create/edit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Bug ID: 15788 Summary: Split borrowers permission into create/edit Change sponsored?: Seeking cosponsors Product: Koha Version: master Hardware: All URL: http://devs.bywatersolutions.com/projects/patron-edit- permission/ OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Goal : Add ability to control if a staff user can create new patrons vs editing existing patrons Work to be done: 1) Add new borrowers sub-permission ?modify? 2) Add new borrowers sub-permission ?create? 3) Implement new permissions for patron editor/creator Looking for sponsors here: http://devs.bywatersolutions.com/projects/patron-edit-permission/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 19:54:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 18:54:20 +0000 Subject: [Koha-bugs] [Bug 15789] New: Split borrowers permission into create/edit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15789 Bug ID: 15789 Summary: Split borrowers permission into create/edit Change sponsored?: Seeking cosponsors Product: Koha Version: master Hardware: All URL: http://devs.bywatersolutions.com/projects/fine-overrid es/ OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Goal: Add ability to control if an individual staff user can override checkout restriction based on noissuescharge Work to be done: 1) Add new permission allow_fine_override 2) Set new permission for existing staff members with setting for AllowFineOverride 3) Remove use of AllowFineOverride, replace with use of new permission allow_fine_override Looking for sponsors here: http://devs.bywatersolutions.com/projects/fine-overrides/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:03:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:03:34 +0000 Subject: [Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 Cindy Murdock Ames changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock at ccfls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:05:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:05:18 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Cindy Murdock Ames changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock at ccfls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:06:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:06:12 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #11 from M. Tompsett --- PROBLEM! The desktop version does not do UTC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:08:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:08:31 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:08:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:08:33 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47867&action=edit [SIGNED-OFF]Bug 15784: Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert"
    . This patch modifies the confirmation markup to match the standard. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:08:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:08:55 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Attachment #47858|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:10:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:10:17 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47849|0 |1 is obsolete| | --- Comment #29 from M. Tompsett --- Created attachment 47868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47868&action=edit [SIGNED-OFF] Bug 15707 - Add Treegrid library Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:10:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:10:28 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47850|0 |1 is obsolete| | --- Comment #30 from M. Tompsett --- Created attachment 47869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47869&action=edit [SIGNED-OFF] Bug 15707 - Update DB Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:10:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:10:37 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47851|0 |1 is obsolete| | --- Comment #31 from M. Tompsett --- Created attachment 47870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47870&action=edit [SIGNED-OFF] Bug 15707 - Add new modules Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:10:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:10:47 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47852|0 |1 is obsolete| | --- Comment #32 from M. Tompsett --- Created attachment 47871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47871&action=edit [SIGNED-OFF] Bug 15707 - Add editor Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:10:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:10:55 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47853|0 |1 is obsolete| | --- Comment #33 from M. Tompsett --- Created attachment 47872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47872&action=edit [SIGNED-OFF] Bug 15707 - Add and update schema files Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:11:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:11:05 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47854|0 |1 is obsolete| | --- Comment #34 from M. Tompsett --- Created attachment 47873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47873&action=edit [SIGNED-OFF] Bug 15707 - Add TreeGrid library to about page Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:11:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:11:13 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47855|0 |1 is obsolete| | --- Comment #35 from M. Tompsett --- Created attachment 47874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47874&action=edit [SIGNED-OFF] Bug 15707 - Unit Tests Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:13:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:13:12 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #36 from M. Tompsett --- Failed test case is corrected. Prove works fine. About is there. Applies nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:18:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:18:45 +0000 Subject: [Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Aleisha Amohia --- I don't think this works - says Total amount outstanding is now 0.00 in the Pay Fines tab even though there is a credit amount when I try to pay back the credit amount. Then says You must pay a value less than or equal to 0.00 with any amount I try to put in. Also there is a merge conflict in C4/Members.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:20:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:20:43 +0000 Subject: [Koha-bugs] [Bug 15776] "Return to where you were before" in sysprefs doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15776 --- Comment #1 from Marc V?ron --- Created attachment 47875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47875&action=edit Bug 15776: "Return to where you were before" in sysprefs doesn't work This patch fixes "Return to where you were before" in sysprefs To test: - Apply patch - Go to Admin - System Preferences - Click on any tab except for Acquisitions (since this is the default tab to go to) - Do a search in the sysprefs toolbar with spelling mistakes so that it will return no results and you are taken to the Acquisitions tab - Click the 'Return to where you were before link' in the error message - Verify that you are taken back to the correct tab -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:21:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:21:17 +0000 Subject: [Koha-bugs] [Bug 15776] "Return to where you were before" in sysprefs doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15776 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |veron at veron.ch Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Severity|enhancement |trivial Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:30:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:30:44 +0000 Subject: [Koha-bugs] [Bug 15776] "Return to where you were before" in sysprefs doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15776 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:30:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:30:47 +0000 Subject: [Koha-bugs] [Bug 15776] "Return to where you were before" in sysprefs doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15776 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47875|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 47876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47876&action=edit [SIGNED-OFF] Bug 15776: "Return to where you were before" in sysprefs doesn't work This patch fixes "Return to where you were before" in sysprefs To test: - Apply patch - Go to Admin - System Preferences - Click on any tab except for Acquisitions (since this is the default tab to go to) - Do a search in the sysprefs toolbar with spelling mistakes so that it will return no results and you are taken to the Acquisitions tab - Click the 'Return to where you were before link' in the error message - Verify that you are taken back to the correct tab Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:34:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:34:15 +0000 Subject: [Koha-bugs] [Bug 11560] Untranslatable "Close" in greybox popup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11560 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |veron at veron.ch Resolution|--- |FIXED --- Comment #2 from Marc V?ron --- (In reply to Aleisha Amohia from comment #1) > Is this still valid? The "Close" is coded in > /koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt I tested, the bug is no longer valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:34:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:34:39 +0000 Subject: [Koha-bugs] [Bug 11560] Untranslatable "Close" in greybox popup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11560 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:44:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:44:01 +0000 Subject: [Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41647|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 47877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47877&action=edit Bug 14672 - Payment is not able to done, when the patron has credit balance Enables paying with credit, at least when using C4::Accounts::recordpayment function. Sponsored-by Vaara-kirjastot Amended to make patch apply. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 20:57:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 19:57:02 +0000 Subject: [Koha-bugs] [Bug 15789] New permission for fine overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15789 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Split borrowers permission |New permission for fine |into create/edit |overrides CC| |veron at veron.ch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 21:03:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 20:03:04 +0000 Subject: [Koha-bugs] [Bug 13778] lists buttons ugly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 21:07:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 20:07:48 +0000 Subject: [Koha-bugs] [Bug 15790] New: Don't delete a MARC framework if existing records use that framework Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Bug ID: 15790 Summary: Don't delete a MARC framework if existing records use that framework Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/biblio_framework.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In contrast with item types, where you cannot delete an item type if existing records use it, Koha will let you delete a MARC framework even if there are existing records which use that framework code. I think the correct behavior is to prevent the user from proceeding with the deletion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 21:14:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 20:14:37 +0000 Subject: [Koha-bugs] [Bug 15791] New: Don't delete a fund if existing orders are linked to it Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15791 Bug ID: 15791 Summary: Don't delete a fund if existing orders are linked to it Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/aqbudgets.pl?op=delete_confirm OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org When you go to delete a fund Koha displays this message in the confirmation dialog: "If you delete this fund, all orders linked to this fund will be deleted!" The error appears even if there are no orders linked to the fund. In order to be consistent we ought to warn the user only if existing orders will be deleted. Should it even be possible to delete a fund if there are orders linked to it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 21:20:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 20:20:01 +0000 Subject: [Koha-bugs] [Bug 15000] Adding patron card images with duplicate descriptions causes data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15000 --- Comment #3 from Liz Rea --- "but we shouldn't depend on the user to do this." I really think we should not paper over this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 21:33:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 20:33:31 +0000 Subject: [Koha-bugs] [Bug 15000] Adding patron card images with duplicate descriptions causes data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15000 --- Comment #4 from Chris Nighswonger --- I agree with Liz, some quick validation should be run and a pop-up or some such presented with a warning confirming the overwrite. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 21:45:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 20:45:41 +0000 Subject: [Koha-bugs] [Bug 15000] Adding patron card images with duplicate descriptions causes data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15000 --- Comment #5 from Liz Rea --- Alternatively I suppose we could generate a unique description for each image if one is not provided. I feel like we shouldn't ever be just losing data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 21:46:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 20:46:52 +0000 Subject: [Koha-bugs] [Bug 13778] lists buttons ugly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 21:46:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 20:46:55 +0000 Subject: [Koha-bugs] [Bug 13778] lists buttons ugly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778 --- Comment #3 from Aleisha Amohia --- Created attachment 47878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47878&action=edit Bug 13778: Putting patron lists buttons into a dropdown menu To test: 1) Go to Tools -> Patron lists 2) If there are no lists, confirm there is a message box saying 'There are no patron lists.' 3) Create a list if you do not already have one. 4) Confirm that in the 'Actions' drop down menu next to the list, the options to 'Add patrons', 'Edit', 'Delete', and 'Print patron cards' are all there and work as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 21:47:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 20:47:44 +0000 Subject: [Koha-bugs] [Bug 13778] lists buttons ugly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 21:48:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 20:48:13 +0000 Subject: [Koha-bugs] [Bug 13778] lists buttons ugly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47878|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 47879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47879&action=edit Bug 13778: Putting patron lists buttons into a dropdown menu To test: 1) Go to Tools -> Patron lists 2) If there are no lists, confirm there is a message box saying 'There are no patron lists.' 3) Create a list if you do not already have one. 4) Confirm that in the 'Actions' drop down menu next to the list, the options to 'Add patrons', 'Edit', 'Delete', and 'Print patron cards' are all there and work as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 21:54:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 20:54:11 +0000 Subject: [Koha-bugs] [Bug 13508] Tags review page: Buttons "Approve" an "Reject" in table should display on same line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13508 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Aleisha Amohia --- This has been fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 21:54:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 20:54:39 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #7 from M. Tompsett --- Confirmed that koha-common does not install on Ubuntu 16.04 nightly build. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 22:43:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 21:43:37 +0000 Subject: [Koha-bugs] [Bug 15792] New: Double-clicking the 'renew' button on circulation.pl will double-charge account management fee Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15792 Bug ID: 15792 Summary: Double-clicking the 'renew' button on circulation.pl will double-charge account management fee Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com PREREQUISITES 1) Create an account type that has an enrollment fee, and create a borrower of that type. 2) Write off any account management fees charged to that borrower by the account creation. STEPS TO RE-CREATE 1) Change borrower's dateexpiry to make the borrower expired. 2) Paste borrower's card number into 'Check out' bar 3) A warning will appear saying that the borrower's account has expired, including a 'Renew' link. 4) Double-click the link 5) Check the borrower's fines. You will see two account management fees in a row. distinct from the fee that was written off just after the patron was created. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 22:50:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 21:50:32 +0000 Subject: [Koha-bugs] [Bug 15793] New: UX of circulation patron search with long lists of returned borrowers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793 Bug ID: 15793 Summary: UX of circulation patron search with long lists of returned borrowers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If you do a search from the circulation search that returns a long list of borrowers, it is highly likely that to do anything with your one selected borrower you will have to scroll longer than you'd like to get to the "select" button. We can improve this interface for librarians by either putting a "select" button at the top (or float it along the list), or changing the names (or some other part) into a link. I'm open to other implementation suggestions here as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 23:05:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 22:05:18 +0000 Subject: [Koha-bugs] [Bug 15794] New: Allow the use of emojis as tags on records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Bug ID: 15794 Summary: Allow the use of emojis as tags on records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org A library requested the ability to add emojis in the tag field on the opac. Entering an emoji now seems to scrub it clear and leave no value in the db but still enter a new tag. Subsequent attempts warn of repeated tags. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 23:06:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 22:06:02 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 --- Comment #15 from Charles Farmer --- Anybody? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 23:39:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 22:39:12 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #12 from Chris Cormack --- I'd like to see an apology from Mark for his comment in comment 5. That was a totally unacceptable way to act Mark. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 23:47:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 22:47:00 +0000 Subject: [Koha-bugs] [Bug 15681] Improve visibility of place hold option when checking out an item already checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 23:47:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 22:47:04 +0000 Subject: [Koha-bugs] [Bug 15681] Improve visibility of place hold option when checking out an item already checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 --- Comment #2 from Aleisha Amohia --- Created attachment 47880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47880&action=edit Bug 15681: Improve visibility of place hold option when checking out an item already checked out Have converted icons to font-awesome! To test: 1) Check out an item to a user 2) Attempt to check out the same item (ie same barcode) to another user 3) Confirm that message box says 'Please confirm checkout' with 3 newly styled buttons 4) Confirm 'cancel checkout and place a hold' button is styled the same as the other two buttons and clicking it takes you to page to place holds (reserves.pl) 5) Confirm behaviour of other two buttons works as expected also Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 23:47:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 22:47:47 +0000 Subject: [Koha-bugs] [Bug 15681] Improve visibility of place hold option when checking out an item already checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 23:53:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 22:53:58 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #13 from M. Tompsett --- (In reply to Chris Cormack from comment #12) > I'd like to see an apology from Mark for his comment in comment 5. That was > a totally unacceptable way to act Mark. True. I apologize. My frustration is mine alone, and does not reflect the great efforts of users and developers alike or the experiences of others. And this is not an appropriate place for such an outburst, nor is such an outburst acceptable behaviour. Again, I'm sorry everyone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 23:54:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 22:54:41 +0000 Subject: [Koha-bugs] [Bug 15025] Regression: "print summary" does not display fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15025 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #2 from Aleisha Amohia --- I cannot reproduce this in 3.23. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 23:55:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 22:55:42 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #14 from Chris Cormack --- (In reply to M. Tompsett from comment #13) > (In reply to Chris Cormack from comment #12) > > I'd like to see an apology from Mark for his comment in comment 5. That was > > a totally unacceptable way to act Mark. > > True. I apologize. My frustration is mine alone, and does not reflect the > great efforts of users and developers alike or the experiences of others. > And this is not an appropriate place for such an outburst, nor is such an > outburst acceptable behaviour. Again, I'm sorry everyone. Thank you Mark. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 10 23:57:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 22:57:06 +0000 Subject: [Koha-bugs] [Bug 14171] Buttons instead of links in messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14171 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #3 from Aleisha Amohia --- How can I reproduce this message? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 00:31:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 23:31:00 +0000 Subject: [Koha-bugs] [Bug 10981] changing focus when alert on check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10981 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #1 from Aleisha Amohia --- is this still valid? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 00:48:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Feb 2016 23:48:25 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com --- Comment #15 from Indranil Das Gupta --- (In reply to Katrin Fischer from comment #7) > It might depend on browser version and we will probably have to change the > plugin at some point as I think Mozilla seems to plan changes there. there > (XUL?). ^^^^^^^^ W.R.T xul perhaps we should keep the following in mind as the future of KOCT [1] http://arstechnica.com/information-technology/2015/08/mozilla-sets-plan-to-dump-firefox-add-ons-move-to-chrome-like-extensions/ [2] https://blog.mozilla.org/addons/2015/08/21/the-future-of-developing-firefox-add-ons/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 01:57:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 00:57:13 +0000 Subject: [Koha-bugs] [Bug 2710] save buttons should be at both top and bottom of certain forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2710 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #5 from Aleisha Amohia --- I am working on Bug 11088 and bug 11089 to have the floating toolbar at the top like MARC Record cataloguing now has. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 02:03:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 01:03:12 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 OLLIE SCHWEIZER changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katzfiller9 at gmail.com --- Comment #95 from OLLIE SCHWEIZER --- Invaluable comments , Coincidentally , if anyone are searching for a service to merge PDF or PNG files , my kids came across a tool here altomerge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 02:18:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 01:18:08 +0000 Subject: [Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 rhilliker at hotchkiss.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rhilliker at hotchkiss.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 03:27:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 02:27:52 +0000 Subject: [Koha-bugs] [Bug 15795] New: C4/Members.pm is floody Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 Bug ID: 15795 Summary: C4/Members.pm is floody Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com A warn without a prepended $debug is causing floodiness when NorwegianPatronDB is not set. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 03:28:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 02:28:08 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|C4/Members.pm is floody |C4/Members.pm is floody | |(Norwegian Patron DB) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 03:51:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 02:51:56 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | Status|NEW |ASSIGNED Severity|enhancement |trivial --- Comment #1 from M. Tompsett --- Though I can't see how to trigger it, except by deleting ~/kohaclone/Koha/NorwegianPatronDB.pm, there probably should be a $debug prepended on the warn. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 03:55:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 02:55:45 +0000 Subject: [Koha-bugs] [Bug 11089] Item edit screen should use floating toolbar like cataloging interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11089 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com CC| |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 03:55:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 02:55:49 +0000 Subject: [Koha-bugs] [Bug 11088] Patron entry page should use floating toolbar like cataloging interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11088 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 03:55:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 02:55:53 +0000 Subject: [Koha-bugs] [Bug 12333] Acquisitions toolbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12333 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | CC| |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 03:57:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 02:57:04 +0000 Subject: [Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | CC| |aleishaamohia at hotmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 04:03:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 03:03:39 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 04:03:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 03:03:41 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 --- Comment #2 from M. Tompsett --- Created attachment 47881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47881&action=edit Bug 15795: C4/Members.pm is floody (Norwegian Patron DB) >From the mailing list: "I'm working on 3.22.02 and my logs are FILLED with the following warnings: Members.pm: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/acqui/booksellers.pl admin-home.pl: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/admin/preferences.pl" I agree. Looking at C4/Members.pm other warns are all prepended with $debug. TEST PLAN --------- 1) rm Koha/NorwegianPatronDB.pm -- quickest and dirtiest way to get the load to fail. 2) echo > ~/koha-dev/var/log/koha-error_log -- so it will be easy to spot the log changes. -- back up the log file if you really want it. 3) log into the staff client and go to patrons. -- Check the log file. "Unable to load ..." will be there. 4) echo > ~/koha-dev/var/log/koha-error_log 5) sudo vi /etc/apache2/sites-enabled/{your koha site file} -- Find your staff client entry in your apache configuration file and add: SetEnv DEBUG 1 6) sudo service apache2 restart 7) apply the patch 8) refresh the patron page -- "Unable to load..." will still be there. 9) change the DEBUG value in your apache config to 0 10) sudo sevice apache2 restart 11) echo > ~/koha-dev/var/log/koha-error_log 12) refresh the patron page -- "Unable to load..." will NOT be there. 13) git checkout origin/master -- Koha/NorwegianPatronDB.pm -- to bring it back. 14) refresh the patron page -- "Unable to load..." will still not be there. 15) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 04:12:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 03:12:06 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 --- Comment #3 from M. Tompsett --- See the conversation on Nabble: http://koha.1045719.n5.nabble.com/Introduce-the-use-of-Grunt-or-Gulp-tp5873339p5873842.html Sadly, it got inter-threaded. The dangers of just replying in order to create a new thread. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 04:41:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 03:41:26 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 --- Comment #8 from M. Tompsett --- Created attachment 47882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47882&action=edit Bug 14633 - Patch to control.ini to add or dependency to libapache2-mpm-itk The other attachment was not a patch which could be applied by 'git bz'. This corrects that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 04:42:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 03:42:03 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47630|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Comment on attachment 47630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47630 Patch to control.ini to add or dependency to libapache2-mpm-itk This wasn't uploaded as a patch. I corrected that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 06:31:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 05:31:04 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #96 from Mirko Tietgen --- Tried to hide the spammer. Don't know if someone else can delete it. Account should be banned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 06:33:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 05:33:08 +0000 Subject: [Koha-bugs] [Bug 12120] Add --tempdir arg to rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12120 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- mtompset at debian:~/kohaclone$ git checkout master Switched to branch 'master' Your branch is up-to-date with 'origin/master'. mtompset at debian:~/kohaclone$ git branch -D bug_12120 Deleted branch bug_12120 (was 134a7f2). mtompset at debian:~/kohaclone$ git checkout -b bug_12120 origin/master Branch bug_12120 set up to track remote branch master from origin. Switched to a new branch 'bug_12120' mtompset at debian:~/kohaclone$ git bz apply 12120 Bug 12120 - Add --tempdir arg to rebuild_zebra.pl 42279 - Bug 12120: Add --tempdir arg to rebuild_zebra.pl Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12120: Add --tempdir arg to rebuild_zebra.pl mtompset at debian:~/kohaclone$ ./misc/migration_tools/rebuild_zebra.pl -b -a -r -v --tempdir /tmp/a/b/c/d/e/f/g Error in tempdir() using /tmp/a/b/c/d/e/f/g/XXXXXXXXXX: Parent directory (/tmp/a/b/c/d/e/f/g) does not exist at ./misc/migration_tools/rebuild_zebra.pl line 160. mtompset at debian:~/kohaclone$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 08:00:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 07:00:37 +0000 Subject: [Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 08:06:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 07:06:09 +0000 Subject: [Koha-bugs] [Bug 11088] Patron entry page should use floating toolbar like cataloging interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11088 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2710 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 08:06:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 07:06:09 +0000 Subject: [Koha-bugs] [Bug 2710] save buttons should be at both top and bottom of certain forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2710 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11088 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 08:06:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 07:06:32 +0000 Subject: [Koha-bugs] [Bug 2710] save buttons should be at both top and bottom of certain forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2710 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11089 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 08:06:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 07:06:32 +0000 Subject: [Koha-bugs] [Bug 11089] Item edit screen should use floating toolbar like cataloging interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11089 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2710 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 08:08:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 07:08:32 +0000 Subject: [Koha-bugs] [Bug 2710] save buttons should be at both top and bottom of certain forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2710 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12333 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 08:08:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 07:08:32 +0000 Subject: [Koha-bugs] [Bug 12333] Acquisitions toolbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12333 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2710 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 08:26:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 07:26:10 +0000 Subject: [Koha-bugs] [Bug 14102] item search export should include itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14102 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 15787 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 08:26:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 07:26:10 +0000 Subject: [Koha-bugs] [Bug 15787] Show and export itemnumber and biblionumber via the item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15787 --- Comment #1 from Katrin Fischer --- *** Bug 14102 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 08:41:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 07:41:45 +0000 Subject: [Koha-bugs] [Bug 13778] lists buttons ugly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47879|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 47883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47883&action=edit Bug 13778: Putting patron lists buttons into a dropdown menu To test: 1) Go to Tools -> Patron lists 2) If there are no lists, confirm there is a message box saying 'There are no patron lists.' 3) Create a list if you do not already have one. 4) Confirm that in the 'Actions' drop down menu next to the list, the options to 'Add patrons', 'Edit', 'Delete', and 'Print patron cards' are all there and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 08:42:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 07:42:55 +0000 Subject: [Koha-bugs] [Bug 13778] lists buttons ugly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 09:02:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 08:02:52 +0000 Subject: [Koha-bugs] [Bug 15000] Adding patron card images with duplicate descriptions causes data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15000 --- Comment #6 from Marc V?ron --- What should happen if somebody intentionally wants to replace the image? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 09:28:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 08:28:40 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #16 from Julian Maurice --- (In reply to M. Tompsett from comment #11) > PROBLEM! The desktop version does not do UTC. Which versions of Firefox and KOCT do you use ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 09:29:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 08:29:37 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #17 from Katrin Fischer --- Hi Julian, I think Mark was worried about keeping compatibility with Kyle's desktop offline circ client (linked from circ module start page). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 09:45:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 08:45:59 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #12 from Julian Maurice --- (In reply to Olli-Antti Kivilahti from comment #11) > Created attachment 47844 [details] [review] > Swagger Minifier This patch won't apply as it delete a file which doesn't exist in any other (non-obsoleted) patch. Please reformat your patch. Also, if "Big splitted swagger2 spec. Example of the planned usage pattern." patch is not to be pushed, please include "[DO NOT PUSH]" in front of the patch title to make it obvious -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 09:48:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 08:48:01 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #13 from Olli-Antti Kivilahti --- Thanks for taking a look! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 09:48:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 08:48:25 +0000 Subject: [Koha-bugs] [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15795 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 09:48:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 08:48:25 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |15151 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15151 [Bug 15151] t/Circulation_barcodedecode.t fails if no DB present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 09:57:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 08:57:54 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #18 from Julian Maurice --- Oh, I wasn't aware of the desktop client... Do you think we should change the desktop client to send UTC too ? Or change firefox plugin to send time in local timezone ? I would go for changing the desktop client as the timezones for client and server can differ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 09:59:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 08:59:55 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #4 from Magnus Enger --- How about getting rid of both the if and the warn? So from this: use Module::Load::Conditional qw( can_load ); if ( ! can_load( modules => { 'Koha::NorwegianPatronDB' => undef } ) ) { warn "Unable to load Koha::NorwegianPatronDB"; } to this: use Module::Load::Conditional qw( can_load ); can_load( modules => { 'Koha::NorwegianPatronDB' => undef } ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 10:02:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 09:02:24 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #19 from Katrin Fischer --- I am not sure what makes the most sense - timezones are confusing. Would there be an option to handle it inside of Koha like the patch does? Adding Kyle to this discussion for his opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 10:04:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 09:04:04 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #14 from Olli-Antti Kivilahti --- What I am curious of is whether or not the spliced swagger2-spec I posted makes sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 10:17:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 09:17:05 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #15 from Julian Maurice --- I haven't looked at it in detail, but having a filesystem structure that match swagger spec structure would certainly make sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 11:23:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 10:23:55 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15760 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:03:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:03:04 +0000 Subject: [Koha-bugs] [Bug 15783] C4::Koha::AddAuthorisedValue can be replaced with Koha::AuthorisedValue->new->store In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47840|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 47889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47889&action=edit Bug 15783: AddAuthorisedValue - Replace existing calls The C4::Koha::AddAuthorisedValue is only called twice from reports/guided_reports.pl and insert an authorised value. This job can be achieve easily using the Koha::AuthorisedValue module. Test plan: 1/ Create a new guided report 2/ Use an existing group and/or subgroup of reports 3/ Save 4/ Update an existing report 5/ Use an existing group and/or subgroup of reports 6/ Save 7/ Create or update an existing report 8/ Remove its assigned group and subgroup 9/ Save Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:04:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:04:51 +0000 Subject: [Koha-bugs] [Bug 15783] C4::Koha::AddAuthorisedValue can be replaced with Koha::AuthorisedValue->new->store In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47841|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 47890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47890&action=edit Bug 15783: AddAuthorisedValue - Remove the subroutine Test plan: prove t/db_dependent/Koha.t should return green git grep AddAuthorisedValue should not return any results Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:05:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:05:23 +0000 Subject: [Koha-bugs] [Bug 15783] C4::Koha::AddAuthorisedValue can be replaced with Koha::AuthorisedValue->new->store In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:07:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:07:11 +0000 Subject: [Koha-bugs] [Bug 15769] C4::Koha::slashifyDate is outdated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Hi H?cror, Did you forget to switch to Signed-off? :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:11:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:11:13 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 --- Comment #5 from M. Tompsett --- (In reply to Magnus Enger from comment #4) > How about getting rid of both the if and the warn? So ... this: > > use Module::Load::Conditional qw( can_load ); > can_load( modules => { 'Koha::NorwegianPatronDB' => undef } ); While functional, I think warns are a good thing. I would rather keep the potential to warn, hence my patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:36:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:36:01 +0000 Subject: [Koha-bugs] [Bug 14753] Show accession date on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14753 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #6 from Marc V?ron --- Hi Nick, There is a stray i in returns.tt line 10 Koha › Circulation › Check in [% title %]i -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:37:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:37:45 +0000 Subject: [Koha-bugs] [Bug 15796] New: C4::Koha - get_itemtypeinfos_of and get_infos_of are not used anymore Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15796 Bug ID: 15796 Summary: C4::Koha - get_itemtypeinfos_of and get_infos_of are not used anymore Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 15779 These 2 subroutines are no longer in use and can be removed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:37:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:37:45 +0000 Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15796 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15796 [Bug 15796] C4::Koha - get_itemtypeinfos_of and get_infos_of are not used anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:40:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:40:45 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #20 from M. Tompsett --- (In reply to Katrin Fischer from comment #17) > Hi Julian, I think Mark was worried about keeping compatibility with Kyle's > desktop offline circ client (linked from circ module start page). Yes. However, after testing further, I see the routes of processing are not the same -- unless it is that pesky "Commit" route which I still can not for the life of me get working. My transactions disappear into nothingness. And this nothingness void exists for other methods too attempting anything except a direct application. I may end up screen casting these failures to see if someone sees something I am doing wrong or forgot to configure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:42:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:42:51 +0000 Subject: [Koha-bugs] [Bug 15730] 500 error on returns.pl if barcode doesn't exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:43:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:43:12 +0000 Subject: [Koha-bugs] [Bug 15681] Improve visibility of place hold option when checking out an item already checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 --- Comment #3 from Owen Leonard --- Created attachment 47891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47891&action=edit Screenshot of a test case In testing this I randomly happened to pick an item which was both checked out and on hold for someone, so this dialog got pretty complicated. Currently buttons in dialogs have a special style which is different from other buttons. As you can see the patch doesn't modify them all. I would prefer to not use the Bootstrap style buttons here and keep the existing dialog button style. I think if we want to change the style of dialog buttons we should do it across the board. I'm beginning to do so--at least for the icons--with Bug 15785. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:45:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:45:33 +0000 Subject: [Koha-bugs] [Bug 14755] Checking in gives error 500 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15730 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:45:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:45:33 +0000 Subject: [Koha-bugs] [Bug 15730] 500 error on returns.pl if barcode doesn't exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14755 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:51:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:51:30 +0000 Subject: [Koha-bugs] [Bug 15796] C4::Koha - get_itemtypeinfos_of and get_infos_of are not used anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15796 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:51:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:51:31 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #21 from M. Tompsett --- (In reply to Katrin Fischer from comment #19) > I am not sure what makes the most sense - timezones are confusing. Indeed. I was looking at the KOTC plugin source (I think it is the source), and noticing that it used CURRENT_TIMESTAMP. Clearly that timestamp's timezone differs from the desktop version. Thanks for the suggestion to read the manual. I figured out the three ways: https://addons.mozilla.org/en-US/firefox/search/?q=koct (Firefox plugin) https://github.com/bywatersolutions/koha-offline-circulation/releases (Desktop) "If the AllowOfflineCirculation preference is set to 'Enable'..." (http://translate.koha-community.org/manual/3.22/en/html-desktop/#offlinecirc) makes an HTML interface to offline available under Circulation in the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:51:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:51:33 +0000 Subject: [Koha-bugs] [Bug 15796] C4::Koha - get_itemtypeinfos_of and get_infos_of are not used anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15796 --- Comment #1 from Jonathan Druart --- Created attachment 47892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47892&action=edit Bug 15796: Remove C4::Koha::get_itemtypeinfos_of This subroutine is no longer in use. Test plan: git grep get_itemtypeinfos_of should not return any results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:51:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:51:56 +0000 Subject: [Koha-bugs] [Bug 15796] C4::Koha - get_itemtypeinfos_of is not used anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15796 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|C4::Koha - |C4::Koha - |get_itemtypeinfos_of and |get_itemtypeinfos_of is not |get_infos_of are not used |used anymore |anymore | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:52:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:52:22 +0000 Subject: [Koha-bugs] [Bug 15796] C4::Koha - get_itemtypeinfos_of is not used anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15796 --- Comment #2 from Jonathan Druart --- (In reply to Jonathan Druart from comment #0) > These 2 subroutines are no longer in use and can be removed. C4::Koha::get_infos_of is still used! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:53:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:53:22 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 --- Comment #22 from M. Tompsett --- (In reply to Julian Maurice from comment #18) > Oh, I wasn't aware of the desktop client... See comment #21 for a link. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:53:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:53:45 +0000 Subject: [Koha-bugs] [Bug 15797] New: C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 Bug ID: 15797 Summary: C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 15779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:53:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:53:45 +0000 Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:55:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:55:13 +0000 Subject: [Koha-bugs] [Bug 15670] Rename "Cancel" to "Cancel hold" when checking in a waiting item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15670 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:55:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:55:53 +0000 Subject: [Koha-bugs] [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:55:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:55:56 +0000 Subject: [Koha-bugs] [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 --- Comment #1 from Jonathan Druart --- Created attachment 47895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47895&action=edit Bug 15797: Remove C4::Koha::GetKohaImageurlFromAuthorisedValues This subroutine is no longer in used and can be remove. Test plan: git grep GetKohaImageurlFromAuthorisedValues should not return any results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:57:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:57:09 +0000 Subject: [Koha-bugs] [Bug 15775] User should know when they are blocked from checkouts on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Hi Aleisha, If I apply this patch on top of Bug 15374, I get merge conflicts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:57:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:57:23 +0000 Subject: [Koha-bugs] [Bug 15798] New: C4::Koha::displayServers is no longer in use Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 Bug ID: 15798 Summary: C4::Koha::displayServers is no longer in use Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 15779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:57:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:57:23 +0000 Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15798 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 [Bug 15798] C4::Koha::displayServers is no longer in use -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:59:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:59:24 +0000 Subject: [Koha-bugs] [Bug 15798] C4::Koha::displayServers is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 14:59:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 13:59:26 +0000 Subject: [Koha-bugs] [Bug 15798] C4::Koha::displayServers is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 --- Comment #1 from Jonathan Druart --- Created attachment 47896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47896&action=edit Bug 15798: Remove C4::Koha::displayServers This subroutine is no longer is use and can be removed. Test plan: git grep displayServers should not return any results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:02:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:02:17 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:09:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:09:06 +0000 Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 [Bug 15799] move authorised value related code into Koha::AuthorisedValues - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:09:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:09:06 +0000 Subject: [Koha-bugs] [Bug 15799] New: move authorised value related code into Koha::AuthorisedValues - part 2 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 Bug ID: 15799 Summary: move authorised value related code into Koha::AuthorisedValues - part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 15779 The first patch (bug 10363) did not take care of the subroutines from C4::Koha. This module contains several subroutines which could be either moved or replaced with a call to Koha::AuthorisedValues: - GetKohaImageurlFromAuthorisedValues - GetAuthValCode - GetAuthValCodeFromField - GetAuthorisedValues - GetAuthorisedValueCategories - GetAuthorisedValueByCode - GetKohaAuthorisedValues - GetKohaAuthorisedValuesFromField - GetKohaAuthorisedValuesMapping - GetKohaAuthorisedValueLib - GetAuthvalueDropbox Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:09:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:09:15 +0000 Subject: [Koha-bugs] [Bug 10363] Move authorised value related code into its own package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 [Bug 15799] move authorised value related code into Koha::AuthorisedValues - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:09:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:09:15 +0000 Subject: [Koha-bugs] [Bug 15799] move authorised value related code into Koha::AuthorisedValues - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10363 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 [Bug 10363] Move authorised value related code into its own package -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:12:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:12:46 +0000 Subject: [Koha-bugs] [Bug 15799] Move authorised value related code into Koha::AuthorisedValues - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|move authorised value |Move authorised value |related code into |related code into |Koha::AuthorisedValues - |Koha::AuthorisedValues - |part 2 |part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:12:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:12:53 +0000 Subject: [Koha-bugs] [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move authorised value |Move authorised values |related code into |related code into |Koha::AuthorisedValues - |Koha::AuthorisedValues - |part 2 |part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:13:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:13:01 +0000 Subject: [Koha-bugs] [Bug 15800] New: Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800 Bug ID: 15800 Summary: Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 15799 C4::Koha::IsAuthorisedValueCategory contains only 2 useful calls, from C4::Reports::Guided and reports/guided_reports.pl It can be replaced with Koha::AuthorisedValues->search({ category => $authorised_value })->count Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:13:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:13:01 +0000 Subject: [Koha-bugs] [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15800 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800 [Bug 15800] Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:13:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:13:20 +0000 Subject: [Koha-bugs] [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 --- Comment #1 from Jonathan Druart --- IsAuthorisedValueCategory is on bug 15800 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:16:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:16:33 +0000 Subject: [Koha-bugs] [Bug 15769] C4::Koha::slashifyDate is outdated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15800 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800 [Bug 15800] Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:16:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:16:33 +0000 Subject: [Koha-bugs] [Bug 15800] Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15769, 15783 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 [Bug 15769] C4::Koha::slashifyDate is outdated https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 [Bug 15783] C4::Koha::AddAuthorisedValue can be replaced with Koha::AuthorisedValue->new->store -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:16:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:16:33 +0000 Subject: [Koha-bugs] [Bug 15783] C4::Koha::AddAuthorisedValue can be replaced with Koha::AuthorisedValue->new->store In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15800 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800 [Bug 15800] Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:17:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:17:07 +0000 Subject: [Koha-bugs] [Bug 13420] sorting on volume number is not sorting right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- This issue is that the volume column is being sorted as a string, rather than a number. This does and does not make sense. The volume field is not strictly a number, but is a general text field. Some libraries may put "123" in there, or "vol 123" or as is the case for Karl, "v. 123". The quick hack solution would be to pad out all the volume numbers to the same length in the volume field itself. This is a very sub-optimal solution. I think the optimal solution would be to take each volume field and pad out each number in the string to 10 or so digits. We can then take the padded version and put it in a hidden column that is used for sorting the visible column. The regex s/([0-9]+)/sprintf('%010d',$1)/ge; should take care of the padding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:17:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:17:10 +0000 Subject: [Koha-bugs] [Bug 15756] Some tests for haspermission in C4::Auth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:17:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:17:14 +0000 Subject: [Koha-bugs] [Bug 15756] Some tests for haspermission in C4::Auth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15756 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47743|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 47897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47897&action=edit Bug 15756: Some tests for haspermission in C4::Auth Test plan: Run this new test. Signed-off-by: Hector Castro All tests successful. koha-qa.pl run OK. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:22:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:22:39 +0000 Subject: [Koha-bugs] [Bug 15670] Rename "Cancel" to "Cancel hold" when checking in a waiting item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15670 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:22:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:22:42 +0000 Subject: [Koha-bugs] [Bug 15670] Rename "Cancel" to "Cancel hold" when checking in a waiting item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15670 --- Comment #2 from Owen Leonard --- Created attachment 47898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47898&action=edit Bug 15670 - Rename "Cancel" to "Cancel hold" when checking in a waiting item When checking in an on-hold item which is waiting, the "Cancel" button cancels the hold, so it should say so. This patch changes the text. This patch also moves the 'cancel hold' button to the middle, on the theory that buttons on the left should default to 'confirm' and buttons on the right should generally imply 'cancel'--as in 'do nothing.' Moving it to the middle seems like a good place to put it where users will have to think about clicking it. To test: 1. Find an hold which has been made 'waiting,' or check in an confirm a pending hold at your library. 2. Check in that item again and verify that the 'Hold found' dialog contains a 'Cancel hold' button which works to cancel the waiting hold. 3. Repeat the process and confirm that the functionality of the other buttons is unchanged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:23:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:23:43 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47825|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:24:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:24:38 +0000 Subject: [Koha-bugs] [Bug 15800] Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:24:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:24:41 +0000 Subject: [Koha-bugs] [Bug 15800] Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800 --- Comment #1 from Jonathan Druart --- Created attachment 47899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47899&action=edit Bug 15800: Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory C4::Koha::IsAuthorisedValueCategory contains only 2 useful calls, from C4::Reports::Guided and reports/guided_reports.pl It can be replaced with Koha::AuthorisedValues->search({ category => $authorised_value})->count Test plan: 1/ Create a sql report using an authorised value category, something like: SELECT COUNT(*) FROM items where lost=<> 2/ Execute the report and confirm that everything works fine. 3/ Create a sql report using a nonexistent authorised value categor, something like: SELECT COUNT(*) FROM items where lost=<> 4/ When saving the report, you should get a warning message "lost: The authorized value category (NONEXIST) you selected does not exist." 5/ Save anyway and execute the report, you should get the same warning message. QA: git grep IsAuthorisedValueCategory should not return any results prove t/db_dependent/ReportsGuided.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:28:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:28:04 +0000 Subject: [Koha-bugs] [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:28:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:28:04 +0000 Subject: [Koha-bugs] [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15797 --- Comment #2 from Jonathan Druart --- GetKohaImageurlFromAuthorisedValues is removed by bug 15797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:28:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:28:18 +0000 Subject: [Koha-bugs] [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15779 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:28:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:28:18 +0000 Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15797 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:30:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:30:05 +0000 Subject: [Koha-bugs] [Bug 15798] C4::Koha::displayServers is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- I agree. mtompset at debian:~/kohaclone$ git reset --hard origin/master HEAD is now at 59fc325 Bug 15684: Fix encoding issues with quote upload mtompset at debian:~/kohaclone$ git grep -n displayServers C4/Koha.pm:53: &displayServers C4/Koha.pm:1013:=head2 displayServers C4/Koha.pm:1015: my $servers = displayServers(); C4/Koha.pm:1016: my $servers = displayServers( $position ); C4/Koha.pm:1017: my $servers = displayServers( $position, $type ); C4/Koha.pm:1019:displayServers returns a listref of hashrefs, each containing C4/Koha.pm:1037:sub displayServers { mtompset at debian:~/kohaclone$ git bz apply 15798 Bug 15798 - C4::Koha::displayServers is no longer in use 47896 - Bug 15798: Remove C4::Koha::displayServers Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15798: Remove C4::Koha::displayServers mtompset at debian:~/kohaclone$ git grep -n displayServers mtompset at debian:~/kohaclone$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:30:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:30:28 +0000 Subject: [Koha-bugs] [Bug 13420] sorting on volume number is not sorting right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 --- Comment #8 from Kyle M Hall --- Another option, considering this is a serials column, would be to use the serial sequence columns x y and x directly, instead of the concatenated version. The need for padding would still apply though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:30:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:30:56 +0000 Subject: [Koha-bugs] [Bug 15798] C4::Koha::displayServers is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:30:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:30:59 +0000 Subject: [Koha-bugs] [Bug 15798] C4::Koha::displayServers is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47896|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 47900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47900&action=edit [SIGNED-OFF] Bug 15798: Remove C4::Koha::displayServers This subroutine is no longer is use and can be removed. Test plan: git grep displayServers should not return any results. NOTE: See my testing output in comment #2. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:32:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:32:03 +0000 Subject: [Koha-bugs] [Bug 813] OPAC lists should store comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12461 --- Comment #5 from Marc V?ron --- In Bug 12461 - Add patron clubs feature, Kyle introduced functionality to have custom fields in club templates. Each template can define additonal fields. It works great. Maybe something similar could be done here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:32:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:32:03 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=813 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:32:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:32:37 +0000 Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15801 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 [Bug 15801] Move the framework related code to Koha::BiblioFramework[s] - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:32:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:32:37 +0000 Subject: [Koha-bugs] [Bug 15801] New: Move the framework related code to Koha::BiblioFramework[s] - part 2 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Bug ID: 15801 Summary: Move the framework related code to Koha::BiblioFramework[s] - part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 15779 Three subroutines from the C4::Koha module deal with biblio frameworks and could be replaced or moved to Koha::BiblioFramework: - getframeworks - getframeworkinfo - GetFrameworksLoop Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:33:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:33:05 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:33:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:33:20 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15801 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 [Bug 15801] Move the framework related code to Koha::BiblioFramework[s] - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:33:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:33:20 +0000 Subject: [Koha-bugs] [Bug 15801] Move the framework related code to Koha::BiblioFramework[s] - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14889 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:55:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:55:39 +0000 Subject: [Koha-bugs] [Bug 15802] New: The system will not allow me to return any books Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15802 Bug ID: 15802 Summary: The system will not allow me to return any books Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: All Status: NEW Severity: major Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: sashagnb at hotmail.com QA Contact: testopia at bugs.koha-community.org The system is not allowing me to return any books. I`ve tried manually entering the code and also scanning it. Neither works and I get the following message. Message au retour Pas d'exemplaire avec code ? barres : 000000LWS07024 This feature was working earlier today. I have tried working in both FireFox and Chrome and get the same error. Thanks, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:55:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:55:49 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtompset at hotmail.com Status|NEW |ASSIGNED CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:56:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:56:12 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #1 from M. Tompsett --- Created attachment 47901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47901&action=edit Bug 15747 Auth.pm flooding error log with "CGI::param called in list context" TEST PLAN --------- 1) git checkout -b bug_15747 origin/master 2) echo > ~/koha-dev/var/log/koha-error_log 3) open up staff interface and log in. 4) cat ~/koha-dev/var/log/koha-error_log --- BEGIN SNIP --- [Thu Feb 11 09:49:43.627711 2016] [cgi:error] [pid 2132] [client 192.168.71.222: 51107] AH01215: [Thu Feb 11 09:49:43 2016] mainpage.pl: CGI::param called in lis t context from package C4::Auth line 401, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /us r/share/perl5/CGI.pm line 436., referer: http://library-admin.debiankoha.ca/ --- END SNIP --- 5) logout 6) echo > ~/koha-dev/var/log/koha-error_log 7) log back in. 8) cat ~/koha-dev/var/log/koha-error_log -- this time should not be there. 9) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:57:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:57:00 +0000 Subject: [Koha-bugs] [Bug 15802] The system will not allow me to return any books In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15802 Sasha Girard changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 OS|All |Windows -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 15:59:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 14:59:17 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 --- Comment #6 from Blou --- Created attachment 47902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47902&action=edit [SIGNED-OFF] Bug 15795: C4/Members.pm is floody (Norwegian Patron DB) >From the mailing list: "I'm working on 3.22.02 and my logs are FILLED with the following warnings: Members.pm: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/acqui/booksellers.pl admin-home.pl: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/admin/preferences.pl" I agree. Looking at C4/Members.pm other warns are all prepended with $debug. TEST PLAN --------- 1) rm Koha/NorwegianPatronDB.pm -- quickest and dirtiest way to get the load to fail. 2) echo > ~/koha-dev/var/log/koha-error_log -- so it will be easy to spot the log changes. -- back up the log file if you really want it. 3) log into the staff client and go to patrons. -- Check the log file. "Unable to load ..." will be there. 4) echo > ~/koha-dev/var/log/koha-error_log 5) sudo vi /etc/apache2/sites-enabled/{your koha site file} -- Find your staff client entry in your apache configuration file and add: SetEnv DEBUG 1 6) sudo service apache2 restart 7) apply the patch 8) refresh the patron page -- "Unable to load..." will still be there. 9) change the DEBUG value in your apache config to 0 10) sudo sevice apache2 restart 11) echo > ~/koha-dev/var/log/koha-error_log 12) refresh the patron page -- "Unable to load..." will NOT be there. 13) git checkout origin/master -- Koha/NorwegianPatronDB.pm -- to bring it back. 14) refresh the patron page -- "Unable to load..." will still not be there. 15) run koha qa test tools Signed-off-by: Philippe Blouin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:00:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:00:15 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47881|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:01:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:01:58 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:02:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:02:00 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47901|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 47903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47903&action=edit Bug 15747 Auth.pm flooding error log with "CGI::param called in list context" TEST PLAN --------- 1) git checkout -b bug_15747 origin/master 2) echo > ~/koha-dev/var/log/koha-error_log 3) open up staff interface and log in. 4) cat ~/koha-dev/var/log/koha-error_log *** BEGIN SNIP *** [Thu Feb 11 09:49:43.627711 2016] [cgi:error] [pid 2132] [client 192.168.71.222:51107] AH01215: [Thu Feb 11 09:49:43 2016] mainpage.pl: CGI::param called in list context from package C4::Auth line 401, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://library-admin.debiankoha.ca/ *** END SNIP *** 5) logout 6) apply patch 7) echo > ~/koha-dev/var/log/koha-error_log 8) log back in. 9) cat ~/koha-dev/var/log/koha-error_log -- this time should not be there. 10) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:03:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:03:19 +0000 Subject: [Koha-bugs] [Bug 15802] The system will not allow me to return any books In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15802 --- Comment #1 from Owen Leonard --- This sounds like a support question rather than a bug with Koha. Do you have a Koha support provider you can contact? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:04:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:04:09 +0000 Subject: [Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 --- Comment #6 from Alex Arnaud --- Created attachment 47904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47904&action=edit Bug 15564 - Fix tranfert branch: Set collection branch with return branch if it is empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:04:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:04:17 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Blou --- Although I would prefer Magnus' code snippet overall, because it's less ugly than the big "if" that gives too much importance to that feature IMO, adding $debug is following the standard and expectations. I like standards... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:04:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:04:50 +0000 Subject: [Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:06:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:06:49 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46595|0 |1 is obsolete| | Attachment #46596|0 |1 is obsolete| | Attachment #46597|0 |1 is obsolete| | Attachment #46598|0 |1 is obsolete| | Attachment #46599|0 |1 is obsolete| | Attachment #46600|0 |1 is obsolete| | Attachment #46601|0 |1 is obsolete| | Attachment #46602|0 |1 is obsolete| | Attachment #46603|0 |1 is obsolete| | Attachment #46604|0 |1 is obsolete| | Attachment #46605|0 |1 is obsolete| | Attachment #46606|0 |1 is obsolete| | Attachment #46607|0 |1 is obsolete| | Attachment #46608|0 |1 is obsolete| | Attachment #46609|0 |1 is obsolete| | Attachment #46610|0 |1 is obsolete| | Attachment #46611|0 |1 is obsolete| | Attachment #46612|0 |1 is obsolete| | --- Comment #131 from Kyle M Hall --- Created attachment 47905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47905&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:05 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #133 from Kyle M Hall --- Created attachment 47907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47907&action=edit Bug 14610 - Add and update scripts Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:01 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #132 from Kyle M Hall --- Created attachment 47906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47906&action=edit Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:09 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #134 from Kyle M Hall --- Created attachment 47908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47908&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:13 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #135 from Kyle M Hall --- Created attachment 47909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47909&action=edit Bug 14610 [QA Followup] - Rename AR_PRINT to AR_SLIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:17 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #136 from Kyle M Hall --- Created attachment 47910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47910&action=edit Bug 14610 [QA Followup] - Remove bad copyright lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:20 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #137 from Kyle M Hall --- Created attachment 47911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47911&action=edit Bug 14610 [QA Followup] - Fix issuingrules database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:24 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #138 from Kyle M Hall --- Created attachment 47912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47912&action=edit Bug 14610 [QA Followup] - Make prompt tranlatable, only show comma if firstname is set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:28 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #139 from Kyle M Hall --- Created attachment 47913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47913&action=edit Bug 14610 [QA Followup] - Change 'Open' to 'Pending' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:32 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #140 from Kyle M Hall --- Created attachment 47914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47914&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:36 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #141 from Kyle M Hall --- Created attachment 47915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47915&action=edit Bug 14610 [QA Followup] - Don't call get_template_and_user for request-article-do.pl or opac-request-article-do.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:40 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #142 from Kyle M Hall --- Created attachment 47916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47916&action=edit Bug 14610 [QA Followup] - Add non-ajax patron search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:43 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #143 from Kyle M Hall --- Created attachment 47917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47917&action=edit Bug 14610 [QA Followup] - Add request article button to cat toolbar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:47 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #144 from Kyle M Hall --- Created attachment 47918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47918&action=edit Bug 14610 [QA Followup] - Update article request counts in tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:51 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #145 from Kyle M Hall --- Created attachment 47919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47919&action=edit Bug 14610 [QA Followup] - Add article requests count to tab like it is for holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:55 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #146 from Kyle M Hall --- Created attachment 47920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47920&action=edit Bug 14610 [QA Followup] - Add "All libraries" option to article-requests.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:07:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:07:59 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #147 from Kyle M Hall --- Created attachment 47921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47921&action=edit Bug 14610 [QA Followup] - Add article requets count on detail.pl like it is for holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:08:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:08:03 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #148 from Kyle M Hall --- Created attachment 47922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47922&action=edit Bug 14610 - Update opac.css via less -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:18:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:18:30 +0000 Subject: [Koha-bugs] [Bug 15801] Move the framework related code to Koha::BiblioFramework[s] - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:18:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:18:33 +0000 Subject: [Koha-bugs] [Bug 15801] Move the framework related code to Koha::BiblioFramework[s] - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #1 from Jonathan Druart --- Created attachment 47923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47923&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::GetFrameworksLoop The C4::Koha::GetFrameworksLoop retrieves biblio frameworks and returns them ordered by the description (frameworktext). If a parameter is passed, a selected flag is set. The selection of the options should be done on the template side. These 2 calls can be replaced with Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); Test plan: 1/ Go on a Labeled MARC biblio view (catalogue/labeledMARCdetail.pl) You should see a dropdown list with the biblio frameworks. The framework of the record should be selected by default 2/ Create a sql report using the biblio_framework parameter, something like: SELECT COUNT(*) FROM biblio WHERE frameworkcode=<> Save and execute the report. You should get a dropdown list with the framework list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:18:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:18:36 +0000 Subject: [Koha-bugs] [Bug 15801] Move the framework related code to Koha::BiblioFramework[s] - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #2 from Jonathan Druart --- Created attachment 47924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47924&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks C4::Koha::getframeworks returned a hashref of biblio frameworks. It was mainly used to generate the dropdown list of frameworks. The scripts modified in this patch did not necessary order the element by description (frameworktext), the displays were not consistent from one screen to another. Using the same search method everywhere: Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); We will know always get the framework in the same order. Test plan: Following the different pages modified by this patch, and make sure the frameworks are displayed correctly in the dropdown list: 1/ acqui/z3950_search.pl - Create an order from an external source. 2/ admin/fieldmapping.pl - Define some mappings keyword / MARC field 3/ admin/marctagstructure.pl - On the MARC frameworks admin page, select another framework than the default one and click on the 'Search' button 4/ catalogue/MARCdetail.pl - On the MARC defail page, change the framework you want to use to display the record 5/ cataloguing/addbiblio.pl - Add or edit a biblio record, change its framework. When editing, the framework of the record should be selected by default 6/ cataloguing/addbooks.pl - Go on the cataloguing home page and click on the "New record" button. You should see all the frameworks 7/ cataloguing/merge.pl - Select 2 biblio records to merge. On the first step (select the merge reference), you should be allowed to select the framework to use. 8/ tools/inventory.pl - On the inventory page, the "Item statuses" part should be populated as before this patch 9/ tools/manage-marc-import.pl - Stage records for import. Before importing them into the catalog, you should see the framework dropdown list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:18:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:18:40 +0000 Subject: [Koha-bugs] [Bug 15801] Move the framework related code to Koha::BiblioFramework[s] - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #3 from Jonathan Druart --- Created attachment 47925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47925&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo This was the "Get" subroutine for the framework, it can be easily replaced with a call to the Koha::BiblioFrameworks->find method. This patch also replaces some confusing wordings (framework vs frameworkcode). Test plan: On the circulation home page, you should get a warning message if you don't have the FA (Fast cataloguing) framework Note that the admin/marctagstructure.pl has already been tested in the previous patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:19:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:19:01 +0000 Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from R?mi Mayrand-Provencher --- I think the aim of this patch was to allow sysadmins to set a default value to the number of days that should be used in the script while still allowing them to call a custom number of days directly from the command line. Right now, this is exactly what it's doing. It only changes the "days" parameter if the system preference is set, and if both are set, the script will use the value received from the command line. My point is that I am not sure that I understand the problem in your scenario, could you tell me whats wrong? Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:19:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:19:13 +0000 Subject: [Koha-bugs] [Bug 15801] Move the framework related code to Koha::BiblioFramework[s] - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #4 from Jonathan Druart --- To test this patch, makes sure you have the last patch from bug 14889 applied: Bug 14889: Fix typo in Koha/BiblioFrameworks.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:19:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:19:21 +0000 Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|simith.doliveira at inlibro.co |remi.mayrand-provencher at inL |m |ibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:24:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:24:09 +0000 Subject: [Koha-bugs] [Bug 15769] C4::Koha::slashifyDate is outdated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:27:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:27:57 +0000 Subject: [Koha-bugs] [Bug 15803] New: Koha::AuthorisedValues - Remove GetAuthorisedValueCategories Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15803 Bug ID: 15803 Summary: Koha::AuthorisedValues - Remove GetAuthorisedValueCategories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 15801 Blocks: 15799 The subroutine C4::Koha::GetAuthorisedValueCategories just retrieves all the authorised value categories. We already have a method in the Koha::AuthorisedValues module to do this job, let's use it! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 [Bug 15801] Move the framework related code to Koha::BiblioFramework[s] - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:27:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:27:57 +0000 Subject: [Koha-bugs] [Bug 15801] Move the framework related code to Koha::BiblioFramework[s] - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15803 [Bug 15803] Koha::AuthorisedValues - Remove GetAuthorisedValueCategories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:27:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:27:57 +0000 Subject: [Koha-bugs] [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15803 [Bug 15803] Koha::AuthorisedValues - Remove GetAuthorisedValueCategories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:39:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:39:10 +0000 Subject: [Koha-bugs] [Bug 15800] Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:39:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:39:12 +0000 Subject: [Koha-bugs] [Bug 15800] Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47899|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47926&action=edit [SIGNED-OFF]Bug 15800: Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory C4::Koha::IsAuthorisedValueCategory contains only 2 useful calls, from C4::Reports::Guided and reports/guided_reports.pl It can be replaced with Koha::AuthorisedValues->search({ category => $authorised_value})->count Test plan: 1/ Create a sql report using an authorised value category, something like: SELECT COUNT(*) FROM items where itemlost=<> 2/ Execute the report and confirm that everything works fine. 3/ Create a sql report using a nonexistent authorised value categor, something like: SELECT COUNT(*) FROM items where itemlost=<> 4/ When saving the report, you should get a warning message "lost: The authorized value category (NONEXIST) you selected does not exist." 5/ Save anyway and execute the report, you should get the same warning message. QA: git grep IsAuthorisedValueCategory should not return any results prove t/db_dependent/ReportsGuided.t should return green Signed-off-by: Hector Castro Works as described -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:39:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:39:34 +0000 Subject: [Koha-bugs] [Bug 15800] Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:41:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:41:20 +0000 Subject: [Koha-bugs] [Bug 15803] Koha::AuthorisedValues - Remove GetAuthorisedValueCategories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:41:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:41:22 +0000 Subject: [Koha-bugs] [Bug 15803] Koha::AuthorisedValues - Remove GetAuthorisedValueCategories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15803 --- Comment #1 from Jonathan Druart --- Created attachment 47927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47927&action=edit Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories The subroutine C4::Koha::GetAuthorisedValueCategories just retrieves all the authorised value categories. We already have a method in the Koha::AuthorisedValues module to do this job, let's use it! Technical explanations: The new subroutine of the AuthorisedValues TT plugin will allow to get the authorised value categories from the templates. The new html_helpers include file will get rid of the if selected else end statements. Bug 15758 already uses this file, see the commit description for more informations. Test plan: 1/ Create or edit a new fund (aqbudgets.pl), the fields "statistic 1" and "statistic 2" should be correctly filled with the list of authorised value categories 2/ Edit subfields for a biblio and authority framework. The "Authorized value" dropdown list should be correctly filled on both pages 3/ Create new items search fields (from the administration area), same as previously, the authorised value category dropdown list should be correctly filled 4/ Add and edit patron attribute types, check the authorised value category list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:45:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:45:41 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 --- Comment #5 from Jonathan Druart --- Bug 15632 - Move the messages related code to Koha::Patron::Messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:45:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:45:57 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 --- Comment #6 from Jonathan Druart --- Bug 15635 - Move the patron images related code to Koha::Patron::Images -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:46:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:46:11 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 --- Comment #7 from Jonathan Druart --- Bug 15656 - Move the guarantor/guarantees code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:46:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:46:24 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 --- Comment #8 from Jonathan Druart --- Bug 15779 - Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:50:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:50:52 +0000 Subject: [Koha-bugs] [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 --- Comment #3 from Jonathan Druart --- Bug 15803 - Koha::AuthorisedValues - Remove GetAuthorisedValueCategories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:55:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:55:25 +0000 Subject: [Koha-bugs] [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:55:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:55:28 +0000 Subject: [Koha-bugs] [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47895|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47928&action=edit [SIGNED-OFF]Bug 15797: Remove C4::Koha::GetKohaImageurlFromAuthorisedValues This subroutine is no longer in used and can be remove. Test plan: git grep GetKohaImageurlFromAuthorisedValues should not return any results. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:55:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:55:40 +0000 Subject: [Koha-bugs] [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 16:59:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 15:59:03 +0000 Subject: [Koha-bugs] [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 --- Comment #3 from H?ctor Eduardo Castro Avalos --- Hi Jonathan Just one question: I don't need to apply another/others bug on top? For me works fine applying this single patch. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 17:00:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 16:00:01 +0000 Subject: [Koha-bugs] [Bug 15143] Removing a Guarantee from a Guarantors account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15143 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 17:00:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 16:00:20 +0000 Subject: [Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 17:21:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 16:21:23 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #2 from Jesse Weaver --- That's exactly the plan, Jonathan. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 17:39:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 16:39:24 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 --- Comment #1 from Owen Leonard --- Created attachment 47929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47929&action=edit Bug 15785 - Use Font Awesome icons in confirmation dialogs We can simplify the staff client's CSS and reduce some image file usage if we modify confirmation dialogs to use Font Awesome icons. This patch makes this change for Administration templates. This patch includes some whitespace changes, so please consider that when looking at diffs. To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Administration -> Budgets -> Delete budget Administration -> Funds -> Delete fund Administration -> Authority types -> Delete authority type Administration -> Authority types -> MARC Structure -> Delete tag Administration -> Authority types -> MARC Structure -> Subfields -> Delete Administration -> MARC bibliographic framework -> Delete framework Administration -> MARC bibliographic framework -> MARC structure -> Delete Administration -> Cities and Towns -> Delete city Administration -> Classification sources -> Delete classification source Administration -> Classification sources -> Delete classification filing rule Administration -> Item types -> Delete Administration -> Record matching rules -> Delete Administration -> Patron attribute types -> Delete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 17:39:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 16:39:22 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 17:42:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 16:42:54 +0000 Subject: [Koha-bugs] [Bug 15790] Don't delete a MARC framework if existing records use that framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 17:45:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 16:45:28 +0000 Subject: [Koha-bugs] [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15803 [Bug 15803] Koha::AuthorisedValues - Remove GetAuthorisedValueCategories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 17:45:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 16:45:28 +0000 Subject: [Koha-bugs] [Bug 15803] Koha::AuthorisedValues - Remove GetAuthorisedValueCategories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 17:46:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 16:46:08 +0000 Subject: [Koha-bugs] [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 --- Comment #4 from Jonathan Druart --- H?ctor, So there is no deps for this patch. Thanks for the signoff! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 17:48:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 16:48:55 +0000 Subject: [Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver at bywatersolutions.co |kyle at bywatersolutions.com |m | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:08:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:08:16 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:11:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:11:57 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:12:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:12:00 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47929|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47930&action=edit [SIGNED-OFF]Bug 15785 - Use Font Awesome icons in confirmation dialogs We can simplify the staff client's CSS and reduce some image file usage if we modify confirmation dialogs to use Font Awesome icons. This patch makes this change for Administration templates. This patch includes some whitespace changes, so please consider that when looking at diffs. To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Administration -> Budgets -> Delete budget Administration -> Funds -> Delete fund Administration -> Authority types -> Delete authority type Administration -> Authority types -> MARC Structure -> Delete tag Administration -> Authority types -> MARC Structure -> Subfields -> Delete Administration -> MARC bibliographic framework -> Delete framework Administration -> MARC bibliographic framework -> MARC structure -> Delete Administration -> Cities and Towns -> Delete city Administration -> Classification sources -> Delete classification source Administration -> Classification sources -> Delete classification filing rule Administration -> Item types -> Delete Administration -> Record matching rules -> Delete Administration -> Patron attribute types -> Delete Signed-off-by: Hector Castro Works as advertised. Icons changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:12:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:12:20 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:13:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:13:12 +0000 Subject: [Koha-bugs] [Bug 15790] Don't delete a MARC framework if existing records use that framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15785 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:13:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:13:12 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 [Bug 15790] Don't delete a MARC framework if existing records use that framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:14:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:14:15 +0000 Subject: [Koha-bugs] [Bug 15790] Don't delete a MARC framework if existing records use that framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:14:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:14:18 +0000 Subject: [Koha-bugs] [Bug 15790] Don't delete a MARC framework if existing records use that framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 --- Comment #1 from Owen Leonard --- Created attachment 47931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47931&action=edit Bug 15790 - Don't delete a MARC framework if existing records use that framework If a MARC framework is in use by any records it should not be possible to delete it. Deleting a framework which is in use will leave the deleted framework code in those records. This patch modifies the deletion confirmation dialog so that it will not let the user confirm the deletion if there are records using it. Depends on Bug 15785 - Use Font Awesome icons in confirmation dialogs To test, apply the patch and go to Administration -> MARC frameworks 1. Try to delete a framework which is in use by 1 or more records. The resulting confirmation dialog should prevent you from proceeding. 2. Try to delete a framework which is not in use. Test both canceling and confirming that deletion to make both function correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:21:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:21:06 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:24:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:24:06 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15804 --- Comment #3 from Marc V?ron --- Created attachment 47932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47932&action=edit Bug 15785 - Use Font Awesome icons in confirmation dialogs We can simplify the staff client's CSS and reduce some image file usage if we modify confirmation dialogs to use Font Awesome icons. This patch makes this change for Administration templates. This patch includes some whitespace changes, so please consider that when looking at diffs. To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Administration -> Budgets -> Delete budget Administration -> Funds -> Delete fund Administration -> Authority types -> Delete authority type Administration -> Authority types -> MARC Structure -> Delete tag Administration -> Authority types -> MARC Structure -> Subfields -> Delete Administration -> MARC bibliographic framework -> Delete framework Administration -> MARC bibliographic framework -> MARC structure -> Delete Administration -> Cities and Towns -> Delete city Administration -> Classification sources -> Delete classification source Administration -> Classification sources -> Delete classification filing rule Administration -> Item types -> Delete Administration -> Record matching rules -> Delete Administration -> Patron attribute types -> Delete Signed-off-by: Hector Castro Works as advertised. Icons changed Signed-off-by: Marc V?ron Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15804 [Bug 15804] Use standard dialog style for confirmation of MARC subfield deletion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:28:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:28:33 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #47932|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Comment on attachment 47932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47932 Bug 15785 - Use Font Awesome icons in confirmation dialogs Hector was faster :-) Obsoleting my sign-off patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:31:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:31:39 +0000 Subject: [Koha-bugs] [Bug 15790] Don't delete a MARC framework if existing records use that framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47931|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 47933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47933&action=edit Bug 15790 - Don't delete a MARC framework if existing records use that framework If a MARC framework is in use by any records it should not be possible to delete it. Deleting a framework which is in use will leave the deleted framework code in those records. This patch modifies the deletion confirmation dialog so that it will not let the user confirm the deletion if there are records using it. Depends on Bug 15785 - Use Font Awesome icons in confirmation dialogs To test, apply the patch and go to Administration -> MARC frameworks 1. Try to delete a framework which is in use by 1 or more records. The resulting confirmation dialog should prevent you from proceeding. 2. Try to delete a framework which is not in use. Test both canceling and confirming that deletion to make both function correctly. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:32:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:32:15 +0000 Subject: [Koha-bugs] [Bug 15790] Don't delete a MARC framework if existing records use that framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:39:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:39:38 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:43:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:43:39 +0000 Subject: [Koha-bugs] [Bug 15670] Rename "Cancel" to "Cancel hold" when checking in a waiting item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15670 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47898|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 47935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47935&action=edit Bug 15670 - Rename "Cancel" to "Cancel hold" when checking in a waiting item When checking in an on-hold item which is waiting, the "Cancel" button cancels the hold, so it should say so. This patch changes the text. This patch also moves the 'cancel hold' button to the middle, on the theory that buttons on the left should default to 'confirm' and buttons on the right should generally imply 'cancel'--as in 'do nothing.' Moving it to the middle seems like a good place to put it where users will have to think about clicking it. To test: 1. Find an hold which has been made 'waiting,' or check in an confirm a pending hold at your library. 2. Check in that item again and verify that the 'Hold found' dialog contains a 'Cancel hold' button which works to cancel the waiting hold. 3. Repeat the process and confirm that the functionality of the other buttons is unchanged. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 18:43:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 17:43:56 +0000 Subject: [Koha-bugs] [Bug 15670] Rename "Cancel" to "Cancel hold" when checking in a waiting item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15670 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 19:02:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 18:02:39 +0000 Subject: [Koha-bugs] [Bug 15806] New: Remove obsolete vendor prefixes from staff client CSS Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15806 Bug ID: 15806 Summary: Remove obsolete vendor prefixes from staff client CSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org staff-global.css contains many rules which are obsolete now that browsers have progressed in their CSS compliance. I propose we remove: background-image: -o-linear-gradient background-image: -moz-linear-gradient background-image: -webkit-linear-gradient filter: progid:DXImageTransform.Microsoft.gradient (see http://caniuse.com/#feat=css-gradients) -moz-border-radius (see http://caniuse.com/#feat=border-radius) -moz-box-shadow -webkit-box-shadow (see http://caniuse.com/#feat=css-boxshadow) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 19:05:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 18:05:51 +0000 Subject: [Koha-bugs] [Bug 15806] Remove obsolete vendor prefixes from staff client CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15806 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 19:26:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 18:26:23 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 --- Comment #8 from M. Tompsett --- (In reply to Blou from comment #7) > Although I would prefer Magnus' code snippet overall, > because it's less ugly -- totally agree. > than the big "if" that gives too much importance to that feature IMO, adding > $debug is following the standard and expectations. > > I like standards... And the discussion on development mailing list may end up turning this functionality into a plug-in in the future, but until then, this suffices. +1 to future plugin. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 20:30:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 19:30:23 +0000 Subject: [Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 --- Comment #1 from Kyle M Hall --- Created attachment 47936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47936&action=edit Bug 14577 - Allow restriction of checkouts based on fines of guarantor's guarantees This enhancment allows a library to prevent patrons from checking out items if his or her guarantees own too much. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 20:45:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 19:45:08 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |BLOCKED --- Comment #210 from Brendan Gallagher --- Reverted from master. Making Status as Blocked. Jonathan please choose the status you'd prefer for this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 21:07:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 20:07:25 +0000 Subject: [Koha-bugs] [Bug 15775] User should know when they are blocked from checkouts on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 21:07:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 20:07:28 +0000 Subject: [Koha-bugs] [Bug 15775] User should know when they are blocked from checkouts on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47833|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 47937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47937&action=edit Bug 15775 - User should know when they are blocked from checkouts on OPAC When a user has been blocked from checkouts in the staff client for having too many fines, they will now see a message about this in the OPAC To test: - This patch will be easiest to test if you keep three tabs open - system preferences, a patron detail page, and OPAC summary page - Set some system preferences: - OPACFineNoRenewals = 2 - noissuescharge = 4 - OpacRenewalAllowed = Allow - Set up a patron with fines of $3 - Log in to the OPAC and verify the message from patch from Bug 15374, saying the user cannot renew books. Confirm link to accounts page works. - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm the message disappears - Set OpacRenewalAllowed = Allow - Give the patron total fines of $5 (add $2) - Refresh OPAC Summary and verify message appears saying user is BLOCKED from checkouts. Confirm link to accounts page works - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm message is still there Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 21:08:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 20:08:43 +0000 Subject: [Koha-bugs] [Bug 15775] User should know when they are blocked from checkouts on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #5 from Aleisha Amohia --- (In reply to Marc V?ron from comment #3) > Hi Aleisha, > > If I apply this patch on top of Bug 15374, I get merge conflicts. Hi Marc, please try applying on it's own (not on top of Bug 15374). I used the patch from 15374 to write this patch but I realise now it probably doesn't need to be applied on top of the other one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 21:11:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 20:11:57 +0000 Subject: [Koha-bugs] [Bug 15681] Improve visibility of place hold option when checking out an item already checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 --- Comment #4 from Aleisha Amohia --- (In reply to Owen Leonard from comment #3) > Created attachment 47891 [details] > Screenshot of a test case > > In testing this I randomly happened to pick an item which was both checked > out and on hold for someone, so this dialog got pretty complicated. > > Currently buttons in dialogs have a special style which is different from > other buttons. As you can see the patch doesn't modify them all. I would > prefer to not use the Bootstrap style buttons here and keep the existing > dialog button style. I think if we want to change the style of dialog > buttons we should do it across the board. > > I'm beginning to do so--at least for the icons--with Bug 15785. Ah I see! I think we should be changing all of the buttons and icons to be consistent with the buttons all over the site. Should I make a patch for circ templates like you have for acquisitions and add it to your bug or just make a new bug for each module? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 21:23:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 20:23:52 +0000 Subject: [Koha-bugs] [Bug 15681] Improve visibility of place hold option when checking out an item already checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 --- Comment #5 from Owen Leonard --- (In reply to Aleisha Amohia from comment #4) > Ah I see! I think we should be changing all of the buttons and icons to be > consistent with the buttons all over the site. I see a value in having (slightly) different button styles for different areas, but this isn't a rule that anyone has discussed or agreed on. For instance: Toolbars get one button style, dialogs get another, everything else a third. This obviously isn't something we're being consistent about now because many new template changes are using Bootstrap-style buttons by default wherever they are. I'm interested in hearing your (and anyone else's) opinion about that idea. Koha really needs a style guide. More work, though, boo. > Should I make a patch for > circ templates like you have for acquisitions and add it to your bug or just > make a new bug for each module? I think a new bug for each module makes sense so that it's easy to keep track of which patches depend on which. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 21:41:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 20:41:08 +0000 Subject: [Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 21:41:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 20:41:11 +0000 Subject: [Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793 --- Comment #1 from Aleisha Amohia --- Created attachment 47938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47938&action=edit Bug 15793: Add floating toolbar to circulation.tt To test: 1) Put in a patron search that will bring back a long list of patrons (ie the letter 'a') 2) Confirm 'Select patron' button is now at the top 3) Scroll down page, confirm button toolbar follows you down the page 4) Select a patron and click button - confirm you are taken to the correct patron page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 22:04:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 21:04:24 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 --- Comment #2 from Nick Clemens --- In IRC: I suggested: HideItemsNotCheckedIn or DisplayAllItemScannedAtCheckin cait: suggested: ShowAllCheckins I think any would be fine but I think libraries will want this soon and a name change is always possible if we don't like it later -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 22:09:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 21:09:16 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org --- Comment #3 from Heather Braum --- I just want to add my two cents in on this that for our consortia, where we're transferring lots of items in and out, libraries are used to seeing these items listed. It's critical for our operations at 50 libraries to have this list of items enabled. I have no preference on what it's called. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 22:21:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 21:21:40 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 23:03:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 22:03:33 +0000 Subject: [Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 23:07:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 22:07:26 +0000 Subject: [Koha-bugs] [Bug 15807] New: library branch sorting on guarantor_search.pl is incorrect Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15807 Bug ID: 15807 Summary: library branch sorting on guarantor_search.pl is incorrect Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The library branch sorting on guarantor_search.pl is incorrect. It's displaying as Leavenworth... Carbondale... Prairie Hills... Lyndon... and so on. The sorting behavior is the same as what was reported and fixed on this bug, https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13950, if that helps resolve this one more quickly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 11 23:07:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Feb 2016 22:07:26 +0000 Subject: [Koha-bugs] [Bug 13950] Sort Item search home library list by branch name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13950 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15807 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 02:07:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 01:07:51 +0000 Subject: [Koha-bugs] [Bug 11088] Patron entry page should use floating toolbar like cataloging interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11088 --- Comment #1 from Aleisha Amohia --- Created attachment 47939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47939&action=edit Bug 11088: Floating toolbar to patron entry page ~ THIS IS NOT READY FOR SIGN OFF ~ Can someone who knows a bit about jquery (and maybe css) apply what I've got in this patch so far and work out why the toolbar keeps jumping down the page as soon as I scroll? The functionality of the toolbar and scrolling etc seems to work as it should, but I can't work out why it keeps jumping! Help appreciated! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 03:10:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 02:10:43 +0000 Subject: [Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47938|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 47940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47940&action=edit Bug 15793: Add floating toolbar to circulation.tt To test: 1) Put in a patron search that will bring back a long list of patrons (ie the letter 'a') 2) Confirm 'Select patron' button is now at the top 3) Scroll down page, confirm button toolbar follows you down the page 4) Select a patron and click button - confirm you are taken to the correct patron page Signed-off-by: Liz Rea This is much nicer, thank you. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 03:26:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 02:26:12 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Francesca Moore changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chloealabaster at gmail.com |francescamoore at catalyst.net | |.nz CC| |francescamoore at catalyst.net | |.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 05:21:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 04:21:45 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 --- Comment #1 from M. Tompsett --- Created attachment 47941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47941&action=edit Bug 15777 - Test to prove initialization isn't working correctly. TEST PLAN --------- 1) Apply this testing patch 2) prove -v t/RecordProcessor.t -- tests will fail. 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 05:25:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 04:25:59 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 --- Comment #2 from M. Tompsett --- Created attachment 47942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47942&action=edit Bug 15777 - Fix base class to prove refactor and fix required TEST PLAN --------- 1) Apply the testing patch and this patch 2) prove -v t/RecordProcess.t -- will complain about string use with "use strict". This is because it is using the module name, instead of the object instantiated with new(). 3) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 05:32:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 04:32:40 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 05:32:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 04:32:43 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 --- Comment #3 from M. Tompsett --- Created attachment 47943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47943&action=edit Bug 15777 - Refactor and fix the RecordProcessor class TEST PLAN --------- 1) Apply all three patches 2) prove -v t/RecordProcessor.t -- all should be successful 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 05:57:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 04:57:34 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47420|0 |1 is obsolete| | --- Comment #8 from Srdjan Jankovic --- Created attachment 47944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47944&action=edit bug_15562: Sysprefs cache is object property now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 05:58:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 04:58:08 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47838|0 |1 is obsolete| | --- Comment #9 from Srdjan Jankovic --- Created attachment 47945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47945&action=edit bug_15562: Use do() rather than system() to execute updatedatabase.pl from installer.pl That way: * no external process is spawned * code executes in the same perl process, which is required for plack multi-site I have a dream. A dream that one day all code from .pl's will be in some .pm's. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 05:58:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 04:58:30 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47421|0 |1 is obsolete| | --- Comment #10 from Srdjan Jankovic --- Created attachment 47946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47946&action=edit bug_15562: Multi-host helper for plack installations Sort of an apocalypse * C4::Context->new() must be called with at least config file param. If you want current context, call C4::Context->current(). C4::Context->some_method() will still work as is. * Koha::Database->new_schema() now takes optional context param. * C4::Context->set_context() and restore_context() are synched with database set_schema() and restore_schema(). Created run_within_context() that wraps set_context() and restore_context() around code. * Created Koha::Handler::Plack* to facilitate running same code within different (database) contexts. * This initial version does not run with memcached turned on. Next patch will correct that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 05:58:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 04:58:45 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47422|0 |1 is obsolete| | --- Comment #11 from Srdjan Jankovic --- Created attachment 47947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47947&action=edit bug_15562: Removed Koha::Cache->get_instance() There should be no cache singleton, full stop. If Koha is to move away from .pl scripts that is. As an interim measure Koha::Cache->get_instance() is replaced with C4::Context->cache, in the vein of C4::Context->memcached. In that respect it will continue to work in the singleton-ish way if context is used as a singleton, but supports cache-per-context. Koha::Handler::Plack->app_per_host() cache sysprefs using Context memcached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 06:04:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 05:04:28 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:34:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:34:00 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #13 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:34:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:34:25 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #254 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:34:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:34:44 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #14 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:35:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:35:02 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #16 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:35:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:35:21 +0000 Subject: [Koha-bugs] [Bug 12045] Transfer impossible if barcode includes spaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12045 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:35:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:35:40 +0000 Subject: [Koha-bugs] [Bug 15680] Fresh install of Koha cannot find any dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:36:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:36:31 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #31 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:36:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:36:47 +0000 Subject: [Koha-bugs] [Bug 15209] C4::Koha routines expecting a MARC::Record object should check it is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15209 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #10 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:37:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:37:15 +0000 Subject: [Koha-bugs] [Bug 9754] koha-remove optionally includes var/lib and var/spool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #11 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:37:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:37:33 +0000 Subject: [Koha-bugs] [Bug 15391] HoldsQueue.t does not handle for loan itemtypes correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #12 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:37:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:37:48 +0000 Subject: [Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:38:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:38:02 +0000 Subject: [Koha-bugs] [Bug 15353] patron image disappears when on fines tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:38:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:38:18 +0000 Subject: [Koha-bugs] [Bug 15357] Deleting all items on a record with title level holds creates orphaned/ghost holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15357 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #10 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:38:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:38:32 +0000 Subject: [Koha-bugs] [Bug 15576] Link in OPAC redirects to the wrong page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15576 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:38:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:38:47 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #10 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:39:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:39:02 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 --- Comment #12 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:39:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:39:19 +0000 Subject: [Koha-bugs] [Bug 12636] Batch patron modification should not update with unique patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12636 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:39:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:39:49 +0000 Subject: [Koha-bugs] [Bug 14555] Warns in opac-search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555 --- Comment #15 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:40:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:40:06 +0000 Subject: [Koha-bugs] [Bug 14810] Improve messages in patron anonymizing tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14810 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:40:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:40:27 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #14 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:40:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:40:51 +0000 Subject: [Koha-bugs] [Bug 14624] <> for advance_notices.pl wrongly documented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #9 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:41:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:41:05 +0000 Subject: [Koha-bugs] [Bug 15476] Listname not always displayed in shelves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15476 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:41:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:41:23 +0000 Subject: [Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #9 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:41:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:41:41 +0000 Subject: [Koha-bugs] [Bug 15592] spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15592 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:41:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:41:54 +0000 Subject: [Koha-bugs] [Bug 15468] Search links on callnumbers with parentheses fails on OPAC results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:42:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:42:13 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #11 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:42:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:42:28 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #21 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:42:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:42:58 +0000 Subject: [Koha-bugs] [Bug 14641] Warns in subscription-add.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #13 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:43:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:43:13 +0000 Subject: [Koha-bugs] [Bug 15611] Spelling mistake: implimented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15611 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:43:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:43:30 +0000 Subject: [Koha-bugs] [Bug 15613] Spelling mistake: paramter vs parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15613 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:43:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:43:49 +0000 Subject: [Koha-bugs] [Bug 15614] Spelling mistake in circ/pendingreserves.tt: Fullfilled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15614 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:44:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:44:02 +0000 Subject: [Koha-bugs] [Bug 15619] Spelling mistake in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15619 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:44:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:44:17 +0000 Subject: [Koha-bugs] [Bug 15621] Spelling mistake in printinvoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15621 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:44:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:44:37 +0000 Subject: [Koha-bugs] [Bug 15623] Spelling mistake in boraccount.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15623 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:44:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:44:53 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #24 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:45:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:45:07 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 --- Comment #21 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:45:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:45:22 +0000 Subject: [Koha-bugs] [Bug 15589] OPAC Lists "his" string fix In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15589 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:45:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:45:39 +0000 Subject: [Koha-bugs] [Bug 15597] Typo in opac-auth-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:45:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:45:51 +0000 Subject: [Koha-bugs] [Bug 15598] Typo in subscription-add.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15598 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:46:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:46:07 +0000 Subject: [Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 07:46:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 06:46:29 +0000 Subject: [Koha-bugs] [Bug 15298] z39.50 admin setup, options column suggested changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:10:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:10:28 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:14:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:14:46 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:14:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:14:49 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 --- Comment #9 from Marcel de Rooy --- Created attachment 47948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47948&action=edit Bug 15795: C4/Members.pm is floody (Norwegian Patron DB) >From the mailing list: "I'm working on 3.22.02 and my logs are FILLED with the following warnings: Members.pm: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/acqui/booksellers.pl admin-home.pl: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/admin/preferences.pl" I agree. Looking at C4/Members.pm other warns are all prepended with $debug. TEST PLAN --------- 1) rm Koha/NorwegianPatronDB.pm -- quickest and dirtiest way to get the load to fail. 2) echo > ~/koha-dev/var/log/koha-error_log -- so it will be easy to spot the log changes. -- back up the log file if you really want it. 3) log into the staff client and go to patrons. -- Check the log file. "Unable to load ..." will be there. 4) echo > ~/koha-dev/var/log/koha-error_log 5) sudo vi /etc/apache2/sites-enabled/{your koha site file} -- Find your staff client entry in your apache configuration file and add: SetEnv DEBUG 1 6) sudo service apache2 restart 7) apply the patch 8) refresh the patron page -- "Unable to load..." will still be there. 9) change the DEBUG value in your apache config to 0 10) sudo sevice apache2 restart 11) echo > ~/koha-dev/var/log/koha-error_log 12) refresh the patron page -- "Unable to load..." will NOT be there. 13) git checkout origin/master -- Koha/NorwegianPatronDB.pm -- to bring it back. 14) refresh the patron page -- "Unable to load..." will still not be there. 15) run koha qa test tools Signed-off-by: Philippe Blouin Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:15:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:15:11 +0000 Subject: [Koha-bugs] [Bug 15795] C4/Members.pm is floody (Norwegian Patron DB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:17:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:17:57 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #12 from Fr?d?ric Demians --- What about $use_syspref_cache variable and disable_syspref_cache() method? Shouldn't it be removed? What is your test environment? Do you use debian/templates/plack.psgi? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:22:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:22:44 +0000 Subject: [Koha-bugs] [Bug 15670] Rename "Cancel" to "Cancel hold" when checking in a waiting item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15670 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:23:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:23:05 +0000 Subject: [Koha-bugs] [Bug 15670] Rename "Cancel" to "Cancel hold" when checking in a waiting item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15670 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:23:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:23:07 +0000 Subject: [Koha-bugs] [Bug 15670] Rename "Cancel" to "Cancel hold" when checking in a waiting item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15670 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47935|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 47949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47949&action=edit Bug 15670 - Rename "Cancel" to "Cancel hold" when checking in a waiting item When checking in an on-hold item which is waiting, the "Cancel" button cancels the hold, so it should say so. This patch changes the text. This patch also moves the 'cancel hold' button to the middle, on the theory that buttons on the left should default to 'confirm' and buttons on the right should generally imply 'cancel'--as in 'do nothing.' Moving it to the middle seems like a good place to put it where users will have to think about clicking it. To test: 1. Find an hold which has been made 'waiting,' or check in an confirm a pending hold at your library. 2. Check in that item again and verify that the 'Hold found' dialog contains a 'Cancel hold' button which works to cancel the waiting hold. 3. Repeat the process and confirm that the functionality of the other buttons is unchanged. Followed test plan, works as expected. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:27:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:27:08 +0000 Subject: [Koha-bugs] [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:27:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:27:37 +0000 Subject: [Koha-bugs] [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:27:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:27:40 +0000 Subject: [Koha-bugs] [Bug 15797] C4::Koha::GetKohaImageurlFromAuthorisedValues is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15797 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47928|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 47950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47950&action=edit Bug 15797: Remove C4::Koha::GetKohaImageurlFromAuthorisedValues This subroutine is no longer in used and can be remove. Test plan: git grep GetKohaImageurlFromAuthorisedValues should not return any results. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:32:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:32:03 +0000 Subject: [Koha-bugs] [Bug 15769] C4::Koha::slashifyDate is outdated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:32:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:32:25 +0000 Subject: [Koha-bugs] [Bug 15769] C4::Koha::slashifyDate is outdated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:32:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:32:28 +0000 Subject: [Koha-bugs] [Bug 15769] C4::Koha::slashifyDate is outdated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47827|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 47951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47951&action=edit Bug 15769: Remove outdated C4::Koha::slashifyDate subroutine This subroutine does not make sense anymore (Koha::DateUtils should be used) and is no longer used. It can be removed safely. Test plan: git grep slashifyDate should not return any results prove t/Koha.t and prove t/db_dependent/Koha.t should return green Signed-off-by: Hector Castro slashifyDate removed, all test pass successfully Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:33:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:33:10 +0000 Subject: [Koha-bugs] [Bug 15798] C4::Koha::displayServers is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:35:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:35:46 +0000 Subject: [Koha-bugs] [Bug 15798] C4::Koha::displayServers is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:35:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:35:49 +0000 Subject: [Koha-bugs] [Bug 15798] C4::Koha::displayServers is no longer in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15798 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47900|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 47952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47952&action=edit Bug 15798: Remove C4::Koha::displayServers This subroutine is no longer is use and can be removed. Test plan: git grep displayServers should not return any results. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:38:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:38:39 +0000 Subject: [Koha-bugs] [Bug 15771] CGI::escapeHTML should not be used anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15771 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- Need to change status of this report after reverting 13618 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:46:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:46:36 +0000 Subject: [Koha-bugs] [Bug 15776] "Return to where you were before" in sysprefs doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15776 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- Marc, Returning to where I was before, is actually just the tab where I am already. Note that it does not work for Local use (another script). Could you not just remove this link? Just display the alert. Nothing more.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:47:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:47:21 +0000 Subject: [Koha-bugs] [Bug 15776] "Return to where you were before" in sysprefs doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15776 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:47:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:47:33 +0000 Subject: [Koha-bugs] [Bug 15776] "Return to where you were before" in sysprefs doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15776 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:47:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:47:56 +0000 Subject: [Koha-bugs] [Bug 15776] "Return to where you were before" in sysprefs doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15776 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 08:50:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 07:50:53 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Assignee|oleonard at myacpl.org |juan.sieira at xercode.es -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:05:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:05:41 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:05:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:05:45 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47839|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy --- Created attachment 47953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47953&action=edit Bug 11937 - opac link doesn't open in new window Signed-off-by: Juan Romay Sieira Patch works as expected. From a biblio detail page, the link 'OPAC view: Open in new window' opens a new browser window. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:11:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:11:55 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:15:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:15:51 +0000 Subject: [Koha-bugs] [Bug 15776] "Return to where you were before" in sysprefs doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15776 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Marc V?ron --- I will file a new bug and mark this as WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:19:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:19:18 +0000 Subject: [Koha-bugs] [Bug 15808] New: Remove "Return to where you were before" from sysprefs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15808 Bug ID: 15808 Summary: Remove "Return to where you were before" from sysprefs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com See comments on Bug 15776 Description: Go to Admin - System Preferences Click on any tab except for Acquisitions (since this is the default tab to go to) Do a search in the sysprefs toolbar with spelling mistakes so that it will return no results and you are taken to the Acquisitions tab Click the 'Return to where you were before link' in the error message Notice you stay on the Acquisitions tab, which is not where you were before #4 Returning to where I was before, is actually just the tab where I am already. Note that it does not work for Local use (another script). Could you not just remove this link? Just display the alert. Nothing more.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:19:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:19:38 +0000 Subject: [Koha-bugs] [Bug 15808] Remove "Return to where you were before" from sysprefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15808 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15776 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:19:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:19:38 +0000 Subject: [Koha-bugs] [Bug 15776] "Return to where you were before" in sysprefs doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15776 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15808 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:21:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:21:00 +0000 Subject: [Koha-bugs] [Bug 15776] "Return to where you were before" in sysprefs doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15776 --- Comment #5 from Marc V?ron --- See Bug 15808 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:33:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:33:58 +0000 Subject: [Koha-bugs] [Bug 15681] Improve visibility of place hold option when checking out an item already checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 --- Comment #6 from Marc V?ron --- (In reply to Owen Leonard from comment #5) (...) > I see a value in having (slightly) different button styles for different > areas, but this isn't a rule that anyone has discussed or agreed on. For > instance: Toolbars get one button style, dialogs get another, everything > else a third. This obviously isn't something we're being consistent about > now because many new template changes are using Bootstrap-style buttons by > default wherever they are. +1 (...) > Koha really needs a style guide. +1 (...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:35:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:35:30 +0000 Subject: [Koha-bugs] [Bug 15808] Remove "Return to where you were before" from sysprefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15808 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:40:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:40:53 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:41:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:41:16 +0000 Subject: [Koha-bugs] [Bug 15771] CGI::escapeHTML should not be used anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15771 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:43:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:43:01 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX --- Comment #35 from Marc V?ron --- I give up this bug in favor of Bug 15775. Maybe some of the code here can then be used on top of 15775. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:43:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:43:02 +0000 Subject: [Koha-bugs] [Bug 15775] User should know when they are blocked from checkouts on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Bug 15775 depends on bug 15374, which changed state. Bug 15374 Summary: Translatability: Fix issues on OPAC summary page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:44:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:44:25 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #41 from Marcel de Rooy --- QA: Looking at this one now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:48:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:48:01 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15775 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15775 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 [Bug 15775] User should know when they are blocked from checkouts on OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 09:48:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 08:48:01 +0000 Subject: [Koha-bugs] [Bug 15775] User should know when they are blocked from checkouts on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15374 Depends on|15374 | --- Comment #6 from Marc V?ron --- Hi Aleisha, I gave up Bug 15374 because it would have conflicts on top of this Bug. It certainly will make it easier to go on with such enhancements. Plese feel free to re-use code from 15374 on top of your patch, if applicable. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 [Bug 15374] Translatability: Fix issues on OPAC summary page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 10:05:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 09:05:27 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 --- Comment #4 from Jonathan Druart --- Since bug 14821 is in 3.20 and 3.22, what should be considered the default behavior? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 10:05:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 09:05:40 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 10:10:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 09:10:17 +0000 Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15807 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 10:10:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 09:10:17 +0000 Subject: [Koha-bugs] [Bug 15807] library branch sorting on guarantor_search.pl is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15758 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- This will be fixed by bug 15758. It may be useful to provide a patch for 3.22 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 10:23:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 09:23:02 +0000 Subject: [Koha-bugs] [Bug 15808] Remove "Return to where you were before" from sysprefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15808 --- Comment #1 from Marc V?ron --- Created attachment 47954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47954&action=edit Bug 15808 - Remove "Return to where you were before" from sysprefs This patch removes the link 'return to where you were before' from syspref search result page after failing search. To test: - Apply patch - Go to System preferences in staff client, do a search with something that does not exist - Verify that a message pops up that does not contain the link. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 10:23:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 09:23:23 +0000 Subject: [Koha-bugs] [Bug 15808] Remove "Return to where you were before" from sysprefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15808 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 10:38:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 09:38:58 +0000 Subject: [Koha-bugs] [Bug 15717] Installer: Step 3 has
    showing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #6 from Jonathan Druart --- Depends on bug 13618, which has been reverted from master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 10:39:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 09:39:12 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |BLOCKED --- Comment #6 from Jonathan Druart --- Depends on bug 13618, which has been reverted from master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 10:39:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 09:39:30 +0000 Subject: [Koha-bugs] [Bug 15754] html tags displayed when editing frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #6 from Jonathan Druart --- Depends on bug 13618, which has been reverted from master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 10:43:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 09:43:47 +0000 Subject: [Koha-bugs] [Bug 15808] Remove "Return to where you were before" from sysprefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15808 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 10:43:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 09:43:50 +0000 Subject: [Koha-bugs] [Bug 15808] Remove "Return to where you were before" from sysprefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15808 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47954|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy --- Created attachment 47955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47955&action=edit Bug 15808 - Remove "Return to where you were before" from sysprefs This patch removes the link 'return to where you were before' from syspref search result page after failing search. To test: - Apply patch - Go to System preferences in staff client, do a search with something that does not exist - Verify that a message pops up that does not contain the link. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 10:45:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 09:45:07 +0000 Subject: [Koha-bugs] [Bug 15808] Remove "Return to where you were before" from sysprefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15808 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |Passed QA --- Comment #3 from Marcel de Rooy --- Viewing this patch as a qa follow-up for 15776. Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 11:31:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 10:31:49 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 11:31:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 10:31:53 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47588|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy --- Created attachment 47956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47956&action=edit Bug 12426: Allow resending of messages from the notices tab in the patron account This patch adds a link 'Resend' under a notice in 'failed' status in the Patron's Notices tab. By clicking the link, we will request notices.pl with parameter "resendnotice=XXXXX" where XXXXX is message_id. In notices.pl, we then check whether the given message is actually in 'failed' status. If so, we use the C4::Letters::ResendMessage(123) to change the status of the message into 'pending'. This way it will be processed again by the cronjob process_message_queue.pl. To test, find/create a Patron that has failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the failed message 4. Observe that there is nothing for resending the failed message 5. Apply patch. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status Works as expected. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 11:32:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 10:32:00 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47589|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy --- Created attachment 47957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47957&action=edit Bug 12426: Simplify the code adding a new subroutine GetMessage The C4::Letters module does not have a GetMessage subroutine, which could be quite useful. This patch adds it and simplifies the code added by the previous patch. It also adds a few tests and fixes POD typos. Note that ResendNotice only resends failed messages. This will avoid to resend already sent messages (using an url from the browser history for instance). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 11:32:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 10:32:06 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47590|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy --- Created attachment 47958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47958&action=edit Bug 12426: Allow resend for sent messages This patch allows to resend both sent and failed messages. With messages in 'sent' status, we have to be careful not to accidentally send sent messages again. With the previous patch using GET request, this was likely to happen because of browser storing the GET parameters. This patch changes request method from GET to POST. Instead of a simple link, we now have a form element. In notices.pl we redirect back to notices.pl, because with POST there is a risk of resending the message accidentally by form resubmission at refresh. To test, find/create a Patron that has sent or failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the sent or failed message 4. Observe that there is nothing for resending the sent or failed message 5. Apply the patches. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status Tested all patches together. Works as expected. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 11:32:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 10:32:24 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 11:41:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 10:41:47 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #45 from Marcel de Rooy --- Perhaps we could also think about clearing the to_address and reading it again (as is done in SendQueuedLetters already). You could have adjusted the patron's email address (possible trigger for resending an email) and now you want to resend to the new/corrected email address. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 11:44:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 10:44:55 +0000 Subject: [Koha-bugs] [Bug 15796] C4::Koha - get_itemtypeinfos_of is not used anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15796 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 11:44:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 10:44:58 +0000 Subject: [Koha-bugs] [Bug 15796] C4::Koha - get_itemtypeinfos_of is not used anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15796 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47892|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 47959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47959&action=edit Bug 15796: Remove C4::Koha::get_itemtypeinfos_of This subroutine is no longer in use. Test plan: git grep get_itemtypeinfos_of should not return any results. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 11:52:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 10:52:01 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #46 from Katrin Fischer --- Ah, I thought it always rechecked before sending it - maybe in another piece of code? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 11:54:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 10:54:01 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47903|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 47960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47960&action=edit Bug 15747 Auth.pm flooding error log with "CGI::param called in list context" TEST PLAN --------- 1) git checkout -b bug_15747 origin/master 2) echo > ~/koha-dev/var/log/koha-error_log 3) open up staff interface and log in. 4) cat ~/koha-dev/var/log/koha-error_log *** BEGIN SNIP *** [Thu Feb 11 09:49:43.627711 2016] [cgi:error] [pid 2132] [client 192.168.71.222:51107] AH01215: [Thu Feb 11 09:49:43 2016] mainpage.pl: CGI::param called in list context from package C4::Auth line 401, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://library-admin.debiankoha.ca/ *** END SNIP *** 5) logout 6) apply patch 7) echo > ~/koha-dev/var/log/koha-error_log 8) log back in. 9) cat ~/koha-dev/var/log/koha-error_log -- this time should not be there. 10) koha qa test tools Signed-off-by: Marcel de Rooy Warning probably depends on the version of perl/CGI. But this clearly makes it a scalar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 11:53:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 10:53:59 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:08:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:08:03 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #47 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #45) > Perhaps we could also think about clearing the to_address and reading it > again (as is done in SendQueuedLetters already). > > You could have adjusted the patron's email address (possible trigger for > resending an email) and now you want to resend to the new/corrected email > address. That's a very good remark and the expected behavior. IMO it should be a requirement for this patch to be pushed (as it's very easy to implement). (In reply to Katrin Fischer from comment #46) > Ah, I thought it always rechecked before sending it - maybe in another piece > of code? Usually the to_address is not set when inserting the message to the message queue. The _send_message_by_email get the patron's email address only if the message does not have one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:20:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:20:01 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #6 from Alex Arnaud --- Created attachment 47961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47961&action=edit Bug 15516 - Holding first available item from x biblios only count 1 reserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:21:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:21:05 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47570|0 |1 is obsolete| | --- Comment #7 from Alex Arnaud --- Created attachment 47962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47962&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:21:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:21:11 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47961|0 |1 is obsolete| | --- Comment #8 from Alex Arnaud --- Created attachment 47963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47963&action=edit Bug 15516 - Holding first available item from x biblios only count 1 reserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:30:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:30:51 +0000 Subject: [Koha-bugs] [Bug 15809] New: versions of CGI < 4.08 do not have multi_param Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Bug ID: 15809 Summary: versions of CGI < 4.08 do not have multi_param Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org On debian Jessie, the CGI version is >= 4.08 Since this version, the param method raise a warning "CGI::param called in list context". Indeed, it can cause vulnerability if called in list context https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named-parameter http://blog.gerv.net/2014/10/new-class-of-vulnerability-in-perl-web-applications/ There is a long journey to get rid of these warnings. First I suggest to redefine the multi_param method when the CGI version installed is < 4.08, it will allow us to move the wrong ->param calls to ->multi_param without waiting for everybody to upgrade. The different ways to call these 2 methods are: my $foo = $cgi->param('foo'); # OK my @foo = $cgi->param('foo'); # NOK, will raise the warning my @foo = $cgi->multi_param('foo'); #OK $template->param( foo => $cgi->param('foo') ); # NOK, will raise the warning and vulnerable $template->param( foo => scalar $cgi->param('foo') ); # OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:31:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:31:15 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mtompset at hotmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:31:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:31:22 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 [Bug 15809] versions of CGI < 4.08 do not have multi_param -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:31:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:31:22 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:31:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:31:32 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14076 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 [Bug 14076] Noisy warns in opac-authorities-home.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:31:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:31:32 +0000 Subject: [Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15809 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|In Discussion |ASSIGNED Assignee|mtompset at hotmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 [Bug 15809] versions of CGI < 4.08 do not have multi_param -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:35:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:35:44 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #1 from Jonathan Druart --- Created attachment 47964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47964&action=edit Bug 15809: Redefine multi_param is CGI < 4.08 is used On debian Jessie, the CGI version is >= 4.08 Since this version, the param method raise a warning "CGI::param called in list context". Indeed, it can cause vulnerability if called in list context https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named-parameter http://blog.gerv.net/2014/10/new-class-of-vulnerability-in-perl-web-applications/ There is a long journey to get rid of these warnings. First I suggest to redefine the multi_param method when the CGI version installed is < 4.08, it will allow us to move the wrong ->param calls to ->multi_param without waiting for everybody to upgrade. The different ways to call these 2 methods are: my $foo = $cgi->param('foo'); # OK my @foo = $cgi->param('foo'); # NOK, will raise the warning my @foo = $cgi->multi_param('foo'); #OK $template->param( foo => $cgi->param('foo') ); # NOK, will raise the warning # and vulnerable $template->param( foo => scalar $cgi->param('foo') ); # OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:46:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:46:06 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11559 CC| |jweaver at bywatersolutions.co | |m --- Comment #4 from Jonathan Druart --- Jesse, could you explain what you are doing with document.location.hash? I do not understand the following line in includes/cateditor-ui.inc: 1094 if ( "[% auth_forwarded_hash %]" ) { 1095 document.location.hash = "[% auth_forwarded_hash %]"; 1096 } Should not be: 1094 [% IF auth_forwarded_hash %] 1095 document.location.hash = "[% auth_forwarded_hash %]"; 1096 [% END %] instead? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 [Bug 11559] Professional cataloger's interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:46:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:46:06 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:46:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:46:48 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47964|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 47965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47965&action=edit Bug 15809: Redefine multi_param is CGI < 4.08 is used On debian Jessie, the CGI version is >= 4.08 Since this version, the param method raise a warning "CGI::param called in list context". Indeed, it can cause vulnerability if called in list context https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named-parameter http://blog.gerv.net/2014/10/new-class-of-vulnerability-in-perl-web-applications/ There is a long journey to get rid of these warnings. First I suggest to redefine the multi_param method when the CGI version installed is < 4.08, it will allow us to move the wrong ->param calls to ->multi_param without waiting for everybody to upgrade. The different ways to call these 2 methods are: my $foo = $cgi->param('foo'); # OK my @foo = $cgi->param('foo'); # NOK, will raise the warning my @foo = $cgi->multi_param('foo'); #OK $template->param( foo => $cgi->param('foo') ); # NOK, will raise the warning # and vulnerable $template->param( foo => scalar $cgi->param('foo') ); # OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:47:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:47:54 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47960|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 47966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47966&action=edit Bug 15747: Do not use CGI->param in list context - Auth.pm Test plan: No idea! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:49:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:49:18 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #6 from Jonathan Druart --- (In reply to Jonathan Druart from comment #5) > Created attachment 47966 [details] [review] > Bug 15747: Do not use CGI->param in list context - Auth.pm Theoretically, this patch should be the right way to remove the warning, but I have no idea how to test it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:50:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:50:04 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #12 from bondiurbano --- . -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:53:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:53:17 +0000 Subject: [Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 12:53:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 11:53:20 +0000 Subject: [Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39157|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 47967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47967&action=edit Bug 14076: Do not use CGI->param in list context - opac-authorities-home.pl See bug 15809 for more info on why we should not use CGI->param in list context. Note: I have not found any places where several values for the same params are passed to this script but, just in case, this patch won't change this ability. Test plan: Do an authority search at the OPAC Test with several values of the form. Confirm that the results are always the same before and after this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 13:02:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 12:02:49 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 13:10:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 12:10:22 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 13:54:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 12:54:28 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 --- Comment #3 from Jonathan Druart --- Created attachment 47968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47968&action=edit Bug 5404: C4::Koha - remove subfield_is_koha_internal_p The commit b5ecefd485a75d54a5fa26fff5a0cc890541e2c3 Date: Mon Feb 3 18:46:00 2003 +0000 had a funny description: Added function to check if a MARC subfield name is "koha-internal" (instead of checking it for 'lib' and 'tag' everywhere); temporarily added to Koha.pm "Temporarily", since 2003, everything is relative, isn't it? :) The thing is that GetMarcStructure returns hash like field_200 => { subfield_a => { %attributes_of_subfield_a }, %attributes_of_field_200 } The attributes for field_200 can be 'repeatable', 'mandatory', 'tag', 'lib'. We don't want to loop on these values when looping on subfields. Since there are just { k => v } with v is a scalar (string), it's easier to test if we are processing a subfield testing the reference. At some places, we don't need to test that, we are looping on values from MARC::Field->subfields which are always valid subfields. Test plan: 1/ Edit items using the batch item mod tool 2/ display and edit items via the cataloguing module. You should not see any changes between before and after the patch applied. Tech notes: We need to check what we are processing when we loop on 'subfields' from GetMarcStructure, not from MARC::Field->subfields. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 13:54:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 12:54:25 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 13:54:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 12:54:49 +0000 Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5404 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 13:54:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 12:54:49 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Blocks| |15779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 13:54:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 12:54:57 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 13:57:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 12:57:36 +0000 Subject: [Koha-bugs] [Bug 15761] SIP2 can not save statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15761 Humberto Blanco changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |LATER Status|NEW |RESOLVED --- Comment #1 from Humberto Blanco --- this issue is solved in 3.22.02.000 version -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:00:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:00:30 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #82 from Jonathan Druart --- Kyle, please provide tests for the 2 new modules. See t/db_dependent/Koha/Cities.t for a generic example. You will need to cover the new patrons_using method as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:08:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:08:13 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- Jonathan: What happened here? Previous patch, status etc ?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:08:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:08:50 +0000 Subject: [Koha-bugs] [Bug 15479] SIPserver rejects renewals for patrons with alphanumeric cardnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:08:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:08:53 +0000 Subject: [Koha-bugs] [Bug 15479] SIPserver rejects renewals for patrons with alphanumeric cardnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47811|0 |1 is obsolete| | Attachment #47812|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 47969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47969&action=edit Bug 15479 Make ILS cardnumber comparison case insensitive The borrowers table is defined COLLATE=utf8_unicode_ci which means that cardnumbers may be saved in either lowercase or uppercase and these are considered equivalent. The server was performing a case sensitive comparison between the incoming patron identifier and that retrieved from the db As a result some renewals were rejected as being on loan to another borrower if the stored cardnumber differed in case. Make code comparison comply with db. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:09:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:09:03 +0000 Subject: [Koha-bugs] [Bug 15479] SIPserver rejects renewals for patrons with alphanumeric cardnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479 --- Comment #9 from Kyle M Hall --- Created attachment 47970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47970&action=edit Bug 15479 Add tests for ILS.pm This patch specifically adds a test for the sub added to resolve Bug 15479. As no test script existed to add this two added one which also tests that ILS objects can be instantiated correctly and offer the required interface NOTE: This does not apply without the first patch. Comment #3 suggested a unit test that would fail before and pass after. So while this code is good, it missed the before case. -- mtompset Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:09:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:09:02 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:09:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:09:05 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47930|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 47971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47971&action=edit Bug 15785 - Use Font Awesome icons in confirmation dialogs We can simplify the staff client's CSS and reduce some image file usage if we modify confirmation dialogs to use Font Awesome icons. This patch makes this change for Administration templates. This patch includes some whitespace changes, so please consider that when looking at diffs. To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Administration -> Budgets -> Delete budget Administration -> Funds -> Delete fund Administration -> Authority types -> Delete authority type Administration -> Authority types -> MARC Structure -> Delete tag Administration -> Authority types -> MARC Structure -> Subfields -> Delete Administration -> MARC bibliographic framework -> Delete framework Administration -> MARC bibliographic framework -> MARC structure -> Delete Administration -> Cities and Towns -> Delete city Administration -> Classification sources -> Delete classification source Administration -> Classification sources -> Delete classification filing rule Administration -> Item types -> Delete Administration -> Record matching rules -> Delete Administration -> Patron attribute types -> Delete Signed-off-by: Hector Castro Works as advertised. Icons changed Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:09:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:09:06 +0000 Subject: [Koha-bugs] [Bug 15479] SIPserver rejects renewals for patrons with alphanumeric cardnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479 --- Comment #10 from Kyle M Hall --- Created attachment 47972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47972&action=edit Bug 15479 [QA Followup] - Tidy sub to remove tabs causing qa script to fail Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:09:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:09:17 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #8 from Marcel de Rooy --- The change you make is trivial and is no reason to obsolete what was before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:09:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:09:35 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- I have fixed the conflicts with the revert of bug 13618 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:11:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:11:55 +0000 Subject: [Koha-bugs] [Bug 15790] Don't delete a MARC framework if existing records use that framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:11:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:11:58 +0000 Subject: [Koha-bugs] [Bug 15790] Don't delete a MARC framework if existing records use that framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47933|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 47973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47973&action=edit Bug 15790 - Don't delete a MARC framework if existing records use that framework If a MARC framework is in use by any records it should not be possible to delete it. Deleting a framework which is in use will leave the deleted framework code in those records. This patch modifies the deletion confirmation dialog so that it will not let the user confirm the deletion if there are records using it. Depends on Bug 15785 - Use Font Awesome icons in confirmation dialogs To test, apply the patch and go to Administration -> MARC frameworks 1. Try to delete a framework which is in use by 1 or more records. The resulting confirmation dialog should prevent you from proceeding. 2. Try to delete a framework which is not in use. Test both canceling and confirming that deletion to make both function correctly. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:13:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:13:51 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #83 from Jonathan Druart --- Since I won't be able to test the whole workflow, I would prefer to either get a signoff on this new patchset or let another QAer continues with it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:28:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:28:46 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #9 from Jonathan Druart --- I was working on bug 14075 and bug 15809 at the same time (same issue). I am trying to find a global solution to fix them. The previous patch uses an unneeded var. To remove the warnings all around the code, it would be good to have the same pattern everywhere. That's why I have submitted another patch. To be sure everything is fine (even if I am sure it is), I was trying to understand how I could test there is no regression. I have asked Jesse to explain the goal of the auth_forwarded_hash and how it can be tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:33:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:33:07 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #10 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #9) > I was working on bug 14075 and bug 15809 at the same time (same issue). > I am trying to find a global solution to fix them. > The previous patch uses an unneeded var. To remove the warnings all around > the code, it would be good to have the same pattern everywhere. That's why I > have submitted another patch. > To be sure everything is fine (even if I am sure it is), I was trying to > understand how I could test there is no regression. > I have asked Jesse to explain the goal of the auth_forwarded_hash and how it > can be tested. THx for replying. I would recommend to restore the old patch and status now. No reason to block this. What happens with the auth_forwarded_hash could be considered as outside the scope of this small and effective solution. Please respect the work of the original submitter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:42:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:42:01 +0000 Subject: [Koha-bugs] [Bug 15746] A random library is used to record an individual payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15746 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:42:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:42:04 +0000 Subject: [Koha-bugs] [Bug 15746] A random library is used to record an individual payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15746 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47702|0 |1 is obsolete| | Attachment #47703|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 47974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47974&action=edit Bug 15746: Do not record individual payments with randomly picked libraries When a payment is made individualy, the library used to record this payment is randomly picked from the library list. This is because C4::Branch::GetBranch looks at 1. the $branch variable sent by the template, wich does not exist, then 2. the branchname cookie, which does not exist neither, then 3. get the first branchcode from a list of keys (non ordered). To reproduce: - Create a manual invoice for a patron (members/maninvoice.pl?borrowernumber=XXXX) - Pay this fine using the "Pay" button of the corresponding line from the members/pay.pl?borrowernumber=XXXX page Look at the statistics table: select * from statistics order by datetime desc limit 10; The branch value of the first line might not correspond to the library you were using to pay the payment. Test plan: Apply this patch, repeat the steps above and confirm that the library picked is now the one used to pay. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:42:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:42:11 +0000 Subject: [Koha-bugs] [Bug 15746] A random library is used to record an individual payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15746 --- Comment #6 from Kyle M Hall --- Created attachment 47975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47975&action=edit Bug 15746: Same fix for "write off" Same fix as before for the "Write off" button next to the "Pay" button. Signed-off-by: Hector Castro Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:52:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:52:56 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:52:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:52:58 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47867|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 47976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47976&action=edit Bug 15784 [Revised] Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert"
    . This patch modifies the confirmation markup to match the standard. Revised to include Font Awesome icons. Depends on Bug 15785. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:53:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:53:11 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15785 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 14:53:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 13:53:11 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15784 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 [Bug 15784] Library deletion warning is incorrectly styled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:14:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:14:11 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47976|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 47977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47977&action=edit Bug 15784 [Revised] Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert"
    . This patch modifies the confirmation markup to match the standard. Revised to include Font Awesome icons. Depends on Bug 15785. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Owen Leonard Buttons display as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:14:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:14:32 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:17:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:17:16 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #11 from M. Tompsett --- (In reply to Jonathan Druart from comment #9) > I was working on bug 14075 and bug 15809 at the same time (same issue). > I am trying to find a global solution to fix them. Oooo... bug 15809 looks promising. I'm okay with this simplified patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:22:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:22:44 +0000 Subject: [Koha-bugs] [Bug 15810] New: Can't create private lists if OpacAllowPublicListCreation is set to #not allow' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Bug ID: 15810 Summary: Can't create private lists if OpacAllowPublicListCreation is set to #not allow' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl If you try to create a private list from the OPAC and the OpacAllowPublicListCreation is set to 'not allow' public lists to be created by the patron, an error occurs: Koha::Schema::Result::Virtualshelve at /usr/share/koha/lib/Koha/Object.pm line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:23:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:23:06 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to #not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:25:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:25:06 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47941|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 47978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47978&action=edit Bug 15777 - Test to prove initialization isn't working correctly. TEST PLAN --------- 1) Apply this testing patch 2) prove -v t/RecordProcessor.t -- tests will fail. 3) run koha qa test tools Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:25:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:25:52 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47942|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 47979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47979&action=edit Bug 15777 - Fix base class to prove refactor and fix required TEST PLAN --------- 1) Apply the testing patch and this patch 2) prove -v t/RecordProcess.t -- will complain about string use with "use strict". This is because it is using the module name, instead of the object instantiated with new(). 3) run koha qa test tools. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:26:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:26:59 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47943|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 47980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47980&action=edit Bug 15777 - Refactor and fix the RecordProcessor class TEST PLAN --------- 1) Apply all three patches 2) prove -v t/RecordProcessor.t -- all should be successful 3) run koha qa test tools Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:27:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:27:57 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:34:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:34:36 +0000 Subject: [Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Status is still 'Needs Signoff' - should it be switched to SO? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:38:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:38:31 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to #not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:38:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:38:34 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to #not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 --- Comment #1 from Jonathan Druart --- Created attachment 47981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47981&action=edit Bug 15810: Make sure the CGI->param is not called in a list context when creating private shelves This patch fixes the following bug: If OpacAllowPublicListCreation is set to "not allow", the creation of a private list raises an error at the OPAC. CGI->param is called in a list context and some parameters are not filled from the template if the pref is set to "not allow". To make sure we don't have a "Odd number of elements in anonymous hash", we force the context to scalar. Test plan: 1/ Set OpacAllowPublicListCreation to "not allow" 2/ Create private and public lists at the OPAC and the intranet => Everything should work fine with this patch applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:40:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:40:24 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to #not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15809 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:40:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:40:24 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15810 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:42:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:42:53 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:42:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:42:56 +0000 Subject: [Koha-bugs] [Bug 15764] KOCT timestamp timezone problem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15764 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47861|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 47982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47982&action=edit Bug 15764: Fix timestamp sent by KOCT KOCT plugin send UTC timestamp, it should be converted to local timezone Test plan: 1. Install latest version of KOCT and configure it https://addons.mozilla.org/fr/firefox/addon/koct/ https://wiki.koha-community.org/wiki/Offline_circulation_firefox_plugin 2. Use it to do a checkout and a checkin. See that timestamps are UTC. 3. Click on "Commit to Koha" under "Log" tab 4. Wait for all operations to be processed 5. In Koha, go to Circulation > Offline circulation and check the timestamps were correctly converted to the Koha server's timezone 6. Process the pending operations and see that timestamps are still correct 7. Repeat step 2 8. Now click on "Apply directly" 9. Check the timestamps are correct in Koha NOTE: I could not get "Commit to Koha" to work for me, but I did confirm this corrected behaviour with "Apply directly". Signed-off-by: Mark Tompsett Signed-off-by: Owen Leonard Using the "commit to Koha" option works fine for me. Signed-off-by: Kyle M Hall This patch only affects service.pl, which is not used in any way by the uploader for desktop client files. No changes to the desktop offline circ will be needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:43:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:43:42 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #13 from Holger Mei?ner --- Mh. I studied the second PDF. But I still have to take a closer look at those blocking sysprefs. A quick question: Did you apply bug 14395 before testing? What was your setting for syspref NoRenewalBeforePrecision? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:45:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:45:52 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47971|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 47983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47983&action=edit Bug 15784: Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert"
    . This patch modifies the confirmation markup to match the standard. Revised to include Font Awesome icons. Depends on Bug 15785. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Owen Leonard Buttons display as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:49:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:49:59 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #14 from bondiurbano --- (In reply to Holger Mei?ner from comment #13) > Mh. I studied the second PDF. But I still have to take a closer look at > those blocking sysprefs. > > A quick question: Did you apply bug 14395 before testing? What was your > setting for syspref NoRenewalBeforePrecision? Hi Holger! I did not apply bug 14395 before testing. If you agree I can do that this weekend. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:50:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:50:03 +0000 Subject: [Koha-bugs] [Bug 13778] lists buttons ugly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:50:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:50:05 +0000 Subject: [Koha-bugs] [Bug 13778] lists buttons ugly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47883|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 47984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47984&action=edit Bug 13778: Putting patron lists buttons into a dropdown menu To test: 1) Go to Tools -> Patron lists 2) If there are no lists, confirm there is a message box saying 'There are no patron lists.' 3) Create a list if you do not already have one. 4) Confirm that in the 'Actions' drop down menu next to the list, the options to 'Add patrons', 'Edit', 'Delete', and 'Print patron cards' are all there and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:50:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:50:09 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to #not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:50:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:50:13 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to #not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47981|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 47985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47985&action=edit [SIGNED OFF] Bug 15810: Make sure the CGI->param is not called in a list context when creating private shelves This patch fixes the following bug: If OpacAllowPublicListCreation is set to "not allow", the creation of a private list raises an error at the OPAC. CGI->param is called in a list context and some parameters are not filled from the template if the pref is set to "not allow". To make sure we don't have a "Odd number of elements in anonymous hash", we force the context to scalar. Test plan: 1/ Set OpacAllowPublicListCreation to "not allow" 2/ Create private and public lists at the OPAC and the intranet => Everything should work fine with this patch applied Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:51:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:51:22 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 --- Comment #8 from H?ctor Eduardo Castro Avalos --- Hi someone attach a wrong bug number in this patch, please revert/obsolete the last patch attached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:53:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:53:02 +0000 Subject: [Koha-bugs] [Bug 15811] New: Redirect after adding a new list in OPAC broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15811 Bug ID: 15811 Summary: Redirect after adding a new list in OPAC broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When adding a new list in the OPAC you are not redirected to the list. This seems to be a regression between 3.22.2 and 3.22.3, maybe related to 4912. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:53:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:53:27 +0000 Subject: [Koha-bugs] [Bug 15811] Redirect after adding a new list in OPAC broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15811 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |4912 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4912 [Bug 4912] After editing private list, user should be redirect to private lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:53:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:53:27 +0000 Subject: [Koha-bugs] [Bug 4912] After editing private list, user should be redirect to private lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4912 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15811 [Bug 15811] Redirect after adding a new list in OPAC broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:59:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:59:42 +0000 Subject: [Koha-bugs] [Bug 15514] New professional cataloguing editor does not handle repeatable fields correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15514 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 15:59:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 14:59:44 +0000 Subject: [Koha-bugs] [Bug 15514] New professional cataloguing editor does not handle repeatable fields correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15514 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47377|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 47986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47986&action=edit Bug 15514: Fix error with certain repeatable fields in Rancor Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:09:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:09:44 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47983|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:09:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:09:51 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47971|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:11:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:11:06 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:11:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:11:09 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47977|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 47987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47987&action=edit Bug 15784: Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert"
    . This patch modifies the confirmation markup to match the standard. Revised to include Font Awesome icons. Depends on Bug 15785. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Owen Leonard Buttons display as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:11:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:11:25 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:11:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:11:29 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47987|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 47989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47989&action=edit Bug 15784: Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert"
    . This patch modifies the confirmation markup to match the standard. Revised to include Font Awesome icons. Depends on Bug 15785. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Owen Leonard Buttons display as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:11:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:11:28 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47978|0 |1 is obsolete| | Attachment #47979|0 |1 is obsolete| | Attachment #47980|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 47988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47988&action=edit Bug 15777 - Test to prove initialization isn't working correctly. TEST PLAN --------- 1) Apply this testing patch 2) prove -v t/RecordProcessor.t -- tests will fail. 3) run koha qa test tools Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:11:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:11:36 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 --- Comment #8 from Kyle M Hall --- Created attachment 47990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47990&action=edit Bug 15777 - Fix base class to prove refactor and fix required TEST PLAN --------- 1) Apply the testing patch and this patch 2) prove -v t/RecordProcess.t -- will complain about string use with "use strict". This is because it is using the module name, instead of the object instantiated with new(). 3) run koha qa test tools. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:11:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:11:38 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 --- Comment #9 from Kyle M Hall --- Created attachment 47991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47991&action=edit Bug 15777 - Refactor and fix the RecordProcessor class TEST PLAN --------- 1) Apply all three patches 2) prove -v t/RecordProcessor.t -- all should be successful 3) run koha qa test tools Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:11:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:11:56 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 --- Comment #9 from Jonathan Druart --- (In reply to H?ctor Eduardo Castro Avalos from comment #8) > Hi someone attach a wrong bug number in this patch, please revert/obsolete > the last patch attached Done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:16:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:16:29 +0000 Subject: [Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793 --- Comment #4 from Owen Leonard --- Created attachment 47992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47992&action=edit Bug 15793 - UX of circulation patron search with long lists of returned borrowers Using form controls to select a patron from the list of patron search results during checkout means that we have to have a submit button somewhere on a potentially very long form. This patch proposes that we use links to the patron records instead. This patch also makes a minor correction to the template to allow for the correct layout grid to be used, and enables the display of full library names in search results instead of branchcode. To test, apply the patch and search for a patron name from the "Check out" form in the header. Clicking the name of any patron in the search results should take you to the correct checkout page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:16:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:16:36 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #37 from M. Tompsett --- (In reply to Marc V?ron from comment #36) > Still valid? This patch is not the correct way to proceed. I'm working on a rewrite with filters now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:18:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:18:58 +0000 Subject: [Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793 --- Comment #5 from Owen Leonard --- Sorry, I don't mean to be a busybody and I certainly appreciate Aleisha's work to come up with a good solution for this. I just want to push it a little further and see if we can simplify even more. Is there a reason not to use a link here? The method of using form submission includes a lot of hidden fields, but are they used? There are other places in Koha where a checkout is initiated using a plain link, so my assumption is that those hidden fields aren't necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:19:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:19:59 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #84 from Kyle M Hall --- (In reply to Jonathan Druart from comment #83) > Since I won't be able to test the whole workflow, I would prefer to either > get a signoff on this new patchset or let another QAer continues with it. I will work on the unit tests and try to find someone to re-sign this patch set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:25:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:25:40 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #15 from Holger Mei?ner --- Hi bondiurbano, please take your time. Don't work on the weekend. When you do test again, please include when exactly the cronjob is scheduled, or if you run automatic_renewals.pl manually. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:25:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:25:40 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #74 from M. Tompsett --- Created attachment 47993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47993&action=edit Bug 11592 - Old Filtery stuff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:25:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:25:45 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to #not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:27:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:27:25 +0000 Subject: [Koha-bugs] [Bug 15811] Redirect after adding a new list in OPAC broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to #not allow' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:27:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:27:25 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to #not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15811 [Bug 15811] Redirect after adding a new list in OPAC broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:31:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:31:26 +0000 Subject: [Koha-bugs] [Bug 15811] Redirect after adding a new list in OPAC broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:31:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:31:29 +0000 Subject: [Koha-bugs] [Bug 15811] Redirect after adding a new list in OPAC broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15811 --- Comment #1 from Jonathan Druart --- Created attachment 47994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47994&action=edit Bug 15811: follow-up Bug 4912: Redirect to the appropriate view after editing/deleting a list Test plan: 1/ At the opac, go on the the list home page (opac-shelves.pl) 2/ Click on 'new list', create a list and save => You should be redirect to the list 3/ Click on edit, save => You should be redirect to the list 4/ Delete the list => You should be redirect to the list 5/ Edit a list from the list view, save => You should be redirect to the list 6/ Click on a list link (op=view) 7/ Edit the list, save => You should be redirect to the 'show' view 8/ Delete list => You should be redirect to the list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:31:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:31:34 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:31:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:31:38 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #85 from Kyle M Hall --- Created attachment 47995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47995&action=edit Bug 9021 [QA Followup] - Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:54:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:54:11 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15777 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:54:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:54:11 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 [Bug 11592] opac detail scripts do not respect MARC tag visibility -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:55:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:55:06 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35857|0 |1 is obsolete| | --- Comment #75 from M. Tompsett --- Created attachment 47996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47996&action=edit Bug 11592 - Updated License Text and use Modern::Perl Why not clean up the License Agreement stuff while the files are being changed? Used the current one found at: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence Changed the strict and warning lines into just a Modern::Perl. Signed-off-by: Robin Sheat Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:55:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:55:15 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47993|0 |1 is obsolete| | --- Comment #76 from M. Tompsett --- Created attachment 47997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47997&action=edit Bug 11592 - Old Filtery stuff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:57:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:57:33 +0000 Subject: [Koha-bugs] [Bug 13778] lists buttons ugly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47984|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 47998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47998&action=edit Bug 13778: Putting patron lists buttons into a dropdown menu To test: 1) Go to Tools -> Patron lists 2) If there are no lists, confirm there is a message box saying 'There are no patron lists.' 3) Create a list if you do not already have one. 4) Confirm that in the 'Actions' drop down menu next to the list, the options to 'Add patrons', 'Edit', 'Delete', and 'Print patron cards' are all there and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:57:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:57:37 +0000 Subject: [Koha-bugs] [Bug 13778] lists buttons ugly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778 --- Comment #8 from Jonathan Druart --- Created attachment 47999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47999&action=edit Bug 13778: Only the last column is not sortable Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 16:58:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 15:58:18 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47991|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 48000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48000&action=edit Bug 15777 - Refactor and fix the RecordProcessor class TEST PLAN --------- 1) Apply all three patches 2) prove -v t/RecordProcessor.t -- all should be successful 3) run koha qa test tools Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 17:00:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 16:00:41 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 --- Comment #11 from M. Tompsett --- Sorry... git bz attach gone awry. Nothing changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 17:02:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 16:02:03 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47996|0 |1 is obsolete| | --- Comment #77 from M. Tompsett --- Created attachment 48001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48001&action=edit Bug 11592 - Updated License Text and use Modern::Perl Why not clean up the License Agreement stuff while the files are being changed? Used the current one found at: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence Changed the strict and warning lines into just a Modern::Perl. Signed-off-by: Robin Sheat Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 17:11:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 16:11:53 +0000 Subject: [Koha-bugs] [Bug 15000] Adding patron card images with duplicate descriptions causes data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15000 --- Comment #7 from Chris Nighswonger --- Probably the best resolution is to warn the user about the potential overwrite and let the user decide at that point whether to cancel and rename or proceed and overwrite. Based on experience, it is very nice to be able to simply overwrite an image with a more recent one. However, some users may not anticipate that happening and so a warning needs to be in place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 17:20:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 16:20:25 +0000 Subject: [Koha-bugs] [Bug 15796] C4::Koha - get_itemtypeinfos_of is not used anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15796 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 17:20:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 16:20:28 +0000 Subject: [Koha-bugs] [Bug 15796] C4::Koha - get_itemtypeinfos_of is not used anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15796 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47959|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 48002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48002&action=edit Bug 15796: Remove C4::Koha::get_itemtypeinfos_of This subroutine is no longer in use. Test plan: git grep get_itemtypeinfos_of should not return any results. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Trivial and needed removal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 17:22:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 16:22:30 +0000 Subject: [Koha-bugs] [Bug 15812] New: Checkout search with too many results (single character search) causes poor performance or timeout Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Bug ID: 15812 Summary: Checkout search with too many results (single character search) causes poor performance or timeout Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On a system with many patrons a checkout search for a single character (2,X,J) can cause a slow search or timeout from the large number of results returned. Patron search has no problem with the same searches -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 17:22:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 16:22:41 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 17:27:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 16:27:38 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #86 from M. Tompsett --- Comment on attachment 47133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47133 Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Review of attachment 47133: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9021&attachment=47133) ----------------------------------------------------------------- ::: admin/sms_providers.pl @@ +41,5 @@ > + > +my $op = $cgi->param('op'); > +my $id = $cgi->param('id'); > +my $name = $cgi->param('name'); > +my $domain = $cgi->param('domain'); It might be an idea to add '// q{}' to the end of these. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 17:35:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 16:35:31 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #12 from Marcel de Rooy --- (In reply to M. Tompsett from comment #11) > (In reply to Jonathan Druart from comment #9) > > I was working on bug 14075 and bug 15809 at the same time (same issue). > > I am trying to find a global solution to fix them. > > Oooo... bug 15809 looks promising. > I'm okay with this simplified patch. That is fine. Well, Jonathan, go for it. Can we close this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 17:36:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 16:36:17 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 17:40:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 16:40:49 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #13 from M. Tompsett --- (In reply to Marcel de Rooy from comment #12) > That is fine. Well, Jonathan, go for it. Can we close this one? I don't think so, because this doesn't use the 15809 patch. If it did, then it would be multi_param. :) Either way, I'm cool with this (without 15809) or a multi-param version dependent on 15809. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 17:57:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 16:57:36 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com --- Comment #69 from Benjamin Daeuber --- We ran this through the sandbox and adjusted the test plan as follows: a. We should probably update the test plan to make sure we?re all in the same place: 1. Patron class needs at least the same number of holds allowed as you are going to allow per record 2. Item level holds need to be enabled on the item type b. Another note -- and this would vary by library ? we adjusted the default for holds on available items from ?waiting? to ?on hold? so they were not active until they were checked in That said, here?s what we noted: 1. If you start in the staff interface a patron can place holds on more than 3 items on a bib record, regardless of circ rules. But the behavior is kind of strange. If holds are placed from the staff interface, it lets us place 4 holds. When a patron places holds from the OPAC it stops at 3, and then prevents staff from placing additional holds in the staff interface. 2. Selecting an option from the drop down while ?next available? is checked places multiple holds on the selected item. 3. Related, the dropdown could cause policy enforcement issues for some libraries. Say we allow users to put 10 items per record on hold (a realistic number if you consider periodicals records that may have hundreds of items) and a user selects it. If there is only 1 item, a patron could place it on hold 10 times and keep checking it out, bypassing renewal restrictions. Some comments on the user experience 1. When you look at the holds queue, it?s not quite as expected. Say that a Patron A puts 3 items on a bib record on hold, then Patron B comes along and places 2 of the same items on that bib record on hold. Patron B will show up 4th and 5th in the hold queue, despite being 2nd for two different items. 2. I?m not sure that the drop down is necessary. If a customer wants to place holds, the natural desire would be to either have checkboxes for each individual item and a single hold button or individual hold buttons for each item that would trigger a javascript confirmation rather than a second screen 3. Related, the user has to go back into the record for each item they want to place on hold. This is cumbersome. 4. The actual workflow works more or less as expected. One issue would be when checking out a second item on a bib record to a patron, there is a box that asks to confirm checkout. I think we should have the option to suppress this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 17:58:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 16:58:46 +0000 Subject: [Koha-bugs] [Bug 15811] Redirect after adding a new list in OPAC broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15811 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 17:58:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 16:58:48 +0000 Subject: [Koha-bugs] [Bug 15811] Redirect after adding a new list in OPAC broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15811 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47994|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 48003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48003&action=edit [SIGNED-OFF]Bug 15811: follow-up Bug 4912: Redirect to the appropriate view after editing/deleting a list Test plan: 1/ At the opac, go on the the list home page (opac-shelves.pl) 2/ Click on 'new list', create a list and save => You should be redirect to the list 3/ Click on edit, save => You should be redirect to the list 4/ Delete the list => You should be redirect to the list 5/ Edit a list from the list view, save => You should be redirect to the list 6/ Click on a list link (op=view) 7/ Edit the list, save => You should be redirect to the 'show' view 8/ Delete list => You should be redirect to the list Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 17:59:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 16:59:03 +0000 Subject: [Koha-bugs] [Bug 15811] Redirect after adding a new list in OPAC broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15811 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 18:01:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 17:01:25 +0000 Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 18:02:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 17:02:58 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 --- Comment #5 from Heather Braum --- Jonathan, I guess if bug 14821 has been in 3.20 and 3.22 for awhile, the default behavior would need to be the current behavior of the software, which is not showing this list. That's the common practice, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 18:19:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 17:19:59 +0000 Subject: [Koha-bugs] [Bug 15546] Software Error for all access to Label Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15546 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjr at software.coop Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from MJ Ray (software.coop) --- The co-op fixed this. To summarise: The log file included "Table 'koha_library.creator_layouts' doesn't exist" It seems that labels_upgrade.pl did not run successfully during an upgrade back in the mists of time and updatedatabase.pl does not check its exit status. As a consequence, patroncards_upgrade.pl did not run successfully either. The database structure has been fixed by reading those and kohastructure.sql and now the label creator does not produce this error. I will mark this as FIXED and leave it up to others to decide whether it's a bug that updatedatabase.pl doesn't check the exit status of extra upgrade scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 18:42:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 17:42:25 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #14 from Jesse Weaver --- (In reply to Jonathan Druart from comment #4) > Jesse, could you explain what you are doing with document.location.hash? > > I do not understand the following line in includes/cateditor-ui.inc: > > 1094 if ( "[% auth_forwarded_hash %]" ) { > 1095 document.location.hash = "[% auth_forwarded_hash %]"; > 1096 } > > Should not be: > > 1094 [% IF auth_forwarded_hash %] > 1095 document.location.hash = "[% auth_forwarded_hash %]"; > 1096 [% END %] > > instead? I don't quite remember why I did it that way. Your proposed change should be fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 18:47:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 17:47:11 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #15 from Jesse Weaver --- (In reply to Jesse Weaver from comment #14) > (In reply to Jonathan Druart from comment #4) > > Jesse, could you explain what you are doing with document.location.hash? > > > > I do not understand the following line in includes/cateditor-ui.inc: > > > > 1094 if ( "[% auth_forwarded_hash %]" ) { > > 1095 document.location.hash = "[% auth_forwarded_hash %]"; > > 1096 } > > > > Should not be: > > > > 1094 [% IF auth_forwarded_hash %] > > 1095 document.location.hash = "[% auth_forwarded_hash %]"; > > 1096 [% END %] > > > > instead? > > I don't quite remember why I did it that way. Your proposed change should be > fine. And to clarify; this is to make sure that the hash in .../editor.pl#catalog/647 is passed through when you have to log in again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 18:54:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 17:54:56 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 19:50:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 18:50:33 +0000 Subject: [Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15632 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 [Bug 15632] Move the messages related code to Koha::Patron::Messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 19:50:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 18:50:33 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15446 CC| |kyle at bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 19:54:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 18:54:23 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 19:54:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 18:54:28 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47580|0 |1 is obsolete| | Attachment #47581|0 |1 is obsolete| | Attachment #47582|0 |1 is obsolete| | Attachment #47583|0 |1 is obsolete| | Attachment #47584|0 |1 is obsolete| | Attachment #47585|0 |1 is obsolete| | Attachment #47586|0 |1 is obsolete| | Attachment #47587|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall --- Created attachment 48004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48004&action=edit Bug 15632: Koha::Patron::Messages - Add new classes The following 4 CRUD subroutines in C4::Members: - AddMessage - DeleteMessage - GetMessagesCount - GetMessages could be replaced with a new package based on Koha::Objets. This patchset will add the 2 Koha::Patron::Message[s] classes, then use it to replace the different calls to these subroutine. It will slightly reduce the size of C4::Members Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 19:59:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 18:59:19 +0000 Subject: [Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46424|0 |1 is obsolete| | Attachment #46425|0 |1 is obsolete| | Attachment #46426|0 |1 is obsolete| | Attachment #46427|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Created attachment 48005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48005&action=edit Bug 15446: Add tests Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 19:59:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 18:59:40 +0000 Subject: [Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 --- Comment #20 from Kyle M Hall --- Created attachment 48006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48006&action=edit Bug 15446: Rename Koha::Object[s]->type with _type In a few case (at least systempreferences and export_format (csv profiles), the type method of Koha::Object and Koha::Objects can be in conflict with the column names. Indeed systempreferences.type exists and so the method will return 'Systempreference' (the name of the module) instead of the value of the row in DB. I have found at least 1 place where it can cause issue: In C4::Context->set_preference: 601 my $syspref = Koha::Config::SysPrefs->find( $var ); 602 my $type = $syspref ? $syspref->type() : undef; 603 604 $value = 0 if ( $type && $type eq 'YesNo' && $value eq '' ); type will always be 'Systempreference' and the YesNo pref will be set to an empty string '' instead of 0. I am not sure about the consequences of this, but it is preferable to fix it ASAP. To reproduce: 0/ Do not apply this patch 1/ Edit a YesNo prefs, AutoEmailOpacUser for instance 2/ Set it to "Don't sent" 3/ Check the value in DB, it should be set to an empty string, instead of 0 4/ Apply this patch and try again. Now the value should be 0 Followed test plan, value is now 0 as expected. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 19:59:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 18:59:46 +0000 Subject: [Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 --- Comment #21 from Kyle M Hall --- Created attachment 48007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48007&action=edit Bug 15446: Update systempreferences rows where type=YesNo and value='' Signed-off-by: Marc V?ron Amended to fix typo in sql statement. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 19:59:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 18:59:52 +0000 Subject: [Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 --- Comment #22 from Kyle M Hall --- Created attachment 48008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48008&action=edit Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type Some occurrences have been pushed in the meantime. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:05:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:05:10 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48004|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall --- Created attachment 48009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48009&action=edit Bug 15632: Koha::Patron::Messages - Add new classes The following 4 CRUD subroutines in C4::Members: - AddMessage - DeleteMessage - GetMessagesCount - GetMessages could be replaced with a new package based on Koha::Objets. This patchset will add the 2 Koha::Patron::Message[s] classes, then use it to replace the different calls to these subroutine. It will slightly reduce the size of C4::Members Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:05:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:05:17 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #30 from Kyle M Hall --- Created attachment 48010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48010&action=edit Bug 15632: Koha::Patron::Messages - Be sure add and delete will log If the pref BorrowersLog is on, the store and delete method should log into the action_logs table. Easy to do by overloading them. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:05:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:05:19 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #31 from Kyle M Hall --- Created attachment 48011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48011&action=edit Bug 15632: Koha::Patron::Messages - Remove AddMessage The AddMessage subroutine just 1. checked if all the parameters were passed 2. inserted the message in the DB 3. logged the action if needed These 3 jobs are now done by the overloaded store method of Koha::Patron::Message. Test plan: 1/ Go on the "check out" page of a patron 2/ Add different new messages Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:05:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:05:22 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #32 from Kyle M Hall --- Created attachment 48012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48012&action=edit Bug 15632: Koha::Patron::Messages - Remove DeleteMessage The DeleteMessage just deleted and logged if needed. This is now be done by Koha::Patron::Message->delete. Test plan: 1/ Go on the "check out" page of a patron 2/ Delete some messages Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:05:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:05:24 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #33 from Kyle M Hall --- Created attachment 48013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48013&action=edit Bug 15632: Koha::Patron::Messages - Remove GetMessagesCount The GetMessageCount subroutine was only used once, in opac-user.pl, to know if some messages will be displayed. Test plan: 1/ Create messages to display at the OPAC for a patron 2/ Logged this patron in at the OPAC, you should see the messages displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:05:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:05:27 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #34 from Kyle M Hall --- Created attachment 48014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48014&action=edit Bug 15632: Koha::Patron::Messages - Remove GetMessages This subroutine just retrieved the messages given some parameters. Some job should not have been done in this subroutine. It was called only 3 times, in circ/circulation.pl and opac-user.pl. Basically it was used to retrieved the message to displaye for a given patron ($borrowernumber) at the OPAC (B) or Staff (L). For the 3 calls, the 2 parameters $borrowernumber and $type (message_type) were passed, the "%" trick at the beginning of the subroutine was useless. Moreover, the date formatting should be done on the TT side, not in subroutine. The can_delete flag was set if the branchcode given in parameter was the same as the one of the message. This has been delegated to the template. Indeed the can_delete was not valid, since it must depend on the AllowAllMessageDeletion pref. The test is now: IF message.branchcode == branch OR Koha.Preference('AllowAllMessageDeletion'') There is not specific test plan for this patch, the changes have already been tested in previous patches. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:05:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:05:30 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #35 from Kyle M Hall --- Created attachment 48015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48015&action=edit Bug 15632: Koha::Patron::Messages - Remove tests The messages related tests in t/db_dependent/Members.t are not deprecated and can be removed. Test plan: git grep AddMessage git grep DeleteMessage git grep GetMessagesCount git grep GetMessages should not return any result. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:05:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:05:35 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #37 from Kyle M Hall --- Created attachment 48017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48017&action=edit Bug 15632 [QA Followup] - Get rid of use of uninitialized value errors for unit tests * Set $user to "" if not passed * Tidy sub -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:05:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:05:32 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #36 from Kyle M Hall --- Created attachment 48016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48016&action=edit Bug 15632: Koha::Patron::Messages - (follow-up) Remove AddMessage Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:05:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:05:37 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #38 from Kyle M Hall --- Created attachment 48018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48018&action=edit Bug 15632 [QA Followup] - Undo changes needed for Bug 13618 which was reverted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:10:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:10:34 +0000 Subject: [Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 --- Comment #23 from Kyle M Hall --- Created attachment 48019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48019&action=edit Bug 15446 [QA Followup] - Update new classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:14:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:14:02 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #39 from Kyle M Hall --- Created attachment 48020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48020&action=edit Bug 15632 [QA Followup] - Change method type to _type for bug 15446 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:29:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:29:17 +0000 Subject: [Koha-bugs] [Bug 15783] C4::Koha::AddAuthorisedValue can be replaced with Koha::AuthorisedValue->new->store In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:29:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:29:19 +0000 Subject: [Koha-bugs] [Bug 15783] C4::Koha::AddAuthorisedValue can be replaced with Koha::AuthorisedValue->new->store In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47889|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 48021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48021&action=edit Bug 15783: AddAuthorisedValue - Replace existing calls The C4::Koha::AddAuthorisedValue is only called twice from reports/guided_reports.pl and insert an authorised value. This job can be achieve easily using the Koha::AuthorisedValue module. Test plan: 1/ Create a new guided report 2/ Use an existing group and/or subgroup of reports 3/ Save 4/ Update an existing report 5/ Use an existing group and/or subgroup of reports 6/ Save 7/ Create or update an existing report 8/ Remove its assigned group and subgroup 9/ Save Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:29:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:29:45 +0000 Subject: [Koha-bugs] [Bug 15783] C4::Koha::AddAuthorisedValue can be replaced with Koha::AuthorisedValue->new->store In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15783 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47890|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 48022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48022&action=edit Bug 15783: AddAuthorisedValue - Remove the subroutine Test plan: prove t/db_dependent/Koha.t should return green git grep AddAuthorisedValue should not return any results Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:33:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:33:52 +0000 Subject: [Koha-bugs] [Bug 15800] Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:33:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:33:54 +0000 Subject: [Koha-bugs] [Bug 15800] Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47926|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 48023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48023&action=edit Bug 15800: Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory C4::Koha::IsAuthorisedValueCategory contains only 2 useful calls, from C4::Reports::Guided and reports/guided_reports.pl It can be replaced with Koha::AuthorisedValues->search({ category => $authorised_value})->count Test plan: 1/ Create a sql report using an authorised value category, something like: SELECT COUNT(*) FROM items where itemlost=<> 2/ Execute the report and confirm that everything works fine. 3/ Create a sql report using a nonexistent authorised value categor, something like: SELECT COUNT(*) FROM items where itemlost=<> 4/ When saving the report, you should get a warning message "lost: The authorized value category (NONEXIST) you selected does not exist." 5/ Save anyway and execute the report, you should get the same warning message. QA: git grep IsAuthorisedValueCategory should not return any results prove t/db_dependent/ReportsGuided.t should return green Signed-off-by: Hector Castro Works as described Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 20:51:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 19:51:21 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #87 from Kyle M Hall --- Created attachment 48024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48024&action=edit Bug 9021 [QA Followup] - Add additional message to deletion warning if provider is in use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:03:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:03:43 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #88 from M. Tompsett --- Multi-commit bugs are a pain to get through. Thanks for the effort, Kyle. Applies cleanly. Affected test files run. Pretty color use. :) A nice simple elegance to the SMS Provider list. Thanks for the follow up about the additional message. I'll let QA argue over the exact wording. This works well! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:05:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:05:34 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47133|0 |1 is obsolete| | --- Comment #89 from M. Tompsett --- Created attachment 48025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48025&action=edit [SIGNED-OFF] Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber at provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber at messaging.sprintpcs.com Verizon phonenumber at vtext.com T-Mobile phonenumber at tmomail.net AT&T phonenumber at txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. NOTE: Rechecked. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:06:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:06:00 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47338|0 |1 is obsolete| | --- Comment #90 from M. Tompsett --- Created attachment 48026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48026&action=edit [SIGNED-OFF] Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall NOTE: Rechecked. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:06:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:06:22 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47339|0 |1 is obsolete| | --- Comment #91 from M. Tompsett --- Created attachment 48027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48027&action=edit [SIGNED-OFF] Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall NOTE: Rechecked Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:06:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:06:52 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47814|0 |1 is obsolete| | --- Comment #92 from M. Tompsett --- Created attachment 48028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48028&action=edit [SIGNED-OFF] Bug 9021 [QA Followup] - Use TT plugin instead of passing syspref via script NOTE: Rechecked. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:07:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:07:09 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47815|0 |1 is obsolete| | --- Comment #93 from M. Tompsett --- Created attachment 48029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48029&action=edit [SIGNED-OFF] Bug 9021 [QA Followup] - Use Modern::Perl NOTE: Rechecked Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:07:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:07:27 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47816|0 |1 is obsolete| | --- Comment #94 from M. Tompsett --- Created attachment 48030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48030&action=edit [SIGNED-OFF] Bug 9021 [QA Followup] - Fix ENGINE, don't create index on FK NOTE: Rechecked. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:07:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:07:48 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47817|0 |1 is obsolete| | --- Comment #95 from M. Tompsett --- Created attachment 48031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48031&action=edit [SIGNED-OFF] Bug 9021 [QA Followup] - Use same color as circ rules editor for row highlighting NOTE: Rechecked. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:08:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:08:05 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47845|0 |1 is obsolete| | --- Comment #96 from M. Tompsett --- Created attachment 48032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48032&action=edit [SIGNED-OFF] Bug 9021 [QA Followup] - Switch to Koha::Object(s) NOTE: Rechecked. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:08:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:08:30 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47847|0 |1 is obsolete| | --- Comment #97 from M. Tompsett --- Created attachment 48033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48033&action=edit [SIGNED-OFF] Bug 9021 [QA Followup] - Add feedback to delete button if provider is being used * Change links to buttons * Add warning class to delete button if provider is being used NOTE: Rechecked. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:08:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:08:53 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47848|0 |1 is obsolete| | --- Comment #98 from M. Tompsett --- Created attachment 48034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48034&action=edit [SIGNED-OFF] Bug 9021 [QA Followup] - Add column to deleted borrowers, set null on provider deletion NOTE: Rechecked. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:09:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:09:09 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47995|0 |1 is obsolete| | --- Comment #99 from M. Tompsett --- Created attachment 48035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48035&action=edit [SIGNED-OFF] Bug 9021 [QA Followup] - Unit tests NOTE: Rechecked. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:09:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:09:25 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48024|0 |1 is obsolete| | --- Comment #100 from M. Tompsett --- Created attachment 48036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48036&action=edit [SIGNED-OFF] Bug 9021 [QA Followup] - Add additional message to deletion warning if provider is in use. NOTE: Rechecked. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:09:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:09:59 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:29:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:29:10 +0000 Subject: [Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 --- Comment #3 from M. Tompsett --- Comment on attachment 47676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47676 Bug 15745 - C4::Matcher gets CCL parsing error if term contains ? (question mark) Review of attachment 47676: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15745&attachment=47676) ----------------------------------------------------------------- ::: C4/Matcher.pm @@ +658,5 @@ > else { > my $phr = C4::Context->preference('AggressiveMatchOnISBN') ? ',phr' : q{}; > $query = join( " or ", > + map { "$matchpoint->{'index'}$phr=\"$_\"" } @source_keys ); > + #NOTE: double-quote the values so you don't get a "Embedded truncation not supported" error when a term has a ? in it. What about the test case where you want to search for double quotes? Escaping is needed. Perhaps there is another way? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:48:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:48:12 +0000 Subject: [Koha-bugs] [Bug 12549] Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 21:48:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 20:48:16 +0000 Subject: [Koha-bugs] [Bug 12549] Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45897|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 48037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48037&action=edit [SIGNED-OFF] Bug 12549 - Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems Allows for selection of DejaVu font path when installing from the command line. This is useful for non-debian distributions that don't store the fonts in the same place. Adds a new configuration variable to Makefile.PL: FONT_DIR Defaults to the Debian install location for the fonts. Test plan: 1. Run a CLI install, accepting the defaults. 2. Compare the generated koha-conf.xml to a previous install - the font path for DejaVu fonts should be the same. 3. Run another CLI install, this time choosing a custom path for the fonts 4. Check that the path selected is reflected in the koha-conf.xml file. NOTE: 'perl Makefile.pl' and 'make' generates blib/KOHA_CONF_DIR/koha-conf.xml ran with a weird string for the font dir copied that koha-conf.xml to my home dir reran with all defaults compared the two, and only the font paths differed. Also, I cleaned up the tabs that snuck in. :) Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 23:15:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 22:15:01 +0000 Subject: [Koha-bugs] [Bug 15646] koha qa test tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15646 --- Comment #3 from M. Tompsett --- (In reply to Jonathan Druart from comment #2) > Well, it seems that we are not ready at all for level 1... No, but checking the return value for the print function is something I added, because my perlcritic rc file is softlinked to this one, and I sometimes aim to write my code for level 1. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 23:31:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 22:31:55 +0000 Subject: [Koha-bugs] [Bug 15813] New: Fix list-context call to ...->guarantor in opac-memberentry.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15813 Bug ID: 15813 Summary: Fix list-context call to ...->guarantor in opac-memberentry.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Blocks: 14658 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 23:31:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 22:31:55 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15813 [Bug 15813] Fix list-context call to ...->guarantor in opac-memberentry.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 23:35:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 22:35:24 +0000 Subject: [Koha-bugs] [Bug 15813] Fix list-context call to ...->guarantor in opac-memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15813 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 12 23:35:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 22:35:26 +0000 Subject: [Koha-bugs] [Bug 15813] Fix list-context call to ...->guarantor in opac-memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15813 --- Comment #1 from Jesse Weaver --- Created attachment 48038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48038&action=edit Bug 15813: Fix list-context call to ...->guarantor in opac-memberentry.pl (was: Bug 14658: (followup) fix issue with list context on DBIC call) While working on bug 14659, it was discovered that the call to ...->guarantor in list context will cause the hash to be misaligned if there is no guarantor. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 00:04:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 23:04:21 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #21 from Jesse Weaver --- I think that's reasonable, depending on what you have in mind testing-wise. Full round-trip testing of Z39.50 could be difficult, but unit tests for the item-status-adding would be quite doable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 00:05:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 23:05:49 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #8 from Jesse Weaver --- Could I ask you to check your error log after editing/saving? And, since I neglected to mention it in the test plan, did you run updatedatabase.pl? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 00:13:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 23:13:45 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #7 from M. Tompsett --- (In reply to Marcel de Rooy from comment #6) > (In reply to M. Tompsett from comment #5) > > I think this should be none,fatal,warn. > > But I explicitly did not put that default in the commented line; that would > not change anything. In its current state, yes. > As the comment mentions, you need to uncomment it to > get different(!) log levels. We may assume that someone editing koha-conf > knowns that changing config files has side effects :) There is the possibility that they may think fatal,warn is the default to change. Worse yet, they may not be aware of none. How about something like: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 00:48:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 23:48:34 +0000 Subject: [Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jweaver at bywatersolutions.co | |m --- Comment #24 from Jesse Weaver --- Pushed to master, thanks for your work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 00:54:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Feb 2016 23:54:53 +0000 Subject: [Koha-bugs] [Bug 15411] "Non fiction" is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jweaver at bywatersolutions.co | |m --- Comment #12 from Jesse Weaver --- Pushed to master, thanks for your work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 05:26:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Feb 2016 04:26:55 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 --- Comment #10 from M. Tompsett --- I am attempting to test this. Had my first failure, but I've got other ideas to try first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 10:15:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Feb 2016 09:15:59 +0000 Subject: [Koha-bugs] [Bug 15765] Request to replace borrowernumber list by cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15765 --- Comment #6 from Heinrich Hartl --- Thank you Chris for your comments, they made me look at my proposal again. I did some testing: I tried to enter an invalid borrowernumber. It was silently ignored when pushing the ADD button. Since something I normally would like to be achieved failed, I would prefer to get a warning message. After the batch was set up I deleted a patron (both with tool batch deletion and also with patro/more/delete). In both cases the patron was also removed from the batch list. +++ The required input validation is in place :-) I scanned through the patron reports. There I found an almost balanced result: cardnumber is used only slightly more frequently than borrower number. It seem to be a personal preference, finding myself clearly on the cardnumber side. To accomodate both preferences I agree with Katrin: why not have both in the table. Please have a look at patroncards/add_user_search.pl table: Card / Name / Category / Library / Expires / Notes / Add where Card holds cardnumber (which barcode string), Name holds surname, firstname(cardnumber), ... and compare it with patroncards/edit-batch.pl table: Borrower Name / Borrower number / Action / Select Where Borrower Name again is surname, firstname and Action is Delete | Export add_user_search displays barcodes string twice. add_user_search panal could be improved by more clearly indicating which fields are searched for the entered search string. I would like very much if a select column together with "select all" and "add selected" buttons were added! If the contents of the add_user_search table are judged satisfactory why not display consistent and rich information when displaying edit-batch.pl table? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 11:41:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Feb 2016 10:41:20 +0000 Subject: [Koha-bugs] [Bug 15814] New: Templates for MARC modification: Edit action does not work. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814 Bug ID: 15814 Summary: Templates for MARC modification: Edit action does not work. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org There is an edit button in the tool for MARC template modification for every action of a template. Expected: click edit for an action, get a form populated with the related values. Actual result: page is scrolled to "Add new action", fields are empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 11:41:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Feb 2016 10:41:38 +0000 Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit action does not work. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 11:43:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Feb 2016 10:43:08 +0000 Subject: [Koha-bugs] [Bug 4888] pre-set of field indicators value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888 --- Comment #30 from Mirko Tietgen --- (In reply to Marjorie Barry-Vila from comment #29) > Hi, > > Do you always work on this patch? > > Regards, > Marjorie I'm not working on this. AFAIR the patch (written by somebody else) did not do what I was hoping for. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 12:00:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Feb 2016 11:00:16 +0000 Subject: [Koha-bugs] [Bug 15814] Templates for MARC modification: Edit action does not work when Description contains ' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Templates for MARC |Templates for MARC |modification: Edit action |modification: Edit action |does not work. |does not work when | |Description contains ' --- Comment #1 from Mirko Tietgen --- It does work, unless you have ' in the description, which leads to > SyntaxError: unterminated string literal in Firebug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 12:33:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Feb 2016 11:33:41 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 12:33:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Feb 2016 11:33:43 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46463|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 48039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48039&action=edit Bug 15534 - Add the ability to prevent a patron from placing a hold on a record with available items Some libraries would like to prevent patrons from placing holds on items where there are other items available for the patron to check out. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Browse to the circulation rules 4) Note the new option for "On shelf holds allowed" 5) Set the rule to "If all unavailable", set "item level holds" to allow 6) Find a patron/branch/itemtype applicable to this rule 7) Ensure at least one item on the record is available for the patron to check out 8) Attempt to place a hold for the item 9) Note you cannot place the hold 10) Check the available item out to another patron 11) Note you can now place a hold for the first patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 13:25:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Feb 2016 12:25:57 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #16 from bondiurbano --- (In reply to Holger Mei?ner from comment #15) > Hi bondiurbano, please take your time. Don't work on the weekend. > > When you do test again, please include when exactly the cronjob is > scheduled, or if you run automatic_renewals.pl manually. The test was done in a production environment, in a "demo" installation of my own. Crons run daily at 4:00am. I will follow your suggestion and will not work on this weekend. But yerterday I've done a quick test on a local virtual machine, applying bug 14395 and the results were the same: UNDEF and ZERO settings didn't work. A last comment: pay attention that according to my test, UNDEF and ZERO settings do not work neither in a MANUAL schema, not only for automatic renewals. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 13:39:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Feb 2016 12:39:22 +0000 Subject: [Koha-bugs] [Bug 15815] New: improve wording in popup warning when deleting patron from patron-batch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815 Bug ID: 15815 Summary: improve wording in popup warning when deleting patron from patron-batch Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: Heinrich.Hartl at email.de QA Contact: testopia at bugs.koha-community.org Deleting a Patron from a batch the following popup may hold the following text: "Are you sure you want to remove card number(s):1 from this batch?" In the example above however a Patron was chosen for deletion with borrowernumber 2, cardnumber "BB1" which aktuall occupied position 1 in the batch list! Index position (here 1) should not be termed card number. To avoid the incorrect naming the message could be changed.. However I'd prefer to skip this message altogether ? do it the unix way: No comment on regular operation! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 17:28:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Feb 2016 16:28:21 +0000 Subject: [Koha-bugs] [Bug 15816] New: Timeout login redirects to home page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816 Bug ID: 15816 Summary: Timeout login redirects to home page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P3 Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: library at stas.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com On the staff client, when the session times out, or the user is asked to login again, the login always redirects to the home page. Formerly (as of 3.18.6 from which we upgraded to 3.22.1), it would redirect back to the page requested. --------- Example of former behavior: Login has timed out. User clicks link for a new biblio record from z39.50 (Cataloging). Pop-up search window opens, but asks for a login. Once logged in the z39.50 search form is shown. Example of present behavior: Login has timed out. User clicks link for a new biblio record from z39.50 (Cataloging). Pop-up search window opens, but asks for a login. Once logged in the staff home page is shown in the pop-up window. Behavior is the same for other pages as well. It seems the requested page (which appears in the address bar) is not passed to the login form (which is in mainpage.pl) and instead mainpage.pl is shown. Not a deal breaker, but annoying to have to login from scratch (or in another window) to a continue working on a record you were working on yesterday, or continue a session. I suspect Bug 15005. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 17:32:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Feb 2016 16:32:10 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #50 from Ian Palko --- To clarify (Sorry): Will this be pushed to 3.22, or just the Master? It would be nice to have the fix before 3.24 comes out for those of us with lots of authorities to clean up. If it hasn't been pushed to 3.22, would it be possible to test and push to that branch? Many thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 13 23:15:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Feb 2016 22:15:48 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- It looks like we need a sign-off on the patches on 15578 in order to get this into 3.22. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 20:20:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 19:20:11 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #9 from Aleisha Amohia --- Created attachment 48040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48040&action=edit [SIGNED-OFF] Bug 13757 - Make patron attributes editable in the OPAC (2/2) This patch makes attributes marked as OPAC-editable editable from the OPAC. NOTE: This needs to be extended to work with the modifications system, and thus only works for new patrons. Test plan: 1) Create attributes that cover the spectrum of possible attribute types; repeatable, unique, dropdown, etc. 2) Verify that all of these attributes are correctly validated and saved. Aleisha's update: Fixed a merge conflict and a warn "Argument "" isn't numeric in numeric gt (>) at /usr/share/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt line 336." Signed-off-by: Aleisha Sorry forgot to run updatedatabase.pl! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 21:00:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 20:00:38 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 21:00:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 20:00:42 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47625|0 |1 is obsolete| | Attachment #48040|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia --- Created attachment 48041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48041&action=edit [SIGNED-OFF] Bug 13757 - Make patron attributes editable in the OPAC (1/2) This patch adds an opac_editable property of borrower attribute types that can be set in the interface. Test plan: 1. Repeat the following with a new and existing borrower attribute type: 2. Verify that "Editable in OPAC" can only be checked if "Display in OPAC" is checked. 3. Verify that this new property is correctly saved. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 21:01:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 20:01:23 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48041|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia --- Created attachment 48042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48042&action=edit [SIGNED-OFF] Bug 13757 - Make patron attributes editable in the OPAC (1/2) This patch adds an opac_editable property of borrower attribute types that can be set in the interface. Test plan: 1. Repeat the following with a new and existing borrower attribute type: 2. Verify that "Editable in OPAC" can only be checked if "Display in OPAC" is checked. 3. Verify that this new property is correctly saved. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 21:01:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 20:01:32 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42626|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia --- Created attachment 48043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48043&action=edit [SIGNED-OFF] Bug 13757 - (followup) fix creation of patron attributes Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 21:02:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 20:02:11 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48040|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 21:02:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 20:02:40 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42254|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 21:02:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 20:02:58 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #13 from Aleisha Amohia --- Ah sorry for all the comments git kept timing out, but I am signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 21:12:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 20:12:05 +0000 Subject: [Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793 --- Comment #6 from Aleisha Amohia --- We did think about having every name as a link and just thought a floating toolbar could be cool! Up to whoever signs off and QAs to see which they like best since either works :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 21:14:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 20:14:29 +0000 Subject: [Koha-bugs] [Bug 15775] User should know when they are blocked from checkouts on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #7 from Aleisha Amohia --- (In reply to Marc V?ron from comment #6) > Hi Aleisha, > > I gave up Bug 15374 because it would have conflicts on top of this Bug. It > certainly will make it easier to go on with such enhancements. > > Plese feel free to re-use code from 15374 on top of your patch, if > applicable. Hi, thanks Marc! I think I actually wrote the patch for this on top of your patch from 15374 anyway so we kind of wrote this patch together :) I will recommit this patch with the commit message from 15374 and edit the bug report since we are now testing for all that translatability stuff too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 21:16:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 20:16:12 +0000 Subject: [Koha-bugs] [Bug 15775] User should know when they are blocked from checkouts on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 --- Comment #8 from Aleisha Amohia --- Created attachment 48044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48044&action=edit Bug 15775 - User should know when they are blocked from checkouts on OPAC + Translatability fixes for OPAC Summary page When a user has been blocked from checkouts in the staff client for having too many fines, they will now see a message about this in the OPAC To test: - This patch will be easiest to test if you keep three tabs open - system preferences, a patron detail page, and OPAC summary page - Set some system preferences: - OPACFineNoRenewals = 2 - noissuescharge = 4 - OpacRenewalAllowed = Allow - Set up a patron with fines of $3 - Log in to the OPAC and verify the message from patch from Bug 15374, saying the user cannot renew books. Confirm link to accounts page works. - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm the message disappears - Set OpacRenewalAllowed = Allow - Give the patron total fines of $5 (add $2) - Refresh OPAC Summary and verify message appears saying user is BLOCKED from checkouts. Confirm link to accounts page works - Set OpacRenewalAllowed = Don't allow - Refresh OPAC Summary and confirm message is still there Translability tests: - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 21:16:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 20:16:31 +0000 Subject: [Koha-bugs] [Bug 15775] User should know when they are blocked from checkouts on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47937|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 21:16:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 20:16:51 +0000 Subject: [Koha-bugs] [Bug 15775] User should know when they are blocked from checkouts on OPAC + Translatability fixes for OPAC Summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|User should know when they |User should know when they |are blocked from checkouts |are blocked from checkouts |on OPAC |on OPAC + Translatability | |fixes for OPAC Summary page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 21:25:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 20:25:09 +0000 Subject: [Koha-bugs] [Bug 15793] UX of circulation patron search with long lists of returned borrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15793 --- Comment #7 from Liz Rea --- I'm not fussy either way either, I'm happy as long as the problem of "I have to scroll for pages and pages to get to the submit button" is solved. :) Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 21:32:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 20:32:06 +0000 Subject: [Koha-bugs] [Bug 14507] SIP Authentication broken when LDAP Auth Enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 21:32:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 20:32:09 +0000 Subject: [Koha-bugs] [Bug 14507] SIP Authentication broken when LDAP Auth Enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507 --- Comment #5 from Liz Rea --- Created attachment 48045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48045&action=edit Bug 14507 Use checkpw to check password in Patron Info Some devices are using patron information responses to validate patron passwords to govern access to facilities as we were using C4::Auth::checkpw_hash this only worked in a db password context not other authentication routines. The C4::Auth routines are not very consistent and there isnt a dropin replacement for checkpw_hash this calls checkpw instead. In a password only environment this behaves as the old version did returning field CQ as Y if a valid password or no password is passed in the patron info request and N if an incorrect password is supplied It should also test against the appropriate authentication sources if othere autrhentication schemes are in use Signed-off-by: Liz Rea Tested this with a client who reports that this enables SIP authentication to work correctly with their LDAP server. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 14 23:50:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 22:50:12 +0000 Subject: [Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 --- Comment #4 from David Cook --- (In reply to M. Tompsett from comment #3) > What about the test case where you want to search for double quotes? > Escaping is needed. Perhaps there is another way? I disagree. Why do you think escaping is needed? Can you point me to the particular test case or query in mind? Firstly, the values are coming from the MARC record, so I doubt there will be many double quotes in that data. Secondly, even if there are double quotes in the data, CCL2RPN takes them into account. We can see what happens if we double up our double quotes on the front/back of the query: Z> find id-other,st-urx="http://libris.kb.se/resource/bib/219553" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 11, setno 31 SearchResult-1: term=http://libris.kb.se/resource/bib/219553 cnt=11 records returned: 0 Elapsed: 0.000886 BECOMES: @attrset Bib-1 @attr 1=9012 @attr 4=104 http://libris.kb.se/resource/bib/219553 Z> find id-other,st-urx=""http://libris.kb.se/resource/bib/219553"" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 11, setno 32 SearchResult-1: term=http://libris.kb.se/resource/bib/219553 cnt=11 records returned: 0 Elapsed: 0.000792 BECOMES: @attrset Bib-1 @attr 1=9012 @attr 4=104 http://libris.kb.se/resource/bib/219553 Z> f ti,phr=""This is a test"" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 4, setno 33 SearchResult-1: term=This cnt=4, term=is cnt=4, term=a cnt=4, term=test cnt=4 records returned: 0 Elapsed: 0.001079 BECOMES: @attrset Bib-1 @attr 1=4 @attr 4=1 "This is a test" Z> f ti,phr="This is a test" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 4, setno 34 SearchResult-1: term=This cnt=4, term=is cnt=4, term=a cnt=4, term=test cnt=4 records returned: 0 Elapsed: 0.000961 BECOMES: @attrset Bib-1 @attr 1=4 @attr 4=1 "This is a test" -- I'm guessing you're referring to a case where the data contains a double quote and you're searching to match a double quote... but Zebra should strip out double quotes during indexing in most cases. It might not for URLs, but RFC3986 stipulates that you should be percent encoding double quotes as %22 anyway so that shouldn't be an issue. I'll look at an example of that in a moment... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 00:05:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 23:05:32 +0000 Subject: [Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 --- Comment #5 from David Cook --- Interestingly enough, Zebra doesn't like it when you embed double quotes in a URL. http://prosentient.com.au?test="test" Becomes the following during indexing: http://prosentient.com.au?test=@test@ And the only way to retrieve it is to use the @ symbol instead of the double quotes in the query as well. Z> find uri,st-urx=http://prosentient.com.au?test="test" CCL ERROR: Embedded truncation not supported Z> find uri,st-urx="http://prosentient.com.au?test="test"" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 0, setno 11 SearchResult-1: term=http://prosentient.com.au?test=test cnt=0 records returned: 0 Elapsed: 0.000750 Z> find uri,st-urx="http://prosentient.com.au?test=@test@" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 1, setno 10 SearchResult-1: term=http://prosentient.com.au?test=@test@ cnt=1 records returned: 0 Elapsed: 0.000918 Now I'll try an example with normal word and phrase indexes... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 00:14:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 23:14:11 +0000 Subject: [Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 --- Comment #6 from David Cook --- As expected, the double quote is removed during normalization during indexing and retrieval for the phrase index: 245 00 $a This is a "test" / $c by David Cook Z> find ti,phr="This is a "test"" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 4, setno 4 SearchResult-1: term=This cnt=4, term=is cnt=4, term=a cnt=8, term=test cnt=4 records returned: 0 Elapsed: 0.001117 Z> show 1 245 00 $a This is a "test" / $c by David Cook Z> find ti,phr="This is a test" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 4, setno 5 SearchResult-1: term=This cnt=4, term=is cnt=4, term=a cnt=8, term=test cnt=4 records returned: 0 Elapsed: 0.000991 Z> show 1 245 00 $a This is a "test" / $c by David Cook -- We can see this using "elements zebra::index" too: this is a test by david cook We can see it with the word register too: this is a test by david cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 00:14:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Feb 2016 23:14:22 +0000 Subject: [Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 --- Comment #7 from David Cook --- In other words, I think my patch still holds up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 01:23:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 00:23:34 +0000 Subject: [Koha-bugs] [Bug 14376] Allow the librarian to choose a patron when entering a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #18 from Liz Rea --- Hi, I just noticed this bug, wanted to say that I think this is a great idea and I hope you come back to it. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 01:48:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 00:48:59 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #13 from Srdjan Jankovic --- (In reply to Fr?d?ric Demians from comment #12) > What about $use_syspref_cache variable and disable_syspref_cache() method? > Shouldn't it be removed? I have no idea. disable_syspref_cache() is used in some places that do not affect this patch, ie stand-alone scripts and tests, and I'm reluctant to remove it. Although I agree that the whole disable_syspref_cache() thing does not sound right and it should have been done different way. > What is your test environment? Two complete OPAC + intranet sites, running under starman. We are trying to break it. > Do you use debian/templates/plack.psgi? No. It is suited for single site plack app servers. What we wanted here is to serve multiple sites with only one app server thus sharing the code. I cannot see debian/templates/plack.psgi being used at all. Did I miss anything? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 07:30:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 06:30:36 +0000 Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 07:31:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 06:31:06 +0000 Subject: [Koha-bugs] [Bug 14376] Allow the librarian to choose a patron when entering a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 07:31:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 06:31:09 +0000 Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #4 from Katrin Fischer --- This is a workflow thing - you sometimes have to step through different status in order to get back, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 07:33:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 06:33:05 +0000 Subject: [Koha-bugs] [Bug 14376] Allow the librarian to choose a patron when entering a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 --- Comment #19 from Katrin Fischer --- Hi Amit, why did you change the status? I think Failed QA is correct, as there are patches to work with. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 07:51:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 06:51:20 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47965|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 48046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48046&action=edit [SIGNED-OFF] Bug 15809: Redefine multi_param is CGI < 4.08 is used On debian Jessie, the CGI version is >= 4.08 Since this version, the param method raise a warning "CGI::param called in list context". Indeed, it can cause vulnerability if called in list context https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named-parameter http://blog.gerv.net/2014/10/new-class-of-vulnerability-in-perl-web-applications/ There is a long journey to get rid of these warnings. First I suggest to redefine the multi_param method when the CGI version installed is < 4.08, it will allow us to move the wrong ->param calls to ->multi_param without waiting for everybody to upgrade. The different ways to call these 2 methods are: my $foo = $cgi->param('foo'); # OK my @foo = $cgi->param('foo'); # NOK, will raise the warning my @foo = $cgi->multi_param('foo'); #OK $template->param( foo => $cgi->param('foo') ); # NOK, will raise the warning # and vulnerable $template->param( foo => scalar $cgi->param('foo') ); # OK NOTE: Tested in conjuction of bug 14076. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 07:52:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 06:52:12 +0000 Subject: [Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 07:52:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 06:52:15 +0000 Subject: [Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47967|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 48047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48047&action=edit [SIGNED-OFF] Bug 14076: Do not use CGI->param in list context - opac-authorities-home.pl See bug 15809 for more info on why we should not use CGI->param in list context. Note: I have not found any places where several values for the same params are passed to this script but, just in case, this patch won't change this ability. Test plan: Do an authority search at the OPAC Test with several values of the form. Confirm that the results are always the same before and after this patch. NOTE: Tested in conjuction with bug 15809 Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 07:54:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 06:54:16 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|In Discussion |Signed Off --- Comment #4 from M. Tompsett --- This works well in solving the sample case in bug 14076. At some point in the future (2+ years), perhaps we'll up the required CGI version, such that multi_param will be included, and we can remove this code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 08:05:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 07:05:19 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Attachment #47830|0 |1 is obsolete| | --- Comment #23 from M. Tompsett --- Comment on attachment 47830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47830 Bug 14658: (followup) fix issue with list context on DBIC call This last patch was moved to a separate bug: bug 15813. Obsoleting this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 08:49:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 07:49:10 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #51 from Julian Maurice --- Hi Ian, it will be pushed to 3.22. I will add a comment when it's done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 08:50:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 07:50:42 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47599|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 48048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48048&action=edit Bug 15714: Add zebra_loglevels to koha-conf.xml This patch adds a commented zebra_loglevels line to the config file. Behavior does not change, but an admin can easily edit the variable. Test plan: Nothing really changed. But if you are not so sure about that, apply the change to /etc/koha/koha-conf-site.xml.in and run koha-create. Check that the new koha-conf contains the line and is not messed up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 08:51:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 07:51:22 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 --- Comment #9 from Marcel de Rooy --- (In reply to M. Tompsett from comment #7) > There is the possibility that they may think fatal,warn is the default to > change. Worse yet, they may not be aware of none. How about something like: Thx. Adjusted accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 09:02:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 08:02:45 +0000 Subject: [Koha-bugs] [Bug 15411] "Non fiction" is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #13 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 09:29:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 08:29:21 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #48 from Marcel de Rooy --- Created attachment 48049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48049&action=edit Bug 12426: [QA Follow-up] Clear to_address to force update When resending an email from the Notices tab in Patrons, we would like to use the recent email address. Test plan: [1] Look up a patron with some notices sent. [2] Adjust the patron email address (watch AutoEmailPrimaryAddress). [3] Resend the notice. Verify if the new address was used. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 09:30:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 08:30:46 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #49 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #47) > That's a very good remark and the expected behavior. > IMO it should be a requirement for this patch to be pushed (as it's very > easy to implement). OK. Added a follow-up. Thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 11:56:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 10:56:06 +0000 Subject: [Koha-bugs] [Bug 15817] New: Checkboxes for renewing items missing in OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15817 Bug ID: 15817 Summary: Checkboxes for renewing items missing in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org In the OPAC we offer a "Renew selected" and a "Renew all" option. The first won't work at the moment, as there are no checkboxes to select items for renewal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 14:05:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 13:05:30 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC|tomascohen at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 15:07:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 14:07:07 +0000 Subject: [Koha-bugs] [Bug 15818] New: OPAC search with utf-8 characters and without results generates encoding error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818 Bug ID: 15818 Summary: OPAC search with utf-8 characters and without results generates encoding error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: dpavlin at rot13.org QA Contact: testopia at bugs.koha-community.org When searching for something in OPAC which doesn't result in any results we get following encoding error: Cannot decode string with wide characters at /usr/lib/i386-linux-gnu/perl5/5.20/Encode.pm line 215. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 15:34:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 14:34:36 +0000 Subject: [Koha-bugs] [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 15:34:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 14:34:40 +0000 Subject: [Koha-bugs] [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818 --- Comment #1 from Dobrica Pavlinusic --- Created attachment 48050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48050&action=edit Bug 15818 - OPAC search with utf-8 characters and without results generates encoding error When searching for something in OPAC which doesn't result in any results but have utf-8 characters in search string we get following encoding error: Cannot decode string with wide characters at /usr/lib/i386-linux-gnu/perl5/5.20/Encode.pm line 215. This is because we are trying to decode string which is allready correctly marked as utf-8. Test scenario: 1) enter search string with utf-8 characters in opac which doesn't return any results 2) verify that you get application error 3) apply this patch 4) re-run query and verify that errror is gone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 15:35:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 14:35:36 +0000 Subject: [Koha-bugs] [Bug 15819] New: Error when edit borrowers "There are no patron categories defined" but categories exists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15819 Bug ID: 15819 Summary: Error when edit borrowers "There are no patron categories defined" but categories exists Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: hblancoca at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com when i try to edit borrower appears "There are no patron categories defined" in memberentry.pl but the categories works fine, i believe that the problem is the variable to .tt aply to cataloging module not appear authorised values I really apreciate your help -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 16:31:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 15:31:21 +0000 Subject: [Koha-bugs] [Bug 15819] Error when edit borrowers "There are no patron categories defined" but categories exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15819 --- Comment #1 from Humberto Blanco --- Its an error width MySQl because have sql_mode=only_full_group_by -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 16:34:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 15:34:10 +0000 Subject: [Koha-bugs] [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 16:34:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 15:34:13 +0000 Subject: [Koha-bugs] [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48050|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 48051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48051&action=edit Bug 15818 - OPAC search with utf-8 characters and without results generates encoding error When searching for something in OPAC which doesn't result in any results but have utf-8 characters in search string we get following encoding error: Cannot decode string with wide characters at /usr/lib/i386-linux-gnu/perl5/5.20/Encode.pm line 215. This is because we are trying to decode string which is allready correctly marked as utf-8. Test scenario: 1) enter search string with utf-8 characters in opac which doesn't return any results 2) verify that you get application error 3) apply this patch 4) re-run query and verify that errror is gone Signed-off-by: Jonathan Druart Step 0: Define "OPACNoResultsFound" with '{QUERY_KW}' Note that I don't get the error (Encode 2.60) but the search terms are not display correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 16:34:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 15:34:32 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15818 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818 [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 16:34:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 15:34:32 +0000 Subject: [Koha-bugs] [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dpavlin at rot13.org Depends on| |11944 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 [Bug 11944] Cleanup Koha UTF-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 16:51:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 15:51:23 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #22 from Jonathan Druart --- Something like start the server (make sure it starts correctly), request it, fetch records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 16:55:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 15:55:04 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:29:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:29:06 +0000 Subject: [Koha-bugs] [Bug 13061] filters on invoices not clearing after results found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13061 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:29:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:29:15 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #101 from Jonathan Druart --- Created attachment 48052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48052&action=edit Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber at provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber at messaging.sprintpcs.com Verizon phonenumber at vtext.com T-Mobile phonenumber at tmomail.net AT&T phonenumber at txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. Signed-off-by: Mark Tompsett Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:29:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:29:21 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #102 from Jonathan Druart --- Created attachment 48053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48053&action=edit Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:29:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:29:25 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #103 from Jonathan Druart --- Created attachment 48054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48054&action=edit Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:29:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:29:31 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #104 from Jonathan Druart --- Created attachment 48055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48055&action=edit Bug 9021 [QA Followup] - Use TT plugin instead of passing syspref via script Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:29:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:29:36 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #105 from Jonathan Druart --- Created attachment 48056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48056&action=edit Bug 9021 [QA Followup] - Use Modern::Perl Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:29:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:29:41 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #106 from Jonathan Druart --- Created attachment 48057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48057&action=edit Bug 9021 [QA Followup] - Fix ENGINE, don't create index on FK Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:29:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:29:45 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #107 from Jonathan Druart --- Created attachment 48058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48058&action=edit Bug 9021 [QA Followup] - Use same color as circ rules editor for row highlighting Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:29:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:29:51 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #108 from Jonathan Druart --- Created attachment 48059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48059&action=edit Bug 9021 [QA Followup] - Switch to Koha::Object(s) Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:29:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:29:56 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #109 from Jonathan Druart --- Created attachment 48060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48060&action=edit Bug 9021 [QA Followup] - Add feedback to delete button if provider is being used * Change links to buttons * Add warning class to delete button if provider is being used Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:30:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:30:02 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #110 from Jonathan Druart --- Created attachment 48061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48061&action=edit Bug 9021 [QA Followup] - Add column to deleted borrowers, set null on provider deletion Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:30:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:30:17 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #112 from Jonathan Druart --- Created attachment 48063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48063&action=edit Bug 9021 [QA Followup] - Add additional message to deletion warning if provider is in use. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:30:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:30:08 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #111 from Jonathan Druart --- Created attachment 48062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48062&action=edit Bug 9021 [QA Followup] - Unit tests Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:30:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:30:22 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #113 from Jonathan Druart --- Created attachment 48064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48064&action=edit Bug 9021: Fix conflict with bug 15446 (type vs _type) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:30:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:30:27 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #114 from Jonathan Druart --- Created attachment 48065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48065&action=edit Bug 9021: Save the provider even if the sms number is not modified Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:32:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:32:08 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:32:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:32:13 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48025|0 |1 is obsolete| | Attachment #48026|0 |1 is obsolete| | Attachment #48027|0 |1 is obsolete| | Attachment #48028|0 |1 is obsolete| | Attachment #48029|0 |1 is obsolete| | Attachment #48030|0 |1 is obsolete| | Attachment #48031|0 |1 is obsolete| | Attachment #48032|0 |1 is obsolete| | Attachment #48033|0 |1 is obsolete| | Attachment #48034|0 |1 is obsolete| | Attachment #48035|0 |1 is obsolete| | Attachment #48036|0 |1 is obsolete| | Attachment #48065|0 |1 is obsolete| | --- Comment #115 from Jonathan Druart --- Created attachment 48066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48066&action=edit Bug 9021: Save the provider even if the sms number is not modified Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:34:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:34:15 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:34:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:34:19 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47966|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 48067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48067&action=edit Bug 15747: Do not use CGI->param in list context - Auth.pm Test plan: Log you in! Without this patch applied, you will get a warning "Fetching the value or values of a single named parameter" With this patch applied, the warning from C4::Auth line 401 should not appear anymore in the log file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:34:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:34:42 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #17 from Jonathan Druart --- (In reply to Jesse Weaver from comment #14) > (In reply to Jonathan Druart from comment #4) > > Jesse, could you explain what you are doing with document.location.hash? > > > > I do not understand the following line in includes/cateditor-ui.inc: > > > > 1094 if ( "[% auth_forwarded_hash %]" ) { > > 1095 document.location.hash = "[% auth_forwarded_hash %]"; > > 1096 } > > > > Should not be: > > > > 1094 [% IF auth_forwarded_hash %] > > 1095 document.location.hash = "[% auth_forwarded_hash %]"; > > 1096 [% END %] > > > > instead? > > I don't quite remember why I did it that way. Your proposed change should be > fine. I let you fix it if you think it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:39:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:39:15 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #14 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #13) > (In reply to Fr?d?ric Demians from comment #12) > > What about $use_syspref_cache variable and disable_syspref_cache() method? > > Shouldn't it be removed? > > I have no idea. disable_syspref_cache() is used in some places that do not > affect this patch, ie stand-alone scripts and tests, and I'm reluctant to > remove it. Although I agree that the whole disable_syspref_cache() thing > does not sound right and it should have been done different way. See bug 13805 to know what it's needed using Plack (yes, this is terrible and another would be greatly appreciated). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:41:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:41:59 +0000 Subject: [Koha-bugs] [Bug 15813] Fix list-context call to ...->guarantor in opac-memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9303 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 [Bug 9303] relative's checkouts in the opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:41:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:41:59 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15813 [Bug 15813] Fix list-context call to ...->guarantor in opac-memberentry.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:42:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:42:18 +0000 Subject: [Koha-bugs] [Bug 15813] Fix list-context call to ...->guarantor in opac-memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:42:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:42:20 +0000 Subject: [Koha-bugs] [Bug 15813] Fix list-context call to ...->guarantor in opac-memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48038|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 48068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48068&action=edit Bug 15813: Fix list-context call to ...->guarantor in opac-memberentry.pl (was: Bug 14658: (followup) fix issue with list context on DBIC call) While working on bug 14659, it was discovered that the call to ...->guarantor in list context will cause the hash to be misaligned if there is no guarantor. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:42:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:42:43 +0000 Subject: [Koha-bugs] [Bug 15813] Fix list-context call to ...->guarantor in opac-memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart --- Skipping QA. Thanks Jesse! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:50:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:50:36 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:50:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:50:40 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46237|0 |1 is obsolete| | Attachment #46238|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 48069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48069&action=edit Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing Test plan: 1) Make sure there is at least one field in PatronSelfRegistrationBorrowerUnwantedField. 2) Apply patch, and update database. 3) Check to make sure that the new system preference PatronSelfModificationBorrowerUnwantedField has the same value as PatronSelfRegistrationBorrowerUnwantedField. 4) Verify that the same fields are hidden for self-registering a new borrower and edting a new one (both on the OPAC). 5) Change PatronSelfModificationBorrowerUnwantedField, and verify that the two preferences correctly apply to editing vs. creating. Signed-off-by: Michael Sauers Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:50:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:50:46 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #25 from Jonathan Druart --- Created attachment 48070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48070&action=edit Bug 14658 - (QA followup) make it easier to grep for these syspref names Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:50:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:50:50 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #26 from Jonathan Druart --- Created attachment 48071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48071&action=edit Bug 14658: Remove warning if prefs are not defined Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:51:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:51:20 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:52:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:52:58 +0000 Subject: [Koha-bugs] [Bug 15715] Import authorities from z39.50 hangs on import of authority record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15715 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #3 from Jonathan Druart --- See discussion on koha-devel http://lists.koha-community.org/pipermail/koha-devel/2016-February/042371.html Bug 13618 has been reverted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 17:59:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 16:59:00 +0000 Subject: [Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 18:08:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 17:08:47 +0000 Subject: [Koha-bugs] [Bug 12549] Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com --- Comment #4 from Jonathan Druart --- I don't know if we should update debian/templates/koha-conf-site.xml.in as weel, to keep both files in sync. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 18:23:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 17:23:54 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #37 from Jonathan Druart --- Kyle, 1/ Could you provide a test plan? 2/ What's next for these library groups? What's the difference with our existing groups? Is there a plan to move the existing ones to this new table? 3/ We already have a treetable plugin (compatible with DataTables), is there a reason to add another one? Marked as Failed QA for 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 18:24:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 17:24:52 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #38 from Jonathan Druart --- Created attachment 48072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48072&action=edit Bug 15707: Fix conflict with bug 15446 (type vs _type) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 18:30:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 17:30:47 +0000 Subject: [Koha-bugs] [Bug 6513] Library and Category filters when searching for a borrower to add to a routing list don't work correctly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6513 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #11 from Jonathan Druart --- Should have been fixed by bug 13891. *** This bug has been marked as a duplicate of bug 13891 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 18:30:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 17:30:47 +0000 Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables server-side processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #25 from Jonathan Druart --- *** Bug 6513 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 18:31:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 17:31:14 +0000 Subject: [Koha-bugs] [Bug 6513] Library and Category filters when searching for a borrower to add to a routing list don't work correctly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6513 --- Comment #12 from Jonathan Druart --- commit a77a9a70a232c3b2839945638df0f73aa9610327 Bug 13891: DataTables server-side processing - Serial recipients -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 18:32:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 17:32:08 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 18:35:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 17:35:50 +0000 Subject: [Koha-bugs] [Bug 15768] koha-news.pl Deep Recursion ERROR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15768 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Humberto, Could you give us more details please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 18:37:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 17:37:20 +0000 Subject: [Koha-bugs] [Bug 15677] Misconfigured anonymous patron allows checkouts to multiple patrons. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #5 from Jonathan Druart --- Marking as a duplicate of bug 14978. Please reopen if I am wrong. *** This bug has been marked as a duplicate of bug 14978 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 18:37:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 17:37:20 +0000 Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #10 from Jonathan Druart --- *** Bug 15677 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 18:38:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 17:38:40 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. |https://bugs.koha-community |org/bugzilla3/show_bug.cgi? |.org/bugzilla3/show_bug.cgi |id=15555 |?id=14238 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 18:38:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 17:38:40 +0000 Subject: [Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15541 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 18:47:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 17:47:46 +0000 Subject: [Koha-bugs] [Bug 15819] Error when edit borrowers "There are no patron categories defined" but categories exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15819 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|blocker |major --- Comment #2 from Jonathan Druart --- Humberto, Which version of Koha are you using? And the version of MySQL? Did you try and remove the sql_mode option from the MySQL conf file? Lowering the severity to major. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 18:52:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 17:52:41 +0000 Subject: [Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Nick, there is no difference between the 2 snippets you paste :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 18:53:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 17:53:18 +0000 Subject: [Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #2 from Jonathan Druart --- Ha ok, "this should fire a warning" :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 19:01:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 18:01:49 +0000 Subject: [Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #3 from Jonathan Druart --- We could change the different occurrences of if defined($loanlength) && $loanlength->{issuelength}; with if defined($loanlength) && defined $loanlength->{issuelength}; To take into account the "0". And do not default to 0 when defining the circ rules but NULL instead. The only problem is that these behavior changes could be considered as a bug for existing installations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 19:56:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 18:56:10 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 20:06:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 19:06:24 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41220|0 |1 is obsolete| | --- Comment #33 from R?mi Mayrand-Provencher --- Created attachment 48073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48073&action=edit Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on current master for testing) http://bugs.koha-community.org/show_bug.cgi?id=11879 To test this patch: Update database Edit a borrower's informations. The "Main Contact Method" selectbox appears in the form and its value is correctly. Works as expected. For handling of syspref BorrowerUnwantedField use second patch- Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 20:06:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 19:06:33 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41221|0 |1 is obsolete| | --- Comment #34 from R?mi Mayrand-Provencher --- Created attachment 48074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48074&action=edit Bug 11879 - Fix syspref BorrowerUnwantedField How I tested: Apply 1st patch Apply this patch Edit syspref BorrowerUnwantedField to exclude fields Edit patron's contact information Make sure that fields do not longer appear in drop down for Main contact Wors as expected http://bugs.koha-community.org/show_bug.cgi?id=11879 Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 20:06:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 19:06:37 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46286|0 |1 is obsolete| | --- Comment #35 from R?mi Mayrand-Provencher --- Created attachment 48075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48075&action=edit Bug 11879 - Update BDIx schema and show main contact method in moremember.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 20:07:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 19:07:53 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 20:49:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 19:49:33 +0000 Subject: [Koha-bugs] [Bug 14731] Sip2 unavailable Patron Attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14731 Humberto Blanco changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hblancoca at gmail.com --- Comment #1 from Humberto Blanco --- maybe take a look at bug 9936 can help you -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 20:49:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 19:49:39 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Humberto Blanco changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hblancoca at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 21:24:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 20:24:12 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 21:24:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 20:24:16 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48073|0 |1 is obsolete| | --- Comment #36 from Aleisha Amohia --- Created attachment 48076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48076&action=edit [SIGNED-OFF] Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on current master for testing) http://bugs.koha-community.org/show_bug.cgi?id=11879 To test this patch: Update database Edit a borrower's informations. The "Main Contact Method" selectbox appears in the form and its value is correctly. Works as expected. For handling of syspref BorrowerUnwantedField use second patch- Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 21:24:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 20:24:43 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48076|0 |1 is obsolete| | --- Comment #37 from Aleisha Amohia --- Created attachment 48077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48077&action=edit [SIGNED-OFF] Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on current master for testing) http://bugs.koha-community.org/show_bug.cgi?id=11879 To test this patch: Update database Edit a borrower's informations. The "Main Contact Method" selectbox appears in the form and its value is correctly. Works as expected. For handling of syspref BorrowerUnwantedField use second patch- Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 21:24:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 20:24:52 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48074|0 |1 is obsolete| | --- Comment #38 from Aleisha Amohia --- Created attachment 48078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48078&action=edit [SIGNED-OFF] Bug 11879 - Fix syspref BorrowerUnwantedField How I tested: Apply 1st patch Apply this patch Edit syspref BorrowerUnwantedField to exclude fields Edit patron's contact information Make sure that fields do not longer appear in drop down for Main contact Wors as expected http://bugs.koha-community.org/show_bug.cgi?id=11879 Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 21:25:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 20:25:02 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48075|0 |1 is obsolete| | --- Comment #39 from Aleisha Amohia --- Created attachment 48079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48079&action=edit [SIGNED-OFF] Bug 11879 - Update BDIx schema and show main contact method in moremember.pl Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 21:52:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 20:52:53 +0000 Subject: [Koha-bugs] [Bug 15820] New: suggestion.pl maximum internal redirects Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15820 Bug ID: 15820 Summary: suggestion.pl maximum internal redirects Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: hblancoca at gmail.com QA Contact: testopia at bugs.koha-community.org Whe i try to change status for a suggestions appears error 500. If I see the log i can see: [Mon Feb 15 15:48:45.705691 2016] [core:error] [pid 29073] [client 10.11.93.119:50625] AH00124: Request exceeded the limit of 10 internal redirects due to probable configuration error. Use 'LimitInternalRecursion' to increase the limit if necessary. Use 'LogLevel debug' to get a backtrace., referer: http://10.10.11.53:8080/cgi-bin/koha/suggestion/suggestion.pl?displayby=STATUS&budgetid=__ANY__&branchcode=__ANY__ Any suggestion? Humberto -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 21:53:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 20:53:53 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41231|0 |1 is obsolete| | Attachment #41232|0 |1 is obsolete| | --- Comment #17 from R?mi Mayrand-Provencher --- Created attachment 48080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48080&action=edit Bug 8609 - Add an URL validation plugin for authority and biblio frameworks This patch adds a new validation plugin to validate that a field/subfield contains a valid url. This plugin that can be used in biblio and authority frameworks. Testing: I) Before applying: 0) Go to the Cataloging module: menu->More->Cataloging; 1) Click < default framework>> bouton; 2) Click tab << 8 >>; 3) Insert a text (for example "test") in the 856->u input field; 4) Click out of the input field; 5) Validate no message; II) After Applying: i) field/subfield plugin attach 0) In Koha adminstration, click << MARC bibliographic framework >>; 1) In Default framework, click << MARC structure >>; 2) Search field 856 and click << Subfields >>; 3) Click << u >>; 4) In Other options -> Plugin, choose url.pl ii) Insert a text in the 856->u input field 0) Go to the Cataloging module: menu->More->Cataloging; 1) Click < default framework>> bouton; 2) Click tab << 8 >>; 3) Insert a text (for example "test") in the 856->u input field; 4) Click out of the input field; 5) Validate message: << The field 856$u must contain a valid URL! ex : http://www.google.com >> Squashed all previous commits into one as asked by comment #15. I did not see any changes made to the database so I didn't change anything related to that. Bug8609 - Removed useless plugin_parameters sub bug8609 fixes for comment #15 and #16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 21:54:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 20:54:30 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 21:58:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 20:58:39 +0000 Subject: [Koha-bugs] [Bug 15821] New: Use Font Awesome icons in confirmation dialogs - Circulation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Bug ID: 15821 Summary: Use Font Awesome icons in confirmation dialogs - Circulation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Building on from Bug 15785 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 22:04:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 21:04:10 +0000 Subject: [Koha-bugs] [Bug 15681] Improve visibility of place hold option when checking out an item already checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #7 from Aleisha Amohia --- Will fix this in patch for Bug 15821. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 22:15:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 21:15:03 +0000 Subject: [Koha-bugs] [Bug 14099] RESERVESLIP shows incorrect information in items.holdingbranch on first scan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14099 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 22:15:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 21:15:26 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #18 from H?ctor Eduardo Castro Avalos --- Hi R?mi I think IMHO QA will not approve this cataloguing/value_builder/url.pl >+use strict; >+use warnings; >+no warnings 'redefine'; # otherwise loading up multiple plugins fills the log with subroutine redefine warnings >+ This according with -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 22:15:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 21:15:37 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 22:15:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 21:15:46 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 22:16:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 21:16:01 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 22:18:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 21:18:44 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 22:19:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 21:19:30 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 --- Comment #5 from Heather Braum --- Still problematic in 3.22. I accidentally ran into it on testing 3.22 today. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 23:16:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 22:16:06 +0000 Subject: [Koha-bugs] [Bug 15821] Use Font Awesome icons in confirmation dialogs - Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 23:16:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 22:16:09 +0000 Subject: [Koha-bugs] [Bug 15821] Use Font Awesome icons in confirmation dialogs - Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 --- Comment #1 from Aleisha Amohia --- Created attachment 48081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48081&action=edit Bug 15821: Use Font Awesome icons in confirmation dialogs - Circulation To test, apply the patch and test deletion in the following cases. Test both confirmation and cancel actions. Circulation -> Check out -> An item that is checked out by someone else -> An item that is on hold to someone else -> To a patron that has more than noisuescharge in fines (Allow AllowFineOverride syspref) -> To a patron that has reached the max amount of checkouts (Allow AllowTooManyOverride syspref) -> To a patron that has more than noissuescharge in fines (Allow AllowFineOverride syspref and set noissuescharge syspref) -> Renew -> An item that is on hold to someone else -> To a patron that is at max renewals (Allow AllowRenewalLimitOverride syspref) -> An item that is not checked out by anyone -> Check in -> An item that is in transit to another branch And look for other confirmation dialogs and check if I've missed any Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 23:16:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 22:16:30 +0000 Subject: [Koha-bugs] [Bug 15821] Use Font Awesome icons in confirmation dialogs - Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 23:17:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 22:17:02 +0000 Subject: [Koha-bugs] [Bug 15822] New: STAFF Advanced search error date utils Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 Bug ID: 15822 Summary: STAFF Advanced search error date utils Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: hblancoca at gmail.com QA Contact: testopia at bugs.koha-community.org When i try to search in staff advanced search "topographic signature" 340.11, appears following error: Can't locate object method "ymd" via package "dateonly" (perhaps you forgot to load "dateonly"?) at /usr/share/koha/lib/Koha/DateUtils.pm line 223. the search string is: http://catalogo.edu.co:8080/cgi-bin/koha/catalogue/search.pl?idx=callnum&q=340.11&idx=kw&op=and&sort_by=relevance I can probe, that when i search with "Explorar ?ndices" option enabled the string changes(adding scan variable) and try other values to explore. http://catalogo.edu.co:8080/cgi-bin/koha/catalogue/search.pl?idx=callnum&q=340.11&op=and&idx=kw&op=and&idx=kw&scan=1&sort_by=relevance Really appreciate your help -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 23:17:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 22:17:32 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 Humberto Blanco changed: What |Removed |Added ---------------------------------------------------------------------------- OS|All |Linux Priority|P5 - low |P1 - high Severity|enhancement |critical CC| |hblancoca at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 23:19:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 22:19:09 +0000 Subject: [Koha-bugs] [Bug 15819] Error when edit borrowers "There are no patron categories defined" but categories exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15819 --- Comment #3 from Humberto Blanco --- the version is 5.27. after change sql_mode its working for me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 23:24:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 22:24:00 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #9 from Mike --- Hello, if I followed test plan, i got Internal server error as result of step 4. Koha 3.22.3 with active Plack. Mike -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 23:36:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 22:36:16 +0000 Subject: [Koha-bugs] [Bug 13061] filters on invoices not clearing after results found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13061 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hm, I'd say it's the expected behaviour. It helps you to see which search the results refer too and allows you to make modifications to your search if the result list is not what you expected. It's also consistent in how other searches work - for example the patron search. Would a link to clear the filter at the bottom work? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 23:49:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 22:49:26 +0000 Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- Do we need to take another look at this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 23:50:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 22:50:09 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 23:53:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 22:53:14 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED --- Comment #74 from Katrin Fischer --- I think this is no longer needed with SUGGEST_FORMAT - please reopen if I am missing something. Marking INVALID as we opted for another different solution with the new authorized value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 23:53:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 22:53:15 +0000 Subject: [Koha-bugs] [Bug 7115] Suggestion form has wrong label if AdvancedSearchTypes = collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7115 Bug 7115 depends on bug 9223, which changed state. Bug 9223 Summary: Multiple values of AdvancedSearchTypes in suggestions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 15 23:53:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 22:53:16 +0000 Subject: [Koha-bugs] [Bug 8036] item type on purchase suggestion blank In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8036 Bug 8036 depends on bug 9223, which changed state. Bug 9223 Summary: Multiple values of AdvancedSearchTypes in suggestions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 00:39:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 23:39:06 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #18 from David Cook --- Jonathan's patch looks good - provided that $in->{'query'}->param('auth_forwarded_hash') is a single value and not a multi value. (I assume that it is a single value.) I'd like to clarify one thing though. The warning "Do not use CGI->param in list context" is not strictly necessary. The problem isn't with CGI->param() in list context per se but rather with CGI->param("foo") in list context. I'm using "my @param_names = CGI->param()" elsewhere and it doesn't generate warnings. It only generates warnings if you're passing the method an argument, as it introduces some ambiguity and the possibility of buggy behaviour. Here's the example from CGI: my %user_info = ( id => 1, name => $query->param('name'), ); In theory, someone could submit multiple "name" arguments, so the above could actually be interpolated like this: my %user_info = ( id => 1, name => "bruce", "wayne", "clark", "kent" ); If you run the code with that list as the value for "name", you'll get the following hash after interpolation: 'id' => 1, 'name' => 'bruce', 'kent' => undef, 'wayne' => 'clark' That's definitely a vulnerability. So if you know that you only have one "name", you can use "scalar $query->param('name')". However, if you know that you have multiple names, but don't want to wind up with a mangled hash, I think you should be able to do the following: my %user_info = ( id => 1, name => [$query->param('name')], ); That should give you the following: 'id' => 1, 'name' => [ 'bruce', 'wayne', 'clark', 'kent' ] Of course, I think you'd still get the warning even if you did $query->param('name'), which is why CGI->multi_param probably makes more sense as per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 00:44:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 23:44:54 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #19 from David Cook --- So yeah, even if you use the [] to create an arrayref, you'll still get the CGI warning, because CGI just knows you're asking for a single named parameter in list context; it doesn't know that you're going to create a reference using that list. But... even if you were using CGI->multi_param... you'd still need to use the [] construct to use an arrayref for a hash value rather than accidentally filling your hash full of other values because you added a list... Anyway, here's some easy tests to run: -------- BAD NEWS: use Modern::Perl; use CGI; use Data::Dumper; my $query = CGI->new(); $query->param('name',"bruce","wayne","clark","kent"); my %hash = ( id => 1, name => $query->param('name') ); warn Dumper(\%hash); -------- WELL DONE: use Modern::Perl; use CGI; use Data::Dumper; my $query = CGI->new(); $query->param('name',"bruce","wayne","clark","kent"); my %hash = ( id => 1, name => [$query->param('name')] ); warn Dumper(\%hash); --------- HALFWAY THERE: use Modern::Perl; use CGI; use Data::Dumper; my $query = CGI->new(); $query->param('name',"bruce","wayne","clark","kent"); my %hash = ( id => 1, name => scalar $query->param('name') ); warn Dumper(\%hash); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 00:50:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 23:50:52 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13805 --- Comment #15 from Srdjan Jankovic --- > See bug 13805 to know what it's needed using Plack (yes, this is terrible > and another would be greatly appreciated). It is needed as it stands now, but not needed after my patches. In fact, the most laborious part was to reorganise Context and sysprefs caching so it makes much less trouble. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 00:50:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Feb 2016 23:50:52 +0000 Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15562 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 02:12:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 01:12:05 +0000 Subject: [Koha-bugs] [Bug 15823] New: Can still access patron discharge slip without having the syspref on - Permissions breach Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823 Bug ID: 15823 Summary: Can still access patron discharge slip without having the syspref on - Permissions breach Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To reproduce: Ensure that useDischarge syspref is off. Go to cgi-bin/koha/members/discharge.pl?borrowernumber=X Confirm that you are still able to access this page and generate discharge slip. This is a permissions breach -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 02:23:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 01:23:29 +0000 Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip without having the syspref on - Permissions breach In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 02:23:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 01:23:32 +0000 Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip without having the syspref on - Permissions breach In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823 --- Comment #1 from Aleisha Amohia --- Created attachment 48082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48082&action=edit Bug 15823: Can still access patron discharge slip without having the syspref on To test: 1) Ensure syspref useDischarge is disabled 2) Go to http://localhost:8081/cgi-bin/koha/members/discharge.pl?borrowernumber=X 3) Validate that you are still able to generate a discharge slip for this patron 4) Apply patch and refresh page 5) Confirm that you get an error message and can no longer generate a discharge. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 02:54:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 01:54:59 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 --- Comment #28 from Liz Rea --- Hi Jonathan, Yep, that should probably be fixed we'll take a look into a follow up for that. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:07:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:07:47 +0000 Subject: [Koha-bugs] [Bug 15824] New: 'Done' button is unclear on batch item modification and deletion Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Bug ID: 15824 Summary: 'Done' button is unclear on batch item modification and deletion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org To reproduce, go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) Click edit -> Edit items in a batch Click Save (you don't need to make any changes) Notice Done link at the bottom of the page is not very noticeable. This is the same with batch item deletion as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:16:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:16:30 +0000 Subject: [Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:16:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:16:33 +0000 Subject: [Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 --- Comment #1 from Aleisha Amohia --- Created attachment 48083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48083&action=edit Bug 15824 - 'Done' button is unclear on batch item modification and deletion To test: MODIFICATION 1) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 2) Click edit -> Edit items in a batch 3) Click Save (you don't need to make any changes) 4) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 5) Go to a biblio record page 6) Select one or some or all items in the record 7) Click modify selected items 8) Click Save 9) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 10) Go to batch item modification (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl) 11) Write some barcodes into the barcode list and click Continue 12) Click Save 13) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item mod page. DELETION 14) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 15) Click edit -> Delete items in a batch 16) Unselect all the items so you don't actually delete them, then click Delete selected items 17) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 18) Go to a biblio record page 19) Select one or some or all items in the record 20) Click Delete selected items 21) Unselect all the items so you don't actually delete them, then click Delete selected items 22) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 23) Go to batch item deletion (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl?del=1) 24) Write some barcodes into the barcode list and click Continue 25) Unselect all the items so you don't actually delete them, then click Delete selected items 26) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item deletion page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:17:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:17:34 +0000 Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip without having the syspref on - Permissions breach In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | Change sponsored?|--- |Sponsored --- Comment #2 from Aleisha Amohia --- Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:17:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:17:59 +0000 Subject: [Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored --- Comment #2 from Aleisha Amohia --- Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:24:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:24:56 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15555, 15541, 15745 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 [Bug 15541] Prevent normalization during matching/import process https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:24:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:24:56 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 [Bug 10662] Build OAI-PMH Harvesting Client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:24:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:24:56 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 [Bug 10662] Build OAI-PMH Harvesting Client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:24:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:24:56 +0000 Subject: [Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 [Bug 10662] Build OAI-PMH Harvesting Client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:31:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:31:03 +0000 Subject: [Koha-bugs] [Bug 15825] New: Patron lists does not show tools menu sidebar Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15825 Bug ID: 15825 Summary: Patron lists does not show tools menu sidebar Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Patron lists is the only link in the tools-menu sidebar that doesn't show the menu on the side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:41:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:41:01 +0000 Subject: [Koha-bugs] [Bug 14712] Feature for controlling cron jobs/cmd line scripts from staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14712 --- Comment #2 from David Cook --- Hi Eivin, Do you have some code prepared for this already? I've also been working on a new task scheduler, which I'm putting the finishing touches on at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:43:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:43:57 +0000 Subject: [Koha-bugs] [Bug 15826] New: Use Font Awesome icons in confirmation dialogs - Tools Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15826 Bug ID: 15826 Summary: Use Font Awesome icons in confirmation dialogs - Tools Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Building on from Bug 15785 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:49:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:49:32 +0000 Subject: [Koha-bugs] [Bug 15827] New: Unfriendly message when saving overdue notice/status triggers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15827 Bug ID: 15827 Summary: Unfriendly message when saving overdue notice/status triggers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: Go to Tools -> Overdue notice/status triggers Click Save changes (you don't have to change anything) Notice message is all in capitals and isn't very user friendly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:50:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:50:46 +0000 Subject: [Koha-bugs] [Bug 15827] Unfriendly message when saving overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15827 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:50:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:50:49 +0000 Subject: [Koha-bugs] [Bug 15827] Unfriendly message when saving overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15827 --- Comment #1 from Aleisha Amohia --- Created attachment 48084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48084&action=edit Bug 15827 - Unfriendly message when saving overdue notice/status triggers To test: 1) Go to Tools -> Overdue notice/status triggers 2) Click Save changes (you don't have to change anything) 3) Confirm message now says 'Changes saved.' which is much nicer Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 03:52:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 02:52:16 +0000 Subject: [Koha-bugs] [Bug 15827] Unfriendly message when saving overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15827 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 04:03:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 03:03:39 +0000 Subject: [Koha-bugs] [Bug 15828] New: Upload patron images is hard to read Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15828 Bug ID: 15828 Summary: Upload patron images is hard to read Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 48085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48085&action=edit upload patron images See attachment - Uses tiny text and input field. Should be bigger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 04:18:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 03:18:10 +0000 Subject: [Koha-bugs] [Bug 15829] New: Rotating Collections is under Patrons on Tools Home - Should be Catalog Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15829 Bug ID: 15829 Summary: Rotating Collections is under Patrons on Tools Home - Should be Catalog Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 48086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48086&action=edit tools home See attachment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 04:24:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 03:24:29 +0000 Subject: [Koha-bugs] [Bug 15829] Rotating Collections is under Patrons on Tools Home - Should be Catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15829 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 04:24:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 03:24:32 +0000 Subject: [Koha-bugs] [Bug 15829] Rotating Collections is under Patrons on Tools Home - Should be Catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15829 --- Comment #1 from Aleisha Amohia --- Created attachment 48087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48087&action=edit Bug 15829 - Rotating Collections is under Patrons on Tools Home - Should be Catalog To test: 1) Notice Rotating Collections is under Patrons & Circ on tools-home.pl 2) Apply patch and refresh page 3) Notice it is now under Catalog and is in the same position it is in on the tools sidebar menu Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 04:24:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 03:24:54 +0000 Subject: [Koha-bugs] [Bug 15829] Rotating Collections is under Patrons on Tools Home - Should be Catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15829 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 04:26:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 03:26:56 +0000 Subject: [Koha-bugs] [Bug 15830] New: Move Rotating Collections actions into a drop-down list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Bug ID: 15830 Summary: Move Rotating Collections actions into a drop-down list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Similar to the patch for bug 13778 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 04:38:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 03:38:39 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 --- Comment #10 from M. Tompsett --- Here is what I did to test this: Create an empty VM (e.g. an Debian 8.3 VM) Roll a distribution off master+15714 Install it on that VM. sudo koha-stop-zebra library ps aux | grep zebra sudo koha-start-zebra library ps aux | grep zebra --- These should be defaults sudo vi /etc/koha/site/library/koha-conf.xml --- tweak the zebra log levels sudo koha-stop-zebra library ps aux | grep zebra sudo koha-start-zebra library ps aux | grep zebra --- These should match what was tweaked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 04:39:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 03:39:16 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47598|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 48089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48089&action=edit [SIGNED-OFF] Bug 15714: Remove zebra.log and add loglevels The file zebra.log is actually not used, because daemon's --output parameter sends all message to zebra-output (making that stdout goes there too and --stdout does nothing). We do not need any differentiation (if any at all) here; behavior does not change. Note: zebra-error will only contain the daemon's error messages and not the zebra error messages! So you will probably only find messages about stopping zebra in zebra-error. The loglevels are by default none,fatal,warn and can be changed via the zebra_loglevels config variable (read by koha-functions.sh). If you remove 'none', you will have request-messages in the log. You can also keep 'none' and add 'request' to achieve something similar (undocumented however). Some of the parameters passed to daemon when stopping zebra are superfluous and have been removed. Test plan: [1] Remove the file zebra.log. Look at last lines in zebra-error and zebra-output. [2] Remove zebra_loglevels from koha-conf (if present). Start/restart Zebra. Search to verify if Zebra runs. Stop Zebra and check zebra-error for a new line (killed by signal 15). [3] Add fatal,warn in koha-conf:zebra_loglevels (do not include 'none'). Start Zebra. Check zebra-output for a line "[log] zebra_start". Do a search and check zebra-output for lines with "[request]". [4] Verify that zebra.log did not appear again. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 04:39:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 03:39:08 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47597|0 |1 is obsolete| | --- Comment #11 from M. Tompsett --- Created attachment 48088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48088&action=edit [SIGNED-OFF] Bug 15714: Add get_loglevels to koha-functions.sh Preparing for including different log levels in koha-start-zebra. Note that the default response is none,fatal,warn; this is equal to the options passed to zebrasrv in koha-start-zebra (for now). Test plan: [1] Run on the command line: source koha-functions.sh [2] Type get_loglevels [your_instance] By default, you should see: none,fatal,warn [3] Add this line to your koha-conf: how,are,you [4] Run get_loglevels [your_instance] again. Remove the nonsense log levels again.. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 04:39:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 03:39:23 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48048|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 48090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48090&action=edit [SIGNED-OFF] Bug 15714: Add zebra_loglevels to koha-conf.xml This patch adds a commented zebra_loglevels line to the config file. Behavior does not change, but an admin can easily edit the variable. Test plan: Nothing really changed. But if you are not so sure about that, apply the change to /etc/koha/koha-conf-site.xml.in and run koha-create. Check that the new koha-conf contains the line and is not messed up. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 04:41:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 03:41:03 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from M. Tompsett --- See how I test in comment #10. I suppose putting in searchable data and re-indexing and making sure it searches adequately should also be done, but given that it starts and stops properly, I have no reason to doubt it would suddenly break that way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 04:43:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 03:43:25 +0000 Subject: [Koha-bugs] [Bug 14712] Feature for controlling cron jobs/cmd line scripts from staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14712 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=1993 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 04:43:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 03:43:25 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14712 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 04:48:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 03:48:22 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #48 from David Cook --- I'm also working on a related feature via my work on bug 10662. My work is also sponsored by folks in Sweden, so hurray Sweden! I've been thinking about opening a new bug, or looking up one of these bugs to post patches. Basically, I've written a task scheduler, which accepts a few variables (e.g. start_time, repeat_interval, task_type, params). It then uses plugin modules to run the actual task. I've already written plugins to download records via OAI-PMH, and to upload those records to a new Koha API for OAI-PMH records specifically. It would be fairly trivial to create a "Report" plugin. The web user interface relies on a template include which is matched to the plugin. The whole thing needs some work, but I'm hoping folks will test it and I'm looking at polishing it up... At the moment, it's all at bug 10662, but I'm thinking of breaking into different bug reports... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 05:06:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 04:06:43 +0000 Subject: [Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 05:06:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 04:06:46 +0000 Subject: [Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 --- Comment #1 from Aleisha Amohia --- Created attachment 48091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48091&action=edit Bug 15830 - Move Rotating Collections actions into a drop-down list To test: 1) Go to Tools -> Rotating Collections 2) Confirm actions (Add or remove items, Transfer, Edit, Delete) have moved into a drop down menu 3) Confirm all of the actions work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 05:06:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 04:06:58 +0000 Subject: [Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 05:40:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 04:40:53 +0000 Subject: [Koha-bugs] [Bug 15826] Use Font Awesome icons in confirmation dialogs - Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15826 --- Comment #1 from Aleisha Amohia --- Created attachment 48092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48092&action=edit Bug 15826 - Use Font Awesome icons in confirmation dialogs - Tools I only found one confirmation dialog, all the others use javascript. To test: Go to Tools -> Notices and Slips Click Delete on a notice Confirm Yes and No options still work as expected Check Tools module in case I missed any confirm dialogs Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 05:40:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 04:40:50 +0000 Subject: [Koha-bugs] [Bug 15826] Use Font Awesome icons in confirmation dialogs - Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15826 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 05:41:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 04:41:06 +0000 Subject: [Koha-bugs] [Bug 15826] Use Font Awesome icons in confirmation dialogs - Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15826 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 05:43:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 04:43:29 +0000 Subject: [Koha-bugs] [Bug 15829] Rotating Collections is under Patrons on Tools Home - Should be Catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15829 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 05:43:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 04:43:31 +0000 Subject: [Koha-bugs] [Bug 15829] Rotating Collections is under Patrons on Tools Home - Should be Catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15829 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48087|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 48093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48093&action=edit [SIGNED-OFF] Bug 15829 - Rotating Collections is under Patrons on Tools Home - Should be Catalog To test: 1) Notice Rotating Collections is under Patrons & Circ on tools-home.pl 2) Apply patch and refresh page 3) Notice it is now under Catalog and is in the same position it is in on the tools sidebar menu Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 05:47:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 04:47:31 +0000 Subject: [Koha-bugs] [Bug 15827] Unfriendly message when saving overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15827 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 05:47:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 04:47:33 +0000 Subject: [Koha-bugs] [Bug 15827] Unfriendly message when saving overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15827 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48084|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 48094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48094&action=edit [SIGNED-OFF] Bug 15827 - Unfriendly message when saving overdue notice/status triggers To test: 1) Go to Tools -> Overdue notice/status triggers 2) Click Save changes (you don't have to change anything) 3) Confirm message now says 'Changes saved.' which is much nicer Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 05:59:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 04:59:36 +0000 Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip without having the syspref on - Permissions breach In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 05:59:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 04:59:39 +0000 Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip without having the syspref on - Permissions breach In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48082|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 48095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48095&action=edit [SIGNED-OFF] Bug 15823: Can still access patron discharge slip without having the syspref on To test: 1) Ensure syspref useDischarge is disabled 2) Go to http://localhost:8081/cgi-bin/koha/members/discharge.pl?borrowernumber=X 3) Validate that you are still able to generate a discharge slip for this patron 4) Apply patch and refresh page 5) Confirm that you get an error message and can no longer generate a discharge. Sponsored-by: Catalyst IT NOTE: If the useDischarge system preference is enabled, there is a Discharge tab displayed when viewing patron details. This closes a direct URL issue. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 07:05:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 06:05:21 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #10 from Josef Moravec --- (In reply to Mike from comment #9) > Hello, > if I followed test plan, i got Internal server error as result of step 4. > Koha 3.22.3 with active Plack. > > Mike Are you sure you tested with 3.22.3 version? It should be tested on master... maybe the problem is that you didn't run update_dbix_class_files.pl script? Just guess... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 07:26:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 06:26:14 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47675|0 |1 is obsolete| | --- Comment #66 from David Cook --- Created attachment 48096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48096&action=edit Bug 10662 - Build OAI-PMH Harvesting Client _QUICK AND TENTATIVE TEST PLAN_ In the following steps replace "/home/user" with whatever your Koha dev install is _CONFIGURATION_ 1) Add something like the following to your koha-conf.xml after and before unix:/home/user/koha-dev/var/run/icarus.sock /home/user/koha-dev/var/run/icarus.pid /home/user/koha-dev/var/log/icarus.log Koha::Icarus::Task::Enqueue::OAIPMH::Biblio Koha::Icarus::Task::Dequeue::OAIPMH::Biblio Koha::Icarus::Task::Test 30 2) Apply Bugzilla patches 15555, 15541, 15745, then 10662 3) Upgrade your Koha dev install so that it uses new Zebra configuration files; try something like the following: perl Makefile.PL --prev-install-log "$INSTALL_LOG" make make test make upgrade 4) Run upgrade database: perl installer/data/mysql/updatedatabase.pl 4) Set PERL5LIB to include /home/user/koha (i.e. path to your C4 and Koha module directories) export PERL5LIB=/home/user/koha 5) Activate Icarus using the following command: perl /home/user/koha/misc/bin/icarusd.pl -f /home/user/koha-dev/etc/koha-conf.xml NOTE: It will send output to your terminal window. To write to the log file, you can daemonize by adding the "-d" or "--daemon" options. 6) In Koha, create a record matching rule: Code = OAI Match threshold = 100 Record type = Bibliographic Search index = control-number Score = 100 Tag = 001 Search index = id-other,st-urx Score = 100 Tag = 024 Subfields = a Normalization rule = raw _USER DOWNLOAD TASK_ 7a) Go to Koha administration > Saved tasks (http://KOHA/cgi-bin/koha/admin/saved_tasks.pl) 7b) Click "New saved task" 7c) Leave it on "Koha::Icarus::Task::Enqueue::OAIPMH::Biblio" and click "Next" 7d) Choose a "Start time" in the past using the calendar pop-up 7e) Choose a "Repeat interval" of at least 30 seconds (for initial troubleshooting purposes) 7f) Choose a URL of an OAI-PMH repository that you want to harvest (also include a username, password, and realm if necessary) 7g) Fill out your OAI-PMH repositories as you like 7h) Fill out "Queue" with something like file:///home/user/koha/icarus_test 7i) Click "Save" 8a) Check that the Icarus dashboard has a "Status" of "Online" 8b) Click "Send to Icarus" next to your new saved task entry 8c) A task should now appear under "Active Icarus tasks"; click "Start" 8d) Go back to your terminal to check the Icarus server output (or 'tail -f' the log if you daemonized) 8e) You should notice activity; you can also check /home/user/koha/icarus_test to see if records are being downloaded and stored there _USER IMPORT TASK_ 9a) Go back to Koha administration > Saved tasks (http://KOHA/cgi-bin/koha/admin/saved_tasks.pl) 9b) Click "New saved task" 9c) Choose Koha::Icarus::Task::Dequeue::OAIPMH::Biblio, and click "Next" 9d) Repeat the same steps for "Start time" and "Repeat interval" as these are common to all tasks 9e) "Queue" should be the same as before, so try your path of file:///home/user/koha/icarus_test 9f) Provide a username and password for the API authentication; you should be able to use the default URL 9g) You should be able to trust the "Import target parameters" URL 9h) Write "OAI" for "Record matching rule code", if you added it earlier in the configuration steps 9i) Leave the "Action..." defaults... 9j) Change "Filter" to "file:///home/user/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/OAI2MARC21slim.xsl" 9k) Follow the same steps as above for sending the task to Icarus and telling Icarus to start it 9l) You can either watch Icarus's server output, or look at http://KOHA/cgi-bin/koha/tools/manage-marc-import.pl, or look directly at your database's "import_oai" and "biblio" tables to see how records are imported to Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 07:33:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 06:33:29 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #67 from David Cook --- Here's an updated version, which should actually work. Updates include: - Fixed atomic update and kohastructure.sql to actually include another needed table - Added link via admin-menu.inc and admin-home.tt - Added params for active tasks, and changed param display in saved_tasks.pl - Improved the logging, so the output from icarusd.pl will be a lot easier to read and hopefully more useful - Lots of internal changes which hopefully you won't notice on the user side --- Things I desperately want to update next: - Add OAI-PMH deletion support for svc/import_oai - Improve data validation for the plugins (especially web ui side) - Change Makefile.PL so you don't have to manually edit koha-conf.xml for Icarus config -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 07:52:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 06:52:09 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 07:52:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 06:52:23 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47962|0 |1 is obsolete| | --- Comment #11 from Josef Moravec --- Created attachment 48097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48097&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 07:52:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 06:52:30 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47963|0 |1 is obsolete| | --- Comment #12 from Josef Moravec --- Created attachment 48098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48098&action=edit Bug 15516 - Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 08:28:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 07:28:39 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 --- Comment #15 from Marcel de Rooy --- (In reply to M. Tompsett from comment #14) > See how I test in comment #10. I suppose putting in searchable data and > re-indexing and making sure it searches adequately should also be done, but > given that it starts and stops properly, I have no reason to doubt it would > suddenly break that way. Thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 09:45:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 08:45:31 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #20 from Jonathan Druart --- (In reply to David Cook from comment #18) > I'm using "my @param_names = CGI->param()" elsewhere and it doesn't generate warnings. Yes it does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 09:46:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 08:46:30 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 09:51:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 08:51:20 +0000 Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 --- Comment #17 from Jonathan Druart --- (In reply to Katrin Fischer from comment #16) > Do we need to take another look at this? Yes. Tomas, could you confirm that we don't need to disable this cache anymore? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 09:54:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 08:54:59 +0000 Subject: [Koha-bugs] [Bug 15819] Error when edit borrowers "There are no patron categories defined" but categories exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15819 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal Version|3.22 |master See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14637 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 09:54:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 08:54:59 +0000 Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15819 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 10:14:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 09:14:56 +0000 Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com --- Comment #1 from Jonathan Druart --- Hi Ian, Yes I have noticed that, and yes, it's caused by bug 15005. I have talked with Tomas about this bug but we have not found a solution yet. Thanks for reporting the bug anyway! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 10:29:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 09:29:51 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Hi Humberto, Could you give us the detail of the record matching this callnumber please? You certainly have a date starting with '0000-0' in your DB for this record, it would be good to know why one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 10:36:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 09:36:16 +0000 Subject: [Koha-bugs] [Bug 15820] suggestion.pl maximum internal redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15820 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |normal CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- This looks like an error in your apache config. How did you install Koha? Did you modify the apache config? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 10:44:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 09:44:28 +0000 Subject: [Koha-bugs] [Bug 15823] Can still access patron discharge slip without having the syspref on - Permissions breach In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15823 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- Hi Aleisha, It's still possible to generate a discharge even if the pref is off. For instance, you can get /cgi-bin/koha/members/discharge.pl?borrowernumber=42&discharge=1 And the pdf will be generated. Usually we check the additional permissions and prefs in the pl script. And either redirect to 404 or, more friendly, display an error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 10:46:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 09:46:03 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47968|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 48099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48099&action=edit Bug 5404: C4::Koha - remove subfield_is_koha_internal_p The commit b5ecefd485a75d54a5fa26fff5a0cc890541e2c3 Date: Mon Feb 3 18:46:00 2003 +0000 had a funny description: Added function to check if a MARC subfield name is "koha-internal" (instead of checking it for 'lib' and 'tag' everywhere); temporarily added to Koha.pm "Temporarily", since 2003, everything is relative, isn't it? :) The thing is that GetMarcStructure returns hash like field_200 => { subfield_a => { %attributes_of_subfield_a }, %attributes_of_field_200 } The attributes for field_200 can be 'repeatable', 'mandatory', 'tag', 'lib'. We don't want to loop on these values when looping on subfields. Since there are just { k => v } with v is a scalar (string), it's easier to test if we are processing a subfield testing the reference. At some places, we don't need to test that, we are looping on values from MARC::Field->subfields which are always valid subfields. Test plan: 1/ Edit items using the batch item mod tool 2/ display and edit items via the cataloguing module. You should not see any changes between before and after the patch applied. Tech notes: We need to check what we are processing when we loop on 'subfields' from GetMarcStructure, not from MARC::Field->subfields. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 10:46:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 09:46:36 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 10:59:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 09:59:45 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #40 from Jonathan Druart --- Note: This is just for display purpose, this new field is never used for sending notices to patrons. QA comment: - The second patch modifies "Other phone" with "Mobile phone". "Other phone" is used in master atm - The deletedborrowers table structure should be modified too - It would be good to let the user modify this value from the OPAC, don't you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:05:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:05:23 +0000 Subject: [Koha-bugs] [Bug 15829] Rotating Collections is under Patrons on Tools Home - Should be Catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:05:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:05:26 +0000 Subject: [Koha-bugs] [Bug 15829] Rotating Collections is under Patrons on Tools Home - Should be Catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48093|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48100&action=edit Bug 15829 - Rotating Collections is under Patrons on Tools Home - Should be Catalog To test: 1) Notice Rotating Collections is under Patrons & Circ on tools-home.pl 2) Apply patch and refresh page 3) Notice it is now under Catalog and is in the same position it is in on the tools sidebar menu Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:07:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:07:35 +0000 Subject: [Koha-bugs] [Bug 15827] Unfriendly message when saving overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15827 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:07:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:07:37 +0000 Subject: [Koha-bugs] [Bug 15827] Unfriendly message when saving overdue notice/status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15827 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48094|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48101&action=edit Bug 15827 - Unfriendly message when saving overdue notice/status triggers To test: 1) Go to Tools -> Overdue notice/status triggers 2) Click Save changes (you don't have to change anything) 3) Confirm message now says 'Changes saved.' which is much nicer Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:12:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:12:35 +0000 Subject: [Koha-bugs] [Bug 15219] Load checkouts table incrementally In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #5 from Julian Maurice --- Loading checkouts table incrementally takes more time to load all lines than to load them all at once, so I'll go with a classic paginated table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:23:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:23:44 +0000 Subject: [Koha-bugs] [Bug 15826] Use Font Awesome icons in confirmation dialogs - Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15826 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48092|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 48102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48102&action=edit Bug 15826 - Use Font Awesome icons in confirmation dialogs - Tools I only found one confirmation dialog, all the others use javascript. To test: Go to Tools -> Notices and Slips Click Delete on a notice Confirm Yes and No options still work as expected Check Tools module in case I missed any confirm dialogs Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:24:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:24:11 +0000 Subject: [Koha-bugs] [Bug 15826] Use Font Awesome icons in confirmation dialogs - Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15826 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:30:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:30:30 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:30:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:30:33 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48088|0 |1 is obsolete| | Attachment #48089|0 |1 is obsolete| | Attachment #48090|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 48103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48103&action=edit Bug 15714: Add get_loglevels to koha-functions.sh Preparing for including different log levels in koha-start-zebra. Note that the default response is none,fatal,warn; this is equal to the options passed to zebrasrv in koha-start-zebra (for now). Test plan: [1] Run on the command line: source koha-functions.sh [2] Type get_loglevels [your_instance] By default, you should see: none,fatal,warn [3] Add this line to your koha-conf: how,are,you [4] Run get_loglevels [your_instance] again. Remove the nonsense log levels again.. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:30:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:30:36 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 --- Comment #17 from Jonathan Druart --- Created attachment 48104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48104&action=edit Bug 15714: Remove zebra.log and add loglevels The file zebra.log is actually not used, because daemon's --output parameter sends all message to zebra-output (making that stdout goes there too and --stdout does nothing). We do not need any differentiation (if any at all) here; behavior does not change. Note: zebra-error will only contain the daemon's error messages and not the zebra error messages! So you will probably only find messages about stopping zebra in zebra-error. The loglevels are by default none,fatal,warn and can be changed via the zebra_loglevels config variable (read by koha-functions.sh). If you remove 'none', you will have request-messages in the log. You can also keep 'none' and add 'request' to achieve something similar (undocumented however). Some of the parameters passed to daemon when stopping zebra are superfluous and have been removed. Test plan: [1] Remove the file zebra.log. Look at last lines in zebra-error and zebra-output. [2] Remove zebra_loglevels from koha-conf (if present). Start/restart Zebra. Search to verify if Zebra runs. Stop Zebra and check zebra-error for a new line (killed by signal 15). [3] Add fatal,warn in koha-conf:zebra_loglevels (do not include 'none'). Start Zebra. Check zebra-output for a line "[log] zebra_start". Do a search and check zebra-output for lines with "[request]". [4] Verify that zebra.log did not appear again. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:30:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:30:39 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 --- Comment #18 from Jonathan Druart --- Created attachment 48105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48105&action=edit Bug 15714: Add zebra_loglevels to koha-conf.xml This patch adds a commented zebra_loglevels line to the config file. Behavior does not change, but an admin can easily edit the variable. Test plan: Nothing really changed. But if you are not so sure about that, apply the change to /etc/koha/koha-conf-site.xml.in and run koha-create. Check that the new koha-conf contains the line and is not messed up. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:33:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:33:19 +0000 Subject: [Koha-bugs] [Bug 15826] Use Font Awesome icons in confirmation dialogs - Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15826 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15785 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:33:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:33:19 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15826 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:33:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:33:23 +0000 Subject: [Koha-bugs] [Bug 14712] Feature for controlling cron jobs/cmd line scripts from staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14712 --- Comment #3 from Eivin Giske Skaaren --- Hi David, I did some initial work on this but it was abandoned for now because of the security aspect. Exposing root shell via CGI might not be a good idea. If you have a good solution that also perhaps solves some of the things that we wanted to solve with this I would be happy to test/sign-off your patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:33:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:33:24 +0000 Subject: [Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48091|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 48106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48106&action=edit Bug 15830 - Move Rotating Collections actions into a drop-down list To test: 1) Go to Tools -> Rotating Collections 2) Confirm actions (Add or remove items, Transfer, Edit, Delete) have moved into a drop down menu 3) Confirm all of the actions work as expected Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:33:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:33:34 +0000 Subject: [Koha-bugs] [Bug 15219] Load checkouts table incrementally In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #6 from Julian Maurice --- Created attachment 48107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48107&action=edit Bug 15219: Server-side processing and pagination on checkouts tables Some libraries have patrons with more than 1000 checkouts. Loading all of them at once can be very long, and sometimes can cause timeout errors. This patch prevent that by enabling server-side processing and pagination on checkouts tables. This affects patron's checkouts and patron's relatives' checkouts tables on pages circ/circulation.pl and members/moremember.pl. As server-side processing can be useless and cumbersome with small sets of data, a new system preference is introduced to control this behaviour (server-side processing is disabled by default). Additionally, this patch: - adds a switch to turn off and on row grouping (today's checkouts vs previous checkouts) (on by default) - adds "column settings" for relatives' checkouts tables - factorize some code that was duplicated across the two DataTables configurations (mDataProp) Test plan: 1. Find (or create) a patron that have at least 10 checkouts and where the relatives checkouts table contain at least 10 checkouts. 2. Go to the patron's detail page and check everything works fine in both tables (sorting, pagination, the data itself, ...) 3. Do the same on circulation page (circulation.pl) 4. Enable system preference ServerSideCheckoutsTable 5. Repeat steps 2 and 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:34:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:34:01 +0000 Subject: [Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:34:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:34:10 +0000 Subject: [Koha-bugs] [Bug 15219] Load checkouts table incrementally In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45018|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:34:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:34:19 +0000 Subject: [Koha-bugs] [Bug 15219] Load checkouts table incrementally In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45036|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:34:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:34:30 +0000 Subject: [Koha-bugs] [Bug 15219] Load checkouts table incrementally In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45054|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:34:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:34:54 +0000 Subject: [Koha-bugs] [Bug 15219] Load checkouts table incrementally In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:35:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:35:33 +0000 Subject: [Koha-bugs] [Bug 15826] Use Font Awesome icons in confirmation dialogs - Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15826 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15785 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15785 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:35:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:35:33 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15826 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15826 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15826 [Bug 15826] Use Font Awesome icons in confirmation dialogs - Tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:36:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:36:15 +0000 Subject: [Koha-bugs] [Bug 15656] Move the guarantor/guarantees code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47267|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 48108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48108&action=edit Bug 15656: Move guarantor/guarantees code - GetGuarantees 2 subroutines of C4::Members deal with guarantor/guarantees: GetGuarantees and GetMemberRelatives. Since we already have a Koha::Patron->guarantor method, it makes sense to move these 2 subroutines to this module. This first patch deals with GetGuarantees. Test plan for the entire patch set: 1/ Create 5 patrons A (adult), B (child), C (child), D (child), E (child), F (adult) 2/ Add relation between them: A is father of B, C and D. E does not have a guarantor F does not have guarantees 3/ Check some items out for all of these patrons 4/ On the "Check out" and "Details" tabs, you should not see any differences with these patch applied : The "Relatives' checkouts" tabs should list all of the guarantor/guarantee/siblings checkouts Note: $template->param('C' => 1); I have not found any reference of this 'C' in the template. It seems it's an old c/p from members/memberentrygen.tt Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:36:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:36:22 +0000 Subject: [Koha-bugs] [Bug 15826] Use Font Awesome icons in confirmation dialogs - Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15826 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:36:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:36:22 +0000 Subject: [Koha-bugs] [Bug 15656] Move the guarantor/guarantees code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47268|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 48109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48109&action=edit Bug 15656: Move guarantor/guarantees code - GetMemberRelatives Note: QA question: Does the Koha::Patron->siblings method should return undef if there is no guarantor? It would avoid the weird != undef, = $borrowernumber conditions. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:36:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:36:25 +0000 Subject: [Koha-bugs] [Bug 15826] Use Font Awesome icons in confirmation dialogs - Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15826 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48102|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48110&action=edit Bug 15826 - Use Font Awesome icons in confirmation dialogs - Tools I only found one confirmation dialog, all the others use javascript. To test: Go to Tools -> Notices and Slips Click Delete on a notice Confirm Yes and No options still work as expected Check Tools module in case I missed any confirm dialogs Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:36:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:36:45 +0000 Subject: [Koha-bugs] [Bug 15656] Move the guarantor/guarantees code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:37:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:37:37 +0000 Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Load checkouts table |Server-side processing and |incrementally |pagination on checkouts | |tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:40:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:40:25 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |josef.moravec at gmail.com --- Comment #9 from Josef Moravec --- Could you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:46:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:46:37 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart --- FAIL C4/Members/AttributeTypes.pm FAIL pod *** ERROR: Spurious =cut command in file C4/Members/AttributeTypes.pm FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt FAIL forbidden patterns forbidden pattern: merge marker (=======) (line 953) forbidden pattern: merge marker (<<<<<<<) (line 937) forbidden pattern: merge marker (>>>>>>>) (line 971) There are also debug warns, please remove them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 11:48:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 10:48:48 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 12:09:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 11:09:09 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47103|0 |1 is obsolete| | Attachment #47104|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 48111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48111&action=edit Bug 15548: Move new patron related code to Patron* The 'borrower' should not be used anymore, especially for new code. This patch move files and rename variables newly pushed (i.e. in the Koha namespace). Test plan: 1/ git grep Koha::Borrower should not return code in use. 2/ Prove the different modified test files 3/ Do some clicks in the member^Wpatron module to be sure there is not an obvious error. Signed-off-by: Hector Castro Works as described. Tested with Circulation, Members/Patrons, Discharge, Restrictions modules and the must common functionalities Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 12:09:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 11:09:12 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #18 from Jonathan Druart --- Created attachment 48112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48112&action=edit Bug 15548 [QA Followup] - Catch a couple new Koha::Borrower uses Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 12:09:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 11:09:30 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #19 from Jonathan Druart --- Just another rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 12:15:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 11:15:30 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 12:15:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 11:15:32 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47122|0 |1 is obsolete| | Attachment #47124|0 |1 is obsolete| | Attachment #47125|0 |1 is obsolete| | Attachment #47126|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 48113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48113&action=edit Bug 15635: Koha::Patron::Images - Add new classes There are 3 subroutines in C4::Members to get, add and delete patron images: - GetPatronImage - PutPatronImage - RmPatronImage By creating these 2 Koha::Patron::Image[s] classes, we could remove them easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 12:15:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 11:15:36 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #11 from Jonathan Druart --- Created attachment 48114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48114&action=edit Bug 15635: Koha::Patron::Images - Remove PutPatronImage The C4::Members::PutPatronImage inserted/updated the image of a patron. This can be done easily with ->find->set->store or ->new->store Test plan: 1/ Modify the image of a patron from the patron detail page 2/ Add an image to a new patron 3/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add or modify the image of a patron 4/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add or modify the image of several patrons, using a zip file. Stress the script trying to get as many errors as possible (wrong cardnumber, wrong mimetype, file does not exist, etc.) With this patch, if the cardnumber does not exist, you will get a specific error "Image not imported because this patron does not exist in the database" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 12:15:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 11:15:43 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #13 from Jonathan Druart --- Created attachment 48116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48116&action=edit Bug 15635: Koha::Patron::Images - Remove GetPatronImage To retrieve a patron image, we can call Koha::Patron::Images->find or Koha::Patrons->find->image Both will return a Koha::Patron::Image object. Test plan: 1/ From the patron/member module, open all tabs on the left (Checkouts, detail, fines, etc.) The image should be correctly displayed. 2/ At the OPAC, on the patron details page (opac-memberentry.pl) the image should be displayed as well. 3/ Same on the sco module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 12:15:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 11:15:39 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #12 from Jonathan Druart --- Created attachment 48115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48115&action=edit Bug 15635: Koha::Patron::Images - Remove RmPatronImage The C4::Members::RmPatronImage just removed a row in patronimage. This can be accomplished using the delete method of Koha::Patron::Image. Test plan: >From the patron defail page, try to delete the image of a patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 12:15:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 11:15:46 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #14 from Jonathan Druart --- Created attachment 48117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48117&action=edit Bug 15635: Change method type to _type for bug 15446 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 12:16:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 11:16:22 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15548 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 [Bug 15548] New patron related code should have been put to Patron instead of Borrower -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 12:16:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 11:16:22 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15635 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 [Bug 15635] Move the patron images related code to Koha::Patron::Images -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 12:37:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 11:37:11 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #14 from Jonathan Druart --- Hi Nick, I am sorry but I don't understand your last patch. I was referring to this code from additem.pl: 455 # if autoBarcode is set to 'incremental', calculate barcode... 456 if ( C4::Context->preference('autoBarcode') eq 'incremental' ) { 457 $record = _increment_barcode($record, $frameworkcode); 458 } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 12:40:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 11:40:37 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Jonathan Druart --- Ha yes ok, got it! You the previous item is not inserted, then the barcode cannot be generated. Maybe we could display a value in the barcode field to tell the user it will be auto-generated on saving. I would like to avoid a JS function to calculate the next barcode, we already have perl subroutines to do this job. Katrin, could I get your opinion please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 12:48:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 11:48:00 +0000 Subject: [Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15534 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 12:48:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 11:48:00 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15533 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 [Bug 15533] Allow patrons and librarians to select itemtype when placing hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 13:09:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 12:09:52 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Srdjan, koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 383 +++++++++++++++++++- This is wrong, opac.css should contain only 1 line and be generated from the less file. See https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 13:11:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 12:11:03 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #16 from Katrin Fischer --- Auto-generating on saving sounds good to me - showing a note if AutoBarcode is active? The other alternative would probably be to add the item immediately in the background, but not sure that's worth the trouble right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 13:18:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 12:18:04 +0000 Subject: [Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Hi Aleisha, If you want to use DataTables on this table, you should make it a valid table html element. It should contain thead and tbody. Moverover, the line: + { "aTargets": [ -1, -2, -3, -4 ], "bSortable": false, "bSearchable": false }, means: Do not allow to sort on the last 4 columns. It's not what you want, you only want to remove the sort on the last column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 13:26:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 12:26:32 +0000 Subject: [Koha-bugs] [Bug 15768] koha-news.pl Deep Recursion ERROR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15768 --- Comment #3 from Humberto Blanco --- after adjust the environment variable sql_mode, works fine. the version of mysql is 5.27 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 13:27:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 12:27:40 +0000 Subject: [Koha-bugs] [Bug 15819] Error when edit borrowers "There are no patron categories defined" but categories exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15819 Humberto Blanco changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:04:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:04:56 +0000 Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15768 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:04:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:04:56 +0000 Subject: [Koha-bugs] [Bug 15819] Error when edit borrowers "There are no patron categories defined" but categories exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15819 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15768 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:04:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:04:56 +0000 Subject: [Koha-bugs] [Bug 15768] koha-news.pl Deep Recursion ERROR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15768 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14637, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15819 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:18:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:18:46 +0000 Subject: [Koha-bugs] [Bug 15820] suggestion.pl maximum internal redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15820 --- Comment #2 from Humberto Blanco --- (In reply to Jonathan Druart from comment #1) > This looks like an error in your apache config. > How did you install Koha? Did you modify the apache config? I have the same like the bug 15768, in koha news, Koha create 6 new records with the same notice in my httpd.conf i not have this preference enable . -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:19:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:19:44 +0000 Subject: [Koha-bugs] [Bug 12549] Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48037|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 48118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48118&action=edit Bug 12549: Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems Allows for selection of DejaVu font path when installing from the command line. This is useful for non-debian distributions that don't store the fonts in the same place. Adds a new configuration variable to Makefile.PL: FONT_DIR Defaults to the Debian install location for the fonts. Test plan: 1. Run a CLI install, accepting the defaults. 2. Compare the generated koha-conf.xml to a previous install - the font path for DejaVu fonts should be the same. 3. Run another CLI install, this time choosing a custom path for the fonts 4. Check that the path selected is reflected in the koha-conf.xml file. NOTE: 'perl Makefile.pl' and 'make' generates blib/KOHA_CONF_DIR/koha-conf.xml ran with a weird string for the font dir copied that koha-conf.xml to my home dir reran with all defaults compared the two, and only the font paths differed. Also, I cleaned up the tabs that snuck in. :) Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:19:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:19:51 +0000 Subject: [Koha-bugs] [Bug 12549] Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549 --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 48119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48119&action=edit Bug 12549: (QA followup) missing newline in CLI dialog Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:26:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:26:03 +0000 Subject: [Koha-bugs] [Bug 12549] Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Tom?s Cohen Arazi --- I don't think is necessary to add placeholders for font path into the packages template right now. In the mid term the packages-way should be integrated into the source install so we should have a single file to maintain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:27:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:27:09 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #15 from Josef Moravec --- I tested these patches and they work fine for me. I found just few issues: when I tried to upload "bad" file (pdf, too big jpg, etc.), the file is not uploaded (of course) but no error message appears... Also I wasn't able to see "Image not imported because this patron does not exist in the database" error message. Maybe I'm doing something wrong... there are error messages in templates as I can see... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:27:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:27:24 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:29:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:29:09 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 --- Comment #2 from Humberto Blanco --- (In reply to Jonathan Druart from comment #1) > Hi Humberto, > Could you give us the detail of the record matching this callnumber please? > You certainly have a date starting with '0000-0' in your DB for this record, > it would be good to know why one. I dont know exactly what are you talking, can be a little more specific please, this was after migration to 3.22 from 3.08.006. I?m adding a image of one of those records that have "340.11" in call number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:30:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:30:18 +0000 Subject: [Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:31:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:31:27 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 --- Comment #3 from Humberto Blanco --- Created attachment 48121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48121&action=edit Image for one of those record width "340.11" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:43:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:43:16 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 --- Comment #6 from Jonathan Druart --- Created attachment 48122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48122&action=edit Bug 15736: Add ShowAllCheckins pref to control the display of checked-in item list on checking Bug 14821 removed the items which were not checked out, but some libraries considered it as a bug. So let's add a new pref to control this behavior. Test plan: 0/ Execute the updatedb entry and set ShowAllCheckins to "Do not show" (default) 1/ Check an item in. If the item was not checked out, it won't be listed 2/ Turn the pref to "Show" 3/ Check an item in If the item was not checked out, it should be listed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:43:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:43:28 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:44:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:44:29 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #10 from Josef Moravec --- Could you rebase please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:50:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:50:06 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #16 from Jonathan Druart --- (In reply to Josef Moravec from comment #15) > I tested these patches and they work fine for me. I found just few issues: > when I tried to upload "bad" file (pdf, too big jpg, etc.), the file is not > uploaded (of course) but no error message appears... Also I wasn't able to > see "Image not imported because this patron does not exist in > the database" error message. > > Maybe I'm doing something wrong... there are error messages in templates as > I can see... Did you test without this patchset? Just to know if I have to submit follow-ups or open a new bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:53:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:53:33 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 --- Comment #4 from Jonathan Druart --- Could you export the record and attach it to the bug report. Then execute, in your sql cli: SELECT * FROM biblio WHERE biblionumber=YOUR_BIBLIONUMBER and post the result here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:55:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:55:58 +0000 Subject: [Koha-bugs] [Bug 15820] suggestion.pl maximum internal redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15820 --- Comment #3 from Jonathan Druart --- Could you confirm that the error still exists after you have modified the sql_mode mysql variable? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 14:59:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 13:59:53 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48122|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 48123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48123&action=edit Bug 15736: Add ShowAllCheckins pref to control the display of checked-in item list on checking Bug 14821 removed the items which were not checked out, but some libraries considered it as a bug. So let's add a new pref to control this behavior. Test plan: 0/ Execute the updatedb entry and set ShowAllCheckins to "Do not show" (default) 1/ Check an item in. If the item was not checked out, it won't be listed 2/ Turn the pref to "Show" 3/ Check an item in If the item was not checked out, it should be listed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:04:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:04:41 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:04:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:04:43 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48123|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 48124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48124&action=edit Bug 15736: Add ShowAllCheckins pref to control the display of checked-in item list on checking Bug 14821 removed the items which were not checked out, but some libraries considered it as a bug. So let's add a new pref to control this behavior. Test plan: 0/ Execute the updatedb entry and set ShowAllCheckins to "Do not show" (default) 1/ Check an item in. If the item was not checked out, it won't be listed 2/ Turn the pref to "Show" 3/ Check an item in If the item was not checked out, it should be listed Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:05:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:05:06 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48080|0 |1 is obsolete| | --- Comment #19 from R?mi Mayrand-Provencher --- Created attachment 48125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48125&action=edit Bug 8609 - Add an URL validation plugin for authority and biblio frameworks This patch adds a new validation plugin to validate that a field/subfield contains a valid url. This plugin that can be used in biblio and authority frameworks. Testing: I) Before applying: 0) Go to the Cataloging module: menu->More->Cataloging; 1) Click < default framework>> bouton; 2) Click tab << 8 >>; 3) Insert a text (for example "test") in the 856->u input field; 4) Click out of the input field; 5) Validate no message; II) After Applying: i) field/subfield plugin attach 0) In Koha adminstration, click << MARC bibliographic framework >>; 1) In Default framework, click << MARC structure >>; 2) Search field 856 and click << Subfields >>; 3) Click << u >>; 4) In Other options -> Plugin, choose url.pl ii) Insert a text in the 856->u input field 0) Go to the Cataloging module: menu->More->Cataloging; 1) Click < default framework>> bouton; 2) Click tab << 8 >>; 3) Insert a text (for example "test") in the 856->u input field; 4) Click out of the input field; 5) Validate message: << The field 856$u must contain a valid URL! ex : http://www.google.com >> Squashed all previous commits into one as asked by comment #15. I did not see any changes made to the database so I didn't change anything related to that. Bug8609 - Removed useless plugin_parameters sub bug8609 fixes for comment #15 and #16 bug8609 Use Modern::Perl instead of strict and warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:10:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:10:39 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 --- Comment #22 from Tom?s Cohen Arazi --- Created attachment 48126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48126&action=edit Bug 11081: (followup) Rebuild debian/control Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:11:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:11:04 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:11:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:11:18 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:11:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:11:27 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:12:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:12:06 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #23 from Tom?s Cohen Arazi --- Brendan and Galen, this patch should update the deps. I put it here just in case you didn't rebuild the control file yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:13:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:13:20 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:13:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:13:54 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46878|0 |1 is obsolete| | Attachment #46879|0 |1 is obsolete| | Attachment #46880|0 |1 is obsolete| | Attachment #46881|0 |1 is obsolete| | Attachment #46883|0 |1 is obsolete| | Attachment #46884|0 |1 is obsolete| | --- Comment #91 from Jonathan Druart --- Created attachment 48127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48127&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud bsoletes: 46882 - Bug 8352 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:14:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:14:00 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #92 from Jonathan Druart --- Created attachment 48128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48128&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:14:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:14:05 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #93 from Jonathan Druart --- Created attachment 48129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48129&action=edit Bug 8352 [QA Followup] - Fix column type in kohastructure.sql Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:14:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:14:10 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #94 from Jonathan Druart --- Created attachment 48130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48130&action=edit Bug 8352 [QA Followup] - Don't use SQL in pl files Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:14:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:14:15 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46882|0 |1 is obsolete| | --- Comment #95 from Jonathan Druart --- Created attachment 48131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48131&action=edit Bug 8352 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:14:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:14:21 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #96 from Jonathan Druart --- Created attachment 48132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48132&action=edit Bug 8352 [QA Followup] - Notices for translation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:14:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:14:25 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #97 from Jonathan Druart --- Created attachment 48133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48133&action=edit Bug 8352 [QA Followup] - Remove use of HTML::HTMLDoc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:15:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:15:57 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #98 from Jonathan Druart --- Patches rebased, conflicts in notices sql files fixed! QA comments: 1/ FAIL Koha/Printer.pm FAIL critic "$pdf_data" is declared but not used at line 61, column 9. Unused variables clutter code and make it harder to read. 2/ What's the status of the NET::Printer lib? It's not packaged already. Kyle, did you try to package it? Failing QA for 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:18:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:18:49 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #99 from Jonathan Druart --- Created attachment 48134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48134&action=edit Bug 8352: Fix perlcritic '$pdf_data' is declared but not used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:18:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:18:55 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #100 from Jonathan Druart --- Created attachment 48135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48135&action=edit Bug 8352: Fix type vs _type for bug 15446 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:19:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:19:18 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #101 from Jonathan Druart --- (In reply to Jonathan Druart from comment #98) > Patches rebased, conflicts in notices sql files fixed! > > QA comments: > 1/ > FAIL Koha/Printer.pm > FAIL critic > "$pdf_data" is declared but not used at line 61, column 9. > Unused variables clutter code and make it harder to read. Ok fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:23:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:23:03 +0000 Subject: [Koha-bugs] [Bug 15821] Use Font Awesome icons in confirmation dialogs - Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15785 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:23:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:23:03 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 [Bug 15821] Use Font Awesome icons in confirmation dialogs - Circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:26:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:26:35 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48113|0 |1 is obsolete| | --- Comment #17 from Josef Moravec --- Created attachment 48136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48136&action=edit Bug 15635: Koha::Patron::Images - Add new classes There are 3 subroutines in C4::Members to get, add and delete patron images: - GetPatronImage - PutPatronImage - RmPatronImage By creating these 2 Koha::Patron::Image[s] classes, we could remove them easily. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:26:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:26:39 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48114|0 |1 is obsolete| | --- Comment #18 from Josef Moravec --- Created attachment 48137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48137&action=edit Bug 15635: Koha::Patron::Images - Remove PutPatronImage The C4::Members::PutPatronImage inserted/updated the image of a patron. This can be done easily with ->find->set->store or ->new->store Test plan: 1/ Modify the image of a patron from the patron detail page 2/ Add an image to a new patron 3/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add or modify the image of a patron 4/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add or modify the image of several patrons, using a zip file. Stress the script trying to get as many errors as possible (wrong cardnumber, wrong mimetype, file does not exist, etc.) With this patch, if the cardnumber does not exist, you will get a specific error "Image not imported because this patron does not exist in the database" Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:26:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:26:45 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48115|0 |1 is obsolete| | --- Comment #19 from Josef Moravec --- Created attachment 48138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48138&action=edit Bug 15635: Koha::Patron::Images - Remove RmPatronImage The C4::Members::RmPatronImage just removed a row in patronimage. This can be accomplished using the delete method of Koha::Patron::Image. Test plan: >From the patron defail page, try to delete the image of a patron. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:26:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:26:53 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48116|0 |1 is obsolete| | --- Comment #20 from Josef Moravec --- Created attachment 48139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48139&action=edit Bug 15635: Koha::Patron::Images - Remove GetPatronImage To retrieve a patron image, we can call Koha::Patron::Images->find or Koha::Patrons->find->image Both will return a Koha::Patron::Image object. Test plan: 1/ From the patron/member module, open all tabs on the left (Checkouts, detail, fines, etc.) The image should be correctly displayed. 2/ At the OPAC, on the patron details page (opac-memberentry.pl) the image should be displayed as well. 3/ Same on the sco module. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:27:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:27:01 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48117|0 |1 is obsolete| | --- Comment #21 from Josef Moravec --- Created attachment 48140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48140&action=edit Bug 15635: Change method type to _type for bug 15446 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:27:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:27:21 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:29:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:29:27 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #22 from Josef Moravec --- (In reply to Jonathan Druart from comment #16) > (In reply to Josef Moravec from comment #15) > > I tested these patches and they work fine for me. I found just few issues: > > when I tried to upload "bad" file (pdf, too big jpg, etc.), the file is not > > uploaded (of course) but no error message appears... Also I wasn't able to > > see "Image not imported because this patron does not exist in > > the database" error message. > > > > Maybe I'm doing something wrong... there are error messages in templates as > > I can see... > > Did you test without this patchset? > Just to know if I have to submit follow-ups or open a new bug report. I've just tested it on clean master and there is the same issue. So as it looks that it's not related with these patches, I'm signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:40:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:40:14 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #24 from Josef Moravec --- Could you rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:55:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:55:58 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 15:56:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 14:56:54 +0000 Subject: [Koha-bugs] [Bug 15831] New: Can't override renew limit by submitting a barcode in checkout with AllowRenewalLimitOverride on Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15831 Bug ID: 15831 Summary: Can't override renew limit by submitting a barcode in checkout with AllowRenewalLimitOverride on Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If I have AllowRenewalLimitOverride set to "Allow," I should be able to scan a barcode in checkout and be prompted to override the renewal limit. That's how it works on the renewal page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 16:09:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 15:09:45 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Can we get a test plan for this patch? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 16:30:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 15:30:03 +0000 Subject: [Koha-bugs] [Bug 15832] New: Pending reserves: duplicates branches in datatable filter Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Bug ID: 15832 Summary: Pending reserves: duplicates branches in datatable filter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In the datatable of pending reserves, if a title has several branches, this cause duplicates in the filter select. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 16:32:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 15:32:24 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #116 from Kyle M Hall --- Pushed to Master - Should be in the May 2016 3.24 release! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 16:34:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 15:34:44 +0000 Subject: [Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 --- Comment #1 from Alex Arnaud --- Created attachment 48141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48141&action=edit Bug 15832 - Fix items split-up in pendingreserves.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 16:36:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 15:36:34 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #20 from Kyle M Hall --- Created attachment 48142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48142&action=edit Bug 15548 [QA Followup] - More new uses of Koha::Borrower Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 16:41:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 15:41:01 +0000 Subject: [Koha-bugs] [Bug 15821] Use Font Awesome icons in confirmation dialogs - Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- Everything looks good except these issues: - The "Cancel checkout and place hold" button isn't working for me. Nothing happens when I click it. - On the batch checkout screen, I don't think it is consistent to add an icon to that button. At this time we don't have a standard of adding icons to every submit button. - Missing closing bracket on line 52 of renew.tt: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 16:41:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 15:41:13 +0000 Subject: [Koha-bugs] [Bug 15821] Use Font Awesome icons in confirmation dialogs - Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 16:46:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 15:46:36 +0000 Subject: [Koha-bugs] [Bug 15833] New: Bad variable value in renewal template confirmation dialog Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Bug ID: 15833 Summary: Bad variable value in renewal template confirmation dialog Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/renew.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart at bugs.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On renew.pl, the confirmation dialog which appears when you have successfully renewed something includes a link to the item, but a bad value is being passed to the template as part of that link: /cgi-bin/koha/catalogue/moredetail.pl?itemnumber=11157&biblionumber=5433&bi=Koha::Schema::Result::Biblioitem=HASH(0x8a58338)#item11157 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 17:00:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 16:00:40 +0000 Subject: [Koha-bugs] [Bug 15833] Bad variable value in renewal template confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 17:00:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 16:00:42 +0000 Subject: [Koha-bugs] [Bug 15833] Bad variable value in renewal template confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 --- Comment #1 from Jonathan Druart --- Created attachment 48143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48143&action=edit Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object 2 links are wrong on the renew page, because item.biblioitemnumber does not return the biblioitemnumber as expect the template. Test plan: Renew an item and check the item link. It should contain a valid biblioitemnumber for the 'bi' parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 17:34:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 16:34:28 +0000 Subject: [Koha-bugs] [Bug 15817] Checkboxes for renewing items missing in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- There ARE checkboxes, I am just blind :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 17:55:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 16:55:05 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 17:55:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 16:55:10 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48124|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 48144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48144&action=edit Bug 15736: Add ShowAllCheckins pref to control the display of checked-in item list on checking Bug 14821 removed the items which were not checked out, but some libraries considered it as a bug. So let's add a new pref to control this behavior. Test plan: 0/ Execute the updatedb entry and set ShowAllCheckins to "Do not show" (default) 1/ Check an item in. If the item was not checked out, it won't be listed 2/ Turn the pref to "Show" 3/ Check an item in If the item was not checked out, it should be listed Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 17:55:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 16:55:26 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 --- Comment #10 from Kyle M Hall --- Created attachment 48145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48145&action=edit Bug 15736 [QA Followup] - Make add more details to the syspref description Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 17:57:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 16:57:18 +0000 Subject: [Koha-bugs] [Bug 15833] Bad variable value in renewal template confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 17:57:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 16:57:20 +0000 Subject: [Koha-bugs] [Bug 15833] Bad variable value in renewal template confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48143|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 48146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48146&action=edit [SIGNED-OFF] Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object 2 links are wrong on the renew page, because item.biblioitemnumber does not return the biblioitemnumber as expect the template. Test plan: Renew an item and check the item link. It should contain a valid biblioitemnumber for the 'bi' parameter. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 18:00:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 17:00:02 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 David Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |techservspec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 18:20:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 17:20:38 +0000 Subject: [Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 18:20:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 17:20:41 +0000 Subject: [Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48083|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 48147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48147&action=edit [SIGNED-OFF] Bug 15824 - 'Done' button is unclear on batch item modification and deletion To test: MODIFICATION 1) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 2) Click edit -> Edit items in a batch 3) Click Save (you don't need to make any changes) 4) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 5) Go to a biblio record page 6) Select one or some or all items in the record 7) Click modify selected items 8) Click Save 9) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 10) Go to batch item modification (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl) 11) Write some barcodes into the barcode list and click Continue 12) Click Save 13) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item mod page. DELETION 14) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 15) Click edit -> Delete items in a batch 16) Unselect all the items so you don't actually delete them, then click Delete selected items 17) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 18) Go to a biblio record page 19) Select one or some or all items in the record 20) Click Delete selected items 21) Unselect all the items so you don't actually delete them, then click Delete selected items 22) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 23) Go to batch item deletion (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl?del=1) 24) Write some barcodes into the barcode list and click Continue 25) Unselect all the items so you don't actually delete them, then click Delete selected items 26) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item deletion page. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 18:22:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 17:22:08 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 --- Comment #11 from Heather Braum --- I know Kyle has already passed QA, but at Nick's encouragement, I put this on a sandbox and gave it a second look, following the test plan. Everything looks good. Thanks Jonathan, so much, for getting this written. You have my many thanks today for this and saved me lots of grief with all my librarians when we upgrade in less than two weeks to 3.22. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 18:24:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 17:24:43 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 --- Comment #20 from Marcel de Rooy --- Why not use the new style for plugins? See EXAMPLE.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 18:29:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 17:29:21 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #21 from Marc V?ron --- In C4/Installer/PerlDependencies.pm, Regexp::Common::URI is not marked as required. Should it be marekd as required? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 18:31:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 17:31:24 +0000 Subject: [Koha-bugs] [Bug 15828] Upload patron images is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15828 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |oleonard at myacpl.org Status|NEW |ASSIGNED Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 18:38:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 17:38:48 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #22 from H?ctor Eduardo Castro Avalos --- (In reply to R?mi Mayrand-Provencher from comment #19) Hi R?mi and others I applied the patch and works as expected. You're right about my previous comment 15: > > Could be great if you include changes in SQL frameworks for fresh > installations and update database > for frameworks > already installed. > 856$u in marc_subfield_structure can share this plugin and upload.pl plugin (bug 6874) But also we can leave one of them by default, changing this: installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql > ('856', 'u', 'Uniform Resource Identifier', 'Uniform Resource Identifier', 1, 0, 'biblioitems.url', 8, '', '', 'url.pl', 1, 0, '', '', '', NULL), AND installer/data/mysql/atomicupdate/bug_8609_mychange.sql >-- add url.pl to value_builder for marc_subfield_structure in 856$u >UPDATE marc_subfield_structure SET value_builder='url.pl' WHERE tagfield='856' and tagsubfield='u'; Please give me a positive feedback Regads -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 19:04:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 18:04:26 +0000 Subject: [Koha-bugs] [Bug 15828] Upload patron images is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15828 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 19:04:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 18:04:29 +0000 Subject: [Koha-bugs] [Bug 15828] Upload patron images is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15828 --- Comment #1 from Owen Leonard --- Created attachment 48148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48148&action=edit Bug 15828 - Upload patron images is hard to read The styling of the patron image upload form causes the text to be smaller than it should be for the main body of a page. This patch revises the form style and cleans up the markup a bit. This patch also adds client-side validation of the form so that a file upload is required, and a card number is required if an image file is selected. To test, apply the patch and go to Tools -> Upload patron images. 1. Confirm that the text in the form is the correct size. 2. With "Zip file" selected, confirm that submitting the form is blocked and the file upload marked as required. 3. With "Image file" selected, confirm that submitting the form with an empty card number field is blocked and the card number field is marked as required. 4. Confirm that uploading zip files and single images still works correctly. https://bugs.koha-community.org/show_bug.cgi?id=15282 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 19:58:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 18:58:37 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Brendan Gallagher --- Pushed the followup - Thanks! Should be in the May 2016 release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 20:29:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 19:29:24 +0000 Subject: [Koha-bugs] [Bug 15698] Include MARCMaker to export options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15698 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #5 from Fr?d?ric Demians --- (In reply to H?ctor Eduardo Castro Avalos from comment #0) > Sometimes the librarian want a way to harvest a few records not recorded in > Z39.50 databases also they want to obtain and manage a versatile format > supported in MARCEdit or MARCMaker. > > Koha doesn't have support to export in MARCMaker. This feature is very > useful to librarian whom are accustomed to use it especially in MARCEdit > software. As far as I know, MARCMaker is format which isn't used in the Unimarc-world. It seems to be an old and outdated tool. Don't you think so? Is it really still used? Doesn't MARCEdit support ISO2709 format? And there if I recall properly, there is already a link Koha-MARCEdit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 20:31:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 19:31:35 +0000 Subject: [Koha-bugs] [Bug 15698] Include MARCMaker to export options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15698 --- Comment #6 from Fr?d?ric Demians --- (In reply to H?ctor Eduardo Castro Avalos from comment #3) > Add UNIMARC to MARC21 transformation Such a simplistic conversion via XSLT could make sense when used during Z39.50 importation process, because a cataloguer will reformat the result into valid MARC21. Otherwise, with this manual pass, it's necessarily a mess. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 20:44:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 19:44:01 +0000 Subject: [Koha-bugs] [Bug 15698] Include MARCMaker to export options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15698 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|ASSIGNED |RESOLVED --- Comment #7 from H?ctor Eduardo Castro Avalos --- Thank you for your reply Fr?d?ric, looking your point of view I will close this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 20:56:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 19:56:52 +0000 Subject: [Koha-bugs] [Bug 15828] Upload patron images is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15828 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 20:56:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 19:56:54 +0000 Subject: [Koha-bugs] [Bug 15828] Upload patron images is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15828 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48148|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 48149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48149&action=edit [SIGNED-OFF]Bug 15828: Upload patron images is hard to read The styling of the patron image upload form causes the text to be smaller than it should be for the main body of a page. This patch revises the form style and cleans up the markup a bit. This patch also adds client-side validation of the form so that a file upload is required, and a card number is required if an image file is selected. To test, apply the patch and go to Tools -> Upload patron images. 1. Confirm that the text in the form is the correct size. 2. With "Zip file" selected, confirm that submitting the form is blocked and the file upload marked as required. 3. With "Image file" selected, confirm that submitting the form with an empty card number field is blocked and the card number field is marked as required. 4. Confirm that uploading zip files and single images still works correctly. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 21:47:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 20:47:30 +0000 Subject: [Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 21:47:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 20:47:33 +0000 Subject: [Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48106|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 48150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48150&action=edit Bug 15830 - Move Rotating Collections actions into a drop-down list To test: 1) Go to Tools -> Rotating Collections 2) Confirm actions (Add or remove items, Transfer, Edit, Delete) have moved into a drop down menu 3) Confirm all of the actions work as expected Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 21:48:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 20:48:34 +0000 Subject: [Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48150|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 48151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48151&action=edit Bug 15830 - Move Rotating Collections actions into a drop-down list To test: 1) Go to Tools -> Rotating Collections 2) Confirm actions (Add or remove items, Transfer, Edit, Delete) have moved into a drop down menu 3) Confirm all of the actions work as expected Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 22:19:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 21:19:37 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #5 from H?ctor Eduardo Castro Avalos --- 082 field isn't indexed. Line 164 to 168 in ccl.properties #Classification-Dewey 13 A classification number from 082 # the Dewey Decimal # Classification, developed by # Melvyl Dewey. #Dewey-classification 1=13 When you search under Callnumber in advanced search the index used is 952$o callnum or Local-classification Like Jonathan comment maybe you have a date starting with 000-00 in another 952 field or Holding field. I recommend you search in all bibliographic record (Leader/008) and holding data to see if you have invalid dates Saludos Humberto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 22:27:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 21:27:46 +0000 Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables server-side processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 22:27:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 21:27:48 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 22:41:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 21:41:24 +0000 Subject: [Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- "Koha instance is empty, no staff user created." -- Oops. In a fresh install without a pre-existing DB, this doesn't work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 22:44:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 21:44:07 +0000 Subject: [Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Liz Rea --- I don't understand, that behaviour predates this patch. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 22:49:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 21:49:56 +0000 Subject: [Koha-bugs] [Bug 15834] New: Options to supress e-mail generated by AutoEmailOpacUser Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15834 Bug ID: 15834 Summary: Options to supress e-mail generated by AutoEmailOpacUser Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Would love to see a selection when creating a new account to suppress the welcome e-mail generated by AutoEmailOpacUser. Sometimes, like when creating accounts for ILL, you don't want to send the info. It would also be great if there were a preference where you could choose patron groups to not send this e-mail to. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 16 22:56:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 21:56:58 +0000 Subject: [Koha-bugs] [Bug 15834] Options to supress e-mail generated by AutoEmailOpacUser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15834 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think it's not send if you leave either email, username or password empty - maybe something to try as a work around. But would be nice to have this as an option by patron category. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 00:22:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 23:22:02 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 --- Comment #19 from David Cook --- Hmm... is koha-conf.xml really the most appropriate place to put , since it's only going to be able to affect Debian package installs? I notice that it is in koha-conf.xml.in, so it should only appear in koha-conf.xml files generated by the Debian packages... so I guess that's OK... but it represents yet another deviation between the Debian package installs and all other Koha installs... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 00:30:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 23:30:07 +0000 Subject: [Koha-bugs] [Bug 15834] Options to supress e-mail generated by AutoEmailOpacUser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15834 --- Comment #2 from Christopher Brannon --- Yeah, kind of a clunky workaround, if you remember. Options are always better than workarounds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 00:30:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 23:30:16 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #21 from David Cook --- (In reply to Jonathan Druart from comment #20) > (In reply to David Cook from comment #18) > > I'm using "my @param_names = CGI->param()" elsewhere and it doesn't generate warnings. > > Yes it does. No, it doesn't. Here's the evidence: cat test.pl && perl test.pl use Modern::Perl; use CGI; use Data::Dumper; my $query = CGI->new(); $query->param('name',"bruce","wayne","clark","kent"); my @name = $query->param(); say Dumper(\@name); $VAR1 = [ 'name' ]; -- cat test.pl && perl test.pl use Modern::Perl; use CGI; use Data::Dumper; my $query = CGI->new(); $query->param('name',"bruce","wayne","clark","kent"); my @name = $query->param("name"); say Dumper(\@name); CGI::param called in list context from package main line 8, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/lib/perl5/site_perl/5.20.1/CGI.pm line 437. $VAR1 = [ 'bruce', 'wayne', 'clark', 'kent' ]; -- As you can observe in the warning itself, the warning is for "Fetching the value or values of a single named parameter". In the case of '$query->param("name")', we're fetching the value of a single named parameter. In the case of '$query->param()', we're fetching the names of all the parameters. It's completely different. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 00:30:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 23:30:45 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #22 from David Cook --- P.S. That is CGI.pm version 4.13. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 00:48:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Feb 2016 23:48:10 +0000 Subject: [Koha-bugs] [Bug 14712] Feature for controlling cron jobs/cmd line scripts from staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14712 --- Comment #4 from David Cook --- (In reply to Eivin Giske Skaaren from comment #3) > Hi David, > > I did some initial work on this but it was abandoned for now because of the > security aspect. Exposing root shell via CGI might not be a good idea. > > If you have a good solution that also perhaps solves some of the things that > we wanted to solve with this I would be happy to test/sign-off your patch. Thanks for the update. Basically, I've just written a task scheduler, which uses pluggable modules to run tasks. At the moment, I'm using it for downloading OAI-PMH records and importing OAI-PMH records into Koha. Adding support for things like "scheduled reports" would be as easy as creating a task plugin and creating a data entry template on the Koha staff client. At the moment, all the work is on bug #10662, but I've thought about splitting my patches into separate bug reports... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 01:56:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 00:56:46 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 kholt at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholt at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 02:10:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 01:10:29 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #9 from Srdjan Jankovic --- Jonathan, that's exactly what I did. I'll give it another go, maybe did not get the options right -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 03:35:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 02:35:56 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 03:35:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 02:35:59 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46657|0 |1 is obsolete| | --- Comment #10 from Srdjan Jankovic --- Created attachment 48152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48152&action=edit bug_6624: Added Open Library Search and Read API calls to opac-results.tt and opac-detail.tt Conditional to OpenLibrarySearch syspref Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 03:39:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 02:39:54 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #11 from Srdjan Jankovic --- Ok, so packaged lessc was not good, had to be installed with npm. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 06:09:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 05:09:51 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 --- Comment #6 from Humberto Blanco --- (In reply to Jonathan Druart from comment #4) > Could you export the record and attach it to the bug report. > Then execute, in your sql cli: > SELECT * FROM biblio WHERE biblionumber=YOUR_BIBLIONUMBER > and post the result here. Jonathan, I used: SELECT * FROM biblio inner join biblioitems using (biblionumber) WHERE cn_class like '340.11' I attached the output -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 06:12:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 05:12:42 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 --- Comment #7 from Humberto Blanco --- Created attachment 48153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48153&action=edit select cn_class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 06:47:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 05:47:01 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 --- Comment #8 from Humberto Blanco --- in the apache2 log found thiswhen the error exist [Wed Feb 17 00:25:53 2016] -e: CGI::param called in list context from package ModPerl::ROOT::ModPerl::Registry::usr_share_koha_intranet_cgi_2dbin_catalogue_search_2epl line 168, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436, line 751. [Wed Feb 17 00:25:53 2016] -e: CGI::param called in list context from package C4::Auth line 399, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436, line 751. [Wed Feb 17 00:25:53 2016] -e: CGI::param called in list context from package ModPerl::ROOT::ModPerl::Registry::usr_share_koha_intranet_cgi_2dbin_catalogue_search_2epl line 386, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436, line 751. [Wed Feb 17 00:25:53 2016] -e: CGI::param called in list context from package ModPerl::ROOT::ModPerl::Registry::usr_share_koha_intranet_cgi_2dbin_catalogue_search_2epl line 394, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436, line 751. [Wed Feb 17 00:25:53 2016] -e: CGI::param called in list context from package ModPerl::ROOT::ModPerl::Registry::usr_share_koha_intranet_cgi_2dbin_catalogue_search_2epl line 402, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436, line 751. [Wed Feb 17 00:25:53 2016] -e: CGI::param called in list context from package ModPerl::ROOT::ModPerl::Registry::usr_share_koha_intranet_cgi_2dbin_catalogue_search_2epl line 406, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436, line 751. [Wed Feb 17 00:25:53 2016] -e: CGI::param called in list context from package ModPerl::ROOT::ModPerl::Registry::usr_share_koha_intranet_cgi_2dbin_catalogue_search_2epl line 416, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436, line 751. [Wed Feb 17 00:25:53 2016] -e: CGI::param called in list context from package ModPerl::ROOT::ModPerl::Registry::usr_share_koha_intranet_cgi_2dbin_catalogue_search_2epl line 419, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436, line 751. [Wed Feb 17 00:25:53 2016] -e: CGI::param called in list context from package ModPerl::ROOT::ModPerl::Registry::usr_share_koha_intranet_cgi_2dbin_catalogue_search_2epl line 420, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436, line 751. [Wed Feb 17 00:26:03 2016] -e: CGI::param called in list context from package C4::Auth line 399, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436, line 751. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 06:58:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 05:58:33 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 --- Comment #9 from Humberto Blanco --- (In reply to H?ctor Eduardo Castro Avalos from comment #5) > 082 field isn't indexed. > > Line 164 to 168 in ccl.properties > > #Classification-Dewey 13 A classification number from 082 > # the Dewey Decimal > # Classification, developed by > # Melvyl Dewey. > #Dewey-classification 1=13 > > When you search under Callnumber in advanced search the index used is 952$o > callnum or Local-classification > > Like Jonathan comment maybe you have a date starting with 000-00 in another > 952 field or Holding field. > > I recommend you search in all bibliographic record (Leader/008) and holding > data to see if you have invalid dates > > > Saludos Humberto those happend after migration to koha 3.22, any idea for one more detailed log?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 07:22:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 06:22:53 +0000 Subject: [Koha-bugs] [Bug 15834] Options to supress e-mail generated by AutoEmailOpacUser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15834 --- Comment #3 from Katrin Fischer --- Agreed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 08:06:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 07:06:56 +0000 Subject: [Koha-bugs] [Bug 15835] New: Koha::Object does not save shanges Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15835 Bug ID: 15835 Summary: Koha::Object does not save shanges Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: srdjan at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org $object->set({column => $val})->store does not work. DB trace: BEGIN WORK COMMIT On the other hand, $object->_result()->update({column => $val}) does work. DB trace: BEGIN WORK UPDATE borrowers SET overdrive_auth_token = ? WHERE ( borrowernumber = ? ): XXX, YYY COMMIT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 08:08:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 07:08:24 +0000 Subject: [Koha-bugs] [Bug 15835] Koha::Object does not save shanges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15835 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 08:11:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 07:11:56 +0000 Subject: [Koha-bugs] [Bug 15835] Koha::Object does not save shanges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15835 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 08:25:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 07:25:27 +0000 Subject: [Koha-bugs] [Bug 15835] Koha::Object does not save shanges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15835 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 10:19:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 09:19:12 +0000 Subject: [Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48151|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 48154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48154&action=edit Bug 15830 - Move Rotating Collections actions into a drop-down list To test: 1) Go to Tools -> Rotating Collections 2) Confirm actions (Add or remove items, Transfer, Edit, Delete) have moved into a drop down menu 3) Confirm all of the actions work as expected Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 10:19:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 09:19:29 +0000 Subject: [Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 10:21:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 09:21:18 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #14 from Julian Maurice --- I think I'll push these patches even without a signoff, because it blocks bug 15358 which is a "blocker". Moreover, 15358's patch for 3.22 has been signed off, which mean this bug's patches kind of work too :) That being said, I would still like those patches to be signed off before I push them ;) (probably tomorrow or the day after) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 10:27:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 09:27:40 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #36 from Josef Moravec --- Could you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 10:30:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 09:30:39 +0000 Subject: [Koha-bugs] [Bug 15835] Koha::Object does not save changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15835 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha::Object does not save |Koha::Object does not save |shanges |changes CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 10:47:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 09:47:51 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #24 from Julian Maurice --- Why Koha should allow to place hold that will be (probably) impossible to satisfy ? Let's take an example: - Patron 1 place a hold that starts on 2016-03-01 and ends on 2016-03-07 - Patron 2 place a hold that starts on 2016-03-02 and ends on 2016-03-06 If patron 1 get the book, patron 2 will never have it (unless patron 1 returns the book very quickly, which is very unlikely to happen imo) and is never informed about the high probability that this will happen. Another issue: - Patron 1 place a hold that starts on 2016-03-02 and ends on 2016-03-08 - Patron 2 place a hold (after patron 1 has placed their hold) that starts on 2016-03-01 (we don't care about the end date here) If priority is based on start date, then patron 2 will "steal" the book from patron 1. Patron 1 will never get the book while they have placed their hold first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 10:50:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 09:50:14 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC|sandboxes at biblibre.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 10:53:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 09:53:46 +0000 Subject: [Koha-bugs] [Bug 15836] New: Labels: Offer configuration option for splitting call number in layout definition Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Bug ID: 15836 Summary: Labels: Offer configuration option for splitting call number in layout definition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Currently the call number splitting seems to be mostly implemented for DDC and LC classifications. Those are both not very common in Germany and possibly other countries. A lot of our libraries use their own custom classification schemes so the call number splitting is something that should be individually configurable. One option would be using a regex expression, that can be set in the layout additional to the standard splitting offered by the checkbox. (see bug 2500 for some discussion about the splitting algorithms implemented atm) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 10:53:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 09:53:55 +0000 Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call number in layout definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2500 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 10:53:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 09:53:55 +0000 Subject: [Koha-bugs] [Bug 2500] Standing enhancement request for adding/updating call number splitting algorithms in C4/Labels.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2500 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15836 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 10:57:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 09:57:50 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #23 from Jonathan Druart --- (In reply to David Cook from comment #21) > As you can observe in the warning itself, the warning is for "Fetching the > value or values of a single named parameter". In the case of > '$query->param("name")', we're fetching the value of a single named > parameter. In the case of '$query->param()', we're fetching the names of all > the parameters. It's completely different. I don't understand, we both agree, it generates a warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 10:58:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 09:58:04 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #25 from Katrin Fischer --- I think ideally we shoudl have a proper reservation system that maybe even works separately from the holds system. But my main concern here is that the new behavioru should be optional - so we honor the different workflows. If the books is not checked out or only used on-site, the library can coordinate overlapping holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 11:06:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 10:06:48 +0000 Subject: [Koha-bugs] [Bug 15782] Paging on comments moderation broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15782 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- I can not reproduce the issue on curent master. Tested with about 50 comments / 3 "pages". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 11:07:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 10:07:15 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #121 from Josef Moravec --- Could you rebase please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 11:08:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 10:08:36 +0000 Subject: [Koha-bugs] [Bug 15782] Paging on comments moderation broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15782 --- Comment #2 from Katrin Fischer --- Interesting. I have tested it serveral times now for the library, but couldn't see it in the very beginning. Can you check the offset parameter in the pagination links maybe? In the library reporting they change by 1. If I manipulate the offset parameter in the URL, it works to make bigger 'jumps'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 11:15:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 10:15:36 +0000 Subject: [Koha-bugs] [Bug 15835] Koha::Object does not save changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15835 --- Comment #1 from Jonathan Druart --- Srdjan, what did you try exactly? I have tried the following: use Modern::Perl; use Koha::Borrowers; my $p = Koha::Borrowers->find(10); $p->set({firstname => 'my new firstname', surname => 'my new surname' })->store; then MariaDB [koha]> select firstname, surname from borrowers where borrowernumber=10; And I got my updated values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 11:16:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 10:16:40 +0000 Subject: [Koha-bugs] [Bug 15837] New: "Enter starting label position (for PDF):" for CSV export Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15837 Bug ID: 15837 Summary: "Enter starting label position (for PDF):" for CSV export Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org A library reports that it would be helfpul, if the option "Enter starting label position (for PDF):" when exporting labels, would also work exporting as CSV file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 11:23:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 10:23:35 +0000 Subject: [Koha-bugs] [Bug 15782] Paging on comments moderation broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15782 --- Comment #3 from Marc V?ron --- URL for 1st page: .../cgi-bin/koha/reviews/reviewswaiting.pl?status=1&page=1 URL for the 2nd page: .../cgi-bin/koha/reviews/reviewswaiting.pl?status=1&page=2 URL for 3rd page: .../cgi-bin/koha/reviews/reviewswaiting.pl?status=1&page=3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 11:28:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 10:28:10 +0000 Subject: [Koha-bugs] [Bug 15782] Paging on comments moderation broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15782 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 --- Comment #4 from Katrin Fischer --- Interesting! The parameter is offset in this version (3.18) - I will recheck on master. Thx for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 11:30:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 10:30:20 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47641|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart --- Created attachment 48155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48155&action=edit [3.22.x] Bug 15358: Fix authorities merge Bug 8064 (Merge several biblio records) change some code used in both biblios and authorities merge tool without updating the authorities merge tool. This patch fixes that. Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 11:31:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 10:31:49 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47638|0 |1 is obsolete| | Attachment #47639|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 48156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48156&action=edit [3.22.x] Bug 15578: Insert authority records before processing tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 11:32:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 10:32:03 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #16 from Jonathan Druart --- Created attachment 48157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48157&action=edit [3.22.x] Bug 15578: Make sure all params will be taken into account when instantiating The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. Test plan: Apply the first patch, launch tests => Fail Apply the second patch, launch tests => \o/ Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 11:32:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 10:32:42 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #17 from Jonathan Druart --- Let's sign my own patches off... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 11:53:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 10:53:25 +0000 Subject: [Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 11:53:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 10:53:28 +0000 Subject: [Koha-bugs] [Bug 15830] Move Rotating Collections actions into a drop-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15830 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48154|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 48158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48158&action=edit Bug 15830 - Move Rotating Collections actions into a drop-down list To test: 1) Go to Tools -> Rotating Collections 2) Confirm actions (Add or remove items, Transfer, Edit, Delete) have moved into a drop down menu 3) Confirm all of the actions work as expected Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 12:08:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 11:08:01 +0000 Subject: [Koha-bugs] [Bug 15838] New: syspref SubscriptionDuplicateDroppedInput does not work for all fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15838 Bug ID: 15838 Summary: syspref SubscriptionDuplicateDroppedInput does not work for all fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Some fields (especially on second page?) are not reset when duplicating a subscription despite they are in SubscriptionDuplicateDroppedInput system preference. The reason is that these fields have an id different than the name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 12:08:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 11:08:09 +0000 Subject: [Koha-bugs] [Bug 15838] syspref SubscriptionDuplicateDroppedInput does not work for all fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15838 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 12:14:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 11:14:55 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 12:14:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 11:14:58 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46655|0 |1 is obsolete| | Attachment #46656|0 |1 is obsolete| | Attachment #48152|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 48159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48159&action=edit bug_6624: OpenLibrarySearch syspref for OPAC If set to Yes, OPAC search results and details will include buton from Open Library Raed API. In addition, Number of titles held in Open Library and the results link will be reported on the search results screen. Signed-off-by: Nicole Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 12:15:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 11:15:10 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #13 from Jonathan Druart --- Created attachment 48160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48160&action=edit bug_6624: Added Open Library Search and Read API to openlibrary.js Signed-off-by: Nicole Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 12:15:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 11:15:14 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #14 from Jonathan Druart --- Created attachment 48161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48161&action=edit bug_6624: Added Open Library Search and Read API calls to opac-results.tt and opac-detail.tt Conditional to OpenLibrarySearch syspref Signed-off-by: Nicole Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 12:24:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 11:24:29 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #15 from Jonathan Druart --- Created attachment 48162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48162&action=edit Bug 6624: Add test for OpenLibrary -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 12:27:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 11:27:42 +0000 Subject: [Koha-bugs] [Bug 15838] syspref SubscriptionDuplicateDroppedInput does not work for all fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15838 --- Comment #1 from Alex Arnaud --- Created attachment 48163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48163&action=edit Bug 15838 - Subscription duplicating: Reset fields from SubscriptionDuplicateDroppedInput syspef by getting them using name instead of id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 12:28:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 11:28:03 +0000 Subject: [Koha-bugs] [Bug 15838] syspref SubscriptionDuplicateDroppedInput does not work for all fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15838 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 12:39:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 11:39:03 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15839 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 [Bug 15839] Move the reviews related code to Koha::Reviews -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 12:39:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 11:39:03 +0000 Subject: [Koha-bugs] [Bug 15839] New: Move the reviews related code to Koha::Reviews Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Bug ID: 15839 Summary: Move the reviews related code to Koha::Reviews Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 15449 The subroutines in C4::Reviews are only doing CRUD operations. This module can be moved easily to Koha::Reviews. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 12:39:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 11:39:18 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 --- Comment #9 from Jonathan Druart --- Bug 15839 - Move the reviews related code to Koha::Reviews -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 13:17:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 12:17:07 +0000 Subject: [Koha-bugs] [Bug 8397] Can import patrons with duplicate userids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #4 from Mason James --- (In reply to Owen Leonard from comment #0) > If you use the "import patrons" tool to upload a CSV file of patron records > it is possible to create more than one patron with the same userid. This > should not be possible. I also hit this bug today, when attempting to import/update patrons with undefined ("") userids -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 13:18:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 12:18:25 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 --- Comment #20 from Marcel de Rooy --- (In reply to David Cook from comment #19) Hi David. Thx for your interest in this patch. > Hmm... is koha-conf.xml really the most appropriate place to put > , since it's only going to be able to affect Debian package > installs? Hmm only Debian installs :) Your second remark is part of the answer btw. > I notice that it is in koha-conf.xml.in, so it should only appear in > koha-conf.xml files generated by the Debian packages... so I guess that's > OK... but it represents yet another deviation between the Debian package > installs and all other Koha installs... This is an interesting topic but really outside the scope of this tiny change. The percentage of Debian users of Koha will probably be quite substantial due to the tools developed for it. (We eventually switched from Fedora to Debian for such reasons.) The various install modes (default, single, dev), Debian packaging, gitified, having possibly different directory structures etc., imo really beg for being simplified and brough together. But realizing that is hard. In the meantime the Debian percentage will keep growing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 13:29:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 12:29:58 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #24 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #23) > (In reply to David Cook from comment #21) > > As you can observe in the warning itself, the warning is for "Fetching the > > value or values of a single named parameter". In the case of > > '$query->param("name")', we're fetching the value of a single named > > parameter. In the case of '$query->param()', we're fetching the names of all > > the parameters. It's completely different. > > I don't understand, we both agree, it generates a warning. Misunderstanding? He talks about calling it without arguments (and without warning). You mean calls with an argument (and warnings dependent on context). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 13:32:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 12:32:53 +0000 Subject: [Koha-bugs] [Bug 8397] Can import patrons with duplicate userids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397 --- Comment #5 from Jonathan Druart --- (In reply to Mason James from comment #4) > (In reply to Owen Leonard from comment #0) > > If you use the "import patrons" tool to upload a CSV file of patron records > > it is possible to create more than one patron with the same userid. This > > should not be possible. > > I also hit this bug today, when attempting to import/update patrons with > undefined ("") userids Which versions? Do you have the unique key defined? (see bug 1861). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 13:43:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 12:43:40 +0000 Subject: [Koha-bugs] [Bug 15840] New: Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Bug ID: 15840 Summary: Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org to replicate the bug 1/ import a borrowers.csv file containing any row with a blank 'userid' value, - use the 'overwrite' option. 2/ repeat step 1/ koha dies with error.. DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '' for key 'userid' at /path/to/yr/koha/C4/Members.pm line 683 bug confirmed on 3.18.9 -> master 43bcc1c -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 13:47:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 12:47:15 +0000 Subject: [Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 --- Comment #1 from Mason James --- Created attachment 48164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48164&action=edit pic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 13:47:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 12:47:24 +0000 Subject: [Koha-bugs] [Bug 15841] New: Final truth value in C4:Circulation has become displaced Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15841 Bug ID: 15841 Summary: Final truth value in C4:Circulation has become displaced Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Last thing in a module should be a true value, looks as though a subroutine has been added after the one in circulation. Lets put it back where it should be -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 13:48:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 12:48:18 +0000 Subject: [Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1861 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=1861, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8397 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 [Bug 1861] Unique patrons logins not (totally) enforced -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 13:48:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 12:48:18 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15840 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15840 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 13:48:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 12:48:18 +0000 Subject: [Koha-bugs] [Bug 8397] Can import patrons with duplicate userids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15840 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 13:51:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 12:51:15 +0000 Subject: [Koha-bugs] [Bug 8397] Can import patrons with duplicate userids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397 --- Comment #6 from Mason James --- (In reply to Mason James from comment #4) > (In reply to Owen Leonard from comment #0) > > If you use the "import patrons" tool to upload a CSV file of patron records > > it is possible to create more than one patron with the same userid. This > > should not be possible. > > I also hit this bug today, when attempting to import/update patrons with > undefined ("") userids i logged a new bug, as it is a little different from this one https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 13:52:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 12:52:28 +0000 Subject: [Koha-bugs] [Bug 15841] Final truth value in C4:Circulation has become displaced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15841 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell --- Created attachment 48165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48165&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 13:54:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 12:54:02 +0000 Subject: [Koha-bugs] [Bug 8397] Can import patrons with duplicate userids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397 --- Comment #7 from Mason James --- (In reply to Jonathan Druart from comment #5) > (In reply to Mason James from comment #4) > > (In reply to Owen Leonard from comment #0) > > > If you use the "import patrons" tool to upload a CSV file of patron records > > > it is possible to create more than one patron with the same userid. This > > > should not be possible. > > > > I also hit this bug today, when attempting to import/update patrons with > > undefined ("") userids > > Which versions? Do you have the unique key defined? (see bug 1861). version 3.18.9 to master in my situation the unique key is '', which is a valid value hey? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 13:57:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 12:57:34 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #5 from Marcel de Rooy --- I am having the impression that we do not completely tackle the problem (read vulnerability given) here. Because just switching param to multi_param (without looking to the context) does not really solve it. You only suppress the warning. We could still be vulnerable with calls like: my $hash = { a => multi_param('b'), c => 'd' ) If multi_param b returns ( b1, b2, b3), your hash is 'injected' with b2 => b3, just the same as param b would have done. So we should check (before or after this patch) if we are calling params in a hash context. If so, prepend with scalar. Redefining methods/routines for lower versions of a module is not the most elegant solution (from QA perspective). If we could prevent doing so, we should. Since we do not need to add calls to multi_param yet and we do not address the actual vulnerability in this patch, I would propose to not add this redefinition. We should concentrate on the calls to param in a hash context and scalarize them. (The warnings in the log show us where these calls are.) Failed QA I will also ask for another (QA) opinion on the dev list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 13:59:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 12:59:35 +0000 Subject: [Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:09:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:09:04 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #26 from Marcel de Rooy --- (In reply to Julian Maurice from comment #24) Thx for your response. > Let's take an example: > - Patron 1 place a hold that starts on 2016-03-01 and ends on 2016-03-07 > - Patron 2 place a hold that starts on 2016-03-02 and ends on 2016-03-06 > If patron 1 get the book, patron 2 will never have it (unless patron 1 > returns the book very quickly, which is very unlikely to happen imo) and is > never informed about the high probability that this will happen. "Unlikely to happen imo " is the problem here. As a special library we loan the book and it will normally be returned the same day. (The book does not really leave the building.) > Another issue: > - Patron 1 place a hold that starts on 2016-03-02 and ends on 2016-03-08 > - Patron 2 place a hold (after patron 1 has placed their hold) that starts > on 2016-03-01 (we don't care about the end date here) > If priority is based on start date, then patron 2 will "steal" the book from > patron 1. Patron 1 will never get the book while they have placed their hold > first. No. Patron2 may receive the book before patron1. That is no problem. Patron1 will probably have it the next day. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:12:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:12:16 +0000 Subject: [Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from M. Tompsett --- (In reply to Liz Rea from comment #5) > I don't understand, that behaviour predates this patch. > > Liz That's not the issue. Read the code. I called a fresh install with create DB and the createoptions file was empty, because it generated the else case. That's the else case message. That's why I put it to Failed QA, because it doesn't notice when it was called with --create-db in the case of a fresh install. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:20:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:20:08 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #6 from Marcel de Rooy --- Still we have the other situation that we do want multiple values: my @a = param( 'b' ); Should this actually be solved in CGI? It generates a lot of false warnings. For reasons of compatibility param cannot just return a scalar. Would it be simpler to only clear $CGI::LIST_CONTEXT_WARN for individual cases? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:20:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:20:26 +0000 Subject: [Koha-bugs] [Bug 8397] Can import patrons with duplicate userids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397 --- Comment #8 from Katrin Fischer --- I haven't seen this problem in recent vresions - maybe there is a twist to it. We have seen errors where users haven't been imported because the userid in the file was already in the database. - So that appears to be checked correctly. Also when the same userid was listed twice in one import file, only the first would be imported. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:23:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:23:00 +0000 Subject: [Koha-bugs] [Bug 8397] Can import patrons with duplicate userids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397 --- Comment #9 from Mason James --- (In reply to Owen Leonard from comment #0) > If you use the "import patrons" tool to upload a CSV file of patron records > it is possible to create more than one patron with the same userid. This > should not be possible. I've confirmed that it's no longer possible to import duped useres, however the import tool now dies in some conditions see bug 15840 for details -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:24:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:24:05 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #27 from Julian Maurice --- (In reply to Marcel de Rooy from comment #26) > No. Patron2 may receive the book before patron1. That is no problem. Patron1 > will probably have it the next day. For a 1-day loan that is true. Looks like we are going to need another reserves syspref :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:25:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:25:24 +0000 Subject: [Koha-bugs] [Bug 8397] Can import patrons with duplicate userids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397 --- Comment #10 from Mason James --- (In reply to Katrin Fischer from comment #8) > I haven't seen this problem in recent vresions - maybe there is a twist to > it. > We have seen errors where users haven't been imported because the userid in > the file was already in the database. - So that appears to be checked > correctly. Also when the same userid was listed twice in one import file, > only the first would be imported. i think the twist is that the bug is triggered when using the 'overwrite' import option, rather than 'ignore/skip' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:27:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:27:07 +0000 Subject: [Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 --- Comment #2 from Mason James --- (In reply to Mason James from comment #0) > to replicate the bug > > 1/ import a borrowers.csv file containing any row with a blank 'userid' > value, > - use the 'overwrite' option. > actually the bug is triggered using *any* duplicated 'userid' value, not just "" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:27:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:27:19 +0000 Subject: [Koha-bugs] [Bug 8397] Can import patrons with duplicate userids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8397 --- Comment #11 from Katrin Fischer --- Maybe it's some change since 3.18.x that we are using - because iirc that was with overwrite. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:29:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:29:34 +0000 Subject: [Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 --- Comment #3 from Mason James --- (In reply to Mason James from comment #2) > (In reply to Mason James from comment #0) > > to replicate the bug > > > > 1/ import a borrowers.csv file containing any row with a blank 'userid' > > value, > > - use the 'overwrite' option. > > > > actually the bug is triggered using *any* duplicated 'userid' value, not > just "" ..which means if you import any .csv file twice (with overwrite option), the error is triggered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:29:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:29:49 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:30:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:30:31 +0000 Subject: [Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:43:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:43:48 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #7 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #5) > I am having the impression that we do not completely tackle the problem > (read vulnerability given) here. > Because just switching param to multi_param (without looking to the context) > does not really solve it. You only suppress the warning. Yes of course, but we are now aware of this problem, and it's the QA's job to catch them if they are wrongly used. > Redefining methods/routines for lower versions of a module is not the most > elegant solution (from QA perspective). If we could prevent doing so, we > should. > Since we do not need to add calls to multi_param yet and we do not address > the actual vulnerability in this patch, I would propose to not add this > redefinition. We should concentrate on the calls to param in a hash context > and scalarize them. (The warnings in the log show us where these calls are.) The goal was to remove the warnings for production installs using CGI < 4.08. As a developer, I am using > 4.08 and will see the warnings in my logs. (In reply to Marcel de Rooy from comment #6) > Still we have the other situation that we do want multiple values: > my @a = param( 'b' ); > > Should this actually be solved in CGI? It generates a lot of false warnings. > For reasons of compatibility param cannot just return a scalar. How do you want to fix that, I don't think I understand what you meant here. > Would it be simpler to only clear $CGI::LIST_CONTEXT_WARN for individual > cases? I don't think so, developers won't see the warnings, we should keep them to know where the issues could come from. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:45:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:45:20 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:45:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:45:23 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #1 from Jonathan Druart --- Created attachment 48166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48166&action=edit Bug 15839: Koha::Reviews - Add Koha::Review[s] classes The subroutines in C4::Reviews are only doing CRUD operations. This patch set moves them to 2 new Koha::Review[s] classes. Test plan for the whole patch set: 0/ Set the reviewson syspref 1/ At the OPAC, create a couple of reviews for a record Try and create a review without html tags different that br b i em big small strong: You should get a warning. 2/ Edit a review 3/ On the Staff interface, you should see a "Comments pending approval" link on the mainpage 4/ Approve 1 review and delete the other 5/ At the OPAC you should only see 1 review (the approved one) in the "Comments" tab 6/ Modify the review 7/ The review should appear again in the "comments awaiting moderation" tab. Note that even the comment has not been changed, it will have to be reapproved (FIXME later). This behavior already existed prior to this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:45:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:45:26 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #2 from Jonathan Druart --- Created attachment 48167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48167&action=edit Bug 15839: Koha::Reviews - Remove getreviews The C4::Reviews::getreviews subroutine retrieved the reviews for a given record, depending on their status. This can be achieve with a call to Koha::Reviews->search. There were 2 calls to this subroutine. The one from opac-ISBDdetail.pl does not look in used: the reviews are not display on this page. It certainly comes from an old copy/paste from opac-detail.pl. The one from opac-detail only asked for the approved reviews. So the logged in user does not see its own review if it is pending approval. Actually this pending approval review is only displayed when the user submits it (because of a unecessary complex text replacement done in JS). With this patch, the approved reviews AND the unaproved review from the logged in user will be displayed. It will allow a future enhancement to add a way to delete our own reviews. Moreover, the reviews were retrieved even if they were not displayed (if reviewson is off), it's now fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:45:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:45:29 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #3 from Jonathan Druart --- Created attachment 48168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48168&action=edit Bug 15839: Koha::Reviews - Remove getallreviews -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:45:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:45:31 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #4 from Jonathan Druart --- Created attachment 48169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48169&action=edit Bug 15839: Koha::Reviews - Remove approvereview & unapprovereview This patch adds 2 new methods to Koha::Review: approve and unapprove. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:45:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:45:34 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #5 from Jonathan Druart --- Created attachment 48170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48170&action=edit Bug 15839: Koha::Reviews - Change default value for approved to 0 The reviews.approved column had a default value set to NULL. It does not make sense, the default value should be 0, this will avoid to have to specify the approved value when creating a new review. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:45:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:45:37 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #6 from Jonathan Druart --- Created attachment 48171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48171&action=edit Bug 15839: Koha::Reviews - Remove deletereview Note that a future enhancement should take into account the possible error returned by ->approve, ->unapprove and ->delete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:45:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:45:40 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #7 from Jonathan Druart --- Created attachment 48172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48172&action=edit Bug 15839: Koha::Reviews - Remove getreview Note that this (biblionumber, borrowernumber) pair should be defined as a unique key at the DB level (FIXME added) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:45:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:45:43 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #8 from Jonathan Druart --- Created attachment 48173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48173&action=edit Bug 15839: Koha::Reviews - Remove getnumberofreviews -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:45:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:45:46 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #9 from Jonathan Druart --- Created attachment 48174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48174&action=edit Bug 15839: Koha::Reviews - Remove updatereview -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:45:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:45:49 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #10 from Jonathan Druart --- Created attachment 48175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48175&action=edit Bug 15839: Koha::Reviews - Remove savereview -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:45:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:45:52 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #11 from Jonathan Druart --- Created attachment 48176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48176&action=edit Bug 15839: Koha::Reviews - Remove C4::Review residue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:59:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:59:41 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47905|0 |1 is obsolete| | Attachment #47906|0 |1 is obsolete| | Attachment #47907|0 |1 is obsolete| | Attachment #47908|0 |1 is obsolete| | Attachment #47909|0 |1 is obsolete| | Attachment #47910|0 |1 is obsolete| | Attachment #47911|0 |1 is obsolete| | Attachment #47912|0 |1 is obsolete| | Attachment #47913|0 |1 is obsolete| | Attachment #47914|0 |1 is obsolete| | Attachment #47915|0 |1 is obsolete| | Attachment #47916|0 |1 is obsolete| | Attachment #47917|0 |1 is obsolete| | Attachment #47918|0 |1 is obsolete| | Attachment #47919|0 |1 is obsolete| | Attachment #47920|0 |1 is obsolete| | Attachment #47921|0 |1 is obsolete| | Attachment #47922|0 |1 is obsolete| | --- Comment #149 from Kyle M Hall --- Created attachment 48177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48177&action=edit Squashed followups into main patch set for ease of reading. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:59:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:59:51 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #150 from Kyle M Hall --- Created attachment 48178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48178&action=edit Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:59:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:59:55 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #151 from Kyle M Hall --- Created attachment 48179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48179&action=edit Bug 14610 - Add and update scripts Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 14:59:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 13:59:59 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #152 from Kyle M Hall --- Created attachment 48180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48180&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:00:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:00:03 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #153 from Kyle M Hall --- Created attachment 48181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48181&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:00:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:00:08 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #154 from Kyle M Hall --- Created attachment 48182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48182&action=edit Bug 14610 - Update opac.css via less -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:07:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:07:01 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #8 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #7) > The goal was to remove the warnings for production installs using CGI < 4.08. > As a developer, I am using > 4.08 and will see the warnings in my logs. Older CGI versions do not have this warning. I am not sure about the exact version, but it could well be that the introduction of multi_param also added this warning. How does your solution differentiate production from other installs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:15:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:15:05 +0000 Subject: [Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 --- Comment #7 from M. Tompsett --- Created attachment 48184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48184&action=edit Bug 15088 - Follow for koha-create Logic in the koha-create was requiring a DEFAULTSQL to trigger. This patch moves it, such that --create-db will be registered all the time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:20:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:20:21 +0000 Subject: [Koha-bugs] [Bug 15842] New: Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Bug ID: 15842 Summary: Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Tools Assignee: kyle at bywatersolutions.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 9303 When importing patrons with a csv file which does not contain the privacy_guarantor_checkouts column in the header, you will get DBIx::Class::Storage::DBI::_dbh_execute(): Column 'privacy_guarantor_checkouts' cannot be null at /home/koha/src/C4/Members.pm line 768 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 [Bug 9303] relative's checkouts in the opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:20:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:20:21 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:25:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:25:47 +0000 Subject: [Koha-bugs] [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818 --- Comment #3 from Dobrica Pavlinusic --- Jonathan, I'm wondering do you have libencode-perl package installed or are you using Encode which ships with perl (and which version?). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:26:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:26:35 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:31:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:31:09 +0000 Subject: [Koha-bugs] [Bug 15843] New: Move MARC subfields structure JavaScript into separate file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843 Bug ID: 15843 Summary: Move MARC subfields structure JavaScript into separate file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Coding guideline JS1 (https://wiki.koha-community.org/wiki/Coding_Guidelines#JS1:_Embedding_JavaScript_blocks_in_templates) says "Whenever possible JavaScript should be placed in a separate file." The JavaScript embedded in admin/marc_subfields_structure.tt is not dependent on template processing, so it can be safely moved to a separate file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:41:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:41:19 +0000 Subject: [Koha-bugs] [Bug 15843] Move MARC subfields structure JavaScript into separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:41:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:41:21 +0000 Subject: [Koha-bugs] [Bug 15843] Move MARC subfields structure JavaScript into separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843 --- Comment #1 from Owen Leonard --- Created attachment 48185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48185&action=edit Bug 15843 - Move MARC subfields structure JavaScript into separate file The JavaScript embedded in the MARC subfields structure template is not dependent on template processing and can safely be moved to a separate file. This patch does so. Removed in the process is some lines which were commented out. To test, apply the patch and go to Administration -> MARC framworks. - Click 'MARC structure' for a framework you can edit. - Click 'subfields' for a tag you can edit. - Click 'Edit' for a subfield you can edit. - Confirm that tabs and accordian sections work correctly. - Make changes under Advanced constraints -> Visibility and confirm that they are saved correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:41:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:41:34 +0000 Subject: [Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15842 --- Comment #5 from Jonathan Druart --- I don't reproduce, because the import patron tool is broken at the moment, by bug 15842. But looking at the code, I don't understand how it could happen, there is: 733 $data{'userid'} = Generate_Userid( $data{'borrowernumber'}, $data{'firstname'}, $data{'surname'} ) 734 if ( $data{'userid'} eq '' || !Check_Userid( $data{'userid'} ) ); in C4::Members::AddMember which should avoid that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:41:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:41:34 +0000 Subject: [Koha-bugs] [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15840 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:44:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:44:25 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:53:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:53:22 +0000 Subject: [Koha-bugs] [Bug 15844] New: Correct JSHint errors in staff-global.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15844 Bug ID: 15844 Summary: Correct JSHint errors in staff-global.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in staff-global.js staff-global.js: line 7, col 73, Missing semicolon. staff-global.js: line 7, col 75, Missing semicolon. staff-global.js: line 16, col 2, Unnecessary semicolon. staff-global.js: line 103, col 13, 'newin' is already defined. staff-global.js: line 125, col 39, Use '===' to compare with '0'. staff-global.js: line 125, col 73, Use '===' to compare with '0'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:59:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:59:29 +0000 Subject: [Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44347|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 48186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48186&action=edit [SIGNED-OFF] Bug 15088 - notice when koha has been installed with --request-db instead of --create-db Patch does 2 major things - * creates an options file during koha-create that lets us know what database option was used when the instance was created /etc/koha/sites/$name/createoptions * when an instance is removed, we assume we can do things to the database, per usual. If we have a createoptions, we'll read it and find out if our instance was created with create-db or request-db. If it was requested, we don't do anything with the database because we assume we don't have rights to, and print a message. If it was created, we do the same thing we've always done - remove the database and users (unless we've specified --keep-mysql) To test: create a throwaway instance with --create-db remove that instance, all should happen as normal. your instance should have an /etc/koha/sites/$name/createoptions file with REQUEST_DB=0 in it. create another throwaway instance with --request-db remove that instance, you should see a message alerting you to the fact that you may still have database work to do after Koha is removed. your instance should have an /etc/koha/sites/$name/createoptions file with REQUEST_DB=1 in it. NOTE: Only works in conjuction with my patch. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 15:59:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 14:59:39 +0000 Subject: [Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48184|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 48187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48187&action=edit Bug 15088 - Follow for koha-create Logic in the koha-create was requiring a DEFAULTSQL to trigger. This patch moves it, such that --create-db will be registered all the time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:00:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:00:56 +0000 Subject: [Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from M. Tompsett --- If you could test and sign off, Liz, I would be glad to have this set to signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:12:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:12:08 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #9 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #8) > (In reply to Jonathan Druart from comment #7) > > The goal was to remove the warnings for production installs using CGI < 4.08. > > As a developer, I am using > 4.08 and will see the warnings in my logs. > > Older CGI versions do not have this warning. I am not sure about the exact > version, but it could well be that the introduction of multi_param also > added this warning. You might be right. In this case, we could remove $CGI::LIST_CONTEXT_WARN = 0; from the patch. > How does your solution differentiate production from other installs? It does not -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:17:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:17:19 +0000 Subject: [Koha-bugs] [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818 --- Comment #4 from Jonathan Druart --- % dpkg -l | grep libencode-perl Does not return anything and % pmpath Encode /usr/lib/i386-linux-gnu/perl/5.20/Encode.pm % pmvers Encode 2.60 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:18:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:18:26 +0000 Subject: [Koha-bugs] [Bug 15821] Use Font Awesome icons in confirmation dialogs - Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15821 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:19:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:19:03 +0000 Subject: [Koha-bugs] [Bug 15820] suggestion.pl maximum internal redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15820 --- Comment #4 from Humberto Blanco --- (In reply to Jonathan Druart from comment #3) > Could you confirm that the error still exists after you have modified the > sql_mode mysql variable? yes, now I see in the log [Wed Feb 17 08:19:32.283271 2016] [core:error] [pid 817] [client 10.10.11.192:4002] AH00124: Request exceeded the limit of 10 internal redirects due to probable configuration error. Use 'LimitInternalRecursion' to increase the limit if necessary. Use 'LogLevel debug' to get a backtrace., referer: http://catalogo.urosario.edu.co:8080/cgi-bin/koha/suggestion/suggestion.pl ANd get 500 error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:26:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:26:54 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 --- Comment #10 from Humberto Blanco --- This morning i have the same error when do this search http://catalogo.urosario.edu.co/cgi-bin/koha/opac-search.pl?idx=kw&q=vivo&offset=80&sort_by=relevance_dsc and get the error Software error: Can't locate object method "ymd" via package "dateonly" (perhaps you forgot to load "dateonly"?) at /usr/share/koha/lib/Koha/DateUtils.pm line 223. In the QueryWeightFields KOHA preferences set to disabled. and the query works fine. but in the staff i have the same error in advanced search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:28:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:28:00 +0000 Subject: [Koha-bugs] [Bug 15820] suggestion.pl maximum internal redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15820 --- Comment #5 from Jonathan Druart --- Are you using the default Koha Apache configuration file? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:32:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:32:59 +0000 Subject: [Koha-bugs] [Bug 15845] New: Renewal date in circulation.pl is not always correct and not even used Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15845 Bug ID: 15845 Summary: Renewal date in circulation.pl is not always correct and not even used Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:34:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:34:40 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48177|Squashed followups into |Bug 14610 - Add ability to description|main patch set for ease of |place article requests in |reading. |Koha - Update database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:36:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:36:43 +0000 Subject: [Koha-bugs] [Bug 15844] Correct JSHint errors in staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15844 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:36:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:36:45 +0000 Subject: [Koha-bugs] [Bug 15844] Correct JSHint errors in staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15844 --- Comment #1 from Owen Leonard --- Created attachment 48188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48188&action=edit Bug 15844 - Correct JSHint errors in staff-global.js This patch corrects minor errors in staff-global.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on staff-global.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Confirm that the "Help" link opens the help window. - Confirm that audio alerts work with local and remote sound files - Confirm that the format() method is still working correctly by, for instance, opening the detail page for a bibliographic record with multiple items and choosing 'Edit -> Delete record' from the menu. The error message should read like "2 item(s) are attached to this record..." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:37:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:37:34 +0000 Subject: [Koha-bugs] [Bug 15845] Renewal date in circulation.pl is not always correct and not even used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15845 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:37:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:37:36 +0000 Subject: [Koha-bugs] [Bug 15845] Renewal date in circulation.pl is not always correct and not even used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15845 --- Comment #1 from Marcel de Rooy --- Created attachment 48189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48189&action=edit Bug 15845: Renewal date in circulation.pl is not always correct and not even used If you have a patron category with a hard renewal date, the enrolllment period will be zero. You cannot calculate the renewal date as is done in the script currently. Even more, the renewaldate template var is not even used. Test plan: [1] Verify that checkin/checkout works as expected. [2] Git grep on renewaldate [3] Check the code in circulation.pl for "$renew" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:37:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:37:36 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 --- Comment #11 from Jonathan Druart --- I am sorry but I don't have enough information to help you. On a test server, you could try to modify Koha::DateUtils::output_pref with: +++ b/Koha/DateUtils.pm @@ -220,6 +220,7 @@ sub output_pref { return unless defined $dt; # FIXME: see bug 13242 => no TZ for dates 'infinite' + use Data::Dumper;warn Dumper caller; if ( $dt->ymd !~ /^9999/ ) { my $tz = $dateonly ? DateTime::TimeZone->new(name => 'floating') : C4::Context->tz; $dt->set_time_zone( $tz ); Looking at the logs, you will know which routines has called it just before crashing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:38:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:38:26 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 --- Comment #12 from H?ctor Eduardo Castro Avalos --- Your records look good, Humberto. I could see that in my records I don't have biblioitems.cn_sort with any data populated on it. And you got 340_110000000000000 in all records Maybe Jonathan knows more about it, He got a lot of experience in Koha Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:38:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:38:35 +0000 Subject: [Koha-bugs] [Bug 15845] Renewal date in circulation.pl is not always correct and not even used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15845 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:51:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:51:04 +0000 Subject: [Koha-bugs] [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:51:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:51:09 +0000 Subject: [Koha-bugs] [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 --- Comment #1 from Kyle M Hall --- Created attachment 48190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48190&action=edit Bug 15842 - Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts When importing patrons with a csv file which does not contain the privacy_guarantor_checkouts column in the header, you will get DBIx::Class::Storage::DBI::_dbh_execute(): Column 'privacy_guarantor_checkouts' cannot be null at /home/koha/src/C4/Members.pm line 768 The same issue seems to occur for sms_provider_id. Test Plan: 1) Attempt to import patron csv file with no privacy_guarantor_checkouts column 2) Note the error 3) Apply this patch 4) Repeat step 1 5) The error should no longer occur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:52:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:52:28 +0000 Subject: [Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- After modifying items (from the catalogue/detail.pl), I get a screen with: 5 item(s) modified (with 5 fields modified). Return to where you were [TABLE] Done button If I click on the done button, I am not redirected to the detail page but the still on the batch tool with the same screen "item(s) modified (with fields modified)." The submit button you have added is in a form, the window.location.href does not work and the form is submitted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:54:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:54:13 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 16:57:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 15:57:22 +0000 Subject: [Koha-bugs] [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 17:04:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 16:04:57 +0000 Subject: [Koha-bugs] [Bug 15843] Move MARC subfields structure JavaScript into separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48185|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 48191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48191&action=edit [SIGNED-OFF]Bug 15843: Move MARC subfields structure JavaScript into separate file The JavaScript embedded in the MARC subfields structure template is not dependent on template processing and can safely be moved to a separate file. This patch does so. Removed in the process is some lines which were commented out. To test, apply the patch and go to Administration -> MARC framworks. - Click 'MARC structure' for a framework you can edit. - Click 'subfields' for a tag you can edit. - Click 'Edit' for a subfield you can edit. - Confirm that tabs and accordian sections work correctly. - Make changes under Advanced constraints -> Visibility and confirm that they are saved correctly. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 17:05:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 16:05:07 +0000 Subject: [Koha-bugs] [Bug 15843] Move MARC subfields structure JavaScript into separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 17:14:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 16:14:11 +0000 Subject: [Koha-bugs] [Bug 15844] Correct JSHint errors in staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15844 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48188|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 48192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48192&action=edit Bug 15844 - Correct JSHint errors in staff-global.js This patch corrects minor errors in staff-global.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on staff-global.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Confirm that the "Help" link opens the help window. - Confirm that audio alerts work with local and remote sound files - Confirm that the format() method is still working correctly by, for instance, opening the detail page for a bibliographic record with multiple items and choosing 'Edit -> Delete record' from the menu. The error message should read like "2 item(s) are attached to this record..." Signed-off-by: Hector Castro Works as described. No errors with JSHint CLI (6 errors fixed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 17:14:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 16:14:27 +0000 Subject: [Koha-bugs] [Bug 15844] Correct JSHint errors in staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15844 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 17:21:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 16:21:13 +0000 Subject: [Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 --- Comment #6 from Jonathan Druart --- Ok, got it. I almost have a patch, what should we do if the userid is still used? 1/ Generate a new one, insert the patron and display a warning or 2/ Do not insert the patron and display an error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 17:23:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 16:23:00 +0000 Subject: [Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 --- Comment #7 from Katrin Fischer --- What is meant by 'still used' - can you explain? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 17:45:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 16:45:51 +0000 Subject: [Koha-bugs] [Bug 14616] Introducing Koha::Object subclasses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14616 --- Comment #10 from M. Tompsett --- Comment on attachment 41532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41532 Bug 14616 - Introducing Koha::Object subclasses Review of attachment 41532: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14616&attachment=41532) ----------------------------------------------------------------- ::: Koha/Biblio.pm @@ -44,5 @@ > } > > -=head1 AUTHOR > - > -Kyle M Hall Why is this being removed? I don't think Biblio.pm shouldn't even be in this patch. ::: Koha/Biblios.pm @@ +1,3 @@ > package Koha::Biblios; > > +# Copyright Open Source Freedom Fighters This is an addition, not a replacement! @@ +36,5 @@ > } > > +sub _get_castable_unique_columns { > + return ['biblionumber']; > +} This is an addition, which is fine. @@ -55,5 @@ > > -=head1 AUTHOR > - > -Kyle M Hall > - Again, why is this removed? ::: Koha/Item.pm @@ +1,4 @@ > package Koha::Item; > > # Copyright ByWater Solutions 2014 > +# Copyright Open Source Freedom Fighters Why add a copyright for nothing added? ::: Koha/Items.pm @@ +61,5 @@ > =cut > > +sub _get_castable_unique_columns { > + return ['itemnumber', 'barcode']; > +} Like this! Nice, sharing credit, with a functionality addition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 17:48:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 16:48:34 +0000 Subject: [Koha-bugs] [Bug 15846] New: Move MARC Framework JavaScript into separate file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15846 Bug ID: 15846 Summary: Move MARC Framework JavaScript into separate file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: hector.hecaxmmx at gmail.com, testopia at bugs.koha-community.org Coding guideline JS1 (https://wiki.koha-community.org/wiki/Coding_Guidelines#JS1:_Embedding_JavaScript_blocks_in_templates) says "Whenever possible JavaScript should be placed in a separate file." The JavaScript embedded in admin/biblio_framework.tt is not so dependent on template processing that it can't be safely moved to a separate file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 17:48:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 16:48:45 +0000 Subject: [Koha-bugs] [Bug 15846] Move MARC Framework JavaScript into separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15846 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 17:58:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 16:58:45 +0000 Subject: [Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 --- Comment #8 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > What is meant by 'still used' - can you explain? s/still/already ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 17:59:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 16:59:36 +0000 Subject: [Koha-bugs] [Bug 15846] Move MARC Framework JavaScript into separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15846 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 17:59:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 16:59:38 +0000 Subject: [Koha-bugs] [Bug 15846] Move MARC Framework JavaScript into separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15846 --- Comment #1 from Owen Leonard --- Created attachment 48193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48193&action=edit Bug 15846 - Move MARC Framework JavaScript into separate file The JavaScript embedded in the MARC framework template is not dependent on template processing to such an extent that it can't be safely moved to a separate file. This patch does so, adding definition of a few translatable strings to the template. To test, apply the patch and go to Administration -> MARC frameworks. - The table of existing frameworks should be sortable. - The "Export" link should trigger the export modal. - The "Import" link should trigger the import modal. -- Clicking "Import" without selecting a file should trigger an alert. -- Selecting the wrong file type should trigger an alert. -- Importing a file of the correct type should trigger an overwrite warning ("Do you really want to import...?"). -- A progress indicator should show during the import, with correct values for "Importing from" and "Importing to". -- Importing an incorrectly-formatted file of a correct type should trigger an alert, "Error importing the framework..." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 18:13:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 17:13:30 +0000 Subject: [Koha-bugs] [Bug 15846] Move MARC Framework JavaScript into separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15846 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48193|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 48194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48194&action=edit [SIGNED-OFF]Bug 15846: Move MARC Framework JavaScript into separate file The JavaScript embedded in the MARC framework template is not dependent on template processing to such an extent that it can't be safely moved to a separate file. This patch does so, adding definition of a few translatable strings to the template. To test, apply the patch and go to Administration -> MARC frameworks. - The table of existing frameworks should be sortable. - The "Export" link should trigger the export modal. - The "Import" link should trigger the import modal. -- Clicking "Import" without selecting a file should trigger an alert. -- Selecting the wrong file type should trigger an alert. -- Importing a file of the correct type should trigger an overwrite warning ("Do you really want to import...?"). -- A progress indicator should show during the import, with correct values for "Importing from" and "Importing to". -- Importing an incorrectly-formatted file of a correct type should trigger an alert, "Error importing the framework..." Signed-off-by: Hector Castro Works as advertised. Export and Import options work properly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 18:13:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 17:13:43 +0000 Subject: [Koha-bugs] [Bug 15846] Move MARC Framework JavaScript into separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15846 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 18:15:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 17:15:12 +0000 Subject: [Koha-bugs] [Bug 15847] New: Correct JSHint errors in basket.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 Bug ID: 15847 Summary: Correct JSHint errors in basket.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: hector.hecaxmmx at gmail.com, testopia at bugs.koha-community.org Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in basket.js basket.js: line 53, col 36, Use '===' to compare with '0'. basket.js: line 85, col 42, Missing semicolon. basket.js: line 210, col 5, Implied eval. Consider passing a function instead of a string. basket.js: line 219, col 44, Missing semicolon. basket.js: line 243, col 46, Missing semicolon. basket.js: line 251, col 29, Use '===' to compare with '0'. basket.js: line 270, col 13, 'valCookie' is already defined. basket.js: line 305, col 13, Use '===' to compare with 'undefined'. basket.js: line 409, col 25, The array literal notation [] is preferable. basket.js: line 416, col 25, Use '===' to compare with '0'. basket.js: line 432, col 33, Missing semicolon. basket.js: line 1, col 11, Missing semicolon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 18:18:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 17:18:13 +0000 Subject: [Koha-bugs] [Bug 15847] Correct JSHint errors in basket.js in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Correct JSHint errors in |Correct JSHint errors in |basket.js |basket.js in the staff | |client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 18:25:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 17:25:02 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- So, ->param() starts displaying warnings when evaluated in list context as of CGI.pm 4.05. ->multi_param() was added in 4.08 as a way of saying "I really want multiple parameter values, don't make me do { $CGI::LIST_CONTEXT_WARN = 0; @f = $q->param('foo'); } just to quell the warning." To deal with the most common exploit scenario, "git grep '=>.*->param'" turns up ~270 cases where we most likely *don't* want multi_param(); rather, we want to wrap ->param in scalar(...). I think that should be the first priority. "git grep '@.*->param'" turns up 332 places in 120 files where a parameter is intentionally being fed into a list. I'm not keen about monkey-patching a core module, though I recognize the expediency of it; but if we go that route so that we can start using ->multi_param() across the board, I think we *shouldn't* set $CGI::LIST_CONTEXT_WARN. An alternative would be adding a bunch of "local $CGI::LIST_CONTEXT_WARN = 0;" and making a note to ourselves to replace that with ->multi_param() once we're past the point where stable Linux distros ship CGI.pm older than 4.08. We could also do it like this: Change: @f = $cgi->param('foo'); To: @f = Koha::CGI::multi_param($cgi, 'foo'); where Koha::CGI::multi_param looks something like this: sub multi_param { my ($cgi, $param) = @_; local $CGI::LIST_CONTEXT_WARN = 0; return $cgi->param($param); } That way, we're not monkey-patching a core module and we get something that we can mechanically translate to $cgi->multi_param once we're assured of having a recent enough version of CGI.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 18:27:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 17:27:54 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #11 from Galen Charlton --- Yet another way to do it would be to make Koha::CGI be a full (but thin) OO wrapper around CGI.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 18:34:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 17:34:27 +0000 Subject: [Koha-bugs] [Bug 15847] Correct JSHint errors in basket.js in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 --- Comment #1 from Owen Leonard --- Created attachment 48195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48195&action=edit Bug 15847 - Correct JSHint errors in basket.js in the staff client This patch corrects minor errors in the staff client's basket.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on basket.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Test adding multiple titles to the Cart from staff client search results. - Confirm that adding titles to the Cart triggers a message by the Cart link. - Test clicking the "Cart" link in the header menu when the Cart popup is open but behind the main window. - Testing emptying the Cart. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 18:34:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 17:34:24 +0000 Subject: [Koha-bugs] [Bug 15847] Correct JSHint errors in basket.js in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 18:43:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 17:43:23 +0000 Subject: [Koha-bugs] [Bug 15848] New: Correct JSHint errors in acq.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15848 Bug ID: 15848 Summary: Correct JSHint errors in acq.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: hector.hecaxmmx at gmail.com, testopia at bugs.koha-community.org Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in acq.js koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 5, col 17, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 11, col 21, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 25, col 24, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 40, col 13, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 44, col 18, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 44, col 32, Use '===' to compare with ''. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 73, col 17, Use '===' to compare with 'null'. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 74, col 17, Use '===' to compare with 'null'. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 75, col 23, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 110, col 14, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 114, col 24, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 129, col 24, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 129, col 28, Missing '()' invoking a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 134, col 15, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 134, col 19, Missing '()' invoking a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 136, col 31, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 140, col 27, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 147, col 19, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 148, col 16, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 150, col 14, 'i' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 179, col 20, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 180, col 20, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 181, col 24, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 182, col 20, Do not use String as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 183, col 25, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 186, col 17, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 189, col 17, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 191, col 18, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 220, col 13, Use '===' to compare with 'null'. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 220, col 28, Use '===' to compare with ''. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 258, col 24, eval can be harmful. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 267, col 6, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 287, col 50, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 287, col 52, Unnecessary semicolon. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 288, col 66, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 288, col 67, Unnecessary semicolon. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 302, col 18, eval can be harmful. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 336, col 18, eval can be harmful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 18:44:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 17:44:25 +0000 Subject: [Koha-bugs] [Bug 15849] New: Correct JSHint errors in additem.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15849 Bug ID: 15849 Summary: Correct JSHint errors in additem.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: hector.hecaxmmx at gmail.com, koha-bugs at lists.koha-community.org, testopia at bugs.koha-community.org Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in acq.js koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 5, col 41, Use '!==' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 10, col 76, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 19, col 17, Bad line breaking before '||'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 35, col 97, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 51, col 9, Bad line breaking before '+'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 53, col 9, Bad line breaking before '+'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 54, col 9, Bad line breaking before '+'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 57, col 9, Creating global 'for' variable. Should be 'for (var i ...'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 68, col 25, Use '===' to compare with 'undefined'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 88, col 41, Use '!==' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 95, col 24, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 99, col 67, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 103, col 31, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 103, col 73, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 113, col 37, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 115, col 13, 'dont_copy_fields' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 116, col 13, Creating global 'for' variable. Should be 'for (var i ...'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 122, col 58, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 174, col 17, Use '===' to compare with 'null'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 195, col 26, The object literal notation {} is preferable. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 196, col 9, ['field'] is better written in dot notation. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 196, col 30, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 197, col 9, ['value'] is better written in dot notation. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 197, col 30, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 202, col 11, Creating global 'for' variable. Should be 'for (var field ...'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 204, col 23, Use '===' to compare with ''. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 207, col 31, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 212, col 21, ['field'] is better written in dot notation. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 213, col 21, ['value'] is better written in dot notation. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 208, col 69, Don't make functions within a loop. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 222, col 21, Bad line breaking before '+'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 223, col 21, Bad line breaking before '+'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 230, col 18, Use '===' to compare with 'false'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 241, col 18, Creating global 'for' variable. Should be 'for (var field ...'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 247, col 25, Bad line breaking before '+'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 248, col 29, Bad line breaking before '||'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 249, col 25, Bad line breaking before '+'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 256, col 18, Use '===' to compare with 'false'. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 18:45:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 17:45:49 +0000 Subject: [Koha-bugs] [Bug 15850] New: Correct JSHint errors in cataloging.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850 Bug ID: 15850 Summary: Correct JSHint errors in cataloging.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: koha-bugs at lists.koha-community.org, m.de.rooy at rijksmuseum.nl, testopia at bugs.koha-community.org Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in cataloging.js koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 43, col 31, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 49, col 72, Use '!==' to compare with ''. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 99, col 13, 'i' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 116, col 17, 'id_input' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 182, col 37, 'olddiv' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 183, col 37, 'oldcontrol' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 108, col 18, 'j' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 108, col 26, 'j' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 108, col 46, 'j' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 109, col 27, 'j' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 109, col 59, 'j' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 110, col 28, 'j' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 220, col 21, 'inputs' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 226, col 25, 'anchors' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 227, col 30, 'j' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 176, col 21, 'CloneButtonPlus' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 280, col 13, 'i' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 280, col 17, 'len' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 287, col 13, 'i' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 287, col 17, 'len' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 296, col 13, 'oldcontrol' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 315, col 21, 'i' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 409, col 15, 'line' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 425, col 34, 'line' used out of scope. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 465, col 13, 'i' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 465, col 17, 'len' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 471, col 13, 'i' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js: line 471, col 17, 'len' is already defined. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 18:52:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 17:52:29 +0000 Subject: [Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 19:08:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 18:08:32 +0000 Subject: [Koha-bugs] [Bug 8373] opacheader should not show in print layout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8373 --- Comment #2 from Owen Leonard --- (In reply to Marc V?ron from comment #1) > Tested on current master with opac-shelves.pl: > > If I use the browser's print preview, it looks OK. If I use the icon > 'print', the whole page is printed, including the contents of the opacheader > system preference. I can't reproduce this bug either way. The opacheader
    is contained within the #header-region
    which has a class of "noprint." Seems like you'd have to have a display property applied to #opacheader to override the "noprint" class to make it show up in a printout. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 19:16:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 18:16:46 +0000 Subject: [Koha-bugs] [Bug 12239] Errors loading script under https in chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 19:54:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 18:54:18 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.4 Thanks Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 19:55:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 18:55:08 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #53 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.4 Thanks Jonathan and Josef -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 20:01:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 19:01:10 +0000 Subject: [Koha-bugs] [Bug 15738] Summary page says item has no fines, but Fines tab says otherwise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15738 --- Comment #2 from Owen Leonard --- I'm pretty sure the "fines" column in the OPAC only shows overdue fines. What you're describing sounds like a rental charge. Perhaps this bug should be be "Show a rental charges column in the OPAC summary table." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 20:01:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 19:01:43 +0000 Subject: [Koha-bugs] [Bug 15738] Summary page says item has no fines, but Fines tab says otherwise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15738 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 20:09:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 19:09:31 +0000 Subject: [Koha-bugs] [Bug 15349] Problem with email pattern check on forms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349 --- Comment #1 from Owen Leonard --- Koha is inconsistent about where an email formatted that way is acceptable. I think before we could solve this we would need to either enable it everywhere or at least identify where it is and isn't possible. See bug 9815 - "<> can't contain "The Library" " -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 20:17:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 19:17:01 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #17 from bondiurbano --- Holger, I have made a second test (including bug 14101) on my local virtual machine and the problem persists. - Release 3.22.3 + bug 14101 - Automatic renewal cronjob was executed manually by me - Same parameters in issuing rules that were set in the first test Tell me how can I help from now on please. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 20:19:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 19:19:45 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #18 from bondiurbano --- (In reply to bondiurbano from comment #17) > Holger, > > I have made a second test (including bug 14101) on my local virtual machine > and the problem persists. > > - Release 3.22.3 + bug 14101 > - Automatic renewal cronjob was executed manually by me > - Same parameters in issuing rules that were set in the first test > > Tell me how can I help from now on please. Sorry, 14101 (pushed to master) and 14395 (passed QA) bugs were included. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 20:20:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 19:20:33 +0000 Subject: [Koha-bugs] [Bug 10616] hold warning needs design work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10616 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19804|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 48196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48196&action=edit Screenshot in current master > Revert waiting status & Check out > Cancel hold & Check out > No, don't check out Thos options would be more accurate too since the current interface suggests that 'Cancel hold' and 'Revert waiting status' are settings which apply to /all/ the buttons, as if you could select 'cancel hold' and click 'Don't check out' and have both happen. That's not the way it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 20:26:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 19:26:10 +0000 Subject: [Koha-bugs] [Bug 15847] Correct JSHint errors in basket.js in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48195|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 48197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48197&action=edit [SIGNED-OFF]Bug 15847: Correct JSHint errors in basket.js in the staff client This patch corrects minor errors in the staff client's basket.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on basket.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Test adding multiple titles to the Cart from staff client search results. - Confirm that adding titles to the Cart triggers a message by the Cart link. - Test clicking the "Cart" link in the header menu when the Cart popup is open but behind the main window. - Testing emptying the Cart. Signed-off-by: Hector Castro Works as described. No warnigns raised with jshint tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 20:26:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 19:26:25 +0000 Subject: [Koha-bugs] [Bug 15847] Correct JSHint errors in basket.js in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 20:27:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 19:27:54 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #12 from Jonathan Druart --- (In reply to Galen Charlton from comment #10) I totally agree with the "what to do next" part, but what about now? My patch seems to match your requirements. It could be very easy and quick to replace the different occurrences. I would like to avoid a temporary solution. Even if we need one, something different than "FIXME bug 2505" would be better ;) Defining the CGi->multi_param method for < 4.08 and use CGI->param instead looks, to me, the easiest and cleanest solution. We will just need to remove it when >= 4.08 will be widely used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 21:29:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 20:29:37 +0000 Subject: [Koha-bugs] [Bug 15851] New: "Analytics: Show analytics" showing regardless of whether they have analytics. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Bug ID: 15851 Summary: "Analytics: Show analytics" showing regardless of whether they have analytics. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: ed.veal at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl All of records where position 7 of the leader indicates serial automatically display "Analytics: Show analytics" -- regardless of whether they have analytics. To confirm, we linked numerous items to host records in the case where monographic volumes were bound together via the "Link to Host Item" feature, automatically creating 773s. These are not in question and we do not want to make any changes that would affect them. The request is to remove the display "Analytics: Show analytics" for periodical records that do not have analytics. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 21:45:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 20:45:47 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- There are 2 ways in Koha to manage analytical records - one is EasyAnalytics, which I think you are referring to. The other is using the "New child record" option and is based on the bibliographic record only, without involving the items. If you are using EasyAnalytics you could probably just hide the link with CSS as it should not be needed. The basic problem is, that the parent record doesn't know in the MARC if it has children... so we can't solve that only with XSLT, we need another way of checking for children. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 22:09:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 21:09:03 +0000 Subject: [Koha-bugs] [Bug 15852] New: 3M selfCheck do not connect Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15852 Bug ID: 15852 Summary: 3M selfCheck do not connect Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: hblancoca at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Created attachment 48198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48198&action=edit 3m selfcheckout machines. I have not idea but i before update to 3.22 have some errors (every minute)in connection (attached image) in the log /var/log/koha/catalogo/sip-output.log SIP Timed Out! SIP Timed Out! LDAP bind failed as kohauser bibecsd1: LDAP error #49: LDAP_INVALID_CREDENTIALS # The wrong password was supplied or the SASL credentials could not be processed I believe that the error its (SIP Timed Out!) but i do know how to solve this. NOTE: the users, passwords an d branches are OK but the problem was imn migration. The server has iptables but the policy its accept all; we have RAW implementation no telnet my configuration file its really appreciate your help. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 17 22:53:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 21:53:08 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 00:07:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 23:07:44 +0000 Subject: [Koha-bugs] [Bug 15853] New: Add author and link columns to opac course reserves table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15853 Bug ID: 15853 Summary: Add author and link columns to opac course reserves table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To be done: 1 - Add an author column to the opac course reserves table 2 - Add a 'link' column to the opac course reserves table, populated from the 856$u field -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 00:08:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 23:08:15 +0000 Subject: [Koha-bugs] [Bug 15853] Add author and link columns to opac course reserves table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15853 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |nicole at bywatersolutions.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 00:08:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 23:08:28 +0000 Subject: [Koha-bugs] [Bug 15671] Show branch name instead of branch code in checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15671 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 00:31:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 23:31:07 +0000 Subject: [Koha-bugs] [Bug 15671] Show branch name instead of branch code in checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15671 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 00:35:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 23:35:27 +0000 Subject: [Koha-bugs] [Bug 15671] Show branch name instead of branch code in checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15671 --- Comment #1 from Owen Leonard --- Created attachment 48199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48199&action=edit Bug 15671 - Show branch name instead of branch code in checkout history When viewing the checkout history for a title the branchcode is displayed. This patch alters the template to show the library name instead. To test, apply the patch and locate a title in the staff client which has been checked out at least once. From the detail page, click "Checkout history" in the sidebar. The "Checked out from" column of the checkout history table should show the library name instead of the branchcode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 00:38:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 23:38:55 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #16 from Srdjan Jankovic --- Just curious, this test does not test any part of Koha. What if it fails? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 00:52:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 23:52:43 +0000 Subject: [Koha-bugs] [Bug 15672] Show descriptions instead of codes on the hold ratios report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15672 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 00:52:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 23:52:58 +0000 Subject: [Koha-bugs] [Bug 15672] Show descriptions instead of codes on the hold ratios report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15672 --- Comment #1 from Owen Leonard --- Created attachment 48200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48200&action=edit Bug 15672 - Show descriptions instead of codes on the hold ratios report This patch revises the hold ratios report so that it uses template plugins to display descriptions instead of codes for item holding branch, item home branch, item type, and library name. To test you should have multiple items on the hold ratio report (set the ratio to a small number to increase the number of results). It should include one or more items which have a shelving location set. View the hold ratios report and confirm that library names, shelving location descriptions, and item type descriptions are shown instead of codes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 00:56:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Feb 2016 23:56:31 +0000 Subject: [Koha-bugs] [Bug 15535] can't call method "default-privacy" on an undefined value /usr/share/koha/lib/c4/members.pm line 753 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15535 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All OS|Linux |All Component|OPAC |System Administration CC| |gmcharlt at gmail.com Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 01:12:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 00:12:27 +0000 Subject: [Koha-bugs] [Bug 15071] red color on check outs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 01:12:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 00:12:52 +0000 Subject: [Koha-bugs] [Bug 15071] red color on check outs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 --- Comment #8 from Owen Leonard --- I suspect this was an omission during the prog -> bootstrap conversion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 02:03:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 01:03:07 +0000 Subject: [Koha-bugs] [Bug 15835] Koha::Object does not save changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15835 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Srdjan Jankovic --- Well I cannot make it happen now myself. Who knows what was going on... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 03:12:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 02:12:27 +0000 Subject: [Koha-bugs] [Bug 15071] In OPAC search results, "checked out" status should be more visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|red color on check outs |In OPAC search results, | |"checked out" status should | |be more visible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 03:20:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 02:20:30 +0000 Subject: [Koha-bugs] [Bug 15071] In OPAC search results, "checked out" status should be more visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 03:20:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 02:20:45 +0000 Subject: [Koha-bugs] [Bug 15071] In OPAC search results, "checked out" status should be more visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 --- Comment #9 from Owen Leonard --- Created attachment 48201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48201&action=edit Bug 15071 - In OPAC search results, "checked out" status should be more visible The prog template in the OPAC designated a color for the "unavailable" class associated with items in search results which are checked out. This class never made it into the Bootstrap theme. This patch adds it to the Bootstrap theme's LESS file. To test, apply the patch and search the OPAC for terms that will return checked out items. In the list of search results, on the "availability" line, the "Checked out" text should now be red. The change is visible with XSLT on or off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 03:20:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 02:20:50 +0000 Subject: [Koha-bugs] [Bug 15071] In OPAC search results, "checked out" status should be more visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 --- Comment #10 from Owen Leonard --- Created attachment 48202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48202&action=edit Bug 15071 - In OPAC search results, "checked out" status should be more visible Compiled CSS file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 03:27:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 02:27:01 +0000 Subject: [Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- mysql> show variables like '%char%'; +--------------------------+----------------------------+ | Variable_name | Value | +--------------------------+----------------------------+ | character_set_client | utf8 | | character_set_connection | utf8 | | character_set_database | latin1 | | character_set_filesystem | binary | | character_set_results | utf8 | | character_set_server | latin1 | | character_set_system | utf8 | | character_sets_dir | /usr/share/mysql/charsets/ | +--------------------------+----------------------------+ 8 rows in set (0.00 sec) mysql> set character_set_database=utf8mb4; Query OK, 0 rows affected (0.00 sec) mysql> set character_set_connection=utf8mb4; Query OK, 0 rows affected (0.00 sec) mysql> set character_set_client=utf8mb4; Query OK, 0 rows affected (0.00 sec) mysql> set character_set_results=utf8mb4; Query OK, 0 rows affected (0.00 sec) mysql> show variables like '%char%'; +--------------------------+----------------------------+ | Variable_name | Value | +--------------------------+----------------------------+ | character_set_client | utf8mb4 | | character_set_connection | utf8mb4 | | character_set_database | utf8mb4 | | character_set_filesystem | binary | | character_set_results | utf8mb4 | | character_set_server | latin1 | | character_set_system | utf8 | | character_sets_dir | /usr/share/mysql/charsets/ | +--------------------------+----------------------------+ 8 rows in set (0.00 sec) mysql> drop database test_unicode; Query OK, 1 row affected (0.01 sec) mysql> CREATE DATABASE test_unicode DEFAULT CHARACTER SET utf8 DEFAULT COLLATE utf8_general_ci; Query OK, 1 row affected (0.00 sec) mysql> use test_unicode; Database changed mysql> create table simple_table (text varchar(100)) collate utf8_unicode_ci; Query OK, 0 rows affected (0.01 sec) mysql> INSERT INTO simple_table VALUES ('?'); Query OK, 1 row affected, 1 warning (0.00 sec) mysql> show warnings; +---------+------+-----------------------------------------------------------------------+ | Level | Code | Message | +---------+------+-----------------------------------------------------------------------+ | Warning | 1366 | Incorrect string value: '\xF0\x9F\x92\xA9' for column 'text' at row 1 | +---------+------+-----------------------------------------------------------------------+ 1 row in set (0.00 sec) mysql> delete from simple_table; Query OK, 1 row affected (0.00 sec) mysql> drop table simple_table; Query OK, 0 rows affected (0.00 sec) mysql> create table simple_table (text varchar(100)) collate utf8mb4_unicode_ci; Query OK, 0 rows affected (0.02 sec) mysql> INSERT INTO simple_table VALUES ('?'); Query OK, 1 row affected (0.01 sec) mysql> select * from simple_table; +------+ | text | +------+ | ? | +------+ 1 row in set (0.00 sec) mysql> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 03:29:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 02:29:23 +0000 Subject: [Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #2 from M. Tompsett --- https://dev.mysql.com/doc/refman/5.7/en/charset-unicode-utf8mb4.html Hope these point in a useful direction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 06:49:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 05:49:38 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #25 from David Cook --- (In reply to Marcel de Rooy from comment #24) > Misunderstanding? He talks about calling it without arguments (and without > warning). You mean calls with an argument (and warnings dependent on > context). Certainly a misunderstanding I think. Generates no warning: my @parameter_names = CGI->param(); Generates no warning: my $name = CGI->param("foo"); Generates a warning: my @name = CGI->param("foo"); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 06:52:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 05:52:36 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 --- Comment #21 from David Cook --- (In reply to Marcel de Rooy from comment #20) > This is an interesting topic but really outside the scope of this tiny > change. > The percentage of Debian users of Koha will probably be quite substantial > due to the tools developed for it. (We eventually switched from Fedora to > Debian for such reasons.) > The various install modes (default, single, dev), Debian packaging, > gitified, having possibly different directory structures etc., imo really > beg for being simplified and brough together. But realizing that is hard. In > the meantime the Debian percentage will keep growing? I think you're right. I think it's a worthwhile change :). I admit that I think about switching away from openSUSE to Debian for this reason as well, although we also run a few different versions of Koha on the same server, and that's something that the packages can't cope with I think. I would love if the different installation streams could use the same tools, but it is hard, and the Debian percentage probably is growing (and with good reason). Thanks for taking the time to reply :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 07:32:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 06:32:56 +0000 Subject: [Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #3 from M. Tompsett --- P.S. DataTables may not be as unicode friend as we would like for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 08:43:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 07:43:39 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #13 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #12) > (In reply to Galen Charlton from comment #10) > > I totally agree with the "what to do next" part, but what about now? My > patch seems to match your requirements. Jonathan, I am reading: "I am not keen about monkey patching a core module", which imo does not seem to translate to "match your requirements" :) I would not opt for a complete Koha::CGI at this point. But I would (slightly) prefer the Koha::CGI::multi_param above "*CGI::multi_param = \&CGI::param". It will make any developer immediately aware of our "interception". The switchover to the real multi_param at some point in time will be completely painless. Also note the different handling of the LIST_CONTEXT_WARN var. > It could be very easy and quick to replace the different occurrences. I > would like to avoid a temporary solution. Even if we need one, something > different than "FIXME bug 2505" would be better ;) Agreed, altough some code is temporary in any solution for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 09:28:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 08:28:34 +0000 Subject: [Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 --- Comment #9 from Katrin Fischer --- >1/ Generate a new one, insert the patron and display a warning >or >2/ Do not insert the patron and display an error Currently you only get the name/borrowernumber of the last patron who couldn't be loaded - which is really not helpful when you try to find out who are the missing ones. I think I a fine with both solutions - but the error/warning should show for each and help you identify them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 09:54:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 08:54:25 +0000 Subject: [Koha-bugs] [Bug 15854] New: Possible race condition for sending renewal notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15854 Bug ID: 15854 Summary: Possible race condition for sending renewal notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Renewal notices are sent as digests - all renewed items are collected in one e-mail that is sent out with the process_messagequeue. We have a library, where sometimes this doesn't work. Instead of one single e-mail notice to the patron for one 'process_messagequeue' interval, multiple renewal notices are generated. The majority of e-mails is generated correctly. Looking at the code, this is about how it works: - AddRenewal is exectuted per item and calls - SendCirculationAlert which calls - C4::Message->find_last_message to help decide if a new notice has to be generated or an existing one can be amended In order to test this, you need: - EnhancedMessagingPreferences - Check-out notice checked for the patron you test with - RenewalSendNotice activated - A notice called RENEWAL As I see no problem in the logic so far, I think it could be a race condition where find_last_message doesn't find an existing notice (yet)? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 10:56:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 09:56:57 +0000 Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:00:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:00:33 +0000 Subject: [Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5771 --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #9) > >1/ Generate a new one, insert the patron and display a warning > >or > >2/ Do not insert the patron and display an error > > Currently you only get the name/borrowernumber of the last patron who > couldn't be loaded - which is really not helpful when you try to find out > who are the missing ones. I think I a fine with both solutions - but the > error/warning should show for each and help you identify them. It's exactly the purpose of bug 5771. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:00:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:00:33 +0000 Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15840 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:09:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:09:23 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #2 from Zeno Tajoli --- In unumarc is possible to use Leader pos. 8 [Hierarchical code]. The value '1' means 'highest level record', so it is sure it has children. In MARC21 I think we need a proprietary subfield. I suggest one from tag 942. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:12:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:12:11 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #14 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #13) > (In reply to Jonathan Druart from comment #12) > > (In reply to Galen Charlton from comment #10) > > > > I totally agree with the "what to do next" part, but what about now? My > > patch seems to match your requirements. > > Jonathan, I am reading: "I am not keen about monkey patching a core module", > which imo does not seem to translate to "match your requirements" :) Sorry, I thought Galen was talking about patching CGI (solution suggested on the ML). > I would not opt for a complete Koha::CGI at this point. But I would > (slightly) prefer the Koha::CGI::multi_param above "*CGI::multi_param = > \&CGI::param". It will make any developer immediately aware of our > "interception". The switchover to the real multi_param at some point in time > will be completely painless. > > Also note the different handling of the LIST_CONTEXT_WARN var. Is anyone ready to submit a counter-patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:12:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:12:38 +0000 Subject: [Koha-bugs] [Bug 15855] New: Disabling multiple submission on search form Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15855 Bug ID: 15855 Summary: Disabling multiple submission on search form Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: arthur.suzuki at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org Created attachment 48203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48203&action=edit Extract from koha-opac-access_log Some impatient users tends to click several times on the ?Go? button of the search form on OPAC. Probably in a desperate hope that this will speed up the whole process. However the result is quite opposite, as Zebra is then queried multiple times which increases the server cpu load, until it reach 100% and cause Denial of Service (boooh?) We had the idea of disabling the ?searchsubmit? button upon first click. This is done by adding onclick=?this.disabled=true;this.form.submit();return true;? after ?id=searchsubmit? in masthead.inc. It is also possible to solve this issue by adding the following section to opacuser.js: $(document).ready(function() { $('#searchform').submit(function() { $('#searchsubmit').prop('disabled',true).text('searching...'); }); }); Thanks to Frederic Demians and Olivier Crouzet for their help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:15:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:15:50 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #3 from Katrin Fischer --- The 942 won't work in our use case for the same reason that we can't use EasyAnalatics. For libraries, where the bibliographic record is created outside of Koha and automatically kept in sync with the external master record, there is no way to have 'local' fields, because they will always be overwritten/deleted with an update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:16:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:16:34 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15809 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15809 --- Comment #26 from Jonathan Druart --- Yes sorry, didn't read carefully enough. What's missing to get a signoff? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 [Bug 15809] versions of CGI < 4.08 do not have multi_param -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:16:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:16:34 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15747 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:17:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:17:28 +0000 Subject: [Koha-bugs] [Bug 15840] Fix 'import borrowers' tool to not die when importing a file with blank 'userid' values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 --- Comment #11 from Katrin Fischer --- I know... but that's been there for a while :( If we wanted to stick with current the behaviour, I think the user should not be added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:24:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:24:54 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #17 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #16) > Just curious, this test does not test any part of Koha. What if it fails? I was thinking of the tests we have for C4::XISBN, but I may be not relevant, feel free to obsolete it. If the test fails, the feature will be broken. It would mean that the key "numFound" or the url has changed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:25:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:25:20 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #18 from Jonathan Druart --- s/I may/it may ... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:29:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:29:50 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #4 from Zeno Tajoli --- We can change the wording. >From "Analytics: Show analytics" to "Analytics: Search if present". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:30:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:30:30 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 --- Comment #27 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #26) > Yes sorry, didn't read carefully enough. > What's missing to get a signoff? I signed off Mark's patch. Your patch is more or less identical.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:32:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:32:47 +0000 Subject: [Koha-bugs] [Bug 15855] Disabling multiple submission on search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|3.18 |unspecified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:47:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:47:33 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:47:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:47:36 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48067|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy --- Created attachment 48204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48204&action=edit Bug 15747: Do not use CGI->param in list context - Auth.pm Test plan: Log you in! Without this patch applied, you will get a warning "Fetching the value or values of a single named parameter" With this patch applied, the warning from C4::Auth line 401 should not appear anymore in the log file. Signed-off-by: Marcel de Rooy Note: no warnings for older CGI versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:50:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:50:16 +0000 Subject: [Koha-bugs] [Bug 15747] Auth.pm flooding error log with "CGI::param called in list context" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #29 from Marcel de Rooy --- QA Comment: As you can see, this already received (too) much attention :) Taking the liberty to promote this trivial patch to PQA therefore. Note: I checked the specific variable auth_forwarded_hash. It is used to store the document.location.hash. Single value! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:51:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:51:29 +0000 Subject: [Koha-bugs] [Bug 15840] Import borrowers tool explodes if userid already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix 'import borrowers' tool |Import borrowers tool |to not die when importing a |explodes if userid already |file with blank 'userid' |exists |values | Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:51:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:51:41 +0000 Subject: [Koha-bugs] [Bug 15840] Import borrowers tool explodes if userid already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:56:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:56:44 +0000 Subject: [Koha-bugs] [Bug 15840] Import borrowers tool explodes if userid already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 11:56:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 10:56:47 +0000 Subject: [Koha-bugs] [Bug 15840] Import borrowers tool explodes if userid already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 --- Comment #12 from Jonathan Druart --- Created attachment 48205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48205&action=edit Bug 15840: Catch errors if userid already exists when importing patrons Import borrowers tool explodes if userid already exists. This error should be caught to avoid the script to explodes. Test plan: Import a csv file with the same userid used Without this patch, you will get a DBIx::class exception "Duplicate entry ' for key 'userid'" With this patch applied, these patrons won't be inserted but an error will be nicely displayed in the error list. Note that it would be easy to insert the patrons anyway and generate a userid based on the surname and firstname. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:14:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:14:14 +0000 Subject: [Koha-bugs] [Bug 15847] Correct JSHint errors in basket.js in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:14:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:14:16 +0000 Subject: [Koha-bugs] [Bug 15847] Correct JSHint errors in basket.js in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48197|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48206&action=edit Bug 15847: Correct JSHint errors in basket.js in the staff client This patch corrects minor errors in the staff client's basket.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on basket.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Test adding multiple titles to the Cart from staff client search results. - Confirm that adding titles to the Cart triggers a message by the Cart link. - Test clicking the "Cart" link in the header menu when the Cart popup is open but behind the main window. - Testing emptying the Cart. Signed-off-by: Hector Castro Works as described. No warnigns raised with jshint tool Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:31:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:31:13 +0000 Subject: [Koha-bugs] [Bug 15773] Checkboxes does not work correctly when creating a new subfield for an authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47826|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 48207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48207&action=edit Bug 15773: Fix and standardise checkboxes code in framework When creating a new subfield for an authority framework, the checkboxes don't behave as they should. If you click on the 'repeatable', 'mandatory' or 'is url' checkbox's label, the checkbox from the second tab will be checked/unchecked. This is caused by a non-unique id of the input element. I have found this bug when working on the removal of CGI::checkbox in both admin/auth_subfields_structure.pl and admin/marc_subfields_structure.pl scripts. This patch remove the use of CGI::checkbox as well as the generation of html code from these 2 pl scripts (which should be avoided). The code these scripts are now pretty similar. Test plan: Add/modify/remove subfield for a MARC framework and an Authority framework. Use as many field as possible and confirm that the values are correctly inserted/displayed. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:31:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:31:44 +0000 Subject: [Koha-bugs] [Bug 15773] Checkboxes does not work correctly when creating a new subfield for an authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773 --- Comment #6 from Jonathan Druart --- Rebased and removed deps on bug 15754 and bug 15771. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:31:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:31:50 +0000 Subject: [Koha-bugs] [Bug 15754] html tags displayed when editing frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15773 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773 [Bug 15773] Checkboxes does not work correctly when creating a new subfield for an authority framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:31:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:31:50 +0000 Subject: [Koha-bugs] [Bug 15773] Checkboxes does not work correctly when creating a new subfield for an authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15754, 15771 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 [Bug 15754] html tags displayed when editing frameworks https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15771 [Bug 15771] CGI::escapeHTML should not be used anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:31:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:31:50 +0000 Subject: [Koha-bugs] [Bug 15771] CGI::escapeHTML should not be used anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15771 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15773 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773 [Bug 15773] Checkboxes does not work correctly when creating a new subfield for an authority framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:32:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:32:38 +0000 Subject: [Koha-bugs] [Bug 15773] Checkboxes does not work correctly when creating a new subfield for an authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14308 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:32:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:32:38 +0000 Subject: [Koha-bugs] [Bug 14308] Remove CGI::checkbox from subfield editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14308 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15773 --- Comment #3 from Jonathan Druart --- Too bad that I have not seen your patch before, I have done the same job on bug 15773 :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:36:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:36:14 +0000 Subject: [Koha-bugs] [Bug 15773] Checkboxes does not work correctly when creating a new subfield for an authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:36:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:36:16 +0000 Subject: [Koha-bugs] [Bug 15773] Checkboxes does not work correctly when creating a new subfield for an authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48207|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 48208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48208&action=edit Bug 15843: Move MARC subfields structure JavaScript into separate file The JavaScript embedded in the MARC subfields structure template is not dependent on template processing and can safely be moved to a separate file. This patch does so. Removed in the process is some lines which were commented out. To test, apply the patch and go to Administration -> MARC framworks. - Click 'MARC structure' for a framework you can edit. - Click 'subfields' for a tag you can edit. - Click 'Edit' for a subfield you can edit. - Confirm that tabs and accordian sections work correctly. - Make changes under Advanced constraints -> Visibility and confirm that they are saved correctly. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:36:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:36:55 +0000 Subject: [Koha-bugs] [Bug 15843] Move MARC subfields structure JavaScript into separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:36:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:36:58 +0000 Subject: [Koha-bugs] [Bug 15843] Move MARC subfields structure JavaScript into separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15843 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48191|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48209&action=edit Bug 15843: Move MARC subfields structure JavaScript into separate file The JavaScript embedded in the MARC subfields structure template is not dependent on template processing and can safely be moved to a separate file. This patch does so. Removed in the process is some lines which were commented out. To test, apply the patch and go to Administration -> MARC framworks. - Click 'MARC structure' for a framework you can edit. - Click 'subfields' for a tag you can edit. - Click 'Edit' for a subfield you can edit. - Confirm that tabs and accordian sections work correctly. - Make changes under Advanced constraints -> Visibility and confirm that they are saved correctly. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:37:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:37:10 +0000 Subject: [Koha-bugs] [Bug 15773] Checkboxes does not work correctly when creating a new subfield for an authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:37:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:37:25 +0000 Subject: [Koha-bugs] [Bug 15773] Checkboxes does not work correctly when creating a new subfield for an authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48207|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:37:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:37:39 +0000 Subject: [Koha-bugs] [Bug 15773] Checkboxes does not work correctly when creating a new subfield for an authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #8 from Jonathan Druart --- Sorry for the noise, wrong bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:40:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:40:17 +0000 Subject: [Koha-bugs] [Bug 15844] Correct JSHint errors in staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:40:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:40:19 +0000 Subject: [Koha-bugs] [Bug 15844] Correct JSHint errors in staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48192|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48210&action=edit Bug 15844 - Correct JSHint errors in staff-global.js This patch corrects minor errors in staff-global.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on staff-global.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Confirm that the "Help" link opens the help window. - Confirm that audio alerts work with local and remote sound files - Confirm that the format() method is still working correctly by, for instance, opening the detail page for a bibliographic record with multiple items and choosing 'Edit -> Delete record' from the menu. The error message should read like "2 item(s) are attached to this record..." Signed-off-by: Hector Castro Works as described. No errors with JSHint CLI (6 errors fixed) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:57:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:57:44 +0000 Subject: [Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11944 --- Comment #4 from Jonathan Druart --- See bug 11944 comment 247 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 12:57:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 11:57:44 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15794 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 13:08:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 12:08:41 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #19 from Srdjan Jankovic --- OK, that makes sense. I was more thinking of tests auto run, and for some reason http request fails (site down, timeout etc) that raises red alert. But I'm probably taking it too far. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 13:48:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 12:48:16 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #15 from Galen Charlton --- (In reply to Marcel de Rooy from comment #13) > Jonathan, I am reading: "I am not keen about monkey patching a core module", > which imo does not seem to translate to "match your requirements" :) > I would not opt for a complete Koha::CGI at this point. But I would > (slightly) prefer the Koha::CGI::multi_param above "*CGI::multi_param = > \&CGI::param". It will make any developer immediately aware of our > "interception". The switchover to the real multi_param at some point in time > will be completely painless. Indeed, Marcel has correctly identified what I was trying to say -- I meant "core module" in the sense of a module typically distributed with Perl, not a Koha module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 13:52:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 12:52:49 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #16 from Galen Charlton --- (In reply to Jonathan Druart from comment #14) > Is anyone ready to submit a counter-patch? Working on one that is intended to actually fix at least some of the potential vulnerabilities. I feel that this bug's title is not ideal, as the focus should be on resolving potential misuse of CGI parameters, not merely on quelling noisy warnings in the logs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 14:14:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 13:14:43 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 14:22:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 13:22:20 +0000 Subject: [Koha-bugs] [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818 --- Comment #5 from Dobrica Pavlinusic --- Interesting. I have libencode-perl which is 2.63 and I do get application error. I guess that built-in Encode is less strict, but anyway, this patch helps :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 15:19:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 14:19:14 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 rhilliker at hotchkiss.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rhilliker at hotchkiss.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 16:08:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 15:08:15 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|francescamoore at catalyst.net |oleonard at myacpl.org |.nz | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 16:16:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 15:16:27 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 16:16:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 15:16:30 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 --- Comment #8 from Owen Leonard --- Created attachment 48211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48211&action=edit Bug 15600 - System preferences broken toolbar looks broken This patch reverts some deletions made to staff-global.css in Bug 11559. The deletions broke the appearance of the floating toolbar in system preferences. To test, apply the patch and clear your browser cache if necessary. - Go to Administration -> System preferences and view a tab with enough content to allow you to scroll and test the appearance of the floating toolbar. Confirm that it looks correct. - Open the advanced cataloging editor and confirm that its toolbar looks correct. - Open the normal cataloging editor and confirm that the floating toolbar looks correct and works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 16:37:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 15:37:30 +0000 Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from R?mi Mayrand-Provencher --- I tested this patch again by applying it on a clean version of master and it worked properly. Could you test it again? Here's a clearer test plan to make sure that nothing breaks while testing. Thank you! Test plan : 1)Apply patch 2)Select an existing patron that doesn't have an oustanding fine 3)Check out a book for this patron 4)Click the "Restriction" tab 5)Click "Add manual restriction" 6)Write any comment and leave expiration date blank 7)Validate text on patron's checkout page: "Cannot check out! Restricted: Patron's account is restricted with the explanation:" 8)Check in the book that you checked out at step 2 9)Validate the warning message: "Check in message 013880: Heart health for Canadians : Reminder: Patron has an indefinite restriction." Then you can redo these steps and change the date at step 6 to see different messages at step 8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 17:20:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 16:20:33 +0000 Subject: [Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #4 from Nick Clemens --- I suppose a syspref then? CircRuleUndefinedCheckout: Yes/No/Warn CircRuleUndefinedCheckoutPeriod: default(21) So default is 'Yes/Allow' for 21 days? (In reply to Jonathan Druart from comment #3) > We could change the different occurrences of > if defined($loanlength) && $loanlength->{issuelength}; > with > if defined($loanlength) && defined $loanlength->{issuelength}; > To take into account the "0". > And do not default to 0 when defining the circ rules but NULL instead. > > The only problem is that these behavior changes could be considered as a bug > for existing installations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 17:28:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 16:28:40 +0000 Subject: [Koha-bugs] [Bug 15463] view_holdsqueue.tt uses a search for cardnumber instead of borrowernumber direct link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15463 --- Comment #2 from Nick Clemens --- It seems like we add a call to GetMember to get the borrowernumber from the cardnumber when we could just as easily provide the borrowernumber directly. Maybe it doesn't have an impact, just feels like it would be more clean the other way. (In reply to Jonathan Druart from comment #1) > I don't understand what is the problem here -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 17:31:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 16:31:24 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48177|0 |1 is obsolete| | Attachment #48178|0 |1 is obsolete| | Attachment #48179|0 |1 is obsolete| | Attachment #48180|0 |1 is obsolete| | Attachment #48181|0 |1 is obsolete| | Attachment #48182|0 |1 is obsolete| | --- Comment #155 from Kyle M Hall --- Created attachment 48212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48212&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 17:31:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 16:31:34 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #156 from Kyle M Hall --- Created attachment 48213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48213&action=edit Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 17:31:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 16:31:38 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #157 from Kyle M Hall --- Created attachment 48214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48214&action=edit Bug 14610 - Add and update scripts Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 17:31:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 16:31:42 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #158 from Kyle M Hall --- Created attachment 48215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48215&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 17:31:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 16:31:47 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #159 from Kyle M Hall --- Created attachment 48216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48216&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 17:31:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 16:31:51 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #160 from Kyle M Hall --- Created attachment 48217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48217&action=edit Bug 14610 - Update opac.css via less -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 17:31:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 16:31:55 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #161 from Kyle M Hall --- Created attachment 48218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48218&action=edit Bug 14610 [QA Followup] - Get rid of separate scripts just for creating new requests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 17:43:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 16:43:24 +0000 Subject: [Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 17:43:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 16:43:26 +0000 Subject: [Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47311|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 48219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48219&action=edit Bug 15669 - alphabetize marc modification templates This patch sorts the modification templates when getting them from the database This affects the pages below: tools/batch_record_modification.pl tools/marc_modification.pl tools/stage-marc-import.pl tools/stage-marc-import.pl To test: 1 - Add some marc modification templates in a non alpha order (Shoes, Hats, Cats) 2 - visit the pages above and note the templates are in order added 3 - apply patch 4 - visit the three pages and note correct order 5 - verify all tools continue to work as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 17:44:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 16:44:09 +0000 Subject: [Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 --- Comment #5 from Nick Clemens --- This was my first though, no idea what changed my mind, but I have done it this way now :-) (In reply to Jonathan Druart from comment #3) > Maybe the best way would be to modify GetModificationTemplates and sort the > entries at the DB level (order by clause). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 18:06:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 17:06:23 +0000 Subject: [Koha-bugs] [Bug 15856] New: Serials Software error when saving new subscription Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15856 Bug ID: 15856 Summary: Serials Software error when saving new subscription Change sponsored?: --- Product: Koha Version: 3.18 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: saidshafik at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Created attachment 48220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48220&action=edit Screen shots of new subscription form entries, and software errors we got after Serials crashes When adding a new subscription, and after filling all fields on form, reviewing patterns, click on "Save", Serials crashes and gives the attached message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 18:12:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 17:12:11 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 --- Comment #13 from Humberto Blanco --- Today review and found that nothing is happend if i found "topographic signature" 340.1 or 340.12 or failed when search some terms that use spaces in the url the system puts + to do this and the problem appears like indexes for example in advanced search : (idx=kw%2Cphr, q=la+informalidad+laboral) http://catalogo.urosario.edu.co:8080/cgi-bin/koha/catalogue/search.pl?idx=kw%2Cphr&q=la+informalidad+laboral&op=and&idx=kw&op=and&idx=kw&sort_by=relevance In general search failed http://catalogo.urosario.edu.co:8080/cgi-bin/koha/catalogue/search.pl?q=la+informalidad+laboral -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 18:13:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 17:13:25 +0000 Subject: [Koha-bugs] [Bug 15671] Show branch name instead of branch code in checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15671 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48199|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 48221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48221&action=edit Bug 15671 - Show branch name instead of branch code in checkout history When viewing the checkout history for a title the branchcode is displayed. This patch alters the template to show the library name instead. To test, apply the patch and locate a title in the staff client which has been checked out at least once. From the detail page, click "Checkout history" in the sidebar. The "Checked out from" column of the checkout history table should show the library name instead of the branchcode. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 18:13:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 17:13:52 +0000 Subject: [Koha-bugs] [Bug 15671] Show branch name instead of branch code in checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15671 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 18:26:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 17:26:50 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47477|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 19:35:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 18:35:35 +0000 Subject: [Koha-bugs] [Bug 15857] New: Add test mode to process_message_queue.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 Bug ID: 15857 Summary: Add test mode to process_message_queue.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be nice for testing and migration purposes if we could run process_message_queue.pl but have the emails go to a testing address instead of the patron's email address, and have SMS messages go to a testing phone number instead of the patron's sms number. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 19:37:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 18:37:50 +0000 Subject: [Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #12 from Fr?d?ric Demians --- Patches pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 19:53:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 18:53:41 +0000 Subject: [Koha-bugs] [Bug 15857] Add test mode to process_message_queue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 19:53:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 18:53:43 +0000 Subject: [Koha-bugs] [Bug 15857] Add test mode to process_message_queue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 --- Comment #1 from Kyle M Hall --- Created attachment 48222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48222&action=edit Bug 15857 - Add test mode to process_message_queue.pl It would be nice for testing and migration purposes if we could run process_message_queue.pl but have the emails go to a testing address instead of the patron's email address, and have SMS messages go to a testing phone number instead of the patron's sms number. Test Plan: 1) Apply this patch 2) Add some stuff to the message queue however you wish 3) Run process_message_queue.pl with the addition parameters --test --test-email your at email.com 4) Note that you recieve those emails, and not the address listed in the message_queue table! 5) Bonus points: If you have an SMS service, repeat the test with SMS notices and --test-sms -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 19:53:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 18:53:57 +0000 Subject: [Koha-bugs] [Bug 15857] Add test mode to process_message_queue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 21:48:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 20:48:51 +0000 Subject: [Koha-bugs] [Bug 10674] System preferences not marked as modified after paste In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10674 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Jesse Weaver --- *** This bug has been marked as a duplicate of bug 14389 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 21:48:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 20:48:51 +0000 Subject: [Koha-bugs] [Bug 14389] Editing a syspref in a textarea does not enable the Save button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m --- Comment #22 from Jesse Weaver --- *** Bug 10674 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 21:49:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 20:49:29 +0000 Subject: [Koha-bugs] [Bug 12272] Refactor C4::Service API into Koha::Service class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #4 from Jesse Weaver --- ... due to REST API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 21:49:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 20:49:29 +0000 Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Bug 13630 depends on bug 12272, which changed state. Bug 12272 Summary: Refactor C4::Service API into Koha::Service class https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 21:49:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 20:49:30 +0000 Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Bug 13733 depends on bug 12272, which changed state. Bug 12272 Summary: Refactor C4::Service API into Koha::Service class https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 21:49:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 20:49:31 +0000 Subject: [Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 Bug 13737 depends on bug 12272, which changed state. Bug 12272 Summary: Refactor C4::Service API into Koha::Service class https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 21:49:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 20:49:31 +0000 Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 Bug 13738 depends on bug 12272, which changed state. Bug 12272 Summary: Refactor C4::Service API into Koha::Service class https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 21:49:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 20:49:54 +0000 Subject: [Koha-bugs] [Bug 15858] New: Use Font Awesome icons in dialog alert for addorder.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15858 Bug ID: 15858 Summary: Use Font Awesome icons in dialog alert for addorder.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: hector.hecaxmmx at gmail.com Reporter: hector.hecaxmmx at gmail.com QA Contact: testopia at bugs.koha-community.org A warning is raised when order amount exceed budget or fund this dialog needs to be styled with Font Awesome icons. File: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorder.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 21:50:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 20:50:29 +0000 Subject: [Koha-bugs] [Bug 15858] Use Font Awesome icons in dialog alert for addorder.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15858 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 21:54:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 20:54:32 +0000 Subject: [Koha-bugs] [Bug 15858] Use Font Awesome icons in dialog alert for addorder.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15858 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 21:54:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 20:54:34 +0000 Subject: [Koha-bugs] [Bug 15858] Use Font Awesome icons in dialog alert for addorder.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15858 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 48223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48223&action=edit Bug 15858: Use Font Awesome icons in dialog alert for addorder.tt A warning is raised when order amount exceed budget or fund this dialog needs to be styled with Font Awesome icons. To test: -Add orders to a basket -Exceed a fund or budget -Notice about the dialog alert -Apply patch -Exceed again and see the new icons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 22:32:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 21:32:53 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #15 from Jesse Weaver --- (In reply to Jonathan Druart from comment #11) > Jesse, yes it should be the way to go but.. > I have already tried something and was stuck. I have a wip branch but I > don't remember what was wrong. > > Looking at the diff it seems that I have tried to add a > DeleteBorrowerAttributes subroutines and the code looks quite complicated: > > +sub DeleteBorrowerAttributes { > + my $borrowernumber = shift; > + my $no_branch_limit = @_ ? shift : 0; > + my $branch_limit = $no_branch_limit > + ? 0 > + : C4::Context->userenv ? C4::Context->userenv->{"branch"} : 0; > + > + my $dbh = C4::Context->dbh; > + my $query = q{ > + DELETE FROM borrower_attributes > + }; > + $query .= q{ > + LEFT JOIN borrower_attribute_types_branches ON bat_code = code > + WHERE b_branchcode = ? OR b_branchcode IS NULL > + } if $branch_limit; > + $query .= q{ > + WHERE borrowernumber = ? > + }; > + > + $dbh->do( $query, undef, $branch_limit ? $branch_limit : (), > $borrowernumber ); > +} That honestly looks exactly like what I would have done. Why send the hidden attributes in memberentrygen.tt, though, if DeleteBorrowerAttributes is branch-limited? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 22:36:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 21:36:06 +0000 Subject: [Koha-bugs] [Bug 15531] Add support for standing orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #7 from Liz Rea --- Aleisha, I think I know what your problem may be here, come find me next time you're in. :) Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 22:56:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 21:56:18 +0000 Subject: [Koha-bugs] [Bug 15724] Add possibility to export notice in marc format in z39.50 results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15724 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Marjorie - have you tried the new cataloguing editor? You can do a Z39.50 search, click import and then export it (save to catalog pull down - save to xml/iso) without saving it to your catalog. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 18 23:00:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 22:00:16 +0000 Subject: [Koha-bugs] [Bug 15852] 3M selfCheck do not connect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15852 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi, could this be a duplicate to bug 14507? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 00:07:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 23:07:40 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 00:07:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Feb 2016 23:07:43 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #3 from Jesse Weaver --- Created attachment 48224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48224&action=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 09:31:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 08:31:31 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |m.de.rooy at rijksmuseum.nl QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 09:44:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 08:44:36 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #10 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 09:46:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 08:46:13 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #15 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.4 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 09:49:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 08:49:17 +0000 Subject: [Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 09:58:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 08:58:47 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #5 from Marcel de Rooy --- QA Comment: I am not sure if this really is a better solution. I also doubt about the remark in comment 1 "Apparently older versions of Koha considered a MARC subfield in the frameworks that had a code longer than one character to be reserved for internal use". To me it just seems to be a trick to skip the internal fields lib, tab, mandatory and repeatable (all length>1). In terms of design it would have been easier to put all subfields a level deeper instead of on the same level as lib, etc. I understand about not changing the design of the structure here. But now we move the test length<>1 from a subroutine into the code and check if it is a ref or not. I probably would like to still have the test in the subroutine (with all benefits of a subroutine); another name would be fine. If someone wants to add some other property to the structure and suppose that is an arrayref or a hashref or an object, your test would fail. I would propose to test (in the sub): [a] skip if the field name matches lib|tab|mandatory|repeatable or [b] proceed if the field is a ref called MARC::Field (instead of testing if ref is true, we test ref eq ..) Obviously, I agree with removing the call for a loop on only real subfields. Changing status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 10:00:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 09:00:24 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 --- Comment #6 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #5) > or [b] proceed if the field is a ref called MARC::Field (instead of testing > if ref is true, we test ref eq ..) Oops. That is not true. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 10:27:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 09:27:25 +0000 Subject: [Koha-bugs] [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 10:27:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 09:27:44 +0000 Subject: [Koha-bugs] [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818 --- Comment #6 from Marcel de Rooy --- Cannot reproduce this with Encode 2.42 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 10:34:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 09:34:15 +0000 Subject: [Koha-bugs] [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48051|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 48225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48225&action=edit Bug 15818 - OPAC search with utf-8 characters and without results generates encoding error When searching for something in OPAC which doesn't result in any results but have utf-8 characters in search string we get following encoding error: Cannot decode string with wide characters at /usr/lib/i386-linux-gnu/perl5/5.20/Encode.pm line 215. This is because we are trying to decode string which is allready correctly marked as utf-8. Test scenario: 1) enter search string with utf-8 characters in opac which doesn't return any results 2) verify that you get application error 3) apply this patch 4) re-run query and verify that errror is gone Signed-off-by: Jonathan Druart Step 0: Define "OPACNoResultsFound" with '{QUERY_KW}' Note that I don't get the error (Encode 2.60) but the search terms are not display correctly. Signed-off-by: Marcel de Rooy The variable to be decoded comes from already decoded vars (via the -utf8 flag from CGI), following the trail in Search.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 10:34:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 09:34:13 +0000 Subject: [Koha-bugs] [Bug 15818] OPAC search with utf-8 characters and without results generates encoding error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15818 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 10:38:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 09:38:48 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 10:45:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 09:45:28 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply --- Comment #31 from Marcel de Rooy --- The patch does not apply anymore. Additionally, reading the discussion, how can I generate some performance figures to compare with the different figures given already? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 10:48:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 09:48:05 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #16 from Marcel de Rooy --- (In reply to David Cook from comment #15) > > + - LIBRIS Spellcheking API key > There is a typo here, but perhaps QA can fix it? Really nice typo at the right spot :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 11:03:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 10:03:32 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 11:24:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 10:24:11 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Marcel de Rooy --- QA Comment: Nice addition, Eivin. First I am stumbling over the hardcoded Swedish libris server in the code. Nothing against Sweden btw, but could we put that URL in a pref or config somewhere else? In this case you could add both prefs in one entry like some other prefs are organized (e.g. DefaultLongOverdueLostValue and DefaultLongOverdueDays ). Another small point is: Please add the new pref(s) to sysprefs.sql To test error checking, I changed the URL. Clicking on suggestions gave me: File does not exist: Can't connect to api.libris.kb.nl:80 (Bad hostname) LWP::Protocol::http::Socket: Bad hostname 'api.libris.kb.nl' Could you add some checks around line 34? What is the return value if get does not connect etc? Or when given an expired key? And in terms of security. You get $search from CGI param and directly feed it into LWP. Should we do some sanitizing here? When testing some searches, I always got only one alternative. Do you have examples where I get various results back? And the typo in spellcheking is hilarious. But please correct. Changing status to reflect need for some adjustments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 11:39:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 10:39:36 +0000 Subject: [Koha-bugs] [Bug 15126]=?UTF-8?Q?=20REST=C2=A0API?=: Use newer version of Swagger2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47843|0 |1 is obsolete| | Attachment #47844|0 |1 is obsolete| | --- Comment #16 from Olli-Antti Kivilahti --- Created attachment 48226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48226&action=edit Newest Swagger-spec validated 100% and pushed to production yay! Includes the swaggerMinifier.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 11:47:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 10:47:33 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #44 from Marcel de Rooy --- I could rebase the first three but then the fourth complained about useless sha1 info on Accounts.t Please rebase and squash all patches. Or at least squash all QA follow-ups. You could add the signoff from Chris (on the first one), but if you do, please add a line that the patch was amended after that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 12:08:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 11:08:43 +0000 Subject: [Koha-bugs] [Bug 15833] Bad variable value in renewal template confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 12:08:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 11:08:45 +0000 Subject: [Koha-bugs] [Bug 15833] Bad variable value in renewal template confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48146|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 48227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48227&action=edit Bug 15833: item.biblioitemnumber returns a biblioitem DBIx::Class object 2 links are wrong on the renew page, because item.biblioitemnumber does not return the biblioitemnumber as expect the template. Test plan: Renew an item and check the item link. It should contain a valid biblioitemnumber for the 'bi' parameter. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Link repaired. At first glance, I am wondering if biblioitemnumber is of actual use here; is it only passed back and forth between script and template? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 12:08:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 11:08:59 +0000 Subject: [Koha-bugs] [Bug 15833] Bad variable value in renewal template confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 12:36:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 11:36:55 +0000 Subject: [Koha-bugs] [Bug 15858] Use Font Awesome icons in dialog alert for addorder.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15858 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48223|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 48228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48228&action=edit Bug 15858: Use Font Awesome icons in dialog alert for addorder.tt A warning is raised when order amount exceed budget or fund this dialog needs to be styled with Font Awesome icons. To test: -Add orders to a basket -Exceed a fund or budget -Notice about the dialog alert -Apply patch -Exceed again and see the new icons Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 12:44:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 11:44:59 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #18 from Katrin Fischer --- I am not sure about a preference here as it's a plugin for a specific API (LibrisSpellcheck.pm). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 13:31:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 12:31:41 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to #not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #3 from Kyle M Hall --- I cannot re-create this bug. Is the test plan incomplete, or has this been fixed in master incidentally? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 13:34:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 12:34:41 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to #not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 --- Comment #4 from Katrin Fischer --- We have tested this on 3.22.3 - there it's definitely a problem. Have you set the system preference? It will hide several options from the form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 13:34:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 12:34:52 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to 'not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't create private lists |Can't create private lists |if |if |OpacAllowPublicListCreation |OpacAllowPublicListCreation |is set to #not allow' |is set to 'not allow' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 13:36:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 12:36:22 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to 'not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 --- Comment #5 from Kyle M Hall --- (In reply to Katrin Fischer from comment #4) > We have tested this on 3.22.3 - there it's definitely a problem. > Have you set the system preference? It will hide several options from the > form. Yes, I enabled the syspref which made "private" the only list option available. Can you confirm you can recreate the bug on master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 13:37:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 12:37:02 +0000 Subject: [Koha-bugs] [Bug 14507] SIP Authentication broken when LDAP Auth Enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #41379|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 13:37:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 12:37:47 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to 'not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 --- Comment #6 from Katrin Fischer --- Sorry - can't check right now, will try later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 13:52:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 12:52:01 +0000 Subject: [Koha-bugs] [Bug 14507] SIP Authentication broken when LDAP Auth Enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 13:52:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 12:52:03 +0000 Subject: [Koha-bugs] [Bug 14507] SIP Authentication broken when LDAP Auth Enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48045|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 48229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48229&action=edit Bug 14507 Use checkpw to check password in Patron Info Some devices are using patron information responses to validate patron passwords to govern access to facilities as we were using C4::Auth::checkpw_hash this only worked in a db password context not other authentication routines. The C4::Auth routines are not very consistent and there isnt a dropin replacement for checkpw_hash this calls checkpw instead. In a password only environment this behaves as the old version did returning field CQ as Y if a valid password or no password is passed in the patron info request and N if an incorrect password is supplied It should also test against the appropriate authentication sources if othere autrhentication schemes are in use Signed-off-by: Liz Rea Tested this with a client who reports that this enables SIP authentication to work correctly with their LDAP server. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 13:52:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 12:52:13 +0000 Subject: [Koha-bugs] [Bug 14507] SIP Authentication broken when LDAP Auth Enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507 --- Comment #7 from Kyle M Hall --- Created attachment 48230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48230&action=edit Bug 14507 [QA Followup] - Restore comment, tidy sub Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 13:56:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 12:56:49 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #19 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #18) > I am not sure about a preference here as it's a plugin for a specific API > (LibrisSpellcheck.pm). Please explain further. Plugin is read here in the context of SuggestionEngine. The word has become overloaded in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 13:59:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 12:59:50 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #20 from Katrin Fischer --- Looking at the code this seems a very specific feature, like Amazon-Covers, Syndectics, etc. Koha::SuggestionEngine::Plugin::LibrisSpellcheck; So if the URL is always the same and there is no other service this plugin works with - a configuration option doesn't seem necessary. ... and yes, we have multiples of plugins now (cataloguing, those, the plugin system...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 14:23:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 13:23:21 +0000 Subject: [Koha-bugs] [Bug 15852] 3M selfCheck do not connect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15852 Humberto Blanco changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #2 from Humberto Blanco --- Finally, i adjust the time alive in 3m selfcheckout machines, and works for me. Thanks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 14:43:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 13:43:56 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to 'not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 --- Comment #7 from Kyle M Hall --- (In reply to Katrin Fischer from comment #6) > Sorry - can't check right now, will try later. Confirmed the bug. I was looking in the wrong place ; ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 14:49:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 13:49:10 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to 'not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 --- Comment #8 from Katrin Fischer --- Yay! something off the to-do list :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 14:51:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 13:51:08 +0000 Subject: [Koha-bugs] [Bug 15859] New: Move some basic MARC editor controls into settings menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15859 Bug ID: 15859 Summary: Move some basic MARC editor controls into settings menu Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/addbiblio.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 48231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48231&action=edit Screenshot of the proposed change I think it would simplify the "basic" MARC editor a little to move some controls into a "Settings" menu similar to the one in the advanced editor. I propose that these items be included in the menu: - Switch to advanced editor - Show MARC tag documentation links - Show tags - Change framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 14:53:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 13:53:51 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to 'not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 14:53:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 13:53:54 +0000 Subject: [Koha-bugs] [Bug 15810] Can't create private lists if OpacAllowPublicListCreation is set to 'not allow' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47985|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 48232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48232&action=edit Bug 15810: Make sure the CGI->param is not called in a list context when creating private shelves This patch fixes the following bug: If OpacAllowPublicListCreation is set to "not allow", the creation of a private list raises an error at the OPAC. CGI->param is called in a list context and some parameters are not filled from the template if the pref is set to "not allow". To make sure we don't have a "Odd number of elements in anonymous hash", we force the context to scalar. Test plan: 1/ Set OpacAllowPublicListCreation to "not allow" 2/ Create private and public lists at the OPAC and the intranet => Everything should work fine with this patch applied Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 14:54:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 13:54:33 +0000 Subject: [Koha-bugs] [Bug 15811] Redirect after adding a new list in OPAC broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15811 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48003|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 48233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48233&action=edit Bug 15811: follow-up Bug 4912: Redirect to the appropriate view after editing/deleting a list Test plan: 1/ At the opac, go on the the list home page (opac-shelves.pl) 2/ Click on 'new list', create a list and save => You should be redirect to the list 3/ Click on edit, save => You should be redirect to the list 4/ Delete the list => You should be redirect to the list 5/ Edit a list from the list view, save => You should be redirect to the list 6/ Click on a list link (op=view) 7/ Edit the list, save => You should be redirect to the 'show' view 8/ Delete list => You should be redirect to the list Signed-off-by: Hector Castro Works as advertised Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 14:54:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 13:54:31 +0000 Subject: [Koha-bugs] [Bug 15811] Redirect after adding a new list in OPAC broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15811 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 15:05:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 14:05:35 +0000 Subject: [Koha-bugs] [Bug 15858] Use Font Awesome icons in dialog alert for addorder.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15858 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 15:06:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 14:06:16 +0000 Subject: [Koha-bugs] [Bug 15859] Move some basic MARC editor controls into settings menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15859 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 15:06:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 14:06:18 +0000 Subject: [Koha-bugs] [Bug 15859] Move some basic MARC editor controls into settings menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15859 --- Comment #1 from Owen Leonard --- Created attachment 48234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48234&action=edit Bug 15859 - Move some basic MARC editor controls into settings menu This patch moves the following options into a "Settings" menu inspired by the one in the advanced editor: - Switch to advanced editor - Show MARC tag documentation links - Show tags - Change framework To test, apply the patch and open a new or existing record in the standard MARC editor. - Test that the 'Switch to advanced editor' button option works. - Test that the 'Show MARC tag documenation links' option works (and that your choice persists across sessions). - Test that the initial settings for 'Show tags' respects the 'hide_marc' system preference. - Test that the 'Show tags' option works (and that your choice persists across sessions). - Test that framework switching works correctly and that the menu correctly reflects your choice. - Confirm that other toolbar functions work as expected, both in regular editing mode and Fast Cataloging. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 15:08:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 14:08:56 +0000 Subject: [Koha-bugs] [Bug 15860] New: Alias missing for /plugin on packages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15860 Bug ID: 15860 Summary: Alias missing for /plugin on packages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Created attachment 48235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48235&action=edit Broken image There is an alias missing on the packages-shipped apache templates. It prevents some things to show on the UI. To test: - Enable the plugins - Install libmarc-lint-perl - Install the MARC checker plugin (https://github.com/bywatersolutions/koha-plugin-marc-checker) - Run the plugin => FAIL: There's a broken image link (see attachment) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 15:17:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 14:17:48 +0000 Subject: [Koha-bugs] [Bug 15861] New: No chance to correctly translate an isolated word "The" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15861 Bug ID: 15861 Summary: No chance to correctly translate an isolated word "The" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr English: The German: Der? Die? Das? Locations: intranet-tmpl/prog/en/modules/help/reports/reports-home.tt:11 intranet-tmpl/prog/en/modules/help/reports/reports-home.tt:12 intranet-tmpl/prog/en/modules/help/rotating_collections/rotatingCollections.tt:7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 15:21:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 14:21:25 +0000 Subject: [Koha-bugs] [Bug 15855] Disabling multiple submission on search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15855 --- Comment #1 from Arthur Suzuki --- Here is the code designed by Olivier : // multi soumission Enter var submitted; $('#translControl1').bind('keyup',function() { submitted = false; }); $('#translControl1').bind('keydown',function(event) { code = event.keyCode||event.which||event.charCode||event.char||0; if(code == 13) { if (submitted == false) { submitted = true; $('#searchform').submit(); } else { event.preventDefault(); event.returnValue = false; return false; } } }); The use of keyCode permits to submit form only once, and only uppon key down event. It prevents the users to fire multiple searches while holding the "Return" key down (a behavior which is still possible with previously shared code). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 15:40:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 14:40:44 +0000 Subject: [Koha-bugs] [Bug 15071] In OPAC search results, "checked out" status should be more visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 15:40:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 14:40:46 +0000 Subject: [Koha-bugs] [Bug 15071] In OPAC search results, "checked out" status should be more visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48201|0 |1 is obsolete| | --- Comment #11 from Nicole C. Engard --- Created attachment 48236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48236&action=edit [SIGNED-OFF] Bug 15071 - In OPAC search results, "checked out" status should be more visible The prog template in the OPAC designated a color for the "unavailable" class associated with items in search results which are checked out. This class never made it into the Bootstrap theme. This patch adds it to the Bootstrap theme's LESS file. To test, apply the patch and search the OPAC for terms that will return checked out items. In the list of search results, on the "availability" line, the "Checked out" text should now be red. The change is visible with XSLT on or off. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 15:40:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 14:40:56 +0000 Subject: [Koha-bugs] [Bug 15071] In OPAC search results, "checked out" status should be more visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48202|0 |1 is obsolete| | --- Comment #12 from Nicole C. Engard --- Created attachment 48237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48237&action=edit [SIGNED-OFF] Bug 15071 - In OPAC search results, "checked out" status should be more visible Compiled CSS file. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 15:59:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 14:59:12 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #21 from Eivin Giske Skaaren --- Hi, It seems like they have changed the url to http://api.libris.kb.se/bibspell/ so perhaps some way of changing it without committing code would be good. Please advise on the preferred solution. As Katrin already said this is a specific API for the Swedish libraries so it might not be useful for search in other languages. I also think it is very specific to what is in their catalog, it is not a generic spell-checker but a specialized one for existing library items. PS. Nice typo yes, thats what you get from coding on a laptop late at night :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:00:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:00:44 +0000 Subject: [Koha-bugs] [Bug 15859] Move some basic MARC editor controls into settings menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15859 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48234|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 48238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48238&action=edit [SIGNED-OFF]Bug 15859: Move some basic MARC editor controls into settings menu This patch moves the following options into a "Settings" menu inspired by the one in the advanced editor: - Switch to advanced editor - Show MARC tag documentation links - Show tags - Change framework To test, apply the patch and open a new or existing record in the standard MARC editor. - Test that the 'Switch to advanced editor' button option works. - Test that the 'Show MARC tag documenation links' option works (and that your choice persists across sessions). - Test that the initial settings for 'Show tags' respects the 'hide_marc' system preference. - Test that the 'Show tags' option works (and that your choice persists across sessions). - Test that framework switching works correctly and that the menu correctly reflects your choice. - Confirm that other toolbar functions work as expected, both in regular editing mode and Fast Cataloging. Signed-off-by: Hector Castro Works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:00:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:00:56 +0000 Subject: [Koha-bugs] [Bug 15859] Move some basic MARC editor controls into settings menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15859 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:20:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:20:00 +0000 Subject: [Koha-bugs] [Bug 15862] New: Cataloging editor should gracefully handle unknown biblionumbers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15862 Bug ID: 15862 Summary: Cataloging editor should gracefully handle unknown biblionumbers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl If you try to open a record in the basic MARC editor by passing bad or deleted biblionumber you get an error: Can't call method "title" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 827. We should show a friendlier error message to the user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:22:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:22:44 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46962|0 |1 is obsolete| | --- Comment #9 from H?ctor Eduardo Castro Avalos --- Created attachment 48241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48241&action=edit [SIGNED-OFF]Bug 15600: System preferences broken toolbar looks broken To test: 1-see without patch the toolbar looks transparent and "broken" 2-apply patch, with this the toolbar is solid and has new colours (including the hover) -see screenshots for examples 3-try scrolling on different tabs to the left eg "OPAC" and that the style continues with them Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:22:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:22:54 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48211|0 |1 is obsolete| | --- Comment #10 from H?ctor Eduardo Castro Avalos --- Created attachment 48242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48242&action=edit [SIGNED-OFF]Bug 15600: System preferences broken toolbar looks broken This patch reverts some deletions made to staff-global.css in Bug 11559. The deletions broke the appearance of the floating toolbar in system preferences. To test, apply the patch and clear your browser cache if necessary. - Go to Administration -> System preferences and view a tab with enough content to allow you to scroll and test the appearance of the floating toolbar. Confirm that it looks correct. - Open the advanced cataloging editor and confirm that its toolbar looks correct. - Open the normal cataloging editor and confirm that the floating toolbar looks correct and works correctly. Signed-off-by: Hector Castro Works as advertised. Tollbar looks correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:23:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:23:38 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:25:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:25:56 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:25:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:25:59 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48136|0 |1 is obsolete| | Attachment #48137|0 |1 is obsolete| | Attachment #48138|0 |1 is obsolete| | Attachment #48139|0 |1 is obsolete| | Attachment #48140|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 48243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48243&action=edit Bug 15635: Koha::Patron::Images - Add new classes There are 3 subroutines in C4::Members to get, add and delete patron images: - GetPatronImage - PutPatronImage - RmPatronImage By creating these 2 Koha::Patron::Image[s] classes, we could remove them easily. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:26:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:26:28 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48243|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 48244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48244&action=edit Bug 15635: Koha::Patron::Images - Add new classes There are 3 subroutines in C4::Members to get, add and delete patron images: - GetPatronImage - PutPatronImage - RmPatronImage By creating these 2 Koha::Patron::Image[s] classes, we could remove them easily. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:26:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:26:35 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #25 from Kyle M Hall --- Created attachment 48245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48245&action=edit Bug 15635: Koha::Patron::Images - Remove PutPatronImage The C4::Members::PutPatronImage inserted/updated the image of a patron. This can be done easily with ->find->set->store or ->new->store Test plan: 1/ Modify the image of a patron from the patron detail page 2/ Add an image to a new patron 3/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add or modify the image of a patron 4/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add or modify the image of several patrons, using a zip file. Stress the script trying to get as many errors as possible (wrong cardnumber, wrong mimetype, file does not exist, etc.) With this patch, if the cardnumber does not exist, you will get a specific error "Image not imported because this patron does not exist in the database" Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:26:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:26:38 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #26 from Kyle M Hall --- Created attachment 48246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48246&action=edit Bug 15635: Koha::Patron::Images - Remove RmPatronImage The C4::Members::RmPatronImage just removed a row in patronimage. This can be accomplished using the delete method of Koha::Patron::Image. Test plan: >From the patron defail page, try to delete the image of a patron. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:26:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:26:40 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #27 from Kyle M Hall --- Created attachment 48247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48247&action=edit Bug 15635: Koha::Patron::Images - Remove GetPatronImage To retrieve a patron image, we can call Koha::Patron::Images->find or Koha::Patrons->find->image Both will return a Koha::Patron::Image object. Test plan: 1/ From the patron/member module, open all tabs on the left (Checkouts, detail, fines, etc.) The image should be correctly displayed. 2/ At the OPAC, on the patron details page (opac-memberentry.pl) the image should be displayed as well. 3/ Same on the sco module. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:26:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:26:43 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #28 from Kyle M Hall --- Created attachment 48248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48248&action=edit Bug 15635: Change method type to _type for bug 15446 Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:26:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:26:45 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #29 from Kyle M Hall --- Created attachment 48249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48249&action=edit Bug 15635 [QA Followup] - Fix number of unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:28:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:28:25 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 --- Comment #7 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #5) > QA Comment: > I am not sure if this really is a better solution. > I also doubt about the remark in comment 1 "Apparently older versions of > Koha considered a MARC subfield in the frameworks that had a code longer > than one character to be reserved for internal use". To me it just seems to > be a trick to skip the internal fields lib, tab, mandatory and repeatable > (all length>1). > > In terms of design it would have been easier to put all subfields a level > deeper instead of on the same level as lib, etc. > > I understand about not changing the design of the structure here. Yes, that would be a next step. > But now we move the test length<>1 from a subroutine into the code and check > if it is a ref or not. > I probably would like to still have the test in the subroutine (with all > benefits of a subroutine); another name would be fine. Not sure it's needed, as the test is very simple. Where would you move this subroutine? > If someone wants to add some other property to the structure and suppose > that is an arrayref or a hashref or an object, your test would fail. Yes but it works for the moment :) The structure has not changed for years. > I would propose to test (in the sub): > [a] skip if the field name matches lib|tab|mandatory|repeatable Imo, that would make the test less strong and too specific. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:29:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:29:31 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11844 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:29:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:29:31 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15774 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:34:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:34:47 +0000 Subject: [Koha-bugs] [Bug 15376] Edit invoices: Can not change Shipping cost. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15376 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #10 from Marc V?ron --- Re-tested on current master, I can no longer reproduce the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:34:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:34:48 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Jonathan Druart --- The tablename is not saved when I create a new field for aqbasket. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:35:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:35:07 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jweaver at bywatersolutions.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:35:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:35:32 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #5 from Jonathan Druart --- Note that I would prefer to this patch based on top of bug 11844. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:40:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:40:21 +0000 Subject: [Koha-bugs] [Bug 15463] view_holdsqueue.tt uses a search for cardnumber instead of borrowernumber direct link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15463 --- Comment #3 from Jonathan Druart --- circ/circulation.pl expects a cardnumber: 246 if ($findborrower) { 247 my $borrower = C4::Members::GetMember( cardnumber => $findborrower ); 248 if ( $borrower ) { 249 $borrowernumber = $borrower->{borrowernumber}; 250 } else { If not found, the script will try and search the $findborrower using the C4::Utils::DataTables::Members::search subroutine. We will have to change all occurrences if we want to change this behavior, not only view_holdsqueue.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:42:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:42:37 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 --- Comment #17 from Jonathan Druart --- (In reply to Galen Charlton from comment #16) > (In reply to Jonathan Druart from comment #14) > > Is anyone ready to submit a counter-patch? > > Working on one that is intended to actually fix at least some of the > potential vulnerabilities. I feel that this bug's title is not ideal, as > the focus should be on resolving potential misuse of CGI parameters, not > merely on quelling noisy warnings in the logs. The purpose of this first patch was to provide a quick fix to allow the use of multi_param anywhere else. The second step will be to get rid of the misuses of CGI->param -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:45:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:45:06 +0000 Subject: [Koha-bugs] [Bug 15757] Hard coded due loan/renewal period of 21 days if no circ rule found in C4::Circulation::GetLoanLength In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15757 --- Comment #5 from Jonathan Druart --- I would consider it more an enhancement than as a blocker -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:51:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:51:37 +0000 Subject: [Koha-bugs] [Bug 15718] Need more information for items that don't successfully batch checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15718 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |katrin.fischer at bsz-bw.de, | |nengard at gmail.com, | |oleonard at myacpl.org --- Comment #3 from Jonathan Druart --- (In reply to Heather Braum from comment #2) > Johnathan, what about something as simple as adding a table title for that > screen, "items that didn't check out" or in the information column for each > item, "item didn't check out?" > > Is that possible? (almost) Everything is possible :) I agree there is an ergonomic issue, the different screens are not obvious about what has been done and what will be done on the next screen. I have cced Katrin, Nicole and Owen to get more ideas. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:56:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:56:19 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 --- Comment #8 from Marc V?ron --- Created attachment 48250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48250&action=edit Bug 15721: (followup) Add apache2ctl to C4::Context::get_versions See comment #6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 16:57:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 15:57:39 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Marc V?ron --- I think the followup needs a sign-off. For test plan see comment #2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 17:04:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 16:04:19 +0000 Subject: [Koha-bugs] [Bug 13041] Can't add user as manager of basket if name includes a single quote In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 17:13:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 16:13:25 +0000 Subject: [Koha-bugs] [Bug 15863] New: When creating a dictionary for date column, date range selection should be hidden if all dates is selected Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15863 Bug ID: 15863 Summary: When creating a dictionary for date column, date range selection should be hidden if all dates is selected Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org When creating a dictionary for a date column, there is a "date range" / "all dates" radio buttons and 2 inputs to select the date range. These inputs should be hidden if "all dates" is selected. See bug 2669 comment 10 for the request. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 17:13:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 16:13:46 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15863 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 17:13:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 16:13:46 +0000 Subject: [Koha-bugs] [Bug 15863] When creating a dictionary for date column, date range selection should be hidden if all dates is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15863 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2669 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 17:14:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 16:14:08 +0000 Subject: [Koha-bugs] [Bug 13835] Popup "Search for budget owner" should not display language menu in footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13835 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #1 from Marc V?ron --- Language selection is part of intranet-bottom.inc A fix of this rather cosmetic issue would need to create a separate 'bottom.inc' for such popups. Setting to RESOLVED WONTFIX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 17:14:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 16:14:34 +0000 Subject: [Koha-bugs] [Bug 13837] Popup "Search for garantor" should not display language menu in footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13837 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Marc V?ron --- Language selection is part of intranet-bottom.inc A fix of this rather cosmetic issue would need to create a separate 'bottom.inc' for such popups. Setting to RESOLVED WONTFIX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 17:15:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 16:15:55 +0000 Subject: [Koha-bugs] [Bug 15863] When creating a dictionary for date column, date range selection should be hidden if all dates is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15863 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 17:15:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 16:15:58 +0000 Subject: [Koha-bugs] [Bug 15863] When creating a dictionary for date column, date range selection should be hidden if all dates is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15863 --- Comment #1 from Jonathan Druart --- Created attachment 48251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48251&action=edit Bug 15863: Show/hide date range selection if not needed - dictionnary When creating a dictionary for a date column, there is a "date range" / "all dates" radio buttons and 2 inputs to select the date range. These inputs should be hidden if "all dates" is selected. Test plan: 1/ Create a new dictionary on reports/dictionary.pl 2/ Select a date column (borrowers.dateofbirth of instance) 3/ On step 4, the start/end of the date range inputs should be hidden/shown depending of the radio buttons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 17:22:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 16:22:35 +0000 Subject: [Koha-bugs] [Bug 14941] Subfield defaults: Add information about substitutable values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14941 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nengard at gmail.com Component|Cataloging |Documentation --- Comment #1 from Marc V?ron --- Changed to 'Documentation' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 17:27:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 16:27:19 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart --- Do we need both patches? With both patches applied, the button does not look disabled if nothing has been changed, it's a bit confusing (and the cursor is the cursor is a pointer). With only the following change, I get what is (I think) is expected: diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css index b35e6be..06c39c2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css +++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css @@ -422,7 +422,7 @@ dd { font-weight : normal; } -.btn-toolbar { +div#toolbar, .btn-toolbar { background-color : #EDF4F6; padding: 5px 5px 5px 5px; border-radius: 5px 5px 0 0; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 17:32:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 16:32:37 +0000 Subject: [Koha-bugs] [Bug 13873] Lenghty tables do not properly print in Firefox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13873 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Marc V?ron --- Can no longer reproduce with current Firefox version 44.0.2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 17:54:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 16:54:32 +0000 Subject: [Koha-bugs] [Bug 15856] Serials Software error when saving new subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15856 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7728 --- Comment #1 from Marc V?ron --- It crashes because of the invalid subscription end date 9999. It does not crash with current version 3.22 and with current master. Workaround for 3.18: Leave empty or enter a valid date for end date. BTW: It seems that the end date should be empty while the subscription is running, see Bug 7728 More related bugs: Bug 15484, Bug 15149 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 17:54:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 16:54:32 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15856 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 18:02:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 17:02:07 +0000 Subject: [Koha-bugs] [Bug 15863] When creating a dictionary for date column, date range selection should be hidden if all dates is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15863 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48251|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 48252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48252&action=edit Bug 15863: Show/hide date range selection if not needed - dictionnary When creating a dictionary for a date column, there is a "date range" / "all dates" radio buttons and 2 inputs to select the date range. These inputs should be hidden if "all dates" is selected. Test plan: 1/ Create a new dictionary on reports/dictionary.pl 2/ Select a date column (borrowers.dateofbirth of instance) 3/ On step 4, the start/end of the date range inputs should be hidden/shown depending of the radio buttons. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 18:02:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 17:02:28 +0000 Subject: [Koha-bugs] [Bug 15863] When creating a dictionary for date column, date range selection should be hidden if all dates is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15863 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 18:23:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 17:23:37 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 --- Comment #12 from Owen Leonard --- No we don't need both patches. I think mine is the correct solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 18:35:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 17:35:43 +0000 Subject: [Koha-bugs] [Bug 15864] New: SMS cellular providers link missing from administration sidebar menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15864 Bug ID: 15864 Summary: SMS cellular providers link missing from administration sidebar menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: kyle at bywatersolutions.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Even with SMS cellular provider management enabled, the link to SMS cellular providers doesn't appear in the administration sidebar menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 18:37:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 17:37:46 +0000 Subject: [Koha-bugs] [Bug 15865] New: Standard header search form missing from SMS cellular providers page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15865 Bug ID: 15865 Summary: Standard header search form missing from SMS cellular providers page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: kyle at bywatersolutions.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Administration pages which do not have their own special header search form should use cat-search.inc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 18:48:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 17:48:36 +0000 Subject: [Koha-bugs] [Bug 15866] New: No warning when deleting a rotating collection using the toolbar button Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15866 Bug ID: 15866 Summary: No warning when deleting a rotating collection using the toolbar button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org If you are viewing the contents of or adding items to a rotating collection (Tools ? Rotating collections ? Collection ? Add or remove items) clicking the "Delete" button in the toolbar will delete the collection without any client-side or server-side warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 18:59:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 17:59:12 +0000 Subject: [Koha-bugs] [Bug 15867] New: Move MARC modification templates JavaScript into separate file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15867 Bug ID: 15867 Summary: Move MARC modification templates JavaScript into separate file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Coding guideline JS1 (https://wiki.koha-community.org/wiki/Coding_Guidelines#JS1:_Embedding_JavaScript_blocks_in_templates) says "Whenever possible JavaScript should be placed in a separate file." The JavaScript embedded in tools/marc_modification_templates.tt is not so dependent on template processing that it can't be safely moved to a separate file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 20:19:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 19:19:45 +0000 Subject: [Koha-bugs] [Bug 15867] Move MARC modification templates JavaScript into separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15867 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 20:19:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 19:19:48 +0000 Subject: [Koha-bugs] [Bug 15867] Move MARC modification templates JavaScript into separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15867 --- Comment #1 from Owen Leonard --- Created attachment 48253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48253&action=edit Bug 15867 - Move MARC modification templates JavaScript into separate file The JavaScript embedded in the MARC modification templates template is not dependent on template processing to such an extent that it can't be safely moved to a separate file. This patch does so, adding definition of a some translatable strings to the template. Other minor changes: A couple of JSHint warnings corrected, a couple of missing semicolons added to template markup. To test, apply the patch and go to Tools -> MARC modification templates - Confirm that The add/update form works normally with various actions (Add/update,Delete,Move, etc.). - Confirm that template switching works correctly. - Confirm that template deletion confirmation works correctly. - Confirm that cancelling an edit works correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 20:21:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 19:21:51 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48241|0 |1 is obsolete| | --- Comment #13 from H?ctor Eduardo Castro Avalos --- Comment on attachment 48241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48241 [SIGNED-OFF]Bug 15600: System preferences broken toolbar looks broken (In reply to Owen Leonard from comment #12) > No we don't need both patches. I think mine is the correct solution. It's right, doing obsolete Chloe's patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 20:34:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 19:34:21 +0000 Subject: [Koha-bugs] [Bug 15868] New: Ask for confirmation before deleting MARC modification template Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15868 Bug ID: 15868 Summary: Ask for confirmation before deleting MARC modification template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/marc_modification_templates.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org There is no client side or server side confirmation before deleting a MARC modification template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 20:39:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 19:39:06 +0000 Subject: [Koha-bugs] [Bug 15868] Ask for confirmation before deleting MARC modification template action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15868 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Ask for confirmation before |Ask for confirmation before |deleting MARC modification |deleting MARC modification |template |template action --- Comment #1 from Owen Leonard --- Sorry, I mean a MARC modification template action. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 20:41:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 19:41:55 +0000 Subject: [Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 20:44:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 19:44:09 +0000 Subject: [Koha-bugs] [Bug 15869] New: change framework on overlay Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Bug ID: 15869 Summary: change framework on overlay Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When you stage files for import you can choose how to handle matches. One option is to replace the existing record. The problem is that many libraries use this option to load a fuller record over a quick or fast record and the framework doesn't change. So you can choose the framework before importing but that framework only applies to new records, it doesn't update records that are being replaced or overlaid. We should fix that to update the framework for all items, not just new ones. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:02:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:02:46 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:02:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:02:49 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #17 from Nick Clemens --- Created attachment 48254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48254&action=edit Bug 14752 - [QA followup] Auto-Generate barcode if left blank and autoBarcode is set Adds a warning/notice to item form and modal that barcodes will be auto-filled using syspref if autoBarcode is turned on Fills in barcodes if passed in blank -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:06:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:06:26 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #18 from Nick Clemens --- Okay, I attached a patch that 'works' I used C4::Barcodes for generating the next barcode, however, this is apparently broken for annual and hbyymmdd and the latter indicates it is deprecated Do we patch C4::Barcodes, or use ValueBuilder.pm basically copying code from value_builder.pl? Opinions? (In reply to Jonathan Druart from comment #15) > Ha yes ok, got it! > You the previous item is not inserted, then the barcode cannot be generated. > Maybe we could display a value in the barcode field to tell the user it will > be auto-generated on saving. > I would like to avoid a JS function to calculate the next barcode, we > already have perl subroutines to do this job. > > Katrin, could I get your opinion please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:07:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:07:58 +0000 Subject: [Koha-bugs] [Bug 15870] New: Add Filter for MARC to respect visibility settings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 Bug ID: 15870 Summary: Add Filter for MARC to respect visibility settings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org There needs to be a new filter for MARC::Records such that when a record is processed a cloned record with hidden fields and sub-fields excluded. This will only affect MARC::Records, and as such will leave some visibility gaps still. This will only attempt to implement this filter on OPAC pages, though the filter should be usable for the staff client as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:08:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:08:06 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:19:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:19:16 +0000 Subject: [Koha-bugs] [Bug 15871] New: Improve perl critic of t/RecordProcessor.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 Bug ID: 15871 Summary: Improve perl critic of t/RecordProcessor.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org perlcritic -5 t/RecordProcessor fails with: Don't modify $_ in list functions at line 43, column 25. See page 114 of PBP. (Severity: 5) This is because of a hacky good single line of code. While correcting this for improved readability, attempt to get this to a higher level of perl critic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:19:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:19:28 +0000 Subject: [Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:23:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:23:38 +0000 Subject: [Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:23:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:23:41 +0000 Subject: [Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 --- Comment #1 from M. Tompsett --- Created attachment 48255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48255&action=edit Bug 15871: Improve PerlCritic level for t/RecordProcessor.t perlcritic -5 failed. Attempt to clean up to a higher level: -- use English to address use of $@ variable -- perltidy on the code -- substitute q{} for '' -- expand out single line hacky goodness (... s/\.pm$//) to more code -- remove parenthesis on functions that don't need it -- add x, s, and m as needed to regexps -- change double quotes to single quotes where no variable involved -- tweaked eval destroy test to check return value and use $EVAL_ERROR -- renamed $processor to $record_processor in the subtest to avoid lexical warnings TEST PLAN --------- $ perlcritic -5 t/RecordProcessor.t Don't modify $_ in list functions at line 43, column 25. See page 114 of PBP. (Severity: 5) $ perlcritic -2 t/RecordProcessor.t No package-scoped "$VERSION" variable found at line 1, column 1. See page 404 of PBP. (Severity: 2) Quotes used with a string containing no non-whitespace characters at line 34, column 36. See page 53 of PBP. (Severity: 2) Quotes used with a string containing no non-whitespace characters at line 34, column 39. See page 53 of PBP. (Severity: 2) Quotes used with a string containing no non-whitespace characters at line 36, column 33. See page 53 of PBP. (Severity: 2) Quotes used with a string containing no non-whitespace characters at line 36, column 36. See page 53 of PBP. (Severity: 2) Don't modify $_ in list functions at line 43, column 25. See page 114 of PBP. (Severity: 5) Regular expression without "/s" flag at line 43, column 33. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/x" flag at line 43, column 33. See page 236 of PBP. (Severity: 3) Regular expression without "/m" flag at line 43, column 33. See page 237 of PBP. (Severity: 2) Regular expression without "/s" flag at line 43, column 66. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/x" flag at line 43, column 66. See page 236 of PBP. (Severity: 3) Regular expression without "/m" flag at line 43, column 66. See page 237 of PBP. (Severity: 2) Expression form of "grep" at line 47, column 8. See page 169 of PBP. (Severity: 4) Expression form of "grep" at line 50, column 20. See page 169 of PBP. (Severity: 4) Regular expression without "/s" flag at line 50, column 26. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/m" flag at line 50, column 26. See page 237 of PBP. (Severity: 2) Return value of eval not tested at line 73, column 1. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) Magic punctuation variable $@ used at line 78, column 5. See page 79 of PBP. (Severity: 2) Reused variable name in lexical scope: $processor at line 84, column 5. Invent unique variable names. (Severity: 3) Subroutine "new" called using indirect syntax at line 87, column 18. See page 349 of PBP. (Severity: 4) Subroutine "new" called using indirect syntax at line 93, column 18. See page 349 of PBP. (Severity: 4) Quotes used with a string containing no non-whitespace characters at line 96, column 40. See page 53 of PBP. (Severity: 2) Subroutine "new" called using indirect syntax at line 99, column 18. See page 349 of PBP. (Severity: 4) Subroutine "new" called using indirect syntax at line 106, column 18. See page 349 of PBP. (Severity: 4) $ prove -v t/RecordProcessor.t t/RecordProcessor.t .. ok All tests successful. Files=1, Tests=13, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.22 cusr 0.02 csys = 0.25 CPU) Result: PASS $ prove -v t/RecordProcessor.t ... $ git bz apply 15871 Repeat perlcritic level 2, and only $VERSION warning should exist. Retest with the prove. Run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:24:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:24:09 +0000 Subject: [Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6679 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:24:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:24:09 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15871 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:47:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:47:57 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:48:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:48:14 +0000 Subject: [Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 [Bug 15870] Add Filter for MARC to respect visibility settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:48:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:48:14 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 [Bug 15871] Improve perl critic of t/RecordProcessor.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:50:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:50:24 +0000 Subject: [Koha-bugs] [Bug 15872] New: Rancor: Ctrl-Shift-X has incorrect description in "Keyboard shortcuts" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15872 Bug ID: 15872 Summary: Rancor: Ctrl-Shift-X has incorrect description in "Keyboard shortcuts" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Cataloging Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Should be "Delete current subfield". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:52:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:52:59 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 [Bug 15870] Add Filter for MARC to respect visibility settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:52:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:52:59 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15871 |15777 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 [Bug 15871] Improve perl critic of t/RecordProcessor.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:52:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:52:59 +0000 Subject: [Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15870 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 [Bug 15870] Add Filter for MARC to respect visibility settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:53:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:53:14 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 [Bug 15871] Improve perl critic of t/RecordProcessor.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:53:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:53:14 +0000 Subject: [Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 [Bug 15870] Add Filter for MARC to respect visibility settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:53:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:53:24 +0000 Subject: [Koha-bugs] [Bug 15872] Rancor: Ctrl-Shift-X has incorrect description in "Keyboard shortcuts" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15872 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:53:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:53:26 +0000 Subject: [Koha-bugs] [Bug 15872] Rancor: Ctrl-Shift-X has incorrect description in "Keyboard shortcuts" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15872 --- Comment #1 from Jesse Weaver --- Created attachment 48256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48256&action=edit Bug 15872: Rancor: Ctrl-Shift-X has incorrect description in "Keyboard shortcuts" Should be "Delete current subfield." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:55:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:55:00 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11592 --- Comment #1 from M. Tompsett --- Correction, this will ONLY be the filter, and tests for the filter. OPAC stuff will go on bug 11592. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:55:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:55:00 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15870 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:55:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:55:13 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 [Bug 11592] opac detail scripts do not respect MARC tag visibility -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:55:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:55:13 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 [Bug 15870] Add Filter for MARC to respect visibility settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 22:59:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 21:59:54 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 23:01:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 22:01:36 +0000 Subject: [Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48255|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 48257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48257&action=edit Bug 15871: Improve PerlCritic level for t/RecordProcessor.t perlcritic -5 failed. Attempt to clean up to a higher level: -- use English to address use of $@ variable -- perltidy on the code -- substitute q{} for '' -- expand out single line hacky goodness (... s/\.pm$//) to more code -- remove parenthesis on functions that don't need it -- add x, s, and m as needed to regexps -- change double quotes to single quotes where no variable involved -- tweaked eval destroy test to check return value and use $EVAL_ERROR -- renamed $processor to $record_processor in the subtest to avoid lexical warnings TEST PLAN --------- $ perlcritic -5 t/RecordProcessor.t Don't modify $_ in list functions at line 43, column 25. See page 114 of PBP. (Severity: 5) $ perlcritic -2 t/RecordProcessor.t No package-scoped "$VERSION" variable found at line 1, column 1. See page 404 of PBP. (Severity: 2) Quotes used with a string containing no non-whitespace characters at line 34, column 36. See page 53 of PBP. (Severity: 2) Quotes used with a string containing no non-whitespace characters at line 34, column 39. See page 53 of PBP. (Severity: 2) Quotes used with a string containing no non-whitespace characters at line 36, column 33. See page 53 of PBP. (Severity: 2) Quotes used with a string containing no non-whitespace characters at line 36, column 36. See page 53 of PBP. (Severity: 2) Don't modify $_ in list functions at line 43, column 25. See page 114 of PBP. (Severity: 5) Regular expression without "/s" flag at line 43, column 33. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/x" flag at line 43, column 33. See page 236 of PBP. (Severity: 3) Regular expression without "/m" flag at line 43, column 33. See page 237 of PBP. (Severity: 2) Regular expression without "/s" flag at line 43, column 66. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/x" flag at line 43, column 66. See page 236 of PBP. (Severity: 3) Regular expression without "/m" flag at line 43, column 66. See page 237 of PBP. (Severity: 2) Expression form of "grep" at line 47, column 8. See page 169 of PBP. (Severity: 4) Expression form of "grep" at line 50, column 20. See page 169 of PBP. (Severity: 4) Regular expression without "/s" flag at line 50, column 26. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/m" flag at line 50, column 26. See page 237 of PBP. (Severity: 2) Return value of eval not tested at line 73, column 1. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) Magic punctuation variable $@ used at line 78, column 5. See page 79 of PBP. (Severity: 2) Reused variable name in lexical scope: $processor at line 84, column 5. Invent unique variable names. (Severity: 3) Subroutine "new" called using indirect syntax at line 87, column 18. See page 349 of PBP. (Severity: 4) Subroutine "new" called using indirect syntax at line 93, column 18. See page 349 of PBP. (Severity: 4) Quotes used with a string containing no non-whitespace characters at line 96, column 40. See page 53 of PBP. (Severity: 2) Subroutine "new" called using indirect syntax at line 99, column 18. See page 349 of PBP. (Severity: 4) Subroutine "new" called using indirect syntax at line 106, column 18. See page 349 of PBP. (Severity: 4) $ prove -v t/RecordProcessor.t t/RecordProcessor.t .. ok All tests successful. Files=1, Tests=13, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.22 cusr 0.02 csys = 0.25 CPU) Result: PASS $ prove -v t/RecordProcessor.t ... $ git bz apply 15871 Repeat perlcritic level 2, and only $VERSION warning should exist. Retest with the prove. Run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 23:02:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 22:02:14 +0000 Subject: [Koha-bugs] [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 [Bug 15871] Improve perl critic of t/RecordProcessor.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 23:02:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 22:02:14 +0000 Subject: [Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15777 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15777 [Bug 15777] Refactor loop in which Record::Processor does not initialize parameters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 23:03:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 22:03:20 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 23:03:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 22:03:23 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46455|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 48258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48258&action=edit Bug 14576 - Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 23:03:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 22:03:31 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46456|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 48259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48259&action=edit Bug 14576 - Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 23:15:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 22:15:36 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 --- Comment #2 from M. Tompsett --- Created attachment 48260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48260&action=edit Bug 15870: MARC Filter to exclude fields/subfields lacking visibility TEST PLAN --------- 1) Apply patch 2) prove -v t/db_dependpent/RecordProcessor_ViewPolicy.t -- all should pass. 3) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 23:25:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 22:25:05 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 19 23:25:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Feb 2016 22:25:08 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48260|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 48261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48261&action=edit Bug 15870: MARC Filter to exclude fields/subfields lacking visibility TEST PLAN --------- 0) Apply 15777 and 15871 as required. 1) Apply patch 2) prove -v t/db_dependpent/RecordProcessor_ViewPolicy.t -- all should pass. 3) koha qa test tools. BONUS 4) perlcritic -1 t/db_dependpent/RecordProcessor_ViewPolicy.t -- using the koha qa test tools perlcriticrc, it should pass though I am excluding checking print return values. (see bug 15646) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 08:02:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 07:02:42 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #13 from Fr?d?ric Demians --- Marcel, from my perspective, this patch is an enhancement, and as so shouldn't enter into 3.20 branch. Am I wrong? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 09:49:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 08:49:37 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #54 from Fr?d?ric Demians --- I can't make it work properly on 3.20 branch. Code has diverged too much. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 09:51:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 08:51:51 +0000 Subject: [Koha-bugs] [Bug 11569] Typo in userpermissions.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11569 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- (In reply to Julian Maurice from comment #5) > Patch pushed to 3.22.x, will be in 3.22.3 This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 09:52:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 08:52:10 +0000 Subject: [Koha-bugs] [Bug 15684] Fix encoding issues with quote upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #11 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 09:52:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 08:52:30 +0000 Subject: [Koha-bugs] [Bug 14406] When adding messages in patron account, only first name is shown in pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14406 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 09:53:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 08:53:02 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #17 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 09:53:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 08:53:23 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #12 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 09:53:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 08:53:57 +0000 Subject: [Koha-bugs] [Bug 15628] Remove get_branchinfos_of vestiges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15628 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 09:54:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 08:54:13 +0000 Subject: [Koha-bugs] [Bug 15574] Better wording for error message when adding tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15574 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 09:54:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 08:54:44 +0000 Subject: [Koha-bugs] [Bug 15411] "Non fiction" is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #14 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 09:55:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 08:55:01 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #16 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 09:55:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 08:55:25 +0000 Subject: [Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 18:12:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 17:12:25 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 --- Comment #14 from Magnus Enger --- (In reply to Fr?d?ric Demians from comment #13) > Marcel, from my perspective, this patch is an enhancement, and as so > shouldn't enter into 3.20 branch. Am I wrong? To me it looks like a bugfix, see my comment #6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 23:07:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 22:07:22 +0000 Subject: [Koha-bugs] [Bug 11251] Be able to configure HTML Opac preferences per library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11251 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |System Administration CC| |gmcharlt at gmail.com Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 23:08:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 22:08:55 +0000 Subject: [Koha-bugs] [Bug 11036] track log ins to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11036 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |gmcharlt at gmail.com Component|OPAC |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 20 23:35:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Feb 2016 22:35:05 +0000 Subject: [Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451 --- Comment #11 from Owen Leonard --- Two years later is this still an issue? It isn't in my tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 21 13:18:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Feb 2016 12:18:25 +0000 Subject: [Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46462|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 48262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48262&action=edit Bug 15533 - Allow patrons and librarians to select itemtype when placing hold Some libraries would like the ability to select the itemtype to request when placing holds. For example, if a record has 3 copies of BookA and 3 copies of BookA in large print, this feature would allow a person to place a hold on the record, but still be able to target only the Large Print edition so that the first Large Print copy that becomes available is targeted, rather than forcing the patron to select a particular copy to hold. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with items of two or more itemtypes 4) Place a record level hold on the record while choosing one particular itemtype 5) Check in an item from the record that is not of that itemtype 6) Notee it is not trapped for the hold 7) Check in an item from the record that does match the selected itemtype 8) Note the item is trapped for the hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 21 17:04:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Feb 2016 16:04:13 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 --- Comment #15 from Fr?d?ric Demians --- This patch depends on a 3.22 enhancement which isn't available on 3.22 branch: see bug 14321. I can't backport and fix in the same time. Seems too risky. From my perspective, if it's a major issue on 3.20, a separate bug should be open, and a patch attached, specifically for 3.20. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 21 17:42:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Feb 2016 16:42:02 +0000 Subject: [Koha-bugs] [Bug 15873] New: Restrict patron to hold those items which already checked-out by them. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15873 Bug ID: 15873 Summary: Restrict patron to hold those items which already checked-out by them. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: amitddng135 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Restrict patron to hold those items which already checked-out by them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 21 17:42:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Feb 2016 16:42:53 +0000 Subject: [Koha-bugs] [Bug 15873] Restrict patron to hold those items which already checked-out by them. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15873 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com |ity.org | --- Comment #1 from Amit Gupta --- Restrict patron to hold those items which already checked-out by them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 21 17:43:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Feb 2016 16:43:25 +0000 Subject: [Koha-bugs] [Bug 15873] Restrict patron to hold those items which already checked-out by them. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15873 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 21 18:12:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Feb 2016 17:12:10 +0000 Subject: [Koha-bugs] [Bug 15873] Restrict patron to hold those items which already checked-out by them. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15873 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- hi Amit, did you see the AllowHoldsOnPatronsPossessions system preference? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 21 21:14:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Feb 2016 20:14:58 +0000 Subject: [Koha-bugs] [Bug 15874] New: koha-dump should provide a way to exclude any database table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15874 Bug ID: 15874 Summary: koha-dump should provide a way to exclude any database table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: costalc at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz koha-dump should provide a way to exclude any database table from the backup process, like --ignore-table switch does in mysqldump command. For example: biblioimages and patronimage tables in most cases are heavy tables that consume a long backup execution time so it would be nice to be able not to do a backup of them. Ref: http://dev.mysql.com/doc/refman/5.1/en/mysqldump.html#option_mysqldump_ignore-table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 04:39:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 03:39:36 +0000 Subject: [Koha-bugs] [Bug 15873] Restrict patron to hold those items which already checked-out by them. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15873 --- Comment #3 from Amit Gupta --- Hi Katrin i have not checked but some one already raised a bug it is not working. Please see bug no 13374 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 04:40:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 03:40:07 +0000 Subject: [Koha-bugs] [Bug 13374] AllowHoldsOnPatronsPossessions not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13374 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 04:40:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 03:40:19 +0000 Subject: [Koha-bugs] [Bug 13374] AllowHoldsOnPatronsPossessions not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13374 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15873 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 04:40:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 03:40:19 +0000 Subject: [Koha-bugs] [Bug 15873] Restrict patron to hold those items which already checked-out by them. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15873 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13374 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 05:45:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 04:45:58 +0000 Subject: [Koha-bugs] [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- (In reply to Kyle M Hall from comment #1) > The same issue seems to occur for sms_provider_id. Confirmed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 06:04:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 05:04:19 +0000 Subject: [Koha-bugs] [Bug 14433] To print a slip as receipit for a single issue (checkout) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14433 Arup changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arup.raychaudhury at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 06:17:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 05:17:30 +0000 Subject: [Koha-bugs] [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 06:17:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 05:17:32 +0000 Subject: [Koha-bugs] [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48190|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 48263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48263&action=edit [SIGNED-OFF] Bug 15842 - Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts When importing patrons with a csv file which does not contain the privacy_guarantor_checkouts column in the header, you will get DBIx::Class::Storage::DBI::_dbh_execute(): Column 'privacy_guarantor_checkouts' cannot be null at /home/koha/src/C4/Members.pm line 768 The same issue seems to occur for sms_provider_id. Test Plan: 1) Attempt to import patron csv file with no privacy_guarantor_checkouts column 2) Note the error 3) Apply this patch 4) Repeat step 1 5) The error should no longer occur NOTE: While this patch does work, should it be solved only at this level? The issue that there is the lack of those two fields on the tools screen still exists. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 06:34:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 05:34:57 +0000 Subject: [Koha-bugs] [Bug 15840] Import borrowers tool explodes if userid already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #13 from M. Tompsett --- I can't duplicate this. Could you provide sample user data which causes explosion? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 07:29:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 06:29:53 +0000 Subject: [Koha-bugs] [Bug 15873] Restrict patron to hold those items which already checked-out by them. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15873 --- Comment #4 from Katrin Fischer --- Hm, maybe close this bug and work on the other then? Reading through the bug description there it looks like it would be working for most databases and break for those where biblionumber and biblioitemnumber got out of sync. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 09:31:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 08:31:14 +0000 Subject: [Koha-bugs] [Bug 15840] Import borrowers tool explodes if userid already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 --- Comment #14 from Jonathan Druart --- I have tried with a csv file containing 3 lines: headers, then 2 lines with patron data. The patron data contained the same userid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 09:31:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 08:31:58 +0000 Subject: [Koha-bugs] [Bug 15840] Import borrowers tool explodes if userid already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15842 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15842 | --- Comment #15 from Jonathan Druart --- iirc, you need bug 15842. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 09:31:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 08:31:58 +0000 Subject: [Koha-bugs] [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15840 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15840 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 [Bug 15840] Import borrowers tool explodes if userid already exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 09:36:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 08:36:55 +0000 Subject: [Koha-bugs] [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 --- Comment #4 from Jonathan Druart --- (In reply to M. Tompsett from comment #3) > NOTE: While this patch does work, should it be solved only > at this level? The issue that there is the lack of those two > fields on the tools screen still exists. Could you detail? I don't understand what you suggest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 09:39:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 08:39:52 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 09:39:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 08:39:55 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48242|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 48264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48264&action=edit Bug 15600: System preferences broken toolbar looks broken This patch reverts some deletions made to staff-global.css in Bug 11559. The deletions broke the appearance of the floating toolbar in system preferences. To test, apply the patch and clear your browser cache if necessary. - Go to Administration -> System preferences and view a tab with enough content to allow you to scroll and test the appearance of the floating toolbar. Confirm that it looks correct. - Open the advanced cataloging editor and confirm that its toolbar looks correct. - Open the normal cataloging editor and confirm that the floating toolbar looks correct and works correctly. Signed-off-by: Hector Castro Works as advertised. Tollbar looks correct Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 10:14:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 09:14:40 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #25 from Alex Arnaud --- Does anyone known why this bug failed QA ? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 10:21:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 09:21:44 +0000 Subject: [Koha-bugs] [Bug 5979] Add separate OPACISBD system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #26 from Katrin Fischer --- comment#21 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:01:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:01:41 +0000 Subject: [Koha-bugs] [Bug 15845] Renewal date in circulation.pl is not always correct and not even used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15845 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48189|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 48266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48266&action=edit Bug 15845: Renewal date in circulation.pl is not always correct and not even used If you have a patron category with a hard renewal date, the enrolllment period will be zero. You cannot calculate the renewal date as is done in the script currently. Even more, the renewaldate template var is not even used. Test plan: [1] Verify that checkin/checkout works as expected. [2] Git grep on renewaldate [3] Check the code in circulation.pl for "$renew" Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:01:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:01:58 +0000 Subject: [Koha-bugs] [Bug 15845] Renewal date in circulation.pl is not always correct and not even used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15845 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:04:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:04:28 +0000 Subject: [Koha-bugs] [Bug 15841] Final truth value in C4:Circulation has become displaced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15841 --- Comment #2 from Marc V?ron --- Created attachment 48267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48267&action=edit Bug 15841 Circulation module's true value misplaced 1; was not at the end of the module as it should be to ensure compilation returns true return it to last line of code where it should be This patch fixes an ovious mistake. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:05:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:05:07 +0000 Subject: [Koha-bugs] [Bug 15841] Final truth value in C4:Circulation has become displaced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15841 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #48165|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:05:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:05:21 +0000 Subject: [Koha-bugs] [Bug 15841] Final truth value in C4:Circulation has become displaced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15841 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:10:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:10:56 +0000 Subject: [Koha-bugs] [Bug 15119] Hide search header text boxes on render In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15119 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #8 from Marc V?ron --- What is the status of this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:12:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:12:24 +0000 Subject: [Koha-bugs] [Bug 15009] Planning dropdown button in aqbudget can have empty line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron --- What is the status of this Bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:17:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:17:01 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |veron at veron.ch --- Comment #25 from Marc V?ron --- Sorry, there is a merge conflict in returns.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:21:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:21:47 +0000 Subject: [Koha-bugs] [Bug 15857] Add test mode to process_message_queue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- With patch applied, I get (with and without test mode): "state" variable @_ masks earlier declaration in same scope at /usr/share/kohaclone/C4/Letters.pm line 1282. "my" variable $message masks earlier declaration in same scope at /usr/share/kohaclone/C4/Letters.pm line 1298. syntax error at /usr/share/kohaclone/C4/Letters.pm line 1237, near ") if" syntax error at /usr/share/kohaclone/C4/Letters.pm line 1246, near "}" Global symbol "$message" requires explicit package name at /usr/share/kohaclone/C4/Letters.pm line 1250. syntax error at /usr/share/kohaclone/C4/Letters.pm line 1256, near "}" Can't use global @_ in "my" at /usr/share/kohaclone/C4/Letters.pm line 1261, near "= @_" syntax error at /usr/share/kohaclone/C4/Letters.pm line 1279, near "}" (Might be a runaway multi-line << string starting on line 1265) Can't use global @_ in "my" at /usr/share/kohaclone/C4/Letters.pm line 1282, near "= @_" syntax error at /usr/share/kohaclone/C4/Letters.pm line 1295, near "}" syntax error at /usr/share/kohaclone/C4/Letters.pm line 1344, near "}" Can't use global @_ in "my" at /usr/share/kohaclone/C4/Letters.pm line 1347, near "= @_" /usr/share/kohaclone/C4/Letters.pm has too many errors. Compilation failed in require at misc/cronjobs/process_message_queue.pl line 28. BEGIN failed--compilation aborted at misc/cronjobs/process_message_queue.pl line 28. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:25:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:25:06 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 --- Comment #16 from Marcel de Rooy --- (In reply to Fr?d?ric Demians from comment #15) > This patch depends on a 3.22 enhancement which isn't available on 3.22 > branch: see bug 14321. I can't backport and fix in the same time. Seems too > risky. From my perspective, if it's a major issue on 3.20, a separate bug > should be open, and a patch attached, specifically for 3.20. The development this depends on, was pushed to 3.22. So this patch is not directly related to problems in 3.20. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:32:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:32:28 +0000 Subject: [Koha-bugs] [Bug 15875] New: Refactor DB accessors from "z39.50 admin setup / z3950servers.pl" to C4::Breeding Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15875 Bug ID: 15875 Summary: Refactor DB accessors from "z39.50 admin setup / z3950servers.pl" to C4::Breeding Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl z3950servers.pl is a horrible mess of hard SQL in the perl script/Controller-layer. Also a lack of proper internal API for mutating Z3950servers makes writing tests much harder. This patch refactors z3950servers.pl by moving SQL to C4::Breeding under proper accessors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:32:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:32:39 +0000 Subject: [Koha-bugs] [Bug 15298] z39.50 admin setup, options column suggested changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15875 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:32:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:32:39 +0000 Subject: [Koha-bugs] [Bug 15875] Refactor DB accessors from "z39.50 admin setup / z3950servers.pl" to C4::Breeding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15875 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15298 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:36:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:36:18 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 --- Comment #8 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #7) > Not sure it's needed, as the test is very simple. > Where would you move this subroutine? If we would ever have to change this very simple test, it would also be very easy to overlook a simple test. I would keep it close to GetMarcStructure. > Yes but it works for the moment :) The structure has not changed for years. True > Imo, that would make the test less strong and too specific. OK So, I prefer to move the ref-test to a subroutine in Biblio.pm IsMarcStructureInternal ? or something ? That would be the only place to document this test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:38:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:38:40 +0000 Subject: [Koha-bugs] [Bug 15875] Refactor DB accessors from "z39.50 admin setup / z3950servers.pl" to C4::Breeding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15875 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 48268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48268&action=edit Bug 15875 - Refactor DB accessors from "z39.50 admin setup / z3950servers.pl" to C4::Breeding z3950servers.pl is a horrible mess of hard SQL in the perl script/Controller-layer. Also a lack of proper internal API for mutating Z3950servers makes writing tests much harder. This patch refactors z3950servers.pl by moving SQL to C4::Breeding under proper accessors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:45:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:45:11 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:45:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:45:14 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #16 from Jonathan Druart --- Created attachment 48269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48269&action=edit Bug 15163: Do not erase patron attributes if limited to another library The patron attributes displayed on editing a patron are not displayed if limited to another library. C4::Members::Attributes::SetBorrowerAttributes will now only delete attributes the librarian is editing. SetBorrowerAttributes takes a new $no_branch_limit parameter. If set, the branch limitations have not effect and all attributes are deleted (same behavior as before this patch). Test plan: 1/ Create 2 patron attributes, without branch limitations. 2/ Edit a patron and set a value for these attributes 3/ Limit a patron attributes to a library (one you are not logged in with). 4/ Edit again the patron. => You should not see the limited attributes 5/ Edit the patron attributes and remove the branch limitation => Without this patch, it has been removed from the database and is not displayed anymore. => With this patch, you should see it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:51:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:51:03 +0000 Subject: [Koha-bugs] [Bug 15845] Renewal date in circulation.pl is not always correct and not even used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15845 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:51:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:51:06 +0000 Subject: [Koha-bugs] [Bug 15845] Renewal date in circulation.pl is not always correct and not even used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15845 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48266|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48270&action=edit Bug 15845: Renewal date in circulation.pl is not always correct and not even used If you have a patron category with a hard renewal date, the enrolllment period will be zero. You cannot calculate the renewal date as is done in the script currently. Even more, the renewaldate template var is not even used. Test plan: [1] Verify that checkin/checkout works as expected. [2] Git grep on renewaldate [3] Check the code in circulation.pl for "$renew" Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:51:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:51:09 +0000 Subject: [Koha-bugs] [Bug 15845] Renewal date in circulation.pl is not always correct and not even used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15845 --- Comment #4 from Jonathan Druart --- Created attachment 48271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48271&action=edit Bug 15845: Do not import Add_Delta_YM from circulation.pl This subroutine is no longer used in this script. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:52:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:52:40 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #22 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #20) > Looking at the code this seems a very specific feature, like Amazon-Covers, > Syndectics, etc. > > Koha::SuggestionEngine::Plugin::LibrisSpellcheck; The name does not tell that this is only interesting for Swedish libs. > So if the URL is always the same and there is no other service this plugin > works with - a configuration option doesn't seem necessary. The URL has changed already :) Note that e.g. Syndetics has 12 prefs or so in Koha. (In reply to Eivin Giske Skaaren from comment #21) > It seems like they have changed the url to http://api.libris.kb.se/bibspell/ > so perhaps some way of changing it without committing code would be good. > Please advise on the preferred solution. I do not really oppose a pref here. But you could use a local pref, or an "undocumented" koha-conf variable. Not ideal, since you would reference it from standard code.. The whole problem here is: How do we adjust Koha to include various language specific features (like this one)? Should they be part of the core code or not? Note that we recently had such a discussion about NorwegianPatronDB. There is no clear answer yet. For the time being, I would not oppose two prefs and toggling this feature via admin/didyoumean. Final word to the RM. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:56:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:56:20 +0000 Subject: [Koha-bugs] [Bug 15841] Final truth value in C4:Circulation has become displaced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15841 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |11201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 [Bug 11201] List pending in-house checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:56:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:56:20 +0000 Subject: [Koha-bugs] [Bug 11201] List pending in-house checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15841 [Bug 15841] Final truth value in C4:Circulation has become displaced -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:56:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:56:49 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #23 from Katrin Fischer --- I think if a pref - better have a proper one so we know what's going on there :) The Did-you-mean-feature already has a very modulized structure, so I think adding to that should be ok for now until we can give the whole topic more thought. It won't hurt anyone and it doesn't touch core routines/templates apart from the small change in the include. Maybe we need to think about a good way to store configuration options for plugins? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:56:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:56:50 +0000 Subject: [Koha-bugs] [Bug 15875] Refactor DB accessors from "z39.50 admin setup / z3950servers.pl" to C4::Breeding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15875 --- Comment #2 from Marcel de Rooy --- sub castCGIToZ3950serverParams { + my ($cgi) = @_; + + my $params = {}; + $params->{'host'} = $input->param('host'), Sure this is what you mean? :) cgi..inpuy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:57:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:57:07 +0000 Subject: [Koha-bugs] [Bug 15875] Refactor DB accessors from "z39.50 admin setup / z3950servers.pl" to C4::Breeding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15875 --- Comment #3 from Marcel de Rooy --- horrible mess :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:57:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:57:57 +0000 Subject: [Koha-bugs] [Bug 15841] Final truth value in C4:Circulation has become displaced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15841 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 11:58:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 10:58:00 +0000 Subject: [Koha-bugs] [Bug 15841] Final truth value in C4:Circulation has become displaced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15841 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48267|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48272&action=edit Bug 15841 Circulation module's true value misplaced 1; was not at the end of the module as it should be to ensure compilation returns true return it to last line of code where it should be This patch fixes an ovious mistake. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 22 12:08:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Feb 2016 11:08:57 +0000 Subject: [Koha-bugs] [Bug 15828] Upload patron images is hard to read In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15828 --- Comment #3 from Jonathan Druart --- Comment on attachment 48149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48149 [SIGNED-OFF]Bug 15828: Upload patron images is hard to read Review of attachment 48149: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15828&attachment=48149) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/picture-upload.tt @@ +129,5 @@ > +
  • > + [% ELSE %] > +