[Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415

Héctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46760|0                           |1
        is obsolete|                            |

--- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 47567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47567&action=edit
[SIGNED-OFF]Bug 15415: Warn when creating a new print profile

This warn is hard-coded in Profile.pm

sub get_attr {
    my $self = shift;
    if (_check_params(@_) eq 1) {
        return -1;
    }
    my ($attr) = @_;
    if (exists($self->{$attr})) {
        return $self->{$attr};
    }
    else {
        warn sprintf('%s is currently undefined.', $attr); <-- THIS LINE
        return -1;
    }
}

So I have removed this line because I don't think it's really necessary.

To test:
1) Go to Tools -> Patron Card Creator -> New printer profile
2) Notice warn
3) Apply patch
4) Refresh page
5) Confirm warn is gone and page still works as expected

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Warn is gone and working correctly

-- 
You are receiving this mail because:
You are watching all bug changes.