[Koha-bugs] [Bug 15743] Allow plugins to embed Perl modules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15743

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47651|0                           |1
        is obsolete|                            |

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 47657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47657&action=edit
[SIGNED-OFF] Bug 15743: Allow plugins to embed Perl modules

This patch allows plugins to embed Perl modules by ignoring Perl modules
in plugins directory that don't inherit from Koha::Plugins::Base

TEST PLAN
---------
1) Edit koha-conf.xml to have enable_plugins set to 1, and
   the pluginsdir set to a particular path.
2) Create a dummy plugin file. (e.g. {that path}/Koha/Plugin/Kaboom.pm)
--- BEGIN Kaboom.pm ---
package Koha::Plugin::Kaboom;

use Modern::Perl;

our $VERSION = '1';
1;
--- END Kaboom.pm ---

3) Sign in to staff client
4) Reports -> Report plugins
   -- commented line version explodes.
5) Apply patch
6) Reports -> Report plugins
   -- commented line version works.
   -- the ?method= portion in the address bar
      prevents you from seeing that the plugin
      is actually considered, because various
      methods are not defined. Delete that
      portion of the URL, and you should see
      a thin empty second row appear.
7) run koha qa tests

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.