[Koha-bugs] [Bug 13995] Proper Exception handling

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

--- Comment #21 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Olli-Antti Kivilahti from comment #20)
> See the attached opendocument presentation about the pros and cons of the
> two different approaches.
> 
> If you like this approach, sign off this patch.

While I may prefer the individual file for the reason of reducing potential
conflicts, I still can't sign off for the very reason given in comment #19.

"This patch still applies, but there is no "t/Exceptions.t" test file. I think
this should be required for a sign off"

Additionally, it has usually been the case that if one method is used first in
Koha that either:
a) you do it the way already there, OR
b) you refactor the other way AFTER discussion on koha-devel.

So, if (b) is the choice, then create a refactor bug, and make this depend on
that. And of course, actually discuss this on koha-devel.

And either way, there should be a test file.

-- 
You are receiving this mail because:
You are watching all bug changes.