[Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534

Andreas Hedström Mace <andreas.hedstrom.mace at sub.su.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreas.hedstrom.mace at sub.s
                   |                            |u.se

--- Comment #7 from Andreas Hedström Mace <andreas.hedstrom.mace at sub.su.se> ---
Last week I wrote a rather lengthy comment about how I don't see how
AllowOnShelfHolds and the proposed AllowHoldIfOtherAvailable are necessarily
the same thing and should be kept as two separate sysprefs. But in writing I
got unsure if my original concerns are correct.

I went through some various setting on the two sysprefs and how I envision they
would work together with some tests of how they are handled by the patch now
(pasted at the bottom for reference, for those interested - everyone else can
skip them). My basic reservation against placing a third option on
AllowOnShelfHolds is that there are libraries who don't want to allow on shelf
holds that might want to only allow holds when all items are checked out.

But I came to realize that the third option would in effect means no on shelf
holds.

What I wonder though is how a third option for AllowOnShelfHolds would affect
connected patches, like bug 15532, and other hold options? I'm having a hard
time envisioning the extended effects of such a change. Any thought's there is
greatly appreciated!

A use case to centre this discussion around: at Stockholm University Library
the general rule is that placing holds is only possible when all item are
checked out; and no shelf holds allowed. Holds are limited per branch: only
holds that have the same pick-up branch as the holding library fills the holds
(implemented in bug 15532). However, researchers have special privileges and
are allowed to place on shelf holds.

So, I guess my basic question is - can a third option on AllowOnShelfHolds work
together with the ability to allow only items whose home/holding branch matches
the hold's pickup branch to fill a given hold (bug 15532)?

-----

How would the two sysprefs work together?

I'll shorten "Allow on shelf holds" and "Allow hold if items available" as
shelf_holds and allow_if_available here, for easier reference.)

Say we have one bib, with two items. To me, it should work this way, if
shelf_holds = no and allow_if_available = yes:
a) No items checked out - no hold allowed.
b) One item checked out (or more) - the checkout item(s) fills the hold when it
is returned, the other items are unaffected.
Testing his patch now this seem to be the case.

The other way around is a little bit more problematic: shelf_holds = yes,
allow_if_available = no. 
a) No items checked out - holds allowed.
b) One item checked out – only the item available on the shelf should fill the
hold. (A bit unsure about this one though, might require more thought.)
Testing the patch, neither of these work – no holds are allowed until they are
all checked out.

The example Owen mentioned, when both sysprefs are set to no, and being able to
place a hold when there are items available seems like a bug to me. I tried the
same setting and was not allowed to place a hold...

Setting both sysprefs = yes, should work as shelf_holds does today.

-- 
You are receiving this mail because:
You are watching all bug changes.