[Koha-bugs] [Bug 15773] Checkboxes does not work correctly when creating a new subfield for an authority framework

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773

Héctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47820|0                           |1
        is obsolete|                            |

--- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 47826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47826&action=edit
[SIGNED-OFF]Bug 15773: Fix and standardise checkboxes code in framework

When creating a new subfield for an authority framework, the checkboxes
don't behave as they should.
If you click on the 'repeatable', 'mandatory' or 'is url' checkbox's
label, the checkbox from the second tab will be checked/unchecked.
This is caused by a non-unique id of the input element.

I have found this bug when working on the removal of CGI::checkbox in
both admin/auth_subfields_structure.pl and
admin/marc_subfields_structure.pl scripts.

This patch remove the use of CGI::checkbox as well as the generation of
html code from these 2 pl scripts (which should be avoided).
The code these scripts are now pretty similar.

Test plan:
Add/modify/remove subfield for a MARC framework and an Authority
framework.
Use as many field as possible and confirm that the values are correctly
inserted/displayed.

Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.