[Koha-bugs] [Bug 15800] Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Feb 11 16:39:12 CET 2016
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800
Héctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #47899|0 |1
is obsolete| |
--- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
Created attachment 47926
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47926&action=edit
[SIGNED-OFF]Bug 15800: Koha::AuthorisedValues - Remove
C4::Koha::IsAuthorisedValueCategory
C4::Koha::IsAuthorisedValueCategory contains only 2 useful calls, from
C4::Reports::Guided and reports/guided_reports.pl
It can be replaced with
Koha::AuthorisedValues->search({ category => $authorised_value})->count
Test plan:
1/ Create a sql report using an authorised value category, something
like:
SELECT COUNT(*) FROM items where itemlost=<<lost|LOST>>
2/ Execute the report and confirm that everything works fine.
3/ Create a sql report using a nonexistent authorised value categor,
something like:
SELECT COUNT(*) FROM items where itemlost=<<lost|NONEXIST>>
4/ When saving the report, you should get a warning message
"lost: The authorized value category (NONEXIST) you selected does not exist."
5/ Save anyway and execute the report, you should get the same warning
message.
QA:
git grep IsAuthorisedValueCategory
should not return any results
prove t/db_dependent/ReportsGuided.t
should return green
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as described
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list