[Koha-bugs] [Bug 14616] Introducing Koha::Object subclasses

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14616

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 41532
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41532
Bug 14616 - Introducing Koha::Object subclasses

Review of attachment 41532:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14616&attachment=41532)
-----------------------------------------------------------------

::: Koha/Biblio.pm
@@ -44,5 @@
>  }
>  
> -=head1 AUTHOR
> -
> -Kyle M Hall <kyle at bywatersolutions.com>

Why is this being removed? I don't think Biblio.pm shouldn't even be in this
patch.

::: Koha/Biblios.pm
@@ +1,3 @@
>  package Koha::Biblios;
>  
> +# Copyright Open Source Freedom Fighters

This is an addition, not a replacement!

@@ +36,5 @@
>  }
>  
> +sub _get_castable_unique_columns {
> +    return ['biblionumber'];
> +}

This is an addition, which is fine.

@@ -55,5 @@
>  
> -=head1 AUTHOR
> -
> -Kyle M Hall <kyle at bywatersolutions.com>
> -

Again, why is this removed?

::: Koha/Item.pm
@@ +1,4 @@
>  package Koha::Item;
>  
>  # Copyright ByWater Solutions 2014
> +# Copyright Open Source Freedom Fighters

Why add a copyright for nothing added?

::: Koha/Items.pm
@@ +61,5 @@
>  =cut
>  
> +sub _get_castable_unique_columns {
> +    return ['itemnumber', 'barcode'];
> +}

Like this! Nice, sharing credit, with a functionality addition.

-- 
You are receiving this mail because:
You are watching all bug changes.