[Koha-bugs] [Bug 15854] New: Possible race condition for sending renewal notices

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15854

            Bug ID: 15854
           Summary: Possible race condition for sending renewal notices
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Renewal notices are sent as digests - all renewed items are collected in one
e-mail that is sent out with the process_messagequeue. We have a library, where
sometimes this doesn't work. Instead of one single e-mail notice to the patron
for one 'process_messagequeue' interval, multiple renewal notices are
generated. The majority of e-mails is generated correctly.

Looking at the code, this is about how it works:
- AddRenewal is exectuted per item and calls
- SendCirculationAlert which calls 
- C4::Message->find_last_message to help decide if a new notice has to be
generated or an existing one can be amended

In order to test this, you need:
- EnhancedMessagingPreferences
- Check-out notice checked for the patron you test with
- RenewalSendNotice activated
- A notice called RENEWAL

As I see no problem in the logic so far, I think it could be a race condition
where find_last_message doesn't find an existing notice (yet)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.