[Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #7)
> Not sure it's needed, as the test is very simple.
> Where would you move this subroutine?
If we would ever have to change this very simple test, it would also be very
easy to overlook a simple test.
I would keep it close to GetMarcStructure.

> Yes but it works for the moment :) The structure has not changed for years.
True

> Imo, that would make the test less strong and too specific.
OK

So, I prefer to move the ref-test to a subroutine in Biblio.pm
IsMarcStructureInternal ? or something ?
That would be the only place to document this test.

-- 
You are receiving this mail because:
You are watching all bug changes.