[Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance Improvement

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 44447
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44447
Bug 15107: Batch Patron Deletion (Trash) Performance Improvement

Review of attachment 44447:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15107&attachment=44447)
-----------------------------------------------------------------

While DBIx assures DB agnosticism, all this code is really ANSI stuff. I'm
personally torn between speed and eventual consistency (keeping DBIx across the
board). As for Martin's comment, perhaps DBIx::CopyRecord? I have no idea.

::: C4/Members.pm
@@ +1788,5 @@
> +        cardnumber, branchcode, categorycode, sort1, sort2, 
> +        dateenrolled, dateexpiry, opacnote, borrowernotes, userid,
> +        password, flags, gonenoaddress, lost, debarred, 
> +        debarredcomment, smsalertnumber, privacy
> +    };

This would be better built with C4::Member::columns()

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.