[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45260|0                           |1
        is obsolete|                            |
  Attachment #46416|0                           |1
        is obsolete|                            |
  Attachment #48269|0                           |1
        is obsolete|                            |

--- Comment #17 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 48322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48322&action=edit
Bug 15163: Do not erase patron attributes if limited to another library

The patron attributes displayed on editing a patron are not displayed if
limited to another library.

C4::Members::Attributes::SetBorrowerAttributes will now only delete attributes
the librarian is editing.
SetBorrowerAttributes takes a new $no_branch_limit parameter. If set,
the branch limitations have not effect and all attributes are deleted
(same behavior as before this patch).

Test plan:
1/ Create 2 patron attributes, without branch limitations.
2/ Edit a patron and set a value for these attributes
3/ Limit a patron attributes to a library (one you are not logged in
with).
4/ Edit again the patron.
=> You should not see the limited attributes
5/ Edit the patron attributes and remove the branch limitation
=> Without this patch, it has been removed from the database and is not
displayed anymore.
=> With this patch, you should see it.

Signed-off-by: Jesse Weaver <jweaver at bywatersolutions.com>
Works, sincere thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.