[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #47 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Katrin Fischer from comment #43)
> 1) Please remove the changes to opac-detail.tt and opac-results.tt. (see:
> http://wiki.koha-community.org/wiki/Coding_Guidelines#DEPR1:_non-
> XSLT_search_results_and_bib_display_templates_deprecated)

Changes removed

> 2) Please chose a better variable name reflecting that this is about the
> OpenUrl feature.

I am not sure of what you ask here, "COinS" is related to OpenURL, this name
makes perfect sense to me.

> 2.5) Please do the librarian in me a favor... and keep the alphabetic order
> in this file :)

Done ;)

> 3) Please create a new heading for the OpenURL preferences, so that they are
> listed in one section together.

Done

> 4) Please remove the <tt> tags (see:
> https://www.w3.org/wiki/HTML/Elements/tt). I think we are using <code> in
> some other preferences.

Done

> 5) Sorry, but I think this is bad advice. One shouldn't redefine the
> biblioitems.itemtype field like that - or you will cause yourself trouble in
> a lot of other places. For example some of the circulation code falls back
> to the itemtype defined on biblio level now.

Advice removed

> What happens when pref is left empty? Can the OpenUrl be displayed for
> records with empty biblioitems.itemtype?

If the preference is empty, the feature is disabled. It can be changed if
needed.


I took the opportunity to put opac.css changes in a separate patch as
recommended by guidelines.

-- 
You are receiving this mail because:
You are watching all bug changes.