[Koha-bugs] [Bug 15939] New: modification logs view now silently defaults to only current day's actions

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Feb 29 19:17:16 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15939

            Bug ID: 15939
           Summary: modification logs view now silently defaults to only
                    current day's actions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: gmcharlt at gmail.com
        QA Contact: testopia at bugs.koha-community.org

When accessing the modification logs from a link that does not explicitly set
the to and from dates (e.g., from patron or bib details), no results are
displayed unless the object had an action occur during the current day.

This is a side-effect of commit 5dceb851 for bug 13813:

In C4/Log.pm:

-    my $iso_datefrom =
C4::Dates->new($datefrom,C4::Context->preference("dateformat"))->output('iso');
-    my $iso_dateto =
C4::Dates->new($dateto,C4::Context->preference("dateformat"))->output('iso');
+    my $iso_datefrom = output_pref({ dt => dt_from_string( $datefrom ),
dateformat => 'iso', dateonly => 1 });
+    my $iso_dateto = output_pref({ dt => dt_from_string( $dateto ), dateformat
=> 'iso', dateonly => 1 });

In particular, C4::Dates->new($foo... returns undefined if $foo is undefined,
whereas output_pref({ dt => dt_from_string( $foo... returns the current date.

This amounts to a regression.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list