From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 03:28:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 02:28:04 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #53 from M. Tompsett --- Also, make sure there are SMS letters (notices and slips). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 03:43:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 02:43:41 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 03:44:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 02:44:34 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46083|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 46166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46166&action=edit Bug 15135: Get rid of Warning 'Subroutine HasOverdues redefined' This patch renames the subroutine HasOverdues to WithOverdues in Koha/Template/Plugin/Borrowers.pm and in members-toolbar.inc (only place where it is used). To test: - First test without patch - Search for a patron with overdues (I used the 'Overdues' report on page Home > Cirulation - Display detail page, open drop down tool 'Print'. Verify that you have an item 'Print overdues' - Apply patch - Repeat steps above. Verify that the item 'Print overdues' still appears - Search for remaining occurences of HasOverdues in template files / template includes with git grep 'Patrons.HasOverdues'. There should not be any occurences. Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 03:55:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 02:55:41 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 03:56:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 02:56:22 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46085|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 46167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46167&action=edit Bug 14133: Print notices should be generated with the print template If the overdue notice to send is an email or a SMS and the patron does not provided such information, a print notice is generated. But it will be generated with the email or sms template, which is not useful, especially in the SMS case. The template to use should be the print one. Test plan: 0/ Does not apply this patch and Correctly define the overdue rules to generate an overdue notice to the message_queue table. Check email + SMS 1/ Define an email address and a SMS number for a patron 2/ Generate the overdue notices (misc/cronjobs/overdue_notices.pl [-t]) 3/ 2 notices should have been generated: mtt=email with the email template used mtt=sms with the sms template used 4/ Truncate the message_queue table 5/ Remove the email address and repeat 2 6/ Only 1 notice should have been generated: mtt=print with the email template used 7/ Truncate the message_queue table 8/ Remove the sms alert number and repeat 2 9/ 2 notices should have been generated: mtt=print with the email template used (or sms I suppose) 10/ Apply this patch and repeat previous steps. The print notices should be generated with the print template. IMPORTANT NOTE: This test plan does not take into account the notices generated for the staff ("These messages were not sent directly to the patrons."). However the behavior will also change, the print template will be used in all cases. Is it what we want? Signed-off-by: Chris Seems fine by me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 06:19:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 05:19:58 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #54 from M. Tompsett --- HA HA! Email configured well enough. Patch applies cleanly. I believe it tests well now. I'm signing off both, but since I wrote the Schema patch, I'd like another sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 06:35:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 05:35:54 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #55 from M. Tompsett --- Created attachment 46168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46168&action=edit Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 06:47:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 05:47:12 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46163|0 |1 is obsolete| | --- Comment #56 from M. Tompsett --- Created attachment 46169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46169&action=edit Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber at provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber at messaging.sprintpcs.com Verizon phonenumber at vtext.com T-Mobile phonenumber at tmomail.net AT&T phonenumber at txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 06:47:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 05:47:20 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46165|0 |1 is obsolete| | --- Comment #57 from M. Tompsett --- Created attachment 46170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46170&action=edit Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 06:47:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 05:47:32 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46168|0 |1 is obsolete| | --- Comment #58 from M. Tompsett --- Created attachment 46171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46171&action=edit Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 06:50:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 05:50:33 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #59 from M. Tompsett --- For Canadians using Rogers: Rogers phonenumber at pcs.rogers.com See step 5 in comment #4 for wider context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 07:27:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 06:27:20 +0000 Subject: [Koha-bugs] [Bug 15445] DateUtils.t fails on Jenkins due to server sluggishness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15445 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 07:27:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 06:27:24 +0000 Subject: [Koha-bugs] [Bug 15445] DateUtils.t fails on Jenkins due to server sluggishness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15445 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46089|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 46172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46172&action=edit Bug 15445 DateUtils.t fails on Jenkins due to server sluggishness Jenkins server is abnormally slow to perform a task done in less than 1s elsewhere. The test stay valid by giving just a bit more time to Jenkins server. TO TEST: - Confirm that the two test hasn't changed. They the just get 4s to perform - Push the patch to master and observe that DateUtils.t doesn't fail anymore. NOTE: Also passed koha qa test tools too. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 07:38:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 06:38:31 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 --- Comment #4 from M. Tompsett --- Comment on attachment 45336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45336 Bug 15283 - Switch default ISSUEQSLIP notice to Template Toolkit Review of attachment 45336: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15283&attachment=45336) ----------------------------------------------------------------- The sample_notices.sql files for non-English files could have been kept closer to the original in terms of language, rather than changing them to English. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 07:40:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 06:40:17 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- New files could have used the license text found on the wiki. http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 07:40:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 06:40:59 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 --- Comment #6 from M. Tompsett --- You added a Koha level library without any test coverage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 12:42:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 11:42:06 +0000 Subject: [Koha-bugs] [Bug 15344] GetMemberDetails called unecessary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 --- Comment #16 from Marc V?ron --- (In reply to Fr?d?ric Demians from comment #15) > This patch has been pushed to 3.20.x, will be in 3.20.8. Was it pushed without the third patch? - That would be a blocker, because I still get the error from comment #13 (on master), and it seems that the third patch that fixes it is not on master. The offending line is #273 in circ/circulation.pl, we need the member details here (for useres with staff permission), otherwise we get the software error: Can't use string ("1") as a HASH ref while "strict refs" in use at /usr/share/kohaclone/C4/Circulation.pm line 815. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 13:45:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 12:45:01 +0000 Subject: [Koha-bugs] [Bug 15344] GetMemberDetails called unecessary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 --- Comment #17 from Fr?d?ric Demians --- Marc and Johnatan, thanks. I confirm 3rd patch is required. I've pushed it directly to 3.20.x branch. It still has to be pushed to master/stable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 14:12:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 13:12:20 +0000 Subject: [Koha-bugs] [Bug 14555] Warns in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555 Martin Stenberg changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42718|0 |1 is obsolete| | --- Comment #7 from Martin Stenberg --- Created attachment 46173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46173&action=edit Bug 14555: Warns in opac-search.pl Avoid use of uninitialized value in split == Test plan == 1. Go to opac advanced search 2. Click "Search" without any search query 3. Log file will show "Use of uninitialized value in split at ..." 4. Apply this patch 5. Repeat step 1 and 2 6. Log file should no longer show "Use of uninitialized value in split at ..." Sponsored-by: Regionbibliotek Halland / County library of Halland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 15:18:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 14:18:30 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #4 from Martin Stenberg --- Hi Jonathan, Do you think it's worth adding a new subroutine GetIssue for this special case of GetIssues? GetIssues will still return an arrayref when called with issue_id, so the return type matches the plural "s" at least. I'm doing an ajax request to minimize overhead when sending the request (i.e. no need to send note data for all issues when only one has been changed) and when recieving (i.e. no need to render a new template and send a whole document when only an "ok" or "nok" is needed). And as a bonus it allows the user to write a second note while the first one is beeing sent/processed to the server. To be honest I thought javascript was concidered a requirment for Koha. I'm using NoScript myself, and am always positivly surprised when a page works without having to enable javascript. How about keeping the ajax-version and adding a fallback for browsers without javascript? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 00:31:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 23:31:38 +0000 Subject: [Koha-bugs] [Bug 15454] Bad spanish translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com, | |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi :) we handle translations via translate.koha-community.org - if you register there you can suggest the correct translation or even submit it directly (depending on permissions) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 00:34:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2016 23:34:16 +0000 Subject: [Koha-bugs] [Bug 15383] Opac: Authority details: Fix translation issues with tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Opac: Autority details: Fix |Opac: Authority details: |translation issues with a |Fix translation issues with |tags |tags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 04:29:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 03:29:52 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #12 from M. Tompsett --- (In reply to Jonathan Druart from comment #11) > Anyway, what I have proposed previously was the wrong test indeed, it should > be > [% UNLESS debarments %] Or clearer, swap the IF/ELSE. You know you are generating the table [% IF (debarments) %], [% ELSE %] you are putting out that other message. The advantage of Jonathan's suggestion is smaller patch size. The disadvantage is that the novice programmer does not usually think in negation logic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 06:18:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 05:18:01 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 --- Comment #13 from M. Tompsett --- (In reply to Aleisha Amohia from comment #9) > Sorry, I made the change to [% IF ( debarments && debarments.size < 1 ) %] Actually, if you wanted to use an UGLY condition. [% IF ((! debarments) || (debarments && debarments.size<1)) %] But let's not go there. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 09:54:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 08:54:59 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #14 from M. Tompsett --- Comment on attachment 44283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44283 Bug 11144: Fix sequence of cronjobs: automatic renewal - fines - overdue notices Review of attachment 44283: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11144&attachment=44283) ----------------------------------------------------------------- ::: misc/cronjobs/crontab.example @@ +48,4 @@ > > +# AUTOMATIC RENEWAL + FINES + OVERDUE NOTICES > +# Sequence is important - renew what can be renewed, charge fines for the rest, print fine amount into overdue notices > +5 1 * * * __KOHA_USER__ $KOHA_CRON_PATH/automatic_renewals.pl && $KOHA_CRON_PATH/fines.pl && $KOHA_CRON_PATH/overdue_notices.pl -t I'm pretty sure you want semi-colons. You want to run them sequentially in this order regardless of the success or failure of script. echo one; false; echo three echo one; true; echo three echo one && false && echo three echo one && true && echo three echo one || false || echo three echo one || true || echo three Only the first two print one and three for both false and true cases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 11:00:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 10:00:10 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 --- Comment #7 from Marc V?ron --- Still applies on current master. Note: This patch is about string changes only, it does not change the functionallity. If you find an issue or want to suggest an enhancement regarding functionallity, please file a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 11:14:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 10:14:30 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 11:49:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 10:49:49 +0000 Subject: [Koha-bugs] [Bug 15457] New: HEA Display of system preferences cut Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15457 Bug ID: 15457 Summary: HEA Display of system preferences cut Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzyrea at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 11:57:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 10:57:16 +0000 Subject: [Koha-bugs] [Bug 15457] HEA Display of system preferences cut In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15457 --- Comment #1 from Marc V?ron --- Created attachment 46174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46174&action=edit HEA: Charts cut for libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 12:01:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 11:01:20 +0000 Subject: [Koha-bugs] [Bug 15457] HEA Display of system preferences cut In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15457 --- Comment #2 from Marc V?ron --- Created attachment 46175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46175&action=edit HEA: Charts cut for system preferences On the Koha community statistics website (http://hea.koha-community.org/), the charts are cut on small screens. See screenshots. A quick solution in hea.css would be to set .chart to a width of 100% (instead of 48%). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 12:03:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 11:03:55 +0000 Subject: [Koha-bugs] [Bug 15457] HEA : Display of charts is cut on Koha community statistics website In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15457 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|HEA Display of system |HEA : Display of charts is |preferences cut |cut on Koha community | |statistics website -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 12:12:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 11:12:39 +0000 Subject: [Koha-bugs] [Bug 15457] HEA : Display of charts is cut on Koha community statistics website In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15457 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 12:19:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 11:19:08 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #24 from Marc V?ron --- Does not apply: CONFLICT (content): Merge conflict in t/db_dependent/UsageStats.t Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 12:21:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 11:21:47 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Marc V?ron --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 15:11:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 14:11:01 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Marc V?ron --- Hi Jonathan, Sorry, I found following issues: 1) Syspref dateformat = dmydot (01.10.2017) is not covered by the function is_valid_date Symptom 1: - Set syspref dateformat to dmydot, clear browser chache - Try to add a manual restriction on moremember.pl - manually enter 26.01.2017 - hit 'Add restriction' Result: restriction is added with empty date = indefinite restriction. Symptom 2: - manually enter 1.1.2018 - hit enter - Message appears "Please enter valid date...", closes automatically after ca. 1 second Result: restriction is added with empty date = indefinite restriction. 2) Software error in following cases Case 1: - Set syspref dateformat to dd/mm/yyyy, clear browser cache - manually enter 1/10/2017 - hit 'Add restriction' Result: Software error: The given date (1/10/2017) does not match the date format (metric) at /usr/share/kohaclone/Koha/DateUtils.pm line 153. Case 2: - Set syspref to yyyy-mm-dd - manually enter 2017-2-2 - hit 'Add Restiction' Result: Software error: The given date (2018-2-2) does not match the date format (iso) at /usr/share/kohaclone/Koha/DateUtils.pm line 153. It seems that the timepicker's function parseDate accepts such dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 17:38:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 16:38:39 +0000 Subject: [Koha-bugs] [Bug 3317] Author displays inconsistently ( and incorrectly ) in opac-basket.pl (and when emailing cart ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3317 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Is this bug still valid? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 17:39:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 16:39:28 +0000 Subject: [Koha-bugs] [Bug 2710] save buttons should be at both top and bottom of certain forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2710 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #4 from Marc V?ron --- Is this bug still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 18:06:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 17:06:58 +0000 Subject: [Koha-bugs] [Bug 5512] Display Published Date with Received Date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5512 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Is this bug still valid? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 18:13:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 17:13:19 +0000 Subject: [Koha-bugs] [Bug 6847] Bulk userid, password generation and email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6847 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Is this bug still valid? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 18:22:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 17:22:59 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 18:23:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 17:23:03 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39419|0 |1 is obsolete| | --- Comment #16 from Fr?d?ric Demians --- Created attachment 46176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46176&action=edit Bug 11081: Port Koha::Contrib::Tamil indexer into Koha code base Add two scripts for indexing: koha-index and koha-index-daemon. Documentation: perldoc koha-index perldoc koha-index-daemon New dependencies: MooseX::Getopt MooseX::RW AnyEvent::Processor Available as a Debian package: libmoosex-getopt-perl Test plan: - Apply the patch - Install dependencies, if necessary - Reindex a whole biblio catalog: koha-index --verbose - Reindex a whole authorities catalog: koha-index --source authority --verbose - Modify 1 biblio record, and index it: koha-index --select queue - Modifiy 1 authority record, and index it: koha-index --select queue --source authority - Run indexing daemon, with a 15s timeout: koha-index-daemon --timeout 15 - Modify a biblio record: wait 15s, and see - Modify an authority record: wait 15s, and see Signed-off-by: Bernardo Gonzalez Kriegel Works well, followed test plan without problems One comment: perhaps an option for koha-index-daemon to work quietly, without printing information. No koha-qa errors, but new files don't have license, fixed in followup Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 18:23:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 17:23:25 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39420|0 |1 is obsolete| | --- Comment #17 from Fr?d?ric Demians --- Created attachment 46177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46177&action=edit Bug 11081: (followup) Add license information Signed-off-by: Fr?d?ric Demians Signed-off-by: Kyle M Hall Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 18:24:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2016 17:24:14 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 --- Comment #18 from Fr?d?ric Demians --- Rebased, and revert to Passed QA status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 11:27:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 10:27:57 +0000 Subject: [Koha-bugs] [Bug 15383] Opac: Authority details: Fix translation issues with tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15383 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 11:29:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 10:29:10 +0000 Subject: [Koha-bugs] [Bug 15447] log4perl.conf does not have __LOG_DIR__ replaced when installing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15447 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 11:35:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 10:35:25 +0000 Subject: [Koha-bugs] [Bug 14397] Typo 'foriegn' in table comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14397 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 11:54:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 10:54:02 +0000 Subject: [Koha-bugs] [Bug 14034] User logged out on refresh after Shibboleth authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 12:16:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 11:16:26 +0000 Subject: [Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #13 from Julian Maurice --- (In reply to Katrin Fischer from comment #12) > Hi Julian, I think this is in a grey area - for libraries using RDA it means > that the publication year, publisher etc. is missing from the export formats > - which is quite important information. Sorry, I didn't see comment 8. So, switching to 'normal' severity again, and I will push it into 3.22.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 12:17:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 11:17:04 +0000 Subject: [Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 12:21:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 11:21:56 +0000 Subject: [Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Severity|minor |enhancement --- Comment #9 from Julian Maurice --- Switching severity to 'enhancement' as the patch does not fix any bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 12:22:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 11:22:15 +0000 Subject: [Koha-bugs] [Bug 15317] Use Bootstrap modal for MARC and Card preview when ordering from staged files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Severity|minor |enhancement --- Comment #7 from Julian Maurice --- Switching severity to 'enhancement' as the patch does not fix any bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 12:22:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 11:22:33 +0000 Subject: [Koha-bugs] [Bug 15318] Use Bootstrap modal for MARC and Card preview when ordering an external source In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15318 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Switching severity to 'enhancement' as the patch does not fix any bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 12:22:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 11:22:59 +0000 Subject: [Koha-bugs] [Bug 15320] Use Bootstrap modal for MARC preview when ordering from an existing record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15320 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Severity|minor |enhancement --- Comment #6 from Julian Maurice --- Switching severity to 'enhancement' as the patch does not fix any bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 15:53:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 14:53:22 +0000 Subject: [Koha-bugs] [Bug 6845] Add default date (today) to view log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6845 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Is this bug still valid? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 21:23:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 20:23:17 +0000 Subject: [Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 --- Comment #15 from Katrin Fischer --- Thx Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 21:24:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 20:24:21 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com, | |katrin.fischer at bsz-bw.de Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 21:35:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 20:35:27 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #286 from Chris Cormack --- Created attachment 46178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46178&action=edit Bug 7143 : Adding releases and fixing some missing tabs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 21:35:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 20:35:48 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 21:36:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2016 20:36:01 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 02:35:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 01:35:16 +0000 Subject: [Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434 --- Comment #8 from Srdjan Jankovic --- As far as I can see it is a bug either in * modules/svc/suggestion.tt, line 37, that composes query as q=[indexed query], or in * C4::Search::parseQuery() that cannot deal with that kind of query I think that buildQuery() actually builds an invalid query, but I'd certainly need an authoritative opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 03:48:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 02:48:31 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Needs Signoff |Patch doesn't apply --- Comment #43 from Chris Cormack --- Falling back to patching base and 3-way merge... Auto-merging reports/issues_stats.pl CONFLICT (content): Merge conflict in reports/issues_stats.pl Failed to merge in the changes. Not a simple conflict -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 04:00:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 03:00:23 +0000 Subject: [Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 04:08:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 03:08:18 +0000 Subject: [Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 04:08:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 03:08:21 +0000 Subject: [Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35164|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 46179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46179&action=edit Bug 13572 - Add onlyactives parameter to force_borrower_messaging_defaults script 1) Apply both patches 2) Create a new patron with random values, except for it expiration date, make it expired (Patrons > New Patron > Student) 3) Enable the system preference called ?EnhancedMessagingPreferences? 4) In ?Administration" > "Patron categories" > Student, modify the "days in advance", then click "Save" 5) run the script "./misc/maintenance/borrowers-force-messaging-defaults --doit --onlyactives" 6) Validate that the student created in step 2 hasn't changed (Patrons > search) 7) Validate that any other student that isn't expired has changed. Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 04:08:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 03:08:48 +0000 Subject: [Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41235|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 46180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46180&action=edit Bug13572 - Changed "borrowers-force-messaging-defaults" --help parameter's result to better explain the new functionality New test plan (well, a clearer version): 1) Apply both patches 2) Create a new patron with random values, except for it expiration date, make it expired (Patrons > New Patron > Student) 3) Enable the system preference called ?EnhancedMessagingPreferences? 4) In ?Administration" > "Patron categories" > Student, modify the "days in advance", then click "Save" 5) run the script "./misc/maintenance/borrowers-force-messaging-defaults --doit --onlyactives" 6) Validate that the student created in step 2 hasn't changed (Patrons > search) 7) Validate that any other student that isn't expired has changed. Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 04:18:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 03:18:15 +0000 Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #56 from Chris Cormack --- With the plack in production as of 3.22.0 this bug needs a rethink, the patches as they stand will duplicate a lot of stuff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 04:37:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 03:37:20 +0000 Subject: [Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 04:37:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 03:37:25 +0000 Subject: [Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42061|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 46181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46181&action=edit Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline' Koha::Logger allows us to split up logging to separate files based on the interface. However, right now the interface is limited to just 'opac' or 'intranet'. We should extend this to allow the interface to also be set to 'sip' for SIP server logging, and to 'commandline' for cronjobs and all other command line scripts. Signed-off-by: Chris Does what it says on the tin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 04:54:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 03:54:40 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25526|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 46182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46182&action=edit Bug 11807 : Add support for categorycode conversions when updating an user using a LDAP server. To test 1/ Apply both patches 2/ This patch lets you easily configure mappings for categorycode values. These mapping will be used when updating the user's account after a successful LDAP login. Here is an example configuration : STU ... STUDENT EMPLOYEE 3/ With this configuration, LDAP users with the usertype value "EMP" on the LDAP server should have the "EMPLOYEE" categorycode in Koha. Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 04:57:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 03:57:22 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 04:57:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 03:57:26 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42105|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 46183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46183&action=edit Bug 11807: (follow-up) remove date conversions To test 1/ Apply both patches 2/ This patch lets you easily configure mappings for categorycode values. These mapping will be used when updating the user's account after a successful LDAP login. Here is an example configuration : STU ... STUDENT EMPLOYEE 3/ With this configuration, LDAP users with the usertype value "EMP" on the LDAP server should have the "EMPLOYEE" categorycode in Koha. Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 05:01:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 04:01:59 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Can we get a sign off on this please, I can't sign it off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:38:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:38:39 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #44 from M. Tompsett --- (In reply to Chris Cormack from comment #43) > Falling back to patching base and 3-way merge... > Auto-merging reports/issues_stats.pl > CONFLICT (content): Merge conflict in reports/issues_stats.pl > Failed to merge in the changes. > > > Not a simple conflict Most of it seemed to be whitespace indentation issues. I'll upload a fix, and then do a comparison to make sure nothing seems lost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:39:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:39:55 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39250|0 |1 is obsolete| | --- Comment #45 from M. Tompsett --- Created attachment 46184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46184&action=edit Bug 7679: circulation statistics wizard improvements - Add patron branch to the list of possible rows, columns, and filters - Add extended patron attributes to the list of possible rows, columns, and filters - Allow to group period by hour - Allow to translate filter names NOTE: Removed signed off, since I believe I have dealt with the conflicts. Retesting required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:40:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:40:01 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39251|0 |1 is obsolete| | --- Comment #46 from M. Tompsett --- Created attachment 46185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46185&action=edit Bug 7679: Followup: circulation statistics wizard improvements Signed-off-by: Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:40:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:40:08 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39252|0 |1 is obsolete| | --- Comment #47 from M. Tompsett --- Created attachment 46186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46186&action=edit Bug 7679: Fix criteria display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:40:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:40:15 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39253|0 |1 is obsolete| | --- Comment #48 from M. Tompsett --- Created attachment 46187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46187&action=edit Bug 7679: Group different case values in the same row/column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:40:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:40:21 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39254|0 |1 is obsolete| | --- Comment #49 from M. Tompsett --- Created attachment 46188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46188&action=edit Bug 7679: Fix several bugs in circulation statistics wizard - Display values in NULL columns/rows - Display columns/rows that contain values only in NULL rows/columns - "To" filter in period row should be inclusive (YYYY-MM-DD should be YYYY-MM-DD 23:59:59) - Make it possible to use only the "To" filter in period row (actually it results in DBI error (2 bind variables instead of 1)) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:40:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:40:28 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39255|0 |1 is obsolete| | --- Comment #50 from M. Tompsett --- Created attachment 46189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46189&action=edit Bug 7679: Fix two SQL queries when using patron attributes and remove some Perl warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:40:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:40:35 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39256|0 |1 is obsolete| | --- Comment #51 from M. Tompsett --- Created attachment 46190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46190&action=edit Bug 7679: Various fixes for circulation statistics wizard - use SQL TRIM functions to avoid having '' and ' ' considered as different values - use Text::Unaccent to remove accents from columns or rows values when accessing %table. This is required as MySQL consider as equals two strings that differ only by their accents when using GROUP BY clause. - Exclude '' values from the list of columns or rows. Otherwise we could have a row 'UNKNOWN VALUE' and a row 'NULL' which both have the same values in their cells. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:40:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:40:41 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39257|0 |1 is obsolete| | --- Comment #52 from M. Tompsett --- Created attachment 46191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46191&action=edit Bug 7679: Display all table headers (case and accent sensitive) It appears that we can't assume that a lowercase word is equivalent to the same word in uppercase (or a mix of lowercase and uppercase letters). And this is also true about accented words. So display all values even if they differ only by case or by their accents. This means that: - "foobar" and "Foobar" will be in two separate rows/columns - "Etudiant" and "?tudiant" (french) will be in two separate rows/columns too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:57:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:57:14 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46184|0 |1 is obsolete| | --- Comment #53 from M. Tompsett --- Created attachment 46192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46192&action=edit Bug 7679: circulation statistics wizard improvements - Add patron branch to the list of possible rows, columns, and filters - Add extended patron attributes to the list of possible rows, columns, and filters - Allow to group period by hour - Allow to translate filter names NOTE: Removed signed off, since I believe I have dealt with the conflicts. Retesting required. Found some comments C4::Date that I missed. line prepatch 194/ postpatch 233 seems to be where the major conflict is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:57:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:57:21 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46185|0 |1 is obsolete| | --- Comment #54 from M. Tompsett --- Created attachment 46193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46193&action=edit Bug 7679: Followup: circulation statistics wizard improvements Signed-off-by: Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:57:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:57:27 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46186|0 |1 is obsolete| | --- Comment #55 from M. Tompsett --- Created attachment 46194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46194&action=edit Bug 7679: Fix criteria display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:57:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:57:34 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46187|0 |1 is obsolete| | --- Comment #56 from M. Tompsett --- Created attachment 46195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46195&action=edit Bug 7679: Group different case values in the same row/column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:57:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:57:40 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46188|0 |1 is obsolete| | --- Comment #57 from M. Tompsett --- Created attachment 46196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46196&action=edit Bug 7679: Fix several bugs in circulation statistics wizard - Display values in NULL columns/rows - Display columns/rows that contain values only in NULL rows/columns - "To" filter in period row should be inclusive (YYYY-MM-DD should be YYYY-MM-DD 23:59:59) - Make it possible to use only the "To" filter in period row (actually it results in DBI error (2 bind variables instead of 1)) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:57:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:57:45 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46189|0 |1 is obsolete| | --- Comment #58 from M. Tompsett --- Created attachment 46197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46197&action=edit Bug 7679: Fix two SQL queries when using patron attributes and remove some Perl warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:57:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:57:51 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46190|0 |1 is obsolete| | --- Comment #59 from M. Tompsett --- Created attachment 46198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46198&action=edit Bug 7679: Various fixes for circulation statistics wizard - use SQL TRIM functions to avoid having '' and ' ' considered as different values - use Text::Unaccent to remove accents from columns or rows values when accessing %table. This is required as MySQL consider as equals two strings that differ only by their accents when using GROUP BY clause. - Exclude '' values from the list of columns or rows. Otherwise we could have a row 'UNKNOWN VALUE' and a row 'NULL' which both have the same values in their cells. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:57:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:57:57 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46191|0 |1 is obsolete| | --- Comment #60 from M. Tompsett --- Created attachment 46199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46199&action=edit Bug 7679: Display all table headers (case and accent sensitive) It appears that we can't assume that a lowercase word is equivalent to the same word in uppercase (or a mix of lowercase and uppercase letters). And this is also true about accented words. So display all values even if they differ only by case or by their accents. This means that: - "foobar" and "Foobar" will be in two separate rows/columns - "Etudiant" and "?tudiant" (french) will be in two separate rows/columns too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 06:58:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 05:58:21 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:25:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:25:08 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38946|0 |1 is obsolete| | --- Comment #25 from M. Tompsett --- Created attachment 46200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46200&action=edit Bug 14097: Testing C4::UsageStats DESCRIPTION ----------- Add unit tests to C4::UsageStats Subroutine : (V : tested, X : Not tested) V NeedUpdate V BuiltReport X ReportToCommunity V _count TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/UsageStats.t -- All tests should run successfully /!\ I have 1 warning but I don't know where it can come /!\ (in cleanup) DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 308 TEST PLAN OPTIONAL ------------------ Go check bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 40,5% Branch : 0,0% Condition : 0,0% Subroutine : 55,6% Coverage AFTER this patch : Statement : 81,0% Branch : 100,0% Condition : 100,0% Subroutine : 88,8% Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:25:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:25:19 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38947|0 |1 is obsolete| | --- Comment #26 from M. Tompsett --- Created attachment 46201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46201&action=edit Bug 14097: Delete table issues before testing If we delete all biblio DB, we could have some troubles with foreign keys Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:25:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:25:30 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38948|0 |1 is obsolete| | --- Comment #27 from M. Tompsett --- Created attachment 46202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46202&action=edit Bug 14097: changing verif_systempreferences_values subroutine It's saving a large number of lines Signed-off-by: Bernardo Gonzalez Kriegel All tests run, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:25:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:25:55 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39085|0 |1 is obsolete| | --- Comment #28 from M. Tompsett --- Created attachment 46203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46203&action=edit Bug 14097: Rollback issue and warning corrected The rollback issue came from '_count' testing. It used a 'DROP TABLE' and 'CREATE TABLE' which implicitly do autocommit. That's why the final rollback could not be. This patch no longer uses t::lib::TestBuilder either because it was the cause of the warning on Comment #1 : "DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 308" Signed-off-by: Bernardo Gonzalez Kriegel Now data is preserved, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:26:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:26:05 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39435|0 |1 is obsolete| | --- Comment #29 from M. Tompsett --- Created attachment 46204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46204&action=edit Bug 14097 - Correct noise under Debian The first four patches do not create any noise under Ubuntu 14.04 LTS. Running on Debian Jessie: [SNIP] keys on reference is experimental at t/db_dependent/UsageStats.t line 88. keys on reference is experimental at t/db_dependent/UsageStats.t line 106. keys on reference is experimental at t/db_dependent/UsageStats.t line 119. keys on reference is experimental at t/db_dependent/UsageStats.t line 136. keys on reference is experimental at t/db_dependent/UsageStats.t line 153. keys on reference is experimental at t/db_dependent/UsageStats.t line 162. keys on reference is experimental at t/db_dependent/UsageStats.t line 587. [SNIP] Instead of having 'keys $foo->{bar}', 'keys %{$foo->{bar}}' was used. TEST PLAN --------- 1) On a DEBIAN system (Jessie gives above messages) apply the first 4 patches interactively. 2) $ prove t/db_dependent/UsageStats.t -- trigger noise like above. 3) apply this patch 4) $ prove t/db_dependent/UsageStats.t -- no noise triggered. 5) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:26:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:26:13 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41843|0 |1 is obsolete| | --- Comment #30 from M. Tompsett --- Created attachment 46205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46205&action=edit Bug 14097 : Avoid issue if the number of syspref shared is modified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:26:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:26:27 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41844|0 |1 is obsolete| | --- Comment #31 from M. Tompsett --- Created attachment 46206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46206&action=edit Bug 14097 : Changing AddReserve prototype call In response of Joubu comment #19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:26:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:26:36 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #32 from M. Tompsett --- Created attachment 46207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46207&action=edit Bug 14097: Fixed missing test cases Fixed AllowPkiAuth issue caused by 15101. Added missing AudioAlerts TEST PLAN --------- 1) prove -v t/db_dependent/UsageStats.t -- should pass after applying patch 2) Run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:30:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:30:14 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46200|0 |1 is obsolete| | --- Comment #33 from M. Tompsett --- Created attachment 46208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46208&action=edit Bug 14097: Testing C4::UsageStats DESCRIPTION ----------- Add unit tests to C4::UsageStats Subroutine : (V : tested, X : Not tested) V NeedUpdate V BuiltReport X ReportToCommunity V _count TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/UsageStats.t -- All tests should run successfully /!\ I have 1 warning but I don't know where it can come /!\ (in cleanup) DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 308 TEST PLAN OPTIONAL ------------------ Go check bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 40,5% Branch : 0,0% Condition : 0,0% Subroutine : 55,6% Coverage AFTER this patch : Statement : 81,0% Branch : 100,0% Condition : 100,0% Subroutine : 88,8% Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:30:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:30:21 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46201|0 |1 is obsolete| | --- Comment #34 from M. Tompsett --- Created attachment 46209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46209&action=edit Bug 14097: Delete table issues before testing If we delete all biblio DB, we could have some troubles with foreign keys Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:30:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:30:30 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46202|0 |1 is obsolete| | --- Comment #35 from M. Tompsett --- Created attachment 46210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46210&action=edit Bug 14097: changing verif_systempreferences_values subroutine It's saving a large number of lines Signed-off-by: Bernardo Gonzalez Kriegel All tests run, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:30:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:30:34 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:30:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:30:36 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46203|0 |1 is obsolete| | --- Comment #36 from M. Tompsett --- Created attachment 46211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46211&action=edit Bug 14097: Rollback issue and warning corrected The rollback issue came from '_count' testing. It used a 'DROP TABLE' and 'CREATE TABLE' which implicitly do autocommit. That's why the final rollback could not be. This patch no longer uses t::lib::TestBuilder either because it was the cause of the warning on Comment #1 : "DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 308" Signed-off-by: Bernardo Gonzalez Kriegel Now data is preserved, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:30:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:30:40 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46204|0 |1 is obsolete| | --- Comment #37 from M. Tompsett --- Created attachment 46212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46212&action=edit Bug 14097 - Correct noise under Debian The first four patches do not create any noise under Ubuntu 14.04 LTS. Running on Debian Jessie: [SNIP] keys on reference is experimental at t/db_dependent/UsageStats.t line 88. keys on reference is experimental at t/db_dependent/UsageStats.t line 106. keys on reference is experimental at t/db_dependent/UsageStats.t line 119. keys on reference is experimental at t/db_dependent/UsageStats.t line 136. keys on reference is experimental at t/db_dependent/UsageStats.t line 153. keys on reference is experimental at t/db_dependent/UsageStats.t line 162. keys on reference is experimental at t/db_dependent/UsageStats.t line 587. [SNIP] Instead of having 'keys $foo->{bar}', 'keys %{$foo->{bar}}' was used. TEST PLAN --------- 1) On a DEBIAN system (Jessie gives above messages) apply the first 4 patches interactively. 2) $ prove t/db_dependent/UsageStats.t -- trigger noise like above. 3) apply this patch 4) $ prove t/db_dependent/UsageStats.t -- no noise triggered. 5) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:30:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:30:45 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46205|0 |1 is obsolete| | --- Comment #38 from M. Tompsett --- Created attachment 46213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46213&action=edit Bug 14097 : Avoid issue if the number of syspref shared is modified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:30:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:30:49 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46206|0 |1 is obsolete| | --- Comment #39 from M. Tompsett --- Created attachment 46214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46214&action=edit Bug 14097 : Changing AddReserve prototype call In response of Joubu comment #19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 07:30:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 06:30:54 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46207|0 |1 is obsolete| | --- Comment #40 from M. Tompsett --- Created attachment 46215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46215&action=edit Bug 14097: Fixed missing test cases Fixed AllowPkiAuth issue caused by 15101. Added missing AudioAlerts TEST PLAN --------- 1) prove -v t/db_dependent/UsageStats.t -- should pass after applying patch 2) Run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 08:18:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 07:18:42 +0000 Subject: [Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #17 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 08:27:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 07:27:38 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11315 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 [Bug 11315] Add support for subfield deletion when doing authority merges. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 08:27:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 07:27:38 +0000 Subject: [Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15358 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 [Bug 15358] merge.pl does not populate values to merge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 08:32:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 07:32:50 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- Another one I can't sign off on, could someone please test this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 08:42:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 07:42:01 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #29 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 08:52:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 07:52:03 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 08:52:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 07:52:08 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45943|0 |1 is obsolete| | --- Comment #77 from Chris Cormack --- Created attachment 46216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46216&action=edit Bug 7677 [Follow-up]: New areas in subscriptions and new functions when receiving. - Various fixes. Test plan: Once the makePreviousSerialAvailable syspref is enabled, receive a serial, and then another, then check that: - the first received itemtype has been set to the "previous item type" value (set in the subscription). - the first received has been made available. - the last received serial itemtype has been set to the "item type" value (set in the subscription). - 995$l is automatically prefilled. Configure the serialsFieldsToAV syspref. When creating or editing a subscription, check that: - the domain and/or origin and/or support fields are correctly displaying the authorized values configured in the syspref. Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 10:03:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 09:03:32 +0000 Subject: [Koha-bugs] [Bug 15442] Checkouts table will not display due to javascript error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15442 --- Comment #7 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #6) > This patch has been pushed to 3.20.x, will be in 3.20.8. This patch is a bug fix for bug 15289, which is not in 3.20.x. It was not needed for this branch but won't cause any regression. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 10:27:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 09:27:14 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46156|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart --- Created attachment 46217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46217&action=edit Bug 12528: Bug 9254: Followup - Rename pref to EnhancedMessagingPreferencesOPAC If the new pref is named EnhancedMessagingPreferencesOPAC, it will show up adjacent to EnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 10:27:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 09:27:20 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #55 from Jonathan Druart --- Created attachment 46218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46218&action=edit Bug 12528: redirect to 404 if at least 1 pref is off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 10:28:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 09:28:03 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #56 from Jonathan Druart --- Please keep authorship -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 10:34:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 09:34:18 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 --- Comment #11 from Marcel de Rooy --- http://code4lib.org/files/unapi_revision_1-14.html https://www.google.nl/url?sa=t&rct=j&q=&esrc=s&source=web&cd=4&ved=0ahUKEwjFvafUzPbJAhWCDhoKHarGDJUQFgg4MAM&url=https%3A%2F%2Fir.library.oregonstate.edu%2Fxmlui%2Fbitstream%2Fhandle%2F1957%2F2359%2Fintro-unapi-draftV15.doc%3Fsequence%3D8&usg=AFQjCNEGxssbXiRQmzUPElGJkGQd1hjx5w&bvm=bv.110151844,d.bGQ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 10:38:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 09:38:02 +0000 Subject: [Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45922|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 46219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46219&action=edit Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] There was already 2 Koha::Branch[es] using Koha::Object[s] before. For this new rewrite, it seems preferable to start with good basis and name the new modules Koha::Library and Koha::Libraries. Tested both patches together, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 10:38:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 09:38:07 +0000 Subject: [Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45923|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 46220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46220&action=edit Bug 15294: Koha::Libraries - Rewrite the admin scripts This patch rewrites the admin/branches.pl script to use the new modules instead of C4::Branches. Test plan: 1/ Create libraries using all the fields available 2/ Create groups of libraries 3/ Assign 1+ libraries to some groups 4/ Delete libraries and groups of libraries You should not able to delete a library if items or patrons use it. You should not able to delete a group of libraries if there are still libraries using it. 5/ Update libraries and groups of libraries Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 10:40:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 09:40:05 +0000 Subject: [Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 --- Comment #12 from Jonathan Druart --- (In reply to Brendan Gallagher from comment #9) > Didn't apply cleanly for me - can you rebase this Jonathan? (ping me when > you've rebased so I can test it and push it). > > Thanks! Trivial conflicts with bug 15373, bug 13517 and bug 13853 fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 10:41:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 09:41:49 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42013|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy --- Created attachment 46221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46221&action=edit Bug 14306: Remove call to GetMarcNotes from sendshelf Just as mentioned in the first patch for sendbasket, I discovered that the call of GetMarcNotes is not really used in sendshelf. The array is passed to the template, but the template does not use it. (It uses the information from GetBiblioData.) Test plan: [1] Send a list that includes a record with some notes (opac and staff). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 10:43:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 09:43:40 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #19 from Marcel de Rooy --- Rebased. Who adds a signoff? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 11:03:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 10:03:20 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 11:03:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 10:03:23 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 --- Comment #5 from Jonathan Druart --- Created attachment 46222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46222&action=edit Bug 15354: Sort itemtypes by translated description everywhere on circ rules admin page It's better to cmp on lc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 11:05:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 10:05:56 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 --- Comment #6 from Jonathan Druart --- (In reply to Jesse Weaver from comment #4) > Minor whitespace issues: > > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt > FAIL forbidden patterns > forbidden pattern: tab char (line 188) > SKIP spelling > OK tt_valid > OK valid_template > > (These aren't really your fault; I put a patch to fix all this mess on bug > 15456 that you can rebase onto if you'd prefer.) I think it should be fixed asap and not depend on something else to ease a possible backport. > More importantly, though, I noticed that while the item type descriptions > now correctly show, and the list of rules is sorted by the translated > description, the item type selection dropdown is not sorted by the > translated description. Good catch. I have fixed it. Not that C4::Koha::GetItemTypes should be fixed for a global fix. It will be easy to do on top of bug 14828. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 11:39:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 10:39:52 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #11 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #10) > Hi Marcel, > > can you please fix the patches to work with the renamed files from bug 15181? The big change that affects this patch, comes from: b2c302440b7d33e8dc3923b645286a70111dd305 Bug 15097: Update MARC21 de-DE frameworks to Update 21 (September 2015) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 11:44:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 10:44:56 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #12 from Katrin Fischer --- How is that? Maybe it's bug 10963? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 11:57:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 10:57:16 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #13 from Katrin Fischer --- Ah sorry, missed looking at the second patch - but I think some more frameworks updated since (it-IT?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:03:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 11:03:48 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44020|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 46223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46223&action=edit Bug 14199: Modify webinstaller sql files for marc21_orgcode plugin This patch updates the sql installer files for new installations. Occurrences to the three plugins marc21_field_003, 040c and 040d are replaced by marc21_orgcode.pl. This has been generated by one sed statement. Test plan: [1] Run a new installation or run some of the changed sql files manually. [2] Verify that marc21_orgcode is linked to fields previously linked to the three old plugins. [3] Do a git grep on the three plugin file names. No occurrences expected. Signed-off-by: Marcel de Rooy Have tested the three english sql files: authorities_normal_marc21.sql: 18 rows with marc21_orgcode (003 and 040a for 9 auth codes) marc21_framework_DEFAULT.sql: 1 row with marc21_orgcode (003) -- this patch does not add them to 040c or 040d; no behavior change.. marc21_simple_bib_frameworks.sql: 8 rows (003 for 8 frameworks) Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Marcel de Rooy The following files do no longer need an adjustment: installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql installer/data/mysql/it-IT/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql For details, check Bug 15097: Update MARC21 de-DE frameworks to Update 21. And similar reports for es-ES and it-IT. Verified this change by installing de-DE in the webinstaller. The plugin for field 003 was correctly set to marc21_orgcode.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:04:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 11:04:10 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #17 from Jonathan Druart --- Created attachment 46224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46224&action=edit Bug 14060: Add support for dmydot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:05:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 11:05:29 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #18 from Jonathan Druart --- (In reply to Marc V?ron from comment #16) > Hi Jonathan, > > Sorry, I found following issues: > > 1) > Syspref dateformat = dmydot (01.10.2017) is not covered by the function > is_valid_date > > Symptom 1: > - Set syspref dateformat to dmydot, clear browser chache > - Try to add a manual restriction on moremember.pl > - manually enter 26.01.2017 > - hit 'Add restriction' > Result: restriction is added with empty date = indefinite restriction. > > Symptom 2: > - manually enter 1.1.2018 > - hit enter > - Message appears "Please enter valid date...", closes automatically after > ca. 1 second > Result: restriction is added with empty date = indefinite restriction. Should be fixed with the last patch. > 2) > Software error in following cases > > Case 1: > - Set syspref dateformat to dd/mm/yyyy, clear browser cache > - manually enter 1/10/2017 > - hit 'Add restriction' > Result: Software error: The given date (1/10/2017) does not match the date > format (metric) at /usr/share/kohaclone/Koha/DateUtils.pm line 153. > > Case 2: > - Set syspref to yyyy-mm-dd > - manually enter 2017-2-2 > - hit 'Add Restiction' > Result: Software error: The given date (2018-2-2) does not match the date > format (iso) at /usr/share/kohaclone/Koha/DateUtils.pm line 153. > > It seems that the timepicker's function parseDate accepts such dates. I don't manage to force the leading zeros, suggestions are welcome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:05:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 11:05:44 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:15:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 11:15:38 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #5 from Jonathan Druart --- (In reply to Martin Stenberg from comment #4) > Hi Jonathan, > > Do you think it's worth adding a new subroutine GetIssue for this special > case of GetIssues? GetIssues will still return an arrayref when called with > issue_id, so the return type matches the plural "s" at least. GetIssue would not return an array, but the matching issue. > I'm doing an ajax request to minimize overhead when sending the request > (i.e. no need to send note data for all issues when only one has been > changed) and when recieving (i.e. no need to render a new template and send > a whole document when only an "ok" or "nok" is needed). And as a bonus it > allows the user to write a second note while the first one is beeing > sent/processed to the server. > > To be honest I thought javascript was concidered a requirment for Koha. I'm > using NoScript myself, and am always positivly surprised when a page works > without having to enable javascript. > > How about keeping the ajax-version and adding a fallback for browsers > without javascript? You can add 2 forms in the page, the one needing JS can be hidden with a css rule. When the page is loading, a JS code could hide one and display the other one. I suppose it's the way to go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:17:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 11:17:04 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #6 from Jonathan Druart --- Additional note: the ajax part should be moved to svc/ and some of this code put in a subroutine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:28:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 11:28:20 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #20 from Marc V?ron --- Hi Marcel, a question about the test plan: Do you expect the values (500$a, 555$a and a URL in 555$u) to be inserted into the mails? Or should we test only that the mails still work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:36:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 11:36:50 +0000 Subject: [Koha-bugs] [Bug 15458] New: Marc21 leader 07 error in translation: "a- Serial component" part is not in format Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15458 Bug ID: 15458 Summary: Marc21 leader 07 error in translation: "a- Serial component" part is not in format Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: paivi.knuutinen at jns.fi QA Contact: testopia at bugs.koha-community.org Created attachment 46225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46225&action=edit a- Monographic component part; b- Serial component part -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:39:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 11:39:42 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #100 from Jonathan Druart --- Branches rebased against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:40:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 11:40:04 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #101 from Jonathan Druart --- Branch rebased against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:50:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 11:50:53 +0000 Subject: [Koha-bugs] [Bug 15443] Re-code RESERVESLIP as HOLD_SLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15443 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:50:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 11:50:56 +0000 Subject: [Koha-bugs] [Bug 15443] Re-code RESERVESLIP as HOLD_SLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15443 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46153|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 46226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46226&action=edit Bug 15443 - Re-code RESERVESLIP as HOLD_SLIP It's a bit confusing to have RESERVESLIP named "Hold Slip", we should finish the job and recode the slip. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Try printing a hold slip, you should note no difference from pre-patch behavior Followed test plan. The slip is triggered if you want to check out an item that is reserved / on hold for another patron. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:57:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 11:57:46 +0000 Subject: [Koha-bugs] [Bug 13774] Add the unique anchors of news as links in the RSS for news in Opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:57:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 11:57:49 +0000 Subject: [Koha-bugs] [Bug 13774] Add the unique anchors of news as links in the RSS for news in Opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46154|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 46227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46227&action=edit Bug 13774 Add the unique anchors of news as links in the RSS for news in Opac This patch adds the unique anchors of bugs from bug13729 into the rss stream of the news in opac from bug7843. Since 7843 is already passed QA and I'm new to Git and mess things up I chose to post this update in a separate patch even if it's a tiny change. The addition of a unique guid tag both help users and keeps validators happy. Test plan: * Make sure you are on master in order to get the anchors from bug 13729 (or you could apply it manually). * Apply bug 7843 * Apply this patch. * Make shure you have enough news to make the Opac main page scroll. * Find the RSS link at the bottom om opac main and klick it. * Verify that the link displayed for each newsitem takes you to the right anchor. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:22:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:22:04 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Failed QA --- Comment #31 from Jonathan Druart --- QA comments: This is a very simple implementation, but could be considered as a first step. I would like to get feedback from someone else (ccing some QA people). For instance 1. there is no way to sent an sms instead of an email, 2. the letter is generated even if the patron does not have an email address defined, 3. there is no way to know if a recall has already been generated I don't understand the use case, why don't you use the overdue_notices script instead? Technical review: 1/ A variable items_checked_out is passed to the template but never used. 2/ ajax script should be moved to the svc/ directory 3/ The Recall button is display if the pref is set, then the user get an unauthorised message if does not have the permission. It would be easier not to display the button in this case... (and sent a 403 if the script is called). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:22:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:22:42 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 --- Comment #32 from Jonathan Druart --- I have set the status to "Failed QA", but it's more a "In discussion". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:23:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:23:39 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8688 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:23:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:23:39 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12426 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:24:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:24:04 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:29:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:29:17 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 Ian Bays changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.bays at ptfs-europe.com --- Comment #36 from Ian Bays --- It seems that the change in the xslt to put span around subfields c and h has removed the space that was generated between the subfields. In koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl there is an: at line 125 in the otherwise clause that spaces out the subfields. The two that were singled out do not have this. Adding them back in within the achieves the normal, desired spacing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:36:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:36:29 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #37 from Katrin Fischer --- Hi Ian, can you please file this as a separate bug report linked to this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:39:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:39:33 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com Status|Signed Off |In Discussion --- Comment #11 from Jonathan Druart --- Marc, The problem is that we have the same issue with IsDebarred. The current code tricks us using not exporting the IsDebarred method: use Koha::Borrower::Debarments qw(); Either we continue to trick: -use C4::Members qw(HasOverdues); +use C4::Members qw(); Or we fix both. But I am pretty sure that introducing another workaround is a good idea. I would like to get Martin and Kyle POV here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:41:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:41:23 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 --- Comment #12 from Jonathan Druart --- (In reply to Jonathan Druart from comment #11) I should read before clicking the submit button... > The current code tricks us using not exporting the IsDebarred method: s/using// > But I am pretty sure that introducing another workaround is a good idea. is *not* a good idea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:46:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:46:32 +0000 Subject: [Koha-bugs] [Bug 13774] Add the unique anchors of news as links in the RSS for news in Opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master, thanks Viktor! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:47:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:47:52 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:48:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:48:24 +0000 Subject: [Koha-bugs] [Bug 15445] DateUtils.t fails on Jenkins due to server sluggishness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- You are removing the usefulness of this test :) This test should not take more than 1s, do you know if it's new? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:50:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:50:46 +0000 Subject: [Koha-bugs] [Bug 15459] New: Allow to select 'Any library' for suggestions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15459 Bug ID: 15459 Summary: Allow to select 'Any library' for suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When AllowPurchaseSuggestionBranchChoice is set to allow, the patron can pick the library the suggestion is for in the OPAC. It would be nice if there was also an option "Any library" if the user doesn't care which library the book is purchased for. Suggestions for any library would be visible to all libraries in the staff interface until the status is switched and a library is set. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:51:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:51:12 +0000 Subject: [Koha-bugs] [Bug 15445] DateUtils.t fails on Jenkins due to server sluggishness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15445 --- Comment #4 from Jonathan Druart --- A workaround would be to get the loadavg of the server at the moment the tests run. If it's > x and the test fails, then skip it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:53:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:53:05 +0000 Subject: [Koha-bugs] [Bug 15443] Re-code RESERVESLIP as HOLD_SLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15443 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:53:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 12:53:51 +0000 Subject: [Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart --- It would make more sense to have a --active[s] instead of --onlyactives, it will allow to add another flag later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:01:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 13:01:04 +0000 Subject: [Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- I don't find where interface is set to "sip" or "commandline". Can we get a test plan please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:29:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 13:29:03 +0000 Subject: [Koha-bugs] [Bug 15445] DateUtils.t fails on Jenkins due to server sluggishness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15445 --- Comment #5 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #3) > You are removing the usefulness of this test :) I don't. When this test is supposed to 'normally' fail it take minutes to calculate duration in the far futur (9999). So, changing the 'normal' duration from 1s to 4s doesn't change the ability of this test to detect the fix introduced by bug 13342 to the way Koha::DateUtils calculate 9999- dates. > This test should not take more than 1s, do you know if it's new? No. It seems to occur randomly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:31:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 13:31:02 +0000 Subject: [Koha-bugs] [Bug 15460] New: Bug 13381 accidentally removed spaces after subfields c and h of 245 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15460 Bug ID: 15460 Summary: Bug 13381 accidentally removed spaces after subfields c and h of 245 Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: ian.bays at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org It seems that the change in the xslt (bug 13381) to put span around subfields c and h has removed the space that was generated between the subfields. In koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl there is an: at line 125 in the otherwise clause that spaces out the subfields. The two that were singled out do not have this. Adding them back in within the achieves the normal, desired spacing. All four xsl files are affected: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:39:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 13:39:29 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart --- It cannot work, C4::Dates has been removed from the codebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:43:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 13:43:27 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart --- CONFLICT (content): Merge conflict in opac/opac-user.pl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:47:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 13:47:29 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #92 from Jonathan Druart --- CONFLICT (content): Merge conflict in Koha/Item.pm CONFLICT (content): Merge conflict in Koha/Borrower.pm CONFLICT (content): Merge conflict in Koha/Biblio.pm Did you make the changes asked in comments 79 and 80? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:07:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:07:45 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45597|0 |1 is obsolete| | Attachment #45598|0 |1 is obsolete| | Attachment #45599|0 |1 is obsolete| | Attachment #45600|0 |1 is obsolete| | Attachment #45601|0 |1 is obsolete| | --- Comment #35 from Alex Arnaud --- Created attachment 46228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46228&action=edit Bug 15206 - Show patron's age under date of birth in memberentry.pl Test plan: Create or edit a patron (members/memberentry.pl), enter a date of birth (for a new patron), patron'a age should be shown under -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:11:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:11:56 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41100|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 46229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46229&action=edit [SIGNED-OFF] Bug 14571: using_https check for ssl connections doesn't work in some situations To test: * turn on Amazon images for result and detail in the OPAC * do a search that will result in an Amazon image being displayed on the result page * inspect the cover image that is returned on the result page, it should be using a https://images-na... Amazon URL. * click through to the detail for that item * inspect the cover image that is returned on the detail page, it should be using a https://images-na... Amazon URL. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:13:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:13:25 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41101|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 46230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46230&action=edit [SIGNED-OFF] Bug 14571: HTTPS Amazon images [follow up] I found a couple more places where we should be using images-na, so I updated them * in the shelf browser * in XISBN related works (honestly not sure how to test this one, but changing from the http:// url won't hurt anything.) To test: * Turn on the shelf browser, and browse for an item that has an amazon image, * inspect it, it should be using https://images-na... url. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:13:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:13:47 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #7 from Owen Leonard --- Created attachment 46231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46231&action=edit [SIGNED-OFF] Bug 14571 - More switching of Amazon image source URL to https modified: modules/opac-opensearch.tt modified: modules/opac-results-grouped.tt modified: modules/opac-shelves.tt modified: modules/opac-showreviews-rss.tt modified: modules/opac-showreviews.tt Basically, just inspect these places and make sure the Amazon images are using https://images-na instead of http://images Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:14:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:14:12 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41102|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:15:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:15:03 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #36 from Alex Arnaud --- The last patch replace all others. It removes showing of age in patron's detail page (duplicate of bug 14763) and it remove the use of perl sub getAge() via ajax call (bad performances). Also it handles better plural forms. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:16:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:16:04 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:16:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:16:21 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Jonathan Druart --- QA comments: 1/ +function isNull(f,noalert) { not used later 2/ The datepicker from/to should be done using the datepickerfrom and datepickerto css class (see acqui/histsearch.tt for an example). 3/ Why do we have to fill a date? 4/ Ergonomic: the date interval is in a table with only 1 column and 1 row, it could be better to move them in the same fieldset as the 2 dropdown lists. 5/ $fullreportname is only used once, not needed. 6/ +my $fromDate = dt_from_string; and later + beginDate => dt_from_string($fromDate), You are passing a DT to dt_from_string, a string is expected. 7/ Remove the unneeded commented lines ("^###") 8/ The csv file should be generated using Text::CSV::Encoded 9/ The column names should be retrieved using C4::Reports::Guided to get the translated values -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:34:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:34:32 +0000 Subject: [Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:36:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:36:04 +0000 Subject: [Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com, | |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:46:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:46:10 +0000 Subject: [Koha-bugs] [Bug 15461] New: Add staff equivalent to OpacLocationBranchToDisplayShelving Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461 Bug ID: 15461 Summary: Add staff equivalent to OpacLocationBranchToDisplayShelving Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be nice if there was an equivalent setting to OpacLocationBranchToDisplayShelving for the staff interface to determine where the location information is shown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:46:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:46:53 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13906 CC| |mtompset at hotmail.com Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:46:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:46:53 +0000 Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15156 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:51:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:51:42 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44642|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 46232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46232&action=edit Bug 15156 - Get all Borrowers with pending/unpaid fines/accountlines A new API call. Useful when doing group operations for Borrowers with fines. Includes some test-coverage for C4::Accountlines since it was missing any. NOTE: Renamed test file to t/db_dependent/Accounts/... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:54:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:54:06 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |BLOCKED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:56:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:56:30 +0000 Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #22 from M. Tompsett --- *ping* Is this moving forward? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:56:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:56:34 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com, | |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:58:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 14:58:16 +0000 Subject: [Koha-bugs] [Bug 15086] Creators layout and template sql has warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 16:04:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 15:04:33 +0000 Subject: [Koha-bugs] [Bug 15383] Opac: Authority details: Fix translation issues with tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15383 --- Comment #9 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 16:04:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 15:04:51 +0000 Subject: [Koha-bugs] [Bug 14397] Typo 'foriegn' in table comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14397 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 16:05:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 15:05:09 +0000 Subject: [Koha-bugs] [Bug 14034] User logged out on refresh after Shibboleth authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 16:05:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 15:05:39 +0000 Subject: [Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170 --- Comment #16 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 16:05:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 15:05:54 +0000 Subject: [Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 --- Comment #18 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 16:08:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 15:08:48 +0000 Subject: [Koha-bugs] [Bug 15086] Creators layout and template sql has warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44180|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 46233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46233&action=edit Bug 15086: Creators layout and template sql has warnings When doing a hacked install off the master branch: use ... {koha database name} truncate creator_layouts; truncate creator_templates; truncate printers_profiles; source installer/data/mysql/... {name of a sample_labels type file} Warnings are generated, which may not be visible in the UI. Most of the warnings were triggered by: -/*!40000 ALTER TABLE `creator_layouts` DISABLE KEYS */; -/*!40000 ALTER TABLE `creator_layouts` ENABLE KEYS */; http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_er_illegal_ha In the Russian, the layout_name was truncated, because the layout_name was only 20. An atomic update sql and kohastructure.sql update were provided to widen it to 25. http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_warn_data_truncated Also fr-FR, ru-RU, and uk-UA were slightly different in structure, so the structure was made the same as the other files. See comment #1 for the test plan. NOTE: pl-PL is likely very out of date, but is not affected in this regard. it-IT was updated in Bug 15178 which added a line feed causing conflict. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 16:11:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 15:11:03 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #30 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 16:16:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 15:16:03 +0000 Subject: [Koha-bugs] [Bug 15086] Creators layout and template sql has warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 16:32:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 15:32:56 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 16:34:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 15:34:47 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 16:50:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 15:50:58 +0000 Subject: [Koha-bugs] [Bug 15344] GetMemberDetails called unecessary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 --- Comment #18 from Kyle M Hall --- (In reply to Fr?d?ric Demians from comment #17) > Marc and Johnatan, thanks. I confirm 3rd patch is required. I've pushed it > directly to 3.20.x branch. It still has to be pushed to master/stable. Third patch has been pushed to master! Thanks for the followup Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 18:06:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 17:06:36 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 --- Comment #13 from Marc V?ron --- Sorry, I have no other ideas. Maybe someone else finds a solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 18:24:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 17:24:20 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45918|0 |1 is obsolete| | --- Comment #13 from Marc V?ron --- Created attachment 46234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46234&action=edit Bug 15374 - Translatability: Fix issues on OPAC summary page Fix several issues on opac-user.tt with sentences splitted by tags, leading to odd translations. Additionally, fix a broken link that should point to opac-account.pl To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions (Amended to add price formatting in fines tab label) Can see the warning message now :) signing off Signed-off-by: Aleisha (Amended to make patches apply, see comment #12) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 18:36:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 17:36:19 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 19:13:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 18:13:33 +0000 Subject: [Koha-bugs] [Bug 15462] New: Unable to renew books via circ/renew.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Bug ID: 15462 Summary: Unable to renew books via circ/renew.pl Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: chad at pennmanor.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Renewing books from circ/renew.pl produces an internal server error with the following entry in the logs: ("Can't locate object method \"single\" via package \"5\" (perhaps "...) called at /var/koha/circ/renew.pl line 57 mveron confirmed this impacts the master branch as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 19:24:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 18:24:45 +0000 Subject: [Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 chad at pennmanor.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chad at pennmanor.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 20:42:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 19:42:57 +0000 Subject: [Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 20:46:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 19:46:04 +0000 Subject: [Koha-bugs] [Bug 14790] Link to OPAC view from within subscriptions, search and item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14790 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Assignee|jweaver at bywatersolutions.co |kyle at bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 21:04:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 20:04:39 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #22 from Francois Charbonnier --- We won't (In reply to Jonathan Druart from comment #21) > (In reply to Maxime Beaulieu from comment #20) > > Indeed, the "guarantor" option could be added to the syspref. > > If you agree to add this feature to bug 12802, we can close this one and/or > > mark it as duplicate. > > As you can see on bug 12802, I am not in charge of this bug anymore. > And I would be very surprised that it will be included. Then, we will stay focus on this patch. :) I change the status to "signed off" since it was by Nick Clemens (see http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532#c15) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 22:51:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 21:51:05 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 22:51:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 21:51:08 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46074|0 |1 is obsolete| | --- Comment #11 from Jesse Weaver --- Created attachment 46235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46235&action=edit Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing Test plan: 1) Make sure there is at least one field in PatronSelfRegistrationBorrowerUnwantedField. 2) Apply patch, and update database. 3) Check to make sure that the new system preference PatronSelfModificationBorrowerUnwantedField has the same value as PatronSelfRegistrationBorrowerUnwantedField. 4) Verify that the same fields are hidden for self-registering a new borrower and edting a new one (both on the OPAC). 5) Change PatronSelfModificationBorrowerUnwantedField, and verify that the two preferences correctly apply to editing vs. creating. Signed-off-by: Michael Sauers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 22:51:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 21:51:14 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46075|0 |1 is obsolete| | --- Comment #12 from Jesse Weaver --- Created attachment 46236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46236&action=edit Bug 14658 - (QA followup) make it easier to grep for these syspref names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 22:53:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 21:53:02 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46235|0 |1 is obsolete| | --- Comment #13 from Jesse Weaver --- Created attachment 46237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46237&action=edit Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing Test plan: 1) Make sure there is at least one field in PatronSelfRegistrationBorrowerUnwantedField. 2) Apply patch, and update database. 3) Check to make sure that the new system preference PatronSelfModificationBorrowerUnwantedField has the same value as PatronSelfRegistrationBorrowerUnwantedField. 4) Verify that the same fields are hidden for self-registering a new borrower and edting a new one (both on the OPAC). 5) Change PatronSelfModificationBorrowerUnwantedField, and verify that the two preferences correctly apply to editing vs. creating. Signed-off-by: Michael Sauers Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 22:53:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 21:53:07 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46236|0 |1 is obsolete| | --- Comment #14 from Jesse Weaver --- Created attachment 46238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46238&action=edit Bug 14658 - (QA followup) make it easier to grep for these syspref names Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 22:54:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 21:54:03 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #15 from Jesse Weaver --- Sorry for spam, accidentally obliterated Joubu's signoffs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 23:14:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 22:14:36 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 23:14:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 22:14:39 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41363|0 |1 is obsolete| | Attachment #41364|0 |1 is obsolete| | Attachment #41365|0 |1 is obsolete| | --- Comment #46 from Nick Clemens --- Created attachment 46239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46239&action=edit Bug 10612 - Add ability to delete patrons with batch patron deletion tool This patch adds the ability to select a patron list for deletetion when using the Batch patron deletion/anonymization tool. It also adds buttons to the the patron lists table to access both the batch deletion and batch modification directly from the lists view. This is a squash of previous patches with a check added for issues before deleting borrowers. Test Plan: 1) Apply this patch 2) Create a list of patrons with the new Patron Lists feature 3) Try using the batch edit link form the lists table 4) Try using the batch delete link from the lists table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 23:17:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 22:17:04 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #47 from Nick Clemens --- I squashed patches, rebased, and added a check for issues to the subroutine: _skip_borrowers_with_nonzero_balance making it: _skip_borrowers_with_nonzero_balance_or_issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 23:19:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 22:19:54 +0000 Subject: [Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 23:26:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 22:26:13 +0000 Subject: [Koha-bugs] [Bug 15463] New: view_holdsqueue.tt uses a search for cardnumber instead of borrowernumber direct link Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15463 Bug ID: 15463 Summary: view_holdsqueue.tt uses a search for cardnumber instead of borrowernumber direct link Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com This line:

Should be:

or something similar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 23:46:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 22:46:33 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 23:46:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 22:46:37 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46178|0 |1 is obsolete| | --- Comment #287 from Bernardo Gonzalez Kriegel --- Created attachment 46240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46240&action=edit [SIGNED-OFF] Bug 7143 : Adding releases and fixing some missing tabs Signed-off-by: Bernardo Gonzalez Kriegel No errors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 00:29:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 23:29:30 +0000 Subject: [Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 00:29:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 23:29:34 +0000 Subject: [Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46161|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 46241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46241&action=edit [SIGNED-OFF] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. Signed-off-by: Bernardo Gonzalez Kriegel Looks like refactoring :) No regressions, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 00:50:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 23:50:26 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- Hi Jonathan and Happy new year :) With all patches applied Tools > CSVprofiles fails with Software error: DBIx::Class::Schema::resultset(): resultset() expects a source name at /home/bgkriegel/kohaclone/Koha/Objects.pm line 237 Test fails with similar error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 00:50:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 23:50:57 +0000 Subject: [Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #1 from Katrin Fischer --- Hi Winona - should there be a patch attached? I am resetting the status to NEW until there is a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 00:51:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2016 23:51:04 +0000 Subject: [Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 01:12:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 00:12:41 +0000 Subject: [Koha-bugs] [Bug 15464] New: Fast Cataloguing gateway timeout Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 Bug ID: 15464 Summary: Fast Cataloguing gateway timeout Change sponsored?: --- Product: Koha Version: 3.22 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: patrick.fratczak at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hello. And happy new year ! I am using Koha from debian packages v3.22.01 and i cannot add from fast cataloguing since the last update to this version. It results in a gateway timeout. AH01220: Timeout waiting for output from CGI script /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl, referer: http://.../cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=FA It's running on Ubuntu 14.04 apache2 2.4.7-1ubuntu4. i386 mysql-server 5.5.46-0ubuntu0 all I don't know what's wrong since the last update. Could you help me please ? Thanks in advance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 01:18:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 00:18:48 +0000 Subject: [Koha-bugs] [Bug 14748] REST API Testing framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14748 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel --- Hi, trying to test. 1) Need to install YAML::XS 2) Can't find Koha/ApiKeys.pm. Are there other dependencies for this bug? Listed one (Bug 13799) is already in master. Can't locate Koha/ApiKeys.pm in @INC (you may need to install the Koha::ApiKeys module) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 01:33:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 00:33:07 +0000 Subject: [Koha-bugs] [Bug 14749] Add API route to get top issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel --- Please, can you provide a test plan? Don't know what to do with this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 05:34:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 04:34:50 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #24 from David Cook --- I'm thinking about using AnyEvent::HTTP for bug 10662, and I see that libanyevent-http-perl is now a part of Debian Stable (Jessie) and Debian Old Stable (Wheezy). https://packages.debian.org/wheezy/libanyevent-http-perl I wonder if we should now include it as a required rather than optional dependency? For my purposes, I could probably just display a message telling users that they need to install the library before they can use the feature, but it'd probably be nice to have it already available. That said, I haven't decided whether or not to use AnyEvent::HTTP quite yet. Just one of a few options I'm pondering... but thought I'd mention how it's now in Debian. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 06:08:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 05:08:25 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 --- Comment #25 from David Cook --- In hindsight, it looks like libanyevent-perl was available in Squeeze, so they were halfway there already. https://packages.debian.org/squeeze/libanyevent-perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 07:44:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 06:44:15 +0000 Subject: [Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 08:12:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 07:12:44 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #9 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #8) > Hi Jonathan and Happy new year :) > > With all patches applied Tools > CSVprofiles fails with > > Software error: > DBIx::Class::Schema::resultset(): resultset() expects a source name at > /home/bgkriegel/kohaclone/Koha/Objects.pm line 237 > > Test fails with similar error. Thanks for testing Bernardo, happy new year too ;) You should apply bug 15446 before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 08:31:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 07:31:28 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #23 from Jonathan Druart --- (In reply to Francois Charbonnier from comment #22) > > As you can see on bug 12802, I am not in charge of this bug anymore. > > And I would be very surprised that it will be included. I have absolutely no idea why I have written this last sentence. I was not wanted to tell that the patches on bug 12802 won't be included/pushed into master. But certainly more that the new author/maintainer of bug 12802 won't write the changes I have proposed on comment 19. Sorry for the misunderstanding and please provide an answer. If the solution seems better to you, please provide a followup on top of bug 12802. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 09:02:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 08:02:22 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15462 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 [Bug 15462] Unable to renew books via circ/renew.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 09:02:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 08:02:22 +0000 Subject: [Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical Version|3.22 |master Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Depends on| |13790 Status|NEW |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- This is critical. It looks like a bad side effect of bug 13790. Still investigating... Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 [Bug 13790] Add unique id issue_id to issues and old_issues tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 09:14:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 08:14:09 +0000 Subject: [Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 --- Comment #2 from Marc V?ron --- Found soultion, patch follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 09:15:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 08:15:09 +0000 Subject: [Koha-bugs] [Bug 15344] GetMemberDetails called unecessary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 --- Comment #19 from Julian Maurice --- (In reply to Kyle M Hall from comment #18) > Third patch has been pushed to master! Pushed to 3.22.x as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 09:19:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 08:19:23 +0000 Subject: [Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 --- Comment #3 from Marc V?ron --- Created attachment 46242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46242&action=edit Bug 15462 - Unable to renew books via circ/renew.pl To verify: Got to circ/circulation.pl and try to renew an item. Result: Can't call method "single" without a package or object reference at /usr/share/kohaclone/circ/renew.pl line 57 To test: - Apply patch - Try to renow items that are or are not checked out. Error no longer occurs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 09:19:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 08:19:47 +0000 Subject: [Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 09:40:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 08:40:23 +0000 Subject: [Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 --- Comment #4 from Jonathan Druart --- For the record, it has been introduced by commit 3cab4d1efd25268441c88ce74d5a4b568773c8aa Bug 14978: (RM followup) DBIx update Bug 14978 introduced a unique on items.itemnumber to get the constraint we had before bug 13790. With adding this constraint, DBIx::Class::Schema::Loader renamed the has_many issues RS with a might_have issue. +__PACKAGE__->might_have( + "issue", -__PACKAGE__->has_many( - "issues", -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 09:40:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 08:40:44 +0000 Subject: [Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14978 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 [Bug 14978] issues.itemnumber should be a unique key -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 09:40:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 08:40:44 +0000 Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15462 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 [Bug 15462] Unable to renew books via circ/renew.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 09:43:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 08:43:10 +0000 Subject: [Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 09:43:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 08:43:13 +0000 Subject: [Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46242|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 46243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46243&action=edit Bug 15462 - Unable to renew books via circ/renew.pl To verify: Got to circ/circulation.pl and try to renew an item. Result: Can't call method "single" without a package or object reference at /usr/share/kohaclone/circ/renew.pl line 57 To test: - Apply patch - Try to renow items that are or are not checked out. Error no longer occurs. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 10:19:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 09:19:06 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 --- Comment #14 from Martin Renvoize --- I agree adding another workaround is bad, doing it 'properly' is better. So, am I reading it right that basically we also need IsDebarred also renaming and then this patch could stand.. or have I misunderstood something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 10:28:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 09:28:14 +0000 Subject: [Koha-bugs] [Bug 15465] New: README for github Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 Bug ID: 15465 Summary: README for github Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org This doesn't really fit in here, but I couldn't see a better category for it. We have a github presence in the form of a git mirror, and that presence is getting the odd pull request through. We aught to have a README.md for github display to direct developer who find Koha via github to the main resources and explicitly state that pull requests are not accepted via github. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 10:32:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 09:32:03 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #41 from Jonathan Druart --- (In reply to Kyle M Hall from comment #40) > Pushed to master, thanks Philippe! Please regenerate the Schema files, some tests are failing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 10:39:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 09:39:29 +0000 Subject: [Koha-bugs] [Bug 15466] New: Suggestions.t is failing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15466 Bug ID: 15466 Summary: Suggestions.t is failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 15429 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429 [Bug 15429] sub _parseletter should not change referenced values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 10:39:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 09:39:29 +0000 Subject: [Koha-bugs] [Bug 15429] sub _parseletter should not change referenced values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15466 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15466 [Bug 15466] Suggestions.t is failing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 10:40:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 09:40:39 +0000 Subject: [Koha-bugs] [Bug 15466] Suggestions.t is failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15466 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 10:40:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 09:40:42 +0000 Subject: [Koha-bugs] [Bug 15466] Suggestions.t is failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15466 --- Comment #1 from Jonathan Druart --- Created attachment 46244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46244&action=edit Bug 15466: Do not assume $values_in is a hashref It could be undefined. Test plan: prove t/db_dependent/Suggestions.t should return green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 10:45:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 09:45:19 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46228|0 |1 is obsolete| | --- Comment #37 from Marc V?ron --- Created attachment 46245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46245&action=edit Bug 15206 - Show patron's age under date of birth in memberentry.pl Test plan: Create or edit a patron (members/memberentry.pl), enter a date of birth (for a new patron), patron'a age should be shown under Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 10:45:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 09:45:48 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 10:50:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 09:50:01 +0000 Subject: [Koha-bugs] [Bug 15466] Suggestions.t is failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15466 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46244|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 46246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46246&action=edit Bug 15466: Do not assume $values_in is a hashref It could be undefined. Test plan: prove t/db_dependent/Suggestions.t should return green. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 10:50:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 09:50:28 +0000 Subject: [Koha-bugs] [Bug 15466] Suggestions.t is failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15466 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 10:59:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 09:59:16 +0000 Subject: [Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015 --- Comment #21 from Marc V?ron --- I can still reprduce the error on current master. Patch still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 11:17:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 10:17:13 +0000 Subject: [Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15467 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15467 [Bug 15467] AuthoritiesMarc.t is failing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 11:17:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 10:17:13 +0000 Subject: [Koha-bugs] [Bug 15467] New: AuthoritiesMarc.t is failing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15467 Bug ID: 15467 Summary: AuthoritiesMarc.t is failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 15381 Since bug 15381. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 11:25:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 10:25:59 +0000 Subject: [Koha-bugs] [Bug 15467] AuthoritiesMarc.t is failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15467 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 11:26:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 10:26:02 +0000 Subject: [Koha-bugs] [Bug 15467] AuthoritiesMarc.t is failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15467 --- Comment #1 from Jonathan Druart --- Created attachment 46247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46247&action=edit Bug 15467: If authtypecode is not defined, do not explode The test t/db_dependent/AuthoritiesMarc.t fails because one test expect the BuildSummary subroutine to not crash if the authtypecode passed in parameter does not exist in the DB. Test plan: prove t/db_dependent/AuthoritiesMarc.t should return green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 11:36:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 10:36:39 +0000 Subject: [Koha-bugs] [Bug 15468] New: Search links on callnumber fails on opac results page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468 Bug ID: 15468 Summary: Search links on callnumber fails on opac results page Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: jefkoha at dias.ie QA Contact: testopia at bugs.koha-community.org Similar to Bug 12405, but for the OPAC. Freshly migrated from Heritage to Koha: https://library.celt.dias.ie If a call number contains "(" or ")", the "q=callnum" query doesn't work in the Debian packaged version 3.22 Example: https://library.celt.dias.ie/cgi-bin/koha/opac-search.pl?q=callnum:891.6205%20ITS%20(43iii) Solution is similar to Bug 12405, is to introduce %22 into the search query https://library.celt.dias.ie/cgi-bin/koha/opac-search.pl?q=callnum:%22891.6205%20ITS%20(43iii)%22 This can be done by changing: /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/modules/opac-results.tt on line 405: [% IF ( available_items_loo.itemcallnumber ) %][[% available_items_loo.itemcallnumber %]][% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 11:44:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 10:44:01 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds system preferences to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 11:44:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 10:44:02 +0000 Subject: [Koha-bugs] [Bug 5609] Holds Rewrite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5609 Bug 5609 depends on bug 5786, which changed state. Bug 5786 Summary: Move AllowOnShelfHolds and OpacItemHolds system preferences to the Circulation Matrix http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 11:44:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 10:44:03 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Bug 8362 depends on bug 5786, which changed state. Bug 5786 Summary: Move AllowOnShelfHolds and OpacItemHolds system preferences to the Circulation Matrix http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 11:44:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 10:44:03 +0000 Subject: [Koha-bugs] [Bug 14792] Fix visibility check for 'place holds' link in OPAC result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14792 Bug 14792 depends on bug 5786, which changed state. Bug 5786 Summary: Move AllowOnShelfHolds and OpacItemHolds system preferences to the Circulation Matrix http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 11:44:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 10:44:03 +0000 Subject: [Koha-bugs] [Bug 5787] Move OPACItemHolds system preference to the Circulation Matrix. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5787 Bug 5787 depends on bug 5786, which changed state. Bug 5786 Summary: Move AllowOnShelfHolds and OpacItemHolds system preferences to the Circulation Matrix http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 11:44:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 10:44:04 +0000 Subject: [Koha-bugs] [Bug 5788] Move ReservesMaxPickupDelay system preference to the Circulation Matrix. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Bug 5788 depends on bug 5786, which changed state. Bug 5786 Summary: Move AllowOnShelfHolds and OpacItemHolds system preferences to the Circulation Matrix http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 11:49:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 10:49:54 +0000 Subject: [Koha-bugs] [Bug 15469] New: The authority header search is broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Bug ID: 15469 Summary: The authority header search is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 15381 Introduced by bug 15381. The logs contain plenty of "detail.pl: No method value!" and the dropwdown list is not correctly populated (no value for options). Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 11:49:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 10:49:54 +0000 Subject: [Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15469 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 [Bug 15469] The authority header search is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 11:51:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 10:51:36 +0000 Subject: [Koha-bugs] [Bug 15469] The authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 11:51:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 10:51:38 +0000 Subject: [Koha-bugs] [Bug 15469] The authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 --- Comment #1 from Jonathan Druart --- Created attachment 46248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46248&action=edit Bug 15469: Fix authority header search Introduced by bug 15381. The logs contain plenty of "detail.pl: No method value!" and the dropwdown list is not correctly populated (no value for options) Test plan: Go to the authority module and have a look at the auth type codes dropdown list. Without this patch, the values of the options are empty. With this patch, the values are correctly filled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 12:29:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 11:29:21 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #89 from Mirko Tietgen --- Now that this is in 3.22, I wonder how the nonpublic file upload is supposed to work? There is no direct link to tools/upload.pl AFAICT and with the cataloguing plugin, there is no option to choose public/nonpublic. Am I missing something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 12:32:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 11:32:02 +0000 Subject: [Koha-bugs] [Bug 15469] The authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 12:32:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 11:32:05 +0000 Subject: [Koha-bugs] [Bug 15469] The authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46248|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 46249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46249&action=edit Bug 15469: Fix authority header search Introduced by bug 15381. The logs contain plenty of "detail.pl: No method value!" and the dropwdown list is not correctly populated (no value for options) Test plan: Go to the authority module and have a look at the auth type codes dropdown list. Without this patch, the values of the options are empty. With this patch, the values are correctly filled. Signed-off-by: Fr?d?ric Demians I confirm this patch silence noise in log file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 12:45:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 11:45:06 +0000 Subject: [Koha-bugs] [Bug 15470] New: Error when adding new authority with Default framework Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470 Bug ID: 15470 Summary: Error when adding new authority with Default framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org To produce this bug: Authorities > New authority > Default Result: Can't call method "authtypetext" on an undefined value at /home/tamil/client/devel/kohaclone/authorities/authorities.pl line 665. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 12:45:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 11:45:33 +0000 Subject: [Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15470 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470 [Bug 15470] Error when adding new authority with Default framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 12:45:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 11:45:33 +0000 Subject: [Koha-bugs] [Bug 15470] Error when adding new authority with Default framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |frederic at tamil.fr Depends on| |15381 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 12:48:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 11:48:18 +0000 Subject: [Koha-bugs] [Bug 15470] Error when adding new authority with Default framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 12:48:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 11:48:20 +0000 Subject: [Koha-bugs] [Bug 15470] Error when adding new authority with Default framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470 --- Comment #1 from Fr?d?ric Demians --- Created attachment 46250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46250&action=edit Bug 15470: Error when adding new authority with Default framework TO TEST: 1. Authorities > New authority > Default 2. You get: Can't call method "authtypetext" on an undefined value at 3. Apply the patch and repeat 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 12:51:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 11:51:31 +0000 Subject: [Koha-bugs] [Bug 5590] error message on holds not consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5590 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Is this bug still valid? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 12:53:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 11:53:15 +0000 Subject: [Koha-bugs] [Bug 15463] view_holdsqueue.tt uses a search for cardnumber instead of borrowernumber direct link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15463 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 12:53:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 11:53:49 +0000 Subject: [Koha-bugs] [Bug 15391] Some tests in HoldsQueue.t should not pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 13:03:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 12:03:02 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #21 from Marcel de Rooy --- (In reply to Marc V?ron from comment #20) > Hi Marcel, a question about the test plan: > Do you expect the values (500$a, 555$a and a URL in 555$u) to be inserted > into the mails? Or should we test only that the mails still work? Hi Marc, You may check the mails for unexpected side-effects or so. The main changes in this patch are template changes. Please check the tabs mentioned. The 555 field is not passed in the mail IIRC (the code there did not use GetMarcNotes at all). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 13:06:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 12:06:58 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #90 from Marcel de Rooy --- (In reply to Mirko Tietgen from comment #89) > Now that this is in 3.22, I wonder how the nonpublic file upload is supposed > to work? There is no direct link to tools/upload.pl AFAICT and with the > cataloguing plugin, there is no option to choose public/nonpublic. Am I > missing something? Yes, you miss bug 14686. Still in the pipeline :) Note that I am still waiting too for any progress on bug 14893. At the time I hoped to still get that into 3.22, but unfortunately.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 13:14:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 12:14:05 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #91 from Mirko Tietgen --- Ah, thanks! I checked the blocks/depends on bugs, but managed to overlook the see also ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 13:14:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 12:14:20 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 13:15:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 12:15:53 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 13:20:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 12:20:14 +0000 Subject: [Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015 --- Comment #22 from Marcel de Rooy --- (In reply to Marc V?ron from comment #21) > I can still reprduce the error on current master. > Patch still applies. It seems that Kyle missed the purpose of this report if I read comment19. If you reset the status, it will receive attention again from the RM. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 13:34:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 12:34:11 +0000 Subject: [Koha-bugs] [Bug 15470] Error when adding new authority with Default framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 14:00:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 13:00:34 +0000 Subject: [Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #23 from Marc V?ron --- Reset status as of comment #22 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 14:04:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 13:04:03 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42010|0 |1 is obsolete| | --- Comment #22 from Marc V?ron --- Created attachment 46251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46251&action=edit Bug 14306: Show URL from MARC21 field 555$u under Title Notes/Descriptions This patch includes: [1] Add some logic to GetMarcNotes to embed the contents of MARC21 field 555$u in a html anchor tag. [2] Add a unit test for GetMarcNotes in Biblio.t [3] Remove calls to GetMarcNotes from sendbasket.pl (opac and staff). A closer look revealed that the data was not used; the notes in the mail of sendbasket are taken from GetBiblioData. Test plan: [1] Edit a record. Add one or two URLS in 555$u. Add something in 500$a too. [2] Check if you can click the URLs in opac and staff detail tab Notes or Descriptions. [3] Run the unit test t/db../Biblio.t [4] Add something in the cart. Click More Details and send the cart. Verify that you have something in Notes (from 500$a). Signed-off-by: Marc Veron Followed test plan. Works as expected. QA tools OK. Tested with all patches together, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 14:04:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 13:04:03 +0000 Subject: [Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 --- Comment #6 from chad at pennmanor.net --- This patch fixed it. Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 14:04:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 13:04:55 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42011|0 |1 is obsolete| | --- Comment #23 from Marc V?ron --- Created attachment 46252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46252&action=edit Bug 14306: Follow-up for URLs in 555$u This patch removes the code for inserting the anchor tags around URLs in GetMarcNotes (as added originally). The URLs are placed in separate array elements; the template should take care of further handling. The unit test has been adjusted accordingly. Test plan: Run the unit test. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 14:07:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 13:07:15 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42012|0 |1 is obsolete| | --- Comment #24 from Marc V?ron --- Created attachment 46253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46253&action=edit Bug 14306: Changes for basket and detail templates A simple regex is added to the basket and detail templates to select the URLs passed separately from MARC21 555$u by GetMarcNotes. Note that the regex tests if a note starts with http:// or https:// and does not contain any whitespace in order to be considered as a url. These URLs are put in an anchor tag. This touches four places: [1] opac detail, tab title notes [2] catalogue detail, tab Descriptions [3] opac basket, more details, notes [4] staff basket, more details, notes Test plan: [1] Edit a record. Add a 500$a, 555$a and a URL in 555$u. Put "http://this is not a url" in the 500$a (whitespace!). [2] Check opac-detail, tab Title Notes. Check the URL. [3] Do the same for catalogue/detail. [4] Add record to cart in OPAC. Open basket. Check More details. [5] Repeat previous step in staff. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 14:08:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 13:08:47 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46221|0 |1 is obsolete| | --- Comment #25 from Marc V?ron --- Created attachment 46254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46254&action=edit Bug 14306: Remove call to GetMarcNotes from sendshelf Just as mentioned in the first patch for sendbasket, I discovered that the call of GetMarcNotes is not really used in sendshelf. The array is passed to the template, but the template does not use it. (It uses the information from GetBiblioData.) Test plan: [1] Send a list that includes a record with some notes (opac and staff). Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 14:09:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 13:09:19 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 14:17:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 13:17:00 +0000 Subject: [Koha-bugs] [Bug 14459] Marking parts of text bold is bad for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6988 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 14:17:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 13:17:00 +0000 Subject: [Koha-bugs] [Bug 6988] formatted strings get split in substrings for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 14:44:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 13:44:58 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 --- Comment #15 from Jonathan Druart --- (In reply to Martin Renvoize from comment #14) > I agree adding another workaround is bad, doing it 'properly' is better. > > So, am I reading it right that basically we also need IsDebarred also > renaming and then this patch could stand.. or have I misunderstood something? No, you got it. Renaming them could work, but otoh it would make sense to keep the same name: the subroutines only call the corresponding subroutine/method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 14:49:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 13:49:46 +0000 Subject: [Koha-bugs] [Bug 15463] view_holdsqueue.tt uses a search for cardnumber instead of borrowernumber direct link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15463 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- I don't understand what is the problem here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 14:51:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 13:51:19 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- >From which version did you update? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 14:53:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 13:53:33 +0000 Subject: [Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 14:59:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 13:59:09 +0000 Subject: [Koha-bugs] [Bug 15323] ./t/Prices.t fails without a valid database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WORKSFORME CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- t/Prices.t is not data-related: % sudo service mysql stop [ ok ] Stopping MariaDB database server: mysqld. % prove t/Prices.t t/Prices.t .. ok All tests successful. Files=1, Tests=16, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.40 cusr 0.04 csys = 1.46 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 14:59:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 13:59:50 +0000 Subject: [Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:02:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:02:47 +0000 Subject: [Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wsalesky at gmail.com --- Comment #2 from Winona Salesky --- Sorry, Using git bz, and something is going wrong. Troubleshooting. Will have something up by the end of the day. -Winona -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:06:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:06:13 +0000 Subject: [Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444 --- Comment #3 from Katrin Fischer --- Thx! If it won't work at all: 'git format-patch' will create a file you can attach. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:12:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:12:10 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #10 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #9) > You should apply bug 15446 before. Done, now works more. I'm testing in order, all patches applied. First 3 Ok. When testing 4th, /cgi-bin/koha/tools/export.pl gives the same/similar error of comment #8, Software error: DBIx::Class::Schema::resultset(): resultset() expects a source name at /home/bgkriegel/kohaclone/Koha/Objects.pm line 235 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:12:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:12:27 +0000 Subject: [Koha-bugs] [Bug 15467] AuthoritiesMarc.t is failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15467 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46247|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 46255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46255&action=edit Bug 15467: If authtypecode is not defined, do not explode The test t/db_dependent/AuthoritiesMarc.t fails because one test expect the BuildSummary subroutine to not crash if the authtypecode passed in parameter does not exist in the DB. Test plan: prove t/db_dependent/AuthoritiesMarc.t should return green. Signed-off-by: Fr?d?ric Demians Test fails before patch, and doesn't anymore after. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:12:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:12:25 +0000 Subject: [Koha-bugs] [Bug 15467] AuthoritiesMarc.t is failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15467 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:18:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:18:42 +0000 Subject: [Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444 --- Comment #4 from Winona Salesky --- Created attachment 46256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46256&action=edit Corrects repeated 508 formatting This patch adds a separator for multiple 508 fields to the XSLT display in the staff and OPAC detail view. Separator is wrapped in span with class=?separator? for easy manipulation via css. To test: * Search the OPAC * Click the title with multiple 508 fields * Make sure the fields display properly * Repeat for a few more titles * Repeat in the Staff Client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:20:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:20:30 +0000 Subject: [Koha-bugs] [Bug 7017] override_renewals permission confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7017 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- As far as I understand it, overdues_report, force_checkout, manage_restrictions work only if circulate_remaining_permissions is set. (Hmm, what about self_checkout?) Maybe we could re-word the descriptions to make it clear? Something like: [] circulate_remaining_permissions Basic circulation permissions [] overdues_report Execute overdue items report (needs basic permissions) [] force_checkout Force checkout if a limitation exists (needs basic permissions) [] manage_restrictions Manage restrictions for accounts (needs basic permissions) [] override_renewals Override blocked renewals (needs basic permissions) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:24:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:24:10 +0000 Subject: [Koha-bugs] [Bug 7017] override_renewals permission confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7017 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14713 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:24:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:24:10 +0000 Subject: [Koha-bugs] [Bug 14713] remaining_permissions permission under the "updatecharges" permission not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14713 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7017 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:29:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:29:16 +0000 Subject: [Koha-bugs] [Bug 15471] New: Add column settings and filters to Holds queue table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Bug ID: 15471 Summary: Add column settings and filters to Holds queue table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 15285 Add column visibility menu and a text filter on top of each column for the holds queue table Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 [Bug 15285] Upgrade DataTables to 1.10.10 or later -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:29:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:29:16 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15471 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 [Bug 15471] Add column settings and filters to Holds queue table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:29:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:29:24 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:29:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:29:27 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #1 from Jonathan Druart --- Created attachment 46257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46257&action=edit Bug 15337: Add tests to ensure that GetItemTypes will return element ordered by desc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:29:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:29:30 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #2 from Jonathan Druart --- Created attachment 46258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46258&action=edit Bug 15337: Make itemtypes retrieved with GetItemTypes ordered by descriptions Prior to this patch, the itemtypes were displayed ordered by the code (itemtypes.itemtype DB column). This patch will make them displayed by the description displayed (the translated description). Test plan: 0/ Do not apply this patch set 1/ Confirm that the itemtypes are displayed ordered by code (when adding an item, cataloguing/additem.pl) 2/ Confirm that t/db_dependent/Koha.t does not pass 3/ Apply the test patch 4/ Confirm that t/db_dependent/Koha.t pass 5/ Confirm that the itemtypes are not displayed by description (on additem.pl) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:29:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:29:47 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 --- Comment #1 from Julian Maurice --- Created attachment 46259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46259&action=edit Bug 15471: Add column settings and filters to Holds queue table Add column visibility menu using DataTables Buttons Add a text filter on top of each column Also extend page width so that the large table is better centered Depends on bug 15285 Test plan 1. Go to Holds queue page (circ/view_holdsqueue.pl) 2. Check that table sorting and filtering work well and that you can hide each column 3. Go to Admin > Configure columns and change the settings for this table (Circulation > view_holdsqueue > holds-table). Verify that the settings work by going again to the Holds queue page 4. Check that filters continue to work after hiding some columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:29:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:29:55 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:30:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:30:01 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15354 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:30:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:30:01 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15337 --- Comment #7 from Jonathan Druart --- (In reply to Jonathan Druart from comment #6) > Not that C4::Koha::GetItemTypes should be fixed for a global fix. > It will be easy to do on top of bug 14828. Finally done on bug 15337 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:38:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:38:39 +0000 Subject: [Koha-bugs] [Bug 15472] New: Do not display links to circulation.pl if remaining_permissions is not set Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Bug ID: 15472 Summary: Do not display links to circulation.pl if remaining_permissions is not set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If permisison 'remaining_permissions' is not set, links to 'Circulation' (/circ/circulation-home.pl) lead to an error message (Error: You do not have permission to access this page). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:39:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:39:01 +0000 Subject: [Koha-bugs] [Bug 15353] patron image disappears when on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:39:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:39:04 +0000 Subject: [Koha-bugs] [Bug 15353] patron image disappears when on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 --- Comment #1 from Jonathan Druart --- Created attachment 46260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46260&action=edit Bug 15353: Display the patron image where needed On the 3 following pages, the patron image was not displayed: members/discharge.pl members/pay.pl members/paycollect.pl Test plan: Apply this patch and confirm the image is now displayed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:41:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:41:11 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #11 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #10) > I'm testing in order, all patches applied. First 3 Ok. I add a test plan on each patch to explain what I do, but to test them, you have to apply the entire patch set (well, in a dream world you should not, but I am not perfect :p). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:41:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:41:21 +0000 Subject: [Koha-bugs] [Bug 15353] patron image disappears when on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:41:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:41:39 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:48:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:48:18 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:48:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:48:21 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 --- Comment #1 from Jonathan Druart --- Created attachment 46261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46261&action=edit Bug 15360: Rename "New from Z39.50" with "Replace with Z39.50" If the record exist, the button text should not be "New from", but "Replace". Test plan: Go on the authority home page (authorities/authorities-home.pl) You should see a "New from Z39.50" button. Edit an authority You should now see "Replace with Z39.50" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:48:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:48:27 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 15:59:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 14:59:57 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #12 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #11) > (In reply to Bernardo Gonzalez Kriegel from comment #10) > > I'm testing in order, all patches applied. First 3 Ok. > > I add a test plan on each patch to explain what I do, but to test them, you > have to apply the entire patch set (well, in a dream world you should not, > but I am not perfect :p). Hehe :) I applied all patches, and follow each test plan before sign. But on current master (e2a3b93860740fd498baad35fc8a4dc859527cb9), on top of 15446 $ git status On branch bug_15451 Your branch is ahead of 'origin/master' by 10 commits Go to Tools > Export data and got the error described on comment #10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:03:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:03:21 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44631|0 |1 is obsolete| | --- Comment #33 from Alex Arnaud --- Created attachment 46262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46262&action=edit Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved - Check if borrower already has reserved the same biblio (or item). - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower 3/ Try to hold the same biblio/item with the same borrower through ILS-DI and note that you can Apply the patch 4/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 5/ Try to hold the same biblio/item with the same borrower through ILS-DI. You shouldn't be able to do that. 6/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:03:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:03:28 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44632|0 |1 is obsolete| | --- Comment #34 from Alex Arnaud --- Created attachment 46263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46263&action=edit Bug 11999: Check for age restriction in CanBookBeReserved + improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:04:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:04:01 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:06:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:06:58 +0000 Subject: [Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:07:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:07:21 +0000 Subject: [Koha-bugs] [Bug 15442] Checkouts table will not display due to javascript error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15442 --- Comment #8 from Marc V?ron --- Created attachment 46264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46264&action=edit Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set If permission 'circulate_remaining_permissions' is not set, links to 'Circulation' (/circ/circulation-home.pl) on the intranet home page lead to an error message: "Error: You do not have permission to access this page." This patch hides the links if the permission is not set. To test: - Apply patch - Log in to the intranet (staff client) with a patron who has the permission 'circulate_remaining_pernissions' not set - Verify that no links to Circulation appear on the intranet start page (menu top left and menu in main page area) - Log in as a user who has the permission set. - Verify that te links appear as appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:08:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:08:47 +0000 Subject: [Koha-bugs] [Bug 15442] Checkouts table will not display due to javascript error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15442 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #46264|0 |1 is obsolete| | --- Comment #9 from Marc V?ron --- Comment on attachment 46264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46264 Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set Mistaked with the bug number, sorry for the noise... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:09:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:09:22 +0000 Subject: [Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 --- Comment #1 from Marc V?ron --- Created attachment 46265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46265&action=edit Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set If permission 'circulate_remaining_permissions' is not set, links to 'Circulation' (/circ/circulation-home.pl) on the intranet home page lead to an error message: "Error: You do not have permission to access this page." This patch hides the links if the permission is not set. To test: - Apply patch - Log in to the intranet (staff client) with a patron who has the permission 'circulate_remaining_pernissions' not set - Verify that no links to Circulation appear on the intranet start page (menu top left and menu in main page area) - Log in as a user who has the permission set. - Verify that te links appear as appropriate. http://bugs.koha-community.org/show_bug.cgi?id=15442 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:12:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:12:17 +0000 Subject: [Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:15:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:15:15 +0000 Subject: [Koha-bugs] [Bug 15473] New: Koha::Objects->find should find if the key is an empty string Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473 Bug ID: 15473 Summary: Koha::Objects->find should find if the key is an empty string Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 15381 This bug has been found after bug 15381 was pushed: If you go on authorities/authorities.pl, you expect a form to create a authorities with a "Default" authority type. Now, it explodes: Can't call method "authtypetext" on an undefined value at /home/koha/src/authorities/authorities.pl line 665. Koha::Objects->find does not want to search if the key does not exist (undef, '', 0). But actually it should only be a coward if it is not defined. Moreover this is the default behavior of the DBIx::Class find method. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:15:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:15:15 +0000 Subject: [Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15473 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473 [Bug 15473] Koha::Objects->find should find if the key is an empty string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:15:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:15:15 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15473 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:17:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:17:14 +0000 Subject: [Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:17:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:17:16 +0000 Subject: [Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473 --- Comment #1 from Jonathan Druart --- Created attachment 46266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46266&action=edit Bug 15473: Make Koha::Objects->find accepts 0 and '' as a key This bug has been found after bug 15381 was pushed: If you go on authorities/authorities.pl, you expect a form to create a authorities with a "Default" authority type. Now, it explodes: Can't call method "authtypetext" on an undefined value at /home/koha/src/authorities/authorities.pl line 665. Koha::Objects->find does not want to search if the key does not exist (undef, '', 0). But actually it should only be a coward if it is not defined. Moreover this is the default behavior of the DBIx::Class find method. Test plan: prove t/db_dependent/Koha/Objects.t should return green and GET /cgi-bin/koha/authorities/authorities.pl should not make everything explode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:22:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:22:49 +0000 Subject: [Koha-bugs] [Bug 15470] Error when adding new authority with Default framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:22:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:22:52 +0000 Subject: [Koha-bugs] [Bug 15470] Error when adding new authority with Default framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46250|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 46267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46267&action=edit [SIGNED-OFF] Bug 15470: Error when adding new authority with Default framework TO TEST: 1. Authorities > New authority > Default 2. You get: Can't call method "authtypetext" on an undefined value at 3. Apply the patch and repeat 1 Signed-off-by: Bernardo Gonzalez Kriegel Bug reproduced, now fixed. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:26:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:26:45 +0000 Subject: [Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 --- Comment #13 from Jonathan Druart --- Created attachment 46268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46268&action=edit Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type Some occurrences have been pushed in the meantime. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:28:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:28:08 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #13 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #12) Sorry Bernardo, I tested on my local branch, which was not updated. I have attached new patch on bug 15446, some occurrences of 'sub type' have been pushed in the meanwhile. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:31:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:31:51 +0000 Subject: [Koha-bugs] [Bug 15470] Error when adding new authority with Default framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel --- Hi, I signed this, but seems to be duplicate of Bug 15473, can you take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:32:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:32:40 +0000 Subject: [Koha-bugs] [Bug 15470] Error when adding new authority with Default framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470 --- Comment #4 from Jonathan Druart --- Fr?d?ric, Sorry I have noticed before but actually it's a duplicate of bug 15473 (I have just filled). With your patch, we are loosing the 'Default' authtypetext. I am marking this one as a duplicate as I am pretty sure it's the way to go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:33:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:33:00 +0000 Subject: [Koha-bugs] [Bug 15470] Error when adding new authority with Default framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #5 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 15473 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:33:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:33:00 +0000 Subject: [Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Jonathan Druart --- *** Bug 15470 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:37:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:37:01 +0000 Subject: [Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:37:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:37:04 +0000 Subject: [Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46266|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 46269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46269&action=edit [SIGNED-OFF] Bug 15473: Make Koha::Objects->find accepts 0 and '' as a key This bug has been found after bug 15381 was pushed: If you go on authorities/authorities.pl, you expect a form to create a authorities with a "Default" authority type. Now, it explodes: Can't call method "authtypetext" on an undefined value at /home/koha/src/authorities/authorities.pl line 665. Koha::Objects->find does not want to search if the key does not exist (undef, '', 0). But actually it should only be a coward if it is not defined. Moreover this is the default behavior of the DBIx::Class find method. Test plan: prove t/db_dependent/Koha/Objects.t should return green and GET /cgi-bin/koha/authorities/authorities.pl should not make everything explode. Signed-off-by: Bernardo Gonzalez Kriegel Find this after signing 15470 :) Test pass, new auth (Default) created, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:41:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:41:31 +0000 Subject: [Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|3.18 |master Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:42:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:42:51 +0000 Subject: [Koha-bugs] [Bug 2092] Koha should support Unicode 6 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2092 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Is this placeholder bug still necessary? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:44:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:44:20 +0000 Subject: [Koha-bugs] [Bug 4338] Consistent Interface To Currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4338 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Is this bug still necessary? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:45:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:45:36 +0000 Subject: [Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:45:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:45:38 +0000 Subject: [Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398 --- Comment #1 from Jonathan Druart --- Created attachment 46270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46270&action=edit Bug 15398: Hide Staff members only in the patron deletion/anonymization tool On bug 9076 (commit 568a4c1230ee9a4002181fcab2c083faf6c323a9), the plan was to hide the Staff members from the tool. But the test was wrong, it was done on the category_code instead of the category_type value. Test plan: 1/ Create a category 'Student' which is not part of the Staff (category_code=S, category_type!=S) 2/ Create a staff category (category_type=S) 3/ Go on the deletion/anonymization tool (tools/cleanborrowers.pl) and confirm that the category Student category is displayed in the dropdown list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:46:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:46:14 +0000 Subject: [Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11352, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9076 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:46:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:46:14 +0000 Subject: [Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15398 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:46:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:46:14 +0000 Subject: [Koha-bugs] [Bug 9076] Add ability to delete borrowers by expiration date and category code to cleanborrowers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15398 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:48:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:48:13 +0000 Subject: [Koha-bugs] [Bug 15470] Error when adding new authority with Default framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15470 --- Comment #6 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #4) > Fr?d?ric, > > Sorry I have noticed before but actually it's a duplicate of bug 15473 (I > have just filled). > With your patch, we are loosing the 'Default' authtypetext. > > I am marking this one as a duplicate as I am pretty sure it's the way to go. I agree -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:49:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:49:36 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #10 from Marc V?ron --- (In reply to Jonathan Druart from comment #8) > (In reply to Katrin Fischer from comment #7) > > Looking at the pref or doing a count of the branches in Auth.pm? Trying to > > understand :) > > Count the branches from Auth and remove the pref everywhere. > $template->param( singleBranchMode => Koha::Branches->search->count ); Yes, that makes sense. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:51:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:51:18 +0000 Subject: [Koha-bugs] [Bug 7314] Remove singleBranchMode system preference in favour of counting configured branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7314 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Is this kind of duplicate of Bug 4941 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:56:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:56:02 +0000 Subject: [Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #24 from Alex Arnaud --- *** This bug has been marked as a duplicate of bug 11999 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:56:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:56:02 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #35 from Alex Arnaud --- *** Bug 14155 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:57:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:57:06 +0000 Subject: [Koha-bugs] [Bug 15412] Dropdowns in suspend holds date selector do not function in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15412 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:57:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:57:09 +0000 Subject: [Koha-bugs] [Bug 15412] Dropdowns in suspend holds date selector do not function in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15412 --- Comment #3 from Jonathan Druart --- Created attachment 46271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46271&action=edit Bug 15412: Enable dropdowns date selector when suspending holds It seems to be the way to fix that https://stackoverflow.com/questions/13649459/twitter-bootstrap-multiple-modal-error Test plan: 1 - Place a hold through the opac 2 - View your account->Holds 3 - Click suspend hold 4 - You should be able to select a date using the arrows and dropdowns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:57:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:57:18 +0000 Subject: [Koha-bugs] [Bug 15412] Dropdowns in suspend holds date selector do not function in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15412 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 16:59:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 15:59:53 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 17:00:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 16:00:36 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|paul.poulain at biblibre.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 17:01:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 16:01:04 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6625 CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 17:01:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 16:01:04 +0000 Subject: [Koha-bugs] [Bug 6625] Allow Koha to use Openlibrary subject api In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6625 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6624 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 17:02:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 16:02:27 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #14 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #13) > (In reply to Bernardo Gonzalez Kriegel from comment #12) > > Sorry Bernardo, I tested on my local branch, which was not updated. > I have attached new patch on bug 15446, some occurrences of 'sub type' have > been pushed in the meanwhile. With all patches from 15446 and this, exporting a range of biblios to marc/xml/cvs, with/without ExportWithCsvProfile Inside the file (marc/xml/csv)

Software error:

Can't locate object method "export_format_id" via package
"Koha::CsvProfiles" at /home/bgkriegel/kohaclone/tools/export.pl line
196.
On logs export.pl: Can't locate object method "export_format_id" via package "Koha::CsvProfiles" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 17:12:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 16:12:31 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- (In reply to Katrin Fischer from comment #1) > Created attachment 8794 [details] > screenshot > > I tried retesting this on current master, what I did: > > 1) New definition > 2) Module: patrons > 3) Registration date > 4) Nothing shows up for the 4th step > > For other dates like 'Expiry date' the 4th step shows up correctly and shows > the wrong behaviour Nicole described. With current master 'Expiry date' displays on current master, but the bug as such is still valid. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 17:17:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 16:17:57 +0000 Subject: [Koha-bugs] [Bug 3607] Lost item returned credit to borrower - but can't resolve credit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3607 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 17:19:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 16:19:12 +0000 Subject: [Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46270|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 46272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46272&action=edit [SIGNED-OFF] Bug 15398: Hide Staff members only in the patron deletion/anonymization tool On bug 9076 (commit 568a4c1230ee9a4002181fcab2c083faf6c323a9), the plan was to hide the Staff members from the tool. But the test was wrong, it was done on the category_code instead of the category_type value. Test plan: 1/ Create a category 'Student' which is not part of the Staff (category_code=S, category_type!=S) 2/ Create a staff category (category_type=S) 3/ Go on the deletion/anonymization tool (tools/cleanborrowers.pl) and confirm that the category Student category is displayed in the dropdown list. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 17:19:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 16:19:09 +0000 Subject: [Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 17:31:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 16:31:29 +0000 Subject: [Koha-bugs] [Bug 8373] opacheader should not show in print layout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8373 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Tested on current master with opac-shelves.pl: If I use the browser's print preview, it looks OK. If I use the icon 'print', the whole page is printed, including the contents of the opacheader system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 17:54:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 16:54:15 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46261|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 46273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46273&action=edit Bug 15360: Rename "New from Z39.50" with "Replace with Z39.50" If the record exist, the button text should not be "New from", but "Replace". Test plan: Go on the authority home page (authorities/authorities-home.pl) You should see a "New from Z39.50" button. Edit an authority You should now see "Replace with Z39.50" Followed test plan, displays as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 17:54:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 16:54:59 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 18:05:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 17:05:18 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Testing: Without patches: - Order in dropdown list of Koha item types is wrong (not alphabetically). - t/db_dependent/Koha.t passes green With first patch (tests): - t/db_dependent/Koha.t does not pass (not ok 10 - GetItemTypes test) (as expected) With second patch applied: - Order in dropdown is alphabetically (as expected) - t/db_dependent/Koha.t passes green (as expected) Going to sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 18:06:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 17:06:36 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46257|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 46274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46274&action=edit Bug 15337: Add tests to ensure that GetItemTypes will return element ordered by desc See comment #3 Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 18:07:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 17:07:32 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46258|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 46275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46275&action=edit Bug 15337: Make itemtypes retrieved with GetItemTypes ordered by descriptions Prior to this patch, the itemtypes were displayed ordered by the code (itemtypes.itemtype DB column). This patch will make them displayed by the description displayed (the translated description). Test plan: 0/ Do not apply this patch set 1/ Confirm that the itemtypes are displayed ordered by code (when adding an item, cataloguing/additem.pl) 2/ Confirm that t/db_dependent/Koha.t does not pass 3/ Apply the test patch 4/ Confirm that t/db_dependent/Koha.t pass 5/ Confirm that the itemtypes are not displayed by description (on additem.pl) See comment #3 Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 18:07:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 17:07:49 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 18:18:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 17:18:21 +0000 Subject: [Koha-bugs] [Bug 15353] patron image disappears when on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46260|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 46276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46276&action=edit Bug 15353: Display the patron image where needed On the 3 following pages, the patron image was not displayed: members/discharge.pl members/pay.pl members/paycollect.pl Test plan: Apply this patch and confirm the image is now displayed Followed test plan, image displays as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 18:18:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 17:18:32 +0000 Subject: [Koha-bugs] [Bug 15353] patron image disappears when on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 18:18:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 17:18:47 +0000 Subject: [Koha-bugs] [Bug 15353] patron image disappears when on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 18:43:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 17:43:41 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- QA tools say: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt FAIL forbidden patterns forbidden pattern: console.log (line 25) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 18:46:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 17:46:48 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 --- Comment #3 from Marc V?ron --- Oh, sorry, I was not aware of the dependency: Bug 15285. Patch seems to work, though, behalve of the QA tools complaining (see comment #2) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 18:47:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 17:47:18 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 --- Comment #3 from Ian Palko --- Perhaps this would qualify as an "enhancement", but would it be possible to restore the older behavior as well? Previously the "New from z39.50" button did exactly that. It generated a new record from a z39.50 authorities search. There was never a "Replace" function or button. The replace feature is great, and allowing replacement as this patch does is a good idea, but perhaps we should also allow the creation of a new record as before. That would require a new "New from z39.50" button which would actually generate a new record, in addition to the "Replace from z39.50". Being on vacation, I'm not in front of my test server, else I'd work up a quick and dirty solution, since it seems easy and straight-forward. Perhaps if someone else has a few minutes ... Thanks for the work to fix and clarify this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 19:00:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 18:00:55 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 21:12:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 20:12:03 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42469|0 |1 is obsolete| | --- Comment #17 from R?mi Mayrand-Provencher --- Created attachment 46277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46277&action=edit bug 12446 - Enable adult patrons to have a guarantor I have rebased every patch. This includes all the features from the previous patches. On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; Please enter the commit message for your changes. Lines starting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 21:17:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 20:17:51 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42470|0 |1 is obsolete| | Attachment #42535|0 |1 is obsolete| | Attachment #46277|0 |1 is obsolete| | --- Comment #18 from R?mi Mayrand-Provencher --- Created attachment 46278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46278&action=edit bug 12446 - Enable adult patrons to have a guarantor I have rebased every patch. This includes all the features from the previous patches. On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 21:20:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 20:20:35 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46239|0 |1 is obsolete| | --- Comment #48 from Jesse Weaver --- Created attachment 46279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46279&action=edit Bug 10612 - Add ability to delete patrons with batch patron deletion tool This patch adds the ability to select a patron list for deletetion when using the Batch patron deletion/anonymization tool. It also adds buttons to the the patron lists table to access both the batch deletion and batch modification directly from the lists view. This is a squash of previous patches with a check added for issues before deleting borrowers. Test Plan: 1) Apply this patch 2) Create a list of patrons with the new Patron Lists feature 3) Try using the batch edit link form the lists table 4) Try using the batch delete link from the lists table Signed-off-by: Jesse Weaver ByWater internal signoff, still needs signoff from community. Patch seems kosher, passes QA tools. Needs followup to fix one small issue: squished patch undoes switch to FontAwesome icons in lists.tt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 21:22:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 20:22:09 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |remi.mayrand-provencher at inL | |ibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 21:30:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 20:30:02 +0000 Subject: [Koha-bugs] [Bug 15323] ./t/Prices.t fails without a valid database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323 --- Comment #3 from Liz Rea --- I've seen this too, but I didn't have a chance to look into it. Maybe it is ok in isolation, but not ok when run with other tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 21:45:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 20:45:01 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #49 from Nick Clemens --- Created attachment 46280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46280&action=edit Bug 10612 - [QA followup] Use font awesome icons in patron lists lists.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 21:45:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 20:45:38 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 21:45:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 20:45:40 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45716|0 |1 is obsolete| | --- Comment #8 from Jesse Weaver --- Created attachment 46281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46281&action=edit Bug 15354: Fix translated itemtype descriptions in circ rules In bug 14100, the admin/smart-rules.pl needed much more love. Indeed, the translated_description string should be used everywhere and replaced the previous 'humanitemtype'. Test plan: 1/ Translate some item types. 2/ Define some holds policy using these item types. 3/ Update the template strings 4/ Confirm that the "holds policy by item type" are displayed (for the default and specific library) and sorted by translated item type descriptions. Signed-off-by: Fr?d?ric Demians Signed-off-by: Jesse Weaver Passes QA tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 21:45:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 20:45:44 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46222|0 |1 is obsolete| | --- Comment #9 from Jesse Weaver --- Created attachment 46282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46282&action=edit Bug 15354: Sort itemtypes by translated description everywhere on circ rules admin page It's better to cmp on lc. Signed-off-by: Jesse Weaver Passes QA tools. Fixes sorting of dropdown for translated itemtype descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 21:45:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 20:45:50 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 --- Comment #10 from Jesse Weaver --- Created attachment 46283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46283&action=edit Bug 15354: (QA followup) remove tab character Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 21:58:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 20:58:19 +0000 Subject: [Koha-bugs] [Bug 15474] New: LDAP Integration Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15474 Bug ID: 15474 Summary: LDAP Integration Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kamekenshin at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Koha currently only reads from LDAP. It would be a good enhancement if KOHA was able to update the LDAP directory so that patron data can be updated/modified in KOHA and replicated to LDAP. This would allow for easier administration in some circumstances. One example is having a RADIUS server for wifi access authenticate users in an LDAP database that can be updated when changes are made to KOHA. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 22:01:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 21:01:50 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46101|0 |1 is obsolete| | --- Comment #29 from Bouzid --- Created attachment 46284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46284&action=edit Bug 11879 - Update BDIx schema and show main contact method in moremember.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 22:20:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 21:20:14 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46284|0 |1 is obsolete| | --- Comment #30 from Bouzid --- Created attachment 46285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46285&action=edit Bug 11879 - Update BDIx schema and show main contact method in moremember.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 5 22:29:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jan 2016 21:29:37 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46285|0 |1 is obsolete| | --- Comment #31 from Bouzid --- Created attachment 46286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46286&action=edit Bug 11879 - Update BDIx schema and show main contact method in moremember.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 01:21:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 00:21:46 +0000 Subject: [Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 01:21:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 00:21:49 +0000 Subject: [Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44769|0 |1 is obsolete| | --- Comment #5 from Jesse Weaver --- Created attachment 46287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46287&action=edit Skip articles in MARC21 using indicator n.2 of field 245 Only in MARC21 is possible to use ind2 of tag 245 to skip articles. This patch is based on inserting a special template in koha-indexdefs-to-zebra.xsl With this patch you must not insert index Title:s in biblio-koha-indexdefs.xml, it is defined in koha-indexdefs-to-zebra.xsl. It is not the best setup, but I find very difficult to use biblio-koha-indexdefs.xml. To test it in a english MARC21 setup: Insert same records with titles and correct values in ind2 of 245. If you have articles not in the skiping list of sort-string-utf.chr (The|the|a|A|an|An) you can see that the sort by articles use also articles. Insert the patch Rebuilt indexes from scratch Now all articles of titles are skipped TO TEST WITHOUT INDEXING: 1. Go to etc/zebradb/marc_defs/marc21/biblios directory. 2. Put the sample MARCXML file in this directory. 3. Transform the file into Zebra indexes: xsltproc biblio-zebra-indexdefs.xsl record.xml Observe that the Title:s index contains: 01 Business and Technologies 4. Apply the patch. 5. Repeat: xsltproc biblio-zebra-indexdefs.xsl record.xml Observe that the Title:s index contains: Business and Technologies Signed-off-by: Frederic Demians Signed-off-by: Jesse Weaver Verified working using yaz-client (as in http://wiki.koha-community.org/wiki/Understanding_Zebra_indexing#Examine_Zebra_index, though note that the `elem zebra::index` seems to be unneeded). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 01:22:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 00:22:38 +0000 Subject: [Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 --- Comment #6 from Jesse Weaver --- Created attachment 46288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46288&action=edit Bug 14332: Skip articles in MARC21 using indicator n.2 of field 245 Only in MARC21 is possible to use ind2 of tag 245 to skip articles. This patch is based on inserting a special template in koha-indexdefs-to-zebra.xsl With this patch you must not insert index Title:s in biblio-koha-indexdefs.xml, it is defined in koha-indexdefs-to-zebra.xsl. It is not the best setup, but I find very difficult to use biblio-koha-indexdefs.xml. To test it in a english MARC21 setup: Insert same records with titles and correct values in ind2 of 245. If you have articles not in the skiping list of sort-string-utf.chr (The|the|a|A|an|An) you can see that the sort by articles use also articles. Insert the patch Rebuilt indexes from scratch Now all articles of titles are skipped TO TEST WITHOUT INDEXING: 1. Go to etc/zebradb/marc_defs/marc21/biblios directory. 2. Put the sample MARCXML file in this directory. 3. Transform the file into Zebra indexes: xsltproc biblio-zebra-indexdefs.xsl record.xml Observe that the Title:s index contains: 01 Business and Technologies 4. Apply the patch. 5. Repeat: xsltproc biblio-zebra-indexdefs.xsl record.xml Observe that the Title:s index contains: Business and Technologies Signed-off-by: Frederic Demians Signed-off-by: Jesse Weaver Verified working using yaz-client (as in http://wiki.koha-community.org/wiki/Understanding_Zebra_indexing#Examine_Zebra_index, though note that the `elem zebra::index` seems to be unneeded). (Updated commit message to include bug number.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 01:23:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 00:23:18 +0000 Subject: [Koha-bugs] [Bug 15411] "Non fiction" is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 01:23:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 00:23:21 +0000 Subject: [Koha-bugs] [Bug 15411] "Non fiction" is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 --- Comment #4 from Aleisha Amohia --- Created attachment 46289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46289&action=edit Bug 15411: More changes Changes to Italian and Polish sql files and catalogue help file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 01:26:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 00:26:03 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #2 from Patfrat --- I will try to see from wich version i update as soon as possible, when i retrieve the distant access to the computer concerned. It is shutdown at this moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 01:28:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 00:28:29 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #28 from Aleisha Amohia --- (In reply to Marc V?ron from comment #27) > Hi Aleisha, as a native speaker, would you have time to do a follow up with > your wording? - That would be great. Have you had a look at my error messages from Bug 14573? I think this bug is basically a duplicate of 14573. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 01:38:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 00:38:19 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 --- Comment #14 from Aleisha Amohia --- I tried the UNLESS, and it was successful in clearing the warn but it gave us the empty table again, so decided to go with the IF/ELSE swap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 01:38:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 00:38:40 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 --- Comment #15 from Aleisha Amohia --- Created attachment 46290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46290&action=edit Bug 14480: Switching the IF/ELSE To test: 1) Go to any patron (ie this link http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=1369) 2) Click Edit 3) Notice the warn appears 4) Apply patch and reload page 5) Notice warns are gone but page still works correctly 6) Add restriction and save, then go back to Edit 7) Confirm restriction shows as it should 8) Remove restriction and save, then go back to Edit 9) Confirm it says "Patron is currently unrestricted". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 01:40:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 00:40:26 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #1 from Srdjan Jankovic --- Created attachment 46291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46291&action=edit bug_6624: OpenLibrarySearch syspref for OPAC If set to Yes, OPAC search results and details will include buton from Open Library Raed API. In addition, Number of titles held in Open Library and the results link will be reported on the search results screen. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 01:40:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 00:40:37 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #2 from Srdjan Jankovic --- Created attachment 46292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46292&action=edit bug_6624: Added Open Library Search and Read API to openlibrary.js -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 01:41:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 00:41:37 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 01:41:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 00:41:40 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #3 from Srdjan Jankovic --- Created attachment 46293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46293&action=edit bug_6624: Added Open Library Search and Read API calls to opac-results.tt and opac-detail.tt Conditional to OpenLibrarySearch syspref -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 01:44:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 00:44:04 +0000 Subject: [Koha-bugs] [Bug 14555] Warns in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46173|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia --- Created attachment 46294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46294&action=edit Bug 14555: Warns in opac-search.pl Avoid use of uninitialized value in split == Test plan == 1. Go to opac advanced search 2. Click "Search" without any search query 3. Log file will show "Use of uninitialized value in split at ..." 4. Apply this patch 5. Repeat step 1 and 2 6. Log file should no longer show "Use of uninitialized value in split at ..." Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 02:11:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 01:11:19 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #32 from Aleisha Amohia --- Applying: Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on current master for testing) fatal: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on current master for testing) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 02:15:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 01:15:28 +0000 Subject: [Koha-bugs] [Bug 15411] "Non fiction" is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45920|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 46295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46295&action=edit Bug 15411: Changing 'Non fiction' to 'Non-fiction' To test: 1) Apply patch 2) Run updatedatabase.pl 3) Go to advanced search in Staff Client (ie /cgi-bin/koha/catalogue/search.pl) 4) Confirm that it says 'Non-fiction' in the 'Any content' drop-down menu under 'Subtype limits' 5) Go to item search (ie /cgi-bin/koha/catalogue/itemsearch.pl) 6) Confirm that it says 'Non-fiction' under 'Collection code' 7) Go to advanced search in OPAC (ie /cgi-bin/koha/opac-search.pl) and click 'More options' 8) Confirm that it says 'Non-fiction' in the 'Content' drop-down menu 9) Go to the details page for a non-fiction book in the OPAC (ie /cgi-bin/koha/opac-detail.pl?biblionumber=2) and click 'Holdings' tab 10) Confirm that it says 'Non-fiction' under 'Collection' heading Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 02:19:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 01:19:00 +0000 Subject: [Koha-bugs] [Bug 15411] "Non fiction" is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46295|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 46296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46296&action=edit Bug 15411: Changing 'Non fiction' to 'Non-fiction' To test: 1) Apply patch 2) Run updatedatabase.pl 3) Go to advanced search in Staff Client (ie /cgi-bin/koha/catalogue/search.pl) 4) Confirm that it says 'Non-fiction' in the 'Any content' drop-down menu under 'Subtype limits' 5) Go to item search (ie /cgi-bin/koha/catalogue/itemsearch.pl) 6) Confirm that it says 'Non-fiction' under 'Collection code' 7) Go to advanced search in OPAC (ie /cgi-bin/koha/opac-search.pl) and click 'More options' 8) Confirm that it says 'Non-fiction' in the 'Content' drop-down menu 9) Go to the details page for a non-fiction book in the OPAC (ie /cgi-bin/koha/opac-detail.pl?biblionumber=2) and click 'Holdings' tab 10) Confirm that it says 'Non-fiction' under 'Collection' heading Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 02:19:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 01:19:06 +0000 Subject: [Koha-bugs] [Bug 15411] "Non fiction" is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46289|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 46297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46297&action=edit Bug 15411: More changes Changes to Italian and Polish sql files and catalogue help file. TEST PLAN --------- 1) Confirm sql is valid and has Non-fiction. > delete from auth_vals; > source {appropriate file}; 2) Staff -> Search -> Help -- Confirm Non-fiction 3) Run koha qa test tools Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 02:19:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 01:19:24 +0000 Subject: [Koha-bugs] [Bug 15411] "Non fiction" is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 02:24:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 01:24:36 +0000 Subject: [Koha-bugs] [Bug 15411] "Non fiction" is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46296|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 46298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46298&action=edit Bug 15411: Changing 'Non fiction' to 'Non-fiction' To test: 1) Apply patch 2) Run updatedatabase.pl 3) Go to advanced search in Staff Client (ie /cgi-bin/koha/catalogue/search.pl) 4) Confirm that it says 'Non-fiction' in the 'Any content' drop-down menu under 'Subtype limits' 5) Go to item search (ie /cgi-bin/koha/catalogue/itemsearch.pl) 6) Confirm that it says 'Non-fiction' under 'Collection code' 7) Go to advanced search in OPAC (ie /cgi-bin/koha/opac-search.pl) and click 'More options' 8) Confirm that it says 'Non-fiction' in the 'Content' drop-down menu 9) Go to the details page for a non-fiction book in the OPAC (ie /cgi-bin/koha/opac-detail.pl?biblionumber=2) and click 'Holdings' tab 10) Confirm that it says 'Non-fiction' under 'Collection' heading Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 02:24:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 01:24:43 +0000 Subject: [Koha-bugs] [Bug 15411] "Non fiction" is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15411 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46297|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 46299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46299&action=edit Bug 15411: More changes Changes to Italian and Polish sql files and catalogue help file. TEST PLAN --------- 1) Confirm sql is valid and has Non-fiction. > delete from auth_vals; > source {appropriate file}; 2) Staff -> Search -> Help -- Confirm Non-fiction 3) Run koha qa test tools Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 02:53:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 01:53:22 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 02:53:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 01:53:25 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46025|0 |1 is obsolete| | Attachment #46290|0 |1 is obsolete| | --- Comment #16 from M. Tompsett --- Created attachment 46300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46300&action=edit Bug 14480: Silences warn from editing patron Argument "" isn't numeric in numeric lt (<) TEST PLAN --------- 1) Go to any patron in staff client 2) Click 'Edit' 3) Check error logs -- warnings should exist. 4) Apply patch 5) Reload page -- warnings should not be triggered. 6) Add restriction and save 7) Go back to edit screen -- restriction should be shown 8) Remove restriction and save 9) Go back to edit screen -- Should say "Patron is currently unrestricted" 10) Run koha qa test tools. NOTE: Squashed, because it is a really small set of patches and multiple commits does not make sense to me. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 02:56:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 01:56:42 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46300|0 |1 is obsolete| | --- Comment #17 from M. Tompsett --- Created attachment 46301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46301&action=edit Bug 14480: Silences warn from editing patron Argument "" isn't numeric in numeric lt (<) TEST PLAN --------- 1) Go to any patron in staff client 2) Click 'Edit' 3) Check error logs -- warnings should exist. 4) Apply patch 5) Reload page -- warnings should not be triggered. 6) Add restriction and save 7) Go back to edit screen -- restriction should be shown 8) Remove restriction and save 9) Go back to edit screen -- Should say "Patron is currently unrestricted" 10) Run koha qa test tools. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 03:14:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 02:14:47 +0000 Subject: [Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46256|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 46302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46302&action=edit Bug 15444 - MARC21: Repeated 508 not correctly formatted (missing separator) This patch adds a separator for multiple 508 fields to the XSLT display in the staff and OPAC detail view. Separator is wrapped in span with class=?separator? for easy manipulation via css. To test: * Search the OPAC * Click the title with multiple 508 fields * Make sure the fields display properly * Repeat for a few more titles * Repeat in the Staff Client Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 03:15:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 02:15:16 +0000 Subject: [Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 03:24:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 02:24:13 +0000 Subject: [Koha-bugs] [Bug 15131] Give SCO separate control for AllowItemsOnHoldCheckout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15131 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 03:27:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 02:27:14 +0000 Subject: [Koha-bugs] [Bug 13215] letter.code is considered as a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 05:17:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 04:17:16 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #8 from M. Tompsett --- Comment on attachment 45524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45524 Bug 15240: Do not process issues with a date due later than today Review of attachment 45524: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15240&attachment=45524) ----------------------------------------------------------------- This eyeballs well. ::: misc/cronjobs/overdue_notices.pl @@ +454,4 @@ > AND b.branchcode = items.homebranch > AND biblio.biblionumber = biblioitems.biblionumber > AND issues.borrowernumber = ? > + AND TO_DAYS($date)-TO_DAYS(issues.date_due) >= 0 This makes sure all the filtering based on date is done by MySQL. @@ -500,5 @@ > # > > - my $borrower_sql = <<'END_SQL'; > -SELECT issues.borrowernumber, firstname, surname, address, address2, city, zipcode, country, email, emailpro, B_email, smsalertnumber, phone, cardnumber, > -TO_DAYS(?)-TO_DAYS(date_due) as difference, date_due 'difference' field removed because it is moved to part of the WHERE condition. @@ +505,4 @@ > FROM issues,borrowers,categories > WHERE issues.borrowernumber=borrowers.borrowernumber > AND borrowers.categorycode=categories.categorycode > +AND TO_DAYS($date)-TO_DAYS(issues.date_due) >= 0 This was the difference field, which strangely was never really used, and by limiting the SQL query here (make SQL do the work), this speeds the script up. Also, the ? in the TO_DAYS was changed to a hard coded $date. Gut feeling: meh, not a big deal. @@ -508,3 @@ > END_SQL > my @borrower_parameters; > - push @borrower_parameters, $date_to_run->datetime(); Removed, because the ? was changed to a hard coded $date. @@ -526,5 @@ > my $borrowernumber; > while ( my $data = $sth->fetchrow_hashref ) { > > - next unless ( DateTime->compare( $date_to_run, dt_from_string($data->{date_due})) ) == 1; > - Perl filtering on a larger data set is slower. Hence the removal of this, when replaced by the SQL grunt work. @@ -616,5 @@ > my $j = 0; > my $exceededPrintNoticesMaxLines = 0; > while ( my $item_info = $sth2->fetchrow_hashref() ) { > - next unless ( DateTime->compare( $date_to_run, dt_from_string($item_info->{date_due})) ) == 1; > - Perl filtering on a larger data set is slower. Hence the removal of this, when replaced by the SQL grunt work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 05:48:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 04:48:18 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #9 from M. Tompsett --- It's nearing midnight, and there is no express test plan to follow or steps to take to generate the data necessary to sign off. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 06:54:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 05:54:30 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #29 from Marc V?ron --- Created attachment 46303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46303&action=edit Bug 15288: (followup) Better wording for OPAC error page This patch changes the wording of the OPAC error page (See Bug 14573). Additionally, it displays the link to the login page only if the system preference 'opacuserlogin' is set. To test: - Apply patch - Review koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 06:56:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 05:56:34 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #30 from Marc V?ron --- Needs sign-off for the followup (Better wording). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 08:18:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 07:18:52 +0000 Subject: [Koha-bugs] [Bug 15412] Dropdowns in suspend holds date selector do not function in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15412 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46271|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 46304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46304&action=edit Bug 15412: Enable dropdowns date selector when suspending holds It seems to be the way to fix that https://stackoverflow.com/questions/13649459/twitter-bootstrap-multiple-modal-error Test plan: 1 - Place a hold through the opac 2 - View your account->Holds 3 - Click suspend hold 4 - You should be able to select a date using the arrows and dropdowns Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 08:19:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 07:19:10 +0000 Subject: [Koha-bugs] [Bug 15412] Dropdowns in suspend holds date selector do not function in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15412 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 08:41:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 07:41:06 +0000 Subject: [Koha-bugs] [Bug 12489] Ajax checkout table: no "loading..." popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12489 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #6 from Marc V?ron --- Tested on current master. On member/moremember.pl with "Always show checkouts immediately" set, a message "Loading" appears while loading the table. (I had first to zoom the browser window to make the the checkouts table visible while loading the page. With zoom set to normal, I had to scroll down to the checkouts table, and meanwhile it was loaded.) With other words, the Bug seems no longer to be valid on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 09:29:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 08:29:41 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #10 from Jonathan Druart --- Test plan: Launch the overdue_notices.pl on a large DB and compare the execution times with and without patch applied. No behavior difference should be noticed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 09:36:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 08:36:54 +0000 Subject: [Koha-bugs] [Bug 6816] Capture member signature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6816 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- We can upload files related to patrons ( cgi-bin/koha/members/files.pl?borrowernumber=nnnnn ) This way, e.g. signed and scanned contracts could be uploaded. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 09:37:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 08:37:01 +0000 Subject: [Koha-bugs] [Bug 14294] Umbrella report for tracking improvements to File upload feature (see also 6874) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14294 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6816 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 09:37:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 08:37:01 +0000 Subject: [Koha-bugs] [Bug 6816] Capture member signature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6816 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14294 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 09:37:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 08:37:19 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 09:37:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 08:37:22 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46301|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 46305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46305&action=edit Bug 14480: Silences warn from editing patron Argument "" isn't numeric in numeric lt (<) TEST PLAN --------- 1) Go to any patron in staff client 2) Click 'Edit' 3) Check error logs -- warnings should exist. 4) Apply patch 5) Reload page -- warnings should not be triggered. 6) Add restriction and save 7) Go back to edit screen -- restriction should be shown 8) Remove restriction and save 9) Go back to edit screen -- Should say "Patron is currently unrestricted" 10) Run koha qa test tools. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 09:40:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 08:40:31 +0000 Subject: [Koha-bugs] [Bug 14555] Warns in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 09:42:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 08:42:13 +0000 Subject: [Koha-bugs] [Bug 1598] Allow unmoderated comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1598 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 09:45:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 08:45:23 +0000 Subject: [Koha-bugs] [Bug 12489] Ajax checkout table: no "loading..." popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12489 --- Comment #7 from Jonathan Druart --- There is a "Loading... you may continue scanning." on circulation, not on moremember. The message popup is not displayed on top anymore but not in the table neither. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:00:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:00:26 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #15 from Jonathan Druart --- Created attachment 46306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46306&action=edit Bug 15451: Do not considered a Resultset as a Result The previous calls were wrong, but there is something bad with the DB structure: export_format.profile should be a unique key. This patch fixes the previous calls and add a FIXME not to forget to fix the DB structure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:02:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:02:34 +0000 Subject: [Koha-bugs] [Bug 15475] New: export_format.profile should be a unique key Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15475 Bug ID: 15475 Summary: export_format.profile should be a unique key Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 15451 The pref ExportWithCsvProfile considers that export_format.profile is unique. We should reflect this constraint in the DB structure. See bug 15451 comment 15 to know what should be fixed (and git grep ExportWithCsvProfile). Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:02:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:02:34 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15475 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15475 [Bug 15475] export_format.profile should be a unique key -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:03:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:03:10 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #16 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > Created attachment 46306 [details] [review] > Bug 15451: Do not considered a Resultset as a Result > > The previous calls were wrong, but there is something bad with the DB > structure: export_format.profile should be a unique key. > This patch fixes the previous calls and add a FIXME not to forget to fix > the DB structure. I have opened bug 15475. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:05:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:05:03 +0000 Subject: [Koha-bugs] [Bug 15323] ./t/Prices.t fails without a valid database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- --- Comment #4 from Jonathan Druart --- Let me know if you manage to recreate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:05:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:05:24 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6846 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:05:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:05:24 +0000 Subject: [Koha-bugs] [Bug 6846] Dont allow staff to change own permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6846 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10573 --- Comment #4 from Marc V?ron --- This seems to work on current master. To verify: - Give a test user following permisson - borrowers Add, modify and view patron information - permissions Set user permissions - Log in as test user - Search a user, change the permission -> possible - Search test user, try to change the permission -> error page not allowed Though, because the borrowers permission is needed, somebody could create a new patron and set there a higher level of permissions. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:05:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:05:54 +0000 Subject: [Koha-bugs] [Bug 7648] staff can make themselves superlibrarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7648 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6846 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:05:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:05:54 +0000 Subject: [Koha-bugs] [Bug 6846] Dont allow staff to change own permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6846 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7648 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:08:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:08:14 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46259|0 |1 is obsolete| | --- Comment #4 from Julian Maurice --- Created attachment 46307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46307&action=edit Bug 15471: Add column settings and filters to Holds queue table Same patch with console.log removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:09:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:09:32 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 --- Comment #5 from Julian Maurice --- (In reply to Marc V?ron from comment #2) > QA tools say: > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt > FAIL forbidden patterns > forbidden pattern: console.log (line 25) Sorry about that, this is fixed now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:13:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:13:45 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 --- Comment #4 from Jonathan Druart --- Created attachment 46308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46308&action=edit [ALTERNATIVE-PATCH] Bug 15360: Add a "Replace with Z39.50" button when editing an authority If the record exist, a new button "Replace with Z39.50" is added Test plan: Go on the authority home page (authorities/authorities-home.pl) You should see a "New from Z39.50" button. Edit an authority You should now see "Replace with Z39.50" and "New from Z39.50" Confirm that the 2 buttons work as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:14:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:14:16 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #5 from Jonathan Druart --- There are 2 patches now, pick the one you prefer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:25:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:25:32 +0000 Subject: [Koha-bugs] [Bug 15476] New: Listname not always displayed in shelves.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15476 Bug ID: 15476 Summary: Listname not always displayed in shelves.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To reproduce: In staff client, go to List and click on the name of an exixting list. At the bottom of the screen, you see a title "Add an item to " but no list name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:33:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:33:06 +0000 Subject: [Koha-bugs] [Bug 15476] Listname not always displayed in shelves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15476 --- Comment #1 from Marc V?ron --- Created attachment 46309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46309&action=edit Bug 15476: Listname not always displayed in shelves.pl To reproduce: - In staff client, go to List and click on the name of an existing list. - At the bottom of the screen, you see a title "Add an item to " but no list name. To test: - Apply patch - Verify that listname appears after "Add an item to " -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:33:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:33:44 +0000 Subject: [Koha-bugs] [Bug 15476] Listname not always displayed in shelves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15476 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:48:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:48:30 +0000 Subject: [Koha-bugs] [Bug 4912] After editing private list, user should be redirect to private lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4912 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #26 from Marc V?ron --- This is still an issue on current master: - Log in to OPAC - Go to 'your Lists' - Click on "edit" near one of the lists - Save Result: The list contents display (you are not taken back to the page where you clicked the "edit" link.). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 10:53:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 09:53:21 +0000 Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition module could order by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #19 from Marc V?ron --- Has anybody plans to work on this enhancement? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 11:07:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 10:07:23 +0000 Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition module could order by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #20 from Mirko Tietgen --- I talked to Katrin about this topic recently, she said she has a proof of concept. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 11:23:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 10:23:36 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 --- Comment #6 from Marc V?ron --- Filtering works OK and I can manage the columns in administration, but I do not see a 'Show / hide columns' on the page itself (like e.g. with the currency table). Should the patch be tested on top of 15285? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 11:26:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 10:26:52 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46307|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 46310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46310&action=edit Bug 15471: Add column settings and filters to Holds queue table Add column visibility menu using DataTables Buttons Add a text filter on top of each column Also extend page width so that the large table is better centered Depends on bug 15285 Test plan 1. Go to Holds queue page (circ/view_holdsqueue.pl) 2. Check that table sorting and filtering work well and that you can hide each column 3. Go to Admin > Configure columns and change the settings for this table (Circulation > view_holdsqueue > holds-table). Verify that the settings work by going again to the Holds queue page 4. Check that filters continue to work after hiding some columns Tested on top of 15285, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 11:27:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 10:27:09 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 11:29:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 10:29:55 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #7 from Marc V?ron --- Tested, works with currency table and with Bug 15471. Status is "New" at the moment, does it need Sign-off or are there updates to come? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 11:48:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 10:48:52 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 11:48:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 10:48:55 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #11 from Jonathan Druart --- Created attachment 46311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46311&action=edit Bug 4941: Make tests non DB dependent -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 11:48:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 10:48:59 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #12 from Jonathan Druart --- Created attachment 46312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46312&action=edit Bug 4941: DB Changes -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 11:49:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 10:49:02 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #13 from Jonathan Druart --- Created attachment 46313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46313&action=edit Bug 4941: Remove the singleBranchMode system preference The singleBranchMode system preference does not make sense. Either the install has only 1 library defined or several. In both case, we can easily guess the behavior to follow. So the idea of this patch is to replace the fetch of this syspref with a call to count the number of libraries defined in DB. Test plan: 1/ From a fresh Koha install, execute the DB entry to remove the pref. 2/ Define only 1 library 3/ Confirm that Koha behaves the same as before (try to change your library, look at the facets) 4/ Create another library (or more) and reinsert the pref and set it: insert into systempreferences (variable, value) values('singleBranchMode', 1); 5/ Execute the DB entry You should get a warning message. 6/ Repeat 3. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 11:49:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 10:49:55 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15294 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 11:49:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 10:49:55 +0000 Subject: [Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4941 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 11:52:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 10:52:19 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15404 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 11:52:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 10:52:19 +0000 Subject: [Koha-bugs] [Bug 15404] CanBookBeReserved: No count of biblio level holds if ReservesControlBranch is item's home library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11999 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 11:53:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 10:53:22 +0000 Subject: [Koha-bugs] [Bug 12489] Ajax checkout table: no "loading..." popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12489 --- Comment #8 from Marc V?ron --- Created attachment 46314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46314&action=edit Message "Loading" on moremember.pl Screen capture: The message appears if "Always show checkouts immediately" is set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:06:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:06:35 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:08:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:08:27 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel at gmail.com --- Comment #14 from Bernardo Gonzalez Kriegel --- Current master, on top of 15294, patch does not apply Applying: Bug 4941: Remove the singleBranchMode system preference fatal: sha1 information is lacking or useless (C4/Auth.pm). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:12:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:12:42 +0000 Subject: [Koha-bugs] [Bug 14555] Warns in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel --- Hi Aleisha, switch this to signed-off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:16:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:16:37 +0000 Subject: [Koha-bugs] [Bug 15477] New: Error handling on editing item type translations Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15477 Bug ID: 15477 Summary: Error handling on editing item type translations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 14100 The user always get "An error occurred when updating this translation" although it has been updated in DB. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 [Bug 14100] Add base to make item types, branch names, sysprefs values and authorised values translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:16:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:16:37 +0000 Subject: [Koha-bugs] [Bug 14100] Add base to make item types, branch names, sysprefs values and authorised values translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15477 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15477 [Bug 15477] Error handling on editing item type translations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:20:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:20:53 +0000 Subject: [Koha-bugs] [Bug 15477] Error handling on editing item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:20:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:20:55 +0000 Subject: [Koha-bugs] [Bug 15477] Error handling on editing item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15477 --- Comment #1 from Jonathan Druart --- Created attachment 46315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46315&action=edit Bug 15477: (follow-up) Bug 14100: Better errors handling On bug 14100, the patch "Better errors handling" introduced an ... error. The user always get "An error occurred when updating this translation" although it has been updated in DB. Test plan: Edit translations for an item type: you should not get an error when everything went fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:21:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:21:31 +0000 Subject: [Koha-bugs] [Bug 15307] Delete link doesn't appear for newly-added item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15307 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15477 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- (In reply to Owen Leonard from comment #1) > Oh, I see now that the table cell is editable directly. I could only tell > because I was inspecting the source! How we indicate to the user that they > can edit? What do you suggest? > Another issue: When I edit something I get an error message every time: "An > error occurred when updating this translation," although my edits seem to be > getting saved each time. See bug 15477 for a patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:21:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:21:31 +0000 Subject: [Koha-bugs] [Bug 15477] Error handling on editing item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15307 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:27:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:27:43 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:27:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:27:47 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46303|0 |1 is obsolete| | --- Comment #31 from Bernardo Gonzalez Kriegel --- Created attachment 46316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46316&action=edit [SIGNED-OFF] Bug 15288: (followup) Better wording for OPAC error page This patch changes the wording of the OPAC error page (See Bug 14573). Additionally, it displays the link to the login page only if the system preference 'opacuserlogin' is set. To test: - Apply patch - Review koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt Signed-off-by: Bernardo Gonzalez Kriegel No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:28:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:28:50 +0000 Subject: [Koha-bugs] [Bug 15308] Suggested new interface for item type translation process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15308 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Owen, That makes sense to me! Note that at the beginning bug 14100 did not provide edition. It was more a POC than a very shiny proposal :) A few notes: - You have 'Add' and 'Delete' on the same line, it does not make sense - The already translated strings could be on top of others - The idea was other "entities" to translate, as system preferences, see the 'Think further / Todo' on one of the commit description. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:29:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:29:26 +0000 Subject: [Koha-bugs] [Bug 15308] Suggested new interface for item type translation process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15308 --- Comment #2 from Jonathan Druart --- Here it is: > Think further / Todo: > 1/ Update all occurrences of the item type's description (DONE) > 2/ Implement for authorised values > 3/ Implement for syspref value (at least textarea) > 4/ Implement for branch names > 5/ Centralize all the translation on a single page in the admin area > ... > N/ Implement a webservice to centralize all the translations and give > the ability to sync the item types/authorised values description with > the rest of the world (push and pull). The 5) should be kept in mind. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:33:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:33:35 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Depends on| |15295 --- Comment #15 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #14) > Current master, on top of 15294, patch does not apply Sorry, depends on bug 15295 too. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:33:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:33:35 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4941 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:37:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:37:49 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |julian.maurice at biblibre.com Status|NEW |ASSIGNED --- Comment #10 from Jonathan Druart --- Julian, could you please have a look at this blocker please? I would like a better solution than the Bernardo's patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:41:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:41:22 +0000 Subject: [Koha-bugs] [Bug 15247] mysql_auto_reconnect do not reconnect with UTF8 connection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15247 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Did you try with 3.22? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:42:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:42:25 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15247 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:42:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:42:25 +0000 Subject: [Koha-bugs] [Bug 15247] mysql_auto_reconnect do not reconnect with UTF8 connection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15247 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14778 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 12:44:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 11:44:23 +0000 Subject: [Koha-bugs] [Bug 15297] Patron registration default date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15297 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Did you forget to apply the patch? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:03:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:03:57 +0000 Subject: [Koha-bugs] [Bug 15478] New: Checksum mismatch when regenerating schema Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 Bug ID: 15478 Summary: Checksum mismatch when regenerating schema Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When regenerating the db schema on master, the script will error out with a checksum mismatch on Borrower.pm, and also DeletedBorrower.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:04:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:04:05 +0000 Subject: [Koha-bugs] [Bug 15478] Checksum mismatch when regenerating schema In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |blocker Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:05:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:05:50 +0000 Subject: [Koha-bugs] [Bug 15478] Checksum mismatch when regenerating schema In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:05:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:05:52 +0000 Subject: [Koha-bugs] [Bug 15478] Checksum mismatch when regenerating schema In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 --- Comment #1 from Kyle M Hall --- Created attachment 46317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46317&action=edit Bug 15478 - Checksum mismatch when regenerating schema When regenerating the db schema on master, the script will error out with a checksum mismatch on Borrower.pm, and also DeletedBorrower.pm Test Plan: 1) Check out master 2) Run ./misc/devel/update_dbix_class_files.pl 3) Note the error 4) Apply this patch 5) Re-reun ./misc/devel/update_dbix_class_files.pl 6) Note there is no error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:06:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:06:30 +0000 Subject: [Koha-bugs] [Bug 15478] Checksum mismatch when regenerating schema In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 --- Comment #2 from Kyle M Hall --- Created attachment 46318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46318&action=edit Bug 15478 - Update the remaining schema files that do not match the db schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:10:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:10:27 +0000 Subject: [Koha-bugs] [Bug 15239] Add multiple items fail on barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- The module looks completely buggy, indeed. There is the following note in the module: > This format is deprecated and SHOULD NOT BE USED. With an explanation of why it should not be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:11:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:11:36 +0000 Subject: [Koha-bugs] [Bug 15478] Checksum mismatch when regenerating schema In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9303 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 [Bug 9303] relative's checkouts in the opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:11:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:11:36 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15478 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 [Bug 15478] Checksum mismatch when regenerating schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:12:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:12:34 +0000 Subject: [Koha-bugs] [Bug 15239] Add multiple items fail on barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:15:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:15:45 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #26 from Marcel de Rooy --- (In reply to Marc V?ron from comment #25) > Signed-off-by: Marc V?ron Thanks, Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:18:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:18:00 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #53 from Kyle M Hall --- Created attachment 46319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46319&action=edit Bug 12375 - Add new serial fields to kohastructure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:18:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:18:13 +0000 Subject: [Koha-bugs] [Bug 15234] Administrative interface timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Manos, Looking at the timeout code, it looks good. With what searches on what servers do you get this problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:20:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:20:34 +0000 Subject: [Koha-bugs] [Bug 15478] Checksum mismatch when regenerating schema In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46318|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 46320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46320&action=edit Bug 15478 - Update the remaining schema files that do not match the db schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:22:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:22:59 +0000 Subject: [Koha-bugs] [Bug 15195] patron details should open in tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15195 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12352, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10904 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- commit 49fa3c0d08232e6d44f82e6827cedb076bcdbdd7 Bug 10904: Limit patron update request management by branch commit d49cba287e46b4c1e6656f9ec2c1867bfd633016 Bug 12352: Patron modification request page: Add link to patron record (In reply to Katrin Fischer from comment #1) > I think we accidentally added the same feature twice there - one could be > removed. Which one? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:23:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:23:00 +0000 Subject: [Koha-bugs] [Bug 12352] Patron modification request page: Add link to patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15195 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:23:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:23:00 +0000 Subject: [Koha-bugs] [Bug 10904] Limit patron modification request management by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15195 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:33:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:33:37 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #19 from Jonathan Druart --- Bug 15407 is going to remove C4::Category, you should use Koha::Patron::Categories instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:33:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:33:44 +0000 Subject: [Koha-bugs] [Bug 15143] Removing a Guarantee from a Guarantors account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15143 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12446 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:33:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:33:44 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15143 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:35:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:35:17 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:35:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:35:22 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46240|0 |1 is obsolete| | --- Comment #288 from Marcel de Rooy --- Created attachment 46321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46321&action=edit Bug 7143 : Adding releases and fixing some missing tabs Signed-off-by: Bernardo Gonzalez Kriegel No errors Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:40:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:40:33 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #32 from Marcel de Rooy --- QA: Having a look now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:54:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:54:52 +0000 Subject: [Koha-bugs] [Bug 15479] New: SIPserver rejects renewals for patrons with alphanumeric cardnumbers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479 Bug ID: 15479 Summary: SIPserver rejects renewals for patrons with alphanumeric cardnumbers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com If you allow non-numeric characters in patron barcodes they may be stored in either lower or uppercase in the borrowers table which is defined with a _ci (case insensitive) collation and therefore treats both forms as equivalent. However when the sipserver processes an issue transaction (used by most devices for both issue and renew) the test to see if the issue is in fact a renew uses a case sensitive comparison of the incoming cardnumber and that in the database causing the renewal to be rejected as 'Item checked out to another patron' e.g. this client sends cardnumber A17 but the database has stored this as 'a17' Request:11YN20160106 12164220160828 093005AO|AAA17|AB502326000767|AC|AD|BOY|AY1AZED86 Response:120NUN20160106 121642AOCPL|AAA17|AB502326000767|AJProzac nation [region 2] [import]|AH|AFItem checked out to another patron|BLY|AY1AZD57E[0d][0a] Request:11YN20160106 12164220160828 093005AO|AAA17|AB502326000755|AC|AD|AY2AZEEEE Response:120NUN20160106 121642AOCPL|AAA17|AB502326000755|AJAdvanced programming in the UNIX environment /|AH|AFItem checked out to another patron|BLY|AY2AZD100[0d][0a] Patron status reveals cardnumber as stored and that the two items are indeed on loan to this patron: Request:6302420160106 121642 Y AOCPL|AAA17|AC|AD|AY3AZF34D Response:64 02420160106 121642000000000002000000000000AOCPL|AAa17|AEFHT Trial|BLY|CQN|BV2.00|CC5|AU502326000767|AU502326000755|PCST|PIY|AFGreetings from Koha. -- Patron owes 2.00|AY3AZCE4B[0d][0a] Comparison in code should use same type of comparison as the database -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 13:59:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 12:59:20 +0000 Subject: [Koha-bugs] [Bug 15478] Checksum mismatch when regenerating schema In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #4 from Julian Maurice --- Why are these patches already in master ? (status is Needs Signoff) BTW in master there is still the first version of the 2nd patch, so when I receive a new serial I have a fatal error: DBIx::Class::ResultSet::new(): No such column serialseq_z on Koha::Schema::Result::Serial at /home/koha/src/Koha/Object.pm line 59 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:01:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:01:59 +0000 Subject: [Koha-bugs] [Bug 15480] New: Number of issues displayed by prediction pattern test and setting of not published issues Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15480 Bug ID: 15480 Summary: Number of issues displayed by prediction pattern test and setting of not published issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com May be this post could have been added to bug 15148 and 15149, but it's seen here under a different aspect, so I opened a new bug. By now the number of issues displayed by prediction pattern test is related to the number set in "subscription length". But sometimes when a serial has predictable not published issues to be set on the prediction pattern checkboxes, this behaviour can make it impossible : Imagine a weekly serial that has only 46 issues a year, say it's not published in August and during the last 2 weeks of december. Initially, you would be tempted to set the number of issues to 46, but then, the last november and the december issues will not be displayed by the prediction pattern test and so you will not be able to check all the not published issues. >From what I experienced, you can set the issues number to the standard 52, and if the WhenMoreThan parameter of numbering pattern is correctly set to 46, it will be ok. But that is not very intuitive and should be at least documented. And may be, it would be preferable to fix automatically this parameter according to periodicity. Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:03:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:03:39 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:03:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:03:42 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45425|0 |1 is obsolete| | Attachment #45426|0 |1 is obsolete| | Attachment #46316|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy --- Created attachment 46322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46322&action=edit Bug 15288: Error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by only one template for staff and only one template for OPAC. Additionally it removes a translatability issues due to sentence splitings by html tags. To test: - Apply patch - Trigger 404 error for staff and for OPAC by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files - Review koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt and koha-tmpl/intranet-tmpl/prog/en/modules/errorpage.tt (Amended to fix a typo) (Amended for comment #6) (Amended to cover OPAC error pages as well) Signed-off-by: Hector Castro Works as advertised Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:03:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:03:48 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #34 from Marcel de Rooy --- Created attachment 46323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46323&action=edit Bug 15288: (followup) Remove obsolete *.tt files Follwoing files were not yet deleted: koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/400.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/401.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/402.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/403.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/500.tt Note: the 404.tt file was renamed to errorpage.tt To test: Verify that files are deleted. Signed-off-by: Hector Castro Files removed, new errorpage.tt added Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:03:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:03:52 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #35 from Marcel de Rooy --- Created attachment 46324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46324&action=edit Bug 15288: (followup) Better wording for OPAC error page This patch changes the wording of the OPAC error page (See Bug 14573). Additionally, it displays the link to the login page only if the system preference 'opacuserlogin' is set. To test: - Apply patch - Review koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt Signed-off-by: Bernardo Gonzalez Kriegel No errors Signed-off-by: Marcel de Rooy Amended: Replaced following reasons by 'the following reasons'. Reads better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:07:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:07:37 +0000 Subject: [Koha-bugs] [Bug 15480] Number of issues displayed by prediction pattern test and setting of not published issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15480 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15149, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15148 CC| |koha at univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:07:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:07:37 +0000 Subject: [Koha-bugs] [Bug 15149] Serials: Test prediction pattern does not consider Subscription start and end date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15149 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15480 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:07:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:07:37 +0000 Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at First issue date, not Subscription start date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15480 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:09:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:09:06 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- Changed status to Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:10:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:10:04 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #36 from Marcel de Rooy --- QA Comment: Thanks for the follow-up, Marc. Looks good to me now. No blockers, but maybe for future improvement: [1] For more consistency, it would be nice to have the same reasons for an error listed on opac and intranet. Perhaps from a shared include or so? At this time the opac is more specific. [2] I would not mind listing the original status message after Error on the same line. Something like Error 403 Forbidden or Error 404 Not Found [3] Perhaps removing 402 is better than saying Invalid link. We do not use it in Koha, it is supposed to mean Payment required. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:13:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:13:14 +0000 Subject: [Koha-bugs] [Bug 15119] Hide search header text boxes on render In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15119 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:13:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:13:17 +0000 Subject: [Koha-bugs] [Bug 15119] Hide search header text boxes on render In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15119 --- Comment #1 from Jonathan Druart --- Created attachment 46325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46325&action=edit Bug 15119: Hide search header text boxes on render When the page rendering is slow or the page is heavy, the tabs in the header shown be not correctly displayed as tabs. This patch suggests to hide them, display the first one, and wait for the JS code to display them nicely. To easily reproduced the ergonomic issue, go on the circulation home page (/cgi-bin/koha/circ/circulation.pl) and search for a patron 'a' or 'd', you will get a lot of result and the page will be slow to be fully displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:13:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:13:31 +0000 Subject: [Koha-bugs] [Bug 15119] Hide search header text boxes on render In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15119 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:22:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:22:00 +0000 Subject: [Koha-bugs] [Bug 15479] SIPserver rejects renewals for patrons with alphanumeric cardnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell --- Created attachment 46326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46326&action=edit Proposed Patch Patch uses a case insensitive comparison to get correct result. To test issue a checkout for a borrower whith an item already on loan to them and where the request uses a different case to the db see examples in bug -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:22:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:22:34 +0000 Subject: [Koha-bugs] [Bug 12489] Ajax checkout table: no "loading..." popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #9 from Jonathan Druart --- So let's consider it as fixed :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:24:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:24:31 +0000 Subject: [Koha-bugs] [Bug 15479] SIPserver rejects renewals for patrons with alphanumeric cardnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479 --- Comment #2 from Colin Campbell --- With patch applied repeating the requests listed in the bug result in issues being correctly identified and processed as renewals: Request:11YN20160106 12224420160828 093005AO|AAA17|AB502326000767|AC|AD|BOY|AY1AZED87 Response:120NUN20160106 122244AOCPL|AAA17|AB502326000767|AJProzac nation [region 2] [import]|AH|AFNO_MORE_RENEWALS: 1|BLY|BV2.00|BHUSD|BT06|AY1AZD77D[0d][0a] Request:11YN20160106 12224420160828 093005AO|AAA17|AB502326000755|AC|AD|AY2AZEEEF Response:121YNY20160106 122245AOCPL|AAA17|AB502326000755|AJAdvanced programming in the UNIX environment /|AH20160108 235900|AFItem already checked out to you: renewing item.|AY2AZCA9E[0d][0a] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:26:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:26:50 +0000 Subject: [Koha-bugs] [Bug 7314] Remove singleBranchMode system preference in favour of counting configured branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7314 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 4941 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:26:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:26:50 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #16 from Jonathan Druart --- *** Bug 7314 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:53:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:53:14 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46278|0 |1 is obsolete| | --- Comment #20 from R?mi Mayrand-Provencher --- Created attachment 46327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46327&action=edit The C4::Category file was not even used! rebased to avoid eventual possible conflicts. bug 12446 - Enable adult patrons to have a guarantor I have rebased every patch. This includes all the features from the previous patches. On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 14:59:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 13:59:16 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46327|The C4::Category file was |bug 12446 - Enable adult description|not even used! rebased to |patrons to have a guarantor |avoid eventual possible | |conflicts. | --- Comment #21 from R?mi Mayrand-Provencher --- Comment on attachment 46327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46327 bug 12446 - Enable adult patrons to have a guarantor >From 7020394e74d993f645d8b1b7bf98649a00c1f837 Mon Sep 17 00:00:00 2001 >From: remi >Date: Wed, 6 Jan 2016 08:46:27 -0500 >Subject: [PATCH] bug 12446 - Enable adult patrons to have a guarantor > >The C4::Category file was not even used! rebased to avoid eventual possible conflicts. > >I have rebased every patch. >This includes all the features from the previous patches. > >On the patron category page, there is a new field to specify whether patrons can be guarantee or not. >The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". > >1) Apply the patch >2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. >3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) >4) See below to test various scenarios > >- Enable an adult to have a guarantor: >0.0) Create or edit a patron category of type 'A'. >0.1) Set the "Can be guarantee" field to "Yes" and save. >1) Select an adult patron -> details tab; >2) Click edit button; >3) validate "guarantor information" fieldset; > >- Shows guarantees' fines in the guarantor's page: >4) Click Set to patron button and select a guarantor; >5) Generate a fine; >6) Select guarantor patron -> details tab; >7) Validate guarantee's fine information. > >- Transfer some guarantor's information to the guarantee while adding a guarantiee: >0) Select an adult patron; >1) Insert all information; >2) Click Add guarantiee bouton; >3) Validade Garantor information/Main address/Contact fieldsets filled; > >- Transfer some guarantor's information to the guarantee while creating a new patron >0) Select an adult patron; >1) Insert all information; >2) Add a new adult patron; >3) Click "Set to patron" button; >4) Select the adult patron from 0); >5) Validade Garantor information/Main address/Contact fieldsets filled; > >- Transfer some guarantor's information to the guarantee while adding a guarantiee: >0) Select an adult patron; >1) Insert all information; >2) Click Add guarantiee bouton; >3) Validade Garantor information/Main address/Contact fieldsets filled; > >- Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: >0) Search AdditionalGuarantorField preference; >1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; >2) Select an adult patron; >3) Insert all information; >4) Add a new adult patron; >5) Click "Set to patron" button; >6) Select the adult patron from 0); >7) Validade Garantor information/Main address/Contact fieldsets filled; >8) Validade Garantor additional alternate address/contact filled; > >- Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: >0) Search AdditionalGuarantorField preference; >1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; >3) Select an adult patron; >4) Insert all information; >5) Click Add guarantiee bouton; >6) Validade Garantor information/Main address/Contact fieldsets filled; >7) Validade Garantor additional alternate address/contact filled; >--- > C4/Members/Attributes.pm | 17 +++++++++++++- > C4/Utils/DataTables/Members.pm | 22 ++++++++++++------ > Koha/Schema/Result/Category.pm | 8 +++++++ > admin/categories.pl | 3 +++ > .../atomicupdate/bug_12446-EnableAdultGarantee.sql | 10 ++++++++ > installer/data/mysql/kohastructure.sql | 3 ++- > installer/data/mysql/sysprefs.sql | 4 +++- > .../prog/en/includes/members-toolbar.inc | 2 +- > .../prog/en/modules/admin/categories.tt | 15 ++++++++++++ > .../prog/en/modules/admin/preferences/patrons.pref | 5 ++++ > .../prog/en/modules/members/memberentrygen.tt | 18 +++++---------- > .../prog/en/modules/members/moremember.tt | 17 +++++++++++--- > members/memberentry.pl | 17 ++++++++++---- > members/moremember.pl | 27 +++++++++++----------- > 14 files changed, 125 insertions(+), 43 deletions(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql > >diff --git a/C4/Members/Attributes.pm b/C4/Members/Attributes.pm >index b25a813..b2b0762 100644 >--- a/C4/Members/Attributes.pm >+++ b/C4/Members/Attributes.pm >@@ -34,7 +34,7 @@ BEGIN { > @EXPORT_OK = qw(GetBorrowerAttributes GetBorrowerAttributeValue CheckUniqueness SetBorrowerAttributes > DeleteBorrowerAttribute UpdateBorrowerAttribute > extended_attributes_code_value_arrayref extended_attributes_merge >- SearchIdMatchingAttribute); >+ SearchIdMatchingAttribute get_guarantor_shared_attributes); > %EXPORT_TAGS = ( all => \@EXPORT_OK ); > } > >@@ -357,6 +357,21 @@ sub _sort_by_code { > return $x->{code} cmp $y->{code} || $x->{value} cmp $y->{value}; > } > >+=head2 get_guarantor_shared_attributes >+ >+ $guarantor_attributes = get_guarantor_attributes(); >+ >+ returns an array reference containing attributes to be shared between guarantor and guarantee. >+=cut >+sub get_guarantor_shared_attributes{ >+ my @attributes = qw( streetnumber address address2 city state zipcode country branchcode phone phonepro mobile email emailpro fax ); >+ if( my @additional = split(/\|/, C4::Context->preference("AdditionalGuarantorField")) ){ >+ $_ =~ s/(?:^\s+)|(?:\s+$)//g for (@additional); # Trim whitespaces >+ @attributes = ( @attributes, @additional); >+ } >+ return \@attributes; >+} >+ > =head1 AUTHOR > > Koha Development Team >diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm >index 1ebecd7..49fd1fc 100644 >--- a/C4/Utils/DataTables/Members.pm >+++ b/C4/Utils/DataTables/Members.pm >@@ -4,6 +4,7 @@ use Modern::Perl; > use C4::Branch qw/onlymine/; > use C4::Context; > use C4::Members qw/GetMemberIssuesAndFines/; >+use C4::Members::Attributes qw/get_guarantor_shared_attributes/; > use C4::Utils::DataTables; > use Koha::DateUtils; > >@@ -32,13 +33,20 @@ sub search { > } > > my $dbh = C4::Context->dbh; >- my $select = "SELECT >- borrowers.borrowernumber, borrowers.surname, borrowers.firstname, >- borrowers.streetnumber, borrowers.streettype, borrowers.address, >- borrowers.address2, borrowers.city, borrowers.state, borrowers.zipcode, >- borrowers.country, cardnumber, borrowers.dateexpiry, >- borrowers.borrowernotes, borrowers.branchcode, borrowers.email, >- borrowers.userid, borrowers.dateofbirth, borrowers.categorycode, >+ my @columns = qw( borrowernumber surname firstname streetnumber streettype address address2 city state zipcode country cardnumber dateexpiry borrowernotes branchcode email userid dateofbirth categorycode ); >+ if( my @guarantor_attributes = @{ get_guarantor_shared_attributes() }){ >+ foreach my $item (@guarantor_attributes) { >+ if (! grep {$_ eq $item} @columns) { >+ push @columns, $item; >+ } >+ } >+ }; >+ my $borrowers_columns = ""; >+ foreach my $item (@columns) { >+ $borrowers_columns .= "borrowers." . $item . ", "; >+ } >+ >+ my $select = "SELECT " . $borrowers_columns . " > categories.description AS category_description, categories.category_type, > branches.branchname"; > my $from = "FROM borrowers >diff --git a/Koha/Schema/Result/Category.pm b/Koha/Schema/Result/Category.pm >index 4926587..e5a40a9 100644 >--- a/Koha/Schema/Result/Category.pm >+++ b/Koha/Schema/Result/Category.pm >@@ -109,6 +109,12 @@ __PACKAGE__->table("categories"); > default_value: -1 > is_nullable: 0 > >+=head2 canbeguarantee >+ >+ data_type: 'tinyint' >+ default_value: 0 >+ is_nullable: 0 >+ > =head2 default_privacy > > data_type: 'enum' >@@ -154,6 +160,8 @@ __PACKAGE__->add_columns( > default_value => -1, > is_nullable => 0, > }, >+ "canbeguarantee", >+ { data_type => "tinyint", default_value => 0, is_nullable => 0}, > "default_privacy", > { > data_type => "enum", >diff --git a/admin/categories.pl b/admin/categories.pl >index 1370b58..593886c 100755 >--- a/admin/categories.pl >+++ b/admin/categories.pl >@@ -91,6 +91,7 @@ elsif ( $op eq 'add_validate' ) { > my $category_type = $input->param('category_type'); > my $BlockExpiredPatronOpacActions = $input->param('BlockExpiredPatronOpacActions'); > my $default_privacy = $input->param('default_privacy'); >+ my $canbeguarantee = $input->param('canbeguarantee'); > my @branches = grep { $_ ne q{} } $input->param('branches'); > > my $is_a_modif = $input->param("is_a_modif"); >@@ -112,6 +113,7 @@ elsif ( $op eq 'add_validate' ) { > $category->hidelostitems($hidelostitems); > $category->overduenoticerequired($overduenoticerequired); > $category->category_type($category_type); >+ $category->canbeguarantee($canbeguarantee); > $category->BlockExpiredPatronOpacActions($BlockExpiredPatronOpacActions); > $category->default_privacy($default_privacy); > eval { >@@ -137,6 +139,7 @@ elsif ( $op eq 'add_validate' ) { > hidelostitems => $hidelostitems, > overduenoticerequired => $overduenoticerequired, > category_type => $category_type, >+ canbeguarantee => $canbeguarantee, > BlockExpiredPatronOpacActions => $BlockExpiredPatronOpacActions, > default_privacy => $default_privacy, > }); >diff --git a/installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql b/installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql >new file mode 100644 >index 0000000..55c2b78 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql >@@ -0,0 +1,10 @@ >+-- ******** -- >+-- SYSPREFS -- >+-- ******** -- >+INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) >+VALUES ('AdditionalGuarantorField','',NULL,'Additional fields name to be transfer from guarantor to guarantee.','free'); >+ >+-- ********* -- >+-- STRUCTURE -- >+-- ********* -- >+ALTER TABLE categories ADD COLUMN `canbeguarantee` tinyint(1) NOT NULL default '0'; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 02725fd..1302be2 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -488,7 +488,8 @@ CREATE TABLE `categories` ( -- this table shows information related to Koha patr > `hidelostitems` tinyint(1) NOT NULL default '0', -- are lost items shown to this category (1 for yes, 0 for no) > `category_type` varchar(1) NOT NULL default 'A', -- type of Koha patron (Adult, Child, Professional, Organizational, Statistical, Staff) > `BlockExpiredPatronOpacActions` tinyint(1) NOT NULL default '-1', -- wheither or not a patron of this category can renew books or place holds once their card has expired. 0 means they can, 1 means they cannot, -1 means use syspref BlockExpiredPatronOpacActions >- `default_privacy` ENUM( 'default', 'never', 'forever' ) NOT NULL DEFAULT 'default', -- Default privacy setting for this patron category >+ `default_privacy` ENUM( 'default', 'never', 'forever' ) NOT NULL DEFAULT 'default', -- Default privacy setting for this patron category, >+ `canbeguarantee` tinyint(1) NOT NULL default '0' > PRIMARY KEY (`categorycode`), > UNIQUE KEY `categorycode` (`categorycode`) > ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index aa53139..fdfe94c 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -6,6 +6,8 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('AcquisitionDetails', '1', '', 'Hide/Show acquisition details on the biblio detail page.', 'YesNo'), > ('AcqViewBaskets','user','user|branch|all','Define which baskets a user is allowed to view: his own only, any within his branch or all','Choice'), > ('AcqWarnOnDuplicateInvoice','0','','Warn librarians when they try to create a duplicate invoice','YesNo'), >+('AdditionalGuarantorField','',NULL,'Additional fields name to be transfer from guarantor to guarantee.','free'), >+('AddPatronLists','categorycode','categorycode|category_type','Allow user to choose what list to pick up from when adding patrons','Choice'), > ('AddressFormat','us','','Choose format to display postal addresses', 'Choice'), > ('advancedMARCeditor','0','','If ON, the MARC editor won\'t display field/subfield descriptions','YesNo'), > ('AdvancedSearchLanguages','','','ISO 639-2 codes of languages you wish to see appear as an Advanced search option. Example: eng|fre|ita','Textarea'), >@@ -517,5 +519,5 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('XSLTDetailsDisplay','default','','Enable XSL stylesheet control over details page display on intranet','Free'), > ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over results page display on intranet','Free'), > ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'), >-('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo') >+('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'), > ; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >index 641bbad..7cc0c0e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >@@ -146,7 +146,7 @@ function searchToHold(){ > > [% IF ( CAN_user_borrowers ) %] > [% IF ( adultborrower AND activeBorrowerRelationship ) %] >- Add child >+ Add guarantee > [% END %] > [% IF ( CAN_user_borrowers ) %] > Change password >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >index d4d0130..4112d44 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >@@ -238,6 +238,18 @@ > > Required > >+
  • >+ >+ >+
    • >
  • > > [% END %] >
    • >- [% END %] >- [% UNLESS nocontactfirstname %] >-
  • >+ [% UNLESS nocontactfirstname %] >+
  • > > [% IF ( guarantorid ) %] > [% contactfirstname %] >@@ -1025,6 +1018,7 @@ >
  • > > >+ > [% IF ( patron_attribute.use_dropdown ) %] > (like http://www.wufoo.com/html5/types/7-number.html) for the number-of-copies control. It'll add useful UI and make validation easier. I'd also suggest using the humanMsg API for error messages (like Rancor does), though that's more a matter of opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 23:45:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 22:45:38 +0000 Subject: [Koha-bugs] [Bug 15511] Tabbed fines display on OPAC patron summary page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15511 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46367|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 46374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46374&action=edit [SIGNED-OFF]Bug 15511: Fix tabbed display on OPAC patron account summary page Some variables were not correctly renamed in a previous patch, resulting in the fines tab of the OPAC patron summary page not showing correctly. To test: - Go to the OPAC patron account - Check the display of the Checkouts, Fines and Holds tabs on the summary page - Verify that with the patch, the display is corrected Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 23:45:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 22:45:58 +0000 Subject: [Koha-bugs] [Bug 15511] Tabbed fines display on OPAC patron summary page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15511 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 23:46:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 22:46:52 +0000 Subject: [Koha-bugs] [Bug 15476] Listname not always displayed in shelves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15476 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 6 23:46:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 22:46:55 +0000 Subject: [Koha-bugs] [Bug 15476] Listname not always displayed in shelves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15476 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46371|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 46375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46375&action=edit [PASSED QA] Bug 15476: Listname not always displayed in shelves.pl To reproduce: - In staff client, go to List and click on the name of an existing list. - At the bottom of the screen, you see a title "Add an item to " but no list name. To test: - Apply patch - Verify that listname appears after "Add an item to " Signed-off-by: Hector Castro Works as advertised. Label/legend for listname displayed Ok Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 00:00:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 23:00:00 +0000 Subject: [Koha-bugs] [Bug 15357] Deleting all items on a record with title level holds creates orphaned/ghost holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15357 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 00:00:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 23:00:04 +0000 Subject: [Koha-bugs] [Bug 15357] Deleting all items on a record with title level holds creates orphaned/ghost holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15357 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45665|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 46376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46376&action=edit [PASSED QA] Bug 15357: Display existing holds even if no items exist If all the items have been deleted for a record and holds exist, the holds are not displayed. You are not able to delete the items from the record detail page, but you can from the items page. Test plan: 1 - Place 1 or more title level holds on a record. 2 - Delete each item individually. 3 - Note that you see the number of holds on the record details page With this patch, that holds are accessible via the holds tab. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 00:06:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 23:06:37 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #289 from Jesse Weaver --- Pushed to master, thanks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 00:07:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 23:07:12 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46321|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 00:21:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 23:21:36 +0000 Subject: [Koha-bugs] [Bug 15119] Hide search header text boxes on render In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15119 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #2 from H?ctor Eduardo Castro Avalos --- Hi Jonathan, I have an old computer and always render slowly, but i can't reproduce the issue, or I misunderstand the main problem. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 00:29:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 23:29:29 +0000 Subject: [Koha-bugs] [Bug 15119] Hide search header text boxes on render In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15119 --- Comment #3 from H?ctor Eduardo Castro Avalos --- (In reply to H?ctor Eduardo Castro Avalos from comment #2) > Hi Jonathan, I have an old computer and always render slowly, but i can't > reproduce the issue, or I misunderstand the main problem. > > Regards Ahh... Ok I needed to delete my cookies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 00:32:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 23:32:49 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #37 from Aleisha Amohia --- (In reply to Marcel de Rooy from comment #36) > [1] For more consistency, it would be nice to have the same reasons for an > error listed on opac and intranet. Perhaps from a shared include or so? At > this time the opac is more specific. This is exactly why I suggested using the error messages from Bug 14573 which needed signing off, because the error messages would then be consistent with those on Bug 14574, which has been pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 00:33:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 23:33:00 +0000 Subject: [Koha-bugs] [Bug 15119] Hide search header text boxes on render In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15119 --- Comment #4 from H?ctor Eduardo Castro Avalos --- Or erase my browsing history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 00:33:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 23:33:42 +0000 Subject: [Koha-bugs] [Bug 15119] Hide search header text boxes on render In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15119 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46325|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 46377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46377&action=edit [SIGNED-OFF]Bug 15119: Hide search header text boxes on render When the page rendering is slow or the page is heavy, the tabs in the header shown be not correctly displayed as tabs. This patch suggests to hide them, display the first one, and wait for the JS code to display them nicely. To easily reproduced the ergonomic issue, go on the circulation home page (/cgi-bin/koha/circ/circulation.pl) and search for a patron 'a' or 'd', you will get a lot of result and the page will be slow to be fully displayed. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 00:34:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 23:34:30 +0000 Subject: [Koha-bugs] [Bug 15119] Hide search header text boxes on render In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15119 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 00:53:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 23:53:02 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #4 from Patfrat --- I have also a bug when i try to save via default form cataloguing Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a -> try at /usr/share/perl5/MARC/File/XML.pm line 568. Is it reliable to my timeout post bug on fast cataloguing ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 00:57:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jan 2016 23:57:45 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #5 from Patfrat --- Z39.50/SRU importation is working Manually adding via addbiblio.pl in default or Fast cataloguing not! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 01:27:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 00:27:17 +0000 Subject: [Koha-bugs] [Bug 15512] New: Minor regression caused by Bug 7369 - warn on deleting item not triggered Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512 Bug ID: 15512 Summary: Minor regression caused by Bug 7369 - warn on deleting item not triggered Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl A typo in the code prevents the confirm deletion box form firing when deleting an item using the action menu To recreate: Select Action->Delete on the edit item screen. No warning box and a js error Delete using a link in another field - get a warning box and no error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 01:30:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 00:30:05 +0000 Subject: [Koha-bugs] [Bug 15512] Minor regression caused by Bug 7369 - warn on deleting item not triggered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 01:30:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 00:30:07 +0000 Subject: [Koha-bugs] [Bug 15512] Minor regression caused by Bug 7369 - warn on deleting item not triggered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512 --- Comment #1 from Nick Clemens --- Created attachment 46378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46378&action=edit Bug 15512 - Minor regression caused by Bug 7369 - warn on deleting item not triggered To test: 1 - Delete an item using the Action menu 2 - There is a js error and no warning box 3 - Apply patch 4 - Delete an item using the action menu 5 - You should get a confirmation box as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 01:58:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 00:58:34 +0000 Subject: [Koha-bugs] [Bug 15511] Tabbed fines display on OPAC patron summary page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15511 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #3 from Liz Rea --- a+, it's happy now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 02:05:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 01:05:55 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz Status|Needs Signoff |Failed QA --- Comment #7 from Liz Rea --- With this patch, the verification box doesn't show, and you cannot complete a self registration. You will always get the message "You typed in the wrong characters in the box before submitting. Please try again." I like the idea of this though. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 02:14:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 01:14:31 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #6 from Patfrat --- Found at night ! Missing some perl modules : Test::DBIx::Class and HTTPD::Bench::ApacheBench Perl modules to upgrade : Exception::class Just a module to upgrade but failed behing my proxy : Test::WWW::Mechanize So it seems it was a perl module issue ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 03:18:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 02:18:08 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45230|0 |1 is obsolete| | --- Comment #167 from Liz Rea --- Created attachment 46379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46379&action=edit Bug 8753 - propagating the changes to kohastructure.sql and sysprefs.sql Signed-off-by: Liz Rea Looks good with a new install. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 03:18:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 02:18:34 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 03:57:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 02:57:39 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #11 from Aleisha Amohia --- Is this bug still valid? I can't see the StatisticFields syspref in version 3.23 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 03:59:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 02:59:11 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |liz at catalyst.net.nz --- Comment #25 from Liz Rea --- Hi, I don't see that the atomic update is setting the field for existing categories, with this patch on and the atomic update run, all of the categories (including C and P) are all set to 0 in the database after the update. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 04:20:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 03:20:16 +0000 Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 --- Comment #5 from David Cook --- Comment on attachment 29948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29948 Bug 12586 - Record matching rules - Required match checks doesn't work with MARCXML Review of attachment 29948: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12586&attachment=29948) ----------------------------------------------------------------- I ran into this problem today and this is pretty much exactly what I had in mind for a fix. I've just added a couple comments about things to change. Suggested test plan: 1) Create a bibliographic record with a control number of 123456 2) Create a matching rule with the following: a) Search index "Control-number" b) Score 100 c) Matchpoint components tag 001 d) Match check Source Tag 001 e) Match check Target Tag 001 3) Download the bibliographic from Step 1 as ISO MARC 4) Upload it via Stage Marc for Import, and use the record matching rule from Step 2 Before applying patch: 5) Note that the no records match with your rule Apply the patch: 6) Repeat Step 4 (ie upload using the matching rule from step 2) 7) Note that the record DOES match using the matching rule ::: C4/Matcher.pm @@ +689,5 @@ > + foreach my $matched ( @{$searchresults} ) { > + my $record = C4::Search::new_record_from_zebra( 'biblioserver', $matched ); > + $matches{$record}->{score} += $matchpoint->{'score'}; #Using $record HASH string representation as the key :) > + $matches{$record}->{record} = $record; > + } This block all looks good. @@ +704,1 @@ > keys %matches unless ($self->{'record_type'} eq 'auth'); There's no such record_type as 'auth'... this should be 'authority'. I know it's not related to this bug per se, but may as well change it now. @@ +711,4 @@ > my $record_number; > my $result = C4::Biblio::TransformMarcToKoha(C4::Context->dbh, $target_record, ''); > $record_number = $result->{'biblionumber'}; > + push @results, { 'record_id' => $record_number, 'score' => $matches{$hashkey}->{score}, 'target_record' => $target_record, 'target_biblio' => $result }; Why have you included "target_record" and "target_biblio" here? This seems unnecessary and is an addition to the original code. If it's being used elsewhere, I think that should be separated into a separate patch. @@ +760,4 @@ > } > > sub _passes_required_checks { > + my ($source_record, $target_record, $matchchecks) = @_; Looks good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 04:26:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 03:26:14 +0000 Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29948|0 |1 is obsolete| | --- Comment #6 from David Cook --- Created attachment 46380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46380&action=edit Bug 12586 - Record matching rules - Required match checks doesn't work with MARCXML When trying to Match MARCXML-records from Zebra using Required match checks, C4::Matcher::_passes_required_checks() tries to make a MARC::Record out of MARCXML while thinking it is USMARC. This leads to matching records getting not-matched, and subsequently importing the same records again and again. Very hard to debug or create a test case. I accidentally noticed this while building an automatic acquisitions record overlay mechanism. There are no big errors, simply no match is found, even though a match exists. Also refactored the Matcher a bit to prevent excessive MARC::Record creation for each "Required match check" for each search results. This probably would cripple any reasonably sized batch Matching operations. --------- TEST PLAN --------- 1. Create a Matcher with "Required match checks" in addition to normal checks. 2. Find matches using the C4::Matcher->get_matches() and notice that you don't find matches. 3. Somebody who is actually using this Matcher could help me out here with defining a test plan. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 04:26:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 03:26:20 +0000 Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 --- Comment #7 from David Cook --- Created attachment 46381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46381&action=edit Bug 12586 - Record matching rules - Required match checks doesn't work with MARCXML (follow-up) The follow-up fixes a typo ('auth' to 'authority') and removes 'target_result' and 'target_biblio' which were introduced, seemingly unnecessarily, by the first patch in the set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 04:26:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 03:26:32 +0000 Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 04:27:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 03:27:32 +0000 Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 --- Comment #8 from David Cook --- So I've signed off Olli's original fix, and I added a follow-up to fix a typo in a related bit of code, and to remove some seemingly superfluous data added by Olli's fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 04:32:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 03:32:59 +0000 Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 --- Comment #9 from David Cook --- Comment on attachment 46380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46380 Bug 12586 - Record matching rules - Required match checks doesn't work with MARCXML Review of attachment 46380: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12586&attachment=46380) ----------------------------------------------------------------- ::: C4/Matcher.pm @@ +703,5 @@ > + foreach my $matched ( @{$searchresults} ) { > + my $record = C4::Search::new_record_from_zebra( 'biblioserver', $matched ); > + $matches{$record}->{score} += $matchpoint->{'score'}; #Using $record HASH string representation as the key :) > + $matches{$record}->{record} = $record; > + } Actually, looking at this again, there's no point repeating the loop... it would've made more sense to have 1 foreach loop and done the record_type checks within it... Not a big deal though really -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 04:33:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 03:33:51 +0000 Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 --- Comment #10 from David Cook --- Maybe also worth mentioning that this fix ONLY fixes match checks for bibliographic records... Match checks don't work for authority records. More refactoring could be done to fix that... but that's outside the scope of this bug I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 05:56:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 04:56:54 +0000 Subject: [Koha-bugs] [Bug 15247] mysql_auto_reconnect do not reconnect with UTF8 connection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15247 --- Comment #2 from Pongtawat --- No, I haven't try with 3.22 yet. But look like the new code in 3.22 should solve the problem. I will try. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 09:15:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 08:15:34 +0000 Subject: [Koha-bugs] [Bug 15511] Tabbed fines display on OPAC patron summary page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15511 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 09:15:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 08:15:36 +0000 Subject: [Koha-bugs] [Bug 15511] Tabbed fines display on OPAC patron summary page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15511 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46374|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 46382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46382&action=edit Bug 15511: Fix tabbed display on OPAC patron account summary page Some variables were not correctly renamed in a previous patch, resulting in the fines tab of the OPAC patron summary page not showing correctly. To test: - Go to the OPAC patron account - Check the display of the Checkouts, Fines and Holds tabs on the summary page - Verify that with the patch, the display is corrected Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 09:30:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 08:30:15 +0000 Subject: [Koha-bugs] [Bug 15469] Authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 09:30:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 08:30:18 +0000 Subject: [Koha-bugs] [Bug 15469] Authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 --- Comment #6 from Jonathan Druart --- Created attachment 46383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46383&action=edit Bug 15469: Same fix for the "entire record" tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 09:34:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 08:34:26 +0000 Subject: [Koha-bugs] [Bug 15477] Error handling on editing item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46336|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 46384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46384&action=edit Bug 15477: (follow-up) Bug 14100: Better errors handling On bug 14100, the patch "Better errors handling" introduced an ... error. The user always get "An error occurred when updating this translation" although it has been updated in DB. Test plan: Edit translations for an item type: you should not get an error when everything went fine. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 09:34:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 08:34:50 +0000 Subject: [Koha-bugs] [Bug 15477] Error handling on editing item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15487 --- Comment #9 from Jonathan Druart --- Rebased on top of bug 15487 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15487 [Bug 15487] Encoding problem with item type translations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 09:34:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 08:34:50 +0000 Subject: [Koha-bugs] [Bug 15487] Encoding problem with item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15477 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15477 [Bug 15477] Error handling on editing item type translations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 09:45:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 08:45:36 +0000 Subject: [Koha-bugs] [Bug 15119] Hide search header text boxes on render In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15119 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #6 from Jonathan Druart --- Thanks for testing H?ctor. Switch back to Needs Signoff, I would like to get one from Christopher. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 09:47:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 08:47:37 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #7 from Jonathan Druart --- (In reply to Patfrat from comment #6) > Found at night ! > > Missing some perl modules : Test::DBIx::Class and HTTPD::Bench::ApacheBench > Perl modules to upgrade : Exception::class > > Just a module to upgrade but failed behing my proxy : Test::WWW::Mechanize > > So it seems it was a perl module issue ! Did you note the versions of Exception::class before and after the upgrade? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 09:54:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 08:54:24 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #8 from Patfrat --- Exception::Class was v1.37 and upgraded to v1.39 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 10:41:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 09:41:16 +0000 Subject: [Koha-bugs] [Bug 15513] New: Hide OpacHiddenItems items from cart Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15513 Bug ID: 15513 Summary: Hide OpacHiddenItems items from cart Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Items hidden with the OpacHiddenItems system preference display in the cart view. It would be nice if they were hidden there as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 10:45:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 09:45:29 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #104 from Jonathan Druart --- (In reply to Katrin Fischer from comment #102) Everything has been fixed in the following new commits: commit 13faef4d28df0a70c2c89ab4317ebc2882fc3704 Bug 13618: Fix for system preference description If a syspref description contains html tag, do not display them commit 2879a9976549f84c9520d5778a45d8348845d7b4 Bug 13618: Do not display   and html tags in item fields content Note that there might be other occurrences to fix! commit d8547698a47e83cdb7d321391cadddd4f26e5f85 Bug 13618: Do not display html tags in patron's notices commit 58e62b53eda1110003d6c0b0cebc983c62bf2f46 Bug 13618: Fix for debarredcomment and patron messages At the OPAC and intranet. commit 0aefdddb394db1fab7287970ab0b80f3a92479e8 Bug 13618: (follow-up) Specific for other prefs follow-up for SlipCSS Remote branch updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 10:46:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 09:46:02 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #105 from Jonathan Druart --- Katrin, feel free to ask to new signoffs on these patches if you think it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 10:48:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 09:48:13 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #9 from Jonathan Druart --- It's the only one used from Koha, the others are for the tests. But it seems weird that your problem came from this module. Anyway, can we mark this bug as fixed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 10:49:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 09:49:54 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #10 from Jonathan Druart --- (In reply to Patfrat from comment #4) > I have also a bug when i try to save via default form cataloguing > Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a > -> try at /usr/share/perl5/MARC/File/XML.pm line 568. This generally happens when you are using MARC21 records with the syspref marcflavour set to UNIMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 10:52:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 09:52:44 +0000 Subject: [Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46341|0 |1 is obsolete| | --- Comment #2 from Koha Team Lyon 3 --- Created attachment 46385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46385&action=edit Bug 15501 - Planned Irregularities are deleted when modifying subscription Test plan : Before applying patch 1) Go to serials Home page 2) Choose an existing subscription (from a daily, weekly or monthly serial) and edit 3) Go to second page and launch the prediction pattern test 4) Check some checkboxes 5) Save. 6) Edit again and add a note on first page 7) Go to next page and Save : you can see there had been no alert. 8) Edit again, go to next page and launch prediction pattern test : You see that the checkboxes you had selected are not any more checked. Now apply the patch and redo all steps 2 to 6. 7) when you click on Save button, an alert warn you that you must launch the prediciton test before. Do it and save. 8) When you edit again and launch again the prediction test, you can see that the checkboxes selected are still checked. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 10:53:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 09:53:39 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 10:54:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 09:54:20 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 10:54:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 09:54:45 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #11 from Patfrat --- Thanks for all your replies ! I am happy to have Koha working again ! You can mark this bug as fixed ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 11:04:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 10:04:02 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #6) > Hi Jonathan, this doesn't appear to work for me. I changed the english and > the default description of my BK itemtype to "Z" - but it still appears > first in list when adding a new item? Cannot recreate that. I have changed my "CD" description to "Z", then go to /cataloguing/additem.pl?op=edititem&biblionumber=1986&itemnumber=2990#edititem I have my 995$r set as r type de document et support mat?riel Tab:10, | Koha field: items.itype, Not repeatable, Mandatory, | Auth value:itemtypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 11:05:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 10:05:04 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 11:27:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 10:27:01 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #8 from Katrin Fischer --- Hm, I will try and test again. Not sure what's going wrong. Another last idea - mine was not mandatory. I think that changes the look of the drop down a bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 11:33:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 10:33:18 +0000 Subject: [Koha-bugs] [Bug 15445] DateUtils.t fails on Jenkins due to server sluggishness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #6 from Jonathan Druart --- Tomas, do you know if the nodes are monitored? It would be good to know if the server is overloaded when the test fails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 11:42:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 10:42:45 +0000 Subject: [Koha-bugs] [Bug 15478] Checksum mismatch when regenerating schema In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 11:42:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 10:42:48 +0000 Subject: [Koha-bugs] [Bug 15478] Checksum mismatch when regenerating schema In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46317|0 |1 is obsolete| | Attachment #46320|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 46386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46386&action=edit Bug 15478 - Checksum mismatch when regenerating schema When regenerating the db schema on master, the script will error out with a checksum mismatch on Borrower.pm, and also DeletedBorrower.pm Test Plan: 1) Check out master 2) Run ./misc/devel/update_dbix_class_files.pl 3) Note the error 4) Apply this patch 5) Re-reun ./misc/devel/update_dbix_class_files.pl 6) Note there is no error Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 11:42:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 10:42:54 +0000 Subject: [Koha-bugs] [Bug 15478] Checksum mismatch when regenerating schema In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 --- Comment #7 from Jonathan Druart --- Created attachment 46387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46387&action=edit Bug 15478 - Update the remaining schema files that do not match the db schema Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 11:44:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 10:44:00 +0000 Subject: [Koha-bugs] [Bug 15475] export_format.profile should be a unique key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15475 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Jonathan Druart --- With bug 15498, this is not needed anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 11:44:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 10:44:25 +0000 Subject: [Koha-bugs] [Bug 15475] export_format.profile should be a unique key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15475 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15498 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 11:44:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 10:44:25 +0000 Subject: [Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15475 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 12:01:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 11:01:08 +0000 Subject: [Koha-bugs] [Bug 15514] New: New professional cataloguing editor does not handle repeatable fields correctly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15514 Bug ID: 15514 Summary: New professional cataloguing editor does not handle repeatable fields correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Depends on: 11559 I get a JS error on saving a record (not modified, just edited an existing one): TypeError: nonRepeatableSubfields[field.tagnumber(...)] is undefined ...d[0] ] != null && nonRepeatableSubfields[ field.tagnumber() ][ subfield[0] ] ) koha-backend.js (line 229, col 89) In koha-backend.js 227 if ( seenSubfields[ subfield[0] ] != null && nonRepeatableSubfields[ field.tagnumber() ][ subfield[0] ] ) { field.tagnumber() returns 210 The field 210 is not marked as repeatable in my default framework Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 [Bug 11559] Professional cataloger's interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 12:01:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 11:01:08 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15514 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15514 [Bug 15514] New professional cataloguing editor does not handle repeatable fields correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 12:09:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 11:09:02 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart --- Since I am the author of bug 10855, it would be better to see someone else QA this new enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 12:16:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 11:16:37 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- There are 2 more left, is it expected? koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 12:18:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 11:18:37 +0000 Subject: [Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- There are patches in the queue waiting for SO and QA. I would prefer to wait before pushing this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 12:41:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 11:41:46 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #38 from Jonathan Druart --- Alex, Could you please: 1/ move the CalculateAge to a js file (to make it reusable) 2/ do not display "Age:" if the calculation fails 3/ Remove the checkdate param, it is not really needed. You should use Date_from_syspref defined in calendar.inc instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:06:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:06:14 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #36 from Jonathan Druart --- Can we get tests for the age restriction check please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:06:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:06:23 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14695 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:06:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:06:23 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11999 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:07:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:07:55 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:14:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:14:35 +0000 Subject: [Koha-bugs] [Bug 15515] New: Date of Birth gadget Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15515 Bug ID: 15515 Summary: Date of Birth gadget Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fiona.borthwick at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When registering a new patron the DOB gadget only allows you to scroll back 10 years. If you select the oldest year you are presented with another range of 10 years but never more than 10 years at a time. The date of birth can obviously be manually typed in but it would be nice to have this fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:14:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:14:48 +0000 Subject: [Koha-bugs] [Bug 15515] Date of Birth gadget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15515 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:17:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:17:04 +0000 Subject: [Koha-bugs] [Bug 15481] Remove dead code in datatables.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15481 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Julian, IIRC, these functions were originally used by an alternative patch of bug 5342, never pushed (see attachment 8910, Followup : DataTables server-side processing). Are there no plan to rebase these changes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:18:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:18:51 +0000 Subject: [Koha-bugs] [Bug 15512] Minor regression caused by Bug 7369 - warn on deleting item not triggered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |Needs Signoff --- Comment #2 from Jonathan Druart --- This looks ready to be signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:18:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:18:59 +0000 Subject: [Koha-bugs] [Bug 15512] Minor regression caused by Bug 7369 - warn on deleting item not triggered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:23:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:23:14 +0000 Subject: [Koha-bugs] [Bug 15328] Z39 replaces authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15328 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 15360 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:23:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:23:14 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #6 from Jonathan Druart --- *** Bug 15328 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:24:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:24:50 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:37:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:37:42 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:37:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:37:45 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 --- Comment #1 from Jonathan Druart --- Created attachment 46388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46388&action=edit Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Enable only 1 language at the OPAC and the intranet. Edit an item type and confirm that the link "translate into..." is not displayed. Enable 1+ languages at the intranet and 1 at the opac, confirm that the link is displayed. Enable 1 language at the intranet and 1+ at the opac, confirm that the link is displayed. Enable 1+ language at the intranet and 1+ at the opac, confirm that the link is displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:37:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:37:54 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14828 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 [Bug 14828] Move the item types related code to Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:37:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:37:54 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15306 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 [Bug 15306] Don't show translate link for item types if only one language is installed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:38:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:38:40 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 --- Comment #2 from Jonathan Druart --- Another version of the patch could be provided to apply on top of 3.22. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:44:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:44:36 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Same here, I cannot recreate on master. Heather, please provide more details if it still happens. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:46:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:46:59 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master Status|RESOLVED |REOPENED Severity|minor |normal Resolution|INVALID |--- --- Comment #4 from Jonathan Druart --- Ok got it! It happens when you want to delete a report which is not displayed initially (pagination). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:53:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:53:51 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:53:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:53:54 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 --- Comment #5 from Jonathan Druart --- Created attachment 46389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46389&action=edit Bug 15299: Ask for confirmation when deleting a report from second page Some link are hidden when loading the page, by DataTables, we need to use the delegate jQuery method to attach a handler to the click event for all delete links (the ones existing when loading the page, and the ones displayed in the future). Test plan: Have more than 20 reports defined Go on the report list view, then change the number of elements displayed, click "action>delete". You should get a warn. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 13:54:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 12:54:04 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 14:03:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 13:03:57 +0000 Subject: [Koha-bugs] [Bug 15477] Error handling on editing item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15477 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46384|0 |1 is obsolete| | --- Comment #10 from Marc V?ron --- Created attachment 46390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46390&action=edit Bug 15477: (follow-up) Bug 14100: Better errors handling On bug 14100, the patch "Better errors handling" introduced an ... error. The user always get "An error occurred when updating this translation" although it has been updated in DB. Test plan: Edit translations for an item type: you should not get an error when everything went fine. Tested on top of 15487, error message does no longer appear. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 14:24:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 13:24:35 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- I'm not sure about taking enabled languages as a trigger for displaying the translation link. Use case for a country with multiple languages: - I have an installation with let's say English, German, French, Italian - English is and German are enabled. - Now I want to prepare my installation for French and / or Italian. I do all the translation work, but do not yet want to enbale the languages until I'm finished, e.g. because everithing has to be reviewed befor the new language is officially launched. With this patch, the translations would be have to be already visible while translating. Alternative: Use the _installed_ language as a trigger. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 14:31:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 13:31:49 +0000 Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 14:32:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 13:32:34 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #12 from Marc V?ron --- (In reply to Aleisha Amohia from comment #11) > Is this bug still valid? I can't see the StatisticFields syspref in version > 3.23 Sorry, that was a typo in the first comment and the test plan. It is StatisticsFields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 14:36:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 13:36:11 +0000 Subject: [Koha-bugs] [Bug 14902] Add qualifier menu to staff side "Search the Catalog" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14902 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 14:41:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 13:41:48 +0000 Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 14:50:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 13:50:54 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 --- Comment #4 from Jonathan Druart --- Created attachment 46391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46391&action=edit [ALTERNATIVE-PATCH] Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 14:53:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 13:53:46 +0000 Subject: [Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Is it still ready to be signed off? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 14:56:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 13:56:59 +0000 Subject: [Koha-bugs] [Bug 15516] New: RFC: Allow to reserve first available item from a group of titles Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Bug ID: 15516 Summary: RFC: Allow to reserve first available item from a group of titles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: new feature Priority: P5 - low Component: Hold requests Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 14:57:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 13:57:27 +0000 Subject: [Koha-bugs] [Bug 15516] RFC: Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #1 from Julian Maurice --- Created attachment 46392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46392&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is a kind of "RFC-patch" as I'm not sure of how to implement that feature. It's obviously not finished, as I would like some feedback before going further. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Check in an item of one of the reserved biblios and confirm the hold 7. The hold status is changed to Waiting, and all other holds are deleted. Comments: - A column is added to the reserves table (reserve_group_id) to group the reserves that belong together, and an additional table (reserve_group) with a single column is used to generate an auto increment ID. I feel that something better can be done... - I don't know how to indicates in the interface that two or more reserves are only one request in reality. - I'm bad at naming things, and "reserve_group" should probably be something else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 14:57:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 13:57:41 +0000 Subject: [Koha-bugs] [Bug 15516] RFC: Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 14:58:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 13:58:09 +0000 Subject: [Koha-bugs] [Bug 14250] can generate discharge for patron with fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |8007 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 [Bug 8007] Discharge management -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 14:58:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 13:58:09 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14250 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 [Bug 14250] can generate discharge for patron with fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 14:58:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 13:58:14 +0000 Subject: [Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 14:59:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 13:59:38 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off Keywords|rel_3_22_candidate | --- Comment #8 from Jonathan Druart --- Still waiting for QAM's opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:00:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:00:29 +0000 Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in patron creation from In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ed.veal at bywatersolutions.co | |m --- Comment #13 from Jonathan Druart --- *** Bug 14236 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:00:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:00:29 +0000 Subject: [Koha-bugs] [Bug 14236] Firefox usr/pwd storing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14236 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 14599 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:03:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:03:15 +0000 Subject: [Koha-bugs] [Bug 14164] Change in due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14164 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:11:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:11:43 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #12 from Julian Maurice --- Created attachment 46393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46393&action=edit Bug 15358: Build result preview after page load -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:12:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:12:38 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45767|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:13:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:13:07 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:16:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:16:59 +0000 Subject: [Koha-bugs] [Bug 14082] can't edit vendor notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14082 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12111 --- Comment #2 from Jonathan Druart --- Nicole, it's a "feature", see: commit fda9976cda1669eb12feaeee9e900c5eb962e9ea Bug 12111: Improving templates regarding order notes """ It also suppresses the ability to edit order "vendor note" in reception, as the note for vendor is not made to be changed after the document is received. """ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:16:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:16:59 +0000 Subject: [Koha-bugs] [Bug 12111] Improving templates regarding order notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14082 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:26:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:26:21 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 --- Comment #3 from Sally Healey --- This issue doesn't occur often, but when it does, the 'local use' response in particular is highly problematic. As a temporary measure, even a prompt for the staff member to investigate the item would be preferable. Ideally, a full solution would be as Kyle has suggested - the hold should change status from Waiting to In Transit, and a transfer to the collection branch should occur. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:29:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:29:53 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com, | |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:38:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:38:09 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46388|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 46394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46394&action=edit Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. Works as expected. Tested with English only installed. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:38:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:38:25 +0000 Subject: [Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:39:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:39:56 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 --- Comment #6 from Marc V?ron --- @Owen: What do you think, is the alternative patch OK for you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:43:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:43:39 +0000 Subject: [Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 --- Comment #1 from Julian Maurice --- Created attachment 46395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46395&action=edit Bug 14816: Fix multiple selection in item search Send each selected value as a separate parameter. Otherwise DataTables (or jQuery ?) joins all values with a comma -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:43:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:43:49 +0000 Subject: [Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 15:54:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 14:54:43 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #13 from Ian Palko --- I don't have a git setup yet, but a 3.22.0 package setup on a test server, so for what it's worth ... I have not updated yet to 3.22.1, but will do so tomorrow morning, so can try to test it then on the latest packages. I've manually edited the relevant files in accordance with Julian's patches here. It does seem to fix things back to merging, but probably more thorough test are certainly in order from those who actually are competent here. I'm just a librarian and armchair hacker ... If all works tomorrow when I test on the latest packages, I'll signoff. If anyone is able to test before then, I'm more than happy to let them do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:05:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:05:16 +0000 Subject: [Koha-bugs] [Bug 15478] Checksum mismatch when regenerating schema In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Kyle M Hall --- Considering the triviality of the issue, I think we can jump this to Passed QA. Please knock it back down if you disagree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:05:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:05:37 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46245|0 |1 is obsolete| | --- Comment #39 from Alex Arnaud --- Created attachment 46396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46396&action=edit Bug 15206 - Show patron's age under date of birth in memberentry.pl Test plan: Create or edit a patron (members/memberentry.pl), enter a date of birth (for a new patron), patron'a age should be shown under -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:08:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:08:54 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #40 from Alex Arnaud --- (In reply to Jonathan Druart from comment #38) > Alex, > Could you please: > 1/ move the CalculateAge to a js file (to make it reusable) > 2/ do not display "Age:" if the calculation fails > 3/ Remove the checkdate param, it is not really needed. You should use > Date_from_syspref defined in calendar.inc instead I don't need Date_from_syspref since i use datepicker( 'getDate' ) from datepicker component to get the correct format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:11:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:11:26 +0000 Subject: [Koha-bugs] [Bug 12832] Basketgroup printing doesn't support no latin chars In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12832 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org --- Comment #3 from Dobrica Pavlinusic --- I don't think that it's enough to just add utf-8 encoding to $pdf->corefont. Just as with labels, we need to use true type fonts here to support all available utf-8 characters (otherwise western utf-8 characters work, but Croatian for example don't). Replacing $pdf->corefont("Times", -encoding => "utf8") with something like $pdf->ttfont('/usr/share/fonts/truetype/ttf-dejavu/DejaVuSerif.ttf') will nicely fix this problem (but also somewhat break tables which are created using PDF::Table, I will have to investigate this a bit more). But, now I'm wondering if we should use same mapping from koha-conf.xml which we use for labels (if available)? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:13:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:13:27 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45049|0 |1 is obsolete| | --- Comment #51 from Julian Maurice --- Created attachment 46397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46397&action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes Indentation and whitespace fixes Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:13:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:13:31 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #52 from Julian Maurice --- Created attachment 46398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46398&action=edit Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes - Returns the list of modified biblio records - Retrieve MARC records from DB if not given in parameters - Delete source authority if source and destination records are different Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:13:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:13:35 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45050|0 |1 is obsolete| | --- Comment #53 from Julian Maurice --- Created attachment 46399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46399&action=edit Bug 11700: Avoid to try to delete the authority twice Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:13:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:13:39 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45051|0 |1 is obsolete| | --- Comment #54 from Julian Maurice --- Created attachment 46400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46400&action=edit Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:13:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:13:43 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45052|0 |1 is obsolete| | --- Comment #55 from Julian Maurice --- Created attachment 46401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46401&action=edit Bug 11700: Add description to unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:13:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:13:47 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45053|0 |1 is obsolete| | --- Comment #56 from Julian Maurice --- Created attachment 46402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46402&action=edit Bug 11700 [QA Followup] - Tidy merge a bit, fix warning triggered during unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:14:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:14:58 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #57 from Julian Maurice --- All patches rebased on master. Resetting status to Signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:17:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:17:39 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #14 from Katrin Fischer --- Ian, your testing is much appreciated! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:22:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:22:33 +0000 Subject: [Koha-bugs] [Bug 15517] New: deleted tables differ again Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Bug ID: 15517 Summary: deleted tables differ again Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The structure of borrowers and deletedborrowers differs again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:28:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:28:39 +0000 Subject: [Koha-bugs] [Bug 15517] deleted tables differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:28:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:28:42 +0000 Subject: [Koha-bugs] [Bug 15517] deleted tables differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 --- Comment #1 from Jonathan Druart --- Created attachment 46403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46403&action=edit Bug 15517: Resync borrowers and deletedborrowers tables The 2 columns password and userid are not sync and could cause errors when deleting patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:28:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:28:46 +0000 Subject: [Koha-bugs] [Bug 15517] deleted tables differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 --- Comment #2 from Jonathan Druart --- Created attachment 46404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46404&action=edit Bug 15517: deleted* tables won't never differ anymore! These tests will ensure that the 4 deleted* tables won't never differ anymore. Test plan: 0/ Do not execute the update DB entry 1/ prove t/db_dependent/db_structure.t should fail 2/ Execute the update DB entry and update the schema with misc/devel/update_dbix_class_files.pl 3/ prove t/db_dependent/db_structure.t should now be happy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:29:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:29:14 +0000 Subject: [Koha-bugs] [Bug 15478] Checksum mismatch when regenerating schema In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15517 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 [Bug 15517] deleted tables differ again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:29:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:29:14 +0000 Subject: [Koha-bugs] [Bug 15517] deleted tables differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15478 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 [Bug 15478] Checksum mismatch when regenerating schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:29:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:29:37 +0000 Subject: [Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015 --- Comment #24 from Kyle M Hall --- Thanks for the explanation Marc! Indeed I did misunderstand the intention of the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:29:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:29:46 +0000 Subject: [Koha-bugs] [Bug 14067] 500 error when deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14067 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15517 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart --- (In reply to BUWM from comment #9) > Created attachment 43437 [details] > error when deleting patron > > We also had problem with deleting patrons. > `borrowers` . `password` was VARCHAR(60), while > `deletedborrowers` . `password` was VARCHAR(30). Setting the latter to 60 > resolved this issue in our case (Koha 3.20.01) This will be fixed by bug 15517. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:29:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:29:46 +0000 Subject: [Koha-bugs] [Bug 15517] deleted tables differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14067 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:31:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:31:41 +0000 Subject: [Koha-bugs] [Bug 15239] Add multiple items fail on barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14110 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:31:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:31:41 +0000 Subject: [Koha-bugs] [Bug 14110] Silence warnings t/00-load.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15239 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:35:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:35:27 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #15 from Jonathan Druart --- (In reply to Ian Palko from comment #13) > I've manually edited the relevant files in accordance with Julian's patches > here. Please, help yourself, don't do that :) git is your friend and can help you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:40:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:40:47 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #41 from Jonathan Druart --- With "to make it reusable", I meant "Don't hardcode stuff in it"... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:41:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:41:55 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #42 from Jonathan Druart --- And don't call CheckDate, it's obsolete. Date_from_syspref does that for any date format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:48:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:48:16 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #8 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > This works as described. > > With the proposed solution the values of the hidden patron attribute are > visible in the HTML source of the page. I am not super happy about this, as > it seems like a potential privacy problem to me. I can add a syspref to choose between privacy and data lost :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:52:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:52:32 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #43 from Alex Arnaud --- (In reply to Jonathan Druart from comment #41) > With "to make it reusable", I meant "Don't hardcode stuff in it"... oops... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:57:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:57:53 +0000 Subject: [Koha-bugs] [Bug 14555] Warns in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555 --- Comment #10 from Jonathan Druart --- I don't get the warn in the logs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 16:58:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 15:58:44 +0000 Subject: [Koha-bugs] [Bug 14555] Warns in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555 --- Comment #11 from Jonathan Druart --- Ok got it, the test plan is incomplete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 17:01:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 16:01:36 +0000 Subject: [Koha-bugs] [Bug 14555] Warns in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 17:01:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 16:01:39 +0000 Subject: [Koha-bugs] [Bug 14555] Warns in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46294|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 46405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46405&action=edit Bug 14555: Warns in opac-search.pl Avoid use of uninitialized value in split == Test plan == 1. Go to opac advanced search 2. Click "Search" without any search query 3. Log file will show "Use of uninitialized value in split at ..." 4. Apply this patch 5. Repeat step 1 and 2 6. Log file should no longer show "Use of uninitialized value in split at ..." Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Aleisha Signed-off-by: Jonathan Druart At step 2 you have to check a criteria -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 17:03:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 16:03:15 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #44 from Alex Arnaud --- (In reply to Jonathan Druart from comment #41) > With "to make it reusable", I meant "Don't hardcode stuff in it"... This means i could not reset the description (div .hint) under the datepicker with date format when datepicker is emptied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 17:37:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 16:37:03 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #13 from Kyle M Hall --- I will try to find some time to run some tests. Here is what I will do: 1) Revert 13432 on master 2) Set up a script that continuously makes sip2 calls via sip_cli_emulator.pl 3) Let that run for a long time 4) Note whether memory usage increases dramatically 5) Apply this patch 6) Repeat steps 2-4 6) Apply bug 15006 7) Repeat steps 2-4 If everything checks out, we should move ahead with this. Colin, does that seem like a reasonable test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 17:41:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 16:41:34 +0000 Subject: [Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|In Discussion |RESOLVED --- Comment #14 from Kyle M Hall --- (In reply to Martin Renvoize from comment #13) > OK, So, you're always calling ->all on he dbic resultset, even when you may > only actually want the ->first result :(. Bad mojo, this is a big memory > leak in my opinion. > > Yes calling ->all is a good idea when you know you want the full set (or you > know the full set will always be sufficiently small that your not worried > about the memory overhead, but calling it for all requests is just asking > for trouble in my opinion. > > We should be encouraging thought behind these calls and good practice. Not > coding around other coders deficiencies.. that's what QA is for, spotting > such performance mistakes during QA time. > > All in all, this gets a definitive thumbs down from me Good point. Let's just close this it out, it seemed like a good idea at first, but I think you are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 17:41:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 16:41:35 +0000 Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Bug 13726 depends on bug 13719, which changed state. Bug 13719 Summary: Make Koha::Objects store list of resultant objects on an as needed basis http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 18:18:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 17:18:55 +0000 Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 18:45:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 17:45:29 +0000 Subject: [Koha-bugs] [Bug 15508] Select which library a staff user can login as In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15508 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 18:49:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 17:49:13 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 19:28:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 18:28:05 +0000 Subject: [Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher --- Pushed to master - Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 19:47:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 18:47:32 +0000 Subject: [Koha-bugs] [Bug 15493] Export records using a CSV profile does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15493 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher --- Pushed to Master - Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 19:49:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 18:49:45 +0000 Subject: [Koha-bugs] [Bug 15478] Checksum mismatch when regenerating schema In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #9 from Brendan Gallagher --- Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 19:58:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 18:58:08 +0000 Subject: [Koha-bugs] [Bug 15453] Cannot download a list in the staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15453 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 20:02:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 19:02:45 +0000 Subject: [Koha-bugs] [Bug 15511] Tabbed fines display on OPAC patron summary page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15511 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Pushed to master - Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 20:17:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 19:17:16 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 20:17:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 19:17:22 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 Chris Rohde changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crohde at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 20:20:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 19:20:48 +0000 Subject: [Koha-bugs] [Bug 15467] AuthoritiesMarc.t is failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15467 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Pushed to Master - thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 20:25:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 19:25:20 +0000 Subject: [Koha-bugs] [Bug 15466] Suggestions.t is failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15466 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 20:32:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 19:32:31 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 schorr at uthscsa.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |schorr at uthscsa.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 20:35:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 19:35:12 +0000 Subject: [Koha-bugs] [Bug 15412] Dropdowns in suspend holds date selector do not function in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15412 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher --- Pushed to master - Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 20:54:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 19:54:33 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #11 from Heather Braum --- Jonathan, I'm checking with ByWater to see if our rather large test system (running 3.22.1) database could somehow be used to help test the patch as you suggested you needed a large db to do it. I'll let you know what I find out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 20:59:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 19:59:47 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 21:04:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 20:04:16 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 21:04:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 20:04:19 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45524|0 |1 is obsolete| | --- Comment #12 from Chris Cormack --- Created attachment 46406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46406&action=edit Bug 15240: Do not process issues with a date due later than today There is no need to do this job in Perl, MySQL could do it instead. The idea is to only retrieve the issues info which could be overdued. To test: 1/ Run the script 2/ Apply the patch 3/ Run the script again, notice the exact same results but execution time is faster Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 21:32:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 20:32:42 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #16 from Josef Moravec --- I just tested the patch, the records and result are displayed as they should. But after merging, the resulted record has all the data from both records! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 21:33:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 20:33:29 +0000 Subject: [Koha-bugs] [Bug 15397] Pay selected does not works as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15397 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Priority|P5 - low |P4 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 21:36:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 20:36:28 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #9 from Liz Rea --- I didn't go after the intranet here, but I didn't specify so I'll add a followup. :) Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 21:36:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 20:36:50 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #10 from Liz Rea --- Can we get these ones through first though? I'll make a different bug for the intranet detail. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 21:40:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 20:40:42 +0000 Subject: [Koha-bugs] [Bug 15518] New: Intranet detail needs ssl sources for Amazon images Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15518 Bug ID: 15518 Summary: Intranet detail needs ssl sources for Amazon images Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Discovered as part of bug 14571, the intranet detail page needs to have the amazon image sources converted to https. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 21:40:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 20:40:42 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15518 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 22:01:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 21:01:35 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Aleisha Amohia --- fatal: sha1 information is lacking or useless (about.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12721 - Syspref StatisticsFields: Warning on About page and text change in System preferences Setting to Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 22:04:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 21:04:57 +0000 Subject: [Koha-bugs] [Bug 11324] "Delete All Items" fails except on "Normal Tab" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11324 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #4 from Aleisha Amohia --- I could not reproduce this bug in version 3.23. Must have been fixed? Can someone else test if this bug is still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 22:15:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 21:15:59 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #9 from Katrin Fischer --- I am not sure there is a valid answer to this. Would it be possible to teach it not to update/change attributes not sent with the form at all? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 22:17:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 21:17:33 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 22:18:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 21:18:13 +0000 Subject: [Koha-bugs] [Bug 15481] Remove dead code in datatables.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15481 --- Comment #4 from Julian Maurice --- I'm not sure if there are plans to rebase this patch, but in this case I'm sure it could be rewritten differently (i.e. better) without these functions. And let's face it, replace_html is such a bad name for a JS function :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 22:32:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 21:32:21 +0000 Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 22:39:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 21:39:05 +0000 Subject: [Koha-bugs] [Bug 15519] New: Warns when creating a basket Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15519 Bug ID: 15519 Summary: Warns when creating a basket Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: 1) Go to acquisitions 2) Go to a vendor 3) Create a new basket and click save 4) See warn in intranet error log: basket.pl: Argument "" isn't numeric in numeric le (<=) at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 207. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 22:39:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 21:39:45 +0000 Subject: [Koha-bugs] [Bug 15520] New: Add more granular permission for only editing own library's circ rules Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Bug ID: 15520 Summary: Add more granular permission for only editing own library's circ rules Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, nicole at bywatersolutions.com In large library systems, it can be inconvenient to allow a staff member to edit circulation rules for all libraries. A permission that allows editing only circ rules for the staff member's home library would help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 22:44:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 21:44:04 +0000 Subject: [Koha-bugs] [Bug 15519] Warns when creating a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15519 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 22:44:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 21:44:06 +0000 Subject: [Koha-bugs] [Bug 15519] Warns when creating a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15519 --- Comment #1 from Aleisha Amohia --- Created attachment 46407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46407&action=edit Bug 15519: Warns when creating a basket To test: 1) Reproduce warn following steps above 2) Apply patch 3) Create a new basket and click Save. Do not add any items 4) Notice warn is gone 5) Click 'Delete this basket' and confirm that the validation message reads: "Are you sure you want to delete this basket?" Click cancel. 6) Add an order to the basket, then click 'Delete this basket'. Confirm the validation message gives more information and more delete options. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 22:46:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 21:46:40 +0000 Subject: [Koha-bugs] [Bug 15469] Authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- Almost there - just one small inconsistency - the last tab shows the 'chronological term' preselected, while all others show 'default'. Can you take a quick look if that's an easy fix? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 22:49:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 21:49:13 +0000 Subject: [Koha-bugs] [Bug 15521] New: Make circulation rules backend more granular Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 Bug ID: 15521 Summary: Make circulation rules backend more granular Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, nicole at bywatersolutions.com To allow for more flexible specification of policy, a new table structure will be created. Instead of a single row per branchcode/categorycode/itemtype with columns for each policy value, we?ll have a row for each rule. This row would contain the relevant branchcode/categorycode/itemtype and the name and contents of the rule. The first iteration of this will rewrite GetIssuingRule to fetch all of these rules behind the scenes and return all of the rules for a given situation. The second iteration will identify all code calling the subroutine that fetches circulation rules, and instead of calling GetIssuingRule will fetch only the circulation rules it needs. Once this is complete, the subroutine GetIssuingRule will be removed altogether. To migrate data to this new system, we will create a row for each column of each row of the current schema. That is, each row in issuingrules will become ~20 rows in the new table (for loanlength, fine, etc.). This is less than ideal, but we will develop a new frontend to make this structure more manageable. (See http://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend_Revamp_RFC#Backend for more information.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 22:54:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 21:54:18 +0000 Subject: [Koha-bugs] [Bug 15221] SIP server always sets the alert flag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15522 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 [Bug 15522] New interface for revamped circulation rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 22:54:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 21:54:18 +0000 Subject: [Koha-bugs] [Bug 15522] New: New interface for revamped circulation rules Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Bug ID: 15522 Summary: New interface for revamped circulation rules Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, nicole at bywatersolutions.com Depends on: 15221 This interface would allow editing individual rules for each branch/category/itemtype, and be reorganized to clearly show the specificity order of default rules. (See http://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend_Revamp_RFC#Frontend for more information and a rough mockup.) Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 [Bug 15221] SIP server always sets the alert flag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:01:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:01:41 +0000 Subject: [Koha-bugs] [Bug 14554] Warns when updating personal details on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14554 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Aleisha Amohia --- Can't see these warns anymore :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:04:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:04:43 +0000 Subject: [Koha-bugs] [Bug 14191] Noisy warns in C4/XSLT.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14191 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED --- Comment #6 from Aleisha Amohia --- I don't see these warns anymore :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:05:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:05:02 +0000 Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15523 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 [Bug 15523] Move a number of sysprefs to circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:05:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:05:02 +0000 Subject: [Koha-bugs] [Bug 15523] New: Move a number of sysprefs to circulation rules Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 Bug ID: 15523 Summary: Move a number of sysprefs to circulation rules Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, nicole at bywatersolutions.com Depends on: 15521, 15522 Specifically: AllFinesNeedOverride AllowFineOverride AllowRenewalLimitOverride AllowTooManyOverride maxoutstanding noissuescharge overduesblockcirc refundlostitemfeeonreturn whenlostforgivefine Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 [Bug 15521] Make circulation rules backend more granular http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 [Bug 15522] New interface for revamped circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:05:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:05:02 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15523 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 [Bug 15523] Move a number of sysprefs to circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:07:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:07:00 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15522 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 [Bug 15522] New interface for revamped circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:07:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:07:00 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14048 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:12:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:12:20 +0000 Subject: [Koha-bugs] [Bug 15477] Error handling on editing item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15477 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:12:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:12:23 +0000 Subject: [Koha-bugs] [Bug 15477] Error handling on editing item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15477 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46390|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 46408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46408&action=edit [PASSED QA] Bug 15477: (follow-up) Bug 14100: Better errors handling On bug 14100, the patch "Better errors handling" introduced an ... error. The user always get "An error occurred when updating this translation" although it has been updated in DB. Test plan: Edit translations for an item type: you should not get an error when everything went fine. Tested on top of 15487, error message does no longer appear. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:20:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:20:12 +0000 Subject: [Koha-bugs] [Bug 15367] Batch patron modification: Data loss with multiple repeatable patron attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:20:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:20:15 +0000 Subject: [Koha-bugs] [Bug 15367] Batch patron modification: Data loss with multiple repeatable patron attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45883|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 46409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46409&action=edit [PASSED QA] Bug 15367: Do not display repeatable patron attributes in the batch patron modification The repeatable patron attributes are not correctly managed and can cause data lost. To avoid that, the easier way is not to display them in the batch patron modification tool. This should be implemented, as a new enhancement. Test plan: Create some patron attributes, some should be repeatable. Use the batch patron modification tool to modify patrons. With this patch, the patron attributes marked as repeatable won't be display anymore. Signed-off-by: Bernardo Gonzalez Kriegel Works as described, no koha-qa errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:27:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:27:22 +0000 Subject: [Koha-bugs] [Bug 15518] Intranet detail needs ssl sources for Amazon images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15518 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:27:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:27:25 +0000 Subject: [Koha-bugs] [Bug 15518] Intranet detail needs ssl sources for Amazon images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15518 --- Comment #1 from Liz Rea --- Created attachment 46410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46410&action=edit Bug 15518 - Intranet detail needs ssl sources for Amazon images To test: Enable Amazon images for the staff client - syspref: AmazonCoverImages -> Show Go to a record detail in the intranet that has an Amazon image, inspect it, and make sure that it 1. Shows 2. has https://images-na. and not http://images. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:31:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:31:05 +0000 Subject: [Koha-bugs] [Bug 15524] New: Set limit on maximum possible holds per patron by category Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Bug ID: 15524 Summary: Set limit on maximum possible holds per patron by category Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, nicole at bywatersolutions.com Depends on: 15521, 15522 It's possible to set a limit on the maximum number of holds for a particular branch/category/itemtype, but not on the total number of holds for a given patron (by branch/category). Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 [Bug 15521] Make circulation rules backend more granular http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 [Bug 15522] New interface for revamped circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:31:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:31:05 +0000 Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15524 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 [Bug 15524] Set limit on maximum possible holds per patron by category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:31:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:31:05 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15524 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 [Bug 15524] Set limit on maximum possible holds per patron by category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:38:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:38:08 +0000 Subject: [Koha-bugs] [Bug 15440] Warns in Members/Messaging.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15440 --- Comment #1 from Aleisha Amohia --- These warns only appear when the syspref EnhancedMessagingPreferences is set to Allow. Changing bug title -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:38:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:38:51 +0000 Subject: [Koha-bugs] [Bug 15440] EnhancedMessagingPreferences syspref causing warns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15440 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Warns in |EnhancedMessagingPreference |Members/Messaging.pm |s syspref causing warns -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:49:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:49:30 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz Status|Needs Signoff |Failed QA --- Comment #15 from Liz Rea --- Hi, May we please have a comprehensive test plan, it seems there are cases where this bug doesn't manifest and can't be reproduced. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 7 23:49:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 22:49:37 +0000 Subject: [Koha-bugs] [Bug 15376] Edit invoices: Can not change Shipping cost. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15376 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #8 from Aleisha Amohia --- I followed test plan and can't reproduce this bug either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 00:07:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 23:07:21 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #14 from Marc V?ron --- Hmm, it applies here... Applying: Bug 12721 - Prevent software error if incorrect fieldnames given in sypref StatisticsFields Applying: Bug 12721 - Syspref StatisticsFields: Warning on About page and text change in System preferences Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/about.tt Auto-merging about.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 00:15:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 23:15:48 +0000 Subject: [Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 00:15:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 23:15:51 +0000 Subject: [Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46385|0 |1 is obsolete| | --- Comment #4 from Liz Rea --- Created attachment 46411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46411&action=edit Bug 15501 - Planned Irregularities are deleted when modifying subscription Add a warning to avoid saving a subscription whitout testing prediction pattern when there are planned no published issues Signed-off-by: Liz Rea Ran through test plan, looks all good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 00:23:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 23:23:51 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #10 from Jesse Weaver --- Started working on this; Jonathan, what do you think of passing a $branchcode_limit parameter to SetBorrowerAttributes so it only deletes the correct attributes? (Either just passing 1 and using userenv, which is what AttributeTypes.pm does, or explicitly passing the branchcode, which is easier to test.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 00:44:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 23:44:11 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 00:44:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jan 2016 23:44:13 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 --- Comment #9 from Jesse Weaver --- Created attachment 46412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46412&action=edit Bug 15100: MARC21 - make display of "Dates associated with a name" optional With the changes for RDA now more subfields for the fields 100, 110, 111, and 700, 710, 711 are displayed. One of them is $d - Dates associated with a name This patch adds separate treatment of the $d subfield and wraps it in a span with the class "authordates". This makes it possible to hide the information with CSS. To test: - Make sure you have several records with $d catalogued - Check the display in result list and detail page with and without the page. - Check, if there is a difference in display - Check if the dates are correctly wrapped in a span - Try to hide the information, using the following entry in your *UserCSS preferences: .authordates { display: none; } Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 01:04:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 00:04:08 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m Status|Signed Off |Failed QA --- Comment #41 from Jesse Weaver --- One of the new test fails after applying all patches, and I'm not quite sure why: [elf]:~/p/koha> prove t/db_dependent/Circulation/Returns.t -- [2016-01-07 17:01] ------------------------------------------------------------------------------------------------------------ t/db_dependent/Circulation/Returns.t .. 1/3 item-level_itypes set but no itemtype set for item (Koha::Schema::Result::Item=HASH(0x7666618)->itemnumber) at /home/feoh3/p/koha/Koha/Schema/Result/Item.pm line 653. item-level_itypes set but no itemtype set for item (Koha::Schema::Result::Item=HASH(0x7677b68)->itemnumber) at /home/feoh3/p/koha/Koha/Schema/Result/Item.pm line 653. # Failed test 'biblio-level itype recorded on statistics for return as a fallback for null item-level itype' # at t/db_dependent/Circulation/Returns.t line 167. # got: 'zmH5aYw18' # expected: 'JTI' # Looks like you failed 1 test of 2. # Failed test 'AddReturn logging on statistics table (item-level_itypes=1)' # at t/db_dependent/Circulation/Returns.t line 170. # Looks like you failed 1 test of 3. t/db_dependent/Circulation/Returns.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/db_dependent/Circulation/Returns.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 1 wallclock secs ( 0.02 usr 0.00 sys + 1.19 cusr 0.04 csys = 1.25 CPU) Result: FAIL (FYI: the same warning that appears at the top of the test output here also appears when I prove t/db_dependent/Items.t, though that test passes.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 01:21:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 00:21:56 +0000 Subject: [Koha-bugs] [Bug 10551] Merging records allows duplicaton of non-repeatable subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10551 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #2 from Aleisha Amohia --- is this bug the same as Bug 8411? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 01:22:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 00:22:38 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 Patfrat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #12 from Patfrat --- It seems finally that the bug is there again I have setted marcflavour to MARC1 to fix Unsupported UNIMARC character encoding error. So, now, i can use addbiblio with default grid but not yet with my fast cataloguing framework addbiblio.pl?frameworkcode=FA that contains only these fields Tab0: 099, 200, 205, 210, 225 Tab1: 000, 001, 100 No response from the server ... AM i missing an important field ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 01:29:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 00:29:25 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #6 from Liz Rea --- Just noting that clicking the delete button from the Run, Edit, or Show views also doesn't prompt for confirmation. But this patch adds a confirm for deleting from the list, and that's good! Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 01:30:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 00:30:35 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 01:30:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 00:30:38 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46389|0 |1 is obsolete| | --- Comment #7 from Liz Rea --- Created attachment 46413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46413&action=edit Bug 15299: Ask for confirmation when deleting a report from second page Some link are hidden when loading the page, by DataTables, we need to use the delegate jQuery method to attach a handler to the click event for all delete links (the ones existing when loading the page, and the ones displayed in the future). Test plan: Have more than 20 reports defined Go on the report list view, then change the number of elements displayed, click "action>delete". You should get a warn. Signed-off-by: Liz Rea Confirm that there is now a confirmation on delete from the list -> action menu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 01:32:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 00:32:49 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 --- Comment #8 from Liz Rea --- adds back the confirm for ones that are not initially displayed, I mean -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 01:34:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 00:34:33 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #13 from Patfrat --- I have done a dump from the distant computer and a restore to my own computer to be able to debug it at home. I have already those error on my logs Timeout waiting for output from CGI script /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl Script timed out before returning headers: addbiblio.pl How can i know what happens ? When i submit the form, addbiblio.pl script set my CPU to 100% ?!? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 01:36:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 00:36:28 +0000 Subject: [Koha-bugs] [Bug 15525] New: Delete button on show, edit, and run pages of reports doesn't ask for confirmation to delete Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15525 Bug ID: 15525 Summary: Delete button on show, edit, and run pages of reports doesn't ask for confirmation to delete Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org on /cgi-bin/koha/reports/guided_reports.pl /cgi-bin/koha/reports/guided_reports.pl?reports=4&phase=Edit SQL /cgi-bin/koha/reports/guided_reports.pl?reports=4&phase=Show%20SQL clicking the delete button doesn't ask the user to confirm that they want to delete the report. It probably should. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 01:54:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 00:54:52 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #14 from Patfrat --- Oh and the search does not work anymore, no results ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 02:18:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 01:18:13 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #15 from Patfrat --- ok, the search works again if i a this to my koha-conf.xml file __KOHA_CONF_DIR__/log4perl.conf /usr/share/fonts/truetype/ttf-dejavu/DejaVuSerif.ttf /usr/share/fonts/truetype/ttf-dejavu/DejaVuSerif-Bold.ttf /usr/share/fonts/truetype/ttf-dejavu/DejaVuSerif-Italic.ttf /usr/share/fonts/truetype/ttf-dejavu/DejaVuSerif-BoldItalic.ttf /usr/share/fonts/truetype/ttf-dejavu/DejaVuSansMono.ttf /usr/share/fonts/truetype/ttf-dejavu/DejaVuSansMono-Bold.ttf /usr/share/fonts/truetype/ttf-dejavu/DejaVuSansMono-Oblique.ttf /usr/share/fonts/truetype/ttf-dejavu/DejaVuSansMono-BoldOblique.ttf /usr/share/fonts/truetype/ttf-dejavu/DejaVuSans.ttf /usr/share/fonts/truetype/ttf-dejavu/DejaVuSans-Oblique.ttf /usr/share/fonts/truetype/ttf-dejavu/DejaVuSans-Bold.ttf /usr/share/fonts/truetype/ttf-dejavu/DejaVuSans-BoldOblique.ttf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 02:56:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 01:56:33 +0000 Subject: [Koha-bugs] [Bug 15525] Delete button on show, edit, and run pages of reports doesn't ask for confirmation to delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15525 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 03:14:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 02:14:15 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 --- Comment #9 from Liz Rea --- Actually sorry I was wrong, it works fine on the show page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 04:39:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 03:39:29 +0000 Subject: [Koha-bugs] [Bug 15119] Hide search header text boxes on render In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15119 --- Comment #7 from H?ctor Eduardo Castro Avalos --- (In reply to Jonathan Druart from comment #6) > Thanks for testing H?ctor. > Switch back to Needs Signoff, I would like to get one from Christopher. Okidoki -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 07:13:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 06:13:46 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17569|0 |1 is obsolete| | --- Comment #38 from Srdjan Jankovic --- Created attachment 46414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46414&action=edit bug_8034: Restored network printer maintenance and selection This patch is just for restoring printer maintenance and selection, not for priting itself. It is just a preparation step. * Added UsePrintQueues syspref. If set to No, no printer info will be displayed/used * Database changes: - printers table PRIMARY KEY is now printqueue. It is more natural. We should really have a synthetic id, but printqueue is good enough - branches.branchprinter is a FOREIGN KEY to printers.printqueue * Created C4::Auth::get_user_printer() function that will return appropriate printer. In order of preference: - session selected - logged in branch branchprinter * Moved printer functions to C4::Printer * C4::Printer - added branch count to printer queries * admin/printers.tt - show or not delete link * Restored printer maint/selection in admin zone UsePrintQueues permitting * Restored printer selection in circ/selectbranchprinter.pl UsePrintQueues permitting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 07:14:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 06:14:32 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 07:14:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 06:14:35 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46414|0 |1 is obsolete| | --- Comment #39 from Srdjan Jankovic --- Created attachment 46415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46415&action=edit bug_8034: Restored network printer maintenance and selection This patch is just for restoring printer maintenance and selection, not for priting itself. It is just a preparation step. * Added UsePrintQueues syspref. If set to No, no printer info will be displayed/used * Database changes: - printers table PRIMARY KEY is now printqueue. It is more natural. We should really have a synthetic id, but printqueue is good enough - branches.branchprinter is a FOREIGN KEY to printers.printqueue * Created C4::Auth::get_user_printer() function that will return appropriate printer. In order of preference: - session selected - logged in branch branchprinter * Moved printer functions to C4::Printer * C4::Printer - added branch count to printer queries * admin/printers.tt - show or not delete link * Restored printer maint/selection in admin zone UsePrintQueues permitting * Restored printer selection in circ/selectbranchprinter.pl UsePrintQueues permitting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 09:37:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 08:37:28 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #16 from Patfrat --- And this error again Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a -> try at /usr/share/perl5/MARC/File/XML.pm line 568. If i set macflavour to MARC21, all my document's title are not visible If i set macflvaour to UNIMARC, default value for my instance, titles are visible but this error appears for these items i have saved with addbiblio default grid ! I will try first to remove manually wrong items, then, trying to see what's wrong with addbiblio.pl overloading my CPU when i submit via Fast Add ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 09:41:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 08:41:11 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #17 from Katrin Fischer --- Failed QA last night because of Josef's comment. Glad to see this move forward, hope remaining problems can be solved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 09:46:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 08:46:59 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #13 from Jonathan Druart --- Hi Chris, Thanks for testing! Did you compare the execution times before and after the patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 10:22:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 09:22:47 +0000 Subject: [Koha-bugs] [Bug 15376] Edit invoices: Can not change Shipping cost. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15376 --- Comment #9 from Marc V?ron --- The error no longer appears on current master. I had a look at the database: When I filed the bug, the error occured with records where shipmentdate = NULL. The current behaviour is that a record with shipmentdate = NULL has now shipmentdate = 0000-00-00 after saving with an empty field 'shipmentdate'. More testing: If I receive a shipment and save with an empty shipmentdate, the shipmentdate gets a NULL in the database (and billingdate / closedate as well). Additionally: If I edit this record and save it without changing any values (leaving shipmentdate and billingdate empty), shipmentdate turns to 0000-00-00 but billingdate is still NULL. I would expect that both dates behave the same. (BTW: While saving I get a log entry 'invoice.pl: Use of uninitialized value in concatenation (.) or string at .../invoice.tt line 79) So we have two different values for "empty date" in the table aqinvoices: NULL and 0000-00-00. @Jonathan: What dou you think about 0000-00-00 vs NULL? If I look at Bugzilla I see a couple of Bugs regarding 0000-00-00. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 10:22:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 09:22:52 +0000 Subject: [Koha-bugs] [Bug 15469] Authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 --- Comment #8 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > Almost there - just one small inconsistency - the last tab shows the > 'chronological term' preselected, while all others show 'default'. > Can you take a quick look if that's an easy fix? I have Default preselected for the 4 tabs. Are you sure it comes from this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 10:27:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 09:27:50 +0000 Subject: [Koha-bugs] [Bug 15469] Authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 --- Comment #9 from Katrin Fischer --- Hm not sure what else it could, but will retest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 10:31:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 09:31:02 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED Depends on| |13762 --- Comment #58 from Katrin Fischer --- Setting this to BLOCKED because of bug 13762 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 [Bug 13762] biblionumber field and subfield can be called once in authorities merge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 10:31:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 09:31:02 +0000 Subject: [Koha-bugs] [Bug 13762] biblionumber field and subfield can be called once in authorities merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11700 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 10:33:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 09:33:17 +0000 Subject: [Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- We will certainly need 1 bug report per pref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 10:33:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 09:33:46 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 10:37:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 09:37:15 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 --- Comment #10 from Jonathan Druart --- (In reply to Liz Rea from comment #9) > Actually sorry I was wrong, it works fine on the show page. I have tested all others and they worked, please confirm you don't get the warn somewhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 10:55:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 09:55:25 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #11 from Jonathan Druart --- Jesse, yes it should be the way to go but.. I have already tried something and was stuck. I have a wip branch but I don't remember what was wrong. Looking at the diff it seems that I have tried to add a DeleteBorrowerAttributes subroutines and the code looks quite complicated: +sub DeleteBorrowerAttributes { + my $borrowernumber = shift; + my $no_branch_limit = @_ ? shift : 0; + my $branch_limit = $no_branch_limit + ? 0 + : C4::Context->userenv ? C4::Context->userenv->{"branch"} : 0; + + my $dbh = C4::Context->dbh; + my $query = q{ + DELETE FROM borrower_attributes + }; + $query .= q{ + LEFT JOIN borrower_attribute_types_branches ON bat_code = code + WHERE b_branchcode = ? OR b_branchcode IS NULL + } if $branch_limit; + $query .= q{ + WHERE borrowernumber = ? + }; + + $dbh->do( $query, undef, $branch_limit ? $branch_limit : (), $borrowernumber ); +} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 10:56:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 09:56:16 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #12 from Jonathan Druart --- Created attachment 46416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46416&action=edit Bug 15163: Wip - stuck -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 10:56:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 09:56:37 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #13 from Jonathan Druart --- (In reply to Jonathan Druart from comment #12) > Created attachment 46416 [details] [review] > Bug 15163: Wip - stuck Jesse, here is my start. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 11:08:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 10:08:30 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #17 from Jonathan Druart --- (In reply to Jesse Weaver from comment #16) > Created attachment 46352 [details] [review] > Bug 14658: (followup) fix issue with list context on DBIC call > > While working on bug 14659, it was discovered that the call to > ...->guarantor in list context will cause the hash to be misaligned > (thus causing hidden => ... to not actually be sent to the template). Could you move that to another bug report, to make it backportable to stable branches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 11:09:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 10:09:23 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 11:24:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 10:24:40 +0000 Subject: [Koha-bugs] [Bug 15481] Remove dead code in datatables.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15481 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 11:24:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 10:24:43 +0000 Subject: [Koha-bugs] [Bug 15481] Remove dead code in datatables.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15481 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46331|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 46417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46417&action=edit Bug 15481: Remove dead code in datatables.js This removes the following functions that are not used anywhere: - dt_add_rangedate_filter - dt_overwrite_string_sorting_localeCompare - replace_html - replace_html_date Test plan: 1. Search for calls to the above functions in the code. There should be none. 2. Check that existing tables using DataTables are not broken. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 11:33:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 10:33:43 +0000 Subject: [Koha-bugs] [Bug 15526] New: Drop nozebra database table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15526 Bug ID: 15526 Summary: Drop nozebra database table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org All Code related to nozbra was removed, but it looks like the table was never dropped from older existing installations. New installations won't have the table, as it has been removed from kohastructure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 11:38:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 10:38:44 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 11:38:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 10:38:47 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46229|0 |1 is obsolete| | Attachment #46230|0 |1 is obsolete| | Attachment #46231|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 46418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46418&action=edit Bug 14571: using_https check for ssl connections doesn't work in some situations To test: * turn on Amazon images for result and detail in the OPAC * do a search that will result in an Amazon image being displayed on the result page * inspect the cover image that is returned on the result page, it should be using a https://images-na... Amazon URL. * click through to the detail for that item * inspect the cover image that is returned on the detail page, it should be using a https://images-na... Amazon URL. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 11:38:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 10:38:54 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #13 from Jonathan Druart --- Created attachment 46420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46420&action=edit Bug 14571 - More switching of Amazon image source URL to https modified: modules/opac-opensearch.tt modified: modules/opac-results-grouped.tt modified: modules/opac-shelves.tt modified: modules/opac-showreviews-rss.tt modified: modules/opac-showreviews.tt Basically, just inspect these places and make sure the Amazon images are using https://images-na instead of http://images Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 11:38:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 10:38:51 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #12 from Jonathan Druart --- Created attachment 46419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46419&action=edit Bug 14571: HTTPS Amazon images [follow up] I found a couple more places where we should be using images-na, so I updated them * in the shelf browser * in XISBN related works (honestly not sure how to test this one, but changing from the http:// url won't hurt anything.) To test: * Turn on the shelf browser, and browse for an item that has an amazon image, * inspect it, it should be using https://images-na... url. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 11:38:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 10:38:58 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #14 from Jonathan Druart --- Created attachment 46421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46421&action=edit Bug 14571 - Intranet detail needs ssl sources for Amazon images To test: Enable Amazon images for the staff client - syspref: AmazonCoverImages -> Show Go to a record detail in the intranet that has an Amazon image, inspect it, and make sure that it 1. Shows 2. has https://images-na. and not http://images. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 11:39:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 10:39:29 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #15 from Jonathan Druart --- (In reply to Liz Rea from comment #10) > Can we get these ones through first though? I'll make a different bug for > the intranet detail. > > Cheers, > Liz I have embedded it in this patch set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 11:39:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 10:39:43 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #16 from Jonathan Druart --- *** Bug 15518 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 11:39:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 10:39:43 +0000 Subject: [Koha-bugs] [Bug 15518] Intranet detail needs ssl sources for Amazon images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15518 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 14571 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 11:52:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 10:52:45 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #45 from Jonathan Druart --- I don't understand your issue, what about something like: function CalculateAge(date) { // Caculate age return (years, months); } onchange( age = CalculateAge(date); add_age_string_to_the_div ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 13:28:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 12:28:33 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- Pre patch: time misc/cronjobs/overdue_notices.pl -t -itemscontent title,author,itemcallnumber,barcode,replacementprice real 2m9.252s user 2m5.492s sys 0m0.108s Post Patch: time misc/cronjobs/overdue_notices.pl -t -itemscontent title,author,itemcallnumber,barcode,replacementprice real 1m19.965s user 1m12.437s sys 0m0.192s mysql> select COUNT(*) from issues where date_due > now(); +----------+ | COUNT(*) | +----------+ | 480 | +----------+ 1 row in set (0.01 sec) mysql> select COUNT(*) from issues where date_due <= now(); +----------+ | COUNT(*) | +----------+ | 65218 | +----------+ 1 row in set (0.01 sec) I found it quite striking how much of a time difference there was even though the number of checkouts not due yet is quite low so I ran the tests again with very similar results! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 13:33:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 12:33:37 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #17 from Patfrat --- I have modified this file /usr/share/perl5/MARC/File/XML.pm row 568 to not die and return UTF-8 instead to be allow to retrieve my test items and not throwing Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a -> try at /usr/share/perl5/MARC/File/XML.pm line 568. Then i have deleted concerned items ... but i have always some bugs. Fast cataloguing not working Having some javascript files timeout (browser.js, basket.js) And saving via default grid use MARC21 and not UNIMARC !!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 13:36:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 12:36:25 +0000 Subject: [Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 13:36:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 12:36:27 +0000 Subject: [Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46411|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 46422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46422&action=edit Bug 15501 - Planned Irregularities are deleted when modifying subscription Add a warning to avoid saving a subscription whitout testing prediction pattern when there are planned no published issues Signed-off-by: Liz Rea Ran through test plan, looks all good. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 13:42:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 12:42:04 +0000 Subject: [Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 13:42:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 12:42:07 +0000 Subject: [Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46269|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 46423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46423&action=edit Bug 15473: Make Koha::Objects->find accepts 0 and '' as a key This bug has been found after bug 15381 was pushed: If you go on authorities/authorities.pl, you expect a form to create a authorities with a "Default" authority type. Now, it explodes: Can't call method "authtypetext" on an undefined value at /home/koha/src/authorities/authorities.pl line 665. Koha::Objects->find does not want to search if the key does not exist (undef, '', 0). But actually it should only be a coward if it is not defined. Moreover this is the default behavior of the DBIx::Class find method. Test plan: prove t/db_dependent/Koha/Objects.t should return green and GET /cgi-bin/koha/authorities/authorities.pl should not make everything explode. Signed-off-by: Bernardo Gonzalez Kriegel Find this after signing 15470 :) Test pass, new auth (Default) created, no errors. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 13:51:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 12:51:41 +0000 Subject: [Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 13:51:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 12:51:44 +0000 Subject: [Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46104|0 |1 is obsolete| | Attachment #46105|0 |1 is obsolete| | Attachment #46107|0 |1 is obsolete| | Attachment #46268|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 46424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46424&action=edit Bug 15446: Add tests Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 13:51:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 12:51:53 +0000 Subject: [Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 --- Comment #16 from Kyle M Hall --- Created attachment 46426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46426&action=edit Bug 15446: Update systempreferences rows where type=YesNo and value='' Signed-off-by: Marc V?ron Amended to fix typo in sql statement. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 13:51:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 12:51:50 +0000 Subject: [Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 --- Comment #15 from Kyle M Hall --- Created attachment 46425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46425&action=edit Bug 15446: Rename Koha::Object[s]->type with _type In a few case (at least systempreferences and export_format (csv profiles), the type method of Koha::Object and Koha::Objects can be in conflict with the column names. Indeed systempreferences.type exists and so the method will return 'Systempreference' (the name of the module) instead of the value of the row in DB. I have found at least 1 place where it can cause issue: In C4::Context->set_preference: 601 my $syspref = Koha::Config::SysPrefs->find( $var ); 602 my $type = $syspref ? $syspref->type() : undef; 603 604 $value = 0 if ( $type && $type eq 'YesNo' && $value eq '' ); type will always be 'Systempreference' and the YesNo pref will be set to an empty string '' instead of 0. I am not sure about the consequences of this, but it is preferable to fix it ASAP. To reproduce: 0/ Do not apply this patch 1/ Edit a YesNo prefs, AutoEmailOpacUser for instance 2/ Set it to "Don't sent" 3/ Check the value in DB, it should be set to an empty string, instead of 0 4/ Apply this patch and try again. Now the value should be 0 Followed test plan, value is now 0 as expected. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 13:51:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 12:51:55 +0000 Subject: [Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 --- Comment #17 from Kyle M Hall --- Created attachment 46427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46427&action=edit Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type Some occurrences have been pushed in the meantime. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 13:58:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 12:58:04 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 13:58:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 12:58:07 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46413|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 46428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46428&action=edit Bug 15299: Ask for confirmation when deleting a report from second page Some link are hidden when loading the page, by DataTables, we need to use the delegate jQuery method to attach a handler to the click event for all delete links (the ones existing when loading the page, and the ones displayed in the future). Test plan: Have more than 20 reports defined Go on the report list view, then change the number of elements displayed, click "action>delete". You should get a warn. Signed-off-by: Liz Rea Confirm that there is now a confirmation on delete from the list -> action menu Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 14:39:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 13:39:50 +0000 Subject: [Koha-bugs] [Bug 15527] New: OAI-PMH should have a stylesheet to aid usability Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 Bug ID: 15527 Summary: OAI-PMH should have a stylesheet to aid usability Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 46429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46429&action=edit Original style Both EPrints and DSpace projects ship XSLT stylesheets that are included in the OAI response so using a web browser to navigate the repository. We should add one ourselves. See the attached screenshots for better understanding this enhancement proposal. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 14:40:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 13:40:13 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 46430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46430&action=edit Proposed style -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:03:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:03:42 +0000 Subject: [Koha-bugs] [Bug 15519] Warns when creating a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15519 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46407|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 46431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46431&action=edit Bug 15519: Warns when creating a basket To test: 1) Reproduce warn following steps above 2) Apply patch 3) Create a new basket and click Save. Do not add any items 4) Notice warn is gone 5) Click 'Delete this basket' and confirm that the validation message reads: "Are you sure you want to delete this basket?" Click cancel. 6) Add an order to the basket, then click 'Delete this basket'. Confirm the validation message gives more information and more delete options. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:04:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:04:05 +0000 Subject: [Koha-bugs] [Bug 15519] Warns when creating a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15519 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:13:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:13:13 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45216|0 |1 is obsolete| | --- Comment #10 from Alex Arnaud --- Created attachment 46432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46432&action=edit Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:13:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:13:19 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45841|0 |1 is obsolete| | --- Comment #11 from Alex Arnaud --- Created attachment 46433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46433&action=edit Bug 15261: remove Date::Range and Date::Simple dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:17:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:17:04 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:17:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:17:11 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:21:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:21:35 +0000 Subject: [Koha-bugs] [Bug 15528] New: Updating the authorised value for a report subgroup removes the previous value assigned from all report Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15528 Bug ID: 15528 Summary: Updating the authorised value for a report subgroup removes the previous value assigned from all report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Create some reports and assign/create groups and subgroups 2 - Change the authorised value for one of the subgroups 3 - Note that rather than the previous value being left behind (expected) or updated (ideal behavior) the subgroup data is stripped from the report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:29:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:29:50 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:29:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:29:54 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 46434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46434&action=edit Bug 15527: Add a stylesheet for OAI-PMH to aid usability This patch introduces an XSLT file grabbed from DSpace and a couple css files. To test: - Point to your dev Koha's oai endpoint. For example: http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListMetadataFormats => FAIL: Look how ugly it is for humans. - Apply this patch - Reload => SUCCES: It is styled and provides really useful links to interact with the OAI server verbs. - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:30:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:30:03 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 46435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46435&action=edit Bug 15527: (followup) Allow using custom stylesheets This patch introduces a syspref to let users choose their own XSLT stylesheets for the OAI-PMH front end. Regards Sponsored-by: Universidad Empresarial Siglo 21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:39:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:39:09 +0000 Subject: [Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46395|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 46436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46436&action=edit Bug 14816: Fix multiple selection in item search Send each selected value as a separate parameter. Otherwise DataTables (or jQuery ?) joins all values with a comma Tested / compared with several combinations, e.g. "All libraries" vs all libraries checked. With patch result is the same (without, all libraries checked had zero result). Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:45:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:45:41 +0000 Subject: [Koha-bugs] [Bug 15529] New: Process Message Queue may send duplicate emails if process is launched twice Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Bug ID: 15529 Summary: Process Message Queue may send duplicate emails if process is launched twice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Neither process_message_queue.pl nor C4::Letters::SendQueuedMessages have any method of ensuring that duplicate emails are not sent if two or more instances of process_message_queue.pl are running concurrently. This seems to have caused issues on a server which was re-running cron jobs because the system clock was re-set by NTP, but it could also cause issues if process_message_queue.pl took a very long time to process. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:50:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:50:28 +0000 Subject: [Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Summary|Move a number of sysprefs |Move a number of sysprefs |to circulation rules |to circulation rules | |(Omnibus) --- Comment #2 from Nicole C. Engard --- Once we have finished the dependencies we will split this bug report for the multiple patches. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:54:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:54:37 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Nick Clemens --- Hi Liz, I tested in Firefox and Chrome and could not recreate this issue, can you check again? Moving back to Needs Signoff -Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:56:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:56:20 +0000 Subject: [Koha-bugs] [Bug 15512] Minor regression caused by Bug 7369 - warn on deleting item not triggered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46378|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 46437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46437&action=edit Bug 15512 - Minor regression caused by Bug 7369 - warn on deleting item not triggered To test: 1 - Delete an item using the Action menu 2 - There is a js error and no warning box 3 - Apply patch 4 - Delete an item using the action menu 5 - You should get a confirmation box as expected Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 15:56:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 14:56:39 +0000 Subject: [Koha-bugs] [Bug 15512] Minor regression caused by Bug 7369 - warn on deleting item not triggered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 16:14:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 15:14:25 +0000 Subject: [Koha-bugs] [Bug 15482] Koha does not like the full-width commercial character in an email address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15482 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Tested and confirmed. I would go to the left (accept the letter in validation JavaScript and while validation with JavaScript disabled, replace it before storing to the database). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 16:16:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 15:16:18 +0000 Subject: [Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 16:39:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 15:39:09 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 46438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46438&action=edit Bug 15527: (followup) Avoid replacing spaces for non-breaking spaces This causes the template not to wrap long lines correctly, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 16:53:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 15:53:21 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #3 from Nick Clemens --- Created attachment 46439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46439&action=edit Bug 14752 - (QA Followup) Use input type="number" and small update to error modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 16:58:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 15:58:30 +0000 Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46102|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 46440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46440&action=edit Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher This patch adds a syspref "AggressiveMatchOnISSN" allowing for a match of ISSNs with or without hyphens. It uses Business::ISSN in order to follow the use of Business::ISBN and allow for validation of ISSNs To test: 1 - Find a record in your system with an ISSN (or add one) 2 - Stage a record containing the same ISSN but lacking a hyphen 3 - Matching on ISSN should find 0 matches 4 - Repeat with no hyphen ISSN in system and hyphen ISSN in import 5 - Matching should find 0 6 - Apply patch 7 - Update datbase and install Business::ISSN 8 - Leave AggressiveMatchOnISSN as don't and repeat original tests- no change 9 - Set AggressiveMatchOnISSN as do and repeat original test 10 - You should find a match 11 - prove t/Koha.t - all tests pass Sponsored by North Central Regional Library System (NCRL) www.ncrl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:07:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:07:13 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #12 from sandboxes at biblibre.com --- Patch tested with a sandbox, by delaye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:07:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:07:28 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46432|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:07:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:07:32 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46433|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:07:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:07:40 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #13 from sandboxes at biblibre.com --- Created attachment 46441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46441&action=edit Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve Signed-off-by: delaye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:07:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:07:44 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #14 from sandboxes at biblibre.com --- Created attachment 46442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46442&action=edit Bug 15261: remove Date::Range and Date::Simple dependencies Signed-off-by: delaye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:22:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:22:09 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:22:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:22:11 +0000 Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:22:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:22:13 +0000 Subject: [Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:22:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:22:12 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:22:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:22:16 +0000 Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:31:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:31:50 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #18 from Ian Palko --- (In reply to Jonathan Druart from comment #15) > (In reply to Ian Palko from comment #13) > > I've manually edited the relevant files in accordance with Julian's patches > > here. > > Please, help yourself, don't do that :) > git is your friend and can help you. I know... Eventually that will happen. For now, I need a backup server at the ready "just in case", as we have had some issues with the production server. It will be replaced (fingers crossed) thus summer when we move to a new building with a new server waiting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:32:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:32:58 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #19 from Ian Palko --- (In reply to Josef Moravec from comment #16) > I just tested the patch, the records and result are displayed as they > should. But after merging, the resulted record has all the data from both > records! I can confirm this behavior. One step closer, though ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:36:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:36:12 +0000 Subject: [Koha-bugs] [Bug 11324] "Delete All Items" fails except on "Normal Tab" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11324 Ian Palko changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #5 from Ian Palko --- (In reply to Aleisha Amohia from comment #4) > I could not reproduce this bug in version 3.23. Must have been fixed? Can > someone else test if this bug is still valid? I can confirm, the code seems to have been either copied as Owen suggested, or other fixes have fixed this. Marking as Resolved:Invalid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:36:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:36:22 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Wendy Sharkey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catalog at bfli.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:59:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:59:25 +0000 Subject: [Koha-bugs] [Bug 15530] New: Editing a course item via a disabled course disables it even if it is on other enabled courses Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 Bug ID: 15530 Summary: Editing a course item via a disabled course disables it even if it is on other enabled courses Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It appears that if the course item is edited by clicking the edit link from an active course, the course item will be set to enabled and the fields will be swapped, if the same course item is edited from a course that is *not* active, the course item will be set to *not* enabled, and the original fields will be swapped back in! The short term work-around is to only edit course items from an enabled course if the item has a course that is enabled. If all the courses it is on are disabled, it doesn't matter what course the item is edited from. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 17:59:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 16:59:30 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 18:03:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 17:03:16 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 --- Comment #1 from Kyle M Hall --- Created attachment 46443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46443&action=edit Bug 15530 - Add Unit Test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 18:03:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 17:03:14 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 18:03:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 17:03:23 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 --- Comment #2 from Kyle M Hall --- Created attachment 46444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46444&action=edit Bug 15530 - Editing a course item via a disabled course disables it even if it is on other enabled courses It appears that if the course item is edited by clicking the edit link from an active course, the course item will be set to enabled and the fields will be swapped, if the same course item is edited from a course that is *not* active, the course item will be set to *not* enabled, and the original fields will be swapped back in! The short term work-around is to only edit course items from an enabled course if the item has a course that is enabled. If all the courses it is on are disabled, it doesn't matter what course the item is edited from. Test Plan: 1) Create two courses, 1 enabled and 1 disabled 2) Add an item as a course reserve to both courses 3) Edit the course reserve data for the item via the enabled course 4) Note the course item is enabled ( easy way is to check the database ) 5) Edit the same course reserve data, but via the disabled course 6) Note the course item is now disabled even though it is part of an enabled course! 7) Apply this patch 8) Repeat steps 1 through 5 9) Note the course item is still enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 18:05:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 17:05:07 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46443|0 |1 is obsolete| | Attachment #46444|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 46445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46445&action=edit Bug 15530 - Add Unit Test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 18:05:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 17:05:14 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 --- Comment #4 from Kyle M Hall --- Created attachment 46446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46446&action=edit Bug 15530 - Editing a course item via a disabled course disables it even if it is on other enabled courses It appears that if the course item is edited by clicking the edit link from an active course, the course item will be set to enabled and the fields will be swapped, if the same course item is edited from a course that is *not* active, the course item will be set to *not* enabled, and the original fields will be swapped back in! The short term work-around is to only edit course items from an enabled course if the item has a course that is enabled. If all the courses it is on are disabled, it doesn't matter what course the item is edited from. Test Plan: 1) Create two courses, 1 enabled and 1 disabled 2) Add an item as a course reserve to both courses 3) Edit the course reserve data for the item via the enabled course 4) Note the course item is enabled ( easy way is to check the database ) 5) Edit the same course reserve data, but via the disabled course 6) Note the course item is now disabled even though it is part of an enabled course! 7) Apply this patch 8) Repeat steps 1 through 5 9) Note the course item is still enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 18:34:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 17:34:07 +0000 Subject: [Koha-bugs] [Bug 15209] C4::Koha routines expecting a MARC::Record object should check it is defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15209 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 18:34:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 17:34:09 +0000 Subject: [Koha-bugs] [Bug 15209] C4::Koha routines expecting a MARC::Record object should check it is defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15209 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46007|0 |1 is obsolete| | Attachment #46008|0 |1 is obsolete| | Attachment #46009|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 46447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46447&action=edit Bug 15209 Validate passed MARC::Record objs in C4::Koha Ensure that a passed MARC::Record is defined before calling its methods. Otherwise you are open to occurences of the error 'Can't call method "field" on an undefined value' In a CGI environment you can live with such sloppiness but in a persistent environment the error can cause the instance to abort. Made all routines passed a MARC::Record validate it before calling its methods. Changed the parameter name from the meaningless record to marcrecord to indicate its content. Added an explicit return for all cases where no valid data returned. Cleaned up some logic for clarity. I think we can assume that GetNormalizedOCLCNumber meant to look at all 035s till it found an OCLC number not just the first. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 18:34:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 17:34:17 +0000 Subject: [Koha-bugs] [Bug 15209] C4::Koha routines expecting a MARC::Record object should check it is defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15209 --- Comment #6 from Kyle M Hall --- Created attachment 46448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46448&action=edit Bug 15209: Add tests Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 18:34:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 17:34:19 +0000 Subject: [Koha-bugs] [Bug 15209] C4::Koha routines expecting a MARC::Record object should check it is defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15209 --- Comment #7 from Kyle M Hall --- Created attachment 46449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46449&action=edit Bug 15209: Check the parameter at the beginning of the subroutines It seems better to check if parameters exist at the beginning of a subroutine. It makes the code easier to read and there is 1 indentation level less. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 18:41:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 17:41:39 +0000 Subject: [Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 18:41:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 17:41:42 +0000 Subject: [Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46272|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 46450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46450&action=edit Bug 15398: Hide Staff members only in the patron deletion/anonymization tool On bug 9076 (commit 568a4c1230ee9a4002181fcab2c083faf6c323a9), the plan was to hide the Staff members from the tool. But the test was wrong, it was done on the category_code instead of the category_type value. Test plan: 1/ Create a category 'Student' which is not part of the Staff (category_code=S, category_type!=S) 2/ Create a staff category (category_type=S) 3/ Go on the deletion/anonymization tool (tools/cleanborrowers.pl) and confirm that the category Student category is displayed in the dropdown list. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no errors. Signed-off-by: Kyle M Hall http://bugs.koha-community.org/show_bug.cgi?id=15308 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 18:43:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 17:43:31 +0000 Subject: [Koha-bugs] [Bug 15531] New: Add support for standing orders Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Bug ID: 15531 Summary: Add support for standing orders Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: nicole at bywatersolutions.com A new kind of standing order basket, with the following behavior: * Items can be received without the basket being closed. * Items can be received without their price being known in advance. * Creation of items upon receive customizable per-basket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 18:57:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 17:57:14 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #5 from Fr?d?ric Demians --- It doesn't work for me when your stylesheet is in opac-tmpl/xsl/. I have to put it in opac-tmpl directly, and modify Repository.pm file to make it works. Could you try on your side? I've seen in your screenshot you're working with 'localhost' as your server URL. It may come from there. A remark: you introduce a new syspref OAI-PMH:CustomStylesheet. I think that this kind of parameter belongs to the 'Extended Mode'. The YAML config file could be used to link to a local stylesheet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 19:18:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 18:18:41 +0000 Subject: [Koha-bugs] [Bug 15512] Minor regression caused by Bug 7369 - warn on deleting item not triggered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 19:18:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 18:18:44 +0000 Subject: [Koha-bugs] [Bug 15512] Minor regression caused by Bug 7369 - warn on deleting item not triggered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46437|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 46451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46451&action=edit Bug 15512 - Minor regression caused by Bug 7369 - warn on deleting item not triggered To test: 1 - Delete an item using the Action menu 2 - There is a js error and no warning box 3 - Apply patch 4 - Delete an item using the action menu 5 - You should get a confirmation box as expected Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 19:31:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 18:31:16 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46167|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 46452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46452&action=edit Bug 14133: Print notices should be generated with the print template If the overdue notice to send is an email or a SMS and the patron does not provided such information, a print notice is generated. But it will be generated with the email or sms template, which is not useful, especially in the SMS case. The template to use should be the print one. Test plan: 0/ Does not apply this patch and Correctly define the overdue rules to generate an overdue notice to the message_queue table. Check email + SMS 1/ Define an email address and a SMS number for a patron 2/ Generate the overdue notices (misc/cronjobs/overdue_notices.pl [-t]) 3/ 2 notices should have been generated: mtt=email with the email template used mtt=sms with the sms template used 4/ Truncate the message_queue table 5/ Remove the email address and repeat 2 6/ Only 1 notice should have been generated: mtt=print with the email template used 7/ Truncate the message_queue table 8/ Remove the sms alert number and repeat 2 9/ 2 notices should have been generated: mtt=print with the email template used (or sms I suppose) 10/ Apply this patch and repeat previous steps. The print notices should be generated with the print template. IMPORTANT NOTE: This test plan does not take into account the notices generated for the staff ("These messages were not sent directly to the patrons."). However the behavior will also change, the print template will be used in all cases. Is it what we want? Signed-off-by: Chris Seems fine by me Signed-off-by: Kyle M Hall The IMPORTANT NOTE change makes sense to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 19:31:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 18:31:24 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 19:37:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 18:37:34 +0000 Subject: [Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 19:37:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 18:37:38 +0000 Subject: [Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46241|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 46453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46453&action=edit Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. Signed-off-by: Bernardo Gonzalez Kriegel Looks like refactoring :) No regressions, no koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 19:43:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 18:43:03 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #168 from Kyle M Hall --- I don't think C4::Passwordrecovery is a good namespace. Should this not be something like Koha::Patron::Password::Recovery or Koha::Borrower::Password::Recovery? We should not be adding modules to the C4 namespace at this point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 20:22:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 19:22:23 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8352 CC| |kyle at bywatersolutions.com --- Comment #40 from Kyle M Hall --- This work will certainly conflict with Bug 8352. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 20:22:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 19:22:23 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8034 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 20:46:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 19:46:52 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #1 from Nick Clemens --- Created attachment 46454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46454&action=edit Bug 14576 - Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 20:57:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 19:57:55 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Assignee|jweaver at bywatersolutions.co |nick at bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 21:51:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 20:51:34 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 21:51:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 20:51:37 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46454|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 46455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46455&action=edit Bug 14576 - Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 8 21:51:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 20:51:45 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #3 from Nick Clemens --- Created attachment 46456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46456&action=edit Bug 14576 - Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 00:26:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jan 2016 23:26:05 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #18 from Patfrat --- After searching a lot, i have decided to delete my fast add unimarc framework. I have also deleted two bad documents that zebra rebuild indocicates me with error on item numbers 1030, 1034 I have deleted them via mysql Then, i have updated all biblio records setting frameworkcode to '' instead of FA And now, it works ! But i have no more Fast Add framework ! DO you provide one for Unimarc in fr-FR language ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 02:59:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 01:59:47 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #6 from Tom?s Cohen Arazi --- (In reply to Fr?d?ric Demians from comment #5) > It doesn't work for me when your stylesheet is in opac-tmpl/xsl/. I have to > put it in opac-tmpl directly, and modify Repository.pm file to make it > works. Could you try on your side? I've seen in your screenshot you're > working with 'localhost' as your server URL. It may come from there. I'm using kohadevbox:ansible. I think the permissions (apache ones) on a regular dev/normal install have diverged from the packages. I'll take a look. > A remark: you introduce a new syspref OAI-PMH:CustomStylesheet. I think that > this kind of parameter belongs to the 'Extended Mode'. The YAML config file > could be used to link to a local stylesheet. That's probably a good idea. I'll dig into it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 04:04:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 03:04:36 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #7 from H?ctor Eduardo Castro Avalos --- Looks very good. Good job, Tom?s. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 04:41:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 03:41:13 +0000 Subject: [Koha-bugs] [Bug 15517] deleted tables differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46404|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 46458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46458&action=edit [SIGNED-OFF]Bug 15517: deleted* tables won't never differ anymore! These tests will ensure that the 4 deleted* tables won't never differ anymore. Test plan: 0/ Do not execute the update DB entry 1/ prove t/db_dependent/db_structure.t should fail 2/ Execute the update DB entry and update the schema with misc/devel/update_dbix_class_files.pl 3/ prove t/db_dependent/db_structure.t should now be happy Signed-off-by: Hector Castro Test pass successfuly. Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 04:40:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 03:40:47 +0000 Subject: [Koha-bugs] [Bug 15517] deleted tables differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46403|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 46457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46457&action=edit [SIGNED-OFF]Bug 15517: Resync borrowers and deletedborrowers tables The 2 columns password and userid are not sync and could cause errors when deleting patrons. Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 04:41:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 03:41:42 +0000 Subject: [Koha-bugs] [Bug 15517] deleted tables differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 08:48:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 07:48:59 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #8 from Fr?d?ric Demians --- (In reply to Tom?s Cohen Arazi from comment #6) > I'm using kohadevbox:ansible. I think the permissions (apache ones) on a > regular dev/normal install have diverged from the packages. I'll take a look. This part in apache conf is the culprit: Order deny,allow Deny from all I will propose a patch fixing that, and using OAI server conf file to define custom XSLT for web view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 08:50:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 07:50:20 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 08:56:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 07:56:33 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 08:56:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 07:56:36 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46434|0 |1 is obsolete| | Attachment #46435|0 |1 is obsolete| | Attachment #46438|0 |1 is obsolete| | --- Comment #9 from Fr?d?ric Demians --- Created attachment 46459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46459&action=edit Bug 15527: Add a stylesheet for OAI-PMH to aid usability This patch introduces an XSLT file grabbed from DSpace and a couple css files. To test: - Point to your dev Koha's oai endpoint. For example: http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListMetadataFormats => FAIL: Look how ugly it is for humans. - Apply this patch - Reload => SUCCES: It is styled and provides really useful links to interact with the OAI server verbs. - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Fr?d?ric Demians Works as described. Nice looking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 08:56:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 07:56:48 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #10 from Fr?d?ric Demians --- Created attachment 46460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46460&action=edit Bug 15527 Custom stylesheet in extended mode Add a parameter to YAML config file in order to specify a local XSLT used style the XML returned by OAI Server. Some doc. Move default XSLT from /opac-tmpl/xslt to /opac-tmpl/bootstrap/css/OAI.xslt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 09:01:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 08:01:29 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #11 from Fr?d?ric Demians --- (In reply to Fr?d?ric Demians from comment #10) > Created attachment 46460 [details] [review] > Bug 15527 Custom stylesheet in extended mode > > Add a parameter to YAML config file in order to specify a local XSLT > used style the XML returned by OAI Server. Some doc. > > Move default XSLT from /opac-tmpl/xslt to > /opac-tmpl/bootstrap/css/OAI.xslt. Tom?s, I've signed-off your first patch, and obsoleted the 2 others. You should take a look at mine (2nd patch attached) and sign it whether it seems OK to you. Maybe a third eye (Hector) and sign-off would be welcome. Thanks for the good job. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 10:52:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 09:52:54 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:00:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:00:25 +0000 Subject: [Koha-bugs] [Bug 15532] New: Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 Bug ID: 15532 Summary: Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Some libraries would like to be able to limit hold filling to items that match the pickup library for a hold based on the item's home or holding library. The patron's home library should not affect whether a patron can place the hold, instead the hold will only be fillable when an item matching the pickup location becomes available. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:00:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:00:30 +0000 Subject: [Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:05:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:05:36 +0000 Subject: [Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:05:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:05:38 +0000 Subject: [Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 --- Comment #1 from Kyle M Hall --- Created attachment 46461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46461&action=edit Bug 15532 - Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold Some libraries would like to be able to limit hold filling to items that match the pickup library for a hold based on the item's home or holding library. The patron's home library should not affect whether a patron can place the hold, instead the hold will only be fillable when an item matching the pickup location becomes available. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Note the new "Hold pickup library match" rules for "checkout, hold, and return policy" and for "holds policy by item type" 4) Set the policy to "item's holding library" 5) Place a hold where the item's holding branch does not match the pickup branch 6) Check in the item 7) Note it is not trapped for the hold 8) Update the item's holding branch to match the pickup branch 8) Check in the item 9) Note the item is trapped for the hold 10) Repeat steps 4-9 but for home branch instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:10:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:10:29 +0000 Subject: [Koha-bugs] [Bug 15533] New: Allow patrons and librarians to select itemtype when placing hold Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 Bug ID: 15533 Summary: Allow patrons and librarians to select itemtype when placing hold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Some libraries would like the ability to select the itemtype to request when placing holds. For example, if a record has 3 copies of BookA and 3 copies of BookA in large print, this feature would allow a person to place a hold on the record, but still be able to target only the Large Print edition so that the first Large Print copy that becomes available is targeted, rather than forcing the patron to select a particular copy to hold. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:11:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:11:03 +0000 Subject: [Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:11:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:11:15 +0000 Subject: [Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15533 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 [Bug 15533] Allow patrons and librarians to select itemtype when placing hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:11:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:11:15 +0000 Subject: [Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15532 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:14:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:14:24 +0000 Subject: [Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:14:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:14:26 +0000 Subject: [Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 --- Comment #1 from Kyle M Hall --- Created attachment 46462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46462&action=edit Bug 15533 - Allow patrons and librarians to select itemtype when placing hold Some libraries would like the ability to select the itemtype to request when placing holds. For example, if a record has 3 copies of BookA and 3 copies of BookA in large print, this feature would allow a person to place a hold on the record, but still be able to target only the Large Print edition so that the first Large Print copy that becomes available is targeted, rather than forcing the patron to select a particular copy to hold. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with items of two or more itemtypes 4) Place a record level hold on the record while choosing one particular itemtype 5) Check in an item from the record that is not of that itemtype 6) Notee it is not trapped for the hold 7) Check in an item from the record that does match the selected itemtype 8) Note the item is trapped for the hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:19:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:19:36 +0000 Subject: [Koha-bugs] [Bug 15534] New: Add the ability to prevent a patron from placing a hold on a record with available items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Bug ID: 15534 Summary: Add the ability to prevent a patron from placing a hold on a record with available items Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Some libraries would like to prevent patrons from placing holds on records/items where there are other items available for the patron to check out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:19:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:19:39 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:20:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:20:55 +0000 Subject: [Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15534 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:20:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:20:55 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15533 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 [Bug 15533] Allow patrons and librarians to select itemtype when placing hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:25:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:25:04 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 9 12:25:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jan 2016 11:25:07 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 --- Comment #1 from Kyle M Hall --- Created attachment 46463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46463&action=edit Bug 15534 - Add the ability to prevent a patron from placing a hold on a record with available items Some libraries would like to prevent patrons from placing holds on records/items where there are other items available for the patron to check out. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Browse to the circulation rules 4) Note the new rule "Allow hold if others available" 5) Set the rule to "No" 6) Find a patron/branch/itemtype applicable to this rule 7) Ensure at least one item on the record is available for the patron to check out 8) Attempt to place a hold for the patron 9) Note you cannot place the hold 10) Check the available item out to another patron 11) Note you can now place a hold for the first patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 02:43:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 01:43:23 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #12 from H?ctor Eduardo Castro Avalos --- > > Tom?s, I've signed-off your first patch, and obsoleted the 2 others. You > should take a look at mine (2nd patch attached) and sign it whether it seems > OK to you. Maybe a third eye (Hector) and sign-off would be welcome. Thanks > for the good job. For me looks very good I'll signed-off if you don't care Tom?s. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 02:45:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 01:45:26 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46460|0 |1 is obsolete| | --- Comment #13 from H?ctor Eduardo Castro Avalos --- Created attachment 46464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46464&action=edit [SIGNED-OFF]Bug 15527: Custom stylesheet in extended mode Add a parameter to YAML config file in order to specify a local XSLT used style the XML returned by OAI Server. Some doc. Move default XSLT from /opac-tmpl/xslt to /opac-tmpl/bootstrap/css/OAI.xslt. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 03:35:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 02:35:20 +0000 Subject: [Koha-bugs] [Bug 15458] Marc21 leader 07 error in translation: "a- Serial component" part is not in format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15458 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #1 from H?ctor Eduardo Castro Avalos --- In master this is Ok, this apply only for 3.20 and less In bug 14201, Marcel has removed this three templates: marc21_leader_book.pl marc21_leader_computerfile.pl marc21_leader_video.pl But this patch has been pushed only to Master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 03:46:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 02:46:19 +0000 Subject: [Koha-bugs] [Bug 15458] Marc21 leader 07 error in translation: "a- Serial component" part is not in format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15458 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 03:46:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 02:46:22 +0000 Subject: [Koha-bugs] [Bug 15458] Marc21 leader 07 error in translation: "a- Serial component" part is not in format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15458 --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 46465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46465&action=edit Bug 15458: Marc21 leader 07 error in translation: "a- Serial component" part is not in format Fix "a- Serial component part" to "b-" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 03:54:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 02:54:20 +0000 Subject: [Koha-bugs] [Bug 15458] Marc21 leader 07 error in translation: "a- Serial component" part is not in format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15458 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr, | |liz at catalyst.net.nz Assignee|koha-bugs at lists.koha-commun |gmcharlt at gmail.com |ity.org | Component|translate.koha-community.or |MARC Bibliographic data |g |support Patch complexity|--- |String patch --- Comment #3 from H?ctor Eduardo Castro Avalos --- Include here RM's 3.20 and 3.18, maybe they decide to push bug 14201 and obsolete this one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 12:16:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 11:16:04 +0000 Subject: [Koha-bugs] [Bug 15535] New: can't call method "default-privacy" on an undefined value /usr/share/koha/lib/c4/members.pm line 753 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15535 Bug ID: 15535 Summary: can't call method "default-privacy" on an undefined value /usr/share/koha/lib/c4/members.pm line 753 Change sponsored?: --- Product: Koha Version: 3.22 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: irfan.mirza at uettaxila.edu.pk QA Contact: testopia at bugs.koha-community.org When I try to create a patron from opac. A message appears (can't call method "default-privacy" on an undefind value /usr/share/koha/lib/c4/members.pm line 753) on submitting the form after filling it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 20:03:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 19:03:17 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 21:41:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 20:41:03 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #17 from Liz Rea --- Sweet as, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 22:54:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 21:54:35 +0000 Subject: [Koha-bugs] [Bug 4338] Consistent Interface To Currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4338 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I think some of the problems have probably been addressed by the tax rewrite. This is a really old bug and there are no other bugs dependent on it. I think we will need more specific information about remaining issues to continue here. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 23:14:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 22:14:17 +0000 Subject: [Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- I looked it up with the splitter tool: bug 8367 - needs sign-off bug 15407 - needs sign-off bug 15354 - passed qa bug 9805 - failed qa bug 14695 - failed qa I'd like to wait a bit too - there is currently no new work dependent on the clean-up and it will make it harder for other patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 23:39:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 22:39:26 +0000 Subject: [Koha-bugs] [Bug 14481] Warns when setting permissions for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 --- Comment #10 from Aleisha Amohia --- So this warn only shows up when no authorized value has been chosen for roadtype. I've found ways to make the warn disappear, but then it doesn't display the roadtype in the address where it should. Any suggestions for a patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 23:42:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 22:42:21 +0000 Subject: [Koha-bugs] [Bug 14641] Warns in subscription-add.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 --- Comment #6 from Aleisha Amohia --- (In reply to Joonas Kylm?l? from comment #2) > The warning is triggered when get_letter_loop() is called without an > argument. We should maybe check if @_ is true, and if it's not then use $_ > or "" as the value? I'm pretty new to perl so don't really know how I would write this. Do you have any suggestions so that we can give this bug a patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 23:42:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 22:42:43 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 23:43:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 22:43:51 +0000 Subject: [Koha-bugs] [Bug 15531] Add support for standing orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 10 23:45:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 22:45:13 +0000 Subject: [Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 00:10:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 23:10:16 +0000 Subject: [Koha-bugs] [Bug 15517] deleted tables differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi Jonathan, thx for catching this! Something weird: After applying the patch and running the database update (I verified in MySQL Workbench that both tables match now) I still have the 2 tests failing for password and userid. It seems like it's not looking at the right db or has outdated information. Do you have an idea why this could happen? The other thing - shouldn't the test message not be: ok - ... don't differ ...? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 00:17:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 23:17:30 +0000 Subject: [Koha-bugs] [Bug 15517] deleted tables differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 --- Comment #6 from Katrin Fischer --- ... should read better... misc/devel/update_dbix_class_files.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 00:18:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 23:18:25 +0000 Subject: [Koha-bugs] [Bug 15517] Tables borrowers and deletedborrowers differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|deleted tables differ again |Tables borrowers and | |deletedborrowers differ | |again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 00:25:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 23:25:22 +0000 Subject: [Koha-bugs] [Bug 15517] Tables borrowers and deletedborrowers differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 00:25:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 23:25:25 +0000 Subject: [Koha-bugs] [Bug 15517] Tables borrowers and deletedborrowers differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46457|0 |1 is obsolete| | Attachment #46458|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 46466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46466&action=edit [PASSED QA] Bug 15517: Resync borrowers and deletedborrowers tables The 2 columns password and userid are not sync and could cause errors when deleting patrons. Signed-off-by: Hector Castro Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 00:25:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 23:25:59 +0000 Subject: [Koha-bugs] [Bug 15517] Tables borrowers and deletedborrowers differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 --- Comment #8 from Katrin Fischer --- Created attachment 46467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46467&action=edit [PASSED QA] Bug 15517: deleted* tables won't never differ anymore! These tests will ensure that the 4 deleted* tables won't never differ anymore. Test plan: 0/ Do not execute the update DB entry 1/ prove t/db_dependent/db_structure.t should fail 2/ Execute the update DB entry and update the schema with misc/devel/update_dbix_class_files.pl 3/ prove t/db_dependent/db_structure.t should now be happy Signed-off-by: Hector Castro Test pass successfuly. Works as advertised Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 00:31:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 23:31:56 +0000 Subject: [Koha-bugs] [Bug 15469] Authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 --- Comment #10 from Katrin Fischer --- It looks like you are right - it was wrong before! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 00:33:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 23:33:55 +0000 Subject: [Koha-bugs] [Bug 15469] Authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 00:33:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 23:33:58 +0000 Subject: [Koha-bugs] [Bug 15469] Authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 --- Comment #11 from Katrin Fischer --- Created attachment 46468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46468&action=edit [PASSED QA] Bug 15469: Fix authority header search Introduced by bug 15381. The logs contain plenty of "detail.pl: No method value!" and the dropwdown list is not correctly populated (no value for options) Test plan: Go to the authority module and have a look at the auth type codes dropdown list. Without this patch, the values of the options are empty. With this patch, the values are correctly filled. Signed-off-by: Fr?d?ric Demians I confirm this patch silence noise in log file. Signed-off-by: Julian Maurice Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 00:34:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 23:34:28 +0000 Subject: [Koha-bugs] [Bug 15469] Authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 --- Comment #12 from Katrin Fischer --- Created attachment 46469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46469&action=edit [PASSED QA] Bug 15469: Same fix for the "entire record" tab Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 00:36:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 23:36:01 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 --- Comment #5 from Aleisha Amohia --- When 'intranetreadinghistory' is set to "don't allow', the circulation history tab disappears - was this the intention? if yes, happy to sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 00:43:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jan 2016 23:43:46 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #9 from Katrin Fischer --- I have no idea why, but 'Zooks' stays on top of list in the edit item screen no matter what I do. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 01:25:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 00:25:08 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #41 from Srdjan Jankovic --- In that case let's pick one. I have no problems with this being obsoleted in favour of 8352. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 01:42:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 00:42:30 +0000 Subject: [Koha-bugs] [Bug 12366] Better handling of Zebra errors when searching empty indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12366 --- Comment #1 from David Cook --- It might be worthwhile to re-look at "dontmerge" in light of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 01:59:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 00:59:49 +0000 Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #9 from David Cook --- Just noticed that http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 is using biblioitems.marc as a string... that would block this bug... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 02:02:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 01:02:08 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 --- Comment #37 from David Cook --- Comment on attachment 46021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46021 Bug 11084 - Delete biblios on Leader 05 == d Review of attachment 46021: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11084&attachment=46021) ----------------------------------------------------------------- ::: misc/cronjobs/delete_records_via_leader.pl @@ +67,5 @@ > +} > + > +my $schema = Koha::Database->new()->schema(); > +my @biblioitems = > + $schema->resultset('Biblioitem')->search( { marc => { LIKE => '_____d%' } } ); We're reading the 'marc' field as a string? While that's pretty fast on smaller databases, it takes about 60 seconds on a database with about 1.1 million bib records. I suppose performance doesn't matter too much for a cronjob though - depending on the frequency that it's run. Also, aren't we trying to get rid of the biblioitems.marc field? See: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Wouldn't it be better if we started indexing LDR05 as 'rstatus' or "record_status' or some such? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 02:07:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 01:07:37 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #38 from David Cook --- More over, if we indexed LDR05, we would be able to hide "deleted" records from the OPAC like we do with "suppressed" records. While we had to worry about that OpacSuppression bug, which erroneously returned 0 results when the OpacSuppression index was completely empty, we don't need to worry about that too much since we started using @attr 14=1 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198. We could prepend @attr 14=1 at the start of all queries (so that it applied to all query parts) and we wouldn't encounter that problem anymore. -- I desire the above behaviour also because of what David Noe originally described here. It would be nice if records with a LDR05 "d" were deleted during the overlay of existing records during an import. In my case, I'm downloading records via OAI-PMH, but when I get a record with a "deleted" status, I'm not given a metadata record. I just have an identifier and a deleted status. So I can create an empty MARC record, change LDR05 to "d", inject the identifier, and then match to existing records in Koha. However, I don't want to overlay an empty record over a non-empty record in Koha, and then have it show up in search results in the OPAC. Actually, I wouldn't want it to show up in search results in the staff client either, but that might be unavoidable... I suppose I could also add a fake title to the record like "This record has been deleted" or some such, although that's not translation friendly... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 02:31:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 01:31:57 +0000 Subject: [Koha-bugs] [Bug 15536] New: Additional match check comparison operators Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15536 Bug ID: 15536 Summary: Additional match check comparison operators Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org When http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 is pushed, the "required match checks" will work for Bibliographic records once again. At the moment, match checks work on an "equal" comparison, but I'm thinking it might be useful to have additional comparisons like >, <, >=, <=, and !=. (Well, string and numeric comparison operators...) Example: - Record 1b 005 > Record 1a 005 Import only if the record's 005 is newer than the existing record's 005. Admittedly, that's the only feasible example I can think of off the top of my head at the moment. I suppose you might require that the 942$c be "not equal" before updating, if you only want to update a subset of records that are missing some information. I suppose you should have figured that out beforehand and only tried importing the records you actually want to change. You might try a match check where the 250 edition statement is > or < but since it's a free-text field, that would probably be a bad idea. I suppose most cases of using additional comparison operators might be in regards to arbitrary data. Like maybe you only want to update target records if the match result has a 999$c < 1000 or something like that, but that seems unlikely and unwieldy at best. Just throwing it out here as an idea. It could be useful for the 005 at least. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 02:37:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 01:37:23 +0000 Subject: [Koha-bugs] [Bug 15537] New: Hide records on Leader 05 = d in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 Bug ID: 15537 Summary: Hide records on Leader 05 = d in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org At the moment, we hide "suppressed" records in the OPAC when they have a 942$n of 1 and when the OpacSuppression system preference is enabled. Why don't we also hide "deleted" records with a Leader position 05 of "d"? In the past, "OpacSuppression" would cause problems if there wasn't at least 1 record suppressed, but I fixed that with http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198. If we use the special attribute @attr 14=1 in the query (especially globally at the start of the query), we deactivate that problem in Zebra. So we could hide "deleted" records from the OPAC. We probably want to still show them in the staff client, so that they're findable. While a cronjob for removing these records has been added in master (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084), that cronjob might not always be run consistently by all Koha systems. Plus, it would be good to have that record hidden immediately from OPAC users, even if the record hasn't been fully deleted from the system yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 02:37:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 01:37:33 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15537 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 02:37:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 01:37:33 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11084 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 02:39:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 01:39:13 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 --- Comment #1 from David Cook --- All we'd need to do is change biblio-zebra-indexdefs.xml/xsl so that we're indexing LDR05, add "@attr 14=1 @not record_status=d" at the start of all OPAC queries (ie where we already have OPAC Suppression code), and we'd be fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 04:17:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 03:17:57 +0000 Subject: [Koha-bugs] [Bug 15458] Marc21 leader 07 error in translation: "a- Serial component" part is not in format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15458 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 04:23:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 03:23:44 +0000 Subject: [Koha-bugs] [Bug 15538] New: Use Koha::Logger in longoverdue.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538 Bug ID: 15538 Summary: Use Koha::Logger in longoverdue.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: srdjan at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Replace stdout debug prints with proper $logger->debug() calls -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 04:24:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 03:24:06 +0000 Subject: [Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |srdjan at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 04:37:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 03:37:07 +0000 Subject: [Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538 --- Comment #1 from Srdjan Jankovic --- Created attachment 46470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46470&action=edit bug_15538: Koha::Logger in longoverdue.pl * Removed --verbose option and replaved verbose prints with $logger->debug() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 04:37:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 03:37:05 +0000 Subject: [Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 05:28:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 04:28:33 +0000 Subject: [Koha-bugs] [Bug 15539] New: Create a ccl.properties alias for Identifier-other Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15539 Bug ID: 15539 Summary: Create a ccl.properties alias for Identifier-other Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl At the moment, the only way to access "Identifier-other" via CCL is to use "id-other" which is paired with 9012 in ccl.properties which is paired with "Identifier-other" in bib1.att. At a glance, it's not obvious that "id-other" is the qualifier for "Identifier-other", so I propose making an alias of "Identifier-other" which points to "id-other" or "1=9012". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 06:59:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 05:59:01 +0000 Subject: [Koha-bugs] [Bug 15540] New: Debian package option to set up an .onion address (Tor hidden service) for the OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15540 Bug ID: 15540 Summary: Debian package option to set up an .onion address (Tor hidden service) for the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: mirko at abunchofthings.net Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Created attachment 46471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46471&action=edit Working prototype screenshot Allow automatic setup of an .onion address pointing to the Koha OPAC. Automatic installation of Tor from the official repository if necessary. Easily upgradable to run a Tor relay or add other hidden services. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 07:15:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 06:15:07 +0000 Subject: [Koha-bugs] [Bug 15541] New: Prevent normalization during matching/import process Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Bug ID: 15541 Summary: Prevent normalization during matching/import process Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org By default, when you're using a matching rule during an import, the data from the incoming record for a match point is normalized using the following regex: $value =~ s/[.;:,\]\[\)\(\/'"]//g; $value =~ s/^\s+//; $value =~ s/\s+$//; $value =~ s/\s+/ /g; The first line removes all sorts of punctuation and other marks. The second removes leading spaces. The third removes trailing spaces. The fourth converts multiple spaces into a single space. -- While this might work well in many cases, it's a problem when you're trying to match using a URL. During matching, using CHR Zebra indexing, the following occurs: "http://libris.kb.se/resource/bib/219553" becomes "HTTPLIBRISKBSERESOURCEBIB219553" If you're using a URL index, it's stored in Zebra as "http://libris.kb.se/resource/bib/219553", so no match is made. If you're using a Phrase index, it's stored in Zebra as "http libris kb se resource bib 219553". If you're using a Word index, it's tokenized so that each little alphanumeric piece between punctuation parts is indexed separately. -- The solution seems to be to either prevent normalization all together, or to "replace punctuation with spaces" in accordance with the default word-phrase-utf.chr file. I'd have to review what would need to be done for ICU indexing... -- An additional problem is C4::Search::SimpleSearch, as it converts all colons (ie ":") into equal signs (ie "="). This is obviously a problem when you're searching for a URL as the URL is stored as "http://libris.kb.se/resource/bib/219553" but you're searching for "http=//libris.kb.se/resource/bib/219553". No match will be made. In this case, I think we could pass an additional flag to C4::Search::SimpleSearch asking it not to normalize the query. Since it's a simple search, we are often able to make the CCL qualifier choices before passing in the query argument, so this seems reasonable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 09:28:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 08:28:15 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #10 from Jonathan Druart --- Could you try to debug around cataloguing/additem.pl l.178 to 190? The GetItemTypes subroutine is called to construct the item types. $itemtypes should be an arrayref of item types, ordered by descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 09:35:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 08:35:14 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 --- Comment #6 from Marc V?ron --- (In reply to Aleisha Amohia from comment #5) > When 'intranetreadinghistory' is set to "don't allow', the circulation > history tab disappears - was this the intention? if yes, happy to sign off. Just tested without patch, it is the same behaviour. The explanation of 'intranetreadinghistory' is "[Allow / don't] allow staff to access a patron's checkout history (it is stored regardless)." So it makes sense that the tab disappears when 'intranetreadinghistory' is set to "don't allow". However, the explanation is not precise ('it is stored regardless'), I think it should be something like ('it is stored regardless if the patron has allowed to keep the reading history'). - That would be something for a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 09:36:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 08:36:07 +0000 Subject: [Koha-bugs] [Bug 15517] Tables borrowers and deletedborrowers differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 --- Comment #9 from Jonathan Druart --- Created attachment 46472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46472&action=edit Bug 15517: Change wording for tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 09:36:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 08:36:32 +0000 Subject: [Koha-bugs] [Bug 15517] Tables borrowers and deletedborrowers differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > The other thing - shouldn't the test message not be: > > ok - ... don't differ ...? Yep! Fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 09:52:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 08:52:21 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46016|0 |1 is obsolete| | --- Comment #61 from Nicholas van Oudtshoorn --- Created attachment 46473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46473&action=edit Bug 10988 - Rewrite and renamed to OpenIDConnect Fixes the concerns raised in comments 57 and 58. Renamed the settings to OpenID Connect, as opposed to OAuth2, since that better reflects what this is. Detailed comments on the changes: ** MARTIN: Comment #57 ** > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc > I disagree with this change.... I take your point - and have removed the offending lines >> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt > There's not enough added to this file. There should be a 'login with your google id' block somewhere which appears to be missing. You're right - that's in our customisations for our local site, but it makes sense to do it here! Done! > I think this needs rewording, it's a Google Login.. it's not automagic.. Fair point - reword to "Google login" > I'm not seeing an state tokens in use anywhere in this Flow.. without them we are wide open to cross-site request forgery (CSRF) attacks.. we likely need to create a nice randomised string and store it between invocations of the script. Done - I think. What do people think about the technique used. Wasn't too sure about how Koha does session handling, but think it's working now... ** David: Comment #58 ** > Alternatively, you could put the ClientID and the ClientSecret in koha-conf.xml. While it would give less control to libraries, it would keep this information on a more "need to know" basis. I personally think that it's better to put this in the preferences, since it's possible to regenerate these at any time. It makes it easier for these to be updated. Also, although they might be able to be changed, they can't be stolen since they are only valid for the redirect_url for koha. > How did you choose this endpoint? Both https://developers.google.com/identity/protocols/OpenIDConnect?hl=en#discovery and https://accounts.google.com/.well-known/openid-configuration provide versioned endpoints. Good question - no idea. Fixed this now. >tokeninfo isn't a standard OpenID Connect endpoint. Moved to the proper endpoints now. > As noted above, a standard response should be $json->{'iss'}, but otherwise this is good as per #2 at http://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation. Fixed now > As noted in #3 at http://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation, $json->{'aud'} (the standard claim), "may" be an array. I'm not familiar with Google's responses... it might always return a string, but the spec points out that you should check for either a string or an array (and to reject the token if it doesn't contain the expected audience or if it includes untrusted audiences). Put in a check to make sure that we're the only audience - but it looks like google only sends us a string > This is bizarre... the token shouldn't contain the email. That must be for debugging purposes in tokeninfo. You should have to get it from https://www.googleapis.com/oauth2/v3/userinfo or a similar endpoint, which also need its "sub" claim to be validated. Moved to a different endpoint. Not sure that we need to validate "sub", since we don't actually use it anywhere (Besides which, Google doesn't even think we need to validate the token as much as we are - see https://developers.google.com/identity/protocols/OpenIDConnect#obtainuserinfo for rationale) > At this point, you must also verify that the token type is "Bearer" (case insensitive as per RFC 6749 Section 5.1). Done > At this point, you must also be verifying that the token isn't expired. Done > You must also validate the "azp" claim if it's present in the response. Done Oh, and as in reply to Martin, Forgery protection is also done Test Plan (remains the same): 0) Back up your database 1) Apply all these patches 2) In your mysql client use your Koha database and execute: > DELETE FROM systempreferences; > SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql; -- Should be no errors. > SELECT * FROM systempreferences LIKE 'GoogleO%'; -- Should see 4 entries. > QUIT; 3) Restore your database 4) Run ./installer/data/mysql/updatedatabase.pl; 5) In your mysql client use your Koha database and execute: > SELECT * FROM systempreferences LIKE 'GoogleO%'; -- Should see the same 4 entries. 6) Log into the staff client 7) Home -> Koha administration -> Global system preferences 8) -> OPAC -- make sure your OPACBaseURL is set (e.g. https://opac.koha.ca) 9) -> Administration -- There should be a 'Google OAuth2' section with the ability to set those 4 system preferences. 10) In a new tab, go to https://console.developers.google.com/project 11) Click 'Create Project' 12) Type in a project name that won't freak users out, like your library name (e.g. South Pole Library). 13) Click the 'Create' button. 14) Click the 'APIs & auth' in the left frame. 15) Click 'Credentials' 16) Click 'Create new Client ID' 17) Select 'Web application' and click 'Configure consent screen'. 18) Select the Email Address. 19) Put it a meaningful string into the Product Name (e.g. South Pole Library Authentication) 20) Fill in the other fields as desired (or not) 21) Click 'Save' 22) Change the 'AUTHORIZED JAVASCRIPT ORIGINS' to your OPACBaseURL. (http://library.yourDNS.org) 23) Change the 'AUTHORIZED REDIRECT URIS' to point to the new googleoauth2 script (http://library.yourDNS.org/cgi-bin/koha/svc/auth/googleopenidconnect) 24) Click 'Create Client ID' 25) Copy and paste the 'CLIENT ID' into the GoogleOAuth2ClientID system preference. 26) Copy and paste the 'CLIENT SECRET' into the GoogleOAuth2ClientSecret system preference. 27) Change the GoogleOpenIDConnect preference to 'Use'. 28) Click 'Save all Administration preferences' 29) In the OPAC, click 'Log in to your account'. -- You should get a confirmation request, if you are already logged in, OR a login screen if you are not. -- You need to have the primary email address set to one authenticated by Google in order to log in. 30) Run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 09:52:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 08:52:38 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow login via Google |Allow login via Google |OAuth2 |OAuth2 (OpenID Connect) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 09:55:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 08:55:11 +0000 Subject: [Koha-bugs] [Bug 14481] Warns when setting permissions for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 --- Comment #11 from Jonathan Druart --- I am not sure it makes sense to remove this warning, it happens if there is a configuration issue. Moreover, there is something wrong with the display of the roadtype in the address. I am going to open a bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 10:02:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 09:02:15 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #62 from Nicholas van Oudtshoorn --- Created attachment 46474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46474&action=edit Remove some outdated wording from googleopenidconnect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 10:13:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 09:13:53 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #16 from Marcel de Rooy --- If I understood correctly, the problem is that we now have Borrowers::HasOverdues and Members::HasOverdues and similar for IsDebarred. Looking at the Borrowers plugin, not importing Overdues from Members there, resolves the warning for now and is consistent with the IsDebarred case. So I agree with Jonathan. Marc: Could you adjust your patch? Too bad btw that TT forces us to create a stub for each Koha routine we want to call in the templates. (Exception for OO modules as below) >From the TT docs: === If a regular Perl module supports an object-oriented interface and a new() constructor then it can be loaded and instantiated automatically like: [% USE file = IO.File('/tmp/mydata') %] === -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 10:24:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 09:24:38 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15542 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 [Bug 15542] Patron's information are not always displayed the same way -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 10:24:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 09:24:38 +0000 Subject: [Koha-bugs] [Bug 15542] New: Patron's information are not always displayed the same way Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Bug ID: 15542 Summary: Patron's information are not always displayed the same way Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 4041 The patron's information displayed in the member module (includes/circ-menu.inc and includes/member-display-address-style-*.inc) are not always displayed the same way. Sometimes the streetnumber is missing, sometimes it's the streettype. Sometimes the streettype is after the address, sometimes before... Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 [Bug 4041] Address Format as a I18N/L10N system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 10:29:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 09:29:28 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 10:29:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 09:29:30 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 --- Comment #1 from Jonathan Druart --- Created attachment 46475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46475&action=edit Bug 15542: Always display the patron's info the same way. The patron's information displayed in the member module (includes/circ-menu.inc and includes/member-display-address-style-*.inc) are not always displayed the same way. Sometimes the streetnumber is missing, sometimes it's the streettype. Sometimes the streettype is after the address, sometimes before... Test plan: Go on a patron detail page, and open all the tabs on the left (Check out, Fines, Notices, etc.) Without this patch, the patron's info displayed will differ from one page to another. With this patch, they will be displayed the same everywhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 10:29:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 09:29:52 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #2 from Jonathan Druart --- *** Bug 14481 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 10:29:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 09:29:52 +0000 Subject: [Koha-bugs] [Bug 14481] Warns when setting permissions for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #12 from Jonathan Druart --- This warning will be removed by bug 15542. *** This bug has been marked as a duplicate of bug 15542 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 10:31:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 09:31:50 +0000 Subject: [Koha-bugs] [Bug 15543] New: Add another option to membership_expiry.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15543 Bug ID: 15543 Summary: Add another option to membership_expiry.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 10:32:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 09:32:53 +0000 Subject: [Koha-bugs] [Bug 14834] Add range parameters to membership_expiry cronjob In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14834 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15543 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15543 [Bug 15543] Add another option to membership_expiry.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 10:32:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 09:32:53 +0000 Subject: [Koha-bugs] [Bug 15543] Add another option to membership_expiry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15543 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Depends on| |14834 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14834 [Bug 14834] Add range parameters to membership_expiry cronjob -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 10:36:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 09:36:32 +0000 Subject: [Koha-bugs] [Bug 14641] Warns in subscription-add.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 --- Comment #7 from Jonathan Druart --- The verbose way to do it is: my ($selected_lettercode) = @_; if ( not defined $selected_lettercode ) { $selected_lettercode = ''; } A better way, IMO is to use `unless` instead of `if not` my ($selected_lettercode) = @_; unless ( defined $selected_lettercode ) { $selected_lettercode = ''; } A much more better way is to do the same but more readable (because less verbose): my ($selected_lettercode) = @_; $selected_lettercode //= ''; `//=` means `assign what is at the right if what is at the left is not defined` `||=` would means `assign what is at the right if what is at the left is not defined or is 0 or is an empty string` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:00:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:00:52 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 --- Comment #17 from Marc V?ron --- (In reply to Marcel de Rooy from comment #16) > If I understood correctly, the problem is that we now have > Borrowers::HasOverdues and Members::HasOverdues and similar for IsDebarred. > Looking at the Borrowers plugin, not importing Overdues from Members there, > resolves the warning for now and is consistent with the IsDebarred case. So > I agree with Jonathan. > > Marc: Could you adjust your patch? > > Too bad btw that TT forces us to create a stub for each Koha routine we want > to call in the templates. (Exception for OO modules as below) > > From the TT docs: > === > If a regular Perl module supports an object-oriented interface and a new() > constructor then it can be loaded and instantiated automatically like: > [% USE file = IO.File('/tmp/mydata') %] > === "...not importing Overdues from Members there..." Sorry, I lost track here (Ik ben the kluts kwijt). Wasn't that what I did in my very first patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:05:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:05:24 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #14 from Jonathan Druart --- Comment on attachment 46464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46464 [SIGNED-OFF]Bug 15527: Custom stylesheet in extended mode Review of attachment 46464: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15527&attachment=46464) ----------------------------------------------------------------- ::: Koha/OAI/Server/Repository.pm @@ +111,5 @@ > > # Load configuration file if defined in OAI-PMH:ConfFile syspref > + my $conf = C4::Context->preference("OAI-PMH:ConfFile"); > + if ( $conf ) { > + $self->{ conf } = $conf = LoadFile( $conf ); What's the point of this change? I personally prefer the previous version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:11:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:11:34 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:20:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:20:15 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 --- Comment #3 from Marc V?ron --- This patch changes koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style-us.inc Is there also a need to change koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style-de.inc ? (See syspref AddressFormat) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:31:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:31:08 +0000 Subject: [Koha-bugs] [Bug 15526] Drop nozebra database table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:31:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:31:11 +0000 Subject: [Koha-bugs] [Bug 15526] Drop nozebra database table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15526 --- Comment #1 from Jonathan Druart --- Created attachment 46476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46476&action=edit Bug 15526: drop table nozebra This table is not used anymore and can be removed. Test plan: In your sql cli: SHOW TABLES; should return nozebra if your DB has been created before bug 7440. Apply this patch and execute the update DB entry. Now the table should have been dropped. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:31:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:31:43 +0000 Subject: [Koha-bugs] [Bug 15526] Drop nozebra database table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |7440 Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 [Bug 7440] Vestiges of NoZebra should be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:31:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:31:43 +0000 Subject: [Koha-bugs] [Bug 7440] Vestiges of NoZebra should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15526 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15526 [Bug 15526] Drop nozebra database table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:35:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:35:05 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:35:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:35:47 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #15 from Katrin Fischer --- Hi Alex and Julian, some things about this patch: - Can you please add a some information about the use case of this? I am not sure about how this is used in the library. - It seems to change the behaviour, but there are no new preferences or configuration options introduced. Bit worried about this. As this touches the complicated matter of holds, I'd like to ask for another sign-off. Also to get another opinion about the mechanics of it. Adding Marcel and Kyle in CC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:36:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:36:46 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #19 from Jonathan Druart --- (In reply to Patfrat from comment #18) > But i have no more Fast Add framework ! > DO you provide one for Unimarc in fr-FR language ? Sorry but I am a bit lost :) I confirm that there is a FA framework for UNIMARC installations, and I am able to create a record using it without getting any error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:37:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:37:49 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #16 from Marcel de Rooy --- Could you please clarify why an existing reserve and a new one should not be allowed to have some overlap in the period? In our case this may happen frequently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:39:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:39:27 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 --- Comment #18 from Marcel de Rooy --- (In reply to Marc V?ron from comment #17) > (In reply to Marcel de Rooy from comment #16) > > If I understood correctly, the problem is that we now have > > Borrowers::HasOverdues and Members::HasOverdues and similar for IsDebarred. > > Looking at the Borrowers plugin, not importing Overdues from Members there, > > resolves the warning for now and is consistent with the IsDebarred case. So > > I agree with Jonathan. > > > > Marc: Could you adjust your patch? > > > > Too bad btw that TT forces us to create a stub for each Koha routine we want > > to call in the templates. (Exception for OO modules as below) > > > > From the TT docs: > > === > > If a regular Perl module supports an object-oriented interface and a new() > > constructor then it can be loaded and instantiated automatically like: > > [% USE file = IO.File('/tmp/mydata') %] > > === > > "...not importing Overdues from Members there..." > Sorry, I lost track here (Ik ben the kluts kwijt). Wasn't that what I did in > my very first patch? No you removed the use completely there. You only should say: use Module qw(); In that case you do not import any routines in the current namespace. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:41:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:41:29 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 --- Comment #4 from Jonathan Druart --- Created attachment 46477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46477&action=edit Bug 15542: Change for the German style address format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:41:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:41:52 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 --- Comment #5 from Jonathan Druart --- (In reply to Marc V?ron from comment #3) > This patch changes > koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style-us.inc > > Is there also a need to change > koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style-de.inc > ? (See syspref AddressFormat) Yes of course, done in the second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:45:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:45:54 +0000 Subject: [Koha-bugs] [Bug 15535] can't call method "default-privacy" on an undefined value /usr/share/koha/lib/c4/members.pm line 753 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15535 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Could you please confirm that your system preference PatronSelfRegistrationDefaultCategory is filled with a valid patron category? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:46:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:46:10 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #20 from Patfrat --- After installing fresh version from debian repository with UNIMARC, no Fast Add was present for me ... but i have finally removed my Fast Add configuration and hidden a lot of fields in the default grid and all is working ! I will try to reinstall again Koha from debian package to see what could be wrong with FA ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:48:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:48:49 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:49:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:49:04 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 11:57:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 10:57:58 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #21 from Jonathan Druart --- (In reply to Patfrat from comment #20) > After installing fresh version from debian repository with UNIMARC, no Fast > Add was present for me ... but i have finally removed my Fast Add > configuration and hidden a lot of fields in the default grid and all is > working ! > > I will try to reinstall again Koha from debian package to see what could be > wrong with FA ! Have a look at the Koha log files when the installer is injecting data in DB. Maybe there is something going wrong during this step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:02:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:02:00 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 --- Comment #19 from Marc V?ron --- Created attachment 46478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46478&action=edit Bug 15135: Remove Warning Subroutine HasOverdues redefined In staff client, while displying patron related pages (e.g. moremember.pl) you get a warning like: moremember.pl: Subroutine HasOverdues redefined at /usr/share/kohaclone/Koha/Template/Plugin/Borrowers.pm line 52. This occurs with all pages that have [% USE Borrowers %] in their templates (directly or via members-toolbar.inc) To test: - Go to Home > Patrons > Patron details for.... - Search for warning above in log - Apply patch - Verify that no more warnings appear - Verify that patron pages behave as before (Solution as of comment #18) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:02:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:02:32 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46166|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:04:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:04:01 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 --- Comment #20 from Marc V?ron --- Not quit sure, should that go back to "Needs Signoff"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:12:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:12:29 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #21 from Marcel de Rooy --- (In reply to Marc V?ron from comment #20) > Not quit sure, should that go back to "Needs Signoff"? I will add a signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:16:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:16:01 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:16:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:16:04 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46478|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy --- Created attachment 46479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46479&action=edit Bug 15135: Remove Warning Subroutine HasOverdues redefined In staff client, while displying patron related pages (e.g. moremember.pl) you get a warning like: moremember.pl: Subroutine HasOverdues redefined at /usr/share/kohaclone/Koha/Template/Plugin/Borrowers.pm line 52. This occurs with all pages that have [% USE Borrowers %] in their templates (directly or via members-toolbar.inc) To test: - Go to Home > Patrons > Patron details for.... - Search for warning above in log - Apply patch - Verify that no more warnings appear - Verify that patron pages behave as before (Solution as of comment #18) Signed-off-by: Marcel de Rooy Verified that warning disappears with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:17:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:17:17 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch Depends on|12933 | QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |Passed QA --- Comment #23 from Marcel de Rooy --- This patch now received enough attention to pass QA. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 [Bug 12933] Add ability to print overdue slip from staff intranet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:17:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:17:17 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15135 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 [Bug 15135] Remove Warning Subroutine HasOverdues redefined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:17:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:17:18 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46394|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Comment on attachment 46394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46394 Bug 15306: Do not display the translate link if only 1 language is installed I think my sign-off here was on the alternative patch, but to make it sure I obsolete this one and sgn-off again on the alternative patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:23:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:23:30 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46391|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 46480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46480&action=edit [ALTERNATIVE-PATCH] Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:24:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:24:08 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:25:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:25:05 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #15 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #14) > Comment on attachment 46464 [details] [review] > [SIGNED-OFF]Bug 15527: Custom stylesheet in extended mode > > Review of attachment 46464 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/OAI/Server/Repository.pm > @@ +111,5 @@ > > > > # Load configuration file if defined in OAI-PMH:ConfFile syspref > > + my $conf = C4::Context->preference("OAI-PMH:ConfFile"); > > + if ( $conf ) { > > + $self->{ conf } = $conf = LoadFile( $conf ); > > What's the point of this change? I personally prefer the previous version. The $conf variable is used above (line 148) in order to get the new extended 'xslt' parameter: 148 $response->xslt( 149 $conf && $conf->{xslt} 150 ? $conf->{xslt} 151 : "/opac-tmpl/bootstrap/css/OAI.xslt" 152 ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:26:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:26:51 +0000 Subject: [Koha-bugs] [Bug 15544] New: Facets must be managed from the intranet Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544 Bug ID: 15544 Summary: Facets must be managed from the intranet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: juan.sieira at xercode.es QA Contact: testopia at bugs.koha-community.org Add the ability to manage the facets from the intranet. Nowadays the facets are hardcoded. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:27:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:27:12 +0000 Subject: [Koha-bugs] [Bug 15544] Facets must be managed from the intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544 Juan Romay Sieira changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |juan.sieira at xercode.es -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:28:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:28:57 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46479|0 |1 is obsolete| | --- Comment #24 from Jacek Ablewicz --- Created attachment 46481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46481&action=edit Bug 15135: Remove Warning Subroutine HasOverdues redefined In staff client, while displying patron related pages (e.g. moremember.pl) you get a warning like: moremember.pl: Subroutine HasOverdues redefined at /usr/share/kohaclone/Koha/Template/Plugin/Borrowers.pm line 52. This occurs with all pages that have [% USE Borrowers %] in their templates (directly or via members-toolbar.inc) To test: - Go to Home > Patrons > Patron details for.... - Search for warning above in log - Apply patch - Verify that no more warnings appear - Verify that patron pages behave as before (Solution as of comment #18) Signed-off-by: Marcel de Rooy Verified that warning disappears with this patch. Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:35:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:35:58 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:36:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:36:01 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 --- Comment #3 from Jonathan Druart --- Created attachment 46482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46482&action=edit Bug 2669: Change checkboxes to radio buttons on dictionary On creating new dictionary for report, the choice between "All dates" and "Date range" should be a real radio button, not 2 radio buttons with different names (which means they could be selected altogether...) Note that I don't understand what means 'All dates', there is no condition generated for the dictionary. We should not have to select a field if we don't want to add a condition on it :) Test plan: Create a new dictionary for the Patron module, then a date field (dateenrolled or birthdate, etc.) Confirm that the radio buttons now behave as radio buttons... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:36:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:36:09 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:51:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:51:42 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46480|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 46483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46483&action=edit Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 12:52:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 11:52:20 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 --- Comment #10 from Jonathan Druart --- Just removed a trailing warn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 13:39:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 12:39:03 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 13:39:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 12:39:06 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45640|0 |1 is obsolete| | Attachment #45641|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 46484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46484&action=edit Bug 15285: Update common files This patch moves the Button area all tables which does not redefine the dom/sDom DT parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 13:39:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 12:39:12 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #9 from Jonathan Druart --- Created attachment 46485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46485&action=edit Bug 15285: Update for 3 specific tables The checkouts, currency and items lost tables redefine the dom/sDom and the older C(olvis) should be replaced with the current B(utton). Test plan: To test the whole patch set, you will have to test the 4 tables impacted by this patch as well as the others using the columns settings. The additem has specific code and should be tested keeping that in mind. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 13:39:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 12:39:54 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #10 from Jonathan Druart --- I let CSS experts modify the style of the new button :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 13:40:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 12:40:04 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 14:08:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 13:08:11 +0000 Subject: [Koha-bugs] [Bug 1088] expand independant branches functionallity In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1088 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Is this bug still necessary? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 14:50:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 13:50:11 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 --- Comment #4 from Marc V?ron --- (In reply to Jonathan Druart from comment #3) (...) > Note that I don't understand what means 'All dates', there is no > condition generated for the dictionary. We should not have to select a > field if we don't want to add a condition on it :) Same findings with my tests: If "All dates" is set, the definition saves with an empty condition. (With and without patch, see dictionary.pl line 152.) To have a condition saved, "Date range" and at least one of the dates "Start of date range" and/or "End of date range" has to be set. Conclusion: The checkboxes rsp. radio buttons and the condition for their value in dictionary.pl line 152 could be removed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 15:17:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 14:17:35 +0000 Subject: [Koha-bugs] [Bug 15545] New: Optionally require notes when placing a hold Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Bug ID: 15545 Summary: Optionally require notes when placing a hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 15:17:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 14:17:53 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 15:19:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 14:19:24 +0000 Subject: [Koha-bugs] [Bug 9743] Allow customization for making hold notes required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |LATER Status|Needs Signoff |RESOLVED --- Comment #35 from Marcel de Rooy --- Closing this report; revised under a new report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 15:19:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 14:19:39 +0000 Subject: [Koha-bugs] [Bug 9743] Allow customization for making hold notes required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34526|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 15:20:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 14:20:52 +0000 Subject: [Koha-bugs] [Bug 9743] Allow customization for making hold notes required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15545 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 15:20:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 14:20:52 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9743 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 15:27:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 14:27:21 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 --- Comment #6 from Marc V?ron --- Sorry, with the syspref 'AddressFormat' set to German, I get: Template process failed: file error - parse error - member-display-address-style-de.inc line 7: unexpected token (roadtype_desc) [% if roadtype_desc %] at /usr/share/kohaclone/C4/Templates.pm line 121. Seems to be due to a missing blank: [%if roadtype_desc %] Makes it fail QA tools as well. BTW: In both the us and the de includes, the if statements are sometimes in capital letters ( [% IF )and sometimes not ( [% if ). Should / could that be streamlined? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 15:28:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 14:28:17 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 15:33:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 14:33:07 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 15:35:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 14:35:21 +0000 Subject: [Koha-bugs] [Bug 15516] RFC: Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 15:37:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 14:37:12 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #1 from Marcel de Rooy --- This report adds three cases where you could want to require a note when placing a hold. Each of these cases may be enabled separately via a system preference. (The hold note itself is triggered by OpacHoldNotes.) The three cases are: serial indication in the leader, collection indication in the leader, and MARC 300$a contains an indication of multiple parts/volumes (identified via a regular expression). A new sub in Reserves handles these cases and will be easily extensible. A unit test will be provided too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 15:38:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 14:38:40 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #26 from R?mi Mayrand-Provencher --- Created attachment 46486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46486&action=edit bug 12446 - Atomic update now sets canbeguarantee to 1 for categories of type C and P Same test plan applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 15:50:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 14:50:20 +0000 Subject: [Koha-bugs] [Bug 15546] New: Software Error for all access to Label Creator Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15546 Bug ID: 15546 Summary: Software Error for all access to Label Creator Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: library at bu-london.co.uk QA Contact: testopia at bugs.koha-community.org This software error message appears for each option selected in Label Creator. I am able to create a new template but when 'save' is selected, again the error message appears. Please advise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 15:50:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 14:50:46 +0000 Subject: [Koha-bugs] [Bug 15546] Software Error for all access to Label Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15546 --- Comment #1 from Charlotte Stock --- Software error: Can't use string ("-1") as an ARRAY ref while "strict refs" in use at /usr/share/koha/intranet/cgi-bin/labels/label-edit-template.pl line 120. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 15:59:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 14:59:02 +0000 Subject: [Koha-bugs] [Bug 15547] New: Location for stored OPAC header images Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15547 Bug ID: 15547 Summary: Location for stored OPAC header images Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: library at bu-london.co.uk QA Contact: testopia at bugs.koha-community.org Good afternoon We are currently customising our OPAC page and notice that Koha requires images to be stored at an https: address. Please could you advise how and where I should upload these images so that they can be displayed on our OPAC? Many thanks Charlotte Stock -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 16:02:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 15:02:27 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46477|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 46487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46487&action=edit Bug 15542: Change for the German style address format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 16:02:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 15:02:56 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 --- Comment #8 from Jonathan Druart --- The missing space already existed, but there were parenthesis. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 16:39:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 15:39:18 +0000 Subject: [Koha-bugs] [Bug 15546] Software Error for all access to Label Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15546 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- You should have an error in your Koha log file, do you have access to it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 16:45:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 15:45:43 +0000 Subject: [Koha-bugs] [Bug 15519] Warns when creating a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15519 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 16:45:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 15:45:46 +0000 Subject: [Koha-bugs] [Bug 15519] Warns when creating a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15519 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46431|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 46488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46488&action=edit Bug 15519: Warns when creating a basket To test: 1) Reproduce warn following steps above 2) Apply patch 3) Create a new basket and click Save. Do not add any items 4) Notice warn is gone 5) Click 'Delete this basket' and confirm that the validation message reads: "Are you sure you want to delete this basket?" Click cancel. 6) Add an order to the basket, then click 'Delete this basket'. Confirm the validation message gives more information and more delete options. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 16:45:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 15:45:57 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 16:46:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 15:46:23 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 16:47:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 15:47:02 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #169 from Jonathan Druart --- Koha::Patron please :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 16:47:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 15:47:05 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 16:49:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 15:49:54 +0000 Subject: [Koha-bugs] [Bug 15547] Location for stored OPAC header images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15547 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- I responded with this on the Koha mailing list: Koha doesn't require that your images be stored anywhere in particular. However if your Koha catalog runs over https and your images are hosted at a non-https location, the user's browser might give them "mixed content" warnings. I'm guessing this is what you're seeing? If you don't have the ability to upload your images to a location somewhere on your domain where they can be accessed via https perhaps you could ask your Koha support provider to place the images on the same server as Koha? I think this is a support issue rather than a bug, so I'm going to close the report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:00:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:00:30 +0000 Subject: [Koha-bugs] [Bug 15548] New: New patron related code should have been put to Patron instead of Borrower Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Bug ID: 15548 Summary: New patron related code should have been put to Patron instead of Borrower Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org As previously agreed, we need to standardize our wording, Borrower should be Patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:06:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:06:38 +0000 Subject: [Koha-bugs] [Bug 15535] can't call method "default-privacy" on an undefined value /usr/share/koha/lib/c4/members.pm line 753 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15535 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Testing: If PatronSelfRegistrationDefaultCategory is empty, the link for self registration is not displayed in OPAC If PatronSelfRegistrationDefaultCategory is set to a category that does not exist, the error can be triggered. It happens as well if there is a leading space char by mistake. Example with a valid category PT: [PT] -> OK [PT ] -> OK (one or more trailing space chars) [ PT] -> Software error (Leading space char) [ ] -> Software eror (one or more space chars) Maybe we could - validate the syspref field for not having leading spaces or spaces only - give some more explanation in the syspref descriptions for PatronSelfRegistration depending on a correct value for PatronSelfRegistrationDefaultCategory - add a warning on the about page (tab system information) if PatronSelfRegistration is set and PatronSelfRegistrationDefaultCategory is wrong or does not exist - not display the self registration link if PatronSelfRegistration is set and PatronSelfRegistrationDefaultCategory is wrong or does not exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:07:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:07:14 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Danielle Elder changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle at bywatersolutions.c | |om --- Comment #1 from Danielle Elder --- Other languages missing are Inuktitut (iku) and Inupiaq (ipk). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:11:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:11:28 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:11:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:11:31 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #1 from Jonathan Druart --- Created attachment 46489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46489&action=edit Bug 15548: Move new patron related code to Patron* The 'borrower' should not be used anymore, especially for new code. This patch move files and rename variables newly pushed (i.e. in the Koha namespace). Test plan: 1/ git grep Koha::Borrower should not return code in use. 2/ Prove the different modified test files 3/ Do some clicks in the member^Wpatron module to be sure there is not an obvious error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:24:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:24:37 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 --- Comment #9 from Marc V?ron --- On tab "Files" I get Software error: Global symbol "$address" requires explicit package name at /usr/share/kohaclone/members/files.pl line 126. Global symbol "$roadtype" requires explicit package name at /usr/share/kohaclone/members/files.pl line 127. Execution of /usr/share/kohaclone/members/files.pl aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:31:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:31:26 +0000 Subject: [Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 --- Comment #16 from Jonathan Druart --- Note that there is a failure when updating from 3.18 to 3.20: DBD::mysql::db do failed: Duplicate entry '1-self_checkout' for key 'PRIMARY' at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 10614. Upgrade to 3.20.03.003 done (Bug 14298: AutoSelfCheckID user should only be able to access SCO ) see https://lists.katipo.co.nz/pipermail/koha/2016-January/044539.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:32:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:32:33 +0000 Subject: [Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 --- Comment #17 from Jonathan Druart --- Sorry, c/p the wrong error: DBD::mysql::db do failed: Can't create table 'koha_library.#sql-4b9_42' (errno: 121) at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 10584. Upgrade to 3.20.03.001 done (Bug 14205: Deleting an Item/Record does not remove link to course reserve) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:43:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:43:32 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46475|0 |1 is obsolete| | Attachment #46487|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 46490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46490&action=edit Bug 15542: Always display the patron's info the same way. The patron's information displayed in the member module (includes/circ-menu.inc and includes/member-display-address-style-*.inc) are not always displayed the same way. Sometimes the streetnumber is missing, sometimes it's the streettype. Sometimes the streettype is after the address, sometimes before... Test plan: Go on a patron detail page, and open all the tabs on the left (Check out, Fines, Notices, etc.) Without this patch, the patron's info displayed will differ from one page to another. With this patch, they will be displayed the same everywhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:43:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:43:55 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 --- Comment #11 from Jonathan Druart --- Created attachment 46491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46491&action=edit Bug 15542: Change for the German style address format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:44:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:44:48 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 --- Comment #12 from Jonathan Druart --- Sorry about that Marc, this tab was not displayed on the install I have tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:48:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:48:47 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46490|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 46492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46492&action=edit Bug 15542: Always display the patron's info the same way. The patron's information displayed in the member module (includes/circ-menu.inc and includes/member-display-address-style-*.inc) are not always displayed the same way. Sometimes the streetnumber is missing, sometimes it's the streettype. Sometimes the streettype is after the address, sometimes before... Test plan: Go on a patron detail page, and open all the tabs on the left (Check out, Fines, Notices, etc.) Without this patch, the patron's info displayed will differ from one page to another. With this patch, they will be displayed the same everywhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:48:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:48:50 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46491|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 46493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46493&action=edit Bug 15542: Change for the German style address format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:54:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:54:17 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46492|0 |1 is obsolete| | --- Comment #15 from Marc V?ron --- Created attachment 46494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46494&action=edit Bug 15542: Always display the patron's info the same way. The patron's information displayed in the member module (includes/circ-menu.inc and includes/member-display-address-style-*.inc) are not always displayed the same way. Sometimes the streetnumber is missing, sometimes it's the streettype. Sometimes the streettype is after the address, sometimes before... Test plan: Go on a patron detail page, and open all the tabs on the left (Check out, Fines, Notices, etc.) Without this patch, the patron's info displayed will differ from one page to another. With this patch, they will be displayed the same everywhere. Followed test plan, works as expected. (Tested both patches together.) Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:55:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:55:14 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46493|0 |1 is obsolete| | --- Comment #16 from Marc V?ron --- Created attachment 46495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46495&action=edit Bug 15542: Change for the German style address format Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 17:55:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 16:55:46 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 18:21:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 17:21:41 +0000 Subject: [Koha-bugs] [Bug 15549] New: Forgive fines when checking out a currently checked out item Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15549 Bug ID: 15549 Summary: Forgive fines when checking out a currently checked out item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 46496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46496&action=edit Current yellow box When checking out to a patron you sometimes discover an item that was on the shelf was never checked in. In a fines library it would be nice to have the option to forgive fines when checking in/checkout out the item using the yellow box. It would eb nice to have a checkbox on the yellow box to allow for this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 18:41:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 17:41:29 +0000 Subject: [Koha-bugs] [Bug 15508] Select which library a staff user can login as In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15508 --- Comment #1 from Christopher Brannon --- This permission would need to exclude superlibrarian. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 19:49:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 18:49:44 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Testing with patch: t/db_dependent/Circulation.t OK t/db_dependent/Members.t OK t/db_dependent/Hold.t OK t/db_dependent/Item OK t/db_dependent/Koha_Misc_Files.t (OK) t/db_dependent/Patron.t OK t/db_dependent/Patrons.t OK t/db_dependent/Virtualshelves.t OK t/Patron.t OK t/db_dependent/Accounts.t OK t/db_dependent/BiblioObject.t OK t/db_dependent/Circulation/AnonymiseIssueHistory.t (Fails with and without patch, could be related to my test server) t/db_dependent/Creators/Lib.t (OK) t/db_dependent/Hold.t (OK) t/db_dependent/Koha_borrower_modifications.t (OK) t/db_dependent/Borrower_Debarments.t OK t/db_dependent/Borrower_Discharge.t OK t/db_dependent/Borrower_Files.t OK t/db_dependent/Review.t t/db_dependent/api/v1/patrons.t (Fails with and without patch) I think somebody else should run all the tests as well (especially the two failing without and with patches). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 21:10:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 20:10:05 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #11 from Katrin Fischer --- I think it must have been some hidden whitespace. I reentered all descriptions, didn't notice an additional space, but after that - it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 21:14:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 20:14:21 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 21:14:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 20:14:24 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46274|0 |1 is obsolete| | Attachment #46275|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 46497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46497&action=edit [PASSED QA] Bug 15337: Add tests to ensure that GetItemTypes will return element ordered by desc See comment #3 Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 21:15:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 20:15:18 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 21:18:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 20:18:03 +0000 Subject: [Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #2 from H?ctor Eduardo Castro Avalos --- Good catch, Marc. If I want a staff patron has only access to one or two granular permissions, e.g., self_checkout, the System displays the circulation links. If patron clicks in one of the links, the program logs out the user and is presented with the error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 21:19:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 20:19:13 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #13 from Katrin Fischer --- Created attachment 46498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46498&action=edit [PASSED QA] Bug 15337: Make itemtypes retrieved with GetItemTypes ordered by descriptions Prior to this patch, the itemtypes were displayed ordered by the code (itemtypes.itemtype DB column). This patch will make them displayed by the description displayed (the translated description). Test plan: 0/ Do not apply this patch set 1/ Confirm that the itemtypes are displayed ordered by code (when adding an item, cataloguing/additem.pl) 2/ Confirm that t/db_dependent/Koha.t does not pass 3/ Apply the test patch 4/ Confirm that t/db_dependent/Koha.t pass 5/ Confirm that the itemtypes are not displayed by description (on additem.pl) See comment #3 Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 21:21:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 20:21:11 +0000 Subject: [Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46265|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 46499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46499&action=edit [SIGNED-OFF]Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set If permission 'circulate_remaining_permissions' is not set, links to 'Circulation' (/circ/circulation-home.pl) on the intranet home page lead to an error message: "Error: You do not have permission to access this page." This patch hides the links if the permission is not set. To test: - Apply patch - Log in to the intranet (staff client) with a patron who has the permission 'circulate_remaining_pernissions' not set - Verify that no links to Circulation appear on the intranet start page (menu top left and menu in main page area) - Log in as a user who has the permission set. - Verify that te links appear as appropriate. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 21:21:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 20:21:35 +0000 Subject: [Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 21:57:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 20:57:43 +0000 Subject: [Koha-bugs] [Bug 15550] New: Authority type pull down in OPAC authority search is empty Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Bug ID: 15550 Summary: Authority type pull down in OPAC authority search is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart at bugs.koha-community.org In the authority search form in the OPAC the pull down for choosing the authority type appears empty. Maybe similar to the bug report for the staff authority search? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 21:58:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 20:58:20 +0000 Subject: [Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #1 from Katrin Fischer --- Search dies with Can't call method "authtypetext" on an undefined value at /home/katrin/kohaclone/opac/opac-authorities-home.pl line 155. Updating severity a bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:12:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:12:36 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #106 from Katrin Fischer --- Hi Jonathan, I (re)testd some more: NOW OK: - Patron account in staff > notices tab > HTML notices - System preferences containing HTML tags display them To test: search for 'note' in system preferences - Staff > detail page > MARC view > Items tab >   displays in URL column To test: Add a 952$u to one of multiple items - HTML tags in messages in the patron account ('new message' link) NOT OK: - HTML printer slips are broken To test: Patron account > print quick slip This shows still the same problem for and I don't see a patch with a matching description on the branch? - HTML tags in restriction/debarment comments Works partially - the restriction message on top of the patron account is ok. The entries in the little restrictions table inside the tab still appear broken - on the details and checkout tabs and also when editing a patron. Other test results: - OPAC is looking good, nothing found - Staff is looking good as well - no new findings. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:13:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:13:31 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 --- Comment #17 from Aleisha Amohia --- Thank you for this patch!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:16:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:16:58 +0000 Subject: [Koha-bugs] [Bug 14641] Warns in subscription-add.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:17:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:17:01 +0000 Subject: [Koha-bugs] [Bug 14641] Warns in subscription-add.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45623|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia --- Created attachment 46500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46500&action=edit Bug 14641: Warns in subscription-add.pl Removes warn using Jonathan's suggestion! To test: 1) Reproduce warns by clicking New Subscription 2) Apply patch 3) Click New Subscription again 4) Confirm warns are gone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:17:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:17:17 +0000 Subject: [Koha-bugs] [Bug 15551] New: checked out items not showing on returns.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551 Bug ID: 15551 Summary: checked out items not showing on returns.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 14821: Dont show item in checked in list, when it wasnt checked in. This is seen as a regression by some of our libraries -- checking an item in previously showed other items checked out by the same borrower, which was useful for renewing items and/or telling patrons what items they still had checked out. I would suggest a separate "Checked out by same borrower" list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:20:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:20:36 +0000 Subject: [Koha-bugs] [Bug 15551] checked out items not showing on returns.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hm, I am not sure about this - the new change should only avoid showing items which actually haven't been checked in - like items not checked out when performing the check in. Also - I don't think it ever showed other items checked out by the patron? Maybe they just followed the link from the checked in item? That should still work, if the patch you are referring didn't cause a bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:21:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:21:24 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:21:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:21:27 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45508|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia --- Created attachment 46501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46501&action=edit Bug 15096: Export today's checked in barcodes: Display warning if reading history is set to "never" If a patron's privacy settings are set to "Never" for keeping a reading history, "Export today's checked in barcodes" returns an empty file. This patch skips the export if such privacy rule is set and dsiplays a message. To test: - Apply patch - Search for a user who has privacy rules set to never keeping a circulation history - Check out / check in in some items - On users detail page, go to More->Export today's checked in barcodes - Verify that a message appears about user's privacy settings (in same window) - Click left tab "Circulation history" - Verify that the same message appearsar - Verify the same with the other conditions that prevent the display of the user's circulation history: - Syspref 'intranetreadinghistory' is 'Don't allow' - Patron is 'Anonymous patron' (syspref 'Anonymous patron') - Search for a user who allows circulation history - repeat steps above, verify that circulation history appears (if allowed by syspref 'intranetreadinghistory' and that today's checkouts are exported. (Amended for comment #3) Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:25:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:25:02 +0000 Subject: [Koha-bugs] [Bug 15552] New: Better wording of intranetreadinghistory syspref Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 Bug ID: 15552 Summary: Better wording of intranetreadinghistory syspref Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently says: "(Allow/Don't allow) staff to access a patron's checkout history (it is stored regardless)." It has been suggested that this could be worded better. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:25:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:25:14 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 --- Comment #8 from Aleisha Amohia --- (In reply to Marc V?ron from comment #6) > However, the explanation is not precise ('it is stored regardless'), I think > it should be something like ('it is stored regardless if the patron has > allowed to keep the reading history'). - That would be something for a > separate bug. See Bug 15552. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:34:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:34:30 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Karl Holten changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:35:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:35:15 +0000 Subject: [Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:35:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:35:18 +0000 Subject: [Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 --- Comment #1 from Aleisha Amohia --- Created attachment 46502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46502&action=edit Bug 15552: Better wording of intranetreadinghistory To test: 1) Find intranetreadinghistory system preference in Administration 2) Confirm new description gives more information and makes sense -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:40:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:40:59 +0000 Subject: [Koha-bugs] [Bug 15553] New: cgisess_ files polluting the /tmp directory Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Bug ID: 15553 Summary: cgisess_ files polluting the /tmp directory Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: philippe.blouin at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org When some users want to improve performance, they get the recommandation to switch the syspref "sessionstorage" to 'tmp', which store the session info in the /tmp directory instead of the database. Depending on the frequency of the cleaning process (or lack thereof), this can be heavy pollution into the /tmp directory, making it unusable. "rm cgi*" would not even work since cgi* extends to over 8000 items... A simple fix is to modify the target directory in C4/Auth.pm to /tmp/cgisess. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:45:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:45:55 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 --- Comment #1 from Blou --- Created attachment 46503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46503&action=edit Bug 15553 - cgisess_ files polluting the /tmp directory When some users want to improve performance, one suggestion is to switch the syspref "sessionstorage" to 'tmp', which store the session info in the /tmp directory instead of the database. Depending on the frequency of the cleaning process (or lack thereof), this can be heavy pollution into the /tmp directory, making it unusable. "rm cgi*" would not even work since cgi* extends to over 8000 items... A simple fix is to modify the target directory in C4/Auth.pm to /tmp/cgisess. Testing scenario: 1) change the syspref SessionStorage to 'tmp' 2) Log into the OPAC, validate that a file named /tmp/cgisess_(something) got created 3) Apply the patch 4) Log into the OPAC, validate that a file /tmp/cgisess/cgisess_(something) got created -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:50:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:50:25 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer --- Hm, I might have found a case where this doesn't work quite right: Apply patch. Follow test plan: - Make sure there is an overdue item with a fine. - Renew overdue item with due date A. - Observe that fine type changes from FU to F. - Check out the item again - with a different due date B. - Run fines again. - Observe that fine is now F - although it should still be accrueing and FU. Kyle, can you please check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:51:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:51:00 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |philippe.blouin at inlibro.com Status|NEW |Needs Signoff --- Comment #2 from Blou --- My initial plan was to have some value specific to each library (when multiple libraries on a server), but I didn't want to add a syspref, nor could I find an easy, meaningful value to reuse. Deleting the dir poses no problem, since CGI:Session creates the directory when needed, owned by www-data (or equivalent). I only tested on Ubuntu & Debian. No Windows. I added that for our benefit, thought it might be useful to others. No biggie if no one's interested :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:51:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:51:39 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #21 from Katrin Fischer --- ... I should add that switching back to master and repeating the process with a third due date C closer to today, the new fine added is FU. So there seems to be a difference from this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:52:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:52:11 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com, | |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 22:52:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 21:52:49 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Karl Holten changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 23:00:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 22:00:13 +0000 Subject: [Koha-bugs] [Bug 14573] Correcting messages on OPAC error pages so they make more sense In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14573 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #3 from Aleisha Amohia --- *** This bug has been marked as a duplicate of bug 15288 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 23:00:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 22:00:13 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #38 from Aleisha Amohia --- *** Bug 14573 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 23:08:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 22:08:35 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #23 from Christopher Brannon --- Would LOVE it if this could get a QA. :) Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 23:08:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 22:08:45 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #46 from Aleisha Amohia --- There is a GetAge function already in C4::Members which I used to write a patch for Bug 14763. I am not saying this is a duplicate of that bug, because I feel this is slightly different to what my patch does, but is it possible to use that function for this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 23:09:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 22:09:42 +0000 Subject: [Koha-bugs] [Bug 15400] display patron age in useful places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #4 from Aleisha Amohia --- Is this similar to Bug 14763, but in more places? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 23:11:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 22:11:31 +0000 Subject: [Koha-bugs] [Bug 15385] News archive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15385 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Aleisha Amohia --- Patch doesn't apply: Applying: Bug 15385: News archive fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 15385: News archive -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 23:12:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 22:12:40 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #170 from Liz Rea --- May we have this heavily tested version in, and move it to the new namespace in a follow up? This is an egregiously missing feature, and one that we have been waiting a long, long time for. It's for the users, let's get it in. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 11 23:42:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 22:42:45 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #171 from David Cook --- As the local pedant in the Koha community, I'm with Liz on this one. While we shouldn't be adding anything to the C4 namespace, I think perhaps an exception should be made for this particular patch set, as the feature is rather important in modernizing Koha. Out in the world, there's pretty much no service where you can't reset your own password. Yet, you can't do it in Koha. Surely this frustrates users and puts a burden on librarians. It's an aspect of the modern web experience which Koha fails at. This patch set has been a long time coming. While it should be fairly easy to do a search and replace through the patches, mistakes do happen, and we'd probably need to re-test all the patches again to make sure that nothing was missed. It seems like it's already been tested to the Nth degree, so perhaps a pass should be made this one time. I suppose it would qualify as technical debt, and I hate technical debt. But this does seem to be an extraordinary case. If it were anything but a password reset, I'd say change the namespace. But this is such a missing piece of functionality in Koha, that I think the faster we get it in the better. Of course, I defer to the QA team and the RM. But just adding that perspective to the comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 00:01:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 23:01:28 +0000 Subject: [Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 00:01:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 23:01:31 +0000 Subject: [Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46436|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia --- Created attachment 46504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46504&action=edit Bug 14816: Fix multiple selection in item search Send each selected value as a separate parameter. Otherwise DataTables (or jQuery ?) joins all values with a comma Tested / compared with several combinations, e.g. "All libraries" vs all libraries checked. With patch result is the same (without, all libraries checked had zero result). Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 00:07:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 23:07:29 +0000 Subject: [Koha-bugs] [Bug 15554] New: Organize entries in ccl.properties Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15554 Bug ID: 15554 Summary: Organize entries in ccl.properties Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl At the moment, ccl.properties is fairly disorganized. Once upon a time, it may have been organized numerically or alphabetically, but that seems to have gone out the window a bit. It would be nicer if it followed a similar scheme to https://www.loc.gov/z3950/agency/defns/bib1.html That is, qualifiers and aliases would be grouped into Bib-1 attribute categories: 1. Use Attributes 2. Relation Attributes 3. Position Attributes 4. Structure Attributes 5. Truncation Attributes 6. Completeness Attributes -- Indexdata Extensions: 7. Sort 9. Ranking In other words, all entries that roughly follow the pattern "Qualifier 1=[A-Za-z0-9]+" would be grouped in "1. Use Attributes". Examples: Abstract 1=62 ab Abstract Any 1=1016 kw Any Likewise, entries following the pattern "Qualifier 2=[A-Za-z0-9]+" would be grouped in "2. Relation Attributes". Examples: lt 2=1 le 2=2 eq 2=3 ge 2=4 gt 2=5 ne 2=6 --- That said... maybe it makes sense to group together qualifiers that are functionally similar. Like everything found around the comment "# Koha Local-Use Authority Indexes" or "# Subdivisions". I'm not 100% sure how we should order qualifier (and alias) entries within their respective Bib-1 attribute categories. We could do it alphabetically or numerically (although some entries use index string names rather than numerical values. Example: Geographic-subdivision 1=Geographic-subdivision). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 00:08:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 23:08:32 +0000 Subject: [Koha-bugs] [Bug 15554] Organize entries in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15554 --- Comment #1 from David Cook --- In any case, it might also be good to have a test in "xt" which checks to make sure that no entries have been added or lost during the re-organization process... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 00:08:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 23:08:45 +0000 Subject: [Koha-bugs] [Bug 15554] Organize entries in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15554 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 00:12:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 23:12:22 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 00:12:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 23:12:25 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46482|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 46505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46505&action=edit Bug 2669: Change checkboxes to radio buttons on dictionary On creating new dictionary for report, the choice between "All dates" and "Date range" should be a real radio button, not 2 radio buttons with different names (which means they could be selected altogether...) Note that I don't understand what means 'All dates', there is no condition generated for the dictionary. We should not have to select a field if we don't want to add a condition on it :) Test plan: Create a new dictionary for the Patron module, then a date field (dateenrolled or birthdate, etc.) Confirm that the radio buttons now behave as radio buttons... Signed-off-by: Aleisha Looks so much nicer too! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 00:16:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 23:16:22 +0000 Subject: [Koha-bugs] [Bug 15526] Drop nozebra database table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15526 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 00:16:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 23:16:25 +0000 Subject: [Koha-bugs] [Bug 15526] Drop nozebra database table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15526 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46476|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 46506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46506&action=edit Bug 15526: drop table nozebra This table is not used anymore and can be removed. Test plan: In your sql cli: SHOW TABLES; should return nozebra if your DB has been created before bug 7440. Apply this patch and execute the update DB entry. Now the table should have been dropped. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 00:22:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 23:22:20 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Aleisha Amohia --- Patch doesn't apply: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/authorities-toolbar.inc Failed to merge in the changes. Patch failed at 0001 Bug 15360: Add a "Replace with Z39.50" button when editing an authority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 00:26:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 23:26:34 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #172 from Tim Hannah --- As a librarian I can confirm that the lack of this feature frustrates me, my colleagues and our users. We've been waiting for this for a while and would dearly love to have it sooner rather than later. I can't pretend to understand the ramifications of an imperfect namespace choice, but I know we currently lose users due to them being locked out and going elsewhere rather than approaching us for resets or reminders. If it can be released as is and fixed later, as Liz suggests, I for one would be very grateful. (And thanks for everyone's work on it. Looking forward to it, whenever we get it). Cheers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 00:26:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 23:26:46 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #107 from Katrin Fischer --- One more thing - I had to install 2 dependencies to get it to work. - Should both go into the PerlDependencies.pm file? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 00:27:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 23:27:02 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Aleisha Amohia --- Oops sorry, I realise now these patches are meant to be alternatives and tested separately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 00:32:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 23:32:01 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 --- Comment #9 from Aleisha Amohia --- I want to sign off on the alternative patch but the 'New from Z39.50' button now doesn't fit along the same line as the other buttons and would look much better if it did. Will sign off once that's fixed up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 00:44:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jan 2016 23:44:31 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 JD at TeTakere changed: What |Removed |Added ---------------------------------------------------------------------------- CC|joanned at tetakere.org.nz | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 01:26:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 00:26:11 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m --- Comment #15 from Jesse Weaver --- Kyle, Heather, does this changed script yield the same results? It passes my QA, as it just moves the date comparison into MySQL and preserves the --date functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 01:32:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 00:32:24 +0000 Subject: [Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 01:32:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 00:32:27 +0000 Subject: [Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46502|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 46507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46507&action=edit Bug 15552: Better wording of intranetreadinghistory To test: 1) Find intranetreadinghistory system preference in Administration 2) Confirm new description gives more information and makes sense Signed-off-by: Hector Castro Better wording and much better for translatability purposes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 01:33:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 00:33:56 +0000 Subject: [Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 03:25:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 02:25:55 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 --- Comment #2 from David Cook --- Created attachment 46508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46508&action=edit Bug 15537 - Hide records on Leader 05 = d in OPAC (follow-up) This follow-up adds a warning message on the detail page in the staff client, which says that the record will not appear in the OPAC. It also includes some logic in opac-detail.pl which prevents an OPAC user from visiting it directly. Test Plan: Apply the patch. 1) Visit a staff client page for a bib record with LDR05=d. 2) Note that there is a warning message saying that it will not be visible in the OPAC 3) Visit the corresponding OPAC page for the bib record 4) Note that you get a redirect to a 404. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 03:26:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 02:26:44 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 --- Comment #3 from David Cook --- Created attachment 46509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46509&action=edit Bug 15537 - Hide records on Leader 05 = d in OPAC Currently, if a bibliographic record has a record status of "deleted" (ie LDR05=d), it shows up in the catalogue. This patch indexes the LDR05 character into the Record-status index (already defined in bib1.att). It creates a CCL qualifier for that index, and it adds a condition to OPAC queries where it only returns records that do not have a LDR05 of "d". Test Conditions: 1) With QueryParser 2) Without QueryParser 3) With OpacSuppression 4) Without OpacSuppression Test Plan: Before applying patch: 1) Choose a bibliographic record and change the LDR05 to "d" 2) Try searching for that record in the OPAC 3) Note that it appears in the search results (or takes you directly to the record) Apply patch. After applying patch: 4) Try searching for that record in the OPAC 5) Note that the record doesn't appear in the search results 6) Re-try steps 4 & 5 with each of the 4 test conditions outlined above. It should work the same regardless of using the QueryParser or OpacSuppression. NOTE: When using the QueryParser, you might need to vary your syntax. For instance, w/ QP you'd need "local-number:492 || local-number:495" whereas w/o QP you'd need "local-number:492 or local-number:495". NOTE: For extra points, double-check the staff client to make sure that you can still find records that have a LDR05 of "d". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 03:28:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 02:28:18 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46508|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 03:28:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 02:28:26 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46509|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 03:28:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 02:28:39 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 --- Comment #4 from David Cook --- Created attachment 46510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46510&action=edit Bug 15537 - Hide records on Leader 05 = d in OPAC Currently, if a bibliographic record has a record status of "deleted" (ie LDR05=d), it shows up in the catalogue. This patch indexes the LDR05 character into the Record-status index (already defined in bib1.att). It creates a CCL qualifier for that index, and it adds a condition to OPAC queries where it only returns records that do not have a LDR05 of "d". Test Conditions: 1) With QueryParser 2) Without QueryParser 3) With OpacSuppression 4) Without OpacSuppression Test Plan: Before applying patch: 1) Choose a bibliographic record and change the LDR05 to "d" 2) Try searching for that record in the OPAC 3) Note that it appears in the search results (or takes you directly to the record) Apply patch. After applying patch: 4) Try searching for that record in the OPAC 5) Note that the record doesn't appear in the search results 6) Re-try steps 4 & 5 with each of the 4 test conditions outlined above. It should work the same regardless of using the QueryParser or OpacSuppression. NOTE: When using the QueryParser, you might need to vary your syntax. For instance, w/ QP you'd need "local-number:492 || local-number:495" whereas w/o QP you'd need "local-number:492 or local-number:495". NOTE: For extra points, double-check the staff client to make sure that you can still find records that have a LDR05 of "d". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 03:28:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 02:28:44 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 --- Comment #5 from David Cook --- Created attachment 46511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46511&action=edit Bug 15537 - Hide records on Leader 05 = d in OPAC (follow-up) This follow-up adds a warning message on the detail page in the staff client, which says that the record will not appear in the OPAC. It also includes some logic in opac-detail.pl which prevents an OPAC user from visiting it directly. Test Plan: Apply the patch. 1) Visit a staff client page for a bib record with LDR05=d. 2) Note that there is a warning message saying that it will not be visible in the OPAC 3) Visit the corresponding OPAC page for the bib record 4) Note that you get a redirect to a 404. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 03:28:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 02:28:57 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 03:29:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 02:29:42 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 --- Comment #6 from David Cook --- NOTE: I have not tested this in UNIMARC or NORMARC, although I've provided Zebra changes for both. They should be OK, but I haven't confirmed that to be the case. I have only tested MARC21. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 03:29:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 02:29:50 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 03:39:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 02:39:25 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 --- Comment #7 from David Cook --- ADDITIONAL TESTING NOTE: You'll need to re-index Zebra before this feature works... otherwise the Record-status index won't be populated... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 03:51:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 02:51:50 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 --- Comment #39 from David Cook --- Comment on attachment 46021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46021 Bug 11084 - Delete biblios on Leader 05 == d Review of attachment 46021: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11084&attachment=46021) ----------------------------------------------------------------- ::: misc/cronjobs/delete_records_via_leader.pl @@ +67,5 @@ > +} > + > +my $schema = Koha::Database->new()->schema(); > +my @biblioitems = > + $schema->resultset('Biblioitem')->search( { marc => { LIKE => '_____d%' } } ); Once Bug 15537 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537) is pushed, this could be replaced with the following query with C4::Search::SimpleSearch(): "Record-status=d" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 04:11:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 03:11:10 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #3 from H?ctor Eduardo Castro Avalos --- Hi Marc and Jonathan For me all involved tests works successfully t/Patron.t t/db_dependent/Accounts.t t/db_dependent/BiblioObject.t t/db_dependent/Circulation/AnonymiseIssueHistory.t t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t t/db_dependent/Creators/Lib.t t/db_dependent/Hold.t t/db_dependent/Koha_borrower_modifications.t t/db_dependent/Patron.t t/db_dependent/Patron/Borrower_Debarments.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_Files.t t/db_dependent/Patrons.t t/db_dependent/Review.t t/db_dependent/api/v1/patrons.t The next was renamed/removed Renamed t/Borrower.t Renamed t/db_dependent/Borrower.t Renamed t/db_dependent/Borrowers.t git grep Koha::Borrower showed entries in release notes for 3.18 only. I will start to test the modules implied. It seems to be that you only replaced "borrower" to "patron" but IMHO I think this needs a rigorous test plan since you changed a lot in this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 04:38:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 03:38:47 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|hector.hecaxmmx at gmail.com |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 04:56:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 03:56:59 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 05:17:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 04:17:21 +0000 Subject: [Koha-bugs] [Bug 15555] New: Index 024$a into Identifier-other:u url register when source $2 is uri Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 Bug ID: 15555 Summary: Index 024$a into Identifier-other:u url register when source $2 is uri Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Currently, 024$a is indexed into Identifier-other:w, even when it is a URI (e.g. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217) This causes problems because the "w" index type replaces punctuation with spaces, and tokenizes on spaces, so that the URI is decomposed into a series of values which are indexed separately. This is definitely not what you want when indexing a 024$a when it is a URI. For example: The url "http://libris.kb.se/resource/bib/219553" becomes the following: @^ http libris kb se resource bib 219553 Fortunately, the 024$2 subfield value tells us the source of the identifier, and "uri" is one of the valid options. So, when we have a 024$2=uri, we can index the 024$a using the "url" index type. (I'm also planning to index into the "phrase" index type for all 024$a as it performs the normalization but it doesn't tokenize based on the spaces, so this normal form may still be of use for urls and other identifiers that rely on punctuation for meaning.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 05:17:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 04:17:31 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 05:19:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 04:19:35 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 --- Comment #1 from David Cook --- Created attachment 46512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46512&action=edit Bug 15555 - Index 024$a into Identifier-other:u url register when source $2 is uri This patch indexes 024$a into the "phrase" index type, and the "url" index type, if the 024$2 equals "uri". TEST PLAN 1) Apply the patch. 1b) If you're using a gitified Koha or a git install, you'll need to upgrade your instance or copy your zebradb files over to /etc/koha/zebradb or your "kohadev" directory. 2) Add a 024$a with a URL like http://libris.kb.se/resource/bib/219553 to a bibliographic record 3) Re-index Zebra 4) Type "id-other,st-urx,fuzzy=http://libris.kb.se/resource/bib/219553" into the "Search the catalog" box in the Staff Client and search 5) Note that you retrieve your record NOTE: The fuzzy is required because Koha's query "parsing" functions change http:// to http=// which won't correctly match the value in the "Identifier-other:u" index. NOTE: Alternatively, you could do the following search instead: "id-other,phr=http libris kb se resource bib 219553". It would work as well by using the "Identifier-other:p" index. Advanced tester version: 4) In a terminal window, find the "koha-conf.xml" file in your "etc" directory. 5) Open "koha-conf.xml" and find . Copy the URI you find there. (e.g. unix:/home/dcook/koha-dev/var/run/zebradb/bibliosocket). 6) Type "yaz-client unix:/home/dcook/koha-dev/var/run/zebradb/bibliosocket" 7) After it connects, type "base biblios" and press enter 8) Type "format xml" and press enter 9) Type "elements zebra::index" and press enter 10) Type "f id-other,st-urx=http://libris.kb.se/resource/bib/219553" and press enter 11) Note that you should have at least one result 12) Type "show 1" 13) If you scroll through the results, you should find something like the following: @^ http libris kb se resource bib 219553 http libris kb se resource bib 219553 http://libris.kb.se/resource/bib/219553 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 05:19:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 04:19:58 +0000 Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15555 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 05:19:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 04:19:58 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |14217 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 [Bug 14217] Add a DOM syntax for specifying conditions on indexes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 05:25:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 04:25:50 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing error status 200 for unapi with no parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bad utf8 decode to unapi |Bad utf8 decode to unapi |and fixing blank screen |and fixing error status 200 |error status |for unapi with no | |parameters --- Comment #12 from H?ctor Eduardo Castro Avalos --- Thank you very much, Marcel. I've changed the name of the bug according with the info you sent me. I make the changes that you recommend it. I only changed the 200 Ok status if no parameters passed to script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 05:27:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 04:27:38 +0000 Subject: [Koha-bugs] [Bug 15541] Create additional normalizers for Record Matching Rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Prevent normalization |Create additional |during matching/import |normalizers for Record |process |Matching Rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 05:37:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 04:37:08 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bad utf8 decode to unapi |Bad utf8 decode to unapi |and fixing error status 200 |and fixing code status 200 |for unapi with no | |parameters | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 05:38:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 04:38:59 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45432|0 |1 is obsolete| | --- Comment #13 from H?ctor Eduardo Castro Avalos --- Created attachment 46513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46513&action=edit Bug 15190: Bad utf8 decode to unapi and fixing status code 200 Fix bad utf8 decoding, also fix status code 200 for no parameters passed to script To reproduce the issue in OPAC 1) Copy from LOC (Z39.50) ISBN 8467020113 or test it with whichever record with special characters 2) Open URL in OPAC cgi-bin/koha/unapi?id=koha:biblionumber:4&format=oai_dc play with oai_dc, srw_dc, mods, mods-full, mods3, mods3-full, rdfdc. Note: marcxml does not fail 3) Enter the new biblionumber for ISBN 8467020113 or the record of your choise 4) An oai_dc record will display, notice about the bad utf8 decoding characters 5) Search the record in OPAC 6) To reproduce code 200 Ok and 300 Multiple choices play with: cgi-bin/koha/unapi cgi-bin/koha/unapi?id=koha:biblionumber:4 7) If possible test in NORMARC (UNIMARC will launch an error because bug 15162) Test plan -Apply patch -Follow steps 2 to 6 -You will see no errors in utf8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 05:39:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 04:39:21 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 --- Comment #2 from David Cook --- Advanced testers: Here's the steps you need to do to upgrade your Koha's Zebra config, if you're using a git dev install: cd /home/dcook/git INSTALL_LOG="/home/dcook/koha-dev/misc/koha-install-log" cp $INSTALL_LOG backup-koha-install-log perl Makefile.PL --prev-install-log "$INSTALL_LOG" make make upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 05:39:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 04:39:23 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 05:46:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 04:46:44 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 --- Comment #8 from David Cook --- ADDITIONAL TESTING NOTE: Here's the steps you need to do to upgrade your Koha's Zebra config, if you're using a git dev install: cd /home/dcook/git INSTALL_LOG="/home/dcook/koha-dev/misc/koha-install-log" cp $INSTALL_LOG backup-koha-install-log perl Makefile.PL --prev-install-log "$INSTALL_LOG" make make upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 06:43:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 05:43:48 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 --- Comment #3 from David Cook --- NOTE: The output I've provided in the above comments has come from a Koha using CHR indexing. ICU indexing has different output, but the same behaviour. Here's what I see with "format xml" and "elements zebra::index": http://libris.kb.se/resource/bib/219553 Here's what I see with "format xml" and "elements index": http://libris.kb.se/resource/bib/219553 http://libris.kb.se/resource/bib/219553 However, this output is misleading. That's basically just the output of "xsltproc biblio-zebra-indexdefs.xsl ". It's pre-normalization and thus essentially meaningless. ----------- Only advanced users will look at yaz-client though. That being said, there are functional differences between ICU and CHR. For instance, the following query will work in CHR but NOT in ICU: id-other,phr=http libris kb se resource bib 219553 Conversely, the following query will work in ICU but not in CHR: id-other,phr=http libriskbse resource bib 219553 That's because we've configured tokenization and normalization to work differently between the two schemes. Fun, right? ICU uses the "l" tokenize rule from http://www.indexdata.com/yaz/doc/yaz-icu.html. That means it tokenizes based on slashes, spaces, and maybe some other characters I haven't discovered yet. You can verify that with the following commands: echo "THIS IS A TEST" | yaz-icu -x -c ./etc/zebradb/etc/phrases-icu.xml echo "THIS/IS/A/TEST" | yaz-icu -x -c ./etc/zebradb/etc/phrases-icu.xml Indeed, check out the following yaz-client output when using ICU: Z> f id-other,phr=http://libris.kb.se/resource/bib/219553 Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 12, setno 17 SearchResult-1: term=http cnt=12, term=libriskbse cnt=12, term=resource cnt=12, term=bib cnt=12, term=219553 cnt=12 records returned: 0 Elapsed: 0.001458 You can see the URL has been broken into 5 terms/tokens with ICU, while CHR does the following: Z> f id-other,phr=http://libris.kb.se/resource/bib/219553 Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 12, setno 13 SearchResult-1: term=http cnt=12, term=libris cnt=12, term=kb cnt=12, term=se cnt=12, term=resource cnt=12, term=bib cnt=12, term=219553 cnt=12 records returned: 0 Elapsed: 0.001119 We actually have 7 terms/tokens in the case of CHR! And that means that we don't want to try to outsmart Zebra by pre-normalizing our queries. We want to query Zebra with the exact same data that it indexed, because that way the normalization will be the same! Science! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 06:44:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 05:44:44 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 --- Comment #4 from David Cook --- Note that the above pertains to "phrases-icu.xml" specifically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 06:52:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 05:52:06 +0000 Subject: [Koha-bugs] [Bug 15541] Create additional normalizers for Record Matching Rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #1 from David Cook --- Here's my latest findings: Input: "http://libris.kb.se/resource/bib/219553" C4::Matcher::_normalize() = "HTTPLIBRISKBSERESOURCEBIB219553" Zebra CHR = "http libris kb se resource bib 219553" Zebra ICU = "http libriskbse resource bib 219553" It seems to me that the smartest thing to do is NOT to normalize with C4::Matcher::_normalize(), because we're probably going to get it wrong as we have above. Zebra indexes "http://libris.kb.se/resource/bib/219553" as "http libris kb se resource bib 219553" (CHR Phrase) or as "http libriskbse resource bib 219553" (ICU Phrase) or as "http://libris.kb.se/resource/bib/219553" (URL, which is a Charmap when using either CHR or ICU). If we query Zebra with "http://libris.kb.se/resource/bib/219553", it will normalize the query the same way that it normalized "http://libris.kb.se/resource/bib/219553" when it was originally indexing it, and we'll get a match. Of course, we can't necessarily stop using C4::Matcher::_normalize() as it's the default behaviour. Many people may count on that _normalize() without even knowing it... even if it's potentially working badly. I think what I want to do is create a new normalizer which does nothing, and call it "none" or "raw". That way, I'm passing to Zebra the same thing that it's seen before, and it will normalize it exactly the same way and the likelihood of an accurate match increases considerably. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 06:52:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 05:52:15 +0000 Subject: [Koha-bugs] [Bug 15541] Create additional normalizers for Record Matching Rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 06:59:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 05:59:24 +0000 Subject: [Koha-bugs] [Bug 15541] Create additional normalizers for Record Matching Rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #2 from David Cook --- Of course, what I've said isn't 100% true. There's one more obstacle between C4::Matcher::get_matches and Zebra's normalized indexes. And that's C4::Search::SimpleSearch(), which uses the s/:/=/g regex before sending the query. While that's trivial for Zebra's CHR and ICU indexing for words and phrases, since they just strip out punctuation anyway, it's a problem for Zebra's URL Charmap, which doesn't normalize URLs. So you'll get a failed match in that case. So I think a pure match would have to be done without any normalization before the query gets to Zebra. That should be easy enough to implement in C4::Matcher when it uses C4::Search::SimpleSearch(). Because it's a simple search, it shouldn't be normalizing the query anyway. I'll just add a flag so that you can do an unnormalized search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 07:39:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 06:39:03 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 07:39:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 06:39:07 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45971|0 |1 is obsolete| | --- Comment #154 from Fr?d?ric Demians --- Created attachment 46514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46514&action=edit Bug 13642: (followup) OAI-DC checked by default in OPAC modal -Fixing default option checked for OAI-DC in OPAC modal -Move OPAC modal to opac-detail-sidebar.inc to display in MARC view and ISBD view This follow-up fix the QA comment in comment 149 Signed-off-by: Fr?d?ric Demians Above issue fixed & usable also in MARC/ISBD view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 07:46:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 06:46:05 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #63 from Martin Renvoize --- Nice work Nick! I will be eagerly looking at this, hopefully this afternoon. Thanks for putting in all the hard work, so glad you followed through. :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 08:36:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 07:36:51 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 --- Comment #14 from Marcel de Rooy --- Great, Hector. Marc: if you can your signoff again, I can QA again.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 09:27:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 08:27:41 +0000 Subject: [Koha-bugs] [Bug 15556] New: 'In processing' status in result lists Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15556 Bug ID: 15556 Summary: 'In processing' status in result lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org A lot of library have an 'in processing' status of some kind. Sometimes a not for loan value is used for this task. This works nicely, except for the result lists in the OPAC, where the items show up as "for reference". It would be nice if it was possible to configure the "in processing" status of the library and show it in the result lists accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 09:32:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 08:32:33 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15552 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 09:32:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 08:32:33 +0000 Subject: [Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15096 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 09:39:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 08:39:33 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #4 from Marc V?ron --- (In reply to H?ctor Eduardo Castro Avalos from comment #3) > (...) > > For me all involved tests works successfully > Glad to hear. I'm quite sure that the two fails in my tests were related to some local issue on my VM. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 09:48:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 08:48:50 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #6 from Marc V?ron --- Jonathan and Aleisha, Since the radio buttons do not make much sense, couldn't we simply remove them? (See test and conclusion on comment #4) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 09:52:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 08:52:28 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #173 from Marc V?ron --- +1 for getting it in! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 09:59:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 08:59:06 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #174 from Katrin Fischer --- After thinking this over for a bit I would be in favor of pushing it as it is. This is a long needed development that probably predates most of the work in the Koha namespace. Changing the namespace now would require more testing and it might give us a lot of conflicts in other places. So it might be easier to fix the namespace separately after this is pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 10:05:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 09:05:18 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #175 from Magnus Enger --- +1 for getting this in ASAP. :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 10:29:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 09:29:44 +0000 Subject: [Koha-bugs] [Bug 3092] Data values storage and use 100 bug meta-bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3092 --- Comment #5 from Katrin Fischer --- I think we can't handle the bug as it currently stands, without someone taking the time to break it up into smaller 'bite size' bugs with descriptions and examples. The bug dates back to 2009 and as no such action has been taken since, I propose to close it in favor of smaller bug reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 10:36:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 09:36:13 +0000 Subject: [Koha-bugs] [Bug 3092] Data values storage and use 100 bug meta-bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3092 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #6 from Magnus Enger --- (In reply to Katrin Fischer from comment #5) > The bug dates back to 2009 and as no such action has been taken since, I > propose to close it in favor of smaller bug reports. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 10:38:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 09:38:15 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 --- Comment #7 from Jonathan Druart --- (In reply to Marc V?ron from comment #6) > Jonathan and Aleisha, > > Since the radio buttons do not make much sense, couldn't we simply remove > them? (See test and conclusion on comment #4) I would prefer another bug report, it won't be as easy as this patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 10:44:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 09:44:00 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 --- Comment #15 from Marc V?ron --- Hi H?ctor, The encoding is OK with the newest patch for example with: cgi-bin/koha/unapi?id=koha:biblionumber:45100&format=oai_dc (tested with all of: oai_dc, srw_dc, mods, mods-full, mods3, mods3-full, rdfdc) What should happen if I do: cgi-bin/koha/unapi?id=koha:biblionumber:45100&format=xxx cgi-bin/koha/unapi?id=koha:biblionumber:45100&format= What should happen if I use a biblionumber that does not exist? cgi-bin/koha/unapi?id=koha:biblionumber:999999999&format=oai_dc At the moment I get a blank page for all cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 10:46:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 09:46:09 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #24 from Jonathan Druart --- I would love to get an answer when I ask for a question. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 10:51:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 09:51:12 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 10:51:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 09:51:30 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46505|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 46515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46515&action=edit Bug 2669: Change checkboxes to radio buttons on dictionary On creating new dictionary for report, the choice between "All dates" and "Date range" should be a real radio button, not 2 radio buttons with different names (which means they could be selected altogether...) Note that I don't understand what means 'All dates', there is no condition generated for the dictionary. We should not have to select a field if we don't want to add a condition on it :) Test plan: Create a new dictionary for the Patron module, then a date field (dateenrolled or birthdate, etc.) Confirm that the radio buttons now behave as radio buttons... Signed-off-by: Aleisha Looks so much nicer too! Radio buttons display as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 10:52:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 09:52:06 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 10:58:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 09:58:08 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #15 from Fr?d?ric Demians --- This patch has a side effect on authorities creation (tested in 3.20.x). The authorities.pl run foreever, and adding a new authority is impossible. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:04:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:04:17 +0000 Subject: [Koha-bugs] [Bug 15557] New: Reports dictionary: Remove superfluous radio buttons for date entry Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15557 Bug ID: 15557 Summary: Reports dictionary: Remove superfluous radio buttons for date entry Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org In reports dictionary step 4, the form displays 2 radioboxes for "All dates" and for "Date range". If "All dates" is set, the definition saves with an empty condition. (With and without patch, see dictionary.pl line 152.) To have a condition saved, "Date range" and at least one of the dates "Start of date range" and/or "End of date range" has to be set. Conclusion: The checkboxes could be removed. This needs some changes in dictionary.pl line 152 and following. See Bug 2669, comment #4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:04:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:04:33 +0000 Subject: [Koha-bugs] [Bug 15557] Reports dictionary: Remove superfluous radio buttons for date entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15557 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |2699 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2699 [Bug 2699] Organization for Reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:04:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:04:33 +0000 Subject: [Koha-bugs] [Bug 2699] Organization for Reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2699 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15557 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15557 [Bug 15557] Reports dictionary: Remove superfluous radio buttons for date entry -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:05:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:05:14 +0000 Subject: [Koha-bugs] [Bug 15557] Reports dictionary: Remove superfluous radio buttons for date entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15557 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|2699 |2669 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2699 [Bug 2699] Organization for Reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:05:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:05:14 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15557 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15557 [Bug 15557] Reports dictionary: Remove superfluous radio buttons for date entry -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:05:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:05:14 +0000 Subject: [Koha-bugs] [Bug 2699] Organization for Reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2699 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15557 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15557 [Bug 15557] Reports dictionary: Remove superfluous radio buttons for date entry -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:22:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:22:37 +0000 Subject: [Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15381 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:22:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:22:37 +0000 Subject: [Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15550 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 [Bug 15550] Authority type pull down in OPAC authority search is empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:23:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:23:12 +0000 Subject: [Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:23:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:23:25 +0000 Subject: [Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:29:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:29:30 +0000 Subject: [Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:29:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:29:33 +0000 Subject: [Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 --- Comment #2 from Jonathan Druart --- Created attachment 46516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46516&action=edit Bug 15550: Fix authority search and detail at the OPAC The author of Bug 15381 (me!) has mismatch the objects he was manipulating and forgotten to update a template. for the opac-aythorities-home, the variable is named authority_types, not authtypesloop. In opac-authoritiesdetail.pl, the $record is a MARC::Record and there is no authtypecode method. We need to retrieve the authtypecode using the new Koha::Authorities module. Test plan: Search for authorities at the OPAC and click on the detail link to go to the detail page. Without this patch, you will get errors. With this patch, the errors should have gone and everything should work as before bug 15381. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:38:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:38:24 +0000 Subject: [Koha-bugs] [Bug 3092] Data values storage and use 100 bug meta-bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3092 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #7 from Marc V?ron --- (In reply to Magnus Enger from comment #6) > (In reply to Katrin Fischer from comment #5) > > The bug dates back to 2009 and as no such action has been taken since, I > > propose to close it in favor of smaller bug reports. > > +1 +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:44:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:44:23 +0000 Subject: [Koha-bugs] [Bug 15508] Select which library a staff user can login as In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15508 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:55:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:55:45 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:56:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:56:07 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #16 from Fr?d?ric Demians --- Created attachment 46517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46517&action=edit Bug 6657: Follow-up to fix error on authority creation Bug 6657 modified the way C4::Biblio::TransformHtmlToMarc operates in order to solve an issue occuring during biblio record cataloguing. But this function is also used by authorities cataloguing, and the code in this case is irrelevante. This followup allows to distinguish for which kind of record TransformHtmlToMarc is called: biblio/authority. A bug appears in authority creation without this patch in some circunstances: when authid is linked to 001 field. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:56:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:56:04 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:56:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:56:39 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44869|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 11:57:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 10:57:23 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 --- Comment #20 from Jonathan Druart --- This patch set has introduced a big issue on Koha::Authority (now Koha::Metadata::Authority). The authid method does not return the authid anymore... The tests in t/db_dependent/Koha_Authority.t are bad: they skipped if the authid does not exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 12:10:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 11:10:51 +0000 Subject: [Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 --- Comment #19 from Jonathan Druart --- These patches introduced some regressions: 1/ Tests failures, fixed by bug 15467 2/ At the intranet, the search box was broken, fixed by bu 15469 3/ At the OPAC, the search and detail were broken, will be fixed by bug 15550 4/ Not fixed yet: the merge authority is broken. It was already broken before and bug 15358 is going to fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 12:11:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 11:11:15 +0000 Subject: [Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15358 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 12:11:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 11:11:15 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15381 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 12:53:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 11:53:54 +0000 Subject: [Koha-bugs] [Bug 14892] Initial checkin of an item to be transferred shows incorrect holding location In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14892 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell --- (In reply to Nick Clemens from comment #0) > If an item from another branch is checked in (with AutomaticItemReturn=Do) a > transfer message yellow box appears, but in the checkins table the item > shows the home branch for both Home and Holding locations. A second checkin > updates the table correctly Are there not two different things happening here? If an item from Lib A is checked in at Lib B a transit is generated from B to A and the holding branch is set to the home branch A. The second checkin, when the item is no longer on loan, has no affect on the transit but changes the holding library back to B to record a 'last seen' there. What you're seeing after the initial checkin is the correct behaviour in that it is the explicit intention of the transit generating code. There is a certain ambiguity because the holding library can then be changed to record the last wanding location -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:01:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:01:13 +0000 Subject: [Koha-bugs] [Bug 13552] Added: debarredcomment and debarreddate in batch patrons modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 B?ra Lich changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |b.lichancova at polac.cz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:02:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:02:54 +0000 Subject: [Koha-bugs] [Bug 13552] Added: debarredcomment and debarreddate in batch patrons modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 --- Comment #1 from B?ra Lich --- It would be usefull for me too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:10:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:10:00 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:10:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:10:03 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45946|0 |1 is obsolete| | Attachment #45947|0 |1 is obsolete| | Attachment #45948|0 |1 is obsolete| | Attachment #45949|0 |1 is obsolete| | Attachment #45950|0 |1 is obsolete| | Attachment #45951|0 |1 is obsolete| | Attachment #45952|0 |1 is obsolete| | Attachment #45953|0 |1 is obsolete| | Attachment #45954|0 |1 is obsolete| | Attachment #45955|0 |1 is obsolete| | Attachment #45956|0 |1 is obsolete| | --- Comment #93 from Kyle M Hall --- Created attachment 46518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46518&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:10:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:10:14 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #94 from Kyle M Hall --- Created attachment 46519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46519&action=edit Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:10:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:10:17 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #95 from Kyle M Hall --- Created attachment 46520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46520&action=edit Bug 14610 - Add and update scripts Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:10:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:10:21 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #96 from Kyle M Hall --- Created attachment 46521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46521&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:10:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:10:24 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #97 from Kyle M Hall --- Created attachment 46522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46522&action=edit Bug 14610 [QA Followup] - Rename AR_PRINT to AR_SLIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:10:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:10:27 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #98 from Kyle M Hall --- Created attachment 46523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46523&action=edit Bug 14610 [QA Followup] - Remove bad copyright lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:10:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:10:31 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #99 from Kyle M Hall --- Created attachment 46524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46524&action=edit Bug 14610 [QA Followup] - Fix issuingrules database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:10:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:10:38 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #101 from Kyle M Hall --- Created attachment 46526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46526&action=edit Bug 14610 [QA Followup] - Change 'Open' to 'Pending' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:10:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:10:34 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #100 from Kyle M Hall --- Created attachment 46525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46525&action=edit Bug 14610 [QA Followup] - Make prompt tranlatable, only show comma if firstname is set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:10:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:10:45 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #103 from Kyle M Hall --- Created attachment 46528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46528&action=edit Bug 14610 - Update opac.css via less -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:10:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:10:41 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #102 from Kyle M Hall --- Created attachment 46527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46527&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:21:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:21:12 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #17 from Jonathan Druart --- Comment on attachment 46517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46517 Bug 6657: Follow-up to fix error on authority creation Review of attachment 46517: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6657&attachment=46517) ----------------------------------------------------------------- ::: C4/Biblio.pm @@ +2541,5 @@ > > if ( $tag < 10 ) { # no code for theses fields > # in MARC editor, 000 contains the leader. > + if ( $isbiblio && $tag == $biblionumbertagfield ) { > + $i += 4; Could you explain this line please? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:29:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:29:05 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6657 --- Comment #20 from Jonathan Druart --- Patch on bug 6657 could affect this one too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:29:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:29:05 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15358 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:29:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:29:43 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #104 from Kyle M Hall --- (In reply to Katrin Fischer from comment #80) > Hm, I tend to agree with Jonathan on first glance. I think the new object > code tends to be quite short and readable - so having it all in one file > seems easier to comprehend. Some of the newly introduced files by this patch > are really very short and the copyright/license is almost the biggest part > of them. A 1:1-relation between template and .pl file also often makes it > easier to navigate the code for me. I must respectfully disagree. I think assertion that this is without precedent is also incorrect. Please see modrequest.pl, placerequest.pl, and modrequest_suspendall.pl, add_message.pl, deletemem.pl, mod_debarment.pl, setstatus.pl for examples of similar behavior. At this point those scripts are simple enough that it may seem silly, but I'm sure memberentry.pl was quite simple when it was first written as well. Now it has if statments like: if ( ($op eq 'modify' || $op eq 'insert' || $op eq 'save'|| $op eq 'duplicate') and ($step == 0 or $step == 3 )){ I also believe the assertion that this duplicates code is incorrect. There is actually very little code shared between the two scripts if you don't count the boilerplate that all Koha cgi scripts have. Basically the duplicated code is the get_template_and_user call. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:31:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:31:55 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #105 from Kyle M Hall --- (In reply to Kyle M Hall from comment #104) In fact, circ/request-article-do.pl shouldn't even be calling get_template_and_user! That's my bad, I'll get that fixed up and then the code will be totally DRY! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:32:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:32:58 +0000 Subject: [Koha-bugs] [Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #37 from Jonathan Druart --- This patch set does not apply anymore. We will need tests here, the merge functionality is completely unstable at the moment and it seems dangerous to continue without good basis. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:33:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:33:28 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #18 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #17) > Comment on attachment 46517 [details] [review] > Bug 6657: Follow-up to fix error on authority creation > > Review of attachment 46517 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Biblio.pm > @@ +2541,5 @@ > > > > if ( $tag < 10 ) { # no code for theses fields > > # in MARC editor, 000 contains the leader. > > + if ( $isbiblio && $tag == $biblionumbertagfield ) { > > + $i += 4; > > Could you explain this line please? In @params array, for a control field (tag < 10), there is 4 entries. For example: tag_001_indicator1_816115 tag_001_indicator2_816115 tag_001_code_00_816115_723352 tag_001_subfield_00_816115_723352 So $i += 4 is done before next in order to move to the next field in the @params array. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:33:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:33:44 +0000 Subject: [Koha-bugs] [Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15358 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:33:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:33:44 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5572 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:38:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:38:39 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #106 from Kyle M Hall --- Created attachment 46529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46529&action=edit Bug 14610 [QA Followup] - Don't call get_template_and_user for request-article-do.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:43:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:43:13 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46529|0 |1 is obsolete| | --- Comment #107 from Kyle M Hall --- Created attachment 46530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46530&action=edit Bug 14610 [QA Followup] - Don't call get_template_and_user for request-article-do.pl or opac-request-article-do.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:52:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:52:10 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #21 from Julian Maurice --- Created attachment 46531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46531&action=edit Bug 15358: Authorities merge - submit only result record This patch removes parts of form that should not be submitted just before submit. The same is done on biblio merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 13:53:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 12:53:15 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:03:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:03:26 +0000 Subject: [Koha-bugs] [Bug 15517] Tables borrowers and deletedborrowers differ again In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Bug 15517 depends on bug 15478, which changed state. Bug 15478 Summary: Checksum mismatch when regenerating schema http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:03:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:03:26 +0000 Subject: [Koha-bugs] [Bug 15478] Checksum mismatch when regenerating schema In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Julian Maurice --- Does not concern stable versions, changing status to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:03:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:03:59 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #176 from Blou --- In the name of the whole personnel at inLibro, which I've cycled through to support this patch in the past 2.5 years (so many good people fell on the battlefield, see comment #102), I say "yeah! it's about time!". Of course, we're now at 180 comments and counting, so there's a side of me that would like to see that keep increasing and beat a record of some sort. ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:04:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:04:40 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #25 from Kyle M Hall --- (In reply to Jonathan Druart from comment #22) > (In reply to Kyle M Hall from comment #20) > > > > ::: Koha/Biblio.pm > > > > @@ +41,5 @@ > > > > > +or list of Koha::Item objects in list context. > > > > > + > > > > > +=cut > > > > > + > > > > > +sub items { > > > > > > > > Wouldn't be better to use a DBIx::Class relation? > > > > Something like bug 14819. > > > > No, we want to return a Koha::Object object, not a DBIC object. It would be > > most confusing if a Koha::Object method were to return a DBIC object instead > > of a Koha Object. > > And what about using the _wrap method? > I am afraid that we are going to introduce quickly circular dependencies in > the Koha namespace if we follow this way. The _wrap method would still require including Koha::Items, so that does not solve anything. In addition, you are assuming circular dependencies are always a bad thing. It is important to realize our objects are loosely coupled, rather than tightly coupled. Because of this, we could re-engineer Koha::Items to be anything we want inside, it's a black box. Koha::Biblio doesn't care how Koha::Items works, nor should it. In fact, using the _wrap method makes the objects more tightly coupled, as we are now accessing private methods and tying the objects together with a specific implementation. If we *really* want to decouple all of our objects, we need to build a factory to create all our objects whether they are Koha::Object(s) based or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:09:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:09:06 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43598|0 |1 is obsolete| | Attachment #43752|0 |1 is obsolete| | Attachment #43768|0 |1 is obsolete| | Attachment #43952|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 46532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46532&action=edit Bug 14694 - Make decreaseloanHighHolds more flexible This patch allows for more flexibility for determining when the number of holds a record has should trigger the reduction of the loan length for items on that record. This patch adds a new system preference decreaseLoanHighHoldsControl, which defaults to 'static', the original behavior of the feature. It also has a new behavior 'dynamic' which makes the feature only decrease the loan length if the number of holds on the record exceeds the number of holdable items + decreaseLoanHighHoldsValue. It also allows items to be filtered from the list of items based on the damaged, lost, not for loan, and withdrawn values even if those values would have allowed holds ( i.e. values < 0 ) Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set decreaseLoanHighHolds to Enable 4) Set decreaseLoanHighHoldsControl to "over the number of items on the record" 5) Set decreaseLoanHighHoldsDuration to 1 6) Set decreaseLoanHighHoldsValue to 3 7) Create a record with 5 items 8) Please 8 or more holds on the record 9) Check out one of the items to a patron 10) Note the loan length is reduced to 1 day 11) Set decreaseLoanHighHoldsValue to 3 to 2 12) Check out one of the items to a patron 13) Note the loan length is *not* reduced 14) Enbale all the filters possible in decreaseLoanHighHoldsIgnoreStatuses 15) Set one item to be damaged 16) Note the loan length is reduced 17) Unset the damaged status 18) Repeat steps 15 - 17 for lost, not for loan, and withdrawn Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:09:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:09:13 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #27 from Kyle M Hall --- Created attachment 46533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46533&action=edit Bug 14694 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:09:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:09:16 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #28 from Kyle M Hall --- Created attachment 46534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46534&action=edit Bug 14694 [QA Followup] - Fix typos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:09:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:09:18 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #29 from Kyle M Hall --- Created attachment 46535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46535&action=edit Bug 14694 [QA Followup] - Fix syspref order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:09:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:09:21 +0000 Subject: [Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:19:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:19:58 +0000 Subject: [Koha-bugs] [Bug 15558] New: To rename the patron expiration date field in patron screen Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15558 Bug ID: 15558 Summary: To rename the patron expiration date field in patron screen Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: tejoskumar at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hi team, Is it possible to rename the field "Expiration date:" in patron screen with a better word. Regards Suresh Kumar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:25:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:25:26 +0000 Subject: [Koha-bugs] [Bug 15453] Cannot download a list in the staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15453 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:37:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:37:03 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #19 from Jonathan Druart --- Looking at koha-tmpl/intranet-tmpl/prog/en/includes/merge-record.inc, it seems that this sequence could be different. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:47:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:47:01 +0000 Subject: [Koha-bugs] [Bug 15493] Export records using a CSV profile does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15493 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:48:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:48:56 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- [copying feedback I posted to koha-devel] On Sun, Jan 10, 2016 at 8:44 PM, David Cook wrote: > We can?t necessarily rely on all Koha instances running this cronjob, nor > can we rely on the frequency. Shouldn?t we be hiding these records from the > OPAC as soon as they?re marked as ?deleted?? > > I?ve opened a bug for this purpose: > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 I am in mild disfavor of this proposal, particularly as implemented in current patch. Using a cronjob to delete records where Leader/05 is set to 'd' is useful when the library has arranged their workflow such that they *know* that Leader/05 = 'd' is being used consistently to signify that a record is no longer wanted. However, for a library that has not hitherto cared about the values in that position, unconditionally suppressing the display of such records could come as an unwelcome surprise. That said, it is also a reasonable choice for a library to want to use the Leader/05 as suppression criterion. Consequently, I suggest adding a configuration option. For that matter, making it configurable (say, by allowing the library to specify a set of query additions for the purpose of filtering records from public display) could result in a more generally useful mechanism. > I admit that I have a special interest in this where I might > be overlaying existing records using a mostly empty skeleton > record generated from an OAI-PMH identifier and a OAI-PMH > deleted status (OAI-PMH doesn?t send metadata for deleted records). > I?d match the existing record in Koha using the identifier, and > then set LDR05 to ?d? in accordance with the OAI-PMH deleted > status. Then, that record would disappear from the OPAC, so that > end users don?t see this skeleton record. I do not find this a compelling use case as stated. If the goal is to allow harvesting and overlay records from an OAI-PMH provider to also delete bibs from a Koha database... coding so that the records are *actually* deleted seems more direct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:49:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:49:44 +0000 Subject: [Koha-bugs] [Bug 15412] Dropdowns in suspend holds date selector do not function in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15412 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:52:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:52:33 +0000 Subject: [Koha-bugs] [Bug 15467] AuthoritiesMarc.t is failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15467 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Julian Maurice --- Does not concern stable versions, changing status to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:55:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:55:35 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #20 from Fr?d?ric Demians --- OK. In any case, $i has to be increment before next. Otherwise the loop on the @params array never ends: that's what I get now on 3.20/3.22/master branches. I will just increment by 1, relying on this line to positionne $i on the array good element: } elsif ( $param =~ /^tag_(\d*)_indicator1_/ ) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:55:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:55:54 +0000 Subject: [Koha-bugs] [Bug 15466] Suggestions.t is failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15466 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:58:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:58:28 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46517|0 |1 is obsolete| | --- Comment #21 from Fr?d?ric Demians --- Created attachment 46536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46536&action=edit Bug 6657: Follow-up to fix error on authority creation Bug 6657 modified the way C4::Biblio::TransformHtmlToMarc operates in order to solve an issue occuring during biblio record cataloguing. But this function is also used by authorities cataloguing, and the code in this case is irrelevante. This followup allows to distinguish for which kind of record TransformHtmlToMarc is called: biblio/authority. A bug appears in authority creation without this patch in some circunstances: when authid is linked to 001 field. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 14:59:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 13:59:49 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46536|0 |1 is obsolete| | --- Comment #22 from Fr?d?ric Demians --- Created attachment 46537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46537&action=edit Bug 6657: Follow-up to fix error on authority creation Bug 6657 modified the way C4::Biblio::TransformHtmlToMarc operates in order to solve an issue occuring during biblio record cataloguing. But this function is also used by authorities cataloguing, and the code in this case is irrelevante. This followup allows to distinguish for which kind of record TransformHtmlToMarc is called: biblio/authority. A bug appears in authority creation without this patch in some circunstances: when authid is linked to 001 field. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 15:05:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 14:05:26 +0000 Subject: [Koha-bugs] [Bug 15511] Tabbed fines display on OPAC patron summary page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15511 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 15:24:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 14:24:51 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #22 from Fr?d?ric Demians --- It's better. Now the merge form is displayed. Authorities are merged. BUT Biblio records containing the rejected authority are not relinked to the retained authority. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 15:25:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 14:25:29 +0000 Subject: [Koha-bugs] [Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 --- Comment #38 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #37) > This patch set does not apply anymore. > We will need tests here, the merge functionality is completely unstable at > the moment and it seems dangerous to continue without good basis. Bug 15358 need to be fixed before doing anything here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 15:26:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 14:26:53 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Arve S?reide changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arve.soreide at kul.oslo.kommu | |ne.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 15:49:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 14:49:56 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 --- Comment #16 from Marcel de Rooy --- (In reply to Marc V?ron from comment #15) > Hi H?ctor, > > The encoding is OK with the newest patch for example with: > cgi-bin/koha/unapi?id=koha:biblionumber:45100&format=oai_dc > (tested with all of: oai_dc, srw_dc, mods, mods-full, mods3, mods3-full, > rdfdc) > > What should happen if I do: > > cgi-bin/koha/unapi?id=koha:biblionumber:45100&format=xxx > cgi-bin/koha/unapi?id=koha:biblionumber:45100&format= > > What should happen if I use a biblionumber that does not exist? > cgi-bin/koha/unapi?id=koha:biblionumber:999999999&format=oai_dc > > At the moment I get a blank page for all cases. Blank page is not an error. Unapi should return a http status code for bad requests. See comment11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 15:52:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 14:52:34 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #16 from Kyle M Hall --- (In reply to Jesse Weaver from comment #15) > Kyle, Heather, does this changed script yield the same results? It passes my > QA, as it just moves the date comparison into MySQL and preserves the --date > functionality. I did not think to check that, I was focused on performance testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:01:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:01:07 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer --- For us it's terribly important that the functionality remains unchanged and it's not quickly testable in Koha. Please don't rush this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:05:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:05:13 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #23 from Jonathan Druart --- What about setting biblionumbertagsubfield and biblionumbertagfield to an empty string at the beginning of the subroutine if we are processing an authority record? It would avoid to add lines to this code... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:10:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:10:32 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #24 from Fr?d?ric Demians --- No problem if you prefer. But do you agree with the principle of changing TransformMarcHtmlToMarc() signature, ie adding a second parameter to distinguish biblio/authority record? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:12:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:12:15 +0000 Subject: [Koha-bugs] [Bug 15559] New: Software error: Wide character in subroutine entry at /usr/share/perl5/MARC/Charset/Table.pm line 96. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15559 Bug ID: 15559 Summary: Software error: Wide character in subroutine entry at /usr/share/perl5/MARC/Charset/Table.pm line 96. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error Change sponsored?: --- Product: Koha Version: 3.20 Hardware: PC OS: Windows Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: german.uch.edu at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Buenos d?as estimados en mi sistema sigue este error al guardar un registro, yo ingreso en espa?o pero los los acentos ortogr?ficos cambian adjunto el error Software error: Wide character in subroutine entry at /usr/share/perl5/MARC/Charset/Table.pm line 96. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error por ejemplo la palabra educaci?n esta escrito asi y cuando gurdo me aparece asi educacin? por favor alguine me puede ayudar que procesos seguir soy bibliotecario ya tres meses ya esta asi y no puedo avanzar en calogaci?n -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:14:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:14:15 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #22 from Kyle M Hall --- I was unable to reproduce: http://screencast.com/t/LRtwBd6ax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:16:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:16:03 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #18 from Kyle M Hall --- (In reply to Katrin Fischer from comment #17) > For us it's terribly important that the functionality remains unchanged and > it's not quickly testable in Koha. Please don't rush this. Katrin, you are more than welcome to take point on QA for this bug. I wasn't QA'ing it, I was only doing performance testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:21:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:21:01 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #17 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #16) > Could you please clarify why an existing reserve and a new one should not be > allowed to have some overlap in the period? > In our case this may happen frequently. It seems to me that this is more like treating a hold as a true reservation than a hold. It's saying "This item will go to this patron on this date, so nobody else can have it on that date". Kind of like reserving a conference room. Now, whether we should have that behavior or not is a the real question or not. This link is for another ILS and at seems to explain Holds vs Reserves vs Reservations pretty well: http://www.goalexandria.com/totw/tips/2009/100509.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:22:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:22:49 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #18 from Kyle M Hall --- I should also note, we have Holds ( of course! ), we have Reserves ( aka Course Reserves ) but Koha doesn't really have Reservations as a first class feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:22:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:22:59 +0000 Subject: [Koha-bugs] [Bug 11884] SlipCSS and NoticeCSS should be CSS not a file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11884 --- Comment #4 from Nicole C. Engard --- This was talked about again today at a library. Anyone interested in tackling it? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:23:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:23:48 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #25 from Jonathan Druart --- Created attachment 46538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46538&action=edit Bug 6657: Add tests for TransformHtmlToMarc -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:24:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:24:26 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #26 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #24) > No problem if you prefer. But do you agree with the principle of changing > TransformMarcHtmlToMarc() signature, ie adding a second parameter to > distinguish biblio/authority record? No, I hate the idea :) But I don't see any other quick and easy solution. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:25:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:25:23 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #27 from Jonathan Druart --- (In reply to Jonathan Druart from comment #25) > Created attachment 46538 [details] [review] > Bug 6657: Add tests for TransformHtmlToMarc Regarding these tests, your patch is wrong. But the tests may be wrong too :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:26:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:26:15 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #42 from Kyle M Hall --- (In reply to Srdjan Jankovic from comment #41) > In that case let's pick one. I have no problems with this being obsoleted in > favour of 8352. Excellent! Thanks! *** This bug has been marked as a duplicate of bug 8352 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:26:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:26:15 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #82 from Kyle M Hall --- *** Bug 8034 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:26:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:26:17 +0000 Subject: [Koha-bugs] [Bug 8038] Enable network printing when UsePrintQueues is on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8038 Bug 8038 depends on bug 8034, which changed state. Bug 8034 Summary: Enable server print queue selection http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:29:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:29:09 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #19 from Katrin Fischer --- I hope to get around to it soon - but the more testing the better. Overdues are a bit of a complicated matter. We only actively use it with the overdue and notice triggers - if someone else could verify it works the same as before without -t that would be helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:36:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:36:58 +0000 Subject: [Koha-bugs] [Bug 15367] Batch patron modification: Data loss with multiple repeatable patron attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to master - Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:39:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:39:40 +0000 Subject: [Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher --- Pushed to master - Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:40:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:40:25 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:40:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:40:25 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #19 from Katrin Fischer --- Hi Kyle or Marcel, can you maybe explain the usual use case for the HoldDateInFuture setting? Maybe this will help to clear things up about the differences even more. I am not quite sure about myself and would like to understand better how it's currently used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:40:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:40:28 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45411|0 |1 is obsolete| | Attachment #45413|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 46539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46539&action=edit Bug 9805 - Lost items are un-lost if returned, but not if renewed. If an item has a lost status, that status is removed when the item is returned. However, it is not removed if the item is renewed. Test Plan: 1) Check an item out to a patron, back date the due date 6 months 2) Run misc/cronjobs/longoverdue.pl -l 30=2 --confirm 3) Verify the item is now checked out but lost 4) Renew the item, verify the item is still lost 5) Apply this patch 6) Renew the item again, verify the item is no longer lost Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:40:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:40:37 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 --- Comment #27 from Kyle M Hall --- Created attachment 46540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46540&action=edit Bug 9805 [QA Followup] - Control renewing and finding of lost items via circ rules Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Browse to the circ rules 4) Note the "Renew lost?" and "Renewal marks lost found" rules 5) Set and test each of the rules both ways for the rules for all libraries 6) Repeat but for a specific branch this time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:40:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:40:41 +0000 Subject: [Koha-bugs] [Bug 15367] Batch patron modification: Data loss with multiple repeatable patron attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 --- Comment #5 from Jonathan Druart --- Note: this could be implemented. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:40:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:40:40 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 --- Comment #28 from Kyle M Hall --- Created attachment 46541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46541&action=edit Bug 9805 [QA Followup] - Fix QA Issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:41:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:41:12 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #23 from Katrin Fischer --- I will retest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:41:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:41:33 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #24 from Kyle M Hall --- (In reply to Katrin Fischer from comment #23) > I will retest Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:44:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:44:47 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #20 from Kyle M Hall --- (In reply to Katrin Fischer from comment #19) > Hi Kyle or Marcel, > > can you maybe explain the usual use case for the HoldDateInFuture setting? > Maybe this will help to clear things up about the differences even more. I > am not quite sure about myself and would like to understand better how it's > currently used. I'm not the author of HoldDateInFuture ( iirc ), so I don't really know. I think that it is basically shoehorning Reservations behavior into holds, but since I don't have a use case, I may be wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:44:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:44:49 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #108 from Nick Clemens --- Two issues I saw: 1 - 'New request' messages are not being queued, I didn't see them when placing requests via opac or staff side 2 - Search from the article request tab only works with cardnumber. Enter patron name and press enter and the screen reloads. Works when you choose from the search options that appear as you type. Current search only checks at 3+ characters but should allow for 2 letter last names Everything else is request: * - There should be a 'Place request' button on detail.pl * - On article-requests.pl the count in the tab doesn't reload when you change the number (2 requests, mark one completed, the table updates but tab still says 2) * - Similarly, take action 'process request' and it disappears from the pending tab but does not show on the processing tab until you click update button or refresh page * - It would be nice to see article requests on circulation.pl and moremember.pl * - It would be nice to have an 'All libraries' option in the dropdown on article-requests.pl * - Article-requests.pl doesn't show owning library for a specific item request. I can follow the logic that all requests go to the pickup library, but they shold be able to see where the item is from. It might be nice to have the patrons library visible as well * - For consistency it would be nice to have the count of article requests show as holds do on detail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:46:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:46:53 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46537|0 |1 is obsolete| | --- Comment #28 from Fr?d?ric Demians --- Created attachment 46542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46542&action=edit Bug 6657: Follow-up to fix error on authority creation Bug 6657 modified the way C4::Biblio::TransformHtmlToMarc operates in order to solve an issue occuring during biblio record cataloguing. But this function is also used by authorities cataloguing, and the code in this case is irrelevante. This followup allows to distinguish for which kind of record TransformHtmlToMarc is called: biblio/authority. A bug appears in authority creation without this patch in some circunstances: when authid is linked to 001 field. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:47:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:47:03 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46538|0 |1 is obsolete| | --- Comment #29 from Fr?d?ric Demians --- Created attachment 46543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46543&action=edit Bug 6657: Add tests for TransformHtmlToMarc Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:48:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:48:02 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #30 from Julian Maurice --- What about replacing the 'while' loop by a good old 'for' loop ? This way, 'next' would increment the counter correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:48:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:48:40 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #31 from Fr?d?ric Demians --- > Regarding these tests, your patch is wrong. > But the tests may be wrong too :) +1 for UT! I've signed-off your patch, which works with amending the call to TransformHtmlToMarc (2nd parameter was missing). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:49:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:49:55 +0000 Subject: [Koha-bugs] [Bug 15560] New: holding branch missing in pending reserves report Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Bug ID: 15560 Summary: holding branch missing in pending reserves report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: sophie.meynieux at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In pending reserves report, when there are several items spread into several branches, libraries are not displaid any more. It's due to Bug 12152 that replaces branchcode with branchname but can't deal with a list of branchcodes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:50:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:50:34 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15560 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:50:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:50:34 +0000 Subject: [Koha-bugs] [Bug 15560] holding branch missing in pending reserves report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12152 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:50:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:50:52 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #32 from Julian Maurice --- Created attachment 46544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46544&action=edit Bug 6657: counter-patch Replace while by for -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:52:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:52:17 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #108 from Jonathan Druart --- Last 2 patches updated on the remote branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:52:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:52:39 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #14 from Sophie MEYNIEUX --- Replacement of code with name doesn't work for a list of codes. See bug 15560 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 16:58:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 15:58:28 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46544|0 |1 is obsolete| | --- Comment #33 from Fr?d?ric Demians --- Created attachment 46545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46545&action=edit Bug 6657: counter-patch Replace while by for Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:02:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:02:42 +0000 Subject: [Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Pushed to Master - thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:05:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:05:29 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:05:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:05:32 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #42 from Kyle M Hall --- Created attachment 46546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46546&action=edit Bug 14598 [QA Followup] - Make unit test pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:06:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:06:02 +0000 Subject: [Koha-bugs] [Bug 15512] Minor regression caused by Bug 7369 - warn on deleting item not triggered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- pushed to master thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:11:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:11:55 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46545|0 |1 is obsolete| | --- Comment #34 from Julian Maurice --- Created attachment 46547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46547&action=edit Bug 6657: TransformHtmlToMarc - rewrite the loop This rewrites the while loop into a for loop, so $i still gets incremented when we call next -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:13:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:13:04 +0000 Subject: [Koha-bugs] [Bug 15487] Encoding problem with item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15487 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher --- Pushed to master - Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:14:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:14:14 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #35 from Julian Maurice --- It seems that the "while -> for" rewrite is not enough alone, so I rewrite my patch to fit well with the others -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:16:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:16:55 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #21 from Katrin Fischer --- Ah, I thought it was yours - Holds... must be Kyle! Sorry! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:18:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:18:08 +0000 Subject: [Koha-bugs] [Bug 15477] Error handling on editing item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15477 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #12 from Brendan Gallagher --- pushed to master - thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:21:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:21:44 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #88 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 14695 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:21:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:21:48 +0000 Subject: [Koha-bugs] [Bug 8809] Cascading Holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8809 Bug 8809 depends on bug 7710, which changed state. Bug 7710 Summary: multiple holds per title http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:21:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:21:44 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia at bywatersolutions.com --- Comment #11 from Kyle M Hall --- *** Bug 7710 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:21:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:21:48 +0000 Subject: [Koha-bugs] [Bug 7065] reserves table needs a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065 Bug 7065 depends on bug 7710, which changed state. Bug 7710 Summary: multiple holds per title http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:24:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:24:30 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:24:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:24:33 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45061|0 |1 is obsolete| | Attachment #45063|0 |1 is obsolete| | Attachment #45064|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 46548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46548&action=edit Bug 14695 - Update database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:24:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:24:40 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #13 from Kyle M Hall --- Created attachment 46549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46549&action=edit Bug 14695 - Update DB Schema file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:24:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:24:43 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #14 from Kyle M Hall --- Created attachment 46550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46550&action=edit Bug 14695 - Add new circulation rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:24:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:24:45 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #15 from Kyle M Hall --- Created attachment 46551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46551&action=edit Bug 14695 - Tidy C4::Reserves::CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:24:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:24:48 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #16 from Kyle M Hall --- Created attachment 46552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46552&action=edit Bug 14695 - Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:24:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:24:57 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:26:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:26:29 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:27:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:27:28 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:30:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:30:49 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46548|0 |1 is obsolete| | Attachment #46549|0 |1 is obsolete| | Attachment #46550|0 |1 is obsolete| | Attachment #46551|0 |1 is obsolete| | Attachment #46552|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 46553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46553&action=edit Bug 14695 - Update database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:30:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:30:47 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:30:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:30:59 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #19 from Kyle M Hall --- Created attachment 46555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46555&action=edit Bug 14695 - Add new circulation rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:30:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:30:57 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #18 from Kyle M Hall --- Created attachment 46554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46554&action=edit Bug 14695 - Update DB Schema file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:31:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:31:03 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #20 from Kyle M Hall --- Created attachment 46556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46556&action=edit Bug 14695 - Tidy C4::Reserves::CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:31:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:31:06 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #21 from Kyle M Hall --- Created attachment 46557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46557&action=edit Bug 14695 - Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:31:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:31:05 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #109 from Jonathan Druart --- (In reply to Katrin Fischer from comment #102) > I had to install 2 dependencies via cpanm: > sudo cpanm Template::Stash::HTML::Entities > sudo cpanm Template::Stash::AutoEscaping Are you sure about that? I have removed Template::Stash::HTML::Entities and everything looks fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:35:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:35:33 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #110 from Katrin Fischer --- But comment#3 told me to install it! Maybe it's not needed then :) I can retest this as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:48:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:48:39 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:56:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:56:16 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from Nick Clemens --- Same issue as before Place 3 item specific holds Checkout 1 item All holds are resolved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 17:59:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 16:59:16 +0000 Subject: [Koha-bugs] [Bug 15446] Koha::Object[s]->type should be renamed to _type to avoid conflict with column name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 --- Comment #18 from Jonathan Druart --- I have added a new rule to the qa tools: commit 75bf0eead3fab5b1918f4d2f2fc6c1bc66f2dc76 type subroutine should be _type See bug 15446 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:02:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:02:15 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14137 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137 [Bug 14137] Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:02:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:02:15 +0000 Subject: [Koha-bugs] [Bug 14137] Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14464 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 [Bug 14464] Add ability to cancel waiting holds from checkin screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:09:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:09:44 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 --- Comment #10 from Jonathan Druart --- (In reply to Aleisha Amohia from comment #9) > I want to sign off on the alternative patch but the 'New from Z39.50' button > now doesn't fit along the same line as the other buttons and would look much > better if it did. Will sign off once that's fixed up. I don't get that, everything looks correct for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:36:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:36:46 +0000 Subject: [Koha-bugs] [Bug 15561] New: Add ability to charge cancelation fee from "Holds over" tab Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Bug ID: 15561 Summary: Add ability to charge cancelation fee from "Holds over" tab Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The fee set in ExpireReservesMaxPickUpDelayCharge can only be charged by the automatic expiration cron script. Some libraries would prefer to manually cancel holds via the "Holds over" tab of the "Holds awaiting pickup" page but still be able to charge the cancellation fee. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:38:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:38:08 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14137 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137 [Bug 14137] Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:38:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:38:08 +0000 Subject: [Koha-bugs] [Bug 14137] Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Depends on|14464 | Status|Failed QA |RESOLVED --- Comment #4 from Kyle M Hall --- In light of bug 14464 I'm going to close this bug and open a new one with a tighter scope that will accomplish what our librarians are requesting. *** This bug has been marked as a duplicate of bug 15561 *** Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 [Bug 14464] Add ability to cancel waiting holds from checkin screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:38:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:38:08 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #1 from Kyle M Hall --- *** Bug 14137 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:41:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:41:21 +0000 Subject: [Koha-bugs] [Bug 15511] Tabbed fines display on OPAC patron summary page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15511 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:41:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:41:47 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:41:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:41:49 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #2 from Kyle M Hall --- Created attachment 46558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46558&action=edit Bug 15561 - Add ability to charge cancelation fee from "Holds over" tab The fee set in ExpireReservesMaxPickUpDelayCharge can only be charged by the automatic expiration cron script. Some libraries would prefer to manually cancel holds via the "Holds over" tab of the "Holds awaiting pickup" page but still be able to charge the cancellation fee. Test Plan: 1) Apply this patch 2) Set ExpireReservesMaxPickUpDelayCharge to some number 3) Go to the Holds awaiting pickup page 4) Go to the Holds over tab 5) Note the new checkbox for charging the fee 6) Test canceling a single hold with the checkbox checked 7) Note a fee is charged 8) Test canceling a single hold with the checkbox unchecked 9) Note a fee is not charged 10) Test canceling all holds with the checkbox checked 11) Note the patrons are charged fees 12) Test canceling all holds without the checkbox checked 13) Note the patrons are not charged fees -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:46:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:46:32 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:46:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:46:42 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:47:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:47:48 +0000 Subject: [Koha-bugs] [Bug 14405] Add datatable to fines table in OPAC patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14405 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:48:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:48:17 +0000 Subject: [Koha-bugs] [Bug 14137] Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15561 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:48:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:48:17 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14137 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:48:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:48:34 +0000 Subject: [Koha-bugs] [Bug 14137] Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15561 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:48:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:48:34 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14137 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 18:54:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 17:54:48 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #22 from Kyle M Hall --- (In reply to Katrin Fischer from comment #21) > Ah, I thought it was yours - Holds... must be Kyle! Sorry! lol, I can understand why ; ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 19:35:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 18:35:56 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #3 from Magnus Enger --- Too many /tmp/cgisess* files for a simple rm can also come as an unpleasant surprise if you have Koha set up to use memcached for sessions, and memcached dies for some reason. Bam, next morning your disk is full... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 19:51:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 18:51:06 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 --- Comment #4 from Magnus Enger --- Created attachment 46559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46559&action=edit Bug 15553 - [SIGNED-OFF] cgisess_ files polluting the /tmp directory When some users want to improve performance, one suggestion is to switch the syspref "sessionstorage" to 'tmp', which store the session info in the /tmp directory instead of the database. Depending on the frequency of the cleaning process (or lack thereof), this can be heavy pollution into the /tmp directory, making it unusable. "rm cgi*" would not even work since cgi* extends to over 8000 items... A simple fix is to modify the target directory in C4/Auth.pm to /tmp/cgisess. Testing scenario: 1) change the syspref SessionStorage to 'tmp' 2) Log into the OPAC, validate that a file named /tmp/cgisess_(something) got created 3) Apply the patch 4) Log into the OPAC, validate that a file /tmp/cgisess/cgisess_(something) got created Signed-off-by: Magnus Enger Works as advertised. Session files are created in /tmp/cgisess/ instead of directly in /tmp. I usually store sessions in memcached, but a couple of times memcached has died on me, and before I knew it, /tmp was so full of sessions files, I could not easily delete them with "rm /tmp/cgisess*". Being able to delete /tmp/cgisess/ should be a bit easier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 19:51:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 18:51:03 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 20:05:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 19:05:02 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 --- Comment #17 from H?ctor Eduardo Castro Avalos --- (In reply to Marcel de Rooy from comment #16) Hi Marc Thank you for keep testing. As Marcel comments the way of the bug has change since the documentation in comment 11. ( I was in a mistake) > (In reply to Marc V?ron from comment #15) > > What should happen if I do: > > > > cgi-bin/koha/unapi?id=koha:biblionumber:45100&format=xxx > > cgi-bin/koha/unapi?id=koha:biblionumber:45100&format= According with the first revision, the unapi must return an code status 300 multiple choice. > > What should happen if I use a biblionumber that does not exist? > > cgi-bin/koha/unapi?id=koha:biblionumber:999999999&format=oai_dc This must return a 400 or 404 code. > > > > At the moment I get a blank page for all cases. > > Blank page is not an error. Unapi should return a http status code for bad > requests. See comment11 Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 20:14:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 19:14:10 +0000 Subject: [Koha-bugs] [Bug 14641] Warns in subscription-add.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 20:14:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 19:14:12 +0000 Subject: [Koha-bugs] [Bug 14641] Warns in subscription-add.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46500|0 |1 is obsolete| | --- Comment #9 from Magnus Enger --- Created attachment 46560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46560&action=edit Bug 14641: [SIGNED-OFF] Warns in subscription-add.pl Removes warn using Jonathan's suggestion! To test: 1) Reproduce warns by clicking New Subscription 2) Apply patch 3) Click New Subscription again 4) Confirm warns are gone Signed-off-by: Magnus Enger Patch removes the warn that come when clicking "New subscription" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 20:15:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 19:15:28 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46503|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 20:32:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 19:32:40 +0000 Subject: [Koha-bugs] [Bug 15400] display patron age in useful places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Magnus Enger --- $ git bz apply 15400 Bug 15400 - display patron age in useful places 45882 - Bug 15400: Show patron age in search results Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15400: Show patron age in search results Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt M koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc Failed to merge in the changes. Patch failed at 0001 Bug 15400: Show patron age in search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 20:34:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 19:34:34 +0000 Subject: [Koha-bugs] [Bug 15400] display patron age in useful places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #6 from Magnus Enger --- Also, I have a hunch this: [% IF age %]([% age%])[% END %] might be better written as: [% IF age %] ([% age %])[% END %] to 1. Give a space between the link and the opening parenthesis 2. Make the layout of TT tags consistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 20:46:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 19:46:58 +0000 Subject: [Koha-bugs] [Bug 15528] Updating the authorised value for a report subgroup removes the previous value assigned from all report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15528 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 20:47:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 19:47:02 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 20:50:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 19:50:27 +0000 Subject: [Koha-bugs] [Bug 15512] Minor regression caused by Bug 7369 - warn on deleting item not triggered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 21:43:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 20:43:18 +0000 Subject: [Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 21:43:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 20:43:21 +0000 Subject: [Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46516|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 46561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46561&action=edit [SIGNED-OFF]Bug 15550: Fix authority search and detail at the OPAC The author of Bug 15381 (me!) has mismatch the objects he was manipulating and forgotten to update a template. for the opac-aythorities-home, the variable is named authority_types, not authtypesloop. In opac-authoritiesdetail.pl, the $record is a MARC::Record and there is no authtypecode method. We need to retrieve the authtypecode using the new Koha::Authorities module. Test plan: Search for authorities at the OPAC and click on the detail link to go to the detail page. Without this patch, you will get errors. With this patch, the errors should have gone and everything should work as before bug 15381. Signed-off-by: Hector Castro Works as described. Pull down for choosing the auth_type displayed again detail fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 23:00:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 22:00:53 +0000 Subject: [Koha-bugs] [Bug 15394] Confirm messages on OPAC lists interface strangely worded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15394 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 23:16:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 22:16:33 +0000 Subject: [Koha-bugs] [Bug 13177] Add help pages for Rotating collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 23:16:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 22:16:54 +0000 Subject: [Koha-bugs] [Bug 13177] Add help pages for Rotating collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 --- Comment #4 from Aleisha Amohia --- Created attachment 46562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46562&action=edit Bug 13177: Accidental copy/paste error fix Confirm it now says Rotating Collections instead of Patron Import in the last line, and the link is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 23:28:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 22:28:48 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 23:28:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 22:28:51 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29611|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia --- Created attachment 46563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46563&action=edit Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off If the user knows the URL for OPAC lists they can access them even with the virtualshelves preference turned off. This patch copies the solution added to opac-topissues.pl by Bug 10595 and applies it to OPAC lists pages. To test, apply the patch and set the virtualshelves system preference to "don't allow." - Navigate to /cgi-bin/koha/opac-shelves.pl. You should be redirected to an Error 404 page. - Also check: - /cgi-bin/koha/opac-shareshelf.pl. - /cgi-bin/koha/opac-downloadshelf.pl - /cgi-bin/koha/opac-sendshelf.pl - /cgi-bin/koha/opac-addbybiblionumber.pl - Turn virtualshelves back on. Access to lists and list sharing should be restored. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 23:29:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 22:29:50 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 --- Comment #8 from Aleisha Amohia --- There was a merge conflict in opac-addbybiblionumber.pl but I think I fixed it. Not sure what went wrong the first time I tested this but seems fine to sign off now :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 23:33:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 22:33:08 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 23:33:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 22:33:11 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46234|0 |1 is obsolete| | --- Comment #14 from Aleisha Amohia --- Created attachment 46564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46564&action=edit Bug 15374 - Translatability: Fix issues on OPAC summary page Fix several issues on opac-user.tt with sentences splitted by tags, leading to odd translations. Additionally, fix a broken link that should point to opac-account.pl To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions (Amended to add price formatting in fines tab label) Can see the warning message now :) signing off Signed-off-by: Aleisha (Amended to make patches apply, see comment #12) Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 23:36:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 22:36:40 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 --- Comment #11 from Aleisha Amohia --- Created attachment 46565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46565&action=edit Button on next line This is what happens for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 23:54:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 22:54:05 +0000 Subject: [Koha-bugs] [Bug 5501] Improve the 'do not notify' option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 12 23:54:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 22:54:09 +0000 Subject: [Koha-bugs] [Bug 5501] Improve the 'do not notify' option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35414|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia --- Created attachment 46566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46566&action=edit Bug 5501 - Improve the 'do not notify' option. HOLD-letter. TEST PLAN: 1. Find a Borrower and edit "Patron messaging preferences". 2. Check the "Do not notify" for "Hold filled" -letter. 3. Check any other checkboxes for "Hold filled" -letter. The "Do not notify"-checkbox should get unchecked. 4. Check the "Do not notify" -checkbox again for the "Hold filled" -letter. Other selections for the row get unchecked. 5. Save changes. 6. Make a hold for a borrower. 7. Check-in the reserved Item and catch the hold. 8. In the notices-tab for the Borrower, there should be no message for the borrower about getting the caught Hold. Signed-off-by: Aleisha -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 00:48:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 23:48:50 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 --- Comment #8 from Aleisha Amohia --- Can't sign off on this yet, a few things: Blocked/debarred user - the link to the account page did not work, even though I can see in the code that it should so I am not sure what happened there but it did not redirect me anywhere. Uncertain address information - The link took me to opac-userupdate.pl which doesn't exist - should be to opac-memeberentry.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 00:52:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 23:52:08 +0000 Subject: [Koha-bugs] [Bug 15311] Let libraries set text to display when OpacMaintenance = on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #7 from Aleisha Amohia --- CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 00:56:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jan 2016 23:56:49 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 --- Comment #3 from Aleisha Amohia --- This could use a sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 01:00:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 00:00:17 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|Needs Signoff |Signed Off --- Comment #24 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #23) > Aleisha, you have only signed off the last patch, could you confirm you have > tested the whole feature? Yes I have! sorry, meant to sign off on all of the patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 01:35:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 00:35:54 +0000 Subject: [Koha-bugs] [Bug 15458] Marc21 leader 07 error in translation: "a- Serial component" part is not in format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15458 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- (In reply to H?ctor Eduardo Castro Avalos from comment #3) > Include here RM's 3.20 and 3.18, maybe they decide to push bug 14201 and > obsolete this one. 14201 has been pushed so perhaps we can close this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 04:24:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 03:24:46 +0000 Subject: [Koha-bugs] [Bug 15562] New: Make Koha more suitable for shared hosting with plack Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Bug ID: 15562 Summary: Make Koha more suitable for shared hosting with plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: srdjan at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org As it stands each koha site needs a separate plack instance. In multi-host environments that run off a single code base it is suboptimal, because it loads same resources multiple times. The problem is in the context instance, because it was designed to be a singleton. This is an attempt at running requests within multiple contexts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 04:30:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 03:30:31 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 05:09:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 04:09:39 +0000 Subject: [Koha-bugs] [Bug 15458] Marc21 leader 07 error in translation: "a- Serial component" part is not in format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15458 --- Comment #5 from H?ctor Eduardo Castro Avalos --- (In reply to Brendan Gallagher from comment #4) Hi Brendan > 14201 has been pushed so perhaps we can close this one? I don't know if I'm wrong but 14201 has been pushed only in Master, neither Fr?d?ric nor Liz have pushed to 3.20.x/3.18.x respectively. I leave the decision to them. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 06:01:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 05:01:49 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 06:01:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 05:01:52 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46512|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 46567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46567&action=edit [SIGNED-OFF]Bug 15555: Index 024$a into Identifier-other:u url register when source $2 is uri This patch indexes 024$a into the "phrase" index type, and the "url" index type, if the 024$2 equals "uri". TEST PLAN 1) Apply the patch. 1b) If you're using a gitified Koha or a git install, you'll need to upgrade your instance or copy your zebradb files over to /etc/koha/zebradb or your "kohadev" directory. 2) Add a 024$a with a URL like http://libris.kb.se/resource/bib/219553 to a bibliographic record 3) Re-index Zebra 4) Type "id-other,st-urx,fuzzy=http://libris.kb.se/resource/bib/219553" into the "Search the catalog" box in the Staff Client and search 5) Note that you retrieve your record NOTE: The fuzzy is required because Koha's query "parsing" functions change http:// to http=// which won't correctly match the value in the "Identifier-other:u" index. NOTE: Alternatively, you could do the following search instead: "id-other,phr=http libris kb se resource bib 219553". It would work as well by using the "Identifier-other:p" index. Advanced tester version: 4) In a terminal window, find the "koha-conf.xml" file in your "etc" directory. 5) Open "koha-conf.xml" and find . Copy the URI you find there. (e.g. unix:/home/dcook/koha-dev/var/run/zebradb/bibliosocket). 6) Type "yaz-client unix:/home/dcook/koha-dev/var/run/zebradb/bibliosocket" 7) After it connects, type "base biblios" and press enter 8) Type "format xml" and press enter 9) Type "elements zebra::index" and press enter 10) Type "f id-other,st-urx=http://libris.kb.se/resource/bib/219553" and press enter 11) Note that you should have at least one result 12) Type "show 1" 13) If you scroll through the results, you should find something like the following: @^ http libris kb se resource bib 219553 http libris kb se resource bib 219553 http://libris.kb.se/resource/bib/219553 Signed-off-by: Hector Castro Works as advertised the record is retrieved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 06:06:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 05:06:53 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com, | |nicole at bywatersolutions.com --- Comment #6 from H?ctor Eduardo Castro Avalos --- Because of your NOTE I think IMHO this needs to go in Manual. Add here Documentation Manager -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 06:29:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 05:29:33 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #10 from H?ctor Eduardo Castro Avalos --- Galen is right you must add an configurable option to leave librarians to choose if they want this feature working in their libraries or not. IMHO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 08:25:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 07:25:07 +0000 Subject: [Koha-bugs] [Bug 15511] Tabbed fines display on OPAC patron summary page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15511 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 08:25:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 07:25:58 +0000 Subject: [Koha-bugs] [Bug 15412] Dropdowns in suspend holds date selector do not function in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15412 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 08:26:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 07:26:16 +0000 Subject: [Koha-bugs] [Bug 15511] Tabbed fines display on OPAC patron summary page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15511 --- Comment #8 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 08:52:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 07:52:57 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 09:16:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 08:16:09 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46547|0 |1 is obsolete| | --- Comment #36 from Julian Maurice --- Created attachment 46568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46568&action=edit Bug 6657: TransformHtmlToMarc - rewrite the loop This rewrites the while loop into a for loop, so $i still gets incremented when we call next -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 09:20:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 08:20:29 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #23 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #19) > can you maybe explain the usual use case for the HoldDateInFuture setting? > Maybe this will help to clear things up about the differences even more. I > am not quite sure about myself and would like to understand better how it's > currently used. We have enabled a.o.: AllowHoldDateInFuture, ConfirmFutureHolds=2, OPACAllowHoldDateInFuture. This offers the user to supply two additional dates with a hold request: Hold starts on date, and Hold not needed after. What does that mean? The patron tells us here that he would like to have the book only in the indicated (future) period. So we do not put the book in waiting status for him until this period is very close (ConfirmFutureHolds). In the meantime we can issue the book to someone else or let others place holds. Similarly, another patron can also say: I want this book between A and B. No problem if this overlaps the period of patron 1. Priority is here based on [future] start date. If the book could not be put in waiting status for patron 1 in the indicated period somehow, the expired hold will be cancelled. This is imo just a straightforward use of the two dates as Koha offers by default. Our specific local situation is not relevant in this discussion. Note that I am still missing any response from the authors of this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 09:28:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 08:28:14 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 09:28:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 08:28:17 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46568|0 |1 is obsolete| | --- Comment #37 from Fr?d?ric Demians --- Created attachment 46569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46569&action=edit Bug 6657: TransformHtmlToMarc - rewrite the loop This rewrites the while loop into a for loop, so $i still gets incremented when we call next Signed-off-by: Fr?d?ric Demians Make sense. Add readability. Infinite loop no more possible. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 09:30:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 08:30:23 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #38 from Fr?d?ric Demians --- I finally reset this patch status to 'Needs Signoff' since the 1st patch of the set isn't yet signed. Maybe the importance of this patch should be upgraded to Critical. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 09:44:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 08:44:42 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #39 from Katrin Fischer --- >This patch has a side effect on authorities creation (tested in 3.20.x). The >authorities.pl run foreever, and adding a new authority is impossible. Hi Frederic, I agree with critical - I have changed the severity. For next time - I think it's better to handle these things on a separate bug report linked to the one which caused the problem. Then the title can reflect the urgency better and it's easer to navigate the discussion. As we use the bug titles for the release notes it also helps to better communicate a fixed problem. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 09:55:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 08:55:59 +0000 Subject: [Koha-bugs] [Bug 15563] New: Cronjob to regularly delete patroncard label batches Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15563 Bug ID: 15563 Summary: Cronjob to regularly delete patroncard label batches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Patron card batches can be deleted manually, but it would also be helpful if the batches could be cleaned up automatically after X days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 10:03:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 09:03:26 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 --- Comment #4 from Marc V?ron --- Testing for today (13/01/2016) Date of birth: 12/01/2000 Expecting: 16 years old Display: 16 years Date of birth: 13/01/2000 Expecting: 16 years old Display: 16 years Date of birth: 14/01/2000 Expecting: 15 years old Display: 15 years BTW: Applied on top of this Bug 15206 - Show patron's age when filling date of birth in memberentry.pl, works fine, no conflicts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 10:05:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 09:05:22 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45790|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 46570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46570&action=edit Bug 14763: Calculate and display patron age This patch uses the GetAge function from C4::Members to calculate the patron's age and display it. To test: 1) Go to patron Details page (ie http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51) 2) Confirm that 'Age:' is showing under the Date of Birth and is correct according to DOB (ie if DOB: 30/11/1996, Age: 19 years) 3) Edit date of birth to be a month later (ie from 30 November to 30 December) so that, as of the date you are testing, the patron has not had their birthday yet 4) Confirm that Age changes to be one year younger 5) Edit date of birth to be a different year 6) Confirm that Age changes accordingly Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 10:06:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 09:06:49 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 10:20:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 09:20:45 +0000 Subject: [Koha-bugs] [Bug 15560] holding branch missing in pending reserves report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 10:23:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 09:23:50 +0000 Subject: [Koha-bugs] [Bug 15560] holding branch missing in pending reserves report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 --- Comment #1 from Sophie MEYNIEUX --- why not changing directly the SQL to get branchname rather than branchcode ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 10:56:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 09:56:10 +0000 Subject: [Koha-bugs] [Bug 15394] Confirm messages on OPAC lists interface strangely worded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15394 --- Comment #5 from Jonathan Druart --- (In reply to Liz Rea from comment #4) > Hi Jonathan, I've opened bug 15403 for the intranet. :) There is no patch on bug 15403 :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 10:56:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 09:56:22 +0000 Subject: [Koha-bugs] [Bug 15560] holding branch missing in pending reserves report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Sophie, sorry for causing the bug. :( I will try to fix, but not sure when I will have the time - so if someone wants to have a go, please do! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:02:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:02:45 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 --- Comment #18 from Marc V?ron --- Hi H?ctor, i did more testing: cgi-bin/koha/unapi?id=koha:biblionumber:45100&format=xxx cgi-bin/koha/unapi?id=koha:biblionumber:45100&format= Result for both: 406 invalid format requested Empty page http://10.0.0.62/cgi-bin/koha/unapi?id=koha:biblionumber:999999999&format=oai_dc Result: 404 record not found Empty page http://10.0.0.62/cgi-bin/koha/unapi?id=koha:biblionumber:xxxxxxxxxxxxx&format=oai_dc Result: 404 record not found Empty page http://10.0.0.62/cgi-bin/koha/unapi?id=koha:blabla:1&format=oai_dc Result: 404 record not found Empty page http://10.0.0.62/cgi-bin/koha/unapi?id=koha:biblionumber:1xxxxxxxxxxxxx&format=oai_dc Result: 200 OK Page beginning with: oai_dc:dc xsi:schemaLocation="http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd"> (...) Same as with koha:biblionumber:1 (existing number) http://10.0.0.62/cgi-bin/koha/unapi?id= Result: 300 multiple choices Page beginning with: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 --- Comment #9 from Jonathan Druart --- Comment on attachment 46563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46563 Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off Review of attachment 46563: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6322&attachment=46563) ----------------------------------------------------------------- ::: opac/opac-addbybiblionumber.pl @@ -41,5 @@ > our @biblios; > > - > -if (scalar(@biblionumber) == 1) { > - @biblionumber = (split /\//,$biblionumber[0]); No it has not been fixed correctly, these lines should be kept. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:04:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:04:51 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Arve S?reide changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arve.soreide at kul.oslo.kommu | |ne.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:04:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:04:54 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #29611|1 |0 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:05:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:05:10 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46563|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:07:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:07:47 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 --- Comment #10 from Jonathan Druart --- Owen, Don't you think we should apply the same fix for the staff interface? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:08:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:08:52 +0000 Subject: [Koha-bugs] [Bug 15394] Confirm messages on OPAC lists interface strangely worded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:08:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:08:55 +0000 Subject: [Koha-bugs] [Bug 15394] Confirm messages on OPAC lists interface strangely worded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45875|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 46571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46571&action=edit Bug 15394 - Tidy up error messages in OPAC lists To test: Create a list in the OPAC, observe the message Create another list in the OPAC with the same name, observe the message Delete a list, observe the message Check the patch itself, look for typos. Signed-off-by: Aleisha Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:09:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:09:15 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15394 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15394 [Bug 15394] Confirm messages on OPAC lists interface strangely worded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:09:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:09:15 +0000 Subject: [Koha-bugs] [Bug 15394] Confirm messages on OPAC lists interface strangely worded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14544 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 [Bug 14544] Move the list related code to Koha::Virtualshelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:13:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:13:33 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:14:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:14:43 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Doesn't it make more sense to display it like: Date of birth: dd/mm/yyyy (xx years) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:17:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:17:17 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #40 from Fr?d?ric Demians --- (In reply to Katrin Fischer from comment #39) > >This patch has a side effect on authorities creation (tested in 3.20.x). The >authorities.pl run foreever, and adding a new authority is impossible. > > Hi Frederic, I agree with critical - I have changed the severity. > > For next time - I think it's better to handle these things on a separate bug > report linked to the one which caused the problem. Then the title can > reflect the urgency better and it's easer to navigate the discussion. As we > use the bug titles for the release notes it also helps to better communicate > a fixed problem. Katrin, I agree that a new bug report would have been better. It's still not too late. I can create a new bug and attach the 3 patches if you may want. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:17:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:17:51 +0000 Subject: [Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Jonathan Druart --- Marc, I have not tested the patch, but it seems that a conflict with bug 15344 has not been fixed correctly. BORROWER_INFO should not be BORROWER_INF -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:25:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:25:39 +0000 Subject: [Koha-bugs] [Bug 5501] Improve the 'do not notify' option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #13 from Jonathan Druart --- Olli, is it still valid? As it, it cannot be pushed to master, it should be done for any letter types if we want it. Moreover, there is now a "none" message transport type when editing letter templates, I am not sure it removes confusion :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:29:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:29:04 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #25 from Jonathan Druart --- Owen, I would like to get your signoff on this one. I am ready to pass QA it as I think the behavior is consistent and it could be very useful for users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:31:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:31:18 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #26 from Jonathan Druart --- Julian, maybe it would be better to use a minified version of select2.css. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:33:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:33:09 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46559|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 46572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46572&action=edit Bug 15553 - [SIGNED-OFF] cgisess_ files polluting the /tmp directory When some users want to improve performance, one suggestion is to switch the syspref "sessionstorage" to 'tmp', which store the session info in the /tmp directory instead of the database. Depending on the frequency of the cleaning process (or lack thereof), this can be heavy pollution into the /tmp directory, making it unusable. "rm cgi*" would not even work since cgi* extends to over 8000 items... A simple fix is to modify the target directory in C4/Auth.pm to /tmp/cgisess. Testing scenario: 1) change the syspref SessionStorage to 'tmp' 2) Log into the OPAC, validate that a file named /tmp/cgisess_(something) got created 3) Apply the patch 4) Log into the OPAC, validate that a file /tmp/cgisess/cgisess_(something) got created Signed-off-by: Magnus Enger Works as advertised. Session files are created in /tmp/cgisess/ instead of directly in /tmp. I usually store sessions in memcached, but a couple of times memcached has died on me, and before I knew it, /tmp was so full of sessions files, I could not easily delete them with "rm /tmp/cgisess*". Being able to delete /tmp/cgisess/ should be a bit easier. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:33:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:33:13 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 --- Comment #6 from Marcel de Rooy --- Created attachment 46573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46573&action=edit Bug 15553: [QA Follow-up] Replace hardcoded tmp and add instance to dirname If you use multiple instances on one server, you could have the situation that instance A creates the cgisess subfolder and instance B could have a permission problem. This patch resolves that by allowing each instance to have its own cgisess subfolder. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:35:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:35:36 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Marcel de Rooy --- QA Comment: Looks good to me, adding the multiple instance case. Another report could deal with cleaning up this folder. Why not remove all older session files in cleanup_database.pl on daily basis? Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:43:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:43:19 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #41 from Katrin Fischer --- Hi Frederic, I am ok with both - leaving it here or separating it out. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 11:59:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 10:59:02 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 --- Comment #19 from Marcel de Rooy --- Marc: This looks reasonable to me. Note that the biblionumber is extracted like this: if ($id =~ /koha:biblionumber:(\d+)/) { my $biblionumber = $1; This is current behavior and could be considered as outside the scope of this report.. The id= (empty) case is actually the same as without any parameters. So should present formats. I do not have a problem with the 406; this particular case was a 400. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:01:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:01:50 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 --- Comment #9 from Marc V?ron --- Hi Aleisha, Blocked user: I re-tested with patch applied. Logged in to OPAC with a user who has a manual debarrement. Searched a biblio and tried to put a hold (from the search result list). Got yellow info with message as expected with working link to the useres addount page. Uncertain address / wrong link: If I do git grep 'opac-userupdate.pl', I get a result in: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt I think this is a separate Bug. This patch is about koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:04:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:04:28 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46513|0 |1 is obsolete| | --- Comment #20 from Marc V?ron --- Created attachment 46574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46574&action=edit Bug 15190: Bad utf8 decode to unapi and fixing status code 200 Fix bad utf8 decoding, also fix status code 200 for no parameters passed to script To reproduce the issue in OPAC 1) Copy from LOC (Z39.50) ISBN 8467020113 or test it with whichever record with special characters 2) Open URL in OPAC cgi-bin/koha/unapi?id=koha:biblionumber:4&format=oai_dc play with oai_dc, srw_dc, mods, mods-full, mods3, mods3-full, rdfdc. Note: marcxml does not fail 3) Enter the new biblionumber for ISBN 8467020113 or the record of your choise 4) An oai_dc record will display, notice about the bad utf8 decoding characters 5) Search the record in OPAC 6) To reproduce code 200 Ok and 300 Multiple choices play with: cgi-bin/koha/unapi cgi-bin/koha/unapi?id=koha:biblionumber:4 7) If possible test in NORMARC (UNIMARC will launch an error because bug 15162) Test plan -Apply patch -Follow steps 2 to 6 -You will see no errors in utf8 Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:04:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:04:48 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:06:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:06:22 +0000 Subject: [Koha-bugs] [Bug 15544] Facets must be managed from the intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544 --- Comment #1 from Juan Romay Sieira --- Created attachment 46575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46575&action=edit Patch to apply in master branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:07:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:07:31 +0000 Subject: [Koha-bugs] [Bug 15544] Facets must be managed from the intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544 --- Comment #2 from Juan Romay Sieira --- Created attachment 46576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46576&action=edit SQL with a new facet table, to save the configuration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:08:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:08:03 +0000 Subject: [Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:08:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:08:06 +0000 Subject: [Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46499|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 46577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46577&action=edit Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set If permission 'circulate_remaining_permissions' is not set, links to 'Circulation' (/circ/circulation-home.pl) on the intranet home page lead to an error message: "Error: You do not have permission to access this page." This patch hides the links if the permission is not set. To test: - Apply patch - Log in to the intranet (staff client) with a patron who has the permission 'circulate_remaining_pernissions' not set - Verify that no links to Circulation appear on the intranet start page (menu top left and menu in main page area) - Log in as a user who has the permission set. - Verify that te links appear as appropriate. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:10:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:10:03 +0000 Subject: [Koha-bugs] [Bug 15544] Facets must be managed from the intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544 --- Comment #3 from Juan Romay Sieira --- Test plan: Apply the patch in master branch. Import the facet.sql file into your koha database. Next go to Administration -> Facet indexes manager You can create facets and test it appears into the search (intranet and opac) There is a SQL with inserts of facet configuration samples. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:14:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:14:29 +0000 Subject: [Koha-bugs] [Bug 15544] Facets must be managed from the intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544 --- Comment #4 from Juan Romay Sieira --- Created attachment 46578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46578&action=edit Facet SQL samples -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:19:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:19:34 +0000 Subject: [Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Julian, I'd suggest to simplify with something like: $form.find('select').not('[disabled]').find('option:selected').each(function () { I have tried and it seems to work, please confirm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:28:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:28:33 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 --- Comment #8 from Jonathan Druart --- Comment on attachment 44825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44825 [SIGNED-OFF]Bug 15162 Add for Unimarc XSL trans for RDF-DC & SRW-DC Review of attachment 44825: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15162&attachment=44825) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2RDFDC.xsl @@ +142,5 @@ > + URN:ISSN: > + > + > + > + It seems that unapi does not return the item fields. @@ +147,5 @@ > + > + LOC: > + > + Main library > + Library 2 Hum? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:30:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:30:59 +0000 Subject: [Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:31:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:31:02 +0000 Subject: [Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46507|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 46579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46579&action=edit Bug 15552: Better wording of intranetreadinghistory To test: 1) Find intranetreadinghistory system preference in Administration 2) Confirm new description gives more information and makes sense Signed-off-by: Hector Castro Better wording and much better for translatability purposes Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:39:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:39:48 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 --- Comment #9 from Jonathan Druart --- Comment on attachment 46501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46501 Bug 15096: Export today's checked in barcodes: Display warning if reading history is set to "never" Review of attachment 46501: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15096&attachment=46501) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc @@ +118,5 @@ > } > function export_barcodes() { > + [% IF ( > + ( ! Koha.Preference('intranetreadinghistory') ) || > + ( Koha.Preference('AnonymousPatron') == ( borrowernumber) ) || Could you detail this use case? If you are logged in with the anonymous patron why do you want to block the export? @@ +122,5 @@ > + ( Koha.Preference('AnonymousPatron') == ( borrowernumber) ) || > + ( privacy == 2 ) > + ) > + %] > + window.location = '/cgi-bin/koha/members/readingrec.pl?borrowernumber=[% borrowernumber %] ' ; I'd prefer to disable the button on the same way as we do for the "update child to adult patron" button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:42:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:42:53 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #29 from Jonathan Druart --- Please provide a complete test coverage for these changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:51:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:51:02 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #43 from Jonathan Druart --- (In reply to Jesse Weaver from comment #41) > (FYI: the same warning that appears at the top of the test output here also > appears when I prove t/db_dependent/Items.t, though that test passes.) We should not expect warnings on proving, they must be caught be warning_is/warning_like. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:53:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:53:48 +0000 Subject: [Koha-bugs] [Bug 14641] Warns in subscription-add.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 12:53:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 11:53:50 +0000 Subject: [Koha-bugs] [Bug 14641] Warns in subscription-add.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46560|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 46580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46580&action=edit Bug 14641: [SIGNED-OFF] Warns in subscription-add.pl Removes warn using Jonathan's suggestion! To test: 1) Reproduce warns by clicking New Subscription 2) Apply patch 3) Click New Subscription again 4) Confirm warns are gone Signed-off-by: Magnus Enger Patch removes the warn that come when clicking "New subscription" Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:03:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:03:58 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Note that users will be logged out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:14:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:14:55 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 --- Comment #9 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #8) > Comment on attachment 44825 [details] [review] > [SIGNED-OFF]Bug 15162 Add for Unimarc XSL trans for RDF-DC & SRW-DC > > Review of attachment 44825 [details] [review]: > ----------------------------------------------------------------- > > ::: koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2RDFDC.xsl > @@ +142,5 @@ > > + URN:ISSN: > > + > > + > > + > > + > > It seems that unapi does not return the item fields. So it won't hurt. It's a cut-and-paste of the OAI-PMH XSL. > @@ +147,5 @@ > > + > > + LOC: > > + > > + Main library > > + Library 2 > > Hum? :) It's how it is now for OAI XSL. It's not a regression... It won't display anything except if a Unimarc DB has a branch named MAIN or BIB2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:23:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:23:11 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:23:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:23:13 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46574|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy --- Created attachment 46581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46581&action=edit Bug 15190: Bad utf8 decode to unapi and fixing status code 200 Fix bad utf8 decoding, also fix status code 200 for no parameters passed to script To reproduce the issue in OPAC 1) Copy from LOC (Z39.50) ISBN 8467020113 or test it with whichever record with special characters 2) Open URL in OPAC cgi-bin/koha/unapi?id=koha:biblionumber:4&format=oai_dc play with oai_dc, srw_dc, mods, mods-full, mods3, mods3-full, rdfdc. Note: marcxml does not fail 3) Enter the new biblionumber for ISBN 8467020113 or the record of your choise 4) An oai_dc record will display, notice about the bad utf8 decoding characters 5) Search the record in OPAC 6) To reproduce code 200 Ok and 300 Multiple choices play with: cgi-bin/koha/unapi cgi-bin/koha/unapi?id=koha:biblionumber:4 7) If possible test in NORMARC (UNIMARC will launch an error because bug 15162) Test plan -Apply patch -Follow steps 2 to 6 -You will see no errors in utf8 Followed test plan, works as expected. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:25:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:25:57 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:26:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:26:00 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44825|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 46582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46582&action=edit Bug 15162 Add for Unimarc XSL trans for RDF-DC & SRW-DC Fix also, marginaly, OAI-DC XSL file which were using 090$a as biblionumber rather than 001. To test with an Unimarc Catalog: - Open this URL /cgi-bin/koha/unapi?id=koha:biblionumber:41201&format=marcxml And play with id & format parameters Test format=rdfdc and format=srw_dc - Or try with bug 13642 Signed-off-by: Hector Castro Works as advertised. Both XML formats generated successfully. Also fix problem with OPACBaseURL in UNIMARC environment. Tested with Sandbox too. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:26:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:26:03 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 --- Comment #11 from Jonathan Druart --- Created attachment 46583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46583&action=edit Bug 15162: Remove specific test in UNIMARCslim2*.xsl Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:26:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:26:38 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #9) > > @@ +147,5 @@ > > > + > > > + LOC: > > > + > > > + Main library > > > + Library 2 > > > > Hum? :) > > It's how it is now for OAI XSL. It's not a regression... It won't display > anything except if a Unimarc DB has a branch named MAIN or BIB2. I have removed them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:29:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:29:55 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:29:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:29:59 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44727|0 |1 is obsolete| | Attachment #44728|0 |1 is obsolete| | Attachment #44815|0 |1 is obsolete| | Attachment #44819|0 |1 is obsolete| | Attachment #46514|0 |1 is obsolete| | --- Comment #155 from Jonathan Druart --- Created attachment 46584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46584&action=edit Bug 13642 - Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML not follows the DC-XML recommendations as should be: elements in uppercase eg. dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property names for the 15 DC elements should be all lower-case." eg. dc:date, dc:creator" and section "4.3 Example - a simple DC record", xsi:schemaLocation="http://example.org/myapp/ http://example.org/myapp/schema.xsd" schema does not exist. NOTE: This new feature implement the XSLT transformation for OAI-DC, SRW-DC and RDF-DC Test plan --------------- 1) Download Dublin Core file from record detail page. Open up the file, and make sure that the document not follows the DC-XML recommendations as should be. 2) Apply patch. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) Test with all marc flavours. Sponsored-by: Universidad de El Salvador Signed-off-by: Frederic Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:30:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:30:07 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #156 from Jonathan Druart --- Created attachment 46585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46585&action=edit Bug 13642 - Changes LESS opac.less > to opac.css Changes LESS opac.less > to opac.css Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:30:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:30:19 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #158 from Jonathan Druart --- Created attachment 46587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46587&action=edit Bug 13642 - Remove MARC::Crosswalk::DublinCore from Koha To test: 1) git grep "MARC::Crosswalk::DublinCore" C4/Installer/PerlDependencies.pm: 'MARC::Crosswalk::DublinCore' => { INSTALL.fedora7:MARC::Crosswalk::DublinCore 2) git grep "libmarc-crosswalk-dublincore-perl" debian/control: libmarc-crosswalk-dublincore-perl, debian/control: libmarc-crosswalk-dublincore-perl, install_misc/debian.packages:libmarc-crosswalk-dublincore-perl install install_misc/ubuntu.10.04.packages:libmarc-crosswalk-dublincore-perl install install_misc/ubuntu.12.04.packages:libmarc-crosswalk-dublincore-perl install install_misc/ubuntu.packages:libmarc-crosswalk-dublincore-perl install 3) Repeat step 1 and 2 Signed-off-by: Frederic Demians Ripping out any mention to MARC::Crosswalk::DublinCore can't hurt. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:30:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:30:14 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #157 from Jonathan Druart --- Created attachment 46586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46586&action=edit Bug 13642 - Add Unit test for C4::Record::marc2dcxml Add Unit test for C4::Record::marc2dcxml To test: prove t/db_dependent/Record.t prove t/db_dependent/Record/Record.t Signed-off-by: Frederic Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:30:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:30:24 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #159 from Jonathan Druart --- Created attachment 46588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46588&action=edit Bug 13642: (followup) OAI-DC checked by default in OPAC modal -Fixing default option checked for OAI-DC in OPAC modal -Move OPAC modal to opac-detail-sidebar.inc to display in MARC view and ISBD view This follow-up fix the QA comment in comment 149 Signed-off-by: Fr?d?ric Demians Above issue fixed & usable also in MARC/ISBD view Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:30:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:30:59 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #160 from Jonathan Druart --- This patch set is blocked by bug 15169 which is waiting for a signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:31:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:31:30 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #161 from Jonathan Druart --- Great work H?ctor and Fr?d?ric! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:43:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:43:08 +0000 Subject: [Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983 --- Comment #5 from Jonathan Druart --- Comment on attachment 45991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45991 Bug 1983: Checkout: Hold request when checking out an item already on loan or reserved Review of attachment 45991: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=1983&attachment=45991) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ +408,5 @@ > > > +[% IF ( RESERVE_WAITING ) || ( RESERVED ) || ( ISSUED_TO_ANOTHER ) %] > + [%IF (CAN_user_reserveforothers_place_holds ) %] > + Click here to place hold What is this 'x'?? Why a link instead of a button? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:44:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:44:25 +0000 Subject: [Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |veron at veron.ch CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:50:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:50:20 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 --- Comment #13 from Fr?d?ric Demians --- > I have removed them. Good. Thanks for that, and thanks for the QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 13:57:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 12:57:00 +0000 Subject: [Koha-bugs] [Bug 15564] New: Display "print slip" option when returning an item which is in a rotating collection Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 Bug ID: 15564 Summary: Display "print slip" option when returning an item which is in a rotating collection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When an item is returned and have to be transfered, we have the ability to click on a "Print slip" link. But this link is not here when an item from a rotating collection is returned. For consistency, we should provide a "Print slip" link in both cases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 14:10:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 13:10:53 +0000 Subject: [Koha-bugs] [Bug 15565] New: Allow multiple title-level holds for the same record Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Bug ID: 15565 Summary: Allow multiple title-level holds for the same record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 14695 allows to place multiple item-level holds for the same record. It would be nice to also have the ability to place multiple title-level holds for the same record. An example use case could be a teacher that wants to borrow multiple copies of the same book for his students. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 14:10:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 13:10:53 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15565 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 14:20:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 13:20:07 +0000 Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15566 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15566 [Bug 15566] Update API to allow to reserve first available item from a group of titles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 14:20:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 13:20:07 +0000 Subject: [Koha-bugs] [Bug 15566] New: Update API to allow to reserve first available item from a group of titles Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15566 Bug ID: 15566 Summary: Update API to allow to reserve first available item from a group of titles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 13903, 15516 Bug 15516 will bring the ability to reserve the first available item from a group of titles. The API should allow that too. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 [Bug 13903] Add API routes to list, create, update, delete reserves http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] RFC: Allow to reserve first available item from a group of titles -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 14:20:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 13:20:07 +0000 Subject: [Koha-bugs] [Bug 15516] RFC: Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15566 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15566 [Bug 15566] Update API to allow to reserve first available item from a group of titles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 14:23:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 13:23:34 +0000 Subject: [Koha-bugs] [Bug 15567] New: Update API to allow multiple holds for the same record Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15567 Bug ID: 15567 Summary: Update API to allow multiple holds for the same record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 13903, 14695, 15565 Bug 14695 and bug 15565 will allow to place multiple holds for the same record. The API should allow that too. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 [Bug 13903] Add API routes to list, create, update, delete reserves http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 [Bug 15565] Allow multiple title-level holds for the same record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 14:23:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 13:23:34 +0000 Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15567 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15567 [Bug 15567] Update API to allow multiple holds for the same record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 14:23:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 13:23:34 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15567 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15567 [Bug 15567] Update API to allow multiple holds for the same record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 14:23:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 13:23:34 +0000 Subject: [Koha-bugs] [Bug 15565] Allow multiple title-level holds for the same record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15567 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15567 [Bug 15567] Update API to allow multiple holds for the same record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 14:35:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 13:35:58 +0000 Subject: [Koha-bugs] [Bug 15565] Allow multiple title-level holds for the same record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 14:52:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 13:52:43 +0000 Subject: [Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 14:52:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 13:52:46 +0000 Subject: [Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849 --- Comment #1 from Jonathan Druart --- Created attachment 46589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46589&action=edit Bug 14849: Add foreign key on uploaded_files.owner uploaded_files.owner refers to a borrowernumber, the DB structure should reflect this constraint. Test plan: 0/ Do not execute the update DB entry 1/ Add a new patron 2/ Use this patron to upload a new file 3/ In the uploaded_files you should see that the owner value is the borrowernumber of the newly created patron 4/ Execute the DB entry 5/ The uploaded_files.owner value should have been set to NULL 6/ Repeat 1, 2 and 3 7/ Delete the patron 5/ The uploaded_files.owner value should have been set to NULL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 14:52:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 13:52:55 +0000 Subject: [Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 14:53:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 13:53:29 +0000 Subject: [Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 14:53:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 13:53:29 +0000 Subject: [Koha-bugs] [Bug 5334] add explicit foreign key constraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14849 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849 [Bug 14849] Owner should be FK in uploaded_files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 15:20:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 14:20:39 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 15:43:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 14:43:51 +0000 Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #10 from Jonathan Druart --- (In reply to Jonathan Druart from comment #6) > (In reply to David Cook from comment #5) > > (In reply to Jonathan Druart from comment #4) > > > biblioitems.marc is used by misc/cronjobs/MARC21_parse_test.pl. Does this > > > script still used? > > > > I've never even heard of this script before, so I don't think that we use > > it. However, I suppose it's possible that someone uses it? > > > > Could we just remove the references to biblioitems.marc in this one script? > > Yes we could, if nobody uses the --fix option: > > 243 -f --fix Replace biblioitems.marcxml from data in marc field, > default OFF I have just used it right now. For testing purpose I have removed the marcxml field. Using --fix, I was able to repopulate it from the marc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 15:45:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 14:45:15 +0000 Subject: [Koha-bugs] [Bug 13534] Deleting staff member who moderated a tag removes tags imcompletely In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13534 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 15:45:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 14:45:17 +0000 Subject: [Koha-bugs] [Bug 13534] Deleting staff member who moderated a tag removes tags imcompletely In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13534 --- Comment #2 from Jonathan Druart --- Created attachment 46590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46590&action=edit Bug 13534: Do not remove tags on deleting a patron On deleting a patron, all the tags approved by this user will be deleted. This can cause data lost. Test plan: 0/ Do not execute the update DB entry 1/ Create 2 patrons A, B 2/ Create some tags with patron A logged in 3/ Approve them with patron B logged in 4/ Delete the 2 patrons => The tags have been deleted 5/ Execute the DB entry 6/ Repeat 1,2,3,4 => The tags have not been deleted and are still shown on the interface (result, detail, tags module) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 15:46:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 14:46:29 +0000 Subject: [Koha-bugs] [Bug 13534] Deleting staff patron will delete tags approved by this patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13534 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|normal |major Summary|Deleting staff member who |Deleting staff patron will |moderated a tag removes |delete tags approved by |tags imcompletely |this patron Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Increasing severity since it can cause data lost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 15:48:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 14:48:51 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46501|0 |1 is obsolete| | --- Comment #10 from Marc V?ron --- Created attachment 46591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46591&action=edit Bug 15096: Export today's checked in barcodes: Display warning if reading history is set to "never" If a patron's privacy settings are set to "Never" for keeping a reading history, "Export today's checked in barcodes" returns an empty file. This patch does not allow to export in such case. To test: - Apply patch - Check out / check in in some items -Test toolbar: - On user's detail page, go to More->Export today's checked in barcodes - Verify that the menu item does not appear if syspref 'intranetreadinghistory' is set to 'Don't allow' - Verify that the menu item appears if syspref 'intranetreadinghistory' is set to allow and - that the menu item is grayed out with a tooltip if the user has set privacy settings to never keep a reading history - that the menu item works as before if user's privacy settings allow reading history. - Test left tab "Circulation history": - Verify that the left tab "Circulation history" does not appear if syspref 'intranetreadinghistory' is set to 'Don't allow' - Verify that the tab appars if syspref 'intranetreadinghistory' is set to 'Allow' and - that a message appears if user's privacy settings do not allow to keep the reading history - that the export works as before if user's privacy settings allow to keep the reading history (Amended and changed test plan for comment #9) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 15:49:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 14:49:57 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #11 from Marc V?ron --- This patch needs a new sing-off. For new behaviour see new test plan (on patch). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 15:54:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 14:54:34 +0000 Subject: [Koha-bugs] [Bug 13542] Subscripton is only table to store userid instead of borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13542 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Can we envisage to simply remove this column? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 15:58:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 14:58:25 +0000 Subject: [Koha-bugs] [Bug 13542] Subscripton is only table to store userid instead of borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13542 --- Comment #3 from Katrin Fischer --- We save the creator in lots of places, maybe we could replaces it with a creator/user... whatever that has a FK on borrowers with a SET NULL on deletion of the borrower? We could also look up the userid visible in the borrowers and deletedborrowers tables ... but that might not always lead to a correct borrowernumber (userid could have been reused... not sure if that happens often). A bit worried a library might complain, but at the same time I am not sure how useful it is to save the initial creator - if someone changes the subscription afer, noone will know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 16:15:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 15:15:33 +0000 Subject: [Koha-bugs] [Bug 13668] Creator of an SQL report shoudl be NULL when the staff patron is deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 --- Comment #5 from Jonathan Druart --- Created attachment 46592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46592&action=edit Bug 13668: Add foreign key on saved_sql.borrowernumber saved_sql.borrowernumber refers to a borrowernumber, the DB structure should reflect this constraint. Test plan: 0/ Do not execute the update DB entry 1/ Add a new patron 2/ Use this patron to create a new report 3/ Delete the patron 4/ Execute the DB entry 5/ The saved_sql.borrowernumber for this report should have been set to NULL 6/ On the reports table, the column 'Author' should be empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 16:15:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 15:15:31 +0000 Subject: [Koha-bugs] [Bug 13668] Creator of an SQL report shoudl be NULL when the staff patron is deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 16:15:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 15:15:39 +0000 Subject: [Koha-bugs] [Bug 13668] Creator of an SQL report shoudl be NULL when the staff patron is deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 16:17:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 15:17:20 +0000 Subject: [Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #6 from Marc V?ron --- Oh, there was something missing. Switching bach to assigned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 16:41:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 15:41:19 +0000 Subject: [Koha-bugs] [Bug 13668] Creator of an SQL report shoudl be NULL when the staff patron is deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 16:41:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 15:41:19 +0000 Subject: [Koha-bugs] [Bug 5334] add explicit foreign key constraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13668 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 [Bug 13668] Creator of an SQL report shoudl be NULL when the staff patron is deleted -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 16:41:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 15:41:20 +0000 Subject: [Koha-bugs] [Bug 13534] Deleting staff patron will delete tags approved by this patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13534 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 16:41:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 15:41:20 +0000 Subject: [Koha-bugs] [Bug 5334] add explicit foreign key constraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13534 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13534 [Bug 13534] Deleting staff patron will delete tags approved by this patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 16:44:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 15:44:06 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #9 from Alex Arnaud --- Hello Mike, Nice to read your comment 4. I totally agree with you but i have a question: What do you mean by "openLDAP user-login-via-test-authbind method" ? For me, there is no difference between AD and openLDAP binds. Net::LDAP should work with both, right ? I think bug 8983 is quite tricky. It has the advantage that we can make more complex/useful mapping when replicating users from LDAP but it needs librian create a package with perl code. The attached patch here is more simple and could solve (with a little change) the problem of multiple branche. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:13:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:13:33 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15568 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 [Bug 15568] Circ rules are not displayed anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:13:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:13:33 +0000 Subject: [Koha-bugs] [Bug 15568] New: Circ rules are not displayed anymore Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Bug ID: 15568 Summary: Circ rules are not displayed anymore Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: System Administration Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 11625 When changing the library from specific to all, the rules are not displayed anymore on the circ rules admin table. git bisect blames: commit 83e913f8c26a815019ffde21524cc7f126357d57 Bug 11625 - Implement DefaultToLoggedInLibraryCircRules Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 [Bug 11625] Default to logged in library for circ rules and notices & slips -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:15:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:15:36 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:15:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:15:38 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 --- Comment #1 from Jonathan Druart --- Created attachment 46593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46593&action=edit Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:36:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:36:41 +0000 Subject: [Koha-bugs] [Bug 15569] New: Automatic renewal should not be displayed if the patron cannot checkout Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Bug ID: 15569 Summary: Automatic renewal should not be displayed if the patron cannot checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 10860, 11577 If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 [Bug 10860] On-site checkouts (was In-House Use) http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 [Bug 11577] Automatic renewals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:36:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:36:41 +0000 Subject: [Koha-bugs] [Bug 11577] Automatic renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15569 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:36:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:36:41 +0000 Subject: [Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15569 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:38:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:38:35 +0000 Subject: [Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 --- Comment #1 from Jonathan Druart --- Created attachment 46594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46594&action=edit Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen. Test plan: Enable OnSiteCheckouts and OnSiteCheckoutsForce Debar a patron and go on the circulation page. Without this patch, the automatic renewal checkbox is displayed. With this patch applied, it's not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:38:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:38:33 +0000 Subject: [Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:44:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:44:52 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:44:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:44:56 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46518|0 |1 is obsolete| | Attachment #46519|0 |1 is obsolete| | Attachment #46520|0 |1 is obsolete| | Attachment #46521|0 |1 is obsolete| | Attachment #46522|0 |1 is obsolete| | Attachment #46523|0 |1 is obsolete| | Attachment #46524|0 |1 is obsolete| | Attachment #46525|0 |1 is obsolete| | Attachment #46526|0 |1 is obsolete| | Attachment #46527|0 |1 is obsolete| | Attachment #46528|0 |1 is obsolete| | Attachment #46530|0 |1 is obsolete| | --- Comment #109 from Kyle M Hall --- Created attachment 46595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46595&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:05 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #110 from Kyle M Hall --- Created attachment 46596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46596&action=edit Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:09 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #111 from Kyle M Hall --- Created attachment 46597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46597&action=edit Bug 14610 - Add and update scripts Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:13 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #112 from Kyle M Hall --- Created attachment 46598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46598&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:16 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #113 from Kyle M Hall --- Created attachment 46599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46599&action=edit Bug 14610 [QA Followup] - Rename AR_PRINT to AR_SLIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:20 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #114 from Kyle M Hall --- Created attachment 46600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46600&action=edit Bug 14610 [QA Followup] - Remove bad copyright lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:23 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #115 from Kyle M Hall --- Created attachment 46601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46601&action=edit Bug 14610 [QA Followup] - Fix issuingrules database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:30 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #117 from Kyle M Hall --- Created attachment 46603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46603&action=edit Bug 14610 [QA Followup] - Change 'Open' to 'Pending' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:27 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #116 from Kyle M Hall --- Created attachment 46602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46602&action=edit Bug 14610 [QA Followup] - Make prompt tranlatable, only show comma if firstname is set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:34 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #118 from Kyle M Hall --- Created attachment 46604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46604&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:37 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #119 from Kyle M Hall --- Created attachment 46605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46605&action=edit Bug 14610 - Update opac.css via less -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:41 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #120 from Kyle M Hall --- Created attachment 46606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46606&action=edit Bug 14610 [QA Followup] - Don't call get_template_and_user for request-article-do.pl or opac-request-article-do.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:45 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #121 from Kyle M Hall --- Created attachment 46607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46607&action=edit Bug 14610 [QA Followup] - Add non-ajax patron search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:48 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #122 from Kyle M Hall --- Created attachment 46608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46608&action=edit Bug 14610 [QA Followup] - Add request article button to cat toolbar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:52 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #123 from Kyle M Hall --- Created attachment 46609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46609&action=edit Bug 14610 [QA Followup] - Update article request counts in tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:55 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #124 from Kyle M Hall --- Created attachment 46610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46610&action=edit Bug 14610 [QA Followup] - Add article requests count to tab like it is for holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:45:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:45:59 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #125 from Kyle M Hall --- Created attachment 46611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46611&action=edit Bug 14610 [QA Followup] - Add "All libraries" option to article-requests.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:46:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:46:03 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #126 from Kyle M Hall --- Created attachment 46612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46612&action=edit Bug 14610 [QA Followup] - Add article requets count on detail.pl like it is for holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 17:47:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 16:47:39 +0000 Subject: [Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46594|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 46613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46613&action=edit Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen. Test plan: Enable OnSiteCheckouts and OnSiteCheckoutsForce Debar a patron and go on the circulation page. Without this patch, the automatic renewal checkbox is displayed. With this patch applied, it's not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 18:50:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 17:50:54 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15570 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 [Bug 15570] circ/renew.pl is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 18:50:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 17:50:54 +0000 Subject: [Koha-bugs] [Bug 15570] New: circ/renew.pl is broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 Bug ID: 15570 Summary: circ/renew.pl is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Circulation Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 11944 Using this script to renew an issue, you will get a "Template process failed: plugin error - ". Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 [Bug 11944] Cleanup Koha UTF-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 18:52:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 17:52:23 +0000 Subject: [Koha-bugs] [Bug 15570] circ/renew.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 18:52:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 17:52:26 +0000 Subject: [Koha-bugs] [Bug 15570] circ/renew.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 --- Comment #1 from Jonathan Druart --- Created attachment 46614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46614&action=edit Bug 15570: (follow-up) Bug 11944 Remove all utf8 filter from templates Test plan: use circ/renew.pl to renew an issue. Without this patch, you will get an error. Note: The error exists for 1 year now and nobody complained?? Does someone still use this script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 19:08:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 18:08:15 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #5 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Margaret Holt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 19:08:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 18:08:28 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46445|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 19:08:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 18:08:31 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46446|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 19:08:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 18:08:38 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 --- Comment #6 from sandboxes at biblibre.com --- Created attachment 46615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46615&action=edit Bug 15530 - Add Unit Test Signed-off-by: Margaret Holt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 19:08:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 18:08:41 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 46616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46616&action=edit Bug 15530 - Editing a course item via a disabled course disables it even if it is on other enabled courses It appears that if the course item is edited by clicking the edit link from an active course, the course item will be set to enabled and the fields will be swapped, if the same course item is edited from a course that is *not* active, the course item will be set to *not* enabled, and the original fields will be swapped back in! The short term work-around is to only edit course items from an enabled course if the item has a course that is enabled. If all the courses it is on are disabled, it doesn't matter what course the item is edited from. Test Plan: 1) Create two courses, 1 enabled and 1 disabled 2) Add an item as a course reserve to both courses 3) Edit the course reserve data for the item via the enabled course 4) Note the course item is enabled ( easy way is to check the database ) 5) Edit the same course reserve data, but via the disabled course 6) Note the course item is now disabled even though it is part of an enabled course! 7) Apply this patch 8) Repeat steps 1 through 5 9) Note the course item is still enabled Signed-off-by: Margaret Holt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 19:43:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 18:43:04 +0000 Subject: [Koha-bugs] [Bug 10747] PDF template for order printing should be selectable per order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10747 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 20:00:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 19:00:48 +0000 Subject: [Koha-bugs] [Bug 15571] New: reserveforothers permission does not remove Search to hold button from patron account Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Bug ID: 15571 Summary: reserveforothers permission does not remove Search to hold button from patron account Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Deactivating the reserveforothers permission (or place_holds) effectively keeps staff from placing holds for patrons, but it should also remove the button from the patron screens (circulation.pl, moremember.pl, pay.pl, routing-lists.pl, notices.pl, statistics.pl, etc.). Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 20:04:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 19:04:37 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 20:04:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 19:04:41 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46116|0 |1 is obsolete| | Attachment #46117|0 |1 is obsolete| | Attachment #46118|0 |1 is obsolete| | --- Comment #24 from Mirko Tietgen --- Created attachment 46617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46617&action=edit Bug 15303 Letsencrypt option for Debian package installations Apache file for https only setups with automatic certificate generation via letsencrypt. We need a workiung web server for the letsencrypt magic, but we can't start on 443 without certs. So we start on 80, get the certs, switch to 443 and restart apache. 80 gets forwarded to https. New option koha-create --force-https - generates letsencrypt certificates - sets up a https-only website - redirects http to https New option --letsencrypt - sets the path where letsencrypt-auto lives - default value /usr/bin, but there is no Debian package yet Test plan: - build a debian package with patch applied - checkout letsencrypt on the machine where you are testing the package git clone https://github.com/letsencrypt/letsencrypt - use apache mod_ssl sudo a2enmod ssl - make sure the machine is accessible on 80 (needed for letsencrypt) and 443 from the internet - install koha with your new package - Put your (existing) domain options in /etc/koha/koha-sites.conf - use koha-create with the new options: sudo koha-create --create-db --force-https --letsencrypt /home/mirko/letsencrypt - wait until setup is finished, check that you got a working OPAC and staff client with certificates make sure to use https:// to open both sites - check that http redirects to https -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 20:29:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 19:29:54 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #14 from Brendan Gallagher --- Pushed to master - thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 20:54:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 19:54:09 +0000 Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 --- Comment #1 from Heather Braum --- Created attachment 46618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46618&action=edit NExpress issuing rules table dump -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 20:55:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 19:55:21 +0000 Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 --- Comment #2 from Heather Braum --- The NExpress consortia (50 branches) is sponsoring this development. I know Jesse has access to our issuingrules table already, but I'm responding to his call on the developers list and adding our current issuingrules to the bug report. It really is truly too complex how it stands right now (esp for multi-branch systems). I have a 27" monitor and can't see all the columns even when the circ rules page is full screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:22:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:22:33 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:23:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:23:12 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:25:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:25:44 +0000 Subject: [Koha-bugs] [Bug 15570] circ/renew.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #2 from Kyle M Hall --- (In reply to Jonathan Druart from comment #1) > Created attachment 46614 [details] [review] > Bug 15570: (follow-up) Bug 11944 Remove all utf8 filter from templates > > Test plan: > use circ/renew.pl to renew an issue. > Without this patch, you will get an error. > > Note: The error exists for 1 year now and nobody complained?? Does > someone still use this script? Yes, the library that sponsored the feature is still on an older stable release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:27:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:27:14 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:27:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:27:33 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:53:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:53:33 +0000 Subject: [Koha-bugs] [Bug 15572] New: Authority creation fails when authid is linked to 001 field Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 Bug ID: 15572 Summary: Authority creation fails when authid is linked to 001 field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When adding a new authority, authorities.pl run foreever when authid is linked to 001 field. This is related to bug 6657 which modified the way C4::Biblio::TransformHtmlToMarc operates in order to solve an issue occurring during biblio record cataloging. But this function is also used by authorities cataloging, and the code in this case is irrelevant. Occurs also in 3.20. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:54:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:54:49 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |julian.maurice at biblibre.com | |, katrin.fischer at bsz-bw.de Depends on| |6657 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:54:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:54:49 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15572 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 [Bug 15572] Authority creation fails when authid is linked to 001 field -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:55:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:55:37 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:56:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:56:48 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:56:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:56:51 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #1 from Fr?d?ric Demians --- Created attachment 46619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46619&action=edit Bug 6657: Follow-up to fix error on authority creation Bug 6657 modified the way C4::Biblio::TransformHtmlToMarc operates in order to solve an issue occuring during biblio record cataloguing. But this function is also used by authorities cataloguing, and the code in this case is irrelevante. This followup allows to distinguish for which kind of record TransformHtmlToMarc is called: biblio/authority. A bug appears in authority creation without this patch in some circunstances: when authid is linked to 001 field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:56:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:56:59 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #2 from Fr?d?ric Demians --- Created attachment 46620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46620&action=edit Bug 6657: Add tests for TransformHtmlToMarc Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:57:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:57:18 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #3 from Fr?d?ric Demians --- Created attachment 46621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46621&action=edit Bug 6657: TransformHtmlToMarc - rewrite the loop This rewrites the while loop into a for loop, so $i still gets incremented when we call next Signed-off-by: Fr?d?ric Demians Make sense. Add readability. Infinite loop no more possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:58:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:58:29 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #4 from Fr?d?ric Demians --- Patch-1 has to be sign-off. Patch-2 and 3 are already signed-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:58:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:58:48 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:59:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:59:04 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46543|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:59:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:59:19 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46569|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:59:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:59:35 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 21:59:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 20:59:36 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 Bug 15572 depends on bug 6657, which changed state. Bug 6657 Summary: Making 999 visible in framework duplicates 999 entry and affects index http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 22:00:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 21:00:46 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 --- Comment #42 from Fr?d?ric Demians --- (In reply to Katrin Fischer from comment #41) > Hi Frederic, I am ok with both - leaving it here or separating it out. I've closed this patch, since it's already pushed in master, and attached the set of patch to new bug 15572. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 22:15:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 21:15:43 +0000 Subject: [Koha-bugs] [Bug 15570] circ/renew.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org --- Comment #3 from Heather Braum --- Kyle beat me to commenting -- I just checked it on 3.18.12 and it's still working as expected, hence no complaints yet! Only our school libraries are using the feature, as far as I know. They would have let me know if it was broken. I haven't started testing 3.22 yet (coming soon), but will definitely be tracking this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 23:06:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 22:06:18 +0000 Subject: [Koha-bugs] [Bug 14631] Change to "Patron" in patroncard toolbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Danielle Elder changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle at bywatersolutions.c | |om --- Comment #13 from Danielle Elder --- Comment on attachment 41306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41306 Bug 14631 - Change item(s) to patron(s) in toolbar Did not apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 23:13:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 22:13:30 +0000 Subject: [Koha-bugs] [Bug 14631] Change to "Patron" in patroncard toolbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 --- Comment #14 from Liz Rea --- Hi, I'm not sure most of this is even applicable, as the patron card creator has had a UI overhaul since this bug was started. It would pay to go through and make sure we didn't miss any items -> patrons conversion as part of that work, but this may not be relevant anymore. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 23:14:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 22:14:09 +0000 Subject: [Koha-bugs] [Bug 14631] Change to "Patron" in patroncard toolbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Liz Rea --- Bug 14676 is the one that did most of that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 23:26:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 22:26:01 +0000 Subject: [Koha-bugs] [Bug 13668] Creator of an SQL report shoudl be NULL when the staff patron is deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 23:26:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 22:26:03 +0000 Subject: [Koha-bugs] [Bug 13668] Creator of an SQL report shoudl be NULL when the staff patron is deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46592|0 |1 is obsolete| | --- Comment #6 from Joy Nelson --- Created attachment 46622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46622&action=edit Bug 13668: Add foreign key on saved_sql.borrowernumber saved_sql.borrowernumber refers to a borrowernumber, the DB structure should reflect this constraint. Test plan: 0/ Do not execute the update DB entry 1/ Add a new patron 2/ Use this patron to create a new report 3/ Delete the patron 4/ Execute the DB entry 5/ The saved_sql.borrowernumber for this report should have been set to NULL 6/ On the reports table, the column 'Author' should be empty. Signed-off-by: Joy Nelson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 23:35:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 22:35:04 +0000 Subject: [Koha-bugs] [Bug 14668] Show serial enumeration in the checkin page and the patron's opac checkout summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #2 from Joy Nelson --- Did not apply for me. (In reply to Charles Farmer from comment #1) > Created attachment 45294 [details] [review] > Bug 14668 - Show serial enumeration in the checkin page and the patron's > opac checkout summary > > The enumchron is now displayed alongside the author name in the "Title" > section of the item summary. > > TEST PLAN > ========= > > 1) INTRANET > > 1) Edit an item and add something in the "h" subfield, ie: "volume > #42" > 2) Check out the item to a patron > 3) In the patron page, both at the bottom of the page or in the > "Check out" tab, you should see the enumchron concatenated with the title > > 2) OPAC > > 1) Search for the same patron you used earlier > 2) In the "your summary" tab, you should see the enumchron in the > Title > > 3) INTRANET > > 1) Check in the item you just borrowed > 2) At check in, the enumchron should also appear in the Title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 13 23:35:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 22:35:49 +0000 Subject: [Koha-bugs] [Bug 13668] Creator of an SQL report shoudl be NULL when the staff patron is deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Danielle Elder changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46622|0 |1 is obsolete| | --- Comment #7 from Danielle Elder --- Created attachment 46623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46623&action=edit Bug 13668: Add foreign key on saved_sql.borrowernumber saved_sql.borrowernumber refers to a borrowernumber, the DB structure should reflect this constraint. Test plan: 0/ Do not execute the update DB entry 1/ Add a new patron 2/ Use this patron to create a new report 3/ Delete the patron 4/ Execute the DB entry 5/ The saved_sql.borrowernumber for this report should have been set to NULL 6/ On the reports table, the column 'Author' should be empty. Signed-off-by: Joy Nelson Signed-off-by: Dani Elder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 00:00:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 23:00:11 +0000 Subject: [Koha-bugs] [Bug 15573] New: String and translatability fix to Patron Card Creator Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Bug ID: 15573 Summary: String and translatability fix to Patron Card Creator Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Most of the changes from 'Item' to 'Patron' were fixed, but there is one case where it still says 'Item Count' and a case for a translatability fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 00:03:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 23:03:49 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 --- Comment #1 from Aleisha Amohia --- Created attachment 46624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46624&action=edit Bug 15573: String and translatability fix to Patron Card Creator To test: 1) Go to Tools -> Patron Card Creator -> Manage -> Card batches 2) Confirm the table heading reads 'Patron Count' 3) Edit a batch 4) Click Remove duplicates 5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 00:03:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 23:03:46 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 00:13:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 23:13:32 +0000 Subject: [Koha-bugs] [Bug 15103] Import Borrowers Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103 rocio at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rocio at bywatersolutions.com --- Comment #5 from rocio at bywatersolutions.com --- I tested this on a test site and got these results: csv1 - 53.75 secs csv2 - 48.27 secs I erased all borrowers in the table and tested again: csv1 - 52.92 sec csv2 - 47.74 sec I would recommend that someone else test this to confirm. I used the csv files as-is, with the exception of changing the branch and category codes to match my configuration. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 00:14:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 23:14:25 +0000 Subject: [Koha-bugs] [Bug 14631] Change to "Patron" in patroncard toolbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Patch doesn't apply |RESOLVED --- Comment #16 from Liz Rea --- Aleisha has opened bug 15573 for the remaining things to be fixed here. As the UI is totally changed, nothing here is of importance anymore. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 00:27:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 23:27:31 +0000 Subject: [Koha-bugs] [Bug 15103] Import Borrowers Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103 rocio at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 00:27:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 23:27:33 +0000 Subject: [Koha-bugs] [Bug 15103] Import Borrowers Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103 rocio at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44443|0 |1 is obsolete| | --- Comment #6 from rocio at bywatersolutions.com --- Created attachment 46625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46625&action=edit Bug 15103: Import Borrowers Performance Improvement Improves the performance of importing borrowers in batches from file by by switching out resultset calls for more direct SQL queries and using hash lookups instead of repeated DB lookups. Test Plan: 1) Prepare NTYprof (http://wiki.koha-community.org/wiki/Profiling_with_Devel::NYTProf) or procure a stopwatch (stopwatch will be simpler but less accurate). 2) Download the PatronDataCSV1.csv and PatronDataCSV2.csv attachements from the bug page or organise your own csv's with data for 1000 or more patrons to import. 3) Navigate to Home > Tools > Import Patrons in the Koha Intranet (http://demo-intra.mykoha.co.nz/cgi-bin/koha/tools/import_borrowers.pl) 4) Click the "Browse..." button and select PatronDataCSV1.csv or your equilient. 5) If you are using a stopwatch, prepare your stopwatch so that you will start counting seconds from the point you click the button in the next step. 6) Scroll to the bottom of the page and click the "Import" button (simultaneously start your stopwatch if using one) 7) When the page appears showing completion of the import, stop your stopwatch and check the time or navigate to the folder you have set NYTProf to output. 8) Record the runtime. This is the pre-optimisation time. 9) Apply this patch. 9) Repeat steps 2-7 of this testplan with the patch applied and use the PatronDataCSV2.csv this time around. This will yield the post-optimisation time. 10) Compare the pre-optimisation time and post optimisation time. The second post-optimisation time should be faster. Signed-off-by: Rocio Jordan -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 00:33:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 23:33:51 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 --- Comment #7 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #6) > Doesn't it make more sense to display it like: > Date of birth: dd/mm/yyyy (xx years) > ? Patch to come -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 00:37:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 23:37:58 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 00:38:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 23:38:01 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46570|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia --- Created attachment 46626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46626&action=edit Bug 14763: Calculate and display patron age To test: 1) Go to patron Details page (ie http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51) 2) Confirm that '(x years)' is showing next to the Date of Birth and is correct according to DOB (ie if DOB: 30/11/1996, Age: 19 years) 3) Edit date of birth to be a month later (ie from 30 November to 30 December) so that, as of the date you are testing, the patron has not had their birthday yet 4) Confirm that age changes to be one year younger 5) Edit date of birth to be a different year 6) Confirm that age changes accordingly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 00:47:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 23:47:29 +0000 Subject: [Koha-bugs] [Bug 15403] Confirm messages in intranet lists interface strangely worded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 00:47:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 23:47:32 +0000 Subject: [Koha-bugs] [Bug 15403] Confirm messages in intranet lists interface strangely worded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403 --- Comment #1 from Aleisha Amohia --- Created attachment 46627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46627&action=edit Bug 15403: Tidy up error messages in Staff lists To test: 1) Create a list on the intranet, observe the message 2) Create another list with the same name, observe the message 3) Delete a list, observe the message 4) Check the patch itself for typos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 00:56:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 23:56:43 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 00:56:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jan 2016 23:56:47 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46591|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia --- Created attachment 46628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46628&action=edit Bug 15096: Export today's checked in barcodes: Display warning if reading history is set to "never" If a patron's privacy settings are set to "Never" for keeping a reading history, "Export today's checked in barcodes" returns an empty file. This patch does not allow to export in such case. To test: - Apply patch - Check out / check in in some items -Test toolbar: - On user's detail page, go to More->Export today's checked in barcodes - Verify that the menu item does not appear if syspref 'intranetreadinghistory' is set to 'Don't allow' - Verify that the menu item appears if syspref 'intranetreadinghistory' is set to allow and - that the menu item is grayed out with a tooltip if the user has set privacy settings to never keep a reading history - that the menu item works as before if user's privacy settings allow reading history. - Test left tab "Circulation history": - Verify that the left tab "Circulation history" does not appear if syspref 'intranetreadinghistory' is set to 'Don't allow' - Verify that the tab appars if syspref 'intranetreadinghistory' is set to 'Allow' and - that a message appears if user's privacy settings do not allow to keep the reading history - that the export works as before if user's privacy settings allow to keep the reading history (Amended and changed test plan for comment #9) Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 01:00:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 00:00:52 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 01:07:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 00:07:59 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #23 from Aleisha Amohia --- CONFLICT (content): Merge conflict in C4/Biblio.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 01:24:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 00:24:06 +0000 Subject: [Koha-bugs] [Bug 15570] circ/renew.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #4 from Aleisha Amohia --- circ/renew.pl is not working for me, i keep getting this error: Can't call method "single" without a package or object reference at /home/vagrant/kohaclone/circ/renew.pl line 57. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 01:39:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 00:39:56 +0000 Subject: [Koha-bugs] [Bug 15574] New: Better wording for error message when adding tags Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15574 Bug ID: 15574 Summary: Better wording for error message when adding tags Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org When a user attempts to add a tag which already exists, the error message starts with: "Error! The add_tag operation failed on" which is kind of developer speak and should be worded better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 01:43:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 00:43:02 +0000 Subject: [Koha-bugs] [Bug 15574] Better wording for error message when adding tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15574 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 01:43:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 00:43:04 +0000 Subject: [Koha-bugs] [Bug 15574] Better wording for error message when adding tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15574 --- Comment #1 from Aleisha Amohia --- Created attachment 46629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46629&action=edit Bug 15574: Better wording for error message when adding a duplicate tag To test: 1) Apply patch 2) Go to a record (ie opac-detail.pl) and add tags that already exist with that record 3) Confirm new error message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 01:51:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 00:51:28 +0000 Subject: [Koha-bugs] [Bug 15394] Confirm messages on OPAC lists interface strangely worded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15394 --- Comment #7 from Liz Rea --- (In reply to Jonathan Druart from comment #5) > (In reply to Liz Rea from comment #4) > > Hi Jonathan, I've opened bug 15403 for the intranet. :) > > There is no patch on bug 15403 :) There is now! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 01:55:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 00:55:12 +0000 Subject: [Koha-bugs] [Bug 13534] Deleting staff patron will delete tags approved by this patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13534 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 01:55:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 00:55:16 +0000 Subject: [Koha-bugs] [Bug 13534] Deleting staff patron will delete tags approved by this patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13534 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46590|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 46630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46630&action=edit Bug 13534: Do not remove tags on deleting a patron On deleting a patron, all the tags approved by this user will be deleted. This can cause data lost. Test plan: 0/ Do not execute the update DB entry 1/ Create 2 patrons A, B 2/ Create some tags with patron A logged in 3/ Approve them with patron B logged in 4/ Delete the 2 patrons => The tags have been deleted 5/ Execute the DB entry 6/ Repeat 1,2,3,4 => The tags have not been deleted and are still shown on the interface (result, detail, tags module) Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 02:13:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 01:13:48 +0000 Subject: [Koha-bugs] [Bug 15575] New: opac-authorities-home.pl broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15575 Bug ID: 15575 Summary: opac-authorities-home.pl broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Every time I click submit, regardless of what I put in the search boxes, I get this software error: Can't call method "authtypetext" on an undefined value at /home/vagrant/kohaclone/opac/opac-authorities-home.pl line 155. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 03:20:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 02:20:21 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 03:20:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 02:20:24 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45715|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia --- Created attachment 46631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46631&action=edit Bug 15375 - Translatability: Fix issues on OPAC page 'Placing a hold' Fix several issues with odd translations on opac-reserve.tt due to string splitting by tags. In addition, streamline messages to make them similar to the same messages on the OPAC summary page (Bug 15374) To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with expired account - with user with uncertain address information - Try to put holds - Verify that message about why holds are not possible is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions (Amended: stray i removed, test plan updated, removed account that is about to expire) Signed-off-by: Aleisha I am going to sign off on this because it works as it should and I think the problems I had in comment 8 are a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 03:23:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 02:23:49 +0000 Subject: [Koha-bugs] [Bug 15576] New: Link in OPAC redirects to the wrong page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15576 Bug ID: 15576 Summary: Link in OPAC redirects to the wrong page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org When a user has an uncertain address, a yellow message shows up on the OPAC summary page (opac-user.pl). The link redirects to opac-userupdate.pl, which is the wrong page and doesn't exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 03:28:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 02:28:03 +0000 Subject: [Koha-bugs] [Bug 15576] Link in OPAC redirects to the wrong page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15576 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 03:28:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 02:28:05 +0000 Subject: [Koha-bugs] [Bug 15576] Link in OPAC redirects to the wrong page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15576 --- Comment #1 from Aleisha Amohia --- Created attachment 46632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46632&action=edit Bug 15576: Fix for incorrect link redirect To test: 1) Edit a user to have an uncertain address (gone no address) 2) Log in as that user on OPAC 3) Click 'online update form' link in the yellow message 4) Confirm you are taken to opac-memberentry.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 03:33:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 02:33:14 +0000 Subject: [Koha-bugs] [Bug 15577] New: Link in OPAC doesn't redirect anywhere Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 Bug ID: 15577 Summary: Link in OPAC doesn't redirect anywhere Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org When a user has a restriction or is debarred, a yellow message shows up on the OPAC summary page (opac-user.pl). The link is meant to redirect to the accounts page (opac-account.pl) but it doesn't go anywhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 03:37:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 02:37:27 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 03:37:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 02:37:29 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 --- Comment #1 from Aleisha Amohia --- Created attachment 46633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46633&action=edit Bug 15577: Correcting link redirect To test: 1) Add a restriction to a user 2) Log in as that user in the OPAC 3) Click 'your account page' link in the yellow mesage 4) Confirm you are taken to opac-account.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 03:41:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 02:41:32 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 --- Comment #11 from Aleisha Amohia --- (In reply to Aleisha Amohia from comment #8) > Can't sign off on this yet, a few things: > > Blocked/debarred user - the link to the account page did not work, even > though I can see in the code that it should so I am not sure what happened > there but it did not redirect me anywhere. Patch for this on Bug 15577 > Uncertain address information - The link took me to opac-userupdate.pl which > doesn't exist - should be to opac-memberentry.pl Patch for this on Bug 15576 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 04:03:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 03:03:25 +0000 Subject: [Koha-bugs] [Bug 15535] can't call method "default-privacy" on an undefined value /usr/share/koha/lib/c4/members.pm line 753 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15535 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #3 from Aleisha Amohia --- (In reply to Marc V?ron from comment #2) > - not display the self registration link if PatronSelfRegistration is set > and PatronSelfRegistrationDefaultCategory is wrong or does not exist I think this is probably the best option, as well as updating the descriptions for both system preferences. For example, update PatronSelfRegistration to say that even when set to Allow, the link will not display if PatronSelfRegistrationDefaultCategory is incorrectly set. Then update PatronSelfRegistrationDefaultCategory and give options of common patron categories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 05:13:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 04:13:39 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 05:13:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 04:13:43 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46489|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 46634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46634&action=edit [SIGNED-OFF]Bug 15548: Move new patron related code to Patron* The 'borrower' should not be used anymore, especially for new code. This patch move files and rename variables newly pushed (i.e. in the Koha namespace). Test plan: 1/ git grep Koha::Borrower should not return code in use. 2/ Prove the different modified test files 3/ Do some clicks in the member^Wpatron module to be sure there is not an obvious error. Signed-off-by: Hector Castro Works as described. Tested with Circulation, Members/Patrons, Discharge, Restrictions modules and the must common functionalities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 05:40:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 04:40:43 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 05:40:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 04:40:46 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46619|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 46635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46635&action=edit [SIGNED-OFF]Bug 6657: Follow-up to fix error on authority creation Bug 6657 modified the way C4::Biblio::TransformHtmlToMarc operates in order to solve an issue occuring during biblio record cataloguing. But this function is also used by authorities cataloguing, and the code in this case is irrelevante. This followup allows to distinguish for which kind of record TransformHtmlToMarc is called: biblio/authority. A bug appears in authority creation without this patch in some circunstances: when authid is linked to 001 field. Signed-off-by: Hector Castro Tested with a new authority record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 05:41:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 04:41:24 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46620|0 |1 is obsolete| | --- Comment #6 from H?ctor Eduardo Castro Avalos --- Created attachment 46636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46636&action=edit Bug 6657: Add tests for TransformHtmlToMarc Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 05:41:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 04:41:35 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46621|0 |1 is obsolete| | --- Comment #7 from H?ctor Eduardo Castro Avalos --- Created attachment 46637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46637&action=edit Bug 6657: TransformHtmlToMarc - rewrite the loop This rewrites the while loop into a for loop, so $i still gets incremented when we call next Signed-off-by: Fr?d?ric Demians Make sense. Add readability. Infinite loop no more possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 05:53:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 04:53:36 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 05:53:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 04:53:40 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46624|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 46638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46638&action=edit [SIGNED-OFF]Bug 15573: String and translatability fix to Patron Card Creator To test: 1) Go to Tools -> Patron Card Creator -> Manage -> Card batches 2) Confirm the table heading reads 'Patron Count' 3) Edit a batch 4) Click Remove duplicates 5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)' Signed-off-by: Hector Castro Works as described. Rewording Ok for translatability purpose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 07:18:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 06:18:03 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #2 from H?ctor Eduardo Castro Avalos --- Another bug Aleisha, opac-userupdate.pl lead us to a html code error 404 if you click in "online update form". I will fix this in a follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 07:19:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 06:19:15 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 46639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46639&action=edit Bug 15577: 404 html code error in OPAC message with syspref OPACPatronDetails The script opac-userupdate.pl doesn't exist in Koha. Fix the link redirecting to opac-memberentry.pl and reword the message. To reproduce the issue: 1)Edit whichever patron 2)Check Yes in 'Gone no Address' and 'Lost card' 3)Login as the user in OPAC 4)See the yellow message in summary of the account and click in 'online update form' this link redirect to 404 code error page. 5)Play with syspref OPACPatronDetails to Allow and Don't Allow To test: -Apply patch -Follow steps 1 to 5 -Confirm that you are taken to 'your personal details' page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 07:21:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 06:21:38 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 --- Comment #4 from Aleisha Amohia --- (In reply to H?ctor Eduardo Castro Avalos from comment #2) > Another bug Aleisha, opac-userupdate.pl lead us to a html code error 404 if > you click in "online update form". > > I will fix this in a follow-up I already have this in Bug 15576! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 07:55:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 06:55:31 +0000 Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 07:56:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 06:56:21 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:24:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:24:15 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #0) > As previously agreed, we need to standardize our wording, Borrower should be > Patron. Was this announced somewhere? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:38:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:38:29 +0000 Subject: [Koha-bugs] [Bug 15535] can't call method "default-privacy" on an undefined value /usr/share/koha/lib/c4/members.pm line 753 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15535 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master Severity|major |normal --- Comment #4 from Jonathan Druart --- Lowering the severity as it comes from a configuration issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:41:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:41:39 +0000 Subject: [Koha-bugs] [Bug 15570] circ/renew.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 --- Comment #5 from Jonathan Druart --- Aleisha, update your repo, this error has been fixed by bug 15462. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:44:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:44:47 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27296|0 |1 is obsolete| | --- Comment #40 from Mirko Tietgen --- Created attachment 46640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46640&action=edit Bug 8897 [ENH] GPG Mail encryption -- New version Koha should offer patrons the option to receive their emails encrypted. This patch adds a dialog to the user interface (OPAC side) for patrons to add or delete a GPG public key. The key is directly added to or deleted from gpg (gnupg needs to be installed, binary expected at /usr/bin/gpg). This feature does not require sysadmins/librarians to do anything as long as the gpg binary if found. So far, mails are encrypted if a key for the recipient is avaliable - when sending lists or carts (encryption of email text + attachment) - when mails are sent through the message queue - ... Missing so far: - hide public key interface from OPAC/userdetails when no binary is found - de-hardcode path to gpg (syspref) - deal with BCC mails (send message explaining that an encrypted email has been send to the patron instead of a BCC) - ... Maybe later: - library-side key management: secret key for signing - encryption of emails from library to vendors - ... Test plan: -apply patch * Add/delete key: - in OPAC, log in as a user you got GPG kes for (primary email needs to match the key) - go to user details, email encryption - paste your public key into the form, save. when the page reloads, your key should be displayed in the form and a delete button at the bottom. in the terminal (as the koha-user!), do 'gpg --list-keys' and verify the key you just added is present - press the delete button under the form. on reload the form should be empty and your key gone. verify with (as the koha user) 'gpg --list-keys' in the terminal. - paste your key into the form again and save to do the following tests. * Encrypted cart emails - do a search, save a record in the the cart. open the cart, send it to the adress you added the key for. - check if the mail you receive has encrypted text and an encrypted attachment - decrypt both the text and the attachment, check if they are what you would expect * Encrypted list emails - if you do not have any lists, set up one with one record. - open the list from the opac, send it to you. enter the address you just added the key for - check that the mail you receive has encrypted text and an encrypted attachment. - decrypt both the text and the attachment, check if they are what you would expect * Encrypted message queue emails - check some items in and out for the patron you added the key for - wait for the message queue cronjob to run or run it manually - check if the email(s) you receive are encrypted and after decryption contain what you would expect Check all this again with another patron (without a gpg key) or use the same but delete the key before. Check that all mails and attachments are unencrypted and contain what you would expect (nothing is broken). If all that works for you, sign off the patch. Squashed a few minor changes. Bug 8897 Follow-up: plack fix NOTE: I rebased this so it applies nicely. I'm setting into 'In Discussion', so the original author can rebase himself or confirm this is good. I found the following: - Bug 8368 (only a couple days after the last rebase) patch (recoded the line, for the first conflict -- New version is correct) (renamed shelf to list, for the second conflict -- Second version is this patch) - Bug 11124 triggers a conflict in C4/Installer/PerlDependencies.pm - Bug 9611 also affected C4/Installer/PerlDependencies.pm and debian/control - Bug 5544 added code which caused a conflict for C4/Letter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:45:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:45:43 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:45:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:45:46 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46635|0 |1 is obsolete| | Attachment #46636|0 |1 is obsolete| | Attachment #46637|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 46641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46641&action=edit Bug 15572: Follow-up to fix error on authority creation Bug 6657 modified the way C4::Biblio::TransformHtmlToMarc operates in order to solve an issue occuring during biblio record cataloguing. But this function is also used by authorities cataloguing, and the code in this case is irrelevante. This followup allows to distinguish for which kind of record TransformHtmlToMarc is called: biblio/authority. A bug appears in authority creation without this patch in some circunstances: when authid is linked to 001 field. Signed-off-by: Hector Castro Tested with a new authority record Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:45:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:45:49 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #9 from Jonathan Druart --- Created attachment 46642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46642&action=edit Bug 15572: Add tests for TransformHtmlToMarc Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:45:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:45:52 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #10 from Jonathan Druart --- Created attachment 46643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46643&action=edit Bug 15572: TransformHtmlToMarc - rewrite the loop This rewrites the while loop into a for loop, so $i still gets incremented when we call next Signed-off-by: Fr?d?ric Demians Make sense. Add readability. Infinite loop no more possible. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:46:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:46:44 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #11 from Jonathan Druart --- This subroutine is based on the order of the input in the html... It is really dangerous and should be rewrite. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:46:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:46:46 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #41 from Mirko Tietgen --- Rebased. I will look into this soon, probably make a few changes and set it back to needs signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:48:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:48:01 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8897 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:48:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:48:01 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15303 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:48:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:48:09 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15540 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:48:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:48:09 +0000 Subject: [Koha-bugs] [Bug 15540] Debian package option to set up an .onion address (Tor hidden service) for the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15540 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8897 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:51:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:51:33 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #7 from Jonathan Druart --- http://lists.koha-community.org/pipermail/koha-devel/2015-June/041551.html http://wiki.koha-community.org/wiki/Terminology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:53:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:53:41 +0000 Subject: [Koha-bugs] [Bug 15540] Debian package option to set up an .onion address (Tor hidden service) for the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15540 --- Comment #1 from Mirko Tietgen --- Created attachment 46644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46644&action=edit Bug 15540 - Debian package option to set up an .onion address (Tor hidden service) for the OPAC Add --tor to koha-create: automatically set up a .onion URL for the OPAC. Install Tor from official repository if required. Test plan: 0) Requirements - Apply patch - Build Debian package - Test server needs to be reachable from the internet - Download Tor Browser to your local machine (not the server) https://www.torproject.org/download/download-easy.html.en (Running Tor Browser and Koha with Tor on the same machine does not seem to work) 1) First Koha instance using Tor, refuse Tor installation - Test without the package 'tor' installed! - koha-create --create-db --tor You should be asked if you want to install Tor - Refuse Expected result: - You are told to either accept to install Tor or not use the --tor option - Installation process stops cleanly (no remaining user account etc.) 2) First Koha instance using Tor, accept Tor installation - Test without the package 'tor' installed! - koha-create --create-db --tor You should be asked if you want to install Tor - Accept - Wait for the installation to finish - Open your regular OPAC URL You should see the OPAC maintenance website - Open (in Tor Browser) the .onion address displayed at the end of the installation You should see the OPAC maintenance website. It can take a minute until this works Expected results: - Tor repository is added to /etc/apt/sources.list.d/tor.list - Package 'tor' (and keyring + dependencies) is installed - Koha instance is created as usual - Tor config is added to /etc/tor/torrc. It includes a block that looks like # begin instance koha- HiddenServiceDir /var/lib/tor/koha//hidden_service HiddenServicePort 80 127.0.0.1:80 # end instance koha- - .onion address from /var/lib/tor/koha//hidden_service/hostname is added as ServerAlias to /etc/apache2/sites-availabled/.conf - You can reach the OPAC from the regular address and via .onion (in Tor Browser) 3) Additional instances using Tor / Tor already installed - koha-create --create-db --tor You should not be asked if you want to install Tor again. - Wait for the installation to finish - Open your regular OPAC URL of You should see the OPAC maintenance website - Open Tor Browser at the .onion address displayed at the end of the second installation You should see the OPAC maintenance website It can take a minute until this works - Copy the .onion address, you will need it in step 5 and 7! Expected results: - Second Tor config is added to /etc/tor/torrc - You can reach the second OPAC from the regular address and via .onion (Tor Browser) 4) Remove an instance - Remove your first instance with koha-remove Removal process should work as expected - Check /etc/tor/torrc The block for your first instance should be gone - Check /var/lib/tor/koha/instance1/ The hidden_service folder and key should still be there. This way you can re-use an .onion address after reinstallation. 5) Re-create an instance (old config) - koha-create --create-db --tor #use the same name as for step 2! You should be asked if you want to re-use the existing .onion address or delete it - Choose to re-use the old config - Wait for installation to finish - Open the OPAC with the regular URL and the (old) .onion address (in Tor Browser) Both should work. It can take a minute for the .onion to show up - Verify that the .onion is the same as the one from step 3 6) Remove the instance again - Follow step 4 7) Re-create an instance (new config) - koha-create --create-db --tor #use the same name as for step 1! You should be asked if you want to re-use the existing key and .onion address or delete it - Choose to delete the folder and get a new .onion - Wait for installation to finish - Open the OPAC with the regular URL and the (new) .onion address (in Tor Browser) Both should work. It can take a minute for the .onion to show up - Verify that the .onion is not the same as in step 3 and 5 Possible bonus tests: - Using an operating system that does not have a Tor package available in the official repository should be detected. Testing this would require such an OS for testing. Recent Debian and Ubuntu seems to be covered. - A manual Tor installation before Koha is installed should be detected and work, a prompt will allow to either overwrite the old config or stop the installation - If the Tor repository is already present in /etc/apt/sources.list*, it is not added again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:55:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:55:27 +0000 Subject: [Koha-bugs] [Bug 15540] Debian package option to set up an .onion address (Tor hidden service) for the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15540 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:56:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:56:38 +0000 Subject: [Koha-bugs] [Bug 15540] Debian package option to set up an .onion address (Tor hidden service) for the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15540 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:56:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:56:56 +0000 Subject: [Koha-bugs] [Bug 15540] Debian package option to set up an .onion address (Tor hidden service) for the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15540 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15303 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 09:56:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 08:56:56 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15540 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 10:08:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 09:08:54 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #127 from Martin Renvoize --- First I've seen this bug, I like the feature as a whole.. >From a QA perspective I think I agree with Katrin and Jonathan. As much as I'm not as totally against splitting up some of the code into smaller more manageable files I think having a standard approach to coding this stuff is important for developers to adopts and adhere to, and I feel there isn't sufficient reasoning here to split the script into multiple smaller scripts. A clearly written $op eq '' set is pretty darn clear and it makes the relation between tt -> pl and pm clearer too. I'd prefer the single script approach here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 10:38:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 09:38:55 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #8 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #7) > http://lists.koha-community.org/pipermail/koha-devel/2015-June/041551.html > http://wiki.koha-community.org/wiki/Terminology Agreed seems to be a strong word, if I am searching back. It was only discussed on the second part of a dev meeting on June 24 with just three or four attending. http://irc.koha-community.org/koha/2015-06-24#i_1694243 This means that the list on the wiki does not have community consensus yet. We cannot definitely say here that Patron e.g. is the new standard as decided by the community (on a regular IRC meeting). Apart from that, I am all for consistency but not for refactoring code just to reword. It will most probably generate new errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 10:46:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 09:46:43 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46626|0 |1 is obsolete| | --- Comment #9 from Marc V?ron --- Created attachment 46645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46645&action=edit Bug 14763: Calculate and display patron age To test: 1) Go to patron Details page (ie http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51) 2) Confirm that '(x years)' is showing next to the Date of Birth and is correct according to DOB (ie if DOB: 30/11/1996, Age: 19 years) 3) Edit date of birth to be a month later (ie from 30 November to 30 December) so that, as of the date you are testing, the patron has not had their birthday yet 4) Confirm that age changes to be one year younger 5) Edit date of birth to be a different year 6) Confirm that age changes accordingly Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 10:47:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 09:47:08 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 10:50:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 09:50:22 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #9 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #8) > (In reply to Jonathan Druart from comment #7) > > http://lists.koha-community.org/pipermail/koha-devel/2015-June/041551.html > > http://wiki.koha-community.org/wiki/Terminology > > Agreed seems to be a strong word, if I am searching back. > It was only discussed on the second part of a dev meeting on June 24 with > just three or four attending. > http://irc.koha-community.org/koha/2015-06-24#i_1694243 > > This means that the list on the wiki does not have community consensus yet. > We cannot definitely say here that Patron e.g. is the new standard as > decided by the community (on a regular IRC meeting). > > Apart from that, I am all for consistency but not for refactoring code just > to reword. It will most probably generate new errors. It's not "only to reword", it's to keep consistency. We have now 2 packages Koha::Borrowers and Koha::Patrons, which represent the same thing. To make things clear, it's important to have only 1 word to represent the same entity. A new dev will know where (s)he should add new code patron-related. I am pretty sure that the use of the "patron" term has been voted years ago for the interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:29:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:29:07 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5723|0 |1 is obsolete| | --- Comment #10 from Alex Arnaud --- Created attachment 46646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46646&action=edit Bug #6979 I removed several lines of code in the checkpw_ldap subroutine where LDAP authentication takes place, in the "else" part of the conditional that checks for the auth_by_bind config parameter. I added several lines to check whether the user can log in to LDAP using their DN and the password supplied in the login form. If they are able to bind, login contiues as normal and the LDAP attributes can be harvested as normal if the update options are turned on. The routine that was in place was failing because it was trying to check against a non-existent LDAP entry attribute called 'userpassword'. Instead of checking against a 'userpassword' attribute, the routine really should be checking to make sure the user can actually bind to LDAP. That's what I set up, and it is a safer way to test authentication against LDAP. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:37:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:37:52 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Barry Cannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bc at interleaf.ie --- Comment #10 from Barry Cannon --- If a patron has no date of birth set the display is "Age: 2016 years", which doesn't look right. Maybe set a string of "unset" or "no DOB" if there isn't a date of birth on the patron record? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:48:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:48:14 +0000 Subject: [Koha-bugs] [Bug 15540] Debian package option to set up an .onion address (Tor hidden service) for the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15540 --- Comment #2 from Mirko Tietgen --- This patch is about automatic setup. Needs a follow-up to deal with OPACbaseURL in some way (links should go to .onion for people coming via .onion) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:48:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:48:20 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart --- That's exactly what I was writing(In reply to Barry Cannon from comment #10) > If a patron has no date of birth set the display is "Age: 2016 years", > which doesn't look right. Maybe set a string of "unset" or "no DOB" if there > isn't a date of birth on the patron record? Are you sure? Nothing is displayed for me if there is no date of birth set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:48:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:48:27 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:53:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:53:23 +0000 Subject: [Koha-bugs] [Bug 5334] add explicit foreign key constraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13535 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13535 [Bug 13535] Table alert is missing FK and not deleted with the patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:53:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:53:23 +0000 Subject: [Koha-bugs] [Bug 13535] Table alert is missing FK and not deleted with the patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13535 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Blocks| |5334 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:53:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:53:28 +0000 Subject: [Koha-bugs] [Bug 13533] Table suggestions is missing FK constraints / borrowernumbers are kept on deletion of patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:53:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:53:28 +0000 Subject: [Koha-bugs] [Bug 5334] add explicit foreign key constraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13533 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13533 [Bug 13533] Table suggestions is missing FK constraints / borrowernumbers are kept on deletion of patron -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:53:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:53:32 +0000 Subject: [Koha-bugs] [Bug 5334] add explicit foreign key constraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13515 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 [Bug 13515] Table messages is missing FK constraints and is never cleaned up -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:53:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:53:32 +0000 Subject: [Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Blocks| |5334 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:53:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:53:38 +0000 Subject: [Koha-bugs] [Bug 5334] add explicit foreign key constraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13667 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 [Bug 13667] Provide script to regularly clean deletedpatrons table -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:53:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:53:38 +0000 Subject: [Koha-bugs] [Bug 13667] Provide script to regularly clean deletedpatrons table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Blocks| |5334 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:53:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:53:50 +0000 Subject: [Koha-bugs] [Bug 13667] Provide script to regularly clean deletedpatrons table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|5334 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:53:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:53:50 +0000 Subject: [Koha-bugs] [Bug 5334] add explicit foreign key constraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13667 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 [Bug 13667] Provide script to regularly clean deletedpatrons table -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:54:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:54:01 +0000 Subject: [Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Blocks| |5334 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:54:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:54:01 +0000 Subject: [Koha-bugs] [Bug 5334] add explicit foreign key constraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13518 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 11:55:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 10:55:00 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 12:01:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 11:01:16 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart --- Marc, why do you replace div with li? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 12:01:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 11:01:39 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 --- Comment #12 from Barry Cannon --- Strange, I can't recreate that problem now. I had removed this branch (and I observed the problem there) and re-based and applied it again. Sure enough, there is no problem now. Sorry! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 12:07:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 11:07:09 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 --- Comment #3 from Jonathan Druart --- Comment on attachment 46638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46638 [SIGNED-OFF]Bug 15573: String and translatability fix to Patron Card Creator Review of attachment 46638: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15573&attachment=46638) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt @@ +179,4 @@ > > [% IF ( duplicate_message ) %] >
    > + Duplicates removed from batch number [% batch_id %]: [% duplicate_count %] patron(s) To avoid the string to be split, maybe could we put the entire string in the same tag? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 12:07:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 11:07:31 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 12:24:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 11:24:38 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Kyle, where is this enable/disable value used? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 12:35:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 11:35:15 +0000 Subject: [Koha-bugs] [Bug 15103] Import Borrowers Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103 --- Comment #7 from Jonathan Druart --- Comment on attachment 46625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46625 Bug 15103: Import Borrowers Performance Improvement Review of attachment 46625: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15103&attachment=46625) ----------------------------------------------------------------- ::: C4/Members.pm @@ +736,5 @@ > $data{'dateenrolled'} = output_pref( { dt => dt_from_string, dateonly => 1, dateformat => 'iso' } ); > } > > + # Check the member category privacy level > + my $patron_privacy = GetCategoryPrivacy( $data{'categorycode'} ); You are moving backward, we are trying to use DBIx::Class everywhere. The generation of SQL queries should not be done anymore. Moreover bug 15407 is going to remove the patron categories code from C4::Members. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 12:35:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 11:35:22 +0000 Subject: [Koha-bugs] [Bug 9754] koha-remove optionally includes var/lib and var/spool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Summary|koha-remove does not remove |koha-remove optionally |the stuff in /var/lib/koha/ |includes var/lib and | |var/spool -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 12:35:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 11:35:25 +0000 Subject: [Koha-bugs] [Bug 15103] Import Borrowers Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 12:36:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 11:36:50 +0000 Subject: [Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 12:43:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 11:43:28 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 12:43:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 11:43:31 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46645|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 46647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46647&action=edit Bug 14763: Calculate and display patron age To test: 1) Go to patron Details page (ie http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51) 2) Confirm that '(x years)' is showing next to the Date of Birth and is correct according to DOB (ie if DOB: 30/11/1996, Age: 19 years) 3) Edit date of birth to be a month later (ie from 30 November to 30 December) so that, as of the date you are testing, the patron has not had their birthday yet 4) Confirm that age changes to be one year younger 5) Edit date of birth to be a different year 6) Confirm that age changes accordingly Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 12:50:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 11:50:33 +0000 Subject: [Koha-bugs] [Bug 9754] koha-remove optionally includes var/lib and var/spool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 12:50:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 11:50:36 +0000 Subject: [Koha-bugs] [Bug 9754] koha-remove optionally includes var/lib and var/spool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 --- Comment #6 from Marcel de Rooy --- Created attachment 46648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46648&action=edit Bug 9754: koha-remove optionally includes var/lib and var/spool Currently, the files in the folder /var/lib/koha/[instance] and also in /var/spool/koha/[instance] are not removed. This patch adds the option -p|--purge-all to include those two directories when removing files. Note: There was a small bug in the for loop. On the -k line the extra shift statement is one too much. NOTE: Verify that you use the adjusted koha-remove in the test plan and not accidentally an older version of this script. Test plan: [1] Create an instance test. [2] Run koha-remove and verify that /var/lib/koha/test still exists. [3] Create an instance test2. [4] Run koha-remove -k -p and verify that the sql database still exists but the two instance folders in var/lib/koha and var/spool/koha are gone. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 12:52:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 11:52:14 +0000 Subject: [Koha-bugs] [Bug 9754] koha-remove optionally includes var/lib and var/spool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 13:26:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 12:26:43 +0000 Subject: [Koha-bugs] [Bug 15578] New: Authority tests skip and hide a bug Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Bug ID: 15578 Summary: Authority tests skip and hide a bug Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 13:27:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 12:27:14 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15578 --- Comment #21 from Jonathan Druart --- (In reply to Jonathan Druart from comment #20) > This patch set has introduced a big issue on Koha::Authority (now > Koha::Metadata::Authority). > The authid method does not return the authid anymore... > The tests in t/db_dependent/Koha_Authority.t are bad: they skipped if the > authid does not exist. Will be fixed by bug 15578. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 [Bug 15578] Authority tests skip and hide a bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 13:27:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 12:27:14 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14639 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 [Bug 14639] Extend Koha::MetadataRecord to handle serialization format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 13:29:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 12:29:38 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 13:29:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 12:29:43 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #2 from Jonathan Druart --- Created attachment 46650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46650&action=edit Bug 15578: Make sure all params will be taken into account when instantiating The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. Test plan: Apply the first patch, launch tests => Fail Apply the second patch, launch tests => \o/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 13:29:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 12:29:41 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #1 from Jonathan Druart --- Created attachment 46649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46649&action=edit Bug 15578: Insert authority records before processing tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 13:32:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 12:32:13 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46343|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 46651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46651&action=edit Bug 15358: Attempt to fix authorities merge This is a quick fix, and I'm quite sure there are other bugs hiding... but I managed to display both authority in tabs and merge them. The result preview requires at least one click on checkboxes to show up, I haven't looked at this issue yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 13:32:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 12:32:17 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46393|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 46652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46652&action=edit Bug 15358: Build result preview after page load -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 13:32:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 12:32:21 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46531|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 46653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46653&action=edit Bug 15358: Authorities merge - submit only result record This patch removes parts of form that should not be submitted just before submit. The same is done on biblio merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 13:33:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 12:33:19 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15578 --- Comment #26 from Jonathan Druart --- Trying to make this moving forward, I have moved some code to bug 15578 (with tests). Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 [Bug 15578] Authority tests skip and hide a bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 13:33:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 12:33:19 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15358 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 [Bug 15358] merge.pl does not populate values to merge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 13:54:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 12:54:25 +0000 Subject: [Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart --- Please provide a regression test for this change and provide use case. Why do you want to look at this value when the reserve has been removed (just a curious question :))? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 13:55:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 12:55:00 +0000 Subject: [Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |koha at univ-lyon3.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 14:32:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 13:32:39 +0000 Subject: [Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Hi Jonathan, I think it's for statistics: filled vs. cancelled holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 14:36:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 13:36:37 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #65 from Jonathan Druart --- Kyle, There is a small conflict to fix. Do you mind if we mark this patch dependent on bug 15391? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 14:59:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 13:59:51 +0000 Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 15:16:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 14:16:36 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #31 from Jonathan Druart --- QA comments: 1/ The correct mimetype for json is application/json (https://www.ietf.org/rfc/rfc4627.txt). Maybe it would be easier to use C4::Output::output_with_http_headers 2/ +if ( $auth_status ne "ok" ) { + exit 0; +} It might make more sense to return a 403. 3/ I am a bit worried to add different ways to suspend/resume hold, the others (in C4::Reserves) are mainly used and the behaviors could differ. Does the plan is to adapt the existing code to use these new methods? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 15:18:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 14:18:02 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 15:25:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 14:25:18 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46646|0 |1 is obsolete| | --- Comment #11 from Alex Arnaud --- Created attachment 46654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46654&action=edit Bug #6979 I removed several lines of code in the checkpw_ldap subroutine where LDAP authentication takes place, in the "else" part of the conditional that checks for the auth_by_bind config parameter. I added several lines to check whether the user can log in to LDAP using their DN and the password supplied in the login form. If they are able to bind, login contiues as normal and the LDAP attributes can be harvested as normal if the update options are turned on. The routine that was in place was failing because it was trying to check against a non-existent LDAP entry attribute called 'userpassword'. Instead of checking against a 'userpassword' attribute, the routine really should be checking to make sure the user can actually bind to LDAP. That's what I set up, and it is a safer way to test authentication against LDAP. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 15:29:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 14:29:55 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 --- Comment #13 from Marc V?ron --- (In reply to Jonathan Druart from comment #12) > Marc, why do you replace div with li? Because it looks nicer if there are multiple messages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 16:19:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 15:19:48 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #128 from Brendan Gallagher --- (In reply to Martin Renvoize from comment #127) > First I've seen this bug, I like the feature as a whole.. > > From a QA perspective I think I agree with Katrin and Jonathan. As much as > I'm not as totally against splitting up some of the code into smaller more > manageable files I think having a standard approach to coding this stuff is > important for developers to adopts and adhere to, and I feel there isn't > sufficient reasoning here to split the script into multiple smaller scripts. > A clearly written $op eq '' set is pretty darn clear and it makes the > relation between tt -> pl and pm clearer too. > > I'd prefer the single script approach here. After doing some searching through the code, I don't see what Kyle is proposing, as a new model (there are some examples where this is the case). Also, stated above the individual .pl files don't have an association with the tt. Since this isn't a new model, should we reject it based on that? I just am not crazy about seeing a developer spend time on a development (that has followed other models), and have to rewrite the code. Also to be clear, I see validity in both approaches (not one over the other). My worry is just the amount of time it would take to consolidate something that isn't a "new" way of development. Perhaps that time spent could be used towards other areas of Koha? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 16:20:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 15:20:55 +0000 Subject: [Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Nicole C. Engard --- Applying: Bug 15434: Search criteria definition table Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc Failed to merge in the changes. Patch failed at 0001 Bug 15434: Search criteria definition table When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15434-Search-criteria-definition-table-QMpnoE.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 16:31:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 15:31:56 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46291|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard --- Created attachment 46655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46655&action=edit bug_6624: OpenLibrarySearch syspref for OPAC If set to Yes, OPAC search results and details will include buton from Open Library Raed API. In addition, Number of titles held in Open Library and the results link will be reported on the search results screen. Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 16:31:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 15:31:54 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 16:32:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 15:32:03 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46292|0 |1 is obsolete| | --- Comment #5 from Nicole C. Engard --- Created attachment 46656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46656&action=edit bug_6624: Added Open Library Search and Read API to openlibrary.js Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 16:32:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 15:32:07 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46293|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard --- Created attachment 46657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46657&action=edit bug_6624: Added Open Library Search and Read API calls to opac-results.tt and opac-detail.tt Conditional to OpenLibrarySearch syspref Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 16:32:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 15:32:48 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 --- Comment #7 from Nicole C. Engard --- Works as expected! I would say we might want to add a note down the road or some clue that the results will open in a new window unlike Overdrive - but that's not reason to not sign off on this. Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 16:34:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 15:34:34 +0000 Subject: [Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 17:18:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 16:18:53 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #30 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 17:22:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 16:22:23 +0000 Subject: [Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46613|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 46658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46658&action=edit Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen. Test plan: Enable OnSiteCheckouts and OnSiteCheckoutsForce Debar a patron and go on the circulation page. Without this patch, the automatic renewal checkbox is displayed. With this patch applied, it's not. Patch works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 17:23:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 16:23:03 +0000 Subject: [Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 17:38:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 16:38:05 +0000 Subject: [Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 --- Comment #4 from Marc V?ron --- Question: When renewals are not possible, should the form field "Renewal due date: ..." be removed as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 17:38:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 16:38:17 +0000 Subject: [Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 17:45:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 16:45:42 +0000 Subject: [Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 17:49:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 16:49:39 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 --- Comment #12 from Alex Arnaud --- Created attachment 46659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46659&action=edit Bug 6979 - Update tests -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 18:01:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 17:01:14 +0000 Subject: [Koha-bugs] [Bug 15570] circ/renew.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 18:01:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 17:01:16 +0000 Subject: [Koha-bugs] [Bug 15570] circ/renew.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46614|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 46660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46660&action=edit Bug 15570: (follow-up) Bug 11944 Remove all utf8 filter from templates Test plan: use circ/renew.pl to renew an issue. Without this patch, you will get an error. Note: The error exists for 1 year now and nobody complained?? Does someone still use this script? Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 18:02:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 17:02:23 +0000 Subject: [Koha-bugs] [Bug 15469] Authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Attachment #46344|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 18:02:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 17:02:38 +0000 Subject: [Koha-bugs] [Bug 15469] Authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46383|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 18:08:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 17:08:40 +0000 Subject: [Koha-bugs] [Bug 15469] Authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 18:13:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 17:13:38 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #12 from Brendan Gallagher --- So does this still pass QA? Or this is a recommendation that we should rewrite in the future? At this point in the release I am ok - waiting for a rewrite because we still have a couple of months. (In reply to Jonathan Druart from comment #11) > This subroutine is based on the order of the input in the html... It is > really dangerous and should be rewrite. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 18:14:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 17:14:00 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46593|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 46661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46661&action=edit Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. This patch also replaces a call to the removed method C4::Branches::GetBranchesCoutn with a call to Koha::Libraries->search-count -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 18:14:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 17:14:50 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46661|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 46662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46662&action=edit Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. This patch also replaces a call to the removed method C4::Branches::GetBranchesCoutn with a call to Koha::Libraries->search-count -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 18:21:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 17:21:00 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Attachment #46593|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 18:21:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 17:21:28 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46662|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 18:25:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 17:25:24 +0000 Subject: [Koha-bugs] [Bug 15394] Confirm messages on OPAC lists interface strangely worded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15394 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #8 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 18:30:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 17:30:11 +0000 Subject: [Koha-bugs] [Bug 15579] New: records_batchmod permission doesn't allow access to batch modification Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 Bug ID: 15579 Summary: records_batchmod permission doesn't allow access to batch modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 46663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46663&action=edit permissions I have a staff member with permission to use the batch record modification tool but they can't use it. I have tested on 3.20 and on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 18:32:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 17:32:53 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46593|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 46664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46664&action=edit Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 18:33:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 17:33:24 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 --- Comment #5 from Nick Clemens --- Created attachment 46665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46665&action=edit Bug 15568 (Follow up) Replace call to C4::Branches::GetBranchesCount with Koha::Libraries->search->count -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 18:41:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 17:41:52 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #27 from Nick Clemens --- A test plan would be appreciated (even if as simple as 'Merge two authorities') I get this error when merging authorities: Software error: Subfields are only for data fields (generally, just tags >= 010) at /home/vagrant/kohaclone/C4/AuthoritiesMarc.pm line 1488. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 19:03:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 18:03:13 +0000 Subject: [Koha-bugs] [Bug 13177] Add help pages for Rotating collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #5 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 19:03:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 18:03:26 +0000 Subject: [Koha-bugs] [Bug 13177] Add help pages for Rotating collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45904|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 19:03:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 18:03:30 +0000 Subject: [Koha-bugs] [Bug 13177] Add help pages for Rotating collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46562|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 19:03:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 18:03:38 +0000 Subject: [Koha-bugs] [Bug 13177] Add help pages for Rotating collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 --- Comment #6 from sandboxes at biblibre.com --- Created attachment 46666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46666&action=edit Bug 13177: Help page for Rotating Collections To test: Go to Tools -> Rotating Collections and click Help in the top-right. Confirm the Help page shows and gives correct accurate instructions with no typos or grammatical errors. Help displays as expected. Signed-off-by: Marc V?ron Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 19:03:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 18:03:40 +0000 Subject: [Koha-bugs] [Bug 13177] Add help pages for Rotating collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 46667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46667&action=edit Bug 13177: Accidental copy/paste error fix Confirm it now says Rotating Collections instead of Patron Import in the last line, and the link is correct. Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 19:26:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 18:26:37 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #13 from Jonathan Druart --- (In reply to Brendan Gallagher from comment #12) > So does this still pass QA? Or this is a recommendation that we should > rewrite in the future? At this point in the release I am ok - waiting for a > rewrite because we still have a couple of months. Yes, it needs a rewrite. It's how the subroutine has been for years, so no rush :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 19:59:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 18:59:05 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #14 from Fr?d?ric Demians --- What is the workflow? This patch is required in 3.22/3.20 branches. Can it be pushed directly without being firstly pushed in master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 20:23:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 19:23:56 +0000 Subject: [Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983 --- Comment #7 from Marc V?ron --- Created attachment 46668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46668&action=edit Bug 1983: Checkout: Hold repquest when checking out an item already on loan or reserved This patch allows to put a hold on an item that is already checked out or reserved. To test: - Check out an item A - Put a hold on an item B - Verify that the staff user has permission to put holds - Check out item A to a patron X - Try to checkout item A to a patron Y - Verify that you see underneath the buttons for Checkin/Checkout a link with following text: "Click here to place hold for [Patron X' name]" - Verify that the link is stylable (div class circ-scheckoutplacehold) - Verify that the link takes you to the page to place a hold on this biblio for patron Y - Do the same for item B and verify that it works for reserved items as well. - Repeat steps above for a patron who has restrictions, verify that the link does not appear - Log in with a staff member who has no permission to place holds - Repeat steps above for a patron without restrictions, verify that the link does not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 20:24:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 19:24:27 +0000 Subject: [Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45991|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 20:32:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 19:32:20 +0000 Subject: [Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #8 from Marc V?ron --- I refactored the patch (more / changed conditions to display link, give the link correct params). The patch will need a new sign-off. See changed test plan on this patch. Regarding link vs button: For more clarity, I decided for a link below the buttons with a text including the patron's name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 20:32:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 19:32:46 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #177 from Kyle M Hall --- (In reply to Katrin Fischer from comment #174) > After thinking this over for a bit I would be in favor of pushing it as it > is. This is a long needed development that probably predates most of the > work in the Koha namespace. Changing the namespace now would require more > testing and it might give us a lot of conflicts in other places. So it might > be easier to fix the namespace separately after this is pushed. If it doesn't get fixed now, it won't get fixed. This patch was submitted long after the creation of the Koha namespace. Changing the namespace is not that onerous a request. We can't allow code in that isn't fit just because we like the feature itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 20:32:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 19:32:56 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 20:42:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 19:42:52 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #178 from Blou --- Noooooo!!! Not the dreaded "In Discussion" !! I would have prefered Failed QA. Not sure what is left to discuss. Everyone already chimed in. But I respect the QA's right to fail it. At this point, since it would require "full retest", I will ask Charles to fix it and SQUASH everything. Considering the amount of support this feature has, I suppose a re-signoff wouldn't be long. *sigh* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 21:33:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 20:33:32 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #7 from Nicole C. Engard --- Where do we think this should go in the manual? We don't really get this nitty gritting in the searching section. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 21:55:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 20:55:31 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46639|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Comment on attachment 46639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46639 Bug 15577: 404 html code error in OPAC message with syspref OPACPatronDetails Sorry I didn't realize it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 21:58:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 20:58:33 +0000 Subject: [Koha-bugs] [Bug 15576] Link in OPAC redirects to the wrong page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15576 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 21:58:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 20:58:36 +0000 Subject: [Koha-bugs] [Bug 15576] Link in OPAC redirects to the wrong page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15576 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46632|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 46669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46669&action=edit [SIGNED-OFF]Bug 15576: Fix for incorrect link redirect To test: 1) Edit a user to have an uncertain address (gone no address) 2) Log in as that user on OPAC 3) Click 'online update form' link in the yellow message 4) Confirm you are taken to opac-memberentry.pl Signed-off-by: Hector Castro Works as described -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 22:01:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 21:01:15 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #179 from Chris Cormack --- *sigh* Oh well, can't be helped I guess. I will test the new patch as soon as it is up. Hopefully this new super strict QA standard will be across the board and I won't see people pushing patches they wrote skipping qa steps anymore. Switching back to assigned, while we wait for the new patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 22:02:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 21:02:51 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 22:02:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 21:02:55 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46633|0 |1 is obsolete| | --- Comment #6 from H?ctor Eduardo Castro Avalos --- Created attachment 46670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46670&action=edit [SIGNED-OFF]Bug 15577: Correcting link redirect To test: 1) Add a restriction to a user 2) Log in as that user in the OPAC 3) Click 'your account page' link in the yellow mesage 4) Confirm you are taken to opac-account.pl Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 22:04:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 21:04:12 +0000 Subject: [Koha-bugs] [Bug 15576] Link in OPAC redirects to the wrong page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15576 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15577 Patch complexity|--- |String patch Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 22:04:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 21:04:12 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15576 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 22:05:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 21:05:13 +0000 Subject: [Koha-bugs] [Bug 15576] Link in OPAC redirects to the wrong page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15576 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 22:05:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 21:05:44 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 23:01:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 22:01:27 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #14 from Heather Braum --- Thanks Jonathan and Jesse for working on this. I understand the privacy concerns of some of the ways this could be resolved. The issue really does need to be resolved. I am unable to use branch specific limits on several sets of authorised_values & patron categories until this is resolved (which is not ideal). We have patrons who use multiple branches and when their accounts are edited at another branch, we risk data being lost. Just my two cents on how important this bug is to get resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 23:01:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 22:01:52 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 14 23:01:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 22:01:55 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46638|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 46671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46671&action=edit Bug 15573: String and translatability fix to Patron Card Creator Fixing the split string To test: 1) Go to Tools -> Patron Card Creator -> Manage -> Card batches 2) Confirm the table heading reads 'Patron Count' 3) Edit a batch 4) Click Remove duplicates 5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 00:21:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 23:21:00 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #18 from Jesse Weaver --- (In reply to Jonathan Druart from comment #17) > (In reply to Jesse Weaver from comment #16) > > Created attachment 46352 [details] [review] [review] > > Bug 14658: (followup) fix issue with list context on DBIC call > > > > While working on bug 14659, it was discovered that the call to > > ...->guarantor in list context will cause the hash to be misaligned > > (thus causing hidden => ... to not actually be sent to the template). > > Could you move that to another bug report, to make it backportable to stable > branches? I could, but this error doesn't really cause any issues unless you add something else to that $template->param call, which is only likely from an another enhancement. Not much benefit from backporting, in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 00:23:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jan 2016 23:23:53 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #1 from Aleisha Amohia --- I suppose we can either take the tags out completely or put the entire string within the tags. I can write a patch for both options -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 01:22:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 00:22:21 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 01:22:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 00:22:24 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 --- Comment #2 from Aleisha Amohia --- Created attachment 46672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46672&action=edit Bug 15274: Removing tags from circulation.tt which split the sentence I have only removed the tags from strings where the tags split the sentence. To test: 1) Go to a borrower's check out page (circulation.pl) 2) Check out a book and specify the due date to a past date (ie, to 2015 etc) 3) Confirm the "ITEMS OVERDUE" in the error message is no longer styled by the span tags. 4) Create a manual invoice of $100 for the borrower 5) Confirm the "BLOCKED" and "OVER THE LIMIT" is no longer styled by span tags. 6) Check the patch and the circulation.tt file and confirm that I haven't missed any tags that split the string and make translation difficult. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 01:29:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 00:29:04 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 --- Comment #3 from Aleisha Amohia --- Created attachment 46673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46673&action=edit Bug 15274: Putting tags around entire string where the originally split the sentence I have only done this where the tags split the sentence. To test: 1) Go to a borrower's check out page (circulation.pl) 2) Check out a book and specify the due date to a past date (ie, to 2015 etc) 3) Confirm the entire sentence in the error message is styled by the span tags. 4) Create a manual invoice of $100 for the borrower 5) Confirm the entire sentence in the error message styled by span tags. 6) Check the patch and the circulation.tt file and confirm that I haven't missed any tags that split the string and make translation difficult. I personally do not prefer this patch because the red bold sentences don't look very good and aren't highly readable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 01:30:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 00:30:17 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46673|Bug 15274: Putting |[Alternative Patch] Bug description|tags around entire string |15274: Putting tags |where the originally split |around entire string where |the sentence |the originally split the | |sentence Attachment #46673|Bug-15274-Putting-span-tags |[ALTERNATIVE-PATCH]Bug-1527 filename|-around-entire-string-w.pat |4-Putting-span-tags-around- |ch |entire-string-w.patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 01:39:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 00:39:39 +0000 Subject: [Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46103|0 |1 is obsolete| | --- Comment #10 from Srdjan Jankovic --- Created attachment 46674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46674&action=edit Bug 15434: Search criteria definition table Collected search criteria and limit labels in opac-bottom.inc, so it can be used for both making search criteria selects and displaying back selections on the result screen. *-opac-bootstrap.po translation files need to be changed: - references to opac-advanced-search.tt need to be updated to opac-bottom.inc - messages and translations need  -s removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 01:54:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 00:54:48 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 01:54:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 00:54:51 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46649|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 46675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46675&action=edit [SIGNED-OFF]Bug 15578: Insert authority records before processing tests Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 01:55:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 00:55:20 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46650|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 46676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46676&action=edit [SIGNED-OFF]Bug 15578: Make sure all params will be taken into account when instantiating The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. Test plan: Apply the first patch, launch tests => Fail Apply the second patch, launch tests => \o/ Signed-off-by: Hector Castro Test pass successfuly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 02:22:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 01:22:46 +0000 Subject: [Koha-bugs] [Bug 15574] Better wording for error message when adding tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15574 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 02:22:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 01:22:49 +0000 Subject: [Koha-bugs] [Bug 15574] Better wording for error message when adding tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15574 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46629|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 46677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46677&action=edit [SIGNED-OFF]Bug 15574: Better wording for error message when adding a duplicate tag To test: 1) Apply patch 2) Go to a record (ie opac-detail.pl) and add tags that already exist with that record 3) Confirm new error message Signed-off-by: Hector Castro Rewording Ok for common patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 02:30:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 01:30:39 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 02:30:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 01:30:42 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46671|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 46678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46678&action=edit [SIGNED-OFF]Bug 15573: String and translatability fix to Patron Card Creator Fixing the split string To test: 1) Go to Tools -> Patron Card Creator -> Manage -> Card batches 2) Confirm the table heading reads 'Patron Count' 3) Edit a batch 4) Click Remove duplicates 5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)' Signed-off-by: Hector Castro Works as described. Rewording Ok for translatability purpose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 02:31:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 01:31:16 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 03:27:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 02:27:07 +0000 Subject: [Koha-bugs] [Bug 14556] Improve translatability of strings including links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14556 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #1 from Aleisha Amohia --- Is this still valid? It looks like this has been fixed in opac-auth-MARCdetail.tt and opac-auth-detail.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 04:22:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 03:22:34 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 04:22:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 03:22:37 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 --- Comment #6 from Aleisha Amohia --- Created attachment 46679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46679&action=edit ^# Attachment to Bug 15568 - Circ rules are not displayed anymore [SIGNED-OFF] Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. Signed-off-by: Nick Clemens Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 04:23:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 03:23:51 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Attachment #46679|1 |0 is patch| | Attachment #46679|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 04:24:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 03:24:24 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 --- Comment #7 from Aleisha Amohia --- Sorry, I'm not really sure what I just did, but I was meant to be signing off on both patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 04:54:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 03:54:12 +0000 Subject: [Koha-bugs] [Bug 14668] Show serial enumeration in the checkin page and the patron's opac checkout summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Aleisha Amohia --- Applying: Bug 14668 - Show serial enumeration in the checkin page and the patron's opac checkout summary /home/vagrant/kohaclone/.git/rebase-apply/patch:139: trailing whitespace. [% WaitingReserveLoo.title | html %] warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... :139: trailing whitespace. [% WaitingReserveLoo.title | html %] warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging svc/checkouts CONFLICT (content): Merge conflict in svc/checkouts Auto-merging opac/opac-user.pl CONFLICT (content): Merge conflict in opac/opac-user.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js Auto-merging circ/returns.pl CONFLICT (content): Merge conflict in circ/returns.pl Auto-merging circ/circulation.pl CONFLICT (content): Merge conflict in circ/circulation.pl Auto-merging C4/Reserves.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 06:11:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 05:11:01 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 --- Comment #4 from Marc V?ron --- Created attachment 46680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46680&action=edit Screenshots to compare patches I made some screenshots. For this Bug I would prefer the alternative patch (whole sentence in tags). Most important thing at the moment is to get rid of the sentence splitting because of the really weird translations. The whole part with blocking messages can then be streamlined in a separate bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 06:24:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 05:24:44 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 --- Comment #5 from Marc V?ron --- Created attachment 46681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46681&action=edit Bug 15274: Putting tags around entire string where the originally split the sentence I have only done this where the tags split the sentence. To test: 1) Go to a borrower's check out page (circulation.pl) 2) Check out a book and specify the due date to a past date (ie, to 2015 etc) 3) Confirm the entire sentence in the error message is styled by the span tags. 4) Create a manual invoice of $100 for the borrower 5) Confirm the entire sentence in the error message styled by span tags. 6) Check the patch and the circulation.tt file and confirm that I haven't missed any tags that split the string and make translation difficult. I personally do not prefer this patch because the red bold sentences don't look very good and aren't highly readable. Signed off on this second patch, see screenshots in comment #4. (Forbidden tab char in line 779 removed) Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 06:26:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 05:26:17 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46673|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 06:29:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 05:29:45 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46672|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 46682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46682&action=edit Bug 15274: Removing tags from circulation.tt which split the sentence I have only removed the tags from strings where the tags split the sentence. To test: 1) Go to a borrower's check out page (circulation.pl) 2) Check out a book and specify the due date to a past date (ie, to 2015 etc) 3) Confirm the "ITEMS OVERDUE" in the error message is no longer styled by the span tags. 4) Create a manual invoice of $100 for the borrower 5) Confirm the "BLOCKED" and "OVER THE LIMIT" is no longer styled by span tags. 6) Check the patch and the circulation.tt file and confirm that I haven't missed any tags that split the string and make translation difficult. Sign-off on first patch (offending tab char in line 779 removed) Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 06:31:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 05:31:49 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Marc V?ron --- Hi Aleisha, I signed off on both patches, I propose that you decide and obsolete one of them. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 06:45:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 05:45:03 +0000 Subject: [Koha-bugs] [Bug 15580] New: Confirm button not visible Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15580 Bug ID: 15580 Summary: Confirm button not visible Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: library.ltce at ltjss.net QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl After I delete private list I receive a message -- "The list ABCD is not empty. It has 1 entry. Use the "Confirm" button below to confirm deletion." BUT no "confirm" button is visible. It was visible in 3.18 version. I use "Delete" button (in front of the list to be deleted) again to delete the list and list gets deleted. Please fix this. Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 07:12:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 06:12:35 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #11 from Marc V?ron --- Created attachment 46683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46683&action=edit Screenshots table 'All funds' With patch the table "All funds" looks weird. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 08:08:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 07:08:51 +0000 Subject: [Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This bug appears only in release notes| |3.20.7 version and is very | |visible (or invisible) and | |disturbing. It has been | |discussed several times on | |Koha mailing list: after a | |package upgrade to the 3.20 | |branch last version, the | |check-out screen doesn't | |display anymore the | |checkouts table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 08:10:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 07:10:25 +0000 Subject: [Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This bug appears only in |This bug appears only in release notes|3.20.7 version and is very |3.20.7 version and is very |visible (or invisible) and |visible (or invisible) and |disturbing. It has been |disturbing. It has been |discussed several times on |discussed several times on |Koha mailing list: after a |Koha mailing list: after a |package upgrade to the 3.20 |package upgrade to the 3.20 |branch last version, the |branch last version, the |check-out screen doesn't |check-out screen doesn't |display anymore the |display anymore the CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi Frederic, it looks like the text of the new release notes field might been cut off? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 08:11:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 07:11:30 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |On 3.20.05, if release notes| |AnonymousPatron is set to a | |nonexistent borrowernumber, | |the about.pl crashes with: | |DBIC result type isn't of | |the type Borrower at | |/home/koha/src/Koha/Objects | |.pm line 87. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 08:14:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 07:14:08 +0000 Subject: [Koha-bugs] [Bug 11602] Fix localcover display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adds a CSS class of release notes| |thumbnail to local covers. | |Don't show the 1px "No | |image found" image (since | |we'll usually try another | |image provider). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 08:15:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 07:15:36 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #180 from Marcel de Rooy --- (In reply to Chris Cormack from comment #179) > Hopefully this new super strict QA standard will be across the board and I > won't see people pushing patches they wrote skipping qa steps anymore. I do not favor a super strict QA standard. Common_sense++ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 08:17:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 07:17:36 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |If a record has more than release notes| |20 items, all the items | |over 20 will show as | |available on the search | |results even if they are | |not! This is a hard coded | |limit in the Search module. | |This number should is made | |configurable with the new | |system preference | |MaxSearchResultsItemsPerRec | |ordStatusCheck. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 08:20:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 07:20:18 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 --- Comment #8 from Aleisha Amohia --- (In reply to Marc V?ron from comment #7) > Hi Aleisha, I signed off on both patches, I propose that you decide and > obsolete one of them. :-) Happy to go with what you think is best! Will obselete the first patch :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 08:21:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 07:21:10 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46682|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 08:21:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 07:21:23 +0000 Subject: [Koha-bugs] [Bug 14363] OAI-PMH should handle records without marcxml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Text to go in the| |Sometimes, some biblioitems release notes| |records have empty marcxml. | |In this case, OAI harvester | |fails with a software | |error: Can't call method | |"as_xml" on an | |undefined value at | |/home/koha/src/opac/oai.pl | |line 516. Instead, now, | |record is skipped, and a | |message is sent to log | |file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 08:28:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 07:28:28 +0000 Subject: [Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This bug appears only in |This bug appears only in release notes|3.20.7 version and is very |3.20.7 version and is very |visible (or invisible) and |visible (or invisible) and |disturbing. It has been |disturbing. It has been |discussed several times on |discussed several times on |Koha mailing list: after a |Koha mailing list: after a |package upgrade to the 3.20 |package upgrade to the 3.20 |branch last version, the |branch last version, the |check-out screen doesn't |check-out screen doesn't |display anymore the |display anymore the | |checkouts table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 09:00:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 08:00:39 +0000 Subject: [Koha-bugs] [Bug 15367] Batch patron modification: Data loss with multiple repeatable patron attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 09:03:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 08:03:06 +0000 Subject: [Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 09:08:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 08:08:34 +0000 Subject: [Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 09:10:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 08:10:47 +0000 Subject: [Koha-bugs] [Bug 15394] Confirm messages on OPAC lists interface strangely worded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15394 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 09:17:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 08:17:25 +0000 Subject: [Koha-bugs] [Bug 15469] Authority header search is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15469 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #14 from Julian Maurice --- Does not concern stable versions, changing status to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 09:17:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 08:17:29 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #15 from Katrin Fischer --- Hi Frederic, I think the fix should go into master and stable releases and then we can rewrite on top of it in master - Jonathan, do you agree? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 09:20:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 08:20:49 +0000 Subject: [Koha-bugs] [Bug 15487] Encoding problem with item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15487 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 09:20:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 08:20:58 +0000 Subject: [Koha-bugs] [Bug 15477] Error handling on editing item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15477 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #13 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 09:23:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 08:23:06 +0000 Subject: [Koha-bugs] [Bug 15512] Minor regression caused by Bug 7369 - warn on deleting item not triggered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15512 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 09:56:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 08:56:55 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #181 from Chris Cormack --- (In reply to Marcel de Rooy from comment #180) > (In reply to Chris Cormack from comment #179) > > Hopefully this new super strict QA standard will be across the board and I > > won't see people pushing patches they wrote skipping qa steps anymore. > > I do not favor a super strict QA standard. Common_sense++ Neither do I, but if we are going to be super strict about this one, we need to at least be consistent. That was my point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 10:36:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 09:36:44 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 --- Comment #31 from Jonathan Druart --- Created attachment 46684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46684&action=edit Bug 15295: (follow-up) Koha::Libraries - Remove GetBranchesCount Fix conflict with bug 11625 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 10:40:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 09:40:38 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Arve S?reide changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arve.soreide at kul.oslo.kommu | |ne.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 10:46:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 09:46:27 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 --- Comment #8 from Jonathan Druart --- I have submitted a patch on bug 14295 to remove the GetBranchesCount occurrences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 10:49:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 09:49:56 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 10:49:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 09:49:59 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46664|0 |1 is obsolete| | Attachment #46665|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 46685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46685&action=edit Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 10:53:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 09:53:11 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14295 --- Comment #10 from Jonathan Druart --- Nick, I have moved the GetBranchesCount changes as a followup of bug 14295 (because there are 2 occurrences to fix). So I mark this fix as dependent on it and switch back to needs signoff. Sorry for the additional work. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14295 [Bug 14295] Add creation time, size and owner for uploaded files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 10:53:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 09:53:11 +0000 Subject: [Koha-bugs] [Bug 14295] Add creation time, size and owner for uploaded files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15568 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 [Bug 15568] Circ rules are not displayed anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:03:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:03:31 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #12 from Jonathan Druart --- Created attachment 46686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46686&action=edit Bug 15285: Fix conflict with the treetable plugin The tables using the treetable plugin don't display correctly (with JS error). The lazy way to fix it is to redefine the dom of the table and remove the button area (B). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:03:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:03:55 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 --- Comment #13 from Jonathan Druart --- (In reply to Marc V?ron from comment #11) > Created attachment 46683 [details] > Screenshots table 'All funds' > > With patch the table "All funds" looks weird. Thanks, good catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:08:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:08:09 +0000 Subject: [Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 --- Comment #5 from Jonathan Druart --- (In reply to Marc V?ron from comment #4) > Question: When renewals are not possible, should the form field "Renewal due > date: ..." be removed as well? At the bottom of the table, that's it (not auto renewal related)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:11:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:11:40 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #28 from Jonathan Druart --- (In reply to Nick Clemens from comment #27) > A test plan would be appreciated (even if as simple as 'Merge two > authorities') > > I get this error when merging authorities: > Software error: > > Subfields are only for data fields (generally, just tags >= 010) at > /home/vagrant/kohaclone/C4/AuthoritiesMarc.pm line 1488. I had a very quick look at the code and I'd say that it existed prior to bug 8064, could you test on a 3.20 release and confirm that the bug already existed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:19:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:19:18 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:19:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:19:20 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #2 from Marcel de Rooy --- Created attachment 46687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46687&action=edit Bug 15545: Database revision for HoldNoteReasons pref Adds a new preference. Test plan: Run the db revision. Check the pref in the interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:19:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:19:26 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #3 from Marcel de Rooy --- Created attachment 46688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46688&action=edit Bug 15545: Optionally require notes when placing a hold This report adds three cases where you could want to require a note when placing a hold. Each of these cases may be enabled separately via the system preference HoldNoteReasons. (The hold note itself is triggered by OpacHoldNotes.) These three cases are: [1] serial indication in the leader (called LEADER_SERIAL) [2] collection indication in the leader (LEADER_COLLECTION) [3] MARC 300$a contains an indication of multiple parts/volumes, as identified by a regular expression (MARC300A_PARTS). The new sub IsHoldNoteRequired in Reserves.pm handles these cases. And will be easily extensible. Also this patch removes some unused code in the reserves template for mandatory hold notes reasons. Test plan: [1] Enable OpacHoldNotes. Set HoldNoteReasons to LEADER_SERIAL. [2] In OPAC, place a hold on a serial record (with correct leader). Verify that the hold notes are required. [3] Set HoldNoteReasons to MARC300A_PARTS. Verify that the hold notes are no longer required for the record in the preceding step. (This actually depends on your 300$a..) Cancel the hold you placed. [4] Add "2 vols" to MARC 300$a in the same record. Try to place the hold again. The hold notes should be required again. [5] Place a multiple hold request with the same record and another one. Click Place Hold while more-options is collapsed (blank notes). Is the correct hold note made visible? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:19:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:19:31 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #4 from Marcel de Rooy --- Created attachment 46689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46689&action=edit Bug 15545: Unit test for IsHoldNoteRequired Adds unit test. Test plan: Run the test t/db../Reserves/IsHoldNoteRequired.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:31:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:31:42 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #16 from Jonathan Druart --- The patches are for master, 3.22.x, 3.20.x and 3.18.x It would be good to have it into the next stable releases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:36:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:36:32 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #129 from Jonathan Druart --- I think we need to talk together when a developer wants to introduce a new practice. On comment 79, I have suggested to have this discussion during the next (?) dev meeting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:37:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:37:59 +0000 Subject: [Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- I can't make it work on master. Commit 347d12c41f9ebe may have broken Koha::Logger on master. For me, the logger is never instantiated. After modifying Koha::Logger to bypass conf file checking, I get a result in the OPAC log file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:39:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:39:02 +0000 Subject: [Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This bug appears only in |This bug appears only in release notes|3.20.7 version and is very |3.20.7 version and is very |visible (or invisible) and |visible (or invisible) and |disturbing. It has been |disturbing. It has been |discussed several times on |discussed several times on |Koha mailing list: after a |Koha mailing list: after a |package upgrade to the 3.20 |package upgrade to the 3.20 |branch last version, the |branch last version, the |check-out screen doesn't |check-out screen doesn't |display anymore the |display anymore the --- Comment #6 from Fr?d?ric Demians --- > Hi Frederic, it looks like the text of the new release notes field might > been cut off? Yes. Chris is investigating... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:39:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:39:58 +0000 Subject: [Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 --- Comment #6 from Marc V?ron --- (In reply to Jonathan Druart from comment #5) > (In reply to Marc V?ron from comment #4) > > Question: When renewals are not possible, should the form field "Renewal due > > date: ..." be removed as well? > > At the bottom of the table, that's it (not auto renewal related)? Yes, at the bottom of the table. It was just a question - I think this should have it's own bug (if we decide to remove it). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:43:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:43:12 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #182 from Jonathan Druart --- Kyle, can we imagine to make an exception for this one, open a new bug report to move the new module to the Koha namespace and ask for the author to commit to submit a patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:46:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:46:17 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #183 from Jonathan Druart --- (In reply to Blou from comment #176) > Of course, we're now at 180 comments and counting, so there's a side of me > that would like to see that keep increasing and beat a record of some sort. > ;-) Don't worry about that, we won't reach it (there are 247 comments on bug 7167 and it as been abandoned, there is another one with more than 500 comments iirc). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:52:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:52:31 +0000 Subject: [Koha-bugs] [Bug 14295] Add creation time, size and owner for uploaded files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15568 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 [Bug 15568] Circ rules are not displayed anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:52:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:52:31 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14295 |15295 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14295 [Bug 14295] Add creation time, size and owner for uploaded files http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:52:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:52:31 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15568 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 [Bug 15568] Circ rules are not displayed anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 11:56:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 10:56:24 +0000 Subject: [Koha-bugs] [Bug 14834] Add range parameters to membership_expiry cronjob In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14834 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Marcel de Rooy --- Does not apply anymore. Rebasing this soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 12:09:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 11:09:02 +0000 Subject: [Koha-bugs] [Bug 11557] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15581 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 [Bug 15581] Add a circ rule to limit the auto renewals given a delay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 12:09:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 11:09:02 +0000 Subject: [Koha-bugs] [Bug 15581] New: Add a circ rule to limit the auto renewals given a delay Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Bug ID: 15581 Summary: Add a circ rule to limit the auto renewals given a delay Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Blocks: 11557 A new column issuingrules.no_auto_renewal_after will allow to restrict the auto renewals based on a delay. For instance, if the issue date is 10 days before today, and no_auto_renewal_after is set to 10, tomorrow the issue won't be auto renewed. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11557 [Bug 11557] Collector bug for Academy bootstrap3 upgrading work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 12:09:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 11:09:13 +0000 Subject: [Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 12:09:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 11:09:26 +0000 Subject: [Koha-bugs] [Bug 11557] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15582 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 12:09:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 11:09:26 +0000 Subject: [Koha-bugs] [Bug 15582] New: Ability to block auto renewals if the max outstanding balance is reached Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Bug ID: 15582 Summary: Ability to block auto renewals if the max outstanding balance is reached Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Blocks: 11557 If a patron owes more than the max outstanding balance (defined in the maxoutstanding syspref), the issue won't be auto renewed anymore (driven by a new syspref). Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11557 [Bug 11557] Collector bug for Academy bootstrap3 upgrading work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 12:09:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 11:09:55 +0000 Subject: [Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This bug appears only in |This bug appears only in release notes|3.20.7 version and is very |3.20.7 version and is very |visible (or invisible) and |visible (or invisible) and |disturbing. It has been |disturbing. It has been |discussed several times on |discussed several times on |Koha mailing list: after a |Koha mailing list: after a |package upgrade to the 3.20 |package upgrade to the 3.20 |branch last version, the |branch last version, the |check-out screen doesn't |check-out screen doesn't |display anymore the |display anymore the problem CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 12:10:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 11:10:57 +0000 Subject: [Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This bug appears only in |This bug appears only in release notes|3.20.7 version and is very |3.20.7 version and is very |visible (or invisible) and |visible (or invisible). It |disturbing. It has been |has been discussed several |discussed several times on |times on Koha mailing list: |Koha mailing list: after a |after a package upgrade to |package upgrade to the 3.20 |the 3.20 branch last |branch last version, the |version, the check-out |check-out screen doesn't |screen doesn't display |display anymore the |anymore the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 12:12:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 11:12:05 +0000 Subject: [Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This bug appears only in |This bug appears only in release notes|3.20.7 version and is very |3.20.7 version and is very |visible (or invisible). It |visible (or invisible) and |has been discussed several |disturbing. It has been |times on Koha mailing list: |discussed several times on |after a package upgrade to |Koha mailing list: after a |the 3.20 branch last |package upgrade to the 3.20 |version, the check-out |branch last version, the |screen doesn't display |check-out screen doesn't |anymore the problem. |display anymore the | |problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 12:12:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 11:12:56 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #130 from Kyle M Hall --- (In reply to Jonathan Druart from comment #129) > I think we need to talk together when a developer wants to introduce a new > practice. > On comment 79, I have suggested to have this discussion during the next (?) > dev meeting. Jonathan, again, this is *not* a new practice! As I wrote previously, the following scripts use this same methodology: modrequest.pl placerequest.pl modrequest_suspendall.pl add_message.pl deletemem.pl mod_debarment.pl setstatus.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 13:45:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 12:45:40 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15581 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 [Bug 15581] Add a circ rule to limit the auto renewals given a delay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 13:45:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 12:45:39 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #184 from Kyle M Hall --- (In reply to Jonathan Druart from comment #182) > Kyle, can we imagine to make an exception for this one, open a new bug > report to move the new module to the Koha namespace and ask for the author > to commit to submit a patch? Yes! I set this bug to in discussion while we were actually discussing the issue. I purposefully did not set it to failed qa. My fear is that if this is pushed as is, there is no impetus for the namespace to be fixed. All I'd like to see is a commitment from someone that the patches to move this to a better namespace *will be submitted*, preferably before the next major release if possible. So far I haven't seen anyone make that commitment. I should have written that more clearly than I had. Philippe, if you can vouch that Charles or someone will submit the patch to move this module to a new namespace, I have no problem with it proceeding as is. Now would be the time to file the followup bug report and assign it to the proper person. If this works for you please go ahead and reset the status to Signed Off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 13:45:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 12:45:40 +0000 Subject: [Koha-bugs] [Bug 15570] circ/renew.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15581 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 [Bug 15581] Add a circ rule to limit the auto renewals given a delay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 13:45:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 12:45:40 +0000 Subject: [Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15568, 15570 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 [Bug 15568] Circ rules are not displayed anymore http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 [Bug 15570] circ/renew.pl is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 13:45:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 12:45:47 +0000 Subject: [Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15582 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 13:45:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 12:45:47 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15581 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 [Bug 15581] Add a circ rule to limit the auto renewals given a delay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 13:53:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 12:53:50 +0000 Subject: [Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 13:53:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 12:53:53 +0000 Subject: [Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 --- Comment #1 from Jonathan Druart --- Created attachment 46690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46690&action=edit Bug 15581: Add a circ rule to limit the auto renewals given a delay This patch adds a new circulation rule (no_auto_renewal_after) to block/allow auto renewals after a given delay. For instance, if the issue date is 10 days before today, and no_auto_renewal_after is set to 10, tomorrow the issue won't be auto renewed. Test plan: 0/ Execute the update DB entry Note: You will have to manually change data in your DB, make sure you have access to the sql cli. 1/ Define a rule with no_auto_renewal_after (10 for instance) and norenewalbefore (5 for instance). (This new rule will behave the same as norenewalbefore: the unit depends on the lengthunit value). The automatic renewals will be done from 5 to 10 days ahead. 2/ Modify the issues.issuedate, to simulate a checkout in the past: UPDATE issues SET issuedate = "yyyy-mm-dd hh:mm:ss" WHERE itemnumber = YOUR_ITEMNUMBER; with issuedate = 2 days before for instance 3/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed (too soon) 4/ Repeat step 2 with a due date set as 11 days before 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed (too late) 6/ Repeat step 2 with a due date set as 7 days before 7/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed (issues.renewals has been incremented and date_due has been updated according your circ rules). Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 13:53:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 12:53:57 +0000 Subject: [Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 --- Comment #2 from Jonathan Druart --- Created attachment 46691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46691&action=edit Bug 15581: Display the latest auto renew date possible when renewing manually If an issue marked as auto_renew is renewed manually, we want to display the latest auto renew date possible. Test plan: 1/ Define circ rules as in the previous patch. 2/ Check a item out, mark it as an auto renewal 3/ Back date the issuedate and make sure it will be too late to renew it 4/ Use the Circulation > renew page (circ/renew.pl) to manually renew this issue. You should get a warning "You barcode has been scheduled for automatic renewal and cannot be renewed anymore since DATE." If the pref AllowRenewalLimitOverride is set, you will be allowed to renew it anyway. Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 13:54:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 12:54:15 +0000 Subject: [Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 --- Comment #3 from Jonathan Druart --- Created attachment 46692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46692&action=edit Bug 15581: [DO NOT PUSH] Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 13:54:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 12:54:43 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 13:54:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 12:54:45 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 --- Comment #1 from Jonathan Druart --- Created attachment 46693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46693&action=edit Bug 15582: Ability to block auto renewals if the max outstanding balance is reached If a patron owes more than the max outstanding balance (defined in the maxoutstanding syspref), the issue won't be auto renewed anymore (driven by the new pref MaxOutstandingBlockAutoRenew). Test plan: Note: You will have to manually change data in your DB, make sure you have access to the sql cli. 1/ Set the maxoutstanding to 5 (for instance) 2/ Set MaxOutstandingBlockAutoRenew to block 3/ Check an item out to a patron and mark is as an auto renewal 4/ Make sure the patron does not have any fees or charges. 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed 6/ Create an invoice for this patron with a amount > maxoustanding (6 for instance) 7/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed. 8/ Set MaxOutstandingBlockAutoRenew to allow 9/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 13:54:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 12:54:49 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 --- Comment #2 from Jonathan Druart --- Created attachment 46694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46694&action=edit Bug 15582: DB changes - add new pref MaxOutstandingBlockAutoRenew Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 14:30:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 13:30:55 +0000 Subject: [Koha-bugs] [Bug 15583] New: List of lists in the staff client should have a default sort Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15583 Bug ID: 15583 Summary: List of lists in the staff client should have a default sort Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The list of lists in the staff client seems to default to a sort by shelfnumber. While it may make sense to sort lists by creation date, I think in that case the DataTable should be configured to explicitly sort by creation date rather than have there be no visible sense to the default sort. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 14:37:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 13:37:34 +0000 Subject: [Koha-bugs] [Bug 15584] New: Staff client list errors are incorrectly styled Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Bug ID: 15584 Summary: Staff client list errors are incorrectly styled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When an error is triggered by the lists system in the staff client the "dialog"
    has the wrong class. It has
    but the correct class is
    The message or alert class is a template variable, so the script will have to be modified. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 14:39:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 13:39:21 +0000 Subject: [Koha-bugs] [Bug 15403] Confirm messages in intranet lists interface strangely worded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46627|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 46695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46695&action=edit [SIGNED-OFF] Bug 15403: Tidy up error messages in Staff lists To test: 1) Create a list on the intranet, observe the message 2) Create another list with the same name, observe the message 3) Delete a list, observe the message 4) Check the patch itself for typos Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 14:40:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 13:40:06 +0000 Subject: [Koha-bugs] [Bug 15403] Confirm messages in intranet lists interface strangely worded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 14:47:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 13:47:26 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #185 from Blou --- This is not a problem for us. To be sure, just create the new bug and assign it to me immediately. I assure you you'll get a patch within a week after this has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 14:51:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 13:51:18 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46684|0 |1 is obsolete| | --- Comment #32 from Nick Clemens --- Created attachment 46696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46696&action=edit [SIGNED-OFF] Bug 15295: (follow-up) Koha::Libraries - Remove GetBranchesCount Fix conflict with bug 11625 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 14:52:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 13:52:00 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 14:52:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 13:52:03 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46685|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 46697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46697&action=edit [SIGNED-OFF] Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 15:11:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 14:11:26 +0000 Subject: [Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434 --- Comment #11 from Nicole C. Engard --- That new patch doesn't apply either :( Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15434: Search criteria definition table Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... error: The following untracked working tree files would be overwritten by merge: koha-tmpl/opac-tmpl/bootstrap/js/search.js Please move or remove them before you can merge. Aborting Failed to merge in the changes. Patch failed at 0001 Bug 15434: Search criteria definition table When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15434-Search-criteria-definition-table-K9mxpF.patch 08:10 ~/kohaclone (bug15434-qa %|AM u=)$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 15:23:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 14:23:18 +0000 Subject: [Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 --- Comment #23 from Owen Leonard --- Is this bug invalid since the AllowOnShelfHolds system preferences is now in circulation and fine rules? (Bug 5786) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 15:27:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 14:27:29 +0000 Subject: [Koha-bugs] [Bug 8964] AllowHoldsOnDamagedItems and AllowOnShelfHolds don't work with Professional category type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8964 --- Comment #2 from Owen Leonard --- Is this bug still valid now that the AllowOnShelfHolds system preferences is in circulation and fine rules? (Bug 5786) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 15:28:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 14:28:01 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #186 from Kyle M Hall --- (In reply to Blou from comment #185) > This is not a problem for us. To be sure, just create the new bug and > assign it to me immediately. I assure you you'll get a patch within a week > after this has been pushed to master. Thanks! I'll go ahead and take care of that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 15:30:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 14:30:06 +0000 Subject: [Koha-bugs] [Bug 9190] Problem with holds - allow place a hold without all items checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9190 --- Comment #9 from Owen Leonard --- What is the status of this bug since Bug 5786 has moved the AllowOnShelfHolds system preferences to circulation and fine rules? How does this relate to Bug 15534? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 15:31:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 14:31:00 +0000 Subject: [Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 --- Comment #24 from Katrin Fischer --- Yes, the behaviour has not changed with the move - but I think Kyle is working on something that will resolve this on another bug report. I will try to dig it up later. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 15:31:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 14:31:01 +0000 Subject: [Koha-bugs] [Bug 8372] Move AllowOnShelfHolds at granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8372 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 15:31:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 14:31:22 +0000 Subject: [Koha-bugs] [Bug 7970] Allow OPAC holds per library policy without default rule In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7970 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 15:32:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 14:32:34 +0000 Subject: [Koha-bugs] [Bug 11321] "On hold" items can't be placed on hold with allowonshelfholds off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11321 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 15:37:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 14:37:40 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #187 from Kyle M Hall --- (In reply to Chris Cormack from comment #179) > Hopefully this new super strict QA standard will be across the board and I > won't see people pushing patches they wrote skipping qa steps anymore. I'd like to address this. I'm not in favor of super strict QA standards. What I'm in favor of are transparent, standardized, and consistently applied QA rules. My experience as a developer has informed my work as a QA team member. I have had to rewrite C4 modules as Koha modules, I've asked others to rewrite C4 modules as Koha modules. Code quality guidelines should be completely divorced from the necessity or popularity of a bugfix or feature. I think our coding guidelines need a bit of a revamp to make sure all of the things we've taken for granted as being necessary to pass QA are actually in the coding guidelines. If a QA team member fails QA on a patch, the QA'er should be able to link directly to the reason and explanation for it failing QA. If the QA'er believes the patch should fail QA but the reason is not part of the coding guidelines, then a meeting should be called, a vote should be made, and a new rule added to the guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 15:48:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 14:48:31 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #188 from Katrin Fischer --- While I have put coding guideline additions on the agenda a lot of times in the past, I don't believe that we can ever have a complete set of rules that will fit every situation and possible question. Another common practice we QA has used where they haven't been sure about something is asking for more opinions - I think this has helped in a lot of cases to get more views and a better picture of the problem and possible solutions. That said, I am happy with the 2 step approach here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 15:55:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 14:55:52 +0000 Subject: [Koha-bugs] [Bug 15585] New: Move C4::Passwordrecovery to Koha::Patron::Password::Reset Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 Bug ID: 15585 Summary: Move C4::Passwordrecovery to Koha::Patron::Password::Reset Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 8753 introduces a new C4 module. This module should be moved to the Koha namespace. It looks like Koha::Patron::Password::Reset would be the most appropriate namespace, as the feature allows for password resets rather than being able to recover the original password. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 15:56:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 14:56:10 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8753 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 [Bug 8753] Add forgot password link to OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 15:56:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 14:56:10 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15585 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 15:56:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 14:56:38 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:06:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:06:12 +0000 Subject: [Koha-bugs] [Bug 14935] waiting and in transit items cannot be reserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14935 --- Comment #2 from Katrin Fischer --- Hi Team Lyon - please prefer the older bug if there are patches/discussion on it, unless there is a need to start over, when resolving a bug as a duplicate. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:09:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:09:21 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 --- Comment #13 from Alex Arnaud --- Created attachment 46698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46698&action=edit Bug 6979 - Handle multiple branches in non-auth_by_bin -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:09:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:09:29 +0000 Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:09:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:09:48 +0000 Subject: [Koha-bugs] [Bug 14935] waiting and in transit items cannot be reserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14935 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 4319 *** -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:09:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:09:48 +0000 Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #26 from Katrin Fischer --- *** Bug 14935 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:10:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:10:11 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P1 - high Status|Failed QA |Needs Signoff Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:10:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:10:38 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:11:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:11:08 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion Version|unspecified |master --- Comment #2 from Owen Leonard --- I don't think this is the right solution for what is currently a messy problem. As I understand it, the current "allow on shelf holds" feature will let you place a hold if *any* of multiple items is unavailable. I understand that this is The Way It Has Been, but the description of the option in and the documentation do NOT make it explicit that this is the behavior. My initial reaction to this patch is that it's trying to make "allow on shelf holds" work the way it is actually described rather than how it really works. Do libraries who use the "allow on shelf holds" feature *want* it to work that way, or do they use it because it's better than nothing? I think having two settings, "allow on shelf holds" and "allow hold if others available" is needlessly confusing. On the face of it they both look like they do exactly the same thing, and I have no idea how they're supposed to work in conjunction with each other. In my test of this patch I set a global all item types/all patron categories rule with both "allow on shelf holds" and "allow hold if others available" set to "no." However, I was able to place a hold on a title which has one checked-out item and three available. I don't think that's right. There have been other discussions of this issue too which should be taken into account: Bug 6837 and Bug 9190. If we bring it all together is there a single solution which can accommodate everyone's needs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:12:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:12:17 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #189 from Kyle M Hall --- (In reply to Katrin Fischer from comment #188) > While I have put coding guideline additions on the agenda a lot of times in > the past, I don't believe that we can ever have a complete set of rules that > will fit every situation and possible question. > > Another common practice we QA has used where they haven't been sure about > something is asking for more opinions - I think this has helped in a lot of > cases to get more views and a better picture of the problem and possible > solutions. That simply highlights the problem. With this methodology, a developer will not know if code will pass qa or not until it has been written and submitted. I agree, we will never have a complete set of rules, but we can build that set as we go. The more we have written down for developers to be aware in advance, the better. We need documented guidelines. The approach of "this doesn't feel right to me" just doesn't work any more. It can only lead to future frustration for developers. We can't have one set of rules for bug A and another set of rules for bug B. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:17:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:17:53 +0000 Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4329|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:23:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:23:47 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #5 from Owen Leonard --- Would the need for this feature be eliminated if it was possible to limit item-level holds to the types of records defined in this patch? That is, serials, titles with volumes, etc? If so, shouldn't we be solving that problem instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:32:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:32:00 +0000 Subject: [Koha-bugs] [Bug 15403] Confirm messages in intranet lists interface strangely worded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:32:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:32:03 +0000 Subject: [Koha-bugs] [Bug 15403] Confirm messages in intranet lists interface strangely worded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46695|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 46699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46699&action=edit Bug 15403: Tidy up error messages in Staff lists To test: 1) Create a list on the intranet, observe the message 2) Create another list with the same name, observe the message 3) Delete a list, observe the message 4) Check the patch itself for typos Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:32:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:32:13 +0000 Subject: [Koha-bugs] [Bug 15403] Confirm messages in intranet lists interface strangely worded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403 --- Comment #4 from Kyle M Hall --- Created attachment 46700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46700&action=edit Bug 15403 [QA Follow] - Minor language tweak The phrase "Please check it's not" sees incorrect gramatically, changing the wording to "Please verify it is not" Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:33:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:33:03 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard --- (In reply to Liz Rea from comment #7) > With this patch, the verification box doesn't show, and you cannot complete > a self registration. You will always get the message "You typed in the wrong > characters in the box before submitting. Please try again." Same for me. Iceweasel 38.5.0 and Chromium 47.0.2526.80 on Debian. Here are my settings: PatronSelfRegistration - "Allow" PatronSelfRegistrationAdditionalInstructions - Empty PatronSelfRegistrationBorrowerMandatoryField - surname|firstname PatronSelfRegistrationBorrowerUnwantedField - password PatronSelfRegistrationDefaultCategory - T PatronSelfRegistrationExpireTemporaryAccountsDelay - 14 PatronSelfRegistrationVerifyByEmail - Require -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:38:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:38:56 +0000 Subject: [Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:39:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:39:00 +0000 Subject: [Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46658|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 46701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46701&action=edit Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen. Test plan: Enable OnSiteCheckouts and OnSiteCheckoutsForce Debar a patron and go on the circulation page. Without this patch, the automatic renewal checkbox is displayed. With this patch applied, it's not. Patch works as expected. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:44:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:44:06 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:44:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:44:10 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46681|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 46702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46702&action=edit Bug 15274: Putting tags around entire string where the originally split the sentence I have only done this where the tags split the sentence. To test: 1) Go to a borrower's check out page (circulation.pl) 2) Check out a book and specify the due date to a past date (ie, to 2015 etc) 3) Confirm the entire sentence in the error message is styled by the span tags. 4) Create a manual invoice of $100 for the borrower 5) Confirm the entire sentence in the error message styled by span tags. 6) Check the patch and the circulation.tt file and confirm that I haven't missed any tags that split the string and make translation difficult. I personally do not prefer this patch because the red bold sentences don't look very good and aren't highly readable. Signed off on this second patch, see screenshots in comment #4. (Forbidden tab char in line 779 removed) Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:46:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:46:40 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #190 from Katrin Fischer --- I think we are actually not in disagreement - I just want to warn about wanting to solve everything with rules. That will be trying for the impossible. And a 20 pages catalog of guidelines... is kind of scaring away devs too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:51:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:51:03 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:51:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:51:07 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46678|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 46703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46703&action=edit Bug 15573: String and translatability fix to Patron Card Creator Fixing the split string To test: 1) Go to Tools -> Patron Card Creator -> Manage -> Card batches 2) Confirm the table heading reads 'Patron Count' 3) Edit a batch 4) Click Remove duplicates 5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)' Signed-off-by: Hector Castro Works as described. Rewording Ok for translatability purpose Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:51:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:51:15 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 --- Comment #7 from Kyle M Hall --- Created attachment 46704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46704&action=edit Bug 15573 [QA Followup] - Tweak wording Based on JS4 of the coding guidelines, it seems improper embed the count in the middle of this string. I think this working may be more correct. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:54:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:54:49 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:54:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:54:52 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #10 from Nick Clemens --- Created attachment 46705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46705&action=edit Bug 15343 [QA Follow up] Fix captcha display Make captcha visible even if password field is hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:55:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:55:38 +0000 Subject: [Koha-bugs] [Bug 15574] Better wording for error message when adding tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15574 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:55:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:55:42 +0000 Subject: [Koha-bugs] [Bug 15574] Better wording for error message when adding tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15574 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46677|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 46706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46706&action=edit Bug 15574: Better wording for error message when adding a duplicate tag To test: 1) Apply patch 2) Go to a record (ie opac-detail.pl) and add tags that already exist with that record 3) Confirm new error message Signed-off-by: Hector Castro Rewording Ok for common patrons Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:56:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:56:56 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 16:57:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 15:57:14 +0000 Subject: [Koha-bugs] [Bug 15576] Link in OPAC redirects to the wrong page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15576 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:00:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:00:16 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:00:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:00:19 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46670|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 46707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46707&action=edit Bug 15577: Correcting link redirect To test: 1) Add a restriction to a user 2) Log in as that user in the OPAC 3) Click 'your account page' link in the yellow mesage 4) Confirm you are taken to opac-account.pl Signed-off-by: Hector Castro Works as advertised Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:03:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:03:32 +0000 Subject: [Koha-bugs] [Bug 15576] Link in OPAC redirects to the wrong page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15576 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:03:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:03:36 +0000 Subject: [Koha-bugs] [Bug 15576] Link in OPAC redirects to the wrong page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15576 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46669|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 46708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46708&action=edit Bug 15576: Fix for incorrect link redirect To test: 1) Edit a user to have an uncertain address (gone no address) 2) Log in as that user on OPAC 3) Click 'online update form' link in the yellow message 4) Confirm you are taken to opac-memberentry.pl Signed-off-by: Hector Castro Works as described Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:09:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:09:48 +0000 Subject: [Koha-bugs] [Bug 13177] Add help pages for Rotating collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:09:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:09:52 +0000 Subject: [Koha-bugs] [Bug 13177] Add help pages for Rotating collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46666|0 |1 is obsolete| | Attachment #46667|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 46709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46709&action=edit Bug 13177: Help page for Rotating Collections To test: Go to Tools -> Rotating Collections and click Help in the top-right. Confirm the Help page shows and gives correct accurate instructions with no typos or grammatical errors. Help displays as expected. Signed-off-by: Marc V?ron Signed-off-by: Nicole Engard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:10:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:10:00 +0000 Subject: [Koha-bugs] [Bug 13177] Add help pages for Rotating collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 --- Comment #9 from Kyle M Hall --- Created attachment 46710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46710&action=edit Bug 13177: Accidental copy/paste error fix Confirm it now says Rotating Collections instead of Patron Import in the last line, and the link is correct. Signed-off-by: Nicole Engard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:18:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:18:22 +0000 Subject: [Koha-bugs] [Bug 1887] Managing Suggestions - hold books for patron who requested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1887 Wendy Sharkey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catalog at bfli.org --- Comment #3 from Wendy Sharkey --- This seems like a good idea to me and would solve the disconnect between suggestion and hold. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:41:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:41:30 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:41:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:41:32 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46675|0 |1 is obsolete| | Attachment #46676|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 46711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46711&action=edit Bug 15578: Insert authority records before processing tests Signed-off-by: Hector Castro Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:41:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:41:41 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 --- Comment #6 from Kyle M Hall --- Created attachment 46712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46712&action=edit Bug 15578: Make sure all params will be taken into account when instantiating The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped. On our integration server, the DB does not contain any records, and the tests are skipped. Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority. Test plan: Apply the first patch, launch tests => Fail Apply the second patch, launch tests => \o/ Signed-off-by: Hector Castro Test pass successfuly Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:47:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:47:32 +0000 Subject: [Koha-bugs] [Bug 13534] Deleting staff patron will delete tags approved by this patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:47:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:47:35 +0000 Subject: [Koha-bugs] [Bug 13534] Deleting staff patron will delete tags approved by this patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46630|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 46713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46713&action=edit Bug 13534: Do not remove tags on deleting a patron On deleting a patron, all the tags approved by this user will be deleted. This can cause data lost. Test plan: 0/ Do not execute the update DB entry 1/ Create 2 patrons A, B 2/ Create some tags with patron A logged in 3/ Approve them with patron B logged in 4/ Delete the 2 patrons => The tags have been deleted 5/ Execute the DB entry 6/ Repeat 1,2,3,4 => The tags have not been deleted and are still shown on the interface (result, detail, tags module) Signed-off-by: Aleisha Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:49:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:49:35 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #4 from Owen Leonard --- This looks useful. I'm not crazy about additions to Koha which require the user to set configurations in this manner because I think it's no very friendly. A better choice, I think, would be to build a separate page as a front-end for the preference, displaying a form with paired dropdown menus listing existing shelving locations. I see a couple of problems with the functionality as it is here: 1. I think there are bound to be conflicts with the InProcessingToShelvingCart and ReturnToShelvingCart system preferences. I'm guessing the functionality of those preferences can be fully replaced by that of this patch, but a migration system will have to be built. 2. If this patch is approved without an improved interface like I describe, it needs to be made clear what empty values are meant to do. For instance: PROC: or :PROC Should that work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:59:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:59:06 +0000 Subject: [Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 17:59:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 16:59:10 +0000 Subject: [Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46561|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 46714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46714&action=edit Bug 15550: Fix authority search and detail at the OPAC The author of Bug 15381 (me!) has mismatch the objects he was manipulating and forgotten to update a template. for the opac-aythorities-home, the variable is named authority_types, not authtypesloop. In opac-authoritiesdetail.pl, the $record is a MARC::Record and there is no authtypecode method. We need to retrieve the authtypecode using the new Koha::Authorities module. Test plan: Search for authorities at the OPAC and click on the detail link to go to the detail page. Without this patch, you will get errors. With this patch, the errors should have gone and everything should work as before bug 15381. Signed-off-by: Hector Castro Works as described. Pull down for choosing the auth_type displayed again Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:06:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:06:45 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Owen Leonard --- (In reply to Nick Clemens from comment #1) > 8 - Register a patron with a password, your password should be used At this step I'm getting an error: DBIx::Class::Row::store_column(): No such column 'password2' on Koha::Schema::Result::BorrowerModification at /home/oleonard/kohaclone/Koha/Borrower/Modifications.pm line 65 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:08:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:08:36 +0000 Subject: [Koha-bugs] [Bug 15458] Marc21 leader 07 error in translation: "a- Serial component" part is not in format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15458 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #6 from Fr?d?ric Demians --- Patch for bug 14201 hasn't been pushed to stable (3.22). That's the reason why it hasn't been examined to be pushed to 3.20. It's Julian responsibility to push or not this patch to its branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:13:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:13:03 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #19 from Owen Leonard --- (In reply to Jesse Weaver from comment #16) > Created attachment 46352 [details] [review] > Bug 14658: (followup) fix issue with list context on DBIC call Is this bug set to 'needs signoff' because of this follow-up? If so, is there a test plan for the follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:21:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:21:30 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:21:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:21:35 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29611|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 46715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46715&action=edit Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off If the user knows the URL for OPAC lists they can access them even with the virtualshelves preference turned off. This patch copies the solution added to opac-topissues.pl by Bug 10595 and applies it to OPAC lists pages. To test, apply the patch and set the virtualshelves system preference to "don't allow." - Navigate to /cgi-bin/koha/opac-shelves.pl. You should be redirected to an Error 404 page. - Also check: - /cgi-bin/koha/opac-shareshelf.pl. - /cgi-bin/koha/opac-downloadshelf.pl - /cgi-bin/koha/opac-sendshelf.pl - /cgi-bin/koha/opac-addbybiblionumber.pl - Turn virtualshelves back on. Access to lists and list sharing should be restored. Signed-off-by: Aleisha Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:22:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:22:21 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #12 from Kyle M Hall --- Aleisha, I'm not sure if you meant to set this to signed off or not. If you did not sign off on this, just set the status to signed-off and I can be the signer. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:26:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:26:30 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #36 from Owen Leonard --- Sorry, this doesn't apply anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:27:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:27:34 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:27:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:27:39 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46515|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 46716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46716&action=edit Bug 2669: Change checkboxes to radio buttons on dictionary On creating new dictionary for report, the choice between "All dates" and "Date range" should be a real radio button, not 2 radio buttons with different names (which means they could be selected altogether...) Note that I don't understand what means 'All dates', there is no condition generated for the dictionary. We should not have to select a field if we don't want to add a condition on it :) Test plan: Create a new dictionary for the Patron module, then a date field (dateenrolled or birthdate, etc.) Confirm that the radio buttons now behave as radio buttons... Signed-off-by: Aleisha Looks so much nicer too! Radio buttons display as expected. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:28:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:28:42 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Another wishlist item: it would be nice of the date range fields only displayed when the date range option is selected, or the date range option is selected automatically if the date range gets filled in my the librarian. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:32:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:32:32 +0000 Subject: [Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- I can't apply this patch on master. I get: fatal: sha1 information is lacking or useless (C4/HoldsQueue.pm). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:36:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:36:07 +0000 Subject: [Koha-bugs] [Bug 15323] ./t/Prices.t fails without a valid database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323 Larry Baerveldt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larry at bywatersolutions.com --- Comment #5 from Larry Baerveldt --- I've seen this error too when attempting to build a package. Version tested was 3.20.06. Here's the test failure message: DBI connect('dbname=koha;host=localhost;port=3306','kohaadmin',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /usr/share/perl5/DBIx/Connector.pm line 32. Can't call method "do" on unblessed reference at /tmp/buildd/koha-3.20.06+20160114144139.2d762685/blib/PERL_MODULE_DIR/C4/Context.pm line 793. # Child (Configuration 1: 0 0) exited without calling finalize() # Failed test 'Configuration 1: 0 0' # at /usr/share/perl/5.20/Test/Builder.pm line 276. # Looks like you planned 16 tests but ran 5. # Looks like you failed 1 test of 5 run. # Looks like your test exited with 255 just after 5. t/Prices.t .......................... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 12/16 subtests t/Print.t ........................... ok ... Test Summary Report ------------------- t/Prices.t (Wstat: 65280 Tests: 5 Failed: 1) Failed test: 5 Non-zero exit status: 255 Parse errors: Bad plan. You planned 16 tests but ran 5. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:42:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:42:41 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:42:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:42:44 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46494|0 |1 is obsolete| | Attachment #46495|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 46717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46717&action=edit Bug 15542: Always display the patron's info the same way. The patron's information displayed in the member module (includes/circ-menu.inc and includes/member-display-address-style-*.inc) are not always displayed the same way. Sometimes the streetnumber is missing, sometimes it's the streettype. Sometimes the streettype is after the address, sometimes before... Test plan: Go on a patron detail page, and open all the tabs on the left (Check out, Fines, Notices, etc.) Without this patch, the patron's info displayed will differ from one page to another. With this patch, they will be displayed the same everywhere. Followed test plan, works as expected. (Tested both patches together.) Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:42:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:42:53 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 --- Comment #20 from Kyle M Hall --- Created attachment 46719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46719&action=edit Bug 15542 [QA Followup] - Fix code error Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:42:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:42:51 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 --- Comment #19 from Kyle M Hall --- Created attachment 46718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46718&action=edit Bug 15542: Change for the German style address format Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:42:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:42:56 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 --- Comment #21 from Kyle M Hall --- Created attachment 46720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46720&action=edit Bug 15542 [QA Followup] - Tidy member-password.pl No other patches in process modify member-password.pl, now would be a great time to tidy it! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:44:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:44:10 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46720|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 46721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46721&action=edit Bug 15542 [QA Followup] - Tidy member-password.pl No other patches in process modify member-password.pl, now would be a great time to tidy it! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:52:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:52:42 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Still waiting for QAM's opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:54:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:54:58 +0000 Subject: [Koha-bugs] [Bug 15526] Drop nozebra database table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15526 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 18:55:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 17:55:00 +0000 Subject: [Koha-bugs] [Bug 15526] Drop nozebra database table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15526 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46506|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 46722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46722&action=edit Bug 15526: drop table nozebra This table is not used anymore and can be removed. Test plan: In your sql cli: SHOW TABLES; should return nozebra if your DB has been created before bug 7440. Apply this patch and execute the update DB entry. Now the table should have been dropped. Signed-off-by: Aleisha Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:05:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:05:25 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- (In reply to Marc V?ron from comment #13) > (In reply to Jonathan Druart from comment #12) > > Marc, why do you replace div with li? > > Because it looks nicer if there are multiple messages. I think it's a great improvement! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:07:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:07:14 +0000 Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699 --- Comment #7 from Owen Leonard --- (In reply to Nick Clemens from comment #6) > 2 - Select all searches but respect filters. If I filter down to 8 searches > it should select only those. If my filter finds 21 searches (default 20 > visible) it should select all 21, but not searches limited by filter. > Labels would say "With ## selected searches: delete" I think this is the correct goal. With a filtered result clicking "select all" shouldn't select lines which are not visible because of the filter. However, with a filtered or unfiltered result clicking "select all" should select records across all pages. > 1 - On master selecting any search past 20 doesn't change the look of the > delete button, though it is enabled. It does only function on the visible > searches either way Confirmed. Checking a box on any but the first page does not change the appearance of the delete button or show the number of selected lines even though the delete button will work. > 2 - The phrasing "With selected searches: Delete" is awkward. This is a pattern used elsewhere, although it's not quite as useful when there is only one "action" available. See the OPAC list interface where we have "Select titles to: Place hold | Remove from list" ...which changes to: "With selected titles: Place hold | Remove from list" I think the advantage to doing it this way is that the interface is explicit about *why* an option is disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:13:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:13:10 +0000 Subject: [Koha-bugs] [Bug 15357] Deleting all items on a record with title level holds creates orphaned/ghost holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15357 --- Comment #7 from Kyle M Hall --- Created attachment 46723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46723&action=edit Bug 15357 [QA Followup] - Remove refereces to biblio and biblionumber for patron messages Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:14:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:14:23 +0000 Subject: [Koha-bugs] [Bug 15357] Deleting all items on a record with title level holds creates orphaned/ghost holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15357 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #46723|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:14:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:14:56 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 --- Comment #15 from Kyle M Hall --- Created attachment 46724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46724&action=edit Bug 15375 [QA Followup] - Remove refereces to biblio and biblionumber for patron messages Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:26:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:26:05 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:26:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:26:08 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46631|0 |1 is obsolete| | Attachment #46724|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 46725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46725&action=edit Bug 15375 - Translatability: Fix issues on OPAC page 'Placing a hold' Fix several issues with odd translations on opac-reserve.tt due to string splitting by tags. In addition, streamline messages to make them similar to the same messages on the OPAC summary page (Bug 15374) To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with expired account - with user with uncertain address information - Try to put holds - Verify that message about why holds are not possible is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions (Amended: stray i removed, test plan updated, removed account that is about to expire) Signed-off-by: Aleisha I am going to sign off on this because it works as it should and I think the problems I had in comment 8 are a separate bug. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:26:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:26:16 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 --- Comment #17 from Kyle M Hall --- Created attachment 46726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46726&action=edit Bug 15375 [QA Followup] - Remove refereces to biblio and biblionumber for patron messages Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:26:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:26:18 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 --- Comment #18 from Kyle M Hall --- Created attachment 46727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46727&action=edit Bug 15375 [QA Followup] - Fix non-functional restriction message and date Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:30:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:30:34 +0000 Subject: [Koha-bugs] [Bug 15479] SIPserver rejects renewals for patrons with alphanumeric cardnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #3 from Fr?d?ric Demians --- I get the reasoning, and agree with it. Do you think you could cook a unit test to check this case? A UT which fails without your patch, and succeed with it? And a minor point of detail: why do you use a function rather than a regex in your test. For example: $item->{patron} && $item->{patron} !~ /^$patron_id$/i -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:44:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:44:11 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:44:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:44:14 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46634|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 46728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46728&action=edit Bug 15548: Move new patron related code to Patron* The 'borrower' should not be used anymore, especially for new code. This patch move files and rename variables newly pushed (i.e. in the Koha namespace). Test plan: 1/ git grep Koha::Borrower should not return code in use. 2/ Prove the different modified test files 3/ Do some clicks in the member^Wpatron module to be sure there is not an obvious error. Signed-off-by: Hector Castro Works as described. Tested with Circulation, Members/Patrons, Discharge, Restrictions modules and the must common functionalities Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:44:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:44:22 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #11 from Kyle M Hall --- Created attachment 46729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46729&action=edit Bug 15548 [QA Followup] - Catch a couple new Koha::Borrower uses Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:48:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:48:03 +0000 Subject: [Koha-bugs] [Bug 15586] New: References to Koha::Branches remain in unit tests Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Bug ID: 15586 Summary: References to Koha::Branches remain in unit tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The unit tests BiblioObject.t and Hold.t still have references to Koha::Branches that need to be changed to Koha::Libraries. These tests currently fail because of this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:48:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:48:10 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com Severity|enhancement |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:49:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:49:04 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 --- Comment #13 from Aleisha Amohia --- (In reply to Kyle M Hall from comment #12) > Aleisha, I'm not sure if you meant to set this to signed off or not. If you > did not sign off on this, just set the status to signed-off and I can be the > signer. Sorry, yes I was meant to sign off. Not sure why it didn't work -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:49:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:49:19 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:49:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:49:21 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 --- Comment #1 from Kyle M Hall --- Created attachment 46730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46730&action=edit Bug 15586 - References to Koha::Branches remain in unit tests The unit tests BiblioObject.t and Hold.t still have references to Koha::Branches that need to be changed to Koha::Libraries. These tests currently fail because of this. Test Plan: 1) prove t/db_dependent/BiblioObject.t should fail 2) prove t/db_dependent/Hold.t should fail 3) Apply this patch 1) prove t/db_dependent/BiblioObject.t should pass 2) prove t/db_dependent/Hold.t should pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:52:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:52:46 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #12 from Kyle M Hall --- RM Note: git grep Koha::Borrower should only result in references to: misc/release_notes/release_notes_3_18_0.txt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 19:57:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 18:57:01 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 --- Comment #1 from Blou --- We'll hold our side of the bargain. I've already created a local task at high priority. But if it's ok with everyone, we'll wait until 8753 is pushed to master before doing so, just to avoid some rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 20:15:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 19:15:52 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 20:15:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 19:15:54 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45771|0 |1 is obsolete| | Attachment #45772|0 |1 is obsolete| | Attachment #45773|0 |1 is obsolete| | Attachment #45774|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 46731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46731&action=edit Bug 14828: Add Koha::ItemType[s] classes Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 20:16:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 19:16:05 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #24 from Kyle M Hall --- Created attachment 46733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46733&action=edit Bug 14828: Remove old package and tests C4::ItemType can be now removed safely, there is no use of this module. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 20:16:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 19:16:02 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #23 from Kyle M Hall --- Created attachment 46732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46732&action=edit Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used This patch mainly replaces C4::ItemType->all with Koha::ItemTypes->search. Test plan: At the places where the C4::ItemType module was used, confirm there is no regression: - acqui/neworderempty.pl - catalogue/itemsearch.pl - admin/item_circulation_alerts.pl and the 2 cataloguing plugins: - marc21_linking_section.pl - unimarc_field_4XX.pl QA step: prove t/db_dependent/HoldsQueue.t should return green Note that the tests were buggy. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 20:16:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 19:16:08 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #25 from Kyle M Hall --- Created attachment 46734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46734&action=edit Bug 14828: use Koha::ItemType[s] in admin/itemtypes Test plan: Add/edit/remove item types from the administration module (admin/itemtypes.pl). You should get message feedback after each action. Don't forget to play with the image and try to remove an item type linked to records (you should not be able to remove it). Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 20:16:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 19:16:11 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #26 from Kyle M Hall --- Created attachment 46735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46735&action=edit Bug 14828 [QA Followup] - Hide in OPAC checkbox not checked in editor even if enabled Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 20:35:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 19:35:23 +0000 Subject: [Koha-bugs] [Bug 15391] Some tests in HoldsQueue.t should not pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 --- Comment #3 from Kyle M Hall --- The "itemtype" from line 64 is being inserted into a biblioitems row at line , which does not have a foreign key to itemtypes, so it succeeds. The itemtype is re-used at line 98 for an item. It appears the test actually requires the item to be *for* loan, rather than not for loan. Since the itemtype doesn't really exists, is seems to fail as a for loan itemtype, even though it seems like we should get an execution error instead. Then, at line 181 the itemtype is replace with an arbitrary itemtype selected from the database, which is probably just a lucky grab since the default data would give a for loan itemtype first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 20:37:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 19:37:26 +0000 Subject: [Koha-bugs] [Bug 15391] Some tests in HoldsQueue.t should not pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 --- Comment #4 from Kyle M Hall --- Also, I kind of expected this tests to fail when I set item level itypes to biblio, but it still continued to succeed. It seems that the selection of a not for loan itemtype is just cruft at this point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 20:52:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 19:52:59 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #191 from Kyle M Hall --- (In reply to Katrin Fischer from comment #190) > I think we are actually not in disagreement - I just want to warn about > wanting to solve everything with rules. That will be trying for the > impossible. And a 20 pages catalog of guidelines... is kind of scaring away > devs too. Lol, yeah, I agree with that too. I just think at the moment we have too few guidelines on paper and too many guidelines only in the heads of the QA team ; ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 20:53:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 19:53:46 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 --- Comment #14 from Kyle M Hall --- (In reply to Aleisha Amohia from comment #13) > (In reply to Kyle M Hall from comment #12) > > Aleisha, I'm not sure if you meant to set this to signed off or not. If you > > did not sign off on this, just set the status to signed-off and I can be the > > signer. > > Sorry, yes I was meant to sign off. Not sure why it didn't work Np! I already added your sign-off to the patch, assuming that was the case. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 21:03:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 20:03:36 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #192 from Kyle M Hall --- I also want to add that the guidelines would be an explanation of they something failed qa. Instead of "Here is a link to the community decided reason" it is currently more of a "because I said so" situation. I personally dislike failing qa on something without having those reasons. I'm far more apt to submit follow ups to avoid doing so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 22:00:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 21:00:39 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal CC| |charles.farmer at inlibro.com, | |eric.begin at inLibro.com, | |francois.charbonnier at inlibr | |o.com, | |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 22:05:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 21:05:56 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 22:05:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 21:05:58 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #1 from Nick Clemens --- Created attachment 46736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46736&action=edit Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page Currently if not logged in when browsing to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl You are redirected to opac-auth.pl and SCOUserCSS and SCOUserJS are not loaded. This patch adds new opac-auth.tt file for authenticating SCO users which loads these files and redirects a login to the SCO module instead of the patron account Common code between opac-auth and sco-auth is mostly alternate login info and has been move to alt-auth.inc To test: 1 - Verify that normal login works on both staff and opac 2 - Verify that SCO login goes to a new page 3 - Enter changes into SCOUserJS and SCOUserCSS and observe these are present on SOC log in page 4 - Verify that a logged in opac user without permissions cannot access the self-checkout module 5 - Verify that AutoSelfCheckAllowed and associated system preferences function as expected 6 - Verify the AutoSelfCheck user is logged out if they attempt to visit another page Bonus points for verifying all alternate methonds of login function as expected Sponsored by Northeast Kansas Libary System (NEKLS) www.nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 22:28:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 21:28:40 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 22:28:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 21:28:42 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46705|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 46737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46737&action=edit Bug 15343 [QA Follow up] Fix captcha display Make captcha visible even if password field is hidden Remove password confirmation field before submitting modification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 15 23:47:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jan 2016 22:47:54 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #20 from Jesse Weaver --- (In reply to Owen Leonard from comment #19) > (In reply to Jesse Weaver from comment #16) > > Created attachment 46352 [details] [review] [review] > > Bug 14658: (followup) fix issue with list context on DBIC call > > Is this bug set to 'needs signoff' because of this follow-up? If so, is > there a test plan for the follow-up? The followup was introduced to fix a bug caused by a change in master since this patch was originally submitted; the test plan should be the same as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 01:03:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 00:03:58 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |In Discussion --- Comment #2 from H?ctor Eduardo Castro Avalos --- Hi Kyle the patch fails in merging process Applying: Bug 15586 - References to Koha::Branches remain in unit tests Using index info to reconstruct a base tree... M t/db_dependent/BiblioObject.t M t/db_dependent/Hold.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Hold.t CONFLICT (content): Merge conflict in t/db_dependent/Hold.t Auto-merging t/db_dependent/BiblioObject.t CONFLICT (content): Merge conflict in t/db_dependent/BiblioObject.t Failed to merge in the changes. Patch failed at 0001 Bug 15586 - References to Koha::Branches remain in unit tests The copy of the patch that failed is found in: /var/koha/koha/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15586---References-to-KohaBranches-remain-in-u-Ltdaou.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 01:25:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 00:25:47 +0000 Subject: [Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |In Discussion --- Comment #3 from H?ctor Eduardo Castro Avalos --- (In reply to Fr?d?ric Demians from comment #2) > I can't apply this patch on master. I get: > > fatal: sha1 information is lacking or useless (C4/HoldsQueue.pm). > error: could not build fake ancestor Applying: Bug 15533 - Allow patrons and librarians to select itemtype when placing hold fatal: sha1 information is lacking or useless (C4/HoldsQueue.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 15533 - Allow patrons and librarians to select itemtype when placing hold The copy of the patch that failed is found in: /var/koha/koha/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15533---Allow-patrons-and-librarians-to-select-UnO2iN.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 02:28:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 01:28:51 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 02:28:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 01:28:54 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46730|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 46738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46738&action=edit Bug 15586 - References to Koha::Branches remain in unit tests The unit tests BiblioObject.t and Hold.t still have references to Koha::Branches that need to be changed to Koha::Libraries. These tests currently fail because of this. Test Plan: 1) prove t/db_dependent/BiblioObject.t should fail 2) prove t/db_dependent/Hold.t should fail 3) Apply this patch 1) prove t/db_dependent/BiblioObject.t should pass 2) prove t/db_dependent/Hold.t should pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 03:08:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 02:08:50 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #1 from Chris Cormack --- Created attachment 46739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46739&action=edit Bug 15584 - References to Koha::Branches remain in unit tests The unit tests BiblioObject.t and Hold.t still have references to Koha::Branches that need to be changed to Koha::Libraries. These tests currently fail because of this. Test Plan: 1) prove t/db_dependent/BiblioObject.t should fail 2) prove t/db_dependent/Hold.t should fail 3) Apply this patch 1) prove t/db_dependent/BiblioObject.t should pass 2) prove t/db_dependent/Hold.t should pass Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 03:09:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 02:09:41 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #2 from Chris Cormack --- The content of attachment 46739 has been deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 03:10:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 02:10:38 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 03:10:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 02:10:41 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46738|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 46740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46740&action=edit Bug 15586 - References to Koha::Branches remain in unit tests The unit tests BiblioObject.t and Hold.t still have references to Koha::Branches that need to be changed to Koha::Libraries. These tests currently fail because of this. Test Plan: 1) prove t/db_dependent/BiblioObject.t should fail 2) prove t/db_dependent/Hold.t should fail 3) Apply this patch 1) prove t/db_dependent/BiblioObject.t should pass 2) prove t/db_dependent/Hold.t should pass Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 03:11:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 02:11:01 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Severity|blocker |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 03:21:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 02:21:00 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 03:21:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 02:21:04 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46018|0 |1 is obsolete| | --- Comment #9 from Chris Cormack --- Created attachment 46741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46741&action=edit Bug 15188 - Fixes remove_unused_authorities.pl will delete all authorities if zebra is not running Test plan: 1) Shut down zebra: koha-zebra-ctl.sh stop 2) Execute the script: remove_unused_authorities.pl (with -t if you don't want to really delete from your database). 3) Check that the script would have deleted all the authorities (eg: 31449 authorities parsed, 31449 deleted and 0 unchanged because used). 4) Apply patch 5) Run, notice that the script dies because zebra is unavailable Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 03:31:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 02:31:06 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #15 from Chris Cormack --- Hmmm or maybe we do want them && Don't put fines on, if the automatic renewals script failed to run, or we will be fining people that we shouldn't A case could be made for it either way What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 09:47:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 08:47:07 +0000 Subject: [Koha-bugs] [Bug 15587] New: Unstable letsencrypt_x.x.x-x_all.deb testing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15587 Bug ID: 15587 Summary: Unstable letsencrypt_x.x.x-x_all.deb testing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz This bug is to test bug 15303 with the Debian package for letsencrypt. It is only available in unstable so far. To test this, you need to mix Jessie and unstable sources. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 09:47:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 08:47:36 +0000 Subject: [Koha-bugs] [Bug 15587] Unstable letsencrypt_x.x.x-x_all.deb testing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15587 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15303 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 [Bug 15303] Letsencrypt option for Debian package installations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 09:47:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 08:47:36 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15587 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15587 [Bug 15587] Unstable letsencrypt_x.x.x-x_all.deb testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 09:47:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 08:47:43 +0000 Subject: [Koha-bugs] [Bug 15587] Unstable letsencrypt_x.x.x-x_all.deb testing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15587 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 10:08:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 09:08:41 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #25 from Mirko Tietgen --- Created attachment 46742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46742&action=edit Bug 15303 Use --staging during development to circumvent limits The --staging parameter uses the LE test server. This is only for testing, not supposed to go into master, no signoff needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 10:53:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 09:53:24 +0000 Subject: [Koha-bugs] [Bug 13552] Added: debarredcomment and debarreddate in batch patrons modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 12:52:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 11:52:13 +0000 Subject: [Koha-bugs] [Bug 15587] Unstable letsencrypt_x.x.x-x_all.deb testing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15587 --- Comment #1 from Mirko Tietgen --- Created attachment 46743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46743&action=edit Bug 15587 Unstable letsencrypt_x.x.x-x_all.deb testing Apply on top of bug 15303! * only one commandline parameter left: ** --letsencrypt replaces --force-https: use LE ** old --letsencrypt (folder path) obsolete * dependency: letsencrypt debian package Test plan: - apply bug 15303 - apply this patch - enable debian unstable repository - install package letsencrypt and dependencies - remove debian unstable repository - create koha instance koha-create --create-db --letsencrypt - follow test plan on bug 15303 where applicable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 13:30:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 12:30:43 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 --- Comment #3 from Kyle M Hall --- (In reply to Owen Leonard from comment #2) I think we can establish right now that we can't change the shelf holds behavior. It has been this way so long that it is a fundamental part of how Koha works. We can however, add an alternative. I think the basic issue is that shelfholds = no and allow_hold_if_items_available are fundamentally at odss with each other and should be mutually exclusive. I had though to somehow extend shelfholds, but it's inner workings are completely different than what is needed for allow_hold_if_items_available. It *would* be possible for an additional option in on shelf holds allowed, so the choices would be: Yes Only if at least one item is unavailable Only if all itmes are unavailble This would require a bit more code, changing all the shelfhold checks from if $shelfholds to if $shelfholds == 1, but that isn't too onerous a change. Then I could remove my new rule and use the existing shelfholds rule for the new logic code. How does that sound Owen? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 13:37:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 12:37:44 +0000 Subject: [Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 13:39:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 12:39:52 +0000 Subject: [Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Kyle M Hall --- I'm having no trouble applying the patch. Did you apply it's dependency ( Bug 15532 ) first? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 22:56:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 21:56:36 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #26 from Mirko Tietgen --- Bug 15587 changes the commandline parameter. I will merge both bugs together, otherwise it's confusing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 16 23:00:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 22:00:39 +0000 Subject: [Koha-bugs] [Bug 15587] Unstable letsencrypt_x.x.x-x_all.deb testing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15587 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46743|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 46744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46744&action=edit Bug 15587 Unstable letsencrypt_x.x.x-x_all.deb testing Apply on top of bug 15303! * only one commandline parameter left: ** --letsencrypt replaces --force-https: use LE ** old --letsencrypt (folder path) obsolete * dependency: letsencrypt debian package Test plan: - apply bug 15303 - apply this patch - build a package - test in disposable vm, we're mixing releases - install koha-common unstable and dependencies - enable debian unstable repository - install package letsencrypt and dependencies - remove debian unstable repository - create koha instance koha-create --create-db --letsencrypt - follow test plan on bug 15303 where applicable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 00:17:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 23:17:46 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #27 from Mirko Tietgen --- Created attachment 46745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46745&action=edit Bug 15303 LE production server Deletes the --staging option of the letsencrypt command to get real certificates. Rate limits apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 00:18:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 23:18:59 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46617|0 |1 is obsolete| | --- Comment #28 from Mirko Tietgen --- Created attachment 46746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46746&action=edit Bug 15303 Letsencrypt option for Debian package installations New option koha-create --letsencrypt - installs the letsencrypt package if needed - creates - generates letsencrypt certificates for - sets up a https-only website for - redirects http to https for ! letsencrypt and dependencies are only available in debian unstable right now ! but koha-common does not work in debian unstable, so you cannot test there ! apply the "Workaround" patch to test without letsencrypt package ! this patch uses the letsencrypt staging server ! to create real certificates, apply thy "LE production server" patch Test plan: - build a debian package with patch applied - use apache mod_ssl sudo a2enmod ssl - make sure the machine is accessible on 80 (needed for letsencrypt) and 443 from the internet - install koha with your new package - Put your (existing) domain options in /etc/koha/koha-sites.conf - use koha-create with the new options: sudo koha-create --create-db --letsencrypt - if you do not have the letsencrypt package installed, you will be prompted to do that [ as long as there is no package available, a symlink to the git checkout will work ] - wait until setup is finished, check that you got a working OPAC and staff client with certificates - check that http redirects to https -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 00:19:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 23:19:12 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46742|0 |1 is obsolete| | --- Comment #29 from Mirko Tietgen --- Created attachment 46747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46747&action=edit Bug 15303 Workaround to use git ckeckout The Debian package letsencrypt is only available in unstable at the moment. To test without letsencrypt package: - apply this patch before you build the package - on the test vm/server: -- get letsencrypt via git git clone https://github.com/letsencrypt/letsencrypt -- create a symlink from /usr/bin/letsencrypt to letsencrypt-auto sudo ln -s /path/to/letsencrypt/letsencrypt-auto /usr/bin/letsencrypt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 00:19:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 23:19:18 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46745|0 |1 is obsolete| | --- Comment #30 from Mirko Tietgen --- Created attachment 46748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46748&action=edit Bug 15303 LE production server Deletes the --staging option of the letsencrypt command to get real certificates. Rate limits apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 00:28:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 23:28:16 +0000 Subject: [Koha-bugs] [Bug 15587] Unstable letsencrypt_x.x.x-x_all.deb testing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15587 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #3 from Mirko Tietgen --- Merged into bug 15303 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 00:36:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 23:36:31 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46746|0 |1 is obsolete| | --- Comment #31 from Mirko Tietgen --- Created attachment 46749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46749&action=edit Bug 15303 Letsencrypt option for Debian package installations New option koha-create --letsencrypt - installs the letsencrypt package if needed - creates - generates letsencrypt certificates for - sets up a https-only website for - redirects http to https for ! letsencrypt and dependencies are only available in debian unstable right now ! but koha-common does not work in debian unstable, so you cannot test there ! apply the "Workaround" patch to test without letsencrypt package ! this patch uses the letsencrypt staging server ! to create real certificates, apply thy "LE production server" patch Test plan: - build a debian package with patch applied - use apache mod_ssl sudo a2enmod ssl - make sure the machine is accessible on 80 (needed for letsencrypt) and 443 from the internet - install koha with your new package - Put your (existing) domain options in /etc/koha/koha-sites.conf - use koha-create with the new options: sudo koha-create --create-db --letsencrypt - if you do not have the letsencrypt package installed, you will be prompted to do that [ as long as there is no package available, a symlink to the git checkout will work ] - wait until setup is finished, check that you got a working OPAC and staff client with certificates - check that http redirects to https Bug 15303 Recreate accidentally deleted C4/Auth_cas_servers.yaml.orig -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 00:36:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 23:36:38 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46747|0 |1 is obsolete| | --- Comment #32 from Mirko Tietgen --- Created attachment 46750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46750&action=edit Bug 15303 Workaround to use git ckeckout The Debian package letsencrypt is only available in unstable at the moment. To test without letsencrypt package: - apply this patch before you build the package - on the test vm/server: -- get letsencrypt via git git clone https://github.com/letsencrypt/letsencrypt -- create a symlink from /usr/bin/letsencrypt to letsencrypt-auto sudo ln -s /path/to/letsencrypt/letsencrypt-auto /usr/bin/letsencrypt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 00:36:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 23:36:44 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46748|0 |1 is obsolete| | --- Comment #33 from Mirko Tietgen --- Created attachment 46751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46751&action=edit Bug 15303 LE production server Deletes the --staging option of the letsencrypt command to get real certificates. Rate limits apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 00:42:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jan 2016 23:42:21 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #34 from Mirko Tietgen --- Created attachment 46752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46752&action=edit Bug 15303 Followup: apache port 80 servername/alias and typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 02:52:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 01:52:22 +0000 Subject: [Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 02:52:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 01:52:25 +0000 Subject: [Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46461|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 46753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46753&action=edit [SIGNED-OFF]Bug 15532: Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold Some libraries would like to be able to limit hold filling to items that match the pickup library for a hold based on the item's home or holding library. The patron's home library should not affect whether a patron can place the hold, instead the hold will only be fillable when an item matching the pickup location becomes available. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Note the new "Hold pickup library match" rules for "checkout, hold, and return policy" and for "holds policy by item type" 4) Set the policy to "item's holding library" 5) Place a hold where the item's holding branch does not match the pickup branch 6) Check in the item 7) Note it is not trapped for the hold 8) Update the item's holding branch to match the pickup branch 8) Check in the item 9) Note the item is trapped for the hold 10) Repeat steps 4-9 but for home branch instead Signed-off-by: Hector Castro Works as described -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 02:55:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 01:55:38 +0000 Subject: [Koha-bugs] [Bug 15533] Allow patrons and librarians to select itemtype when placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15533 --- Comment #5 from H?ctor Eduardo Castro Avalos --- (In reply to Kyle M Hall from comment #4) > I'm having no trouble applying the patch. Did you apply it's dependency ( > Bug 15532 ) first? You're right, patch apply without trouble -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 03:20:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 02:20:23 +0000 Subject: [Koha-bugs] [Bug 9754] koha-remove optionally includes var/lib and var/spool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 03:20:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 02:20:27 +0000 Subject: [Koha-bugs] [Bug 9754] koha-remove optionally includes var/lib and var/spool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46648|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 46754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46754&action=edit Bug 9754: koha-remove optionally includes var/lib and var/spool Currently, the files in the folder /var/lib/koha/[instance] and also in /var/spool/koha/[instance] are not removed. This patch adds the option -p|--purge-all to include those two directories when removing files. Note: There was a small bug in the for loop. On the -k line the extra shift statement is one too much. NOTE: Verify that you use the adjusted koha-remove in the test plan and not accidentally an older version of this script. Test plan: [1] Create an instance test. [2] Run koha-remove and verify that /var/lib/koha/test still exists. [3] Create an instance test2. [4] Run koha-remove -k -p and verify that the sql database still exists but the two instance folders in var/lib/koha and var/spool/koha are gone. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 03:46:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 02:46:26 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46311|0 |1 is obsolete| | --- Comment #17 from Chris Cormack --- Created attachment 46755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46755&action=edit Bug 4941: Make tests non DB dependent Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 03:47:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 02:47:49 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46312|0 |1 is obsolete| | --- Comment #18 from Chris Cormack --- Created attachment 46756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46756&action=edit Bug 4941: DB Changes Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 03:48:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 02:48:08 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 03:48:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 02:48:12 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46313|0 |1 is obsolete| | --- Comment #19 from Chris Cormack --- Created attachment 46757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46757&action=edit Bug 4941: Remove the singleBranchMode system preference The singleBranchMode system preference does not make sense. Either the install has only 1 library defined or several. In both case, we can easily guess the behavior to follow. So the idea of this patch is to replace the fetch of this syspref with a call to count the number of libraries defined in DB. Test plan: 1/ From a fresh Koha install, execute the DB entry to remove the pref. 2/ Define only 1 library 3/ Confirm that Koha behaves the same as before (try to change your library, look at the facets) 4/ Create another library (or more) and reinsert the pref and set it: insert into systempreferences (variable, value) values('singleBranchMode', 1); 5/ Execute the DB entry You should get a warning message. 6/ Repeat 3. Signed-off-by: Chris Cormack Does what it says, but will change behaviour for any Koha install that has 2 branches defined, One circulation, and this preference set. If that is an acceptable change, we might need to make sure this is noted well in the release notes. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 07:49:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 06:49:56 +0000 Subject: [Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 07:50:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 06:50:00 +0000 Subject: [Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46668|0 |1 is obsolete| | --- Comment #9 from Chris Cormack --- Created attachment 46758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46758&action=edit Bug 1983: Checkout: Hold repquest when checking out an item already on loan or reserved This patch allows to put a hold on an item that is already checked out or reserved. To test: - Check out an item A - Put a hold on an item B - Verify that the staff user has permission to put holds - Check out item A to a patron X - Try to checkout item A to a patron Y - Verify that you see underneath the buttons for Checkin/Checkout a link with following text: "Click here to place hold for [Patron X' name]" - Verify that the link is stylable (div class circ-scheckoutplacehold) - Verify that the link takes you to the page to place a hold on this biblio for patron Y - Do the same for item B and verify that it works for reserved items as well. - Repeat steps above for a patron who has restrictions, verify that the link does not appear - Log in with a staff member who has no permission to place holds - Repeat steps above for a patron without restrictions, verify that the link does not appear. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 08:07:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 07:07:09 +0000 Subject: [Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 08:07:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 07:07:12 +0000 Subject: [Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46589|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 46759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46759&action=edit Bug 14849: Add foreign key on uploaded_files.owner uploaded_files.owner refers to a borrowernumber, the DB structure should reflect this constraint. Test plan: 0/ Do not execute the update DB entry 1/ Add a new patron 2/ Use this patron to upload a new file 3/ In the uploaded_files you should see that the owner value is the borrowernumber of the newly created patron 4/ Execute the DB entry 5/ The uploaded_files.owner value should have been set to NULL 6/ Repeat 1, 2 and 3 7/ Delete the patron 5/ The uploaded_files.owner value should have been set to NULL Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 17 23:19:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 22:19:28 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 --- Comment #8 from David Cook --- Yeah, that might be tough to add to the manual. Prior to this patch, only the 952$u had an index with a "u" (ie url) register, and that's only accessible using "st-urx" as a CCL qualifier. Actually, in the future, I'd like to add the 856$u to the "url:u" index as well. I suppose that might be added to the manual... saying that "url,st-urx" will let you look up URLs in the 952$u and 856$u. I've had some people ask in the past about easy ways to find records with URLs and that would do it... But yeah. Not sure about the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 00:41:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 23:41:31 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #290 from Katrin Fischer --- Add Martin Renvoize to QA team for 3.24 (see General_IRC_meeting_13_January_2016) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 00:41:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 23:41:42 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 00:43:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 23:43:57 +0000 Subject: [Koha-bugs] [Bug 15468] Search links on callnumber fails on opac results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 00:46:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 23:46:07 +0000 Subject: [Koha-bugs] [Bug 15460] Bug 13381 accidentally removed spaces after subfields c and h of 245 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |Academy --- Comment #1 from Katrin Fischer --- Some examples for testing can be found here: http://www.loc.gov/marc/bibliographic/bd245.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 00:48:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 23:48:24 +0000 Subject: [Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 00:50:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 23:50:13 +0000 Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and volumne information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 00:54:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 23:54:13 +0000 Subject: [Koha-bugs] [Bug 15298] z39.50 admin setup, options column suggested changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 00:55:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 23:55:34 +0000 Subject: [Koha-bugs] [Bug 15195] patron details should open in tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15195 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 00:57:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 23:57:24 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #2 from Katrin Fischer --- System preference needs to be reworded or behaviour fixed :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 00:58:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 23:58:26 +0000 Subject: [Koha-bugs] [Bug 14810] Improve messages in patron anonymizing tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #1 from Katrin Fischer --- Some nice rewording would be good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 00:59:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jan 2016 23:59:40 +0000 Subject: [Koha-bugs] [Bug 14624] <> for advance_notices.pl wrongly documented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #1 from Katrin Fischer --- The documentation of the script and how it works don't match up - we should fix the documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 01:00:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 00:00:14 +0000 Subject: [Koha-bugs] [Bug 14613] Send cart window is too small in staff and hides 'send' button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14613 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 01:00:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 00:00:51 +0000 Subject: [Koha-bugs] [Bug 14538] POD for CalcFine is incomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14538 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 01:02:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 00:02:12 +0000 Subject: [Koha-bugs] [Bug 14535] Late orders doensn't show orders with price = 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #1 from Katrin Fischer --- 129 AND aqorders.rrp <> 0 130 AND aqorders.ecost <> 0 Appear to be the reason for the orders not showing up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 01:04:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 00:04:20 +0000 Subject: [Koha-bugs] [Bug 14406] When adding messages in patron account, only first name is shown in pull down In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14406 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #1 from Katrin Fischer --- ... should have read: I think this _is_ unusual ... :) Libraries have been irritated by the first name for the patron in the pull down. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 01:07:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 00:07:00 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #1 from Katrin Fischer --- This is a bit tricky, but maybe someone has an idea :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 01:10:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 00:10:57 +0000 Subject: [Koha-bugs] [Bug 10881] Fast Add Framework has different item fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10881 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #3 from Katrin Fischer --- Picking only important item subfields for a shorter Fast Add form would be nice! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 01:20:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 00:20:39 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 01:34:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 00:34:28 +0000 Subject: [Koha-bugs] [Bug 15579] records_batchmod permission doesn't allow access to batch modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Nicole, can you try and remove the batchmod_restricted permission for a test? Is the syspref set? Is the 'no permission' page showing or is it not usable in another way? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 01:53:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 00:53:02 +0000 Subject: [Koha-bugs] [Bug 15559] Software error: Wide character in subroutine entry at /usr/share/perl5/MARC/Charset/Table.pm line 96. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15559 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Software error: Wide |Software error: Wide |character in subroutine |character in subroutine |entry at |entry at |/usr/share/perl5/MARC/Chars |/usr/share/perl5/MARC/Chars |et/Table.pm line 96. For |et/Table.pm line 96. |help, please send mail to | |the webmaster ([no address | |given]), giving this error | |message and the time and | |date of the error | CC| |katrin.fischer at bsz-bw.de, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 02:00:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 01:00:52 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |Academy --- Comment #1 from Katrin Fischer --- Adding a check for the permission in the template should work here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 02:02:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 01:02:11 +0000 Subject: [Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |h.meissner.82 at web.de, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 03:50:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 02:50:14 +0000 Subject: [Koha-bugs] [Bug 15575] opac-authorities-home.pl broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15575 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Aleisha Amohia --- I am not getting this error anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 04:27:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 03:27:12 +0000 Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 04:27:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 03:27:15 +0000 Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 --- Comment #1 from Aleisha Amohia --- Created attachment 46760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46760&action=edit Bug 15415: Warn when creating a new print profile This warn is hard-coded in Profile.pm sub get_attr { my $self = shift; if (_check_params(@_) eq 1) { return -1; } my ($attr) = @_; if (exists($self->{$attr})) { return $self->{$attr}; } else { warn sprintf('%s is currently undefined.', $attr); <-- THIS LINE return -1; } } So I have removed this line because I don't think it's really necessary. To test: 1) Go to Tools -> Patron Card Creator -> New printer profile 2) Notice warn 3) Apply patch 4) Refresh page 5) Confirm warn is gone and page still works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 04:32:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 03:32:58 +0000 Subject: [Koha-bugs] [Bug 15416] Warns on Guided Reports page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 04:33:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 03:33:01 +0000 Subject: [Koha-bugs] [Bug 15416] Warns on Guided Reports page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416 --- Comment #1 from Aleisha Amohia --- Created attachment 46761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46761&action=edit Bug 15416: Warns on guided_reports.pl Initialising $phase variable to be '' if not defined. To test: 1) Go to Reports -> Guided Reports Wizard 2) Notice warns 3) Apply patch 4) Refresh page 5) Confirm warns are gone and page still works as it should -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 04:58:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 03:58:35 +0000 Subject: [Koha-bugs] [Bug 15440] EnhancedMessagingPreferences syspref causing warns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15440 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Aleisha Amohia --- Am no longer getting this problem! Must be fixed. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 05:41:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 04:41:04 +0000 Subject: [Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #11 from David Cook --- Hmm, I don't seem to be getting the emails about comments... I agree that I should add a system preference in this case. I've also followed up Galen's emails on koha-devel regarding OAI-PMH, and I think I'm going to go a different route, which makes this bug and its patches irrelevant for bug 10662. Resetting this bug to assigned, although I'm in no rush to finish this bug due to the change in direction of bug 10662. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 05:43:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 04:43:52 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 --- Comment #9 from David Cook --- Actually, regarding the manual, I'm tempted to personally write up an appendix regarding searching in Koha using CCL... but I'm not sure when that's going to happen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 05:44:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 04:44:40 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 --- Comment #10 from David Cook --- It would also be a bit advanced, as I would need to get into the stuff about the "p", "n", "w", and "u" registers for it to make complete sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 05:48:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 04:48:59 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Create additional |Prevent normalization |normalizers for Record |during matching/import |Matching Rules |process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 07:13:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 06:13:28 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #3 from David Cook --- This is turning out to be harder than expected... In C4::Matcher::get_matches, it creates a query like "qualifier,qualifier:value" for QP, or "qualifier,qualifier=value" for non-QP. That's OK... but in C4::Search::SimpleSearch, QP gets turned off by "qualifier,qualifier" so it becomes a non-QP query... but it's created with a ":" instead of a "=". This matters because we need a "=" instead of a ":" for the non-QP query... and we can't wholesale change ":" to "=" because of the URL syntax required by the URL register... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:00:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:00:16 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #12 from Katrin Fischer --- Hm, dependencies are pushed to master, but patch doesn't apply for me: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15568: Fix display default circ rules fatal: sha1 information is lacking or useless (admin/smart-rules.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:06:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:06:50 +0000 Subject: [Koha-bugs] [Bug 15570] circ/renew.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:06:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:06:53 +0000 Subject: [Koha-bugs] [Bug 15570] circ/renew.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46660|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 46762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46762&action=edit [PASSED QA] Bug 15570: (follow-up) Bug 11944 Remove all utf8 filter from templates Test plan: use circ/renew.pl to renew an issue. Without this patch, you will get an error. Note: The error exists for 1 year now and nobody complained?? Does someone still use this script? Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:07:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:07:38 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |gmcharlt at gmail.com |y.org | Component|Architecture, internals, |Test Suite |and plumbing | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:09:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:09:09 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:09:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:09:12 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46740|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 46763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46763&action=edit [PASSED QA] Bug 15586 - References to Koha::Branches remain in unit tests The unit tests BiblioObject.t and Hold.t still have references to Koha::Branches that need to be changed to Koha::Libraries. These tests currently fail because of this. Test Plan: 1) prove t/db_dependent/BiblioObject.t should fail 2) prove t/db_dependent/Hold.t should fail 3) Apply this patch 1) prove t/db_dependent/BiblioObject.t should pass 2) prove t/db_dependent/Hold.t should pass Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:17:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:17:41 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:17:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:17:44 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46483|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 46764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46764&action=edit [PASSED QA] Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:24:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:24:37 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #111 from Katrin Fischer --- Hi Jonathan, working on this again - can you please update your branch to master once more? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:29:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:29:05 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #112 from Katrin Fischer --- Retesting the issues found last time: - HTML printer slips work perfectly now - HTML tags in restriction/debarment comments show ... and while you are on it, could you please add my sign off lines as well? :) I am going to obsolete the patches here for now, to avoid confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:29:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:29:59 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #113 from Katrin Fischer --- Works partially - the restriction message on top of the patron account is ok. The entries in the little restrictions table inside the tab still appear broken - on the details and checkout tabs and also when editing a patron.variables - intra -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:30:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:30:02 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41347|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:30:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:30:06 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42054|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:30:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:30:09 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42087|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:30:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:30:12 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41353|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:30:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:30:15 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41354|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:30:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:30:22 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42092|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:30:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:30:19 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42091|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:30:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:30:25 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42094|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:30:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:30:28 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42095|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:30:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:30:31 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42096|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:30:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:30:34 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41747|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:30:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:30:37 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42075|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:30:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:30:41 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42090|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:30:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:30:44 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42078|Bug 13618: Specific places |Bug 13618: Specific places description|where we don't need to |where we don't need to |escape |escape | variables - intra | variables - intra Attachment #42078|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:31:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:31:41 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42097|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:31:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:31:45 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45788|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:31:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:31:48 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45141|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 08:48:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 07:48:15 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally require notes when placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #6 from Marcel de Rooy --- (In reply to Owen Leonard from comment #5) > Would the need for this feature be eliminated if it was possible to limit > item-level holds to the types of records defined in this patch? That is, > serials, titles with volumes, etc? > > If so, shouldn't we be solving that problem instead? We still feel the need for this feature in that case. As long as our data is not perfect (and all issuable materials have been split in the items table), we still want the user to say what he really needs instead of collecting the whole set. To illustrate: a multipart with 2 items a-d,e-h (which should indeed be 8 items). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 09:24:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 08:24:11 +0000 Subject: [Koha-bugs] [Bug 14834] Make membership_expiry cronjob more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14834 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add range parameters to |Make membership_expiry |membership_expiry cronjob |cronjob more flexible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 09:58:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 08:58:30 +0000 Subject: [Koha-bugs] [Bug 14834] Make membership_expiry cronjob more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14834 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 09:58:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 08:58:32 +0000 Subject: [Koha-bugs] [Bug 14834] Make membership_expiry cronjob more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14834 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42650|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 46765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46765&action=edit Bug 14834: Make membership_expiry cronjob more flexible This patch adds three parameters to the cron job: -before and -after, and -branch. You can run the cronjob now in an adjusted frequency: say once a week with before 6 or after 6 (not both together). If your pref is set to 14, running before=6 will include expiries from 8 days to 14 days ahead. When you use after=6, you would include 14 days to 20 days ahead, etc. You could also rerun the job of yesterday by setting before=1 and after=-1; this could help in case of problem recovery. Obviously, the branch parameter can be used as a filter. NOTE: Why are these parameters passed only via the command line? Well, obviously the branch parameter is not suitable for a pref. The before/after parameter allows you to handle expiry mails different from the normal scheme or could be used in some sort of recovery. In those cases it will be more practical to use a command line parameter than editing a pref. NOTE: The unit test has been adjusted for the above reasons, but I also added some lines to let existing expires not interfere with the added borrowers by an additional count and using the branchcode parameter. Test plan: [1] Run the adjusted unit test GetUpcomingMembershipExpires.t [2] Set the expiry date for patron A to now+16 (with pref 14). Set the expiry date for patron B to now+11. [3] Run the cronjob without range. You should not see A and B. [4] Run the cronjob with before 3. You should see patron B. [5] Run the cronjob with before 3 and after 2. You should see A and B. [6] Repeat step 5 with a branchcode that does not exist. No patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 11:39:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 10:39:41 +0000 Subject: [Koha-bugs] [Bug 15588] New: C4::Fonts, introduce a package to work with enabled fonts. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15588 Bug ID: 15588 Summary: C4::Fonts, introduce a package to work with enabled fonts. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 11:45:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 10:45:59 +0000 Subject: [Koha-bugs] [Bug 15482] Koha does not like the full-width commercial character in an email address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15482 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 11:45:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 10:45:50 +0000 Subject: [Koha-bugs] [Bug 15482] Koha does not like the full-width commercial character in an email address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15482 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Marcel de Rooy --- This does not apply anymore to master. It is not possible in opac and staff to put this email address in the patron record. (This check was not in older versions of Koha.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 11:55:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 10:55:03 +0000 Subject: [Koha-bugs] [Bug 15543] Use another notice in membership_expiry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15543 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add another option to |Use another notice in |membership_expiry.pl |membership_expiry.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:12:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:12:53 +0000 Subject: [Koha-bugs] [Bug 15543] Use another notice in membership_expiry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15543 --- Comment #1 from Marcel de Rooy --- Created attachment 46766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46766&action=edit Bug 15543: Use another notice in membership_expiry.pl This patch adds a letter parameter to the cron job membership_expiry. It is used to substitute the default notice by another one. This could be handy if you e.g. send a reminder after the first notice. In any case, it allows for more flexibility. Apart from this new parameter, this patch removes the sub parse_letter from the code. The call to GetPreparedLetter is moved to the for loop and the call to getletter is removed (no longer needed). If there is no letter found, the Letter module already warns you. So we just exit the loop. Test plan: [1] Run membership_expiry.pl -c -n -v -let NOT_EXIST Check if you see a warning (coming from Letters.pm) [2] Check if you have some soon expiring patrons or add before/after parameter to include some. Run membership_expiry.pl -c -n -v [-before ?] [-after ?] [3] Create a new notice MEMBERSHIP2. Copy the text from the original notice and make some adjustments. [4] Run membership_expiry.pl -c -v -let MEMBERSHIP2 [-before ?] [-after ?]. Be aware that this call generates email messages. Verify that the email contained the adjusted text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:12:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:12:51 +0000 Subject: [Koha-bugs] [Bug 15543] Use another notice in membership_expiry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15543 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:18:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:18:51 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #114 from Jonathan Druart --- Created attachment 46767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46767&action=edit Bug 13618: Use Template::Stash::AutoEscaping to use the html filter Test plan: 0/ sudo cpanm Template::Stash::AutoEscaping 1/ Verify don't reproduce the XSS issue described on bug 13609 and other xss related bugs. 2/ Try to find some encoding issues (detail page, search results, facets, etc.) Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:18:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:18:57 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #115 from Jonathan Druart --- Created attachment 46768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46768&action=edit Bug 13618: Remove html filters at the OPAC This patch removes the html filters at the OPAC, if necessary. Generated with: perl -p -i -e 's/\ ?\|\ ?html(\ ?)%/\1%/g' **/*.tt **/*.inc Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:19:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:19:02 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #116 from Jonathan Druart --- Created attachment 46769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46769&action=edit Bug 13618: Specific places where we don't need to escape variables There is no need to escape the html generated by the XSLT. Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:19:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:19:08 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #117 from Jonathan Druart --- Created attachment 46770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46770&action=edit Bug 13618: Remove html filters at the intranet Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:19:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:19:13 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #118 from Jonathan Druart --- Created attachment 46771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46771&action=edit Bug 13618: Specific places where we don't need to escape variables - intra Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:19:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:19:17 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #119 from Jonathan Druart --- Created attachment 46772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46772&action=edit Bug 13618: Specific for pagination_bar Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:19:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:19:21 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #120 from Jonathan Druart --- Created attachment 46773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46773&action=edit Bug 13618: Specific for the ISBD view Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:19:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:19:26 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #121 from Jonathan Druart --- Created attachment 46774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46774&action=edit Bug 13618: Fix error 'Not a GLOB reference' The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. The easier fix is to replace it with a SWITCH. Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:19:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:19:32 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #122 from Jonathan Druart --- Created attachment 46775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46775&action=edit Bug 13618: Specific for IntranetUser* and OPACUser* prefs Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:19:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:19:36 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #123 from Jonathan Druart --- Created attachment 46776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46776&action=edit Bug 13618: Specific for ColumnsSettings Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:19:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:19:41 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #124 from Jonathan Druart --- Created attachment 46777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46777&action=edit Bug 13618 - memberentrygen.tt errors Not a GLOB reference Like Jonathan said: The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. Replaced it with a SWITCH, like the other patch for this similar error. Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:19:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:19:45 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #125 from Jonathan Druart --- Created attachment 46778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46778&action=edit Bug 13618: Specific for other prefs opacmainuserblock opacnav opacnavright opaccredits opacheader opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:19:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:19:50 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #126 from Jonathan Druart --- Created attachment 46779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46779&action=edit Bug 13618: Specific for Salutation on editing a patron Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:19:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:19:54 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #127 from Jonathan Druart --- Created attachment 46780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46780&action=edit Bug 13618: Specific for XSLTBloc Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:19:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:19:58 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #128 from Jonathan Druart --- Created attachment 46781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46781&action=edit Bug 13618: Fix escape on sending baskets or shelves by email Test plan: Send baskets and shelves by email. With or without this patch, you should not see any changes. Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:20:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:20:03 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #129 from Jonathan Druart --- Created attachment 46782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46782&action=edit Bug 13618: Fix for news Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:20:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:20:07 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #130 from Jonathan Druart --- Created attachment 46783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46783&action=edit Bug 13618: Fix last occurrences recently introduced to master Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:20:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:20:12 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #131 from Jonathan Druart --- Created attachment 46784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46784&action=edit Bug 13618: followup to remove tabs Signed-off-by: Bernardo Gonzalez Kriegel This followup on top of remote branch Only remove tabs and trailing spaces to make koha-qa pass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:20:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:20:17 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #132 from Jonathan Druart --- Created attachment 46785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46785&action=edit Bug 13618: Fix for edit biblios and items On editing biblios or items, the marc_lib, marc_value and javascript values are often populated with html code which needs to be displayed raw. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:20:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:20:22 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #133 from Jonathan Druart --- Created attachment 46786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46786&action=edit Bug 13618: (follow-up) Specific for ColumnsSettings Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:20:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:20:26 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #134 from Jonathan Druart --- Created attachment 46787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46787&action=edit Bug 13618: (follow-up) add missing lines for opac-shelves Proposed patch to fix opac-shelves Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:20:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:20:37 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #136 from Jonathan Druart --- Created attachment 46789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46789&action=edit Bug 13618: Fix for system preference description If a syspref description contains html tag, do not display them Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:20:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:20:32 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #135 from Jonathan Druart --- Created attachment 46788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46788&action=edit Bug 13618: Remove html filters for newly pushed code Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:20:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:20:42 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #137 from Jonathan Druart --- Created attachment 46790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46790&action=edit Bug 13618: Do not display   and html tags in item fields content Note that there might be other occurrences to fix! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:20:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:20:47 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #138 from Jonathan Druart --- Created attachment 46791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46791&action=edit Bug 13618: Do not display html tags in patron's notices Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:20:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:20:51 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #139 from Jonathan Druart --- Created attachment 46792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46792&action=edit Bug 13618: Fix for debarredcomment and patron messages At the OPAC and intranet. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:20:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:20:57 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #140 from Jonathan Druart --- Created attachment 46793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46793&action=edit Bug 13618: (follow-up) Specific for other prefs follow-up for SlipCSS and printslip Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:21:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:21:02 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #141 from Jonathan Druart --- Created attachment 46794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46794&action=edit Bug 13618: Specific for branches.opac_info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:23:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:23:15 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #142 from Jonathan Druart --- (In reply to Katrin Fischer from comment #112) > Retesting the issues found last time: > - HTML printer slips work perfectly now > - HTML tags in restriction/debarment comments show > > ... and while you are on it, could you please add my sign off lines as well? > :) > > I am going to obsolete the patches here for now, to avoid confusion. I have added your signed-off-by line, attached the patches from the remote branch on this bug report and attached a new patch (found a bug when rebasing). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:30:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:30:20 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 --- Comment #13 from Jonathan Druart --- (In reply to Katrin Fischer from comment #12) > Hm, dependencies are pushed to master, but patch doesn't apply for me: You must apply the last patch on bug 15295, not pushed to master yet. [SIGNED-OFF] Bug 15295: (follow-up) Koha::Libraries - Remove GetBranchesCount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:30:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:30:29 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:33:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:33:17 +0000 Subject: [Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11557 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11557 [Bug 11557] Collector bug for Academy bootstrap3 upgrading work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:33:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:33:17 +0000 Subject: [Koha-bugs] [Bug 11557] Collector bug for Academy bootstrap3 upgrading work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on|15581, 15582 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 [Bug 15581] Add a circ rule to limit the auto renewals given a delay http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:33:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:33:17 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11557 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11557 [Bug 11557] Collector bug for Academy bootstrap3 upgrading work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:35:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:35:03 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 --- Comment #14 from Katrin Fischer --- Tricky! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:44:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:44:36 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46767|0 |1 is obsolete| | --- Comment #143 from Jonathan Druart --- Created attachment 46795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46795&action=edit Bug 13618: Use Template::Stash::AutoEscaping to use the html filter Test plan: 0/ sudo cpanm Template::Stash::AutoEscaping 1/ Verify don't reproduce the XSS issue described on bug 13609 and other xss related bugs. 2/ Try to find some encoding issues (detail page, search results, facets, etc.) Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:44:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:44:41 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46768|0 |1 is obsolete| | --- Comment #144 from Jonathan Druart --- Created attachment 46796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46796&action=edit Bug 13618: Remove html filters at the OPAC This patch removes the html filters at the OPAC, if necessary. Generated with: perl -p -i -e 's/\ ?\|\ ?html(\ ?)%/\1%/g' **/*.tt **/*.inc Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:44:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:44:45 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46769|0 |1 is obsolete| | --- Comment #145 from Jonathan Druart --- Created attachment 46797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46797&action=edit Bug 13618: Specific places where we don't need to escape variables There is no need to escape the html generated by the XSLT. Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:44:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:44:51 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46770|0 |1 is obsolete| | --- Comment #146 from Jonathan Druart --- Created attachment 46798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46798&action=edit Bug 13618: Remove html filters at the intranet Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:44:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:44:55 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46771|0 |1 is obsolete| | --- Comment #147 from Jonathan Druart --- Created attachment 46799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46799&action=edit Bug 13618: Specific places where we don't need to escape variables - intra Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:44:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:44:59 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46772|0 |1 is obsolete| | --- Comment #148 from Jonathan Druart --- Created attachment 46800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46800&action=edit Bug 13618: Specific for pagination_bar Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:45:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:45:04 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46773|0 |1 is obsolete| | --- Comment #149 from Jonathan Druart --- Created attachment 46801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46801&action=edit Bug 13618: Specific for the ISBD view Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:45:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:45:08 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46774|0 |1 is obsolete| | --- Comment #150 from Jonathan Druart --- Created attachment 46802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46802&action=edit Bug 13618: Fix error 'Not a GLOB reference' The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. The easier fix is to replace it with a SWITCH. Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:45:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:45:13 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46775|0 |1 is obsolete| | --- Comment #151 from Jonathan Druart --- Created attachment 46803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46803&action=edit Bug 13618: Specific for IntranetUser* and OPACUser* prefs Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:45:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:45:17 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46776|0 |1 is obsolete| | --- Comment #152 from Jonathan Druart --- Created attachment 46804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46804&action=edit Bug 13618: Specific for ColumnsSettings Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:45:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:45:26 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46778|0 |1 is obsolete| | --- Comment #154 from Jonathan Druart --- Created attachment 46806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46806&action=edit Bug 13618: Specific for other prefs opacmainuserblock opacnav opacnavright opaccredits opacheader opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:45:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:45:22 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46777|0 |1 is obsolete| | --- Comment #153 from Jonathan Druart --- Created attachment 46805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46805&action=edit Bug 13618 - memberentrygen.tt errors Not a GLOB reference Like Jonathan said: The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. Replaced it with a SWITCH, like the other patch for this similar error. Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:45:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:45:30 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46779|0 |1 is obsolete| | --- Comment #155 from Jonathan Druart --- Created attachment 46807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46807&action=edit Bug 13618: Specific for Salutation on editing a patron Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:45:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:45:35 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46780|0 |1 is obsolete| | --- Comment #156 from Jonathan Druart --- Created attachment 46808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46808&action=edit Bug 13618: Specific for XSLTBloc Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:45:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:45:39 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46781|0 |1 is obsolete| | --- Comment #157 from Jonathan Druart --- Created attachment 46809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46809&action=edit Bug 13618: Fix escape on sending baskets or shelves by email Test plan: Send baskets and shelves by email. With or without this patch, you should not see any changes. Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:45:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:45:44 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46782|0 |1 is obsolete| | --- Comment #158 from Jonathan Druart --- Created attachment 46810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46810&action=edit Bug 13618: Fix for news Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:45:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:45:48 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46783|0 |1 is obsolete| | --- Comment #159 from Jonathan Druart --- Created attachment 46811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46811&action=edit Bug 13618: Fix last occurrences recently introduced to master Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:45:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:45:53 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46784|0 |1 is obsolete| | --- Comment #160 from Jonathan Druart --- Created attachment 46812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46812&action=edit Bug 13618: followup to remove tabs Signed-off-by: Bernardo Gonzalez Kriegel This followup on top of remote branch Only remove tabs and trailing spaces to make koha-qa pass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:45:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:45:58 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46785|0 |1 is obsolete| | --- Comment #161 from Jonathan Druart --- Created attachment 46813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46813&action=edit Bug 13618: Fix for edit biblios and items On editing biblios or items, the marc_lib, marc_value and javascript values are often populated with html code which needs to be displayed raw. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:46:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:46:02 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46786|0 |1 is obsolete| | --- Comment #162 from Jonathan Druart --- Created attachment 46814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46814&action=edit Bug 13618: (follow-up) Specific for ColumnsSettings Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:46:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:46:07 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46787|0 |1 is obsolete| | --- Comment #163 from Jonathan Druart --- Created attachment 46815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46815&action=edit Bug 13618: (follow-up) add missing lines for opac-shelves Proposed patch to fix opac-shelves Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:46:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:46:11 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46788|0 |1 is obsolete| | --- Comment #164 from Jonathan Druart --- Created attachment 46816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46816&action=edit Bug 13618: Remove html filters for newly pushed code Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:46:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:46:15 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46789|0 |1 is obsolete| | --- Comment #165 from Jonathan Druart --- Created attachment 46817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46817&action=edit Bug 13618: Fix for system preference description If a syspref description contains html tag, do not display them Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:46:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:46:20 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46790|0 |1 is obsolete| | --- Comment #166 from Jonathan Druart --- Created attachment 46818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46818&action=edit Bug 13618: Do not display   and html tags in item fields content Note that there might be other occurrences to fix! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:46:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:46:24 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46791|0 |1 is obsolete| | --- Comment #167 from Jonathan Druart --- Created attachment 46819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46819&action=edit Bug 13618: Do not display html tags in patron's notices Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:46:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:46:28 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46792|0 |1 is obsolete| | --- Comment #168 from Jonathan Druart --- Created attachment 46820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46820&action=edit Bug 13618: Fix for debarredcomment and patron messages At the OPAC and intranet. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:46:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:46:33 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46793|0 |1 is obsolete| | --- Comment #169 from Jonathan Druart --- Created attachment 46821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46821&action=edit Bug 13618: (follow-up) Specific for other prefs follow-up for SlipCSS and printslip Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 12:46:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 11:46:37 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46794|0 |1 is obsolete| | --- Comment #170 from Jonathan Druart --- Created attachment 46822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46822&action=edit Bug 13618: Specific for branches.opac_info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 13:40:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 12:40:49 +0000 Subject: [Koha-bugs] [Bug 15559] Software error: Wide character in subroutine entry at /usr/share/perl5/MARC/Charset/Table.pm line 96. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15559 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal OS|Windows |All CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Which version of Koha are you using? How did you install it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 13:41:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 12:41:16 +0000 Subject: [Koha-bugs] [Bug 15546] Software Error for all access to Label Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15546 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 13:51:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 12:51:06 +0000 Subject: [Koha-bugs] [Bug 10213] UniqueItemFields should be implemented for creating items in cataloguing and serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10213 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 13:51:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 12:51:24 +0000 Subject: [Koha-bugs] [Bug 10213] UniqueItemFields should be implemented for creating items in cataloguing and serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10213 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 13:51:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 12:51:31 +0000 Subject: [Koha-bugs] [Bug 15179] Marc field 084 does not show on bibliographic record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15179 Felix Hemme changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felix.hemme at thulb.uni-jena. | |de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 15:14:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 14:14:03 +0000 Subject: [Koha-bugs] [Bug 14294] Umbrella report for tracking improvements to File upload feature (see also 6874) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14294 --- Comment #6 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #5) > Bug 14686 should be the next point to address. I have been waiting quite a while now for bug 14893 now to move further. But it did not (yet). If you are interested in this development, please help by signing that one off ! Thanks in advance :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 15:15:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 14:15:25 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 --- Comment #4 from Marcel de Rooy --- Please help this lonely patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 17:56:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 16:56:45 +0000 Subject: [Koha-bugs] [Bug 14489] Software error when trying to create new batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14489 Xoxo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egzoni_a94 at hotmail.com --- Comment #5 from Xoxo --- How to make a solutions for this error? Can't locate object method "get_attr" via package "-2" (perhaps you forgot to load "-2"?) at /usr/share/koha/intranet/cgi-bin/patroncards/edit-batch.pl line 125. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 21:11:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 20:11:18 +0000 Subject: [Koha-bugs] [Bug 15589] New: OPAC Lists "his" string fix Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15589 Bug ID: 15589 Summary: OPAC Lists "his" string fix Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org When creating a new list (opac-shelves.pl), under permissions it says "Allow anyone to remove his own contributed entries." I don't think this should say 'his' - should be more gender neutral. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 21:12:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 20:12:11 +0000 Subject: [Koha-bugs] [Bug 15590] New: Next issue skipped if planned date is 1/1/2016 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15590 Bug ID: 15590 Summary: Next issue skipped if planned date is 1/1/2016 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Created attachment 46823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46823&action=edit subscription set up - see prediction A weekly serial is skipping over 1/1/2016 as a next issue date. See attached image. Expected issue goes from 12/25/15 to 1/8/16, bypassing 1/1/16 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 21:12:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 20:12:43 +0000 Subject: [Koha-bugs] [Bug 15590] Next issue skipped if planned date is 1/1/2016 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15590 --- Comment #1 from Joy Nelson --- Created attachment 46824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46824&action=edit Receiving an issue - see skipped date -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 21:15:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 20:15:40 +0000 Subject: [Koha-bugs] [Bug 15589] OPAC Lists "his" string fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15589 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 21:15:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 20:15:42 +0000 Subject: [Koha-bugs] [Bug 15589] OPAC Lists "his" string fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15589 --- Comment #1 from Aleisha Amohia --- Created attachment 46825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46825&action=edit Bug 15589: Changing 'his' to 'their' in OPAC lists To be more gender neutral To test: 1) Go to OPAC lists (opac-shelves.pl) 2) Confirm it now says "Allow anyone to remove their own contributed entries." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 21:29:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 20:29:12 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 21:43:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 20:43:10 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42866|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 46826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46826&action=edit Bug 14893: Separate temporary storage per instance in Upload.pm To make life easier when multiple instances are uploading temporary files to Koha, this patch adds the database name to the upload subfolder in your /tmp folder. Note: Although multiple instances could share the same subfolder for temporary storage (hashvalue is based on a timestamp too), it will be better to separate them for efficient housekeeping (removing older or partial files with a cronjob etc.) Since multiple instances come with separate permissions, keeping them in separate folders will be much simpler. Permanent storage is not affected by this patch. The location of permanent storage is ruled by the upload_path in each config file. Sharing that space is not recommended too. Although it may not be strictly necessary yet to remove files from the old temp storage folder (before the 3.22 release), the accompanying db rev performs that housekeeping task. Test plan: [1] Do not yet apply this patch. Upload a temporary file (use the tools/upload.pl script without selecting a category). [2] Check /tmp/koha_upload. [3] Apply this patch. Run the db rev with web installer. [4] Upload another temporary file. [5] Check /tmp for folder [your_database]_upload. [6] Check that /tmp/koha_upload is gone and the associated records too. [7] Run the adjusted t/db../Upload.t Followed test plan. Could not do steps before applying patch [1]-[2] (I suppose a local permission problem). After applying patch and updating db file appears in /tmp/[database] as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:13:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:13:09 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:13:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:13:12 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46697|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 46827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46827&action=edit [PASSED QA] Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:27:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:27:12 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Severity|enhancement |major CC| |magnus at libriotech.no --- Comment #6 from Magnus Enger --- As far as I can tell, this patch has been signed off by Marc V?ron - changing status accordingly. I think it is also an important bugfix, not an enhancement: I have a server with multiple instances running off the 3.22.1 Debian packages. After the upgrade from 3.20.x, a couple of sites were complaining that they could no longer upload local cover images. After some investigation it turns out that Koha was trying to save uploaded files temporarily in /tmp/koha_upload/, but this directory was owned by another Koha instance, with permissions "drwxr-xr-x", thus denying all other sites the ability to upload files. A per-instance temporary upload directory should fix this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:35:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:35:13 +0000 Subject: [Koha-bugs] [Bug 15544] Facets must be managed from the intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- As this has a new patch, I am marking the older bug 10891 as a duplicate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:35:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:35:27 +0000 Subject: [Koha-bugs] [Bug 15544] Facets must be managed from the intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #6 from Katrin Fischer --- *** Bug 10891 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:35:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:35:27 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #32 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 15544 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:37:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:37:34 +0000 Subject: [Koha-bugs] [Bug 7497] "kw, wrdl" and variants should be replaced by something more explicit in search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7497 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15434 --- Comment #8 from Katrin Fischer --- Not for the search history yet, but please see bug 15434 for a solution for the breadcrumbs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:37:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:37:34 +0000 Subject: [Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7497 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:38:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:38:35 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #16 from Katrin Fischer --- I think I agree with rangi - better to have it fail early, then to have to clean up all the patron accounts after figuring out what went wrong. What do others think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:39:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:39:04 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 --- Comment #2 from Briana Greally --- Created attachment 46828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46828&action=edit Bug 15571 reserveforothers permission does not remove Search to hold button from patron account To Test: 1. Create a user without 'reserveforothers' permission 2. Go onto user details 3. 'Search to hold' button should not be there 4. Create a user with 'reserveforothers' permission 5. Repeat steps 6. 'Search to Hold' button should be there -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:39:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:39:01 +0000 Subject: [Koha-bugs] [Bug 14613] Send cart window is too small in staff and hides 'send' button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14613 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:39:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:39:04 +0000 Subject: [Koha-bugs] [Bug 14613] Send cart window is too small in staff and hides 'send' button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14613 --- Comment #1 from Chloe Alabaster --- Created attachment 46829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46829&action=edit Bug 14613 Send cart window is too small in staff and hides 'send' button To Test: Add an item to cart click "cart" click "send" confirm that the send window is larger and the send button is visible -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:39:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:39:01 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:39:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:39:51 +0000 Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and volumne information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:39:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:39:54 +0000 Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and volumne information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 --- Comment #1 from Gus Ellerm --- Created attachment 46830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46830&action=edit Bug 15436 Use semicolon between series name and volumne information To Test: Add 490 and 830 for series and volume View page Should be ; (Semicolon) between series name and volume information, this replaced the : that was used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:41:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:41:58 +0000 Subject: [Koha-bugs] [Bug 15575] opac-authorities-home.pl broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15575 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |DUPLICATE CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Aleisha, I think this sounds like a duplicate to another bug - linking them together. *** This bug has been marked as a duplicate of bug 15550 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 18 23:41:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 22:41:58 +0000 Subject: [Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #5 from Katrin Fischer --- *** Bug 15575 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 00:02:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 23:02:26 +0000 Subject: [Koha-bugs] [Bug 14538] POD for CalcFine is incomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14538 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 00:02:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 23:02:28 +0000 Subject: [Koha-bugs] [Bug 14538] POD for CalcFine is incomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14538 --- Comment #1 from natasha --- Created attachment 46831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46831&action=edit Bug 14538: editing perl doc for CalcFine To Test: Read perldoc C4/Overdues.pm Confirm that it says CalcFine returns four values and that rest of the documentation is correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 00:03:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 23:03:22 +0000 Subject: [Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #12 from David Cook --- (In reply to Srdjan Jankovic from comment #8) > As far as I can see it is a bug either in > * modules/svc/suggestion.tt, line 37, that composes query as q=[indexed > query], or in > * C4::Search::parseQuery() that cannot deal with that kind of query > > I think that buildQuery() actually builds an invalid query, but I'd > certainly need an authoritative opinion. I used to know the answer to this one but I can't remember now. That said: 1) buildQuery() is terribad 2) I think there might be some Javascript which adds the "su-br, su-na, su-rl" stuff and I recall it also being terribad. The whole of search needs an overhaul... The other thing with this patch is that it doesn't include all CCL qualifiers, so hand-made queries will still show as the codes instead of the descriptions. Of course, providing descriptive labels for all CCL qualifiers is probably outside the scope of this bug... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 00:05:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 23:05:31 +0000 Subject: [Koha-bugs] [Bug 15540] Debian package option to set up an .onion address (Tor hidden service) for the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15540 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 00:23:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 23:23:13 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46093|0 |1 is obsolete| | --- Comment #4 from Briana Greally --- Created attachment 46832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46832&action=edit Bug 14752 - Add multiple copies to a basket at once This patch add an 'Add multiple copies' button on the new order page in acquisitions. While processing the multiple copies a modal is displayed. To test: 1 - Add an order to an acquisitions basket 2 - Choose to add multiple items 3 - A modal shouold warn about ignoring UniqueItemFields from syspref 4 - When submitting the modal should popup until all items are processed. 5 - The modal should disappear after items are added. 6 - Items should be cloned, minus unique fields Sponsored by: Middletown Township Public Library (http://www.mtpl.org) Signed-off-by: Briana -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 00:23:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 23:23:41 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 00:23:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 23:23:44 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46439|0 |1 is obsolete| | --- Comment #5 from Briana Greally --- Created attachment 46833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46833&action=edit Bug 14752 - (QA Followup) Use input type="number" and small update to error modal Signed-off-by: Briana -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 00:25:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 23:25:11 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 00:25:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 23:25:16 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46280|0 |1 is obsolete| | --- Comment #50 from natasha --- Created attachment 46834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46834&action=edit Bug 10612 - [QA followup] Use font awesome icons in patron lists lists.tt Signed-off-by: Natasha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 00:34:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 23:34:52 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #4 from Chris Cormack --- Students are working on this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 00:40:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jan 2016 23:40:04 +0000 Subject: [Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434 --- Comment #13 from Srdjan Jankovic --- > The whole of search needs an overhaul... Oh yes... > > The other thing with this patch is that it doesn't include all CCL > qualifiers, so hand-made queries will still show as the codes instead of the > descriptions. Of course, providing descriptive labels for all CCL qualifiers > is probably outside the scope of this bug... I can add that if you (or someone else) gives me the list. Or anyone can write a follow-up to add them, that's not a big thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 01:59:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 00:59:15 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 01:59:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 00:59:18 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31596|0 |1 is obsolete| | --- Comment #5 from natasha --- Created attachment 46835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46835&action=edit bug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha.Preference instead Test Plan: 1) Apply this patch 2) Go to circulation.pl 3) Ensure you can still override renewal limits with pref enabled 4) Ensure you can not override renewal limits with pref disabled 5) Go to moremember.pl 6) Repeat steps 3-4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:01:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:01:28 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tasham_8 at hotmail.com --- Comment #6 from natasha --- Original patch did not apply fatal: sha1 information is lacking or useless (circ/circulation.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12920 - Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:05:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:05:27 +0000 Subject: [Koha-bugs] [Bug 14406] When adding messages in patron account, only first name is shown in pull down In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14406 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:05:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:05:29 +0000 Subject: [Koha-bugs] [Bug 14406] When adding messages in patron account, only first name is shown in pull down In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14406 --- Comment #2 from Briana Greally --- Created attachment 46836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46836&action=edit Bug 14406 When adding messages in patron account, only first name is shown in pull down To test: Log in to staff patron account Go to Checkout tab Click 'Add a new message' Drop down box should show 'Staff - Internal Note' and 'OPAC - [Full name of patron]' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:06:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:06:11 +0000 Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and volumne information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46830|0 |1 is obsolete| | --- Comment #2 from Gus Ellerm --- Created attachment 46837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46837&action=edit Bug 15436 Use semicolon between series name and volumne information To Test: Add 490 and 830 for series and volume View page Should be ; (Semicolon) between series name and volume information, this replaced the : that was used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:13:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:13:09 +0000 Subject: [Koha-bugs] [Bug 15195] patron details should open in tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15195 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:13:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:13:11 +0000 Subject: [Koha-bugs] [Bug 15195] patron details should open in tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15195 --- Comment #3 from natasha --- Created attachment 46838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46838&action=edit Bug 15195 - patron details should open in tab Deleted View record link and made patron details open in a new tab. To Test: Edit personal details for a user on opac and submit update request. In staff client go to patrons requesting modifications. Confirm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:15:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:15:45 +0000 Subject: [Koha-bugs] [Bug 15195] patron details should open in tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15195 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tasham_8 at hotmail.com --- Comment #4 from natasha --- To Test: Edit personal details for a user on opac and submit update request. In staff client go to patrons requesting modifications. Confirm View record link is gone and patron details opens in a new tab. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:19:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:19:04 +0000 Subject: [Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434 --- Comment #14 from Srdjan Jankovic --- (In reply to Nicole C. Engard from comment #11) > That new patch doesn't apply either :( > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 15434: Search criteria definition table > Using index info to reconstruct a base tree... > Falling back to patching base and 3-way merge... > error: The following untracked working tree files would be overwritten by > merge: > koha-tmpl/opac-tmpl/bootstrap/js/search.js > Please move or remove them before you can merge. > Aborting > Failed to merge in the changes. > Patch failed at 0001 Bug 15434: Search criteria definition table > When you have resolved this problem run "git bz apply --continue". > If you would prefer to skip this patch, instead run "git bz apply --skip". > To restore the original branch and stop patching run "git bz apply --abort". > Patch left in /tmp/Bug-15434-Search-criteria-definition-table-K9mxpF.patch > 08:10 ~/kohaclone (bug15434-qa %|AM u=)$ Not sure why. I'm getting no errors: srdjan at srdjan:~/koha/dev (bug_15434_wr251001)$ git checkout kc/master Note: checking out 'kc/master'. ... srdjan at srdjan:~/koha/dev ((e7e1da8...))$ git bz apply 15434 Bug 15434 - Make search results breadcrumbs human readable 46674 - Bug 15434: Search criteria definition table Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15434: Search criteria definition table srdjan at srdjan:~/koha/dev ((084446e...))$ Maybe your tree was not clean for some reason? Can you please check git status after checking out master, maybe there are some leftovers? That sometimes happens to me when changing branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:23:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:23:49 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gel1163 at stacmail.net --- Comment #3 from Gus Ellerm --- Could you please tell us what URL to go too to create the error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:27:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:27:00 +0000 Subject: [Koha-bugs] [Bug 14810] Improve messages in patron anonymizing tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14810 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:27:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:27:03 +0000 Subject: [Koha-bugs] [Bug 14810] Improve messages in patron anonymizing tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14810 --- Comment #2 from Briana Greally --- Created attachment 46839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46839&action=edit Bug 14810 Improve messages in patron anonymizing tool To test: Create circulation records Go to 'http://localhost:8081/cgi-bin/koha/tools/cleanborrowers.pl' Anonymize patron checkout history Message should read 'All checkouts older than [date] have been anonymized When patch is not applied, message reads 'All patrons with checkouts older than [date] have been anonymized" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:40:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:40:02 +0000 Subject: [Koha-bugs] [Bug 12028] Add cardnumber on update patron records page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12028 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gel1163 at stacmail.net --- Comment #3 from Gus Ellerm --- Created attachment 46840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46840&action=edit Working card number This bug has been fixed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:42:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:42:50 +0000 Subject: [Koha-bugs] [Bug 14479] Open 856 link in new tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14479 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |tasham_8 at hotmail.com --- Comment #1 from natasha --- The links open in the same tab for the OPAC Normal View and the Staff Client, so this has already been fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:43:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:43:14 +0000 Subject: [Koha-bugs] [Bug 15298] z39.50 admin setup, options column suggested changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:43:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:43:16 +0000 Subject: [Koha-bugs] [Bug 15298] z39.50 admin setup, options column suggested changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 --- Comment #1 from Chloe Alabaster --- Created attachment 46841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46841&action=edit Bug 15298 - z39.50 admin setup, options column suggested changes To Test- 1-first look at the orginal Z39.50/SRU servers administration page (/cgi-bin/koha/admin/z3950servers.pl?op=delete_confirmed&id=6) 2-apply patch 3-now see the new styling of the "action" drop down tab like the one on the saved reports page 4-check that each link works (for delete i reccommend copying one then deleting the copy) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:50:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:50:36 +0000 Subject: [Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538 --- Comment #3 from Srdjan Jankovic --- (In reply to Fr?d?ric Demians from comment #2) > I can't make it work on master. Commit 347d12c41f9ebe may have broken > Koha::Logger on master. For me, the logger is never instantiated. After > modifying Koha::Logger to bypass conf file checking, I get a result in the > OPAC log file. Not sure why. I am supplying a conf file via LOG4PERL_CONF variable. What is your situation? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 02:50:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 01:50:44 +0000 Subject: [Koha-bugs] [Bug 12028] Add cardnumber on update patron records page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12028 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |chris at bigballofwax.co.nz Status|ASSIGNED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 03:33:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 02:33:19 +0000 Subject: [Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437 --- Comment #1 from Briana Greally --- Created attachment 46842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46842&action=edit Bug 15437 MARC21: Show $i for 780/785 To test: Search the catalog for a book Edit the record Go to the '7' tab and write an entry under the '780' and/or '785' titles Save that line should appear in the details section corresponding to whatever you wrote in the 780/785 box -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 03:35:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 02:35:34 +0000 Subject: [Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437 --- Comment #2 from Briana Greally --- I fixed the issue but it hasn't been styled to match the rest of the information surrounding it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 04:04:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 03:04:19 +0000 Subject: [Koha-bugs] [Bug 14624] <> for advance_notices.pl wrongly documented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 04:04:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 03:04:22 +0000 Subject: [Koha-bugs] [Bug 14624] <> for advance_notices.pl wrongly documented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 --- Comment #2 from natasha --- Created attachment 46843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46843&action=edit Bug 14624 - <> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 04:16:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 03:16:21 +0000 Subject: [Koha-bugs] [Bug 15468] Search links on callnumber fails on opac results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468 --- Comment #1 from Chloe Alabaster --- Created attachment 46844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46844&action=edit Bug 15468 - Search links on callnumber fails on opac results page To Test: 1-before plugin search in opac for a call number with either a "(" or a ")" in it 2-it should come back with no results 3-use plugin 4-re-search the call number with "(" or ")" 5-the search should come back with results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 04:16:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 03:16:18 +0000 Subject: [Koha-bugs] [Bug 15468] Search links on callnumber fails on opac results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 04:17:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 03:17:24 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 --- Comment #3 from Gus Ellerm --- Created attachment 46845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46845&action=edit 14930 - Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature To Test - - Borrower has some fines and checkouts - Leave OPACFineNoRenewals empty/blank - Try to renew items in the OPAC - notice error message - Add a big value to Opac -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 04:17:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 03:17:52 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 04:17:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 03:17:57 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 --- Comment #4 from Gus Ellerm --- Created attachment 46846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46846&action=edit 14930 - Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature To Test - - Borrower has some fines and checkouts - Leave OPACFineNoRenewals empty/blank - Try to renew items in the OPAC - notice error message - Add a big value to Opac -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 04:48:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 03:48:22 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 04:48:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 03:48:24 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 --- Comment #1 from Aleisha Amohia --- Created attachment 46847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46847&action=edit Bug 12051: Adds a Renew tab to the staff client To test: 1) Apply patch 2) Confirm that there is now a Renew tab on every page 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 04:56:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 03:56:51 +0000 Subject: [Koha-bugs] [Bug 15591] New: Spelling mistake Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15591 Bug ID: 15591 Summary: Spelling mistake Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: gel1163 at stacmail.net QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 04:56:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 03:56:52 +0000 Subject: [Koha-bugs] [Bug 15592] New: spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15592 Bug ID: 15592 Summary: spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-uplo ad.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: chloealabaster at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com extention -> extension :27 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 04:57:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 03:57:01 +0000 Subject: [Koha-bugs] [Bug 15593] New: Spelling mistake Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15593 Bug ID: 15593 Summary: Spelling mistake Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: gel1163 at stacmail.net QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 04:58:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 03:58:26 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Attachment #46846|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:23:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:23:10 +0000 Subject: [Koha-bugs] [Bug 15594] New: Sequence of MARC 260 subfields different on XSLT result list and detail page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 Bug ID: 15594 Summary: Sequence of MARC 260 subfields different on XSLT result list and detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org Sequence of MARC 260 subfields different on XSLT result list and detail page (both in staff client and OPAC) when there are repeating subfields $a and/or $b. For example: On MARC cataloguing screen it is entered as: $aNew York :$bHarperCollins ;$aMelbourne :$bCollins,$c2016 is displayed as: New York : Melbourne : HarperCollins ; Collins, 2016 It needs to match the order it is entered on the MARC cataloguing screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:34:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:34:03 +0000 Subject: [Koha-bugs] [Bug 12028] Add cardnumber on update patron records page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12028 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:36:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:36:27 +0000 Subject: [Koha-bugs] [Bug 13549] Add cardnumber to overdue circulation report overdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13549 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Keywords|Academy | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:36:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:36:34 +0000 Subject: [Koha-bugs] [Bug 12210] Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:36:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:36:51 +0000 Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy, rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:37:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:37:14 +0000 Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:37:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:37:20 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:36:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:36:59 +0000 Subject: [Koha-bugs] [Bug 15595] New: Display Google Jacket image on staff client search list and detail page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595 Bug ID: 15595 Summary: Display Google Jacket image on staff client search list and detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Ability to display book cover images from Google Books on staff client search list and detail page. Currently, this is available to OPAC result list and detail page only. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:37:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:37:37 +0000 Subject: [Koha-bugs] [Bug 13657] Don't show extra comma after guarantor name on patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:37:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:37:28 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:37:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:37:49 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:40:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:40:59 +0000 Subject: [Koha-bugs] [Bug 13682] Capitalization: Holds Queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:41:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:41:03 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:41:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:41:07 +0000 Subject: [Koha-bugs] [Bug 13587] Authorized Values toolbar missing '+' Icons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13587 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:41:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:41:34 +0000 Subject: [Koha-bugs] [Bug 13544] admin/auth_subfields_structure.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:43:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:43:59 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:44:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:44:04 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:46:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:46:10 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- I agree and will get the students this year to switch it around -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:49:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:49:32 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:50:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:50:30 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:50:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:50:36 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:50:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:50:42 +0000 Subject: [Koha-bugs] [Bug 13585] HEA - activate cronjob by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:50:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:50:46 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:51:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:51:53 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:52:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:52:03 +0000 Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:52:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:52:19 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:52:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:52:54 +0000 Subject: [Koha-bugs] [Bug 13683] Display library name on holds queue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13683 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:52:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:52:57 +0000 Subject: [Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:53:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:53:01 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:53:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:53:04 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:57:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:57:37 +0000 Subject: [Koha-bugs] [Bug 15595] Display Google Jacket image on staff client search list and detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:58:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:58:06 +0000 Subject: [Koha-bugs] [Bug 15596] New: Missing space between MARC 245 $h and $c (MARC21/XSLT) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15596 Bug ID: 15596 Summary: Missing space between MARC 245 $h and $c (MARC21/XSLT) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org Missing a single space between MARC 245 $h and $c subfields when displaying details in XSLT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 05:58:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 04:58:20 +0000 Subject: [Koha-bugs] [Bug 15590] Next issue skipped if planned date is 1/1/2016 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15590 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 06:00:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 05:00:29 +0000 Subject: [Koha-bugs] [Bug 15179] Marc field 084 does not show on bibliographic record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15179 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 06:05:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 05:05:42 +0000 Subject: [Koha-bugs] [Bug 15579] records_batchmod permission doesn't allow access to batch modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 06:13:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 05:13:14 +0000 Subject: [Koha-bugs] [Bug 15580] Confirm button not visible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15580 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 06:14:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 05:14:21 +0000 Subject: [Koha-bugs] [Bug 15560] holding branch missing in pending reserves report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 06:15:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 05:15:42 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15541 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 06:15:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 05:15:42 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15555 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 06:16:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 05:16:21 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #4 from David Cook --- I've solved this one... but now I need to write up an easy test plan... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 06:21:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 05:21:03 +0000 Subject: [Koha-bugs] [Bug 3092] Data values storage and use 100 bug meta-bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3092 --- Comment #8 from Chris Cormack --- +1 Do eeeeeeeet :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 06:23:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 05:23:21 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 06:56:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 05:56:20 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #5 from David Cook --- Created attachment 46848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46848&action=edit Bug 15541 - Prevent normalization during matching/import process This patch allows you to use the "qualifier,qualifier" syntax in the Record Matching Rules "Search Index" when using the QueryParser. While QueryParser doesn't support this syntax, it will now fallback correctly to non-QueryParser functionality. Without the patch, your search will just fail silently. This patch also adds a "skip_normalize" flag to C4::Search::SimpleSearch(), and sets the flag during C4::Matcher::get_matches. This prevents the s/:/=/g and s/=/:/g normalization which happens in a heavy-handed way to provide correct query syntax. However, get_matches() already uses the correct syntax, so this normalization is unneeded. The normalization also mangles URLs which causes failures when using the "url" (ie "u") register in Zebra (see bug 15555). This patch also creates "raw" and "none" normalizers for the Record Matching Rules, which prevents the stripping of spaces and punctuation by Koha prior to sending queries to Zebra. This is important for a number of reasons. First and foremost, Zebra does normalization better than Koha. ICU and CHR normalize strings differently, so it's better not to try to outsmart Zebra with pre-normalization of punctuation and spaces, as it will lead to search problems. Second, when using the "u" register in Zebra, you don't want to normalize the value, since it's stored "as is" in the Zebra database. Normalization causes search failures. _TEST PLAN_ 1) Apply patches from http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 2) Create a record in Koha with a 024 $a http://koha-community.org/test $2 uri 3) Do a full re-index of Zebra 4) Create a Record Matching Rule in Koha with the following details: Description: Test Match threshold: 100 Record type: Bibliographic Match point 1: Search index: id-other,st-urx Score: 100 Tag: 024 Subfields: a Normalization rule: raw 5) Download your record from Koha as a .mrc file (ie isomarc, binary marc, etc) 6) Go to "Stage MARC records for import" 7) Upload your .marc file. 8) Change your "Record matching rule" to "Test" 9) Click Stage for import 10) It should say "1 records with at least one match in catalogu per matching rule "Test". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 06:56:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 05:56:48 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Status|NEW |Needs Signoff Depends on| |15555 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 06:56:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 05:56:48 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15541 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 [Bug 15541] Prevent normalization during matching/import process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 06:57:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 05:57:34 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #6 from David Cook --- Marked this with the "Academy" keyword, although it might be a bit advanced... More than happy to walk people through the Zebra stuff relating to this bug though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 07:00:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 06:00:14 +0000 Subject: [Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434 --- Comment #15 from David Cook --- (In reply to Srdjan Jankovic from comment #13) > I can add that if you (or someone else) gives me the list. Or anyone can > write a follow-up to add them, that's not a big thing. Cool. I don't have time at the moment, but I'll keep that in mind. I've been thinking about writing a parser for ccl.properties, so if I ever pull that off, that could be useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 07:56:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 06:56:32 +0000 Subject: [Koha-bugs] [Bug 15460] Bug 13381 accidentally removed spaces after subfields c and h of 245 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 07:56:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 06:56:40 +0000 Subject: [Koha-bugs] [Bug 15596] Missing space between MARC 245 $h and $c (MARC21/XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15596 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 15460 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 07:56:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 06:56:40 +0000 Subject: [Koha-bugs] [Bug 15460] Bug 13381 accidentally removed spaces after subfields c and h of 245 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |imingchan at yahoo.com.au --- Comment #2 from Katrin Fischer --- *** Bug 15596 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 08:00:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 07:00:34 +0000 Subject: [Koha-bugs] [Bug 3092] Data values storage and use 100 bug meta-bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3092 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #9 from Katrin Fischer --- Decided for 'moved' as I think parts of this has been fixed elsewhere or should be moved to new bugs :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 09:47:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 08:47:57 +0000 Subject: [Koha-bugs] [Bug 14489] Software error when trying to create new batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14489 --- Comment #6 from Jonathan Druart --- You have to create a new batch and then add items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 09:55:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 08:55:19 +0000 Subject: [Koha-bugs] [Bug 15597] New: Typo in opac-auth-detail.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 Bug ID: 15597 Summary: Typo in opac-auth-detail.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Found while translating, in opac-auth-detail.tt: Number of records used in:: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 09:58:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 08:58:16 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 09:58:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 08:58:18 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46741|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 46849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46849&action=edit Bug 15188 - Fixes remove_unused_authorities.pl will delete all authorities if zebra is not running Test plan: 1) Shut down zebra: koha-zebra-ctl.sh stop 2) Execute the script: remove_unused_authorities.pl (with -t if you don't want to really delete from your database). 3) Check that the script would have deleted all the authorities (eg: 31449 authorities parsed, 31449 deleted and 0 unchanged because used). 4) Apply patch 5) Run, notice that the script dies because zebra is unavailable Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 09:58:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 08:58:21 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 --- Comment #11 from Jonathan Druart --- Created attachment 46850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46850&action=edit Bug 15188: Do not remove unused auths if zebra is not reachable Other conn errors should be checked (wrong user/pwd, etc.) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:01:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:01:53 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:06:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:06:12 +0000 Subject: [Koha-bugs] [Bug 15597] Typo in opac-auth-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:09:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:09:51 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 --- Comment #7 from Marcel de Rooy --- Thanks Marc and Magnus. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:12:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:12:31 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #24 from Jonathan Druart --- I really would like to get another signoff on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:27:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:27:15 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |frederic at tamil.fr, | |gaetan.boisson at biblibre.com | |, | |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #25 from Jonathan Druart --- This is not marcflavour independent: 942$n is hardcoded, so it won't work for UNIMARC The XSLT changes have been done for MARC21 only, if NORMARC uses 942$n also, it would be easy to c/p the changes to the according XSLT files. Does a UNIMARC user want to provide a patch for UNIMARC XSLT? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:27:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:27:35 +0000 Subject: [Koha-bugs] [Bug 15598] New: Typo in subscription-add.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15598 Bug ID: 15598 Summary: Typo in subscription-add.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Found while translating - I think there should be no space between Warning and ! ? subscription-add.tt: Warning ! Present pattern has planned irregularities. Click on 'Test prediction pattern' to check if it's still valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:27:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:27:51 +0000 Subject: [Koha-bugs] [Bug 15598] Typo in subscription-add.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15598 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:36:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:36:52 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #30 from Jonathan Druart --- These patches don't apply anymore. There are too much changes and too many patches, I have suggested a very simple solution months ago, now we have patches modifying 10 different files... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:38:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:38:08 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:38:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:38:13 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:44:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:44:05 +0000 Subject: [Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280 --- Comment #6 from Katrin Fischer --- Hi Jonathan, can you give an example? Not sure I understand. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:50:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:50:59 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:51:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:51:01 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44019|0 |1 is obsolete| | Attachment #44021|0 |1 is obsolete| | Attachment #46223|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 46851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46851&action=edit Bug 14199: Unify marc orgcode plugins, not overwriting existing values This patch copies code from marc21_field_003.pl to create marc21_orgcode.pl for more generic use. Other fields like 040c or 040d should use it too. Note: The plugin is used for authorities too (003, 040a). One behaviour change is added: If the corresponding field is already filled, it will not be overwritten. In the unit test marc21_orgcode already replaces marc21_field_003. Test plan: [1] Attach plugin marc21_orgcode to a field (e.g. 003) and test it in the MARC editor of Cataloguing or Authorities. [2] Check if a value is not overwritten any more. [3] Run unit test t/db_dependent/FrameworkPlugin.t; don't be distracted by the noisy warnings of marc21_field_007.pl. They will be addressed on another report. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:51:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:51:06 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #16 from Jonathan Druart --- Created attachment 46852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46852&action=edit Bug 14199: Database revision for marc21_orgcode.pl This patch adds the dbrev in atomicupdate, updating the marc structure for existing installations. (New installation in previous patch.) And it removes the obsolete plugin files. Test plan: Run upgrade. Verify that new plugin is linked (for bib and auth). Check plugin in editor. Signed-off-by: Bernardo Gonzalez Kriegel Plugin tested, added to 040a/c/d Test pass No koha-qa errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:51:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:51:11 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #17 from Jonathan Druart --- Created attachment 46853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46853&action=edit Bug 14199: Modify webinstaller sql files for marc21_orgcode plugin This patch updates the sql installer files for new installations. Occurrences to the three plugins marc21_field_003, 040c and 040d are replaced by marc21_orgcode.pl. This has been generated by one sed statement. Test plan: [1] Run a new installation or run some of the changed sql files manually. [2] Verify that marc21_orgcode is linked to fields previously linked to the three old plugins. [3] Do a git grep on the three plugin file names. No occurrences expected. Signed-off-by: Marcel de Rooy Have tested the three english sql files: authorities_normal_marc21.sql: 18 rows with marc21_orgcode (003 and 040a for 9 auth codes) marc21_framework_DEFAULT.sql: 1 row with marc21_orgcode (003) -- this patch does not add them to 040c or 040d; no behavior change.. marc21_simple_bib_frameworks.sql: 8 rows (003 for 8 frameworks) Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Marcel de Rooy The following files do no longer need an adjustment: installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql installer/data/mysql/it-IT/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql For details, check Bug 15097: Update MARC21 de-DE frameworks to Update 21. And similar reports for es-ES and it-IT. Verified this change by installing de-DE in the webinstaller. The plugin for field 003 was correctly set to marc21_orgcode.pl. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:54:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:54:28 +0000 Subject: [Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:54:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:54:31 +0000 Subject: [Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46014|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 46854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46854&action=edit Bug 11280 - Change Withdrawn toggle to drop down selection of authorized values 'Withdrawn' is an authorised value just like 'Lost' and 'Damaged,' so the item detail screen should offer the same means of selecting one of multiple values. This patch re-uses the same template markup and code 'Lost' and 'Damage' use to make it possible to select a specific withdrawn value. To test you should have multiple values entered for the authorised value category 'WITHDRAWN'. 1. Apply the patch and locate any record in the catalog. 2. From the detail screen, click the barcode in the items table to go to the item detail page. 3. Confirm that there is a dropdown list of choices for 'Withdrawn status.' 4. Try both setting and unsetting various withdrawn statuses. 5. Confirm that setting Lost or Damaged statuses. Signed-off-by: Aleisha Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:55:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:55:14 +0000 Subject: [Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280 --- Comment #8 from Jonathan Druart --- (In reply to Katrin Fischer from comment #6) > Hi Jonathan, can you give an example? Not sure I understand. Sorry, forget that, it did not make sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 10:56:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 09:56:13 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 11:07:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 10:07:33 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart --- QA comments: 1/ Could you please add the DSpace license (linked to the xslt) to the about page? 2/ Fr?d?ric, why did you move the xslt file to the OPAC css dir? Why not koha-tmpl/opac-tmpl/bootstrap/en/xslt/? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 11:07:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 10:07:48 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 11:09:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 10:09:35 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #17 from Jonathan Druart --- 3/ Should the new file be translatable? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 11:09:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 10:09:59 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 11:28:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 10:28:59 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #18 from Fr?d?ric Demians --- > 2/ Fr?d?ric, why did you move the xslt file to the OPAC css dir? Why not > koha-tmpl/opac-tmpl/bootstrap/en/xslt/? See comment 8. The XSL file is accessed directly by the web browser by http. Files in koha-tmpl/opac-tmpl/bootstrap/en/xslt/ can only be accessed by Koha web scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 11:30:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 10:30:57 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #19 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #17) > 3/ Should the new file be translatable? In my opinion, humble as appropriate, no. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 11:38:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 10:38:50 +0000 Subject: [Koha-bugs] [Bug 9754] koha-remove optionally includes var/lib and var/spool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 11:38:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 10:38:53 +0000 Subject: [Koha-bugs] [Bug 9754] koha-remove optionally includes var/lib and var/spool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46754|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 46855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46855&action=edit Bug 9754: koha-remove optionally includes var/lib and var/spool Currently, the files in the folder /var/lib/koha/[instance] and also in /var/spool/koha/[instance] are not removed. This patch adds the option -p|--purge-all to include those two directories when removing files. Note: There was a small bug in the for loop. On the -k line the extra shift statement is one too much. NOTE: Verify that you use the adjusted koha-remove in the test plan and not accidentally an older version of this script. Test plan: [1] Create an instance test. [2] Run koha-remove and verify that /var/lib/koha/test still exists. [3] Create an instance test2. [4] Run koha-remove -k -p and verify that the sql database still exists but the two instance folders in var/lib/koha and var/spool/koha are gone. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 11:43:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 10:43:43 +0000 Subject: [Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 11:43:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 10:43:45 +0000 Subject: [Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46758|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 46856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46856&action=edit Bug 1983: Checkout: Hold repquest when checking out an item already on loan or reserved This patch allows to put a hold on an item that is already checked out or reserved. To test: - Check out an item A - Put a hold on an item B - Verify that the staff user has permission to put holds - Check out item A to a patron X - Try to checkout item A to a patron Y - Verify that you see underneath the buttons for Checkin/Checkout a link with following text: "Click here to place hold for [Patron X' name]" - Verify that the link is stylable (div class circ-scheckoutplacehold) - Verify that the link takes you to the page to place a hold on this biblio for patron Y - Do the same for item B and verify that it works for reserved items as well. - Repeat steps above for a patron who has restrictions, verify that the link does not appear - Log in with a staff member who has no permission to place holds - Repeat steps above for a patron without restrictions, verify that the link does not appear. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 11:53:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 10:53:08 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Marcel, Why do you remove temporary uploads? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 12:11:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 11:11:55 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- QA comments: 1/ (window.MSG_ADDITEM_JS_UPDATEITEM || "Update item ") If the string is not defined, there is something wrong in the code, we should not provide a hardcoded string 2/ When I click on the "add multiple" button, I get a JS error "TypeError: document.f is undefined" And the behavior if weird: I get the "Invalid number of copies" even if I enter "2", it may come from the JS error. 3/ If I am not wrong, the barcode could be sent, the next one will be generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 12:14:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 11:14:41 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 12:15:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 11:15:57 +0000 Subject: [Koha-bugs] [Bug 15570] circ/renew.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 12:41:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 11:41:43 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #51 from Jonathan Druart --- Comment on attachment 46279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46279 Bug 10612 - Add ability to delete patrons with batch patron deletion tool Review of attachment 46279: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10612&attachment=46279) ----------------------------------------------------------------- ::: tools/cleanborrowers.pl @@ +85,5 @@ > > + my $patrons_to_delete; > + if ($patron_list_id) { > + my @patron_list_patrons = > + Koha::Database->new()->schema()->resultset('PatronListPatron') It would be better to use Koha::List::Patron instead. @@ +169,5 @@ > trash => ( $radio eq "trash" ) ? (1) : (0), > testrun => ( $radio eq "testrun" ) ? 1: 0, > ); > +} else { # $step == 1 > + $template->param( patron_lists => [ GetPatronLists() ] ); I'd make more sense to pass the non empty patron lists only. @@ +185,4 @@ > #writing the template > output_html_with_http_headers $cgi, $cookie, $template->output; > > +sub _skip_borrowers_with_nonzero_balance_or_issues { You are modifying the behavior of the tool. This change should be moved to another bug report (misc/cronjobs/delete_patrons.pl will need the change too). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 12:41:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 11:41:51 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 12:43:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 11:43:00 +0000 Subject: [Koha-bugs] [Bug 14624] <> for advance_notices.pl wrongly documented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tasham_8 at hotmail.com CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 12:58:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 11:58:02 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- I have added a new test in the QA tools to avoid that: commit 6cae93f77e8b3b909e290a967c8171aac913bd5f Koha::Branches has been removed by bug 15294 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:18:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:18:29 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:18:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:18:32 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #32 from Kyle M Hall --- Created attachment 46857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46857&action=edit Bug 14310 [QA Followup] - Use output_with_http_headers, return 403s -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:18:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:18:38 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #33 from Kyle M Hall --- Created attachment 46858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46858&action=edit Bug 14310 [QA Followup] - Adapt existing code to use new methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:23:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:23:11 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46857|0 |1 is obsolete| | Attachment #46858|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall --- Created attachment 46859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46859&action=edit Bug 14310 [QA Followup] - Use output_with_http_headers, return 403s -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:23:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:23:18 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #35 from Kyle M Hall --- Created attachment 46860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46860&action=edit Bug 14310 [QA Followup] - Adapt existing code to use new methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:28:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:28:22 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46860|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall --- Created attachment 46861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46861&action=edit Bug 14310 [QA Followup] - Adapt existing code to use new methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:31:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:31:28 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #33 from Kyle M Hall --- Follow pushed to master! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:33:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:33:12 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall --- Pushed to master! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:37:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:37:04 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46861|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall --- Created attachment 46862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46862&action=edit Bug 14310 [QA Followup] - Adapt existing code to use new methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:39:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:39:03 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 --- Comment #8 from Kyle M Hall --- (In reply to Jonathan Druart from comment #6) > I have added a new test in the QA tools to avoid that: > > commit 6cae93f77e8b3b909e290a967c8171aac913bd5f > Koha::Branches has been removed by bug 15294 Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:41:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:41:08 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15548 --- Comment #4 from Jonathan Druart --- Bug 15548 - New patron related code should have been put to Patron instead of Borrower (Koha::Borrower* vs Koha::Patron*) Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 [Bug 15548] New patron related code should have been put to Patron instead of Borrower -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:41:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:41:08 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15449 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:43:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:43:49 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #13 from Jonathan Druart --- I have added a new test in the QA tools: commit 352357f88d1225075b555723f9135e91eb76571c Koha::Borrower has been moved by bug 15548 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:51:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:51:48 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #44 from Kyle M Hall --- (In reply to Jonathan Druart from comment #43) > (In reply to Jesse Weaver from comment #41) > > (FYI: the same warning that appears at the top of the test output here also > > appears when I prove t/db_dependent/Items.t, though that test passes.) > > We should not expect warnings on proving, they must be caught be > warning_is/warning_like. The warnings are unavoidable, unless we change the behavior that falls back to the record itemtype if there is no item itype ( even though item-level_itypes is enabled ). I think are actually testing the cases that specifically triggers this error condition. Either way, I think the issue is outside the scope of this bug. We should decide whether or not this is a bug that needs fixed on a separate report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:53:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:53:28 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #45 from Kyle M Hall --- It took me a minute for what you wrote to sink in. Still, we should address the issue on a separate bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:54:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:54:30 +0000 Subject: [Koha-bugs] [Bug 15599] New: Unit tests output warnings Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 Bug ID: 15599 Summary: Unit tests output warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The unit tests t/db_dependent/Circulation/Returns.t and t/db_dependent/Items.t print out eh warning "item-level_itypes set but no itemtype set for item". This should not happen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:54:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:54:41 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:54:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:54:51 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15599 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 [Bug 15599] Unit tests output warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:54:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:54:51 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14598 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 13:54:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 12:54:55 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:25:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:25:45 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46698|0 |1 is obsolete| | --- Comment #14 from Alex Arnaud --- Created attachment 46863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46863&action=edit Bug 6979 - Handle multiple branches in non-auth_by_bin -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:33:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:33:00 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:33:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:33:03 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46532|0 |1 is obsolete| | Attachment #46533|0 |1 is obsolete| | Attachment #46534|0 |1 is obsolete| | Attachment #46535|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 46864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46864&action=edit Bug 14694 - Make decreaseloanHighHolds more flexible This patch allows for more flexibility for determining when the number of holds a record has should trigger the reduction of the loan length for items on that record. This patch adds a new system preference decreaseLoanHighHoldsControl, which defaults to 'static', the original behavior of the feature. It also has a new behavior 'dynamic' which makes the feature only decrease the loan length if the number of holds on the record exceeds the number of holdable items + decreaseLoanHighHoldsValue. It also allows items to be filtered from the list of items based on the damaged, lost, not for loan, and withdrawn values even if those values would have allowed holds ( i.e. values < 0 ) Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set decreaseLoanHighHolds to Enable 4) Set decreaseLoanHighHoldsControl to "over the number of items on the record" 5) Set decreaseLoanHighHoldsDuration to 1 6) Set decreaseLoanHighHoldsValue to 3 7) Create a record with 5 items 8) Please 8 or more holds on the record 9) Check out one of the items to a patron 10) Note the loan length is reduced to 1 day 11) Set decreaseLoanHighHoldsValue to 3 to 2 12) Check out one of the items to a patron 13) Note the loan length is *not* reduced 14) Enbale all the filters possible in decreaseLoanHighHoldsIgnoreStatuses 15) Set one item to be damaged 16) Note the loan length is reduced 17) Unset the damaged status 18) Repeat steps 15 - 17 for lost, not for loan, and withdrawn Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:33:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:33:11 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #32 from Jonathan Druart --- Created attachment 46866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46866&action=edit Bug 14694 [QA Followup] - Fix typos Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:33:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:33:08 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #31 from Jonathan Druart --- Created attachment 46865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46865&action=edit Bug 14694 [QA Followup] - Fix unit tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:33:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:33:16 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #33 from Jonathan Druart --- Created attachment 46867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46867&action=edit Bug 14694 [QA Followup] - Fix syspref order Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:33:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:33:21 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #34 from Jonathan Druart --- Created attachment 46868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46868&action=edit Bug 14694: Create data the tests need Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:36:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:36:52 +0000 Subject: [Koha-bugs] [Bug 15544] Facets must be managed from the intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:49:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:49:13 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:49:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:49:15 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 --- Comment #1 from Kyle M Hall --- Created attachment 46869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46869&action=edit Bug 15599 - Unit tests output warnings The unit tests t/db_dependent/Circulation/Returns.t and t/db_dependent/Items.t print out eh warning "item-level_itypes set but no itemtype set for item". This should not happen. Test Plan: 1) prove t/db_dependent/Circulation/Returns.t 2) Note the warning 3) prove t/db_dependent/Items.t 4) Note the warning 5) Apply this patch 6) prove t/db_dependent/Circulation/Returns.t 7) Note there is no warning 8) prove t/db_dependent/Items.t 9) Note there is no warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:50:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:50:20 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #46 from Kyle M Hall --- Unit tests fixes submitted on bug 15599! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:50:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:50:26 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #38 from Jonathan Druart --- Comment on attachment 46862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46862 Bug 14310 [QA Followup] - Adapt existing code to use new methods Review of attachment 46862: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14310&attachment=46862) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +1178,4 @@ > } else { > + # FIXME: Why are we doing this? Should this be resuming the hold, > + # or maybe suspending it indefinitely? > + $hold->set( { suspend_until => undef } )->store(); Indeed, this is weird. If suspend_until is defined, it should be a date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:53:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:53:23 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 --- Comment #7 from Kyle M Hall --- (In reply to natasha from comment #6) > Original patch did not apply > fatal: sha1 information is lacking or useless (circ/circulation.pl). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 12920 - Remove AllowRenewalLimitOverride from pl > scripts, use Koha.Preference instead I'm having no trouble applying this patch to the latest master. Can you try again? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:59:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:59:09 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:59:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:59:12 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44203|0 |1 is obsolete| | Attachment #44204|0 |1 is obsolete| | Attachment #44205|0 |1 is obsolete| | Attachment #44207|0 |1 is obsolete| | Attachment #46859|0 |1 is obsolete| | Attachment #46862|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart --- Created attachment 46870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46870&action=edit Bug 14310 - Suspend and resume indvidual holds from patron holds table This enhancment adds the ability to suspend and resume individual holds from the holds table on circulation.pl and moremember.pl. The interface is inspired/cribbed from the same feature already available in the opac. Test Plan: 1) Apply this patch 2) Find a patron with holds 3) Suspend a hold with no resume date 4) Resume the suspended hold 5) Suspend a hold with a resume date 6) Resume the suspended hold Signed-off-by: Kyle M Hall Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:59:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:59:18 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #40 from Jonathan Druart --- Created attachment 46871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46871&action=edit Bug 14310 [QA Followup] - Add unit tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:59:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:59:22 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #41 from Jonathan Druart --- Created attachment 46872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46872&action=edit Bug 14310 [QA Followup] - Enable translations, set svc script to be executable Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:59:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:59:25 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #42 from Jonathan Druart --- Created attachment 46873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46873&action=edit Bug 14310 [QA Followup] - Deal with error conditions Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:59:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:59:29 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #43 from Jonathan Druart --- Created attachment 46874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46874&action=edit Bug 14310 [QA Followup] - Use output_with_http_headers, return 403s Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 14:59:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 13:59:32 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #44 from Jonathan Druart --- Created attachment 46875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46875&action=edit Bug 14310 [QA Followup] - Adapt existing code to use new methods Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:07:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:07:00 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #45 from Kyle M Hall --- (In reply to Jonathan Druart from comment #38) > Comment on attachment 46862 [details] [review] > Bug 14310 [QA Followup] - Adapt existing code to use new methods > > Review of attachment 46862 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Reserves.pm > @@ +1178,4 @@ > > } else { > > + # FIXME: Why are we doing this? Should this be resuming the hold, > > + # or maybe suspending it indefinitely? > > + $hold->set( { suspend_until => undef } )->store(); > > Indeed, this is weird. > If suspend_until is defined, it should be a date. I've found the one and only path that executes this code. If you have a suspended hold with a resume date, and clear the resume date, then click "Update hold(s)" the action is to change the suspension from one with a resume date to an indefinite suspension! I'll update the FIXME to document this instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:16:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:16:16 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #46 from Kyle M Hall --- Created attachment 46876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46876&action=edit Bug 14310 [QA Follow] - Remove FIXME, add explanation comment instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:20:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:20:25 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #47 from Jonathan Druart --- Kyle, With the last patches, you consider that all the concerns have been taken into account, that's it? It's what I understand, but in this case, we need to update the existing rows in the update DB entry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:23:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:23:27 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #48 from Katrin Fischer --- I think other routines (CanBookBeIssued, ...?) still suffer the same problem - I tried fixing CanBookBeIssued, but failed at writing the unit tests. We should make sure there are updated separate bug reports for those - best would be to fix them all before the next release (consistency in reporting) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:25:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:25:40 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #49 from Kyle M Hall --- (In reply to Jonathan Druart from comment #47) > Kyle, > With the last patches, you consider that all the concerns have been taken > into account, that's it? > It's what I understand, but in this case, we need to update the existing > rows in the update DB entry. There is already a db update in updatedatabase.pl, is this what you are looking for? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:27:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:27:21 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #50 from Jonathan Druart --- (In reply to Kyle M Hall from comment #49) > (In reply to Jonathan Druart from comment #47) > > Kyle, > > With the last patches, you consider that all the concerns have been taken > > into account, that's it? > > It's what I understand, but in this case, we need to update the existing > > rows in the update DB entry. > > There is already a db update in updatedatabase.pl, is this what you are > looking for? No, it does not update localuse. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:28:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:28:57 +0000 Subject: [Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #25 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 15534 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:28:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:28:57 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axel.jacquin at bsz-bw.de --- Comment #4 from Kyle M Hall --- *** Bug 6837 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:31:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:31:42 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #83 from Jonathan Druart --- fatal: sha1 information is lacking or useless (C4/Installer/PerlDependencies.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8352 - Add printer administration, update script to use Koha defined printers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:34:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:34:17 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #51 from Kyle M Hall --- Created attachment 46877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46877&action=edit Bug 14598 [QA Followup] - Update localuse statistics also -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:34:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:34:54 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #52 from Kyle M Hall --- (In reply to Jonathan Druart from comment #50) > No, it does not update localuse. This followup should take care of that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:40:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:40:21 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:40:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:40:25 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45651|0 |1 is obsolete| | Attachment #45652|0 |1 is obsolete| | Attachment #45653|0 |1 is obsolete| | Attachment #45654|0 |1 is obsolete| | Attachment #45655|0 |1 is obsolete| | Attachment #45656|0 |1 is obsolete| | Attachment #45659|0 |1 is obsolete| | --- Comment #84 from Kyle M Hall --- Created attachment 46878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46878&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:40:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:40:35 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #85 from Kyle M Hall --- Created attachment 46879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46879&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:40:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:40:39 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #86 from Kyle M Hall --- Created attachment 46880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46880&action=edit Bug 8352 [QA Followup] - Fix column type in kohastructure.sql Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:40:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:40:42 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #87 from Kyle M Hall --- Created attachment 46881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46881&action=edit Bug 8352 [QA Followup] - Don't use SQL in pl files Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:40:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:40:46 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #88 from Kyle M Hall --- Created attachment 46882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46882&action=edit Bug 8352 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:40:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:40:50 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #89 from Kyle M Hall --- Created attachment 46883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46883&action=edit Bug 8352 [QA Followup] - Notices for translation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:40:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:40:53 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #90 from Kyle M Hall --- Created attachment 46884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46884&action=edit Bug 8352 [QA Followup] - Remove use of HTML::HTMLDoc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:41:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:41:00 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45460|0 |1 is obsolete| | --- Comment #25 from Owen Leonard --- Created attachment 46885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46885&action=edit [SIGNED-OFF] Bug 15269 [ENH]: Layout tweaks for the opac-detail page Make the following improvements to the layout of the OPAC detail page: * Image thumbnail has more white space * Summary is moved up the details block and font size is increased * Ratings controls are moved up the details * Small devices get a better layout To test: - Check that the ratings controls are moved up the page to be before the summary * If there is no summary, the controls should be under the series * If there is no summary or no series, the controls should be under the type * If there is no summary, no series, or no type, the controls should be under the authors (including contributing authors) - Check that the 520 field (Summary, Subject, Review, Scope and content, Abstract, Content advice) is rendered nearer to the top of the page, following material type, series, and the ratings. - Check that the font size for "Material type", "Series" and the 520 field (Summary, Subject, Review, Scope and content, Abstract, Content advice) are rendered at a 14px font size. - Check that authors and contributing authors are rendered at 16px font size. - Check that if any kind of cover image is present (or the no cover image placeholder image) it is rendered into a div with a class of 'span2' and appears on the left of the main item details. * Need to test every kind of cover image service * If no kind of cover image service is turned on, then the 'span2' div should not be present and the item details should be on the left of the content area. - Check that small devices (e.g. mobile phones) make the 'span2' image column take up the full width and appear above the rest of the item details. - Check that layout of the search results page is unaffected. - Check that changing 'OPACXSLTDetailsDisplay' to an empty string still yields the expected layout. Sponsored-by: ByWater Signed-off-by: Nick Clemens Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:42:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:42:33 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45461|0 |1 is obsolete| | --- Comment #26 from Owen Leonard --- Created attachment 46886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46886&action=edit [SIGNED-OFF] Bug 15269 [ENH]: Compiled CSS changes Sponsored-by: ByWater Signed-off-by: Nick Clemens Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:42:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:42:31 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:49:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:49:34 +0000 Subject: [Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:49:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:49:36 +0000 Subject: [Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46674|0 |1 is obsolete| | --- Comment #16 from Nicole C. Engard --- Created attachment 46887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46887&action=edit Bug 15434: Search criteria definition table Collected search criteria and limit labels in opac-bottom.inc, so it can be used for both making search criteria selects and displaying back selections on the result screen. *-opac-bootstrap.po translation files need to be changed: - references to opac-advanced-search.tt need to be updated to opac-bottom.inc - messages and translations need  -s removed Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:55:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:55:36 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:55:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:55:39 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45569|0 |1 is obsolete| | Attachment #45570|0 |1 is obsolete| | Attachment #45571|0 |1 is obsolete| | Attachment #45572|0 |1 is obsolete| | Attachment #45575|0 |1 is obsolete| | Attachment #45576|0 |1 is obsolete| | Attachment #45638|0 |1 is obsolete| | Attachment #45644|0 |1 is obsolete| | --- Comment #66 from Kyle M Hall --- Created attachment 46888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46888&action=edit Bug 12803 - Add ability to skip closed libraries when generating the holds queue The holds queue is typically generated many times a day in order to select items to fill holds. Often these items are to be sent to a different library. However, if the library whose item is picked to fill a hold is closed, that hold will remain unfilled even if there are other open libraries who own that item. It would be helpful if we could skip closed libraries for the purpose of selecting items to fill holds. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with two items on it, one at Branch A, and one at Branch B 4) Place a hold for pickup at Branch C 5) Generate the holds queue 6) Note which branch's item is selected for the hold 7) Enable the new system preference HoldsQueueSkipClosed 8) Add today as a holiday for that branch noted in step 6 9) Regenerate the holds queue 10) View the holds queue, notice the item selected is not from the closed branch! 11) prove t/db_dependent/HoldsQueue.t Signed-off by: Jason Robb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:55:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:55:47 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #67 from Kyle M Hall --- Created attachment 46889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46889&action=edit Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:55:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:55:50 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #68 from Kyle M Hall --- Created attachment 46890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46890&action=edit Bug 12803 [QA Followup] - Remove use of C4::Dates C4::Dates was being included, but not used in the code! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:55:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:55:56 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #70 from Kyle M Hall --- Created attachment 46892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46892&action=edit Bug 12803 [QA Followup] - Update unit tests due to changes in master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:55:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:55:53 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #69 from Kyle M Hall --- Created attachment 46891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46891&action=edit Bug 12803 [QA Followup] - Fix koha-qa.pl errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:56:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:56:00 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #71 from Kyle M Hall --- Created attachment 46893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46893&action=edit Bug 12803 [QA Followup] - Fix to stop failing unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:56:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:56:03 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #72 from Kyle M Hall --- Created attachment 46894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46894&action=edit Bug 12803 [QA Followup] - Remove duplicate 'use' lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 15:56:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 14:56:06 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #73 from Kyle M Hall --- Created attachment 46895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46895&action=edit Bug 12803 [QA Followup] - Remove NO_CACHE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:01:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:01:24 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #74 from Kyle M Hall --- (In reply to Jonathan Druart from comment #65) > Kyle, > There is a small conflict to fix. > Do you mind if we mark this patch dependent on bug 15391? Fixed! I'm a bit reticent to make this dependent on bug 15391. Bug 15391 has no patches yet, indeed we haven't even truly nailed down the issue. Additionally, there is no real interaction / interdependence between the tests added here and the issues on bug 15391. My fear is that bug 15391 will take a long time to solve, which will hold up this patch set that's already been in process for years now. That being said, I'll leave the call up to you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:05:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:05:42 +0000 Subject: [Koha-bugs] [Bug 15600] New: System preferences broken toolbar looks broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Bug ID: 15600 Summary: System preferences broken toolbar looks broken Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/preferences.pl OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Created attachment 46896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46896&action=edit Broken appearance of the toolbar In system preferences, when you scroll down a long page the toolbar with the "save" button "sticks" to the top of the browser window so that the button is always accessible. Since the addition of the professional cataloging interface (Bug 11559) the appearance of this toolbar has been broken (improper passing, transparent background). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:06:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:06:10 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 --- Comment #1 from Owen Leonard --- Created attachment 46897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46897&action=edit Correct appearance of the toolbar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:06:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:06:58 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:11:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:11:11 +0000 Subject: [Koha-bugs] [Bug 15601] New: TestBuilder tests are failing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15601 Bug ID: 15601 Summary: TestBuilder tests are failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:11:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:11:42 +0000 Subject: [Koha-bugs] [Bug 15601] TestBuilder tests are failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13624 --- Comment #1 from Jonathan Druart --- It has been introduced by DB structure changes of bug 13624. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:11:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:11:42 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15601 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15601 [Bug 15601] TestBuilder tests are failing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:13:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:13:09 +0000 Subject: [Koha-bugs] [Bug 15601] TestBuilder tests are failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:13:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:13:11 +0000 Subject: [Koha-bugs] [Bug 15601] TestBuilder tests are failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15601 --- Comment #2 from Jonathan Druart --- Created attachment 46898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46898&action=edit Bug 15601: Fix TestBuilder tests Bug 13624 modified the DB structure for overduerules. The TestBuilder tests (t/db_dependent/TestBuilder.t) based some of its checks on this structure. Test plan: prove t/db_dependent/TestBuilder.t Should return green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:22:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:22:21 +0000 Subject: [Koha-bugs] [Bug 15580] Confirm button not visible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15580 --- Comment #1 from Owen Leonard --- Created attachment 46899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46899&action=edit Screenshot showing the position of the list delete confirm button The button does not appear as it does in this screenshot, in the list of lists below the confirmation message? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:26:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:26:35 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #26 from Kyle M Hall --- Created attachment 46900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46900&action=edit Bug 14377 [QA Followup] - Add support for NORMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:29:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:29:54 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Failed QA |Signed Off --- Comment #27 from Kyle M Hall --- (In reply to Jonathan Druart from comment #25) > This is not marcflavour independent: 942$n is hardcoded, so it won't work > for UNIMARC > The XSLT changes have been done for MARC21 only, if NORMARC uses 942$n also, > it would be easy to c/p the changes to the according XSLT files. > > Does a UNIMARC user want to provide a patch for UNIMARC XSLT? As far as I can tell, UNIMARC does not have record suppression support! I based this on the fact that I can't find any reference to the Suppress index in marc_defs/unimarc, so unless I'm mistaken, it's a non-issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:31:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:31:57 +0000 Subject: [Koha-bugs] [Bug 15298] z39.50 admin setup, options column suggested changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46841|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 46901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46901&action=edit [SIGNED-OFF] Bug 15298 - z39.50 admin setup, options column suggested changes To Test- 1-first look at the orginal Z39.50/SRU servers administration page (/cgi-bin/koha/admin/z3950servers.pl?op=delete_confirmed&id=6) 2-apply patch 3-now see the new styling of the "action" drop down tab like the one on the saved reports page 4-check that each link works (for delete i reccommend copying one then deleting the copy) Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:31:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:31:55 +0000 Subject: [Koha-bugs] [Bug 15298] z39.50 admin setup, options column suggested changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:33:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:33:23 +0000 Subject: [Koha-bugs] [Bug 15601] TestBuilder tests are failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15601 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:33:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:33:25 +0000 Subject: [Koha-bugs] [Bug 15601] TestBuilder tests are failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15601 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46898|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 46902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46902&action=edit Bug 15601: Fix TestBuilder tests Bug 13624 modified the DB structure for overduerules. The TestBuilder tests (t/db_dependent/TestBuilder.t) based some of its checks on this structure. Test plan: prove t/db_dependent/TestBuilder.t Should return green. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:34:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:34:15 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #28 from Katrin Fischer --- I think the 'problem' with UNIMARC was that there was no default standard field chosen. The systempreference description used to say something about adding a suppress index. So that might be more complicated - as we don't know what people have already been using and not sure how hard it would be to pick a new default fiel for that purpose in UNIMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:39:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:39:05 +0000 Subject: [Koha-bugs] [Bug 15298] z39.50 admin setup, options column suggested changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 --- Comment #3 from Owen Leonard --- Some good possible follow-ups (or new bugs I guess): 1. Validate the HTML to identify some issues with duplicate IDs in the markup. I signed off on the patch because the page already had some duplicate IDs, so it didn't seem fair to hold it up for that. But we should make the page validate. 2. Eliminate the use of 'href="javascript:void(0);"' Progressive-enhancement best practices say that ideally a real URL should be used instead, one which is a fallback for non-JavaScript users. However, we don't require that the staff client be fully functional without JS turned on, so the accepted alternative is to use 'href="#"' The ConfirmDelete() function already returns false, so clicking the link won't result in the page jumping around. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:40:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:40:05 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 --- Comment #9 from Kyle M Hall --- (In reply to Jonathan Druart from comment #8) > Kyle, where is this enable/disable value used? "enabled" on a course item tells us if the fields have been swapped with the actual corresponding item fields. The incorrect assumption in the code was that the "enabled" value of the course an item was on would match the "enabled" value of the course itself. This is incorrect, as the value of "enabled" should be yes if *any* course the item is on is enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:43:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:43:26 +0000 Subject: [Koha-bugs] [Bug 15468] Search links on callnumbers with parentheses fails on OPAC results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master Summary|Search links on callnumber |Search links on callnumbers |fails on opac results page |with parentheses fails on | |OPAC results page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:44:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:44:15 +0000 Subject: [Koha-bugs] [Bug 15468] Search links on callnumbers with parentheses fails on OPAC results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:44:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:44:17 +0000 Subject: [Koha-bugs] [Bug 15468] Search links on callnumbers with parentheses fails on OPAC results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46844|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 46903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46903&action=edit [SIGNED-OFF] Bug 15468 - Search links on callnumbers with parentheses fails on OPAC results page To Test: 1-before plugin search in opac for a call number with either a "(" or a ")" in it 2-it should come back with no results 3-use plugin 4-re-search the call number with "(" or ")" 5-the search should come back with results Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:45:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:45:39 +0000 Subject: [Koha-bugs] [Bug 14810] Improve messages in patron anonymizing tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14810 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |brianagreally at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:51:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:51:35 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #29 from Jonathan Druart --- I will let a MARC21 user to QA this patchset, but I am pretty sure we need a unless UNIMARC statement in transformMARCXML4XSLT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:53:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:53:02 +0000 Subject: [Koha-bugs] [Bug 14810] Improve messages in patron anonymizing tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14810 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:53:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:53:05 +0000 Subject: [Koha-bugs] [Bug 14810] Improve messages in patron anonymizing tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14810 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46839|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 46904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46904&action=edit [SIGNED-OFF] Bug 14810 Improve messages in patron anonymizing tool To test: Create circulation records Go to 'http://localhost:8081/cgi-bin/koha/tools/cleanborrowers.pl' Anonymize patron checkout history Message should read 'All checkouts older than [date] have been anonymized When patch is not applied, message reads 'All patrons with checkouts older than [date] have been anonymized" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 16:54:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 15:54:03 +0000 Subject: [Koha-bugs] [Bug 15195] patron details should open in tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15195 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tasham_8 at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:05:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:05:36 +0000 Subject: [Koha-bugs] [Bug 15195] patron details should open in tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15195 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46838|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 46905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46905&action=edit [SIGNED-OFF] Bug 15195 - patron details should open in tab Deleted View record link and made patron details open in a new tab. To Test: Edit personal details for a user on opac and submit update request. In staff client go to patrons requesting modifications. Confirm view record link is gone and patron details opens in new tab. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:05:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:05:33 +0000 Subject: [Koha-bugs] [Bug 15195] patron details should open in tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15195 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:06:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:06:33 +0000 Subject: [Koha-bugs] [Bug 14406] When adding messages in patron account, only first name is shown in pull down In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14406 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |brianagreally at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:11:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:11:40 +0000 Subject: [Koha-bugs] [Bug 14406] When adding messages in patron account, only first name is shown in pull down In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14406 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46836|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 46906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46906&action=edit [SIGNED-OFF] Bug 14406 When adding messages in patron account, only first name is shown in pull down To test: Log in to staff patron account Go to Checkout tab Click 'Add a new message' Drop down box should show 'Staff - Internal Note' and 'OPAC - [Full name of patron]' Signed-off-by: Owen Leonard Made a tiny change during signoff: uncapitalized "note" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:11:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:11:37 +0000 Subject: [Koha-bugs] [Bug 14406] When adding messages in patron account, only first name is shown in pull down In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14406 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:14:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:14:44 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 --- Comment #27 from Jonathan Druart --- If JS is disabled, the .span2 is empty but takes a lot of space (even with small devices). If JS is enabled and you don't have a local cover image (and pref OPACLocalCoverImages is set), the space takes by the span2 is much more wide than the "no cover" image. I'd say it's not blocker, but I'd prefer someone confirm it's the expected behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:21:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:21:28 +0000 Subject: [Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 --- Comment #7 from Koha Team Lyon 3 --- Yes, we want to have statistics to know if holds have been cancelled because they have never been available or because they've not been picked up by the borrower. We can also imagine having different notices to warn borrowers that their holds have been cancelled : text can be different if the document isn't available or if the document was waiting but the borrowers didn't come to take it in time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:23:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:23:54 +0000 Subject: [Koha-bugs] [Bug 14538] POD for CalcFine is incomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14538 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:23:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:23:57 +0000 Subject: [Koha-bugs] [Bug 14538] POD for CalcFine is incomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14538 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46831|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 46907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46907&action=edit Bug 14538: editing perl doc for CalcFine To Test: Read perldoc C4/Overdues.pm Confirm that it says CalcFine returns four values and that rest of the documentation is correct NOTE: only a little visual ugliness, but definitely an improvement. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:25:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:25:13 +0000 Subject: [Koha-bugs] [Bug 15195] patron details should open in tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15195 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:25:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:25:16 +0000 Subject: [Koha-bugs] [Bug 15195] patron details should open in tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15195 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46905|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 46908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46908&action=edit Bug 15195 - patron details should open in tab Deleted View record link and made patron details open in a new tab. To Test: Edit personal details for a user on opac and submit update request. In staff client go to patrons requesting modifications. Confirm view record link is gone and patron details opens in new tab. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart I don't think it's a good idea to open a new tab (let the user decide) but the behavior already existed before this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:32:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:32:58 +0000 Subject: [Koha-bugs] [Bug 14538] POD for CalcFine is incomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:33:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:33:01 +0000 Subject: [Koha-bugs] [Bug 14538] POD for CalcFine is incomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46907|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 46909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46909&action=edit Bug 14538: editing perl doc for CalcFine To Test: Read perldoc C4/Overdues.pm Confirm that it says CalcFine returns four values and that rest of the documentation is correct NOTE: only a little visual ugliness, but definitely an improvement. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:33:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:33:19 +0000 Subject: [Koha-bugs] [Bug 14538] POD for CalcFine is incomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tasham_8 at hotmail.com CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:35:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:35:09 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:46:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:46:44 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:46:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:46:47 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 --- Comment #2 from Owen Leonard --- Created attachment 46910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46910&action=edit Bug 14193 - Accessibility: Searching patrons using the alphabetic index doesn't work Using a mouse to click on the alphabetic index letters works even though the anchor markup doesn't contain an href attribute. However you can't tab to them using the keyboard, and I assume the issue with screen readers is related. This patch adds a dummy href attribute and a class-based click handler so that we can get rid of the "onclick" attribute in the markup. To test, apply the patch and visit the "Patrons" section. 1. Use the tab key to move the focus to one of the alphabet links. 2. Hit "Enter" and confirm that the search is performed correctly. 3. Click any of the alphabet links and confirm that clicking works as well. 4. View the details of any patron and click the "Add child" button. 5. In the "Guarantor information" section click the "Change" button. 6. In the search popup, use the tab key to move the focus to one of the alphabet links. 2. Hit "Enter" and confirm that the search is performed correctly. 3. Click any of the alphabet links and confirm that clicking works as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:53:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:53:54 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15602 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:53:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:53:54 +0000 Subject: [Koha-bugs] [Bug 15602] New: Accessibility: Can't tab to add link in patron card creator add patrons popup Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Bug ID: 15602 Summary: Accessibility: Can't tab to add link in patron card creator add patrons popup Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/patroncards/add_user_search.pl OS: All Status: NEW Keywords: Academy Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, indradg at gmail.com, katrin.fischer at bsz-bw.de, kyle.m.hall at gmail.com, testopia at bugs.koha-community.org In the patron card creator, patrons are added to a batch from a popup window which lets you search existing patrons. In this popup window it is not possible to use the tab key to highlight the "Add" link. I assume this is because, like the problem in Bug 14193, the link has no href attribute. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:59:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:59:59 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15603 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:59:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:59:59 +0000 Subject: [Koha-bugs] [Bug 15603] New: Accessibility: Can't tab to select link in budgets add user popup Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 Bug ID: 15603 Summary: Accessibility: Can't tab to select link in budgets add user popup Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/add_user_search.pl OS: All Status: NEW Keywords: Academy Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, indradg at gmail.com, katrin.fischer at bsz-bw.de, kyle.m.hall at gmail.com, testopia at bugs.koha-community.org When editing a budget, owners or users are selected from a popup window which lets you search existing patrons. In this popup window it is not possible to use the tab key to highlight the "Select" link. I assume this is because, like the problem in Bug 15602, the link has no href attribute. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 17:59:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 16:59:59 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15603 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:00:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:00:41 +0000 Subject: [Koha-bugs] [Bug 15391] Some tests in HoldsQueue.t should not pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:00:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:00:43 +0000 Subject: [Koha-bugs] [Bug 15391] Some tests in HoldsQueue.t should not pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 --- Comment #5 from Jonathan Druart --- Created attachment 46911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46911&action=edit Bug 15391: Fix HoldsQueue.t tests Prior to this patch, in HoldsQueue.t: 63 my @item_types = C4::ItemType->all; 64 my $itemtype = grep { $_->{notforloan} == 1 } @item_types 65 or BAIL_OUT("No adequate itemtype"); Then we use the $itemtype variable (which contains the number of item types not for loan): 92 $dbh->do("INSERT INTO biblioitems (biblionumber, marcxml, itemtype) 93 VALUES ($biblionumber, '', '$itemtype')"); There is obviously something wrong here. The code should be 64 my @not_for_loan = grep { $_->{notforloan} == 1 } @item_types 65 or BAIL_OUT("No adequate itemtype"); 66 my $itemtype = $not_for_loan[0]->{itemtype}; But then some tests don't pass: Actually the problem comes from: commit bfbc646fdd9ca4b90a0bc2751d0faa95d9e93ba1 Bug 10336: HoldsQueue.t needs to create its own data -my $itemtype = $dbh->selectrow_array("SELECT min(itemtype) FROM itemtypes WHERE notforloan = 0") +my @item_types = C4::ItemType->all; +my $itemtype = grep { $_->{notforloan} == 1 } @item_types The line should have been: my $itemtype = grep { $_->{notforloan} == 0 } @item_types Test plan: Confirm that the tests still pass after this patch applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:00:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:00:52 +0000 Subject: [Koha-bugs] [Bug 15391] Some tests in HoldsQueue.t should not pass In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:01:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:01:36 +0000 Subject: [Koha-bugs] [Bug 15391] HoldsQueue.t does not handle for loan itemtypes correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Some tests in HoldsQueue.t |HoldsQueue.t does not |should not pass |handle for loan itemtypes | |correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:10:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:10:02 +0000 Subject: [Koha-bugs] [Bug 14406] When adding messages in patron account, only first name is shown in pull down In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14406 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:10:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:10:05 +0000 Subject: [Koha-bugs] [Bug 14406] When adding messages in patron account, only first name is shown in pull down In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14406 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46906|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 46912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46912&action=edit Bug 14406 When adding messages in patron account, only first name is shown in pull down To test: Log in to staff patron account Go to Checkout tab Click 'Add a new message' Drop down box should show 'Staff - Internal Note' and 'OPAC - [Full name of patron]' Signed-off-by: Owen Leonard Made a tiny change during signoff: uncapitalized "note" Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:10:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:10:55 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15604 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15604 [Bug 15604] Accessibility: Can't tab to select link in acquisitions basket add user popup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:10:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:10:55 +0000 Subject: [Koha-bugs] [Bug 15604] New: Accessibility: Can't tab to select link in acquisitions basket add user popup Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15604 Bug ID: 15604 Summary: Accessibility: Can't tab to select link in acquisitions basket add user popup Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/add_user_search.pl OS: All Status: NEW Keywords: Academy Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, indradg at gmail.com, katrin.fischer at bsz-bw.de, koha-bugs at lists.koha-community.org, kyle.m.hall at gmail.com, testopia at bugs.koha-community.org Depends on: 15602, 15603 When viewing a basket in Acquisitions, basket managers can be selected from a popup window which lets you search existing patrons. In this popup window it is not possible to use the tab key to highlight the "Select" link. I assume this is because, like the problem in Bug 15602, the link has no href attribute. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:10:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:10:55 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15604 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15604 [Bug 15604] Accessibility: Can't tab to select link in acquisitions basket add user popup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:13:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:13:05 +0000 Subject: [Koha-bugs] [Bug 14810] Improve messages in patron anonymizing tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14810 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:13:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:13:08 +0000 Subject: [Koha-bugs] [Bug 14810] Improve messages in patron anonymizing tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14810 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46904|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 46913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46913&action=edit Bug 14810 Improve messages in patron anonymizing tool To test: Create circulation records Go to 'http://localhost:8081/cgi-bin/koha/tools/cleanborrowers.pl' Anonymize patron checkout history Message should read 'All checkouts older than [date] have been anonymized When patch is not applied, message reads 'All patrons with checkouts older than [date] have been anonymized" Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:25:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:25:49 +0000 Subject: [Koha-bugs] [Bug 15605] New: Accessibility: Can't tab to add link in serials routing list add user popup Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 Bug ID: 15605 Summary: Accessibility: Can't tab to add link in serials routing list add user popup Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/add_user_search.pl OS: All Status: NEW Keywords: Academy Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com, gmcharlt at gmail.com, indradg at gmail.com, katrin.fischer at bsz-bw.de, koha-bugs at lists.koha-community.org, kyle.m.hall at gmail.com, testopia at bugs.koha-community.org Depends on: 15602, 15603, 15604 When adding users to a serial routing list, users can be selected from a popup window which lets you search existing patrons. In this popup window it is not possible to use the tab key to highlight the "Add" link. I assume this is because, like the problem in Bug 15602, the link has no href attribute. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15604 [Bug 15604] Accessibility: Can't tab to select link in acquisitions basket add user popup -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:25:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:25:49 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15605 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 [Bug 15605] Accessibility: Can't tab to add link in serials routing list add user popup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:25:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:25:49 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15605 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 [Bug 15605] Accessibility: Can't tab to add link in serials routing list add user popup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:25:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:25:49 +0000 Subject: [Koha-bugs] [Bug 15604] Accessibility: Can't tab to select link in acquisitions basket add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15604 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15605 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 [Bug 15605] Accessibility: Can't tab to add link in serials routing list add user popup -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:50:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:50:36 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:50:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:50:39 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46553|0 |1 is obsolete| | Attachment #46554|0 |1 is obsolete| | Attachment #46555|0 |1 is obsolete| | Attachment #46556|0 |1 is obsolete| | Attachment #46557|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 46914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46914&action=edit Bug 14695 - Update database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:50:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:50:46 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #24 from Kyle M Hall --- Created attachment 46915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46915&action=edit Bug 14695 - Update DB Schema file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:50:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:50:44 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #100 from Mirko Tietgen --- Hi Zeno, any news on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:50:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:50:49 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #25 from Kyle M Hall --- Created attachment 46916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46916&action=edit Bug 14695 - Add new circulation rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:50:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:50:52 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #26 from Kyle M Hall --- Created attachment 46917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46917&action=edit Bug 14695 - Tidy C4::Reserves::CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:50:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:50:55 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #27 from Kyle M Hall --- Created attachment 46918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46918&action=edit Bug 14695 - Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:50:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:50:59 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #28 from Kyle M Hall --- Created attachment 46919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46919&action=edit Bug 14695 [QA Followup] - Filling one hold fills all of them -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 18:51:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 17:51:02 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #29 from Kyle M Hall --- Created attachment 46920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46920&action=edit Bug 14695 [QA Followup] - Make existing unit tests pass * Removes tests no longer needed * Updates rules to work with existing tests * Fixes code issues revealed by unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:00:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:00:05 +0000 Subject: [Koha-bugs] [Bug 14613] Send cart window is too small in staff and hides 'send' button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14613 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:00:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:00:10 +0000 Subject: [Koha-bugs] [Bug 14613] Send cart window is too small in staff and hides 'send' button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14613 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46829|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 46921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46921&action=edit Bug 14613 Send cart window is too small in staff and hides 'send' button To Test: Add an item to cart click "cart" click "send" confirm that the send window is larger and the send button is visible NOTE: Remember to clear cache to refresh javascripts. This is much more visible if you zoom in 10% or more. This is larger, but more of a stop gap if you've got a large zoom. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:17:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:17:40 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Status|Needs Signoff |Failed QA --- Comment #3 from Nicole C. Engard --- Owen, I applied the patch and cleared my cache, but the tab is not going to the letters. Did I miss something? I'm in Firefox on Mac Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:29:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:29:26 +0000 Subject: [Koha-bugs] [Bug 15298] z39.50 admin setup, options column suggested changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:29:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:29:28 +0000 Subject: [Koha-bugs] [Bug 15298] z39.50 admin setup, options column suggested changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46901|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 46922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46922&action=edit Bug 15298 - z39.50 admin setup, options column suggested changes To Test- 1-first look at the orginal Z39.50/SRU servers administration page (/cgi-bin/koha/admin/z3950servers.pl?op=delete_confirmed&id=6) 2-apply patch 3-now see the new styling of the "action" drop down tab like the one on the saved reports page 4-check that each link works (for delete i reccommend copying one then deleting the copy) Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:29:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:29:35 +0000 Subject: [Koha-bugs] [Bug 15298] z39.50 admin setup, options column suggested changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 --- Comment #5 from Kyle M Hall --- Created attachment 46923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46923&action=edit Bug 15298 [QA Followup] - Fix whitespace issues Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:31:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:31:04 +0000 Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33963|0 |1 is obsolete| | --- Comment #21 from M. Tompsett --- Created attachment 46924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46924&action=edit Bug 13143 - Add a tool to show a Koha's password to test... 1/ run without any args, and get some help # koha-passwd Displays a Koha instance's password. Usage: /usr/sbin/koha-passwd instancename1 instancename2... Missing instance name... 2/ run with a bad instance, get an error # koha-passwd xxxxx Unknown instance xxxxx 3/ run with a correct instance, get a password # koha-passwd koha1 foofoo69 4/ run with many instances, get many passwords # koha-passwd koha1 koha2 koha3 foofoo69 foofoo68 foofoo67 Signed-off-by: Mason James Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:31:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:31:11 +0000 Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33964|0 |1 is obsolete| | --- Comment #22 from M. Tompsett --- Created attachment 46925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46925&action=edit Bug 13143 - follow up - usability improvements * makes sure output is not on the line with the prompt * adds ability to clear screen after password display Same test plan as for original bug. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:31:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:31:20 +0000 Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36435|0 |1 is obsolete| | --- Comment #23 from M. Tompsett --- Created attachment 46926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46926&action=edit Bug 13143: Followup - Correct the pause message 'read anykey' actually requires enter under sh. This patch changes the string from: 'Press any key to clear the screen...' to 'Press enter to clear the screen...' TEST PLAN --------- 1) Apply the first two patches 2) Trigger the script. 2) Press 'q' or anything other than enter when prompted. --- You could type a whole sentence! Oops! 3) Press enter. 4) Apply this patch 5) Trigger the script. 6) Be happy that you aren't told any key will work. 7) run koha qa tools Signed-off-by: Mirko Tietgen http://bugs.koha-community.org/show_bug.cgi?id=13141 Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:31:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:31:42 +0000 Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40817|0 |1 is obsolete| | --- Comment #24 from M. Tompsett --- Created attachment 46927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46927&action=edit Bug 13143 - Detect if the password is in a pipe 1. cd kohaclone/debian/scripts 2. sudo koha-passwd instance | cat Output should be password only 3. sudo koha-passwd instance Output should be "Password for $instance is: $password" Does this get at what you were wanting, Robin? NOTE: $ cd ~ $ sudo mkdir /etc/koha $ sudo mkdir /etc/koha/sites $ sudo mkdir /etc/koha/sites/library $ sudo ln -s ~/koha-dev/etc/koha-conf.xml /etc/koha/sites/library/koha-conf.xml $ sudo mkdir /usr/share/koha $ sudo ln -s ~/kohaclone/debian/scripts /usr/share/koha/bin This will fake out your system enough to get koha-passwd to run in your git system. Since you are using your git system, no need for the sudo's in steps 2 & 3. And no need to roll a custom build to test it. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:32:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:32:29 +0000 Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #25 from M. Tompsett --- Also corrected a rebase issue caused by the release of plack while I was at it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:33:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:33:40 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #35 from Christopher Brannon --- Awesome! Thank you! Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:37:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:37:51 +0000 Subject: [Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #6 from Christopher Brannon --- Bug 14694 has passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:42:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:42:08 +0000 Subject: [Koha-bugs] [Bug 15332] ModMember not interpreting dates (Batch patron modification) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz, | |mtj at kohaaloha.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12309 --- Comment #13 from Mason James --- (In reply to Fr?d?ric Demians from comment #12) > This patch has been pushed to 3.20.x, will be in 3.20.8. FYI: This bug also exists in the 3.18.x series, introduced in BZ-12309 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:42:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:42:08 +0000 Subject: [Koha-bugs] [Bug 12309] Add more fields to batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12309 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15332 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:50:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:50:17 +0000 Subject: [Koha-bugs] [Bug 15606] New: Spelling mistake in MARC21slim2OPACDetail.xsl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15606 Bug ID: 15606 Summary: Spelling mistake in MARC21slim2OPACDetail.xsl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: gel1163 at stacmail.net QA Contact: testopia at bugs.koha-community.org occurrence is spelt occurence in comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 20:59:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 19:59:42 +0000 Subject: [Koha-bugs] [Bug 15607] New: Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Bug ID: 15607 Summary: Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org The 'batch parton modification' tool seems to overwrite 'dateenrolled' and 'expirydate' fields with $todaysdate, if any of these fields are left unpopulated when updating confirmed on master 8db6b0f5330f16d4e3f100987597d0ce72645d07 to test... 1/ Set 'dateenrolled' and/or 'expirydate' fields of a test user 2/ Use 'batch parton modification' tool to update any other field (eg: 'State') 3/ Confirm that user's 'dateenrolled' and/or 'expirydate' fields have been incorrectly updated to $todays date :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:03:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:03:12 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 --- Comment #1 from Mason James --- Created attachment 46928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46928&action=edit updating 'state' field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:03:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:03:37 +0000 Subject: [Koha-bugs] [Bug 15606] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15606 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:03:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:03:39 +0000 Subject: [Koha-bugs] [Bug 15606] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15606 --- Comment #1 from Gus Ellerm --- Created attachment 46929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46929&action=edit 15606 - Spelling mistake Check if spelling mustake is corrected in file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:04:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:04:32 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 --- Comment #2 from Mason James --- Created attachment 46930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46930&action=edit 'dateenrolled' and 'expirydate' fields have now been modified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:06:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:06:05 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15332 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 [Bug 15332] ModMember not interpreting dates (Batch patron modification) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:06:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:06:05 +0000 Subject: [Koha-bugs] [Bug 15332] ModMember not interpreting dates (Batch patron modification) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15607 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:07:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:07:35 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:07:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:07:46 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12309 Depends on|15332 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 [Bug 15332] ModMember not interpreting dates (Batch patron modification) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:07:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:07:46 +0000 Subject: [Koha-bugs] [Bug 15332] ModMember not interpreting dates (Batch patron modification) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15607 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:07:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:07:46 +0000 Subject: [Koha-bugs] [Bug 12309] Add more fields to batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12309 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15607 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:08:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:08:57 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15332 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 [Bug 15332] ModMember not interpreting dates (Batch patron modification) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:08:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:08:57 +0000 Subject: [Koha-bugs] [Bug 15332] ModMember not interpreting dates (Batch patron modification) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15607 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:09:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:09:20 +0000 Subject: [Koha-bugs] [Bug 15608] New: Spelling mistake in MARC21slim2OPACDetail.xsl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15608 Bug ID: 15608 Summary: Spelling mistake in MARC21slim2OPACDetail.xsl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: gel1163 at stacmail.net QA Contact: testopia at bugs.koha-community.org Seperate -> Separate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:10:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:10:11 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:11:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:11:42 +0000 Subject: [Koha-bugs] [Bug 15609] New: spelling mistake in :692: writen ==> written Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15609 Bug ID: 15609 Summary: spelling mistake in :692: writen ==> written Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: chloealabaster at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com ~/Koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt: 692: writen ==> written -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:12:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:12:24 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 --- Comment #3 from Mason James --- (In reply to Mason James from comment #0) > The 'batch parton modification' tool seems to overwrite 'dateenrolled' and > 'expirydate' fields with $todaysdate, if any of these fields are left > unpopulated when updating > > confirmed on master 8db6b0f5330f16d4e3f100987597d0ce72645d07 ..this bug will also exist in 3.22.2 and 3.20.8 releases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:12:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:12:55 +0000 Subject: [Koha-bugs] [Bug 15608] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15608 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:12:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:12:58 +0000 Subject: [Koha-bugs] [Bug 15608] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15608 --- Comment #1 from Gus Ellerm --- Created attachment 46931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46931&action=edit 15608 - Spelling mistake in MARC21slim2OPACDetail.xsl Seperate -> separate test - check if spelling is changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:15:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:15:15 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:18:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:18:13 +0000 Subject: [Koha-bugs] [Bug 15610] New: Spelling mistake in NORMARCslim2OPACResults.xsl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15610 Bug ID: 15610 Summary: Spelling mistake in NORMARCslim2OPACResults.xsl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: gel1163 at stacmail.net QA Contact: testopia at bugs.koha-community.org fortelling ==> foretelling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:19:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:19:18 +0000 Subject: [Koha-bugs] [Bug 15611] New: spelling mistake /patroncards/edit-layout.tt:478: implimented ==> implemented 534: implimented ==> implemented Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15611 Bug ID: 15611 Summary: spelling mistake /patroncards/edit-layout.tt:478: implimented ==> implemented 534: implimented ==> implemented Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: chloealabaster at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com ~/Koha/koha-tmpl/intranet-tmpl/prog/en/module/patroncards/edit-layout.tt:478: implimented ==> implemented ./patroncards/edit-layout.tt:534: implimented ==> implemented -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:20:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:20:20 +0000 Subject: [Koha-bugs] [Bug 15391] HoldsQueue.t does not handle for loan itemtypes correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #6 from Aleisha Amohia --- t/db_dependent/HoldsQueue.t .. 3/23 # Failed test 'Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled' # at t/db_dependent/HoldsQueue.t line 413. # got: '1' # expected: '0' # Looks like you failed 1 test of 23. t/db_dependent/HoldsQueue.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/23 subtests Test Summary Report ------------------- t/db_dependent/HoldsQueue.t (Wstat: 256 Tests: 23 Failed: 1) Failed test: 23 Non-zero exit status: 1 Files=1, Tests=23, 1 wallclock secs ( 0.02 usr 0.01 sys + 1.39 cusr 0.08 csys = 1.50 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:20:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:20:54 +0000 Subject: [Koha-bugs] [Bug 15610] Spelling mistake in NORMARCslim2OPACResults.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15610 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:20:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:20:56 +0000 Subject: [Koha-bugs] [Bug 15610] Spelling mistake in NORMARCslim2OPACResults.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15610 --- Comment #1 from Gus Ellerm --- Created attachment 46932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46932&action=edit 15610 - Spelling mistake in NORMARCslim2OPACResults.xsl fortelling ==> foretelling Test - check if the change is made -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:22:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:22:09 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #8 from Aleisha Amohia --- (In reply to Kyle M Hall from comment #7) > (In reply to natasha from comment #6) > > Original patch did not apply > > fatal: sha1 information is lacking or useless (circ/circulation.pl). > > Repository lacks necessary blobs to fall back on 3-way merge. > > Cannot fall back to three-way merge. > > Patch failed at 0001 Bug 12920 - Remove AllowRenewalLimitOverride from pl > > scripts, use Koha.Preference instead > > I'm having no trouble applying this patch to the latest master. Can you try > again? > > Thanks! I think she meant that your didn't apply, which is why she submitted her patch and obseleted the first one. This needs to be tested now but I can't test it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:23:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:23:41 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:26:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:26:51 +0000 Subject: [Koha-bugs] [Bug 15612] New: spelling mistake /cataloguing/value_builder/normarc_field_008.tt:1303: fortelling ==> foretelling :1305: fortelling ==> foretelling Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15612 Bug ID: 15612 Summary: spelling mistake /cataloguing/value_builder/normarc_field_008.tt:1303: fortelling ==> foretelling :1305: fortelling ==> foretelling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: chloealabaster at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com ~/Koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/normarc_field_008.tt:1303: fortelling ==> foretelling ./cataloguing/value_builder/normarc_field_008.tt:1305: fortelling ==> foretelling -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:26:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:26:53 +0000 Subject: [Koha-bugs] [Bug 15613] New: Spelling mistake in opac-shelves.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15613 Bug ID: 15613 Summary: Spelling mistake in opac-shelves.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: gel1163 at stacmail.net QA Contact: testopia at bugs.koha-community.org paramter ==> parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:30:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:30:27 +0000 Subject: [Koha-bugs] [Bug 13474] Untranslatable log actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:30:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:30:29 +0000 Subject: [Koha-bugs] [Bug 13474] Untranslatable log actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 --- Comment #1 from Aleisha Amohia --- Created attachment 46933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46933&action=edit Bug 13474: Adding untranslatable log actions to viewlog.tt Please confirm this is the fix that you are looking for! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:31:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:31:58 +0000 Subject: [Koha-bugs] [Bug 15613] Spelling mistake in opac-shelves.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15613 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:32:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:32:00 +0000 Subject: [Koha-bugs] [Bug 15613] Spelling mistake in opac-shelves.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15613 --- Comment #1 from Gus Ellerm --- Created attachment 46934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46934&action=edit 15613 - Spelling mistake in opac-shelves.tt paramter ==> parameter Test - check the change is made in the file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:33:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:33:12 +0000 Subject: [Koha-bugs] [Bug 15614] New: spelling mistake ~/Koha/koha-tmpl/intranet-tmpl/prog/en//circ/pendingreserves.tt:137: Fullfilled ==> Fulfilled Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15614 Bug ID: 15614 Summary: spelling mistake ~/Koha/koha-tmpl/intranet-tmpl/prog/en//circ/pendingre serves.tt:137: Fullfilled ==> Fulfilled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: chloealabaster at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com ~/Koha/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/circ/pendingreserves.tt:137: Fullfilled ==> Fulfilled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:33:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:33:32 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15400 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:33:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:33:32 +0000 Subject: [Koha-bugs] [Bug 15400] display patron age in useful places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13931 CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:34:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:34:53 +0000 Subject: [Koha-bugs] [Bug 15615] New: Spelling mistake in opac-user.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15615 Bug ID: 15615 Summary: Spelling mistake in opac-user.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: gel1163 at stacmail.net QA Contact: testopia at bugs.koha-community.org transfered ==> transferred -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:36:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:36:17 +0000 Subject: [Koha-bugs] [Bug 15615] Spelling mistake in opac-user.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15615 --- Comment #1 from Gus Ellerm --- mistake made in a , cant fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:36:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:36:21 +0000 Subject: [Koha-bugs] [Bug 15400] display patron age in useful places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:36:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:36:25 +0000 Subject: [Koha-bugs] [Bug 15400] display patron age in useful places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45882|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 46935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46935&action=edit Bug 15400: Show patron age in search results Display patron age in search results and checkout details. Test plan ========= 1. Go to checkout page for one patron (cgi-bin/koha/circ/circulation.pl) 2. In the circulation menu to the left, under the patrons name you should see a new field "Age:" showing the patrons age, if a date of birth is available. 3. Enter a search term that will match more than one patron in the checkout search field 4. A new table column "Age" should be visible and display each patrons age 5. In cgi-bin/koha/members/member.pl enter a search filter that will match more than one patron 6. Each patrons age should be visible within parentheses to the right of the patron name NOTE: rebased to handle conflict with 13931, but I'm not sure this is fully needed, as 13931 adds date of birth. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:37:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:37:58 +0000 Subject: [Koha-bugs] [Bug 15614] spelling mistake ~/Koha/koha-tmpl/intranet-tmpl/prog/en//circ/pendingreserves.tt:137: Fullfilled ==> Fulfilled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15614 --- Comment #1 from Chloe Alabaster --- wrong directory, in ~/Koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt:137: Fullfilled ==> Fulfilled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:40:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:40:21 +0000 Subject: [Koha-bugs] [Bug 15616] New: Spelling mistake in opac-account.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15616 Bug ID: 15616 Summary: Spelling mistake in opac-account.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: gel1163 at stacmail.net QA Contact: testopia at bugs.koha-community.org Sucessfully ==> successfully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:43:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:43:01 +0000 Subject: [Koha-bugs] [Bug 15614] spelling mistake ~/Koha/koha-tmpl/intranet-tmpl/prog/en//circ/pendingreserves.tt:137: Fullfilled ==> Fulfilled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15614 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:43:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:43:03 +0000 Subject: [Koha-bugs] [Bug 15614] spelling mistake ~/Koha/koha-tmpl/intranet-tmpl/prog/en//circ/pendingreserves.tt:137: Fullfilled ==> Fulfilled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15614 --- Comment #2 from Chloe Alabaster --- Created attachment 46936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46936&action=edit Bug 15614 - spelling mistake ~/Koha/koha-tmpl/intranet-tmpl/prog/en//circ/pendingreserves.tt:137: Fullfilled ==> Fulfilled To Test: Check if "fullfilled" has been changed to "fulfilled" in line 137 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:43:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:43:36 +0000 Subject: [Koha-bugs] [Bug 15616] Spelling mistake in opac-account.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15616 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:43:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:43:38 +0000 Subject: [Koha-bugs] [Bug 15616] Spelling mistake in opac-account.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15616 --- Comment #1 from Gus Ellerm --- Created attachment 46937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46937&action=edit 15616 - Spelling mistake in ./opac-account.tt sucessfully ==> successfully Test - Check that the word has been changed in file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:43:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:43:49 +0000 Subject: [Koha-bugs] [Bug 15597] Typo in opac-auth-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:43:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:43:52 +0000 Subject: [Koha-bugs] [Bug 15597] Typo in opac-auth-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 46938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46938&action=edit Bug 15597: Typo in opac-auth-detail.tt Patch fix a small type To test: - Verify that a double punctuation mark colon (:) is fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:44:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:44:56 +0000 Subject: [Koha-bugs] [Bug 15597] Typo in opac-auth-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch CC| |hector.hecaxmmx at gmail.com Assignee|oleonard at myacpl.org |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:48:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:48:49 +0000 Subject: [Koha-bugs] [Bug 15400] display patron age in useful places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Aleisha Amohia --- I get a software error at Step 3-4 in your test plan: Template process failed: undef error - Date::Calc::Delta_YMD(): not a valid date at /usr/lib/perl5/Template/Plugin/Date.pm line 185. I think the patch for Bug 14763 to show the age on the details page is a better place than above the address like in this patch. I think that if we do want to show the age in brackets on member.pl search, maybe it should say (x years)? Doesn't make much sense to have all these random numbers next to names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:52:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:52:35 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #30 from Katrin Fischer --- Hi Kyle, can you please check status and patches? Patches are missing a sign-off or status is wrong :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:58:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:58:24 +0000 Subject: [Koha-bugs] [Bug 15611] spelling mistake /patroncards/edit-layout.tt:478: implimented ==> implemented 534: implimented ==> implemented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15611 --- Comment #1 from Chloe Alabaster --- Created attachment 46939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46939&action=edit Bug 15611 - spelling mistake /patroncards/edit-layout.tt:478: implimented ==> implemented 534: implimented ==> implemented To Test: check that "implimented" has been changed to "implemented" on both lines 478 and 534 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 21:58:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 20:58:22 +0000 Subject: [Koha-bugs] [Bug 15611] spelling mistake /patroncards/edit-layout.tt:478: implimented ==> implemented 534: implimented ==> implemented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15611 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:04:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:04:01 +0000 Subject: [Koha-bugs] [Bug 15609] spelling mistake in :692: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15609 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:04:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:04:06 +0000 Subject: [Koha-bugs] [Bug 15609] spelling mistake in :692: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15609 --- Comment #1 from Chloe Alabaster --- Created attachment 46940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46940&action=edit Bug 15609 - spelling mistake in :692: writen ==> written ToTest: check that "writen" has been changed to "written" on line 692 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:05:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:05:30 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:05:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:05:34 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46910|0 |1 is obsolete| | --- Comment #4 from Briana Greally --- Created attachment 46941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46941&action=edit Bug 14193 - Accessibility: Searching patrons using the alphabetic index doesn't work Using a mouse to click on the alphabetic index letters works even though the anchor markup doesn't contain an href attribute. However you can't tab to them using the keyboard, and I assume the issue with screen readers is related. This patch adds a dummy href attribute and a class-based click handler so that we can get rid of the "onclick" attribute in the markup. To test, apply the patch and visit the "Patrons" section. 1. Use the tab key to move the focus to one of the alphabet links. 2. Hit "Enter" and confirm that the search is performed correctly. 3. Click any of the alphabet links and confirm that clicking works as well. 4. View the details of any patron and click the "Add child" button. 5. In the "Guarantor information" section click the "Change" button. 6. In the search popup, use the tab key to move the focus to one of the alphabet links. 2. Hit "Enter" and confirm that the search is performed correctly. 3. Click any of the alphabet links and confirm that clicking works as well. Signed-off-by: Briana -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:05:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:05:52 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:06:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:06:04 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:08:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:08:00 +0000 Subject: [Koha-bugs] [Bug 15598] Typo in subscription-add.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15598 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:08:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:08:03 +0000 Subject: [Koha-bugs] [Bug 15598] Typo in subscription-add.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15598 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 46942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46942&action=edit Bug 15598: Typo in subscription-add.tt Fix white space in exclamation mark in subscription-add.tt To test: -Check that the space near to exclamation mark (!) is now fix up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:14:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:14:09 +0000 Subject: [Koha-bugs] [Bug 15598] Typo in subscription-add.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15598 --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 46943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46943&action=edit Bug 15598: Also fixing space near exclamation mark in other files To test: -Check that the space near to exclamation mark (!) is fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:15:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:15:22 +0000 Subject: [Koha-bugs] [Bug 15612] spelling mistake /cataloguing/value_builder/normarc_field_008.tt:1303: fortelling ==> foretelling :1305: fortelling ==> foretelling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15612 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:15:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:15:24 +0000 Subject: [Koha-bugs] [Bug 15612] spelling mistake /cataloguing/value_builder/normarc_field_008.tt:1303: fortelling ==> foretelling :1305: fortelling ==> foretelling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15612 --- Comment #1 from Chloe Alabaster --- Created attachment 46944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46944&action=edit Bug 15612 - spelling mistake /cataloguing/value_builder/normarc_field_008.tt:1303: fortelling ==> foretelling :1305: fortelling ==> foretelling To Test: check that "fortelling" has been changed to "foretelling" on line 1303 and 1305 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:15:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:15:48 +0000 Subject: [Koha-bugs] [Bug 15598] Typo in subscription-add.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15598 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Assignee|oleonard at myacpl.org |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:19:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:19:54 +0000 Subject: [Koha-bugs] [Bug 15592] spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15592 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:19:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:19:57 +0000 Subject: [Koha-bugs] [Bug 15592] spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15592 --- Comment #1 from Chloe Alabaster --- Created attachment 46945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46945&action=edit Bug 15592 - spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt To Test: checkthat "extention" has been changed to "extension" on line 27 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:50:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:50:04 +0000 Subject: [Koha-bugs] [Bug 15580] Confirm button not visible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15580 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chloealabaster at gmail.com --- Comment #2 from Chloe Alabaster --- Created attachment 46946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46946&action=edit my screeshot from deleting a private list This is what I found when trying to find were this problem was, I found this when going to delete one of my private lists that I created to try and find this problem. Am I looking in the wrong place? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:50:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:50:50 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 --- Comment #4 from Christopher Brannon --- Still problematic. Ran into this issue again. Caused by human error, but when correcting the situation, Koha displays confusing information. Really need the hold status updated and item routed correctly if the item is scanned at another location while waiting. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:57:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:57:17 +0000 Subject: [Koha-bugs] [Bug 10014] printcirculationslips missing documentation or obsolete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10014 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #4 from Aleisha Amohia --- I can't find this syspref - is this bug still valid? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 22:58:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 21:58:22 +0000 Subject: [Koha-bugs] [Bug 13703] batchRebuildBiblioTables.pl should also update from database to MARC Record. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13703 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:00:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:00:41 +0000 Subject: [Koha-bugs] [Bug 10014] printcirculationslips missing documentation or obsolete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10014 --- Comment #5 from Katrin Fischer --- Hi Aleisha, it still shows for me - did you check the local use tab? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:01:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:01:07 +0000 Subject: [Koha-bugs] [Bug 10014] printcirculationslips missing documentation or obsolete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10014 --- Comment #6 from Katrin Fischer --- You can't use the search for local use ones as they are not in the yaml file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:01:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:01:10 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jweaver at bywatersolutions.co | |m --- Comment #17 from Jesse Weaver --- Pushed to master. Thanks for your work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:03:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:03:48 +0000 Subject: [Koha-bugs] [Bug 10014] printcirculationslips missing documentation or obsolete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10014 --- Comment #7 from Aleisha Amohia --- Oh I see, found it! Should it also be in the circulation tab? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:04:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:04:47 +0000 Subject: [Koha-bugs] [Bug 10014] printcirculationslips missing documentation or obsolete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10014 --- Comment #8 from Katrin Fischer --- I think we need to find out what it does first - I got no idea. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:05:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:05:57 +0000 Subject: [Koha-bugs] [Bug 14613] Send cart window is too small in staff and hides 'send' button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14613 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:06:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:06:00 +0000 Subject: [Koha-bugs] [Bug 14613] Send cart window is too small in staff and hides 'send' button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14613 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46921|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 46947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46947&action=edit [PASSED QA] Bug 14613 Send cart window is too small in staff and hides 'send' button To Test: Add an item to cart click "cart" click "send" confirm that the send window is larger and the send button is visible NOTE: Remember to clear cache to refresh javascripts. This is much more visible if you zoom in 10% or more. This is larger, but more of a stop gap if you've got a large zoom. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:08:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:08:39 +0000 Subject: [Koha-bugs] [Bug 15570] circ/renew.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jweaver at bywatersolutions.co | |m --- Comment #8 from Jesse Weaver --- Pushed to master. Thanks for your work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:10:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:10:58 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:11:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:11:01 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46941|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 46948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46948&action=edit [PASSED QA] Bug 14193 - Accessibility: Searching patrons using the alphabetic index doesn't work Using a mouse to click on the alphabetic index letters works even though the anchor markup doesn't contain an href attribute. However you can't tab to them using the keyboard, and I assume the issue with screen readers is related. This patch adds a dummy href attribute and a class-based click handler so that we can get rid of the "onclick" attribute in the markup. To test, apply the patch and visit the "Patrons" section. 1. Use the tab key to move the focus to one of the alphabet links. 2. Hit "Enter" and confirm that the search is performed correctly. 3. Click any of the alphabet links and confirm that clicking works as well. 4. View the details of any patron and click the "Add child" button. 5. In the "Guarantor information" section click the "Change" button. 6. In the search popup, use the tab key to move the focus to one of the alphabet links. 2. Hit "Enter" and confirm that the search is performed correctly. 3. Click any of the alphabet links and confirm that clicking works as well. Signed-off-by: Briana Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:11:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:11:33 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 --- Comment #6 from Katrin Fischer --- Thx a lot for this, I had no idea where to start! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:20:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:20:38 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:27:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:27:35 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 --- Comment #11 from Katrin Fischer --- Created attachment 46949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46949&action=edit [PASSED QA] Bug 15354: Fix translated itemtype descriptions in circ rules In bug 14100, the admin/smart-rules.pl needed much more love. Indeed, the translated_description string should be used everywhere and replaced the previous 'humanitemtype'. Test plan: 1/ Translate some item types. 2/ Define some holds policy using these item types. 3/ Update the template strings 4/ Confirm that the "holds policy by item type" are displayed (for the default and specific library) and sorted by translated item type descriptions. Signed-off-by: Fr?d?ric Demians Signed-off-by: Jesse Weaver Passes QA tools. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:27:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:27:38 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 --- Comment #12 from Katrin Fischer --- Created attachment 46950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46950&action=edit [PASSED QA] Bug 15354: Sort itemtypes by translated description everywhere on circ rules admin page It's better to cmp on lc. Signed-off-by: Jesse Weaver Passes QA tools. Fixes sorting of dropdown for translated itemtype descriptions. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:27:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:27:41 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 --- Comment #13 from Katrin Fischer --- Created attachment 46951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46951&action=edit [PASSED QA] Bug 15354: (QA followup) remove tab character Signed-off-by: Jesse Weaver Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:28:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:28:25 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46281|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:28:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:28:27 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46282|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:28:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:28:28 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chloealabaster at gmail.com --- Comment #2 from Chloe Alabaster --- Created attachment 46952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46952&action=edit This is what I have done so far with the toolbar I changed the color of the tool bar so that it was no longer "transparent" however now from this you cant tell that the "submit" button is a button. Will start working on a way to make this noticeable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:28:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:28:29 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46283|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:35:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:35:59 +0000 Subject: [Koha-bugs] [Bug 15617] New: Be able to close "Click to edit" text boxes after opening them Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15617 Bug ID: 15617 Summary: Be able to close "Click to edit" text boxes after opening them Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 46953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46953&action=edit Click to edit text box on syspref I think that once you have opened a 'Click to edit' text box, you should be able to click a 'Cancel' or 'Hide' button and close it again. I realise you are able to collapse the box down by dragging the corner, but it would be nice to have a show and hide function. Leaving for someone better at javascript than me to figure out. I think preferences.tt and systempreferences.tt are the only files that have 'Click to edit' text boxes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:37:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:37:58 +0000 Subject: [Koha-bugs] [Bug 15568] Circ rules are not displayed anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15568 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #16 from Jesse Weaver --- Pushed to master, thanks for your work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:38:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:38:21 +0000 Subject: [Koha-bugs] [Bug 15601] TestBuilder tests are failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15601 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:38:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:38:23 +0000 Subject: [Koha-bugs] [Bug 15601] TestBuilder tests are failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15601 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46902|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 46954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46954&action=edit [PASSED QA] Bug 15601: Fix TestBuilder tests Bug 13624 modified the DB structure for overduerules. The TestBuilder tests (t/db_dependent/TestBuilder.t) based some of its checks on this structure. Test plan: prove t/db_dependent/TestBuilder.t Should return green. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:39:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:39:37 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jesse Weaver --- Pushed to master (after Cait added her QA stamp). Thanks for the work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:41:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:41:04 +0000 Subject: [Koha-bugs] [Bug 15468] Search links on callnumbers with parentheses fails on OPAC results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:41:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:41:54 +0000 Subject: [Koha-bugs] [Bug 15468] Search links on callnumbers with parentheses fails on OPAC results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |chloealabaster at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:42:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:42:24 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14193 CC| |tasham_8 at hotmail.com Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:42:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:42:24 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15603 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:43:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:43:57 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tasham_8 at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:44:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:44:56 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gel1163 at stacmail.net Assignee|gmcharlt at gmail.com |gel1163 at stacmail.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:45:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:45:28 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |chloealabaster at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:50:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:50:11 +0000 Subject: [Koha-bugs] [Bug 14538] POD for CalcFine is incomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14538 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Jesse Weaver --- Pushed to master, thanks for your work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:51:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:51:28 +0000 Subject: [Koha-bugs] [Bug 15618] New: Small typos in system preferences Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Bug ID: 15618 Summary: Small typos in system preferences Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:52:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:52:43 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:52:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:52:46 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 --- Comment #1 from Aleisha Amohia --- Created attachment 46955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46955&action=edit Bug 15618: Typos fixed in admin.pref To test: Confirm all typos under the Administration tab are fixed and that I haven't missed any. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:53:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:53:50 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:53:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:53:54 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 --- Comment #1 from Gus Ellerm --- Created attachment 46956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46956&action=edit 14647 - Make the file name extension dynamic on exporting records Test - 1. Go to /cgi-bin/koha/tools/export.pl and locate the Output format form 2. Change the file format from dropdown and notice the change in the 'File name' 3. Type a random name into ' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:59:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:59:17 +0000 Subject: [Koha-bugs] [Bug 15468] Search links on callnumbers with parentheses fails on OPAC results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 19 23:59:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 22:59:20 +0000 Subject: [Koha-bugs] [Bug 15468] Search links on callnumbers with parentheses fails on OPAC results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46903|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 46957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46957&action=edit [PASSED QA] Bug 15468 - Search links on callnumbers with parentheses fails on OPAC results page To Test: 1-before plugin search in opac for a call number with either a "(" or a ")" in it 2-it should come back with no results 3-use plugin 4-re-search the call number with "(" or ")" 5-the search should come back with results Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer It seems this only works with OPAC XSLT for results page turned off and OPACItemsResultsDisplay turned on. - Then the callnumbers in the result list will be linked for searching. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 00:00:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 23:00:49 +0000 Subject: [Koha-bugs] [Bug 14613] Send cart window is too small in staff and hides 'send' button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14613 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jweaver at bywatersolutions.co | |m --- Comment #4 from Jesse Weaver --- Pushed to master, thanks for your work! (I added a colon to the commit message for consistency's sake.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 00:06:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 23:06:29 +0000 Subject: [Koha-bugs] [Bug 15619] New: Spelling mistake in memberentry.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15619 Bug ID: 15619 Summary: Spelling mistake in memberentry.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: gel1163 at stacmail.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com konw ==> know -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 00:09:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 23:09:53 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 --- Comment #2 from Aleisha Amohia --- Created attachment 46958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46958&action=edit Bug 15618: Typos fixed in circulation.pref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 00:10:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 23:10:15 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 --- Comment #3 from Aleisha Amohia --- Am still working on this - not ready to sign off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 00:12:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 23:12:19 +0000 Subject: [Koha-bugs] [Bug 14406] When adding messages in patron account, only first name is shown in pull down In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14406 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Jesse Weaver --- Pushed to master, thanks for your work! (Added a colon to the commit message for consistency's sake.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 00:16:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 23:16:21 +0000 Subject: [Koha-bugs] [Bug 15619] Spelling mistake in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15619 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 00:16:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 23:16:23 +0000 Subject: [Koha-bugs] [Bug 15619] Spelling mistake in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15619 --- Comment #1 from Gus Ellerm --- Created attachment 46959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46959&action=edit 15619 - Spelling mistake in memberentry.pl Test - Check file for 'konw', notice no instance -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 00:17:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 23:17:52 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 --- Comment #10 from Katrin Fischer --- Hm, at the risk of people not being happy with me... this is what I think: The circulation history tab includes information about borrowers - the patrons who have checked out items of the record. If you have access to the circulation module, it seems 'more ok' to see that, then if you just have catalog permission in order to be able to do some minor tasks in the staff interface. A suggestion: If someone has only catalog - don't show the information about the patrons. If someone has circulation permissions - show all the columns. Could that work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 00:17:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 23:17:59 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 --- Comment #3 from Chloe Alabaster --- Created attachment 46960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46960&action=edit when testing it should look like this: this what the tool bar should look like with this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 00:19:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 23:19:25 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 --- Comment #4 from Chloe Alabaster --- Created attachment 46961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46961&action=edit when testing the hover: in addition to the screen shot above; when hovering over it should look like this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 00:24:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 23:24:43 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 00:24:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 23:24:45 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 --- Comment #5 from Chloe Alabaster --- Created attachment 46962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46962&action=edit Bug 15600 - System preferences broken toolbar looks broken To test: 1-see without patch the toolbar looks transparent and "broken" 2-apply patch, with this the toolbar is solid and has new colours (including the hover) -see screenshots for examples 3-try scrolling on different tabs to the left eg "OPAC" and that the style continues with them -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 00:36:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jan 2016 23:36:51 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 --- Comment #2 from Gus Ellerm --- Created attachment 46963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46963&action=edit 14647 - Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 01:34:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 00:34:58 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 01:50:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 00:50:02 +0000 Subject: [Koha-bugs] [Bug 15560] holding branch missing in pending reserves report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 01:50:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 00:50:05 +0000 Subject: [Koha-bugs] [Bug 15560] holding branch missing in pending reserves report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 --- Comment #3 from Katrin Fischer --- Created attachment 46964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46964&action=edit Bug 15560: Fix display of multiple branches and locations in pending reserves report The patches from bug 12152 broke the display on the pending reserves/ holds to pull report when items from multiple branches and with multiple locations were displayed. The table cells were left empty. To test: - Add a record with at least 2 items from different locations and holdingbranches - Open the 'holds to pull' report - Verify all branches and locations show with their correct description -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 01:51:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 00:51:33 +0000 Subject: [Koha-bugs] [Bug 15560] Multiple holding branchs and locations not displaying in pending holds report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |--- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Summary|holding branch missing in |Multiple holding branchs |pending reserves report |and locations not | |displaying in pending holds | |report -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 01:55:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 00:55:34 +0000 Subject: [Koha-bugs] [Bug 15560] Multiple holding branchs and locations not displaying in pending holds report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 --- Comment #4 from Katrin Fischer --- Forgot a step in my test plan: To test: - Add a record with at least 2 items from different locations and holdingbranches >>> Place a hold on it! - Open the 'holds to pull' report - Verify all branches and locations show with their correct description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 02:22:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 01:22:37 +0000 Subject: [Koha-bugs] [Bug 15287] Use font-awesome on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 Francesca changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |francescalamoore at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 02:31:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 01:31:52 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 --- Comment #1 from natasha --- Created attachment 46965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46965&action=edit Bug 15603 - Accessibility: Can't tab to select link in budgets add user popup To Test - 1. If you don't have a budget and a fund, make at least one of each. 2. Go to funds from budgets. 3. Either make a new fund or edit an existing one and then click Edit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 02:33:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 01:33:42 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 02:33:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 01:33:44 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46965|0 |1 is obsolete| | --- Comment #2 from natasha --- Created attachment 46966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46966&action=edit Bug 15603 - Accessibility: Can't tab to select link in budgets add user popup To Test - 1. If you don't have a budget and a fund, make at least one of each. 2. Go to funds from budgets. 3. Either make a new fund or edit an existing one and then click Edit owner, which will bring up a pop-up tab. 4. Search for a patron. 5. Using the tab key try to navigate onto the Select link. 6. Notice it skips select. 7. Apply the patch and then repeat steps 3-5, notice the select link can now be accessed through using the keyboard. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 02:37:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 01:37:55 +0000 Subject: [Koha-bugs] [Bug 15560] Multiple holding branchs and locations not displaying in pending holds report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 02:37:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 01:37:59 +0000 Subject: [Koha-bugs] [Bug 15560] Multiple holding branchs and locations not displaying in pending holds report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46964|0 |1 is obsolete| | --- Comment #5 from natasha --- Created attachment 46967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46967&action=edit Bug 15560: Fix display of multiple branches and locations in pending reserves report The patches from bug 12152 broke the display on the pending reserves/ holds to pull report when items from multiple branches and with multiple locations were displayed. The table cells were left empty. To test: - Add a record with at least 2 items from different locations and holdingbranches - Open the 'holds to pull' report - Verify all branches and locations show with their correct description Signed-off-by: Natasha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 02:42:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 01:42:05 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tasham_8 at hotmail.com Assignee|gmcharlt at gmail.com |tasham_8 at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 02:48:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 01:48:22 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from natasha --- Just noticed we created another bug, don't test this patch yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 02:55:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 01:55:15 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from natasha --- our mistake, you need to apply the patch from bug 14193 before this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 02:58:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 01:58:49 +0000 Subject: [Koha-bugs] [Bug 15604] Accessibility: Can't tab to select link in acquisitions basket add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15604 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tasham_8 at hotmail.com --- Comment #1 from natasha --- this is fixed by the patch on bug 15603, please update this that passes QA. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:03:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:03:18 +0000 Subject: [Koha-bugs] [Bug 15620] New: Tools: View Log = No Log Found Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15620 Bug ID: 15620 Summary: Tools: View Log = No Log Found Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: mustaqeemabd at gmail.com QA Contact: testopia at bugs.koha-community.org Hi, Our Koha just upgraded to 3.22.1 a few weeks ago. Just realized that there is an issue about View Log features. The problem is it just show "No Log Found" either for bibliographic records or patron. Kindly seek for help from Koha Community. Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:04:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:04:29 +0000 Subject: [Koha-bugs] [Bug 15620] Tools: View Log = No Log Found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15620 mustaqeem changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mustaqeemabd at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:36:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:36:59 +0000 Subject: [Koha-bugs] [Bug 15605] Accessibility: Can't tab to add link in serials routing list add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:37:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:37:02 +0000 Subject: [Koha-bugs] [Bug 15605] Accessibility: Can't tab to add link in serials routing list add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 --- Comment #1 from natasha --- Created attachment 46968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46968&action=edit Bug 15605 - Accessibility: Can't tab to add link in serials routing list add user popup To Test - 1. Go to Serials and search for a title and then click on it. 2. Click routing list and then Add recipients. 3. Search for a patron. 4. Using the tab key try to navigate onto the Add link. 5. Notice it skips Add. 6. Apply the patch and then repeat steps 1-4, notice the Add link can now be accessed through using the keyboard. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:43:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:43:59 +0000 Subject: [Koha-bugs] [Bug 15621] New: Spelling mistake in printinvoice Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15621 Bug ID: 15621 Summary: Spelling mistake in printinvoice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: gel1163 at stacmail.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com writen -> written -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:46:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:46:03 +0000 Subject: [Koha-bugs] [Bug 15597] Typo in opac-auth-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46938|0 |1 is obsolete| | --- Comment #2 from Briana Greally --- Created attachment 46969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46969&action=edit Bug 15597: Typo in opac-auth-detail.tt Patch fix a small type To test: - Verify that a double punctuation mark colon (:) is fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:47:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:47:07 +0000 Subject: [Koha-bugs] [Bug 15621] Spelling mistake in printinvoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15621 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:47:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:47:09 +0000 Subject: [Koha-bugs] [Bug 15621] Spelling mistake in printinvoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15621 --- Comment #1 from Gus Ellerm --- Created attachment 46970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46970&action=edit 15621 - Spelling mistake in printinvice.pl Test- search for writen, if not found patch sucsessful -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:48:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:48:51 +0000 Subject: [Koha-bugs] [Bug 15622] New: Spelling mistake in printfreercpt.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15622 Bug ID: 15622 Summary: Spelling mistake in printfreercpt.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: gel1163 at stacmail.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com writen -> written -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:50:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:50:32 +0000 Subject: [Koha-bugs] [Bug 15445] DateUtils.t fails on Jenkins due to server sluggishness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15445 --- Comment #7 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #6) > Tomas, do you know if the nodes are monitored? > It would be good to know if the server is overloaded when the test fails. I'll try to gather some information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:51:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:51:34 +0000 Subject: [Koha-bugs] [Bug 15597] Typo in opac-auth-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:51:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:51:37 +0000 Subject: [Koha-bugs] [Bug 15597] Typo in opac-auth-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 --- Comment #3 from Briana Greally --- Created attachment 46971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46971&action=edit mend Signed-off-by: Briana -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:51:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:51:41 +0000 Subject: [Koha-bugs] [Bug 15622] Spelling mistake in printfreercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15622 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:51:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:51:43 +0000 Subject: [Koha-bugs] [Bug 15622] Spelling mistake in printfreercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15622 --- Comment #1 from Gus Ellerm --- Created attachment 46972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46972&action=edit 15622 - Spelling mistake in printfeercpt.pl writen -> written Search the file for writen, when not found change sucsessful -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:53:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:53:25 +0000 Subject: [Koha-bugs] [Bug 15622] Spelling mistake in printfreercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15622 --- Comment #2 from Gus Ellerm --- Be advised, file in title is ironically spelt wrong. The correct file is printfeercpt.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:54:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:54:54 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chloealabaster at gmail.com Assignee|oleonard at myacpl.org |chloealabaster at gmail.com --- Comment #2 from Chloe Alabaster --- looks like it needs to be added onto multiple database tables, might try again tomorrow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:54:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:54:56 +0000 Subject: [Koha-bugs] [Bug 15623] New: Spelling mistake in boraccount.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15623 Bug ID: 15623 Summary: Spelling mistake in boraccount.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: gel1163 at stacmail.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com writen -> written -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:55:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:55:10 +0000 Subject: [Koha-bugs] [Bug 15598] Typo in subscription-add.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15598 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:55:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:55:13 +0000 Subject: [Koha-bugs] [Bug 15598] Typo in subscription-add.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15598 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46943|0 |1 is obsolete| | --- Comment #3 from Briana Greally --- Created attachment 46973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46973&action=edit Bug 15598: Also fixing space near exclamation mark in other files To test: -Check that the space near to exclamation mark (!) is fixed Signed-off-by: Briana -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:57:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:57:29 +0000 Subject: [Koha-bugs] [Bug 15623] Spelling mistake in boraccount.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15623 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:57:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:57:31 +0000 Subject: [Koha-bugs] [Bug 15623] Spelling mistake in boraccount.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15623 --- Comment #1 from Gus Ellerm --- Created attachment 46974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46974&action=edit 15623 - Spelling mistake in boraccount.pl Test - Search for writen, if not found fix is correct -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:57:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:57:37 +0000 Subject: [Koha-bugs] [Bug 15604] Accessibility: Can't tab to select link in acquisitions basket add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15604 --- Comment #2 from natasha --- To Test - 1. Go to Acquisitions and add vendor. 2. Click new basket and add an example. 3. Hit Add user which will open a pop-up tab. 4. Search for a patron. 5. Using the tab key try to navigate onto the Select link. 6. Notice it skips Select. 7. Apply the patch and then repeat steps 1-5, notice the Select link can now be accessed through using the keyboard. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 03:59:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 02:59:38 +0000 Subject: [Koha-bugs] [Bug 15595] Display Google Jacket image on staff client search list and detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brianagreally at gmail.com Assignee|koha-bugs at lists.koha-commun |brianagreally at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 04:11:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 03:11:07 +0000 Subject: [Koha-bugs] [Bug 15595] Display Google Jacket image on staff client search list and detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|brianagreally at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 04:13:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 03:13:03 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gel1163 at stacmail.net Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Gus Ellerm --- patch does not apply cleanly CONFLICT (content): Merge conflict in t/db_dependent/Serials.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 04:15:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 03:15:50 +0000 Subject: [Koha-bugs] [Bug 7181] Template indentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7181 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|paul.poulain at biblibre.com |tasham_8 at hotmail.com CC| |tasham_8 at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 04:28:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 03:28:12 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gel1163 at stacmail.net --- Comment #2 from Gus Ellerm --- Tried to test this and still generated errors. Not sure if it was due to me applying the process wrong or if patch is unusable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 04:37:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 03:37:20 +0000 Subject: [Koha-bugs] [Bug 15624] New: Spelling mistake in suggestion.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15624 Bug ID: 15624 Summary: Spelling mistake in suggestion.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: gel1163 at stacmail.net QA Contact: testopia at bugs.koha-community.org choosen ==> chosen agregate ==> aggregate noone ==> no one -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 04:47:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 03:47:42 +0000 Subject: [Koha-bugs] [Bug 15624] Spelling mistake in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15624 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 04:47:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 03:47:44 +0000 Subject: [Koha-bugs] [Bug 15624] Spelling mistake in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15624 --- Comment #1 from Gus Ellerm --- Created attachment 46975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46975&action=edit 15624 - Spelling mistake in suggestion.pl Test - due to noone being in a comparison name it was not changed 1. search for choosen, see that it was removed 2. search for agregate, see that it was removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 04:49:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 03:49:49 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 04:49:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 03:49:52 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 --- Comment #1 from natasha --- Created attachment 46976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46976&action=edit Bug 15602 - Accessibility: Can't tab to add link in patron card creator add patrons popup To Test - 1. Go onto Tools and then click on Patron Card Creator. 2. Click on New and then Card Batch. 3. Add a borrowernumber then add patron. 4. Search for a patron. 5. Using the tab key try to navigate onto the Add link. 6. Notice it skips Add. 7. Apply the patch and then repeat steps 1-5, notice the add link can now be accessed through using the keyboard. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 06:35:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 05:35:13 +0000 Subject: [Koha-bugs] [Bug 15625] New: Add CLI tool to enable/disable public z39 service, for a Koha instance Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15625 Bug ID: 15625 Summary: Add CLI tool to enable/disable public z39 service, for a Koha instance Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Add CLI tool to enable/disable public z39 service, for a Koha instance more info to come... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 06:35:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 05:35:45 +0000 Subject: [Koha-bugs] [Bug 15625] Add CLI tool to enable/disable public z39 service, for a Koha instance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15625 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 08:05:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 07:05:56 +0000 Subject: [Koha-bugs] [Bug 15598] Typo in subscription-add.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15598 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 08:05:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 07:05:59 +0000 Subject: [Koha-bugs] [Bug 15598] Typo in subscription-add.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15598 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46942|0 |1 is obsolete| | Attachment #46973|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 46977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46977&action=edit [PASSED QA] Bug 15598: Typo in subscription-add.tt Fix white space in exclamation mark in subscription-add.tt To test: -Check that the space near to exclamation mark (!) is now fix up Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 08:06:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 07:06:34 +0000 Subject: [Koha-bugs] [Bug 15598] Typo in subscription-add.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15598 --- Comment #5 from Katrin Fischer --- Created attachment 46978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46978&action=edit [PASSED QA] Bug 15598: Also fixing space near exclamation mark in other files To test: -Check that the space near to exclamation mark (!) is fixed Signed-off-by: Briana Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 08:09:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 07:09:04 +0000 Subject: [Koha-bugs] [Bug 15597] Typo in opac-auth-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 --- Comment #4 from Katrin Fischer --- Hi Briana, I think the second patch was unintentionally added? 'mend' from git --amend maybe? I am obsoleting it and adding your sign off line to the first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 08:09:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 07:09:14 +0000 Subject: [Koha-bugs] [Bug 15597] Typo in opac-auth-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46971|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 08:10:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 07:10:38 +0000 Subject: [Koha-bugs] [Bug 15597] Typo in opac-auth-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 08:10:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 07:10:41 +0000 Subject: [Koha-bugs] [Bug 15597] Typo in opac-auth-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46969|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 46979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46979&action=edit [PASSED-QA] Bug 15597: Typo in opac-auth-detail.tt Patch fix a small type To test: - Verify that a double punctuation mark colon (:) is fix it. Signed-off-by: Briana Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 09:17:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 08:17:33 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #35 from Viktor Sarge --- (In reply to Brendan Gallagher from comment #34) > Has this been submitted on another bug? I just looked at the git repo and > haven't seen an update in awhile. As far as I know they are not happy with performance yet and will rework this patch before anything interesting starts happening. I do hope that it will get done in time for the may release since it's a feature I'd love to see, but I don't think anything is happening right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 09:35:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 08:35:32 +0000 Subject: [Koha-bugs] [Bug 12750] koha-create should be able to configure SRU server for the created instance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12750 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- We just tried this on a new 3.22 server - but the variables in the koha-conf.xml file were not replaced correctly: koha-create --create-db --enable-sru __ZEBRA_SRU_HOST__ __ZEBRA_SRU_BIBLIOS_PORT__ biblios ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 09:38:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 08:38:21 +0000 Subject: [Koha-bugs] [Bug 15391] HoldsQueue.t does not handle for loan itemtypes correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 --- Comment #7 from Jonathan Druart --- Aleisha, could you confirm the tests pass before the patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 09:51:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 08:51:09 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 09:51:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 08:51:11 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 --- Comment #4 from Jonathan Druart --- Created attachment 46980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46980&action=edit Bug 15607: batch patron mod - do not update dates if not given Bug 15332 fixed a bug but introduced a bigger one. Even if dateenrolled and dateexpiry are not modified, they will be updated to today. Indeed, dt_from_string returns today without parameters. Test plan: - Set dateenrolled and expirydate for a patron - Using the batch patron mod tool, update any field but dateenrolled and expirydate. => Without this patch, the 2 date fields should be set to today => With this patch applied, the 2 date fields should not have been modified. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 09:51:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 08:51:26 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 09:58:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 08:58:38 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 10:18:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 09:18:52 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #36 from Fr?d?ric Demians --- Bug 9580 feature is an alternative option which is functional. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 10:41:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 09:41:45 +0000 Subject: [Koha-bugs] [Bug 15560] Multiple holding branchs and locations not displaying in pending holds report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 10:41:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 09:41:51 +0000 Subject: [Koha-bugs] [Bug 15560] Multiple holding branchs and locations not displaying in pending holds report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 --- Comment #7 from Jonathan Druart --- Created attachment 46982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46982&action=edit Bug 15560: Fix display of multiple item types in pending reserves report Same fix as previous patch, but for item types. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 10:41:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 09:41:48 +0000 Subject: [Koha-bugs] [Bug 15560] Multiple holding branchs and locations not displaying in pending holds report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46967|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 46981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46981&action=edit Bug 15560: Fix display of multiple branches and locations in pending reserves report The patches from bug 12152 broke the display on the pending reserves/ holds to pull report when items from multiple branches and with multiple locations were displayed. The table cells were left empty. To test: - Add a record with at least 2 items from different locations and holdingbranches - Open the 'holds to pull' report - Verify all branches and locations show with their correct description Signed-off-by: Natasha Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 10:48:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 09:48:51 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Karam Qubsi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46980|0 |1 is obsolete| | CC| |karamqubsi at gmail.com --- Comment #5 from Karam Qubsi --- Created attachment 46983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46983&action=edit [SIGNED-OFF] Bug 15607: batch patron mod - do not update dates if not given batch works as described before applying this batch if you make (Batch patrons modification) all the Registration date and Expiry date fields for the affected patrons will be with today date and the original data will be lost . After applying this batch everything work fine . Thank you Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 10:49:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 09:49:07 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Karam Qubsi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 10:59:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 09:59:37 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 --- Comment #10 from Jonathan Druart --- So if I understand correctly (not sure at all!), the course_items.enabled values could be retrieved from course_reserves.enabled? In this case, why don't we remove this column instead of trying to keep it up-to-date? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 11:27:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 10:27:58 +0000 Subject: [Koha-bugs] [Bug 15626] New: koha-remove does not remove log4perl.conf Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15626 Bug ID: 15626 Summary: koha-remove does not remove log4perl.conf Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 14167 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 [Bug 14167] Add Koha::Logger based on Log4perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 11:27:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 10:27:58 +0000 Subject: [Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15626 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15626 [Bug 15626] koha-remove does not remove log4perl.conf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 11:32:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 10:32:15 +0000 Subject: [Koha-bugs] [Bug 15626] koha-remove does not remove log4perl.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15626 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 11:32:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 10:32:17 +0000 Subject: [Koha-bugs] [Bug 15626] koha-remove does not remove log4perl.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15626 --- Comment #1 from Jonathan Druart --- Created attachment 46984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46984&action=edit Bug 15626: Remove log4perl.conf when using koha-remove if you create a koha install using koha-create, and remove it with koha-remove, the /etc/koha/sites/$SITE/ directory won't be removed, because the /etc/koha/sites/$SITE/log4perl.conf has not been removed by this script. Test plan: Use this koha-remove script to remove a koha install Without this patch, the /etc/koha/sites/$SITE directory won't be removed. With this patch applied, the directory will be correctly removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 11:49:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 10:49:12 +0000 Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 11:49:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 10:49:15 +0000 Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46924|0 |1 is obsolete| | Attachment #46925|0 |1 is obsolete| | Attachment #46926|0 |1 is obsolete| | Attachment #46927|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 46985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46985&action=edit Bug 13143 - Add a tool to show a Koha's password to test... 1/ run without any args, and get some help # koha-passwd Displays a Koha instance's password. Usage: /usr/sbin/koha-passwd instancename1 instancename2... Missing instance name... 2/ run with a bad instance, get an error # koha-passwd xxxxx Unknown instance xxxxx 3/ run with a correct instance, get a password # koha-passwd koha1 foofoo69 4/ run with many instances, get many passwords # koha-passwd koha1 koha2 koha3 foofoo69 foofoo68 foofoo67 Signed-off-by: Mason James Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 11:49:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 10:49:18 +0000 Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143 --- Comment #27 from Jonathan Druart --- Created attachment 46986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46986&action=edit Bug 13143 - follow up - usability improvements * makes sure output is not on the line with the prompt * adds ability to clear screen after password display Same test plan as for original bug. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 11:49:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 10:49:22 +0000 Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143 --- Comment #28 from Jonathan Druart --- Created attachment 46987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46987&action=edit Bug 13143: Followup - Correct the pause message 'read anykey' actually requires enter under sh. This patch changes the string from: 'Press any key to clear the screen...' to 'Press enter to clear the screen...' TEST PLAN --------- 1) Apply the first two patches 2) Trigger the script. 2) Press 'q' or anything other than enter when prompted. --- You could type a whole sentence! Oops! 3) Press enter. 4) Apply this patch 5) Trigger the script. 6) Be happy that you aren't told any key will work. 7) run koha qa tools Signed-off-by: Mirko Tietgen http://bugs.koha-community.org/show_bug.cgi?id=13141 Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 11:49:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 10:49:26 +0000 Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143 --- Comment #29 from Jonathan Druart --- Created attachment 46988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46988&action=edit Bug 13143 - Detect if the password is in a pipe 1. cd kohaclone/debian/scripts 2. sudo koha-passwd instance | cat Output should be password only 3. sudo koha-passwd instance Output should be "Password for $instance is: $password" Does this get at what you were wanting, Robin? NOTE: $ cd ~ $ sudo mkdir /etc/koha $ sudo mkdir /etc/koha/sites $ sudo mkdir /etc/koha/sites/library $ sudo ln -s ~/koha-dev/etc/koha-conf.xml /etc/koha/sites/library/koha-conf.xml $ sudo mkdir /usr/share/koha $ sudo ln -s ~/kohaclone/debian/scripts /usr/share/koha/bin This will fake out your system enough to get koha-passwd to run in your git system. Since you are using your git system, no need for the sudo's in steps 2 & 3. And no need to roll a custom build to test it. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 11:57:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 10:57:09 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #53 from Jonathan Druart --- Could someone signoff the last 5 patches please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 12:25:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 11:25:03 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 joe <15379joe at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |15379joe at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 12:27:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 11:27:09 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #31 from Kyle M Hall --- (In reply to Katrin Fischer from comment #30) > Hi Kyle, can you please check status and patches? Patches are missing a > sign-off or status is wrong :) Indeed, my bad! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 12:28:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 11:28:28 +0000 Subject: [Koha-bugs] [Bug 15628] New: Remove get_branchinfos_of vestiges Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15628 Bug ID: 15628 Summary: Remove get_branchinfos_of vestiges Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 7034 Blocks: 15293 The C4::Branch::get_branchinfos_of subroutine has been removed by bug 7034, but 2 occurrences have been left git grep get_branchinfos_of C4/Branch.pm: &get_branchinfos_of t/db_dependent/Branch.t: get_branchinfos_of Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7034 [Bug 7034] De-nesting C4::Branch http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 [Bug 15293] Move the C4::Branch related code to Koha::Libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 12:28:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 11:28:28 +0000 Subject: [Koha-bugs] [Bug 7034] De-nesting C4::Branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7034 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15628 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15628 [Bug 15628] Remove get_branchinfos_of vestiges -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 12:28:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 11:28:28 +0000 Subject: [Koha-bugs] [Bug 15293] Move the C4::Branch related code to Koha::Libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15628 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15628 [Bug 15628] Remove get_branchinfos_of vestiges -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 12:29:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 11:29:35 +0000 Subject: [Koha-bugs] [Bug 15628] Remove get_branchinfos_of vestiges In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15628 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 12:29:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 11:29:38 +0000 Subject: [Koha-bugs] [Bug 15628] Remove get_branchinfos_of vestiges In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15628 --- Comment #1 from Jonathan Druart --- Created attachment 46989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46989&action=edit Bug 15628: Remove get_branchinfos_of vestiges The C4::Branch::get_branchinfos_of subroutine has been removed by bug 7034, but 2 occurrences have been left git grep get_branchinfos_of C4/Branch.pm: &get_branchinfos_of t/db_dependent/Branch.t: get_branchinfos_of Test plan: git grep get_branchinfos_of should not return any occurrences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 12:36:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 11:36:13 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 --- Comment #11 from Kyle M Hall --- (In reply to Jonathan Druart from comment #10) > So if I understand correctly (not sure at all!), the course_items.enabled > values could be retrieved from course_reserves.enabled? > In this case, why don't we remove this column instead of trying to keep it > up-to-date? No, that is not quite right, here is the mapping: courses <=> courses_reserves <=> course_items course_reserves is a many to many join table between courses and course_items, so that a given item can be on course reserve for many courses at once. The short answer is, if all courses a course_item is part of are disabled, then the course_item should be disabled. If *any* of the courses are enabled, the course_item should be enabled. The 'enabled' flag again tells us whether the itype, ccode, holdingbranch and/or location field have been swapped with the originals. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 12:41:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 11:41:15 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 --- Comment #11 from Kyle M Hall --- (In reply to Katrin Fischer from comment #10) > Hm, at the risk of people not being happy with me... this is what I think: > > The circulation history tab includes information about borrowers - the > patrons who have checked out items of the record. > > If you have access to the circulation module, it seems 'more ok' to see > that, then if you just have catalog permission in order to be able to do > some minor tasks in the staff interface. > > A suggestion: If someone has only catalog - don't show the information about > the patrons. If someone has circulation permissions - show all the columns. > > Could that work? That sounds like a good approach. So, to be clear about it, you are proposing that if the librarian does not have the circulation permission, the first column ( Patron ) should not be displayed, correct? This would need to be done at the template level so the data is not just hidden from view, but would not be in the HTML source at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 12:44:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 11:44:21 +0000 Subject: [Koha-bugs] [Bug 15391] HoldsQueue.t does not handle for loan itemtypes correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 12:44:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 11:44:23 +0000 Subject: [Koha-bugs] [Bug 15391] HoldsQueue.t does not handle for loan itemtypes correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46911|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 46990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46990&action=edit Bug 15391: Fix HoldsQueue.t tests Prior to this patch, in HoldsQueue.t: 63 my @item_types = C4::ItemType->all; 64 my $itemtype = grep { $_->{notforloan} == 1 } @item_types 65 or BAIL_OUT("No adequate itemtype"); Then we use the $itemtype variable (which contains the number of item types not for loan): 92 $dbh->do("INSERT INTO biblioitems (biblionumber, marcxml, itemtype) 93 VALUES ($biblionumber, '', '$itemtype')"); There is obviously something wrong here. The code should be 64 my @not_for_loan = grep { $_->{notforloan} == 1 } @item_types 65 or BAIL_OUT("No adequate itemtype"); 66 my $itemtype = $not_for_loan[0]->{itemtype}; But then some tests don't pass: Actually the problem comes from: commit bfbc646fdd9ca4b90a0bc2751d0faa95d9e93ba1 Bug 10336: HoldsQueue.t needs to create its own data -my $itemtype = $dbh->selectrow_array("SELECT min(itemtype) FROM itemtypes WHERE notforloan = 0") +my @item_types = C4::ItemType->all; +my $itemtype = grep { $_->{notforloan} == 1 } @item_types The line should have been: my $itemtype = grep { $_->{notforloan} == 0 } @item_types Test plan: Confirm that the tests still pass after this patch applied. Signed-off-by: Kyle M Hall All tests pass pre and post patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 12:45:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 11:45:08 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 --- Comment #12 from Katrin Fischer --- Yep, that's what I was thinking. The page level permission could be catalog - which every staff member should have. Then adjust the datatable to hide the first column iirc in the template itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 12:53:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 11:53:38 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 --- Comment #3 from Kyle M Hall --- (In reply to Gus Ellerm from comment #2) > Tried to test this and still generated errors. > Not sure if it was due to me applying the process wrong or if patch is > unusable. Everything still works for me. Did you apply bug 14598 first? If so, can you paste the output of the unit tests here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 13:15:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 12:15:37 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46835|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 46991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46991&action=edit Bug 12920 - Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead Per the new guidelines, AllowRenewalLimitOverride should not be referenced in circulation.pl or moremember.pl Test Plan: 1) Apply this patch 2) Go to circulation.pl 3) Ensure you can still override renewal limits with pref enabled 4) Ensure you can not override renewal limits with pref disabled 5) Go to moremember.pl 6) Repeat steps 3-4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 13:17:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 12:17:16 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 13:17:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 12:17:18 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46991|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 46992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46992&action=edit bug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha.Preference instead Test Plan: 1) Apply this patch 2) Go to circulation.pl 3) Ensure you can still override renewal limits with pref enabled 4) Ensure you can not override renewal limits with pref disabled 5) Go to moremember.pl 6) Repeat steps 3-4 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 13:40:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 12:40:26 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #30 from Kyle M Hall --- Created attachment 46993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46993&action=edit Bug 14377 [QA Followup] - Don't do 942$n processing for UNIMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 13:52:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 12:52:14 +0000 Subject: [Koha-bugs] [Bug 15589] OPAC Lists "his" string fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15589 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 13:52:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 12:52:16 +0000 Subject: [Koha-bugs] [Bug 15589] OPAC Lists "his" string fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15589 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46825|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 46994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46994&action=edit [SIGNED-OFF] Bug 15589: Changing 'his' to 'their' in OPAC lists To be more gender neutral To test: 1) Go to OPAC lists (opac-shelves.pl) 2) Confirm it now says "Allow anyone to remove their own contributed entries." Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 14:07:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 13:07:20 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 14:07:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 13:07:22 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46828|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 46995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46995&action=edit [SIGNED-OFF] Bug 15571 reserveforothers permission does not remove Search to hold button from patron account To Test: 1. Create a user without 'reserveforothers' permission 2. Go onto user details 3. 'Search to hold' button should not be there 4. Create a user with 'reserveforothers' permission 5. Repeat steps 6. 'Search to Hold' button should be there Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 14:14:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 13:14:22 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se --- Comment #76 from Viktor Sarge --- Fr?d?ric made me aware that this one could be an alternative to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 One thing that's been a problem with cover images is the different caching policies from the providers which is of course unfortunate. Does this patch by any chance implement setting caching on/off per source to handle this? (Sorry if I'm being lazy, but searching for cach* in this thread gives a bit many hits) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 14:26:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 13:26:08 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr, | |julian.maurice at biblibre.com --- Comment #6 from Jonathan Druart --- CCing Rmaint 3.22 and 3.20: this fix must be in the 3.22.2 and 3.20.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:14:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:14:34 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #4 from Owen Leonard --- In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:15:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:15:19 +0000 Subject: [Koha-bugs] [Bug 15628] Remove get_branchinfos_of vestiges In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15628 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15629 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:15:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:15:19 +0000 Subject: [Koha-bugs] [Bug 15629] New: Move the C4::Branch related code to Koha::Libraries - part 3 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Bug ID: 15629 Summary: Move the C4::Branch related code to Koha::Libraries - part 3 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 15628 Blocks: 15293 Part 1 (bug 15294) and part 2 (bug 15295) have been pushed. This third part will remove some C4::Branch subroutines: - GetBranchesInCategory - GetBranchDetail - ModBranch - GetBranchInfo Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 [Bug 15293] Move the C4::Branch related code to Koha::Libraries http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15628 [Bug 15628] Remove get_branchinfos_of vestiges -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:15:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:15:19 +0000 Subject: [Koha-bugs] [Bug 15293] Move the C4::Branch related code to Koha::Libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15629 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:21:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:21:08 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33957|0 |1 is obsolete| | Attachment #44079|0 |1 is obsolete| | Attachment #44080|0 |1 is obsolete| | Attachment #44082|0 |1 is obsolete| | Attachment #44083|0 |1 is obsolete| | Attachment #44084|0 |1 is obsolete| | --- Comment #131 from Colin Campbell --- Created attachment 46996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46996&action=edit Amended patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:24:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:24:22 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #132 from Colin Campbell --- Patch with consolidated modifications including ordrsps (and order cancellation as a result) Will update Zeno's patch to Acquisition.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:31:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:31:55 +0000 Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and volumne information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- This patch breaks the detail view for me (no bibliographic data appears). Errors in the log: Error while parsing stylesheet: compilation error: file /koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl element text xsltParseTemplateContent: xslt:text content problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:36:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:36:32 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:36:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:36:35 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #1 from Jonathan Druart --- Created attachment 46997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46997&action=edit Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (1) For consistency, the branchcodes method of Koha::LibraryCategory should be named libraries. At the moment, there is only one occurrence, in admin/branches.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:36:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:36:37 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #2 from Jonathan Druart --- Created attachment 46998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46998&action=edit Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (2) C4::Branch::GetBranchesInCategory can be replaced with Koha::LibraryCategory->libraries Test plan: 1/ Define some 1+ group of libraries with 1+ libraries each 2/ Go on the advanced search (OPAC and Staff) and select a group of libraries 3/ The result should be consistent and only include record from these libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:36:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:36:40 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #3 from Jonathan Druart --- Created attachment 46999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46999&action=edit Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (3) C4::Branch::GetBranchesInCategory is not used anymore and can be removed. Test plan: git grep GetBranchesInCategory should not return any result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:36:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:36:46 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #4 from Jonathan Druart --- Created attachment 47000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47000&action=edit Bug 15629: Koha::Libraries - Remove GetBranchDetail C4::Branch::GetBranchDetail retrieved library infos, it could be easily replaced with Koha::Libraries->find When this change needs other big changes, the unblessed method is called, to manipulate a hashref (as before) instead of a Koha::Library object (for instance when $library is sent to GetPreparedLetter). Test plan: 1/ Print a basket group, the library names should be correctly displayed. 2/ Enable emailLibrarianWhenHoldIsPlaced and place a hold, a HOLDPLACED notice will be generated (focus on the library name) 3/ Edit a patron and change his/her library 4/ Generate the advanced notices (misc/cronjobs/advance_notices.pl) and have a look at the generated notices 5/ Same of overdues notices 6/ Set IndependentBranches and use a non superlibrarian user to place a hold. The "pickup at" should be correctly filled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:36:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:36:49 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #5 from Jonathan Druart --- Created attachment 47001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47001&action=edit Bug 15629: Koha::Libraries - Remove ModBranch This subroutine was only used in tests to add/update a library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:36:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:36:51 +0000 Subject: [Koha-bugs] [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #6 from Jonathan Druart --- Created attachment 47002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47002&action=edit Bug 15629: Koha::Libraries - Remove GetBranchInfo C4::Branch::GetBranchInfo was only used once in opac/opac-suggestions.pl The occurrence can easily be replaced by a call to Koha::Libraries->find Test plan: 1/ Create a suggestion for library A 2/ Enable OPACViewOthersSuggestions 3/ Use a patron from library B to see the suggestions 4/ The "Suggested for" value should be correctly filled with the library A name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:41:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:41:24 +0000 Subject: [Koha-bugs] [Bug 15592] spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15592 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:41:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:41:27 +0000 Subject: [Koha-bugs] [Bug 15592] spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15592 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46945|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 47003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47003&action=edit [SIGNED-OFF] Bug 15592 - spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt To Test: checkthat "extention" has been changed to "extension" on line 27 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:46:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:46:04 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44081|0 |1 is obsolete| | --- Comment #133 from Colin Campbell --- Created attachment 47004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47004&action=edit Amended Patch for Acquisition.t Include the new report field in aqorders for order responses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:51:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:51:23 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 --- Comment #5 from Owen Leonard --- (In reply to Kyle M Hall from comment #3) > It *would* be possible for an additional option in on shelf holds allowed, > so the choices would be: > Yes > Only if at least one item is unavailable > Only if all itmes are unavailble This sounds like a good solution based on what I've heard and read in other bug reports. However since my library doesn't use the feature at all I think it would be good to seek out opinions from people who do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:54:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:54:03 +0000 Subject: [Koha-bugs] [Bug 15606] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15606 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |gel1163 at stacmail.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:58:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:58:29 +0000 Subject: [Koha-bugs] [Bug 15606] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15606 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:58:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:58:31 +0000 Subject: [Koha-bugs] [Bug 15606] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15606 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46929|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 47005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47005&action=edit [SIGNED-OFF] 15606 - Spelling mistake Check if spelling mustake is corrected in file Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:58:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:58:57 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #77 from Fr?d?ric Demians --- Viktor, Coce server is a third-party tool accessed by Koha. Coce-side, for each cover image provider, you can define a cache timeout. Another point to take into account: URL to the images are cached, not the images themselves. This can make a difference from a provider policies point of view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 15:59:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 14:59:05 +0000 Subject: [Koha-bugs] [Bug 15609] spelling mistake in :692: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15609 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |chloealabaster at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:00:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:00:15 +0000 Subject: [Koha-bugs] [Bug 15609] spelling mistake in :692: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15609 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:00:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:00:17 +0000 Subject: [Koha-bugs] [Bug 15609] spelling mistake in :692: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15609 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46940|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 47006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47006&action=edit [SIGNED-OFF] Bug 15609 - spelling mistake in :692: writen ==> written To test: Check that "writen" has been changed to "written" on line 692 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:01:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:01:11 +0000 Subject: [Koha-bugs] [Bug 15610] Spelling mistake in NORMARCslim2OPACResults.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15610 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |gel1163 at stacmail.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:03:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:03:14 +0000 Subject: [Koha-bugs] [Bug 15610] Spelling mistake in NORMARCslim2OPACResults.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15610 --- Comment #2 from Owen Leonard --- That's not an English string, so I'm pretty sure this bug is invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:04:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:04:12 +0000 Subject: [Koha-bugs] [Bug 15611] Spelling mistake in patroncards/edit-layout.tt: implimented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15611 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|spelling mistake |Spelling mistake in |/patroncards/edit-layout.tt |patroncards/edit-layout.tt: |:478: implimented ==> |implimented |implemented 534: | |implimented ==> | |implemented | Severity|enhancement |trivial Assignee|koha-bugs at lists.koha-commun |chloealabaster at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:06:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:06:13 +0000 Subject: [Koha-bugs] [Bug 15611] Spelling mistake in patroncards/edit-layout.tt: implimented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15611 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:06:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:06:15 +0000 Subject: [Koha-bugs] [Bug 15611] Spelling mistake in patroncards/edit-layout.tt: implimented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15611 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46939|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 47007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47007&action=edit [SIGNED-OFF] Bug 15611 - Spelling mistake in patroncards/edit-layout.tt To Test: check that "implimented" has been changed to "implemented" on both lines 478 and 534 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:07:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:07:41 +0000 Subject: [Koha-bugs] [Bug 15612] Spelling mistake /cataloguing/value_builder/normarc_field_008.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15612 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|spelling mistake |Spelling mistake |/cataloguing/value_builder/ |/cataloguing/value_builder/ |normarc_field_008.tt:1303: |normarc_field_008.tt |fortelling ==> foretelling | |:1305: fortelling ==> | |foretelling | Assignee|koha-bugs at lists.koha-commun |chloealabaster at gmail.com |ity.org | Severity|enhancement |minor --- Comment #2 from Owen Leonard --- That's not an English string, so I'm pretty sure this bug is invalid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:08:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:08:25 +0000 Subject: [Koha-bugs] [Bug 15613] Spelling mistake in opac-shelves.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15613 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |gel1163 at stacmail.net Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:10:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:10:59 +0000 Subject: [Koha-bugs] [Bug 15613] Spelling mistake in opac-shelves.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15613 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:11:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:11:01 +0000 Subject: [Koha-bugs] [Bug 15613] Spelling mistake in opac-shelves.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15613 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46934|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 47008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47008&action=edit [SIGNED-OFF] 15613 - Spelling mistake in opac-shelves.tt Spelling mistake in opac-shelves.tt paramter ==> parameter To test - check the change is made in the file Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:12:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:12:48 +0000 Subject: [Koha-bugs] [Bug 15614] Spelling mistake in circ/pendingreserves.tt: Fullfilled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15614 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Assignee|koha-bugs at lists.koha-commun |chloealabaster at gmail.com |ity.org | Summary|spelling mistake |Spelling mistake in |~/Koha/koha-tmpl/intranet-t |circ/pendingreserves.tt: |mpl/prog/en//circ/pendingre |Fullfilled |serves.tt:137: Fullfilled | |==> Fulfilled | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:13:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:13:08 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #78 from Viktor Sarge --- (In reply to Fr?d?ric Demians from comment #77) > Viktor, Coce server is a third-party tool accessed by Koha. Coce-side, for > each cover image provider, you can define a cache timeout. Another point to > take into account: URL to the images are cached, not the images themselves. > This can make a difference from a provider policies point of view. Interesting! Thanks for the quick feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:14:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:14:26 +0000 Subject: [Koha-bugs] [Bug 15614] Spelling mistake in circ/pendingreserves.tt: Fullfilled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15614 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:14:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:14:28 +0000 Subject: [Koha-bugs] [Bug 15614] Spelling mistake in circ/pendingreserves.tt: Fullfilled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15614 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46936|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 47009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47009&action=edit [SIGNED-OFF] Bug 15614 - Spelling mistake in circ/pendingreserves.tt: Fullfilled To Test: Check if "fullfilled" has been changed to "fulfilled" in line 137 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:14:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:14:34 +0000 Subject: [Koha-bugs] [Bug 15630] New: Make Edifact module pluggable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Bug ID: 15630 Summary: Make Edifact module pluggable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 7736 introduces an EDIFACT module that works great for many European vendors, does not work will for US vendors, which have a much different interpretation of 'standard'. In fact, each vendor may pick require different arrangements of values in EDIFACT messages. It would be impossible to encompass all these requirements within Koha's EDIFACT module itself. Instead, we should allow the module to be pluggable, so versions of the module can be developed for vendors that require EDIFACT messages that don't conform to the standard set by Koha's EDIFACT module. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:14:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:14:45 +0000 Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7736 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 [Bug 7736] Edifact QUOTE and ORDER functionality -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:14:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:14:45 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15630 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 [Bug 15630] Make Edifact module pluggable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:14:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:14:49 +0000 Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:48:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:48:40 +0000 Subject: [Koha-bugs] [Bug 15631] New: Move the cities related code to Koha::Cities - part 2 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15631 Bug ID: 15631 Summary: Move the cities related code to Koha::Cities - part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 14888 Bug 14888 has been pushed, but there are still some cities related code in C4::Members: - getzipnamecity (no used) - getidcity Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 [Bug 14888] Move the cities related code to Koha::Cities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:48:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:48:40 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15631 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15631 [Bug 15631] Move the cities related code to Koha::Cities - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 16:52:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 15:52:44 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #101 from Zeno Tajoli --- (In reply to Mirko Tietgen from comment #100) > Hi Zeno, any news on this? Hi, There was a problem on installation on Jessie that block my work on topic: http://lists.koha-community.org/pipermail/koha-devel/2016-January/042204.html Now stay tuned !! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:02:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:02:09 +0000 Subject: [Koha-bugs] [Bug 15631] Move the cities related code to Koha::Cities - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15631 --- Comment #1 from Jonathan Druart --- Created attachment 47010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47010&action=edit Bug 15631: Koha::Cities - remove getzipnamecity C4::Members::getzipnamecity was not used and can be remove safely. Test plan: git grep getzipnamecity should not return any result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:02:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:02:07 +0000 Subject: [Koha-bugs] [Bug 15631] Move the cities related code to Koha::Cities - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15631 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:02:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:02:12 +0000 Subject: [Koha-bugs] [Bug 15631] Move the cities related code to Koha::Cities - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15631 --- Comment #2 from Jonathan Druart --- Created attachment 47011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47011&action=edit Bug 15631: Koha::Cities - remove getidcity and GetCities C4::Members::getidcity and C4::Members::GetCities simply retrieved cities info from the cities table. The job done in members/memberentry.pl looked really weird and complicated. Either I have missed something, or this patch can simplify it. The expected behavior is: 1. Create a new patron => No city selected 2. Edit an existing patron => The borrowers.city value is selected 3. Add a guarantee => The borrowers.city of the guarantor is selected 4. Edit a guarantee => The borrowers.city of the guarantee is selected Test plan: Confirm that the expected behaviors are the ones before and after this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:05:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:05:59 +0000 Subject: [Koha-bugs] [Bug 15592] spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15592 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:06:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:06:02 +0000 Subject: [Koha-bugs] [Bug 15592] spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15592 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47003|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 47012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47012&action=edit Bug 15592 - spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt To Test: checkthat "extention" has been changed to "extension" on line 27 Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:06:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:06:14 +0000 Subject: [Koha-bugs] [Bug 15592] spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15592 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |chloealabaster at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:07:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:07:32 +0000 Subject: [Koha-bugs] [Bug 15606] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47005|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 47013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47013&action=edit Bug 15606 - Spelling mistake Check if spelling mustake is corrected in file Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:07:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:07:29 +0000 Subject: [Koha-bugs] [Bug 15606] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:08:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:08:45 +0000 Subject: [Koha-bugs] [Bug 15609] spelling mistake in :692: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15609 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:08:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:08:48 +0000 Subject: [Koha-bugs] [Bug 15609] spelling mistake in :692: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15609 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47006|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 47014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47014&action=edit Bug 15609 - spelling mistake in :692: writen ==> written To test: Check that "writen" has been changed to "written" on line 692 Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:10:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:10:56 +0000 Subject: [Koha-bugs] [Bug 15611] Spelling mistake in patroncards/edit-layout.tt: implimented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:10:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:10:58 +0000 Subject: [Koha-bugs] [Bug 15611] Spelling mistake in patroncards/edit-layout.tt: implimented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47007|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 47015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47015&action=edit Bug 15611 - Spelling mistake in patroncards/edit-layout.tt To Test: check that "implimented" has been changed to "implemented" on both lines 478 and 534 Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:11:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:11:04 +0000 Subject: [Koha-bugs] [Bug 15611] Spelling mistake in patroncards/edit-layout.tt: implimented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15611 --- Comment #4 from Jonathan Druart --- Created attachment 47016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47016&action=edit Bug 15611: Fix another implimented vs implemented Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:11:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:11:18 +0000 Subject: [Koha-bugs] [Bug 15611] Spelling mistake: implimented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Summary|Spelling mistake in |Spelling mistake: |patroncards/edit-layout.tt: |implimented |implimented | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:11:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:11:38 +0000 Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com, | |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:15:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:15:12 +0000 Subject: [Koha-bugs] [Bug 15613] Spelling mistake in opac-shelves.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15613 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:15:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:15:15 +0000 Subject: [Koha-bugs] [Bug 15613] Spelling mistake in opac-shelves.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15613 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47008|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 47017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47017&action=edit Bug 15613 - Spelling mistake in opac-shelves.tt Spelling mistake in opac-shelves.tt paramter ==> parameter To test - check the change is made in the file Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:15:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:15:18 +0000 Subject: [Koha-bugs] [Bug 15613] Spelling mistake in opac-shelves.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15613 --- Comment #4 from Jonathan Druart --- Created attachment 47018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47018&action=edit Bug 15613: Fix 2 other occurrences of paramter vs parameter Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:15:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:15:43 +0000 Subject: [Koha-bugs] [Bug 15613] Spelling mistake: paramter vs parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15613 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Summary|Spelling mistake in |Spelling mistake: paramter |opac-shelves.tt |vs parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:18:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:18:11 +0000 Subject: [Koha-bugs] [Bug 15614] Spelling mistake in circ/pendingreserves.tt: Fullfilled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15614 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47009|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 47019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47019&action=edit Bug 15614 - Spelling mistake in circ/pendingreserves.tt: Fullfilled To Test: Check if "fullfilled" has been changed to "fulfilled" in line 137 Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:18:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:18:09 +0000 Subject: [Koha-bugs] [Bug 15614] Spelling mistake in circ/pendingreserves.tt: Fullfilled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15614 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:22:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:22:06 +0000 Subject: [Koha-bugs] [Bug 15589] OPAC Lists "his" string fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15589 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:22:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:22:08 +0000 Subject: [Koha-bugs] [Bug 15589] OPAC Lists "his" string fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15589 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46994|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 47020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47020&action=edit Bug 15589: Changing 'his' to 'their' in OPAC lists To be more gender neutral To test: 1) Go to OPAC lists (opac-shelves.pl) 2) Confirm it now says "Allow anyone to remove their own contributed entries." Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:22:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:22:11 +0000 Subject: [Koha-bugs] [Bug 15589] OPAC Lists "his" string fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15589 --- Comment #4 from Jonathan Druart --- Created attachment 47021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47021&action=edit Bug 15589: Fix for the staff interface Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:22:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:22:29 +0000 Subject: [Koha-bugs] [Bug 15589] OPAC Lists "his" string fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15589 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 17:40:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 16:40:15 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Hi Briana, There are 2 subpermissions in the reserveforothers permission: - modify_holds_priority: Modify holds priority - place_holds: Place holds for patrons It would make more sense to test CAN_user_reserveforothers_place_holds instead. Katrin, could you confirm? It seems that we currently test CAN_user_reserveforothers in other places, but it does not look good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 18:03:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 17:03:58 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46848|0 |1 is obsolete| | --- Comment #7 from Bouzid --- Created attachment 47022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47022&action=edit Bug 15541 - Prevent normalization during matching/import process This patch allows you to use the "qualifier,qualifier" syntax in the Record Matching Rules "Search Index" when using the QueryParser. While QueryParser doesn't support this syntax, it will now fallback correctly to non-QueryParser functionality. Without the patch, your search will just fail silently. This patch also adds a "skip_normalize" flag to C4::Search::SimpleSearch(), and sets the flag during C4::Matcher::get_matches. This prevents the s/:/=/g and s/=/:/g normalization which happens in a heavy-handed way to provide correct query syntax. However, get_matches() already uses the correct syntax, so this normalization is unneeded. The normalization also mangles URLs which causes failures when using the "url" (ie "u") register in Zebra (see bug 15555). This patch also creates "raw" and "none" normalizers for the Record Matching Rules, which prevents the stripping of spaces and punctuation by Koha prior to sending queries to Zebra. This is important for a number of reasons. First and foremost, Zebra does normalization better than Koha. ICU and CHR normalize strings differently, so it's better not to try to outsmart Zebra with pre-normalization of punctuation and spaces, as it will lead to search problems. Second, when using the "u" register in Zebra, you don't want to normalize the value, since it's stored "as is" in the Zebra database. Normalization causes search failures. _TEST PLAN_ 1) Apply patches from http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 2) Create a record in Koha with a 024 $a http://koha-community.org/test $2 uri 3) Do a full re-index of Zebra 4) Create a Record Matching Rule in Koha with the following details: Description: Test Match threshold: 100 Record type: Bibliographic Match point 1: Search index: id-other,st-urx Score: 100 Tag: 024 Subfields: a Normalization rule: raw 5) Download your record from Koha as a .mrc file (ie isomarc, binary marc, etc) 6) Go to "Stage MARC records for import" 7) Upload your .marc file. 8) Change your "Record matching rule" to "Test" 9) Click Stage for import 10) It should say "1 records with at least one match in catalogu per matching rule "Test". Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 18:07:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 17:07:46 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 18:08:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 17:08:36 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 18:10:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 17:10:03 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 18:53:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 17:53:37 +0000 Subject: [Koha-bugs] [Bug 15628] Remove get_branchinfos_of vestiges In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15628 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 18:53:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 17:53:39 +0000 Subject: [Koha-bugs] [Bug 15628] Remove get_branchinfos_of vestiges In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15628 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46989|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47023&action=edit [SIGNED-OFF]Bug 15628: Remove get_branchinfos_of vestiges The C4::Branch::get_branchinfos_of subroutine has been removed by bug 7034, but 2 occurrences have been left git grep get_branchinfos_of C4/Branch.pm: &get_branchinfos_of t/db_dependent/Branch.t: get_branchinfos_of Test plan: git grep get_branchinfos_of should not return any occurrences. Signed-off-by: Hector Castro Vestiges removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 18:57:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 17:57:51 +0000 Subject: [Koha-bugs] [Bug 15608] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15608 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 18:57:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 17:57:53 +0000 Subject: [Koha-bugs] [Bug 15608] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15608 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46931|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47024&action=edit [SIGNED-OFF]Bug 15608: Spelling mistake in MARC21slim2OPACDetail.xsl Seperate -> separate test - check if spelling is changed Signed-off-by: Hector Castro Typo fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 19:00:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 18:00:57 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 19:01:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 18:01:04 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 19:10:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 18:10:18 +0000 Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 --- Comment #1 from Kyle M Hall --- Created attachment 47025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47025&action=edit Bug 15630 - Make Edifact module pluggable Koha's EDIFACT module works great for many European vendors, but does not work will for US vendors, which have a much different interpretation of 'standard'. In fact, each vendor may require different arrangements of values in EDIFACT messages. It would be impossible to encompass all these requirements within Koha's EDIFACT module itself. Instead, we should allow the module to be pluggable, so versions of the module can be developed for vendors that require EDIFACT messages that don't conform to the standard set by Koha's EDIFACT module. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable Koha plugins 4) Install the Edifact stub plugin available at https://github.com/bywatersolutions/koha-plugin-edifact-stub 5) Edit the EDI Vendor account, assign the plugin to a Vendor EDI account 6) Test EDI functionality ( ORDER, INVOICE ), there should be no errors or changes to the EDIFACT message input or output -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 19:14:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 18:14:28 +0000 Subject: [Koha-bugs] [Bug 15630] Make Edifact module pluggable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47025|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 47026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47026&action=edit Bug 15630 - Make Edifact module pluggable Koha's EDIFACT module works great for many European vendors, but does not work will for US vendors, which have a much different interpretation of 'standard'. In fact, each vendor may require different arrangements of values in EDIFACT messages. It would be impossible to encompass all these requirements within Koha's EDIFACT module itself. Instead, we should allow the module to be pluggable, so versions of the module can be developed for vendors that require EDIFACT messages that don't conform to the standard set by Koha's EDIFACT module. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable Koha plugins 4) Install the Edifact stub plugin available at https://github.com/bywatersolutions/koha-plugin-edifact-stub 5) Edit the EDI Vendor account, assign the plugin to a Vendor EDI account 6) Test EDI functionality ( ORDER, INVOICE ), there should be no errors or changes to the EDIFACT message input or output -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 19:40:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 18:40:45 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15632 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 [Bug 15632] Move the messages related code to Koha::Patron::Messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 19:40:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 18:40:45 +0000 Subject: [Koha-bugs] [Bug 15632] New: Move the messages related code to Koha::Patron::Messages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Bug ID: 15632 Summary: Move the messages related code to Koha::Patron::Messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 15449 There are 4 subroutines in C4::Messages which could be moved to their own package: - AddMessage - DeleteMessage - GetMessagesCount - GetMessages With Koha::Patron::Message[s] based on Koha::Object[s], it will be easy to move them. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 19:58:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 18:58:33 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #37 from Chris Cormack --- We are actually evaluating 9580 at the moment to see if it will meet all the requirements of this bug. Will let you know shortly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:03:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:03:51 +0000 Subject: [Koha-bugs] [Bug 15610] Spelling mistake in NORMARCslim2OPACResults.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15610 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED CC| |chris at bigballofwax.co.nz Resolution|--- |INVALID --- Comment #3 from Chris Cormack --- Good catch Owen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:05:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:05:32 +0000 Subject: [Koha-bugs] [Bug 15612] Spelling mistake /cataloguing/value_builder/normarc_field_008.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15612 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Needs Signoff |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:08:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:08:04 +0000 Subject: [Koha-bugs] [Bug 15631] Move the cities related code to Koha::Cities - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15631 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:13:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:13:44 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #226 from M. Tompsett --- (In reply to Chris Cormack from comment #13) > All pushed, leaving open for me Given that all the previous patches were likely pushed, and the tweak to C4::Dates is no longer applicable, should set the status to something other than Patch doesn't apply and perhaps obsolete all of these? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:22:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:22:14 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40572|0 |1 is obsolete| | --- Comment #35 from M. Tompsett --- Created attachment 47027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47027&action=edit Bug 11405 [1] - Warn of items possibly scanned out of order This patch addes the ability to choose to be warned if it's possible an item was scanned out of order ( i.e. mis-shelved ). Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) "Misplace" one callnumber by moving it to another area of the list 4) Browse to the inventory tool, choose your barcodes file 5) Check the checkbox for "Check barcodes list for items shelved out of order" 6) Click "submit", note the item has been flagged as possibly out of order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:22:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:22:20 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40573|0 |1 is obsolete| | --- Comment #36 from M. Tompsett --- Created attachment 47028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47028&action=edit Bug 11405 [2] - Skip items with waiting holds This patch enables items to be skipped for inventory stocktaking if the item is currently a waiting hold. The intention is to skip items that should be on the holds waiting shelf in the library. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Select one of those items and place it on hold, then confirm the hold 4) Remove that barcode from the list of barcodes 5) Browse to the inventory tool, choose your barcodes file 6) Run the inventory tool with that barcode file. 7) Note the tool says that item should have been scanned 8) Click the browsers back button to return to the previous page 9) Check the checkbox for "Skip copies marked as waiting holds" 10) Run the tool again, not it does not flag that item as previously -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:22:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:22:26 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40574|0 |1 is obsolete| | --- Comment #37 from M. Tompsett --- Created attachment 47029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47029&action=edit Bug 11405 [3] - Update item status fieldset string to be more descriptive The inventory tool has a fieldset title "Item status" but does not explain what selecting item statuses does. This fieldset legend should be updated to explain what these checkboxes do. This patch changes the legend from "Item statuses" to "Limit to items matching all the following statuses". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:22:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:22:33 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40575|0 |1 is obsolete| | --- Comment #38 from M. Tompsett --- Created attachment 47030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47030&action=edit Bug 11405 [4] - Allow long labels to be less word-wrapped The labels in the last fieldset of the inventory tool are a bit "squashed" and are word wrapped to many lines unnecessarily. This patch adds an additional css style for fieldsets of the class "row". If an additional class "wide" as added to the fieldset, it will give the labels more room for display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:22:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:22:39 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40576|0 |1 is obsolete| | --- Comment #39 from M. Tompsett --- Created attachment 47031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47031&action=edit Bug 11405 [5] - Fix html fieldset weirdness For unknown and unnecessary reasons, the inventory tool display will attempt to merge the "select items you want to check" fieldset with the bottom fieldset if no statuses are present. This situation is highly unlikely and complicates the template logic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:22:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:22:51 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40577|0 |1 is obsolete| | --- Comment #40 from M. Tompsett --- Created attachment 47032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47032&action=edit Bug 11405 [6] - Allow items with selected locations to be not be flagged as "Item should have been scanned" if not scanned This patch allows items to be skipped over if the item has one of the locations selected in the new field set listing shelving locations. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Set one of those items to a shelving location 4) Remove that item from the list 5) Run the inventory tool with this list of barcodes 6) Note the item is listed as "should have been scanned" 7) Click back to return to the previous page 8) Select the shelving location from "If comparing barcodes list to results, assume items with the following locations should note have been scanned". 8) Re-run the inventory tool 9) Note the item is no longer listed as "should have been scanned" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:22:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:22:58 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40578|0 |1 is obsolete| | --- Comment #41 from M. Tompsett --- Created attachment 47033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47033&action=edit Bug 11405 [7] - Add out of order status to CSV file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:23:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:23:03 +0000 Subject: [Koha-bugs] [Bug 15615] Spelling mistake in opac-user.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15615 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:26:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:26:15 +0000 Subject: [Koha-bugs] [Bug 15593] Spelling mistake In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15593 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |chris at bigballofwax.co.nz Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:26:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:26:35 +0000 Subject: [Koha-bugs] [Bug 15591] Spelling mistake In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15591 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:26:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:26:40 +0000 Subject: [Koha-bugs] [Bug 15608] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15608 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Assignee|gmcharlt at gmail.com |gel1163 at stacmail.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:33:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:33:02 +0000 Subject: [Koha-bugs] [Bug 15616] Spelling mistake in opac-account.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15616 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:33:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:33:04 +0000 Subject: [Koha-bugs] [Bug 15616] Spelling mistake in opac-account.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15616 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46937|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47034&action=edit [SIGNED-OFF]Bug 15616: Spelling mistake in ./opac-account.tt sucessfully ==> successfully Test - Check that the word has been changed in file Signed-off-by: Hector Castro Typo fixed correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:33:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:33:27 +0000 Subject: [Koha-bugs] [Bug 15616] Spelling mistake in opac-account.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15616 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Assignee|gmcharlt at gmail.com |gel1163 at stacmail.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:34:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:34:27 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47027|0 |1 is obsolete| | --- Comment #42 from M. Tompsett --- Created attachment 47035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47035&action=edit Bug 11405 [1] - Warn of items possibly scanned out of order This patch addes the ability to choose to be warned if it's possible an item was scanned out of order ( i.e. mis-shelved ). Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) "Misplace" one callnumber by moving it to another area of the list 4) Browse to the inventory tool, choose your barcodes file 5) Check the checkbox for "Check barcodes list for items shelved out of order" 6) Click "submit", note the item has been flagged as possibly out of order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:34:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:34:33 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47028|0 |1 is obsolete| | --- Comment #43 from M. Tompsett --- Created attachment 47036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47036&action=edit Bug 11405 [2] - Skip items with waiting holds This patch enables items to be skipped for inventory stocktaking if the item is currently a waiting hold. The intention is to skip items that should be on the holds waiting shelf in the library. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Select one of those items and place it on hold, then confirm the hold 4) Remove that barcode from the list of barcodes 5) Browse to the inventory tool, choose your barcodes file 6) Run the inventory tool with that barcode file. 7) Note the tool says that item should have been scanned 8) Click the browsers back button to return to the previous page 9) Check the checkbox for "Skip copies marked as waiting holds" 10) Run the tool again, not it does not flag that item as previously -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:34:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:34:38 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47029|0 |1 is obsolete| | --- Comment #44 from M. Tompsett --- Created attachment 47037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47037&action=edit Bug 11405 [3] - Update item status fieldset string to be more descriptive The inventory tool has a fieldset title "Item status" but does not explain what selecting item statuses does. This fieldset legend should be updated to explain what these checkboxes do. This patch changes the legend from "Item statuses" to "Limit to items matching all the following statuses". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:34:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:34:43 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47030|0 |1 is obsolete| | --- Comment #45 from M. Tompsett --- Created attachment 47038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47038&action=edit Bug 11405 [4] - Allow long labels to be less word-wrapped The labels in the last fieldset of the inventory tool are a bit "squashed" and are word wrapped to many lines unnecessarily. This patch adds an additional css style for fieldsets of the class "row". If an additional class "wide" as added to the fieldset, it will give the labels more room for display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:34:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:34:48 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47031|0 |1 is obsolete| | --- Comment #46 from M. Tompsett --- Created attachment 47039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47039&action=edit Bug 11405 [5] - Fix html fieldset weirdness For unknown and unnecessary reasons, the inventory tool display will attempt to merge the "select items you want to check" fieldset with the bottom fieldset if no statuses are present. This situation is highly unlikely and complicates the template logic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:34:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:34:54 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47032|0 |1 is obsolete| | --- Comment #47 from M. Tompsett --- Created attachment 47040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47040&action=edit Bug 11405 [6] - Allow items with selected locations to be not be flagged as "Item should have been scanned" if not scanned This patch allows items to be skipped over if the item has one of the locations selected in the new field set listing shelving locations. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Set one of those items to a shelving location 4) Remove that item from the list 5) Run the inventory tool with this list of barcodes 6) Note the item is listed as "should have been scanned" 7) Click back to return to the previous page 8) Select the shelving location from "If comparing barcodes list to results, assume items with the following locations should note have been scanned". 8) Re-run the inventory tool 9) Note the item is no longer listed as "should have been scanned" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:35:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:35:00 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47033|0 |1 is obsolete| | --- Comment #48 from M. Tompsett --- Created attachment 47041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47041&action=edit Bug 11405 [7] - Add out of order status to CSV file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:36:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:36:24 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |mtompset at hotmail.com --- Comment #49 from M. Tompsett --- It would be handy if Kyle could recheck this too. :) I have merely made it applicable and tried to match old code differences. I have not tested it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:38:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:38:09 +0000 Subject: [Koha-bugs] [Bug 15619] Spelling mistake in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15619 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:38:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:38:11 +0000 Subject: [Koha-bugs] [Bug 15619] Spelling mistake in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15619 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46959|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47042&action=edit [SIGNED-OFF]Bug 15619: Spelling mistake in memberentry.pl Test - Check file for 'konw', notice no instance Signed-off-by: Hector Castro Typo fixed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:38:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:38:34 +0000 Subject: [Koha-bugs] [Bug 15619] Spelling mistake in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15619 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Assignee|koha-bugs at lists.koha-commun |gel1163 at stacmail.net |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:39:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:39:48 +0000 Subject: [Koha-bugs] [Bug 15515] Date of Birth gadget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15515 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:41:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:41:36 +0000 Subject: [Koha-bugs] [Bug 15621] Spelling mistake in printinvoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15621 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:41:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:41:38 +0000 Subject: [Koha-bugs] [Bug 15621] Spelling mistake in printinvoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15621 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46970|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47043&action=edit [SIGNED-OFF]Bug 15621: Spelling mistake in printinvice.pl Test- search for writen, if not found patch successful Signed-off-by: Hector Castro Typo fixed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:44:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:44:48 +0000 Subject: [Koha-bugs] [Bug 15624] Spelling mistake in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15624 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:44:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:44:51 +0000 Subject: [Koha-bugs] [Bug 15624] Spelling mistake in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15624 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46975|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47044&action=edit [SIGNED-OFF]Bug 15624: Spelling mistake in suggestion.pl Test - due to noone being in a comparison name it was not changed 1. search for choosen, see that it was removed 2. search for agregate, see that it was removed Signed-off-by: Hector Castro Typos fixed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:47:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:47:30 +0000 Subject: [Koha-bugs] [Bug 15626] koha-remove does not remove log4perl.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15626 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:47:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:47:32 +0000 Subject: [Koha-bugs] [Bug 15626] koha-remove does not remove log4perl.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15626 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46984|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47045&action=edit Bug 15626: Remove log4perl.conf when using koha-remove if you create a koha install using koha-create, and remove it with koha-remove, the /etc/koha/sites/$SITE/ directory won't be removed, because the /etc/koha/sites/$SITE/log4perl.conf has not been removed by this script. Test plan: Use this koha-remove script to remove a koha install Without this patch, the /etc/koha/sites/$SITE directory won't be removed. With this patch applied, the directory will be correctly removed. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:48:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:48:14 +0000 Subject: [Koha-bugs] [Bug 15510] New professional cataloguing editor shows OPAC favicon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15510 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:55:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:55:34 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #99 from H?ctor Eduardo Castro Avalos --- Hi Bernardo Patch doesn't apply anymore changing status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 20:59:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 19:59:06 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 --- Comment #4 from Gus Ellerm --- Results for first prove - without patches installed kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/Returns.t .. Subroutine C4::Context::userenv redefined at t/db_dependent/Circulation/Returns.t line 15. t/db_dependent/Circulation/Returns.t .. ok All tests successful. Files=1, Tests=2, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.98 cusr 0.09 csys = 1.10 CPU) Result: PASS Results for second prove - without patches installed t/db_dependent/Items.t .. 7/9 # Failed test 'Got Koha::Library from home_branch method' # at t/db_dependent/Items.t line 456. # got: 'Koha::Branch' # expected: 'Koha::Library' # Failed test 'Got Koha::Library from holding_branch method' # at t/db_dependent/Items.t line 460. # got: 'Koha::Branch' # expected: 'Koha::Library' # Looks like you failed 2 tests of 5. # Failed test 'Koha::Item(s) tests' # at t/db_dependent/Items.t line 464. # Looks like you failed 1 test of 9. t/db_dependent/Items.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/9 subtests Test Summary Report ------------------- t/db_dependent/Items.t (Wstat: 256 Tests: 9 Failed: 1) Failed test: 8 Non-zero exit status: 1 Files=1, Tests=9, 2 wallclock secs ( 0.03 usr 0.03 sys + 1.04 cusr 0.19 csys = 1.29 CPU) Result: FAIL Looks like I am missing some sample data. These tests were all done before application off patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:03:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:03:16 +0000 Subject: [Koha-bugs] [Bug 15583] List of lists in the staff client should have a default sort In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15583 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chloealabaster at gmail.com Assignee|gmcharlt at gmail.com |chloealabaster at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:03:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:03:19 +0000 Subject: [Koha-bugs] [Bug 15515] Date of Birth gadget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15515 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |brianagreally at gmail.com |ity.org | CC| |brianagreally at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:03:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:03:22 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |gel1163 at stacmail.net Status|NEW |ASSIGNED CC| |gel1163 at stacmail.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:03:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:03:45 +0000 Subject: [Koha-bugs] [Bug 15510] New professional cataloguing editor shows OPAC favicon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15510 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brianagreally at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:14:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:14:47 +0000 Subject: [Koha-bugs] [Bug 15589] OPAC Lists "his" string fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15589 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47021|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 47046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47046&action=edit Bug 15589: Fix for the staff interface Signed-off-by: Jonathan Druart Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:17:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:17:13 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46963|0 |1 is obsolete| | --- Comment #3 from Gus Ellerm --- Created attachment 47047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47047&action=edit 14647 - Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:17:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:17:18 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #17 from M. Tompsett --- (In reply to Katrin Fischer from comment #16) > I think I agree with rangi - better to have it fail early, then to have to > clean up all the patron accounts after figuring out what went wrong. > > What do others think? My concern is failure to automatically renew would fail to produce overdue notices with &&. "You owe $100 in fines." "But I never got an overdue notice!" (R && F) ; O? The fines won't accidentally charge on automatic renewal failures, but the overdues will run after the automatic renewals. Does this look like a good solution? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:19:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:19:21 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:21:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:21:17 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #18 from M. Tompsett --- Comment on attachment 44283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44283 Bug 11144: Fix sequence of cronjobs: automatic renewal - fines - overdue notices Review of attachment 44283: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11144&attachment=44283) ----------------------------------------------------------------- ::: debian/koha-common.cron.daily @@ +19,1 @@ > koha-foreach --enabled /usr/share/koha/bin/cronjobs/fines.pl Our discussion does raise a problem with this. This runs the fines regardless of whether the renewals succeed or not. @@ +19,2 @@ > koha-foreach --enabled /usr/share/koha/bin/cronjobs/fines.pl > +koha-foreach --enabled --email /usr/share/koha/bin/cronjobs/overdue_notices.pl -t These three lines are the equivalent of semi-colons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:31:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:31:15 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:31:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:31:18 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47047|0 |1 is obsolete| | --- Comment #4 from Gus Ellerm --- Created attachment 47048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47048&action=edit 14647 - Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:37:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:37:00 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 --- Comment #5 from Aleisha Amohia --- Have tested and this works perfectly! Can someone else please sign off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:43:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:43:18 +0000 Subject: [Koha-bugs] [Bug 13474] Untranslatable log actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- I think this is a good start. However: mtompset at debian:~/kohaclone$ git grep "[ ]logaction(" | cut -f2 -d":" | cut -f2 -d"," | cut -f2 -d"(" | sed -e "s#^ *##g" | sed -e "s#\"#'#g" | sort -u 'ADD' 'ADDCIRCMESSAGE' 'CHANGE PASS' 'CREATE' 'DELCIRCMESSAGE' 'DELETE' 'ISSUE' 'MODIFY' 'RENEW' 'RETURN' 'Run' mtompset at debian:~/kohaclone$ [% BLOCK translate_log_action %] [% SWITCH action %] [% CASE 'ADD' %]Add [% CASE 'DELETE' %]Delete [% CASE 'MODIFY' %]Modify [% CASE 'ISSUE' %]Checkout [% CASE 'RETURN' %]Return [% CASE 'CREATE' %]Create [% CASE %][% action %] [% END %] [% END %] SCRATCH PAD: 'ADDCIRCMESSAGE' 'CHANGE PASS' 'DELCIRCMESSAGE' 'RENEW' 'Run' There is one more action missing: 'Run'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:44:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:44:15 +0000 Subject: [Koha-bugs] [Bug 15515] Date of Birth gadget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15515 --- Comment #1 from Briana Greally --- Are you using an earlier version of Koha? Because this issue seems to have been fixed in the latest version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:45:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:45:02 +0000 Subject: [Koha-bugs] [Bug 15515] Date of Birth gadget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15515 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|brianagreally at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:46:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:46:11 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:46:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:46:13 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 --- Comment #1 from Gus Ellerm --- Created attachment 47049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47049&action=edit 15465 - Created README.md file for github -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:53:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:53:53 +0000 Subject: [Koha-bugs] [Bug 14498] uri_escape error triggered by duplicate accountno's for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 21:59:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 20:59:39 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- Can't duplicate problem as described in test plan. mtompset at debian:~/kohaclone$ git checkout -b bug_15599 origin/master Branch bug_15599 set up to track remote branch master from origin. Switched to a new branch 'bug_15599' mtompset at debian:~/kohaclone$ prove t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/Returns.t .. Subroutine C4::Context::userenv redefined at t/db_dependent/Circulation/Returns.t line 15. t/db_dependent/Circulation/Returns.t .. ok All tests successful. Files=1, Tests=2, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.90 cusr 0.04 csys = 0.96 CPU) Result: PASS mtompset at debian:~/kohaclone$ prove t/db_dependent/Items.t t/db_dependent/Items.t .. ok All tests successful. Files=1, Tests=9, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.16 cusr 0.03 csys = 1.21 CPU) Result: PASS Patch does not apply. mtompset at debian:~/kohaclone$ git bz apply 15599 Bug 15599 - Unit tests output warnings 46869 - Bug 15599 - Unit tests output warnings Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15599 - Unit tests output warnings fatal: sha1 information is lacking or useless (t/db_dependent/Circulation/Returns.t). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 15599 - Unit tests output warnings The copy of the patch that failed is found in: /home/mtompset/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15599---Unit-tests-output-warnings-lEGWsI.patch mtompset at debian:~/kohaclone$ NOTE: I read the patch, and it looks like an improvement to me, but can't sign off. Please rebase first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:00:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:00:54 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 --- Comment #2 from Gus Ellerm --- Just adding some formatting to the file now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:03:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:03:53 +0000 Subject: [Koha-bugs] [Bug 7181] Template indentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7181 --- Comment #1 from natasha --- Created attachment 47050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47050&action=edit Screenshot of code This looks like it has already been fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:13:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:13:23 +0000 Subject: [Koha-bugs] [Bug 13474] Untranslatable log actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46933|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia --- Created attachment 47051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47051&action=edit Bug 13474: Adding untranslatable log actions to viewlog.tt Added 'Run' Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:25:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:25:39 +0000 Subject: [Koha-bugs] [Bug 15510] New professional cataloguing editor shows OPAC favicon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15510 --- Comment #1 from Briana Greally --- This is the path to the cataloguing editor favicon from the source code. http://localhost:8081/intranet-tmpl/prog/img/favicon.ico Is that not right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:27:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:27:59 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47049|0 |1 is obsolete| | --- Comment #3 from Gus Ellerm --- Created attachment 47052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47052&action=edit 15465 - Created README.md file for github -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:35:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:35:09 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47052|0 |1 is obsolete| | --- Comment #4 from Gus Ellerm --- Created attachment 47053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47053&action=edit 15465 - Created README.md file for github -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:38:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:38:17 +0000 Subject: [Koha-bugs] [Bug 15510] New professional cataloguing editor shows OPAC favicon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15510 --- Comment #2 from Katrin Fischer --- It seems to not happen constantly, but only under unknown circumstances. I talked to Jonathan and he noticed it too - but I haven't figured out yet how and when exactly it happens. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:39:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:39:43 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gel1163 at stacmail.net Assignee|chloealabaster at gmail.com |gel1163 at stacmail.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:43:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:43:30 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I think a third option to the former 'allowonshelfholds' sounds good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:47:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:47:22 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 --- Comment #5 from Briana Greally --- Created attachment 47054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47054&action=edit Bug 15571 reserveforothers permission does not remove Search to hold button from patron account To Test: 1. Create a user without 'reserveforothers' permission 2. Go onto user details 3. 'Search to hold' button should not be there 4. Create a user with 'reserveforothers' permission 5. Repeat steps 6. 'Search to Hold' button should be there Signed-off-by: Owen Leonard Signed-off-by: Briana Here is the same patch but with 'CAN_user_reserveforothers_place_holds' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:48:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:48:10 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brianagreally at gmail.com Attachment #46995|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:50:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:50:47 +0000 Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and volumne information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gel1163 at stacmail.net --- Comment #4 from Gus Ellerm --- This doesn't break for me, could someone else test and comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:52:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:52:36 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:52:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:52:39 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46983|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 47055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47055&action=edit [PASSED QA] Bug 15607: batch patron mod - do not update dates if not given Bug 15332 fixed a bug but introduced a bigger one. Even if dateenrolled and dateexpiry are not modified, they will be updated to today. Indeed, dt_from_string returns today without parameters. Test plan: - Set dateenrolled and expirydate for a patron - Using the batch patron mod tool, update any field but dateenrolled and expirydate. => Without this patch, the 2 date fields should be set to today => With this patch applied, the 2 date fields should not have been modified. Signed-off-by: Karam Qubsi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:55:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:55:45 +0000 Subject: [Koha-bugs] [Bug 15624] Spelling mistake in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15624 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 22:55:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 21:55:48 +0000 Subject: [Koha-bugs] [Bug 15624] Spelling mistake in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15624 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47044|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 47056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47056&action=edit [PASSED QA] Bug 15624: Spelling mistake in suggestion.pl Test - due to noone being in a comparison name it was not changed 1. search for choosen, see that it was removed 2. search for agregate, see that it was removed Signed-off-by: Hector Castro Typos fixed Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 23:00:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 22:00:03 +0000 Subject: [Koha-bugs] [Bug 15621] Spelling mistake in printinvoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15621 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 23:00:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 22:00:06 +0000 Subject: [Koha-bugs] [Bug 15621] Spelling mistake in printinvoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15621 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47043|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 47057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47057&action=edit [PASSED QA] Bug 15621: Spelling mistake in printinvice.pl Test- search for writen, if not found patch successful Signed-off-by: Hector Castro Typo fixed Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 23:03:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 22:03:50 +0000 Subject: [Koha-bugs] [Bug 15619] Spelling mistake in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 23:03:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 22:03:53 +0000 Subject: [Koha-bugs] [Bug 15619] Spelling mistake in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47042|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 47058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47058&action=edit [PASSED QA] Bug 15619: Spelling mistake in memberentry.pl Test - Check file for 'konw', notice no instance Signed-off-by: Hector Castro Typo fixed Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 23:06:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 22:06:17 +0000 Subject: [Koha-bugs] [Bug 15616] Spelling mistake in opac-account.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 23:06:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 22:06:20 +0000 Subject: [Koha-bugs] [Bug 15616] Spelling mistake in opac-account.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47034|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 47059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47059&action=edit [PASSED QA] Bug 15616: Spelling mistake in ./opac-account.tt sucessfully ==> successfully Test - Check that the word has been changed in file Signed-off-by: Hector Castro Typo fixed correctly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 23:08:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 22:08:03 +0000 Subject: [Koha-bugs] [Bug 15617] Be able to close "Click to edit" text boxes after opening them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15617 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gel1163 at stacmail.net Assignee|koha-bugs at lists.koha-commun |gel1163 at stacmail.net |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 23:08:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 22:08:39 +0000 Subject: [Koha-bugs] [Bug 15608] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15608 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 23:08:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 22:08:42 +0000 Subject: [Koha-bugs] [Bug 15608] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15608 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47024|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 47060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47060&action=edit [PASSED QA] Bug 15608: Spelling mistake in MARC21slim2OPACDetail.xsl Seperate -> separate test - check if spelling is changed Signed-off-by: Hector Castro Typo fixed Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 23:24:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 22:24:05 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- I am sorry, but this patch doesn't seem to work for me: - Activate system preference AllowRenewalLimitOverride (allow) - Go to the checkouts and details tabs in the patron account - There are items with max renewals reached, but the override function doesn't show below the table of loaded checkouts Switching to master the checkbox is shown. Could the problem be i koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 23:26:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 22:26:56 +0000 Subject: [Koha-bugs] [Bug 15391] HoldsQueue.t does not handle for loan itemtypes correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |gmcharlt at gmail.com |y.org | CC| |katrin.fischer at bsz-bw.de Component|Architecture, internals, |Test Suite |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 23:27:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 22:27:34 +0000 Subject: [Koha-bugs] [Bug 15391] HoldsQueue.t does not handle for loan itemtypes correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 23:27:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 22:27:37 +0000 Subject: [Koha-bugs] [Bug 15391] HoldsQueue.t does not handle for loan itemtypes correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46990|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 47061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47061&action=edit [PASSED QA] Bug 15391: Fix HoldsQueue.t tests Prior to this patch, in HoldsQueue.t: 63 my @item_types = C4::ItemType->all; 64 my $itemtype = grep { $_->{notforloan} == 1 } @item_types 65 or BAIL_OUT("No adequate itemtype"); Then we use the $itemtype variable (which contains the number of item types not for loan): 92 $dbh->do("INSERT INTO biblioitems (biblionumber, marcxml, itemtype) 93 VALUES ($biblionumber, '', '$itemtype')"); There is obviously something wrong here. The code should be 64 my @not_for_loan = grep { $_->{notforloan} == 1 } @item_types 65 or BAIL_OUT("No adequate itemtype"); 66 my $itemtype = $not_for_loan[0]->{itemtype}; But then some tests don't pass: Actually the problem comes from: commit bfbc646fdd9ca4b90a0bc2751d0faa95d9e93ba1 Bug 10336: HoldsQueue.t needs to create its own data -my $itemtype = $dbh->selectrow_array("SELECT min(itemtype) FROM itemtypes WHERE notforloan = 0") +my @item_types = C4::ItemType->all; +my $itemtype = grep { $_->{notforloan} == 1 } @item_types The line should have been: my $itemtype = grep { $_->{notforloan} == 0 } @item_types Test plan: Confirm that the tests still pass after this patch applied. Signed-off-by: Kyle M Hall All tests pass pre and post patch Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 23:32:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 22:32:10 +0000 Subject: [Koha-bugs] [Bug 15631] Move the cities related code to Koha::Cities - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15631 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 20 23:32:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 22:32:14 +0000 Subject: [Koha-bugs] [Bug 15631] Move the cities related code to Koha::Cities - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15631 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47011|0 |1 is obsolete| | --- Comment #3 from natasha --- Created attachment 47062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47062&action=edit Bug 15631: Koha::Cities - remove getidcity and GetCities C4::Members::getidcity and C4::Members::GetCities simply retrieved cities info from the cities table. The job done in members/memberentry.pl looked really weird and complicated. Either I have missed something, or this patch can simplify it. The expected behavior is: 1. Create a new patron => No city selected 2. Edit an existing patron => The borrowers.city value is selected 3. Add a guarantee => The borrowers.city of the guarantor is selected 4. Edit a guarantee => The borrowers.city of the guarantee is selected Test plan: Confirm that the expected behaviors are the ones before and after this patch. Signed-off-by: Natasha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 00:17:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 23:17:25 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 --- Comment #4 from Aleisha Amohia --- Created attachment 47063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47063&action=edit Bug 15618: Typos fixed in enhanced_content.pref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 00:19:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 23:19:53 +0000 Subject: [Koha-bugs] [Bug 15583] List of lists in the staff client should have a default sort In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15583 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 00:19:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 23:19:56 +0000 Subject: [Koha-bugs] [Bug 15583] List of lists in the staff client should have a default sort In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15583 --- Comment #1 from Chloe Alabaster --- Created attachment 47064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47064&action=edit Bug 15583 - List of lists in the staff client should have a default sort To Test: 1- first make sure you have lists from different dates, -- if you dont you can go to databases and change the created_on date (by changing the date on the database you can also ensure that the shelfnumber doesn't align with the creation date, replicating the bug being fixed.) 2- after making lists apply patch and refresh page, the lists should be sorted by creation date by default instead of by the "shelfnumber" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 00:31:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 23:31:02 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 --- Comment #5 from Aleisha Amohia --- Created attachment 47065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47065&action=edit Bug 15618: Typos fixed in logs.pref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 00:44:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 23:44:21 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 --- Comment #6 from Aleisha Amohia --- Created attachment 47066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47066&action=edit Bug 15618: Typos fixed in opac.pref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 00:44:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 23:44:54 +0000 Subject: [Koha-bugs] [Bug 14624] <> for advance_notices.pl wrongly documented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9499 CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- Bug 9499 failed to document it correctly in both places. Line 104 was correct, but line 147 is not. This patch visually fixes that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 00:44:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 23:44:54 +0000 Subject: [Koha-bugs] [Bug 9499] --itemscontent= option is undocumented in advanced-notice.pl cronjob + default date should be date_due, not issuedate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14624 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 00:46:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 23:46:31 +0000 Subject: [Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 00:46:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 23:46:33 +0000 Subject: [Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 --- Comment #1 from natasha --- Created attachment 47067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47067&action=edit Bug 15564 - Display "print slip" option when returning an item which is in a rotating collection To Test - 1. Make a new rotating collection (under tools) with at least one book in it. 2. Check out the book/s from rotating collection. 3. Set library to a different library. 4. Check in book you just checked out. 5. Should show a dialog box with no print slip link or city. 6. Apply patch and repeat steps 1-4. Dialog box should now show the item name, city name and print slip link. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 00:50:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 23:50:43 +0000 Subject: [Koha-bugs] [Bug 14624] <> for advance_notices.pl wrongly documented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46843|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 47068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47068&action=edit Bug 14624 - <> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches. Ran: $ perldoc misc/cronjobs/advance_noitces.pl Saw expected changes. Koha QA test tools pass too. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 00:51:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 23:51:31 +0000 Subject: [Koha-bugs] [Bug 15617] Be able to close "Click to edit" text boxes after opening them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15617 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 00:51:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 23:51:33 +0000 Subject: [Koha-bugs] [Bug 15617] Be able to close "Click to edit" text boxes after opening them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15617 --- Comment #1 from Gus Ellerm --- Created attachment 47069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47069&action=edit 15617 - Be able to close "Click to edit" text boxes after opening them Test - 1. Go to admin preferences, Acquisitions, Policy. 2. Find MarcFieldsToOrder and click "Click to Edit" 3. Notice that a "Click to collapse" button appears, click it. 4. Notice th This fix should be applicable to all "Click to Edit" textbox's -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 00:52:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 23:52:17 +0000 Subject: [Koha-bugs] [Bug 14624] <> for advance_notices.pl wrongly documented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 00:55:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jan 2016 23:55:32 +0000 Subject: [Koha-bugs] [Bug 13474] Untranslatable log actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 --- Comment #4 from M. Tompsett --- (In reply to Aleisha Amohia from comment #3) > Created attachment 47051 [details] [review] > Bug 13474: Adding untranslatable log actions to viewlog.tt > > Added 'Run' > > Signed-off-by: Aleisha Sorry, your case is wrong. The code is literally 'Run', not 'RUN'. Yes, I found that strange too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 01:19:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 00:19:21 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Jesse Weaver --- PUshed to master, thanks for your work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 01:21:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 00:21:49 +0000 Subject: [Koha-bugs] [Bug 15606] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15606 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jweaver at bywatersolutions.co | |m --- Comment #4 from Jesse Weaver --- Pushed to master, thanks for your work! (I changed the commit message to match the bug's title.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 01:25:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 00:25:05 +0000 Subject: [Koha-bugs] [Bug 15514] New professional cataloguing editor does not handle repeatable fields correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15514 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m --- Comment #1 from Jesse Weaver --- Could I ask you to attach the record in question? I remember this error popping up during QA on bug 11559, and I'd like to stamp it out for good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 01:36:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 00:36:18 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 --- Comment #7 from Aleisha Amohia --- Created attachment 47070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47070&action=edit Bug 15618: Typos fixed in searching.pref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 01:45:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 00:45:07 +0000 Subject: [Koha-bugs] [Bug 15558] To rename the patron expiration date field in patron screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15558 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tasham_8 at hotmail.com |ity.org | CC| |tasham_8 at hotmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 01:47:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 00:47:58 +0000 Subject: [Koha-bugs] [Bug 15617] Be able to close "Click to edit" text boxes after opening them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15617 --- Comment #2 from Gus Ellerm --- Created attachment 47071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47071&action=edit 15617 - Be able to close "Click to edit" text boxes after opening them Test 1. Go to admin preferences, Acquisitions, Policy. 2. Find MarcFieldsToOrder and click "Click to Edit" 3. Notice that a "Click to collapse" button appears, click it. 4. Notice that the box has collapsed This fix should be applicable to all "Click to Edit" textbox's -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 01:51:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 00:51:00 +0000 Subject: [Koha-bugs] [Bug 15617] Be able to close "Click to edit" text boxes after opening them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15617 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47069|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 01:53:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 00:53:31 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 --- Comment #8 from Aleisha Amohia --- Created attachment 47072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47072&action=edit Bug 15618: Typos fixed in staff_client.pref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 01:59:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 00:59:55 +0000 Subject: [Koha-bugs] [Bug 14875] Search serials by barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14875 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tasham_8 at hotmail.com |ity.org | CC| |tasham_8 at hotmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 02:05:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 01:05:47 +0000 Subject: [Koha-bugs] [Bug 13474] Untranslatable log actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47051|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 47073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47073&action=edit Bug 13474: Adding untranslatable log actions to viewlog.tt Added 'Run' Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 02:11:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 01:11:55 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #9 from Aleisha Amohia --- This is ready for sign-off. Look through the patches to confirm everything is correct and check I didn't miss anything. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 02:16:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 01:16:44 +0000 Subject: [Koha-bugs] [Bug 8055] reversing fines wonky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8055 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #9 from Aleisha Amohia --- (In reply to Marc V?ron from comment #8) > Is this bug still valid? Still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 02:34:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 01:34:20 +0000 Subject: [Koha-bugs] [Bug 15604] Accessibility: Can't tab to select link in acquisitions basket add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15604 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 02:34:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 01:34:50 +0000 Subject: [Koha-bugs] [Bug 15604] Accessibility: Can't tab to select link in acquisitions basket add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15604 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Aleisha Amohia --- *** This bug has been marked as a duplicate of bug 15603 *** -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 02:34:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 01:34:50 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 --- Comment #5 from Aleisha Amohia --- *** Bug 15604 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 02:34:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 01:34:51 +0000 Subject: [Koha-bugs] [Bug 15605] Accessibility: Can't tab to add link in serials routing list add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 Bug 15605 depends on bug 15604, which changed state. Bug 15604 Summary: Accessibility: Can't tab to select link in acquisitions basket add user popup http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15604 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 03:12:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 02:12:40 +0000 Subject: [Koha-bugs] [Bug 14875] Search serials by barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14875 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 03:12:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 02:12:43 +0000 Subject: [Koha-bugs] [Bug 14875] Search serials by barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14875 --- Comment #2 from Briana Greally --- Created attachment 47074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47074&action=edit Bug 14875 - Search serials by barcode This patch is only for the advanced search To test: 1. Go to serials 2. If required make a new subscription and/or then click on advanced search 3. See that there is no barcode field. 4. Apply patch and repeat steps, there should now be a barcode field. 5. Type in a barcode and hit search. See that your book shows up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 03:19:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 02:19:02 +0000 Subject: [Koha-bugs] [Bug 14875] Search serials by barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14875 natasha changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 03:20:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 02:20:32 +0000 Subject: [Koha-bugs] [Bug 15558] To rename the patron expiration date field in patron screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15558 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 03:20:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 02:20:35 +0000 Subject: [Koha-bugs] [Bug 15558] To rename the patron expiration date field in patron screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15558 --- Comment #1 from Chloe Alabaster --- Created attachment 47075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47075&action=edit Bug 15558 - To rename the patron expiration date field in patron screen To Test: 1- confirm that all places where "Expiration Date" for a patrons memebership ending now say "Renewal due" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 03:22:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 02:22:10 +0000 Subject: [Koha-bugs] [Bug 14875] Search serials by barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14875 --- Comment #3 from natasha --- This is not quite fixed, we will continue working on it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 03:23:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 02:23:49 +0000 Subject: [Koha-bugs] [Bug 15558] To rename the patron expiration date field in patron screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15558 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tasham_8 at hotmail.com |chloealabaster at gmail.com CC| |chloealabaster at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 03:28:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 02:28:40 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 03:28:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 02:28:43 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 --- Comment #3 from Gus Ellerm --- Created attachment 47076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47076&action=edit 15067 - Add additional languages to advanced search language search run update database script, look for new laguages under 'Language:' in Advanced search. Languages that should be added are: 1. Estonian 2. Latvian 3. Lithuanian 4. Inuktitut 5. Inupiaq -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 04:07:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 03:07:55 +0000 Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gel1163 at stacmail.net Assignee|koha-bugs at lists.koha-commun |gel1163 at stacmail.net |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 04:12:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 03:12:09 +0000 Subject: [Koha-bugs] [Bug 14875] Search serials by barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14875 Briana Greally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 04:12:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 03:12:12 +0000 Subject: [Koha-bugs] [Bug 14875] Search serials by barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14875 --- Comment #4 from Briana Greally --- Created attachment 47077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47077&action=edit Bug 14875 Search serials by barcode To test: 1. Go onto the 'Serials' page 2. In the quick search, there are only two search fields; ISSN and Title 3. Apply the patch 4. There should now be three search fields, 'Barcode' being added. 5. Fill in that field with a barcode and matching results should come up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 04:13:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 03:13:17 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |chloealabaster at gmail.com CC| |chloealabaster at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 04:16:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 03:16:35 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 04:26:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 03:26:06 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 04:26:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 03:26:09 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #5 from Chloe Alabaster --- Created attachment 47078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47078&action=edit Bug 15584 - Staff client list errors are incorrectly styled To Test- 1-In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. --note that it has some red in it like an error 2- apply patch 3-In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. --note that now it should be just yellow with black writing as an alert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 04:42:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 03:42:35 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #8 from David Cook --- Thanks Bouzid! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 08:32:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 07:32:06 +0000 Subject: [Koha-bugs] [Bug 15623] Spelling mistake in boraccount.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15623 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46974|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 47079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47079&action=edit 15623 - Spelling mistake in boraccount.pl Test - Search for writen, if not found fix is correct Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 08:34:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 07:34:56 +0000 Subject: [Koha-bugs] [Bug 15623] Spelling mistake in boraccount.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15623 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net --- Comment #3 from Mirko Tietgen --- Hi Gus, your patch works! You should set yourself as the "Assignee" of the bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 08:37:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 07:37:19 +0000 Subject: [Koha-bugs] [Bug 15622] Spelling mistake in printfreercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15622 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 08:37:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 07:37:22 +0000 Subject: [Koha-bugs] [Bug 15622] Spelling mistake in printfreercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15622 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46972|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen --- Created attachment 47080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47080&action=edit 15622 - Spelling mistake in printfeercpt.pl writen -> written Search the file for writen, when not found change sucsessful Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 08:44:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 07:44:16 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 08:44:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 07:44:19 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47078|0 |1 is obsolete| | --- Comment #6 from Mirko Tietgen --- Created attachment 47081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47081&action=edit Bug 15584 - Staff client list errors are incorrectly styled To Test- 1-In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. --note that it has some red in it like an error 2- apply patch 3-In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. --note that now it should be just yellow with black writing as an alert Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 08:57:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 07:57:34 +0000 Subject: [Koha-bugs] [Bug 15558] To rename the patron expiration date field in patron screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15558 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 08:57:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 07:57:37 +0000 Subject: [Koha-bugs] [Bug 15558] To rename the patron expiration date field in patron screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15558 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47075|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 47082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47082&action=edit Bug 15558 - To rename the patron expiration date field in patron screen To Test: 1- confirm that all places where "Expiration Date" for a patrons memebership ending now say "Renewal due" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 09:03:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 08:03:51 +0000 Subject: [Koha-bugs] [Bug 15558] To rename the patron expiration date field in patron screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15558 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47082|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen --- Created attachment 47083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47083&action=edit Bug 15558 - To rename the patron expiration date field in patron screen To Test: 1- confirm that all places where "Expiration Date" for a patrons memebership ending now say "Renewal due" Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 09:06:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 08:06:46 +0000 Subject: [Koha-bugs] [Bug 15558] To rename the patron expiration date field in patron screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15558 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #4 from Mirko Tietgen --- Hi Chloe, your patch works for me and fixes what the bug reporter described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 09:24:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 08:24:10 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #6 from Mirko Tietgen --- Hi Chloe, the patch works for me. But I think the nondescript look of the button is intended. What you could try: before applying your patch, open a part of the system preferences that needs scrolling to see all parameters. Scroll down a bit so you get the toolbar. The button is not very impressive. Then go into one of the parameter fields and change it. The button changes the layout now and looks more button-like, because there are changes to save. Do you see what I mean? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 09:36:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 08:36:10 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 09:36:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 08:36:13 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46966|0 |1 is obsolete| | --- Comment #6 from Mirko Tietgen --- Created attachment 47084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47084&action=edit Bug 15603 - Accessibility: Can't tab to select link in budgets add user popup To Test - 1. If you don't have a budget and a fund, make at least one of each. 2. Go to funds from budgets. 3. Either make a new fund or edit an existing one and then click Edit owner, which will bring up a pop-up tab. 4. Search for a patron. 5. Using the tab key try to navigate onto the Select link. 6. Notice it skips select. 7. Apply the patch and then repeat steps 3-5, notice the select link can now be accessed through using the keyboard. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 09:39:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 08:39:13 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #19 from Katrin Fischer --- > My concern is failure to automatically renew would fail to produce overdue > notices with &&. > "You owe $100 in fines." > "But I never got an overdue notice!" Libraries print the fine amount for each item into the overdue notice - so if you send the overdue notices without generating the fines first, it will list 0,00 or a wrong amount, which is what started this bug report :) > > (R && F) ; O? > The fines won't accidentally charge on automatic renewal failures, but the > overdues will run after the automatic renewals. > Does this look like a good solution? see above I'd also like to point out that we should try and decide something here - I am happy to make the changes, but currently this is really a bug with the sequence being totally wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 09:39:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 08:39:27 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #7 from Mirko Tietgen --- Hi Natasha, I followed your test plan, and with bug 14193 applied before, it works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 09:40:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 08:40:50 +0000 Subject: [Koha-bugs] [Bug 15514] New professional cataloguing editor does not handle repeatable fields correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15514 --- Comment #2 from Jonathan Druart --- Created attachment 47085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47085&action=edit bib-112.utf8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 09:53:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 08:53:37 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 09:53:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 08:53:41 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39392|0 |1 is obsolete| | Attachment #39393|0 |1 is obsolete| | Attachment #39394|0 |1 is obsolete| | Attachment #39395|0 |1 is obsolete| | Attachment #39396|0 |1 is obsolete| | Attachment #39397|0 |1 is obsolete| | Attachment #39398|0 |1 is obsolete| | Attachment #42770|0 |1 is obsolete| | --- Comment #227 from Jonathan Druart --- Created attachment 47086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47086&action=edit Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm - Subroutine prototypes used at line 86, column 1. See page 194 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 09:53:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 08:53:59 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #228 from Jonathan Druart --- Created attachment 47087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47087&action=edit Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm Expression form of "eval" at line 71, column 9. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 85, column 13. See page 161 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 09:54:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 08:54:07 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #229 from Jonathan Druart --- Created attachment 47088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47088&action=edit Bug 6679 - Fixing code so it passes basic Perl:::Critic tests opac/ilsdi.pl: Stricture disabled at line 217, column 17. See page 429 of PBP. (Severity: 5) Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 09:54:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 08:54:19 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #230 from Jonathan Druart --- Created attachment 47089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47089&action=edit Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 09:54:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 08:54:28 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #231 from Jonathan Druart --- Created attachment 47090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47090&action=edit Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Record.pm Expression form of "eval" at line 358, column 5. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 367, column 5. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 510, column 3. See page 161 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel Fixed conflict Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 09:57:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 08:57:39 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #232 from Jonathan Druart --- Patches rebased, changes to C4::Dates removed. Back to needs signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 10:28:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 09:28:18 +0000 Subject: [Koha-bugs] [Bug 15515] Date of Birth gadget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15515 --- Comment #2 from Fiona Borthwick --- I have been using 3.20.03.000 where the problem is still very apparent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 10:31:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 09:31:07 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 --- Comment #6 from Katrin Fischer --- I think place_holds is a good pick! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 10:35:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 09:35:04 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 10:35:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 09:35:06 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #1 from Jonathan Druart --- Created attachment 47091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47091&action=edit Bug 15632: Koha::Patron::Messages - Add new classes The following 4 CRUD subroutines in C4::Members: - AddMessage - DeleteMessage - GetMessagesCount - GetMessages could be replaced with a new package based on Koha::Objets. This patchset will add the 2 Koha::Patron::Message[s] classes, then use it to replace the different calls to these subroutine. It will slightly reduce the size of C4::Members -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 10:35:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 09:35:16 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #2 from Jonathan Druart --- Created attachment 47092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47092&action=edit Bug 15632: Koha::Patron::Messages - Be sure add and delete will log If the pref BorrowersLog is on, the store and delete method should log into the action_logs table. Easy to do by overloading them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 10:35:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 09:35:22 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #3 from Jonathan Druart --- Created attachment 47093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47093&action=edit Bug 15632: Koha::Patron::Messages - Remove AddMessage The AddMessage subroutine just 1. checked if all the parameters were passed 2. inserted the message in the DB 3. logged the action if needed These 3 jobs are now done by the overloaded store method of Koha::Patron::Message. Test plan: 1/ Go on the "check out" page of a patron 2/ Add different new messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 10:35:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 09:35:26 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #4 from Jonathan Druart --- Created attachment 47094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47094&action=edit Bug 15632: Koha::Patron::Messages - Remove DeleteMessage The DeleteMessage just deleted and logged if needed. This is now be done by Koha::Patron::Message->delete. Test plan: 1/ Go on the "check out" page of a patron 2/ Delete some messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 10:35:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 09:35:32 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #5 from Jonathan Druart --- Created attachment 47095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47095&action=edit Bug 15632: Koha::Patron::Messages - Remove GetMessagesCount The GetMessageCount subroutine was only used once, in opac-user.pl, to know if some messages will be displayed. Test plan: 1/ Create messages to display at the OPAC for a patron 2/ Logged this patron in at the OPAC, you should see the messages displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 10:35:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 09:35:37 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #6 from Jonathan Druart --- Created attachment 47096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47096&action=edit Bug 15632: Koha::Patron::Messages - Remove GetMessages This subroutine just retrieved the messages given some parameters. Some job should not have been done in this subroutine. It was called only 3 times, in circ/circulation.pl and opac-user.pl. Basically it was used to retrieved the message to displaye for a given patron ($borrowernumber) at the OPAC (B) or Staff (L). For the 3 calls, the 2 parameters $borrowernumber and $type (message_type) were passed, the "%" trick at the beginning of the subroutine was useless. Moreover, the date formatting should be done on the TT side, not in subroutine. The can_delete flag was set if the branchcode given in parameter was the same as the one of the message. This has been delegated to the template. Indeed the can_delete was not valid, since it must depend on the AllowAllMessageDeletion pref. The test is now: IF message.branchcode == branch OR Koha.Preference('AllowAllMessageDeletion'') There is not specific test plan for this patch, the changes have already been tested in previous patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 10:35:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 09:35:44 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #7 from Jonathan Druart --- Created attachment 47097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47097&action=edit Bug 15632: Koha::Patron::Messages - Remove tests The messages related tests in t/db_dependent/Members.t are not deprecated and can be removed. Test plan: git grep AddMessage git grep DeleteMessage git grep GetMessagesCount git grep GetMessages should not return any result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 10:36:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 09:36:20 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15632 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 10:36:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 09:36:20 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15548 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 11:11:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 10:11:39 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45906|0 |1 is obsolete| | Attachment #45907|0 |1 is obsolete| | Attachment #45908|0 |1 is obsolete| | Attachment #45913|0 |1 is obsolete| | Attachment #45914|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 47098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47098&action=edit Bug 15407: Koha::Patron::Categories - remove sql queries in some pl and pm This patch replaces sql queries done in some pl script and in C4::Reports::Guided. Since we have now a Koha::Patron::Categories module, we should use it where it is possible. Test plan: - Prerequisite: Be sure you have several patron categories created, with different option enabled, and limit some to certain libraries. - On the 'Circulation and fine rules' admin page (admin/smart-rules.pl), all the patron categories should be displayed (even the ones limited to another library), ordered by description. Try to add/update existing rules. - On the overdue rules page (tools/overduerules.pl), all the patron categories with overduenoticerequired set should be displayed. Try to add/update existing rules. - On the following reports: reports/borrowers_stats.pl reports/issues_avg_stats.pl The patron categories should be displayed. Note that there is an inconsistency with these 2 reports: the patron categories limited to other libraries are displayed on them, when they are not on the other reports. This should certainly be fixed (on another bug report). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 11:11:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 10:11:42 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #13 from Jonathan Druart --- Created attachment 47099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47099&action=edit Bug 15407: Koha::Patron::Categories - replace C4::Category->all The C4::Category module contained only 1 method to return the patron categories available for the logged in user. The new method Koha::Patron::Categories->search_limited does exactly the same thing (see tests) and must be used in place of it. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. - On the 'Item circulation alerts' admin page (admin/item_circulation_alerts.pl), modify the settings for check-in and checkout (NOTE: Should not we display all patron categories on this page? If yes, it must be done in another bug report to ease backporting it). - Search for patrons in the admin (budget) and acquisition (order) module. - On the patron home page (search form in the header) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 11:11:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 10:11:53 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #14 from Jonathan Druart --- Created attachment 47100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47100&action=edit Bug 15407: Koha::Patron::Categories - replace GetBorrowercategory The purpose of C4::Members::GetBorrowercategory was to return the patron category for a given categorycode. This can be done easily with the Koha::Patron::Categories->find method. Test plan: - Same prerequisite as before - Edit a guarantor and confirm the information will be updated for his/her guarantee(s). - Update a child to adult patron (Note: Should not we hide the patron categories limited to others libraries? If yes, it must be done on another bug report). There is a special behavior if there is only 1 adult category, the user does not need to select a category. So the same as before with only 1 adult patron category. - Import a patron with a category_code which does not exist. You should be warned. - Modify some patron using the batch patron modification tool. The patron category descriptions should correctly be displayed. Note that the overduerules page has already been tested in a previous patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 11:12:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 10:12:22 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #15 from Jonathan Druart --- Created attachment 47101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47101&action=edit Bug 15407: Koha::Patron::Categories - replace GetBorrowercategoryList C4::Members::GetBorrowercategoryList returned all the patron categories, ordered by description. This can be done using the search method of the Koha::Patron::Categories module. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by description. - On the "patron attribute types" admin page (admin/patron-attr-types.pl). - On the "Batch patron deletion/anonymization" (tools/cleanborrowers.pl), the dropdown list should be filled correctly. - On the import patron tool - On the following report: reports/reserves_stats.pl Confirm that the patron categories are displayed and that the report still works as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 11:12:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 10:12:28 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #16 from Jonathan Druart --- Created attachment 47102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47102&action=edit Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType This unnecessary complicated subroutine returned an arrayref and an hashref of the patron categories available for the logged in user, for a given category_type, ordered by categorycode. This can now be done with the search_limited method. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by categorycode. - Add/edit a patron, change his/her patron category value. - On the 3 following reports: reports/bor_issues_top.pl reports/borrowers_out.pl reports/cat_issues_top.pl The display for these 3 reports are different than the 2 from the first patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by categorycode and the ones limited to other libraries are not displayed (should certainly be fixed). Note that the big part of this patch has already been tested before (update child related: CATCODE_MULTI). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 11:13:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 10:13:05 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #17 from Jonathan Druart --- patches rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 11:24:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 10:24:33 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #15 from Jonathan Druart --- Created attachment 47104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47104&action=edit Bug 15548 [QA Followup] - Catch a couple new Koha::Borrower uses Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 11:24:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 10:24:29 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46728|0 |1 is obsolete| | Attachment #46729|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 47103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47103&action=edit Bug 15548: Move new patron related code to Patron* The 'borrower' should not be used anymore, especially for new code. This patch move files and rename variables newly pushed (i.e. in the Koha namespace). Test plan: 1/ git grep Koha::Borrower should not return code in use. 2/ Prove the different modified test files 3/ Do some clicks in the member^Wpatron module to be sure there is not an obvious error. Signed-off-by: Hector Castro Works as described. Tested with Circulation, Members/Patrons, Discharge, Restrictions modules and the must common functionalities Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 11:25:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 10:25:02 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #16 from Jonathan Druart --- Patches rebased, easy conflicts with bug 15295 fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 12:41:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 11:41:11 +0000 Subject: [Koha-bugs] [Bug 15479] SIPserver rejects renewals for patrons with alphanumeric cardnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479 --- Comment #4 from Colin Campbell --- (In reply to Fr?d?ric Demians from comment #3) > I get the reasoning, and agree with it. Do you think you could cook a unit > test to check this case? A UT which fails without your patch, and succeed > with it? > > And a minor point of detail: why do you use a function rather than a regex > in your test. For example: > > $item->{patron} && $item->{patron} !~ /^$patron_id$/i Readability it might be to easy for the eye to skip over the regex, and as the comparison is called twice ensure they both make the same test. Supplementary patch tests the sub's returns as well as adding basic tests for ILS.pm inteface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 12:45:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 11:45:13 +0000 Subject: [Koha-bugs] [Bug 15479] SIPserver rejects renewals for patrons with alphanumeric cardnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479 --- Comment #5 from Colin Campbell --- Created attachment 47105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47105&action=edit Add test for routine Add a test for the routine added in bug 15479 Adds a script making basic tests to ILS.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 12:48:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 11:48:15 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #233 from M. Tompsett --- Comment on attachment 47090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47090 Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Record.pm Review of attachment 47090: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6679&attachment=47090) ----------------------------------------------------------------- ::: C4/Record.pm @@ +380,4 @@ > } > > # Preprocessing > + eval {$preprocess} if ($preprocess); post-fixed 'if' logic prevents a higher level of perlcritic, doesn't it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 13:21:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 12:21:11 +0000 Subject: [Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512 --- Comment #7 from Kyle M Hall --- Here is an example AV field from another ILS I received from Comprise Technologies, a company that makes payment systems with work via SIP: AV31982012795201 188 $0.20 "OVERDUE" Barbie. A fashion fairytale [videorecording] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 13:24:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 12:24:02 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47041|0 |1 is obsolete| | --- Comment #50 from Kyle M Hall --- Created attachment 47106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47106&action=edit Bug 11405 [7] - Add out of order status to CSV file Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:08:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:08:27 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #9 from Bouzid --- I test with: File empty File contain 1 marc record File contain several marc record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:26:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:26:54 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from Owen Leonard --- I think the correct solution is to look at the commit that created the bug and see what changes were the cause: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=edd64d30188fef2b3ecb314ceeb1f613e2217cc2 The problem stems from the fact that Bug 11559 made changes to staff-global.css in a way that didn't take into account the toolbar in system preferences. http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css;h=11781bce7874c5e4c4d482c300666fd020039979;hp=d33580ab1d216f4f3b35b459dc22055587317b67;hb=edd64d30188fef2b3ecb314ceeb1f613e2217cc2;hpb=ac05c178b0317c570aa21bd5d2d5adf34cef38f2 As far as I can tell based on my test the deletions from staff-global.css made by that commit can be reversed while keeping the additions. I'm going to try to ask pianohacker if he knows of a reason not to do that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:27:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:27:54 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | Severity|enhancement |minor Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:34:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:34:09 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46955|0 |1 is obsolete| | --- Comment #10 from Owen Leonard --- Created attachment 47107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47107&action=edit [SIGNED-OFF] Bug 15618: Typos fixed in admin.pref To test: Confirm all typos under the Administration tab are fixed and that I haven't missed any. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:39:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:39:59 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #20 from M. Tompsett --- So what is really needed is a way to: - automatically renew output => list of failures - generate fines input => list of failures to exclude output => same or larger list of failures - overdues input => same or larger list of failures to exclude output => potentially bigger list of failures - email potentially bigger list of failures to administrator to deal with. If this list of failures could be passed from script to script to script, then semi-colons would work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:40:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:40:12 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44665|0 |1 is obsolete| | --- Comment #54 from Tom?s Cohen Arazi --- Created attachment 47108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47108&action=edit Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped inside a subtest, and look for AddReturn storing the right itemtype on the 'statistics' table. Note: It also refactors the file a bit, to avoid side effects. And uses TestBuilder to make it independent on already-present db data. It also removes warnings by mocking C4::Context::userenv To test: - Apply the patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail bacause AddReturn is not storing the itemtype - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:40:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:40:19 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44666|0 |1 is obsolete| | --- Comment #55 from Tom?s Cohen Arazi --- Created attachment 47109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47109&action=edit Bug 14598: Make C4::Circulation::AddReturn store the right itemtype This patch makes C4::Circulation::AddReturn correctly store the itemtype on the 'statistics' table. To reproduce: - Checkout master. - Make a checkout. - Check the 'statistics' table and notice the itemtype is correctly set > SELECT * FROM statistics; - Check the item in. - Check the 'statistics' table and notice the itemtype is not set > SELECT * FROM statistics WHERE type="return"; => FAIL: itemtype is set to NULL To test: - Apply the regression tests patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail - Apply this patch - Run the regression tests: $ prove t/db_dependent/Circulation/Returns.t => SUCCESS: Tests now pass. - Repeat the 'To reproduce' steps => SUCCESS: itemtype is now correctly set (in real life) - Happily sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:40:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:40:29 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44667|0 |1 is obsolete| | --- Comment #56 from Tom?s Cohen Arazi --- Created attachment 47110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47110&action=edit Bug 14598: (QA followup) Don't die on bad barcode Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:40:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:40:35 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44668|0 |1 is obsolete| | --- Comment #57 from Tom?s Cohen Arazi --- Created attachment 47111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47111&action=edit Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows This patch introduces an updatedatabase.pl entry that takes care of updating existing statistics rows. It does so by looping on the statistics rows, collecting itemnumber occurences that are have NULL itemtypes. It then chooses the right itemtype following what is proposed on bug 14651, and then updates the rows in statistics using the calculated itemtype. Regards Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:40:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:40:41 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45030|0 |1 is obsolete| | --- Comment #58 from Tom?s Cohen Arazi --- Created attachment 47112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47112&action=edit Bug 14598 - QA Followup touching CanBookBeIssued subroutine Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:40:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:40:51 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45047|0 |1 is obsolete| | --- Comment #59 from Tom?s Cohen Arazi --- Created attachment 47113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47113&action=edit Bug 14598 [QA Followup] - Only fetch bib data if needed Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:41:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:41:01 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45844|0 |1 is obsolete| | --- Comment #60 from Tom?s Cohen Arazi --- Created attachment 47114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47114&action=edit Bug 14598 [QA Followup] - Correct the behavior of GetItem Currently GetItem sets itemtype to the biblio itemtype if no item level itemtype exists. Instead, it should only do this if item_level-itypes is not set. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:41:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:41:08 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46546|0 |1 is obsolete| | --- Comment #61 from Tom?s Cohen Arazi --- Created attachment 47115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47115&action=edit Bug 14598 [QA Followup] - Make unit test pass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:41:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:41:43 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:41:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:41:48 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46877|0 |1 is obsolete| | --- Comment #62 from Tom?s Cohen Arazi --- Created attachment 47116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47116&action=edit Bug 14598 [QA Followup] - Update localuse statistics also Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:46:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:46:15 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #21 from Katrin Fischer --- Can we have a simple fix first? For your suggestion we'd need to touch a lot of scripts, and also: - Auto-renewal - can be repeated without change for already renewed - fines.pl - can be repeated, without problems - overdue_notices - will generate a new notice if repeated. So you'd have to pass a positive list to avoid sending double notices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:52:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:52:10 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #22 from Katrin Fischer --- > - overdue_notices - will generate a new notice if repeated. So you'd have to > pass a positive list to avoid sending double notices. Actually... I don't think that would work. Why is it so bad if they all don't run, if there is really a bigger problem with one of them? That's how it is now and it doesn't seem to be a problem that occurs frequently. We have been running our installations with a changed cronjob sequence since the very beginning (fines before overdues). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:52:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:52:44 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 47117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47117&action=edit Bug 14532: (followup) Use tar's --exclude for simplicity This patch creates an --exclude definition for the tar command so it is easier to stack excluded stuff. It does so for the authority and biblio indexes if --exclude-indexes is passed. A side effect from this, is that uploads and plugins are still backed up, as Jonathan noted. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:57:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:57:00 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 --- Comment #9 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > Marcel, > Why do you remove temporary uploads? Because of their temporary nature :) When I wrote this, I had the hope to still include this in 3.22. So deleting these files was not an issue. But, since these files have been uploaded as temporary, I imagine that we can delete them as well at the time of an upgrade to the next release. A future cron job should do that too (e.g. after x days). For a server with multiple instances it would be more complex. Instead of picking the files for each instance and moving them to different tmp subfolders, it is much easier to remove them. Note also that we could have permission problems here (even with deleting the folder). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 14:58:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 13:58:24 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 --- Comment #11 from Owen Leonard --- (In reply to Aleisha Amohia from comment #4) > Created attachment 47063 [details] [review] > Bug 15618: Typos fixed in enhanced_content.pref This one doesn't work for me. Syck parser (line 58, column 15): syntax error at /usr/lib/x86_64-linux-gnu/perl5/5.20/YAML/Syck.pm line 75. I think it's the use of a colon followed by a space. Since I don't know offhand what the rules are for this kind of data structure I look at other instances where a colon is used and I see that if you wrap the string in single quotes that works (see for instance line 70, 'Baker and Taylor "My Library Bookstore"...). Simply removing the space works too. I think it would also be nice to format it like this: - 'The URL for the Babeltheque javascript file (eg. http://www.babeltheque.com/bw_XX.js):' - pref: Babeltheque_url_js This seems to be a more common format (Description: URL). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:01:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:01:09 +0000 Subject: [Koha-bugs] [Bug 15558] To rename the patron expiration date field in patron screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15558 --- Comment #5 from Suresh Kumar --- Thank you very much. This is really helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:03:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:03:43 +0000 Subject: [Koha-bugs] [Bug 15633] New: Allow to enter billingdate when adding a new shipment Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15633 Bug ID: 15633 Summary: Allow to enter billingdate when adding a new shipment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When adding a new shipment in acquisitions, you can enter the invoice number and shipment date, but not the billing date. As you are already adding data from the invoice you received, it would be helpful for libraries to be able to enter the billing date at this point as well. Currently you can only add it after you finished processing the delivery. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:07:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:07:14 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47117|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:11:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:11:43 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 --- Comment #12 from Owen Leonard --- (In reply to Aleisha Amohia from comment #2) > Created attachment 46958 [details] [review] > Bug 15618: Typos fixed in circulation.pref This one gives me an error too: Syck parser (line 283, column -1): syntax error at /usr/lib/x86_64-linux-gnu/perl5/5.20/YAML/Syck.pm line 75. I think it's bad single quote/double quote combinations on lines 281 and 428. I think you need to use single quotes if the whole string is wrapped in double quotes and vice versa. Also: "checkouts of items which are reserved to someone else. If allowed do not generate RESERVE_WAITING and RESERVED warning. This allows self checkouts for those items." We try to standardize on the word "hold" instead of "reserve," so I suggest: "checkouts of items which are on hold for someone else. If allowed do not generate RESERVE_WAITING and RESERVED warning. This allows self checkouts for those items." "Reserves" at this time is only used when referring to Course Reserves. If we are making terminology changes to this file, it would be good to catch the instances of the word "borrower" which should be replaced with "patron." Also look at places where the word "issue" is used in descriptions to mean "check out." For instance: "update a bibliographic record's total issues count whenever an item is issued" Using the default English translation's terminology standard that should be: "update a bibliographic record's total checkouts count whenever an item is checked out" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:13:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:13:14 +0000 Subject: [Koha-bugs] [Bug 15634] New: Show uploaded content in an image gallery Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15634 Bug ID: 15634 Summary: Show uploaded content in an image gallery Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org If you have digitized content in the form of images, it would be nice to page through them via some kind of caroussel or gallery when using the link from MARC21 tag 856. (At this time we put images in a pdf and link the pdf to that field. But this requires downloading the whole file at once.) Note that this may require some additional group level for uploaded files in the uploaded_files table. Ideas are welcome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:14:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:14:55 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47065|0 |1 is obsolete| | --- Comment #13 from Owen Leonard --- Created attachment 47118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47118&action=edit [SIGNED-OFF] Bug 15618: Typos fixed in logs.pref Typos fixed in logs.pref Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:19:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:19:35 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47066|0 |1 is obsolete| | --- Comment #14 from Owen Leonard --- Created attachment 47119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47119&action=edit [SIGNED-OFF] Bug 15618: Typos fixed in opac.pref Typos fixed in opac.pref Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:22:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:22:27 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47070|0 |1 is obsolete| | --- Comment #15 from Owen Leonard --- Created attachment 47120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47120&action=edit [SIGNED-OFF] Bug 15618: Typos fixed in searching.pref Typos fixed in searching.pref Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:25:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:25:55 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47072|0 |1 is obsolete| | --- Comment #16 from Owen Leonard --- Created attachment 47121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47121&action=edit [SIGNED-OFF] Bug 15618: Typos fixed in staff_client.pref Typos fixed in staff_client.pref Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:29:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:29:46 +0000 Subject: [Koha-bugs] [Bug 15353] patron image disappears when on fines tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15635 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 [Bug 15635] Move the patron images related code to Koha::Patron::Images -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:29:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:29:46 +0000 Subject: [Koha-bugs] [Bug 15635] New: Move the patron images related code to Koha::Patron::Images Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Bug ID: 15635 Summary: Move the patron images related code to Koha::Patron::Images Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 15353 Blocks: 15449 There are 3 subroutines in C4::Members to get, add and delete patron images. By creating 2 Koha::Patron::Image[s] classes, we could remove them. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 [Bug 15353] patron image disappears when on fines tab http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:29:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:29:46 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15635 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 [Bug 15635] Move the patron images related code to Koha::Patron::Images -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:30:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:30:17 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:44:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:44:32 +0000 Subject: [Koha-bugs] [Bug 15558] To rename the patron expiration date field in patron screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15558 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #6 from Owen Leonard --- I think that this change either goes too far or doesn't go far enough. I don't see the need for this change. I think it's clear in the context of patron records what the word means. I also don't think this kind of global terminology change should be made on the basis of one suggestion. I think we need to get more opinions. If consensus is reached, then the change should be made in a more comprehensive way. The use of the word "expire" in reference to patron accounts is broader than just labels. There are instances throughout the interface where descriptions use variations: "You can decide if this patron category is blocked from performing actions in the OPAC if their card is expired" "If your patron cards expire (based on your patron category settings)..." "[ patron name ]'s account has expired..." "...you cannot place holds because your library card has expired..." Translators: Is there an internationalization issue here? In Koha's English translation the term "expire" can refer to a patron account, a hold, a list invitation, a news item, a self-checkout session, and a subscription. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:53:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:53:38 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:53:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:53:40 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #1 from Jonathan Druart --- Created attachment 47122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47122&action=edit Bug 15635: Koha::Patron::Images - Add new classes There are 3 subroutines in C4::Members to get, add and delete patron images: - GetPatronImage - PutPatronImage - RmPatronImage By creating these 2 Koha::Patron::Image[s] classes, we could remove them easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:53:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:53:49 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45884|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 47123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47123&action=edit Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices This bug is the beginning of a conversion from our current bespoke syntax for slips and notices to Template Toolkit syntax. This patch is the initial seed which will evolve over time. With this addition, we can take advantage of our Koha Objects to greatly simplify the processing of Slips and Notices over time. Test Plan: 1) Apply this patch 2) Ensure you have the default CHECKOUT notice 3) Check out and return an item for a patron 4) Note the text of the CHECKOUT notice 5) Replace your CHECKOUT notice with the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 6) Repeat step 3 7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text Signed-off-by: Bernardo Gonzalez Kriegel New notice syntax works, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:53:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:53:51 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #2 from Jonathan Druart --- Created attachment 47124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47124&action=edit Bug 15635: Koha::Patron::Images - Remove PutPatronImage The C4::Members::PutPatronImage inserted/updated the image of a patron. This can be done easily with ->find->set->store or ->new->store Test plan: 1/ Modify the image of a patron from the patron detail page 2/ Add an image to a new patron 3/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add or modify the image of a patron 4/ Use the "Upload patron images" tools (tools/picture-upload.pl) to add or modify the image of several patrons, using a zip file. Stress the script trying to get as many errors as possible (wrong cardnumber, wrong mimetype, file does not exist, etc.) With this patch, if the cardnumber does not exist, you will get a specific error "Image not imported because this patron does not exist in the database" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:53:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:53:54 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #3 from Jonathan Druart --- Created attachment 47125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47125&action=edit Bug 15635: Koha::Patron::Images - Remove RmPatronImage The C4::Members::RmPatronImage just removed a row in patronimage. This can be accomplished using the delete method of Koha::Patron::Image. Test plan: >From the patron defail page, try to delete the image of a patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:53:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:53:57 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #4 from Jonathan Druart --- Created attachment 47126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47126&action=edit Bug 15635: Koha::Patron::Images - Remove GetPatronImage To retrieve a patron image, we can call Koha::Patron::Images->find or Koha::Patrons->find->image Both will return a Koha::Patron::Image object. Test plan: 1/ From the patron/member module, open all tabs on the left (Checkouts, detail, fines, etc.) The image should be correctly displayed. 2/ At the OPAC, on the patron details page (opac-memberentry.pl) the image should be displayed as well. 3/ Same on the sco module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:54:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:54:19 +0000 Subject: [Koha-bugs] [Bug 15617] Be able to close "Click to edit" text boxes after opening them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15617 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:57:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:57:11 +0000 Subject: [Koha-bugs] [Bug 15617] Be able to close "Click to edit" text boxes after opening them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15617 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 15:57:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 14:57:14 +0000 Subject: [Koha-bugs] [Bug 15617] Be able to close "Click to edit" text boxes after opening them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15617 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47071|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 47127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47127&action=edit [SIGNED-OFF] 15617 - Be able to close "Click to edit" text boxes after opening them To test: 1. Go to admin preferences, Acquisitions, Policy. 2. Find MarcFieldsToOrder and click "Click to Edit" 3. Notice that a "Click to collapse" button appears, click it. 4. Notice that the box has collapsed This fix should be applicable to all "Click to Edit" textboxes Signed-off-by: Owen Leonard Works well, and a nice improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:01:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:01:54 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46169|0 |1 is obsolete| | --- Comment #60 from M. Tompsett --- Created attachment 47128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47128&action=edit Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber at provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber at messaging.sprintpcs.com Verizon phonenumber at vtext.com T-Mobile phonenumber at tmomail.net AT&T phonenumber at txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:02:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:02:07 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46170|0 |1 is obsolete| | --- Comment #61 from M. Tompsett --- Created attachment 47129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47129&action=edit Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:02:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:02:19 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46171|0 |1 is obsolete| | --- Comment #62 from M. Tompsett --- Created attachment 47130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47130&action=edit Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:02:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:02:51 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47123|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 47131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47131&action=edit Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices This bug is the beginning of a conversion from our current bespoke syntax for slips and notices to Template Toolkit syntax. This patch is the initial seed which will evolve over time. With this addition, we can take advantage of our Koha Objects to greatly simplify the processing of Slips and Notices over time. Test Plan: 1) Apply this patch 2) Ensure you have the default CHECKOUT notice 3) Check out and return an item for a patron 4) Note the text of the CHECKOUT notice 5) Replace your CHECKOUT notice with the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 6) Repeat step 3 7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text Signed-off-by: Bernardo Gonzalez Kriegel New notice syntax works, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:04:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:04:25 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #234 from Jonathan Druart --- "post-fixed if" You mean the use of ternary operators? If yes, please source, I have never heard about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:17:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:17:46 +0000 Subject: [Koha-bugs] [Bug 15617] Be able to close "Click to edit" text boxes after opening them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15617 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:17:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:17:49 +0000 Subject: [Koha-bugs] [Bug 15617] Be able to close "Click to edit" text boxes after opening them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15617 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47127|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 47132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47132&action=edit 15617 - Be able to close "Click to edit" text boxes after opening them To test: 1. Go to admin preferences, Acquisitions, Policy. 2. Find MarcFieldsToOrder and click "Click to Edit" 3. Notice that a "Click to collapse" button appears, click it. 4. Notice that the box has collapsed This fix should be applicable to all "Click to Edit" textboxes Signed-off-by: Owen Leonard Works well, and a nice improvement. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:18:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:18:11 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47128|0 |1 is obsolete| | --- Comment #63 from M. Tompsett --- Created attachment 47133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47133&action=edit Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber at provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber at messaging.sprintpcs.com Verizon phonenumber at vtext.com T-Mobile phonenumber at tmomail.net AT&T phonenumber at txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:18:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:18:20 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47129|0 |1 is obsolete| | --- Comment #64 from M. Tompsett --- Created attachment 47134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47134&action=edit Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:18:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:18:29 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47130|0 |1 is obsolete| | --- Comment #65 from M. Tompsett --- Created attachment 47135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47135&action=edit Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:19:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:19:35 +0000 Subject: [Koha-bugs] [Bug 15622] Spelling mistake in printfreercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15622 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Hello Gus, There are other occurrences of 'writen' in other files, could you please patch them too? koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_100.tt:// * This function get the publication date if it's writen on 210d members/boraccount.pl:#writen 11/1/2000 by chris at katipo.oc.nz members/printinvoice.pl:#writen 3rd May 2010 by kmkale at anantcorp.com adapted from boraccount.pl by chris at katipo.oc.nz reserve/placerequest.pl:#writen 2/1/00 by chris at katipo.oc.nz reserve/request.pl:#writen 2/1/00 by chris at katipo.oc.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:20:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:20:10 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #235 from M. Tompsett --- (In reply to Jonathan Druart from comment #234) > "post-fixed if" > You mean the use of ternary operators? > If yes, please source, I have never heard about that. http://search.cpan.org/dist/Perl-Critic-1.126/lib/Perl/Critic/Policy/ControlStructures/ProhibitPostfixControls.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:24:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:24:00 +0000 Subject: [Koha-bugs] [Bug 15583] List of lists in the staff client should have a default sort In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15583 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:24:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:24:03 +0000 Subject: [Koha-bugs] [Bug 15583] List of lists in the staff client should have a default sort In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15583 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47064|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 47136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47136&action=edit [SIGNED-OFF] Bug 15583 - List of lists in the staff client should have a default sort To Test: 1- first make sure you have lists from different dates, -- if you dont you can go to databases and change the created_on date (by changing the date on the database you can also ensure that the shelfnumber doesn't align with the creation date, replicating the bug being fixed.) 2- after making lists apply patch and refresh page, the lists should be sorted by creation date by default instead of by the "shelfnumber" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:30:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:30:51 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:33:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:33:36 +0000 Subject: [Koha-bugs] [Bug 15558] To rename the patron expiration date field in patron screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15558 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- I think in German Ablauf/ablaufen etc. would work for all of those. Could 'Renewal due' in English be misunderstood as the date for renewing your items? We also use Renewal in a lot of contexts, I can think of issues, subscriptions and patron accounts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:33:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:33:57 +0000 Subject: [Koha-bugs] [Bug 15579] records_batchmod permission doesn't allow access to batch modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 --- Comment #2 from Marc V?ron --- Created attachment 47137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47137&action=edit Bug 15579: Fix permission for batch record modification To test: - For a patron, permissions 'catalogue' and 'records_batchmod' only - Go to Bug 15579 - records_batchmod permission doesn't allow access to batch modification Without patch: You have no permisson to acces the page. With patch: Page 'Batch record modification' displays as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:34:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:34:06 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- I disagree with this patch, the "already exist" case is taken into account with the Koha::Exceptions::Virtualshelves::DuplicateObject exception. In some case, an error could happen, it's wrong to change all 'error' with 'alert' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:35:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:35:07 +0000 Subject: [Koha-bugs] [Bug 15579] records_batchmod permission doesn't allow access to batch modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |veron at veron.ch Assignee|gmcharlt at gmail.com |veron at veron.ch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:35:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:35:18 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #8 from Jonathan Druart --- Created attachment 47138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47138&action=edit Bug 15584: Example -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:36:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:36:01 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #9 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > Created attachment 47138 [details] [review] > Bug 15584: Example Gus, With this patch, we have the correct style for the duplicate message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:37:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:37:54 +0000 Subject: [Koha-bugs] [Bug 15579] records_batchmod permission doesn't allow access to batch modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47137|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 47139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47139&action=edit Bug 15579: Fix permission for batch record modification To test: - For a patron, permissions 'catalogue' and 'records_batchmod' only - Log in as this patron - Go to /cgi-bin/koha/tools/batch_record_modification.pl Without patch: You have no permisson to acces the page. With patch: Page 'Batch record modification' displays as expected. (Amended to fix wrong test plan) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:40:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:40:59 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #236 from Jonathan Druart --- We have a massive usage of ternary operators, it won't violate our perlcritic policy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:44:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:44:41 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #10 from Owen Leonard --- Jonathan I don't understand your comments. Are you saying that there are cases where the "error" value is required for some other aspect of the code? There is no standard interface element with an "error" class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:48:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:48:06 +0000 Subject: [Koha-bugs] [Bug 15558] To rename the patron expiration date field in patron screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15558 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #8 from Marc V?ron --- Question (as a non native speaker): What is the main reason to change 'Expiration date:'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:50:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:50:34 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |In Discussion --- Comment #2 from H?ctor Eduardo Castro Avalos --- I got this error: Software error: Can't call method "get_attr" without a package or object reference at /home/koha/kohaclone/patroncards/edit-batch.pl line 137. But isn't your patch the problem here! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:51:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:51:49 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #11 from Jonathan Druart --- (In reply to Owen Leonard from comment #10) > Jonathan I don't understand your comments. Are you saying that there are > cases where the "error" value is required for some other aspect of the code? > There is no standard interface element with an "error" class. Haa! Sorry, I have not got it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:51:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:51:58 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47138|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 16:53:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 15:53:56 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from Jonathan Druart --- I have found acqui/parcel.tt:
    acqui/parcel.tt:
    tools/batch_delete_records.tt:
    tools/batch_record_modification.tt:
    Are they wrong? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 17:08:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 16:08:01 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #13 from Owen Leonard --- (In reply to Jonathan Druart from comment #12) > Are they wrong? Yes, as far as I'm concerned they are. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 17:22:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 16:22:58 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #3 from H?ctor Eduardo Castro Avalos --- (In reply to H?ctor Eduardo Castro Avalos from comment #2) > I got this error: > > Software error: > > Can't call method "get_attr" without a package or object reference at > /home/koha/kohaclone/patroncards/edit-batch.pl line 137. > > But isn't your patch the problem here! Ok the error is lauched when NO LIBRARY IS SET, i.e., when you're using the koha db admin user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 17:28:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 16:28:39 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 17:28:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 16:28:42 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46976|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 47140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47140&action=edit [SIGNED-OFF]Bug 15602: Accessibility: Can't tab to add link in patron card creator add patrons popup To Test - 1. Go onto Tools and then click on Patron Card Creator. 2. Click on New and then Card Batch. 3. Add a borrowernumber then add patron. 4. Search for a patron. 5. Using the tab key try to navigate onto the Add link. 6. Notice it skips Add. 7. Apply the patch and then repeat steps 1-5, notice the add link can now be accessed through using the keyboard. Signed-off-by: Hector Castro Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 17:33:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 16:33:10 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #237 from Chris Nighswonger --- FWIW, somewhere in the distant past we had a discussion regarding how strict to enforce Conway-style on our code. As I recall, there was a general consensus at that time to apply only limited requirements. As Jonathan's observation points out: increasing style strictness may require a lot of refactoring. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 17:34:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 16:34:32 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #14 from Owen Leonard --- Looking at an instance where "dialog error" is used, I see this in itemtypes.tt: [% IF message.type == 'success' %]
    [% ELSIF message.type == 'warning' %]
    [% ELSIF message.type == 'error' %]
    [% END %] In the past we have not distinguished between warnings and errors. Both were styled with the "dialog alert" style. But I'm not opposed to defining a new style specifically for errors and setting up a guideline for its use. I can imagine it being useful to say this, for instance: - "dialog alert" used in cases where there is a problem which requires the user to respond to a question: Yes or no, proceed or cancel. - "dialog error" used in cases where the process is stopped, blocked by an error and there is no path forward. I prefer simplicity if this distinction is not necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 18:08:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 17:08:10 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 19:54:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 18:54:16 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #66 from M. Tompsett --- Given that some of these patches are mine, that is why it was Needs Signoff. Setting back. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 19:56:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 18:56:19 +0000 Subject: [Koha-bugs] [Bug 15636] New: DataTables Warning: Requested unknown parameter from opac-detail.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 Bug ID: 15636 Summary: DataTables Warning: Requested unknown parameter from opac-detail.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: remi.mayrand-provencher at inLibro.com QA Contact: testopia at bugs.koha-community.org the jQuery that generates the DataTable for the holdings (in opac-detail.tt) can bug depending on the instance's system preferences. The header's columns are generated depending on various system preferences, but the jquery that tries to build the DataTable is using a different test for one of the columns, so it isn't calculating how many columns it has to build right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 20:02:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 19:02:05 +0000 Subject: [Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 --- Comment #1 from R?mi Mayrand-Provencher --- Created attachment 47141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47141&action=edit Bug15636 - DataTables Warning: Requested unknown parameter from opac-detail.tt Fixes the jQuery that builds the holdingst DataTable in opac-detail.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 20:03:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 19:03:22 +0000 Subject: [Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |remi.mayrand-provencher at inL | |ibro.com CC| |eric.begin at inLibro.com, | |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 20:20:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 19:20:14 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #238 from M. Tompsett --- (In reply to Jonathan Druart from comment #236) > We have a massive usage of ternary operators, it won't violate our > perlcritic policy. While true, it's easier to fix it while working on it piece by piece rather than try to refactor massively later. No biggie. It's not something worth failing this over. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:00:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:00:48 +0000 Subject: [Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47141|0 |1 is obsolete| | --- Comment #2 from R?mi Mayrand-Provencher --- Created attachment 47142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47142&action=edit Bug 15636 - DataTables Warning: Requested unknown parameter from opac-detail.tt Fixes the jQuery that generates the holdingst DataTable by adding the missing UNLESS and IF tests to it. The IF and UNLESS in opac-detail.tt need to be the same in the header declaration of the DataTable and the jquery that builds it or else there can be an error depening on the system preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:08:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:08:26 +0000 Subject: [Koha-bugs] [Bug 15623] Spelling mistake in boraccount.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15623 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |gel1163 at stacmail.net |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:09:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:09:33 +0000 Subject: [Koha-bugs] [Bug 15621] Spelling mistake in printinvoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15621 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |gel1163 at stacmail.net |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:28:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:28:34 +0000 Subject: [Koha-bugs] [Bug 15637] New: Spelling mistake in placerequest.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15637 Bug ID: 15637 Summary: Spelling mistake in placerequest.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: gel1163 at stacmail.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:29:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:29:07 +0000 Subject: [Koha-bugs] [Bug 15638] New: spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 Bug ID: 15638 Summary: spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: chloealabaster at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com /placerequest.pl:4: writen ==> written -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:32:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:32:01 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gel1163 at stacmail.net --- Comment #1 from Gus Ellerm --- *** Bug 15637 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:32:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:32:01 +0000 Subject: [Koha-bugs] [Bug 15637] Spelling mistake in placerequest.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15637 Gus Ellerm changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Gus Ellerm --- *** This bug has been marked as a duplicate of bug 15638 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:32:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:32:50 +0000 Subject: [Koha-bugs] [Bug 15639] New: Spelling mistake in request.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15639 Bug ID: 15639 Summary: Spelling mistake in request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: gel1163 at stacmail.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:34:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:34:10 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:34:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:34:12 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 --- Comment #2 from Chloe Alabaster --- Created attachment 47143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47143&action=edit Bug 15638 - spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written To Test- check that in line 4 of this file "writin" has been corrected to "written" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:36:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:36:03 +0000 Subject: [Koha-bugs] [Bug 14300] sip.output-log does not record timestamps or process IDs. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14300 --- Comment #1 from Barton Chittenden --- This is addressed by Bug 15253 -- possible duplicate? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:37:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:37:24 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 --- Comment #3 from Chloe Alabaster --- Created attachment 47144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47144&action=edit Bug 15639 - Spelling mistake in request.pl To Test- chek that in line 4 "writen" has been changed to "written" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:38:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:38:07 +0000 Subject: [Koha-bugs] [Bug 14933] SIPserver should not use warn or die to log errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14933 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #1 from Barton Chittenden --- Bug 15253 may already address this, if not, it provides a clean solution. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:38:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:38:10 +0000 Subject: [Koha-bugs] [Bug 15639] Spelling mistake in request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15639 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:38:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:38:12 +0000 Subject: [Koha-bugs] [Bug 15639] Spelling mistake in request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15639 --- Comment #1 from Chloe Alabaster --- Created attachment 47145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47145&action=edit Bug 15639 - Spelling mistake in request.pl To Test- chek that in line 4 "writen" has been changed to "written" http://bugs.koha-community.org/show_bug.cgi?id=15638 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:38:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:38:54 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 --- Comment #4 from Chloe Alabaster --- (In reply to Chloe Alabaster from comment #3) > Created attachment 47144 [details] [review] > Bug 15639 - Spelling mistake in request.pl > > To Test- > chek that in line 4 "writen" has been changed to "written" please ignore this comment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:49:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:49:03 +0000 Subject: [Koha-bugs] [Bug 15622] Spelling mistake in printfreercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15622 --- Comment #5 from Gus Ellerm --- 15609 - unimarc_fild_100.tt 15623 - boraccount.pl 15621 - printinvoice.pl 15638 - placerequest.pl 15639 - request.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 21:49:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 20:49:12 +0000 Subject: [Koha-bugs] [Bug 14489] Software error when trying to create new batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14489 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #7 from H?ctor Eduardo Castro Avalos --- This has been changed a little bit, but problem remain there. To reproduce the issue: 1)Log in as database administrator account. 2)Goto Tools > Patron card creator > Batches > New > Card batch 3)Get notice the label "Current library: NO_LIBRARY_SET" 4)Add a borrowernumber like 51 and click in button Add patron(s) 5)The error is launched. 6)Log out the user and login with another admin account with the librarian permissions. 7)Repeat the steps 1 to 6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 22:03:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 21:03:03 +0000 Subject: [Koha-bugs] [Bug 14489] Software error when trying to create new batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14489 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 22:03:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 21:03:05 +0000 Subject: [Koha-bugs] [Bug 14489] Software error when trying to create new batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14489 --- Comment #8 from H?ctor Eduardo Castro Avalos --- Created attachment 47146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47146&action=edit Bug 14489: Patron card creator fail when login with database administrator account To reproduce the issue: 1)Log in as database administrator account. 2)Goto Tools > Patron card creator > Batches > New > Card batch 3)Get notice the label "Current library: NO_LIBRARY_SET" 4)Add a borrowernumber like 51 and click in button Add patron(s) 5)The error is launched. 6)Log out the user and login with another admin account with the librarian permissions. 7)Repeat the steps 1 to 6. To test: -Apply patch -Follow steps 1 to 6 -Notice about the new informational message "Set library" -Also see the warning message displayed when add patron 51. Koha should not fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 22:04:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 21:04:37 +0000 Subject: [Koha-bugs] [Bug 14489] Software error when trying to create new batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14489 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 22:07:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 21:07:30 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47063|0 |1 is obsolete| | --- Comment #17 from Aleisha Amohia --- Created attachment 47147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47147&action=edit Bug 15618: Typos fixed in enhanced_content.pref This page should work properly now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 22:10:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 21:10:14 +0000 Subject: [Koha-bugs] [Bug 14489] Software error when trying to create new batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14489 --- Comment #9 from Liz Rea --- I don't really it is a problem that the database administrator account can't create batches. You shouldn't be using that account to do work. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 22:17:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 21:17:55 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 22:17:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 21:17:58 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46958|0 |1 is obsolete| | --- Comment #18 from Aleisha Amohia --- Created attachment 47148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47148&action=edit Bug 15618: Typos fixed in circulation.pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 22:30:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 21:30:10 +0000 Subject: [Koha-bugs] [Bug 14603] Warns when checking in items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14603 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Aleisha Amohia --- I can't reproduce this anymore :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 22:34:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 21:34:19 +0000 Subject: [Koha-bugs] [Bug 14489] Software error when trying to create new batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14489 --- Comment #10 from H?ctor Eduardo Castro Avalos --- You're right Liz(In reply to Liz Rea from comment #9) > I don't really it is a problem that the database administrator account can't > create batches. You shouldn't be using that account to do work. > > Liz You're right Liz. The software doesn't crash in a normal way. What do you think about this, Jonathan? If you prefer guys close the bug. No biggie if you feel this patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 22:37:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 21:37:39 +0000 Subject: [Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Remi, can you please add a test plan to your commit message? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 22:54:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 21:54:25 +0000 Subject: [Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7720 --- Comment #4 from Blou --- Hello Cate, We'll need your help on that. You see, we cannot reproduce the situation without hacking the code. It arose because we're adding an extra column in there for ebooks, in a custom development. It causes a jqury message to pop up in the UI because of the imbalance in column count. The origin of it is commit 6d32d66f, by bug #7720. You can see in there that it's missing the javascript part for the test. So, not sure how to test it. Except that by looking at the code (and 7720's code), it's "obvious". Just need a way to translate it into a scenario... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 22:54:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 21:54:25 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15636 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 21 23:01:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 22:01:05 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #10 from Aleisha Amohia --- Applying: Bug 14168 - enhance streaming cataloging to include youtube /home/vagrant/kohaclone/.git/rebase-apply/patch:47: trailing whitespace. $HTML5Media_field->subfield('u'), { warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... :47: trailing whitespace. $HTML5Media_field->subfield('u'), { warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Installer/PerlDependencies.pm CONFLICT (content): Merge conflict in C4/Installer/PerlDependencies.pm Auto-merging C4/HTML5Media.pm CONFLICT (content): Merge conflict in C4/HTML5Media.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 00:04:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 23:04:20 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 --- Comment #4 from Chloe Alabaster --- I tested this, cant sign off but it worked for me --as a side note it would be nice if the languages were sorted in alphabetical order to that it is easier to find the language you want..at the moment they seem to be sorted by when they were added to the database eg the ones Gus has added are the last languages on there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 00:20:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 23:20:04 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chloealabaster at gmail.com --- Comment #12 from Chloe Alabaster --- I am also having the same problem as Aleisha where they aren't on the same line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 00:23:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 23:23:03 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #239 from M. Tompsett --- C4::Record unused variables. Run koha qa test tools -v 2 -c 5. perlcritic -5 C4/Record.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 00:28:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 23:28:39 +0000 Subject: [Koha-bugs] [Bug 13420] sorting on volume number is not sorting right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #2 from Aleisha Amohia --- How do I reproduce this? Is it still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 00:51:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 23:51:07 +0000 Subject: [Koha-bugs] [Bug 12045] Transfer impossible if barcode includes spaces In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12045 Chloe Alabaster changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 00:51:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jan 2016 23:51:09 +0000 Subject: [Koha-bugs] [Bug 12045] Transfer impossible if barcode includes spaces In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12045 --- Comment #1 from Chloe Alabaster --- Created attachment 47149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47149&action=edit Bug 12045 - Transfer impossible if barcode includes spaces have changed the code which strips the white space to only remove the leading and trailing white space instead To Test- 1- go to circulation -> transfer 2- attempt to tranfer an item where the barcode has a space in the middle of it 3- it should fail 4- apply patch 5- try again 6- it should work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 01:05:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 00:05:34 +0000 Subject: [Koha-bugs] [Bug 15640] New: Accessibility - ensuring that the title of a link shows up on hover Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 Bug ID: 15640 Summary: Accessibility - ensuring that the title of a link shows up on hover Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 01:07:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 00:07:27 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 --- Comment #1 from Aleisha Amohia --- Created attachment 47150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47150&action=edit Bug 15640 - Title for links on circulation-home.tt To test: Go to Circulation and ensure that every link shows text on hover. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 01:07:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 00:07:24 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 01:40:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 00:40:18 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 --- Comment #2 from Aleisha Amohia --- Created attachment 47151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47151&action=edit Bug 15640: Title for links on main page of intranet To test: Go to main page and ensure that text shows on hover of links -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 01:46:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 00:46:50 +0000 Subject: [Koha-bugs] [Bug 15641] New: Typo in explanation for MembershipExpiryDaysNotice Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15641 Bug ID: 15641 Summary: Typo in explanation for MembershipExpiryDaysNotice Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There's an extra period after the word "in" in the MembershipExpiryDaysNotice sys pref explanation field: "Send an account expiration notice when a patron's card will expire in. [value box] days." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 02:37:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 01:37:38 +0000 Subject: [Koha-bugs] [Bug 15642] New: Batch patron deletion should not delete patrons with issues Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 Bug ID: 15642 Summary: Batch patron deletion should not delete patrons with issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Batch deletion of patrons should not include patron with checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 03:05:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 02:05:53 +0000 Subject: [Koha-bugs] [Bug 15642] Batch patron deletion should not delete patrons with issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 03:05:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 02:05:55 +0000 Subject: [Koha-bugs] [Bug 15642] Batch patron deletion should not delete patrons with issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 --- Comment #1 from Nick Clemens --- Created attachment 47152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47152&action=edit Bug 15642 - Batch patron deletion should not delete patrons with issues This patch changes _skip_borrowers_with_nonzero_balance to _skip_borrowers_with_nonzero_balance_or_issues and excludes borrowrs with issues from the batch deletion tool (this change brings tools/cleanborrowers.pl into line with misc/cronjobs/delete_patrons.pl with uses C4::Members GetBorrowersToExpunge which excludes patrons with current issues) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 03:11:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 02:11:10 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #52 from Nick Clemens --- Created attachment 47153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47153&action=edit Bug 10612 [QA Followup] 1 - Use Koha::List::Patron 2 - Return only non-empty lists for deletion selection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 03:11:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 02:11:52 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10612 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 [Bug 10612] Add ability to delete patrons with batch patron deletion tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 03:11:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 02:11:52 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10565 |15642 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 [Bug 15642] Batch patron deletion should not delete patrons with issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 03:11:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 02:11:52 +0000 Subject: [Koha-bugs] [Bug 15642] Batch patron deletion should not delete patrons with issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10612 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 [Bug 10612] Add ability to delete patrons with batch patron deletion tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 03:12:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 02:12:48 +0000 Subject: [Koha-bugs] [Bug 15642] Batch patron deletion should not delete patrons with issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47152|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 47154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47154&action=edit Bug 15642 - Batch patron deletion should not delete patrons with issues This patch changes _skip_borrowers_with_nonzero_balance to _skip_borrowers_with_nonzero_balance_or_issues and excludes borrowrs with issues from the batch deletion tool (this change brings tools/cleanborrowers.pl into line with misc/cronjobs/delete_patrons.pl with uses C4::Members GetBorrowersToExpunge which excludes patrons with current issues) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 03:13:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 02:13:41 +0000 Subject: [Koha-bugs] [Bug 15642] Batch patron deletion should not delete patrons with issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47154|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 47155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47155&action=edit Bug 15642 - Batch patron deletion should not delete patrons with issues This patch changes _skip_borrowers_with_nonzero_balance to _skip_borrowers_with_nonzero_balance_or_issues and excludes borrowrs with issues from the batch deletion tool (this change brings tools/cleanborrowers.pl into line with misc/cronjobs/delete_patrons.pl with uses C4::Members GetBorrowersToExpunge which excludes patrons with current issues) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 03:17:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 02:17:33 +0000 Subject: [Koha-bugs] [Bug 15642] Batch patron deletion should not delete patrons with issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47155|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 47156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47156&action=edit Bug 15642 - Batch patron deletion should not delete patrons with issues This patch changes _skip_borrowers_with_nonzero_balance to _skip_borrowers_with_nonzero_balance_or_issues and excludes borrowrs with issues from the batch deletion tool (this change brings tools/cleanborrowers.pl into line with misc/cronjobs/delete_patrons.pl with uses C4::Members GetBorrowersToExpunge which excludes patrons with current issues) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 08:36:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 07:36:38 +0000 Subject: [Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46759|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 47157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47157&action=edit Bug 14849: Add foreign key on uploaded_files.owner uploaded_files.owner refers to a borrowernumber, the DB structure should reflect this constraint. Test plan: 0/ Do not execute the update DB entry 1/ Add a new patron 2/ Use this patron to upload a new file 3/ In the uploaded_files you should see that the owner value is the borrowernumber of the newly created patron 4/ Execute the DB entry 5/ The uploaded_files.owner value should have been set to NULL 6/ Repeat 1, 2 and 3 7/ Delete the patron 5/ The uploaded_files.owner value should have been set to NULL Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy The test plan seems to miss one step: 3b Delete the patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 08:37:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 07:37:10 +0000 Subject: [Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 08:41:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 07:41:01 +0000 Subject: [Koha-bugs] [Bug 15623] Spelling mistake in boraccount.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15623 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 08:41:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 07:41:03 +0000 Subject: [Koha-bugs] [Bug 15623] Spelling mistake in boraccount.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15623 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47079|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 47158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47158&action=edit 15623 - Spelling mistake in boraccount.pl Test - Search for writen, if not found fix is correct Signed-off-by: Mirko Tietgen Signed-off-by: Marcel de Rooy Gus: You should try git grep writen one more time :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 08:41:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 07:41:15 +0000 Subject: [Koha-bugs] [Bug 15623] Spelling mistake in boraccount.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15623 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 09:28:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 08:28:06 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47090|0 |1 is obsolete| | --- Comment #240 from Jonathan Druart --- Comment on attachment 47090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47090 Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Record.pm Let's say we abandone this one... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 09:32:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 08:32:15 +0000 Subject: [Koha-bugs] [Bug 14489] Software error when trying to create new batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Needs Signoff |RESOLVED --- Comment #11 from Jonathan Druart --- If the error only occurs when you are logged in with the admin user, this bug is invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 09:43:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 08:43:32 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #15 from Jonathan Druart --- (In reply to Owen Leonard from comment #14) > Looking at an instance where "dialog error" is used, I see this in > itemtypes.tt: > > [% IF message.type == 'success' %] >
    > [% ELSIF message.type == 'warning' %] >
    > [% ELSIF message.type == 'error' %] >
    > [% END %] > > In the past we have not distinguished between warnings and errors. Both were > styled with the "dialog alert" style. But I'm not opposed to defining a new > style specifically for errors and setting up a guideline for its use. I can > imagine it being useful to say this, for instance: > > - "dialog alert" used in cases where there is a problem which requires the > user to respond to a question: Yes or no, proceed or cancel. > > - "dialog error" used in cases where the process is stopped, blocked by an > error and there is no path forward. > > I prefer simplicity if this distinction is not necessary. Actually the "dialog error" is used in a lot of places: admin/authorised_values.tt admin/authtypes.tt admin/biblio_framework.tt admin/branches.tt admin/categories.tt admin/cities.tt tools/batch_record_modification.tt at least. Almost all of them have been introduced by myself. Actually we have a definition for the div.error in staff-global.css: 931 div.error { 932 >---border : 2px dashed #990000; 933 >---background-color : #FFFF99; 934 >---padding : .5em; 935 >---margin : 1em; 936 } We could adapt it if the style is not the one we expect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 09:43:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 08:43:40 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 09:59:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 08:59:56 +0000 Subject: [Koha-bugs] [Bug 15579] records_batchmod permission doesn't allow access to batch modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 09:59:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 08:59:59 +0000 Subject: [Koha-bugs] [Bug 15579] records_batchmod permission doesn't allow access to batch modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47139|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 47159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47159&action=edit Bug 15579: Fix permission for batch record modification To test: - For a patron, permissions 'catalogue' and 'records_batchmod' only - Log in as this patron - Go to /cgi-bin/koha/tools/batch_record_modification.pl Without patch: You have no permisson to acces the page. With patch: Page 'Batch record modification' displays as expected. (Amended to fix wrong test plan) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:00:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:00:23 +0000 Subject: [Koha-bugs] [Bug 15579] records_batchmod permission doesn't allow access to batch modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11395 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 [Bug 11395] Batch modifications for records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:00:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:00:23 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15579 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 [Bug 15579] records_batchmod permission doesn't allow access to batch modification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:11:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:11:11 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:11:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:11:14 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47140|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 47160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47160&action=edit Bug 15602: Accessibility: Can't tab to add link in patron card creator add patrons popup To Test - 1. Go onto Tools and then click on Patron Card Creator. 2. Click on New and then Card Batch. 3. Add a borrowernumber then add patron. 4. Search for a patron. 5. Using the tab key try to navigate onto the Add link. 6. Notice it skips Add. 7. Apply the patch and then repeat steps 1-5, notice the add link can now be accessed through using the keyboard. Signed-off-by: Hector Castro Works as described. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:11:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:11:18 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 --- Comment #6 from Jonathan Druart --- Created attachment 47161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47161&action=edit Bug 15602: Remove cursor:pointer With the href attribute, the cusor will be displayed as a pointer. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:13:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:13:20 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl --- Comment #193 from Marcel de Rooy --- QA: Working on this one.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:17:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:17:44 +0000 Subject: [Koha-bugs] [Bug 15643] New: Every datepicker on serials expected date column updates top issue Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15643 Bug ID: 15643 Summary: Every datepicker on serials expected date column updates top issue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com In the serials edition page, on 'Expected on' column, whatever item date you try to change using its datepicker, it modify the top item date and only this one. Test plan : 1) Search a serial subscription from the Serials Home page 2)Go to serial collection page and make sure it has a mimimal bunch of already received or missing issues 3)Check some received issues to be sure to get extra issues (not only the extected one) in the serial edition page 4) Click on Edit serials button 5) Try to modify whatever date in 'Expected on' column (excepted first one) using datepicker : You can see that the top date of the column is updated instead of the choosen one. 6) Apply patch and redo 1 to 5 steps : now the right date is updated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:20:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:20:49 +0000 Subject: [Koha-bugs] [Bug 15643] Every datepicker on serials expected date column updates top issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15643 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 --- Created attachment 47162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47162&action=edit Bug 15643 - Every datepicker on serials expected date column updates top issue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:20:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:20:59 +0000 Subject: [Koha-bugs] [Bug 15643] Every datepicker on serials expected date column updates top issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15643 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:24:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:24:07 +0000 Subject: [Koha-bugs] [Bug 15583] List of lists in the staff client should have a default sort In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:24:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:24:10 +0000 Subject: [Koha-bugs] [Bug 15583] List of lists in the staff client should have a default sort In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47136|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 47163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47163&action=edit Bug 15583 - List of lists in the staff client should have a default sort To Test: 1- first make sure you have lists from different dates, -- if you dont you can go to databases and change the created_on date (by changing the date on the database you can also ensure that the shelfnumber doesn't align with the creation date, replicating the bug being fixed.) 2- after making lists apply patch and refresh page, the lists should be sorted by creation date by default instead of by the "shelfnumber" Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:45:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:45:20 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #38 from Jonathan Druart --- Comment on attachment 45982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45982 Bug 11371 - Add a new report : Orders by budget Review of attachment 45982: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11371&attachment=45982) ----------------------------------------------------------------- I am not convinced by the new subroutines you add with this patch. There are usually too specific and could be done with existing subroutines from C4::Acquisition or C4::Budgets The main problem is that there is not real test coverage for them. ::: C4/Budgets.pm @@ +473,5 @@ > + Description is fetched from aqbudgetperiods, id is compared aqbudgets. (INNER JOIN on budget_period_id) > + > +=cut > + > +sub GetBudgetPeriodDescription { This subroutine is too specific. It could be replaced with my $budget_period = GetBudgetPeriod( $budget->{budget_period_id} ) my $budget_period_description = $budget_period->{budget_period_description} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:45:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:45:28 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart at bugs.koha-c | |ommunity.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:47:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:47:31 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:47:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:47:38 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45223|0 |1 is obsolete| | Attachment #45224|0 |1 is obsolete| | Attachment #45225|0 |1 is obsolete| | Attachment #45226|0 |1 is obsolete| | Attachment #45227|0 |1 is obsolete| | Attachment #45228|0 |1 is obsolete| | Attachment #45229|0 |1 is obsolete| | Attachment #46379|0 |1 is obsolete| | --- Comment #194 from Marcel de Rooy --- Created attachment 47164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47164&action=edit Bug 8753 - Add forgot password link to OPAC I've addressed a lot of Liz Rea's points. 1. I have moved the code from updatedatabase.pl and kohastructure.sql to a file in the atomicupdates directory. 1a. The feature is now off by default when the atomicupdate is run. 2. The password reset link is now visible on the home page, in the modal box and on opac-user.pl . 3. The password recovery pages now use bootstrap markup. 4. I am unsure here. I see "New Password:" and "Confirm new password:". 5. This should still work :). 6. I could not reproduce. 7. I have added the userid field. You can now reset the password by submitting either your useid or email address. Both fields can be filled, but the email address must be one of the borrower's (email, emailpro or b_email). When entering only the email address and two borrowers use that same address, the system tells the user to try with another address or to specify his userid. 8. The text is in the atomicupdate file. Have at it, anyone. Concerning the email. It is inconvenient for the use to have to wait X minutes for the message queue the be processed. Maybe we could add a sub in Letters.pm that: Takes the same argments as EnqueueLetter Sends the letter. Saves the letter in the message queue with a 'sent' status. TEST PLAN: Setup) 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 2b) make sure that OpacPasswordChange is also ON. A) 1) refresh front page, click on 'Forgot your password' and enter a VALID address 1b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 2) An email should be received at that address with a link. 3) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 4) Go to main page try the new password. B) 1) Repeat the password reset, this time use the userid (username) field. 2) Try to reset the password using a userid and an email not linked to the account. An error appears. 3) Make sure the borrower has many available email addresses. 4) For each email, reset the password using both the userid and the email. The link should be sent to the specified address C) 1) Make sure two borrowers use the same email. 2) Repeat the reset procedure in test case A). An error message appears http://bugs.koha-community.org/show_bug.cgi?id=13068 Author: Maxime Beaulieu Followed test plan. Works as described. Signed-off-by: Marc Veron New sign-off after testing all patches together Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:47:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:47:47 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #195 from Marcel de Rooy --- Created attachment 47165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47165&action=edit Bug 8753 - Followup - change value text on syspref Followup changes text from "The user can reset | can not reset their password on OPAC" to "Library users are allowed | not allowed to recover their password via e-mail in the OPAC" This change more clearly differentiates the purpose of this new preference from OpacPasswordChange. Bug 8753 - followup - update text for link to match common UI paradigms, fixes OpacPublic disabled view Also corrects OpacNav being included on the reset page on private catalogues. Updated the link for forgotten passwords to more closely match common UI paradigms, i.e. Facebook and Twitter To test: apply all patches, link should now be the less verbose "Forgot your password?" disable OpacPublic, anything in opacnav should not appear (you may need to add something to opacnav to test properly) Bug 8753 - [followup] fix the title on opac-password-recovery.tt The title stanza was missing a around it, causing the extra text to appear. To test, apply all patches and make sure it looks ok and there is no extra text at the top or bottom of the page. Bug 8753 - [followup} Correcting spelling mistakes Make sure it all still works Bug 8753 - [followup] fix error when no information is provided To test: All normal checks plus make sure that a nice error is displayed when no data is provided. fixing the deprecated thing Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:47:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:47:56 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #196 from Marcel de Rooy --- Created attachment 47166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47166&action=edit Bug 8753 - Use Koha::Borrowers instead of C4::Members Use the new library to search for borrowers. Changed how the $borrower variable is used since it is now a Koha::Borrower object. Removed the $protocol parameter from the generated link. It should be included in the OPACBaseURL syspref. modified: C4/Passwordrecovery.pm modified: opac/opac-password-recovery.pl Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:48:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:48:03 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #197 from Marcel de Rooy --- Created attachment 47167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47167&action=edit Bug 8753 - [followup] POD cleanup Check to make sure the messages from the qa checker are gone. Note I'm not sure about this one because my test tools are apparently broken, and I can't get the error to manifest. Amended patch by Jonathan Druart: Add a blank line before =head2 It now passes. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:48:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:48:11 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #198 from Marcel de Rooy --- Created attachment 47168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47168&action=edit Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy, Passwordrecovery.t This is a collection of changes taken from different comments (but mostly comment 21 and comment 122). Passes qa and prove, on my machine at least. There's also a new test file, Passwordrecovery.t, which covers every method of C4::Passwordrecovery. To test: All normal checks plus : 1/ Receive the email 2/ Click on the link 3/ Change the pwd 4/ Click again on the link 5/ You should immediately get an error message Problems with Math/Random/Secure.pm, is solved in following patch, signing off Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:48:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:48:19 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #199 from Marcel de Rooy --- Created attachment 47169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47169&action=edit Bug 8753 - Various little things - removing new dependency, changes to errors, textual updates Koha already has a sub that creates salts, so lets use that instead of math::Random::secure, so as not to add a new dependency. Made the references to "Forgotten password" consistent, including adding it to the title of the page. Also removed the individual error for "this email doesn't belong to this account" as that could expose the existence of a login, which I think we'd rather not do. Made some of the text more grammatically correct, and more library specific. To test: Apply on top of all of the other patches. All the usual checks, plus make sure there are no typos in any text references. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:48:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:48:29 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #200 from Marcel de Rooy --- Created attachment 47170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47170&action=edit Bug 8753 - propagating the changes to kohastructure.sql and sysprefs.sql Signed-off-by: Liz Rea Looks good with a new install. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:48:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:48:38 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #201 from Marcel de Rooy --- Created attachment 47171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47171&action=edit Bug 8753: [QA Follow-up] Primary key and collation This patch includes: [1] Adds primary key borrowernumber to new table. [2] Fixes collation. [3] Removes manual PK in DBIx schema file. [4] Fixes typo CompletePasswordRevovery. [5] Removes use strict from opac-password-recovery; Modern::Perl is used. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 10:52:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 09:52:12 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #202 from Marcel de Rooy --- QA Comment: With reference to the discussion above (and time passed), I am moving the status to Passed QA. Looks good to me. Added a small follow-up. An important detail to fix before the new release is: New notice should be added in all language files! Please fix that asap in a follow-up report after this one has been pushed. This would normally be a reason to Fail QA on itself... Note to RM: Watch the conflict with bug 15548 (Borrower vs Patron); and the promised fix under 15585. Minor points: Spotted "FIXME: That ugly shift-grep contraption". The term "Forgotten password recovery" sounds funny to me (no native speaker :) Is Password recovery not sufficient? Are dots in the unique key (especially at the end) user friendly? Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 11:08:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 10:08:00 +0000 Subject: [Koha-bugs] [Bug 15579] records_batchmod permission doesn't allow access to batch modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47159|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 47172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47172&action=edit Bug 15579: Fix permission for batch record modification To test: - For a patron, permissions 'catalogue' and 'records_batchmod' only - Log in as this patron - Go to /cgi-bin/koha/tools/batch_record_modification.pl Without patch: You have no permisson to acces the page. With patch: Page 'Batch record modification' displays as expected. (Amended to fix wrong test plan) Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 11:07:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 10:07:58 +0000 Subject: [Koha-bugs] [Bug 15579] records_batchmod permission doesn't allow access to batch modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 11:08:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 10:08:11 +0000 Subject: [Koha-bugs] [Bug 15579] records_batchmod permission doesn't allow access to batch modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 11:16:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 10:16:22 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl --- Comment #20 from Marcel de Rooy --- QA: Looking at this one.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 11:58:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 10:58:54 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #21 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #20) > QA: Looking at this one.. Will continue later (if no one else does). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 12:21:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 11:21:38 +0000 Subject: [Koha-bugs] [Bug 14624] <> for advance_notices.pl wrongly documented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 12:22:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 11:22:01 +0000 Subject: [Koha-bugs] [Bug 14624] <> for advance_notices.pl wrongly documented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47068|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 47173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47173&action=edit Bug 14624 - <> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches. Ran: $ perldoc misc/cronjobs/advance_noitces.pl Saw expected changes. Koha QA test tools pass too. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Switched due date for the name of the database column date_due as the parameter expects a list of database column names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 12:24:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 11:24:43 +0000 Subject: [Koha-bugs] [Bug 14624] <> for advance_notices.pl wrongly documented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47173|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 47174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47174&action=edit Bug 14624 - <> for advance_notices.pl wrongly documented To Test Check perldoc for misc/cronjobs/advance_noitces.pl and see that the documentation matches. Ran: $ perldoc misc/cronjobs/advance_noitces.pl Saw expected changes. Koha QA test tools pass too. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Switched due date for the name of the database column date_due as the parameter expects a list of database column names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 12:33:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 11:33:22 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 --- Comment #8 from Katrin Fischer --- Created attachment 47175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47175&action=edit [PASSED QA] Bug 15603 - Accessibility: Can't tab to select link in budgets add user popup To Test - 1. If you don't have a budget and a fund, make at least one of each. 2. Go to funds from budgets. 3. Either make a new fund or edit an existing one and then click Edit owner, which will bring up a pop-up tab. 4. Search for a patron. 5. Using the tab key try to navigate onto the Select link. 6. Notice it skips select. 7. Apply the patch and then repeat steps 3-5, notice the select link can now be accessed through using the keyboard. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 12:34:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 11:34:42 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47084|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 12:35:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 11:35:50 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 13:20:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 12:20:12 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #4 from Colin Campbell --- Is this a bit cumbersome? what about starting by passing Log4perl to the Net::Server config it already supports it its the Koha calls to syslog that stop us enabling it. Coud we not then just call up logger rather than passing $self->server about all the time which looks a bit clumsy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 13:42:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 12:42:53 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 13:42:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 12:42:55 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47131|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 47176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47176&action=edit Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices This bug is the beginning of a conversion from our current bespoke syntax for slips and notices to Template Toolkit syntax. This patch is the initial seed which will evolve over time. With this addition, we can take advantage of our Koha Objects to greatly simplify the processing of Slips and Notices over time. Test Plan: 1) Apply this patch 2) Ensure you have the default CHECKOUT notice 3) Check out and return an item for a patron 4) Note the text of the CHECKOUT notice 5) Replace your CHECKOUT notice with the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 6) Repeat step 3 7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text Signed-off-by: Bernardo Gonzalez Kriegel New notice syntax works, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 13:43:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 12:43:02 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #8 from Kyle M Hall --- Created attachment 47177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47177&action=edit Bug 14757 [QA Followup] - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 14:01:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 13:01:40 +0000 Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 14:37:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 13:37:43 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #32 from Nick Clemens --- Still losing all holds when checking 1 item out Also got and odd mix of waiting/transfer once one hold is confirmed Staff side was able to place one item level hold and then 2 record level holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 14:41:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 13:41:59 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | Version|unspecified |master --- Comment #3 from Owen Leonard --- I'm sorry, but I disagree with these changes. I don't think they add any functionality or improve accessibility. https://www.paciellogroup.com/blog/2010/11/using-the-html-title-attribute/ ...which quotes the W3C: "Relying on the title attribute is currently discouraged as many user agents do not expose the attribute in an accessible manner as required by this specification (e.g. requiring a pointing device such as a mouse to cause a tooltip to appear, which excludes keyboard-only users and touch-only users, such as anyone with a modern phone or tablet)." https://www.w3.org/html/wg/drafts/html/master/dom.html#the-title-attribute -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 14:44:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 13:44:30 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #16 from Owen Leonard --- I think the essence of the issue is: Is it useful to the user to have a different style for 'alerts' and 'errors?' Would it convey information to them which helps them understand what's going on? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 14:56:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 13:56:34 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 14:59:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 13:59:02 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #241 from M. Tompsett --- Here is my testing output. It should be noted that patches 1 and 2 are not required for level 5 testing. However, they are necessary for higher levels. It should also be noted that I added: [InputOutput::RequireCheckedSyscalls] functions = :builtins exclude_functions = print to the perlcriticrc, so I wouldn't have to do stupidity like: my $ignore = print "Hello World!"; But that should be a patch to the qa test tools, not Koha itself. mtompset at debian:~/kohaclone$ git reset --hard origin/master HEAD is now at 2505a3d Bug 15607: batch patron mod - do not update dates if not given mtompset at debian:~/kohaclone$ perlcritic -5 C4/Installer/PerlModules.pm C4/Installer/PerlModules.pm source OK mtompset at debian:~/kohaclone$ perlcritic -5 C4/TmplToken.pm C4/TmplToken.pm source OK mtompset at debian:~/kohaclone$ perlcritic -5 C4/TmplTokenType.pm Subroutine prototypes used at line 86, column 1. See page 194 of PBP. (Severit y: 5) Subroutine prototypes used at line 87, column 1. See page 194 of PBP. (Severit y: 5) Subroutine prototypes used at line 88, column 1. See page 194 of PBP. (Severit y: 5) Subroutine prototypes used at line 89, column 1. See page 194 of PBP. (Severit y: 5) Subroutine prototypes used at line 90, column 1. See page 194 of PBP. (Severit y: 5) Subroutine prototypes used at line 91, column 1. See page 194 of PBP. (Severit y: 5) Subroutine prototypes used at line 92, column 1. See page 194 of PBP. (Severit y: 5) Subroutine prototypes used at line 93, column 1. See page 194 of PBP. (Severit y: 5) Subroutine prototypes used at line 94, column 1. See page 194 of PBP. (Severit y: 5) mtompset at debian:~/kohaclone$ perlcritic -5 opac/ilsdi.pl Stricture disabled at line 220, column 17. See page 429 of PBP. (Severity: 5) mtompset at debian:~/kohaclone$ git reset --hard origin/master HEAD is now at 2505a3d Bug 15607: batch patron mod - do not update dates if not given mtompset at debian:~/kohaclone$ perlcritic -5 C4/Installer/PerlModules.pm C4/Installer/PerlModules.pm source OK mtompset at debian:~/kohaclone$ perlcritic -5 C4/TmplToken.pm C4/TmplToken.pm source OK mtompset at debian:~/kohaclone$ perlcritic -5 C4/TmplTokenType.pm Subroutine prototypes used at line 86, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 87, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 88, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 89, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 90, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 91, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 92, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 93, column 1. See page 194 of PBP. (Severity: 5) Subroutine prototypes used at line 94, column 1. See page 194 of PBP. (Severity: 5) mtompset at debian:~/kohaclone$ perlcritic -5 opac/ilsdi.pl Stricture disabled at line 220, column 17. See page 429 of PBP. (Severity: 5) mtompset at debian:~/kohaclone$ git bz apply 6679 Bug 6679 - Fixing code so it passes basic Perl::Critic tests 47086 - Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm 47087 - Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm 47088 - Bug 6679 - Fixing code so it passes basic Perl:::Critic tests 47089 - Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm Applying: Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm Applying: Bug 6679 - Fixing code so it passes basic Perl:::Critic tests Applying: Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm mtompset at debian:~/kohaclone$ perlcritic -5 C4/Installer/PerlModules.pm C4/Installer/PerlModules.pm source OK mtompset at debian:~/kohaclone$ perlcritic -5 C4/TmplToken.pm C4/TmplToken.pm source OK mtompset at debian:~/kohaclone$ perlcritic -5 C4/TmplTokenType.pm C4/TmplTokenType.pm source OK mtompset at debian:~/kohaclone$ perlcritic -5 opac/ilsdi.pl opac/ilsdi.pl source OK mtompset at debian:~/kohaclone$ ls -la ~/.perlcriticrc lrwxrwxrwx 1 mtompset mtompset 26 Apr 27 2015 /home/mtompset/.perlcriticrc -> qa-test-tools/perlcriticrc mtompset at debian:~/kohaclone$ cat ~/qa-test-tools/perlcriticrc severity = 5 include = ProhibitUnusedVariables exclude = Miscellanea::RequireRcsKeywords [Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval] allow_includes =1 [TestingAndDebugging::RequireUseStrict] equivalent_modules = Modern::Perl [TestingAndDebugging::RequireUseWarnings] equivalent_modules = Modern::Perl [-Modules::RequireBarewordIncludes] [InputOutput::RequireCheckedSyscalls] functions = :builtins exclude_functions = print mtompset at debian:~/kohaclone$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 14:59:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 13:59:41 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47086|0 |1 is obsolete| | --- Comment #242 from M. Tompsett --- Created attachment 47178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47178&action=edit Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm - Subroutine prototypes used at line 86, column 1. See page 194 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 14:59:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 13:59:48 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47087|0 |1 is obsolete| | --- Comment #243 from M. Tompsett --- Created attachment 47179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47179&action=edit Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm Expression form of "eval" at line 71, column 9. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 85, column 13. See page 161 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 14:59:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 13:59:55 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47088|0 |1 is obsolete| | --- Comment #244 from M. Tompsett --- Created attachment 47180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47180&action=edit Bug 6679 - Fixing code so it passes basic Perl:::Critic tests opac/ilsdi.pl: Stricture disabled at line 217, column 17. See page 429 of PBP. (Severity: 5) Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 15:00:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 14:00:03 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47089|0 |1 is obsolete| | --- Comment #245 from M. Tompsett --- Created attachment 47181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47181&action=edit Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 15:01:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 14:01:38 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #246 from M. Tompsett --- I agreed with comment #240 regarding C4/Record.pm Looks good to me, setting to signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 15:17:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 14:17:39 +0000 Subject: [Koha-bugs] [Bug 12045] Transfer impossible if barcode includes spaces In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12045 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 15:17:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 14:17:41 +0000 Subject: [Koha-bugs] [Bug 12045] Transfer impossible if barcode includes spaces In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12045 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47149|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 47182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47182&action=edit Bug 12045 - Transfer impossible if barcode includes spaces have changed the code which strips the white space to only remove the leading and trailing white space instead To Test- 1- go to circulation -> transfer 2- attempt to tranfer an item where the barcode has a space in the middle of it 3- it should fail 4- apply patch 5- try again 6- it should work NOTE: I purposefully added: die "($barcode)"; Before, all spaces were removed. ' white space ' became '(whitespace)' After, only external spaces were remove ' white space ' became '(white space)' Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 15:22:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 14:22:48 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #23 from M. Tompsett --- (In reply to Katrin Fischer from comment #22) > > - overdue_notices - will generate a new notice if repeated. So you'd have to > > pass a positive list to avoid sending double notices. > > Actually... I don't think that would work. > > Why is it so bad if they all don't run, if there is really a bigger problem > with one of them? That's how it is now and it doesn't seem to be a problem > that occurs frequently. We have been running our installations with a > changed cronjob sequence since the very beginning (fines before overdues). If overdues don't run, then people don't get emailed reminders, and then they get angry when they have a larger fine to pay. I would rather be reminded with a footnote stating that the amounts may be incorrect if an automatic renewals failed to run, than get hit with a whack load of fines. Tweak the notice and use semi-colons. That's my suggestion, because the current koha-foreach logic is effectively that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 15:31:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 14:31:41 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46914|0 |1 is obsolete| | Attachment #46915|0 |1 is obsolete| | Attachment #46916|0 |1 is obsolete| | Attachment #46917|0 |1 is obsolete| | Attachment #46918|0 |1 is obsolete| | Attachment #46919|0 |1 is obsolete| | Attachment #46920|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall --- Created attachment 47183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47183&action=edit Bug 14695 - Update database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 15:31:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 14:31:48 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #34 from Kyle M Hall --- Created attachment 47184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47184&action=edit Bug 14695 - Update DB Schema file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 15:31:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 14:31:51 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #35 from Kyle M Hall --- Created attachment 47185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47185&action=edit Bug 14695 - Add new circulation rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 15:31:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 14:31:54 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #36 from Kyle M Hall --- Created attachment 47186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47186&action=edit Bug 14695 - Tidy C4::Reserves::CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 15:31:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 14:31:58 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #37 from Kyle M Hall --- Created attachment 47187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47187&action=edit Bug 14695 - Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 15:32:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 14:32:04 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #39 from Kyle M Hall --- Created attachment 47189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47189&action=edit Bug 14695 [QA Followup] - Make existing unit tests pass * Removes tests no longer needed * Updates rules to work with existing tests * Fixes code issues revealed by unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 15:32:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 14:32:01 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #38 from Kyle M Hall --- Created attachment 47188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47188&action=edit Bug 14695 [QA Followup] - Filling one hold fills all of them -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 16:05:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 15:05:37 +0000 Subject: [Koha-bugs] [Bug 15644] New: City dropdown default selection when modifying a patron matches only on city Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15644 Bug ID: 15644 Summary: City dropdown default selection when modifying a patron matches only on city Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When modifying a patron the dropdown for cities selection tries to select the existing patron's info in the city dropdown menu but matches only on city For cities with multiple zipcodes, or states with matching city names it can select the wrong info. This does not affect data entry, but can be confusing to staff. To recreate: 1 - Enter two cities via Administration->Patrons and circulation->Cities and towns: Springfield, MA 01101 Springfield, VT 05156 2 - Edit a patron chossing Springfield VT 3 - Load thei record in the editor and note that Springfield MA is the selected value in the dropdown Either we should match on zipcode (unique id?) or default to blank -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 16:53:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 15:53:37 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 16:53:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 15:53:41 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #40 from Kyle M Hall --- Created attachment 47190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47190&action=edit Bug 14695 [QA Followup] - Fix clearing of all holds by patron at checkout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 16:53:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 15:53:49 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #41 from Kyle M Hall --- Created attachment 47191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47191&action=edit Bug 14695 [QA Followup] - Fix display issue for in transit holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 16:59:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 15:59:23 +0000 Subject: [Koha-bugs] [Bug 15639] Spelling mistake in request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15639 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE CC| |hector.hecaxmmx at gmail.com --- Comment #2 from H?ctor Eduardo Castro Avalos --- Hi Gus and Chloe. It's much better if you correct a lot of this "writen" typos and attach them to one bug only, like Jonathan ask you in bug 15622. I think IMHO you must reopen that bug and commit all this changes there. *** This bug has been marked as a duplicate of bug 15638 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 16:59:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 15:59:23 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 --- Comment #5 from H?ctor Eduardo Castro Avalos --- *** Bug 15639 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:04:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:04:57 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47143|0 |1 is obsolete| | --- Comment #6 from H?ctor Eduardo Castro Avalos --- Created attachment 47192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47192&action=edit [SIGNED-OFF]Bug 15638: spelling mistake in ~/Koha/reserve/placerequest.pl:4 writen ==> written To Test- check that in line 4 of this file "writin" has been corrected to "written" Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:04:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:04:54 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:05:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:05:08 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47144|0 |1 is obsolete| | --- Comment #7 from H?ctor Eduardo Castro Avalos --- Created attachment 47193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47193&action=edit [SIGNED-OFF]Bug 15638: Spelling mistake in request.pl To Test- chek that in line 4 "writen" has been changed to "written" Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:06:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:06:37 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|koha-bugs at lists.koha-commun |chloealabaster at gmail.com |ity.org | CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:07:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:07:08 +0000 Subject: [Koha-bugs] [Bug 15626] koha-remove does not remove log4perl.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15626 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:07:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:07:10 +0000 Subject: [Koha-bugs] [Bug 15626] koha-remove does not remove log4perl.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15626 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47045|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 47194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47194&action=edit Bug 15626: Remove log4perl.conf when using koha-remove if you create a koha install using koha-create, and remove it with koha-remove, the /etc/koha/sites/$SITE/ directory won't be removed, because the /etc/koha/sites/$SITE/log4perl.conf has not been removed by this script. Test plan: Use this koha-remove script to remove a koha install Without this patch, the /etc/koha/sites/$SITE directory won't be removed. With this patch applied, the directory will be correctly removed. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:12:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:12:07 +0000 Subject: [Koha-bugs] [Bug 12045] Transfer impossible if barcode includes spaces In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12045 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:12:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:12:09 +0000 Subject: [Koha-bugs] [Bug 12045] Transfer impossible if barcode includes spaces In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12045 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47182|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 47195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47195&action=edit Bug 12045 - Transfer impossible if barcode includes spaces have changed the code which strips the white space to only remove the leading and trailing white space instead To Test- 1- go to circulation -> transfer 2- attempt to tranfer an item where the barcode has a space in the middle of it 3- it should fail 4- apply patch 5- try again 6- it should work NOTE: I purposefully added: die "($barcode)"; Before, all spaces were removed. ' white space ' became '(whitespace)' After, only external spaces were remove ' white space ' became '(white space)' Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:15:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:15:17 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |In Discussion --- Comment #4 from H?ctor Eduardo Castro Avalos --- (In reply to Owen Leonard from comment #3) > I'm sorry, but I disagree with these changes. I don't think they add any > functionality or improve accessibility. > > https://www.paciellogroup.com/blog/2010/11/using-the-html-title-attribute/ > > ...which quotes the W3C: > > "Relying on the title attribute is currently discouraged as many user agents > do not expose the attribute in an accessible manner as required by this > specification (e.g. requiring a pointing device such as a mouse to cause a > tooltip to appear, which excludes keyboard-only users and touch-only users, > such as anyone with a modern phone or tablet)." > > https://www.w3.org/html/wg/drafts/html/master/dom.html#the-title-attribute Hi Owen What do you suggest to use instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:17:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:17:16 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47191|0 |1 is obsolete| | --- Comment #42 from Kyle M Hall --- Created attachment 47196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47196&action=edit Bug 14695 [QA Followup] - Fix display issue for in transit holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:24:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:24:59 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver at bywatersolutions.co |nick at bywatersolutions.com |m | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:33:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:33:25 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47196|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:33:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:33:44 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 --- Comment #5 from Owen Leonard --- (In reply to H?ctor Eduardo Castro Avalos from comment #4) > What do you suggest to use instead? What problem are we trying to solve? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:35:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:35:23 +0000 Subject: [Koha-bugs] [Bug 15645] New: In transit holds do not show as in transit on request.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 Bug ID: 15645 Summary: In transit holds do not show as in transit on request.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com A hold in transit will simply appear as an unfilled hold! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:37:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:37:45 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 --- Comment #1 from Kyle M Hall --- Created attachment 47197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47197&action=edit Bug 15645 - In transit holds do not show as in transit on request.pl A hold in transit will simply appear as an unfilled hold! Test Plan: 1) Place a hold for pickup at a different location 2) Capture that hold for a patron 3) Note you do not see the in transit status on request.pl 4) Apply this patch 5) Refresh the page 6) The hold should now show as in transit! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:37:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:37:42 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:37:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:37:52 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:38:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:38:06 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |koha-bugs at lists.koha-commun | |ity.org Severity|critical |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:38:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:38:11 +0000 Subject: [Koha-bugs] [Bug 15645] In transit holds do not show as in transit on request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15645 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:42:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:42:45 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:42:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:42:47 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46826|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 47198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47198&action=edit [PASSED QA] Bug 14893: Separate temporary storage per instance in Upload.pm To make life easier when multiple instances are uploading temporary files to Koha, this patch adds the database name to the upload subfolder in your /tmp folder. Note: Although multiple instances could share the same subfolder for temporary storage (hashvalue is based on a timestamp too), it will be better to separate them for efficient housekeeping (removing older or partial files with a cronjob etc.) Since multiple instances come with separate permissions, keeping them in separate folders will be much simpler. Permanent storage is not affected by this patch. The location of permanent storage is ruled by the upload_path in each config file. Sharing that space is not recommended too. Although it may not be strictly necessary yet to remove files from the old temp storage folder (before the 3.22 release), the accompanying db rev performs that housekeeping task. Test plan: [1] Do not yet apply this patch. Upload a temporary file (use the tools/upload.pl script without selecting a category). [2] Check /tmp/koha_upload. [3] Apply this patch. Run the db rev with web installer. [4] Upload another temporary file. [5] Check /tmp for folder [your_database]_upload. [6] Check that /tmp/koha_upload is gone and the associated records too. [7] Run the adjusted t/db../Upload.t Followed test plan. Could not do steps before applying patch [1]-[2] (I suppose a local permission problem). After applying patch and updating db file appears in /tmp/[database] as expected. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:44:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:44:02 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Note: All temporary release notes| |uploaded files will be | |deleted during upgrade. CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:45:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:45:57 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 --- Comment #6 from H?ctor Eduardo Castro Avalos --- (In reply to Owen Leonard from comment #5) > (In reply to H?ctor Eduardo Castro Avalos from comment #4) > > > What do you suggest to use instead? > > What problem are we trying to solve? The accessibility, for example an image need "alt" attibute or we don't need nothing here because this is redundant like Isofarro explain in this post Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:54:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:54:07 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The singleBranchMode system release notes| |preference has been | |removed. Koha instance with | |multiple libraries will not | |longer be able to use | |single branch mode. Single | |branch mode will be | |automatically enabled for | |Koha instances with only | |one library configured. CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:54:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:54:28 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:54:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:54:31 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46755|0 |1 is obsolete| | Attachment #46756|0 |1 is obsolete| | Attachment #46757|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 47199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47199&action=edit Bug 4941: Make tests non DB dependent Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:54:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:54:53 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47199|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 47200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47200&action=edit Bug 4941: Make tests non DB dependent Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Current status: Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:56:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:56:30 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #22 from Kyle M Hall --- Created attachment 47201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47201&action=edit Bug 4940: DB Changes Signed-off-by: Chris Cormack http://bugs.koha-community.org/show_bug.cgi?id=4941 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 17:56:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 16:56:37 +0000 Subject: [Koha-bugs] [Bug 4941] Can't set branch in staff client when singleBranchMode is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4941 --- Comment #23 from Kyle M Hall --- Created attachment 47202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47202&action=edit Bug 4941: Remove the singleBranchMode system preference The singleBranchMode system preference does not make sense. Either the install has only 1 library defined or several. In both case, we can easily guess the behavior to follow. So the idea of this patch is to replace the fetch of this syspref with a call to count the number of libraries defined in DB. Test plan: 1/ From a fresh Koha install, execute the DB entry to remove the pref. 2/ Define only 1 library 3/ Confirm that Koha behaves the same as before (try to change your library, look at the facets) 4/ Create another library (or more) and reinsert the pref and set it: insert into systempreferences (variable, value) values('singleBranchMode', 1); 5/ Execute the DB entry You should get a warning message. 6/ Repeat 3. Signed-off-by: Chris Cormack Does what it says, but will change behaviour for any Koha install that has 2 branches defined, One circulation, and this preference set. If that is an acceptable change, we might need to make sure this is noted well in the release notes. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 18:02:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 17:02:47 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 --- Comment #7 from Owen Leonard --- (In reply to H?ctor Eduardo Castro Avalos from comment #6) > The accessibility, for example an image need "alt" attibute or we don't need > nothing here because this is redundant like Isofarro explain in this post I don't think that post makes a good case for use of the title attribute. I'm not sure why you mention the "alt" attribute, since that's a completely different issue. The text of a link should express what its purpose is. In cases where the text of the link is not clear, adding a title attribute isn't going to do much, if anything, to help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 18:25:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 17:25:05 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 18:25:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 17:25:08 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47192|0 |1 is obsolete| | Attachment #47193|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 47203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47203&action=edit Bug 15638: spelling mistake in ~/Koha/reserve/placerequest.pl:4 writen ==> written To Test- check that in line 4 of this file "writin" has been corrected to "written" Signed-off-by: Hector Castro Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 18:25:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 17:25:15 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 --- Comment #9 from Kyle M Hall --- Created attachment 47204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47204&action=edit Bug 15638: Spelling mistake in request.pl To Test- chek that in line 4 "writen" has been changed to "written" Signed-off-by: Hector Castro Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 18:27:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 17:27:04 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 --- Comment #8 from H?ctor Eduardo Castro Avalos --- (In reply to Owen Leonard from comment #7) > I don't think that post makes a good case for use of the title attribute. > I'm not sure why you mention the "alt" attribute, since that's a completely > different issue. I didn't express my ideas properly. > The text of a link should express what its purpose is. In cases where the > text of the link is not clear, adding a title attribute isn't going to do > much, if anything, to help. Amen to that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 18:33:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 17:33:57 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 18:34:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 17:34:01 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47178|0 |1 is obsolete| | Attachment #47179|0 |1 is obsolete| | Attachment #47180|0 |1 is obsolete| | Attachment #47181|0 |1 is obsolete| | --- Comment #247 from Kyle M Hall --- Created attachment 47205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47205&action=edit [PASSED QA] Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm - Subroutine prototypes used at line 86, column 1. See page 194 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 18:34:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 17:34:12 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #248 from Kyle M Hall --- Created attachment 47206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47206&action=edit [PASSED QA] Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm Expression form of "eval" at line 71, column 9. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 85, column 13. See page 161 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 18:34:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 17:34:16 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #249 from Kyle M Hall --- Created attachment 47207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47207&action=edit [PASSED QA] Bug 6679 - Fixing code so it passes basic Perl:::Critic tests opac/ilsdi.pl: Stricture disabled at line 217, column 17. See page 429 of PBP. (Severity: 5) Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 18:34:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 17:34:20 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #250 from Kyle M Hall --- Created attachment 47208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47208&action=edit [PASSED QA] Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 18:36:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 17:36:55 +0000 Subject: [Koha-bugs] [Bug 15628] Remove get_branchinfos_of vestiges In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15628 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 18:36:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 17:36:57 +0000 Subject: [Koha-bugs] [Bug 15628] Remove get_branchinfos_of vestiges In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15628 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47023|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 47209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47209&action=edit Bug 15628: Remove get_branchinfos_of vestiges The C4::Branch::get_branchinfos_of subroutine has been removed by bug 7034, but 2 occurrences have been left git grep get_branchinfos_of C4/Branch.pm: &get_branchinfos_of t/db_dependent/Branch.t: get_branchinfos_of Test plan: git grep get_branchinfos_of should not return any occurrences. Signed-off-by: Hector Castro Vestiges removed Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 18:41:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 17:41:19 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 18:41:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 17:41:22 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47054|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 47210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47210&action=edit Bug 15571 reserveforothers permission does not remove Search to hold button from patron account To Test: 1. Create a user without 'reserveforothers' permission 2. Go onto user details 3. 'Search to hold' button should not be there 4. Create a user with 'reserveforothers' permission 5. Repeat steps 6. 'Search to Hold' button should be there Signed-off-by: Owen Leonard Signed-off-by: Briana Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 18:41:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 17:41:30 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 --- Comment #8 from Kyle M Hall --- Created attachment 47211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47211&action=edit Bug 15571 [QA Followup] - Remove tabs Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 19:03:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 18:03:46 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46628|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 47212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47212&action=edit Bug 15096: Export today's checked in barcodes: Display warning if reading history is set to "never" If a patron's privacy settings are set to "Never" for keeping a reading history, "Export today's checked in barcodes" returns an empty file. This patch does not allow to export in such case. To test: - Apply patch - Check out / check in in some items -Test toolbar: - On user's detail page, go to More->Export today's checked in barcodes - Verify that the menu item does not appear if syspref 'intranetreadinghistory' is set to 'Don't allow' - Verify that the menu item appears if syspref 'intranetreadinghistory' is set to allow and - that the menu item is grayed out with a tooltip if the user has set privacy settings to never keep a reading history - that the menu item works as before if user's privacy settings allow reading history. - Test left tab "Circulation history": - Verify that the left tab "Circulation history" does not appear if syspref 'intranetreadinghistory' is set to 'Don't allow' - Verify that the tab appars if syspref 'intranetreadinghistory' is set to 'Allow' and - that a message appears if user's privacy settings do not allow to keep the reading history - that the export works as before if user's privacy settings allow to keep the reading history (Amended and changed test plan for comment #9) Signed-off-by: Aleisha Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 19:03:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 18:03:44 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 19:35:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 18:35:58 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 19:38:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 18:38:20 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 19:38:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 18:38:26 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45807|0 |1 is obsolete| | Attachment #45808|0 |1 is obsolete| | Attachment #45809|0 |1 is obsolete| | Attachment #45810|0 |1 is obsolete| | Attachment #45811|0 |1 is obsolete| | Attachment #45812|0 |1 is obsolete| | Attachment #45813|0 |1 is obsolete| | Attachment #45814|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall --- Created attachment 47213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47213&action=edit Bug 15084: Add Koha::Acquisition::Currenc[y|ies] classes The first step of this patch set is to move the business logic code from admin/currencies.pl to Koha::Acquisition::Currenc[y|ies]. Then a foreign key will be created on aqorders.currency as we want to assure data integrity. Note that a aqbooksellers.currency also exists but is never used. It could be removed in another bug report. This update has to care about possible breaking relation. For instance an old order has been made using a currency which is now deleted. To be sure the update process won't break a new column currency.archived is created and leave open the door for a further improvement (marked a currency as archived from the interface: this won't be provided by this enhancement). These archived currencies won't appear on the interface for newly created items (order/suggestion). Once this is done it becomes easy to remove the subroutine from C4::Budgets: GetCurrencies and GetCurrency. ConvertCurrency will also be removed but is not used anymore. Note that none of these subroutines were covered by tests. Now they are. Test plan: 0/ Don't apply this patch 1/ Create a temporary currency and an order using it 2/ Remove the currency from your CLI 3/ Apply the patch and execute the DB entry 4/ Note that the currency is inserted and marked as archived. 5/ Edit the previous order and confirm that the correct currency is still selected. It won't never be displayed anywhere else. 6/ Test the admin script: on admin/currency.pl add/remove/edit currencies. You could not have 2 active currencies at the same time. 7/ Then on the different scripts of the acquisition module, focus on the currencies values and create a new order, receive it. Create/edit a suggestion Other changes must be checked by the QAer. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 19:38:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 18:38:43 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #29 from Kyle M Hall --- Created attachment 47214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47214&action=edit Bug 15084: Make sure the previous active currency is marked as inactive On inserting an active currency, others should be marked as inactive. We can only have 1 active currency at the same time. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 19:38:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 18:38:51 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #30 from Kyle M Hall --- Created attachment 47215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47215&action=edit Bug 15084: use Koha::Acquisition::Currenc[y|ies] in admin/currency Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 19:38:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 18:38:57 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #31 from Kyle M Hall --- Created attachment 47216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47216&action=edit Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search Most part of the code here is unnecessary complex. We should selected the currency if it is selected, that's all :) Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 19:39:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 18:39:03 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #32 from Kyle M Hall --- Created attachment 47217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47217&action=edit Bug 15084: Remove C4::Budgets::ConvertCurrency This subroutine is unused and can be removed. There is no trace left of currency in C4::Budgets. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 19:39:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 18:39:10 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #33 from Kyle M Hall --- Created attachment 47218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47218&action=edit Bug 15084: Add tests for Koha::Acquisition::Currenc[y|ies] Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 19:39:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 18:39:15 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #34 from Kyle M Hall --- Created attachment 47219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47219&action=edit Bug 15084: DB Changes - add currency.archived and FK on aqorders.currency See the comment for details. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 19:39:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 18:39:21 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #35 from Kyle M Hall --- Created attachment 47220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47220&action=edit Bug 15084: DBIx::Class - Shema changes Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 19:39:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 18:39:27 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #36 from Kyle M Hall --- Created attachment 47221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47221&action=edit Bug 15084 [QA Followup] - Clean up test currencies after unit tests Test currency left behind will cuase next run of the unit test to fail as well as leaving db cruft. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 21:41:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 20:41:29 +0000 Subject: [Koha-bugs] [Bug 15646] New: koha qa test tools Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15646 Bug ID: 15646 Summary: koha qa test tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz It would be nice to append to the end of the perlcriticrc file for the koha qa test tools: [InputOutput::RequireCheckedSyscalls] functions = :builtins exclude_functions = print -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 21:52:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 20:52:27 +0000 Subject: [Koha-bugs] [Bug 15646] koha qa test tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15646 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- Created attachment 47222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47222&action=edit Allow print function return value to be ignored. TEST PLAN --------- 1) link ~/.perlcriticrc to ~/qa-test-tools/perlcriticrc 2) save simple script --- BEGIN example.pl --- #!/usr/bin/perl use Modern::Perl; our $VERSION = q{1.0}; print "Hello World!\n"; --- END example.pl --- 3) perlcritic -1 example.pl Return value of flagged function ignored - print at line 5, column 1. See pages 208,278 of PBP. (Severity: 1) 4) Apply this patch to the qa test tools 5) redo step 3 example.pl source OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 22:35:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 21:35:10 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #7 from Nick Clemens --- Created attachment 47223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47223&action=edit Bug 14752 [QA followup] Remove reference to document.f Remove backup hardcoded string for update item button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 22:44:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 21:44:07 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #8 from Nick Clemens --- (In reply to Jonathan Druart from comment #6) > QA comments: > 1/ (window.MSG_ADDITEM_JS_UPDATEITEM || "Update item ") > If the string is not defined, there is something wrong in the code, we > should not provide a hardcoded string Fixed! I copied that from existing code and fixed there too > 2/ When I click on the "add multiple" button, I get a JS error "TypeError: > document.f is undefined" > And the behavior if weird: I get the "Invalid number of copies" even if I > enter "2", it may come from the JS error. This was a copy paste error, removed the code. I can't replicate the 'Invalid number' though, hoping fixing the error clears that for you. I checked firefox and chromium on Ubuntu > 3/ If I am not wrong, the barcode could be sent, the next one will be > generated. I am not sure what you mean. If barcode is listed in the UniqueItemFields (default) I don't pass barcode into generated records but I do leave it in the form. If it isn't in UniqueItemFields it is passed as is (copied multiple times) and left in the form. It seems tricky because the items are not created until you hit save at the bottom, so incrementing could cause conflicts with autoincrement if others are cataloging at the same time. Thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 22:57:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 21:57:55 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46279|0 |1 is obsolete| | --- Comment #53 from Nick Clemens --- Created attachment 47224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47224&action=edit Bug 10612 - Add ability to delete patrons with batch patron deletion tool This patch adds the ability to select a patron list for deletetion when using the Batch patron deletion/anonymization tool. It also adds buttons to the the patron lists table to access both the batch deletion and batch modification directly from the lists view. This is a squash of previous patches with a check added for issues before deleting borrowers. Test Plan: 1) Apply this patch 2) Create a list of patrons with the new Patron Lists feature 3) Try using the batch edit link form the lists table 4) Try using the batch delete link from the lists table Signed-off-by: Jesse Weaver ByWater internal signoff, still needs signoff from community. Patch seems kosher, passes QA tools. Needs followup to fix one small issue: squished patch undoes switch to FontAwesome icons in lists.tt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 22:58:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 21:58:01 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46834|0 |1 is obsolete| | --- Comment #54 from Nick Clemens --- Created attachment 47225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47225&action=edit Bug 10612 - [QA followup] Use font awesome icons in patron lists lists.tt Signed-off-by: Natasha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 22:59:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 21:59:00 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 22:59:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 21:59:03 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47153|0 |1 is obsolete| | --- Comment #55 from Nick Clemens --- Created attachment 47226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47226&action=edit Bug 10612 [QA Followup] 1 - Use Koha::List::Patron 2 - Return only non-empty lists for deletion selection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 23:05:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 22:05:09 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #56 from Nick Clemens --- (In reply to Jonathan Druart from comment #51) > It would be better to use Koha::List::Patron instead. Done > I'd make more sense to pass the non empty patron lists only. Done > You are modifying the behavior of the tool. > This change should be moved to another bug report > (misc/cronjobs/delete_patrons.pl will need the change too). Done, moved to bug 15642 as a dependency. However, looking over the code again I noted that while the tool did use this subroutine initially, it used it in conjunction with C4::Members GetBorrowersToExpunge which checks for borrowers w/issues in the SQl query it builds and eliminates those borrowers from consideration. The new deletion by list feature doesn't use GetBorrowersToExpunge (since it is basing from a list) so needs to make a check for issues. It seems logical enough to add the check in this sub since we are already calling GetMemberIssuesAndFines and really I just pickup the return value instead of ignoring it. So, I can either leave dependent and wait on 15642, close the other bug and replace the code here, or create a new separate sub to check for issues. Thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 23:21:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 22:21:33 +0000 Subject: [Koha-bugs] [Bug 15647] New: Allow selection of destination email address for print overdue notices Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15647 Bug ID: 15647 Summary: Allow selection of destination email address for print overdue notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Notices Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: larry at bywatersolutions.com Currently, only the branchemail/KohaAdminEmailAddress is used. It would be nice to be able to choose the reply-to or return-path address also. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 23:29:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 22:29:36 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47183|0 |1 is obsolete| | --- Comment #43 from Nick Clemens --- Created attachment 47227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47227&action=edit Bug 14695 - Update database Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 23:29:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 22:29:40 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47184|0 |1 is obsolete| | --- Comment #44 from Nick Clemens --- Created attachment 47228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47228&action=edit Bug 14695 - Update DB Schema file Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 23:29:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 22:29:43 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47185|0 |1 is obsolete| | --- Comment #45 from Nick Clemens --- Created attachment 47229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47229&action=edit Bug 14695 - Add new circulation rule Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 23:29:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 22:29:46 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47186|0 |1 is obsolete| | --- Comment #46 from Nick Clemens --- Created attachment 47230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47230&action=edit Bug 14695 - Tidy C4::Reserves::CanItemBeReserved Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 23:29:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 22:29:50 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47187|0 |1 is obsolete| | --- Comment #47 from Nick Clemens --- Created attachment 47231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47231&action=edit Bug 14695 - Add ability to place multiple item holds on a given record per patron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 23:29:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 22:29:53 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47188|0 |1 is obsolete| | --- Comment #48 from Nick Clemens --- Created attachment 47232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47232&action=edit Bug 14695 [QA Followup] - Filling one hold fills all of them Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 23:29:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 22:29:56 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47189|0 |1 is obsolete| | --- Comment #49 from Nick Clemens --- Created attachment 47233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47233&action=edit Bug 14695 [QA Followup] - Make existing unit tests pass * Removes tests no longer needed * Updates rules to work with existing tests * Fixes code issues revealed by unit tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 23:30:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 22:30:00 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47190|0 |1 is obsolete| | --- Comment #50 from Nick Clemens --- Created attachment 47234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47234&action=edit Bug 14695 [QA Followup] - Fix clearing of all holds by patron at checkout Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 22 23:30:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 22:30:55 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #51 from Nick Clemens --- Internal sign off only, needs community sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 00:27:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 23:27:25 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 00:42:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jan 2016 23:42:43 +0000 Subject: [Koha-bugs] [Bug 15648] New: creator_batches table uses item_number instead of itemnumber Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15648 Bug ID: 15648 Summary: creator_batches table uses item_number instead of itemnumber Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org The creator_batches database table uses the field name of item_number instead of itemnumber like all the other tables in Koha. Could this be fixed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 01:00:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 00:00:53 +0000 Subject: [Koha-bugs] [Bug 15647] Allow selection of destination email address for print overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15647 --- Comment #1 from Larry Baerveldt --- I can provide some background on this. The Reply-to and Return-Path addresses were added to combat a problem with emails being rejected or flagged as spam if the library used an email address with a different domain than that of the Koha server. (The KohaAdminEmailAddress, or library Email address if set, is what shows up in the 'From' header, and is what is checked by many spam filters, and for checking SPF records.) This is especially important for sites like ours, where the library wants to use one of their own addresses for email, and be able to get replies and bouncebacks, but their Koha installation is hosted on a server in the vendor's domain. So we might use something like 'no_reply at site.servername.com' in the KohaAdminEmailAddress or the branchemail, so the messages will get delivered, and not rejected as spam. However, print notices are hard coded to be sent to either the branchemail or the KohaAdminEmailAddress. So the 'gotcha' is you need to use an address in the same domain as the server to avoid rejects, but if you do, then the library may not be able to get their print notices email. This bug requests the option to choose one of the other addresses (Reply-to or Return-path) as the place to send the print notices emails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 01:04:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 00:04:54 +0000 Subject: [Koha-bugs] [Bug 15647] Allow selection of destination email address for print overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15647 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 01:04:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 00:04:56 +0000 Subject: [Koha-bugs] [Bug 15647] Allow selection of destination email address for print overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15647 --- Comment #2 from Jesse Weaver --- Created attachment 47235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47235&action=edit Bug 15647: Allow selection of destination email address for print overdue notices Test plan: * Verify that, after patch, print overdue notices are still sent to branchemail/KohaAdminEmailAddress as appropriate. * Change PrintNoticesEmailField to reply-to/return-path, and check that branchreplyto/ReplytoDefault or branchreturnpath/ReturnpathDefault (respectively) are used instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 01:15:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 00:15:29 +0000 Subject: [Koha-bugs] [Bug 15647] Allow selection of destination email address for print overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15647 --- Comment #3 from Jesse Weaver --- Additional setup hint for test plan: Set different email addresses for ReplytoDefault and ReturnpathDefault, and for branchreplyto and branchreturnpath for one branch, so that it can be verified that the correct email addresses are being selected and the fallback-to-syspref mechanism is working correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 01:44:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 00:44:15 +0000 Subject: [Koha-bugs] [Bug 13551] Add the ability to sort results on cataloguing (addbooks.pl) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13551 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 01:52:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 00:52:04 +0000 Subject: [Koha-bugs] [Bug 15649] New: Addbooks.pl search results, fix 490 data display issues Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15649 Bug ID: 15649 Summary: Addbooks.pl search results, fix 490 data display issues Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When a record has data in the 490 field, the addbooks.pl (cataloging search) search results display is missing spaces before the 490a and 490v field displays. Also, the 490a and 490v order should also be reversed. It's currently displaying 490v, then 490a. It should be 490a, then 490v. Examples from our system's cataloging search results: 1) Building mobile library applications / Jason A. Clark; series edited by Ellyssa Kroski.12The tech set ; 245a = Building mobile library applications / 245c = Jason A. Clark; series edited by Ellyssa Kroski. 490v = 12 490a = The tech set ; Suggested display change: Building mobile library applications / Jason A. Clark; series edited by Ellyssa Kroski. The tech set ; 12. 2) Responsive web design in practice / Jason A. Clark.12Library technology essentials ; 245a Responsive web design in practice / 245c Jason A. Clark. 490v 12 490a Library technology essentials ; Suggested display change: Responsive web design in practice / Jason A. Clark. Library technology essentials ; 12. 3) Top cops / based on the teleplay by Clark Stubbs ; illustrated by Jason Fruchter.Step into reading. Step 2 245a Top cops / 245c based on the teleplay by Clark Stubbs ; illustrated by Jason Fruchter. 490a Step into reading. Step 2 Suggested display change: Top cops / based on the teleplay by Clark Stubbs ; illustrated by Jason Fruchter. Step into reading. Step 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 02:47:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 01:47:28 +0000 Subject: [Koha-bugs] [Bug 15641] Typo in explanation for MembershipExpiryDaysNotice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15641 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |indradg at gmail.com |ity.org | CC| |indradg at gmail.com --- Comment #1 from Indranil Das Gupta --- Hi! I'm taking up this trivial string patch for demo purpose during IndKoha 2016 at Kolkata, India on Jan 23-24, 2016, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 19:38:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 18:38:25 +0000 Subject: [Koha-bugs] [Bug 15579] records_batchmod permission doesn't allow access to batch modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 19:41:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 18:41:19 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #7 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 19:43:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 18:43:17 +0000 Subject: [Koha-bugs] [Bug 15560] Multiple holding branchs and locations not displaying in pending holds report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 19:45:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 18:45:56 +0000 Subject: [Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 20:02:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 19:02:41 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. - Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 20:08:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 19:08:22 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #9 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 20:11:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 19:11:33 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 20:13:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 19:13:44 +0000 Subject: [Koha-bugs] [Bug 15601] TestBuilder tests are failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15601 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 20:15:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 19:15:39 +0000 Subject: [Koha-bugs] [Bug 15576] Link in OPAC redirects to the wrong page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15576 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 20:21:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 19:21:27 +0000 Subject: [Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 20:29:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 19:29:58 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #23 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 23 20:36:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jan 2016 19:36:31 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #2 from M. Tompsett --- Comment on attachment 46736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46736 Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page Review of attachment 46736: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12663&attachment=46736) ----------------------------------------------------------------- ::: C4/Auth.pm @@ +1250,5 @@ > PatronSelfRegistrationDefaultCategory => C4::Context->preference("PatronSelfRegistrationDefaultCategory"), > persona => C4::Context->preference("Persona"), > opac_css_override => $ENV{'OPAC_CSS_OVERRIDE'}, > + SCOUserCSS => C4::Context->preference("SCOUserCSS"), > + SCOUserJS => C4::Context->preference("SCOUserJS"), There is no need to pass system preferences. Use Koha.Preference calls in the Template Toolkit files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 24 17:13:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Jan 2016 16:13:05 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #44 from Marcel de Rooy --- Are there still plans to get this moving again? Additional question: How is this related to the COinS html Koha already generates? Why do we exactly need this, if that span can be easily converted to an OpenURL with standard solutions (browser extensions etc.) ? http://ocoins.info/latent.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 24 19:13:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Jan 2016 18:13:58 +0000 Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com --- Comment #1 from Eric B?gin --- I encounter this problem for a client that moved his Koha database on MySQL 5.6. A temporary fix I did was to force the sql_mode to NO_ENGINE_SUBSTITUTION (removing the STRICT_TRANS_TABLES) on the connection time. I added the following line in Context.pm $dbo->do("set SESSION sql_mode='NO_ENGINE_SUBSTITUTION'"); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 24 22:52:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Jan 2016 21:52:10 +0000 Subject: [Koha-bugs] [Bug 9069] Make it possible to import MARC21 authorities from VIAF into Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9069 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 00:00:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Jan 2016 23:00:00 +0000 Subject: [Koha-bugs] [Bug 15650] New: Credit Card Payment development other than Paypal Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15650 Bug ID: 15650 Summary: Credit Card Payment development other than Paypal Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: ccorrales at losgatosca.gov QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hello All! We are very excited about the new Paypal development however, have discovered we are unable to use it. Our Town requires us to charge a 2% fee for all credit card transactions. Unfortunately, this is against Paypal's policy. Is there any other public libraries out there that may be in the same situation? We do like how the Paypal interacts with Koha in clearing fines from a Patron's account. Is anyone able to assist in possibly developing a different online payment option for those of us who cannot use the Paypal development. Thank you! Carol -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 00:30:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Jan 2016 23:30:24 +0000 Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #11 from David Cook --- (In reply to Jonathan Druart from comment #10) > I have just used it right now. > For testing purpose I have removed the marcxml field. > Using --fix, I was able to repopulate it from the marc. But why did you remove the marcxml field at all? :p -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 03:17:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 02:17:04 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #81 from M. Tompsett --- Comment on attachment 26692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26692 [PATCH] Bug 10869: Allow the deletion of order line if the record is deleted Review of attachment 26692: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10869&attachment=26692) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +1760,4 @@ > =cut > > sub DelOrder { > + my ($ordernumber,$biblionumber) = @_; Were attempts to NOT change the parameter order made? This seems like extra work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 03:50:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 02:50:57 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #19 from M. Tompsett --- Created attachment 47236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47236&action=edit Bug 11573 - Make fine display more consistent for rentals To test: 1. Set up an item type with a rental charge 2. issue an item from that item type 3. Check fines - the rental charge does not show the title of the issued item 4. Renew that item, the renewal charge does show the title of the issued item 5. Apply the patch 6. Repeat steps 1-4, both should show the title of the issued item in the description. This change is proposed in order to get rid of some double ups in the title on the boraccount template. Signed-off-by: Katrin Fischer Tested with rental lines created before and after applying the patch. After applying the patch it's better, but old lines will still look ok. There is still a double up on the title on the 'pay' tab, as we get the title from the itemnumber and also display the description. I think getting all the information from the itemnumber for display would be a bit nicer in the future. Butthis is an improvement. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 03:51:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 02:51:06 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #20 from M. Tompsett --- Created attachment 47237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47237&action=edit Bug 11573 - removing title double ups on boraccount.tt To test: 1. Create a bunch of fines (or view your existing fines data) - it should have lost entries, rentals, rental renewals, and regular fines and fine updates. 2. View the fines tab for your borrower with fines 3. without the patch, it will look like the submitted screenshot 4. with the patch, there will be few, if any, doubleups of title This patch may be incomplete - there may be cases that still need work. I'm happy to do followups. Rental fees and rental renewals will not look wholly consistent without the other attached patch, but this one does not require it. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 03:51:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 02:51:30 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #21 from M. Tompsett --- Created attachment 47238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47238&action=edit Bug 11573: Follow-up: Include changes in OPAC templates Patch adds changes from earlier patches to OPAC prog and bootstrap templates. Patch radds a description for FU - Accrued fine. Removes a stray space before the comma, using some TT magic. To test: - Test like the other patch, display in OPAC prog, OPAC bootstrap, Staff Pay fines tab and Staff Accounts tab should be the same. - No ' , ' should be seen. - FU fines should now display a description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 05:07:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 04:07:18 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Attachment #47236|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 05:07:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 04:07:24 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47237|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 05:07:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 04:07:32 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47238|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 05:32:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 04:32:04 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #22 from M. Tompsett --- Created attachment 47239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47239&action=edit Bug 11573 - Make fine display more consistent for rentals To test: 1. Set up an item type with a rental charge 2. issue an item from that item type 3. Check fines - the rental charge does not show the title of the issued item 4. Renew that item, the renewal charge does show the title of the issued item 5. Apply the patch 6. Repeat steps 1-4, both should show the title of the issued item in the description. This change is proposed in order to get rid of some double ups in the title on the boraccount template. Signed-off-by: Katrin Fischer Tested with rental lines created before and after applying the patch. After applying the patch it's better, but old lines will still look ok. There is still a double up on the title on the 'pay' tab, as we get the title from the itemnumber and also display the description. I think getting all the information from the itemnumber for display would be a bit nicer in the future. Butthis is an improvement. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 05:32:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 04:32:11 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #23 from M. Tompsett --- Created attachment 47240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47240&action=edit Bug 11573 - removing title double ups on boraccount.tt To test: 1. Create a bunch of fines (or view your existing fines data) - it should have lost entries, rentals, rental renewals, and regular fines and fine updates. 2. View the fines tab for your borrower with fines 3. without the patch, it will look like the submitted screenshot 4. with the patch, there will be few, if any, doubleups of title This patch may be incomplete - there may be cases that still need work. I'm happy to do followups. Rental fees and rental renewals will not look wholly consistent without the other attached patch, but this one does not require it. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 05:32:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 04:32:20 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #24 from M. Tompsett --- Created attachment 47241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47241&action=edit Bug 11573: Follow-up: Include changes in OPAC templates Patch adds changes from earlier patches to OPAC prog and bootstrap templates. Patch radds a description for FU - Accrued fine. Removes a stray space before the comma, using some TT magic. To test: - Test like the other patch, display in OPAC prog, OPAC bootstrap, Staff Pay fines tab and Staff Accounts tab should be the same. - No ' , ' should be seen. - FU fines should now display a description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 05:42:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 04:42:23 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47241|0 |1 is obsolete| | --- Comment #25 from M. Tompsett --- Created attachment 47242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47242&action=edit Bug 11573: Follow-up: Include changes in OPAC templates Patch adds changes from earlier patches to OPAC prog and bootstrap templates. Patch radds a description for FU - Accrued fine. Removes a stray space before the comma, using some TT magic. To test: - Test like the other patch, display in OPAC prog, OPAC bootstrap, Staff Pay fines tab and Staff Accounts tab should be the same. - No ' , ' should be seen. - FU fines should now display a description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 05:43:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 04:43:04 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24485|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 05:43:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 04:43:15 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24486|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 05:43:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 04:43:32 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27822|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 05:43:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 04:43:47 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27823|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 05:44:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 04:44:00 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27824|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 05:45:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 04:45:51 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #26 from M. Tompsett --- It now applies, and should be identical to before. Admittedly, the commit messages probably should be tweaked to reflect minor changes, but that would make comparing patches more difficult. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 05:55:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 04:55:03 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 --- Comment #19 from M. Tompsett --- Comment on attachment 47147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47147 Bug 15618: Typos fixed in enhanced_content.pref Review of attachment 47147: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15618&attachment=47147) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref @@ +182,4 @@ > choices: > yes: Use > no: "Don't use" > + - content from Syndetics. Note that this requires that you have signed up for the service and entered in your client code above. Line 187 and 188 visible in this patch make it look like below is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 06:03:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 05:03:33 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 --- Comment #20 from M. Tompsett --- Comment on attachment 47148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47148 Bug 15618: Typos fixed in circulation.pref Review of attachment 47148: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15618&attachment=47148) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref @@ +161,4 @@ > choices: > yes: Allow > no: "Don't allow" > + - checkouts of items which are on hold to someone else. If allowed do not generate RESERVE_WAITING and RESERVED warning. This allows self checkouts for those items. "reserved to" is wrong, but I think this should be either "reserved by" (less change and aligns with RESERVE message portions) or "which are on hold for". @@ +278,4 @@ > - > - "Restrict patrons with the following target audience values from checking out inappropriate materials:" > - pref: AgeRestrictionMarker > + - "E.g. Enter target audience keyword(s) split by | (pipe) FSK|PEGI|Age| (No white space near |). Be sure to map agerestriction in Koha to MARC mapping (e.g. 521$a). A MARC field value of FSK 12 or PEGI 12 would mean: 'Borrower must be 12 years old'. Leave empty to not apply an age restriction." I was noticing 856u in another patch on this bug report. Are we doing 856u or 856$u? We have 521$a here. Should it be 521a? @@ -365,5 @@ > choices: > - confirm: "require confirmation" > - alert: "display a message" > - nothing : "do nothing" > - - . I like this '.' removal and placing at the end of the strings. @@ +523,5 @@ > - pref: emailLibrarianWhenHoldIsPlaced > choices: > + yes: Do > + no: "Don't" > + - "send an email to the Koha administrator email address whenever a hold request is placed." "Send" "Don't send"? I don't see why this change is necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 06:30:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 05:30:37 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 06:30:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 05:30:39 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 --- Comment #6 from M. Tompsett --- Created attachment 47243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47243&action=edit Bug 15599 - Unit tests output warnings The unit tests t/db_dependent/Circulation/Returns.t and t/db_dependent/Items.t print out eh warning "item-level_itypes set but no itemtype set for item". This should not happen. Test Plan: 1) prove t/db_dependent/Circulation/Returns.t 2) Note the warning 3) prove t/db_dependent/Items.t 4) Note the warning 5) Apply this patch 6) prove t/db_dependent/Circulation/Returns.t 7) Note there is no warning 8) prove t/db_dependent/Items.t 9) Note there is no warning Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 06:32:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 05:32:30 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46869|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 06:32:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 05:32:39 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 08:20:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 07:20:19 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #21 from Katrin Fischer --- > @@ +278,4 @@ > > - > > - "Restrict patrons with the following target audience values from checking out inappropriate materials:" > > - pref: AgeRestrictionMarker > > + - "E.g. Enter target audience keyword(s) split by | (pipe) FSK|PEGI|Age| (No white space near |). Be sure to map agerestriction in Koha to MARC mapping (e.g. 521$a). A MARC field value of FSK 12 or PEGI 12 would mean: 'Borrower must be 12 years old'. Leave empty to not apply an age restriction." > > I was noticing 856u in another patch on this bug report. Are we doing 856u > or 856$u? We have 521$a here. Should it be 521a? I think 521$u makes sense, if we have other cases without $ we could fix them separately. I think some options require you to enter without $, so have to be careful fixing. > > @@ -365,5 @@ > > choices: > > - confirm: "require confirmation" > > - alert: "display a message" > > - nothing : "do nothing" > > - - . > > I like this '.' removal and placing at the end of the strings. The extra . at the end creates a separate string in the translation files and is a little advantage for translations. Because it's not always easy to built a grammatically correct sentence that has the options at the end, this extra string for the . allows to split the sentence up and have some words after the option list - not sure if I used it here, but I did in some other cases. > > @@ +523,5 @@ > > - pref: emailLibrarianWhenHoldIsPlaced > > choices: > > + yes: Do > > + no: "Don't" > > + - "send an email to the Koha administrator email address whenever a hold request is placed." > > "Send" "Don't send"? I don't see why this change is necessary. I think the change makes it a bit easier to read. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 09:42:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 08:42:29 +0000 Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44293|0 |1 is obsolete| | --- Comment #23 from Lari Taskula --- Created attachment 47244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47244&action=edit Bug 13906 - TestObjectFactory(ies) for Koha objects. Holds test factory for v3.16 Fixes a conflict. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 09:47:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 08:47:29 +0000 Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larit at student.uef.fi Depends on| |13906 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 09:47:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 08:47:29 +0000 Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14698 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 10:09:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 09:09:17 +0000 Subject: [Koha-bugs] [Bug 5161] patron attributes clearing if duplicate warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5161 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 10:44:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 09:44:16 +0000 Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #12 from Jonathan Druart --- (In reply to David Cook from comment #11) > (In reply to Jonathan Druart from comment #10) > > I have just used it right now. > > For testing purpose I have removed the marcxml field. > > Using --fix, I was able to repopulate it from the marc. > > But why did you remove the marcxml field at all? :p I have no idea, really :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 10:44:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 09:44:25 +0000 Subject: [Koha-bugs] [Bug 15643] Every datepicker on serials expected date column updates top issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15643 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47162|0 |1 is obsolete| | --- Comment #2 from Koha Team Lyon 3 --- Comment on attachment 47162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47162 Bug 15643 - Every datepicker on serials expected date column updates top issue This patch is wrong : the expected date is not any more updated to current date when adding an item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 11:01:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 10:01:32 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 --- Comment #9 from Jonathan Druart --- Kyle, did you read comments 4 and 6? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 11:13:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 10:13:19 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #10 from Katrin Fischer --- I think they might have accidentally uploaded the wrong patch or forgot to include the change mentioned in comment#5. Can we fix this in a little follow-up please? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 11:14:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 10:14:34 +0000 Subject: [Koha-bugs] [Bug 15646] koha qa test tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15646 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- % perlcritic -1 C4/Auth.pm | wc -l 531 Well, it seems that we are not ready at all for level 1... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 11:22:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 10:22:42 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 --- Comment #11 from Jonathan Druart --- This subpermission is never checked actually. So either we only test for CAN_user_reserveforothers everywhere or we change all the appropriate occurrences with CAN_user_reserveforothers_place_holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 11:23:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 10:23:41 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 --- Comment #12 from Katrin Fischer --- Hm, so maybe push this patch as is and then to a general clean-up separately? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 11:35:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 10:35:07 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 11:35:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 10:35:11 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 --- Comment #13 from Jonathan Druart --- Created attachment 47245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47245&action=edit Bug 14244: Does not display patron's info in the checkout history if not authorised The librarian needs CAN_user_circulate_circulate_remaining_permissions to see the checkouts patron's information. Test plan: The "Patron" column of the checkout history page should only be displayed of you have the circulate > circulate_remaining_permissions permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 11:38:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 10:38:06 +0000 Subject: [Koha-bugs] [Bug 15651] New: Bugzilla should use https Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15651 Bug ID: 15651 Summary: Bugzilla should use https Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Project website Assignee: wizzyrea at gmail.com Reporter: mirko at abunchofthings.net Open https://bugs.koha-community.org. Site does not exist. There should be https available, and probably only https available since we send passwords around. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 11:38:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 10:38:29 +0000 Subject: [Koha-bugs] [Bug 15450] koha-community.org/kohacon/ needs update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15450 Wolfram Schneider changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|minor |normal CC| |wosch at freebsd.org --- Comment #1 from Wolfram Schneider --- The KohaCon16 is coming soon - can we add it please to the main site? People needs to book flights, and it would be really helpful to have an official site with the date and locations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 11:46:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 10:46:01 +0000 Subject: [Koha-bugs] [Bug 4850] CheckReserves does not respect holds circulation policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #6 from Koha Team Lyon 3 --- I confirm that it's still an issue on master. If your item-level_itypes syspref is on item level, you can choose different itemtypes for the same biblio : some of them can be hold and the other not. If you choose to deal holds at a biblio level, you can encounter the problem described by Ian Walls : If there a hold on a biblio with 2 items that are checked out, if the first one to be checked in is not an item type that can be reserve, the circulation rules are not verified and the hold is placed on this item. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 11:53:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 10:53:32 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 11:53:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 10:53:35 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46888|0 |1 is obsolete| | Attachment #46889|0 |1 is obsolete| | Attachment #46890|0 |1 is obsolete| | Attachment #46891|0 |1 is obsolete| | Attachment #46892|0 |1 is obsolete| | Attachment #46893|0 |1 is obsolete| | Attachment #46894|0 |1 is obsolete| | Attachment #46895|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart --- Created attachment 47246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47246&action=edit Bug 12803 - Add ability to skip closed libraries when generating the holds queue The holds queue is typically generated many times a day in order to select items to fill holds. Often these items are to be sent to a different library. However, if the library whose item is picked to fill a hold is closed, that hold will remain unfilled even if there are other open libraries who own that item. It would be helpful if we could skip closed libraries for the purpose of selecting items to fill holds. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with two items on it, one at Branch A, and one at Branch B 4) Place a hold for pickup at Branch C 5) Generate the holds queue 6) Note which branch's item is selected for the hold 7) Enable the new system preference HoldsQueueSkipClosed 8) Add today as a holiday for that branch noted in step 6 9) Regenerate the holds queue 10) View the holds queue, notice the item selected is not from the closed branch! 11) prove t/db_dependent/HoldsQueue.t Signed-off by: Jason Robb Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 11:53:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 10:53:42 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #76 from Jonathan Druart --- Created attachment 47247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47247&action=edit Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes Bug 12803 [QA Followup] - Remove use of C4::Dates C4::Dates was being included, but not used in the code! Bug 12803 [QA Followup] - Fix koha-qa.pl errors Bug 12803 [QA Followup] - Update unit tests due to changes in master Bug 12803 [QA Followup] - Fix to stop failing unit tests Bug 12803 [QA Followup] - Remove duplicate 'use' lines Bug 12803 [QA Followup] - Remove NO_CACHE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 11:55:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 10:55:05 +0000 Subject: [Koha-bugs] [Bug 15391] HoldsQueue.t does not handle for loan itemtypes correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12803 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 [Bug 12803] Add ability to skip closed libraries when generating the holds queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 11:55:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 10:55:05 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15391 --- Comment #77 from Jonathan Druart --- Kyle, To easy the readability, I have squashed the qa follow-ups, especially because of the NOCACHE param, which has been added and finally removed. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 [Bug 15391] HoldsQueue.t does not handle for loan itemtypes correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:02:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:02:13 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Jonathan Druart --- yep, agreed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:08:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:08:46 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #57 from Jonathan Druart --- I get Undefined subroutine &main::_skip_borrowers_with_nonzero_balance_or_issues called at /home/koha/src/tools/cleanborrowers.pl line 103. then, afer renaming the subroutine correctly: Can't call method "patron_list_patrons" on an undefined value at /home/koha/src/tools/cleanborrowers.pl line 128. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:11:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:11:45 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Wolfram Schneider changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wosch at freebsd.org --- Comment #87 from Wolfram Schneider --- If marcxml + XSLT is to slow, then you might try to use turbomarc instead. It's a smaller XML for MARC and much faster to work with in XSLT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:18:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:18:08 +0000 Subject: [Koha-bugs] [Bug 15579] records_batchmod permission doesn't allow access to batch modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:19:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:19:20 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:28:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:28:32 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #18 from Julian Maurice --- Patches were not pushed in the right order in master, resulting in a code slightly different from what it should be (empty if body instead of a 'next if' statement) I think this should be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:29:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:29:27 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #19 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:30:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:30:03 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #17 from Jonathan Druart --- (In reply to Owen Leonard from comment #16) > I think the essence of the issue is: Is it useful to the user to have a > different style for 'alerts' and 'errors?' Would it convey information to > them which helps them understand what's going on? In a perfect world, we should not display the error messages after the user has submitted the form, because the values filled are lost. The check should be done when filling the form. IMO it would make sense to separate the 2 behaviors: alert the user that a choice must be made, or display an error because something wrong happened (i.e. the code needs to be fixed to prevent that). If you don't think it's necessary, I can provide a global fix to correct all occurrences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:42:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:42:03 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:42:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:42:06 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46615|0 |1 is obsolete| | Attachment #46616|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 47248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47248&action=edit Bug 15530 - Add Unit Test Signed-off-by: Margaret Holt Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:42:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:42:06 +0000 Subject: [Koha-bugs] [Bug 15560] Multiple holding branchs and locations not displaying in pending holds report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:42:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:42:22 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 --- Comment #13 from Jonathan Druart --- Created attachment 47249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47249&action=edit Bug 15530 - Editing a course item via a disabled course disables it even if it is on other enabled courses It appears that if the course item is edited by clicking the edit link from an active course, the course item will be set to enabled and the fields will be swapped, if the same course item is edited from a course that is *not* active, the course item will be set to *not* enabled, and the original fields will be swapped back in! The short term work-around is to only edit course items from an enabled course if the item has a course that is enabled. If all the courses it is on are disabled, it doesn't matter what course the item is edited from. Test Plan: 1) Create two courses, 1 enabled and 1 disabled 2) Add an item as a course reserve to both courses 3) Edit the course reserve data for the item via the enabled course 4) Note the course item is enabled ( easy way is to check the database ) 5) Edit the same course reserve data, but via the disabled course 6) Note the course item is now disabled even though it is part of an enabled course! 7) Apply this patch 8) Repeat steps 1 through 5 9) Note the course item is still enabled Signed-off-by: Margaret Holt Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:43:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:43:18 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun |ommunity.org |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:43:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:43:51 +0000 Subject: [Koha-bugs] [Bug 15570] circ/renew.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:46:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:46:28 +0000 Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- You can do the same without modifying the source code, just comment the sql_mode=STRICT_TRANS_TABLES line in your MySQL/MariaDB config file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:48:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:48:57 +0000 Subject: [Koha-bugs] [Bug 15380] Move the authority types related code to Koha::Authority::Type[s] - part 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15578 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 [Bug 15578] Authority tests skip and hide a bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:48:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:48:57 +0000 Subject: [Koha-bugs] [Bug 15578] Authority tests skip and hide a bug In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Depends on| |15380 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 [Bug 15380] Move the authority types related code to Koha::Authority::Type[s] - part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:51:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:51:30 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- Kyle, the warnings appear for many other tests, see t/db_dependent/Reserves.t for instance. I don't think this is a right way to fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:51:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:51:40 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:51:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:51:56 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #63 from Jonathan Druart --- We need to fix bug 15599 first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:52:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:52:10 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #10 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:52:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:52:47 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 12:55:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 11:55:45 +0000 Subject: [Koha-bugs] [Bug 15354] item types aren't showing in default hold policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #15 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:05:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:05:03 +0000 Subject: [Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #24 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:08:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:08:58 +0000 Subject: [Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:13:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:13:38 +0000 Subject: [Koha-bugs] [Bug 15652] New: Allow current date in datepicker on opac-reserve Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15652 Bug ID: 15652 Summary: Allow current date in datepicker on opac-reserve Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:17:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:17:49 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #9 from Jonathan Druart --- Nick, could you double check, I don't get the modal. +

    Please enter a number, greater than 1

    I am able to enter 1, without a warning message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:17:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:17:57 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #15 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:21:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:21:47 +0000 Subject: [Koha-bugs] [Bug 14538] POD for CalcFine is incomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14538 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:24:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:24:13 +0000 Subject: [Koha-bugs] [Bug 14613] Send cart window is too small in staff and hides 'send' button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14613 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:25:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:25:47 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15449 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:25:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:25:47 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15407 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:25:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:25:58 +0000 Subject: [Koha-bugs] [Bug 15606] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15606 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:26:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:26:03 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15407 | Depends on| |15407 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:26:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:26:03 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15449 Depends on|15449 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:39:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:39:18 +0000 Subject: [Koha-bugs] [Bug 15653] New: Updating a guarantor has never updated its guarantees Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15653 Bug ID: 15653 Summary: Updating a guarantor has never updated its guarantees Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 15548 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 [Bug 15548] New patron related code should have been put to Patron instead of Borrower -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:39:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:39:18 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15653 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15653 [Bug 15653] Updating a guarantor has never updated its guarantees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:48:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:48:39 +0000 Subject: [Koha-bugs] [Bug 15653] Updating a guarantor has never updated its guarantees In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15653 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:48:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:48:42 +0000 Subject: [Koha-bugs] [Bug 15653] Updating a guarantor has never updated its guarantees In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15653 --- Comment #1 from Jonathan Druart --- Created attachment 47250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47250&action=edit Bug 15653: Remove unused C4::Members::UpdateGuarantees subroutine Looking at the code, there is some broken with the guarantees code. It seems that the expected behavior would be to update address, fax, B_city, mobile, city and phone info of the guarantees when a guarantor is modified. But the code in C4::Members::ModMember is broken: 668 my $borrowercategory= GetBorrowercategory( $data{'category_type'} ); 669 if ( exists $borrowercategory->{'category_type'} && $borrowercategory->{'category_type'} eq ('A' || 'S') ) { 670 # is adult check guarantees; 671 UpdateGuarantees(%data); 672 } First, GetBorrowerCategory expects a categorycode, not a category_type. Then UpdateGuarantees retrieves the param like: 989 sub UpdateGuarantees { 990 my %data = shift; Which means that %data will always be something like ( a_key => undef ) And nothing more. The updateguarantees subroutine (It has been renamed) has been introduced by commit 56825e415fc232e38f0a874dc9a81fa2169ef06b Date: Mon Aug 30 13:48:58 2004 +0000 modularizing (with Members.pm) members management (beginning of...) And the `%data = shift` already existed... This code has never worked and could be removed. See http://lists.koha-community.org/pipermail/koha-devel/2016-January/042241.html Test plan: Confirm the previous assertions. Note that I have found this bug working on bug 15631, see patch "Bug 15631: Koha::Cities - remove getidcity and GetCities" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 13:57:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 12:57:15 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #20 from Marcel de Rooy --- (In reply to Julian Maurice from comment #18) > Patches were not pushed in the right order in master, resulting in a code > slightly different from what it should be (empty if body instead of a 'next > if' statement) > > I think this should be fixed. Perhaps change the status to attract RM attention again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:00:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:00:19 +0000 Subject: [Koha-bugs] [Bug 15652] Allow current date in datepicker on opac-reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15652 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:00:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:00:21 +0000 Subject: [Koha-bugs] [Bug 15652] Allow current date in datepicker on opac-reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15652 --- Comment #1 from Marcel de Rooy --- Created attachment 47251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47251&action=edit Bug 15652: Allow current date in datepicker on opac-reserve If you enable AllowHoldDateInFuture (and its OPAC variant), you get an additional "Hold starts on date". In that field and in "Hold not needed after" it was not possible to enter the current date. Although it does not really make any difference if you leave the startdate empty or put the current date in it, we concluded that it still makes a psychological difference. Some patrons were confused when placing a hold because the first date to select was tomorrow. Instead of telling them "Yes, but you can leave it empty", we should just allow the current date as well. The expiration date ("not needed after") also started on tomorrow. (This field can really be empty.) But there is actually no reason not to allow today here too. If the patron only wants it today, why force tomorrow? How is this arranged? Well, this is one of the simplest Koha patches ever written. It only changes the minDate option of both date pickers in one line from 1 to 0. Test plan: [1] Allow future hold dates via systempreferences. [2] Verify that you can enter today in both fields. [3] Put today in start and expiration date. Place the hold and verify that you can confirm the hold, check out and check in again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:01:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:01:12 +0000 Subject: [Koha-bugs] [Bug 15652] Allow current date in datepicker on opac-reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15652 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:09:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:09:56 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #14 from Marc V?ron --- The patches work as described. However, I can still see patron information in the Normal view on ...cgi-bin/koha/catalogue/detail.pl?biblionumber=xxxxx, in column "Status". Example: Currently in local use by Edna Acosta : due 11/12/2015 23:59 ...and the link on the name leads to the "No permission" page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:11:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:11:38 +0000 Subject: [Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Variouse combinations of |Various combinations of |QueryAutoTruncate, |prefs QueryAutoTruncate, |QueryFuzzy and |QueryFuzzy and |QueryWeightFields |QueryWeightFields conflict |preferences Conflict | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:12:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:12:14 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 --- Comment #15 from Katrin Fischer --- Hi Marc, I think this bug is only about the reading history - so the detail page/normal view woudl be better on another bug report. Do you agree with the general approach or would you like it to work differently? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:13:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:13:28 +0000 Subject: [Koha-bugs] [Bug 15643] Every datepicker on serials expected date column updates top issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15643 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:15:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:15:03 +0000 Subject: [Koha-bugs] [Bug 15650] Credit Card Payment development other than Paypal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15650 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:16:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:16:47 +0000 Subject: [Koha-bugs] [Bug 15634] Show uploaded content in an image gallery In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15634 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:23:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:23:17 +0000 Subject: [Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715 --- Comment #4 from Marcel de Rooy --- What about Fuzzy=Try and an older Zebra 2.0.44 (on Wheezy -- still supported)? Fuzzy adds 5=103 to the query and that results in an ERROR 120 Unsupported Truncation attribute. BTW Note that Fuzzy is enabled by default in a new Koha (sysprefs.sql). Verified on current master. Not really a welcome to Koha? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:31:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:31:10 +0000 Subject: [Koha-bugs] [Bug 15654] New: Integrating a cash register system into Koha: An Example Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15654 Bug ID: 15654 Summary: Integrating a cash register system into Koha: An Example Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: larit at student.uef.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To my knowledge, Koha does not yet have a way to integrate cash register systems. Here at Vaara-kirjastot, we wanted to integrate Koha with our "Ceepos" cash registers and the cash register server provided by CPU (the awesome company that delivers our cash registers). Before the feature, the workflow was as follows: Koha <-> Librarian (manual) <-> cash register Librarians had to manually enter the fine product code and fee amount into a cash register, and then complete the payment in Koha. This would print a receipt with no description (item name) of the item that was paid. With the feature, the workflow changes into: Koha <-> Cash register server (automatic) <-> cash register After librarian proceeds to pay Borrower's fines, product codes and fees are automatically transferred into the cash register via the cash register server. Payment is completed in Koha automatically. A receipt with detailed information (Borrower name, card number, all paid items listed with their description and amount paid) is printed. Short description of how this works: - Borrower comes to a counter and wants to pay his/her fees. - Koha (with this patch) sends the cash register server a JSON-message that contains information about the Borrower and the Products (=> Koha fines). - Cash registers are connected to the cash register server. They pick up the pending payment. - Borrower pays the fee. - Cash register tells the cash register server that the payment is completed. - Cash register server tells Koha that the payment is completed. - Koha completes the Borrower's payment into accountlines. Currently our work only supports CPU's protocol, but if others here at Koha community have interest in a feature like this, it could be modified to make it easily extendable and therefore to suit better the needs of the community. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:32:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:32:04 +0000 Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15654 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15654 [Bug 15654] Integrating a cash register system into Koha: An Example -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:32:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:32:04 +0000 Subject: [Koha-bugs] [Bug 15654] Integrating a cash register system into Koha: An Example In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15654 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14698 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:32:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:32:21 +0000 Subject: [Koha-bugs] [Bug 15654] Integrating a cash register system into Koha: An Example In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15654 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:43:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:43:48 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:43:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:43:50 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #10 from Nick Clemens --- Created attachment 47252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47252&action=edit Bug 14752 - [QA Followup] Correct error message Message changed from 'greater than 1' to 'greater than or equal to 1' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:45:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:45:02 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #11 from Nick Clemens --- (In reply to Jonathan Druart from comment #9) > I am able to enter 1, without a warning message. I think that is the correct behaviour, I altered the error acordingly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:50:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:50:27 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m Assignee|claire.hernandez at biblibre.c |julian.maurice at biblibre.com |om | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:50:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:50:36 +0000 Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 --- Comment #24 from Lari Taskula --- Created attachment 47253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47253&action=edit Bug 13906 (follow-up) - New TestObjectFactory for creating fines into accountlines Adds FinesFactory that creates new fines into accountlines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:52:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:52:47 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 --- Comment #22 from Lari Taskula --- Created attachment 47254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47254&action=edit Bug 14536 (follow-up) - New PageObjects for handling Fines Adds PageObjects that can handle the Fines tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:59:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:59:11 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47226|0 |1 is obsolete| | --- Comment #58 from Nick Clemens --- Created attachment 47255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47255&action=edit Bug 10612 [QA Followup] 1 - Use Koha::List::Patron 2 - Return only non-empty lists for deletion selection 3 - Fix _skip_bo... to accept patro_list_patrons3 - Fix _skip_bo... to accept patro_list_patrons3 - Fix _skip_bo... to accept patro_list_patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 14:59:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 13:59:50 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 --- Comment #8 from M. Tompsett --- (In reply to Jonathan Druart from comment #7) > Kyle, the warnings appear for many other tests, see > t/db_dependent/Reserves.t for instance. > I don't think this is a right way to fix it. Perhaps not overall, however, taking "string $foo->bar" and turning it to "string $foobar" is a start. Catching warnings is a good test. Perhaps "$debug and" prepended to the {warn mess} would be fitting, and still allow for the testing added? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 15:15:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 14:15:26 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #21 from Jesse Weaver --- Patches repushed in correct order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 15:22:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 14:22:58 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 --- Comment #16 from Marc V?ron --- Hi Katrin, no problem with fixing it with a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 15:24:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 14:24:57 +0000 Subject: [Koha-bugs] [Bug 15654] Integrating a cash register system into Koha: An Example In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15654 --- Comment #1 from Lari Taskula --- Created attachment 47256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47256&action=edit Bug 15654: Integrate cash register system into Koha (An Example: case CPU) Integrates Koha with cash register system. Adds "payments_transactions" and "payments_transactions_accountlines" database tables to hold the cash register system payments. Adds REST API endpoints - /api/v1/pos/cpu/100 GET information about a payment - /api/v1/pos/cpu/100/report POST to tell Koha that payment is completed / cancelled. Adds some configurations for the integration to koha-conf. Intranet template modifications for the integration. After payment is sent to the cash register server, a loading screen is shown until the payment is either completed or cancelled at the cash register. Adds system preferences to enable/disable the integration and to map Koha fines to codes recognized by the cash register (as YAML-config). Ability to set SSL certificates for the connection between Koha server and the cash register server. ----------------------------------------------------------------------- Step by step how it works: - Borrower wants to pay fines. - Librarian confirms to pay the fines. - Payment is created into payments_transactions. The selected accountlines related to this payment are stored into payments_transactions_accountlines. - A new loading screen opens. An Ajax call is made to Koha server. - Koha receives the call and starts to go through the selected payments. - Koha "translates" Koha-fine-types (accounttypes) into codes recognized by the cash register and forms a JSON object for the payment. - JSON is sent as a long polling request to cash register server. - Librarian completes payment at cash register. Koha receives a response. - Ajax call gets an response and tells the librarian whether the payment was completed/cancelled. - REST API receives a message from the cash register server. The message tells whether the payment was completed/cancelled. According to this information, the payment at "payments_transactions" table gets an updated status. - Librarian is forwarded into Account tab of Borrower's Fines. If the payment was paid, it should be now shown. ----------------------------------------------------------------------- THIS PATCH ONLY SUPPORTS OUR LOCAL PROVIDER. It is provided as an example in hope to start discussion whether a feature like this is wanted in the Koha community. This patch cannot easily be tested with the actual cash register server, because the server is not open source. However, if you wish to proceed into actually testing the integration, leave a comment in Bug 15654 and we can discuss it further. One possibility would be to create a simple script that responds the way the integration expects. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 15:25:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 14:25:36 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43495|0 |1 is obsolete| | --- Comment #17 from Marc V?ron --- Created attachment 47257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47257&action=edit Bug 14244: viewing a bib item's circ history requires circulation permissions On issuehistory.pl you have: flagsrequired => { circulate => "circulate_remaining_permissions" }, But that really doesn't make sense. People should be able to view the history of circulation without having permission to circulate items themselves This patch changes the required permissions from circulate to catalogue. Test Plan: 1. Login as user without the circulate_remaining_permissions 2. Attempt to view Circulation History of an Item 3. Does not work 4. Apply Patch 5. Attempt to view circulation history with a user that has access to the staff side. 6. Can view circulation history now Signed-off-by: Nicole Engard Signed-off-by: Jonathan Druart Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 15:26:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 14:26:28 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47245|0 |1 is obsolete| | --- Comment #18 from Marc V?ron --- Created attachment 47258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47258&action=edit Bug 14244: Does not display patron's info in the checkout history if not authorised The librarian needs CAN_user_circulate_circulate_remaining_permissions to see the checkouts patron's information. Test plan: The "Patron" column of the checkout history page should only be displayed of you have the circulate > circulate_remaining_permissions permission. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 15:26:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 14:26:46 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 15:37:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 14:37:18 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 15:37:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 14:37:20 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47255|0 |1 is obsolete| | --- Comment #59 from Nick Clemens --- Created attachment 47259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47259&action=edit Bug 10612 [QA Followup] - fix issues 1 - Use Koha::List::Patron 2 - Return only non-empty lists for deletion selection 3 - Fix _skip_bo... to accept patro_list_patrons3 - Fix _skip_borrowers_with_fines_or_issues to accept patro_list_patrons3 4 - Fix missed closing quote in cleanborrowers.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 15:40:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 14:40:20 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #60 from Nick Clemens --- (In reply to Jonathan Druart from comment #57) > Undefined subroutine &main::_skip_borrowers_with_nonzero_balance_or_issues > called at /home/koha/src/tools/cleanborrowers.pl line 103. I don't get this one, did you apply 15642? > Can't call method "patron_list_patrons" on an undefined value at > /home/koha/src/tools/cleanborrowers.pl line 128. Fixed missing closing quote on patron_list_id value which caused this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 15:51:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 14:51:35 +0000 Subject: [Koha-bugs] [Bug 15655] New: Do not display patron information on biblio detail page if not allowed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15655 Bug ID: 15655 Summary: Do not display patron information on biblio detail page if not allowed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Staff members should have at least 'circulate_remaining_permissions' to display patron information (as with Bug 14244). However, the biblio detail page (cgi-bin/koha/catalogue/detail.pl) displays in the 'Holdings' tab, column 'Status' information like: 'Currently in local use by Edna Acosta : due 11/12/2015 23:59', and the link on the patron's name leads to the "No permission" page. This information should not display if 'circulate_remaining_permissions' is not set. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 15:53:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 14:53:21 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15655 Patch complexity|--- |Trivial patch --- Comment #19 from Marc V?ron --- (In reply to Katrin Fischer from comment #15) > Hi Marc, I think this bug is only about the reading history - so the detail > page/normal view woudl be better on another bug report. Do you agree with > the general approach or would you like it to work differently? H Katrin, I filed a separate bug: Bug 15655 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 15:53:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 14:53:21 +0000 Subject: [Koha-bugs] [Bug 15655] Do not display patron information on biblio detail page if not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15655 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14244 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:07:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:07:10 +0000 Subject: [Koha-bugs] [Bug 15605] Accessibility: Can't tab to add link in serials routing list add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46968|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 47260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47260&action=edit Bug 15605 - Accessibility: Can't tab to add link in serials routing list add user popup To Test - 1. Go to Serials and search for a title and then click on it. 2. Click routing list and then Add recipients. 3. Search for a patron. 4. Using the tab key try to navigate onto the Add link. 5. Notice it skips Add. 6. Apply the patch and then repeat steps 1-4, notice the Add link can now be accessed through using the keyboard. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:07:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:07:27 +0000 Subject: [Koha-bugs] [Bug 15605] Accessibility: Can't tab to add link in serials routing list add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:17:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:17:30 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45639|0 |1 is obsolete| | --- Comment #14 from Marc V?ron --- Created attachment 47261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47261&action=edit Bug 15285: Upgrade DataTables to 1.10.10 The ColVis DataTables plugin is now retired. We need to upgrade the plugin to 1.10.10 and use the column visibility module for Buttons. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:17:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:17:43 +0000 Subject: [Koha-bugs] [Bug 15652] Allow current date in datepicker on opac-reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15652 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:17:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:17:45 +0000 Subject: [Koha-bugs] [Bug 15652] Allow current date in datepicker on opac-reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15652 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47251|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47262&action=edit [SIGNED-OFF]Bug 15652: Allow current date in datepicker on opac-reserve If you enable AllowHoldDateInFuture (and its OPAC variant), you get an additional "Hold starts on date". In that field and in "Hold not needed after" it was not possible to enter the current date. Although it does not really make any difference if you leave the startdate empty or put the current date in it, we concluded that it still makes a psychological difference. Some patrons were confused when placing a hold because the first date to select was tomorrow. Instead of telling them "Yes, but you can leave it empty", we should just allow the current date as well. The expiration date ("not needed after") also started on tomorrow. (This field can really be empty.) But there is actually no reason not to allow today here too. If the patron only wants it today, why force tomorrow? How is this arranged? Well, this is one of the simplest Koha patches ever written. It only changes the minDate option of both date pickers in one line from 1 to 0. Test plan: [1] Allow future hold dates via systempreferences. [2] Verify that you can enter today in both fields. [3] Put today in start and expiration date. Place the hold and verify that you can confirm the hold, check out and check in again. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:18:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:18:34 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46484|0 |1 is obsolete| | --- Comment #15 from Marc V?ron --- Created attachment 47263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47263&action=edit Bug 15285: Update common files This patch moves the Button area all tables which does not redefine the dom/sDom DT parameter. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:22:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:22:38 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46485|0 |1 is obsolete| | --- Comment #16 from Marc V?ron --- Created attachment 47264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47264&action=edit Bug 15285: Update for 3 specific tables The checkouts, currency and items lost tables redefine the dom/sDom and the older C(olvis) should be replaced with the current B(utton). Test plan: To test the whole patch set, you will have to test the 4 tables impacted by this patch as well as the others using the columns settings. The additem has specific code and should be tested keeping that in mind. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:23:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:23:01 +0000 Subject: [Koha-bugs] [Bug 15653] Updating a guarantor has never updated its guarantees In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15653 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:23:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:23:04 +0000 Subject: [Koha-bugs] [Bug 15653] Updating a guarantor has never updated its guarantees In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15653 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47250|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47265&action=edit [SIGNED-OFF]Bug 15653: Remove unused C4::Members::UpdateGuarantees subroutine Looking at the code, there is some broken with the guarantees code. It seems that the expected behavior would be to update address, fax, B_city, mobile, city and phone info of the guarantees when a guarantor is modified. But the code in C4::Members::ModMember is broken: 668 my $borrowercategory= GetBorrowercategory( $data{'category_type'} ); 669 if ( exists $borrowercategory->{'category_type'} && $borrowercategory->{'category_type'} eq ('A' || 'S') ) { 670 # is adult check guarantees; 671 UpdateGuarantees(%data); 672 } First, GetBorrowerCategory expects a categorycode, not a category_type. Then UpdateGuarantees retrieves the param like: 989 sub UpdateGuarantees { 990 my %data = shift; Which means that %data will always be something like ( a_key => undef ) And nothing more. The updateguarantees subroutine (It has been renamed) has been introduced by commit 56825e415fc232e38f0a874dc9a81fa2169ef06b Date: Mon Aug 30 13:48:58 2004 +0000 modularizing (with Members.pm) members management (beginning of...) And the `%data = shift` already existed... This code has never worked and could be removed. See http://lists.koha-community.org/pipermail/koha-devel/2016-January/042241.html Test plan: Confirm the previous assertions. Note that I have found this bug working on bug 15631, see patch "Bug 15631: Koha::Cities - remove getidcity and GetCities" Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:23:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:23:42 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46686|0 |1 is obsolete| | --- Comment #17 from Marc V?ron --- Created attachment 47266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47266&action=edit Bug 15285: Fix conflict with the treetable plugin The tables using the treetable plugin don't display correctly (with JS error). The lazy way to fix it is to redefine the dom of the table and remove the button area (B). Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:24:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:24:56 +0000 Subject: [Koha-bugs] [Bug 15285] Upgrade DataTables to 1.10.10 or later In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:26:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:26:15 +0000 Subject: [Koha-bugs] [Bug 15654] Integrating a cash register system into Koha: An Example In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15654 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6934 CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:26:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:26:15 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15654 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:26:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:26:47 +0000 Subject: [Koha-bugs] [Bug 15654] Integrating a cash register system into Koha: An Example In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15654 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11373 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:26:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:26:47 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15654 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:28:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:28:25 +0000 Subject: [Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- Isn't this line problematic? [% IF ( irregularity ) %]patternneedtobetested=1[% END %] Shouldn't it be (with ;): [% IF ( irregularity ) %]patternneedtobetested=1;[% END %] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:40:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:40:42 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15656 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 [Bug 15656] Move the guarantor/guarantees code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:40:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:40:42 +0000 Subject: [Koha-bugs] [Bug 15656] New: Move the guarantor/guarantees code to Koha::Patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 Bug ID: 15656 Summary: Move the guarantor/guarantees code to Koha::Patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 15548, 15653 Blocks: 15449 2 subroutines of C4::Members deal with guarantor/guarantees: GetGuarantees and GetMemberRelatives. Since we already have a Koha::Patron->guarantor method, it makes sense to move these 2 subroutines to this module. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 [Bug 15548] New patron related code should have been put to Patron instead of Borrower http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15653 [Bug 15653] Updating a guarantor has never updated its guarantees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:40:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:40:42 +0000 Subject: [Koha-bugs] [Bug 15653] Updating a guarantor has never updated its guarantees In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15653 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15656 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 [Bug 15656] Move the guarantor/guarantees code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:40:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:40:42 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15656 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 [Bug 15656] Move the guarantor/guarantees code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:56:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:56:26 +0000 Subject: [Koha-bugs] [Bug 15656] Move the guarantor/guarantees code to Koha::Patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:56:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:56:28 +0000 Subject: [Koha-bugs] [Bug 15656] Move the guarantor/guarantees code to Koha::Patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 --- Comment #1 from Jonathan Druart --- Created attachment 47267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47267&action=edit Bug 15656: Move guarantor/guarantees code - GetGuarantees 2 subroutines of C4::Members deal with guarantor/guarantees: GetGuarantees and GetMemberRelatives. Since we already have a Koha::Patron->guarantor method, it makes sense to move these 2 subroutines to this module. This first patch deals with GetGuarantees. Test plan for the entire patch set: 1/ Create 5 patrons A (adult), B (child), C (child), D (child), E (child), F (adult) 2/ Add relation between them: A is father of B, C and D. E does not have a guarantor F does not have guarantees 3/ Check some items out for all of these patrons 4/ On the "Check out" and "Details" tabs, you should not see any differences with these patch applied : The "Relatives' checkouts" tabs should list all of the guarantor/guarantee/siblings checkouts Note: $template->param('C' => 1); I have not found any reference of this 'C' in the template. It seems it's an old c/p from members/memberentrygen.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:56:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:56:31 +0000 Subject: [Koha-bugs] [Bug 15656] Move the guarantor/guarantees code to Koha::Patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 --- Comment #2 from Jonathan Druart --- Created attachment 47268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47268&action=edit Bug 15656: Move guarantor/guarantees code - GetMemberRelatives Note: QA question: Does the Koha::Patron->siblings method should return undef if there is no guarantor? It would avoid the weird != undef, = $borrowernumber conditions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 16:59:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 15:59:35 +0000 Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:09:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:09:43 +0000 Subject: [Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 --- Comment #9 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #8) > Isn't this line problematic? > > [% IF ( irregularity ) %]patternneedtobetested=1[% END %] > > Shouldn't it be (with ;): > > [% IF ( irregularity ) %]patternneedtobetested=1;[% END %] I have just tested: no JS error with irregularities. But it's obviously an error, must be fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:20:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:20:03 +0000 Subject: [Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 --- Comment #10 from Koha Team Lyon 3 --- Arghhh! you are right, I will post a follow-up Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:21:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:21:15 +0000 Subject: [Koha-bugs] [Bug 15657] New: follow-up for bug 15501 : add a missing semi-colon Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15657 Bug ID: 15657 Summary: follow-up for bug 15501 : add a missing semi-colon Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:24:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:24:54 +0000 Subject: [Koha-bugs] [Bug 15657] follow-up for bug 15501 : add a missing semi-colon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15657 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 --- Created attachment 47269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47269&action=edit Bug 15657 (follow-up bug 15501) : add a missing semi-colon -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:25:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:25:21 +0000 Subject: [Koha-bugs] [Bug 15367] Batch patron modification: Data loss with multiple repeatable patron attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15367 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:25:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:25:32 +0000 Subject: [Koha-bugs] [Bug 15657] follow-up for bug 15501 : add a missing semi-colon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15657 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:25:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:25:55 +0000 Subject: [Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #10 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:26:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:26:42 +0000 Subject: [Koha-bugs] [Bug 15579] records_batchmod permission doesn't allow access to batch modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:27:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:27:01 +0000 Subject: [Koha-bugs] [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 --- Comment #10 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:27:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:27:17 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 --- Comment #22 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:27:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:27:31 +0000 Subject: [Koha-bugs] [Bug 15560] Multiple holding branchs and locations not displaying in pending holds report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #10 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:27:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:27:47 +0000 Subject: [Koha-bugs] [Bug 15570] circ/renew.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15570 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #10 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:28:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:28:00 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #9 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:28:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:28:17 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can't tab to select link in budgets add user popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #11 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:28:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:28:34 +0000 Subject: [Koha-bugs] [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #10 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:28:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:28:52 +0000 Subject: [Koha-bugs] [Bug 14538] POD for CalcFine is incomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14538 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:29:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:29:09 +0000 Subject: [Koha-bugs] [Bug 14613] Send cart window is too small in staff and hides 'send' button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14613 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:29:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:29:25 +0000 Subject: [Koha-bugs] [Bug 15606] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15606 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #6 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:29:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:29:36 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can't tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #9 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:30:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:30:40 +0000 Subject: [Koha-bugs] [Bug 15070] Update MARC21 it-IT frameworks to Update 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15070 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:45:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:45:16 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46736|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 47270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47270&action=edit Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page Currently if not logged in when browsing to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl You are redirected to opac-auth.pl and SCOUserCSS and SCOUserJS are not loaded. This patch adds new opac-auth.tt file for authenticating SCO users which loads these files and redirects a login to the SCO module instead of the patron account Common code between opac-auth and sco-auth is mostly alternate login info and has been move to alt-auth.inc To test: 1 - Verify that normal login works on both staff and opac 2 - Verify that SCO login goes to a new page 3 - Enter changes into SCOUserJS and SCOUserCSS and observe these are present on SOC log in page 4 - Verify that a logged in opac user without permissions cannot access the self-checkout module 5 - Verify that AutoSelfCheckAllowed and associated system preferences function as expected 6 - Verify the AutoSelfCheck user is logged out if they attempt to visit another page Bonus points for verifying all alternate methonds of login function as expected Sponsored by Northeast Kansas Libary System (NEKLS) www.nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:47:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:47:25 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #4 from Nick Clemens --- (In reply to M. Tompsett from comment #2) > There is no need to pass system preferences. Use Koha.Preference calls in > the Template Toolkit files. Fixed the calls I added, thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:48:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:48:51 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 --- Comment #5 from Marc V?ron --- Created attachment 47271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47271&action=edit 14930 - Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature To Test - Borrower has some fines and checkouts - Leave OPACFineNoRenewals empty/blank - Try to renew items in the OPAC - notice error message - Add a big value to OpacFineNoRenewals - notice renewals work Leaving the OPACFineNoRenewals empty will disable the feature. Patch works as expected.(Amended to format the commit message and to remove a warn on line 112 / MV) Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:49:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:49:10 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #46845|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:49:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:49:49 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:56:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:56:51 +0000 Subject: [Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15657 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 17:56:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 16:56:51 +0000 Subject: [Koha-bugs] [Bug 15657] follow-up for bug 15501 : add a missing semi-colon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15657 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15501 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 18:35:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 17:35:11 +0000 Subject: [Koha-bugs] [Bug 13474] Untranslatable log actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47073|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 47272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47272&action=edit Bug 13474: Adding untranslatable log actions to viewlog.tt Added 'Run' Signed-off-by: Aleisha (Amended to remove tab chars to make qa tools happy) Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 18:35:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 17:35:48 +0000 Subject: [Koha-bugs] [Bug 13474] Untranslatable log actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 18:42:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 17:42:41 +0000 Subject: [Koha-bugs] [Bug 15658] New: Browse system logs: Add more actions to action filter list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15658 Bug ID: 15658 Summary: Browse system logs: Add more actions to action filter list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org The following actions are missing in the action filter list on cgi-bin/koha/tools/viewlog.pl: 'ADDCIRCMESSAGE' 'CHANGE PASS' 'DELCIRCMESSAGE' 'RENEW' 'Run' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 18:43:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 17:43:54 +0000 Subject: [Koha-bugs] [Bug 15658] Browse system logs: Add more actions to action filter list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15658 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Depends on| |13474 Assignee|gmcharlt at gmail.com |veron at veron.ch Status|NEW |ASSIGNED Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 [Bug 13474] Untranslatable log actions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 18:43:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 17:43:54 +0000 Subject: [Koha-bugs] [Bug 13474] Untranslatable log actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15658 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15658 [Bug 15658] Browse system logs: Add more actions to action filter list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 18:50:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 17:50:41 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #5 from M. Tompsett --- Comment on attachment 47125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47125 Bug 15635: Koha::Patron::Images - Remove RmPatronImage Review of attachment 47125: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15635&attachment=47125) ----------------------------------------------------------------- ::: tools/picture-upload.pl @@ +163,5 @@ > + my $deleted = eval { > + Koha::Patron::Images->find( $borrowernumber )->delete; > + }; > + if ( $@ or not $deleted ) { > + warn "Image for patron '$borrowernumber' has not been deleted"; Should we not distinguish between $@ and not $deleted? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 18:57:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 17:57:47 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #6 from M. Tompsett --- Comment on attachment 47126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47126 Bug 15635: Koha::Patron::Images - Remove GetPatronImage Review of attachment 47126: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15635&attachment=47126) ----------------------------------------------------------------- ::: opac/opac-memberentry.pl @@ +232,5 @@ > ); > > if (C4::Context->preference('OPACpatronimages')) { > + my $patron_image = Koha::Patron::Images->find($borrower->{borrowernumber}); > + $template->param( display_patron_image => 1 ) if $patron_image; After this many changes, I can understand a cut-and-paste mentality. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 19:05:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 18:05:50 +0000 Subject: [Koha-bugs] [Bug 15658] Browse system logs: Add more actions to action filter list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15658 --- Comment #1 from Marc V?ron --- Created attachment 47273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47273&action=edit Bug 15658: Browse system logs: Add more actions to action filter list The following actions were missing in the action filter list on cgi-bin/koha/tools/viewlog.pl: 'ADDCIRCMESSAGE' 'CHANGE PASS' 'DELCIRCMESSAGE' 'RENEW' 'Run' To test: - Apply patch - Go to Tools > Logs (viewlog.pl) - Verify that the actions appear in the list 'Actions' - Verify that the new entries filter the list as appropriate (in combination with Modules: All or with a meaningful selection in list 'Modules') Note for testing: You have to set a date in 'Display from' to get results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 19:06:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 18:06:35 +0000 Subject: [Koha-bugs] [Bug 15658] Browse system logs: Add more actions to action filter list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15658 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 19:36:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 18:36:45 +0000 Subject: [Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This bug appears only in |This bug appears only in release notes|3.20.7 version and is very |3.20.7 version and is very |visible (or invisible) and |visible (or invisible) and |disturbing. It has been |disturbing. It has been |discussed several times on |discussed several times on |Koha mailing list: after a |Koha mailing list: after a |package upgrade to the 3.20 |package upgrade to the 3.20 |branch last version, the |branch last version, the |check-out screen doesn't |check-out screen doesn't |display anymore the |display anymore the | |check-out items table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 19:37:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 18:37:42 +0000 Subject: [Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This bug appears only in |This bug appears only in release notes|3.20.7 version and is very |3.20.7 version and is very |visible (or invisible) and |visible and disturbing. It |disturbing. It has been |has been discussed on Koha |discussed several times on |mailing list: after a |Koha mailing list: after a |package upgrade, the |package upgrade to the 3.20 |check-out screen doesn't |branch last version, the |display anymore the |check-out screen doesn't |checkout items table. |display anymore the | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 19:40:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 18:40:46 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|If a record has more than |If a record has more than release notes|20 items, all the items |20 items, all the items |over 20 will show as |over 20 will show as |available on the search |available on the search |results even if they are |results even if they are |not! This is a hard coded |not! This is a hard coded |limit in the Search module. |limit in the Search module. |This number should is made |This number is made |configurable with the new |configurable with the new |system preference |system preference |MaxSearchR |MaxSearchResultsItemsPerRec | |ordStatusCheck. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 19:41:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 18:41:38 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|If a record has more than |If a record has more than release notes|20 items, all the items |20 items, all the items |over 20 will show as |over 20 will show as |available on the search |available on results even |results even if they are |if they are not! This is a |not! This is a hard coded |hard coded limit in the |limit in the Search module. |Search module. This is made |This number is made |configurable with the new |configurable with the new |system preference |system preference |MaxSearchResultsItemsPerRec |MaxSearchResultsI |ordStatusCheck. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 19:48:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 18:48:23 +0000 Subject: [Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47067|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 47274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47274&action=edit Bug 15564 - Display "print slip" option when returning an item which is in a rotating collection To Test - 1. Make a new rotating collection (under tools) with at least one book in it. 2. Check out the book/s from rotating collection. 3. Set library to a different library. 4. Check in book you just checked out. 5. Should show a dialog box with no print slip link or city. 6. Apply patch and repeat steps 1-4. Dialog box should now show the item name, city name and print slip link. Patch works as expected. (Superfluous white space removed on line 136) Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 19:49:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 18:49:09 +0000 Subject: [Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 19:56:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 18:56:50 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47048|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 47275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47275&action=edit 14647 - Make the file name extension dynamic on exporting records Test - 1. go to cgi-bin/koha/tools/export.pl 2. Check that both tabs ("Export bibliographic records & Rxport authority records") do the following 3. In Output format 4. When changing "File format" from dropdown it update "file name" 5. Still works with user inputted names Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 19:57:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 18:57:10 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 19:59:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 18:59:11 +0000 Subject: [Koha-bugs] [Bug 15659] New: See total of child accounts Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15659 Bug ID: 15659 Summary: See total of child accounts Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jweaver at bywatersolutions.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Add a new column to the Acquisition home table that includes the total of child accounts (like the Funds page) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 19:59:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 18:59:49 +0000 Subject: [Koha-bugs] [Bug 15660] New: prevent sharing budgets Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15660 Bug ID: 15660 Summary: prevent sharing budgets Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jweaver at bywatersolutions.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org * Prevent each library from seeing the budgets/funds of all other libraries * Modify C4::Budgets::GetBudgets to only select budgets for the logged in library unless the logged in user is a superlibrarian * Ensure the same checks are added to other budget modifying / using subroutines as needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 20:13:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 19:13:33 +0000 Subject: [Koha-bugs] [Bug 15661] New: Serials related pages miss a checkin tab Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15661 Bug ID: 15661 Summary: Serials related pages miss a checkin tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org To verify: Go to cgi-bin/koha/serials/serials-home.pl. Verify that the header has following tabs only: Search subscriptions / Check out / Search the catalog and that a checkin tab is missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 20:13:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 19:13:53 +0000 Subject: [Koha-bugs] [Bug 15661] Serials related pages miss a checkin tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15661 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12051 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 20:13:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 19:13:53 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15661 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 20:19:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 19:19:03 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46847|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 47276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47276&action=edit Bug 12051: Adds a Renew tab to the staff client To test: 1) Apply patch 2) Confirm that there is now a Renew tab on every page 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 20:19:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 19:19:35 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 20:29:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 19:29:57 +0000 Subject: [Koha-bugs] [Bug 15311] Let libraries set text to display when OpacMaintenance = on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #8 from Marc V?ron --- (In reply to Aleisha Amohia from comment #7) > CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl I think that the part in /installer/data/mysql/updatedatabase.pl should go to an atomic update, see: http://wiki.koha-community.org/wiki/Database_updates#updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 20:43:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 19:43:56 +0000 Subject: [Koha-bugs] [Bug 15009] Planning dropdown button in aqbudget can have empty line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com Status|Failed QA |Needs Signoff --- Comment #4 from Charles Farmer --- (In reply to Katrin Fischer from comment #3) > This removes the empty entry and the test plan for this works. But under > which conditions would the entry show up again? > Since the sort categories can be different for each fund I wonder if this > can work. Can you please take a look? >From a quick search for C4::Budgets::GetBudgetAuthCats, these values are only used in the 'Planning' button of the acquisition module. They don't seem to show up anywhere else. Even if the sort categories are different from a budget to another, additional statistics on a budget do show up in the 'Planning' button, which is the desired behaviour. For example, if I had the statistic 'CCODE' to my fund, the option shows up after the patch. Does it answer your question? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 20:50:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 19:50:35 +0000 Subject: [Koha-bugs] [Bug 15657] follow-up for bug 15501 : add a missing semi-colon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15657 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 20:50:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 19:50:37 +0000 Subject: [Koha-bugs] [Bug 15657] follow-up for bug 15501 : add a missing semi-colon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15657 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47269|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47277&action=edit [SIGNED-OFF]Bug 15657 (follow-up bug 15501): add missing semi-colon Signed-off-by: Hector Castro The semicolon it's added -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 21:05:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 20:05:52 +0000 Subject: [Koha-bugs] [Bug 15155] Can't call method "truncate" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 1966 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15155 Heinrich Hartl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Heinrich.Hartl at email.de --- Comment #5 from Heinrich Hartl --- I am also getting that error: /usr/share/koha/lib/C4/Circulation.pm line 1966. After reading your questions we ran a report on our users and found that a group of users has the value 0000-00-00 in column debarred and apparently is haunted by above error when returning items. cardnumber;borrowernumber;surname;firstname;debarred 1;1;Admin;Koha; 23529001223637;51;Lanz;Stefan; 23529001223638;52;Pelosi;Silvia; ... P2304-20150001;57;Landwehr;"Mara ";0000-00-00 P2304-20150002;58;Petry;Margit;0000-00-00 P2304-20150003;59;Friedrich-Sander;Heide;0000-00-00 ... That group may be a set of users that were imported in 2015 under then 3.18. But I am not sure about this. The error message pops up when such users return items. Unfortunately I do not know how to correct the situation, how to reset the values of debarred in table Table testsql_comments.borrowers (assuming this is the value causing the trouble) debarred date 10 ? null until this date the patron can only check-in (no loans, no holds, etc.), is a fine based on days instead of money (YYY-MM-DD) If I try to manually correct the debarred date I can not find a menue to do so. Editing the patron attributes the attributes in this koha version (3.20.00.000) do not include the debarred date. The koha manual is not helpful. I have never before operated directly on the mysql database, I only ran reports sofar. Since I have 186 occurrences of debarred = 0000-00-00 A script would be helpful. I am also ignorant if it is ok to adjust the debarred value and not to make other corrections to maintain consistency. Here are my lines from sudo vi /usr/share/koha/lib/C4/Circulation.pm 1965 my $borrower_debar_dt = dt_from_string( $borrower->{debarred} ); 1966 $borrower_debar_dt->truncate(to => 'day'); 1967 my $today_dt = $today->clone()->truncate(to => 'day'); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 21:11:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 20:11:40 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Wendy Sharkey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catalog at bfli.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 21:19:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 20:19:40 +0000 Subject: [Koha-bugs] [Bug 15660] prevent sharing budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hm, will this be optional? How is the owner of a budget determined? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 21:21:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 20:21:10 +0000 Subject: [Koha-bugs] [Bug 15661] Serials related pages miss a checkin tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15661 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think this might have been intentional as 4 options take up more space. I think it used to be only 3 tabs per page, but now sometimes there are more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 21:22:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 20:22:03 +0000 Subject: [Koha-bugs] [Bug 15658] Browse system logs: Add more actions to action filter list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15658 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 21:22:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 20:22:05 +0000 Subject: [Koha-bugs] [Bug 15658] Browse system logs: Add more actions to action filter list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15658 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47273|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47278&action=edit [SIGNED-OFF]Bug 15658: Browse system logs: Add more actions to action filter list The following actions were missing in the action filter list on cgi-bin/koha/tools/viewlog.pl: 'ADDCIRCMESSAGE' 'CHANGE PASS' 'DELCIRCMESSAGE' 'RENEW' 'Run' To test: - Apply patch - Go to Tools > Logs (viewlog.pl) - Verify that the actions appear in the list 'Actions' - Verify that the new entries filter the list as appropriate (in combination with Modules: All or with a meaningful selection in list 'Modules') Note for testing: You have to set a date in 'Display from' to get results Signed-off-by: Hector Castro Logs work as advertised, translated in bug 13474 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 21:24:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 20:24:45 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org --- Comment #3 from Katrin Fischer --- I am not sure about adding the same tabs everywhere - it might get a bit crowded up there. Renew doesn't seem to be used very often as it requires you to have the items on hand to scan the barcodes. Hm, adding Owen for another opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 21:24:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 20:24:50 +0000 Subject: [Koha-bugs] [Bug 15658] Browse system logs: Add more actions to action filter list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15658 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com, | |hector.hecaxmmx at gmail.com, | |mtompset at hotmail.com, | |pasi.kallinen at pttk.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 21:25:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 20:25:07 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #42 from Charles Farmer --- (In reply to Jonathan Druart from comment #41) > (In reply to Kyle M Hall from comment #40) > > Pushed to master, thanks Philippe! > > Please regenerate the Schema files, some tests are failing. Which tests? I ran update_dbix_class_files.pl and nothing changed in my index... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 21:43:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 20:43:22 +0000 Subject: [Koha-bugs] [Bug 9525] group floating rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #17 from Nicole C. Engard --- 40077 - Bug 9525 - group floating rules 44756 - Bug 9525 - group floating rules, floating rule tester :) 44760 - Bug 9525 - group floating rules, CGI doesn't understand DELETE at all. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 9525 - group floating rules fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9525 - group floating rules When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-9525---group-floating-rules-MxbdS8.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 21:47:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 20:47:11 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47076|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 47279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47279&action=edit 15067 - Add additional languages to advanced search language search run update database script, look for new laguages under 'Language:' in Advanced search. Languages that should be added are: 1. Estonian 2. Latvian 3. Lithuanian 4. Inuktitut 5. Inupiaq Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 21:49:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 20:49:22 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 --- Comment #6 from Nick Clemens --- Created attachment 47280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47280&action=edit Bug 15067 - Follow up to fix sorting It looks like C4::Languages:getLanguages relies on implicit database order for languages. They appear to be sorted by subtag so this patch adds that sorting to the database query to ensure the dropdown is sorted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 22:23:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 21:23:49 +0000 Subject: [Koha-bugs] [Bug 15351] RDA fields in Authority Frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15351 --- Comment #2 from Nicole C. Engard --- The link works for me. Can someone else take a look? Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 22:25:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 21:25:33 +0000 Subject: [Koha-bugs] [Bug 6420] in house use checkouts should check for circ statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6420 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Nicole C. Engard --- This is so so old I have no idea what I meant. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 22:26:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 21:26:08 +0000 Subject: [Koha-bugs] [Bug 8751] printable version of holds queue printing different pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8751 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 22:26:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 21:26:50 +0000 Subject: [Koha-bugs] [Bug 9198] total holds in opac doesn't stand out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9198 --- Comment #2 from Nicole C. Engard --- Yes. But I do use CSS on my sites to make it stand out - I guess everyone can do that too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 22:27:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 21:27:21 +0000 Subject: [Koha-bugs] [Bug 4230] new icon for move to lowest priority on holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4230 --- Comment #3 from Nicole C. Engard --- Yes. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 22:27:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 21:27:34 +0000 Subject: [Koha-bugs] [Bug 9543] show if holds email is subscribed on holds notification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #2 from Nicole C. Engard --- Yes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 22:27:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 21:27:53 +0000 Subject: [Koha-bugs] [Bug 4012] Can't place hold on specific copy if selecting more than 1 title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4012 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 22:28:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 21:28:54 +0000 Subject: [Koha-bugs] [Bug 10616] hold warning needs design work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10616 --- Comment #4 from Nicole C. Engard --- Yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 22:32:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 21:32:36 +0000 Subject: [Koha-bugs] [Bug 14251] style discharge letter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #2 from Nicole C. Engard --- I don't think so. That's why my report. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 22:33:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 21:33:32 +0000 Subject: [Koha-bugs] [Bug 15351] RDA fields in Authority Frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15351 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- Hi Nicole, I really think this bug is resolved fixed already - MARC frameworks should be up to date with the standard atm. But the link really does not work from here. For whatever reason, the site seems unreachable from... Germany? Works for rangi, not for drojf and me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 22:36:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 21:36:57 +0000 Subject: [Koha-bugs] [Bug 12146] Add new ISO code column to currency sample files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 22:37:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 21:37:00 +0000 Subject: [Koha-bugs] [Bug 12146] Add new ISO code column to currency sample files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39020|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 47281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47281&action=edit Bug 12146 [ENH] Add isocode column to parameters.sql a) Adds currency.isocode column to parameters.sql b) Introduces INR as an option for Koha's EN installation locale in the list of currencies Remarks: The issue of non-mandatory nature of isocode column is already settled via bug 9593, comment 77. Test Plan ========= 1/ create a fresh Koha instance and run the web installer 2/ at step #3 - "Selecting Default Settings", select "Some basic currencies with USA dollar as default for ACQ module" under the section "Optional" to import the sample currencies. 3/ login to this new instance and go to Home -> Administration -> Currencies & Exchange rates 4/ click edit for any of the currency options 5/ ISO code will be blank 6/ Apply patch 7/ Repeat steps 1 to 4 above 8/ ISO code will now show 3-letter ISO codes inserted by patched parameters.sql Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 22:59:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 21:59:16 +0000 Subject: [Koha-bugs] [Bug 15311] Let libraries set text to display when OpacMaintenance = on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Aleisha Amohia --- Will set to Failed QA until the move to an atomic update is made. Set back to Needs Signoff when that's done so I can come test it again :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 23:00:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 22:00:42 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 --- Comment #4 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #3) > I am not sure about adding the same tabs everywhere - it might get a bit > crowded up there. Renew doesn't seem to be used very often as it requires > you to have the items on hand to scan the barcodes. > > Hm, adding Owen for another opinion. I see what you mean. Perhaps only on the pages where there is also a check-in tab? Since they also need the barcode for that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 23:03:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 22:03:50 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 --- Comment #9 from Aleisha Amohia --- My entire reason for this patch was that some of the links had title tags and some didn't on circulation-home.tt. I thought adding titles to all of them would add consistency and maybe be more semantically correct. I do understand if you don't see the point of this patch, but the point was, if we have it for some of them we should have it for all of them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 23:06:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 22:06:31 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 --- Comment #22 from Aleisha Amohia --- (In reply to M. Tompsett from comment #19) > Comment on attachment 47147 [details] [review] > Bug 15618: Typos fixed in enhanced_content.pref > > Review of attachment 47147 [details] [review]: > ----------------------------------------------------------------- > > ::: > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content. > pref > @@ +182,4 @@ > > choices: > > yes: Use > > no: "Don't use" > > + - content from Syndetics. Note that this requires that you have signed up for the service and entered in your client code above. > > Line 187 and 188 visible in this patch make it look like below is correct. I will attach a screenshot that shows the order of the sysprefs for me and the reason I changed it to above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 23:07:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 22:07:02 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 --- Comment #23 from Aleisha Amohia --- Created attachment 47282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47282&action=edit Order of Syndetics sysprefs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 23:14:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 22:14:11 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 --- Comment #24 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #21) > > @@ +278,4 @@ > > > - > > > - "Restrict patrons with the following target audience values from checking out inappropriate materials:" > > > - pref: AgeRestrictionMarker > > > + - "E.g. Enter target audience keyword(s) split by | (pipe) FSK|PEGI|Age| (No white space near |). Be sure to map agerestriction in Koha to MARC mapping (e.g. 521$a). A MARC field value of FSK 12 or PEGI 12 would mean: 'Borrower must be 12 years old'. Leave empty to not apply an age restriction." > > > > I was noticing 856u in another patch on this bug report. Are we doing 856u > > or 856$u? We have 521$a here. Should it be 521a? > > I think 521$u makes sense, if we have other cases without $ we could fix > them separately. I think some options require you to enter without $, so > have to be careful fixing. > I can find which patch you said had the 856u and change that to 856$u if that is the preferred format. > > > > @@ -365,5 @@ > > > choices: > > > - confirm: "require confirmation" > > > - alert: "display a message" > > > - nothing : "do nothing" > > > - - . > > > > I like this '.' removal and placing at the end of the strings. > > The extra . at the end creates a separate string in the translation files > and is a little advantage for translations. Because it's not always easy to > built a grammatically correct sentence that has the options at the end, this > extra string for the . allows to split the sentence up and have some words > after the option list - not sure if I used it here, but I did in some other > cases. > Sorry I'm not sure if I understand, so you'd like the full stop in a separate string like it was before I changed it? To me it just looked strange to have a full stop lingering on the end, but if it is better for translation to have it the way it was before then it'll need to be changed in more places than just my patches. > > > > @@ +523,5 @@ > > > - pref: emailLibrarianWhenHoldIsPlaced > > > choices: > > > + yes: Do > > > + no: "Don't" > > > + - "send an email to the Koha administrator email address whenever a hold request is placed." > > > > "Send" "Don't send"? I don't see why this change is necessary. > > I think the change makes it a bit easier to read. Before it said 'Enable / Don't enable sending an email' which I thought could be made simpler with 'Do / Don't send'. However 'Send / Don't send' is basically a shortcut of that too so I can make that change if you'd both like. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 23:24:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 22:24:40 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #176 from Mirko Tietgen --- Created attachment 47283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47283&action=edit BUG 6473 test hmpf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 23:26:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 22:26:13 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #177 from Mirko Tietgen --- Created attachment 47284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47284&action=edit HAHAHA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 25 23:58:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jan 2016 22:58:17 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #4 from Aleisha Amohia --- I don't think this is valid anymore - I am unable to type anything once the card number has reached 16 characters in the input box. Please confirm if this is still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 02:03:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 01:03:33 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 02:03:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 01:03:37 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 --- Comment #7 from Aleisha Amohia --- Created attachment 47285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47285&action=edit [SIGNED-OFF] Bug 15067 - Follow up to fix sorting It looks like C4::Languages:getLanguages relies on implicit database order for languages. They appear to be sorted by subtag so this patch adds that sorting to the database query to ensure the dropdown is sorted. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 02:05:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 01:05:28 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47279|0 |1 is obsolete| | Attachment #47280|0 |1 is obsolete| | Attachment #47285|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia --- Created attachment 47286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47286&action=edit [SIGNED-OFF] 15067 - Add additional languages to advanced search language search run update database script, look for new laguages under 'Language:' in Advanced search. Languages that should be added are: 1. Estonian 2. Latvian 3. Lithuanian 4. Inuktitut 5. Inupiaq Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 02:05:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 01:05:40 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 --- Comment #9 from Aleisha Amohia --- Created attachment 47287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47287&action=edit [SIGNED-OFF] Bug 15067 - Follow up to fix sorting It looks like C4::Languages:getLanguages relies on implicit database order for languages. They appear to be sorted by subtag so this patch adds that sorting to the database query to ensure the dropdown is sorted. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 02:09:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 01:09:57 +0000 Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |aleishaamohia at hotmail.com --- Comment #11 from Aleisha Amohia --- Applying: Bug 14698 - AtomicUpdater - Keeps track of which updates have been applied to a database /home/vagrant/kohaclone/.git/rebase-apply/patch:156: trailing whitespace. /home/vagrant/kohaclone/.git/rebase-apply/patch:493: trailing whitespace. /home/vagrant/kohaclone/.git/rebase-apply/patch:682: trailing whitespace. GetOptions( /home/vagrant/kohaclone/.git/rebase-apply/patch:765: trailing whitespace. fatal: sha1 information is lacking or useless (C4/Installer/PerlDependencies.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 14698 - AtomicUpdater - Keeps track of which updates have been applied to a database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 02:20:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 01:20:29 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 02:20:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 01:20:34 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47239|0 |1 is obsolete| | Attachment #47240|0 |1 is obsolete| | Attachment #47242|0 |1 is obsolete| | --- Comment #27 from Aleisha Amohia --- Created attachment 47288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47288&action=edit [SIGNED-OFF] Bug 11573 - Make fine display more consistent for rentals To test: 1. Set up an item type with a rental charge 2. issue an item from that item type 3. Check fines - the rental charge does not show the title of the issued item 4. Renew that item, the renewal charge does show the title of the issued item 5. Apply the patch 6. Repeat steps 1-4, both should show the title of the issued item in the description. This change is proposed in order to get rid of some double ups in the title on the boraccount template. Signed-off-by: Katrin Fischer Tested with rental lines created before and after applying the patch. After applying the patch it's better, but old lines will still look ok. There is still a double up on the title on the 'pay' tab, as we get the title from the itemnumber and also display the description. I think getting all the information from the itemnumber for display would be a bit nicer in the future. Butthis is an improvement. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 02:21:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 01:21:05 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47288|0 |1 is obsolete| | --- Comment #28 from Aleisha Amohia --- Created attachment 47289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47289&action=edit [SIGNED-OFF] Bug 11573 - Make fine display more consistent for rentals To test: 1. Set up an item type with a rental charge 2. issue an item from that item type 3. Check fines - the rental charge does not show the title of the issued item 4. Renew that item, the renewal charge does show the title of the issued item 5. Apply the patch 6. Repeat steps 1-4, both should show the title of the issued item in the description. This change is proposed in order to get rid of some double ups in the title on the boraccount template. Signed-off-by: Katrin Fischer Tested with rental lines created before and after applying the patch. After applying the patch it's better, but old lines will still look ok. There is still a double up on the title on the 'pay' tab, as we get the title from the itemnumber and also display the description. I think getting all the information from the itemnumber for display would be a bit nicer in the future. Butthis is an improvement. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 02:21:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 01:21:16 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #29 from Aleisha Amohia --- Created attachment 47290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47290&action=edit [SIGNED-OFF] Bug 11573 - removing title double ups on boraccount.tt To test: 1. Create a bunch of fines (or view your existing fines data) - it should have lost entries, rentals, rental renewals, and regular fines and fine updates. 2. View the fines tab for your borrower with fines 3. without the patch, it will look like the submitted screenshot 4. with the patch, there will be few, if any, doubleups of title This patch may be incomplete - there may be cases that still need work. I'm happy to do followups. Rental fees and rental renewals will not look wholly consistent without the other attached patch, but this one does not require it. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 02:21:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 01:21:30 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #30 from Aleisha Amohia --- Created attachment 47291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47291&action=edit [SIGNED-OFF] Bug 11573: Follow-up: Include changes in OPAC templates Patch adds changes from earlier patches to OPAC prog and bootstrap templates. Patch radds a description for FU - Accrued fine. Removes a stray space before the comma, using some TT magic. To test: - Test like the other patch, display in OPAC prog, OPAC bootstrap, Staff Pay fines tab and Staff Accounts tab should be the same. - No ' , ' should be seen. - FU fines should now display a description. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 02:32:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 01:32:06 +0000 Subject: [Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #5 from Aleisha Amohia --- Is this ready for testing? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 02:55:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 01:55:55 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #12 from Mason James --- (In reply to Tom?s Cohen Arazi from comment #11) > Created attachment 47117 [details] [review] > Bug 14532: (followup) Use tar's --exclude for simplicity > > This patch creates an --exclude definition for the tar command > so it is easier to stack excluded stuff. It does so for the > authority and biblio indexes if --exclude-indexes is passed. > > A side effect from this, is that uploads and plugins are still > backed up, as Jonathan noted. > > Regards Hi folks, can this be switched to 'sign-off' now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 03:12:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 02:12:30 +0000 Subject: [Koha-bugs] [Bug 15662] New: String and translatability fix to Label Creator Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 Bug ID: 15662 Summary: String and translatability fix to Label Creator Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org 1) "Please select at least label to delete" - missing a word 2) [% duplicate_count %] duplicate item(s) found and removed from batch [% batch_id %] - split string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 03:15:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 02:15:15 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 03:15:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 02:15:18 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 --- Comment #1 from Aleisha Amohia --- Created attachment 47292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47292&action=edit Bug 15662: String and translatability fix to Label Creator To test: 1) Go to Tools -> Label Creator -> New label batch 2) Add an item 3) Click 'Remove selected items' button. Confirm message now reads "Please select at least one label to delete." 4) Click 'Remove duplicates' button. Confirm message now reads "Duplicate item(s) removed from batch number X: Y", all in bold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 03:18:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 02:18:00 +0000 Subject: [Koha-bugs] [Bug 15663] New: Can't delete label from checkbox Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 Bug ID: 15663 Summary: Can't delete label from checkbox Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: 1) Go to Tools -> Label creator -> New label batch 2) Add an item 3) Select the checkbox next to the item you just added and click 'Remove selected items' 4) A pop-up will say that you are yet to select an item - this is a bug. (I am aware of the missing word in the pop-up message, which has been fixed in Bug 15662). Setting severity to normal because it blocks the use of this button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 03:29:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 02:29:31 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 --- Comment #13 from Tom?s Cohen Arazi --- (In reply to Mason James from comment #12) > (In reply to Tom?s Cohen Arazi from comment #11) > > Created attachment 47117 [details] [review] [review] > > Bug 14532: (followup) Use tar's --exclude for simplicity > > > > This patch creates an --exclude definition for the tar command > > so it is easier to stack excluded stuff. It does so for the > > authority and biblio indexes if --exclude-indexes is passed. > > > > A side effect from this, is that uploads and plugins are still > > backed up, as Jonathan noted. > > > > Regards > > Hi folks, can this be switched to 'sign-off' now? Mason, when I was double-checking my followup, I figured it was not excluding things (using the same construct that worked on command-line), so i obsoleted it to avoid confusion, because I was leaving the office and wasn't sure when I was getting back to this. It is probably some typo from me, just didn't have the time that day. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 04:02:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 03:02:39 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 04:02:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 03:02:41 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 --- Comment #1 from Aleisha Amohia --- Created attachment 47293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47293&action=edit Bug 15663: Fix 'remove selected items', add a 'delete batch' button In this patch I have fixed the 'Remove selected items' button. I have also added a 'Delete batch' button like there is in the Patron Card Creator. To test: 1) Go to Tools -> Label creator -> New label batch 2) Add 2 items 3) Select the checkbox next to an item you just added and click 'Remove selected items' 4) A pop-up will say that you are yet to select an item. (Please ignore the mistake in the pop-up message, this is being fixed in Bug 15662) 5) Apply patch and refresh. Confirm there is now a 'Delete batch' button in the toolbar 6) Select one item and click 'Remove selected items' 7) Confirm the item is deleted from the batch 8) Select the final item and click 'Remove selected items' 9) Pop-up message will tell you that deleting this item will delete the batch. Click 'Okay' 10) Click 'Delete batch' then 'Okay' 11) Confirm you are redirected to the Labels page and the batch has been deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 04:06:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 03:06:31 +0000 Subject: [Koha-bugs] [Bug 11606] Novelist Select in Staff Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 04:08:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 03:08:14 +0000 Subject: [Koha-bugs] [Bug 10102] don't show empty novelist tab if no data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10102 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 04:10:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 03:10:18 +0000 Subject: [Koha-bugs] [Bug 15210] Novelist js throws an error if no ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15210 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 04:34:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 03:34:36 +0000 Subject: [Koha-bugs] [Bug 15580] Confirm button not visible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15580 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #3 from Aleisha Amohia --- Created attachment 47294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47294&action=edit Screenshot of my private lists This is what my confirm button looks like, and all delete functions appear to work fine for me? Version 3.23 of Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 04:59:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 03:59:47 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 05:31:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 04:31:46 +0000 Subject: [Koha-bugs] [Bug 15664] New: koha-restore: Allow database dump to be restored to another Koha instance Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15664 Bug ID: 15664 Summary: koha-restore: Allow database dump to be restored to another Koha instance Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Allow database dump to be restored to another Koha instance more info to come... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 05:32:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 04:32:35 +0000 Subject: [Koha-bugs] [Bug 15665] New: Better wording of error messages when importing MARC frameworks Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15665 Bug ID: 15665 Summary: Better wording of error messages when importing MARC frameworks Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com "Please select an spreadsheet file" - not grammatically correct "Please select an ods or xml file" - misses out CSV files, also they should either say 'ODS' or '.ods'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 05:40:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 04:40:40 +0000 Subject: [Koha-bugs] [Bug 15665] Better wording of error messages when importing MARC frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15665 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 05:40:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 04:40:43 +0000 Subject: [Koha-bugs] [Bug 15665] Better wording of error messages when importing MARC frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15665 --- Comment #1 from Aleisha Amohia --- Created attachment 47295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47295&action=edit Bug 15665: Better wording of error messages when importing MARC frameworks To test: 1) Go to Admin -> MARC frameworks 2) Click Import next to any framework. You won't actually be overwriting or importing anything as this is only a string fix, so it can be an existing framework 3) Click the Import button without attaching any file. Confirm it says "Please select a spreadsheet (.csv, .ods, .xml) file." and that this makes sense to you 4) Attempt to attach a file that is not a .csv, .ods or .xml file. You should instantly get an error message saying "Please select a CSV (.csv), ODS (.ods) or XML (.xml) file." Confirm this shows up and makes sense to you -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 05:46:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 04:46:19 +0000 Subject: [Koha-bugs] [Bug 15665] Better wording of error messages when importing MARC frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15665 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47295|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 47296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47296&action=edit Bug 15665: Better wording of error messages when importing MARC frameworks To test: 1) Go to Admin -> MARC frameworks 2) Click Import next to any framework. You won't actually be overwriting or importing anything as this is only a string fix, so it can be an existing framework 3) Click the Import button without attaching any file. Confirm it says "Please select a spreadsheet (.csv, .ods, .xml) file." and that this makes sense to you 4) Attempt to attach a file that is not a .csv, .ods or .xml file. You should instantly get an error message saying "Please select a CSV (.csv), ODS (.ods) or XML (.xml) file." Confirm this shows up and makes sense to you -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 09:12:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 08:12:42 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38032|0 |1 is obsolete| | --- Comment #13 from Julian Maurice --- Created attachment 47297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47297&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Not that subtitles are not displayed in all these cases. Note for QA: This patch refactors 3 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Not that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl 3/ Build the subject and body of the email sent Same as before, the job was done at the same places. Now it's done in Koha::Email->fill_body_for_sending (feel free to suggestion a better name) and tests are provided in t/Koha_Email.t Some tests for BuildBiblioDataForExport can fail if bug 13360 is not pushed yet. Sponsored-by: Mines Paristech Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 09:13:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 08:13:01 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #14 from Julian Maurice --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 09:13:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 08:13:19 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 09:15:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 08:15:32 +0000 Subject: [Koha-bugs] [Bug 15572] Authority creation fails when authid is linked to 001 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15572 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 09:30:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 08:30:10 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47283|0 |1 is obsolete| | Attachment #47284|0 |1 is obsolete| | --- Comment #178 from Chris Cormack --- Created attachment 47298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47298&action=edit Bug 6473 Testing https -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 09:35:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 08:35:37 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47298|0 |1 is obsolete| | --- Comment #179 from Chris Cormack --- Created attachment 47299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47299&action=edit Bug 6473 Testing https -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 10:03:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 09:03:12 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #180 from Mirko Tietgen --- Created attachment 47300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47300&action=edit HAHAHA http://bugs.koha-community.org/show_bug.cgi?id=6473 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 10:09:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 09:09:52 +0000 Subject: [Koha-bugs] [Bug 15651] Bugzilla should use https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15651 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Mirko Tietgen --- Fixed \o/ git-bz needs a new option now git config --global bz-tracker.bugs.koha-community.org.https true -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 10:50:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 09:50:53 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #47 from Alex Arnaud --- Created attachment 47301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47301&action=edit Bug 15206 - Make CalculateAge a reusable function -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 10:51:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 09:51:22 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 10:55:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 09:55:09 +0000 Subject: [Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #48 from Alex Arnaud --- (In reply to Aleisha Amohia from comment #46) > There is a GetAge function already in C4::Members which I used to write a > patch for Bug 14763. I am not saying this is a duplicate of that bug, > because I feel this is slightly different to what my patch does, but is it > possible to use that function for this? I tried to use it by making an ajax call to a perl script but response times are too long. Now CalculateAge function is quite simple and reusable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 11:10:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 10:10:55 +0000 Subject: [Koha-bugs] [Bug 4850] CheckReserves does not respect holds circulation policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850 --- Comment #7 from Koha Team Lyon 3 --- In fact, it's just a problem of settings. Filling the "Defining circulation and fine rules for all libraries" table by setting 0 in "Holds allowed" column isn't sufficient. You have to fill the "Default holds policy by item type" table (default_branch_item_rules or branch_item_rules) and then, circulation rules are respected at a itemtype level for holds. So for me, this isn't an issue anymore. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 11:49:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 10:49:16 +0000 Subject: [Koha-bugs] [Bug 15666] New: Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 Bug ID: 15666 Summary: Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: costalc at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com 1) Now, when automatic_renewals.pl tries to renew due items the sysprefs vars OverduesBlockRenewing and RestrictionBlockRenewing don't allow renewing. That's right for these sysprefs vars but not for renewing. 2) Automatic_renewals.pl should work like a user should: must renew his issues the date they due. 3) Thus automatic_renewals.pl should always avoid loans expire. So automatic_renewals.pl must consider only issues which due date is equal to the date automatic_renewals.pl is executing. 4) I think that CanBookBeRenewed in Circulation.pm must be updated but do not how... 5) In automatic_renewals.pl it is needed to change the mysql command to this one: SELECT borrowernumber, itemnumber, branchcode FROM issues WHERE auto_renew = 1 AND DATE(date_due) = DATE(NOW()) ------------------ I will attach a sample soon... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 13:22:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 12:22:46 +0000 Subject: [Koha-bugs] [Bug 15643] Every datepicker on serials expected date column updates top issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15643 --- Comment #3 from Koha Team Lyon 3 --- Created attachment 47302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47302&action=edit Bug 15643 - Every datepicker on serials expected date column updates top issue I delete the 'expected' id that was causing the initial problem and modified changeDate function to have it get targetted element by name instead. Consequently I also delete changeDate2 that seems to be redundant. Hope I didn't miss something Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 13:32:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 12:32:49 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |h.meissner.82 at web.de, | |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Bondiurbano, > 1) Now, when automatic_renewals.pl tries to renew due items the sysprefs > vars OverduesBlockRenewing and RestrictionBlockRenewing don't allow > renewing. That's right for these sysprefs vars but not for renewing. Do they only block when renewal would be blocked in the OPAC too or did the new feature break the auto renewals? > > 2) Automatic_renewals.pl should work like a user should: must renew his > issues the date they due. > > 3) Thus automatic_renewals.pl should always avoid loans expire. So > automatic_renewals.pl must consider only issues which due date is equal to > the date automatic_renewals.pl is executing. I think 2) and 3) are not how this feature is supposed to work. The automatic renewal cronjob takes the "No renewal before" value from the circulation conditions into account. So you can say: Try to renew for the first time X days before the due date. This means that you can also time a reminder notice to the same day: Try to renew 5 days before the due date - if renewal fails, the advance_notices.pl job can run after and send a reminder. If it was always the day of the due date - you couldn't send a reminder and things would go overdue immediately instead > 4) I think that CanBookBeRenewed in Circulation.pm must be updated but do > not how... Can you explain? > 5) In automatic_renewals.pl it is needed to change the mysql command to this > one: > > SELECT borrowernumber, itemnumber, branchcode FROM issues WHERE auto_renew = > 1 AND DATE(date_due) = DATE(NOW()) I disagree - see above. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 14:13:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 13:13:50 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #2 from bondiurbano --- (In reply to Katrin Fischer from comment #1) > Hi Bondiurbano, > > > 1) Now, when automatic_renewals.pl tries to renew due items the sysprefs > > vars OverduesBlockRenewing and RestrictionBlockRenewing don't allow > > renewing. That's right for these sysprefs vars but not for renewing. > > Do they only block when renewal would be blocked in the OPAC too or did the > new feature break the auto renewals? The problem occurs when OverduesBlockRenewing is set to "block". This syspref var is a recent enhancement. I agree how it works. But now they is also blocking automatic renewals and this is not correct. I think that when OverduesBlockRenewing was added as a control var in syspref nobody of us took into account this. > > > > > 2) Automatic_renewals.pl should work like a user should: must renew his > > issues the date they due. > > > > 3) Thus automatic_renewals.pl should always avoid loans expire. So > > automatic_renewals.pl must consider only issues which due date is equal to > > the date automatic_renewals.pl is executing. > > I think 2) and 3) are not how this feature is supposed to work. > The automatic renewal cronjob takes the "No renewal before" value from the > circulation conditions into account. So you can say: Try to renew for the > first time X days before the due date. This means that you can also time a > reminder notice to the same day: > Try to renew 5 days before the due date - if renewal fails, the > advance_notices.pl job can run after and send a reminder. If it was always > the day of the due date - you couldn't send a reminder and things would go > overdue immediately instead "No renewal before" is an optional setting so it could be absent in the rule. Automatic_renewals.pl must be executed BEFORE the item date_due expires. Otherwise it will be a due item and so OverduesBlockRenewing will block it. This is my point. Apart from "No renewal before" settings, automatic_renewals.pl works as a "replacement" of a manual action by a user or Staff. I'm testing now. ASAP I will attach a sample that hope helps better than my poor english... > > > 4) I think that CanBookBeRenewed in Circulation.pm must be updated but do > > not how... > > Can you explain? > > > 5) In automatic_renewals.pl it is needed to change the mysql command to this > > one: > > > > SELECT borrowernumber, itemnumber, branchcode FROM issues WHERE auto_renew = > > 1 AND DATE(date_due) = DATE(NOW()) > > I disagree - see above. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 14:23:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 13:23:33 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #3 from Katrin Fischer --- It's true that it should try before the item is due - usually. But for example this could happen: if there is a hold on the item, it will prevent renewal, the item will go overdue... the hold might be cancelled. Then you will have a renewable item that is also overdue. The Settings in the system prefrences should apply then to decide if it can be renewed or not. I think if the "No renewal before" is empty, we could agree that it should try on the due date - but witht he parameter set the behaviour should be changed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 14:58:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 13:58:31 +0000 Subject: [Koha-bugs] [Bug 15667] New: Messages in patron account display dates wrongly formatted Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15667 Bug ID: 15667 Summary: Messages in patron account display dates wrongly formatted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When you add a new message to a patron account from the 'checkouts' tab in staff, the displayed date is not correctly formatted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 14:58:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 13:58:37 +0000 Subject: [Koha-bugs] [Bug 15667] Messages in patron account display dates wrongly formatted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15667 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:00:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:00:27 +0000 Subject: [Koha-bugs] [Bug 15668] New: Add column configuration to the items table in staff detail pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668 Bug ID: 15668 Summary: Add column configuration to the items table in staff detail pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The items table in staff sometimes doesn't include all the columns a library wants and other times, libraries want columns hidden or removed. It would be nice if the column configuration options would be available for this table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:09:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:09:23 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #52 from Alex Arnaud --- Hello Kyle, Ok on the staff side (hold 3 times the same biblio with the same patron) but the code doesn't take in account reserves via ILSDI. I got the code "NotHoldable" for the second hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:09:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:09:19 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 --- Comment #11 from Paul Poulain --- Created attachment 47303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47303&action=edit BZ 7728 adding unit test test plan: * run without the patch, the test will fail * run with the patch, the test will pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:11:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:11:03 +0000 Subject: [Koha-bugs] [Bug 15669] New: alphabetize marc modification pulldowns Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 Bug ID: 15669 Summary: alphabetize marc modification pulldowns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 47304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47304&action=edit marc modification templates It would be great if all pull downs in Koha were sorted alphabetically, every pull down can get out of hand real fast. That said this report is for the pull down of Marc Modification Templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:16:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:16:43 +0000 Subject: [Koha-bugs] [Bug 15670] New: Rename "Cancel" to "Cancel hold" when checking in a waiting item Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15670 Bug ID: 15670 Summary: Rename "Cancel" to "Cancel hold" when checking in a waiting item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Bug 14464 adds a new button when checking in an item waiting on the holds shelf. The button is labelled "Cancel" and will cancel the hold when clicked. As cancel usually equates to "do nothing" this is a bit confusing, especially in translation (abbrechen vs. stornieren). I'd suggest to rename it to be more explicit: "Cancel hold". This might also avoid some unpleasant surprises :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:17:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:17:10 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 --- Comment #10 from Katrin Fischer --- We just started testing the new features of 3.22 and didn't understand that "cancel" meant cancelling the hold, as cancel usually means "do nothing". I filed bug 15670 to suggest renaming the button to the more explicit "Cancel hold" - especially since it will ease translation (abbrechen vs. stornieren in German). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:17:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:17:24 +0000 Subject: [Koha-bugs] [Bug 15670] Rename "Cancel" to "Cancel hold" when checking in a waiting item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15670 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14464 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 [Bug 14464] Add ability to cancel waiting holds from checkin screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:17:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:17:24 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15670 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15670 [Bug 15670] Rename "Cancel" to "Cancel hold" when checking in a waiting item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:17:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:17:59 +0000 Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Summary|show if holds email is |Show patrons messaging |subscribed on holds |subscription on holds |notification |notification -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:43:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:43:24 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 --- Comment #10 from H?ctor Eduardo Castro Avalos --- For(In reply to Aleisha Amohia from comment #9) > My entire reason for this patch was that some of the links had title tags > and some didn't on circulation-home.tt. I thought adding titles to all of > them would add consistency and maybe be more semantically correct. I do > understand if you don't see the point of this patch, but the point was, if > we have it for some of them we should have it for all of them. In my opinion your point of view it is Ok. If Owen give you another Ok i'll sign-off. On the contrary, we need to remove the title attribute from other links you found out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:53:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:53:56 +0000 Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #3 from Marc V?ron --- Created attachment 47305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47305&action=edit Bug 9543 - Show patrons messaging subscription on holds notification Display an information about a patron's messaging preferences if an item is checke in where the patron has put a hold. To test: - Apply patch - Make sure that SMS driver and TalkingTech sysprefs are defined to enable SMS and Phone preferences for users (SMS driver can be a dummy value) - Place a hold for a patron - Set patron's messaging preferences to different choices (including none) - Check in the item that is on hold (it has not to be checked out for the test - Verify that below the message "Hold found (item is already waiting") an information appears about the patron's messaging preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:54:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:54:20 +0000 Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:59:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:59:43 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:59:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:59:45 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47292|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47306&action=edit [SIGNED-OFF]Bug 15662: String and translatability fix to Label Creator To test: 1) Go to Tools -> Label Creator -> New label batch 2) Add an item 3) Click 'Remove selected items' button. Confirm message now reads "Please select at least one label to delete." 4) Click 'Remove duplicates' button. Confirm message now reads "Duplicate item(s) removed from batch number X: Y", all in bold. Signed-off-by: Hector Castro Rewording Ok for translatability purpose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:59:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:59:46 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 15:59:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 14:59:50 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 --- Comment #14 from Tom?s Cohen Arazi --- Created attachment 47307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47307&action=edit Bug 14532: (followup) Use tar's --exclude for simplicity This patch creates an --exclude definition for the tar command so it is easier to stack excluded stuff. It does so for the authority and biblio indexes if --exclude-indexes is passed. A side effect from this, is that uploads and plugins are still backed up, as Jonathan noted. Regards Edit: Fixed a weird quoting problem. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:06:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:06:03 +0000 Subject: [Koha-bugs] [Bug 15665] Better wording of error messages when importing MARC frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15665 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:06:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:06:06 +0000 Subject: [Koha-bugs] [Bug 15665] Better wording of error messages when importing MARC frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15665 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47296|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 47308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47308&action=edit [SIGNED-OFF]Bug 15665: Better wording of error messages when importing MARC frameworks To test: 1) Go to Admin -> MARC frameworks 2) Click Import next to any framework. You won't actually be overwriting or importing anything as this is only a string fix, so it can be an existing framework 3) Click the Import button without attaching any file. Confirm it says "Please select a spreadsheet (.csv, .ods, .xml) file." and that this makes sense to you 4) Attempt to attach a file that is not a .csv, .ods or .xml file. You should instantly get an error message saying "Please select a CSV (.csv), ODS (.ods) or XML (.xml) file." Confirm this shows up and makes sense to you Signed-off-by: Hector Castro Rewording Ok. Works as described -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:07:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:07:29 +0000 Subject: [Koha-bugs] [Bug 15671] New: Show branch name instead of branch code in checkout history Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15671 Bug ID: 15671 Summary: Show branch name instead of branch code in checkout history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be nice if the checkouts history (staff > detail page > checkouts history) showed the branch name instead of the branch code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:09:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:09:23 +0000 Subject: [Koha-bugs] [Bug 15672] New: Show descriptions instead of codes on the hold ratios report Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15672 Bug ID: 15672 Summary: Show descriptions instead of codes on the hold ratios report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The hold ratios report available from the circulation module start page lists - homebranch - holdingbranch - location - itype with the code, instead of the descriptions or names for each. It would be nicer to show the descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:18:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:18:08 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #2 from H?ctor Eduardo Castro Avalos --- Good cath Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:22:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:22:45 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:22:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:22:47 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47293|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 47309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47309&action=edit [SIGNED-OFF]Bug 15663: Fix 'remove selected items', add a 'delete batch' button In this patch I have fixed the 'Remove selected items' button. I have also added a 'Delete batch' button like there is in the Patron Card Creator. To test: 1) Go to Tools -> Label creator -> New label batch 2) Add 2 items 3) Select the checkbox next to an item you just added and click 'Remove selected items' 4) A pop-up will say that you are yet to select an item. (Please ignore the mistake in the pop-up message, this is being fixed in Bug 15662) 5) Apply patch and refresh. Confirm there is now a 'Delete batch' button in the toolbar 6) Select one item and click 'Remove selected items' 7) Confirm the item is deleted from the batch 8) Select the final item and click 'Remove selected items' 9) Pop-up message will tell you that deleting this item will delete the batch. Click 'Okay' 10) Click 'Delete batch' then 'Okay' 11) Confirm you are redirected to the Labels page and the batch has been deleted. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:23:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:23:20 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:29:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:29:48 +0000 Subject: [Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:29:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:29:51 +0000 Subject: [Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 --- Comment #1 from Nick Clemens --- Created attachment 47310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47310&action=edit Bug 15669 - alphabetize marc modification templtes This patch sorts the mdofication templates lists before passing them into templates in the three places they are used tools/batch_record_modification.pl tools/marc_modification.pl tools/stage-marc-import.pl To test: 1 - Add some marc modification templates in a non alpha order (Shoes, Hats, Cats) 2 - visit the three pages above and note the templates are in order added 3 - apply patch 4 - visit the three pages and note correct order 5 - verify all tools continue to work as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:34:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:34:02 +0000 Subject: [Koha-bugs] [Bug 15673] New: Accessibility: problems setting the renewal date Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15673 Bug ID: 15673 Summary: Accessibility: problems setting the renewal date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org This is a report from a library using the keyboard, screen reader and braille line for navigating Koha. When trying to set the renewal date below the checkouts table the checkbox for the "forgive fines on return" checkbox is set instead. I think this might be the screen reader not being happy about how we have structured the page in this area, but I was not able to verify. Hoping someone else might have an idea on how to improve accessibility in this area of the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:34:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:34:17 +0000 Subject: [Koha-bugs] [Bug 15673] Accessibility: problems setting the renewal date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15673 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:41:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:41:06 +0000 Subject: [Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:41:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:41:09 +0000 Subject: [Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47310|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47311&action=edit [SIGNED-OFF]Bug 15669: Alphabetize marc modification templates This patch sorts the mdofication templates lists before passing them into templates in the three places they are used tools/batch_record_modification.pl tools/marc_modification.pl tools/stage-marc-import.pl To test: 1 - Add some marc modification templates in a non alpha order (Shoes, Hats, Cats) 2 - visit the three pages above and note the templates are in order added 3 - apply patch 4 - visit the three pages and note correct order 5 - verify all tools continue to work as expected Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:42:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:42:21 +0000 Subject: [Koha-bugs] [Bug 15667] Messages in patron account display dates wrongly formatted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15667 --- Comment #1 from Marc V?ron --- Created attachment 47312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47312&action=edit Bug 15667 - Fix date and branch formatting of messages in patron account display This patch fixes the date and branch formatting of messages in patron account display. To verify: Add a new message to a patron account from the 'checkouts' tab in staff, the displayed date is not correctly formatted and the branch displays as code instead as branch name To test: Apply patch, verify that the messages and branch names are properly formatted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:43:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:43:07 +0000 Subject: [Koha-bugs] [Bug 15667] Messages in patron account display dates wrongly formatted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15667 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |veron at veron.ch Status|NEW |Needs Signoff CC| |veron at veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:43:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:43:36 +0000 Subject: [Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:46:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:46:42 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #4 from Marc V?ron --- H?ctor, did you forget to set teh status tu signed-off? :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:48:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:48:42 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #53 from Alex Arnaud --- In fact, it doesn't work either on the staff side. I have 3 holds per record on my circulation rules and i can place as many record-level holds as i want (in the limit of maxreserves syspref) on the same record for the same patron. I have the same behavior with item-level holds and i can hold many times the same item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 16:54:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 15:54:21 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 --- Comment #5 from H?ctor Eduardo Castro Avalos --- (In reply to Marc V?ron from comment #4) > H?ctor, did you forget to set teh status tu signed-off? :-) Thanks Marc. I've uncommented the line in git-bz, but maybe the program did not update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 17:11:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 16:11:28 +0000 Subject: [Koha-bugs] [Bug 7403] CataloguingLog warning incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 17:17:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 16:17:04 +0000 Subject: [Koha-bugs] [Bug 15674] New: 'Show/hide columns' is not translatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15674 Bug ID: 15674 Summary: 'Show/hide columns' is not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The 'Show/hide columns' button for changing the columns on a table configured under administration > columns configuration is not translatable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 17:17:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 16:17:12 +0000 Subject: [Koha-bugs] [Bug 15674] 'Show/hide columns' is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15674 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 17:41:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 16:41:23 +0000 Subject: [Koha-bugs] [Bug 15334] Accountlines should link to issues/old_issues using issue_id. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15334 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 17:45:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 16:45:00 +0000 Subject: [Koha-bugs] [Bug 15675] New: Add issue_id column to accountlines and use it for updating fines Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Bug ID: 15675 Summary: Add issue_id column to accountlines and use it for updating fines Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Right now, fines are updated based on the fine description. There are a number of areas where this can go wrong ( date or time format changing, title being modified, etc ). Now that issues has a unique identifier, we should use that for selection and updating of fines. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 17:45:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 16:45:08 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 17:45:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 16:45:14 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 17:45:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 16:45:25 +0000 Subject: [Koha-bugs] [Bug 15334] Accountlines should link to issues/old_issues using issue_id. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15334 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 15675 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 17:45:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 16:45:25 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #1 from Kyle M Hall --- *** Bug 15334 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 18:08:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 17:08:20 +0000 Subject: [Koha-bugs] [Bug 7403] CataloguingLog warning incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403 --- Comment #4 from Marc V?ron --- (In reply to Katrin Fischer from comment #3) > The warning is still present, also we somehow seem to add 2 entries for each > checkout and return of an item. Check out an item generates 2 entries: 2016-01-26 17:14:16 A. Testman (51) Catalog Modify Item 364 item $VAR1 = { 'itemnumber' => '364', 'issues' => 1, 'datelastborrowed' => '2016-01-26', 'holdingbranch' => 'CPL', 'itemlost_on' => undef, 'itemlost' => 0, 'onloan' => '2016-02-04' }; 2016-01-26 17:14:16 A. Testman (51) Catalog Modify Item 364 item $VAR1 = { 'itemnumber' => '364', 'datelastseen' => '2016-01-26', 'itemlost_on' => undef, 'itemlost' => 0 }; Check in the item generates 3 entries, #1 and #2 are identical: 2016-01-26 17:16:21 A. Testman (51) Catalog Modify Item 364 item $VAR1 = { 'itemnumber' => '364', 'onloan' => undef }; 2016-01-26 17:16:21 A. Testman (51) Catalog Modify Item 364 item $VAR1 = { 'itemnumber' => '364', 'onloan' => undef }; 2016-01-26 17:16:21 A. Testman (51) Catalog Modify Item 364 item $VAR1 = { 'itemnumber' => '364', 'datelastseen' => '2016-01-26', 'itemlost_on' => undef, 'itemlost' => 0 }; It will be difficult to get that right, because while checking in and out, ModItem is called several times and generates each time a log entry (C4/Items.pm line 608) Maybe the logs for items and for bibliographic records could be separated? E.g. use 'Cataloguing' for records only and a new log 'Items' for Items? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 18:24:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 17:24:46 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 --- Comment #2 from Kyle M Hall --- Created attachment 47313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47313&action=edit Bug 15675 - Add issue_id column to accountlines and use it for updating fines Right now, fines are updated based on the fine description. There are a number of areas where this can go wrong ( date or time format changing, title being modified, etc ). Now that issues has a unique identifier, we should use that for selection and updating of fines. Test Plan: 1) Apply this patch 2) Test creating and updating fines via fines.pl and checking in overdue items. No changes should be noted. 3) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 18:24:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 17:24:44 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 18:24:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 17:24:56 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 --- Comment #3 from Kyle M Hall --- Created attachment 47314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47314&action=edit Bug 15675 - Update Schema file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 18:31:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 17:31:57 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 --- Comment #4 from Kyle M Hall --- Created attachment 47315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47315&action=edit Bug 15675 - Fix some missed tab characters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 18:35:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 17:35:15 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47315|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 47316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47316&action=edit Bug 15675 - Fix some missed tab characters, remove old FIXMEs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 18:35:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 17:35:32 +0000 Subject: [Koha-bugs] [Bug 15676] New: Actions in pending offline circulation actions are not translatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15676 Bug ID: 15676 Summary: Actions in pending offline circulation actions are not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When processing offline circulations the column of the results table Action column contains "issue", "return" and possibly something like payment. These values are not translatable. Also: issue should probably be checkout and return should be check-in? :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 18:39:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 17:39:18 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 18:39:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 17:39:18 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15675 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 [Bug 15675] Add issue_id column to accountlines and use it for updating fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 19:14:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 18:14:10 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com, | |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 19:56:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 18:56:26 +0000 Subject: [Koha-bugs] [Bug 15647] Allow selection of destination email address for print overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15647 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 20:02:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 19:02:07 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 20:10:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 19:10:50 +0000 Subject: [Koha-bugs] [Bug 15427] Allow db connections using TLS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 20:44:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 19:44:08 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #5 from Nick Clemens --- Created attachment 47317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47317&action=edit Bug 12663 - Prevent OPACUserJS and OPACUserCSS from loading Update includes to not load these prefs on any sco page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 21:25:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 20:25:31 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 21:25:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 20:25:34 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47270|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 47318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47318&action=edit [SIGNED-OFF] Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page Currently if not logged in when browsing to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl You are redirected to opac-auth.pl and SCOUserCSS and SCOUserJS are not loaded. This patch adds new opac-auth.tt file for authenticating SCO users which loads these files and redirects a login to the SCO module instead of the patron account Common code between opac-auth and sco-auth is mostly alternate login info and has been move to alt-auth.inc To test: 1 - Verify that normal login works on both staff and opac 2 - Verify that SCO login goes to a new page 3 - Enter changes into SCOUserJS and SCOUserCSS and observe these are present on SOC log in page 4 - Verify that a logged in opac user without permissions cannot access the self-checkout module 5 - Verify that AutoSelfCheckAllowed and associated system preferences function as expected 6 - Verify the AutoSelfCheck user is logged out if they attempt to visit another page Bonus points for verifying all alternate methonds of login function as expected Sponsored by Northeast Kansas Libary System (NEKLS) www.nekls.org Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 21:25:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 20:25:41 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47317|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 47319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47319&action=edit [SIGNED-OFF] Bug 12663 - Prevent OPACUserJS and OPACUserCSS from loading Update includes to not load these prefs on any sco page Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 22:41:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 21:41:21 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 23:23:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 22:23:36 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 23:30:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 22:30:45 +0000 Subject: [Koha-bugs] [Bug 7017] override_renewals permission confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7017 --- Comment #2 from Nicole C. Engard --- I wouldn't say 'basic' I'd say 'circulate_remaining_permissions' since that's what the permission is but that works. Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 23:32:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 22:32:11 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45861|0 |1 is obsolete| | --- Comment #13 from Jesse Weaver --- Created attachment 47320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47320&action=edit Bug 15343 - Allow user to set password on opac-memberentry.pl This patch allows patrons to create thier own password during OPAC self registration. It sets the password field to be hidden by default, and allows for a system generated password if no password is supplied and field is not mandatory 1 - Apply patch 2 - run updatedatabase.pl 3 - Check syspref "PatronSelfRegistrationBorrowerUnwantedField" - it should contain 'password' 4 - Check self registration on opac - there should be no change 5 - Remove 'password' from PatronSelfRegistrationBorrowerUnwantedField 6 - Password field should now be visible in OPAC self registration 7 - Register a patron: If no passwor is supplied you should get a system generated password 8 - Register a patron with a password, your password should be used 9 - Add 'password' to PatronSelfRegistrationBorrowerMnadatoryField 10 - Attempt to register a patron with no password - it should fail 11 - Try all combinations if mismatched/short/missing passwords and view correct error messages 12 - prove t/db_dependent/Members.t Sponsored by : Do Space (www.dospace.org) Signed-off-by: Jesse Weaver ByWater internal signoff, still needs community signoff. Code looks decent and works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 23:32:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 22:32:16 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45869|0 |1 is obsolete| | --- Comment #14 from Jesse Weaver --- Created attachment 47321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47321&action=edit Bug 15343 [QA Followup] - Fix issues 1) "Contact information" should be "Password" 2) Don't pass sysprefs from the script to the template, use Koha.Preference() 3) minPasswordLength is optional, we cannot always assume it is set 4) Password field when does not follow convention completely when mandatory Signed-off-by: Nick Clemens Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 23:32:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 22:32:20 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46737|0 |1 is obsolete| | --- Comment #15 from Jesse Weaver --- Created attachment 47322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47322&action=edit Bug 15343 [QA Follow up] Fix captcha display Make captcha visible even if password field is hidden Remove password confirmation field before submitting modification Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 23:45:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 22:45:11 +0000 Subject: [Koha-bugs] [Bug 14875] Search serials by barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14875 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 23:45:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 22:45:13 +0000 Subject: [Koha-bugs] [Bug 14875] Search serials by barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14875 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47074|0 |1 is obsolete| | --- Comment #5 from Nicole C. Engard --- Created attachment 47323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47323&action=edit Bug 14875 - Search serials by barcode This patch is only for the advanced search To test: 1. Go to serials 2. If required make a new subscription and/or then click on advanced search 3. See that there is no barcode field. 4. Apply patch and repeat steps, there should now be a barcode field. 5. Type in a barcode and hit search. See that your book shows up. Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 23:45:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 22:45:18 +0000 Subject: [Koha-bugs] [Bug 14875] Search serials by barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14875 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47077|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard --- Created attachment 47324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47324&action=edit Bug 14875 Search serials by barcode To test: 1. Go onto the 'Serials' page 2. In the quick search, there are only two search fields; ISSN and Title 3. Apply the patch 4. There should now be three search fields, 'Barcode' being added. 5. Fill in that field with a barcode and matching results should come up. Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 23:55:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 22:55:27 +0000 Subject: [Koha-bugs] [Bug 15351] RDA fields in Authority Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15351 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #4 from Nicole C. Engard --- As of right now the authority frameworks are missing many of the fields required. I have attached a PDF. The bib frameworks are kept up to date but I do not think the authority ones are. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 26 23:55:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 22:55:43 +0000 Subject: [Koha-bugs] [Bug 15351] RDA fields in Authority Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15351 --- Comment #5 from Nicole C. Engard --- Created attachment 47325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47325&action=edit pdf of page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 00:27:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 23:27:14 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #88 from David Cook --- (In reply to Wolfram Schneider from comment #87) > If marcxml + XSLT is to slow, then you might try to use turbomarc instead. > It's a smaller XML for MARC and much faster to work with in XSLT. http://www.indexdata.com/news/2014/06/turbomarc-faster-xml-marc-records I can't imagine us using Turbomarc for anything but indexing, but then we'd lose time converting from MARCXML to/from Turbomarc as well... Personally, I like the idea of using our own intermediary format which can be exported as MARCXML (or Turbomarc or whatever), although I suppose the problem with that is our intermediary format could grow and then not be perfectly exportable as MARCXML, which means lost data for users, although perhaps not a big problem if you provide easy ways of customizing exports, so people could export into fields like 9AA (see http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd for valid tag ranges) and then massage from there... The intermediary format could also help us move away from XML and Zebra anyway, so that we could use any indexing engine like Solr, ElasticSearch, or whatever. Really, we only need MARC(XML) for interchange. Consider this: "2.1. The MARC 21 formats are communication formats, primarily designed to provide specifications for the exchange of bibliographic and related information between systems. They are widely used in a variety of exchange and processing environments. As communication formats, they do not mandate internal storage or display formats to be used by individual systems." (https://www.loc.gov/marc/96principl.html) I suppose my argument could be used to support turbomarc as well... although I don't know how well turbomarc would work itself as a format (besides the performance improvement for XSL transformations). I suppose another argument against changing from MARC(XML) could be the need to provide sufficient mechanisms for using AACR2 and RDA. MARC pretty much already has that built in, but then it also has limitations. Anyway, that's all rather tangential. I don't know about turbomarc. It seems like it would be a bit painful to work with :/. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 00:55:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 23:55:23 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 00:55:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 23:55:27 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #3 from Aleisha Amohia --- Created attachment 47326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47326&action=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Click 'Import' into your new authority type (so you don't overwrite any important existing authority types) 7) Select the file you just exported and click 'Import' 8) Confirm you are taken to auth_tag_structure.pl 9) Go back to Authority types 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Go to Admin -> MARC bibliographic framework 12) Confirm that the 'Export' and 'Import' functions still work here as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 00:58:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 23:58:30 +0000 Subject: [Koha-bugs] [Bug 15677] New: Misconfigured anonymous patron allows checkouts to multiple patrons. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15677 Bug ID: 15677 Summary: Misconfigured anonymous patron allows checkouts to multiple patrons. Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug was found on 3.20.04.000. Configuration: Patron 1 has has his privacy settings set to anonymize upon check-in (2). AnonymousPatron systempreference is set to a number that does not correspond to any borrowernumber. OpacPrivacy is set to 1. Steps to reproduce: 1) Check out item to Patron 1 -- At this point, you can try to check in the item, it will fail because anonymous patron settings are mis-configured. 2) Check out the same item to any other patron. The check-out will succeed, and you will see error such as this in the logs: circulation.pl: Fatal error: the patron (16) has requested their circulation history be anonymized on check-in, but the AnonymousPatron system preference is empty or not set correctly. at /usr/share/koha/lib/C4/Circulation.pm line 2086. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 00:58:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jan 2016 23:58:52 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 01:03:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 00:03:21 +0000 Subject: [Koha-bugs] [Bug 15677] Misconfigured anonymous patron allows checkouts to multiple patrons. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15677 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 01:10:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 00:10:36 +0000 Subject: [Koha-bugs] [Bug 9388] Accessibility - No feedback when returning book. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9388 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #6 from Aleisha Amohia --- Is this still valid? Now, the row is highlighted when it is checked in and says 'Checked in'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 01:17:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 00:17:56 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #19 from Aleisha Amohia --- I'm not sure why this has been marked Failed QA - just tested and works well. I think the only thing it needs is an icon in the menu like the other menu options have! Anyone still working on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 02:02:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 01:02:17 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #14 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. - Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 02:04:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 01:04:01 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #12 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 02:09:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 01:09:10 +0000 Subject: [Koha-bugs] [Bug 12045] Transfer impossible if barcode includes spaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12045 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 02:12:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 01:12:54 +0000 Subject: [Koha-bugs] [Bug 15626] koha-remove does not remove log4perl.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15626 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 02:12:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 01:12:54 +0000 Subject: [Koha-bugs] [Bug 15678] New: Make pickup branch editable on holds tab on circulation/patron detail screens Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15678 Bug ID: 15678 Summary: Make pickup branch editable on holds tab on circulation/patron detail screens Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 9528 added a pickup at column to the holds tab on the circulation/patron detail screens. Liz Rea mentioned, "it should be editable without deleting and re-adding the reserve." I'm filing a new bug with that suggestion. That would be quite useful to have. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 02:12:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 01:12:54 +0000 Subject: [Koha-bugs] [Bug 9528] Add delivery branch to the place hold display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9528 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15678 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 02:16:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 01:16:29 +0000 Subject: [Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 02:16:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 01:16:31 +0000 Subject: [Koha-bugs] [Bug 15678] Make pickup branch editable on holds tab on circulation/patron detail screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15678 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 02:23:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 01:23:06 +0000 Subject: [Koha-bugs] [Bug 15679] New: Reset item level hold back to record level hold without deleting and readding the hold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15679 Bug ID: 15679 Summary: Reset item level hold back to record level hold without deleting and readding the hold Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Right now, if a hold is tied to a specific item (for any number of reasons), and it needs to be set back to a title level hold, you have to delete and readd the hold. This is cumbersome enough, but it's even more cumbersome when a record has multiple holds (especially 20+), and the hold has to be replaced and manually back in its original priority order. It would be nice if Koha could allow you to reset a hold back to record level after it's been placed, for all cases, including when it's in transit for a patron. Situations arise where an item arrives damaged or is lost in transit and a new item is needed to fulfill the hold. There should probably be a permission to control access to this proposed functionality, like the existing modify_holds_priority permission. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 02:46:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 01:46:55 +0000 Subject: [Koha-bugs] [Bug 15391] HoldsQueue.t does not handle for loan itemtypes correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 02:50:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 01:50:59 +0000 Subject: [Koha-bugs] [Bug 15357] Deleting all items on a record with title level holds creates orphaned/ghost holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15357 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #8 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 02:52:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 01:52:07 +0000 Subject: [Koha-bugs] [Bug 15670] Rename "Cancel" to "Cancel hold" when checking in a waiting item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15670 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 02:54:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 01:54:02 +0000 Subject: [Koha-bugs] [Bug 15670] Rename "Cancel" to "Cancel hold" when checking in a waiting item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15670 --- Comment #1 from Heather Braum --- +! on this. It will definitely cause some confusion in our system, too, as it currently stands. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:04:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:04:46 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #12 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:09:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:09:56 +0000 Subject: [Koha-bugs] [Bug 15209] C4::Koha routines expecting a MARC::Record object should check it is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15209 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:13:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:13:57 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #25 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:19:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:19:29 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #10 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:21:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:21:49 +0000 Subject: [Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #25 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:23:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:23:32 +0000 Subject: [Koha-bugs] [Bug 13177] Add help pages for Rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:30:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:30:52 +0000 Subject: [Koha-bugs] [Bug 9754] koha-remove optionally includes var/lib and var/spool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #9 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:33:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:33:07 +0000 Subject: [Koha-bugs] [Bug 6322] It's possible to view lists/virtualshelves even when virtualshelves is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6322 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #15 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:35:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:35:34 +0000 Subject: [Koha-bugs] [Bug 7386] Label batches cannot be batch deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7386 --- Comment #4 from Heather Braum --- Bug 14805 introduced a way for multiple patron card batches to be deleted. Could the same process be used here to be able to delete multiple label batches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:42:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:42:17 +0000 Subject: [Koha-bugs] [Bug 4912] After editing private list, user should be redirect to private lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4912 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #30 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:45:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:45:24 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #11 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. (Also would be cool to notes Kyle's wish list at the end of this.) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:46:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:46:52 +0000 Subject: [Koha-bugs] [Bug 15609] spelling mistake in :692: writen ==> written In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15609 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:48:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:48:45 +0000 Subject: [Koha-bugs] [Bug 15592] spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15592 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:50:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:50:42 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:52:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:52:49 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #9 from Brendan Gallagher --- Pushed to Master - Should be in the may 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 03:55:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 02:55:34 +0000 Subject: [Koha-bugs] [Bug 15476] Listname not always displayed in shelves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15476 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 04:35:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 03:35:32 +0000 Subject: [Koha-bugs] [Bug 15468] Search links on callnumbers with parentheses fails on OPAC results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 05:15:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 04:15:47 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45339|0 |1 is obsolete| | --- Comment #11 from Mirko Tietgen --- Created attachment 47327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47327&action=edit Bug 14168 - enhance streaming cataloging to include youtube Add optional embedding of YouTube videos via HTML5Media. New syspref: HTML5MediaYouTube: Embed/Don't embed videos. Format WEBM is hardcoded as it is the only format accepted by all modern browsers. Test plan: - apply patch - catalogue a YouTube link in 856$u - turn on HTML5MediaEnabled and HTML5MediaYouTube - open the record in OPAC and staff client, check that the 'Play media' tab is showing and playing the video works. Possible enhancements for followups: - check available formats, offer quality choice - accept official YT URL shortener -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 05:16:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 04:16:47 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 --- Comment #12 from Mirko Tietgen --- Aleisha, thanks for testing! I rebased the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 05:18:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 04:18:20 +0000 Subject: [Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #7 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release - Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 05:20:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 04:20:56 +0000 Subject: [Koha-bugs] [Bug 15355] Translatability: Fix issues on check in page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15355 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 05:22:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 04:22:49 +0000 Subject: [Koha-bugs] [Bug 15195] patron details should open in tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15195 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher --- Pushed to Master - Should be in the may 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 05:24:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 04:24:34 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Attachment #45093|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 05:28:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 04:28:06 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 05:30:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 04:30:40 +0000 Subject: [Koha-bugs] [Bug 14810] Improve messages in patron anonymizing tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14810 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 05:32:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 04:32:17 +0000 Subject: [Koha-bugs] [Bug 14641] Warns in subscription-add.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #11 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 05:34:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 04:34:06 +0000 Subject: [Koha-bugs] [Bug 14624] <> for advance_notices.pl wrongly documented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #7 from Brendan Gallagher --- Pushed to Master - Should be in the may 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 05:37:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 04:37:55 +0000 Subject: [Koha-bugs] [Bug 14555] Warns in opac-search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #13 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 05:40:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 04:40:49 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #19 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:08:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:08:34 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #251 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:10:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:10:15 +0000 Subject: [Koha-bugs] [Bug 15624] Spelling mistake in suggestion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15624 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:11:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:11:25 +0000 Subject: [Koha-bugs] [Bug 15623] Spelling mistake in boraccount.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15623 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:12:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:12:28 +0000 Subject: [Koha-bugs] [Bug 15621] Spelling mistake in printinvoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15621 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:13:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:13:54 +0000 Subject: [Koha-bugs] [Bug 15619] Spelling mistake in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15619 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:14:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:14:47 +0000 Subject: [Koha-bugs] [Bug 15616] Spelling mistake in opac-account.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15616 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:15:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:15:56 +0000 Subject: [Koha-bugs] [Bug 15614] Spelling mistake in circ/pendingreserves.tt: Fullfilled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15614 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:16:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:16:49 +0000 Subject: [Koha-bugs] [Bug 15613] Spelling mistake: paramter vs parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15613 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:17:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:17:50 +0000 Subject: [Koha-bugs] [Bug 15611] Spelling mistake: implimented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15611 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:19:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:19:12 +0000 Subject: [Koha-bugs] [Bug 15608] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15608 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:20:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:20:11 +0000 Subject: [Koha-bugs] [Bug 15598] Typo in subscription-add.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15598 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:21:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:21:04 +0000 Subject: [Koha-bugs] [Bug 15597] Typo in opac-auth-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:22:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:22:19 +0000 Subject: [Koha-bugs] [Bug 15589] OPAC Lists "his" string fix In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15589 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:23:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:23:52 +0000 Subject: [Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:26:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:26:11 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #19 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:27:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:27:24 +0000 Subject: [Koha-bugs] [Bug 15298] z39.50 admin setup, options column suggested changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:29:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:29:10 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #22 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:30:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:30:20 +0000 Subject: [Koha-bugs] [Bug 15638] spelling mistake in ~/Koha/reserve/placerequest.pl:4: writen ==> written In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15638 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:31:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:31:46 +0000 Subject: [Koha-bugs] [Bug 15628] Remove get_branchinfos_of vestiges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15628 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:33:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:33:42 +0000 Subject: [Koha-bugs] [Bug 15617] Be able to close "Click to edit" text boxes after opening them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15617 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:34:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:34:45 +0000 Subject: [Koha-bugs] [Bug 15583] List of lists in the staff client should have a default sort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15583 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:35:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:35:53 +0000 Subject: [Koha-bugs] [Bug 15574] Better wording for error message when adding tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15574 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:40:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:40:39 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:41:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:41:47 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #14 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:42:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:42:44 +0000 Subject: [Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:51:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:51:49 +0000 Subject: [Koha-bugs] [Bug 15519] Warns when creating a basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15519 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:52:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:52:42 +0000 Subject: [Koha-bugs] [Bug 15481] Remove dead code in datatables.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15481 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher --- https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:55:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:55:42 +0000 Subject: [Koha-bugs] [Bug 15403] Confirm messages in intranet lists interface strangely worded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher --- https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:58:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:58:25 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #39 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 06:59:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 05:59:42 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 07:01:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 06:01:07 +0000 Subject: [Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #14 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 07:03:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 06:03:28 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #14 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 07:06:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 06:06:03 +0000 Subject: [Koha-bugs] [Bug 15004] Allow to change amounts of duplicated budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15004 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #11 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 07:10:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 06:10:51 +0000 Subject: [Koha-bugs] [Bug 14763] show patron's age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #14 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 07:13:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 06:13:43 +0000 Subject: [Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #18 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 07:16:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 06:16:54 +0000 Subject: [Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Attachment #46287|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 07:18:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 06:18:15 +0000 Subject: [Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 07:21:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 06:21:54 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #47 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 07:24:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 06:24:11 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #162 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 07:28:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 06:28:17 +0000 Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #30 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 07:30:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 06:30:16 +0000 Subject: [Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #9 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 07:32:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 06:32:33 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 07:38:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 06:38:24 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #109 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 07:40:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 06:40:01 +0000 Subject: [Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #11 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 07:46:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 06:46:23 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #203 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 08:31:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 07:31:55 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #204 from Katrin Fischer --- Blou - please don't forget the 2 follow-ups for the namespace and the notices (last comment from Marcel!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 08:35:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 07:35:21 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #20 from Katrin Fischer --- Hi Aleisha, have you seen my comment#11 with the examples? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 09:30:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 08:30:14 +0000 Subject: [Koha-bugs] [Bug 15351] RDA fields in Authority Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15351 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 09:47:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 08:47:14 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #21 from Viktor Sarge --- (In reply to Aleisha Amohia from comment #19) > I'm not sure why this has been marked Failed QA - just tested and works > well. I think the only thing it needs is an icon in the menu like the other > menu options have! Anyone still working on this? We?re not currently working on this. There?s still a few hundred developer hours left in our project, but for now we'll have to focus on things that have higher priority. Anyone is welcome to take it further, but I'll keep following the thread and at least keep it in mind if we should have developer hours left once we get to lower priority development. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 10:55:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 09:55:40 +0000 Subject: [Koha-bugs] [Bug 15677] Misconfigured anonymous patron allows checkouts to multiple patrons. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- It's the expected behavior: the pref is not set correctly, it's a configuration issue. You should also get a warning on the about page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 10:56:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 09:56:51 +0000 Subject: [Koha-bugs] [Bug 9942] Circulation module cannot anonymise if anonymity user is not set up correctly. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9942 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15677 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 10:56:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 09:56:51 +0000 Subject: [Koha-bugs] [Bug 15677] Misconfigured anonymous patron allows checkouts to multiple patrons. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9942 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 11:18:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 10:18:10 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #7 from Jonathan Druart --- (In reply to M. Tompsett from comment #5) > Comment on attachment 47125 [details] [review] > Bug 15635: Koha::Patron::Images - Remove RmPatronImage > > Review of attachment 47125 [details] [review]: > ----------------------------------------------------------------- > > ::: tools/picture-upload.pl > @@ +163,5 @@ > > + my $deleted = eval { > > + Koha::Patron::Images->find( $borrowernumber )->delete; > > + }; > > + if ( $@ or not $deleted ) { > > + warn "Image for patron '$borrowernumber' has not been deleted"; > > Should we not distinguish between $@ and not $deleted? It's what I did for other admin scripts, we could display the error ($@) if needed but could be done later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 11:19:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 10:19:40 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 --- Comment #8 from Jonathan Druart --- (In reply to M. Tompsett from comment #6) > Comment on attachment 47126 [details] [review] > Bug 15635: Koha::Patron::Images - Remove GetPatronImage > > Review of attachment 47126 [details] [review]: > ----------------------------------------------------------------- > > ::: opac/opac-memberentry.pl > @@ +232,5 @@ > > ); > > > > if (C4::Context->preference('OPACpatronimages')) { > > + my $patron_image = Koha::Patron::Images->find($borrower->{borrowernumber}); > > + $template->param( display_patron_image => 1 ) if $patron_image; > > After this many changes, I can understand a cut-and-paste mentality. :) What's wrong? I don't manage to see the error :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 11:27:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 10:27:07 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15478 --- Comment #43 from Jonathan Druart --- (In reply to Charles Farmer from comment #42) > (In reply to Jonathan Druart from comment #41) > > (In reply to Kyle M Hall from comment #40) > > > Pushed to master, thanks Philippe! > > > > Please regenerate the Schema files, some tests are failing. > > Which tests? I ran update_dbix_class_files.pl and nothing changed in my > index... It was a RM note, it has been fixed by bug 15478. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 [Bug 15478] Checksum mismatch when regenerating schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 11:27:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 10:27:07 +0000 Subject: [Koha-bugs] [Bug 15478] Checksum mismatch when regenerating schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13624 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 11:30:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 10:30:01 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #4 from bondiurbano --- Created attachment 47328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47328&action=edit Automatic_renewals failed Test -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 11:32:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 10:32:08 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #5 from bondiurbano --- (In reply to Katrin Fischer from comment #3) > It's true that it should try before the item is due - usually. But for > example this could happen: if there is a hold on the item, it will prevent > renewal, the item will go overdue... the hold might be cancelled. Then you > will have a renewable item that is also overdue. The Settings in the system > prefrences should apply then to decide if it can be renewed or not. What you are describing may happen with manual renewals. Please see the test-case I have attached: except this case I think all works fine. > > I think if the "No renewal before" is empty, we could agree that it should > try on the due date - but witht he parameter set the behaviour should be > changed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 11:34:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 10:34:05 +0000 Subject: [Koha-bugs] [Bug 15605] Accessibility: Can't tab to add link in serials routing list add user popup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 11:34:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 10:34:08 +0000 Subject: [Koha-bugs] [Bug 15605] Accessibility: Can't tab to add link in serials routing list add user popup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47260|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 47329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47329&action=edit Bug 15605 - Accessibility: Can't tab to add link in serials routing list add user popup To Test - 1. Go to Serials and search for a title and then click on it. 2. Click routing list and then Add recipients. 3. Search for a patron. 4. Using the tab key try to navigate onto the Add link. 5. Notice it skips Add. 6. Apply the patch and then repeat steps 1-4, notice the Add link can now be accessed through using the keyboard. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 11:34:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 10:34:13 +0000 Subject: [Koha-bugs] [Bug 15605] Accessibility: Can't tab to add link in serials routing list add user popup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 --- Comment #4 from Jonathan Druart --- Created attachment 47330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47330&action=edit Bug 15605: Remove the cursor:pointer style. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 11:34:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 10:34:27 +0000 Subject: [Koha-bugs] [Bug 15605] Accessibility: Can't tab to add link in serials routing list add user popup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tasham_8 at hotmail.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 11:43:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 10:43:51 +0000 Subject: [Koha-bugs] [Bug 15652] Allow current date in datepicker on opac-reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15652 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Does it make sense to have 'Hold not needed after' set to today? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 11:52:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 10:52:32 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 --- Comment #3 from Jonathan Druart --- Maybe it would make more sense to check OPACFineNoRenewals instead of maxoutstanding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 11:57:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 10:57:00 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Should not we take 0 into account? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:08:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:08:07 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:13:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:13:42 +0000 Subject: [Koha-bugs] [Bug 13474] Untranslatable log actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:13:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:13:45 +0000 Subject: [Koha-bugs] [Bug 13474] Untranslatable log actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47272|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 47331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47331&action=edit Bug 13474: Adding untranslatable log actions to viewlog.tt Added 'Run' Signed-off-by: Aleisha (Amended to remove tab chars to make qa tools happy) Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:15:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:15:12 +0000 Subject: [Koha-bugs] [Bug 15658] Browse system logs: Add more actions to action filter list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15658 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:15:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:15:15 +0000 Subject: [Koha-bugs] [Bug 15658] Browse system logs: Add more actions to action filter list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15658 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47278|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 47332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47332&action=edit Bug 15658: Browse system logs: Add more actions to action filter list The following actions were missing in the action filter list on cgi-bin/koha/tools/viewlog.pl: 'ADDCIRCMESSAGE' 'CHANGE PASS' 'DELCIRCMESSAGE' 'RENEW' 'Run' To test: - Apply patch - Go to Tools > Logs (viewlog.pl) - Verify that the actions appear in the list 'Actions' - Verify that the new entries filter the list as appropriate (in combination with Modules: All or with a meaningful selection in list 'Modules') Note for testing: You have to set a date in 'Display from' to get results Signed-off-by: Hector Castro Logs work as advertised, translated in bug 13474 Signed-off-by: Jonathan Druart "Run" could be more explicit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:15:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:15:37 +0000 Subject: [Koha-bugs] [Bug 13474] Untranslatable log actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:21:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:21:56 +0000 Subject: [Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart --- It does not work: you are modifying a param in the template, but not in the script (output_format_auth). When I export authorities, I always get an empty file named "koha.mrc". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:23:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:23:04 +0000 Subject: [Koha-bugs] [Bug 15657] follow-up for bug 15501 : add a missing semi-colon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15657 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:23:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:23:07 +0000 Subject: [Koha-bugs] [Bug 15657] follow-up for bug 15501 : add a missing semi-colon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15657 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47277|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 47333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47333&action=edit Bug 15657 (follow-up bug 15501): add missing semi-colon Signed-off-by: Hector Castro The semicolon it's added Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:23:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:23:21 +0000 Subject: [Koha-bugs] [Bug 15657] follow-up for bug 15501 : add a missing semi-colon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15657 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |koha at univ-lyon3.fr |ity.org | Depends on| |15501 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 [Bug 15501] Planned Irregularities are deleted when modifying subscription -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:23:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:23:21 +0000 Subject: [Koha-bugs] [Bug 15501] Planned Irregularities are deleted when modifying subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15657 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15657 [Bug 15657] follow-up for bug 15501 : add a missing semi-colon -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:25:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:25:36 +0000 Subject: [Koha-bugs] [Bug 12146] Add new ISO code column to currency sample files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart --- Please provide a patch for other languages too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:26:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:26:50 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #4 from Mike --- Hello Aleisha, I tested patch but output are non correct. Examples: empty export of unification names http://pastebin.com/qnCassBC Personal names, just some mess: http://pastebin.com/1X6NXgeN Expected is same type of output like export from biblio frameworks. Lets find bug :-) Thank You. Mike -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:28:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:28:02 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:31:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:31:59 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #5 from Mike --- Hello Aleisha, I tested patch but outputs are non correct. Examples: empty export of unification names http://pastebin.com/qnCassBC Personal names, just some mess: http://pastebin.com/1X6NXgeN Expected is same type of output like export from biblio frameworks. Lets find bug :-) Export from default biblio framework don't work - empty file Thank You. Mike -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:43:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:43:13 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Josef Moravec --- First of all, thank you Aleisha! But this doesn't work, because functions _export_table_* take data from database filtered by column "frameworkcode" which in auth_subfield_structure is not always populated and in auth_tag_structure is not present at all. I'm not sure how to deal with it, just some ideas for now: 1. we could add new parameter to export routines, which can say the column should be used to filter data (authtypecode if we are working with authorities) 2. add and populate column frameworkcode to tables auth_tag_structure and auth_subfield_structure, which should have the same value as authtypecode. But I don't really like this solution as it's more work ending with dumb duplicate column 3. something else -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:52:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:52:36 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #6 from Katrin Fischer --- Looking at your example - I think what happened is: The item was checked out on the 26th with due date 26th, but after the auto_renewal job was run for that day. On the 27th in the morning the job was run again, but the item was overdue by then - so renewal was blocked. That makes sense to me to be honest. I am not sure how to avoid that. > I think if the "No renewal before" is empty, we could agree that it should > try on the due date - but witht he parameter set the behaviour should be > changed. NOT be changed... :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 12:58:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 11:58:23 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #7 from Josef Moravec --- or 4. just unify the authtypecode/frameworkcode and name it the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:07:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:07:58 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #10 from Jonathan Druart --- I'd say this patch is not complete. Looking at the other part of the files, we have, for instance: INSERT INTO language_descriptions(subtag, type, lang, description) VALUES ( 'fi', 'language', 'fi', 'Suomi'); INSERT INTO language_descriptions(subtag, type, lang, description) VALUES ( 'fi', 'language', 'en', 'Finnish'); We need the language name to be translated in its own language Moreover it seems that we need to add the country with the "region" type too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:10:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:10:45 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #31 from Jonathan Druart --- Comment on attachment 47289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47289 [SIGNED-OFF] Bug 11573 - Make fine display more consistent for rentals Review of attachment 47289: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11573&attachment=47289) ----------------------------------------------------------------- I am not sure I have understood what is expected. I get: Without the patch: Rental, Rental (my_title_99) Rent 0 0 1.00 1.00 Rental, Renewal of Rental Item my_title_99 my_barcode_992 (my_title_99) Rent 0 0 1.00 1.00 With the patch: Rental, my_title_99 my_barcode_992 (my_title_99) Rent 0 0 1.00 1.00 Rental, Renewal of Rental Item my_title_99 my_barcode_992 (my_title_99) I still get the title displayed twice. ::: C4/Circulation.pm @@ +3189,4 @@ > my $dbh = C4::Context->dbh; > my $nextaccntno = getnextacctno( $borrowernumber ); > my $manager_id = 0; > + my $item = GetBiblioFromItemNumber($itemnumber); GetBiblioFromItemNumber returns a biblio, not an item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:15:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:15:50 +0000 Subject: [Koha-bugs] [Bug 15652] Allow current date in datepicker on opac-reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15652 --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > Does it make sense to have 'Hold not needed after' set to today? Only a little little bit. See my commit message btw (" I only want this book today or not" ). For the most, it keeps the code cleaner, more consistent perhaps? In the end, it does not harm at all.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:16:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:16:58 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #8 from Mike --- Hello. I vote for solutions 1 or 4. Thanks for response. Mike -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:17:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:17:14 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #205 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #204) > Blou - please don't forget the 2 follow-ups for the namespace and the > notices (last comment from Marcel!) Yes. Please add the bug number in the See also or Blocks too. Thnx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:17:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:17:20 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |veron at veron.ch --- Comment #3 from Jonathan Druart --- The translatability issue came from the tag in the middle of the sentence. I think we can keep the previous sentence: [% duplicate_count %] duplicate item(s) found and removed from batch [% batch_id %]. Which looks better then the new one: Duplicate item(s) removed from batch number [% batch_id %]: [% duplicate_count %] Marc, any thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:26:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:26:44 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:29:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:29:33 +0000 Subject: [Koha-bugs] [Bug 14875] Search serials by barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14875 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- Natasha, when a subroutine is modified, tests should be provided to cover the changes and avoid regression later. Could you please provide some tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:34:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:34:07 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Heather, did you win the bonus points? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:39:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:39:29 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47300|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:39:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:39:31 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47299|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:39:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:39:33 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45734|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:39:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:39:35 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45349|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:39:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:39:37 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45345|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:39:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:39:39 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40957|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:39:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:39:42 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35303|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:39:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:39:44 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35130|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:40:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:40:02 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #181 from Jonathan Druart --- Created attachment 47334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47334&action=edit just a test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:40:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:40:31 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46406|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy --- Created attachment 47335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47335&action=edit Bug 15240: Do not process issues with a date due later than today There is no need to do this job in Perl, MySQL could do it instead. The idea is to only retrieve the issues info which could be overdued. To test: 1/ Run the script 2/ Apply the patch 3/ Run the script again, notice the exact same results but execution time is faster Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:41:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:41:12 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #182 from Marcel de Rooy --- Created attachment 47336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47336&action=edit Bug 15240: Do not process issues with a date due later than today There is no need to do this job in Perl, MySQL could do it instead. The idea is to only retrieve the issues info which could be overdued. To test: 1/ Run the script 2/ Apply the patch 3/ Run the script again, notice the exact same results but execution time is faster Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:42:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:42:22 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #23 from Marcel de Rooy --- Only tested git-bz; please wait.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:42:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:42:54 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:51:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:51:06 +0000 Subject: [Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart --- Nick, there is another place where they are displayed: tools/stage-marc-import.pl Maybe the best way would be to modify GetModificationTemplates and sort the entries at the DB level (order by clause). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:58:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:58:34 +0000 Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14676 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 [Bug 14676] UI/UX enhancements for the patron card creator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:58:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:58:34 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14676 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 [Bug 14676] UI/UX enhancements for the patron card creator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:58:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:58:34 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15663, 14632 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 [Bug 14632] Incorrect alert while deleting single item in batch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 [Bug 15663] Can't delete label from checkbox -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:58:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:58:47 +0000 Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15663 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:58:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:58:47 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14632 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 13:59:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 12:59:03 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |aleishaamohia at hotmail.com |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:08:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:08:23 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:08:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:08:26 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47309|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 47337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47337&action=edit Bug 15663: Fix 'remove selected items', add a 'delete batch' button In this patch I have fixed the 'Remove selected items' button. I have also added a 'Delete batch' button like there is in the Patron Card Creator. To test: 1) Go to Tools -> Label creator -> New label batch 2) Add 2 items 3) Select the checkbox next to an item you just added and click 'Remove selected items' 4) A pop-up will say that you are yet to select an item. (Please ignore the mistake in the pop-up message, this is being fixed in Bug 15662) 5) Apply patch and refresh. Confirm there is now a 'Delete batch' button in the toolbar 6) Select one item and click 'Remove selected items' 7) Confirm the item is deleted from the batch 8) Select the final item and click 'Remove selected items' 9) Pop-up message will tell you that deleting this item will delete the batch. Click 'Okay' 10) Click 'Delete batch' then 'Okay' 11) Confirm you are redirected to the Labels page and the batch has been deleted. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:09:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:09:36 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 --- Comment #4 from Chris Nighswonger --- (In reply to Jonathan Druart from comment #3) > The translatability issue came from the tag in the middle of the > sentence. > I think we can keep the previous sentence: > [% duplicate_count %] duplicate item(s) found and removed from batch [% > batch_id %]. > > Which looks better then the new one: > Duplicate item(s) removed from batch number [% batch_id %]: [% > duplicate_count %] The original flows better than the proposed replacement imho. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:11:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:11:36 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 --- Comment #7 from Jonathan Druart --- This patch update the label editor behaviors with the patroncard ones, but there are still lot of issues: 1/ You can select all the items and click on "remove selected" without any warning 2/ You can delete the last item clicking on the "Delete" button ("actions" column) In these 2 cases, the batch_id parameter is passed but is wrong. If you add a new batch on the resulting screen, the batch_id of the deleted batch will be displayed, but a new one will be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:18:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:18:51 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:18:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:18:55 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47134|0 |1 is obsolete| | Attachment #47135|0 |1 is obsolete| | --- Comment #67 from Kyle M Hall --- Created attachment 47338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47338&action=edit Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:19:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:19:04 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #68 from Kyle M Hall --- Created attachment 47339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47339&action=edit Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:23:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:23:24 +0000 Subject: [Koha-bugs] [Bug 15353] patron image disappears when on fines tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 --- Comment #4 from Kyle M Hall --- Created attachment 47340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47340&action=edit Bug 15353: Display the patron image where needed Patched needed rebasing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:23:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:23:49 +0000 Subject: [Koha-bugs] [Bug 15353] patron image disappears when on fines tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #46366|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:30:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:30:27 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46731|0 |1 is obsolete| | Attachment #46732|0 |1 is obsolete| | Attachment #46733|0 |1 is obsolete| | Attachment #46734|0 |1 is obsolete| | Attachment #46735|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall --- Created attachment 47341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47341&action=edit Bug 14828: Add Koha::ItemType[s] classes Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:30:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:30:35 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #28 from Kyle M Hall --- Created attachment 47342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47342&action=edit Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used This patch mainly replaces C4::ItemType->all with Koha::ItemTypes->search. Test plan: At the places where the C4::ItemType module was used, confirm there is no regression: - acqui/neworderempty.pl - catalogue/itemsearch.pl - admin/item_circulation_alerts.pl and the 2 cataloguing plugins: - marc21_linking_section.pl - unimarc_field_4XX.pl QA step: prove t/db_dependent/HoldsQueue.t should return green Note that the tests were buggy. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:30:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:30:38 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #29 from Kyle M Hall --- Created attachment 47343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47343&action=edit Bug 14828: Remove old package and tests C4::ItemType can be now removed safely, there is no use of this module. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:30:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:30:43 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #31 from Kyle M Hall --- Created attachment 47345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47345&action=edit Bug 14828 [QA Followup] - Hide in OPAC checkbox not checked in editor even if enabled Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:30:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:30:41 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #30 from Kyle M Hall --- Created attachment 47344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47344&action=edit Bug 14828: use Koha::ItemType[s] in admin/itemtypes Test plan: Add/edit/remove item types from the administration module (admin/itemtypes.pl). You should get message feedback after each action. Don't forget to play with the image and try to remove an item type linked to records (you should not be able to remove it). Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:36:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:36:05 +0000 Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 14:39:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 13:39:00 +0000 Subject: [Koha-bugs] [Bug 12636] Batch patron modification should not update with unique patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12636 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46373|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 47346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47346&action=edit Bug 12636: Do not display unique patron attributes in the batch patron modification Batch patron modification should not offer to update patron attributes with values which are designated as unique since such attributes are required to be unique to a single patron. Test plan: Create some patron attributes, some should be unique. Use the batch patron modification tool to modify patrons. With this patch, the patron attributes marked as unique won't be display anymore. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:05:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:05:56 +0000 Subject: [Koha-bugs] [Bug 13811] Silent Cronjobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13811 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:09:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:09:01 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|philippe.blouin at inlibro.com |charles.farmer at inlibro.com --- Comment #2 from Blou --- See bug title and these other corrections demanded on #8753 --- Minor points: Spotted "FIXME: That ugly shift-grep contraption". The term "Forgotten password recovery" sounds funny to me (no native speaker :) Is Password recovery not sufficient? Are dots in the unique key (especially at the end) user friendly? ---- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:09:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:09:16 +0000 Subject: [Koha-bugs] [Bug 15652] Allow current date in datepicker on opac-reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15652 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:09:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:09:18 +0000 Subject: [Koha-bugs] [Bug 15652] Allow current date in datepicker on opac-reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15652 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47262|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 47347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47347&action=edit Bug 15652: Allow current date in datepicker on opac-reserve If you enable AllowHoldDateInFuture (and its OPAC variant), you get an additional "Hold starts on date". In that field and in "Hold not needed after" it was not possible to enter the current date. Although it does not really make any difference if you leave the startdate empty or put the current date in it, we concluded that it still makes a psychological difference. Some patrons were confused when placing a hold because the first date to select was tomorrow. Instead of telling them "Yes, but you can leave it empty", we should just allow the current date as well. The expiration date ("not needed after") also started on tomorrow. (This field can really be empty.) But there is actually no reason not to allow today here too. If the patron only wants it today, why force tomorrow? How is this arranged? Well, this is one of the simplest Koha patches ever written. It only changes the minDate option of both date pickers in one line from 1 to 0. Test plan: [1] Allow future hold dates via systempreferences. [2] Verify that you can enter today in both fields. [3] Put today in start and expiration date. Place the hold and verify that you can confirm the hold, check out and check in again. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:11:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:11:17 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15585 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:11:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:11:17 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8753 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:23:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:23:26 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44442|0 |1 is obsolete| | Attachment #44674|0 |1 is obsolete| | Attachment #44676|0 |1 is obsolete| | Attachment #47307|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 47348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47348&action=edit Bug 14532: Add --exclude-indexes switch to koha-dump This patch changes the default behaviour of koha-dump to make the inclusion of Zebra indexes on the dump optional. It does so by introducing a new option switch that allows to have the previous behaviour in place. To test: - Run $ koha-dump your_instance - Save a copy of the dump files - Apply the patch / extract the koha-dump script - Run the new one: $ koha-dump your_instance => SUCCESS: Verify the contents of the dump are the same (i.e. it includes /var/lib/koha/your_instance) - Run with the new switch: $ koha-dump --exclude-indexes your_instance => SUCCESS: The dump does not contain stuff from /var/lib/koha/your_instance - Go through the rest of the new option switches -h | --help -q | --quiet => SUCCESS: They work as expected. - Sign off :-D Regards Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:23:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:23:23 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:23:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:23:30 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 --- Comment #16 from Jonathan Druart --- Created attachment 47349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47349&action=edit Bug 14532 - fix syntax error in script Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:23:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:23:33 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 --- Comment #17 from Jonathan Druart --- Created attachment 47350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47350&action=edit Bug 14532: fixed the "empty member" problem PS: thanks to Olly Betts for knowing weird bash constuctions. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:23:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:23:37 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 --- Comment #18 from Jonathan Druart --- Created attachment 47351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47351&action=edit Bug 14532: (followup) Use tar's --exclude for simplicity This patch creates an --exclude definition for the tar command so it is easier to stack excluded stuff. It does so for the authority and biblio indexes if --exclude-indexes is passed. A side effect from this, is that uploads and plugins are still backed up, as Jonathan noted. Regards Edit: Fixed a weird quoting problem. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:25:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:25:09 +0000 Subject: [Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #12 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:26:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:26:11 +0000 Subject: [Koha-bugs] [Bug 15680] New: Fresh install of Koha cannot find any dependencies Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Bug ID: 15680 Summary: Fresh install of Koha cannot find any dependencies Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It seems that on master, after clearing my database, one can no longer perform a fresh install. Koha seems to fail to find any of the installed Perl modules it depends on. This happens on master. The latest 3.22 finds the dependencies without a problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:26:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:26:37 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 --- Comment #5 from Owen Leonard --- (In reply to Aleisha Amohia from comment #4) > I see what you mean. Perhaps only on the pages where there is also a > check-in tab? Since they also need the barcode for that? I agree with this. I think the presence of the check-in tab is a good indicator that the Renew tab fits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:27:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:27:29 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #252 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:30:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:30:53 +0000 Subject: [Koha-bugs] [Bug 15642] Batch patron deletion should not delete patrons with issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Nick, tools/cleanborrowers.pl already call GetBorrowersToExpunge, so I am not sure this change is needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:32:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:32:23 +0000 Subject: [Koha-bugs] [Bug 15680] Fresh install of Koha cannot find any dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6679 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 [Bug 6679] Fixing code so it passes basic Perl::Critic tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:32:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:32:22 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #13 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:32:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:32:23 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15680 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 [Bug 15680] Fresh install of Koha cannot find any dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:33:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:33:29 +0000 Subject: [Koha-bugs] [Bug 15642] Batch patron deletion should not delete patrons with issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 --- Comment #6 from Jonathan Druart --- What's the point of this _skip_borrowers_with_nonzero_balance subroutine actually? :) >From my understanding, it removes the patrons with charges. In misc/cronjobs/delete_patrons.pl it's done with: 68 my $flags = C4::Members::patronflags( $member ); 69 if ( my $charges = $flags->{CHARGES}{amount} ) { 70 say "Failed to delete patron $borrowernumber: patron has $charges in fines"; 71 next; 72 } Should not we simply move this check to the GetBorrowersToExpunge subroutine? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:34:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:34:02 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #61 from Jonathan Druart --- Blocked by bug 15642. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:34:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:34:46 +0000 Subject: [Koha-bugs] [Bug 15530] Editing a course item via a disabled course disables it even if it is on other enabled courses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15530 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #15 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:36:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:36:41 +0000 Subject: [Koha-bugs] [Bug 12045] Transfer impossible if barcode includes spaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12045 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:36:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:36:47 +0000 Subject: [Koha-bugs] [Bug 15665] Better wording of error messages when importing MARC frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15665 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | --- Comment #4 from Jonathan Druart --- Aleisha, should not we use the same wording for the 2 alerts? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:37:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:37:41 +0000 Subject: [Koha-bugs] [Bug 15626] koha-remove does not remove log4perl.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15626 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:37:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:37:45 +0000 Subject: [Koha-bugs] [Bug 15680] Fresh install of Koha cannot find any dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:37:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:37:50 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 --- Comment #5 from Owen Leonard --- I can confirm this bug by doing this: 1. Bring up the new patron form. 2. Along with any other required fields, enter '23467890758428435' as the barcode (17 digits). 3. Save the patron record. The barcode will be saved as '2346789075842843' (16 digits, the last digit missing). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:37:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:37:47 +0000 Subject: [Koha-bugs] [Bug 15680] Fresh install of Koha cannot find any dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 --- Comment #1 from Kyle M Hall --- Created attachment 47352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47352&action=edit Bug 15680 - Fresh install of Koha cannot find any dependencies Fixing the evals in PerlModules.pm to pass perl critic has caused a regression. If appears that using a block eval will not work here, at least not in its current form. Test Plan: 1) Delete your database 2) Run the web installer 3) Note Koha says your dependencies need installed 4) Apply this patch 5) Refresh the page 6) Koha should see your dependencies are installed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:43:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:43:23 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 --- Comment #11 from Owen Leonard --- In my opinion a better consistency would be achieved by removing the existing title attributes because they are redundant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:46:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:46:24 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 --- Comment #6 from Katrin Fischer --- +1 :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:49:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:49:32 +0000 Subject: [Koha-bugs] [Bug 15680] Fresh install of Koha cannot find any dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Kyle, I reproduce the issue, and the patch fixes it. The weird thing is that the script now passes perlcritic (changes in perlcritic?) I'd suggest to revert 0e356b214eb049a446a8d089d579775aa49287d7 instead of create a new patch, to make the git log explicit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:49:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:49:44 +0000 Subject: [Koha-bugs] [Bug 15680] Fresh install of Koha cannot find any dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:52:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:52:06 +0000 Subject: [Koha-bugs] [Bug 7224] Allow patrons to pick their own preferred language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7224 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:52:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:52:08 +0000 Subject: [Koha-bugs] [Bug 9388] Accessibility - No feedback when returning book. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9388 --- Comment #7 from Owen Leonard --- I don't think anything has changed since the bug was reported, so probably still valid in the eyes of the reporter. However, since there has been no comment from the original submitter I'm inclined to mark this as "WONTFIX." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:52:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:52:32 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #253 from Jonathan Druart --- (In reply to Julian Maurice from comment #252) > Patch pushed to 3.22.x, will be in 3.22.3 Watch out for bug 15680. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:54:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:54:41 +0000 Subject: [Koha-bugs] [Bug 11556] Send any notice to any patron (or all patrons) on demand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11556 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:55:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:55:44 +0000 Subject: [Koha-bugs] [Bug 15155] Can't call method "truncate" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 1966 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15155 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14717 --- Comment #6 from Jonathan Druart --- See bug 14717, which has been pushed to 3.20.4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:55:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:55:44 +0000 Subject: [Koha-bugs] [Bug 14717] Prevent 0000-00-00 dates in patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15155 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 15:56:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 14:56:08 +0000 Subject: [Koha-bugs] [Bug 11556] Send any notice to any patron (or all patrons) on demand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11556 --- Comment #2 from Viktor Sarge --- +1 for resend. That could also be useful for retrying things like SMS that didn't go through (if there's no smarter way that I'm currently missing) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 16:03:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 15:03:50 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #24 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #19) > I hope to get around to it soon - but the more testing the better. Overdues > are a bit of a complicated matter. We only actively use it with the overdue > and notice triggers - if someone else could verify it works the same as > before without -t that would be helpful. No reasons to worry. Actually, the code part where the triggered condition is executed (if passed), was not touched. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 16:14:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 15:14:24 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 16:14:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 15:14:27 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47335|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy --- Created attachment 47353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47353&action=edit Bug 15240: Do not process issues with a date due later than today There is no need to do this job in Perl, MySQL could do it instead. The idea is to only retrieve the issues info which could be overdued. To test: 1/ Run the script 2/ Apply the patch 3/ Run the script again, notice the exact same results but execution time is faster Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 16:14:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 15:14:34 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #26 from Marcel de Rooy --- Created attachment 47354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47354&action=edit Bug 15240: [QA Follow-up] Minor adjustments This patch does: [1] It removes some unused modules. [2] It adds some options not listed in the synopsis. [3] It removes an unused sql expression from one query. Note: In fines related code the third parameter of CalcFine sometimes is named as days_overdue too. [4] Corrects a few typos in comments or pod. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 16:15:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 15:15:36 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #27 from Marcel de Rooy --- QA Comment: Your change generally looks good to me. But I will be very precise here :) Note that you use TO_DAYS in the query. So you select the current date with all hours too. Formerly, records of today were compared with date_to_run (including time) eliminating the records in hours still to come. As long as $mindays is not zero (from overduerules), these records will be discarded later on (L 544-555) since mindays may not be zero in the code of this script (line 490). Another point is the -date parameter. I am not sure what it actually should do btw, since it is documented rather poorly. Looking through code, it seems to mimic running on a different date (e.g. say -date or -date e.g.). The same argument as above could be repeated for the records of the specific date given via this parameter. This actually brings me to the conclusion that you made a large first step, but the second step would be moving the checks for mindays and maxdays into the SQL statement too. Note that it may run three times with different values for the three triggers. Another report? Related: While testing PREDUE and ODUE, I found that using -n on the command line will generate the error that the print notice for PREDUE and ODUE are not found. Copying them from email, revealed that PREDUE should use a block ... in order to have the title displayed, or should use . In a new installation this should be corrected. If you confirm that, we could address it on a new report too? I used the opportunity to add a few minor adjustments in a follow-up. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 16:26:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 15:26:40 +0000 Subject: [Koha-bugs] [Bug 14855] Resend notices in Notices tab with AJAX + REST In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14855 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 16:27:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 15:27:41 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 16:36:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 15:36:56 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC|cbrannon at cdalibrary.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 16:48:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 15:48:29 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #54 from Alex Arnaud --- Created attachment 47355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47355&action=edit Bug 14695 - Warn librarian if max_holds_per_record is reached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 17:00:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 16:00:22 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #55 from Alex Arnaud --- The last patch is a proposed solution to warn librarian if placing hold when max_holds_per_record is reached. Sorry for my comment about ILSDI: It works well. And i think we should keep the ability to hold the same item several time insofar as we could ask it at different dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 17:05:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 16:05:44 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #206 from Marcel de Rooy --- Brendan It seems that you forgot to move the atomicupdate revision to the code in updatedatabase. Currently, part of your job as RM :) Marcel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 17:12:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 16:12:03 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #28 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #27) > Another point is the -date parameter. I am not sure what it actually should > do btw, since it is documented rather poorly. Looking through code, it seems > to mimic running on a different date (e.g. say -date or -date > e.g.). The same argument as above could be repeated for the > records of the specific date given via this parameter. That's exactly what it does. > This actually brings me to the conclusion that you made a large first step, > but the second step would be moving the checks for mindays and maxdays into > the SQL statement too. Note that it may run three times with different > values for the three triggers. Another report? I had in mind it was not possible, because of the calendar checks. But looking at the code again, it seems possible. > Related: While testing PREDUE and ODUE, I found that using -n on the command > line will generate the error that the print notice for PREDUE and ODUE are > not found. Copying them from email, revealed that PREDUE should use a block > ... in order to have the title displayed, or should use > . In a new installation this should be corrected. If you > confirm that, we could address it on a new report too? Indeed, ODUE.print should exist, we could add the print template if it does not exist. PREDUE is used by advance_notices.pl > I used the opportunity to add a few minor adjustments in a follow-up. They looks good to me. > Passed QA Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 17:13:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 16:13:57 +0000 Subject: [Koha-bugs] [Bug 15680] Fresh install of Koha cannot find any dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 --- Comment #3 from Kyle M Hall --- (In reply to Jonathan Druart from comment #2) > Kyle, I reproduce the issue, and the patch fixes it. > The weird thing is that the script now passes perlcritic (changes in > perlcritic?) > I'd suggest to revert 0e356b214eb049a446a8d089d579775aa49287d7 instead of > create a new patch, to make the git log explicit. That is most odd! I'll take care of that reversion! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 17:17:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 16:17:15 +0000 Subject: [Koha-bugs] [Bug 15680] Fresh install of Koha cannot find any dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs Signoff |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 17:29:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 16:29:13 +0000 Subject: [Koha-bugs] [Bug 15681] New: Add option to create hold request when checking out an item already on loan Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 Bug ID: 15681 Summary: Add option to create hold request when checking out an item already on loan Change sponsored?: --- Product: Koha Version: master Hardware: PC OS: All Status: NEW Severity: enhancement Priority: P3 Component: Circulation Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 47356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47356&action=edit Screenshot of the proposed change Bug 1983 adds a link to place a hold on an item instead of checking it out when the item is already checked out. Sorry to be late to the party, but I have a couple of issues with the way it works: 1. Saying "click here" is almost always redundant, and doesn't represent the different ways in which users might interact with links (touchscreen? keyboard navigation?). 2. I'm concerned that the link is not very visible and doesn't well represent what is going to happen next. I think the link is a third option with equal weight as the confirm and cancel buttons and should be represented as a button even if the button text makes it big. I would love to hear comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 17:29:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 16:29:13 +0000 Subject: [Koha-bugs] [Bug 1983] Add option to create hold request when checking out an item already on loan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1983 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15681 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 17:30:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 16:30:20 +0000 Subject: [Koha-bugs] [Bug 15681] Improve visibility of place hold option when checking out an item already checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15681 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add option to create hold |Improve visibility of place |request when checking out |hold option when checking |an item already on loan |out an item already checked | |out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 17:36:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 16:36:22 +0000 Subject: [Koha-bugs] [Bug 15682] New: Merging records from cataloguing search only allows to merge 2 records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682 Bug ID: 15682 Summary: Merging records from cataloguing search only allows to merge 2 records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When merging from the list, you can now merge multiple records. But when merging from the cataloguing search, a javascript alert tells you that only 2 records can be selected for merging. Obviously... both should work the same and allow for multiple records to be merged at once. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 17:37:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 16:37:31 +0000 Subject: [Koha-bugs] [Bug 15682] Merging records from cataloguing search only allows to merge 2 records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 [Bug 8064] Merge several biblio records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 17:37:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 16:37:31 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15682 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682 [Bug 15682] Merging records from cataloguing search only allows to merge 2 records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 17:49:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 16:49:32 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Summary|Allow multiple title-level |Place multiple holds at |holds for the same record |once for the same record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 17:53:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 16:53:33 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #1 from Alex Arnaud --- Bug 14695 allows to place multiple holds for the same record. It would be nice to choose the numbers of items (or select several items) at once instead of making X times the same operation. We want this behavior on staff and OPAC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 17:55:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 16:55:21 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 18:01:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 17:01:47 +0000 Subject: [Koha-bugs] [Bug 15353] patron image disappears when on fines tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release - Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 18:05:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 17:05:40 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #207 from Brendan Gallagher --- (In reply to Marcel de Rooy from comment #206) > Brendan > It seems that you forgot to move the atomicupdate revision to the code in > updatedatabase. > Currently, part of your job as RM :) > > Marcel Yes thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 18:40:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 17:40:44 +0000 Subject: [Koha-bugs] [Bug 15683] New: Inconsistent population of lastreneweddate between AddRenewal and AddIssue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15683 Bug ID: 15683 Summary: Inconsistent population of lastreneweddate between AddRenewal and AddIssue Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When lastreneweddate is populated via C4::Circulation::AddRenewal, it is added as a date, whereas C4::Circulation::AddIssue stores it as DateTime, i.e. hours, minutes and seconds are populated. Because of hourly loans, I think that it only makes sense to store lastreneweddate as a full datetime. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 19:30:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 18:30:00 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #208 from Kyle M Hall --- Created attachment 47357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47357&action=edit Bug 8753 [QA Followup] - Add notice to translations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 19:54:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 18:54:14 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- (In reply to Mike from comment #8) > Hello. > > I vote for solutions 1 or 4. > > A twist one 1, we are already passing a value which tells us if we are looking at authorities or not, if we pass that down to the next layer of functions also, as the new parameter you were talking about, that would be an ok way of doing it I think? 4/ would need massive amounts of testing. 1/ only effects the import and export so I think is a lot safer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 19:56:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 18:56:15 +0000 Subject: [Koha-bugs] [Bug 15677] Misconfigured anonymous patron allows checkouts to multiple patrons. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15677 --- Comment #2 from Barton Chittenden --- (In reply to Jonathan Druart from comment #1) > It's the expected behavior: the pref is not set correctly, it's a > configuration issue. > You should also get a warning on the about page. Not allowing the item to be checked in may expected behavior (I'm willing to argue the point), but allowing the item to be checked out to two patrons at the same time is *definitely* a bug. --Barton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 20:18:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 19:18:56 +0000 Subject: [Koha-bugs] [Bug 13420] sorting on volume number is not sorting right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Nicole C. Engard --- *** This bug has been marked as a duplicate of bug 12375 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 20:18:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 19:18:56 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #54 from Nicole C. Engard --- *** Bug 13420 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 20:19:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 19:19:21 +0000 Subject: [Koha-bugs] [Bug 13420] sorting on volume number is not sorting right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 20:19:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 19:19:26 +0000 Subject: [Koha-bugs] [Bug 13420] sorting on volume number is not sorting right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12375 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 20:19:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 19:19:26 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13420 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 20:20:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 19:20:08 +0000 Subject: [Koha-bugs] [Bug 13420] sorting on volume number is not sorting right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 20:20:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 19:20:25 +0000 Subject: [Koha-bugs] [Bug 13420] sorting on volume number is not sorting right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 20:20:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 19:20:37 +0000 Subject: [Koha-bugs] [Bug 13420] sorting on volume number is not sorting right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 --- Comment #4 from Nicole C. Engard --- This is still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 20:20:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 19:20:46 +0000 Subject: [Koha-bugs] [Bug 13420] sorting on volume number is not sorting right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12375 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 [Bug 12375] Store serials enumeration data in separate fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 20:20:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 19:20:46 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13420 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 [Bug 13420] sorting on volume number is not sorting right -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 20:26:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 19:26:12 +0000 Subject: [Koha-bugs] [Bug 15684] New: can't import quotes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 Bug ID: 15684 Summary: can't import quotes Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 47358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47358&action=edit sample quotes We can't seem to import quotes anymore. I just did on 3.20, but in 3.22 when the file loads up clicking the 'save' button does nothing. This happens on a few sites. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 20:53:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 19:53:18 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 21:32:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 20:32:59 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 21:33:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 20:33:12 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 --- Comment #3 from Charles Farmer --- Created attachment 47359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47359&action=edit Bug 15585 - Move C4::Passwordrecovery to the new namespace Koha::Patron::Password::Reset As promised, here is the long-awaited sequel to #8753. What has changed : - The Koha::Patron::Password::Reset is now used in place of C4::Passwordrecovery - That ugly shift-grep contraption is no more (goodbye old friend) - The generated unique key won't end in a dot anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 21:38:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 20:38:53 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 --- Comment #4 from Charles Farmer --- Please confirm that Kyle's latest attachment in #8753 fixes what Marcel de Rooy spoke about (missing notice in languages). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 21:51:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 20:51:29 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #32 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 22:00:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 21:00:13 +0000 Subject: [Koha-bugs] [Bug 12636] Batch patron modification should not update with unique patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12636 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 22:25:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 21:25:10 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 22:25:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 21:25:13 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47326|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia --- Created attachment 47360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47360&action=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Click 'Import' into your new authority type (so you don't overwrite any important existing authority types) 7) Select the file you just exported and click 'Import' 8) Confirm you are taken to auth_tag_structure.pl 9) Go back to Authority types 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Go to Admin -> MARC bibliographic framework 12) Confirm that the 'Export' and 'Import' functions still work here as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 22:28:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 21:28:16 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Aleisha Amohia --- Hi Mirko, patch applied fine but I got a software error while going on to a biblio detail page (ie catalogue/detail.pl). Can't locate WWW/YouTube/Download.pm in @INC (@INC contains: /home/vagrant/kohaclone /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /home/vagrant/kohaclone/C4/HTML5Media.pm line 26. BEGIN failed--compilation aborted at /home/vagrant/kohaclone/C4/HTML5Media.pm line 26. Compilation failed in require at /home/vagrant/kohaclone/catalogue/detail.pl line 42. BEGIN failed--compilation aborted at /home/vagrant/kohaclone/catalogue/detail.pl line 42. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 22:33:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 21:33:03 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #19 from Marc V?ron --- (In reply to Jonathan Druart from comment #18) (...) > I don't manage to force the leading zeros, suggestions are welcome. The date validation seems to be on the datepicker's onClose and change functions only, but there is no onclick function directly on the Submit button. I think that a final date validation could take place there with a function that returns false if the date is not valid. Maybe the same function could try to do some formatting (1/1/2016 -> 01/01/2016 etc.) before validation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 22:53:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 21:53:09 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Patch complexity|Small patch |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 22:53:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 21:53:12 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47276|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia --- Created attachment 47361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47361&action=edit Bug 12051: Adds a Renew tab to the staff client To test: 1) Apply patch 2) Confirm that there is now a Renew tab on the pages where there is also a Check-in tab only 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:02:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:02:30 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47361|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia --- Created attachment 47362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47362&action=edit Bug 12051: Adds a Renew tab to the staff client To test: 1) Apply patch 2) Confirm that there is now a Renew tab on the pages where there is also a Check-in tab only 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages Had to fix some numbering -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:05:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:05:07 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 --- Comment #5 from Aleisha Amohia --- I changed it so that it would be consistent with the duplicates message for Patron Card Creator, see Bug 15573 which has been pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:08:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:08:38 +0000 Subject: [Koha-bugs] [Bug 15665] Better wording of error messages when importing MARC frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15665 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:08:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:08:41 +0000 Subject: [Koha-bugs] [Bug 15665] Better wording of error messages when importing MARC frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15665 --- Comment #5 from Aleisha Amohia --- Created attachment 47363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47363&action=edit Bug 15665: Better wording of error messages when importing MARC frameworks UPDATE: Making error messages the same To test: 1) Go to Admin -> MARC frameworks 2) Click Import next to any framework. You won't actually be overwriting or importing anything as this is only a string fix, so it can be an existing framework 3) Click the Import button without attaching any file. Confirm it says "Please select a spreadsheet (.csv, .ods, .xml) file." and that this makes sense to you 4) Attempt to attach a file that is not a .csv, .ods or .xml file. You should instantly get an error message saying "Please select a CSV (.csv), ODS (.ods) or XML (.xml) file." Confirm this shows up and makes sense to you Signed-off-by: Hector Castro Rewording Ok. Works as described -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:11:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:11:37 +0000 Subject: [Koha-bugs] [Bug 15665] Better wording of error messages when importing MARC frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15665 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47308|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:18:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:18:54 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47360|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia --- Created attachment 47364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47364&action=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Click 'Import' into your new authority type (so you don't overwrite any important existing authority types) 7) Select the file you just exported and click 'Import' 8) Confirm you are taken to auth_tag_structure.pl 9) Go back to Authority types 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Go to Admin -> MARC bibliographic framework 12) Confirm that the 'Export' and 'Import' functions still work here as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:23:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:23:26 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 --- Comment #6 from Aleisha Amohia --- Oh okay I see! So this only (In reply to Owen Leonard from comment #5) > I can confirm this bug by doing this: > > 1. Bring up the new patron form. > 2. Along with any other required fields, enter '23467890758428435' as the > barcode (17 digits). > 3. Save the patron record. The barcode will be saved as '2346789075842843' > (16 digits, the last digit missing). I don't get your problem, when I paste that number it removes the 5 straight away from the text box. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:24:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:24:07 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 --- Comment #12 from Aleisha Amohia --- (In reply to Owen Leonard from comment #11) > In my opinion a better consistency would be achieved by removing the > existing title attributes because they are redundant. No problem! Will make a patch that removes them now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:26:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:26:22 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:26:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:26:27 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47150|0 |1 is obsolete| | Attachment #47151|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia --- Created attachment 47365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47365&action=edit Bug 15640: Removing title for links on circulation-home.tt To test: Go to Circulation and ensure there are no titles on hover over the links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:39:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:39:47 +0000 Subject: [Koha-bugs] [Bug 13420] sorting on volume number is not sorting right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 --- Comment #5 from Aleisha Amohia --- Can you do a screenshot of the full page please so I can see where this is and how to reproduce it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:45:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:45:00 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #18 from Katrin Fischer --- Hi, I am sorry, but I think the proposed solution doesn't work. I tested using a 440 with characters outside latin1 - and the new function totally breaks the link. My example was ?? (the word for Japan in Japanese) which is turned into ?? with the patch applied. I'd be much happier with removing or encoding the known to be problematic characters in order to avoid problems with characters not in the list. Another small thing: patches only touch the OPAC, but we should also include the intranet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:53:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:53:55 +0000 Subject: [Koha-bugs] [Bug 15531] Add support for standing orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15685 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:53:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:53:55 +0000 Subject: [Koha-bugs] [Bug 15685] New: Allow creation of items (AcqCreateItem) to be customizable per-basket Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Bug ID: 15685 Summary: Allow creation of items (AcqCreateItem) to be customizable per-basket Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:54:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:54:21 +0000 Subject: [Koha-bugs] [Bug 15531] Add support for standing orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 --- Comment #1 from Jesse Weaver --- Last item (Creation of items upon receive customizable per-basket) split off into bug 15685. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:56:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:56:59 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47357|0 |1 is obsolete| | --- Comment #209 from Katrin Fischer --- Created attachment 47366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47366&action=edit [PASSED QA] Bug 8753 [QA Followup] - Add notice to translations Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:57:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:57:20 +0000 Subject: [Koha-bugs] [Bug 15531] Add support for standing orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 27 23:57:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 22:57:23 +0000 Subject: [Koha-bugs] [Bug 15531] Add support for standing orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 --- Comment #2 from Jesse Weaver --- Created attachment 47367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47367&action=edit Bug 15531: Add support for standing orders This allows creation of special baskets that include standing orders. These orders do not have a known quantity (and may not have a known price in advance). Upon receipt, the received items are split into a new completed order. Test plan: 1) Run updatedatabase.pl. 2) Run prove t/db_dependent/Acquisition/StandingOrders.t . (and the other Acquisition tests). 3) Create a new basket, mark it as a standing order basket. 4) Add an order to this basket, and notice that the quantity field is missing (and thus not required). 5) Receive items for this order, and notice that the original order is unchanged. The new child order line should have the correct price and quantity information. (Note: the QA tools output what seems to be a spurious spelling error for Test::More's "isnt" in StandingOrders.t.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 00:11:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 23:11:44 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- I just tested Kyle's follow-up for the notices - that should be taken care of. Hint: there is a test to catch that problem - xt/sample_notices.t :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 00:11:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 23:11:53 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #92 from David Cook --- Just a FYI for people testing out permanent uploads. If you're using "/tmp" as the "upload_path", you might want to check if you're using "PrivateTmp". I'm using openSUSE 13.2 and when I look at /usr/lib/systemd/system/apache2.service, I see "PrivateTmp=true". I think that file is located elsewhere on Debian, but I'll leave that up to others to find that. In any case, instead of creating "/tmp/koha_upload/36411ad1c1adeb6d0d774f5282fe8790_test1" when permanently uploading a file, it creates "/tmp/systemd-private-bf25b4b0e5994604b54422ea98e4b8c8-apache2.service-PJS1uF/tmp/koha_upload/36411ad1c1adeb6d0d774f5282fe8790_test1". Fortunately, as far as I can tell, this doesn't create a problem for Koha, at least in the short run. While Koha might still think it's looking in "/tmp/koha_upload", it's actually looking in "/tmp/systemd-private-bf25b4b0e5994604b54422ea98e4b8c8-apache2.service-PJS1uF/tmp/koha_upload". But of course if you go looking for a file in "/tmp/koha_upload", you're going to be looking for a long time. Of course, you'd never actually use "/tmp" for storing a file permanently, as "/tmp" should be deleted when your server next reboots (or if some other clean-up job is running). If you do something like /home/dcook/koha/uploads, you'll be fine. The file will be stored where you expect it to be stored. Not a problem, but just a FYI to developers and testers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 00:15:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 23:15:20 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Mirko Tietgen --- Aleisha, please see comment 9 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168#c9 You need to have the package libwww-youtube-download-perl installed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 00:42:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 23:42:19 +0000 Subject: [Koha-bugs] [Bug 15514] New professional cataloguing editor does not handle repeatable fields correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15514 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 00:42:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 23:42:21 +0000 Subject: [Koha-bugs] [Bug 15514] New professional cataloguing editor does not handle repeatable fields correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15514 --- Comment #3 from Jesse Weaver --- Created attachment 47368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47368&action=edit Bug 15514: Fix error with certain repeatable fields in Rancor Apologies for the lack of test plan. Joubu, could you verify that this fixes your error? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 00:42:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 23:42:36 +0000 Subject: [Koha-bugs] [Bug 15686] New: Rename "item level holds" circ rule column to "OPAC item level holds" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686 Bug ID: 15686 Summary: Rename "item level holds" circ rule column to "OPAC item level holds" Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 5786 moved the OPACItemHolds sys pref setting to the Circulation Rules table. However, the naming of the new circ rules column is quite confusing. It is called "Item level holds" which makes it sound like this setting controls the item level holds placing from anywhere in the system (staff and OPAC sides) Instead, the setting only affects item level hold placing from the OPAC side. Should this column then be renamed to "OPAC item level holds"?, so it's not so confusing? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 00:42:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 23:42:36 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds system preferences to the Circulation Matrix In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15686 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 00:46:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 23:46:00 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #210 from Brendan Gallagher --- Follow up Pushed (Jan 27 - 2016) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 00:49:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jan 2016 23:49:55 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump should provide a way to exclude Zebra indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|koha-dump shouldn provide a |koha-dump should provide a |way to exclude Zebra |way to exclude Zebra |indexes |indexes CC| |katrin.fischer at bsz-bw.de --- Comment #19 from Katrin Fischer --- I guess title should be 'should' - not shouldn or shouldn't? Changing it, please change back if wrong! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 01:38:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 00:38:23 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 01:38:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 00:38:26 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47327|0 |1 is obsolete| | --- Comment #15 from Aleisha Amohia --- Created attachment 47369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47369&action=edit [SIGNED-OFF] Bug 14168 - enhance streaming cataloging to include youtube Add optional embedding of YouTube videos via HTML5Media. New syspref: HTML5MediaYouTube: Embed/Don't embed videos. Format WEBM is hardcoded as it is the only format accepted by all modern browsers. Test plan: - apply patch - catalogue a YouTube link in 856$u - turn on HTML5MediaEnabled and HTML5MediaYouTube - open the record in OPAC and staff client, check that the 'Play media' tab is showing and playing the video works. Possible enhancements for followups: - check available formats, offer quality choice - accept official YT URL shortener Signed-off-by: Aleisha Works perfectly! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 03:29:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 02:29:18 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 --- Comment #8 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #7) > This patch update the label editor behaviors with the patroncard ones, but > there are still lot of issues: > 1/ You can select all the items and click on "remove selected" without any > warning > 2/ You can delete the last item clicking on the "Delete" button ("actions" > column) > > In these 2 cases, the batch_id parameter is passed but is wrong. If you add > a new batch on the resulting screen, the batch_id of the deleted batch will > be displayed, but a new one will be used. I think these are separate bugs and they definitely do need fixing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 08:00:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 07:00:53 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hm, yes, I tihnk that's the one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 08:07:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 07:07:15 +0000 Subject: [Koha-bugs] [Bug 15643] Every datepicker on serials expected date column updates top issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15643 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 08:21:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 07:21:16 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #93 from Marcel de Rooy --- (In reply to David Cook from comment #92) > Just a FYI for people testing out permanent uploads. > > If you're using "/tmp" as the "upload_path", you might want to check if > you're using "PrivateTmp". David: I would not recommend to user /tmp for permanent uploads. Note that File::Spec->tmpdir is also used for *temporary* uploads. The default for permanent uploads in Debian packaging is /var/lib/koha/instance/uploads. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 09:06:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 08:06:19 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 09:06:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 08:06:19 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15565 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 [Bug 15565] Place multiple holds at once for the same record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 09:23:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 08:23:47 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 --- Comment #9 from Marc V?ron --- I think there is one more place where the renew tab would make sense: /cgi-bin/koha/circ/returns.pl Use case: A patron who wants to return some books and to renew some others at the same time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 09:31:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 08:31:36 +0000 Subject: [Koha-bugs] [Bug 15687] New: Syntax errors in misc/translator/xgettext.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Bug ID: 15687 Summary: Syntax errors in misc/translator/xgettext.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 6679 It seems that Bug 6679 broke xgettext.pl To reproduce: 1. cd misc/translator 2. perl -cw xgettext.pl Errors: Use of ?PATTERN? without explicit operator is deprecated at xgettext.pl line 51. Number found where operator expected at xgettext.pl line 52, near "$t == C4::TmplTokenType::DIRECTIVE? 1" (Might be a runaway multi-line ?? string starting on line 51) (Missing operator before 1?) "my" variable $t masks earlier declaration in same scope at xgettext.pl line 54. Use of my $_ is experimental at xgettext.pl line 54. "my" variable $t masks earlier declaration in same statement at xgettext.pl line 55. Use of ?PATTERN? without explicit operator is deprecated at xgettext.pl line 55. "my" variable $t masks earlier declaration in same statement at xgettext.pl line 56. String found where operator expected at xgettext.pl line 57, near "''" (Missing semicolon on previous line?) syntax error at xgettext.pl line 52, near "$t == C4::TmplTokenType::DIRECTIVE? 1" syntax error at xgettext.pl line 57, near "''" Global symbol "$x" requires explicit package name at xgettext.pl line 58. syntax error at xgettext.pl line 58, near "} ) " Can't use global @_ in "my" at xgettext.pl line 64, near "= @_" Global symbol "$string" requires explicit package name at xgettext.pl line 66. Global symbol "$token" requires explicit package name at xgettext.pl line 66. Global symbol "$string" requires explicit package name at xgettext.pl line 67. Global symbol "$token" requires explicit package name at xgettext.pl line 69. syntax error at xgettext.pl line 71, near "}" xgettext.pl has too many errors. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 [Bug 6679] Fixing code so it passes basic Perl::Critic tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 09:31:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 08:31:36 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15687 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 [Bug 15687] Syntax errors in misc/translator/xgettext.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 09:33:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 08:33:47 +0000 Subject: [Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 --- Comment #1 from Julian Maurice --- Created attachment 47370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47370&action=edit Bug 15687: Fix xgettext.pl syntax errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 09:33:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 08:33:57 +0000 Subject: [Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 09:35:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 08:35:49 +0000 Subject: [Koha-bugs] [Bug 15688] New: Renew item that is on hold: Display information about hold's patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15688 Bug ID: 15688 Summary: Renew item that is on hold: Display information about hold's patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To reproduce: - Go to Home > Circulation > Renew (/cgi-bin/koha/circ/returns.pl) - Enter the barcode of an item that is on hold for an other patron Result: Warning "Cannot renew: This item is on hold for another patron.", but no information about the patron given. It would be nice to have here the same information as with an attempt to check out the item on the check out page: Item XYZ : (1) has been on hold for ABC (999) at Centerville since 05/01/2016 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 09:47:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 08:47:02 +0000 Subject: [Koha-bugs] [Bug 15643] Every datepicker on serials expected date column updates top issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15643 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47302|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 47371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47371&action=edit Bug 15643 - Every datepicker on serials expected date column updates top issue delete 'expected' and 'supexpected' ids that don't seem useful anymore. Same thing for changeDate2 function Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 09:47:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 08:47:27 +0000 Subject: [Koha-bugs] [Bug 15643] Every datepicker on serials expected date column updates top issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15643 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 09:58:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 08:58:37 +0000 Subject: [Koha-bugs] [Bug 15680] Fresh install of Koha cannot find any dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #4 from Julian Maurice --- This is needed on 3.22.x too, since bug 6679 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 09:59:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 08:59:56 +0000 Subject: [Koha-bugs] [Bug 15680] Fresh install of Koha cannot find any dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 10:08:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 09:08:25 +0000 Subject: [Koha-bugs] [Bug 15689] New: Label editor: Fix issues with wrong batch_id parameter Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15689 Bug ID: 15689 Summary: Label editor: Fix issues with wrong batch_id parameter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org There are issues with the label editor, related to the batch_id: 1/ You can select all the items and click on "remove selected" without any warning 2/ You can delete the last item clicking on the "Delete" button ("actions" column) In these 2 cases, the batch_id parameter is passed but is wrong. If you add a new batch on the resulting screen, the batch_id of the deleted batch will be displayed, but a new one will be used. Copied from the comment by Jonathan Druart on Bug 15663 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663#c7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 10:09:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 09:09:32 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 --- Comment #9 from Marc V?ron --- (In reply to Aleisha Amohia from comment #8) > (In reply to Jonathan Druart from comment #7) > > This patch update the label editor behaviors with the patroncard ones, but > > there are still lot of issues: > > 1/ You can select all the items and click on "remove selected" without any > > warning > > 2/ You can delete the last item clicking on the "Delete" button ("actions" > > column) > > > > In these 2 cases, the batch_id parameter is passed but is wrong. If you add > > a new batch on the resulting screen, the batch_id of the deleted batch will > > be displayed, but a new one will be used. > > I think these are separate bugs and they definitely do need fixing See Bug 15663 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 10:09:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 09:09:41 +0000 Subject: [Koha-bugs] [Bug 15689] Label editor: Fix issues with wrong batch_id parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15689 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15663 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 10:09:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 09:09:41 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15689 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 10:46:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 09:46:23 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #56 from Alex Arnaud --- Created attachment 47372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47372&action=edit Bug 14695 - Don't use holds_to_place_count when checking an item. This fix the following bug: If you select 2 in "Holds to place (count)" and finally check an item, so you get 2 holds for the same item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 10:47:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 09:47:41 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Failed QA --- Comment #4 from Mirko Tietgen --- Does not work for me. Message I received was The following items have been checked out: [% biblio.title %] Thank you for visiting [% branch.branchname %]. (In reply to Kyle M Hall from comment #1) > 1) Ensure dependancies are applied Are there dependencies not listed here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:01:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:01:39 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14100 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 [Bug 14100] Add base to make item types, branch names, sysprefs values and authorised values translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:01:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:01:39 +0000 Subject: [Koha-bugs] [Bug 14100] Add base to make item types, branch names, sysprefs values and authorised values translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13024 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 [Bug 13024] Nonpublic note not appearing in the staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:14:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:14:26 +0000 Subject: [Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Depends on| |13024 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 [Bug 13024] Nonpublic note not appearing in the staff client -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:14:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:14:26 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15431 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431 [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:15:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:15:23 +0000 Subject: [Koha-bugs] [Bug 15516] RFC: Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- (In reply to Julian Maurice from comment #1) > Comments: > - A column is added to the reserves table (reserve_group_id) to group > the reserves that belong together, and an additional table > (reserve_group) with a single column is used to generate an auto > increment ID. I feel that something better can be done... It's because you don't have any other attributes, but I am sure you could find others: for instance a name, a timestamp, etc. It's a 1n relation and it's correctly represented. Maybe you could add a foreign key to borrowers.borrowernumber to list the reserve group of a given patron. > - I don't know how to indicates in the interface that two or more > reserves are only one request in reality. What do you plan to implement next? If the reserve groups were named, and linked to a patron, you could display these infos. > - I'm bad at naming things, and "reserve_group" should probably be > something else. Some for me... but reserve_group sounds not too bad. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:20:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:20:42 +0000 Subject: [Koha-bugs] [Bug 15647] Allow selection of destination email address for print overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15647 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hi all, I know exactly what you are talking about... the general problem is that with the specific setup described, the branchemail is not the email of the library. This causes problems with the print overdues sent by overdue_notices.pl, but also in other places. 2 things we have run into so far: - the admin email shown on the error pages - the HOLDPLACED email Should we deal with those separately or maybe have a general setting to determine which is the email address emails 'to the library' should be sent to? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:22:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:22:22 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47313|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 47373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47373&action=edit Bug 15675 - Add issue_id column to accountlines and use it for updating fines Right now, fines are updated based on the fine description. There are a number of areas where this can go wrong ( date or time format changing, title being modified, etc ). Now that issues has a unique identifier, we should use that for selection and updating of fines. Test Plan: 1) Apply this patch 2) Test creating and updating fines via fines.pl and checking in overdue items. No changes should be noted. 3) prove t/db_dependent/Circulation.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:23:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:23:19 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47314|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 47374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47374&action=edit Bug 15675 - Update Schema file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:27:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:27:24 +0000 Subject: [Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- the translate script is broken as well % ./translate update fr-FR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:27:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:27:32 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47316|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 47375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47375&action=edit Bug 15675 - Fix some missed tab characters, remove old FIXMEs Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:28:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:28:01 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:29:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:29:55 +0000 Subject: [Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical CC| |kyle at bywatersolutions.com --- Comment #3 from Jonathan Druart --- Julian, there are some other occurrences in xgettext.pl which certainly need to be fixed. I think that the easiest way is to revert the original patch. Upgrading to critical. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:33:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:33:58 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47375|0 |1 is obsolete| | --- Comment #9 from Mirko Tietgen --- Created attachment 47376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47376&action=edit Bug 15675 - Fix some missed tab characters, remove old FIXMEs Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:34:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:34:00 +0000 Subject: [Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 --- Comment #4 from Julian Maurice --- (In reply to Jonathan Druart from comment #3) > Julian, there are some other occurrences in xgettext.pl which certainly need > to be fixed. > > I think that the easiest way is to revert the original patch. With the patch, - perl -cw xgettext.pl is OK - ./translate update fr-FR works fine too Why do you think the revert is needed ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:34:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:34:42 +0000 Subject: [Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 --- Comment #5 from Julian Maurice --- s/needed/easiest/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:35:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:35:11 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47376|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:35:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:35:25 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47375|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:35:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:35:44 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Hi Kyle, after thinking some about this, how are we going to deal with multiple fine lines for the same issue? If the item is renewed the due date in issues will change and a new fine line should be generated. The old due date information will then be lost. I wonder if we should store the due date that the fine was generated for additionally to the link in accountlines - in a separate date column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:38:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:38:35 +0000 Subject: [Koha-bugs] [Bug 15514] New professional cataloguing editor does not handle repeatable fields correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15514 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:38:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:38:38 +0000 Subject: [Koha-bugs] [Bug 15514] New professional cataloguing editor does not handle repeatable fields correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15514 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47368|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 47377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47377&action=edit Bug 15514: Fix error with certain repeatable fields in Rancor Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:39:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:39:57 +0000 Subject: [Koha-bugs] [Bug 15514] New professional cataloguing editor does not handle repeatable fields correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15514 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jweaver at bywatersolutions.co | |m --- Comment #5 from Jonathan Druart --- Much better. I now get the "Missing mandatory subfield|tag" error, which is expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:41:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:41:12 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47373|0 |1 is obsolete| | --- Comment #11 from Mirko Tietgen --- Created attachment 47378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47378&action=edit Bug 15675 - Add issue_id column to accountlines and use it for updating fines Right now, fines are updated based on the fine description. There are a number of areas where this can go wrong ( date or time format changing, title being modified, etc ). Now that issues has a unique identifier, we should use that for selection and updating of fines. Test Plan: 1) Apply this patch 2) Test creating and updating fines via fines.pl and checking in overdue items. No changes should be noted. 3) prove t/db_dependent/Circulation.t Signed-off-by: Marc V?ron Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:41:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:41:18 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47374|0 |1 is obsolete| | --- Comment #12 from Mirko Tietgen --- Created attachment 47379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47379&action=edit Bug 15675 - Update Schema file Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:41:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:41:24 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47375|0 |1 is obsolete| | --- Comment #13 from Mirko Tietgen --- Created attachment 47380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47380&action=edit Bug 15675 - Fix some missed tab characters, remove old FIXMEs Signed-off-by: Marc V?ron Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:42:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:42:01 +0000 Subject: [Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:42:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:42:04 +0000 Subject: [Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47370|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 47381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47381&action=edit Bug 15687: Fix xgettext.pl syntax errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:42:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:42:33 +0000 Subject: [Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 --- Comment #7 from Jonathan Druart --- (In reply to Julian Maurice from comment #4) > (In reply to Jonathan Druart from comment #3) > > Julian, there are some other occurrences in xgettext.pl which certainly need > > to be fixed. > > > > I think that the easiest way is to revert the original patch. > > With the patch, > - perl -cw xgettext.pl is OK > - ./translate update fr-FR works fine too > > Why do you think the revert is needed ? Indeed, sorry. Everything is fine with the patch applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:51:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:51:44 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46693|0 |1 is obsolete| | Attachment #46694|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 47382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47382&action=edit Bug 15582: Ability to block auto renewals if OPACFineNoRenewals is reached If a patron owes more than the OPACFineNoRenewals value, the issue won't be auto renewed anymore (driven by the new pref OPACFineNoRenewalsBlockAutoRenew). Test plan: Note: You will have to manually change data in your DB, make sure you have access to the sql cli. 1/ Set the OPACFineNoRenewals to 5 (for instance) 2/ Set OPACFineNoRenewalsBlockAutoRenew to block 3/ Check an item out to a patron and mark is as an auto renewal 4/ Make sure the patron does not have any fees or charges. 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed 6/ Create an invoice for this patron with a amount > OPACFineNoRenewals (6 for instance) 7/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed. 8/ Set OPACFineNoRenewalsBlockAutoRenew to allow 9/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:52:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:52:01 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 --- Comment #6 from Jonathan Druart --- Created attachment 47383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47383&action=edit Bug 15582: DB changes - add new pref MaxOutstandingBlockAutoRenew Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:53:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:53:38 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the max outstanding balance is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47383|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 47384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47384&action=edit Bug 15582: DB changes - add new pref OPACFineNoRenewalsBlockAutoRenew Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 11:54:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 10:54:10 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Ability to block auto |Ability to block auto |renewals if the max |renewals if the |outstanding balance is |OPACFineNoRenewals amount |reached |is reached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 12:33:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 11:33:39 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 12:34:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 11:34:33 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 13:11:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 12:11:00 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Barry Cannon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40988|0 |1 is obsolete| | CC| |bc at interleaf.ie --- Comment #3 from Barry Cannon --- Created attachment 47385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47385&action=edit Checks current URL and connects to appropriate google resource This patch adds prefix variable to the google-jackets.js file. This detects the current URL prefix and uses that to connect to google to retrieve images. Test Plan: 1) Enable Google Jackets 2) Ensure the Koha OPAC instance is configued to use HTTPS 3) Confirm Google jackets display correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 13:31:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 12:31:14 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 13:31:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 12:31:56 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 13:33:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 12:33:57 +0000 Subject: [Koha-bugs] [Bug 8374] Option to print all entries of a list in a user friendly format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8374 Carolina Andreu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carol.andreu at masmedios.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 13:49:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 12:49:03 +0000 Subject: [Koha-bugs] [Bug 14606] Donate to the Koha International Fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #10 from Mirko Tietgen --- This could use an update. I have been asked about donation options, but I have no idea where to send people for more information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 13:50:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 12:50:57 +0000 Subject: [Koha-bugs] [Bug 15427] Allow db connections using TLS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 --- Comment #2 from Mirko Tietgen --- Can this be tested locally or do I need to set up an external MySQL DB? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 13:55:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 12:55:33 +0000 Subject: [Koha-bugs] [Bug 15665] Better wording of error messages when importing MARC frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15665 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 13:55:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 12:55:37 +0000 Subject: [Koha-bugs] [Bug 15665] Better wording of error messages when importing MARC frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15665 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47363|0 |1 is obsolete| | --- Comment #6 from Mirko Tietgen --- Created attachment 47386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47386&action=edit Bug 15665: Better wording of error messages when importing MARC frameworks UPDATE: Making error messages the same To test: 1) Go to Admin -> MARC frameworks 2) Click Import next to any framework. You won't actually be overwriting or importing anything as this is only a string fix, so it can be an existing framework 3) Click the Import button without attaching any file. Confirm it says "Please select a spreadsheet (.csv, .ods, .xml) file." and that this makes sense to you 4) Attempt to attach a file that is not a .csv, .ods or .xml file. You should instantly get an error message saying "Please select a CSV (.csv), ODS (.ods) or XML (.xml) file." Confirm this shows up and makes sense to you Signed-off-by: Hector Castro Rewording Ok. Works as described Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 13:57:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 12:57:36 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 13:57:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 12:57:40 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47365|0 |1 is obsolete| | --- Comment #14 from Mirko Tietgen --- Created attachment 47387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47387&action=edit Bug 15640: Removing title for links on circulation-home.tt To test: Go to Circulation and ensure there are no titles on hover over the links Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:00:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:00:29 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47053|0 |1 is obsolete| | --- Comment #5 from Mirko Tietgen --- Created attachment 47388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47388&action=edit 15465 - Created README.md file for github Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:00:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:00:26 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:01:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:01:24 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #6 from Mirko Tietgen --- I am not sure about the logo choice, maybe it would be better to use the regular black-on-white one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:04:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:04:57 +0000 Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #11 from Mirko Tietgen --- Are there good instructions on how to set up a test environment for shibboleth patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:06:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:06:48 +0000 Subject: [Koha-bugs] [Bug 15169] Add for NORMARC transformation to new metadata formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15169 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no, | |mirko at abunchofthings.net Status|Needs Signoff |In Discussion --- Comment #7 from Mirko Tietgen --- Added Magnus and set to in discussion. Discuss. ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:08:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:08:19 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #21 from Mirko Tietgen --- I assume Robin is not going to work on this any longer? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:10:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:10:42 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:13:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:13:10 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 --- Comment #7 from Owen Leonard --- (In reply to Aleisha Amohia from comment #6) > when I paste that number it removes the 5 straight > away from the text box. Okay, my mistake. When I tested it I could have sworn the field let me put in a longer number. Either way, if the user isn't carefully watching the number go in they will not be aware that something is wrong. Imagine scanning a barcode -- will the user visually confirm that the number matches what they scanned? This isn't something which is necessarily badly broken, it's just something we can do better with. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:21:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:21:16 +0000 Subject: [Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 --- Comment #4 from Fr?d?ric Demians --- Seems OK to me, except that you're creating a 'prefix' variable which pollutes the Javascript global namespace. Your variable name could potentially be used elsewhere by another JS portion of code. You should rather use directly location.protocol. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:23:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:23:35 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15690 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:23:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:23:35 +0000 Subject: [Koha-bugs] [Bug 15690] New: Unconstrained CardnumberLength preference conflicts with table column limit of 16 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690 Bug ID: 15690 Summary: Unconstrained CardnumberLength preference conflicts with table column limit of 16 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org We offer the ability to define any minimum or maximum card number length, but the table column is limited to 16. At the very least the preference should be constrained to 16, but I think a better solution would be to increase the limit on borrowers.cardnumber /and/ require that the CardnumberLength preference respect it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:24:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:24:34 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:26:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:26:33 +0000 Subject: [Koha-bugs] [Bug 15691] New: Show card number minimum and maximum in visible hint when adding a patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15691 Bug ID: 15691 Summary: Show card number minimum and maximum in visible hint when adding a patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org When adding a new patron, the minimum and maximum allowed card number lengths are embedded in a title tag on the input field. This information is essentially hidden from the user unless they happen to hover their mouse over the field. We already have a
    component to provide information about fields. We should move the information there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:27:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:27:52 +0000 Subject: [Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Failed QA --- Comment #5 from Mirko Tietgen --- No test plan available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:35:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:35:26 +0000 Subject: [Koha-bugs] [Bug 15690] Unconstrained CardnumberLength preference conflicts with table column limit of 16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690 --- Comment #1 from Owen Leonard --- Working on Bug 15691 makes this problem very visible. Here are the minimum/maximum length hints for various values of CardnumberLength: "20" - "Card number can be up to 16 characters." "20,30" - "Card number must be between 20 and 16 characters." "40," - "Card number must be between 40 and 16 characters." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 14:46:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 13:46:45 +0000 Subject: [Koha-bugs] [Bug 15690] Unconstrained CardnumberLength preference conflicts with table column limit of 16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690 --- Comment #2 from Owen Leonard --- > "40," - "Card number must be between 40 and 16 characters." With the above setting you get a validation error, "Please enter at least 40 characters." Impossible because the maxlength of the field is 16. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 15:00:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 14:00:59 +0000 Subject: [Koha-bugs] [Bug 15691] Show card number minimum and maximum in visible hint when adding a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15691 --- Comment #1 from Owen Leonard --- Created attachment 47389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47389&action=edit Bug 15691 - Show card number minimum and maximum in visible hint when adding a patron The CardnumberLength system preference defines card number minimum and maximum allowed values when adding a patron. This information is currently hidden in a title attribute on the card number input field. This patch moves the information into a
    , matching other fields in the entry form which offer details about entry guidelines. To test, apply the patch and open the new patron entry form. Test for various values of CardnumberLength, and with 'cardnumber' mandatory or not mandatory as defined in BorrowerMandatoryField. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 15:00:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 14:00:57 +0000 Subject: [Koha-bugs] [Bug 15691] Show card number minimum and maximum in visible hint when adding a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15691 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 15:07:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 14:07:38 +0000 Subject: [Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 15:37:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 14:37:08 +0000 Subject: [Koha-bugs] [Bug 15692] New: Move some patron entry form JavaScript into members.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15692 Bug ID: 15692 Summary: Move some patron entry form JavaScript into members.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org There is a lot of JavaScript in the patron entry form template which is not dependent on template processing and can therefore be moved to members.js. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 15:37:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 14:37:37 +0000 Subject: [Koha-bugs] [Bug 15516] RFC: Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 15:51:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 14:51:20 +0000 Subject: [Koha-bugs] [Bug 15691] Show card number minimum and maximum in visible hint when adding a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15691 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 15:51:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 14:51:25 +0000 Subject: [Koha-bugs] [Bug 15691] Show card number minimum and maximum in visible hint when adding a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15691 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47389|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47390&action=edit [SIGNED-OFF]Bug 15691: Show card number minimum and maximum in visible hint when adding a patron The CardnumberLength system preference defines card number minimum and maximum allowed values when adding a patron. This information is currently hidden in a title attribute on the card number input field. This patch moves the information into a
    , matching other fields in the entry form which offer details about entry guidelines. To test, apply the patch and open the new patron entry form. Test for various values of CardnumberLength, and with 'cardnumber' mandatory or not mandatory as defined in BorrowerMandatoryField. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 15:54:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 14:54:33 +0000 Subject: [Koha-bugs] [Bug 15690] Unconstrained CardnumberLength preference conflicts with table column limit of 16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15691 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 15:54:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 14:54:33 +0000 Subject: [Koha-bugs] [Bug 15691] Show card number minimum and maximum in visible hint when adding a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15691 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15690 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 16:00:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 15:00:28 +0000 Subject: [Koha-bugs] [Bug 15690] Unconstrained CardnumberLength preference conflicts with table column limit of 16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690 --- Comment #3 from H?ctor Eduardo Castro Avalos --- Hi Owen Also I think IMHO this needs to update the CardnumberLength sypref to explain the maximum lenght allowed. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 16:19:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 15:19:58 +0000 Subject: [Koha-bugs] [Bug 15667] Messages in patron account display dates wrongly formatted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15667 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47312|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 47391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47391&action=edit [SIGNED-OFF]Bug 15667: Fix date and branch formatting of messages in patron account display This patch fixes the date and branch formatting of messages in patron account display. To verify: Add a new message to a patron account from the 'checkouts' tab in staff, the displayed date is not correctly formatted and the branch displays as code instead as branch name To test: Apply patch, verify that the messages and branch names are properly formatted. Signed-off-by: Hector Castro Works as described. The message dates in checkouts tab follow dateformat sypref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 16:19:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 15:19:56 +0000 Subject: [Koha-bugs] [Bug 15667] Messages in patron account display dates wrongly formatted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15667 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 16:40:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 15:40:57 +0000 Subject: [Koha-bugs] [Bug 15692] Move some patron entry form JavaScript into members.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15692 --- Comment #1 from Owen Leonard --- Created attachment 47392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47392&action=edit Bug 15692 - Move some patron entry form JavaScript into members.js We should strive to keep as much JavaScript as possible out of templates in order to keep things modular and maximize the benefits of browser caching. This patch moves JavaScript out of the patron entry template Two other minor edits: Missing semicolons added on the advice of JSHint. To test, apply the patch and confirm that the following interactions still work on the patron entry form: 1. clear_entry(): With ExtendedPatronAttributes enabled, the "Clear" link next to any attribute form field should work to clear the field. 2. clone_entry(): With ExtendedPatronAttributes enabled and a repeatable attribute defined, it should be possible to click the "New" link to add another instance of that attribute's entry field. 3. update_category_code(): With ExtendedPatronAttributes enabled and an attribute defined which is limited to a single patron category, changing the patron category selection should correctly show or hide the attribute entry form. 4. select_user(): When adding or editing a patron with a "Child" category it should be possible to search for and select a guarantor to add to the record by clicking the "Set to patron" button. Selecting a new guarantor should change the text of the button from "Set to patron" to "Change." 5. noEnterSubmit(): This function should be correctly preventing you from hitting "ENTER" in any form field to submit the form. 6. guarantordelete(): When adding or editing a patron with a "Child" category, it should be possible to clear existing guarantor information by clicking the "Delete" button. Clicking the "Delete" button should change the text of the adjacent button to "Set to patron." 7. select_city(): With one or more cities defined it should be possible to use the drop-down menu of cities to populate the city, state, zip, and country fields. 8. Date of birth entry should have a maximum date limit of yesterday. The drop-down menu of years should go back 100 years. 9. Client-side validation rules should be in effect, requiring that a valid email address be entered in the primary email, secondary email, and alternate address email fields. 10.When editing a patron, the "Add manual restriction" link should display the form for adding a manual restriction, and clicking the "Cancel" link should hide it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 16:40:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 15:40:55 +0000 Subject: [Koha-bugs] [Bug 15692] Move some patron entry form JavaScript into members.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15692 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 16:43:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 15:43:39 +0000 Subject: [Koha-bugs] [Bug 15642] Batch patron deletion should not delete patrons with issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 --- Comment #7 from Nick Clemens --- > Nick, tools/cleanborrowers.pl already call GetBorrowersToExpunge, so I am > not sure this change is needed. Agreed, not needed here, but needed on bug 10612, will move back over there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 16:47:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 15:47:15 +0000 Subject: [Koha-bugs] [Bug 15642] Batch patron deletion should not delete patrons with issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #8 from Nick Clemens --- (In reply to Jonathan Druart from comment #6) > In misc/cronjobs/delete_patrons.pl it's done with: > 68 my $flags = C4::Members::patronflags( $member ); > 69 if ( my $charges = $flags->{CHARGES}{amount} ) { > 70 say "Failed to delete patron $borrowernumber: patron has > $charges in fines"; > 71 next; > 72 } > Should not we simply move this check to the GetBorrowersToExpunge subroutine? FWIW I think I would rather see the checks done as above - so that the warning is visible that not all patrons in the category/list/etc were deleted. If the checks were moved into GetBorrowersToExpunge it would be nice to make it return patrons who wont be deleted because of issues/fines This is probably a separate enhancement though and I think this report can be closed. Agreed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 16:47:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 15:47:47 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15642 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15642 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 [Bug 15642] Batch patron deletion should not delete patrons with issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 16:47:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 15:47:47 +0000 Subject: [Koha-bugs] [Bug 15642] Batch patron deletion should not delete patrons with issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10612 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10612 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 [Bug 10612] Add ability to delete patrons with batch patron deletion tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 17:05:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 16:05:15 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47224|0 |1 is obsolete| | --- Comment #62 from Nick Clemens --- Created attachment 47393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47393&action=edit Bug 10612 - Add ability to delete patrons with batch patron deletion tool This patch adds the ability to select a patron list for deletetion when using the Batch patron deletion/anonymization tool. It also adds buttons to the the patron lists table to access both the batch deletion and batch modification directly from the lists view. This is a squash of previous patches with a check added for issues before deleting borrowers. Test Plan: 1) Apply this patch 2) Create a list of patrons with the new Patron Lists feature 3) Try using the batch edit link form the lists table 4) Try using the batch delete link from the lists table Signed-off-by: Jesse Weaver ByWater internal signoff, still needs signoff from community. Patch seems kosher, passes QA tools. Needs followup to fix one small issue: squished patch undoes switch to FontAwesome icons in lists.tt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 17:05:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 16:05:12 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 17:05:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 16:05:30 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47259|0 |1 is obsolete| | --- Comment #64 from Nick Clemens --- Created attachment 47395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47395&action=edit Bug 10612 [QA Followup] - fix issues 1 - Use Koha::List::Patron 2 - Return only non-empty lists for deletion selection 3 - Fix _skip_bo... to accept patro_list_patrons3 - Fix _skip_borrowers_with_fines_or_issues to accept patro_list_patrons3 4 - Fix missed closing quote in cleanborrowers.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 17:05:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 16:05:23 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47225|0 |1 is obsolete| | --- Comment #63 from Nick Clemens --- Created attachment 47394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47394&action=edit Bug 10612 - [QA followup] Use font awesome icons in patron lists lists.tt Signed-off-by: Natasha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 17:05:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 16:05:43 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #65 from Nick Clemens --- Created attachment 47396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47396&action=edit Bug 10612 - Change _skip_borrowers_with_fines to _skip_borrowers_with_fines_or_issues Restore code that was moved to bug 15642 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 17:07:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 16:07:57 +0000 Subject: [Koha-bugs] [Bug 15516] RFC: Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 17:19:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 16:19:58 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Patch doesn't apply --- Comment #171 from Kyle M Hall --- Jonathan, can you please rebase these patches? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 17:38:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 16:38:45 +0000 Subject: [Koha-bugs] [Bug 15693] New: Unnecessary punctuation mark when check-in an item in a library other than the home branch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15693 Bug ID: 15693 Summary: Unnecessary punctuation mark when check-in an item in a library other than the home branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: hector.hecaxmmx at gmail.com QA Contact: testopia at bugs.koha-community.org If you are checking an item in at a library other than the home branch, a message will appear asking you to transfer the book to the home library. Thit message appear with "Print slip )" and the unnecessary punctuation mark -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 17:50:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 16:50:21 +0000 Subject: [Koha-bugs] [Bug 15693] Unnecessary punctuation mark when check-in an item in a library other than the home branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15693 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 17:50:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 16:50:23 +0000 Subject: [Koha-bugs] [Bug 15693] Unnecessary punctuation mark when check-in an item in a library other than the home branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15693 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 47397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47397&action=edit Bug 15693: Unnecessary punctuation mark when check-in an item in a library other than the home branch To test: 1-Checkin an item in a library other than the home branch. 2-A message will display asking to return the item to the home branch 3-You will see the phrase "Print slip )" 4-Apply patch 5-Reproduce or repeat steps 1-2 and verify the punctuation mark is no longer displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 17:52:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 16:52:07 +0000 Subject: [Koha-bugs] [Bug 15693] Unnecessary punctuation mark when check-in an item in a library other than the home branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15693 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |hector.hecaxmmx at gmail.com Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 18:01:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 17:01:05 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 18:01:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 17:01:14 +0000 Subject: [Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 18:01:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 17:01:17 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 18:24:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 17:24:29 +0000 Subject: [Koha-bugs] [Bug 15694] New: Date/time-last-modified not searchable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Bug ID: 15694 Summary: Date/time-last-modified not searchable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Searching Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org There is na index for Date/time-last-modified but the slash (/) can cause issues. This patch will add aliases for this field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 18:26:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 17:26:07 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #1 from Nicole C. Engard --- Created attachment 47398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47398&action=edit Bug 15694: Add aliases for date/time last modified This patch will add indexes for Date/time-last-modified. To test: 1. apply patch 2. reindex 3. search for dtlm:DATE and date-time-last-modified:DATE 4. confirm that you get results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 18:26:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 17:26:28 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Nicole C. Engard --- This is my first ever patch like this so I welcome feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 18:36:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 17:36:59 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 18:36:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 17:36:59 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 [Bug 15280] Switch default CHECKOUT notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 18:37:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 17:37:12 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 18:38:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 17:38:56 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 18:38:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 17:38:57 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Bug 10263 depends on bug 10278, which changed state. Bug 10278 Summary: Add ability to hide items and records from search results for Independent Branches https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 18:39:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 17:39:07 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 19:21:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 18:21:38 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 19:21:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 18:21:43 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45329|0 |1 is obsolete| | --- Comment #5 from Mirko Tietgen --- Created attachment 47399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47399&action=edit Bug 15280 - Switch default CHECKOUT notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKOUT notice to match the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 3) Generate a CHECKOUT notice for a patron 4) Note there is not change to the generated notice Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 19:33:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 18:33:00 +0000 Subject: [Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 19:33:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 18:33:04 +0000 Subject: [Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45330|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 47400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47400&action=edit Bug 15282 - Switch default CHECKIN notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKIN notice to match the following: The following items have been checked in: ---- [% biblio.title %] ---- Thank you. 3) Generate a CHECKIN notice for a patron 4) Note there is no change to the generated notice Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 19:33:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 18:33:32 +0000 Subject: [Koha-bugs] [Bug 15695] New: koha-plack script does not enable plack when plack has never been enabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15695 Bug ID: 15695 Summary: koha-plack script does not enable plack when plack has never been enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: wwwretive at yahoo.fr QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Created attachment 47401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47401&action=edit the patch for koha-plack script hello, When running koha-plack --enable, the script assumes that there is already a commented line that includes the plack configuration in the apache virtual host's config of the instance. The script would comment out the line : (from /usr/sbin/koha-plack line 148) : sed -i 's:^\s*#\(\s*Include /etc/koha/apache-shared-opac-plack.conf\)$:\1:' "$instancefile" sed -i 's:^\s*#\(\s*Include /etc/koha/apache-shared-intranet-plack.conf\)$:\1:' "$instancefile" For old fashioned installs there is no commented line that includes plack configuration, so the regular expression doesn't match and the script doesn't enable plack. In my config (we've set up koha 3 years ago) i had to add the plack-related line directly in the apache virtual host config. Since the included files use the ${instance} variable, i had to define that variable as well in my vhost config : Define instance myinstancename (the "Define" keyword is not well documented in the apache docs ; i used it because SetEnv didn't work). Instead of commenting out the (possibibly non-existent) plack related lines, it is possible to find where the "/etc/koha/apache-shared-{opac,intranet}.conf" files are included and add the two relevant lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 19:35:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 18:35:08 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Mirko Tietgen --- Wende an: Bug 15283 - Switch default ISSUEQSLIP notice to Template Toolkit fatal: sha1 information is lacking or useless (installer/data/mysql/de-DE/mandatory/sample_notices.sql). Dem Repository fehlen notwendige Blobs um auf einen 3-Wege-Merge zur?ckzufallen. Kann nicht zu 3-Wege-Merge zur?ckfallen. Anwendung des Patches fehlgeschlagen bei 0001 Bug 15283 - Switch default ISSUEQSLIP notice to Template Toolkit Die Kopie des fehlgeschlagenen Patches befindet sich in: /home/mirko/koha/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15283---Switch-default-ISSUEQSLIP-notice-to-Te-CHhaFv.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 19:39:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 18:39:04 +0000 Subject: [Koha-bugs] [Bug 14881] batch item modification : item properties not displaying when accented characters are used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14881 philippe kloos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 19:41:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 18:41:37 +0000 Subject: [Koha-bugs] [Bug 15458] Marc21 leader 07 error in translation: "a- Serial component" part is not in format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15458 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mirko at abunchofthings.net --- Comment #7 from Mirko Tietgen --- This needs a decision by RMaint. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 19:47:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 18:47:10 +0000 Subject: [Koha-bugs] [Bug 15693] Unnecessary punctuation mark when check-in an item in a library other than the home branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15693 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 19:47:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 18:47:14 +0000 Subject: [Koha-bugs] [Bug 15693] Unnecessary punctuation mark when check-in an item in a library other than the home branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15693 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47397|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 47402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47402&action=edit Bug 15693: Unnecessary punctuation mark when check-in an item in a library other than the home branch To test: 1-Checkin an item in a library other than the home branch. 2-A message will display asking to return the item to the home branch 3-You will see the phrase "Print slip )" 4-Apply patch 5-Reproduce or repeat steps 1-2 and verify the punctuation mark is no longer displayed Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 19:56:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 18:56:22 +0000 Subject: [Koha-bugs] [Bug 15531] Add support for standing orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens --- Couple issues right off the bat: - When adding an order to a basket I get the form to add an item, but when I click 'Add item' the form disappears and no item is added - If I put a cost in, I get NaN for total since there is no quantity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 19:56:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 18:56:48 +0000 Subject: [Koha-bugs] [Bug 15618] Small typos in system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Ian Hank <129987 at student.pennmanor.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |129987 at student.pennmanor.ne | |t --- Comment #25 from Ian Hank <129987 at student.pennmanor.net> --- Gave a review, made a grammar, spelling, and typo check. I did not notice anything weird or misplaced. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 20:07:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 19:07:00 +0000 Subject: [Koha-bugs] [Bug 15395] Allow correct handling of plural translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 20:17:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 19:17:15 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #29 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 20:18:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 19:18:17 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #78 from Kyle M Hall --- (In reply to Jonathan Druart from comment #77) > Kyle, > To easy the readability, I have squashed the qa follow-ups, especially > because of the NOCACHE param, which has been added and finally removed. That's always fine by me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 20:21:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 19:21:32 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #5 from Kyle M Hall --- (In reply to Colin Campbell from comment #4) > Is this a bit cumbersome? what about starting by passing Log4perl to the > Net::Server config it already supports it its the Koha calls to syslog that > stop us enabling it. Coud we not then just call up logger rather than > passing $self->server about all the time which looks a bit clumsy I'm not sure I understand what your saying. Could you expand on this a bit? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 20:23:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 19:23:53 +0000 Subject: [Koha-bugs] [Bug 15427] Allow db connections using TLS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 --- Comment #3 from Chris Cormack --- (In reply to Mirko Tietgen from comment #2) > Can this be tested locally or do I need to set up an external MySQL DB? YOu should be able to test it locally, just make sure MySQL is running on a port not a socket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 20:24:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 19:24:03 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #16 from Mirko Tietgen --- I tried to test this, but I can't get the self registration to show in OPAC. PatronSelfRegistration is set to allow. Am I missing something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 20:41:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 19:41:05 +0000 Subject: [Koha-bugs] [Bug 15696] New: Notices default all libraries page shows branch-specific notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15696 Bug ID: 15696 Summary: Notices default all libraries page shows branch-specific notices Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org The notices page default page shows all libraries notices (the default ones) AND the branch-specific ones. It would be nice if this page only listed the default ones (when the menu is set to all libraries), and mimicked the behavior on the circulation rules page, where all libraries = default rules shown, and then changing to an individual brach = branch specific rules. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 20:46:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 19:46:00 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #17 from Nicole C. Engard --- (In reply to Mirko Tietgen from comment #16) > I tried to test this, but I can't get the self registration to show in OPAC. > PatronSelfRegistration is set to allow. Am I missing something? You also need to set the PatronSelfRegistrationDefaultCategory Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 20:52:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 19:52:30 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #18 from Mirko Tietgen --- Thanks Nicole, that helped! Maybe it should be in the manual. :P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 20:53:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 19:53:53 +0000 Subject: [Koha-bugs] [Bug 8558] Better confirmation message for importing frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #3 from Aleisha Amohia --- Is this still valid? The message on the latest version is: "Do you really want to import the framework fields and subfields? This will overwrite the current configuration. For safety reasons please use the export option to make a backup" And when you click Import on a framework, it says "Import [% frameworkcode %] framework structure (fields and subfields) from a spreadsheet file (.csv, .xml, .ods)" at the top of the box so you know which one you're overwriting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 20:54:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 19:54:38 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47369|0 |1 is obsolete| | --- Comment #16 from Nicole C. Engard --- Created attachment 47403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47403&action=edit [SIGNED-OFF] Bug 14168 - enhance streaming cataloging to include youtube Add optional embedding of YouTube videos via HTML5Media. New syspref: HTML5MediaYouTube: Embed/Don't embed videos. Format WEBM is hardcoded as it is the only format accepted by all modern browsers. Test plan: - apply patch - catalogue a YouTube link in 856$u - turn on HTML5MediaEnabled and HTML5MediaYouTube - open the record in OPAC and staff client, check that the 'Play media' tab is showing and playing the video works. Possible enhancements for followups: - check available formats, offer quality choice - accept official YT URL shortener Signed-off-by: Aleisha Works perfectly! Signed-off-by: Nicole C Engard I love it!!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 20:57:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 19:57:13 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #29 from Ian Palko --- (In reply to Jonathan Druart from comment #28) > (In reply to Nick Clemens from comment #27) > > A test plan would be appreciated (even if as simple as 'Merge two > > authorities') > > > > I get this error when merging authorities: > > Software error: > > > > Subfields are only for data fields (generally, just tags >= 010) at > > /home/vagrant/kohaclone/C4/AuthoritiesMarc.pm line 1488. > > I had a very quick look at the code and I'd say that it existed prior to bug > 8064, could you test on a 3.20 release and confirm that the bug already > existed? Equinox is still running a demo server with 3.20.1. When merging authorities on that demo server, there was no error. The biblios were correctly re-linked to the merged authority as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:01:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:01:25 +0000 Subject: [Koha-bugs] [Bug 15684] can't import quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Created attachment 47404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47404&action=edit Goethe quotes without umlaut This file does not contain ?, ?, ? etc. It works. (Encoding is UTF8) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:02:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:02:50 +0000 Subject: [Koha-bugs] [Bug 15684] can't import quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 --- Comment #2 from Marc V?ron --- Created attachment 47405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47405&action=edit Goethe with umlaut This file contains ?, ?, ?. It can not be saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:02:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:02:54 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47362|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia --- Created attachment 47406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47406&action=edit Bug 12051: Adds a Renew tab to the staff client UPDATE: Added to checkin-search.inc to show up on returns.pl To test: 1) Apply patch 2) Confirm that there is now a Renew tab on the pages where there is also a Check-in tab only 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:02:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:02:58 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:03:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:03:03 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47320|0 |1 is obsolete| | --- Comment #19 from Mirko Tietgen --- Created attachment 47407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47407&action=edit Bug 15343 - Allow user to set password on opac-memberentry.pl This patch allows patrons to create thier own password during OPAC self registration. It sets the password field to be hidden by default, and allows for a system generated password if no password is supplied and field is not mandatory 1 - Apply patch 2 - run updatedatabase.pl 3 - Check syspref "PatronSelfRegistrationBorrowerUnwantedField" - it should contain 'password' 4 - Check self registration on opac - there should be no change 5 - Remove 'password' from PatronSelfRegistrationBorrowerUnwantedField 6 - Password field should now be visible in OPAC self registration 7 - Register a patron: If no passwor is supplied you should get a system generated password 8 - Register a patron with a password, your password should be used 9 - Add 'password' to PatronSelfRegistrationBorrowerMnadatoryField 10 - Attempt to register a patron with no password - it should fail 11 - Try all combinations if mismatched/short/missing passwords and view correct error messages 12 - prove t/db_dependent/Members.t Sponsored by : Do Space (www.dospace.org) Signed-off-by: Jesse Weaver Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:03:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:03:18 +0000 Subject: [Koha-bugs] [Bug 8963] Can not upload csv file for Quote of the day and encoding problems with non-UTF-8 files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8963 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15684 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:03:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:03:18 +0000 Subject: [Koha-bugs] [Bug 15684] can't import quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8963 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:04:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:04:23 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47321|0 |1 is obsolete| | --- Comment #20 from Mirko Tietgen --- Created attachment 47408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47408&action=edit Bug 15343 [QA Followup] - Fix issues 1) "Contact information" should be "Password" 2) Don't pass sysprefs from the script to the template, use Koha.Preference() 3) minPasswordLength is optional, we cannot always assume it is set 4) Password field when does not follow convention completely when mandatory Signed-off-by: Nick Clemens Signed-off-by: Jesse Weaver Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:04:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:04:30 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47322|0 |1 is obsolete| | --- Comment #21 from Mirko Tietgen --- Created attachment 47409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47409&action=edit Bug 15343 [QA Follow up] Fix captcha display Make captcha visible even if password field is hidden Remove password confirmation field before submitting modification Signed-off-by: Jesse Weaver Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:06:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:06:28 +0000 Subject: [Koha-bugs] [Bug 15684] can't import quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 --- Comment #3 from Marc V?ron --- Goethe with umlaut gives the following warning: quotes-upload_ajax.pl: malformed UTF-8 character in JSON string, at character offset 52 (before "\\x{4b34}."],[2,"Goet...") at /usr/share/kohaclone/tools/quotes/quotes-upload_ajax.pl line 44., referer: http://10.0.0.62:8080/cgi-bin/koha/tools/quotes-upload.pl I fixed Nicole's example (not all quotes were put in quotes "" and tried to upload. This is the warning I get: quotes-upload_ajax.pl: Wide character in subroutine entry at /usr/share/kohaclone/tools/quotes/quotes-upload_ajax.pl line 44., referer: http://10.0.0.62:8080/cgi-bin/koha/tools/quotes-upload.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:12:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:12:27 +0000 Subject: [Koha-bugs] [Bug 12141] On Display Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12141 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:18:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:18:38 +0000 Subject: [Koha-bugs] [Bug 12141] On Display Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12141 Ed Veal changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ed.veal at bywatersolutions.co | |m --- Comment #3 from Ed Veal --- This is something that I have had a number of public libraries really want. As it stands they have a complicated process of changing locations for items that are on "display". By using the Course Reserve functionality it will address the permissions issue that Owen mentioned and allow a library to have items that regularly can be set to display such as Christmas, gardening, and cooking books. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:20:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:20:11 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 --- Comment #10 from Aleisha Amohia --- (In reply to Marc V?ron from comment #9) > > See Bug 15663 Do you mean Bug 14676? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:33:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:33:45 +0000 Subject: [Koha-bugs] [Bug 15697] New: Unnecessary comma between title and subtitle on opac-detail.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Bug ID: 15697 Summary: Unnecessary comma between title and subtitle on opac-detail.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To reproduce: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping Field name: subtitle MARC field: 245 MARC subfield: b (or 200$e I think for UNIMARC) 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:45:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:45:34 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mirko at abunchofthings.net --- Comment #14 from Mirko Tietgen --- It works very well for me, except for step 8. I still get the default descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:50:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:50:59 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 --- Comment #1 from Nick Clemens --- Created attachment 47410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47410&action=edit Bug 15697 - Unnecessary comma between title and subtitle on opac-detail.pl To test: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping (or ensure it exists) Field name: subtitle MARC field: 245 MARC subfield: b 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" 5 - Apply patch 6 - View the record again and note the comma is no longer present. Note: this patch removes the comma only for MARC21 where subtitle is not repeatable. UNIMARC seems to be repeatable and does not include punctuation so I believe this may be needed there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 21:56:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 20:56:53 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |trivial Assignee|oleonard at myacpl.org |nick at bywatersolutions.com CC| |nick at bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 22:08:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 21:08:08 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 22:10:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 21:10:09 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 22:13:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 21:13:32 +0000 Subject: [Koha-bugs] [Bug 15684] can't import quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 --- Comment #4 from Marc V?ron --- Created attachment 47411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47411&action=edit Bug 15684: Fix encoding issues with quote upload To verify: - Download attachment 'Goethe with umlaut' from Bug 15684 - Go to Tools > Quote Editor - Click "Import quotes" and select the file - The quotes display in a table. Click 'Sav quotes' - Result: Nothing happens To test: - Apply patch - Repeat steps above - Verify that you get a message '2 quotes saved' and that the quotes are added in to the quotes table - Test with attachment 'sample quotes' as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 22:14:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 21:14:14 +0000 Subject: [Koha-bugs] [Bug 15684] Fix encoding issues with quote upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch Summary|can't import quotes |Fix encoding issues with | |quote upload -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 22:14:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 21:14:38 +0000 Subject: [Koha-bugs] [Bug 15684] Fix encoding issues with quote upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 22:16:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 21:16:25 +0000 Subject: [Koha-bugs] [Bug 15684] Fix encoding issues with quote upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 22:23:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 21:23:00 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47406|0 |1 is obsolete| | --- Comment #11 from Marc V?ron --- Created attachment 47412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47412&action=edit Bug 12051: Adds a Renew tab to the staff client UPDATE: Added to checkin-search.inc to show up on returns.pl To test: 1) Apply patch 2) Confirm that there is now a Renew tab on the pages where there is also a Check-in tab only 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 22:23:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 21:23:13 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 22:28:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 21:28:59 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 --- Comment #11 from Marc V?ron --- (In reply to Aleisha Amohia from comment #10) > (In reply to Marc V?ron from comment #9) > > > > See Bug 15663 > > Do you mean Bug 14676? Sorry for my mistake, it is Bug 15689 - Label editor: Fix issues with wrong batch_id parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 22:46:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 21:46:40 +0000 Subject: [Koha-bugs] [Bug 15698] New: Include MARCMaker to export options Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15698 Bug ID: 15698 Summary: Include MARCMaker to export options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: hector.hecaxmmx at gmail.com Reporter: hector.hecaxmmx at gmail.com QA Contact: testopia at bugs.koha-community.org Sometimes the librarian want a way to harvest a few records not recorded in Z39.50 databases also they want to obtain and manage a versatile format supported in MARCEdit or MARCMaker. Koha doesn't have support to export in MARCMaker. This feature is very useful to librarian whom are accustomed to use it especially in MARCEdit software. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 22:50:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 21:50:41 +0000 Subject: [Koha-bugs] [Bug 15698] Include MARCMaker to export options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15698 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 47413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47413&action=edit Bug 15698: Include MARCMAker option export to Record.pm Feature inclue: -Sub marc2marcmaker in Record.pm -Include module MARC::File::MARCMaker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 22:54:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 21:54:00 +0000 Subject: [Koha-bugs] [Bug 15698] Include MARCMaker to export options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15698 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from H?ctor Eduardo Castro Avalos --- Patch is a draft, more patches comming soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 22:58:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 21:58:26 +0000 Subject: [Koha-bugs] [Bug 15699] New: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Bug ID: 15699 Summary: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 22:59:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 21:59:04 +0000 Subject: [Koha-bugs] [Bug 15698] Include MARCMaker to export options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15698 --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 47414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47414&action=edit Bug 15698: XSLT for transmform UNIMARC to MARC21 Add UNIMARC to MARC21 transformation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 23:00:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 22:00:36 +0000 Subject: [Koha-bugs] [Bug 15684] Fix encoding issues with quote upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 23:00:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 22:00:42 +0000 Subject: [Koha-bugs] [Bug 15684] Fix encoding issues with quote upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47411|0 |1 is obsolete| | --- Comment #5 from Mirko Tietgen --- Created attachment 47415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47415&action=edit Bug 15684: Fix encoding issues with quote upload To verify: - Download attachment 'Goethe with umlaut' from Bug 15684 - Go to Tools > Quote Editor - Click "Import quotes" and select the file - The quotes display in a table. Click 'Sav quotes' - Result: Nothing happens To test: - Apply patch - Repeat steps above - Verify that you get a message '2 quotes saved' and that the quotes are added in to the quotes table - Test with attachment 'sample quotes' as well Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 23:06:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 22:06:28 +0000 Subject: [Koha-bugs] [Bug 15699] Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 --- Comment #1 from Nick Clemens --- Created attachment 47416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47416&action=edit Bug 15699 - Course reserves instructors should be in form "Surname, Firstname" for sorting purposes This patch changes the order of the name fields and adds a span class around each in case of library wanting to customize further To test: 1 - Enable course reserves 2 - Add some courses with instrcutors 3 - Note they are of form "Firstname Surname" 4 - Apply patch 5 - Note the change 6 - Note span tags 7 - Note you can hide firstname by adding to intranet user js: $(".instr_firstname, instr_separator").hide(); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 23:10:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 22:10:28 +0000 Subject: [Koha-bugs] [Bug 15699] Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |nick at bywatersolutions.com Severity|enhancement |minor Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 23:12:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 22:12:35 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46369|0 |1 is obsolete| | --- Comment #15 from Jesse Weaver --- Created attachment 47417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47417&action=edit Bug 13937 - Add a Z39.50 daemon that can inject item status MARC subfields This creates a new daemon, misc/z3950_responder.pl, which can respond to Z39.50 requests. By default, it just proxies searches to Zebra. If desired, however, it can also add a subfield to the item tags on outgoing records with a textual description of the item's status (checked out, lost, etc.). This is useful for certain ILL systems. These strings can be translated using the 'Z3950_STATUS' authorized value. Test plan: 1) Start the Z39.50 server using `perl misc/z3950_responder.pl`. 2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`. 3) Run a search, such as `find @attr 1=1016 book`. 4) Fetch the results both one at a time with `show 1` and in a batch using `show 1+5`. 5) Turn on MARCXML using `format xml` and `elements marcxml`, and verify that the records are still correctly fetched. 6) Enable the item status subfield by restarting the server with the option `--add-item-status=k`. 7) Search for and fetch records, and verify that a $k subfield is added to the item tags as appropriate. It should show some combination of "Checked Out", "Lost", "Not For Loan", "Damaged", "Withdrawn", "In Transit", or "On Hold" as appropriate, or "Available". 8) Restart the server with the option `--add-status-multi-subfield`; now, if there are multiple statuses for a given item, they should be in multiple $k subfields. 9) Add an authorized value named "Z3950_STATUS" with any of the keys "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED", "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their descriptions are used instead of the default values above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 23:15:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 22:15:29 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47417|0 |1 is obsolete| | --- Comment #16 from Jesse Weaver --- Created attachment 47418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47418&action=edit Bug 13937 - Add a Z39.50 daemon that can inject item status MARC subfields This creates a new daemon, misc/z3950_responder.pl, which can respond to Z39.50 requests. By default, it just proxies searches to Zebra. If desired, however, it can also add a subfield to the item tags on outgoing records with a textual description of the item's status (checked out, lost, etc.). This is useful for certain ILL systems. These strings can be translated using the 'Z3950_STATUS' authorized value. Test plan: 1) Start the Z39.50 server using `perl misc/z3950_responder.pl`. 2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`. 3) Run a search, such as `find @attr 1=1016 book`. 4) Fetch the results both one at a time with `show 1` and in a batch using `show 1+5`. 5) Turn on MARCXML using `format xml` and `elements marcxml`, and verify that the records are still correctly fetched. 6) Enable the item status subfield by restarting the server with the option `--add-item-status=k`. 7) Search for and fetch records, and verify that a $k subfield is added to the item tags as appropriate. It should show some combination of "Checked Out", "Lost", "Not For Loan", "Damaged", "Withdrawn", "In Transit", or "On Hold" as appropriate, or "Available". 8) Restart the server with the option `--add-status-multi-subfield`; now, if there are multiple statuses for a given item, they should be in multiple $k subfields. 9) Add an authorized value named "Z3950_STATUS" with any of the keys "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED", "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their descriptions are used instead of the default values above. Sponsored-by: Central Kansas Library System Sponsored-by: Northeast Kansas Library System Sponsored-by: Southeast Kansas Library System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 23:16:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 22:16:37 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #17 from Jesse Weaver --- Sorry for the spam; needed to note a new option in the test plan and show our sponsors. Mirko, could you try clearing memcached? Can't duplicate your issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 23:34:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 22:34:03 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 23:34:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 22:34:08 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47418|0 |1 is obsolete| | --- Comment #18 from Mirko Tietgen --- Created attachment 47419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47419&action=edit Bug 13937 - Add a Z39.50 daemon that can inject item status MARC subfields This creates a new daemon, misc/z3950_responder.pl, which can respond to Z39.50 requests. By default, it just proxies searches to Zebra. If desired, however, it can also add a subfield to the item tags on outgoing records with a textual description of the item's status (checked out, lost, etc.). This is useful for certain ILL systems. These strings can be translated using the 'Z3950_STATUS' authorized value. Test plan: 1) Start the Z39.50 server using `perl misc/z3950_responder.pl`. 2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`. 3) Run a search, such as `find @attr 1=1016 book`. 4) Fetch the results both one at a time with `show 1` and in a batch using `show 1+5`. 5) Turn on MARCXML using `format xml` and `elements marcxml`, and verify that the records are still correctly fetched. 6) Enable the item status subfield by restarting the server with the option `--add-item-status=k`. 7) Search for and fetch records, and verify that a $k subfield is added to the item tags as appropriate. It should show some combination of "Checked Out", "Lost", "Not For Loan", "Damaged", "Withdrawn", "In Transit", or "On Hold" as appropriate, or "Available". 8) Restart the server with the option `--add-status-multi-subfield`; now, if there are multiple statuses for a given item, they should be in multiple $k subfields. 9) Add an authorized value named "Z3950_STATUS" with any of the keys "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED", "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their descriptions are used instead of the default values above. Sponsored-by: Central Kansas Library System Sponsored-by: Northeast Kansas Library System Sponsored-by: Southeast Kansas Library System Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 23:35:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 22:35:18 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #19 from Mirko Tietgen --- There is no memcached running on the VM I am testing on. Anyway it worked now with the latest patch. I fixed a conflict in C4/Installer/PerlDependencies.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 23:41:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 22:41:32 +0000 Subject: [Koha-bugs] [Bug 15700] New: Buttons don't work in inventory/stocktaking Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15700 Bug ID: 15700 Summary: Buttons don't work in inventory/stocktaking Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: Go to Tools, Inventory/stocktaking Click Submit to show selection of items Buttons 'Mark seen and continue' and 'Continue without marking' do not work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 28 23:43:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jan 2016 22:43:38 +0000 Subject: [Koha-bugs] [Bug 15427] Allow db connections using TLS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 --- Comment #4 from Mirko Tietgen --- When I set to yes and add nothing in the cert fields, it seems to work as before. I don't think it should? I also wonder how to verify that it actually uses TLS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 01:19:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 00:19:17 +0000 Subject: [Koha-bugs] [Bug 15701] New: Port Koha::Contrib::Tamil koha-cloud into Koha code base Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15701 Bug ID: 15701 Summary: Port Koha::Contrib::Tamil koha-cloud into Koha code base Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Port Koha::Contrib::Tamil koha-cloud into Koha code base more info to come... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 01:19:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 00:19:28 +0000 Subject: [Koha-bugs] [Bug 15701] Port Koha::Contrib::Tamil koha-cloud into Koha code base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15701 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11081 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 01:19:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 00:19:28 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15701 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 01:19:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 00:19:42 +0000 Subject: [Koha-bugs] [Bug 15701] Port Koha::Contrib::Tamil koha-cloud into Koha code base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15701 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 01:20:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 00:20:06 +0000 Subject: [Koha-bugs] [Bug 15701] Port Koha::Contrib::Tamil koha-cloud into Koha code base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15701 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 01:21:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 00:21:43 +0000 Subject: [Koha-bugs] [Bug 15701] Port Koha::Contrib::Tamil koha-cloud into Koha code base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15701 --- Comment #1 from Mason James --- http://search.cpan.org/~fredericd/Koha-Contrib-Tamil-0.029/bin/koha-cloud(In reply to Mason James from comment #0) > Port Koha::Contrib::Tamil koha-cloud into Koha code base > > more info to come... here's a helpful link http://search.cpan.org/~fredericd/Koha-Contrib-Tamil-0.029/bin/koha-cloud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 03:15:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 02:15:44 +0000 Subject: [Koha-bugs] [Bug 15698] Include MARCMaker to export options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15698 --- Comment #4 from H?ctor Eduardo Castro Avalos --- (In reply to H?ctor Eduardo Castro Avalos from comment #3) > Created attachment 47414 [details] [review] > Bug 15698: XSLT for transmform UNIMARC to MARC21 > > Add UNIMARC to MARC21 transformation This is for test purpose, we need to ask the creator for permission to use the XSL file, or we're gonna need to create our own xsl to transform. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 04:29:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 03:29:51 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #1 from Srdjan Jankovic --- Created attachment 47420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47420&action=edit Sysprefs cache is object property now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 04:29:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 03:29:49 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 04:30:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 03:30:17 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #2 from Srdjan Jankovic --- Created attachment 47421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47421&action=edit Multi-host helper for plack installations Sort of an apocalypse * C4::Context->new() must be called with at least config file param. If you want current context, call C4::Context->current(). C4::Context->some_method() will still work as is. * Koha::Database->new_schema() now takes optional context param. * C4::Context->set_context() and restore_context() are synched with database set_schema() and restore_schema(). Created run_within_context() that wraps set_context() and restore_context() around code. * Created Koha::Handler::Plack* to facilitate running same code within different (database) contexts. * This initial version does not run with memcached turned on. Next patch will correct that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 04:30:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 03:30:45 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #3 from Srdjan Jankovic --- Created attachment 47422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47422&action=edit Removed Koha::Cache->get_instance() There should be no cache singleton, full stop. If Koha is to move away from .pl scripts that is. As an interim measure Koha::Cache->get_instance() is replaced with C4::Context->cache, in the vein of C4::Context->memcached. In that respect it will continue to work in the singleton-ish way if context is used as a singleton, but supports cache-per-context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 04:56:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 03:56:34 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #4 from Srdjan Jankovic --- There's a serious problem with Koha - it is CGI-centric. So all that singleton badness (as in context, database connection, cache) is to make global vars and optimise performance of the existing code under CGI conditions. I think better idea would be an app container, and develop with that in mind, rather then improving existing code base performance and then doing triple somersaults to get it going in modern setups. Even Koha:: namespace is very in line with the one CGI process paradigm. This is an attempt to control the damage while we decide how to move on. The idea is to enable context-less module load, and improve on clunky set_context -> restore context mechanism. I have tried many pages with caching situation, and it seems to work in both old CGI and new plack setup. But I did not go to every corner. I strongly suggest we start moving towards Koha::App container (a persistant glorified context without singletons). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 07:48:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 06:48:50 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 08:03:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 07:03:49 +0000 Subject: [Koha-bugs] [Bug 15699] Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47416|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 47423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47423&action=edit Bug 15699 - Course reserves instructors should be in form "Surname, Firstname" for sorting purposes This patch changes the order of the name fields and adds a span class around each in case of library wanting to customize further To test: 1 - Enable course reserves 2 - Add some courses with instrcutors 3 - Note they are of form "Firstname Surname" 4 - Apply patch 5 - Note the change 6 - Note span tags 7 - Note you can hide firstname by adding to intranet user js: $(".instr_firstname, instr_separator").hide(); Sing-off note: This patch displays the names as advertised on cgi-bin/koha/opac-course-reserves.pl Sorting the names would need some more actions but seems not to be intended by this patch. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 08:05:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 07:05:49 +0000 Subject: [Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Course reserves instructors |Opac: Course reserves |should be in form "Surname, |instructors should be in |Firstname" for sorting |form "Surname, Firstname" |purposes |for sorting purposes CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 08:06:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 07:06:06 +0000 Subject: [Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 08:49:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 07:49:54 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 09:04:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 08:04:30 +0000 Subject: [Koha-bugs] [Bug 15702] New: Patron details: Problems with leading and trailing blanks (surname, firstname, etc.) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 Bug ID: 15702 Summary: Patron details: Problems with leading and trailing blanks (surname, firstname, etc.) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It is possible to enter leading and trailing blanks in patron's surname, firstname (and in other fields as well). This leads to visible and invisible symptoms like wrong sorting, name not findable if you browse by last name, display of blanks where you do not expect them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 09:06:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 08:06:06 +0000 Subject: [Koha-bugs] [Bug 15702] Patron details: Problems with leading and trailing blanks (surname, firstname, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 --- Comment #1 from Marc V?ron --- Created attachment 47424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47424&action=edit Leading / trailing blanks in patron information (screenshots) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 09:08:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 08:08:37 +0000 Subject: [Koha-bugs] [Bug 15702] Patron details: Problems with leading and trailing blanks (surname, firstname, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10177 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 09:08:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 08:08:37 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15702 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 09:11:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 08:11:00 +0000 Subject: [Koha-bugs] [Bug 14509] Don't allow spaces at the end, beginning or as your password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15702 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 09:11:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 08:11:00 +0000 Subject: [Koha-bugs] [Bug 15702] Patron details: Problems with leading and trailing blanks (surname, firstname, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14509 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 09:46:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 08:46:38 +0000 Subject: [Koha-bugs] [Bug 15516] RFC: Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #3 from Julian Maurice --- (In reply to Jonathan Druart from comment #2) > Maybe you could add a foreign key to borrowers.borrowernumber to list the > reserve group of a given patron. The link to the borrowers table is already there in reserves table, and this makes me think the schema is inconsistent because it allows grouping reserves for different borrowers. Maybe reserves.borrowernumber should be moved to reserve_group (and all reserves should belong to a group, even if the group only contains one reserve). What do you think ? > > - I don't know how to indicates in the interface that two or more > > reserves are only one request in reality. > > What do you plan to implement next? > If the reserve groups were named, and linked to a patron, you could display > these infos. Next steps would be to change the interface to reflect that change everywhere we display holds. And implement that in OPAC too. In the tables that show all holds of a patron I can group visually the holds of the same "reserve_group", but I can't do that on tables that show only a title's holds for instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:13:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:13:37 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11190 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #20 from Jonathan Druart --- After the discussion on bug 11190, I thought we all agreed that Moo must be used, instead of Moose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:13:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:13:37 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a catalog sitemap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11081 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:16:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:16:00 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 --- Comment #21 from Jonathan Druart --- Time::Progress and String::RewritePrefix are listed in the deps, but don't look to be used from this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:25:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:25:54 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:33:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:33:21 +0000 Subject: [Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com --- Comment #5 from Jonathan Druart --- Hi Srdjan, How can we test this patch, could you provide a test plan? Is this patch already in [pre-]production somewhere? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:40:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:40:43 +0000 Subject: [Koha-bugs] [Bug 15358] merge.pl does not populate values to merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 --- Comment #30 from Jonathan Druart --- Yes, it works. The plan was to test with the same records on 3.20 and master + this patch set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:53:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:53:44 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46795|0 |1 is obsolete| | --- Comment #172 from Jonathan Druart --- Created attachment 47425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47425&action=edit Bug 13618: Use Template::Stash::AutoEscaping to use the html filter Test plan: 0/ sudo cpanm Template::Stash::AutoEscaping 1/ Verify don't reproduce the XSS issue described on bug 13609 and other xss related bugs. 2/ Try to find some encoding issues (detail page, search results, facets, etc.) Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:53:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:53:50 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46796|0 |1 is obsolete| | --- Comment #173 from Jonathan Druart --- Created attachment 47426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47426&action=edit Bug 13618: Remove html filters at the OPAC This patch removes the html filters at the OPAC, if necessary. Generated with: perl -p -i -e 's/\ ?\|\ ?html(\ ?)%/\1%/g' **/*.tt **/*.inc Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:53:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:53:55 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46797|0 |1 is obsolete| | --- Comment #174 from Jonathan Druart --- Created attachment 47427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47427&action=edit Bug 13618: Specific places where we don't need to escape variables There is no need to escape the html generated by the XSLT. Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:54:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:54:02 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46798|0 |1 is obsolete| | --- Comment #175 from Jonathan Druart --- Created attachment 47428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47428&action=edit Bug 13618: Remove html filters at the intranet Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:54:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:54:07 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46799|0 |1 is obsolete| | --- Comment #176 from Jonathan Druart --- Created attachment 47429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47429&action=edit Bug 13618: Specific places where we don't need to escape variables - intra Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:54:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:54:12 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46800|0 |1 is obsolete| | --- Comment #177 from Jonathan Druart --- Created attachment 47430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47430&action=edit Bug 13618: Specific for pagination_bar Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:54:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:54:18 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46801|0 |1 is obsolete| | --- Comment #178 from Jonathan Druart --- Created attachment 47431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47431&action=edit Bug 13618: Specific for the ISBD view Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:54:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:54:23 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46802|0 |1 is obsolete| | --- Comment #179 from Jonathan Druart --- Created attachment 47432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47432&action=edit Bug 13618: Fix error 'Not a GLOB reference' The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. The easier fix is to replace it with a SWITCH. Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:54:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:54:28 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46803|0 |1 is obsolete| | --- Comment #180 from Jonathan Druart --- Created attachment 47433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47433&action=edit Bug 13618: Specific for IntranetUser* and OPACUser* prefs Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:54:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:54:33 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46804|0 |1 is obsolete| | --- Comment #181 from Jonathan Druart --- Created attachment 47434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47434&action=edit Bug 13618: Specific for ColumnsSettings Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:54:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:54:39 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46805|0 |1 is obsolete| | --- Comment #182 from Jonathan Druart --- Created attachment 47435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47435&action=edit Bug 13618 - memberentrygen.tt errors Not a GLOB reference Like Jonathan said: The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. Replaced it with a SWITCH, like the other patch for this similar error. Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:54:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:54:44 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46806|0 |1 is obsolete| | --- Comment #183 from Jonathan Druart --- Created attachment 47436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47436&action=edit Bug 13618: Specific for other prefs opacmainuserblock opacnav opacnavright opaccredits opacheader opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:54:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:54:49 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46807|0 |1 is obsolete| | --- Comment #184 from Jonathan Druart --- Created attachment 47437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47437&action=edit Bug 13618: Specific for Salutation on editing a patron Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:54:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:54:55 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46808|0 |1 is obsolete| | --- Comment #185 from Jonathan Druart --- Created attachment 47438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47438&action=edit Bug 13618: Specific for XSLTBloc Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:55:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:55:00 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46809|0 |1 is obsolete| | --- Comment #186 from Jonathan Druart --- Created attachment 47439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47439&action=edit Bug 13618: Fix escape on sending baskets or shelves by email Test plan: Send baskets and shelves by email. With or without this patch, you should not see any changes. Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:55:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:55:06 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46810|0 |1 is obsolete| | --- Comment #187 from Jonathan Druart --- Created attachment 47440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47440&action=edit Bug 13618: Fix for news Signed-off-by: Signed-off-by: Joonas Kylm?l? Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:55:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:55:11 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46811|0 |1 is obsolete| | --- Comment #188 from Jonathan Druart --- Created attachment 47441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47441&action=edit Bug 13618: Fix last occurrences recently introduced to master Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:55:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:55:17 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46812|0 |1 is obsolete| | --- Comment #189 from Jonathan Druart --- Created attachment 47442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47442&action=edit Bug 13618: followup to remove tabs Signed-off-by: Bernardo Gonzalez Kriegel This followup on top of remote branch Only remove tabs and trailing spaces to make koha-qa pass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:55:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:55:22 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46813|0 |1 is obsolete| | --- Comment #190 from Jonathan Druart --- Created attachment 47443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47443&action=edit Bug 13618: Fix for edit biblios and items On editing biblios or items, the marc_lib, marc_value and javascript values are often populated with html code which needs to be displayed raw. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:55:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:55:28 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46814|0 |1 is obsolete| | --- Comment #191 from Jonathan Druart --- Created attachment 47444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47444&action=edit Bug 13618: (follow-up) Specific for ColumnsSettings Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:55:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:55:33 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46815|0 |1 is obsolete| | --- Comment #192 from Jonathan Druart --- Created attachment 47445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47445&action=edit Bug 13618: (follow-up) add missing lines for opac-shelves Proposed patch to fix opac-shelves Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:55:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:55:38 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46816|0 |1 is obsolete| | --- Comment #193 from Jonathan Druart --- Created attachment 47446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47446&action=edit Bug 13618: Remove html filters for newly pushed code Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:55:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:55:44 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46817|0 |1 is obsolete| | --- Comment #194 from Jonathan Druart --- Created attachment 47447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47447&action=edit Bug 13618: Fix for system preference description If a syspref description contains html tag, do not display them Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:55:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:55:49 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46818|0 |1 is obsolete| | --- Comment #195 from Jonathan Druart --- Created attachment 47448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47448&action=edit Bug 13618: Do not display   and html tags in item fields content Note that there might be other occurrences to fix! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:55:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:55:55 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46819|0 |1 is obsolete| | --- Comment #196 from Jonathan Druart --- Created attachment 47449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47449&action=edit Bug 13618: Do not display html tags in patron's notices Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:56:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:56:03 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46820|0 |1 is obsolete| | --- Comment #197 from Jonathan Druart --- Created attachment 47450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47450&action=edit Bug 13618: Fix for debarredcomment and patron messages At the OPAC and intranet. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:56:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:56:14 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46822|0 |1 is obsolete| | --- Comment #199 from Jonathan Druart --- Created attachment 47452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47452&action=edit Bug 13618: Specific for branches.opac_info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:56:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:56:09 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46821|0 |1 is obsolete| | --- Comment #198 from Jonathan Druart --- Created attachment 47451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47451&action=edit Bug 13618: (follow-up) Specific for other prefs follow-up for SlipCSS and printslip Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 10:57:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 09:57:23 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #200 from Jonathan Druart --- @RM: please don't squash these patches, it will be helpful to have the history if a regression if found later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:05:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:05:22 +0000 Subject: [Koha-bugs] [Bug 15701] Port Koha::Contrib::Tamil koha-cloud into Koha code base In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15701 --- Comment #2 from Fr?d?ric Demians --- There is already something in Koha: misc/cronjobs/cloud-kw.pl. The module packaged version isn't algorithmically different. The only difference is that the packaged version is event-driven: So it's possible to attach a 'watcher' to the processing in order to report its progress on a time base. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:06:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:06:28 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #30 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:20:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:20:28 +0000 Subject: [Koha-bugs] [Bug 15677] Misconfigured anonymous patron allows checkouts to multiple patrons. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14978 --- Comment #3 from Jonathan Druart --- Barton, this should be fixed by the addition of the unique key on issues.itemnumber, see bug 14978 (in 3.20.7) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:20:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:20:28 +0000 Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15677 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:27:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:27:00 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #9 from Jonathan Druart --- (In reply to Kyle M Hall from comment #0) > We should enable TT syntax for slips and notices. This could work side by > side with the existing syntax parser for a release or two before we > officially remove our bespoke parsing code for slips and notices, giving > libraries ample time to switch over. The existing syntax is quite easy to understand/modify for everybody, but the TT syntax is not. I would like to see a discussion on koha-devel to know if everybody agrees on the removal of the existing syntax, or if we should support both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:34:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:34:38 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #20 from Jonathan Druart --- Jesse, I would love to see this code moved to a module covered by tests. Do you think it's conceivable? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:37:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:37:37 +0000 Subject: [Koha-bugs] [Bug 15209] C4::Koha routines expecting a MARC::Record object should check it is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15209 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:39:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:39:07 +0000 Subject: [Koha-bugs] [Bug 15692] Move some patron entry form JavaScript into members.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15692 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47392|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 47453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47453&action=edit Bug 15692 - Move some patron entry form JavaScript into members.js We should strive to keep as much JavaScript as possible out of templates in order to keep things modular and maximize the benefits of browser caching. This patch moves JavaScript out of the patron entry template Two other minor edits: Missing semicolons added on the advice of JSHint. To test, apply the patch and confirm that the following interactions still work on the patron entry form: 1. clear_entry(): With ExtendedPatronAttributes enabled, the "Clear" link next to any attribute form field should work to clear the field. 2. clone_entry(): With ExtendedPatronAttributes enabled and a repeatable attribute defined, it should be possible to click the "New" link to add another instance of that attribute's entry field. 3. update_category_code(): With ExtendedPatronAttributes enabled and an attribute defined which is limited to a single patron category, changing the patron category selection should correctly show or hide the attribute entry form. 4. select_user(): When adding or editing a patron with a "Child" category it should be possible to search for and select a guarantor to add to the record by clicking the "Set to patron" button. Selecting a new guarantor should change the text of the button from "Set to patron" to "Change." 5. noEnterSubmit(): This function should be correctly preventing you from hitting "ENTER" in any form field to submit the form. 6. guarantordelete(): When adding or editing a patron with a "Child" category, it should be possible to clear existing guarantor information by clicking the "Delete" button. Clicking the "Delete" button should change the text of the adjacent button to "Set to patron." 7. select_city(): With one or more cities defined it should be possible to use the drop-down menu of cities to populate the city, state, zip, and country fields. 8. Date of birth entry should have a maximum date limit of yesterday. The drop-down menu of years should go back 100 years. 9. Client-side validation rules should be in effect, requiring that a valid email address be entered in the primary email, secondary email, and alternate address email fields. 10.When editing a patron, the "Add manual restriction" link should display the form for adding a manual restriction, and clicking the "Cancel" link should hide it. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:39:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:39:33 +0000 Subject: [Koha-bugs] [Bug 15692] Move some patron entry form JavaScript into members.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15692 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:42:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:42:37 +0000 Subject: [Koha-bugs] [Bug 15516] RFC: Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:43:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:43:34 +0000 Subject: [Koha-bugs] [Bug 9754] koha-remove optionally includes var/lib and var/spool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9754 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #10 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:43:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:43:43 +0000 Subject: [Koha-bugs] [Bug 15516] RFC: Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:45:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:45:06 +0000 Subject: [Koha-bugs] [Bug 15391] HoldsQueue.t does not handle for loan itemtypes correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #11 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:47:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:47:25 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47412|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 47454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47454&action=edit Bug 12051: Adds a Renew tab to the staff client UPDATE: Added to checkin-search.inc to show up on returns.pl To test: 1) Apply patch 2) Confirm that there is now a Renew tab on the pages where there is also a Check-in tab only 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:47:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:47:29 +0000 Subject: [Koha-bugs] [Bug 15398] Batch patron deletion/anonymization issue page: Restricted dropdown menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15398 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:48:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:48:25 +0000 Subject: [Koha-bugs] [Bug 13177] Add help pages for Rotating collections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13177 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #11 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:50:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:50:24 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #26 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:51:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:51:44 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 --- Comment #13 from Jonathan Druart --- Aleisha, I have amended your patch to remove files where only 1 line where added/removed. I have also fixed a 3 vs 2: +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/suggestions-add-search.inc @@ -23,10 +23,11 @@
    [% END %] +
    I was going to pass QA on this patch, but I am wondering if the permission should not be CAN_user_circulate_circulate_remaining_permissions instead of CAN_user_circulate. Indeed the circ/renew.pl script needs only this subperm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:53:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:53:57 +0000 Subject: [Koha-bugs] [Bug 15693] Unnecessary punctuation mark when check-in an item in a library other than the home branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:53:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:53:59 +0000 Subject: [Koha-bugs] [Bug 15693] Unnecessary punctuation mark when check-in an item in a library other than the home branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47402|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 47455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47455&action=edit Bug 15693: Unnecessary punctuation mark when check-in an item in a library other than the home branch To test: 1-Checkin an item in a library other than the home branch. 2-A message will display asking to return the item to the home branch 3-You will see the phrase "Print slip )" 4-Apply patch 5-Reproduce or repeat steps 1-2 and verify the punctuation mark is no longer displayed Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:54:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:54:14 +0000 Subject: [Koha-bugs] [Bug 15355] Translatability: Fix issues on check in page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15355 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15693 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15693 [Bug 15693] Unnecessary punctuation mark when check-in an item in a library other than the home branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 11:54:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 10:54:14 +0000 Subject: [Koha-bugs] [Bug 15693] Unnecessary punctuation mark when check-in an item in a library other than the home branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |15355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15355 [Bug 15355] Translatability: Fix issues on check in page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:09:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:09:19 +0000 Subject: [Koha-bugs] [Bug 15684] Fix encoding issues with quote upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- The patch looks good bug I don't see the quotes in the table after selecting the file. Note that I also get a "Uploads limited to csv. Incorrect filetype: plain/text", I have bypassed forcing the filetype in the tt (+fileType = 'csv';). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:12:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:12:03 +0000 Subject: [Koha-bugs] [Bug 15353] patron image disappears when on fines tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:13:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:13:39 +0000 Subject: [Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #26 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:17:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:17:26 +0000 Subject: [Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org --- Comment #3 from Jonathan Druart --- "firstname, surname" is the form we usually use to display a patron name. I am not sure about this change, ccing Owen and Katrin to get some feedbacks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:18:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:18:35 +0000 Subject: [Koha-bugs] [Bug 15357] Deleting all items on a record with title level holds creates orphaned/ghost holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15357 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:19:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:19:57 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 --- Comment #9 from Jonathan Druart --- >From discussion on bug 15662, it appears that the original wording was better. The problem was not the wording bug the strong tag in the middle of the sentence. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:20:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:20:27 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 --- Comment #6 from Jonathan Druart --- I have let a note on bug 15573 comment 9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:20:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:20:38 +0000 Subject: [Koha-bugs] [Bug 15573] String and translatability fix to Patron Card Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15662 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:20:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:20:38 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15573 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:24:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:24:39 +0000 Subject: [Koha-bugs] [Bug 15643] Every datepicker on serials expected date column updates top issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:24:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:24:42 +0000 Subject: [Koha-bugs] [Bug 15643] Every datepicker on serials expected date column updates top issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47371|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 47456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47456&action=edit Bug 15643 - Every datepicker on serials expected date column updates top issue delete 'expected' and 'supexpected' ids that don't seem useful anymore. Same thing for changeDate2 function Test plan : 1) Search a serial subscription from the Serials Home page 2)Go to serial collection page and make sure it has a mimimal bunch of already received or missing issues 3)Check some received issues to be sure to get extra issues (not only the extected one) in the serial edition page 4) Click on Edit serials button 5) Try to modify whatever date in 'Expected on' column (excepted first one) using datepicker : You can see that the top date of the column is updated instead of the choosen one. 6) Apply patch and redo 1 to 5 steps : now the right date is updated. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:25:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:25:03 +0000 Subject: [Koha-bugs] [Bug 15643] Every datepicker on serials expected date column updates top issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |koha at univ-lyon3.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:30:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:30:54 +0000 Subject: [Koha-bugs] [Bug 15684] Fix encoding issues with quote upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 --- Comment #7 from Marc V?ron --- (In reply to Jonathan Druart from comment #6) > The patch looks good bug I don't see the quotes in the table after selecting > the file. > Note that I also get a "Uploads limited to csv. Incorrect filetype: > plain/text", I have bypassed forcing the filetype in the tt (+fileType = > 'csv';). The instructions say: The quote uploader accepts standard csv files with two columns: "source","text" This bug does not aim to change this behaviour. I think changing the accepted file type extension and/or the behaviour regarding the quotes should be covered by an other bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:36:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:36:19 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart --- Could you please detail what do we need this new column? 1/ There is no fk on it 2/ can be null but C4::Overdues::UpdateFine requires it 3/ The prototype of UpdateFine is weird, you have to pass issue_id, itemnumber and borrowernumber. issue_id should be enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:36:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:36:45 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 --- Comment #15 from Jonathan Druart --- (In reply to Katrin Fischer from comment #10) > Hi Kyle, > after thinking some about this, how are we going to deal with multiple fine > lines for the same issue? If the item is renewed the due date in issues will > change and a new fine line should be generated. The old due date information > will then be lost. I wonder if we should store the due date that the fine > was generated for additionally to the link in accountlines - in a separate > date column. Katrin, since there is no constraint on this new column, I don't understand your comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:42:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:42:20 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:42:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:42:23 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensuring that the title of a link shows up on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47387|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 47457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47457&action=edit Bug 15640: Removing title for links on circulation-home.tt To test: Go to Circulation and ensure there are no titles on hover over the links Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:43:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:43:04 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensure there are no titles on hover over the links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Summary|Accessibility - ensuring |Accessibility - ensure |that the title of a link |there are no titles on |shows up on hover |hover over the links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:43:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:43:14 +0000 Subject: [Koha-bugs] [Bug 15640] Accessibility - ensure there are no titles on hover over the links (circ home page) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15640 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility - ensure |Accessibility - ensure |there are no titles on |there are no titles on |hover over the links |hover over the links (circ | |home page) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:44:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:44:37 +0000 Subject: [Koha-bugs] [Bug 15665] Better wording of error messages when importing MARC frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15665 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:44:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:44:41 +0000 Subject: [Koha-bugs] [Bug 15665] Better wording of error messages when importing MARC frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15665 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47386|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 47458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47458&action=edit Bug 15665: Better wording of error messages when importing MARC frameworks UPDATE: Making error messages the same To test: 1) Go to Admin -> MARC frameworks 2) Click Import next to any framework. You won't actually be overwriting or importing anything as this is only a string fix, so it can be an existing framework 3) Click the Import button without attaching any file. Confirm it says "Please select a spreadsheet (.csv, .ods, .xml) file." and that this makes sense to you 4) Attempt to attach a file that is not a .csv, .ods or .xml file. You should instantly get an error message saying "Please select a CSV (.csv), ODS (.ods) or XML (.xml) file." Confirm this shows up and makes sense to you Signed-off-by: Hector Castro Rewording Ok. Works as described Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:46:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:46:30 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:46:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:46:33 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47403|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 47459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47459&action=edit Bug 14168 - enhance streaming cataloging to include youtube Add optional embedding of YouTube videos via HTML5Media. New syspref: HTML5MediaYouTube: Embed/Don't embed videos. Format WEBM is hardcoded as it is the only format accepted by all modern browsers. Test plan: - apply patch - catalogue a YouTube link in 856$u - turn on HTML5MediaEnabled and HTML5MediaYouTube - open the record in OPAC and staff client, check that the 'Play media' tab is showing and playing the video works. Possible enhancements for followups: - check available formats, offer quality choice - accept official YT URL shortener Signed-off-by: Aleisha Works perfectly! Signed-off-by: Nicole C Engard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:46:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:46:41 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 --- Comment #18 from Kyle M Hall --- Created attachment 47460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47460&action=edit Bug 14168 [QA Followup] - Fix typo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 12:47:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 11:47:39 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- It would be good to add a link to https://wiki.koha-community.org/wiki/SubmitingAPatch and/or https://wiki.koha-community.org/wiki/Development_workflow (I let the choice of the logo to someone else) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:03:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:03:27 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 --- Comment #16 from Katrin Fischer --- Hi Joubu, not really a database structure problem I was worried about, having the issue_id certainly makes sense and no FK seems fine as the id can be in issues or old_issues. I was wondering as this is no 1:1 but a 1:n if the calcuation will be correct. If it will still add another separate line in accountlines if an item goes overdue - renew - overdue - renew... etc. If the due date is removed from the description or no longer used, this information will get lost etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:03:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:03:35 +0000 Subject: [Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:03:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:03:37 +0000 Subject: [Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47381|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 47461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47461&action=edit Bug 15687: Fix xgettext.pl syntax errors Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:03:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:03:47 +0000 Subject: [Koha-bugs] [Bug 15687] Syntax errors in misc/translator/xgettext.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15687 --- Comment #9 from Kyle M Hall --- Created attachment 47462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47462&action=edit Bug 15687 [QA Followup] - Tidy sub to remove tab characters Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:08:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:08:09 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #12 from Jonathan Druart --- Nick, I am sorry but I don't understand why 1/ the barcode is not kept (and auto generated) 2/ you are not using the same method as in additem.tt Also:

    Please enter a number, greater than or equal to 1

    Don't add tagin the middle of a sentence, it makes translation harder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:12:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:12:21 +0000 Subject: [Koha-bugs] [Bug 15684] Fix encoding issues with quote upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:12:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:12:23 +0000 Subject: [Koha-bugs] [Bug 15684] Fix encoding issues with quote upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15684 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47415|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 47463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47463&action=edit Bug 15684: Fix encoding issues with quote upload To verify: - Download attachment 'Goethe with umlaut' from Bug 15684 - Go to Tools > Quote Editor - Click "Import quotes" and select the file - The quotes display in a table. Click 'Sav quotes' - Result: Nothing happens To test: - Apply patch - Repeat steps above - Verify that you get a message '2 quotes saved' and that the quotes are added in to the quotes table - Test with attachment 'sample quotes' as well Signed-off-by: Mirko Tietgen Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:12:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:12:52 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #64 from Jonathan Druart --- When I have updated the DB, I got a lot of warnings: item-level_itypes set but no itype defined for item (3751) at installer/data/mysql/updatedatabase.pl line 11728. Should we keep them or hide them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:14:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:14:50 +0000 Subject: [Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 --- Comment #4 from Katrin Fischer --- Hm, not sure if I am confused, but firstname surname or surname, firstname For sorting and in general I prefer definitely the latter :) Ideally the code should check for the existance of firstname, as we also have organisations where this field will remain empty (not displayed in the patron form even). So I'd say something like: surname[if firstname], firstname[end] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:16:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:16:02 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #65 from Jonathan Druart --- It seems that I get the warning when an item does not exist. Maybe we should check the deleteditems table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:16:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:16:58 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #66 from Katrin Fischer --- Can you quickly explain how the warn is caused? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:17:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:17:52 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #67 from Katrin Fischer --- Missed your last comment, sorry! We usually use deleteditems for statistics too - so it makes sense to include it I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:18:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:18:21 +0000 Subject: [Koha-bugs] [Bug 15576] Link in OPAC redirects to the wrong page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15576 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:18:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:18:28 +0000 Subject: [Koha-bugs] [Bug 15599] Unit tests output warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15599 --- Comment #9 from Kyle M Hall --- (In reply to M. Tompsett from comment #8) > (In reply to Jonathan Druart from comment #7) > > Kyle, the warnings appear for many other tests, see > > t/db_dependent/Reserves.t for instance. > > I don't think this is a right way to fix it. > > Perhaps not overall, however, taking "string $foo->bar" and turning it to > "string $foobar" is a start. Catching warnings is a good test. Perhaps > "$debug and" prepended to the {warn mess} would be fitting, and still allow > for the testing added? I'm open to whatever solution may be proposed. This is starting to go out of scope. The bug is for just two unit tests. I think the $debug and warn idea sounds good! We could have it set to 1 by default and set it to 0 in our unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:22:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:22:14 +0000 Subject: [Koha-bugs] [Bug 4912] After editing private list, user should be redirect to private lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4912 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #31 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:24:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:24:00 +0000 Subject: [Koha-bugs] [Bug 15355] Translatability: Fix issues on check in page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15355 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:35:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:35:09 +0000 Subject: [Koha-bugs] [Bug 15703] New: Time::Piece is only used in Review.t and can be replaced Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15703 Bug ID: 15703 Summary: Time::Piece is only used in Review.t and can be replaced Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:35:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:35:33 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- (In reply to Jonathan Druart from comment #6) > Should not we take 0 into account? I agree. Allowing 0 would mean a patron must have no fines in order to renew items. I think allowing 0 makes sense. It would also be good to note in the system preference description that leaving it empty will disable the feature ( i.e. patrons will always be able to renew items, no matter how much they owe in fines ). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:38:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:38:58 +0000 Subject: [Koha-bugs] [Bug 15703] Time::Piece is only used in Review.t and can be replaced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15703 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID --- Comment #1 from Jonathan Druart --- Oops, it's a core module, forget that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:41:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:41:41 +0000 Subject: [Koha-bugs] [Bug 15577] Link in OPAC doesn't redirect anywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15577 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 13:45:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 12:45:37 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #40 from Jonathan Druart --- Please fix t_db_dependent_Auth_t.The file errors/500.tt should be accessible (contains integers) (734) http://jenkins.koha-community.org/job/Koha_Master_D8/lastBuild/testReport/junit/%28root%29/t_db_dependent_Auth_t/The_file_errors_500_tt_should_be_accessible__contains_integers___734_/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 14:00:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 13:00:11 +0000 Subject: [Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 --- Comment #5 from Marc V?ron --- (In reply to Katrin Fischer from comment #4) (...) > Ideally the code should check for the existance of firstname, as we also > have organisations where this field will remain empty (not displayed in the > patron form even). > > So I'd say something like: > > surname[if firstname], firstname[end] Katrin, I missed that while signing off because it is about instructors / teachers who normally schould have first names :-) ...but you are right, it makes sense to display the firstname only if there is a first name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 14:02:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 13:02:23 +0000 Subject: [Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 --- Comment #6 from Katrin Fischer --- Maybe a faculty or work group account? (quote 123 :) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 14:08:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 13:08:07 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 --- Comment #8 from Marc V?ron --- (In reply to Kyle M Hall from comment #7) > (In reply to Jonathan Druart from comment #6) > > Should not we take 0 into account? > > I agree. Allowing 0 would mean a patron must have no fines in order to renew > items. I think allowing 0 makes sense. It would also be good to note in the > system preference description that leaving it empty will disable the feature > ( i.e. patrons will always be able to renew items, no matter how much they > owe in fines ). ...and maybe the wording should reflect the >0 and 0 cases (with and without displaying the limit), and in a translatable way (sentence not split by tags). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 14:22:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 13:22:20 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #41 from Marc V?ron --- Created attachment 47464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47464&action=edit Bug 15288: (follow-up) Make t/db_dependent/Auth.t pass Changed test from (deleted) 500.tt to erroroage.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 14:26:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 13:26:48 +0000 Subject: [Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 --- Comment #7 from Marc V?ron --- (In reply to Katrin Fischer from comment #6) > Maybe a faculty or work group account? (quote 123 :) ) Or even kind of room reservation... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 14:43:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 13:43:20 +0000 Subject: [Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 --- Comment #8 from Katrin Fischer --- Libraries... who knows :) Not a blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 14:43:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 13:43:56 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #11 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 14:51:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 13:51:11 +0000 Subject: [Koha-bugs] [Bug 12636] Batch patron modification should not update with unique patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12636 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:03:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:03:55 +0000 Subject: [Koha-bugs] [Bug 15702] Patron details: Problems with leading and trailing blanks (surname, firstname, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 --- Comment #2 from Owen Leonard --- Thanks for filing this bug--I should have done so ages ago. This is enough of a problem for us that I regularly run a report to catch these records and correct them. I'm not sure why librarians here are so trigger-happy on the keyboard. We addressed this issue a long time ago with barcodes. See in returns.pl, line 253: $barcode =~ s/^\s*|\s*$//g; # remove leading/trailing whitespace Is there any reason not to trim leading and trailing whitespace from all the data submitted during patron entry? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:04:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:04:41 +0000 Subject: [Koha-bugs] [Bug 14555] Warns in opac-search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #14 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:06:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:06:08 +0000 Subject: [Koha-bugs] [Bug 14810] Improve messages in patron anonymizing tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14810 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:11:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:11:30 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:12:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:12:22 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #13 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:13:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:13:49 +0000 Subject: [Koha-bugs] [Bug 15609] spelling mistake in :692: writen ==> written In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15609 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:16:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:16:10 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #211 from Charles Farmer --- The follow-up patch to change the namespace of this development is in bug 15585 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:19:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:19:07 +0000 Subject: [Koha-bugs] [Bug 14624] <> for advance_notices.pl wrongly documented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:23:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:23:58 +0000 Subject: [Koha-bugs] [Bug 15195] patron details should open in tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15195 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:28:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:28:05 +0000 Subject: [Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #7 from bondiurbano --- (In reply to Katrin Fischer from comment #6) > Looking at your example - I think what happened is: > > The item was checked out on the 26th with due date 26th, but after the > auto_renewal job was run for that day. > > On the 27th in the morning the job was run again, but the item was overdue > by then - so renewal was blocked. > > That makes sense to me to be honest. I am not sure how to avoid that. > > > I think if the "No renewal before" is empty, we could agree that it should > > try on the due date - but witht he parameter set the behaviour should be > > changed. > > NOT be changed... :) Katrin, I have finished my tests. My conclusion is that automatic_renewals.pl works fine if "No renewals before" is informed in the issuing rules, i.e., "No renewals before" is mandatory for that automatic_renewals.pl works fine. Otherwise (my case) it doesn't update the due date of the loan. I will update my internal procedures to adopt this approach. Thanks for you patience. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:34:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:34:16 +0000 Subject: [Koha-bugs] [Bug 15476] Listname not always displayed in shelves.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15476 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:40:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:40:37 +0000 Subject: [Koha-bugs] [Bug 15100] MARC21: Display of $d for 7xx and 1xx fields should be optional In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15100 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #11 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:42:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:42:50 +0000 Subject: [Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:43:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:43:42 +0000 Subject: [Koha-bugs] [Bug 15592] spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15592 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:44:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:44:11 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 --- Comment #3 from Ian Palko --- Perhaps a reminder that the next Ubuntu LTS is due out in less than 3 months, and Koha will be broken on that platform unless the dependency issue is fixed. Perhaps we could get this patched and signed off before then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:46:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:46:18 +0000 Subject: [Koha-bugs] [Bug 15468] Search links on callnumbers with parentheses fails on OPAC results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:48:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:48:31 +0000 Subject: [Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #10 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:49:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:49:51 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #20 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:50:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:50:39 +0000 Subject: [Koha-bugs] [Bug 15586] References to Koha::Branches remain in unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15294 CC| |julian.maurice at biblibre.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:50:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:50:39 +0000 Subject: [Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15586 [Bug 15586] References to Koha::Branches remain in unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:52:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:52:05 +0000 Subject: [Koha-bugs] [Bug 14641] Warns in subscription-add.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #12 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:58:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:58:38 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15616 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15616 [Bug 15616] Spelling mistake in opac-account.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 15:58:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 14:58:38 +0000 Subject: [Koha-bugs] [Bug 15616] Spelling mistake in opac-account.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15616 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Depends on| |11622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:00:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:00:28 +0000 Subject: [Koha-bugs] [Bug 15611] Spelling mistake: implimented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15611 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:00:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:00:34 +0000 Subject: [Koha-bugs] [Bug 15613] Spelling mistake: paramter vs parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15613 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:00:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:00:42 +0000 Subject: [Koha-bugs] [Bug 15614] Spelling mistake in circ/pendingreserves.tt: Fullfilled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15614 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:00:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:00:48 +0000 Subject: [Koha-bugs] [Bug 15619] Spelling mistake in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15619 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:02:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:02:24 +0000 Subject: [Koha-bugs] [Bug 15621] Spelling mistake in printinvoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15621 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:02:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:02:29 +0000 Subject: [Koha-bugs] [Bug 15623] Spelling mistake in boraccount.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15623 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:02:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:02:36 +0000 Subject: [Koha-bugs] [Bug 15624] Spelling mistake in suggestion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15624 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:05:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:05:19 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #23 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:12:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:12:31 +0000 Subject: [Koha-bugs] [Bug 15375] Translatability: Fix issues on OPAC page 'Placing a hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15375 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #20 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:13:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:13:30 +0000 Subject: [Koha-bugs] [Bug 15589] OPAC Lists "his" string fix In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15589 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:14:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:14:05 +0000 Subject: [Koha-bugs] [Bug 15597] Typo in opac-auth-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:14:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:14:52 +0000 Subject: [Koha-bugs] [Bug 15598] Typo in subscription-add.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15598 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:15:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:15:59 +0000 Subject: [Koha-bugs] [Bug 15608] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15608 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:16:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:16:06 +0000 Subject: [Koha-bugs] [Bug 15608] Spelling mistake in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15608 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:18:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:18:03 +0000 Subject: [Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:21:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:21:59 +0000 Subject: [Koha-bugs] [Bug 15298] z39.50 admin setup, options column suggested changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:58:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:58:26 +0000 Subject: [Koha-bugs] [Bug 15704] New: split up 264 index Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704 Bug ID: 15704 Summary: split up 264 index Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 14198 Right now the 260 index look like this: pl:w pl:p Publisher:w Publisher:p copydate:w copydate:s pl:w Provider:w The 264 only indexes the entire thing. Provider:w We should break the 264 up for better/more accurate searching. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 [Bug 14198] RDA: Indexing 264 field (Zebra) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 16:58:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 15:58:26 +0000 Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15704 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704 [Bug 15704] split up 264 index -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:13:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:13:37 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 --- Comment #17 from Kyle M Hall --- (In reply to Jonathan Druart from comment #14) > Could you please detail what do we need this new column? > 1/ There is no fk on it Right, as Katrin wrote, since the issue_id can be in issues or old_issues, we can't give it a key constraint. > 2/ can be null but C4::Overdues::UpdateFine requires it I suppose we *could* make it not null, but then how do we deal with adding an issue_id to all the already existing account lines? We can definitely update the ones that are currently accruing. Those are the only ones where it really matters. > 3/ The prototype of UpdateFine is weird, you have to pass issue_id, > itemnumber and borrowernumber. issue_id should be enough. Agreed, I should change that. I was just trying to make the smallest change possible. It would make sense for it to just take issue_id ( or an issue object if possible ). If you'd like to see that change just set the status to failed qa and let me know! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:17:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:17:38 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 --- Comment #18 from Kyle M Hall --- (In reply to Katrin Fischer from comment #16) > I was wondering as this is no 1:1 but a 1:n if the calcuation will be > correct. If it will still add another separate line in accountlines if an > item goes overdue - renew - overdue - renew... etc. If the due date is > removed from the description or no longer used, this information will get > lost etc. You are right, it is a one to many join from issues to accountlines. One item may go overdue multiple times. However, there should only ever be one *accruing* fine for a given issue at a time, so it shouldn't be a problem. The current query already deals with that in that the FU fine will be the first selected and matched by issue_id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:19:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:19:12 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #25 from Kyle M Hall --- Created attachment 47465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47465&action=edit Bug 14390 [QA Followup] - Allow OpacFineNoRenewals to be 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:19:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:19:43 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47465|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:20:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:20:14 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:20:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:20:17 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 --- Comment #9 from Kyle M Hall --- Created attachment 47466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47466&action=edit Bug 14930 [QA Followup] - Allow OpacFineNoRenewals to be 0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:21:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:21:32 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #10 from Jonathan Druart --- Comment on attachment 47176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47176 Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices Review of attachment 47176: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14757&attachment=47176) ----------------------------------------------------------------- ::: C4/Letters.pm @@ +1414,5 @@ > + issues => { > + module => 'Koha::Checkouts', > + singular => 'checkout', > + plural => 'checkouts', > + fk => 'itemnumber', We should use `pk => issue_id` and update existing calls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:44:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:44:02 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Kyle M Hall --- Per conversation with Katrin, we should make sure to clean up any multiple FU fines that haven't been closed out in a db update for this. Setting to failed qa until I get that done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:47:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:47:31 +0000 Subject: [Koha-bugs] [Bug 15691] Show card number minimum and maximum in visible hint when adding a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15691 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:47:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:47:33 +0000 Subject: [Koha-bugs] [Bug 15691] Show card number minimum and maximum in visible hint when adding a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15691 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47390|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 47467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47467&action=edit Bug 15691: Show card number minimum and maximum in visible hint when adding a patron The CardnumberLength system preference defines card number minimum and maximum allowed values when adding a patron. This information is currently hidden in a title attribute on the card number input field. This patch moves the information into a
    , matching other fields in the entry form which offer details about entry guidelines. To test, apply the patch and open the new patron entry form. Test for various values of CardnumberLength, and with 'cardnumber' mandatory or not mandatory as defined in BorrowerMandatoryField. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:49:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:49:59 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #26 from Kyle M Hall --- (In reply to Kyle M Hall from comment #25) > Created attachment 47465 [details] [review] > Bug 14390 [QA Followup] - Allow OpacFineNoRenewals to be 0 Wrong bug! Patch obsoleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:55:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:55:56 +0000 Subject: [Koha-bugs] [Bug 15705] New: Notify the user on auto renewing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Bug ID: 15705 Summary: Notify the user on auto renewing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Customisable notices must be triggered to tell patrons if the items were renewed and when failed to renew. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:56:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:56:38 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14757, 15582, 15581 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 [Bug 15581] Add a circ rule to limit the auto renewals given a delay https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:56:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:56:38 +0000 Subject: [Koha-bugs] [Bug 15581] Add a circ rule to limit the auto renewals given a delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 [Bug 15705] Notify the user on auto renewing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:56:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:56:38 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 [Bug 15705] Notify the user on auto renewing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:56:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:56:38 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 [Bug 15705] Notify the user on auto renewing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:58:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:58:36 +0000 Subject: [Koha-bugs] [Bug 15667] Messages in patron account display dates wrongly formatted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15667 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47391|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 47468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47468&action=edit Bug 15667: Fix date and branch formatting of messages in patron account display This patch fixes the date and branch formatting of messages in patron account display. To verify: Add a new message to a patron account from the 'checkouts' tab in staff, the displayed date is not correctly formatted and the branch displays as code instead as branch name To test: Apply patch, verify that the messages and branch names are properly formatted. Signed-off-by: Hector Castro Works as described. The message dates in checkouts tab follow dateformat sypref Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 17:58:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 16:58:33 +0000 Subject: [Koha-bugs] [Bug 15667] Messages in patron account display dates wrongly formatted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15667 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 18:17:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 17:17:20 +0000 Subject: [Koha-bugs] [Bug 15692] Move some patron entry form JavaScript into members.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15692 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 18:17:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 17:17:23 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 18:17:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 17:17:23 +0000 Subject: [Koha-bugs] [Bug 15692] Move some patron entry form JavaScript into members.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15692 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47453|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 47469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47469&action=edit Bug 15692 - Move some patron entry form JavaScript into members.js We should strive to keep as much JavaScript as possible out of templates in order to keep things modular and maximize the benefits of browser caching. This patch moves JavaScript out of the patron entry template Two other minor edits: Missing semicolons added on the advice of JSHint. To test, apply the patch and confirm that the following interactions still work on the patron entry form: 1. clear_entry(): With ExtendedPatronAttributes enabled, the "Clear" link next to any attribute form field should work to clear the field. 2. clone_entry(): With ExtendedPatronAttributes enabled and a repeatable attribute defined, it should be possible to click the "New" link to add another instance of that attribute's entry field. 3. update_category_code(): With ExtendedPatronAttributes enabled and an attribute defined which is limited to a single patron category, changing the patron category selection should correctly show or hide the attribute entry form. 4. select_user(): When adding or editing a patron with a "Child" category it should be possible to search for and select a guarantor to add to the record by clicking the "Set to patron" button. Selecting a new guarantor should change the text of the button from "Set to patron" to "Change." 5. noEnterSubmit(): This function should be correctly preventing you from hitting "ENTER" in any form field to submit the form. 6. guarantordelete(): When adding or editing a patron with a "Child" category, it should be possible to clear existing guarantor information by clicking the "Delete" button. Clicking the "Delete" button should change the text of the adjacent button to "Set to patron." 7. select_city(): With one or more cities defined it should be possible to use the drop-down menu of cities to populate the city, state, zip, and country fields. 8. Date of birth entry should have a maximum date limit of yesterday. The drop-down menu of years should go back 100 years. 9. Client-side validation rules should be in effect, requiring that a valid email address be entered in the primary email, secondary email, and alternate address email fields. 10.When editing a patron, the "Add manual restriction" link should display the form for adding a manual restriction, and clicking the "Cancel" link should hide it. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 18:17:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 17:17:26 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #1 from Jonathan Druart --- Created attachment 47470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47470&action=edit Bug 15705: Notify the user on auto renewing When an issue is auto renewed, a notice will be sent to the patron. The notice will tell if the renewed has been successfully done. Note that this patch is not ready to be pushed yet, as it has some defects: - 1 notice per issue - no way to disable the notice generation - no way to specify patron categories to enable/disable the notifications Test plan: Use the automatic_renewals.pl script to auto renew issues. If the auto renew has failed or succeeded, a notice will be generated in the message_queue table. If the error is "too_soon" or is the same as the previous error, the notice won't be generated (we do not want to spam the patron). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 18:17:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 17:17:30 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #2 from Jonathan Druart --- Created attachment 47471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47471&action=edit Bug 15705: DB Changes - Add [old_]issues.auto_renew_error and the AUTO_RENEWALS notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 18:17:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 17:17:33 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 --- Comment #3 from Jonathan Druart --- Created attachment 47472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47472&action=edit Bug 15705: [DO NOT PUSH] DBIC Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 18:18:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 17:18:42 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #4 from Jonathan Druart --- Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 18:23:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 17:23:53 +0000 Subject: [Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 --- Comment #3 from Kyle M Hall --- Comment on attachment 47274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47274 Bug 15564 - Display "print slip" option when returning an item which is in a rotating collection Review of attachment 47274: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15564&attachment=47274) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ +134,5 @@ > > [% IF ( collectionItemNeedsTransferred ) %] > + > +
    > +

    [% title or "item" |html %] is part of a rotating collection and needs to be transferred to [% Branches.GetName( returnbranch ) %]
    ( Print slip )

    Why print title or "item". I don't think we do this anywhere else. Also, should we be using the html filter here? Hasn't Jonathan been removing these because of XSS vulnerabilities? Is it necessary? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 18:24:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 17:24:17 +0000 Subject: [Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 18:33:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 17:33:15 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #11 from Kyle M Hall --- (In reply to Jonathan Druart from comment #10) > (In reply to Francois Charbonnier from comment #8) > > Jonathan, could you sign them off on my behalf? > > Added on the remote branch :) Jonathan, could you rebase your patches and attach them to this bug? I'd like to try to QA them! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 18:47:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 17:47:50 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #201 from Brendan Gallagher --- (In reply to Jonathan Druart from comment #200) > @RM: please don't squash these patches, it will be helpful to have the > history if a regression if found later. Will not squash :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 18:52:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 17:52:26 +0000 Subject: [Koha-bugs] [Bug 15631] Move the cities related code to Koha::Cities - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15631 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 18:52:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 17:52:28 +0000 Subject: [Koha-bugs] [Bug 15631] Move the cities related code to Koha::Cities - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15631 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47010|0 |1 is obsolete| | Attachment #47062|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 47473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47473&action=edit Bug 15631: Koha::Cities - remove getzipnamecity C4::Members::getzipnamecity was not used and can be remove safely. Test plan: git grep getzipnamecity should not return any result. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 18:52:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 17:52:35 +0000 Subject: [Koha-bugs] [Bug 15631] Move the cities related code to Koha::Cities - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15631 --- Comment #5 from Kyle M Hall --- Created attachment 47474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47474&action=edit Bug 15631: Koha::Cities - remove getidcity and GetCities C4::Members::getidcity and C4::Members::GetCities simply retrieved cities info from the cities table. The job done in members/memberentry.pl looked really weird and complicated. Either I have missed something, or this patch can simplify it. The expected behavior is: 1. Create a new patron => No city selected 2. Edit an existing patron => The borrowers.city value is selected 3. Add a guarantee => The borrowers.city of the guarantor is selected 4. Edit a guarantee => The borrowers.city of the guarantee is selected Test plan: Confirm that the expected behaviors are the ones before and after this patch. Signed-off-by: Natasha Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 19:10:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 18:10:26 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- (In reply to Jonathan Druart from comment #6) > I have let a note on bug 15573 comment 9 This syntax style is based on coding guideline JS4. I think we should retain it for consistencies sake, or update the guidelines to reflect this new stance. Now that we have the format method for strings, this style of wording is no longer necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 19:14:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 18:14:52 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #11 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 19:18:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 18:18:44 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #202 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! (we'll probably have some more spots to work on this). Great job though! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 19:22:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 18:22:11 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 --- Comment #8 from Chris Nighswonger --- (In reply to Kyle M Hall from comment #7) > (In reply to Jonathan Druart from comment #6) > > I have let a note on bug 15573 comment 9 > > This syntax style is based on coding guideline JS4. I think we should retain > it for consistencies sake, or update the guidelines to reflect this new > stance. Now that we have the format method for strings, this style of > wording is no longer necessary. Reading over JS4, it seems that even that may not cover all cases. It is conceivable that some languages may have syntax which wants the strings at the beginning rather than the end. That said, I have no problem with it going where ever; just a preference for the original. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 19:33:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 18:33:01 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 19:56:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 18:56:41 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #78 from Kyle M Hall --- Created attachment 47475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47475&action=edit Bug 7677 [QA Followup] - Replace GetItemnumberFromSerialId with use of Koha::Serial::Item(s) GetItemnumberFromSerialId has no unit tests. It would be better to start using our object system here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 20:14:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 19:14:40 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- > I was going to pass QA on this patch, but I am wondering if the permission > should not be CAN_user_circulate_circulate_remaining_permissions instead of > CAN_user_circulate. Indeed the circ/renew.pl script needs only this subperm. I think the issue at hand is that this is really just repeating an existing bug. For instance, in cat-search.inc, the checkin box is wrapped with [% IF ( CAN_user_circulate ) %] yet a librarian with only CAN_user_circulate_circulate_remaining_permissions should be able to see the box, as checkins only require circulate_remaining_permissions. I would suggest we leave it the way it is for now for the sake of consistency and file a new bug to fix the issue globally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 20:17:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 19:17:04 +0000 Subject: [Koha-bugs] [Bug 15706] New: Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Bug ID: 15706 Summary: Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com For instance, in cat-search.inc, the checkin box is wrapped with [% IF ( CAN_user_circulate ) %] yet a librarian with only CAN_user_circulate_circulate_remaining_permissions should be able to see the box, as checkins only require circulate_remaining_permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 20:17:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 19:17:25 +0000 Subject: [Koha-bugs] [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12051 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 20:17:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 19:17:25 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15706 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 20:18:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 19:18:14 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 20:18:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 19:18:17 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47454|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 47476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47476&action=edit Bug 12051: Adds a Renew tab to the staff client UPDATE: Added to checkin-search.inc to show up on returns.pl To test: 1) Apply patch 2) Confirm that there is now a Renew tab on the pages where there is also a Check-in tab only 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 20:19:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 19:19:01 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 --- Comment #16 from Kyle M Hall --- I have filed bug 15706 for the more systemic issue brought up by Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 20:23:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 19:23:14 +0000 Subject: [Koha-bugs] [Bug 15662] String and translatability fix to Label Creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 --- Comment #9 from Kyle M Hall --- > Reading over JS4, it seems that even that may not cover all cases. It is > conceivable that some languages may have syntax which wants the strings at > the beginning rather than the end. > > That said, I have no problem with it going where ever; just a preference for > the original. That sounds like a good argument for updating JS4. Using the format method allows the translator more control over where the numbers would appear. The only limitation would be that they must still be in the same order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 20:29:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 19:29:58 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #13 from Nick Clemens --- Created attachment 47477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47477&action=edit Bug 14752 - increment barcodes when adding multiples if present and uniqueness enforced To test: 1 - Enter a barcode value that ends in a number 2 - Attempt to add multiple items 3 - Items should eb added with increasing barcodes 4 - Enter a barcode not ending in a number 5 - Attempt to add multiple items 6 - You should get an error modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 20:30:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 19:30:12 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 21:36:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 20:36:39 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 21:36:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 20:36:42 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47393|0 |1 is obsolete| | Attachment #47394|0 |1 is obsolete| | Attachment #47395|0 |1 is obsolete| | Attachment #47396|0 |1 is obsolete| | --- Comment #66 from Nick Clemens --- Created attachment 47478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47478&action=edit Bug 10612 - Add ability to delete patrons with batch patron deletion tool This patch adds the ability to select a patron list for deletetion when using the Batch patron deletion/anonymization tool. It also adds buttons to the the patron lists table to access both the batch deletion and batch modification directly from the lists view. This is a squash of previous patches but now adds a patron_list_id parameter to C4::Members::GetBorrowersToExpunge and uses that routine to fetch patrons from a list. Test Plan: 1) Apply this patch 2) Create a list of patrons with the new Patron Lists feature 3) Try using the batch edit link form the lists table 4) Try using the batch delete link from the lists table 5) Verify previous functionality has not changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 29 21:37:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jan 2016 20:37:09 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver at bywatersolutions.co |nick at bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 30 01:52:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jan 2016 00:52:15 +0000 Subject: [Koha-bugs] [Bug 15702] Patron details: Problems with leading and trailing blanks (surname, firstname, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 --- Comment #3 from Marc V?ron --- (In reply to Owen Leonard from comment #2) > Thanks for filing this bug--I should have done so ages ago. This is enough > of a problem for us that I regularly run a report to catch these records and > correct them. I'm not sure why librarians here are so trigger-happy on the > keyboard. > > We addressed this issue a long time ago with barcodes. See in returns.pl, > line 253: $barcode =~ s/^\s*|\s*$//g; # remove leading/trailing whitespace > > Is there any reason not to trim leading and trailing whitespace from all the > data submitted during patron entry? I think there is no any reason to not trim trailin and leading whte spaces. Please go ahead and I will be to signoff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 30 10:48:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jan 2016 09:48:58 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |h.meissner.82 at web.de, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 30 11:03:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jan 2016 10:03:37 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- > The existing syntax is quite easy to understand/modify for everybody, but > the TT syntax is not. > I would like to see a discussion on koha-devel to know if everybody agrees > on the removal of the existing syntax, or if we should support both. It would be nice to have all the advantages of TT, but I am also worried that it will make it harder for libraries to change the notices themselves. It currently works quite well, although we have some placeholders that are not well known or not very consistent ( vs. <> vs. ---- etc.) and need explaining. I looked at the changes on bug 15280 and that looked not too bad. I think key is to have better documentation to explain the change and make it easier to see which variables can be used where and what additional features this will make available. I'd be interested to see how this change will affect the editor - no patch there yet on bug 15277, maybe a screenshot? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 30 20:41:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jan 2016 19:41:14 +0000 Subject: [Koha-bugs] [Bug 15695] koha-plack script does not enable plack when plack has never been enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15695 philippe kloos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wwwretive at yahoo.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 30 20:41:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jan 2016 19:41:34 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #42 from Mirko Tietgen --- Working on this. Ported the template to Bootstrap, was broken before. Struggling with PGP design flaws. If this is supposed to work without any knowledge on the librarian side, there needs to be a way to prevent people from "stealing a patrons identity". Right now, patron uploads key, key will be used to encrypt emails to patron. However, the connection 'patron' => 'key' is done by gpg: - patron uploads public key - (if previous key for email address exists, it is deleted) - key is stored in gpg (keyring of the koha system user) Let's say an attacker generates a key pair with patron's email address in the UID and uploads it to the attacker's own user account. Patron's old key gets deleted, the new one is used for patron's account. Patron will find out once they cannot open their emails from the library. If the attacker managed to get the email(s) up to this point, they are able to open them, because they got the relevant private key. There needs to be a way to connect patron and key in Koha. The easiest and best for our use case would be to have the public keys in the Koha DB only and encrypt emails using what the DB has, without the gpg key management. Unfortunately that does not seem to be possible at all, at least I could not find it yet. I mean something like "gpg, encrypt text x with public key $public_key_as_string_from_db" Workarounds either need interference on the librarian side or prevent updating patron's public key. I am still hoping to get this working for libraries with zero interest in crypto. I will look into what could be done with some kind of Key ID verification by the patron, but it would be overly complicated compared to storing keys in the db per patron. Sorry, just thinking aloud. If you accidentally receive this transmission and think I am missing something, feel free to interrupt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 04:52:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 03:52:02 +0000 Subject: [Koha-bugs] [Bug 15704] split up 264 index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 05:37:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 04:37:07 +0000 Subject: [Koha-bugs] [Bug 15704] split up 264 index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Hi Katrin Split-up the index like 260 was my first intention when I added the new index "provider" also was splitted up in 'Provider-place', and 'Provider-date'. NOTE: Clarified that the latter two do not exist in the documentation. If we want to collect all indexes in Provider -this is the true intention of the index, not just collect 260, 264 but also 270, 257- works if you change etc/zebradb/ccl.properties as follow Provider 1=1225 pv Provider Place-publication Publisher copydate the exmaple above follows yaz documentation at in section 1.2.2.2 Qualifier alias. This at least is not more accurate but will launch more search results Please let me know which solution do you prefer or/also I can attach two patches to see which is most suitable. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 11:55:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 10:55:55 +0000 Subject: [Koha-bugs] [Bug 14689] Marc field 648 does not appear in the subject index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14689 Michael Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik at adminkuhn.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:32:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:32:54 +0000 Subject: [Koha-bugs] [Bug 15707] New: Add ability to define hierarchical groups of libraries Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Bug ID: 15707 Summary: Add ability to define hierarchical groups of libraries Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Koha needs the ability to create hierarchical groups of libraries. This ability could be used in many areas of Koha to make Koha much more flexible and consortium friendly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:36:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:36:13 +0000 Subject: [Koha-bugs] [Bug 15708] New: Add ability to allow only items whose home/holding branch matches one of a group of libraries to fill a given hold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15708 Bug ID: 15708 Summary: Add ability to allow only items whose home/holding branch matches one of a group of libraries to fill a given hold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This enhancement will extend the functionality added in Bug 15532 using the library groups editor in Bug 15707 to allow not only holds from a single library match but a group of libraries that match. This will give much greater flexibility in defining what items should full what holds within a groups of libraries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:36:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:36:30 +0000 Subject: [Koha-bugs] [Bug 15708] Add ability to allow only items whose home/holding branch matches one of a group of libraries to fill a given hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15708 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15707, 15532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 [Bug 15707] Add ability to define hierarchical groups of libraries -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:36:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:36:30 +0000 Subject: [Koha-bugs] [Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15708 [Bug 15708] Add ability to allow only items whose home/holding branch matches one of a group of libraries to fill a given hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:36:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:36:30 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15708 [Bug 15708] Add ability to allow only items whose home/holding branch matches one of a group of libraries to fill a given hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:36:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:36:33 +0000 Subject: [Koha-bugs] [Bug 15708] Add ability to allow only items whose home/holding branch matches one of a group of libraries to fill a given hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15708 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:36:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:36:39 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15708 | Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15708 [Bug 15708] Add ability to allow only items whose home/holding branch matches one of a group of libraries to fill a given hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:36:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:36:39 +0000 Subject: [Koha-bugs] [Bug 15708] Add ability to allow only items whose home/holding branch matches one of a group of libraries to fill a given hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15708 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15707 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 [Bug 15707] Add ability to define hierarchical groups of libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:36:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:36:59 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15708 [Bug 15708] Add ability to allow only items whose home/holding branch matches one of a group of libraries to fill a given hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:36:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:36:59 +0000 Subject: [Koha-bugs] [Bug 15708] Add ability to allow only items whose home/holding branch matches one of a group of libraries to fill a given hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15708 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15707 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 [Bug 15707] Add ability to define hierarchical groups of libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:38:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:38:28 +0000 Subject: [Koha-bugs] [Bug 15709] New: Main navigation looks funny Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15709 Bug ID: 15709 Summary: Main navigation looks funny Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Project website Assignee: wizzyrea at gmail.com Reporter: mirko at abunchofthings.net It seems like the entry for Kohacon 2012 is missing under "Kohacon", but we have the Kohacon 2012 schedule and sponsors as main entries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:38:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:38:50 +0000 Subject: [Koha-bugs] [Bug 15709] Koha website main navigation looks funny In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15709 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Main navigation looks funny |Koha website main | |navigation looks funny -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:40:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:40:19 +0000 Subject: [Koha-bugs] [Bug 15710] New: Kohacon 2015 is missing in the list of Kohacons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15710 Bug ID: 15710 Summary: Kohacon 2015 is missing in the list of Kohacons Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Project website Assignee: wizzyrea at gmail.com Reporter: mirko at abunchofthings.net There is no entry for Kohacon 2015 in Nigeria on the Kohacon subpage https://koha-community.org/kohacon/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:40:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:40:27 +0000 Subject: [Koha-bugs] [Bug 15710] Kohacon 2015 is missing in the list of Kohacons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15710 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:40:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:40:29 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #1 from Kyle M Hall --- Created attachment 47479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47479&action=edit Bug 15707 - Add Treegrid library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:40:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:40:42 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #2 from Kyle M Hall --- Created attachment 47480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47480&action=edit Bug 15707 - Update DB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:40:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:40:44 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #3 from Kyle M Hall --- Created attachment 47481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47481&action=edit Bug 15707 - Add new modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:40:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:40:46 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #4 from Kyle M Hall --- Created attachment 47482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47482&action=edit Bug 15707 - Add editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:40:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:40:48 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #5 from Kyle M Hall --- Created attachment 47483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47483&action=edit Bug 15707 - Add and update schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:54:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:54:19 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #6 from Kyle M Hall --- Created attachment 47484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47484&action=edit Bug 15707 - Add TreeGrid library to about page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 12:56:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 11:56:45 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #43 from Mirko Tietgen --- I will change the patch to store a keyid per user email address in Koha and make GnuPG.pm use that for all relevant operations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 15:17:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 14:17:21 +0000 Subject: [Koha-bugs] [Bug 15450] koha-community.org/kohacon/ needs update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15450 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- This is fixed - 2 other bugs exist for other minor changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 22:18:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 21:18:39 +0000 Subject: [Koha-bugs] [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 --- Comment #1 from Aleisha Amohia --- Created attachment 47485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47485&action=edit Bug 15706: Changing to circulate_remaining_permissions I have only changed this in the includes for the tabs at the top. Dependent on Bug 12051 as that patch adds extra tabs to the top which would need to be changed later To test: 1) Apply Bug 12051 first, then this patch 2) Ensure that Check Out/Check In/Renew tabs still work as they should 3) Check patch for errors or pages I've missed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 22:18:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 21:18:36 +0000 Subject: [Koha-bugs] [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 22:18:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 21:18:48 +0000 Subject: [Koha-bugs] [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12051 CC| |aleishaamohia at hotmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 [Bug 12051] add renew tab to top on staff client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 31 22:18:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2016 21:18:48 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15706 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions -- You are receiving this mail because: You are watching all bug changes.