[Koha-bugs] [Bug 6934] New report Cash Register Statistics

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
QA comments:
1/ +function isNull(f,noalert) {
not used later

2/ The datepicker from/to should be done using the datepickerfrom and
datepickerto css class (see acqui/histsearch.tt for an example).

3/ Why do we have to fill a date?

4/ Ergonomic: the date interval is in a table with only 1 column and 1 row, it
could be better to move them in the same fieldset as the 2 dropdown lists.

5/ $fullreportname is only used once, not needed.

6/ +my $fromDate = dt_from_string;
and later
+    beginDate        => dt_from_string($fromDate),
You are passing a DT to dt_from_string, a string is expected.

7/ Remove the unneeded commented lines ("^###")

8/ The csv file should be generated using Text::CSV::Encoded

9/ The column names should be retrieved using C4::Reports::Guided to get the
translated values

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.