[Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Jan 7 04:26:14 CET 2016
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586
David Cook <dcook at prosentient.com.au> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29948|0 |1
is obsolete| |
--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
Created attachment 46380
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46380&action=edit
Bug 12586 - Record matching rules - Required match checks doesn't work with
MARCXML
When trying to Match MARCXML-records from Zebra using Required match checks,
C4::Matcher::_passes_required_checks()
tries to make a MARC::Record out of MARCXML while thinking it is USMARC.
This leads to matching records getting not-matched, and subsequently importing
the same records again and again.
Very hard to debug or create a test case.
I accidentally noticed this while building an automatic acquisitions record
overlay mechanism.
There are no big errors, simply no match is found, even though a match exists.
Also refactored the Matcher a bit to prevent excessive MARC::Record creation
for each "Required match check"
for each search results. This probably would cripple any reasonably sized batch
Matching operations.
---------
TEST PLAN
---------
1. Create a Matcher with "Required match checks" in addition to normal checks.
2. Find matches using the C4::Matcher->get_matches() and notice that you don't
find matches.
3. Somebody who is actually using this Matcher could help me out here with
defining a test plan.
Signed-off-by: David Cook <dcook at prosentient.com.au>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list