[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #104 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #80)
> Hm, I tend to agree with Jonathan on first glance. I think the new object
> code tends to be quite short and readable - so having it all in one file
> seems easier to comprehend. Some of the newly introduced files by this patch
> are really very short and the copyright/license is almost the biggest part
> of them. A 1:1-relation between template and .pl file also often makes it
> easier to navigate the code for me.

I must respectfully disagree. I think assertion that this is without precedent
is also incorrect. Please see modrequest.pl, placerequest.pl, and
modrequest_suspendall.pl, add_message.pl, deletemem.pl, mod_debarment.pl,
setstatus.pl for examples of similar behavior.

At this point those scripts are simple enough that it may seem silly, but I'm
sure memberentry.pl was quite simple when it was first written as well. Now it
has if statments like:
if ( ($op eq 'modify' || $op eq 'insert' || $op eq 'save'|| $op eq 'duplicate')
and ($step == 0 or $step == 3 )){

I also believe the assertion that this duplicates code is incorrect. There is
actually very little code shared between the two scripts if you don't count the
boilerplate that all Koha cgi scripts have. Basically the duplicated code is
the get_template_and_user call.

-- 
You are receiving this mail because:
You are watching all bug changes.