[Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 19 14:50:26 CET 2016


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 46862
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46862
Bug 14310 [QA Followup] - Adapt existing code to use new methods

Review of attachment 46862:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14310&attachment=46862)
-----------------------------------------------------------------

::: C4/Reserves.pm
@@ +1178,4 @@
>              } else {
> +                # FIXME: Why are we doing this? Should this be resuming the hold,
> +                # or maybe suspending it indefinitely?
> +                $hold->set( { suspend_until => undef } )->store();

Indeed, this is weird.
If suspend_until is defined, it should be a date.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list