[Koha-bugs] [Bug 15298] z39.50 admin setup, options column suggested changes

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 19 16:39:05 CET 2016


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Some good possible follow-ups (or new bugs I guess):

1. Validate the HTML to identify some issues with duplicate IDs in the markup.
I signed off on the patch because the page already had some duplicate IDs, so
it didn't seem fair to hold it up for that. But we should make the page
validate.

2. Eliminate the use of 'href="javascript:void(0);"'

Progressive-enhancement best practices say that ideally a real URL should be
used instead, one which is a fallback for non-JavaScript users. However, we
don't require that the staff client be fully functional without JS turned on,
so the accepted alternative is to use 'href="#"' The ConfirmDelete() function
already returns false, so clicking the link won't result in the page jumping
around.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list