[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Jan 21 12:48:15 CET 2016


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #233 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 47090
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47090
Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Record.pm

Review of attachment 47090:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6679&attachment=47090)
-----------------------------------------------------------------

::: C4/Record.pm
@@ +380,4 @@
>      }
>  
>      # Preprocessing
> +    eval {$preprocess} if ($preprocess);

post-fixed 'if' logic prevents a higher level of perlcritic, doesn't it?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list