[Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584

--- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
Looking at an instance where "dialog error" is used, I see this in
itemtypes.tt:

  [% IF message.type == 'success' %]
      <div class="dialog message">
  [% ELSIF message.type == 'warning' %]
      <div class="dialog alert">
  [% ELSIF message.type == 'error' %]
      <div class="dialog error" style="margin:auto;">
  [% END %]

In the past we have not distinguished between warnings and errors. Both were
styled with the "dialog alert" style. But I'm not opposed to defining a new
style specifically for errors and setting up a guideline for its use. I can
imagine it being useful to say this, for instance:

- "dialog alert" used in cases where there is a problem which requires the user
to respond to a question: Yes or no, proceed or cancel.

- "dialog error" used in cases where the process is stopped, blocked by an
error and there is no path forward.

I prefer simplicity if this distinction is not necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.