[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #241 from M. Tompsett <mtompset at hotmail.com> ---
Here is my testing output. It should be noted that patches 1 and 2 are not
required for level 5 testing. However, they are necessary for higher levels. It
should also be noted that I added:
    [InputOutput::RequireCheckedSyscalls]
    functions = :builtins
    exclude_functions = print
to the perlcriticrc, so I wouldn't have to do stupidity like:
    my $ignore = print "Hello World!";
But that should be a patch to the qa test tools, not Koha itself.

mtompset at debian:~/kohaclone$ git reset --hard origin/master
HEAD is now at 2505a3d Bug 15607: batch patron mod - do not update dates if not
                                                                            
given
mtompset at debian:~/kohaclone$ perlcritic -5 C4/Installer/PerlModules.pm
C4/Installer/PerlModules.pm source OK
mtompset at debian:~/kohaclone$ perlcritic -5 C4/TmplToken.pm
C4/TmplToken.pm source OK
mtompset at debian:~/kohaclone$ perlcritic -5 C4/TmplTokenType.pm
Subroutine prototypes used at line 86, column 1.  See page 194 of PBP. 
(Severit                                                                       
     y: 5)
Subroutine prototypes used at line 87, column 1.  See page 194 of PBP. 
(Severit                                                                       
     y: 5)
Subroutine prototypes used at line 88, column 1.  See page 194 of PBP. 
(Severit                                                                       
     y: 5)
Subroutine prototypes used at line 89, column 1.  See page 194 of PBP. 
(Severit                                                                       
     y: 5)
Subroutine prototypes used at line 90, column 1.  See page 194 of PBP. 
(Severit                                                                       
     y: 5)
Subroutine prototypes used at line 91, column 1.  See page 194 of PBP. 
(Severit                                                                       
     y: 5)
Subroutine prototypes used at line 92, column 1.  See page 194 of PBP. 
(Severit                                                                       
     y: 5)
Subroutine prototypes used at line 93, column 1.  See page 194 of PBP. 
(Severit                                                                       
     y: 5)
Subroutine prototypes used at line 94, column 1.  See page 194 of PBP. 
(Severit                                                                       
     y: 5)
mtompset at debian:~/kohaclone$ perlcritic -5 opac/ilsdi.pl
Stricture disabled at line 220, column 17.  See page 429 of PBP.  (Severity: 5)
mtompset at debian:~/kohaclone$ git reset --hard origin/master
HEAD is now at 2505a3d Bug 15607: batch patron mod - do not update dates if not
given
mtompset at debian:~/kohaclone$ perlcritic -5 C4/Installer/PerlModules.pm
C4/Installer/PerlModules.pm source OK
mtompset at debian:~/kohaclone$ perlcritic -5 C4/TmplToken.pm
C4/TmplToken.pm source OK
mtompset at debian:~/kohaclone$ perlcritic -5 C4/TmplTokenType.pm
Subroutine prototypes used at line 86, column 1.  See page 194 of PBP. 
(Severity: 5)
Subroutine prototypes used at line 87, column 1.  See page 194 of PBP. 
(Severity: 5)
Subroutine prototypes used at line 88, column 1.  See page 194 of PBP. 
(Severity: 5)
Subroutine prototypes used at line 89, column 1.  See page 194 of PBP. 
(Severity: 5)
Subroutine prototypes used at line 90, column 1.  See page 194 of PBP. 
(Severity: 5)
Subroutine prototypes used at line 91, column 1.  See page 194 of PBP. 
(Severity: 5)
Subroutine prototypes used at line 92, column 1.  See page 194 of PBP. 
(Severity: 5)
Subroutine prototypes used at line 93, column 1.  See page 194 of PBP. 
(Severity: 5)
Subroutine prototypes used at line 94, column 1.  See page 194 of PBP. 
(Severity: 5)
mtompset at debian:~/kohaclone$ perlcritic -5 opac/ilsdi.pl
Stricture disabled at line 220, column 17.  See page 429 of PBP.  (Severity: 5)
mtompset at debian:~/kohaclone$ git bz apply 6679
Bug 6679 - Fixing code so it passes basic Perl::Critic tests

47086 - Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in
C4/TmplTokenType.pm
47087 - Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in
C4/Installer/PerlModules.pm
47088 - Bug 6679 - Fixing code so it passes basic Perl:::Critic tests
47089 - Bug 6679: (follow-up) fix 9 perlcritic violations in
C4/TmplTokenType.pm

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in
C4/TmplTokenType.pm
Applying: Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in
C4/Installer/PerlModules.pm
Applying: Bug 6679 - Fixing code so it passes basic Perl:::Critic tests
Applying: Bug 6679: (follow-up) fix 9 perlcritic violations in
C4/TmplTokenType.pm
mtompset at debian:~/kohaclone$ perlcritic -5 C4/Installer/PerlModules.pm
C4/Installer/PerlModules.pm source OK
mtompset at debian:~/kohaclone$ perlcritic -5 C4/TmplToken.pm
C4/TmplToken.pm source OK
mtompset at debian:~/kohaclone$ perlcritic -5 C4/TmplTokenType.pm
C4/TmplTokenType.pm source OK
mtompset at debian:~/kohaclone$ perlcritic -5 opac/ilsdi.pl
opac/ilsdi.pl source OK
mtompset at debian:~/kohaclone$ ls -la ~/.perlcriticrc
lrwxrwxrwx 1 mtompset mtompset 26 Apr 27  2015 /home/mtompset/.perlcriticrc ->
qa-test-tools/perlcriticrc
mtompset at debian:~/kohaclone$ cat ~/qa-test-tools/perlcriticrc
severity = 5
include = ProhibitUnusedVariables
exclude = Miscellanea::RequireRcsKeywords


[Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval]
allow_includes =1

[TestingAndDebugging::RequireUseStrict]
equivalent_modules = Modern::Perl

[TestingAndDebugging::RequireUseWarnings]
equivalent_modules = Modern::Perl

[-Modules::RequireBarewordIncludes]

[InputOutput::RequireCheckedSyscalls]
functions = :builtins
exclude_functions = print
mtompset at debian:~/kohaclone$

-- 
You are receiving this mail because:
You are watching all bug changes.