[Koha-bugs] [Bug 15618] Small typos in system preferences

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618

--- Comment #24 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
(In reply to Katrin Fischer from comment #21)
> > @@ +278,4 @@
> > >          -
> > >              - "Restrict patrons with the following target audience values from checking out inappropriate materials:"
> > >              - pref: AgeRestrictionMarker
> > > +            - "E.g. Enter target audience keyword(s) split by | (pipe) FSK|PEGI|Age| (No white space near |). Be sure to map agerestriction in Koha to MARC mapping (e.g. 521$a). A MARC field value of FSK 12 or PEGI 12 would mean: 'Borrower must be 12 years old'. Leave empty to not apply an age restriction."
> > 
> > I was noticing 856u in another patch on this bug report. Are we doing 856u
> > or 856$u? We have 521$a here. Should it be 521a?
> 
> I think 521$u makes sense, if we have other cases without $ we could fix
> them separately. I think some options require you to enter without $, so
> have to be careful fixing.
> 
I can find which patch you said had the 856u and change that to 856$u if that
is the preferred format.

> > 
> > @@ -365,5 @@
> > >                choices:
> > > -                  confirm: "require confirmation"
> > > -                  alert: "display a message"
> > > -                  nothing : "do nothing"
> > > -            - .
> > 
> > I like this '.' removal and placing at the end of the strings.
> 
> The extra . at the end creates a separate string in the translation files
> and is a little advantage for translations. Because it's not always easy to
> built a grammatically correct sentence that has the options at the end, this
> extra string for the . allows to split the sentence up and have some words
> after the option list - not sure if I used it here, but I did in some other
> cases.
> 
Sorry I'm not sure if I understand, so you'd like the full stop in a separate
string like it was before I changed it? To me it just looked strange to have a
full stop lingering on the end, but if it is better for translation to have it
the way it was before then it'll need to be changed in more places than just my
patches.

> > 
> > @@ +523,5 @@
> > >              - pref: emailLibrarianWhenHoldIsPlaced
> > >                choices:
> > > +                  yes: Do
> > > +                  no:  "Don't"
> > > +            - "send an email to the Koha administrator email address whenever a hold request is placed."
> > 
> > "Send" "Don't send"? I don't see why this change is necessary.
> 
> I think the change makes it a bit easier to read.
Before it said 'Enable / Don't enable sending an email' which I thought could
be made simpler with 'Do / Don't send'. However 'Send / Don't send' is
basically a shortcut of that too so I can make that change if you'd both like.

-- 
You are receiving this mail because:
You are watching all bug changes.