[Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block"

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666

--- Comment #2 from bondiurbano <costalc at gmail.com> ---
(In reply to Katrin Fischer from comment #1)
> Hi Bondiurbano, 
> 
> > 1) Now, when automatic_renewals.pl tries to renew due items the sysprefs
> > vars OverduesBlockRenewing and RestrictionBlockRenewing don't allow
> > renewing. That's right for these sysprefs vars but not for renewing.
> 
> Do they only block when renewal would be blocked in the OPAC too or did the
> new feature break the auto renewals?

The problem occurs when OverduesBlockRenewing is set to "block". This syspref
var is a recent enhancement. I agree how it works. But now they is also
blocking automatic renewals and this is not correct. I think that when
OverduesBlockRenewing was added as a control var in syspref nobody of us took
into account this.

> 
> > 
> > 2) Automatic_renewals.pl should work like a user should: must renew his
> > issues the date they due.
> > 
> > 3) Thus automatic_renewals.pl should always avoid loans expire. So
> > automatic_renewals.pl must consider only issues which due date is equal to
> > the date automatic_renewals.pl is executing. 
> 
> I think 2) and 3) are not how this feature is supposed to work. 
> The automatic renewal cronjob takes the "No renewal before" value from the
> circulation conditions into account. So you can say: Try to renew for the
> first time X days before the due date. This means that you can also time a
> reminder notice to the same day: 
> Try to renew 5 days before the due date - if renewal fails, the
> advance_notices.pl job can run after and send a reminder. If it was always
> the day of the due date - you couldn't send a reminder and things would go
> overdue immediately instead 

"No renewal before" is an optional setting so it could be absent in the rule.
Automatic_renewals.pl must be executed BEFORE the item date_due expires.
Otherwise it will be a due item and so OverduesBlockRenewing will block it.
This is my point. Apart from "No renewal before" settings,
automatic_renewals.pl works as a "replacement" of a manual action by a user or
Staff. I'm testing now. ASAP I will attach a sample that hope helps better than
my poor english...

> 
> > 4) I think that CanBookBeRenewed in Circulation.pm must be updated but do
> > not how...
> 
> Can you explain?
> 
> > 5) In automatic_renewals.pl it is needed to change the mysql command to this
> > one:
> > 
> > SELECT borrowernumber, itemnumber, branchcode FROM issues WHERE auto_renew =
> > 1 AND DATE(date_due) = DATE(NOW())
> 
> I disagree - see above.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.