[Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240

--- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Your change generally looks good to me. But I will be very precise here :)

Note that you use TO_DAYS in the query. So you select the current date with all
hours too. Formerly, records of today were compared with date_to_run (including
time) eliminating the records in hours still to come. As long as $mindays is
not zero (from overduerules), these records will be discarded later on (L
544-555) since mindays may not be zero in the code of this script (line 490).

Another point is the -date parameter. I am not sure what it actually should do
btw, since it is documented rather poorly. Looking through code, it seems to
mimic running on a different date (e.g. say -date <yesterday> or -date
<tomorrow> e.g.). The same argument as above could be repeated for the records
of the specific date given via this parameter.
This actually brings me to the conclusion that you made a large first step, but
the second step would be moving the checks for mindays and maxdays into the SQL
statement too. Note that it may run three times with different values for the
three triggers. Another report? 

Related: While testing PREDUE and ODUE, I found that using -n on the command
line will generate the error that the print notice for PREDUE and ODUE are not
found. Copying them from email, revealed that PREDUE should use a block
<item>...</item> in order to have the title displayed, or should use
<items.content>. In a new installation this should be corrected. If you confirm
that, we could address it on a new report too?

I used the opportunity to add a few minor adjustments in a follow-up.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.