[Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #27)
> Another point is the -date parameter. I am not sure what it actually should
> do btw, since it is documented rather poorly. Looking through code, it seems
> to mimic running on a different date (e.g. say -date <yesterday> or -date
> <tomorrow> e.g.). The same argument as above could be repeated for the
> records of the specific date given via this parameter.

That's exactly what it does.

> This actually brings me to the conclusion that you made a large first step,
> but the second step would be moving the checks for mindays and maxdays into
> the SQL statement too. Note that it may run three times with different
> values for the three triggers. Another report? 

I had in mind it was not possible, because of the calendar checks.
But looking at the code again, it seems possible.

> Related: While testing PREDUE and ODUE, I found that using -n on the command
> line will generate the error that the print notice for PREDUE and ODUE are
> not found. Copying them from email, revealed that PREDUE should use a block
> <item>...</item> in order to have the title displayed, or should use
> <items.content>. In a new installation this should be corrected. If you
> confirm that, we could address it on a new report too?

Indeed, ODUE.print should exist, we could add the print template if it does not
exist.
PREDUE is used by advance_notices.pl

> I used the opportunity to add a few minor adjustments in a follow-up.

They looks good to me.

> Passed QA

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.