[Koha-bugs] [Bug 15642] Batch patron deletion should not delete patrons with issues

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #6)
> In misc/cronjobs/delete_patrons.pl it's done with:
>  68     my $flags = C4::Members::patronflags( $member );
>  69     if ( my $charges = $flags->{CHARGES}{amount} ) {
>  70         say "Failed to delete patron $borrowernumber: patron has
> $charges in fines";
>  71         next;
>  72     }
> Should not we simply move this check to the GetBorrowersToExpunge subroutine?
FWIW I think I would rather see the checks done as above - so that the warning
is visible that not all patrons in the category/list/etc were deleted.

If the checks were moved into GetBorrowersToExpunge it would be nice to make it
return patrons who wont be deleted because of issues/fines

This is probably a separate enhancement though and I think this report can be
closed.  Agreed?

-- 
You are receiving this mail because:
You are watching all bug changes.