[Koha-bugs] [Bug 12051] add renew tab to top on staff client
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Jan 29 11:51:44 CET 2016
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051
--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Aleisha,
I have amended your patch to remove files where only 1 line where
added/removed.
I have also fixed a 3 vs 2:
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/suggestions-add-search.inc
@@ -23,10 +23,11 @@
</form>
</div>
[% END %]
+
<ul>
<li><a href="#suggestions_search">Search suggestions</a></li>
[% IF ( CAN_user_circulate ) %]<li><a onclick="keep_text(0)"
href="#circ_search">Check out</a></li>[% END %]
- [% IF ( CAN_user_catalogue ) %]<li><a onclick="keep_text(1)"
href="#catalog_search">Search the catalog</a></li>[% END %]
+ [% IF ( CAN_user_catalogue ) %]<li><a onclick="keep_text(2)"
href="#catalog_search">Search the catalog</a></li>[% END %]
</ul>
</div>
I was going to pass QA on this patch, but I am wondering if the permission
should not be CAN_user_circulate_circulate_remaining_permissions instead of
CAN_user_circulate. Indeed the circ/renew.pl script needs only this subperm.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list