[Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #14)
> Could you please detail what do we need this new column?
> 1/ There is no fk on it

Right, as Katrin wrote, since the issue_id can be in issues or old_issues, we
can't give it a key constraint.

> 2/ can be null but C4::Overdues::UpdateFine requires it

I suppose we *could* make it not null, but then how do we deal with adding an
issue_id to all the already existing account lines? We can definitely update
the ones that are currently accruing. Those are the only ones where it really
matters.

> 3/ The prototype of UpdateFine is weird, you have to pass issue_id,
> itemnumber and borrowernumber. issue_id should be enough.

Agreed, I should change that. I was just trying to make the smallest change
possible. It would make sense for it to just take issue_id ( or an issue object
if possible ). If you'd like to see that change just set the status to failed
qa and let me know!

-- 
You are receiving this mail because:
You are watching all bug changes.