[Koha-bugs] [Bug 15564] Display "print slip" option when returning an item which is in a rotating collection

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jan 29 18:23:53 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Comment on attachment 47274
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47274
Bug 15564 - Display "print slip" option when returning an item which is in a
rotating collection

Review of attachment 47274:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15564&attachment=47274)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
@@ +134,5 @@
>  
>  [% IF ( collectionItemNeedsTransferred ) %]
> +
> +<div id="rotating-collection" class="dialog message">
> +<h3><a href="/cgi-bin/koha/catalogue/detail.pl?type=intra&biblionumber=[% itembiblionumber %]">[% title or "item" |html %]</a> is part of a rotating collection and needs to be transferred to [% Branches.GetName( returnbranch ) %]<br/>( <a href="#" onclick="Dopop('transfer-slip.pl?transferitem=[% itemnumber %]&branchcode=[% returnbranch %]&op=slip'); return true;">Print slip</a> )</h3>

Why print title or "item". I don't think we do this anywhere else. Also, should
we be using the html filter here? Hasn't Jonathan been removing these because
of XSS vulnerabilities? Is it necessary?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list