[Koha-bugs] [Bug 12051] add renew tab to top on staff client

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
> I was going to pass QA on this patch, but I am wondering if the permission
> should not be CAN_user_circulate_circulate_remaining_permissions instead of
> CAN_user_circulate. Indeed the circ/renew.pl script needs only this subperm.

I think the issue at hand is that this is really just repeating an existing
bug. For instance, in cat-search.inc, the checkin box is wrapped with [% IF (
CAN_user_circulate ) %] yet a librarian with only
CAN_user_circulate_circulate_remaining_permissions should be able to see the
box, as checkins only require circulate_remaining_permissions.

I would suggest we leave it the way it is for now for the sake of consistency
and file a new bug to fix the issue globally.

-- 
You are receiving this mail because:
You are watching all bug changes.