From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 00:47:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Jun 2016 22:47:56 +0000 Subject: [Koha-bugs] [Bug 16837] New: koha-start-zebra should start zebra-indexer too Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16837 Bug ID: 16837 Summary: koha-start-zebra should start zebra-indexer too Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz it would be useful if koha-start-zebra started the zebra-indexer too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 02:22:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 00:22:25 +0000 Subject: [Koha-bugs] [Bug 11000] koha-restore not working: Koha username error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11000 Karam Qubsi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |16.05 --- Comment #3 from Karam Qubsi --- Update : Tested on Debian 8.5 . Koha 16.05.01 (packages ) there is no problem , it is just ubuntu problem . -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 03:45:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 01:45:27 +0000 Subject: [Koha-bugs] [Bug 9259] batch delete marc batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 03:45:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 01:45:31 +0000 Subject: [Koha-bugs] [Bug 9259] batch delete marc batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49746|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia --- Created attachment 53007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53007&action=edit Bug 9259: Ability to delete a staged file once it has been cleaned To test: 1) Go to Tools -> Staged MARC Management and clean a file. If you have no files to clean, go to 'Stage MARC for import' and upload one to clean following the necessary steps. 2) Confirm that once the file has been cleaned, the Action column now shows a Delete button. Confirm this button only shows for cleaned files. 3) Click the Delete button. 4) Confirm that clicking Cancel exits the pop-up message and does not delete the file. 5) Confirm that clicking OK refreshes the list of staged records and the one you just deleted is no longer on it (has been deleted). You can confirm this by checking for the file in mysql (SELECT * FROM import_batches WHERE import_batch_id = X;) 6) Run prove -v t/db_dependent/ImportBatch.t (have written unit tests for CleanBatch and DeleteBatch) Sponsored-by: Catalyst IT Signed-off-by: Liz Rea Catalyst sign off, so needs another one but YAY this is great. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 04:41:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 02:41:10 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51777|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia --- Created attachment 53008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53008&action=edit Bug 16530: Adding a circ sidebar navigation menu Edit: Fast cataloging link should now show on all pages, removed offline circulation links Note: This patch does not create the syspref to activate or deactivate the sidebar, will add that in another patch This adds a sidebar to circ/branchoverdues.tt circ/circulation.tt (I also fixed up some of the indentation in this file to make it easier to see where the divs started and ended) circ/renew.tt circ/returns.tt circ/selectbranchprinter.tt circ/transferstoreceive.tt circ/view_holdsqueue.tt circ/waitingreserves.tt offline_circ/list.tt offline_circ/process_koc.tt To test: 1) Go to all of the above pages and confirm the sidebar menu shows up and fast cataloging link shows up 2) Trigger any error messages you can possibly think of (i.e. on renew.pl: barcode does not exist). Confirm that this does not mess up the layout of the page 3) Go to a user account page, Check out tab. (Since this is a circ/circulation.pl page). Ensure the circ nav sidebar doesn't show up (confirm it looks as it usually does) 4) Decide if you like how things look or not! Sponsored-by: Catalyst IT Signed-off-by: Jan Kissig -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 08:22:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 06:22:02 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #78 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 08:27:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 06:27:16 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #33 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 08:34:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 06:34:59 +0000 Subject: [Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #18 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 08:41:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 06:41:19 +0000 Subject: [Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #24 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 08:44:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 06:44:28 +0000 Subject: [Koha-bugs] [Bug 16670] CGI->param used in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16670 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #13 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 08:47:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 06:47:17 +0000 Subject: [Koha-bugs] [Bug 16692] Error "No method update!" when creating new serial issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16692 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Not needed in 3.22.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 08:50:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 06:50:34 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52850|0 |1 is obsolete| | Attachment #52851|0 |1 is obsolete| | Attachment #52852|0 |1 is obsolete| | Attachment #52853|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy --- Created attachment 53009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53009&action=edit Bug 15006: [QA Follow-up] Indentation for two subroutines Remove tabs from telnet_transport and sip_protocol_loop. Correct indentation. Test plan: Compare files before and after without whitespace (diff -b). Notice only two split lines. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 08:50:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 06:50:40 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #42 from Marcel de Rooy --- Created attachment 53010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53010&action=edit Bug 15006 Sip separate global from login timeouts Timeout logic has been added to the main sip loop However the timeout parameter was initially for the login process which requires a short duration applying such a brief timeout to the main sip loop causes instability in many selfcheck units Most selfchecks have persistent connections and send a periodic status request at intervals (approx every 5mins appears the norm) The timeout was dropping connections by default every 30secs which for the client appears as a very flakey network This patch adds a separate parameter client_timeout that can be used if you do want to force a disconnect if the client sends no requests for a period. By not defining it you can switch off the timeout in the main loop, I recommend this unless you have a good reason not too. If you do want this behaviour you can at least now set it to a more realistic value (see sample config file) Removed the commented out html entry in the config file, this was dead code born of a misconception and was just a source of confusion for users Signed-off-by: Frederic Demians Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 08:50:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 06:50:44 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #43 from Marcel de Rooy --- Created attachment 53011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53011&action=edit Bug 15006: [COUNTERPATCH] Add timeout and strikes to raw_transport The code in raw_transport includes setting a $SIG{ALRM}, but did not use it. For consistency, we add an alarm statement here. Similarly, we add the "three strikes" to raw_transport just as telnet_transport does. Note that raw_transport still responds to other requests, but will exit if there is no valid login within three attempts. (If we want more restrictions, add them later?) Test plan: [1] Start sip session with telnet on raw port 6001. Wait until it times out (probably the default 60 seconds). [2] Change SIPconfig.xml: set timeout=5 for service port 6001. Restart SIP and start another telnet 6001 session. Did it timeout within 5 seconds? [3] Start another 6001 session. Give three wrong requests or false login attempts. Does the connection close? Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 08:50:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 06:50:48 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #44 from Marcel de Rooy --- Created attachment 53012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53012&action=edit Bug 15006: [COUNTERPATCH] Timeout logic in sip_protocol_loop Instead of adding yet another client timeout, I propose to use the policy timeout that we also communicate in send_acs_status. Although I agree that we perhaps better move it from institution to account/login level, this c/should be done on another report. We may have issues with existing configurations. In order to find a compromise between bug 13432 and the originally proposed 15006 patch, this patch allows you to put a zero in the policy timeout entry in the SIPconfig. The timeout logic is moved to a Sip.pm subroutine. Will add a test :) Test plan: [1] Check timeout after login with policy/timeout > 0. [2] Check timeout after login with policy/timeout = 0. (No timeout!) [3] Check timeout after login with no policy timeout. Fallback to service. [4] Check timeout after login with no policy and service timeout. Should fallback to 30 seconds for both login process and after login. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 08:51:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 06:51:31 +0000 Subject: [Koha-bugs] [Bug 16720] DBIx ActionLogs.pm should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16720 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 08:52:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 06:52:10 +0000 Subject: [Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #5) > Passing QA provisionally, we should deal with the interaction with bug 13807 > before anything is pushed. 13807->15006 I rebased 15006 on top of this one. So it can go first.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 08:53:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 06:53:31 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #45 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #35) > Marcel, would you be able to rebase these patches on top of bug 13807? I did now. But in view of Colin's comments I will still have a look on the last patch. Working on it.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 08:55:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 06:55:39 +0000 Subject: [Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16155 CC| |julian.maurice at biblibre.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155 [Bug 16155] Composite keys in TestBuilder and more -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 08:55:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 06:55:39 +0000 Subject: [Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16500 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500 [Bug 16500] Catch two warns in TestBuilder.t with warning_like -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 09:01:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 07:01:11 +0000 Subject: [Koha-bugs] [Bug 16607] Remove CPL/MPL from two unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Depends on| |16155, 11023 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 [Bug 11023] Automatic item modification by age (Was "Toggle new status for items") https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155 [Bug 16155] Composite keys in TestBuilder and more -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 09:01:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 07:01:11 +0000 Subject: [Koha-bugs] [Bug 11023] Automatic item modification by age (Was "Toggle new status for items") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 [Bug 16607] Remove CPL/MPL from two unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 09:01:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 07:01:11 +0000 Subject: [Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607 [Bug 16607] Remove CPL/MPL from two unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 09:05:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 07:05:17 +0000 Subject: [Koha-bugs] [Bug 16717] Remove hardcoded category from Holds.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16717 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 09:07:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 07:07:22 +0000 Subject: [Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css and other issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Not needed in 3.22.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 09:11:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 07:11:48 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16127 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 [Bug 16127] Add discharge menu item to patron toolbar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 09:11:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 07:11:48 +0000 Subject: [Koha-bugs] [Bug 16127] Add discharge menu item to patron toolbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Depends on| |8007 CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.9 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 [Bug 8007] Discharge management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 09:40:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 07:40:48 +0000 Subject: [Koha-bugs] [Bug 16541] Make edit and delete links styled buttons in cities administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16541 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 09:41:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 07:41:36 +0000 Subject: [Koha-bugs] [Bug 16543] Make edit and delete links styled buttons in patron attribute types administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16543 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 09:42:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 07:42:48 +0000 Subject: [Koha-bugs] [Bug 16693] reserve/renewscript.pl is not used and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16693 --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 09:48:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 07:48:52 +0000 Subject: [Koha-bugs] [Bug 16729] Use member-display-address-style*-includes when printing user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 09:56:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 07:56:18 +0000 Subject: [Koha-bugs] [Bug 16747] Fix regression in patron card creator (patron image) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- Not needed in 3.22.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 11:36:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 09:36:40 +0000 Subject: [Koha-bugs] [Bug 16818] CAS redirect broken under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 11:37:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 09:37:35 +0000 Subject: [Koha-bugs] [Bug 16818] CAS redirect broken under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 11:49:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 09:49:13 +0000 Subject: [Koha-bugs] [Bug 16818] CAS redirect broken under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818 --- Comment #1 from Fridolin SOMERS --- I've had this issue. Indeed OPAC url is /cgi-bin/koha/opac-user.pl but for plack it is /opac/opac-user.pl Did you use the koha debian package ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 12:15:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 10:15:55 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #46 from Marcel de Rooy --- Created attachment 53013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53013&action=edit Bug 15006: Add timeout and strikes to raw_transport The code in raw_transport includes setting a $SIG{ALRM}, but did not use it. For consistency, we add an alarm statement here. Similarly, we add the "three strikes" to raw_transport just as telnet_transport does. Note that raw_transport still responds to other requests, but will exit if there is no valid login within three attempts. (If we want more restrictions, add them later?) Test plan: [1] Start sip session with telnet on raw port 6001. Wait until it times out (probably the default 60 seconds). [2] Change SIPconfig.xml: set timeout=5 for service port 6001. Restart SIP and start another telnet 6001 session. Did it timeout within 5 seconds? [3] Start another 6001 session. Give three wrong requests or false login attempts. Does the connection close? Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 12:16:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 10:16:00 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #47 from Marcel de Rooy --- Created attachment 53014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53014&action=edit Bug 15006: Centralize timeout logic and allow zero client timeout Moving timeout logic to one routine in Sip.pm (with unit test). This further implements two suggestions from Kyle and Larry: [1] You could use a client_timeout of 0 to specify no timeout at all. [2] Have the client_timeout default to the timeout if not defined. Test plan: [1] Run t/SIP_Sip.t [2] Test login timeout for raw and telnet. [3] Check ACS status message for timeout value. Should match policy timeout from institution. [4] Test client timeout (zero and non-zero). [5] Remove client timeout. Test fallback to service. [6] Remove service timeout too. Test fallback to 30 at login. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Amended after feedback of Colin. Added a test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 12:17:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 10:17:11 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #48 from Marcel de Rooy --- Kyle: Please verify your signoff. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 12:18:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 10:18:40 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53011|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 12:18:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 10:18:42 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53012|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 12:29:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 10:29:11 +0000 Subject: [Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52111|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:25:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:25:43 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #49 from Colin Campbell --- Comment on attachment 53013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53013 Bug 15006: Add timeout and strikes to raw_transport This is unnecessary - The bogus 3 strikes was already removed in commit 078ce11e113b172726f9ab3180e52a06334d4aab Test plan is ambiguous this routine is not called when using "telnet" authentication. On a raw connection session is started when a sip login is received. If that login fails, the session is terminated. (The login is from the client machine's config so it wont try again with different values) and sends a failed login response before shutting down. If the input is not a login message or a random string it does not respond or login the session but falls through to sip_protocol_loop and times out on the time out set there. I think this should be considered a bug. Its probably the reason why adding a timeout to that had an effect on building up sip sessions as that is meant to be an endless (until logout or connection drop) loop - I think this a bug and that if a connection is not established raw_transport should exit without entering sip_loop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:34:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:34:49 +0000 Subject: [Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:34:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:34:52 +0000 Subject: [Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52941|0 |1 is obsolete| | Attachment #52942|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 53015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53015&action=edit Bug 14968 - found shouldn't be set to null when cancelling holds Signed-off-by: JM Broust Signed-off-by: Broust Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:34:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:34:56 +0000 Subject: [Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 --- Comment #13 from Jonathan Druart --- Created attachment 53016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53016&action=edit Bug 14968 - Provides unit test Signed-off-by: Broust Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:35:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:35:59 +0000 Subject: [Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:39:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:39:47 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #50 from Colin Campbell --- I'll try and tidyup the way login on raw connections handles poor connections. The changes introduced in 13432 was a major regression for us and were no longer using the standard SIPServer.pm as many sites are dependent on large numbers of SIP connections. I'll see if that can all pull together in one patch. I'm resetting the status for the moment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:44:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:44:16 +0000 Subject: [Koha-bugs] [Bug 16583] Strangeness in the staff client on ubuntu 16.04 and MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583 --- Comment #4 from Ian Palko --- (In reply to Nicholas van Oudtshoorn from comment #3) > Are there any plans for debian to migrate from MySQL to MariaDB? Latest > mariadb works fine with Koha under fedora... This is because MariaDB still is configured to accept the less-than-strict way things have been implemented in Koha. Since MySQL 5.1 there has been a strict mode. I would have caused the same problems back then, but "strict mode" was not the default. It became default in 5.7. MySQL 5.7 will work fine with Koha if it is put in the less-strict mode. It also would work fine if we translate the less-than-strict calls into strict calls. It also would work fine if the Koha code is cleaned-up to conform to strict behaviour. The latter seems to me the most preferable long-term solution, since it guarantees future compatibility without hacky fixes. That's a lot of work to do that, however, the first two options would make for a more short-term solution to get Koha running on MySQL 5.7. I don't know that there are plans to move to MariaDB or officially support it. Still, to be clear, this is a MySQL problem, it's a Koha problem. MariaDB simply allows for our less-than-strict implementation, but if it too eventually decides to follow MySQL's lead, we would have the same issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:47:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:47:13 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:47:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:47:19 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52835|0 |1 is obsolete| | --- Comment #83 from Jonathan Druart --- Created attachment 53017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53017&action=edit Bug 14048: Add RefundLostItemFeeRule table and classes This patch introduces new classes for handling refund lost item fee rules. It introduces a new table for storing this rules. It is designed so it is possible to define a global rule, and then branch-specific ones. The specific is prefered if available. This behaviour is fully tested by unit tests introduced by the following patches. This cannot be tested on its own. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:47:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:47:29 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52836|0 |1 is obsolete| | --- Comment #84 from Jonathan Druart --- Created attachment 53018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53018&action=edit Bug 14048: Unit tests This patch introduces unit tests for the feature. To test: - Have all patches from this bug applied - Run: $ prove -v t/db_dependent/RefundLostItemFeeRule.t => SUCCESS: All tests pass! Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:47:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:47:38 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52837|0 |1 is obsolete| | --- Comment #85 from Jonathan Druart --- Created attachment 53019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53019&action=edit Bug 14048: Add a refund rules setting form in smart-rules This patch introduces the CRUD UI for managing the refund lost item fee rules on the general 'Circulation and fines rules' page. Verify that rules can be added and changed. Rules are correctly associated to the chosen branch (or the general default rule). To test: - Apply the patch - Open smart-rules.pl => SUCCESS: The text and refund rules section correctly refers to default global rules. The policy can be set to Yes and No, and works as expected. - Pick a specific branch => SUCCESS: The rule refers to the specific branch => SUCCESS: It detects the default rule is picked => SUCCESS: On changing the rules values are correctly retrieved if entering again to the page. => SUCCESS: The 'Use default' text is suffixed with the correct value set by the user in the 'All libraries' scenario. => Sign off :-D Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:47:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:47:53 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52839|0 |1 is obsolete| | --- Comment #87 from Jonathan Druart --- Created attachment 53021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53021&action=edit Bug 14048: [QA Followup] Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:47:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:47:46 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52838|0 |1 is obsolete| | --- Comment #86 from Jonathan Druart --- Created attachment 53020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53020&action=edit Bug 14048: Hook new rules into C4::Circulation This patch makes AddIssue and AddReturn use the new implementation The behaviour should respect the specification. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:47:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:47:59 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52840|0 |1 is obsolete| | --- Comment #88 from Jonathan Druart --- Created attachment 53022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53022&action=edit Bug 14048: Add syspref and atomic update This patch introduces the changes to the sysprefs and the atomic update that creates the new table. It picks the syspref value for RefundLostItemFeeOnReturn and uses it to create a default (branchcode='*') rule on the new table. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:48:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:48:05 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52841|0 |1 is obsolete| | --- Comment #89 from Jonathan Druart --- Created attachment 53023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53023&action=edit Bug 14048 [QA Followup] - Delete only the removed system preference Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:48:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:48:11 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52842|0 |1 is obsolete| | --- Comment #90 from Jonathan Druart --- Created attachment 53024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53024&action=edit Bug 14048: (QA followup) Update syspref name for HEA Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:48:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:48:19 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52843|0 |1 is obsolete| | --- Comment #91 from Jonathan Druart --- Created attachment 53025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53025&action=edit Bug 14048: (QA followup) Fix typo on syspref value Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:48:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:48:25 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52844|0 |1 is obsolete| | --- Comment #92 from Jonathan Druart --- Created attachment 53026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53026&action=edit Bug 14048: (followup) Use the original holding branch This patch picks the item's holding branch *before* it gets fixed by using the checkin library instead. This way the RefundLostOnReturnControl syspref set to ItemHoldingBranch is respected (otherwise, as Nick explained this behaves just like if CheckinLibrary was set) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jason Robb Signed-off-by: Jennifer Schmidt Signed-off-by: Margaret Thrasher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:48:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:48:32 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52876|0 |1 is obsolete| | --- Comment #93 from Jonathan Druart --- Created attachment 53027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53027&action=edit Bug 14048: (QA folloup) C4::Context->preference should be used Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:48:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:48:39 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52883|0 |1 is obsolete| | --- Comment #94 from Jonathan Druart --- Created attachment 53028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53028&action=edit Bug 14048: Use mock_preference in tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:48:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:48:46 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52894|0 |1 is obsolete| | --- Comment #95 from Jonathan Druart --- Created attachment 53029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53029&action=edit Bug 14048: (QA followup) Default to 1 if no default rule This patch answers Jonathan's request to simplify this patchset a bit. It removes the need for the .sql file, as _default_rule now defaults to a fixed value (1, which was set by the removed .sql file). This allowed to remove the overloaded ->delete method. The tests have been adjusted to reflect this changes, including tests for the new 'default'-if-absent situation. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:49:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:49:43 +0000 Subject: [Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807 --- Comment #7 from Colin Campbell --- (In reply to Marcel de Rooy from comment #6) > (In reply to Kyle M Hall from comment #5) > > Passing QA provisionally, we should deal with the interaction with bug 13807 > > before anything is pushed. > 13807->15006 > I rebased 15006 on top of this one. So it can go first.. I'm trying to add to 15006 a solution to the log in bug I identified, I'll generated that on top of this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:51:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:51:46 +0000 Subject: [Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Does the issue exist on master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 16:55:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 14:55:19 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #51 from Marcel de Rooy --- (In reply to Colin Campbell from comment #49) > Comment on attachment 53013 [details] [review] > Bug 15006: Add timeout and strikes to raw_transport > > This is unnecessary - The bogus 3 strikes was already removed in commit > 078ce11e113b172726f9ab3180e52a06334d4aab > > > Test plan is ambiguous this routine is not called when using "telnet" > authentication. On a raw connection session is started when a sip login is > received. If that login fails, the session is terminated. (The login is from > the client machine's config so it wont try again with different values) and > sends a failed login response before shutting down. If the input is not a > login message or a random string it does not respond or login the session > but falls through to sip_protocol_loop and times out on the time out set > there. I think this should be considered a bug. Its probably the reason why > adding a timeout to that had an effect on building up sip sessions as that > is meant to be an endless (until logout or connection drop) loop - I think > this a bug and that if a connection is not established raw_transport should > exit without entering sip_loop >From testing i recall seeing that raw_transport does respond to requests; one of the reasons that I made it more restrict in a previous patch (relaxed it later again for minimal behavior changes). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 17:09:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 15:09:40 +0000 Subject: [Koha-bugs] [Bug 16836] Document unused parameters of SearchAuthorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #2 from H?ctor Eduardo Castro Avalos --- If you query $ git grep 'SearchAuthorities' There are some lines that use the two parameters, maybe exist more: authorities/auth_finder.pl: SearchAuthorities( \@marclist, \@and_or, \@excluding, \@operator, \@value, authorities/authorities-home.pl: #my ( $results, $total ) = SearchAuthorities( authorities/ysearch.pl: my ( $results, $total ) = SearchAuthorities( \@marclist, \@and_or, \@excluding, \@operator, \@value, $startfrom * $resultsperpage, $resultsperpage, $authtypecode, $orderby ); cataloguing/value_builder/unimarc_field_210c.pl:###TODO To rewrite in order to use SearchAuthorities cataloguing/value_builder/unimarc_field_210c.pl: my ($results,$total) = SearchAuthorities( \@tags,\@and_or, cataloguing/value_builder/unimarc_field_225a.pl: my ($results,$total) = SearchAuthorities( \@tags,\@and_or, Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 17:10:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 15:10:24 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Jonathan Druart --- (In reply to Jonathan Druart from comment #28) > This cannot be signed off, the patchset does not work at all, there is no > limitation! Still valid... Nick, could you confirm that these patches have been tested correctly? They do not work for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 17:17:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 15:17:32 +0000 Subject: [Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52929|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 53030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53030&action=edit [SIGNED-OFF]Bug 16819: Unit tests for C4::Members::DelMember The C4::Members::DelMember function actually deletes reserves, and it is not properly tested. To test: - Apply the patch - Run: $ prove t/db_dependent/Members.t => SUCCESS: Tests pass - Sign off Sponsored-by: NEKLS Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 17:17:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 15:17:43 +0000 Subject: [Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52930|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 53031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53031&action=edit [SIGNED-OFF]Bug 16819: C4::Members::DelMember should use Koha::Holds to delete holds This patch makes C4::Members::DelMember proprely use Koha::Holds to delete holds. This is important as holds actions are started to be logged. To reproduce: - Apply the patch - Run: $ prove t/db_dependent/Members.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: NEKLS Signed-off-by: Hector Castro All tests pass successfully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 17:17:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 15:17:56 +0000 Subject: [Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 17:21:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 15:21:17 +0000 Subject: [Koha-bugs] [Bug 16838] New: Elasticsearch - mapping tables are not populated on new installs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16838 Bug ID: 16838 Summary: Elasticsearch - mapping tables are not populated on new installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 12478 The yaml file is not used to populate ES mapping tables (search_field, search_marc_map and search_marc_to_field) when doing a fresh install. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 17:21:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 15:21:17 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16838 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16838 [Bug 16838] Elasticsearch - mapping tables are not populated on new installs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 17:26:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 15:26:18 +0000 Subject: [Koha-bugs] [Bug 16813] OPACBaseURL cannot be emptied In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16813 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52889|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 53032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53032&action=edit [SIGNED-OFF]Bug 16813: Allow empty string for OPACBaseURL The pref is prefixed by 'http://', but it should not when the pref is set to an empty string. This will fix the bug raised on bug 14790 comment 14. Test plan: Empty OPACBaseURL and confirm that it's save as it in DB Signed-off-by: Hector Castro OPACBaseURL is saved up empty. Prefix http:// is not saved anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 17:26:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 15:26:30 +0000 Subject: [Koha-bugs] [Bug 16813] OPACBaseURL cannot be emptied In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16813 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 17:29:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 15:29:16 +0000 Subject: [Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- I think that the goal of this table (on the acq home page) was to display a simplified version of the table on the "all funds" view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 17:41:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 15:41:11 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 17:41:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 15:41:13 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 --- Comment #32 from Nick Clemens --- Created attachment 53033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53033&action=edit Bug 15128 - (QA Followup) Fix use of 'my' variable causing loss of data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 17:41:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 15:41:18 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 --- Comment #33 from Nick Clemens --- Created attachment 53034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53034&action=edit Bug 15128 - (QA Followup) Don't get patrons suggestions if limit not set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 17:58:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 15:58:18 +0000 Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52947|0 |1 is obsolete| | --- Comment #3 from Lari Taskula --- Created attachment 53035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53035&action=edit Bug 16825: Add API route for getting an item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 18:02:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 16:02:05 +0000 Subject: [Koha-bugs] [Bug 16839] New: Sort Title (A-Z) doesn't work with some non-latin alphabets Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16839 Bug ID: 16839 Summary: Sort Title (A-Z) doesn't work with some non-latin alphabets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 53036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53036&action=edit View of ordered results under ICU Using ICU or not the sorting of a list of results in opac/staff client is ineffective for character sets such as cyrillic Without ICU the sorting seems to be by length -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 18:03:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 16:03:24 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 18:03:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 16:03:28 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52719|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart --- Created attachment 53037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53037&action=edit Bug 15128 - Add ability to limit patrons open purchase suggestions To test: 1 - Define a number of MaxOpenSuggestions 2 - Add some suggestions for a patron 3 - Note they cannot add any more suggestions if limit is reached 4 - Delete a suggestion and note you can add another 5 - Add them to limit again 6 - Accept a suggestion in the staff client and note user can add more 7 - Repeat above with rejecting or deleting 8 - Sign off. Sponsored by: North Central Regional Library (http://ncrl.org/) Signed-off-by: Barbara Walters Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 18:03:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 16:03:33 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52720|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart --- Created attachment 53038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53038&action=edit Bug 15128 [QA Followup] - Make suggestion display after being added Also fixes the issue that the add suggestion link would sometimes show even if the patron could not make an additional suggestion. Signed-off-by: Barbara Walters Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 18:03:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 16:03:48 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52721|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart --- Created attachment 53039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53039&action=edit Bug 15128 [QA Followup 2] - Only count pending suggestions for the limit Signed-off-by: Barbara Walters Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 18:04:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 16:04:00 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52722|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart --- Created attachment 53040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53040&action=edit Bug 15128 - Followup Only check limit for signed in borrower Show all suggestions after a new one is added Signed-off-by: Barbara Walters Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 18:04:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 16:04:04 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 --- Comment #38 from Jonathan Druart --- Created attachment 53041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53041&action=edit Bug 15128 (QA Followup) Display all purchase suggestions whether or not suggestion was added Correct enforcement of 0 limit Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 18:04:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 16:04:10 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53033|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart --- Created attachment 53042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53042&action=edit Bug 15128 - (QA Followup) Fix use of 'my' variable causing loss of data Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 18:04:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 16:04:15 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53034|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart --- Created attachment 53043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53043&action=edit Bug 15128 - (QA Followup) Don't get patrons suggestions if limit not set Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 18:04:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 16:04:20 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 --- Comment #41 from Jonathan Druart --- Created attachment 53044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53044&action=edit Bug 15128: Revert Display all purchase suggestions whether or not suggestion was added This does not work correctly and should be handle on another bug report. The behavior existed prior to this patchset. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 18:04:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 16:04:24 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 --- Comment #42 from Jonathan Druart --- Created attachment 53045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53045&action=edit Bug 15128: Do not display "New suggestion" if limit has just been reached If limit is X and patrons has X-1 pending suggestions, when a new one is added, the "New suggestion" should not been added. to avoid another call to SearchSuggestions, we assume than the suggestion has been correctly added. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 18:11:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 16:11:00 +0000 Subject: [Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819 --- Comment #5 from Jonathan Druart --- Comment on attachment 53031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53031 [SIGNED-OFF]Bug 16819: C4::Members::DelMember should use Koha::Holds to delete holds Review of attachment 53031: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16819&attachment=53031) ----------------------------------------------------------------- ::: C4/Members.pm @@ +1662,5 @@ > #warn "in delmember with $borrowernumber"; > return unless $borrowernumber; # borrowernumber is mandatory. > + # Delete Patron's holds > + my @holds = Koha::Holds->search({ borrowernumber => $borrowernumber }); > + map { $_->delete } @holds; I'd have written that `$_->delete for @holds`. Since map is supposed to return something I guess it can perturb a new developer. Do you agree? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 19:31:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 17:31:57 +0000 Subject: [Koha-bugs] [Bug 16836] Document unused parameters of SearchAuthorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836 --- Comment #3 from Marcel de Rooy --- (In reply to H?ctor Eduardo Castro Avalos from comment #2) > If you query $ git grep 'SearchAuthorities' > > > There are some lines that use the two parameters, maybe exist more: > > > authorities/auth_finder.pl: SearchAuthorities( \@marclist, \@and_or, > \@excluding, \@operator, \@value, > authorities/authorities-home.pl: #my ( $results, $total ) = > SearchAuthorities( > authorities/ysearch.pl: my ( $results, $total ) = SearchAuthorities( > \@marclist, \@and_or, \@excluding, \@operator, \@value, $startfrom * > $resultsperpage, $resultsperpage, $authtypecode, $orderby ); > cataloguing/value_builder/unimarc_field_210c.pl:###TODO To rewrite in order > to use SearchAuthorities > cataloguing/value_builder/unimarc_field_210c.pl: my ($results,$total) > = SearchAuthorities( \@tags,\@and_or, > cataloguing/value_builder/unimarc_field_225a.pl: my ($results,$total) = > SearchAuthorities( \@tags,\@and_or, > > Regards Hello Hector, That is true. The parameters are passed to the routine, but they actually do nothing. This patch makes that fact more visible without having to change all calls of the routine. Note that this allows someone to adjust the routine to do something useful with these parameters. Marcel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 20:08:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 18:08:21 +0000 Subject: [Koha-bugs] [Bug 16838] Elasticsearch - mapping tables are not populated on new installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16838 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 20:42:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 18:42:46 +0000 Subject: [Koha-bugs] [Bug 16840] New: URLs for old releases are broken with every new release Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16840 Bug ID: 16840 Summary: URLs for old releases are broken with every new release Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Project website Assignee: wizzyrea at gmail.com Reporter: jsn.sherman at gmail.com I'm working up a nice CentOS 7 ansible role that builds Koha from the tarball release. The way you shuffle tarball upon release makes automating koha builds more difficult than it has to be, and is user hostile. When you move tarballs under old releases, you don't offer a redirect to the new location, instead you return a 404. When you publish content to the web, you should treat that URL as valid for as long as you have the associated content. In this case, you still have the content, and you know exactly where it is. Ideally, you would offer clients a 301 redirect to the new location. You should only return a 404 when you deleted content or honestly have no idea what the client is asking for. This is a general website stewardship issue, and it may not seem like the most critical thing when you are trying to get a release out the door, so I would be happy to contribute my expertise and/or time to improve this aspect of release management for Koha. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 21:39:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 19:39:56 +0000 Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 21:39:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 19:39:58 +0000 Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030 --- Comment #3 from Nick Clemens --- Created attachment 53046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53046&action=edit Bug 8030 - Change pickup location of a hold from patron record To test: 1 - Place some holds for a patron 2 - Load the patron into checkout module 3 - View thier holds tab, should have a dropdwon for location 4 - Alter the location 5 - You should recieve a confirmation box 6 - Confirm that pressing cancel does not update holds 7 - Confirm that pressing Yes does update the hold 8 - Confirm that waiting holds are not updateable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 21:45:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 19:45:47 +0000 Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #4 from Nick Clemens --- needs to adjust for in transit holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 22:19:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 20:19:53 +0000 Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 1 22:19:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jul 2016 20:19:55 +0000 Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53046|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 53047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53047&action=edit Bug 8030 - Change pickup location of a hold from patron record To test: 1 - Place some holds for a patron 2 - Load the patron into checkout module 3 - View thier holds tab, should have a dropdwon for location 4 - Alter the location 5 - You should recieve a confirmation box 6 - Confirm that pressing cancel does not update holds 7 - Confirm that pressing Yes does update the hold 8 - Confirm that waiting holds are not updateable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 2 08:12:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jul 2016 06:12:39 +0000 Subject: [Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 2 08:12:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jul 2016 06:12:54 +0000 Subject: [Koha-bugs] [Bug 16818] CAS redirect broken under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 2 08:16:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jul 2016 06:16:01 +0000 Subject: [Koha-bugs] [Bug 16583] Strangeness in the staff client on ubuntu 16.04 and MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 2 14:44:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jul 2016 12:44:22 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #26 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > I would like to get another signoff on this one please. (In reply to Katrin Fischer from comment #8) > See comment #3 - I agree as there is some discussion here, another sign-off > would be good. (In reply to Jonathan Druart from comment #15) > Still waiting for another signoff. And... still waiting... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 2 14:54:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jul 2016 12:54:14 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #21 from Jonathan Druart --- CONFLICT (content): Merge conflict in C4/Circulation.pm Please rebase. Could you answer to comment 7? Did you take the remarks into account? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 2 15:20:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jul 2016 13:20:37 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #13 from Jonathan Druart --- Should not we adjust the description of ExpireReservesMaxPickUpDelayCharge? It says "ExpireReservesMaxPickUpDelay is enabled, and this field has a non-zero value, than a borrower whose waiting hold has expired will be charged this amount". But actually this pref is used even if ExpireReservesMaxPickUpDelay is off. Or maybe should we use rename one of these 2 prefs? It seems odd to use the same suffix but they are not so related. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 2 15:31:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jul 2016 13:31:46 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #52 from Jonathan Druart --- (In reply to Nick Clemens from comment #51) > Created attachment 52937 [details] [review] > Bug 3534 (QA Followup) Rebase and change floating save Why do you use another id for the toolbar? You won't need to add this specific JS code if you just use "toolbar" as the id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 2 15:34:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jul 2016 13:34:48 +0000 Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #26 from Jonathan Druart --- (In reply to Jonathan Druart from comment #13) > I am wondering if this behavior is not too arbitrary: Why date of birth and > not another date field? I'd like to get another QA opinion for this point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 13:25:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 11:25:19 +0000 Subject: [Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53003|0 |1 is obsolete| | --- Comment #11 from Marc V?ron --- Created attachment 53048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53048&action=edit Bug 16794: Revise layout for Admistration > Patron categories Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links To test - Go to Administration -> Patron categories - Confirm that two button appear instead of links for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. Patch fix it according with QA comment 3 Fix copy and paste according with QA comment 6 Fix column "Default privacy" to be sorted again according with comment 8 Patch set squashed Buttons appear now as requested in comment #3 (2 buttons, no action menu) Re-tested, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 13:25:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 11:25:37 +0000 Subject: [Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 13:51:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 11:51:12 +0000 Subject: [Koha-bugs] [Bug 16687] Translatability: Fix issues in Administration preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16687 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Marc V?ron --- I re-tested. The issues in the screenshots are related to wrong or missing French translations in http://translate.koha-community.org/fr/16.05/fr-FR-pref.po In English the changes look fine. Switching back to 'Needs Signoff' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 14:01:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 12:01:41 +0000 Subject: [Koha-bugs] [Bug 16803] Add Font Awesome Icons to "Select/Clear all" links to shelves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16803 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52744|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 53049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53049&action=edit Bug 16803: Add Font Awesome Icons to "Select/Clear all" links to shelves.tt Add Font Awesome Icons to "Select/Clear all" links to shelves.tt (Public and private lists) To test: -Apply patch -Go to More -> Lists -Create some Public and Private Lists -See the contents of the list and notice about the new icons in "Select/Clear all" Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 14:02:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 12:02:05 +0000 Subject: [Koha-bugs] [Bug 16803] Add Font Awesome Icons to "Select/Clear all" links to shelves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16803 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 14:19:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 12:19:09 +0000 Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52898|0 |1 is obsolete| | --- Comment #12 from Marc V?ron --- Created attachment 53050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53050&action=edit Bug 16686 - Fix "Item in transit from since" in Holds tab "From branch" and date do not show up in patron's "Holds" tab: "Item in transit from since" OPAC log: opac-user.pl: No method frombranch! at /usr/share/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line 607 Test Plan: 1) Apply this patch 2) Create an in transit hold 3) Not the from library is displayed Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 14:19:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 12:19:50 +0000 Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 15:03:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 13:03:18 +0000 Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52657|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 53051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53051&action=edit Bug 13796: OPAC: Display rental charge for renewing This patch displays the rental fee that will be applied for renewing (near "Renew" link on patron's summary page) To test: - Apply patch - Verify that you have item types with and without rental fee for testing - Issue items with an without rental fee to a patron - In OPAC, display patron's summary page - Verify in table 'Checked out', items with rental charge display an information as appropriate (near the link 'Renew') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 15:08:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 13:08:20 +0000 Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796 --- Comment #7 from Marc V?ron --- (In reply to Sally Healey from comment #5) > Hi Marc, > > The language revision of: NOTE: A charge of 5.00 for Books will be added - > sounds good. > > I've just tested again using the sandbox at: > http://sandbox1.ptfs-europe.co.uk/ with the MARC21 database. > > I'm using a DVD with an item type of "DVD Film" and a collection code of > "Film media" - but it returns 'fee for Books', rather than 'fee for DVD > Film' as I would expect: > > Black snake moan [dvd] 02/07/2016 39999000016611 Renew Fee for Books 1.00 > (5 of 5 renewals remaining) > > I'm not sure what's causing the discrepancy; when you test with an item > other than a book, does it return the correct item type? > > Thanks for your work on this - it'd be great to get this into Koha. Hi Sally, thanks for testing. I did some changes. Can you please test again? On my site, Item types like Books, Hardware, Music appear as expected: Renew Fee for Books 5.01 (8 of 10 renewals remaining) Renew Fee for Hardware 1.25 (9 of 10 renewals remaining) Renew Fee for Music 5.00 (10 of 10 renewals remaining) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 15:10:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 13:10:31 +0000 Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53051|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 53052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53052&action=edit Bug 13796: OPAC: Display rental charge for renewing This patch displays the rental fee that will be applied for renewing (near "Renew" link on patron's summary page) To test: - Apply patch - Verify that you have item types with and without rental fee for testing - Issue items with an without rental fee to a patron - In OPAC, display patron's summary page - Verify in table 'Checked out', items with rental charge display an information as appropriate (near the link 'Renew') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 16:34:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 14:34:07 +0000 Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686 --- Comment #13 from Jonathan Druart --- Created attachment 53053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53053&action=edit [ALT] Bug 16686: Fix "Item in transit from since" in Holds tab POC, tests needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 16:35:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 14:35:59 +0000 Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #14 from Jonathan Druart --- Kyle, could you have a look at this counter-patch? It seems easier to use the DBIC relationship than to create 3 new methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 16:50:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 14:50:04 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #114 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #113) > I have a proposal to un-sink this bug. Can we provide a fix_action_logs.pl > maintenance script with a --itemtypes option switch (that could be extended > in the future) to do the action_logs update, and have the updatadatabase.pl > script JUST ALERT the user about the situation? > > Jonathan: would that mitigate your concerns? Which concerns? I just asked someone to test the update DB entry on a "real" DB. I was ready to pass QA on this one actually... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 16:59:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 14:59:38 +0000 Subject: [Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 16:59:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 14:59:50 +0000 Subject: [Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53030|0 |1 is obsolete| | Attachment #53031|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 53054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53054&action=edit Bug 16819: Unit tests for C4::Members::DelMember The C4::Members::DelMember function actually deletes reserves, and it is not properly tested. To test: - Apply the patch - Run: $ prove t/db_dependent/Members.t => SUCCESS: Tests pass - Sign off Sponsored-by: NEKLS Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 17:00:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 15:00:00 +0000 Subject: [Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819 --- Comment #7 from Jonathan Druart --- Created attachment 53055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53055&action=edit Bug 16819: C4::Members::DelMember should use Koha::Holds to delete holds This patch makes C4::Members::DelMember proprely use Koha::Holds to delete holds. This is important as holds actions are started to be logged. To reproduce: - Apply the patch - Run: $ prove t/db_dependent/Members.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: NEKLS Signed-off-by: Hector Castro All tests pass successfully Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 17:00:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 15:00:10 +0000 Subject: [Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819 --- Comment #8 from Jonathan Druart --- Created attachment 53056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53056&action=edit Bug 16819: Remove use of map Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 17:01:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 15:01:08 +0000 Subject: [Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > Created attachment 53056 [details] [review] > Bug 16819: Remove use of map > > Signed-off-by: Jonathan Druart Tomas or RM: feel free to obsolete this patch if you want to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 17:03:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 15:03:30 +0000 Subject: [Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart --- The 2 buttons should be grouped into the same column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 17:05:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 15:05:05 +0000 Subject: [Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Jonathan Druart --- (In reply to Jonathan Druart from comment #12) > The 2 buttons should be grouped into the same column. Nevermind, I will provide a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 17:08:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 15:08:26 +0000 Subject: [Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 17:08:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 15:08:39 +0000 Subject: [Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53048|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 53057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53057&action=edit Bug 16794: Revise layout for Admistration > Patron categories Add Bootstrap buttons and Font Awesome Icons to "Delete" and "Edit" links To test - Go to Administration -> Patron categories - Confirm that two button appear instead of links for "Edit" and "Delete" - Edit an existing category and confirm that works as expected - Delete a category and confirm that works properly. Patch fix it according with QA comment 3 Fix copy and paste according with QA comment 6 Fix column "Default privacy" to be sorted again according with comment 8 Patch set squashed Buttons appear now as requested in comment #3 (2 buttons, no action menu) Re-tested, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 17:08:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 15:08:54 +0000 Subject: [Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 --- Comment #15 from Jonathan Druart --- Created attachment 53058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53058&action=edit Bug 16794: Group the 2 action buttons into the same column Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 17:11:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 15:11:18 +0000 Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for caching koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #21 from Jonathan Druart --- Could someone take a look at these patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 17:51:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 15:51:30 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jcamins at cpbibliography.com |gmcharlt at gmail.com CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart --- (In reply to Dobrica Pavlinusic from comment #7) > Correct way to fix this is to issue redirect under plack in download_backup > to some plack handled URL so we don't read whole file in memory. The solution seems to be here, but I don't understand what Dobrica meant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 17:51:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 15:51:43 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 17:51:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 15:51:52 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 3 19:33:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 17:33:25 +0000 Subject: [Koha-bugs] [Bug 16086] Add Koha::Issue objects. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- Hm, good point. But renaming now would be best on a separate bug report! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 01:33:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 23:33:59 +0000 Subject: [Koha-bugs] [Bug 16531] Circ overdues report is showing an empty table if no overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51769|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia --- Created attachment 53059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53059&action=edit Bug 16531: Circ overdue report is showing an empty table if no overdues EDIT: Comment 2 EDIT2: using noreport variable (Comment 5) To test: 1) Ensure you have no items overdue 2) Go to Circ -> Circulation reports -> Overdues 3) Notice empty table, '0 items overdue' heading 4) Ensure syspref FilterBeforeOverdueReport is set to 'Don't require' 5) Apply patch and refresh page 6) Notice empty table is no longer showing and page says "There are no overdues" 7) Apply a filter to search 8) Page now says "There are no overdues matching your search" with a link to reset filter. 9) Click Reset filter -> confirm any filters you applied are cleared. 10) Set FilterBeforeOverdueReport to 'Require' and refresh overdue report 11) Page should say "Please choose one or more filters to proceed" 12) Check out an item to a member, ensure due date is a date that has passed (i.e. yesterday) 13) Refresh overdue report page 14) Page should still say "Please choose one or more filters to proceed" 15) Set FilterBeforeOverdueReport to 'Don't require' 16) Confirm table now shows correctly with '1 items overdue' heading etc. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 01:33:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 23:33:55 +0000 Subject: [Koha-bugs] [Bug 16531] Circ overdues report is showing an empty table if no overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 01:48:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 23:48:27 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 53060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53060&action=edit Bug 16829: Add 'interface' column to action_logs This patch introduces a new column for the action_logs table. It is called 'interface' and it is intended to store the interface in which the action was performed. Sponsored-by: NEKLS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 01:48:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 23:48:30 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 53061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53061&action=edit Bug 16829: make logaction and GetLogs aware of the interface column This patch changes the logaction API so it accepts a new 'interface' param. Current code calling logaction is not changed, and this parameter can be ommited in most contexts, and it will correctly fall-back to C4::Context->interface. Unit tests are provided on a different patch. GetLogs gets patched as well, so it can be required to filter by 'interface' param. Sponsored-by: NEKLS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 01:48:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 23:48:34 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 53062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53062&action=edit Bug 16829: Add 'interface' to the log viewer This patch introduces the 'interface' filter to the log viewer. To test: - Apply the patch - Open the log viewer => SUCCESS: As default, 'All' interfaces are chosen. OPAC, Intranet and SIP are presented - Do a lot of log searches, verify that the interface column shows what is expected. => SUCCESS: The chosen 'interfaces' are kept when rendering results. Sponsored-by: NEKLS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 01:48:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 23:48:36 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 53063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53063&action=edit Bug 16829: DBIx update Sponsored-by: NEKLS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 01:48:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 23:48:39 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 53064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53064&action=edit Bug 16829: Unit tests for logaction's 'interface parameter' This patch introduces tests for the new 'interface' parameter for the C4::Log::logaction and C4::Log::GetLogs functions. In logaction, it falls back to C4::Context->interface if ommited. To test: - Run $ prove t/db_dependent/Log.t => SUCCESS: Tests pass - Sign off Sponsored-by: NEKLS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 01:49:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 23:49:10 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomascohen at gmail.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 01:51:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 23:51:26 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 01:51:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 23:51:30 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50046|0 |1 is obsolete| | --- Comment #16 from Aleisha Amohia --- Created attachment 53065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53065&action=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Click 'Import' into your new authority type (so you don't overwrite any important existing authority types) 7) Select the file you just exported and click 'Import' 8) Confirm you are taken to auth_tag_structure.pl 9) Go back to Authority types 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Go to Admin -> MARC bibliographic framework 12) Confirm that the 'Export' and 'Import' functions still work here as well https://bugs.koha-community.org/show_bug.cgi?id=13592 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 01:52:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 23:52:54 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53065|0 |1 is obsolete| | --- Comment #17 from Aleisha Amohia --- Created attachment 53066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53066&action=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Click 'Import' into your new authority type (so you don't overwrite any important existing authority types) 7) Select the file you just exported and click 'Import' 8) Confirm you are taken to auth_tag_structure.pl 9) Go back to Authority types 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Go to Admin -> MARC bibliographic framework 12) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 01:54:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jul 2016 23:54:10 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #18 from Aleisha Amohia --- Can you please test this again? The import seems to work fine for me because we have put in checks for if it is an authority or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:14:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:14:41 +0000 Subject: [Koha-bugs] [Bug 7862] Entries in error log when creating a new notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7862 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #1 from Aleisha Amohia --- I don't believe this is still valid. Can you check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:25:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:25:07 +0000 Subject: [Koha-bugs] [Bug 16841] New: Help for Library EANs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16841 Bug ID: 16841 Summary: Help for Library EANs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There is currently no help file for library EANs (admin/edi_ean_accounts.pl) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:26:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:26:33 +0000 Subject: [Koha-bugs] [Bug 16841] Help for Library EANs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16841 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:26:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:26:36 +0000 Subject: [Koha-bugs] [Bug 16841] Help for Library EANs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16841 --- Comment #1 from Aleisha Amohia --- Created attachment 53067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53067&action=edit Bug 16841: Help for library EANs To test: 1) Go to Admin -> Library EANs 2) Click Help in top-right corner 3) Confirm that Help window opens with appropriate help text 4) Confirm link to manual works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:26:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:26:47 +0000 Subject: [Koha-bugs] [Bug 16841] Help for Library EANs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16841 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:36:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:36:10 +0000 Subject: [Koha-bugs] [Bug 16842] New: Help for EDI accounts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16842 Bug ID: 16842 Summary: Help for EDI accounts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There is currently no help file for EDI accounts (admin/edi_accounts.pl) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:37:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:37:49 +0000 Subject: [Koha-bugs] [Bug 16842] Help for EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16842 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:37:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:37:52 +0000 Subject: [Koha-bugs] [Bug 16842] Help for EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16842 --- Comment #1 from Aleisha Amohia --- Created attachment 53068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53068&action=edit Bug 16842: Help for EDI accounts To test: 1) Go to Admin -> EDI accounts 2) Click Help in top-right corner 3) Confirm that Help window opens with appropriate help text 4) Confirm links work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:38:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:38:02 +0000 Subject: [Koha-bugs] [Bug 16842] Help for EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16842 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:41:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:41:59 +0000 Subject: [Koha-bugs] [Bug 16843] New: Help for EDIFACT messages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16843 Bug ID: 16843 Summary: Help for EDIFACT messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org There is currently no help file for EDIFACT messages (acqui/edifactmsgs.pl) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:43:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:43:10 +0000 Subject: [Koha-bugs] [Bug 16843] Help for EDIFACT messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16843 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:43:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:43:13 +0000 Subject: [Koha-bugs] [Bug 16843] Help for EDIFACT messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16843 --- Comment #1 from Aleisha Amohia --- Created attachment 53069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53069&action=edit Bug 16843: Help for EDIFACT messages To test: 1) Go to Acqui -> EDIFACT messages 2) Click Help in top-right corner 3) Confirm that Help window opens with appropriate help text 4) Confirm link to manual works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:43:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:43:47 +0000 Subject: [Koha-bugs] [Bug 16843] Help for EDIFACT messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16843 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:53:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:53:39 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16819 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16819 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819 [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:53:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:53:39 +0000 Subject: [Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14642 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14642 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 [Bug 14642] Add logging of hold modifications -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 03:56:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 01:56:36 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 --- Comment #12 from Tom?s Cohen Arazi --- (In reply to Colin Campbell from comment #9) > One thing that would be useful is to log if its an opac hold or staff > generated hold. In the UK public libraries standard reporting includes a > requirement to report number of holds placed via opac Colin, please take a look at bug 16829. And sign it :-D One thing I'd add (on another bugs, will try to get funding for it) is that SCO should be a separate interface from OPAC, and also we should make cli scripts explicitly set 'commandline' if they still don't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 04:08:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 02:08:45 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52848|0 |1 is obsolete| | Attachment #52931|0 |1 is obsolete| | --- Comment #13 from Tom?s Cohen Arazi --- Created attachment 53070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53070&action=edit Bug 14642: Add logging for Holds This patch adds logging for several holds actions. Specifically for: - CREATE - CANCEL - DELETE - RESUME - SUSPEND To test: - Enable the HoldsLog syspref - Add a hold on a record/item => SUCCESS: The log view shows the CREATE action - Click on the button => SUCCESS: The log view shows the SUSPEND action - Click on the button => SUCCESS: The log view shows the RESUME action - Click on the red cross, to delete the hold => SUCCESS: The log view shows the CANCEL action Note: The DELETE action is logged when DelMember is called, with bug 16819 patches applied. Sponsored-by: NEKLS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 04:09:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 02:09:58 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 04:21:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 02:21:54 +0000 Subject: [Koha-bugs] [Bug 15419] Sipserver problem with stale db handles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |srdjan at catalyst.net.nz |ity.org | CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 04:49:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 02:49:21 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 [Bug 16829] action_logs should have an 'interface' column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 04:49:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 02:49:21 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14642 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 [Bug 14642] Add logging of hold modifications -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 07:16:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 05:16:54 +0000 Subject: [Koha-bugs] [Bug 15419] Sipserver problem with stale db handles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 07:16:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 05:16:56 +0000 Subject: [Koha-bugs] [Bug 15419] Sipserver problem with stale db handles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419 --- Comment #1 from Srdjan Jankovic --- Created attachment 53071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53071&action=edit Bug 15419 SIP: call auth() subs with timeout, and refresh dbh if need be -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 07:19:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 05:19:33 +0000 Subject: [Koha-bugs] [Bug 15419] Sipserver problem with stale db handles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419 --- Comment #2 from Srdjan Jankovic --- To test: * Start SIP server * Make a request * Stop mysql daemon; start mysql daemon * Make another SIP request - it should not timeout on stale handle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 07:31:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 05:31:04 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 07:31:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 05:31:07 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53008|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia --- Created attachment 53072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53072&action=edit Bug 16530: Adding a circ sidebar navigation menu and circSidebar syspref to activate/deactivate Edit: Fast cataloging link should now show on all pages, removed offline circulation links Edit 2: Creates the syspref to activate or deactivate the sidebar This adds a sidebar to circ/branchoverdues.tt circ/circulation.tt (I also fixed up some of the indentation in this file to make it easier to see where the divs started and ended) circ/renew.tt circ/returns.tt circ/selectbranchprinter.tt circ/transferstoreceive.tt circ/view_holdsqueue.tt circ/waitingreserves.tt circ/branchtransfers.tt To test: 1) Confirm syspref circSidebar is activated 2) Go to all of the above pages and confirm the sidebar menu shows up 3) Confirm fast cataloguing link and transfer link are there 4) Trigger any error messages you can possibly think of (i.e. on renew.pl: barcode does not exist). Confirm that this does not mess up the layout of the page 5) Go to a user account page, Check out tab. (Since this is a circ/circulation.pl page). Ensure the circ nav sidebar doesn't show up (confirm it looks as it usually does) 6) Deactivate circSidebar 7) Confirm pages all look normal Sponsored-by: Catalyst IT Signed-off-by: Jan Kissig -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 07:33:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 05:33:07 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 --- Comment #12 from Aleisha Amohia --- Sorry forgot Step 1: Run updatedatabase.pl! This is ready for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 08:43:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 06:43:21 +0000 Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #27 from Martin Renvoize --- Cheers for the explaination regarding performance. I also see that the DateTime identification code is s simple regex so I'm happy on that front. Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 08:45:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 06:45:41 +0000 Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #28 from Martin Renvoize --- (In reply to Jonathan Druart from comment #26) > (In reply to Jonathan Druart from comment #13) > > I am wondering if this behavior is not too arbitrary: Why date of birth and > > not another date field? > > I'd like to get another QA opinion for this point. I must admit, I'm not sure about the usefulness of this either. The fields we search by default are somewhat arbitrary (but work reasonably well). Adding this may day a precident for adding others so I think it's depict you've asked for such justifications. Hmmm. Me ponders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 11:01:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 09:01:39 +0000 Subject: [Koha-bugs] [Bug 13324] [DEPENDS_ON_13321] The fund values must be based on tax included values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |claire.hernandez at biblibre.c |ommunity.org |om Status|Signed Off |BLOCKED --- Comment #14 from Jonathan Druart --- Blocked by bug 13321 which is failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 11:02:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 09:02:11 +0000 Subject: [Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 11:02:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 09:02:32 +0000 Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha log file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 11:15:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 09:15:23 +0000 Subject: [Koha-bugs] [Bug 16324] Move item search into header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16324 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 11:15:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 09:15:26 +0000 Subject: [Koha-bugs] [Bug 16324] Move item search into header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16324 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52313|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 53073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53073&action=edit Bug 16324: Move item search into header This patch makes the Search button in the header into a dropdown that holds the Advanced search and the Item search. I have rewritten this patch to be independent of Bug 16323 since that patch is so controversial. To test: 1) Confirm that Advanced search and Item search are both under the 'Search' dropdown menu in the header and both links work as expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart Note that the CAN_user_catalogue test is useless. If a librarian does not have it, (s)he cannot access to the staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 11:25:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 09:25:16 +0000 Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 11:25:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 09:25:19 +0000 Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52944|0 |1 is obsolete| | Attachment #52945|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 53074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53074&action=edit Bug 15172: Serial enumchron/sequence not visible when returning/checking in Items Displays the items.enumchron-column in returns.pl when checking in Items. Rewording commit To test: -Checkout a barcode for serial with items generated in Serials > New subscription or item in DB with items.enumchron-column -Checkin the same barcode, the table Checked-in items will appear without information about "Publications details (Vol. 400, No. 32)" -Apply patch -Checkout and checkin another item of the same serial title -Notice about the Vol. 400, No. 32 below the serial title. Signed-off-by: Hector Castro items.enumchron-column display successful in returns.pl (Home>Circulation> Check in) NOTE: Patch rebased on master Signed-off-by: Alain et Aur?lie Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 11:25:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 09:25:23 +0000 Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 --- Comment #17 from Jonathan Druart --- Created attachment 53075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53075&action=edit Bug 15172: (follow-up)Serial enumchron/sequence not visible when returning/checking in Items Display br and span tag only if the value enumchron exists. To test -Apply patches -Follow the previous test plan -Checkin whichever material (e.g., book) without sequence or enumchrom -Open up source code for checkin page, search under title and verify that b and span tags do not appear Signed-off-by: Alain et Aur?lie Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 11:26:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 09:26:15 +0000 Subject: [Koha-bugs] [Bug 14668] Show serial enumeration in the patron's opac checkout summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show serial enumeration in |Show serial enumeration in |the checkin page and the |the patron's opac checkout |patron's opac checkout |summary |summary | CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Serial enum is displayed on the return screen by bug 15172. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 11:36:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 09:36:12 +0000 Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.16 |unspecified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 11:38:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 09:38:58 +0000 Subject: [Koha-bugs] [Bug 16803] Add Font Awesome Icons to "Select/Clear all" links to shelves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 11:39:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 09:39:00 +0000 Subject: [Koha-bugs] [Bug 16803] Add Font Awesome Icons to "Select/Clear all" links to shelves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53049|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53076&action=edit Bug 16803: Add Font Awesome Icons to "Select/Clear all" links to shelves.tt Add Font Awesome Icons to "Select/Clear all" links to shelves.tt (Public and private lists) To test: -Apply patch -Go to More -> Lists -Create some Public and Private Lists -See the contents of the list and notice about the new icons in "Select/Clear all" Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 13:24:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 11:24:49 +0000 Subject: [Koha-bugs] [Bug 16844] New: 1 occurrence of GetMemberRelatives has not been removed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16844 Bug ID: 16844 Summary: 1 occurrence of GetMemberRelatives has not been removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 15656 Bug 15656 removed the C4::Members::GetMemberRelatives subroutine but the module still exports it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 [Bug 15656] Move the guarantor/guarantees code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 13:24:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 11:24:49 +0000 Subject: [Koha-bugs] [Bug 15656] Move the guarantor/guarantees code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16844 [Bug 16844] 1 occurrence of GetMemberRelatives has not been removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 13:27:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 11:27:07 +0000 Subject: [Koha-bugs] [Bug 16844] 1 occurrence of GetMemberRelatives has not been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 13:27:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 11:27:09 +0000 Subject: [Koha-bugs] [Bug 16844] 1 occurrence of GetMemberRelatives has not been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16844 --- Comment #1 from Jonathan Druart --- Created attachment 53077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53077&action=edit Bug 16844: (follow-up of 15656) Remove export of GetMemberRelatives from C4::Members Bug 15656 removed the C4::Members::GetMemberRelatives subroutine but the module still exports it. Test plan: git grep GetMemberRelatives should not return any results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 13:45:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 11:45:22 +0000 Subject: [Koha-bugs] [Bug 13901] sort1 and sort2 not on self registration form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13901 Michal Dudzik changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dudzikmichal at wp.pl --- Comment #3 from Michal Dudzik --- Created attachment 53078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53078&action=edit add sort1 and sort2 on self registration form Test Plan: 1) Apply this patch 2) Register new account from OPAC with values for sort1 and sort2 2) Modification values sort1 and sort2 in OPAC and update personal details patron 3) Go to staff interface and accept Patron modifications -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 14:22:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 12:22:12 +0000 Subject: [Koha-bugs] [Bug 16845] New: C4::Members::ModPrivacy is not used Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16845 Bug ID: 16845 Summary: C4::Members::ModPrivacy is not used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Authentication Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org ...and can be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 14:24:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 12:24:13 +0000 Subject: [Koha-bugs] [Bug 16845] C4::Members::ModPrivacy is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16845 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 14:24:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 12:24:16 +0000 Subject: [Koha-bugs] [Bug 16845] C4::Members::ModPrivacy is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16845 --- Comment #1 from Jonathan Druart --- Created attachment 53079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53079&action=edit Bug 16845: Remove unused C4::Members::ModPrivacy This subroutine is no longer in used and can be removed safely Test plan: git grep ModPrivacy should not return any occurrences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 15:20:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 13:20:11 +0000 Subject: [Koha-bugs] [Bug 11353] Searches with QueryParser activated are broken if an Uppercase is used in the index name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11353 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- (In reply to Owen Leonard from comment #1) > How do you reproduce this bug? Is it still valid in master? Yes, it is. Not sure if this is exactly the same problem. But it is similar at least: Activate QueryParser pref. Type search: Control-number:[your-record-number-here] This search fails. Type search: Control-number=[your-record-number-here] This works. Note that the detail page contains links from e.g. article to magazine via 773 with a record control number that use the character [:]. They do not work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 15:20:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 13:20:21 +0000 Subject: [Koha-bugs] [Bug 11353] Searches with QueryParser activated are broken if an Uppercase is used in the index name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11353 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 15:32:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 13:32:28 +0000 Subject: [Koha-bugs] [Bug 12268] Subject Broader Narrower Related terms and Query Parser and Exploded Terms issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12268 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- Seems to be still valid on current master [16.06] Hard to explain why we offer those options. What should happen with QueryParser in its current state? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 15:48:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 13:48:16 +0000 Subject: [Koha-bugs] [Bug 16842] Help for EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16842 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53068|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 53080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53080&action=edit Bug 16842: Help for EDI accounts To test: 1) Go to Admin -> EDI accounts 2) Click Help in top-right corner 3) Confirm that Help window opens with appropriate help text 4) Confirm links work as expected Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 15:49:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 13:49:19 +0000 Subject: [Koha-bugs] [Bug 16842] Help for EDI accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16842 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 15:51:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 13:51:26 +0000 Subject: [Koha-bugs] [Bug 16843] Help for EDIFACT messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16843 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53069|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 53081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53081&action=edit Bug 16843: Help for EDIFACT messages To test: 1) Go to Acqui -> EDIFACT messages 2) Click Help in top-right corner 3) Confirm that Help window opens with appropriate help text 4) Confirm link to manual works as expected Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 15:51:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 13:51:41 +0000 Subject: [Koha-bugs] [Bug 16843] Help for EDIFACT messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16843 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 15:55:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 13:55:59 +0000 Subject: [Koha-bugs] [Bug 16844] 1 occurrence of GetMemberRelatives has not been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16844 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53077|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 53082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53082&action=edit Bug 16844: (follow-up of 15656) Remove export of GetMemberRelatives from C4::Members Bug 15656 removed the C4::Members::GetMemberRelatives subroutine but the module still exports it. Test plan: git grep GetMemberRelatives should not return any results. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 15:56:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 13:56:47 +0000 Subject: [Koha-bugs] [Bug 16844] 1 occurrence of GetMemberRelatives has not been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16844 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 15:59:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 13:59:00 +0000 Subject: [Koha-bugs] [Bug 16845] C4::Members::ModPrivacy is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16845 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53079|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 53083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53083&action=edit Bug 16845: Remove unused C4::Members::ModPrivacy This subroutine is no longer in used and can be removed safely Test plan: git grep ModPrivacy should not return any occurrences. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 15:59:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 13:59:18 +0000 Subject: [Koha-bugs] [Bug 16845] C4::Members::ModPrivacy is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16845 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 16:07:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 14:07:51 +0000 Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686 --- Comment #15 from Marc V?ron --- Created attachment 53084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53084&action=edit Bug 16686: Fix "Item in transit from since" in Holds tab POC, tests needed. Alternative patch works for me. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 16:12:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 14:12:45 +0000 Subject: [Koha-bugs] [Bug 16846] New: Move patron related code to Koha::Patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Bug ID: 16846 Summary: Move patron related code to Koha::Patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 16:13:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 14:13:25 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 --- Comment #10 from Jonathan Druart --- Bug 16846 - Move patron related code to Koha::Patron (see dependent bugs). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 16:14:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 14:14:29 +0000 Subject: [Koha-bugs] [Bug 16845] C4::Members::ModPrivacy is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16845 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 16:14:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 14:14:29 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16845 --- Comment #1 from Jonathan Druart --- Bug 16845 - C4::Members::ModPrivacy is not used Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16845 [Bug 16845] C4::Members::ModPrivacy is not used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 16:14:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 14:14:58 +0000 Subject: [Koha-bugs] [Bug 16841] Help for Library EANs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16841 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53067|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 53085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53085&action=edit Bug 16841: Help for library EANs To test: 1) Go to Admin -> Library EANs 2) Click Help in top-right corner 3) Confirm that Help window opens with appropriate help text 4) Confirm link to manual works as expected Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 16:15:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 14:15:20 +0000 Subject: [Koha-bugs] [Bug 16841] Help for Library EANs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16841 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 16:18:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 14:18:08 +0000 Subject: [Koha-bugs] [Bug 16847] New: Remove C4::Members::GetTitles Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 Bug ID: 16847 Summary: Remove C4::Members::GetTitles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 16846 This subroutine just reads the content of a pref, split it, add an empty string and returns. It is not really useful and the code in the script (memberentry.pl) uses the only occurrence of CGI::popup_menu Let's remove it and build the dropdown list in the template. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 16:18:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 14:18:08 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 [Bug 16847] Remove C4::Members::GetTitles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 16:21:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 14:21:35 +0000 Subject: [Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 16:21:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 14:21:38 +0000 Subject: [Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 --- Comment #1 from Jonathan Druart --- Created attachment 53086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53086&action=edit Bug 16847: Remove C4::Members::GetTitles This subroutine just reads the content of a pref, split it, add an empty string and returns. It is not really useful and the code in the script (memberentry.pl) uses the only occurrence of CGI::popup_menu Let's remove it and build the dropdown list in the template. Test plan: 1/ Empty BorrowersTitles, edit a patron and confirm that the "Salutation" does not appear 2/ Fill BorrowersTitles with "Mr|Mrs|Miss|Ms", edit a patron and confirm that the "Salutation" dropdown list is correctly filled. The default option should be selected if you are editing a patron with a title defined. This should also be tested at the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 16:21:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 14:21:41 +0000 Subject: [Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 --- Comment #2 from Jonathan Druart --- Created attachment 53087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53087&action=edit Bug 16847: Add empty option to Salutation/title At the OPAC there is no way to empty this value. I think it should be allowed to empty it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 16:31:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 14:31:21 +0000 Subject: [Koha-bugs] [Bug 16848] New: Wrong warning "Invalid date ... passed to output_pre" can be carped Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Bug ID: 16848 Summary: Wrong warning "Invalid date ... passed to output_pre" can be carped Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org >From Koha::DateUtils::output_pref: $dt = eval { dt_from_string( $str ) } if $str; carp "Invalid date '$str' passed to output_pref\n" if $@; This second line is wrong: if $str does not exist, the first line is not evaluated and $@ could be filled with previous error. To reproduce: diff --git a/t/DateUtils.t b/t/DateUtils.t index eede4a0..2dd6a9d 100755 --- a/t/DateUtils.t +++ b/t/DateUtils.t @@ -229,3 +229,5 @@ is( $output_for_invalid_date, undef, 'output_pref should return undef if an inva warning_is { output_pref( { 'str' => $testdate_iso, dt => $dt, dateformat => 'iso', dateonly => 1 } ) } { carped => 'output_pref should not be called with both dt and str parameters' }, 'output_pref should carp if str and dt parameters are passed together'; + +output_pref(); Then: prove t/DateUtils.t will display: t/DateUtils.t .. 20/60 Use of uninitialized value $str in concatenation (.) or string at Koha/DateUtils.pm line 217. Invalid date '' passed to output_pref at t/DateUtils.t line 233. t/DateUtils.t .. ok All tests successful. Files=1, Tests=60, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.40 cusr 0.00 csys = 1.42 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 16:31:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 14:31:51 +0000 Subject: [Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrong warning "Invalid date |Wrong warning "Invalid date |... passed to output_pre" |... passed to output_pref" |can be carped |can be carped -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 16:51:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 14:51:12 +0000 Subject: [Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Hi Jonathan. After applying the patches, I get still results for git grep GetTitles: C4/Members.pm: &GetTitles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 17:52:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 15:52:32 +0000 Subject: [Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53087|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 53089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53089&action=edit Bug 16847: Add empty option to Salutation/title At the OPAC there is no way to empty this value. I think it should be allowed to empty it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 17:52:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 15:52:29 +0000 Subject: [Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53086|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 53088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53088&action=edit Bug 16847: Remove C4::Members::GetTitles This subroutine just reads the content of a pref, split it, add an empty string and returns. It is not really useful and the code in the script (memberentry.pl) uses the only occurrence of CGI::popup_menu Let's remove it and build the dropdown list in the template. Test plan: 1/ Empty BorrowersTitles, edit a patron and confirm that the "Salutation" does not appear 2/ Fill BorrowersTitles with "Mr|Mrs|Miss|Ms", edit a patron and confirm that the "Salutation" dropdown list is correctly filled. The default option should be selected if you are editing a patron with a title defined. This should also be tested at the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 17:52:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 15:52:50 +0000 Subject: [Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 --- Comment #6 from Jonathan Druart --- (In reply to Marc V?ron from comment #3) > Hi Jonathan. > > After applying the patches, I get still results for git grep GetTitles: > > C4/Members.pm: &GetTitles Fixed! Thanks for testing Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 17:54:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 15:54:10 +0000 Subject: [Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 17:54:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 15:54:13 +0000 Subject: [Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 --- Comment #1 from Jonathan Druart --- Created attachment 53090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53090&action=edit Bug 16848: Prevent invalid warning to be carped from output_pref >From Koha::DateUtils::output_pref: $dt = eval { dt_from_string( $str ) } if $str; carp "Invalid date '$str' passed to output_pref\n" if $@; This second line is wrong: if $str does not exist, the first line is not evaluated and $@ could be filled with previous error. To reproduce: Then: prove t/DateUtils.t will display: t/DateUtils.t .. 20/60 Use of uninitialized value $str in concatenation (.) or string at Koha/DateUtils.pm line 217. Invalid date '' passed to output_pref at t/DateUtils.t line 233. t/DateUtils.t .. ok All tests successful. Files=1, Tests=60, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.40 cusr 0.00 csys = 1.42 CPU) Result: PASS Test plan: Without this patch, you should not see the carp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 17:56:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 15:56:19 +0000 Subject: [Koha-bugs] [Bug 16849] New: Move IsDebarred to Koha::Patron->is_debarred Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 Bug ID: 16849 Summary: Move IsDebarred to Koha::Patron->is_debarred Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 17:56:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 15:56:19 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16849 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 17:58:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 15:58:25 +0000 Subject: [Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53088|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 53091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53091&action=edit Bug 16847: Remove C4::Members::GetTitles This subroutine just reads the content of a pref, split it, add an empty string and returns. It is not really useful and the code in the script (memberentry.pl) uses the only occurrence of CGI::popup_menu Let's remove it and build the dropdown list in the template. Test plan: 1/ Empty BorrowersTitles, edit a patron and confirm that the "Salutation" does not appear 2/ Fill BorrowersTitles with "Mr|Mrs|Miss|Ms", edit a patron and confirm that the "Salutation" dropdown list is correctly filled. The default option should be selected if you are editing a patron with a title defined. This should also be tested at the OPAC. Followed test pan, works as expected in Staff and OPAC Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 17:59:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 15:59:57 +0000 Subject: [Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53089|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 53092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53092&action=edit Bug 16847: Add empty option to Salutation/title At the OPAC there is no way to empty this value. I think it should be allowed to empty it. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 18:01:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 16:01:11 +0000 Subject: [Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 18:11:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 16:11:34 +0000 Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 18:11:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 16:11:37 +0000 Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 --- Comment #1 from Jonathan Druart --- Created attachment 53093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53093&action=edit Bug 16849: Move IsDebarred to Koha::Patron->is_debarred In order to move IsMemberBlocked to Koha::Patron it makes sense to move the code from Koha::Patron::Debarments::IsDebarred to Koha::Patron->is_debarred. Test plan: 1/ Add a restriction to a patron 2/ make sure he is not able to checkout items any more 3/ Make sure he cannot get a discharge 4/ Put a hold and make sure you get "Patron has restrictions" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 18:14:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 16:14:27 +0000 Subject: [Koha-bugs] [Bug 16850] New: Move IsMemberBlocked to Koha::Patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850 Bug ID: 16850 Summary: Move IsMemberBlocked to Koha::Patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 16849 The C4::Members::IsMemberBlocked subroutine can be replaced by a call to Koha::Patron->is_debarred and Koha::Patron->has_overdues Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 18:14:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 16:14:27 +0000 Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16850 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850 [Bug 16850] Move IsMemberBlocked to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 18:14:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 16:14:53 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 --- Comment #2 from Jonathan Druart --- Bug 16847 - Remove C4::Members::GetTitles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 18:15:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 16:15:17 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 --- Comment #3 from Jonathan Druart --- Bug 16849 - Move IsDebarred to Koha::Patron->is_debarred -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 18:15:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 16:15:40 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16850 --- Comment #4 from Jonathan Druart --- Bug 16850 - Move IsMemberBlocked to Koha::Patron Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850 [Bug 16850] Move IsMemberBlocked to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 18:15:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 16:15:40 +0000 Subject: [Koha-bugs] [Bug 16850] Move IsMemberBlocked to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 18:37:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 16:37:00 +0000 Subject: [Koha-bugs] [Bug 16851] New: Move HasOverdues to Koha::Patron->has_overdues Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Bug ID: 16851 Summary: Move HasOverdues to Koha::Patron->has_overdues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 16850 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850 [Bug 16850] Move IsMemberBlocked to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 18:37:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 16:37:00 +0000 Subject: [Koha-bugs] [Bug 16850] Move IsMemberBlocked to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 [Bug 16851] Move HasOverdues to Koha::Patron->has_overdues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 18:37:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 16:37:24 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16851 --- Comment #5 from Jonathan Druart --- Bug 16851 - Move HasOverdues to Koha::Patron->has_overdues Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 [Bug 16851] Move HasOverdues to Koha::Patron->has_overdues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 18:37:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 16:37:24 +0000 Subject: [Koha-bugs] [Bug 16851] Move HasOverdues to Koha::Patron->has_overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 18:40:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 16:40:02 +0000 Subject: [Koha-bugs] [Bug 16851] Move HasOverdues to Koha::Patron->has_overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16849 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 18:40:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 16:40:02 +0000 Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 [Bug 16851] Move HasOverdues to Koha::Patron->has_overdues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:00:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:00:50 +0000 Subject: [Koha-bugs] [Bug 16851] Move HasOverdues to Koha::Patron->has_overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:00:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:00:53 +0000 Subject: [Koha-bugs] [Bug 16851] Move HasOverdues to Koha::Patron->has_overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 --- Comment #1 from Jonathan Druart --- Created attachment 53094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53094&action=edit Bug 16851: Move HasOverdues to Koha::Patron->has_overdues This patch just move C4::Members::HasOverdues to Koha::Patron->has_overdues and updated callers Test plan: No change in behavior is expected. 1/ If a patron is debarred and does not have overdues and AutoRemoveOverduesRestrictions is on, the debarment will be removed on checkin 2/ Add overdues and make sure the patron cannot renew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:06:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:06:47 +0000 Subject: [Koha-bugs] [Bug 16850] Move IsMemberBlocked to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:06:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:06:52 +0000 Subject: [Koha-bugs] [Bug 16850] Move IsMemberBlocked to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850 --- Comment #1 from Jonathan Druart --- Created attachment 53095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53095&action=edit Bug 16850: Add test coverage for CanBookBeIssued -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:06:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:06:55 +0000 Subject: [Koha-bugs] [Bug 16850] Move IsMemberBlocked to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850 --- Comment #2 from Jonathan Druart --- Created attachment 53096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53096&action=edit Bug 16850: Remove C4::Members::IsMemberBlocked This subroutine is only called once and can be replaced with a call to is_debarred and has_overdues. Note that prior to this patch, IsMemberBlocked copy/paste code from HasOverdues, which did not make sense. Test plan: Debar a patron and make sure he is not able to checkout (the librarian is asked to overwrite if OverduesBlockCirc is set to 'confirmation') Remove the debarment and add overdues to this patron, same as previously, the checkout should be blocked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:08:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:08:05 +0000 Subject: [Koha-bugs] [Bug 16852] New: Remove C4::Members::GetBorrowerCategorycode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 Bug ID: 16852 Summary: Remove C4::Members::GetBorrowerCategorycode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:08:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:08:44 +0000 Subject: [Koha-bugs] [Bug 16853] New: Move changepassword to Koha::Patron->update_password Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853 Bug ID: 16853 Summary: Move changepassword to Koha::Patron->update_password Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:09:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:09:02 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16852 --- Comment #6 from Jonathan Druart --- Bug 16852 - Remove C4::Members::GetBorrowerCategorycode Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 [Bug 16852] Remove C4::Members::GetBorrowerCategorycode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:09:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:09:02 +0000 Subject: [Koha-bugs] [Bug 16852] Remove C4::Members::GetBorrowerCategorycode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:09:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:09:15 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16853 --- Comment #7 from Jonathan Druart --- Bug 16853 - Move changepassword to Koha::Patron->update_password Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853 [Bug 16853] Move changepassword to Koha::Patron->update_password -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:09:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:09:15 +0000 Subject: [Koha-bugs] [Bug 16853] Move changepassword to Koha::Patron->update_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:10:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:10:54 +0000 Subject: [Koha-bugs] [Bug 16852] Remove C4::Members::GetBorrowerCategorycode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15407 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:10:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:10:54 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16852 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 [Bug 16852] Remove C4::Members::GetBorrowerCategorycode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:15:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:15:09 +0000 Subject: [Koha-bugs] [Bug 16852] Remove C4::Members::GetBorrowerCategorycode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:15:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:15:12 +0000 Subject: [Koha-bugs] [Bug 16852] Remove C4::Members::GetBorrowerCategorycode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 --- Comment #1 from Jonathan Druart --- Created attachment 53097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53097&action=edit Bug 16852: Remove GetBorrowerCategorycode And use Koha::Patron->categorycode instead Test plan: - Restrict a patron attribute to a patron category - Use the batch patron modification tool to update a patron of this category You should not see the the patron attribute -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:18:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:18:55 +0000 Subject: [Koha-bugs] [Bug 16853] Move changepassword to Koha::Patron->update_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 19:18:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 17:18:58 +0000 Subject: [Koha-bugs] [Bug 16853] Move changepassword to Koha::Patron->update_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853 --- Comment #1 from Jonathan Druart --- Created attachment 53098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53098&action=edit Bug 16853: Move changepassword to Koha::Patron->update_password This patch moves the code from C4::Members::changepassword to Koha::Patron->update_password Test plan: Change your password at the OPAC and the staff interface This should work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 21:08:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 19:08:49 +0000 Subject: [Koha-bugs] [Bug 16295] marc_modification_templates permission doesn't allow access to modify template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com --- Comment #1 from bondiurbano --- Same problem after upgrading to 3.22.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 23:13:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 21:13:03 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 23:13:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 21:13:11 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #317 from Chris Cormack --- Created attachment 53099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53099&action=edit Bug 7143 : More new devs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 4 23:23:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jul 2016 21:23:52 +0000 Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for caching koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply --- Comment #22 from Chris Cormack --- Applying: Bug XXXXX_2: Add the ability to define several namespaces - tests fatal: sha1 information is lacking or useless (t/Cache.t). error: could not build fake ancestor Patch failed at 0001 Bug XXXXX_2: Add the ability to define several namespaces - tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 04:39:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 02:39:26 +0000 Subject: [Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 --- Comment #13 from Liz Rea --- Hi, Yes, that is what we're doing. When you put it that way, it seems crazy. However, crazy as it sounds, my thinking was that there might eventually be other things that we wanted to keep track of in a centralised location. I see it as the first instance of having a method of making a Koha self-documenting. A way to make sure we can know how a koha was originally installed, a way to ease troubleshooting for admins, a way to provide explicit error messages for specific types of installations. As Koha installations pass from admin to admin, knowledge is lost. When the knowledge is lost, libraries leave Koha. This desire of mine may not be enough to encourage acceptance of this patch. That's fine. I just wanted to make sure you knew where my head and heart were at when I submitted this in this way. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 04:58:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 02:58:19 +0000 Subject: [Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16690 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 04:58:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 02:58:19 +0000 Subject: [Koha-bugs] [Bug 16690] Installing DB on remote server fails without *.* permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15088 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 11:45:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 09:45:26 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #52 from Colin Campbell --- (In reply to Marcel de Rooy from comment #51) > (In reply to Colin Campbell from comment #49) > > Comment on attachment 53013 [details] [review] [review] > > Bug 15006: Add timeout and strikes to raw_transport > > > > This is unnecessary - The bogus 3 strikes was already removed in commit > > 078ce11e113b172726f9ab3180e52a06334d4aab > > > > > > Test plan is ambiguous this routine is not called when using "telnet" > > authentication. On a raw connection session is started when a sip login is > > received. If that login fails, the session is terminated. (The login is from > > the client machine's config so it wont try again with different values) and > > sends a failed login response before shutting down. If the input is not a > > login message or a random string it does not respond or login the session > > but falls through to sip_protocol_loop and times out on the time out set > > there. I think this should be considered a bug. Its probably the reason why > > adding a timeout to that had an effect on building up sip sessions as that > > is meant to be an endless (until logout or connection drop) loop - I think > > this a bug and that if a connection is not established raw_transport should > > exit without entering sip_loop > > From testing i recall seeing that raw_transport does respond to requests; > one of the reasons that I made it more restrict in a previous patch (relaxed > it later again for minimal behavior changes). Been doing some extensive testing and the raw_transport routine going some things very differently than I think we all imagine. Will post the patch when final element merged. We need the timeout to escape the while if anyone can engineer us into an infinite loop there (I've not been able to do that ...but..) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 13:11:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 11:11:18 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #9 from sandboxes at biblibre.com --- Patch tested with a sandbox, by sonia BOUIS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 13:11:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 11:11:34 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52949|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 13:11:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 11:11:39 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52950|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 13:11:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 11:11:48 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #10 from sandboxes at biblibre.com --- Created attachment 53100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53100&action=edit Bug 12063: Change date calculation for reserve expiration to skip all holiday This patch makes koha automatically set expiration date when reserves become waitting. Also it adds a new syspref "ExcludeHolidaysFromMaxPickUpDelay" that allows to take holidays into account while calculating expiration date. Test plan: - Install this patch and run updatedatabase.pl script, - allow ExpireReservesMaxPickUpDelay in system preferences, - set ReservesMaxPickUpDelay to 5. - Place an hold on a checked out item and check in this item: The hold's expiration date should be today + 5. - Allow ExcludeHolidaysFromMaxPickUpDelay in system preferences, - add holiday during this pickup delay period, - Create a new hold and make it comes waitting: The hold's expiration date should be today + 5 + number of closed day(s). Also: - Check that ExpireReservesOnHolidays syspref works again without ExcludeHolidaysFromMaxPickUpDelay. - Check that cancel fees apply again if wanted. Signed-off-by: sonia BOUIS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 13:11:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 11:11:51 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #11 from sandboxes at biblibre.com --- Created attachment 53101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53101&action=edit Bug 12063 - Remove Koha::Hold::waiting_expires_on since dateexpiration is set on database Signed-off-by: sonia BOUIS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 13:22:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 11:22:46 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #12 from Koha Team Lyon 3 --- tested with several days closed on the library. It works as described for the calculation of expirationdate with ExcludeHolidaysFromMaxPickUpDelay activated/desactivated and ReservesMaxPickUpDelay=5. Cancelation with cancelation with misc/cronjobs/holds/cancel_expired_holds.pl (launched on the server by biblibre staff) works normaly. I tried to activate/desactivate the syspref ExpireReservesOnHolidays : if it was on "don't allow" and today was closed on the calendar, holds expired are not cancelled. If it was on "allow", holds are cancelled. Fees are applied if something is set in ExpireReservesMaxPickUpDelayCharge syspref. So works as expected :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 13:39:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 11:39:27 +0000 Subject: [Koha-bugs] [Bug 16854] New: request.tt: Logic to display messages broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Bug ID: 16854 Summary: request.tt: Logic to display messages broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The logic to display messages is broken in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt To verify, examin code in line 295 and following: [% IF ( expiry || diffbranch ) %] This hides messages after line 301: [% IF restricted %] ...and after line 304: [% IF amount_outstanding && Koha.Preference('maxoutstanding') && amount_outstanding > Koha.Preference('maxoutstanding') %] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 13:55:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 11:55:55 +0000 Subject: [Koha-bugs] [Bug 16854] request.tt: Logic to display messages broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 13:57:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 11:57:36 +0000 Subject: [Koha-bugs] [Bug 16854] request.tt: Logic to display messages broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 --- Comment #1 from Marc V?ron --- Created attachment 53102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53102&action=edit Bug 16854: request.tt: Logic to display messages broken This patch fixes broken logic in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt To verify, see initial comment. To test: - Apply patch - Have a patron with a restricion and with outstanding fines greater than defined in syspref 'maxoutstanding' - Place a hold for this patron and verify, that messages 'Patron has restrictions' and 'Patron has outstanding fines...' appear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 13:58:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 11:58:04 +0000 Subject: [Koha-bugs] [Bug 16854] request.tt: Logic to display messages broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 14:04:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 12:04:52 +0000 Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Testing /4 Put a hold and make sure you get "Patron has restrictions": Works on top of Bug 16854 - request.tt: Logic to display messages broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 14:05:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 12:05:18 +0000 Subject: [Koha-bugs] [Bug 16854] request.tt: Logic to display messages broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16849 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 14:05:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 12:05:18 +0000 Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16854 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 15:27:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 13:27:03 +0000 Subject: [Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Caroline changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.stone at wiltshire.ac | |.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 16:08:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 14:08:10 +0000 Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 --- Comment #3 from Marc V?ron --- Regarding /3 Make sure he cannot get a discharge I added a manual restriction to a patron, and I can discharge her with and without patch. Should discharges be blocked by restrictions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 16:23:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 14:23:13 +0000 Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Lari Taskula --- After thinking this issue further and researching other availability definitions that we have in Koha, I think the above definition of availability is confusing and misleading, and routes are not good. Availability is more broad term than what described in the first post, for example item can be available for in-house use but not for checkouts, and by using these routes, this kind of information should also be presented. I'm open to ideas :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 17:18:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 15:18:19 +0000 Subject: [Koha-bugs] [Bug 16853] Move changepassword to Koha::Patron->update_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53098|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 53103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53103&action=edit Bug 16853: Move changepassword to Koha::Patron->update_password This patch moves the code from C4::Members::changepassword to Koha::Patron->update_password Test plan: Change your password at the OPAC and the staff interface This should work as before Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 17:22:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 15:22:38 +0000 Subject: [Koha-bugs] [Bug 16853] Move changepassword to Koha::Patron->update_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 17:22:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 15:22:51 +0000 Subject: [Koha-bugs] [Bug 16853] Move changepassword to Koha::Patron->update_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 17:47:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 15:47:48 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #49 from Alex Sassmannshausen --- Created attachment 53104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53104&action=edit Bug 6906: Follow coding guidelines in terminology. * Koha/Patron.pm (wantsCheckPrevCheckout, doCheckPrevCheckout): Rename to... (wants_check_for_previous_checkout, do_check_for_previous_checkout): ...this. * C4/Circulation.pm: Use new names. * t/db_dependent/Patron/CheckPrevCheckout.t: Renamed to... * t/db_dependent/Patron/Borrower_PrevCheckout.t: ...this. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 17:48:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 15:48:03 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #50 from Alex Sassmannshausen --- Created attachment 53105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53105&action=edit Bug 6906: Add updated schema files. * Koha/Schema/Result/Borrower.pm: Updated schema file. * Koha/Schema/Result/Category.pm: Updated schema file. * Koha/Schema/Result/Deletedborrower.pm: Updated schema file. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 17:50:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 15:50:51 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #51 from Alex Sassmannshausen --- Hi Kyle, I've added 2 more patches to resolve the issues you raised. - One patch now adds updated schema files for dbic. This will fix the test error (previously I assumed the tester would do this, but since the last hackfest I no longer make that assumption). - The other patch renames the methods as requested. Hopefully this addresses the final issues for this bug? Thanks for the review! Alex -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 18:10:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 16:10:12 +0000 Subject: [Koha-bugs] [Bug 16760] Circulation Statistics wizard not populating itemtype correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760 --- Comment #1 from Galen Charlton --- I was able to reproduce this when running under Plack. Turning on warnings in issues_stats2.pl shows the problem: Variable "@filters" is not available at /usr/share/koha/intranet/cgi-bin/reports/issues_stats.pl line 223. Variable "$itemtypes" is not available at /usr/share/koha/intranet/cgi-bin/reports/issues_stats.pl line 309. Variable "$ccodes" is not available at /usr/share/koha/intranet/cgi-bin/reports/issues_stats.pl line 313. Variable "$locations" is not available at /usr/share/koha/intranet/cgi-bin/reports/issues_stats.pl line 314. Variable "$Bsort1" is not available at /usr/share/koha/intranet/cgi-bin/reports/issues_stats.pl line 318. Variable "$Bsort2" is not available at /usr/share/koha/intranet/cgi-bin/reports/issues_stats.pl line 323. Variable "$categoryloop" is not available at /usr/share/koha/intranet/cgi-bin/reports/issues_stats.pl line 328. ... In particular, because $itemtypes is not carried over into the calculate subroutine, no display labels are found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 18:10:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 16:10:35 +0000 Subject: [Koha-bugs] [Bug 16760] Circulation Statistics wizard not populating itemtype correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7172 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 [Bug 7172] Omnibus for Plack variable scoping problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 18:10:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 16:10:35 +0000 Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16760 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760 [Bug 16760] Circulation Statistics wizard not populating itemtype correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 18:23:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 16:23:42 +0000 Subject: [Koha-bugs] [Bug 16854] request.tt: Logic to display messages broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53102|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 53106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53106&action=edit [SIGNED-OFF]Bug 16854: request.tt: Logic to display messages broken This patch fixes broken logic in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt To verify, see initial comment. To test: - Apply patch - Have a patron with a restricion and with outstanding fines greater than defined in syspref 'maxoutstanding' - Place a hold for this patron and verify, that messages 'Patron has restrictions' and 'Patron has outstanding fines...' appear Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 18:23:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 16:23:52 +0000 Subject: [Koha-bugs] [Bug 16854] request.tt: Logic to display messages broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 18:29:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 16:29:24 +0000 Subject: [Koha-bugs] [Bug 16760] Circulation Statistics wizard not populating itemtype correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 18:29:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 16:29:27 +0000 Subject: [Koha-bugs] [Bug 16760] Circulation Statistics wizard not populating itemtype correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760 --- Comment #2 from Galen Charlton --- Created attachment 53107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53107&action=edit Bug 16760: fix Circulation Statistics wizard under Plack This patch fixes some variable scoping problems when running the circulation statistics wizard under Plack. For example, when using the item type as a row header, with this patch the item type description is displayed rather than "UKNOWN VALUE". This patch also enables warnings and fixes a couple variable initialization issues. (Note that turning on warnings across the board would make it easier to identify Plack variable scoping issues, as "Variable "$foo" is not available at' errors would be recorded in the Plack error log). To test ------- [1] Run the staff interface under Plack. [2] Go to the Circulation Statistics Wizard and run a report using item type as the row. Note that the row labels display as "UNKNOWN VALUE" rather than the item type. [3] Apply the patch and restart Plack. [4] Run step #2 again; this time, the item type descriptions should be used as the row labels. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 19:15:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 17:15:53 +0000 Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 19:50:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 17:50:03 +0000 Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 --- Comment #2 from Ji?? Kozlovsk? --- How about returning JSON with all the values possible? Let's say for availability: { in_house: true, checkout: false } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 20:04:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 18:04:51 +0000 Subject: [Koha-bugs] [Bug 16278] Export.pl Tool needs select all/ unselect all boxes for Library section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16278 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |nick at bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #1 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 16548 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 20:04:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 18:04:51 +0000 Subject: [Koha-bugs] [Bug 16548] All libraries selected on Tools -> Export Data screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16548 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org --- Comment #13 from Nick Clemens --- *** Bug 16278 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 20:12:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 18:12:51 +0000 Subject: [Koha-bugs] [Bug 16855] New: Poor performance due to high overhead of SQL call in export.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16855 Bug ID: 16855 Summary: Poor performance due to high overhead of SQL call in export.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Export.pl uses Koha::Biblioitems->search() to retrieve biblionumbers for the export process. The SQL code generated by this does a full dump of the the biblioitems table including the marcxml for each record. This table can be quite large and on smaller servers can actually cause debian to fire oom-killer on the process. As the results of the search are only used to push biblionumbers into an array it might make better sense to do a direct SQL query and not retrieve the marcxml column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 20:35:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 18:35:57 +0000 Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 20:36:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 18:36:00 +0000 Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53035|0 |1 is obsolete| | --- Comment #4 from Ji?? Kozlovsk? --- Created attachment 53108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53108&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. To test: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 2. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 3. Make sure the returned data is correct. 4. Run unit tests in t/db_dependent/api/v1/items.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 20:37:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 18:37:26 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 20:37:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 18:37:29 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #53 from Nick Clemens --- Created attachment 53109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53109&action=edit Bug 3534 (QA Followup) Move QA save toolbar and use same class as full form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 20:38:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 18:38:55 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #54 from Nick Clemens --- (In reply to Jonathan Druart from comment #52) > Why do you use another id for the toolbar? You won't need to add this > specific JS code if you just use "toolbar" as the id. It was just to keep the toolbar in the quick add form, it seemed cleaner. Moving it to the top of the page works as well and doesn't require the js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 20:53:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 18:53:01 +0000 Subject: [Koha-bugs] [Bug 16855] Poor performance due to high overhead of SQL call in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16855 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 20:53:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 18:53:04 +0000 Subject: [Koha-bugs] [Bug 16855] Poor performance due to high overhead of SQL call in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16855 --- Comment #1 from Nick Clemens --- Created attachment 53110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53110&action=edit Bug 16855 - Poor performance due to high overhead of SQL call in export.pl This patch eliminates all columns retrieved in the biblioitems query except for biblionumber. To test: 1 - Go to tools->Export data 2 - Export using various filters and note you get expected records 3 - Apply patch 4 - Ensure exported results match results before patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 21:05:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 19:05:23 +0000 Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53108|0 |1 is obsolete| | --- Comment #5 from Ji?? Kozlovsk? --- Created attachment 53111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53111&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. To test: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 2. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 3. Make sure the returned data is correct. 4. Run unit tests in t/db_dependent/api/v1/items.t Signed-off-by: jirislav -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 21:14:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 19:14:04 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 21:14:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 19:14:12 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52223|0 |1 is obsolete| | --- Comment #23 from Nick Clemens --- Created attachment 53113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53113&action=edit Bug 14576 - Unit tests Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 21:14:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 19:14:06 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52222|0 |1 is obsolete| | --- Comment #22 from Nick Clemens --- Created attachment 53112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53112&action=edit Bug 14576 - Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 21:14:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 19:14:17 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52224|0 |1 is obsolete| | --- Comment #24 from Nick Clemens --- Created attachment 53114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53114&action=edit Bug 14576 - (QA followup) Fix message for use of value not in authorized values Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 21:14:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 19:14:22 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52365|0 |1 is obsolete| | --- Comment #25 from Nick Clemens --- Created attachment 53115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53115&action=edit Bug 14576 (QA Folllowup) Address issues use mock for tests use a separate variable for yaml fix indentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 21:22:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 19:22:17 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #26 from Nick Clemens --- (In reply to Owen Leonard from comment #7) > I think that should be "Item shelving location" (since "location" could be > confused with "library"). Changed > I think the text "Not an authorized value" is not helpful to the user and is > potentially scary. Think "UNAUTHOIRZED VALUE!!" Changed to: 'No description available' - I am happy to reword but I do think it is nice to indicate to the user that it isn't a defined authorized value somehow > - Text describing explicitly the correct format. > - Text explaining that an "_ALL_" rule overrides all others Added to syspref description in editor > - Some way to warn the user if their entry is incorrect. > - Some way to warn the user if they have set an "_ALL_" rule along with > other rules Added js check with warnings for basic syntax I opened a second bug for addition of full GUI - this patchset follows existing format in the system but I do think a full editor could be added as per bug 16698 once this feature is pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 21:31:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 19:31:31 +0000 Subject: [Koha-bugs] [Bug 9259] batch delete marc batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 21:31:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 19:31:35 +0000 Subject: [Koha-bugs] [Bug 9259] batch delete marc batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53007|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 53116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53116&action=edit Bug 9259: Ability to delete a staged file once it has been cleaned To test: 1) Go to Tools -> Staged MARC Management and clean a file. If you have no files to clean, go to 'Stage MARC for import' and upload one to clean following the necessary steps. 2) Confirm that once the file has been cleaned, the Action column now shows a Delete button. Confirm this button only shows for cleaned files. 3) Click the Delete button. 4) Confirm that clicking Cancel exits the pop-up message and does not delete the file. 5) Confirm that clicking OK refreshes the list of staged records and the one you just deleted is no longer on it (has been deleted). You can confirm this by checking for the file in mysql (SELECT * FROM import_batches WHERE import_batch_id = X;) 6) Run prove -v t/db_dependent/ImportBatch.t (have written unit tests for CleanBatch and DeleteBatch) Sponsored-by: Catalyst IT Signed-off-by: Liz Rea Catalyst sign off, so needs another one but YAY this is great. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 21:33:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 19:33:19 +0000 Subject: [Koha-bugs] [Bug 9259] batch delete marc batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 --- Comment #10 from Nick Clemens --- This is great! I think missing form what was requested is the ability to do this to multiple batches at once (batches of import batches) I can open a new bug and retitle this one if that makes the most sense, unless you want to build that functionality in too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 21:54:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 19:54:50 +0000 Subject: [Koha-bugs] [Bug 16760] Circulation Statistics wizard not populating itemtype correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 21:54:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 19:54:52 +0000 Subject: [Koha-bugs] [Bug 16760] Circulation Statistics wizard not populating itemtype correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53107|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 53117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53117&action=edit Bug 16760: fix Circulation Statistics wizard under Plack This patch fixes some variable scoping problems when running the circulation statistics wizard under Plack. For example, when using the item type as a row header, with this patch the item type description is displayed rather than "UKNOWN VALUE". This patch also enables warnings and fixes a couple variable initialization issues. (Note that turning on warnings across the board would make it easier to identify Plack variable scoping issues, as "Variable "$foo" is not available at' errors would be recorded in the Plack error log). To test ------- [1] Run the staff interface under Plack. [2] Go to the Circulation Statistics Wizard and run a report using item type as the row. Note that the row labels display as "UNKNOWN VALUE" rather than the item type. [3] Apply the patch and restart Plack. [4] Run step #2 again; this time, the item type descriptions should be used as the row labels. Signed-off-by: Galen Charlton Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 22:20:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 20:20:01 +0000 Subject: [Koha-bugs] [Bug 10148] 007/006 not filling in with existing values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- The issue is in the template file. Anything that is 9595 lines long has got to have something wrong with it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 22:37:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 20:37:24 +0000 Subject: [Koha-bugs] [Bug 10148] 007/006 not filling in with existing values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtompset at hotmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 22:45:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 20:45:10 +0000 Subject: [Koha-bugs] [Bug 10148] 007/006 not filling in with existing values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 22:45:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 20:45:13 +0000 Subject: [Koha-bugs] [Bug 10148] 007/006 not filling in with existing values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148 --- Comment #4 from M. Tompsett --- Created attachment 53118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53118&action=edit Bug 10148: Marc21 field 007 builder improper reload values The more correct solution is fix that template file. However, in the mean time, this works. TEST PLAN --------- 1) find a record 2) edit record 3) click value builder for 007 4) change everything to pipes as much as possible. (use Motion Picture to get all 00-22 values) 5) save -- should save just fine. 6) click the value builder again -- OOPS! Bad reload. 7) prove t/db_dependent/FrameworkPlugin.t -- NOISY 007 messages. 8) apply patch 9) click the value builder again -- good reload 10) prove t/db_dependent/FrameworkPlugin.t -- No noise related to 007. 11) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 5 22:49:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jul 2016 20:49:57 +0000 Subject: [Koha-bugs] [Bug 10148] 007/006 not filling in with existing values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from M. Tompsett --- I can't duplicate the problem for 006. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 04:41:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 02:41:16 +0000 Subject: [Koha-bugs] [Bug 16664] SQL issues in 16.05 preventing installation in MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16664 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 04:41:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 02:41:19 +0000 Subject: [Koha-bugs] [Bug 16664] SQL issues in 16.05 preventing installation in MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16664 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52037|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic --- Created attachment 53119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53119&action=edit [SIGNED-OFF] Bug 16664: fix loaded SQL for strictness There were some errors in the SQL structure that MySQL got upset at in strict mode. This lets the file load. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 04:44:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 02:44:55 +0000 Subject: [Koha-bugs] [Bug 10148] 007/006 not filling in with existing values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16856 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 04:44:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 02:44:55 +0000 Subject: [Koha-bugs] [Bug 16856] New: unimarc plugin 4xx template noise Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16856 Bug ID: 16856 Summary: unimarc plugin 4xx template noise Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Running prove t/db_dependent/FrameworkPlugin.t triggers UNIMARC 4xx plugin noise. Discovered while fixing 10148. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 04:51:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 02:51:33 +0000 Subject: [Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 04:51:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 02:51:37 +0000 Subject: [Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53090|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 53120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53120&action=edit [SIGNED-OFF] Bug 16848: Prevent invalid warning to be carped from output_pref >From Koha::DateUtils::output_pref: $dt = eval { dt_from_string( $str ) } if $str; carp "Invalid date '$str' passed to output_pref\n" if $@; This second line is wrong: if $str does not exist, the first line is not evaluated and $@ could be filled with previous error. To reproduce: Then: prove t/DateUtils.t will display: t/DateUtils.t .. 20/60 Use of uninitialized value $str in concatenation (.) or string at Koha/DateUtils.pm line 217. Invalid date '' passed to output_pref at t/DateUtils.t line 233. t/DateUtils.t .. ok All tests successful. Files=1, Tests=60, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.40 cusr 0.00 csys = 1.42 CPU) Result: PASS Test plan: Without this patch, you should not see the carp Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 04:52:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 02:52:30 +0000 Subject: [Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #3 from Srdjan Jankovic --- I took liberty of adding local $@ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 04:57:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 02:57:02 +0000 Subject: [Koha-bugs] [Bug 16856] unimarc plugin 4xx template noise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16856 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 04:58:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 02:58:33 +0000 Subject: [Koha-bugs] [Bug 16856] unimarc plugin 4xx template noise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16856 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 04:58:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 02:58:36 +0000 Subject: [Koha-bugs] [Bug 16856] unimarc plugin 4xx template noise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16856 --- Comment #1 from M. Tompsett --- Created attachment 53121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53121&action=edit Bug 16856 - unimarc plugin 4xx template noise While fixing 10148, prove t/db_dependent/FrameworkPlugin.t was run. This triggers UNIMARC 4xx plugin noise. The issue is that itypeloo.selected is not a property that exists in the hash parameter to the template. git grep cataloguing/value_builder/unimarc_field_4XX.tt | grep -v [.]po: The above was used to confirm that there is only one file which affects that template: cataloguing/value_builder/unimarc_field_4XX.pl There is only one way for the Search value to evaluate to true: the else case of the $op check (right at the bottom of the file). The value passed to the itypeloop parameter is a full search from Koha::ItemTypes->search, which has no parameters passed to it, and does not return a 'selected' key as part of the array of hashes. The logic to try to set "selected" in the template makes no sense, as a result, since it is only called with a value that never has "selected" set. The fix is easy: cut the useless code. TEST PLAN --------- 1) prove t/db_dependent/FrameworkPlugin.t -- see unimarc 4xx related noise. 2) apply patch 3) prove t/db_dependent/FrameworkPlugin.t -- no more unimarc 4xx related noise. 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 05:11:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 03:11:07 +0000 Subject: [Koha-bugs] [Bug 16856] unimarc plugin 4xx template noise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16856 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 06:10:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 04:10:55 +0000 Subject: [Koha-bugs] [Bug 16855] Poor performance due to high overhead of SQL call in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16855 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 06:10:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 04:10:59 +0000 Subject: [Koha-bugs] [Bug 16855] Poor performance due to high overhead of SQL call in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16855 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53110|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 53122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53122&action=edit [SIGNED-OFF] Bug 16855 - Poor performance due to high overhead of SQL call in export.pl This patch eliminates all columns retrieved in the biblioitems query except for biblionumber. To test: 1 - Go to tools->Export data 2 - Export using various filters and note you get expected records 3 - Apply patch 4 - Ensure exported results match results before patch Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 06:19:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 04:19:56 +0000 Subject: [Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to additem.pl causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #7 from Srdjan Jankovic --- Jonathan, maybe a silly question: wouldn't it be better to get referer from the header in selectbranchprinter.pl? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 09:18:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 07:18:35 +0000 Subject: [Koha-bugs] [Bug 16857] New: patron-attr-types.tt: Get rid of warnings "Argument "" isn't numeric" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16857 Bug ID: 16857 Summary: patron-attr-types.tt: Get rid of warnings "Argument "" isn't numeric" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org To verify: - Go to Home > Administration > Patron attribute types - Make sure you have some patron attribute types with no branches limitation - For each attribute type you get a warning in intranet-error.log: patron-attr-types.pl: Argument "" isn't numeric in numeric gt (>) at (...)/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt line 284. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 09:19:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 07:19:00 +0000 Subject: [Koha-bugs] [Bug 16857] patron-attr-types.tt: Get rid of warnings "Argument "" isn' t numeric" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16857 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 09:23:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 07:23:03 +0000 Subject: [Koha-bugs] [Bug 16857] patron-attr-types.tt: Get rid of warnings "Argument "" isn' t numeric" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16857 --- Comment #1 from Marc V?ron --- Created attachment 53123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53123&action=edit Bug 16857 - patron-attr-types.tt: Get rid of warnings "Argument "" isn't numeric" To vrify: - Go to Home > Administration > Patron attribute types - Make sure you have some patron attribute types with no branches limitation - For each attribute type you get a warning in intranet-error.log: patron-attr-types.pl: Argument "" isn't numeric in numeric gt (>) at (...)/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt line 284. To test: - Appy patch - Verify that warnings no longer appear in intranet-error.log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 09:23:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 07:23:25 +0000 Subject: [Koha-bugs] [Bug 16857] patron-attr-types.tt: Get rid of warnings "Argument "" isn' t numeric" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16857 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 09:40:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 07:40:32 +0000 Subject: [Koha-bugs] [Bug 9259] batch delete marc batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 --- Comment #11 from Aleisha Amohia --- (In reply to Nick Clemens from comment #10) > This is great! I think missing form what was requested is the ability to do > this to multiple batches at once (batches of import batches) > > I can open a new bug and retitle this one if that makes the most sense, > unless you want to build that functionality in too? Please file a new bug for that and I'll work on it. Would like to get this one tested and passed since it's been around for a while :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 11:42:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 09:42:15 +0000 Subject: [Koha-bugs] [Bug 16858] New: import_borrowers.pl does not load because of mysql 5.7 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16858 Bug ID: 16858 Summary: import_borrowers.pl does not load because of mysql 5.7 Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: npm at zefanjas.de QA Contact: testopia at bugs.koha-community.org The Import Patrons tool does not load on MySQL 5.7 because of the default sql_mode: only_full_group_by. This is the error I got: http://paste.koha-community.org/16 Can't use an undefined value as an ARRAY reference at /usr/lib/x86_64-linux-gnu/perl5/5.22/DBI.pm line 2083 If I change the sql_mode to a mysql 5.6 behavior the import page loads fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 12:07:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 10:07:44 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 --- Comment #1 from Oliver Bock --- Created attachment 53124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53124&action=edit Patch: support password mapping with empty default This patch fixes a related piece of code. The comment says "if password was mapped". That's not what the original code does as the condition was actually "if password was mapped and it's default is not empty". This patch is required in the context of the other patch in this bug report which removes the broken failsafe (" " -> null/undef, true empty defaults). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 12:47:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 10:47:07 +0000 Subject: [Koha-bugs] [Bug 15131] Give SCO separate control for AllowItemsOnHoldCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15131 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|kyle at bywatersolutions.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 12:53:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 10:53:54 +0000 Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 12:55:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 10:55:58 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 13:03:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 11:03:03 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 13:07:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 11:07:10 +0000 Subject: [Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819 --- Comment #10 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #9) > (In reply to Jonathan Druart from comment #8) > > Created attachment 53056 [details] [review] [review] > > Bug 16819: Remove use of map > > > > Signed-off-by: Jonathan Druart > > Tomas or RM: feel free to obsolete this patch if you want to. I like either, passing the ball to the RM :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 13:40:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 11:40:05 +0000 Subject: [Koha-bugs] [Bug 16810] Fines note not showing on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Version|16.05 |master --- Comment #2 from Marc V?ron --- Same issue on master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 13:40:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 11:40:28 +0000 Subject: [Koha-bugs] [Bug 16810] Fines note not showing on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 13:41:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 11:41:11 +0000 Subject: [Koha-bugs] [Bug 16810] Fines note not showing on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 --- Comment #3 from Marc V?ron --- Created attachment 53125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53125&action=edit Bug 16810 - Fines note not showing on checkout Fines did not show on patron checkout and detail pages unless amout was greater than syspref NoIssueCharges. This patch fixes the logic in koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc Additionally, it changes links to buttons and makes some small text changes to ease translation. To test: - Apply patch - Display checkout or detail page and verify proper display for a patron who has - no fines (no message) - fines not exceeding syspref NoissueCharges (message) - fines exceeding syspref NoIssueCharges (message) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 13:46:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 11:46:42 +0000 Subject: [Koha-bugs] [Bug 16810] Fines note not showing on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 14:50:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 12:50:41 +0000 Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha log file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 14:50:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 12:50:43 +0000 Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha log file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436 --- Comment #7 from Kyle M Hall --- Created attachment 53126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53126&action=edit Bug 16436 [QA Followup] - Use debug instead of info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 14:51:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 12:51:37 +0000 Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha log file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436 --- Comment #8 from Kyle M Hall --- (In reply to Jonathan Druart from comment #6) > How this can be useful for a library? > Should not we use DEBUG instead of INFO? That works for me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 15:27:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 13:27:23 +0000 Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for caching koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16166 --- Comment #23 from Jonathan Druart --- (In reply to Chris Cormack from comment #22) > Applying: Bug XXXXX_2: Add the ability to define several namespaces - tests > fatal: sha1 information is lacking or useless (t/Cache.t). > error: could not build fake ancestor > Patch failed at 0001 Bug XXXXX_2: Add the ability to define several > namespaces - tests Sorry, I forgot to add the dependent bug. It depends on bug 16166. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166 [Bug 16166] Improve L1 cache performance and safety -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 15:27:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 13:27:23 +0000 Subject: [Koha-bugs] [Bug 16166] Improve L1 cache performance and safety In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16579 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 [Bug 16579] Use separate memcached namespace for caching koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 15:27:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 13:27:30 +0000 Subject: [Koha-bugs] [Bug 16579] Use separate memcached namespace for caching koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 15:33:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 13:33:47 +0000 Subject: [Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 --- Comment #4 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #3) > I took liberty of adding local $@ Are you sure it is useful? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 15:44:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 13:44:14 +0000 Subject: [Koha-bugs] [Bug 16854] request.tt: Logic to display messages broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53106|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53127&action=edit Bug 16854: request.tt: Logic to display messages broken This patch fixes broken logic in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt To verify, see initial comment. To test: - Apply patch - Have a patron with a restricion and with outstanding fines greater than defined in syspref 'maxoutstanding' - Place a hold for this patron and verify, that messages 'Patron has restrictions' and 'Patron has outstanding fines...' appear Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 15:44:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 13:44:11 +0000 Subject: [Koha-bugs] [Bug 16854] request.tt: Logic to display messages broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 15:44:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 13:44:31 +0000 Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 [Bug 16854] request.tt: Logic to display messages broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 15:44:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 13:44:31 +0000 Subject: [Koha-bugs] [Bug 16854] request.tt: Logic to display messages broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16849 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 15:54:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 13:54:50 +0000 Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 --- Comment #4 from Jonathan Druart --- (In reply to Marc V?ron from comment #3) > Regarding /3 Make sure he cannot get a discharge > > I added a manual restriction to a patron, and I can discharge her with and > without patch. > Should discharges be blocked by restrictions? Actually it's a bit tricky :) The expected behavior is: Discharge a patron for the first time will debar the patron and generate a discharge. Click on discharge again: no new discharge will be generated (the pdf will, but no new entries in the discharges table). Remove the debarment and generate a new discharge will create a new entry in the discharges table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 15:58:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 13:58:06 +0000 Subject: [Koha-bugs] [Bug 16859] New: Fix wrong item field name in export.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16859 Bug ID: 16859 Summary: Fix wrong item field name in export.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 15:58:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 13:58:18 +0000 Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha log file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436 --- Comment #9 from Jonathan Druart --- (In reply to Kyle M Hall from comment #8) > (In reply to Jonathan Druart from comment #6) > > How this can be useful for a library? > > Should not we use DEBUG instead of INFO? > > That works for me! And, how this can be useful for a library? What's the use case? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:04:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:04:25 +0000 Subject: [Koha-bugs] [Bug 16760] Circulation Statistics wizard not populating itemtype correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:04:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:04:28 +0000 Subject: [Koha-bugs] [Bug 16760] Circulation Statistics wizard not populating itemtype correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53117|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 53128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53128&action=edit Bug 16760: fix Circulation Statistics wizard under Plack This patch fixes some variable scoping problems when running the circulation statistics wizard under Plack. For example, when using the item type as a row header, with this patch the item type description is displayed rather than "UKNOWN VALUE". This patch also enables warnings and fixes a couple variable initialization issues. (Note that turning on warnings across the board would make it easier to identify Plack variable scoping issues, as "Variable "$foo" is not available at' errors would be recorded in the Plack error log). To test ------- [1] Run the staff interface under Plack. [2] Go to the Circulation Statistics Wizard and run a report using item type as the row. Note that the row labels display as "UNKNOWN VALUE" rather than the item type. [3] Apply the patch and restart Plack. [4] Run step #2 again; this time, the item type descriptions should be used as the row labels. Signed-off-by: Galen Charlton Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:08:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:08:42 +0000 Subject: [Koha-bugs] [Bug 16859] Fix wrong item field name in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16859 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Marcel de Rooy --- Resolve: DBIx::Class::ResultSet::next(): Unknown column 'callnumber' in 'where clause' at /usr/share/koha/masterclone/Koha/Objects.pm line 168 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:10:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:10:06 +0000 Subject: [Koha-bugs] [Bug 16589] Quote of the day: Fix upload with csv files associated to LibreOffice Calc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 --- Comment #10 from Marcel de Rooy --- Created attachment 53129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53129&action=edit Bug 16859: Fix wrong item field name in export.pl Field callnumber should be itemcallnumber. For completeness, prefixing the joined fields with items table prefix. Note: You should expect Tools/Export to export only the items within a given itemcallnumber range, but if the biblio has one item in that range, the biblionumber is selected for export with ALL items. The script is designed that way (first select biblio numbers based on criteria, and run export with those biblio numbers). Test plan: [1] Select a biblio N with one item with say itemcallnumber X. [2] Goto Tools/Export. Select biblio range N,N and no itemcallnumber range. The biblio should be exported. [3] Select biblio range N,N and itemcallnumber range A,B. No output. [4] Select biblio range N,N and itemcallnumber range A,. Output. [5] Select biblio range N,N and itemcallnumber range ,X. Output. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:10:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:10:33 +0000 Subject: [Koha-bugs] [Bug 16859] Fix wrong item field name in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16859 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:11:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:11:19 +0000 Subject: [Koha-bugs] [Bug 16859] Fix wrong item field name in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16859 --- Comment #2 from Marcel de Rooy --- Created attachment 53130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53130&action=edit Bug 16859: Fix wrong item field name in export.pl Field callnumber should be itemcallnumber. For completeness, prefixing the joined fields with items table prefix. Note: You should expect Tools/Export to export only the items within a given itemcallnumber range, but if the biblio has one item in that range, the biblionumber is selected for export with ALL items. The script is designed that way (first select biblio numbers based on criteria, and run export with those biblio numbers). Test plan: [1] Select a biblio N with one item with say itemcallnumber X. [2] Goto Tools/Export. Select biblio range N,N and no itemcallnumber range. The biblio should be exported. [3] Select biblio range N,N and itemcallnumber range A,B. No output. [4] Select biblio range N,N and itemcallnumber range A,. Output. [5] Select biblio range N,N and itemcallnumber range ,X. Output. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:12:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:12:53 +0000 Subject: [Koha-bugs] [Bug 16589] Quote of the day: Fix upload with csv files associated to LibreOffice Calc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16589 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53129|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Comment on attachment 53129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53129 Bug 16859: Fix wrong item field name in export.pl Sorry, wrong bug number.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:17:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:17:41 +0000 Subject: [Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to additem.pl causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750 --- Comment #8 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #7) > Jonathan, maybe a silly question: wouldn't it be better to get referer from > the header in selectbranchprinter.pl? It's what does the current code, but the HTTP_REFERER does not contain the POST params. But actually I am not sure it's a good idea: with this patch the form will be submitted again and the item will be saved a second time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:20:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:20:48 +0000 Subject: [Koha-bugs] [Bug 16645] Plack: Add the multi_param fix from Context in koha.psgi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15809 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:20:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:20:48 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16645 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:21:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:21:41 +0000 Subject: [Koha-bugs] [Bug 15088] Notice when koha has been installed with --request-db instead of --create-db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #14 from Jonathan Druart --- Ccing Tomas to get his opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:29:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:29:23 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #52 from Jonathan Druart --- (In reply to Alex Sassmannshausen from comment #49) > * t/db_dependent/Patron/CheckPrevCheckout.t: Renamed to... > * t/db_dependent/Patron/Borrower_PrevCheckout.t: ...this. Why? :) (In reply to Alex Sassmannshausen from comment #51) > - One patch now adds updated schema files for dbic. This will fix the test > error (previously I assumed the tester would do this, but since the last > hackfest I no longer make that assumption). AFAIK that is still the case. Actually I personally submit a patch with a DONT_PUSH pattern in the commit message and let the RM generate the schema by himself. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:31:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:31:05 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #53 from Jonathan Druart --- Note that an occurrence of 'wantsCheckPrevCheckout' has been left in the POD of Koha::Patron. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:34:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:34:18 +0000 Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha log file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436 --- Comment #10 from Kyle M Hall --- (In reply to Jonathan Druart from comment #9) > (In reply to Kyle M Hall from comment #8) > > (In reply to Jonathan Druart from comment #6) > > > How this can be useful for a library? > > > Should not we use DEBUG instead of INFO? > > > > That works for me! > > And, how this can be useful for a library? > What's the use case? The use case would be for a way to 'archive' action logs outside of the database. With the logger, we can even redirect those specific logs to other files. For development and debugging, it's helpful to see the actions in the context of the rest of the debugging output. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:47:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:47:16 +0000 Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 --- Comment #5 from Marc V?ron --- (In reply to Jonathan Druart from comment #4) > (In reply to Marc V?ron from comment #3) > > Regarding /3 Make sure he cannot get a discharge > > > > I added a manual restriction to a patron, and I can discharge her with and > > without patch. > > Should discharges be blocked by restrictions? > > Actually it's a bit tricky :) > The expected behavior is: > Discharge a patron for the first time will debar the patron and generate a > discharge. > Click on discharge again: no new discharge will be generated (the pdf will, > but no new entries in the discharges table). > Remove the debarment and generate a new discharge will create a new entry in > the discharges table. Thanks, Jonathan, for the explanation. Patch works as described and I will sign off. For the records: IMO the behavior (with and without patch) is not optimal: - As far as I understand a patron who has got a discharge should not be able to check out items again (adding a restriction that never expires). - However, if I put a manual restriction to this patron that expires let's say tomorrow, discharging will not add it's own restriction. The day after tomorrow, the patron will be able to check out again (but she has got a discharge). What do you think about? Is that intended or is it a Bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:52:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:52:12 +0000 Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53093|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 53131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53131&action=edit Bug 16849: Move IsDebarred to Koha::Patron->is_debarred In order to move IsMemberBlocked to Koha::Patron it makes sense to move the code from Koha::Patron::Debarments::IsDebarred to Koha::Patron->is_debarred. Test plan: 1/ Add a restriction to a patron 2/ make sure he is not able to checkout items any more 3/ Make sure he cannot get a discharge 4/ Put a hold and make sure you get "Patron has restrictions" Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:52:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:52:40 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53010|0 |1 is obsolete| | Attachment #53013|0 |1 is obsolete| | --- Comment #53 from Colin Campbell --- Created attachment 53132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53132&action=edit proposed patch 1 Fix bugs in login procedure Fix errors which in raw_transport login that caused the server to fall into the sip_proticol_loop if login was unsuccesful. Also ensure session does not use info from a previously closed session if Net::Server::PreFork is used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:53:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:53:42 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53009|0 |1 is obsolete| | --- Comment #54 from Colin Campbell --- Created attachment 53133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53133&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:55:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:55:35 +0000 Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 16:58:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 14:58:54 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53014|0 |1 is obsolete| | --- Comment #55 from Colin Campbell --- Created attachment 53134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53134&action=edit Rebase of Marcel's earlier patch Rebased against the changes in login - NB the test plan includes testing the timeout in raw_connection- however I'm not sure thats now meaningful - if the user fails to login the connection will be dropped after the rejection response is sent. There will be no connection to timeout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:03:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:03:57 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #56 from Colin Campbell --- Created attachment 53135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53135&action=edit Proposed patch As the preceding patch touched Sip.pm's EXPORTS it maybe time to tidy up the messy indent there. Also replaced the direct manipulation of ISA in a begin sub with use base as recommended in perldoc - reads cleaner -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:04:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:04:55 +0000 Subject: [Koha-bugs] [Bug 16645] Plack: Add the multi_param fix from Context in koha.psgi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin SOMERS --- Hie, I'd say it depends on Bug 15809 directly no ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:05:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:05:37 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #55 from Jonathan Druart --- Nick, with your last patches, there is a problem: If you are on the quick add form, then switch to the full form, the toolbar is not floating. If I remove the last patch, there is floating toolbar on the quick add form is not displayed correctly (there is a margin top). I think you should trick the code to have only 1 toolbar for the 2 forms. You will need to add a flag to check, to know which form we want to save. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:09:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:09:32 +0000 Subject: [Koha-bugs] [Bug 16645] Plack: Add the multi_param fix from Context in koha.psgi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 --- Comment #3 from Fridolin SOMERS --- + no warnings 'redefine'; This is already set a few lines above. No ? + use warnings 'redefine'; sure we need this line ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:09:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:09:58 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #57 from Colin Campbell --- I've now submitted a series of 4 patches, including a rebase of Marcel's timeout changes. The main logic changes are all in the first which fixes the flaw in the raw_transport logic that causes bad/failed connections to drop into the sip_protocol_loop thus necessitating timing out. The patches assume that the patch for Bug 13807 has been applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:12:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:12:18 +0000 Subject: [Koha-bugs] [Bug 16664] SQL issues in 16.05 preventing installation in MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16664 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- This fix is already done on bug 16573 (which should get more love). We could push this one separately anyway but I think the patch should fix existing installs too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:13:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:13:08 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #54 from Alex Sassmannshausen --- Created attachment 53136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53136&action=edit Bug 6906: Fix POD reference to old method name. * Koha/Patron.pm (wants_check_for_previous_checkout): Fix POD. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:13:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:13:50 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #55 from Alex Sassmannshausen --- (In reply to Jonathan Druart from comment #53) > Note that an occurrence of 'wantsCheckPrevCheckout' has been left in the POD > of Koha::Patron. Good catch, cheers. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:16:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:16:42 +0000 Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #1 from Jonathan Druart --- *** Bug 16832 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:16:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:16:42 +0000 Subject: [Koha-bugs] [Bug 11698] Add validity check for amount on budget page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11698 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16832 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:16:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:16:42 +0000 Subject: [Koha-bugs] [Bug 16832] Patrons categories fails due the Switzerland number format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11698 Resolution|--- |DUPLICATE CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED --- Comment #3 from Jonathan Druart --- This error appears when you try to display a very big number (on the funds page for instance). I don't think it's related to the new numbering format. *** This bug has been marked as a duplicate of bug 15770 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:19:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:19:15 +0000 Subject: [Koha-bugs] [Bug 16810] Fines note not showing on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53125|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 53137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53137&action=edit [SIGNED-OFF]Bug 16810: Fines note not showing on checkout Fines did not show on patron checkout and detail pages unless amout was greater than syspref NoIssueCharges. This patch fixes the logic in koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc Additionally, it changes links to buttons and makes some small text changes to ease translation. To test: - Apply patch - Display checkout or detail page and verify proper display for a patron who has - no fines (no message) - fines not exceeding syspref NoissueCharges (message) - fines exceeding syspref NoIssueCharges (message) Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:19:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:19:25 +0000 Subject: [Koha-bugs] [Bug 16810] Fines note not showing on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:34:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:34:35 +0000 Subject: [Koha-bugs] [Bug 16855] Poor performance due to high overhead of SQL call in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:34:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:34:38 +0000 Subject: [Koha-bugs] [Bug 16855] Poor performance due to high overhead of SQL call in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53122|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53138&action=edit Bug 16855 - Poor performance due to high overhead of SQL call in export.pl This patch eliminates all columns retrieved in the biblioitems query except for biblionumber. To test: 1 - Go to tools->Export data 2 - Export using various filters and note you get expected records 3 - Apply patch 4 - Ensure exported results match results before patch Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:36:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:36:06 +0000 Subject: [Koha-bugs] [Bug 16855] Poor performance due to high overhead of SQL call in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Quick benchmark using: use Koha::Biblioitems; my @record_ids; my $biblioitems = Koha::Biblioitems->search( {}, { join => 'items', columns => 'biblionumber' } ); while ( my $biblioitem = $biblioitems->next ) { push @record_ids, $biblioitem->biblionumber; } and use Koha::Biblioitems; my @record_ids; my $biblioitems = Koha::Biblioitems->search( {}, { join => 'items' } ); while ( my $biblioitem = $biblioitems->next ) { push @record_ids, $biblioitem->biblionumber; } gives 1.4s vs 1.7s with 8600 items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:36:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:36:15 +0000 Subject: [Koha-bugs] [Bug 16855] Poor performance due to high overhead of SQL call in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:38:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:38:34 +0000 Subject: [Koha-bugs] [Bug 16855] Poor performance due to high overhead of SQL call in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 [Bug 14722] Refactor the catalogue export tool (command-line tools/export.pl does not work anymore. Use misc/export_records.pl instead) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:38:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:38:34 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the catalogue export tool (command-line tools/ export.pl does not work anymore. Use misc/export_records.pl instead) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16855 [Bug 16855] Poor performance due to high overhead of SQL call in export.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:43:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:43:09 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #56 from Jonathan Druart --- (In reply to Jonathan Druart from comment #52) > (In reply to Alex Sassmannshausen from comment #49) > > * t/db_dependent/Patron/CheckPrevCheckout.t: Renamed to... > > * t/db_dependent/Patron/Borrower_PrevCheckout.t: ...this. > > Why? :) It seems that you missed this one -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:45:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:45:24 +0000 Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 --- Comment #7 from Jonathan Druart --- (In reply to Marc V?ron from comment #5) > What do you think about? Is that intended or is it a Bug? I think it's intended: Even if a patron got a discharge, (s)he could come back to the library (next year, or 5 years after). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:47:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:47:51 +0000 Subject: [Koha-bugs] [Bug 16682] Batch patron modification tool should not allow selection of empty patron lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- You get the same result if you simply do not fill any of "Use a file", "Or use a patron list", "Or list card numbers...". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:49:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:49:59 +0000 Subject: [Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #25 from M. Tompsett --- (In reply to Jonathan Druart from comment #23) > Created attachment 40184 [details] [review] > [ FOR DISCUSSION ] Bug 14334: Add a Database module for db dependent tests > > What about something like that to avoid c/p? +1 I like this. If I get back to this bug, I'll use that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:56:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:56:49 +0000 Subject: [Koha-bugs] [Bug 16860] New: Catch warning t/db_dependent/ClassSource.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 Bug ID: 16860 Summary: Catch warning t/db_dependent/ClassSource.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: mtompset at hotmail.com Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com $ prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 3/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.66 cusr 0.02 csys = 0.70 CPU) Result: PASS The above warning might be scary to those unfamiliar with the test. Add a test to catch the warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:57:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:57:24 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #57 from Alex Sassmannshausen --- (In reply to Jonathan Druart from comment #52) > (In reply to Alex Sassmannshausen from comment #49) > > * t/db_dependent/Patron/CheckPrevCheckout.t: Renamed to... > > * t/db_dependent/Patron/Borrower_PrevCheckout.t: ...this. > > Why? :) It struck me there was a pattern to the naming of the test files, I decided to stick with that. > (In reply to Alex Sassmannshausen from comment #51) > > - One patch now adds updated schema files for dbic. This will fix the test > > error (previously I assumed the tester would do this, but since the last > > hackfest I no longer make that assumption). > > AFAIK that is still the case. > Actually I personally submit a patch with a DONT_PUSH pattern in the commit > message and let the RM generate the schema by himself. Interesting ? I see the reason why you'd add DONT_PUSH ? presumably to make it clear to the RM that they should generate the schema files themselves? To clarify: do you literally just dump DONT_PUSH somewhere in the commit message? Or is it part of the subject line or has a special location? Alex -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:58:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:58:11 +0000 Subject: [Koha-bugs] [Bug 9259] batch delete marc batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:58:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:58:14 +0000 Subject: [Koha-bugs] [Bug 9259] batch delete marc batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53116|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 53139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53139&action=edit Bug 9259: Ability to delete a staged file once it has been cleaned To test: 1) Go to Tools -> Staged MARC Management and clean a file. If you have no files to clean, go to 'Stage MARC for import' and upload one to clean following the necessary steps. 2) Confirm that once the file has been cleaned, the Action column now shows a Delete button. Confirm this button only shows for cleaned files. 3) Click the Delete button. 4) Confirm that clicking Cancel exits the pop-up message and does not delete the file. 5) Confirm that clicking OK refreshes the list of staged records and the one you just deleted is no longer on it (has been deleted). You can confirm this by checking for the file in mysql (SELECT * FROM import_batches WHERE import_batch_id = X;) 6) Run prove -v t/db_dependent/ImportBatch.t (have written unit tests for CleanBatch and DeleteBatch) Sponsored-by: Catalyst IT Signed-off-by: Liz Rea Catalyst sign off, so needs another one but YAY this is great. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:58:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:58:18 +0000 Subject: [Koha-bugs] [Bug 9259] batch delete marc batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 --- Comment #13 from Jonathan Druart --- Created attachment 53140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53140&action=edit Bug 9259: Use is instead of is_deeply Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:58:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:58:39 +0000 Subject: [Koha-bugs] [Bug 16861] New: Translatability: Fix separated "abow" in circulation.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Bug ID: 16861 Summary: Translatability: Fix separated "abow" in circulation.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: hector.hecaxmmx at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Depends on: 16810 This patch propose to fix this two entries in PO files: #: intranet-tmpl/prog/en/modules/circ/circulation.tt:797 #, c-format msgid ". See highlighted items " msgstr ". V?ase los ?tems resaltados " #: intranet-tmpl/prog/en/modules/circ/circulation.tt:797 #, c-format msgid "below" msgstr "debajo" Also add some Font Awesome Icons to circulation interface. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 [Bug 16810] Fines note not showing on checkout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 17:58:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 15:58:39 +0000 Subject: [Koha-bugs] [Bug 16810] Fines note not showing on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16861 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 [Bug 16861] Translatability: Fix separated "abow" in circulation.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:00:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:00:21 +0000 Subject: [Koha-bugs] [Bug 16860] Catch warning t/db_dependent/ClassSource.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:00:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:00:24 +0000 Subject: [Koha-bugs] [Bug 16860] Catch warning t/db_dependent/ClassSource.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 --- Comment #1 from M. Tompsett --- Created attachment 53141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53141&action=edit Bug 16860: Catch warning t/db_dependent/ClassSource.t $ prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 3/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.66 cusr 0.02 csys = 0.70 CPU) Result: PASS The above warning might be scary to those unfamiliar with the test. Add a test to catch the warning. TEST PLAN --------- 1) prove t/db_dependent/ClassSource.t -- as above 2) apply patch 3) prove t/db_dependent/ClassSource.t -- no message 4) prove -v t/db_dependent/ClassSource.t -- test 13 is the new test 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:00:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:00:23 +0000 Subject: [Koha-bugs] [Bug 9259] batch delete marc batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart --- To enhance: Maybe DeleteBatch should check if the batch has been cleaned before deleting it. Note that the patch is not perfect but follow the existing pattern of this module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:01:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:01:01 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability: Fix |Translatability: Fix |separated "abow" in |separated "below" in |circulation.tt |circulation.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:04:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:04:54 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:04:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:04:56 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 53142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53142&action=edit Bug 16861: Translatability: Fix separated "below" in circulation.tt This patch propose to fix this two entries in PO files: "See highlighted items" and "below" Also add some Font Awesome Icons To test: -Go to a patron how has overdues -See the link "See highlighted items below" with a hand down icon -Look the new plus icon to "Add a new message" to the patron. -Add a few messages and notice about the trash icon in "Delete" links -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:07:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:07:43 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org, | |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:10:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:10:30 +0000 Subject: [Koha-bugs] [Bug 16862] New: Allow batch actions in staged marc management Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16862 Bug ID: 16862 Summary: Allow batch actions in staged marc management Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Many libraries/consortia have many imports and it would be nice to have a way to select multiple batches at a time for cleaning and deleting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:10:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:10:40 +0000 Subject: [Koha-bugs] [Bug 16862] Allow batch actions in staged marc management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16862 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9259 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:10:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:10:40 +0000 Subject: [Koha-bugs] [Bug 9259] batch delete marc batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16862 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:11:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:11:27 +0000 Subject: [Koha-bugs] [Bug 9259] Delete marc batches from staged marc management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|batch delete marc batches |Delete marc batches from | |staged marc management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:12:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:12:07 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #58 from Jonathan Druart --- (In reply to Alex Sassmannshausen from comment #57) > (In reply to Jonathan Druart from comment #52) > > (In reply to Alex Sassmannshausen from comment #49) > > > * t/db_dependent/Patron/CheckPrevCheckout.t: Renamed to... > > > * t/db_dependent/Patron/Borrower_PrevCheckout.t: ...this. > > > > Why? :) > > It struck me there was a pattern to the naming of the test files, I decided > to stick with that. Ha yes, got it! Actually the methods of Koha::Patron are tested in subtests of t/db_dependent/Koha/Patrons.t So it would make to move yours there. But it's 400 lines, so maybe not... Actually we have t/db_dependent/Patron.t t/db_dependent/Patrons.t t/db_dependent/Patron/*.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patron/*.t It's a bit... confusing, I agree :) So let's keep it as it, and I will try to clean that on another bug report. > > (In reply to Alex Sassmannshausen from comment #51) > > > - One patch now adds updated schema files for dbic. This will fix the test > > > error (previously I assumed the tester would do this, but since the last > > > hackfest I no longer make that assumption). > > > > AFAIK that is still the case. > > Actually I personally submit a patch with a DONT_PUSH pattern in the commit > > message and let the RM generate the schema by himself. > > Interesting ? I see the reason why you'd add DONT_PUSH ? presumably to make > it clear to the RM that they should generate the schema files themselves? > > To clarify: do you literally just dump DONT_PUSH somewhere in the commit > message? > > Or is it part of the subject line or has a special location? Beginning of the commit message, something like: Bug 12345: [DO NOT PUSH] Schema files That could be a topic for the next meeting, in order to clarify things for everybody. Kyle, any thoughts? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:14:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:14:45 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53142|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 53143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53143&action=edit Bug 16861: Translatability: Fix separated "below" in circulation.tt This patch propose to fix this two entries in PO files: "See highlighted items" and "below" Also add some Font Awesome Icons To test: -Apply patch 16810 on top and this patch -Go to a patron who has overdues in checkout tab -See the link "See highlighted items below" with a hand down icon -Look the new plus icon to "Add a new message" to the patron. -Add a few messages and notice about the trash icon in "Delete" links -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:15:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:15:55 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52278|0 |1 is obsolete| | Attachment #52279|0 |1 is obsolete| | Attachment #52280|0 |1 is obsolete| | Attachment #53104|0 |1 is obsolete| | Attachment #53105|0 |1 is obsolete| | Attachment #53136|0 |1 is obsolete| | --- Comment #59 from Jonathan Druart --- Created attachment 53144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53144&action=edit Bug 6906 - show 'Borrower has previously issued... New feature: provide granular means to configure warnings about items that have been issued to a particular borrower before, according to their checkout history. - Global syspref ('CheckPrevCheckout'), set to 'hardno' by default, allows users to enable this feature library wide. - Per patron category pref allows libraries to create overrides per category, falling back on the global setting by default. - Per patron pref allows switching the functionality on at the level of patron. Fall-back to category settings by default. * Koha/Patron (wantsCheckPrevCheckout, doCheckPrevCheckout): New methods. * C4/Circulation.pm (CanBookBeIssued): Introduce CheckPrevCheckout check. * admin/categories.pl: Pass along checkprevcheckout. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: Expose CheckPrevCheckout per category setting. * koha-tmpl/intranet-tmpl/prog/en/modules/preferences/patrons.pref: Expose CheckPrevCheckout syspref. * koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Expose per patron CheckPrevCheckout preference. * koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: Expose per patron CheckPrevCheckout preference. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add 'CHECKPREVCHECKOUT' confirmation message. * installer/data/mysql/kohastructure.sql: Modify structure of 'categories', 'borrowers', 'oldborrowers'. * installer/data/mysql/sysprefs.sql: Add 'CheckPrevCheckout'. * installer/data/mysql/atomicupdate/checkPrevCheckout.sql: New file. * t/db_dependent/Patron/CheckPrevCheckout.t: New file with unit tests. Test plan: - Apply patch. - Run updatedatabase. - Regenerate Koha Schema files. - Run the unit tests. - Verify 'CheckPrevCheckout' is visible in Patrons sysprefs and can be switched to 'hardyes', 'softyes', 'softno' and 'hardno'. + Check out previously checked out items to a patron, checking the message appears as expected. - Verify no 'Check previous checkouts' setting appears on the borrower category pages if the syspref is set to a 'hard' option. - Verify 'Check previous checkouts' setting appears on the borrower category pages and can be modified per borrower category. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the default setting if that is set to a 'soft' option). - Verify no 'Check previous checkouts' setting appears on the individual borrower pages if the syspref is set to a 'hard' option. - Verify 'Check previous checkouts' setting appears on individual borrower pages and can be modified. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the category setting and the default setting if the latter is set to a 'soft' option). Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:16:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:16:05 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #60 from Jonathan Druart --- Created attachment 53145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53145&action=edit Bug 6906: Tests - Do not assume CPL exists Since bug 14878, tests must create the data they need to pass and not assume they exist. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:16:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:16:13 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #61 from Jonathan Druart --- Created attachment 53146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53146&action=edit Bug 6906: Add the warning message to the batch checkout Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:16:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:16:18 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #62 from Jonathan Druart --- Created attachment 53147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53147&action=edit Bug 6906: Follow coding guidelines in terminology. * Koha/Patron.pm (wantsCheckPrevCheckout, doCheckPrevCheckout): Rename to... (wants_check_for_previous_checkout, do_check_for_previous_checkout): ...this. * C4/Circulation.pm: Use new names. * t/db_dependent/Patron/CheckPrevCheckout.t: Renamed to... * t/db_dependent/Patron/Borrower_PrevCheckout.t: ...this. Bug 6906: Fix POD reference to old method name. * Koha/Patron.pm (wants_check_for_previous_checkout): Fix POD. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:16:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:16:23 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #63 from Jonathan Druart --- Created attachment 53148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53148&action=edit Bug 6906: Add updated schema files. * Koha/Schema/Result/Borrower.pm: Updated schema file. * Koha/Schema/Result/Category.pm: Updated schema file. * Koha/Schema/Result/Deletedborrower.pm: Updated schema file. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:19:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:19:33 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #64 from Jonathan Druart --- I have squashed 2 patches, for readability. Note that QA tools complains: FAIL t/db_dependent/Patron/CheckPrevCheckout.t FAIL git manipulation The file has been added and deleted in the same patchset But first patch has been signed off and the other one is a qa-followup, so it's ok by me. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:42:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:42:36 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Batch patron modification |Fix display if Batch patron |tool should not allow |modification tool does not |selection of empty patron |get any patrons |lists | Assignee|gmcharlt at gmail.com |veron at veron.ch --- Comment #2 from Marc V?ron --- Changed Bug title to reflect all of the cases (see comment #1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:47:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:47:18 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 --- Comment #3 from Marc V?ron --- Created attachment 53149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53149&action=edit Bug 16682 - Fix display if Batch patron modification tool does not get any patrons To reproduce: - Go to Tools->Batch patron modification - Submit without filling any of "Use a file", "Or use a patron list", "Or list card numbers..." or use a patron lists with zero members Result: Screen without any information To test: - Apply patch - Repeat steps above - Verify that you get a nice message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 18:47:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 16:47:36 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 19:12:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 17:12:32 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53143|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 53150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53150&action=edit Bug 16861: Translatability: Fix separated "below" in circulation.tt This patch propose to fix this two entries in PO files: "See highlighted items" and "below" Also add some Font Awesome Icons To test: -Apply patch 16810 on top and this patch -Go to a patron who has overdues -See the link "See highlighted items below" with a hand down icon -Look the new plus icon to "Add a new message" to the patron. -Add a few messages and notice about the trash icon in "Delete" links Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 19:12:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 17:12:58 +0000 Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 --- Comment #19 from Jesse Weaver --- I was poking at this, and one issue with moving those sysprefs is that the apache-*-plack.conf files are not .in files, so __MEMCACHED_NAMESPACE__ is not replaced in them. I could rejigger that, but any strenuous objections to leaving the RequestHeader lines where I currently have them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 19:13:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 17:13:41 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 19:25:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 17:25:51 +0000 Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 19:30:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 17:30:00 +0000 Subject: [Koha-bugs] [Bug 16605] All notices should give the ability to unsubscribe or flag account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16605 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 19:32:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 17:32:59 +0000 Subject: [Koha-bugs] [Bug 16623] Limit patron discharge management by library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16623 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 19:49:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 17:49:56 +0000 Subject: [Koha-bugs] [Bug 16863] New: Quotes around search term cause search failure if QueryAutoTruncate is not enabled. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16863 Bug ID: 16863 Summary: Quotes around search term cause search failure if QueryAutoTruncate is not enabled. Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The following search will succedd if the system preference 'quryautotruncate' is set to 'always' but will fail if set to 'only if * is added'. http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?q=%22The+Hobbit%22 This causes issues because call number links in the search results are quoted. To replicate: 1/ Set quryautotruncate to 'only if * is added'. 2/ Run a keyword search, with quotes around the title, e.g. "The Hobbit" Seearch will fail 3/ Set quryautotruncate to 'always' 4/ Re-run the same search. It will succeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 19:53:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 17:53:49 +0000 Subject: [Koha-bugs] [Bug 16863] Quotes around search term cause search failure if QueryAutoTruncate is not enabled. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16863 --- Comment #1 from Barton Chittenden --- Additional notes: Running zebrasrv using the options "-v none,fatal,warn,request? yielded the following warning for the search "FIC Grisham" when queryautotruncate was enabled: WARNING: query problem with (rk=( callnum,ext,r1=" FIC Grisham " or callnum,phr,r3=" FIC Grisham " or callnum,wrdl,r6=" FIC Grisham " or callnum,wrdl,fuzzy,r8=" FIC Grisham " or callnum,wrdl,rt,r9=""fic? grisham"? ")) ZOOM error 10014 "CCL parsing error" (addinfo: "Embedded truncation not supported") from diag-set 'ZOOM' at /usr/share/koha/lib/C4/Search.pm line 378. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 19:54:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 17:54:39 +0000 Subject: [Koha-bugs] [Bug 16863] Quotes around search term cause search failure if QueryAutoTruncate is not enabled. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16863 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 20:17:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 18:17:28 +0000 Subject: [Koha-bugs] [Bug 16864] New: Silence warnings in t/db_dependent/ILSDI_Services.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Bug ID: 16864 Summary: Silence warnings in t/db_dependent/ILSDI_Services.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: mtompset at hotmail.com Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com $cgi->param() is used in an ambiguous context, so it doesn't realize it should be scalar. Clarify the context while maintaining readability by novices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 20:21:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 18:21:00 +0000 Subject: [Koha-bugs] [Bug 16864] Silence warnings in t/db_dependent/ILSDI_Services.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 20:21:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 18:21:02 +0000 Subject: [Koha-bugs] [Bug 16864] Silence warnings in t/db_dependent/ILSDI_Services.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 --- Comment #1 from M. Tompsett --- Created attachment 53151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53151&action=edit Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t prove t/db_dependent/ILSDI_Services.t generates noisy output as a result of the ambiguous context of two $cgi->param() calls. By storing into scalar variables, and then using the scalar variables, the code maintains readability and fixes the problem. TEST PLAN --------- 1) prove t/db_dependent/ILSDI_Services.t -- noisy. 2) apply patch 3) prove t/db_dependent/ILSDI_Services.t -- not noisy 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 20:38:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 18:38:19 +0000 Subject: [Koha-bugs] [Bug 16865] New: marking branchcode unwanted breaks self registration Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 Bug ID: 16865 Summary: marking branchcode unwanted breaks self registration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If you add branchcode to PatronSelfRegistrationBorrowerUnwantedField then self registration fails silently. The library and the user have no idea what happened. We should have an error and/or not let branchcode be added to that preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 21:08:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 19:08:31 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 21:08:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 19:08:35 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53109|0 |1 is obsolete| | --- Comment #56 from Nick Clemens --- Created attachment 53152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53152&action=edit Bug 3534 - (QA Followup) Use single toolbar for regular/quickadd forms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 21:09:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 19:09:58 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #57 from Nick Clemens --- (In reply to Jonathan Druart from comment #55) > I think you should trick the code to have only 1 toolbar for the 2 forms. > You will need to add a flag to check, to know which form we want to save. Indeed, combined to one toolbar, removed 'onclick' action from regular save and redirected to a js function -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 21:19:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 19:19:48 +0000 Subject: [Koha-bugs] [Bug 16866] New: Catch warning t/db_dependent/Languages.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16866 Bug ID: 16866 Summary: Catch warning t/db_dependent/Languages.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: mtompset at hotmail.com Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com The C4::Languages::accept_language() call triggers a warning, which is uncaught. Catch it as a new test, so the output is cleaner. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 21:22:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 19:22:02 +0000 Subject: [Koha-bugs] [Bug 16866] Catch warning t/db_dependent/Languages.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16866 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 21:22:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 19:22:04 +0000 Subject: [Koha-bugs] [Bug 16866] Catch warning t/db_dependent/Languages.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16866 --- Comment #1 from M. Tompsett --- Created attachment 53153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53153&action=edit Bug 16866: Catch warning t/db_dependent/Languages.t TEST PLAN --------- 1) prove t/db_dependent/Languages.t -- noisy output 2) apply patch 3) prove t/db_dependent/Languages.t -- no noise 4) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 22:22:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 20:22:14 +0000 Subject: [Koha-bugs] [Bug 10492] Translation problems with TT directives in po files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10492 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16559 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 22:22:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 20:22:14 +0000 Subject: [Koha-bugs] [Bug 16559] [%% ... %%] should not be picked for translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16559 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10492 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 6 23:55:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 21:55:33 +0000 Subject: [Koha-bugs] [Bug 16867] New: Zebra works in marc21, but fails in unimarc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16867 Bug ID: 16867 Summary: Zebra works in marc21, but fails in unimarc Change sponsored?: --- Product: Koha Version: 16.05 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: petrus952 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hello, After a very long search I finally decide to ask for the help of the Koha community... To make it simple (more details below) : I have two VM with the same system (Debian 8) and the same Koha 16.06 (one is the clone of the other). The only difference : I chose marc21 during the webinstall of Koha on the first one and unimarc on the second one (for French cataloging). On the VM1 (marc21) the zebra indexing works (cmd for biblio : perl rebuild_zebra.pl -run-as-root -b -r -v). I can find my document in Opac. On the VM2 (unimarc) the zebra indexing fails with the following error : Zebraidx (3608) Record didn't countain match fields in (bib1, Local-number). Search in the catalog returns nothing. I already saw this type of error in other forums. But nothing helped me. I also tried on different systems and different Koha version (importing or creating records) and I always end up with the same error. Any ideas would be more than appreciated. For details, this is what I did : cd /usr/share/koha/bin/migration_tools export PERL5LIB=/usr/share/koha/lib/ export KOHA_CONF=/etc/koha/sites/labo8/koha-conf.xml perl rebuild_zebra.pl -run-as-root -b -r -v Here, the output of Zebra (on this case I have only one document on the database) : Zebra configuration information ================================ Zebra biblio directory = /var/lib/koha/labo8/biblios Zebra authorities directory = /var/lib/koha/labo8/authorities Koha directory = /usr/share/koha/intranet/cgi-bin Lockfile = /var/lock/koha/labo8/rebuild/rebuild..LCK BIBLIONUMBER in : 001$@ BIBLIOITEMNUMBER in : 090$a ================================ skipping authorities ==================== exporting biblio ==================== 1 Records exported: 1 ==================== REINDEXING zebra ==================== 21:03:11-06/07 zebraidx(3608) [warn] Record didn't contain match fields in (bib1,Local-number) ==================== CLEANING ==================== I already looked at different configuration files related to Zebra : - /etc/koha/koha-sites.conf was configured in marc21 (despite Koha webinstallation with unimarc option), changed to unimarc -> same error - in /etc/koha/sites/labo8/koha-conf.xml everything was in marc21 (despite Koha webinstallation with unimarc option), all changed to unimarc -> same error - /etc/koha/zebradb/retrieval-info-bib-dom.xml was in marc21, changed to unimarc -> same error - seems like zebra is using the /etc/koha/zebradb/marc_defs/marc21 folder and not the /etc/koha/zebradb/marc_defs/unimarc folder (I changed the name for testing) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 01:41:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jul 2016 23:41:41 +0000 Subject: [Koha-bugs] [Bug 9259] Delete marc batches from staged marc management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 --- Comment #15 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #14) > To enhance: > Maybe DeleteBatch should check if the batch has been cleaned before deleting > it. > I thought about this, but the DeleteBatch function can only be called if the status has been set to cleaned (the user can't see the button), so thought I could get away with skipping that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 03:17:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 01:17:28 +0000 Subject: [Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to additem.pl causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750 --- Comment #9 from Srdjan Jankovic --- Ah I see. I usually go for storing that in the session, but this is fine too. I'll let Kyle have a look, and then sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 03:19:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 01:19:57 +0000 Subject: [Koha-bugs] [Bug 16848] Wrong warning "Invalid date ... passed to output_pref" can be carped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16848 --- Comment #5 from Srdjan Jankovic --- Probably not that much, but I have a habit of doing that, I believe it is a good practice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 03:37:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 01:37:05 +0000 Subject: [Koha-bugs] [Bug 16868] New: Silence error t/db_dependent/Linker_FirstMatch.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868 Bug ID: 16868 Summary: Silence error t/db_dependent/Linker_FirstMatch.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: mtompset at hotmail.com Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com When the auth_header table has records which exclude 1xx and 2xx tags, the $bibfield doesn't match anything. This in turn sets it to undef, which triggers an error on the next line killing the test. Solution: improve the SQL query so it will find the expected records, or not and properly skip tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 03:54:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 01:54:47 +0000 Subject: [Koha-bugs] [Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868 --- Comment #1 from M. Tompsett --- Created attachment 53154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53154&action=edit auth_header.sql My auth_header which triggered this problem. perhaps a: use koha_library; source auth_header.sql; might be useful for testing. Don't push anywhere! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 03:56:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 01:56:06 +0000 Subject: [Koha-bugs] [Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 03:56:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 01:56:08 +0000 Subject: [Koha-bugs] [Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868 --- Comment #2 from M. Tompsett --- Created attachment 53155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53155&action=edit Bug 16868: Silence error t/db_dependent/Linker_FirstMatch.t When the auth_header table has records which exclude 1xx and 2xx tags, the $bibfield doesn't match anything. This in turn sets it to undef, which triggers an error on the next line killing the test. LIMIT was removed as it is not necessary and is a MySQL-ism. Though this may slow down testing with huge auth_header files, it should not be significant. TEST PLAN --------- 1) back up DB 2) Make sure to add in some authority records. 3) DELETE FROM auth_header WHERE marcxml LIKE '%datafield tag="1%'; DELETE FROM auth_header WHERE marcxml LIKE '%datafield tag="2%'; -- Now the test should blow up nicely. -- If you find you have no records, add more such that you repeat steps 2 and 3 and still have records in auth_header. Sorry, getting the trigger data is the hard part. 4) prove t/db_dependent/Linker_FirstMatch.t -- should barf before running all the tests 5) apply patch 6) prove t/db_dependent/Linker_FirstMatch.t -- should have pretty skip message(s) 7) run koha qa test tools 8) restore your backup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 05:00:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 03:00:52 +0000 Subject: [Koha-bugs] [Bug 16859] Fix wrong item field name in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16859 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 05:00:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 03:00:55 +0000 Subject: [Koha-bugs] [Bug 16859] Fix wrong item field name in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16859 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53130|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic --- Created attachment 53156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53156&action=edit [SIGNED-OFF] Bug 16859: Fix wrong item field name in export.pl Field callnumber should be itemcallnumber. For completeness, prefixing the joined fields with items table prefix. Note: You should expect Tools/Export to export only the items within a given itemcallnumber range, but if the biblio has one item in that range, the biblionumber is selected for export with ALL items. The script is designed that way (first select biblio numbers based on criteria, and run export with those biblio numbers). Test plan: [1] Select a biblio N with one item with say itemcallnumber X. [2] Goto Tools/Export. Select biblio range N,N and no itemcallnumber range. The biblio should be exported. [3] Select biblio range N,N and itemcallnumber range A,B. No output. [4] Select biblio range N,N and itemcallnumber range A,. Output. [5] Select biblio range N,N and itemcallnumber range ,X. Output. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 05:07:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 03:07:42 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #4 from Srdjan Jankovic --- I think this needs an additional level of indentation, and maybe a comment at the [% END %] , just to mark what is being closed, because it is far away. Also, I prefer [% IF something %] [% ELSE %] rather than [% IF !something %] [% ELSE %], but that's not that important. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 05:19:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 03:19:05 +0000 Subject: [Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 05:19:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 03:19:14 +0000 Subject: [Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51186|0 |1 is obsolete| | --- Comment #12 from Srdjan Jankovic --- Created attachment 53157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53157&action=edit [SIGNED-OFF] Bug 15636 - DataTables Warning: Requested unknown parameter from opac-detail.tt Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 05:27:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 03:27:36 +0000 Subject: [Koha-bugs] [Bug 16857] patron-attr-types.tt: Get rid of warnings "Argument "" isn' t numeric" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16857 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 05:27:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 03:27:39 +0000 Subject: [Koha-bugs] [Bug 16857] patron-attr-types.tt: Get rid of warnings "Argument "" isn' t numeric" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16857 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53123|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 53158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53158&action=edit [SIGNED-OFF] Bug 16857 - patron-attr-types.tt: Get rid of warnings "Argument "" isn't numeric" To vrify: - Go to Home > Administration > Patron attribute types - Make sure you have some patron attribute types with no branches limitation - For each attribute type you get a warning in intranet-error.log: patron-attr-types.pl: Argument "" isn't numeric in numeric gt (>) at (...)/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt line 284. To test: - Appy patch - Verify that warnings no longer appear in intranet-error.log Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 05:32:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 03:32:58 +0000 Subject: [Koha-bugs] [Bug 16823] Comment out koha-rebuild-zebra in debian/koha-common.cron.d In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16823 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 05:33:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 03:33:01 +0000 Subject: [Koha-bugs] [Bug 16823] Comment out koha-rebuild-zebra in debian/koha-common.cron.d In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16823 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52912|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 53159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53159&action=edit [SIGNED-OFF] Bug 16823 - Comment out koha-rebuild-zebra in koha-common.cron.d Bug 16190 enabled the indexer daemon by default for package installations. This means that it is no longer necessary to set up koha-rebuild-zebra as a cron job. This patch comments it out, so that people who might run into bug 16814 can easily activate the cronjob again after de-activating the indexer daemon. To test: Just read the diff and check that it makes sense. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 08:34:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 06:34:19 +0000 Subject: [Koha-bugs] [Bug 8846] t/SuggestionEngine_ExplodedTerms.t sneakily uses database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8846 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16869 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 08:34:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 06:34:19 +0000 Subject: [Koha-bugs] [Bug 16869] New: Silence and catch warnings in t/db_dependent/ SuggestionEngine_ExplodedTerms.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16869 Bug ID: 16869 Summary: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: mtompset at hotmail.com Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com The warnings are triggered by a lack of opachtdocs, as the current mock function returns '', cascading C4::Template::themelanguage to fall through with no explicit return (turns out to be treated like '',undef,undef). This in turn sets the preferredtheme and lang to undef, which triggers the use of uninitialized values warning. While trying to figure out the best way to fix this, bug 8846 was discovered. Attempting to unset $KOHA_CONF triggers warnings, because of the "use C4::Context;" in C4::Languages and C4::Templates. prove t/db_dependent/SuggestionEngine_ExplodedTerms.t can reproduce the noise easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 08:36:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 06:36:30 +0000 Subject: [Koha-bugs] [Bug 16645] Plack: Add the multi_param fix from Context in koha.psgi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 --- Comment #4 from Marcel de Rooy --- (In reply to Fridolin SOMERS from comment #2) > Hie, > > I'd say it depends on Bug 15809 directly no ? Yes it does. But that has been pushed some time ago already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 08:39:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 06:39:56 +0000 Subject: [Koha-bugs] [Bug 16869] Silence and catch warnings in t/db_dependent/ SuggestionEngine_ExplodedTerms.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16869 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 08:39:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 06:39:58 +0000 Subject: [Koha-bugs] [Bug 16869] Silence and catch warnings in t/db_dependent/ SuggestionEngine_ExplodedTerms.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16869 --- Comment #1 from M. Tompsett --- Created attachment 53160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53160&action=edit Bug 16869: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t By properly defining a opachtdocs (intranethtdocs was done too) in the mock function, uninitialized variable warnings are eliminated. Given that we can check if $KOHA_CONF is defined or not, we can catch the warning as part of testing, so the output of the test is cleaner. TEST PLAN --------- 1) unset KOHA_CONF 2) prove t/db_dependent/SuggestionEngine_ExplodedTerms.t -- lots of noise 3) apply patch 4) prove t/db_dependent/SuggestionEngine_ExplodedTerms.t -- no noise 5) prove -v t/db_dependent/SuggestionEngine_ExplodedTerms.t -- see the warnings were caught and not just ignored. 6) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 08:46:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 06:46:29 +0000 Subject: [Koha-bugs] [Bug 16645] Plack: Add the multi_param fix from Context in koha.psgi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 --- Comment #5 from Marcel de Rooy --- (In reply to Fridolin SOMERS from comment #3) > + no warnings 'redefine'; > This is already set a few lines above. > No ? > > + use warnings 'redefine'; > sure we need this line ? No warnings was repeated. Will remove it and move the enable warns one level higher outside the if statement. It is better to add it. Only allow redefines without warnings within the section you have explicitly marked as such. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 08:47:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 06:47:05 +0000 Subject: [Koha-bugs] [Bug 16645] Plack: Add the multi_param fix from Context in koha.psgi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51985|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 53161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53161&action=edit Bug 16645: Plack: Add the multi_param fix from Context in koha.psgi When you are running koha.psgi (under Wheezy with an older CGI), you will crash on multi_param calls (e.g. when searching in opac). This patch simply copies the fix from Context to koha.psgi. Test plan: Run Plack with koha.psgi and test searching in opac. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 09:12:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 07:12:43 +0000 Subject: [Koha-bugs] [Bug 16690] Installing DB on remote server fails without *.* permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 --- Comment #3 from M. Tompsett --- Created attachment 53162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53162&action=edit Bug 16690: Follow up etc/koha-conf.xml As per Fr?d?ric Demians feedback in comment #2, made same changes to etc/koha-conf.xml as was made to debian/templates/koha-conf-site.xml.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 09:15:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 07:15:35 +0000 Subject: [Koha-bugs] [Bug 16645] Plack: Add the multi_param fix from Context in koha.psgi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 --- Comment #7 from Fridolin SOMERS --- Note that debian scripts work with plack only since jessie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 09:16:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 07:16:07 +0000 Subject: [Koha-bugs] [Bug 16645] Plack: Add the multi_param fix from Context in koha.psgi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16644 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 09:16:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 07:16:07 +0000 Subject: [Koha-bugs] [Bug 16644] Plack: Use to_app to remove warning about Plack::App:: CGIBin instance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16644 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16645 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 09:16:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 07:16:36 +0000 Subject: [Koha-bugs] [Bug 16645] Plack: Add the multi_param fix from Context in koha.psgi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|16644 |15809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 [Bug 15809] versions of CGI < 4.08 do not have multi_param https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16644 [Bug 16644] Plack: Use to_app to remove warning about Plack::App::CGIBin instance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 09:16:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 07:16:36 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16645 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 [Bug 16645] Plack: Add the multi_param fix from Context in koha.psgi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 09:16:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 07:16:36 +0000 Subject: [Koha-bugs] [Bug 16644] Plack: Use to_app to remove warning about Plack::App:: CGIBin instance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16644 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|16645 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 [Bug 16645] Plack: Add the multi_param fix from Context in koha.psgi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 09:16:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 07:16:49 +0000 Subject: [Koha-bugs] [Bug 16645] Plack: Add the multi_param fix from Context in koha.psgi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15809 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 09:16:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 07:16:49 +0000 Subject: [Koha-bugs] [Bug 15809] versions of CGI < 4.08 do not have multi_param In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16645 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 09:57:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 07:57:20 +0000 Subject: [Koha-bugs] [Bug 16645] Plack: Add the multi_param fix from Context in koha.psgi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 --- Comment #8 from Fridolin SOMERS --- I'm testing : With the patch I get this warn : Subroutine _input_cgi_parse redefined at /home/koha/src/opac/opac-search.pl line 527. Is it plack-specific ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 11:22:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 09:22:50 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 --- Comment #5 from Marc V?ron --- (In reply to Srdjan Jankovic from comment #4) > I think this needs an additional level of indentation, and maybe a comment > at the [% END %] , just to mark what is being closed, because it is far away. > Also, I prefer [% IF something %] [% ELSE %] rather than [% IF !something %] > [% ELSE %], but that's not that important. Hi Srdjan, thanks for testing. I'll change the strategy for this, patch follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 11:28:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 09:28:28 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 --- Comment #6 from Marc V?ron --- Created attachment 53163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53163&action=edit Bug 16682: Fix display if Batch patron modification tool does not get any patrons To reproduce: - Go to Tools->Batch patron modification - Submit without filling any of "Use a file", "Or use a patron list", "Or list card numbers..." or use a patron lists with zero members Result: Screen without any information To test: - Apply patch - Repeat steps above - Verify that you get a nice message - Verify that the tool works as before - with invalid card numbers only - with valid and invalid card numbers - with valid card numbers only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 11:28:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 09:28:59 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53149|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 11:48:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 09:48:31 +0000 Subject: [Koha-bugs] [Bug 16867] Zebra works in marc21, but fails in unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16867 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Zeno Tajoli --- Hi, this is the basic error: >I have two VM with the same system (Debian 8) and the same Koha 16.06 (one is >the clone of the other) You can't clone a marc21 Koha and do a web install with unimarc. The sistem doesn't work. You need to start an install from a fresch debian 8 and reintall koha-common package. Reading https://wiki.koha-community.org/wiki/Koha_on_Debian. After "sudo apt-get install koha-common" "vi /etc/koha/koha-sites.conf" and setup unimarc. After "sudo koha-create --create-db libraryname" Now you can do web install and you can choose 'unimarc'. If you want more info, writr to koha mailing-list https://lists.katipo.co.nz/mailman/listinfo/koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 12:00:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 10:00:44 +0000 Subject: [Koha-bugs] [Bug 16645] Plack: Add the multi_param fix from Context in koha.psgi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 --- Comment #9 from Marcel de Rooy --- (In reply to Fridolin SOMERS from comment #8) > I'm testing : > > With the patch I get this warn : > > Subroutine _input_cgi_parse redefined at /home/koha/src/opac/opac-search.pl > line 527. > > Is it plack-specific ? I am not seeing it in my log btw. How can I reproduce? Could be consequence of enabling the warnings again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 13:09:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 11:09:52 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 13:30:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 11:30:31 +0000 Subject: [Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.sassmannshausen at ptfs-e | |urope.com --- Comment #4 from Alex Sassmannshausen --- (In reply to Kyle M Hall from comment #1) > Created attachment 47740 [details] [review] > Bug 15759 - Allow Koha::Object derived objects to be used as hashrefs > > On occasion, bugs in Koha have been revealed to be a mis-use of > Koha::Object. This seems to be due to our long standing use of hashrefs > for data in Koha. > > For instance, a developer may accidentally write: > > my $borrowernumber = $borrower->{borrowernumber}; > > instead of > > my $borrowernumber = $borrower->borrowernumber; > > Since our object is a blessed hashref, this does not cause an error. > Instead, we just access that key of the hashref, which is almost > certainly undefined. I can see the problem here, but I am not sure about the proposed solution. I think the above should cause an error when it happens, rather than Koha trying to hide the error. > With some extra code in Koha/Object.pm, we can allow hashref-like use of > our Objects, which will not only prevent these errors, but allow drop-in > use of Koha::Objects where we currently use hashrefs! To aid code legibility, it makes sense IMHO, to be clear about what we are using. The proposed change, while convenient, would obscure. In terms of the conversion to Koha::Objects, I think it is better to continue trudging through refactoring as we go. It's work that needs to be done anyway, and this is a good opportunity! Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 15:23:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 13:23:34 +0000 Subject: [Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |m.de.rooy at rijksmuseum.nl Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 15:23:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 13:23:57 +0000 Subject: [Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38133|0 |1 is obsolete| | Attachment #42831|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 53164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53164&action=edit Bug 10407: Allow MARCXML records to be imported via GUI Patch from Olli, rebased by Marcel (July 7, 2016). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 15:24:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 13:24:02 +0000 Subject: [Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #15 from Marcel de Rooy --- Created attachment 53165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53165&action=edit Bug 10407: Add marcxml import to stage-marc-import script The previous patch did the groundwork, but did not yet add the call to RecordsFromMARCXMLFile. I will open a new report to add this to the interface, but in the meantime this patch just looks for a .xml extension in the filename. Also changed: [2] The errors of RecordsFromISO2709File are now returned to in array. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 15:24:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 13:24:23 +0000 Subject: [Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch --- Comment #16 from Marcel de Rooy --- Still working on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 15:37:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 13:37:07 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported via GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|allow MARCXML records to be |Allow MARCXML records to be |imported via Koha's GUI |imported via GUI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 15:47:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 13:47:35 +0000 Subject: [Koha-bugs] [Bug 16559] [%% ... %%] should not be picked for translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16559 --- Comment #4 from Marc V?ron --- (In reply to Jonathan Druart from comment #3) > No idea, did you try it? I did try now - and no way, to much side effects. I think we have to fix the line splitted TT directives. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 15:48:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 13:48:40 +0000 Subject: [Koha-bugs] [Bug 16866] Catch warning t/db_dependent/Languages.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16866 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53153|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 53166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53166&action=edit [SIGNED-OFF]Bug 16866: Catch warning t/db_dependent/Languages.t TEST PLAN --------- 1) prove t/db_dependent/Languages.t -- noisy output 2) apply patch 3) prove t/db_dependent/Languages.t -- no noise 4) run koha qa test tools. Signed-off-by: Hector Castro No noisy output -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 15:49:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 13:49:20 +0000 Subject: [Koha-bugs] [Bug 16866] Catch warning t/db_dependent/Languages.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16866 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 15:53:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 13:53:43 +0000 Subject: [Koha-bugs] [Bug 16860] Catch warning t/db_dependent/ClassSource.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53141|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 53167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53167&action=edit [SIGNED-OFF]Bug 16860: Catch warning t/db_dependent/ClassSource.t $ prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 3/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.66 cusr 0.02 csys = 0.70 CPU) Result: PASS The above warning might be scary to those unfamiliar with the test. Add a test to catch the warning. TEST PLAN --------- 1) prove t/db_dependent/ClassSource.t -- as above 2) apply patch 3) prove t/db_dependent/ClassSource.t -- no message 4) prove -v t/db_dependent/ClassSource.t -- test 13 is the new test 5) run koha qa test tools Signed-off-by: Hector Castro Workas as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 15:54:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 13:54:04 +0000 Subject: [Koha-bugs] [Bug 16860] Catch warning t/db_dependent/ClassSource.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 15:57:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 13:57:50 +0000 Subject: [Koha-bugs] [Bug 16869] Silence and catch warnings in t/db_dependent/ SuggestionEngine_ExplodedTerms.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16869 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53160|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 53168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53168&action=edit [SIGNED-OFF]Bug 16869: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t By properly defining a opachtdocs (intranethtdocs was done too) in the mock function, uninitialized variable warnings are eliminated. Given that we can check if $KOHA_CONF is defined or not, we can catch the warning as part of testing, so the output of the test is cleaner. TEST PLAN --------- 1) unset KOHA_CONF 2) prove t/db_dependent/SuggestionEngine_ExplodedTerms.t -- lots of noise 3) apply patch 4) prove t/db_dependent/SuggestionEngine_ExplodedTerms.t -- no noise 5) prove -v t/db_dependent/SuggestionEngine_ExplodedTerms.t -- see the warnings were caught and not just ignored. 6) run koha qa test tools Signed-off-by: Hector Castro No warnings. Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 15:58:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 13:58:02 +0000 Subject: [Koha-bugs] [Bug 16869] Silence and catch warnings in t/db_dependent/ SuggestionEngine_ExplodedTerms.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16869 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:02:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:02:21 +0000 Subject: [Koha-bugs] [Bug 15759] Allow Koha::Object derived objects to be used as hashrefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:09:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:09:14 +0000 Subject: [Koha-bugs] [Bug 16869] Silence and catch warnings in t/db_dependent/ SuggestionEngine_ExplodedTerms.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16869 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:09:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:09:16 +0000 Subject: [Koha-bugs] [Bug 16869] Silence and catch warnings in t/db_dependent/ SuggestionEngine_ExplodedTerms.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16869 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53168|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 53169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53169&action=edit Bug 16869: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t By properly defining a opachtdocs (intranethtdocs was done too) in the mock function, uninitialized variable warnings are eliminated. Given that we can check if $KOHA_CONF is defined or not, we can catch the warning as part of testing, so the output of the test is cleaner. TEST PLAN --------- 1) unset KOHA_CONF 2) prove t/db_dependent/SuggestionEngine_ExplodedTerms.t -- lots of noise 3) apply patch 4) prove t/db_dependent/SuggestionEngine_ExplodedTerms.t -- no noise 5) prove -v t/db_dependent/SuggestionEngine_ExplodedTerms.t -- see the warnings were caught and not just ignored. 6) run koha qa test tools Signed-off-by: Hector Castro No warnings. Works as advertised Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:14:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:14:54 +0000 Subject: [Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to additem.pl causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750 --- Comment #10 from Kyle M Hall --- (In reply to Jonathan Druart from comment #8) > (In reply to Srdjan Jankovic from comment #7) > > Jonathan, maybe a silly question: wouldn't it be better to get referer from > > the header in selectbranchprinter.pl? > > It's what does the current code, but the HTTP_REFERER does not contain the > POST params. > But actually I am not sure it's a good idea: with this patch the form will > be submitted again and the item will be saved a second time. I think the creation of the extra item is blocker for your alternative patch. If you can find a way to avoid that I'd be happy to sign yours. Otherwise my patch, though a more specific case, is safer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:21:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:21:49 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:21:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:21:52 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53150|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 53170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53170&action=edit Bug 16861: Translatability: Fix separated "below" in circulation.tt This patch propose to fix this two entries in PO files: "See highlighted items" and "below" Also add some Font Awesome Icons To test: -Apply patch 16810 on top and this patch -Go to a patron who has overdues -See the link "See highlighted items below" with a hand down icon -Look the new plus icon to "Add a new message" to the patron. -Add a few messages and notice about the trash icon in "Delete" links Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:22:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:22:08 +0000 Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686 --- Comment #16 from Kyle M Hall --- (In reply to Jonathan Druart from comment #14) > Kyle, could you have a look at this counter-patch? > It seems easier to use the DBIC relationship than to create 3 new methods. While I agree, I think it adds confusion. The method name 'transfer' is a verb, so it sounds like you would call $item->transfer() to initiate a transfer. Can you change the method name to get_latest_transfer or something like that? I'm also a bit reticent about having a Koha Object return a DBIC object. Would you create Koha::Item::Transfer(s) and return that? It would also avoid a second db query just to get the branch name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:26:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:26:05 +0000 Subject: [Koha-bugs] [Bug 16870] New: Koha::Issue(s) should be named Koha::Checkout(s) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870 Bug ID: 16870 Summary: Koha::Issue(s) should be named Koha::Checkout(s) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com By our naming guidelines, the term "issue" is deprecated in favor of "checkout". We should update the class names to match. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:26:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:26:09 +0000 Subject: [Koha-bugs] [Bug 16086] Add Koha::Issue objects. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870 [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:26:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:26:09 +0000 Subject: [Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16086 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16086 [Bug 16086] Add Koha::Issue objects. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:26:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:26:57 +0000 Subject: [Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:26:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:26:57 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870 [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:27:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:27:15 +0000 Subject: [Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6906 Blocks|6906 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:27:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:27:15 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16870 Depends on|16870 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870 [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:27:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:27:19 +0000 Subject: [Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:40:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:40:38 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:40:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:40:42 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52934|0 |1 is obsolete| | Attachment #52935|0 |1 is obsolete| | Attachment #52936|0 |1 is obsolete| | Attachment #52937|0 |1 is obsolete| | Attachment #53152|0 |1 is obsolete| | --- Comment #58 from Jonathan Druart --- Created attachment 53171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53171&action=edit Bug 3534 - Patron quick add form This patch adds a new system preference: PatronQuickAddFields When either this pref or BorrowerMandatoryField is populated this will add a new dropdown to the bew patron toolbar. When a category is chosen from this dropdown the fields in PatronQuickAddFields and BorrowerMandatoryField will be displayed. There will be a button allowing a user to switch from the quickadd to the full form and fields will be copied between the forms when toggling. The Quick add will only be displayed on add of a new patron, future edits should display the full form. Test plan: 1 - Apply patch 2 - run updatedatabase.pl 3 - Add a new patron and ensure nothing has changed 4 - Populate either PatronQuickAddFields or BorrowerMandatory fields and note the new button for adding a patron 5 - Click the Quick add and choose a type 6 - Only required or quick add fields should be displayed 7 - Verify toggling forms copies information 8 - Ensure you cannot save patron without filling required fields (quick add fields should be optional) 9 - Ensure you can save patron with fields filled out 10 - Ensure that a duplicate patron brings up the duplicate/add new buttons with full form displayed 11 - Verify that subsequent edits use only full form 12 - Verify that data on form submitted is the data saved to patron 13 - Test with various values in both MandatoryBorrowerFields and PatronQuickAddFields Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries) Followed test plan, works as expected. Re-tested together with followup, works as expected (2016-06-02) Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:40:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:40:47 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #59 from Jonathan Druart --- Created attachment 53172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53172&action=edit Bug 3534 - QA Followup - use floating save I am not sure if this is desired, it makes sense for consistency but floats in a wierd place for a short form. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:40:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:40:53 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #60 from Jonathan Druart --- Created attachment 53173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53173&action=edit Bug 3534 (QA Followup) Fix indentation, show guarantor form, ignore bad data in pref Switch incorrect == to != when checking skipped fields Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:40:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:40:57 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #61 from Jonathan Druart --- Created attachment 53174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53174&action=edit Bug 3534 (QA Followup) Rebase and change floating save Bug 3534 - (QA Followup) Use single toolbar for regular/quickadd forms Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:41:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:41:02 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #62 from Jonathan Druart --- Created attachment 53175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53175&action=edit Bug 3534: Force margin-left: 0 for second button When quick adding a new patron, both button are in the DOM and the second button has a margin-left (from .btn-toolbar > .btn + .btn). This patch force the margin-left to 0 to avoid the button to move when toggling them. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:41:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:41:24 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #63 from Jonathan Druart --- I have squashed 2 patches for the readability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:46:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:46:10 +0000 Subject: [Koha-bugs] [Bug 16859] Fix wrong item field name in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:46:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:46:13 +0000 Subject: [Koha-bugs] [Bug 16859] Fix wrong item field name in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53156|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 53176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53176&action=edit Bug 16859: Fix wrong item field name in export.pl Field callnumber should be itemcallnumber. For completeness, prefixing the joined fields with items table prefix. Note: You should expect Tools/Export to export only the items within a given itemcallnumber range, but if the biblio has one item in that range, the biblionumber is selected for export with ALL items. The script is designed that way (first select biblio numbers based on criteria, and run export with those biblio numbers). Test plan: [1] Select a biblio N with one item with say itemcallnumber X. [2] Goto Tools/Export. Select biblio range N,N and no itemcallnumber range. The biblio should be exported. [3] Select biblio range N,N and itemcallnumber range A,B. No output. [4] Select biblio range N,N and itemcallnumber range A,. Output. [5] Select biblio range N,N and itemcallnumber range ,X. Output. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:46:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:46:33 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the catalogue export tool (command-line tools/ export.pl does not work anymore. Use misc/export_records.pl instead) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16859 [Bug 16859] Fix wrong item field name in export.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:46:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:46:33 +0000 Subject: [Koha-bugs] [Bug 16859] Fix wrong item field name in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |14722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 [Bug 14722] Refactor the catalogue export tool (command-line tools/export.pl does not work anymore. Use misc/export_records.pl instead) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:54:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:54:59 +0000 Subject: [Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 16:55:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 14:55:03 +0000 Subject: [Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53157|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 53177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53177&action=edit Bug 15636 - DataTables Warning: Requested unknown parameter from opac-detail.tt Signed-off-by: Srdjan Signed-off-by: Jonathan Druart This patch adds the same tests in the aoColumns DT definition than the ones in the creation of the table. That's sound good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:25:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:25:39 +0000 Subject: [Koha-bugs] [Bug 16871] New: Translatability: Avoid [ %%-problem fix related sentence splitting in catalogue/detail.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Bug ID: 16871 Summary: Translatability: Avoid [%%-problem fix related sentence splitting in catalogue/detail.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt, fix line splitted TT directives and sentence splitting leading to translatability problems with following, errorprone monster: %s %s at%sfor delivery at %s %s %s since %s %s %s (placed %s) %s %s %s [%% UNLESS ( item.itemnotforloan or item.notforloan_per_itemtype or item.onloan or item.itemlost or item.withdrawn or item.damaged or item.transfertwhen or item.reservedate ) %%] Available %s %s -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:26:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:26:07 +0000 Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix related sentence splitting in catalogue/detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability: Avoid |Translatability: Avoid |[%%-problem fix related |[%%-problem and fix related |sentence splitting in |sentence splitting in |catalogue/detail.tt |catalogue/detail.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:28:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:28:37 +0000 Subject: [Koha-bugs] [Bug 16701] Translatability: Fix problem with isolated ' in currency.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16701 --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 53178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53178&action=edit Bug 16701: (follow-up) improve some changes Add missing quote in line 152 Modify title of the page and breadcrumbs section wrong "searchfield" used should be instead "currency.currency" To test -Try to delete the active and used currency, for example, my case USD, look that appear USD' with the initial single quote missing in message Confirm deletion of currency USD' -Notice about the breadcrumbs section appear: Confirm deletion of currency '' Should appear the currency -Try to delete another currency see the pharese look the same -Notice about the title in both cases, there is missing the currency name -Apply follow-up and re-test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:29:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:29:19 +0000 Subject: [Koha-bugs] [Bug 16559] [%% ... %%] should not be picked for translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16559 --- Comment #5 from Jonathan Druart --- (In reply to Marc V?ron from comment #4) > (In reply to Jonathan Druart from comment #3) > > No idea, did you try it? > > I did try now - and no way, to much side effects. > > I think we have to fix the line splitted TT directives. Yes but there are lot of them and not so easy to fix IIRC :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:31:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:31:30 +0000 Subject: [Koha-bugs] [Bug 16701] Translatability: Fix problem with isolated ' in currency.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16701 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52635|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 53179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53179&action=edit [SIGNED-OFF]Bug 16701: Translatability: Fix problem with isolated ' in currency.tt This patch moves markup into template variables to avoid sentence splitting. To test: - Apply patch - Verify that currency administration works as before (Home > Administration > Currencies & Exchange rates > Currencies) - Examine code changes Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:31:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:31:42 +0000 Subject: [Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to additem.pl causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750 --- Comment #11 from Jonathan Druart --- The problem with your patch is that it will only fix 1 page whereas we have plenty of others with the same issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:32:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:32:38 +0000 Subject: [Koha-bugs] [Bug 16701] Translatability: Fix problem with isolated ' in currency.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16701 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #5 from H?ctor Eduardo Castro Avalos --- Hi Marc Please, test the follow-up and sign-off :) Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:36:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:36:13 +0000 Subject: [Koha-bugs] [Bug 16701] Translatability: Fix problem with isolated ' in currency.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16701 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53178|0 |1 is obsolete| | --- Comment #6 from H?ctor Eduardo Castro Avalos --- Created attachment 53180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53180&action=edit Bug 16701: (follow-up) improve some changes Add missing quote in line 152 Modify title of the page and breadcrumbs section wrong "searchfield" used should be instead "currency.currency" To test -Try to delete the active and used currency, for example, my case USD, look that appear USD' with the initial single quote missing in message Confirm deletion of currency USD' -Notice about the breadcrumbs section appear: Confirm deletion of currency '' Should appear the currency -Try to delete another currency see the pharese look the same -Notice about the title in both cases, there is missing the currency name -Apply follow-up and re-test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:42:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:42:55 +0000 Subject: [Koha-bugs] [Bug 16857] patron-attr-types.tt: Get rid of warnings "Argument "" isn' t numeric" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:42:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:42:58 +0000 Subject: [Koha-bugs] [Bug 16857] patron-attr-types.tt: Get rid of warnings "Argument "" isn' t numeric" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53158|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53181&action=edit Bug 16857 - patron-attr-types.tt: Get rid of warnings "Argument "" isn't numeric" To vrify: - Go to Home > Administration > Patron attribute types - Make sure you have some patron attribute types with no branches limitation - For each attribute type you get a warning in intranet-error.log: patron-attr-types.pl: Argument "" isn't numeric in numeric gt (>) at (...)/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt line 284. To test: - Appy patch - Verify that warnings no longer appear in intranet-error.log Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:43:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:43:07 +0000 Subject: [Koha-bugs] [Bug 16857] patron-attr-types.tt: Get rid of warnings "Argument "" isn' t numeric" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16857 --- Comment #4 from Jonathan Druart --- Created attachment 53182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53182&action=edit Bug 16857: Check on item.branches makes more sense The test should be on the existence of the item.branches method/attribute Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:46:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:46:11 +0000 Subject: [Koha-bugs] [Bug 16823] Comment out koha-rebuild-zebra in debian/koha-common.cron.d In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16823 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:46:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:46:14 +0000 Subject: [Koha-bugs] [Bug 16823] Comment out koha-rebuild-zebra in debian/koha-common.cron.d In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16823 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53159|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53183&action=edit Bug 16823 - Comment out koha-rebuild-zebra in koha-common.cron.d Bug 16190 enabled the indexer daemon by default for package installations. This means that it is no longer necessary to set up koha-rebuild-zebra as a cron job. This patch comments it out, so that people who might run into bug 16814 can easily activate the cronjob again after de-activating the indexer daemon. To test: Just read the diff and check that it makes sense. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:47:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:47:08 +0000 Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix related sentence splitting in catalogue/detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:48:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:48:08 +0000 Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix related sentence splitting in catalogue/detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 --- Comment #1 from Marc V?ron --- Created attachment 53184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53184&action=edit Bug 16871 - Translatability: Avoid [%%-problem and fix related sentence splitting in catalogue/detail.tt In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt, fix line splitted TT directives and sentence splitting leading to translatability problems. (See first comment). To test: - Apply patch - Go to detail pages of biblios with waiting holds - Verify that messages in column 'Status' are OK - Examine code in patch to make sure that the simplification in logic makes sense and that no TT directive is splitted - Bonus test: - Go to folder misc/translator. Run perl translate create xx-XX - Verify that monster mentioned in first comment no longer exists (in po/xx-XX-staff-prog.po) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:48:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:48:30 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #5 from Jonathan Druart --- H?ctor, I have asked Owen (on #koha) if he agrees on the fa-hand-o-down icon and he does not :) Could you please remove it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:48:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:48:49 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53150|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:48:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:48:54 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53170|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:49:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:49:57 +0000 Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix related sentence splitting in catalogue/detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16559 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:49:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:49:57 +0000 Subject: [Koha-bugs] [Bug 16559] [%% ... %%] should not be picked for translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16559 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16871 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:50:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:50:19 +0000 Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix related sentence splitting in catalogue/detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10492 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:50:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:50:19 +0000 Subject: [Koha-bugs] [Bug 10492] Translation problems with TT directives in po files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10492 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16871 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:50:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:50:34 +0000 Subject: [Koha-bugs] [Bug 16866] Catch warning t/db_dependent/Languages.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16866 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:50:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:50:36 +0000 Subject: [Koha-bugs] [Bug 16866] Catch warning t/db_dependent/Languages.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16866 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53166|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53185&action=edit Bug 16866: Catch warning t/db_dependent/Languages.t TEST PLAN --------- 1) prove t/db_dependent/Languages.t -- noisy output 2) apply patch 3) prove t/db_dependent/Languages.t -- no noise 4) run koha qa test tools. Signed-off-by: Hector Castro No noisy output Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:52:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:52:58 +0000 Subject: [Koha-bugs] [Bug 16860] Catch warning t/db_dependent/ClassSource.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:53:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:53:01 +0000 Subject: [Koha-bugs] [Bug 16860] Catch warning t/db_dependent/ClassSource.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53167|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53186&action=edit Bug 16860: Catch warning t/db_dependent/ClassSource.t $ prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 3/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.66 cusr 0.02 csys = 0.70 CPU) Result: PASS The above warning might be scary to those unfamiliar with the test. Add a test to catch the warning. TEST PLAN --------- 1) prove t/db_dependent/ClassSource.t -- as above 2) apply patch 3) prove t/db_dependent/ClassSource.t -- no message 4) prove -v t/db_dependent/ClassSource.t -- test 13 is the new test 5) run koha qa test tools Signed-off-by: Hector Castro Workas as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 17:53:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 15:53:04 +0000 Subject: [Koha-bugs] [Bug 16860] Catch warning t/db_dependent/ClassSource.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 --- Comment #4 from Jonathan Druart --- Created attachment 53187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53187&action=edit Bug 16860: Remove the comment about the warning It is no longer necessary. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 18:14:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 16:14:57 +0000 Subject: [Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 18:14:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 16:14:59 +0000 Subject: [Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870 --- Comment #1 from Kyle M Hall --- Created attachment 53188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53188&action=edit Bug 16870 - Move and rename class files and unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 18:16:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 16:16:28 +0000 Subject: [Koha-bugs] [Bug 16870] Koha::Issue(s) should be named Koha::Checkout(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16870 --- Comment #2 from Kyle M Hall --- Created attachment 53189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53189&action=edit Bug 16870 - Update Koha::Patron use of the class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Patron/Borrower_PrevCheckout.t 3) prove t/db_dependent/Koha/Checkouts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 18:20:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 16:20:27 +0000 Subject: [Koha-bugs] [Bug 16559] [%% ... %%] should not be picked for translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16559 --- Comment #6 from Marc V?ron --- (In reply to Jonathan Druart from comment #5) > (In reply to Marc V?ron from comment #4) > > (In reply to Jonathan Druart from comment #3) > > > No idea, did you try it? > > > > I did try now - and no way, to much side effects. > > > > I think we have to fix the line splitted TT directives. > > Yes but there are lot of them and not so easy to fix IIRC :) I mistaked in my first comment, if I do a search for [%% with exact match in koha translate I get 24 occurences. Examine them reveals some other translation issues anyway, see Bug 16871 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 18:23:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 16:23:05 +0000 Subject: [Koha-bugs] [Bug 16872] New: You should not be allowed to deleted a record with open orders attached Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16872 Bug ID: 16872 Summary: You should not be allowed to deleted a record with open orders attached Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 10869 and Bug 10758 try to deal with the fallout from deleting a record with an order attached. I think, rather than fixing the order end we should prevent the deletion of the record in the first place to avoid causing an issue. This case also affects EDI ordering as item cannot be received when a title has been deleted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 18:23:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 16:23:21 +0000 Subject: [Koha-bugs] [Bug 16872] You should not be allowed to deleted a record with open orders attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16872 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 18:40:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 16:40:10 +0000 Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 19:21:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 17:21:26 +0000 Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53050|0 |1 is obsolete| | Attachment #53053|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 53190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53190&action=edit Bug 16686: Rename the transfer method to get_transfer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 19:21:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 17:21:32 +0000 Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686 --- Comment #18 from Jonathan Druart --- Created attachment 53191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53191&action=edit Bug 16686: Add Koha::Object based class for Koha::Item::Transfer[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 19:21:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 17:21:36 +0000 Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686 --- Comment #19 from Jonathan Druart --- Created attachment 53192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53192&action=edit Bug 16686: Add test for Koha::Item::Transfer[s] and Koha::Item->get_transfer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 19:23:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 17:23:26 +0000 Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686 --- Comment #20 from Jonathan Druart --- (In reply to Kyle M Hall from comment #16) > (In reply to Jonathan Druart from comment #14) > > Kyle, could you have a look at this counter-patch? > > It seems easier to use the DBIC relationship than to create 3 new methods. > > While I agree, I think it adds confusion. The method name 'transfer' is a > verb, so it sounds like you would call $item->transfer() to initiate a > transfer. Can you change the method name to get_latest_transfer or something > like that? Indeed, good idea! I have chosen "get_transfer" which returns the current transfer, or undef if the item is not in transit. > I'm also a bit reticent about having a Koha Object return a DBIC object. > Would you create Koha::Item::Transfer(s) and return that? It would also > avoid a second db query just to get the branch name. Done, but I am not sure to understand how it will avoid the second query. I now use the Branches TT plugin to retrieve the branch name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 20:08:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 18:08:32 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 20:08:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 18:08:35 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 --- Comment #6 from H?ctor Eduardo Castro Avalos --- Created attachment 53193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53193&action=edit Bug 16861: (followup)Translatability: remove fa-hand-o-down icon Remove fa-hand-o-down icon accoring with QA comment 5 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 20:22:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 18:22:45 +0000 Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #23 from Nick Clemens --- The ByWater plugin actually can automatically update the covers used. It uses a public report, chosen in config, so updates whenever the cache expires. I would like to see this option remain as we have many users basing their reports on time or specific item types or collection codes, or pointing the report to a list they can individually and and remove titles from. More flexibility is often better :-) The coverflow plugin is currently tied to amazon covers and generates the links statically: I would second the use of Flipster since it has a few different config options available (coverflow, carousel, flat) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 20:38:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 18:38:10 +0000 Subject: [Koha-bugs] [Bug 3534] Patron quick add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #64 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 20:53:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 18:53:10 +0000 Subject: [Koha-bugs] [Bug 16867] Zebra works in marc21, but fails in unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16867 --- Comment #2 from petrus952 at gmail.com --- Zeno, It works ! My mistake : I set /etc/koha/koha-sites.conf to unimarc after creating the database (koha-create --create-db libraryname). It has to be done just after the apt-get install koha-common. Thank you very much!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:01:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:01:16 +0000 Subject: [Koha-bugs] [Bug 16873] New: Rrenewal error message not specific enough on self check. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873 Bug ID: 16873 Summary: Rrenewal error message not specific enough on self check. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Scenario: An item is set to auto-renew. The borrower uses Koha's web based self-check terminal to renew the item, but gets the error message "This book cannot be renewed" when he/she tries to renew the item, rather than a more specific message like "This item is set for auto-renewal". This is confusing to the borrower, who thinks that the item has not and cannot be renewed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:02:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:02:20 +0000 Subject: [Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rrenewal error message not |Renewal error message not |specific enough on self |specific enough on self |check. |check. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:06:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:06:47 +0000 Subject: [Koha-bugs] [Bug 3311] Statistical reports should error if row and column aren' t selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:06:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:06:49 +0000 Subject: [Koha-bugs] [Bug 3311] Statistical reports should error if row and column aren' t selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52778|0 |1 is obsolete| | --- Comment #8 from Nicole C. Engard --- Created attachment 53194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53194&action=edit Bug 3311: Testing Cases There was no form of testing for the page. In order to test the perl-side of the changes, I just went to a variety of URLs to see if it will blow up. TEST PLAN --------- 1) Apply this patch 2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/ -- Or whatever yours is. With or without the trailing / 3) prove -v t/db_dependent/www/catalogue_stats.t -- before applying the other patch, there should be failures. 4) Apply both patches 5) prove -v t/db_dependent/www/catalogue_stats.t -- there should be no failures now. 6) run koha qa test tools Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:06:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:06:54 +0000 Subject: [Koha-bugs] [Bug 3311] Statistical reports should error if row and column aren' t selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52779|0 |1 is obsolete| | --- Comment #9 from Nicole C. Engard --- Created attachment 53195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53195&action=edit Bug 3311: Statistical reports should error if row and column aren't selected There are three parameters to play with which do not always generate friendly results. A couple of them seriously crash now. TEST PLAN --------- 1) Staff -> Reports -> Catalog -- should be at 'Catalog statistics' area. 2) Run through combinations: no row, no column no row, column row, no column row, column After selecting a combination to test, click submit, see what happens. Pre-patch apply, nasty crashes sometimes. Step 1 may require repeating, since you can't select a radio button and then unselect it. 3) Apply the patch 4) Repeat the first two steps again, and this time, a pretty informational or warning message should be given. 5) Run koha qa test tools Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:09:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:09:02 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53070|0 |1 is obsolete| | --- Comment #14 from Tom?s Cohen Arazi --- Created attachment 53196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53196&action=edit Bug 14642: Add logging for Holds This patch adds logging for several holds actions. Specifically for: - CREATE - CANCEL - DELETE - RESUME - SUSPEND - MODIFY To test: - Enable the HoldsLog syspref - Add a hold on a record/item => SUCCESS: The log view shows the CREATE action - Click on the button => SUCCESS: The log view shows the SUSPEND action - Click on the button => SUCCESS: The log view shows the RESUME action - Click on the red cross, to delete the hold => SUCCESS: The log view shows the CANCEL action Note: The DELETE action is logged when DelMember is called, with bug 16819 patches applied. Sponsored-by: NEKLS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:10:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:10:01 +0000 Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:16:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:16:05 +0000 Subject: [Koha-bugs] [Bug 2735] authority search stops at 15 pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:16:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:16:08 +0000 Subject: [Koha-bugs] [Bug 2735] authority search stops at 15 pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52200|0 |1 is obsolete| | --- Comment #9 from Nicole C. Engard --- Created attachment 53197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53197&action=edit Bug 2735: Fix authority search pagination at the OPAC The authority search pagination displays only 15 pages, even when there are more. To fix that, this patch mimic the authorities-home.pl intranet script to manage the pagination. Test plan: Without this patch, do some authority search and click on different pages. Apply this patch, redo the same search and make sure the same records are displayed (i.e. confirm that the pagination still works as before). Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:16:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:16:14 +0000 Subject: [Koha-bugs] [Bug 2735] authority search stops at 15 pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52201|0 |1 is obsolete| | --- Comment #10 from Nicole C. Engard --- Created attachment 53198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53198&action=edit Bug 2735: CSS changes Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:19:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:19:23 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:19:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:19:25 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53060|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard --- Created attachment 53199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53199&action=edit Bug 16829: Add 'interface' column to action_logs This patch introduces a new column for the action_logs table. It is called 'interface' and it is intended to store the interface in which the action was performed. Sponsored-by: NEKLS Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:19:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:19:30 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53061|0 |1 is obsolete| | --- Comment #7 from Nicole C. Engard --- Created attachment 53200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53200&action=edit Bug 16829: make logaction and GetLogs aware of the interface column This patch changes the logaction API so it accepts a new 'interface' param. Current code calling logaction is not changed, and this parameter can be ommited in most contexts, and it will correctly fall-back to C4::Context->interface. Unit tests are provided on a different patch. GetLogs gets patched as well, so it can be required to filter by 'interface' param. Sponsored-by: NEKLS Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:19:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:19:33 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53062|0 |1 is obsolete| | --- Comment #8 from Nicole C. Engard --- Created attachment 53201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53201&action=edit Bug 16829: Add 'interface' to the log viewer This patch introduces the 'interface' filter to the log viewer. To test: - Apply the patch - Open the log viewer => SUCCESS: As default, 'All' interfaces are chosen. OPAC, Intranet and SIP are presented - Do a lot of log searches, verify that the interface column shows what is expected. => SUCCESS: The chosen 'interfaces' are kept when rendering results. Sponsored-by: NEKLS Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:19:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:19:37 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53063|0 |1 is obsolete| | --- Comment #9 from Nicole C. Engard --- Created attachment 53202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53202&action=edit Bug 16829: DBIx update Sponsored-by: NEKLS Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:19:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:19:41 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53064|0 |1 is obsolete| | --- Comment #10 from Nicole C. Engard --- Created attachment 53203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53203&action=edit Bug 16829: Unit tests for logaction's 'interface parameter' This patch introduces tests for the new 'interface' parameter for the C4::Log::logaction and C4::Log::GetLogs functions. In logaction, it falls back to C4::Context->interface if ommited. To test: - Run $ prove t/db_dependent/Log.t => SUCCESS: Tests pass - Sign off Sponsored-by: NEKLS Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:22:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:22:45 +0000 Subject: [Koha-bugs] [Bug 16738] Improve EDIFACT messages template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16738 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:22:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:22:47 +0000 Subject: [Koha-bugs] [Bug 16738] Improve EDIFACT messages template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16738 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52408|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 53204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53204&action=edit Bug 16738 - Improve EDIFACT messages template This patch makes several improvements to the EDIFACT messages template to make it more consistent with similar interfaces in Koha. Changes to edimsg.tt are made to simplify the display of the data in a modal. This patch also corrects a couple of markup errors. To test you must have multiple rows of data in the edifact_messages table. I tested with dummy data I inserted manually. Should should have some rows which use 'QUOTE' and 'ORDERS' as the message_type. To test deletions you may need to apply the patch for Bug 16737. - Apply the patch and go to Acquisitions -> EDIFACT messages. - In the table of messages, the date should be displayed according to your system preference. - Sorting by date should work correctly regardless of date format setting. - The 'Actions' column should contain 'View message' and 'Delete' Bootstrap-style buttons with Font Awesome icons. The column should be unsorted. - Clicking the 'Delete' button should prompt you to confirm. - Clicking the 'View message' button should trigger a modal which loads the message data. - Test the page with no messages or when all messages have been deleted. The page should display a standard message dialog instead of an empty table. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 21:36:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 19:36:27 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #96 from Jesse Weaver --- Pushed to master for the 16.11 release, thanks for your work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 22:17:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 20:17:55 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 22:17:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 20:17:58 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51964|0 |1 is obsolete| | --- Comment #52 from Nick Clemens --- Created attachment 53205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53205&action=edit Bug 11360 - Disable barcode field and submit button when a hold is found At the moment when scanning in returns, it can be easy to miss a hold trap due to the fact that the barcode and submit are still active and the barcode field is focused on. A librarian who is focused on scanning can easily scan another item and pass over the form, which is equivalent to clicking the "ignore" button. Test Plan: 1) Apply this patch 2) Trap a hold, note the new modal 3) Check the hold in a second time 4) Note the new modal 5) For each modal, test each button Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 22:40:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 20:40:20 +0000 Subject: [Koha-bugs] [Bug 16243] Add reference manager software (Mendeley and EasyBib) to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51062|0 |1 is obsolete| | --- Comment #25 from H?ctor Eduardo Castro Avalos --- Created attachment 53206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53206&action=edit Bug 16243: Add reference manager software (Mendeley and EasyBib) to OPAC Mendeley provides a mechanism for export bib records to a personal account in a free reference manager and academic social network (similar to Zotero) EasyBib Generate citations in MLA, APA & Chicago formats for bibliographies To test: - Apply patches - Run perl installer/data/mysql/updatedatabase.pl - On master, search for the syspref OpacReferenceManager - Enable the two options - Do a search for books - Notice about the new option 'Export to Reference Manager' in search results - Create an account in Mendeley (Is free) - Click in new option and notice that you can save bib references in Mendeley - Click in new option Cite on EasyBib, you will see the records selected in EasyBib - Repeat for items saved in cart and patron list. - Go to record detail page test in Normal view, Marc view and ISBD view NOTE: Fixed according with QA comment Patch rebase due JS translation mistake Sponsored-by: Universidad de El Salvador Signed-off-by: Bernardo Gonzalez Kriegel Works following test plan. No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 22:40:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 20:40:35 +0000 Subject: [Koha-bugs] [Bug 16243] Add reference manager software (Mendeley and EasyBib) to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51063|0 |1 is obsolete| | --- Comment #26 from H?ctor Eduardo Castro Avalos --- Created attachment 53207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53207&action=edit Bug 16243: Changes LESS opac.less > to opac.css Add changes LESS opac.less > to opac.css for Reference Manager Software (Mendeley and EasyBib) Sponsored-by: Universidad de El Salvador Signed-off-by: Bernardo Gonzalez Kriegel No errors NOTE: Patch rebased to avoid merge conflict -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 7 23:11:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 21:11:19 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|kyle at bywatersolutions.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 00:21:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 22:21:44 +0000 Subject: [Koha-bugs] [Bug 16874] New: Making serials collections actions buttons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 Bug ID: 16874 Summary: Making serials collections actions buttons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 00:25:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 22:25:35 +0000 Subject: [Koha-bugs] [Bug 16874] Making serials collections actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 00:25:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 22:25:39 +0000 Subject: [Koha-bugs] [Bug 16874] Making serials collections actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 --- Comment #1 from Aleisha Amohia --- Created attachment 53208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53208&action=edit Bug 16874: Making serials collections actions buttons To test: 1) Go to serials -> Search a subscription (or make a new one) 2) Ensure that subscription has an end-date that has passed or will pass soon 3) Go to Serials collection (left sidebar menu) 4) Ensure that Subscription summary table has two buttons, Create routing list and Renew. These buttons should be bolded and the table cell highlighted 5) Ensure 'Print list' is a button in year tables below 6) Edit subscription to have a later end-date (will not expire soon) 7) Go bacl to serials collection 8) Ensure that table cell is no longer highlighted and buttons not bolded. Renew button should not be there. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 00:25:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 22:25:49 +0000 Subject: [Koha-bugs] [Bug 16874] Making serials collections actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 00:36:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 22:36:16 +0000 Subject: [Koha-bugs] [Bug 10958] no need for home link on home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958 --- Comment #7 from Aleisha Amohia --- why can we not just remove the link from the tt file? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 01:09:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 23:09:33 +0000 Subject: [Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #25 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 01:15:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 23:15:08 +0000 Subject: [Koha-bugs] [Bug 16720] DBIx ActionLogs.pm should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16720 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 01:25:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 23:25:26 +0000 Subject: [Koha-bugs] [Bug 16875] New: OPAC: Removing link to records if authority is not used by any records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16875 Bug ID: 16875 Summary: OPAC: Removing link to records if authority is not used by any records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Bug 15931, but on the OPAC side -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 01:34:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 23:34:28 +0000 Subject: [Koha-bugs] [Bug 16875] OPAC: Removing link to records if authority is not used by any records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16875 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 01:34:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 23:34:32 +0000 Subject: [Koha-bugs] [Bug 16875] OPAC: Removing link to records if authority is not used by any records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16875 --- Comment #1 from Aleisha Amohia --- Created attachment 53209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53209&action=edit Bug 16875: OPAC - removing link to records if authority is not used by any records To test: 1) Do an authority search. Notice that authorities not used by any records have a clickable link (under Biblio records) which redirects to a catalog search with no results 2) Go back to the authority search and click View full heading for an authority with no records. Notice that under the auth name, it says Number of records used in: 0, with a link to a catalog search 3) Apply patch 4) Repeat steps 1 and 2. Authorities not used in any records should no longer have clickable links nd authorities which have records should work as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 01:39:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 23:39:02 +0000 Subject: [Koha-bugs] [Bug 16876] New: Remove Full heading column in OPAC Authority search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16876 Bug ID: 16876 Summary: Remove Full heading column in OPAC Authority search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Suggestion to remove the Full heading column from the OPAC Authority search results and instead have a Details column, like the layout of the auth search results in the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 01:47:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 23:47:01 +0000 Subject: [Koha-bugs] [Bug 16876] Remove Full heading column in OPAC Authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16876 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 01:47:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 23:47:05 +0000 Subject: [Koha-bugs] [Bug 16876] Remove Full heading column in OPAC Authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16876 --- Comment #1 from Aleisha Amohia --- Created attachment 53210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53210&action=edit Bug 16876: Remove Full Heading column from OPAC Auth search results To test: 1) Go to Authority Search and do a search 2) Notice that there is a Full Heading column that has 'View full heading' links. These take up a lot of space and don't mean a lot to the user 3) Apply patch and refresh 4) Notice that the the Full Heading column is gone and there is now a Details column next to the authorities. Confirm the link takes you to the expected authority detail page. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 01:47:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 23:47:20 +0000 Subject: [Koha-bugs] [Bug 16875] OPAC: Removing link to records if authority is not used by any records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16875 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 01:47:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jul 2016 23:47:32 +0000 Subject: [Koha-bugs] [Bug 16876] Remove Full heading column in OPAC Authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16876 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 04:18:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 02:18:39 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 04:18:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 02:18:43 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53163|0 |1 is obsolete| | --- Comment #7 from Srdjan Jankovic --- Created attachment 53211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53211&action=edit [SIGNED-OFF] Bug 16682: Fix display if Batch patron modification tool does not get any patrons To reproduce: - Go to Tools->Batch patron modification - Submit without filling any of "Use a file", "Or use a patron list", "Or list card numbers..." or use a patron lists with zero members Result: Screen without any information To test: - Apply patch - Repeat steps above - Verify that you get a nice message - Verify that the tool works as before - with invalid card numbers only - with valid and invalid card numbers - with valid card numbers only Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 04:36:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 02:36:36 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vanoudt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 04:36:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 02:36:46 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vanoudt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 04:37:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 02:37:17 +0000 Subject: [Koha-bugs] [Bug 11440] Duplicate authorities when edit a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11440 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vanoudt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 04:37:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 02:37:13 +0000 Subject: [Koha-bugs] [Bug 7170] Remove use of XML::Simple In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #19 from M. Tompsett --- I was looking in the svc ones and came up with this hackiness. sub build_xml_output { my ($xml_hash, $root_name) = @_; my @xml_tags = keys %{$xml_hash}; my @values = map { { 'key' => $_, 'value' => $xml_hash->{$_} } } @xml_tags; my $xml_values; foreach my $value (@values) { $xml_values->{$value->{key}} = $value->{value}; } my $dom = XML::LibXML::Document->new( '1.0', q{} ); $dom->setStandalone(1); my $root = $dom->createElement( $root_name ); $dom->setDocumentElement( $root ); foreach my $xml_tag (@xml_tags) { my $xml_value = $xml_values->{$xml_tag}; my $text = $dom->createTextNode( "\n " ); $root->appendChild($text); my $element = $dom->createElement( $xml_tag ); $root->appendChild($element); if ($xml_value =~ /\new(); my $fragment = $parser->parse_balanced_chunk( $xml_value ); $element->appendChild( $fragment ); } else { $text = $dom->createTextNode( $xml_value ); $element->appendTextNode($text); } } my $text = $dom->createTextNode( "\n" ); $root->appendChild($text); my $xml_output = $dom->toString(0); print $xml_output; } You can see why XML::Simple with its XMLout method is desirable. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 04:47:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 02:47:52 +0000 Subject: [Koha-bugs] [Bug 16877] New: GetBorrowercategoryList(): $sth->fetchall_arrayref( {} ) throws an error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 Bug ID: 16877 Summary: GetBorrowercategoryList(): $sth->fetchall_arrayref( {} ) throws an error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: srdjan at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Despite the DBI docs, $sth->fetchall_arrayref( {} ) throws an error on xenial. Simple {Slice => {}} would fix it. But let's take this as an opportunity to replace it with Koha::Patron::Categories->search(). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 04:48:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 02:48:17 +0000 Subject: [Koha-bugs] [Bug 16877] GetBorrowercategoryList(): $sth->fetchall_arrayref( {} ) throws an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |srdjan at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 04:51:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 02:51:04 +0000 Subject: [Koha-bugs] [Bug 16877] GetBorrowercategoryList(): $sth->fetchall_arrayref( {} ) throws an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 04:51:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 02:51:06 +0000 Subject: [Koha-bugs] [Bug 16877] GetBorrowercategoryList(): $sth->fetchall_arrayref( {} ) throws an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 --- Comment #1 from Srdjan Jankovic --- Created attachment 53212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53212&action=edit Bug 16877: Redo GetBorrowercategoryList() to use Koha::Patron::Categories->search() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 04:52:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 02:52:55 +0000 Subject: [Koha-bugs] [Bug 16877] GetBorrowercategoryList(): $sth->fetchall_arrayref( {} ) throws an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #2 from Srdjan Jankovic --- To test: * Check the "Category" list on eg Patron attribute type maint screens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 08:38:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 06:38:05 +0000 Subject: [Koha-bugs] [Bug 16877] GetBorrowercategoryList(): $sth->fetchall_arrayref( {} ) throws an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53212|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 53213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53213&action=edit Bug 16877: Redo GetBorrowercategoryList() to use Koha::Patron::Categories->search() Followed plan from comment #2 * Check the "Category" list on eg Patron attribute type maint screens prove t/db_dependent/Members.t: Same results with and without patch (Test 1 fails, but not related to this patch) Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 08:39:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 06:39:12 +0000 Subject: [Koha-bugs] [Bug 16877] GetBorrowercategoryList(): $sth->fetchall_arrayref( {} ) throws an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 09:05:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 07:05:53 +0000 Subject: [Koha-bugs] [Bug 16877] GetBorrowercategoryList(): $sth->fetchall_arrayref( {} ) throws an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 --- Comment #4 from Marc V?ron --- Note: Error with t/db_dependent/Members.t was due to a local problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 09:29:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 07:29:31 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #59 from Marc V?ron --- installer/data/mysql/updatedatabase.pl adds a field primary_contact_method to borrowers That makes borrowers_primary_contact_method.sql fail (adding fields to borrowers, deletedborrowers, borrower_modifications). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 10:03:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 08:03:04 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #15 from Marc V?ron --- Logging holds is enabled by default. Is that intended? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 10:03:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 08:03:28 +0000 Subject: [Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 10:03:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 08:03:59 +0000 Subject: [Koha-bugs] [Bug 16829] action_logs should have an 'interface' column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 10:05:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 08:05:03 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #18 from Julian Maurice --- (In reply to Lari Taskula from comment #15) > - Payments should be POST instead of PUT (PUT is idempotent, but > making multiple payments has different effect than sending just one) I agree > - If patron has amountoustanding 0, payment is still possible. > Should we return an error instead? Yes, probably > - /accountlines/:borrowernumber/amountpayment is confusing because of > :borrowernumber. How about /accountlines/amountpayment?borrowernumber=X I believe it's not a good idea to mix GET and POST parameters. What about POST /borrowers/:borrowernumber/payment ? > - Do you think it would be useful to return total and currency? e.g. > GET /accountlines?borrowernumber=1 > { > "total": 100.00, > "currency": "USD", > "rows": [ > { > // accountline-object with amountoutstanding 25, > // accountline-object with amountoutstanding 60, > // accountline-object with amountoutstanding 15 > } > ] > } I think it couldn't hurt. But what currency should we return ? The default (active) currency ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 10:57:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 08:57:16 +0000 Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and minification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #26 from Benjamin Rokseth --- Hi, as much as I would like to sign off this patch, I'm afraid I cannot agree on the notion of automatic minifying. It is an anti-pattern of production code, and requires too much quirks to my liking. a) It allows for inconsistency between apache/plack and minified/not minified b) It requires cgi/apache rights to write to swagger definitions, not a good idea. c) Plack also needs restarting/cache invalidation, since it caches swagger.json d) What is the problem of minifying before deploy anyways? Also I'm not sure of the need to minify swagger at all. If the only reason is for the online validation, I would argue that the online validation is the problem. More important is `mojo swagger2 validate`. Minifying swagger gives no extra performance opposed to http gzipped, probably the opposite. And it is unreadable. Hate to be the party killer, but if you consider removing the patch "Automatically minify swagger.json" I will sign off. Certainly if it means the splitting of definition and paths can be signed off, which I consider a very good idea. I don't consider the online validation an issue, but I do consider the problematic patching of large json files an issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 11:02:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 09:02:48 +0000 Subject: [Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #32 from Benjamin Rokseth --- > Currently it is not possible to define multiple types for primitive definitions > in /definitions/*. If you try to use the following > "firstname": { > "type": ["string", "null"], > "description": "patron's first name" mojo swagger2 validate accepts this, and it works, so what is the problem? Perhaps we should consider online swagger validator faulty? If you remove agree on my objections to bug 16212 and remove the auto minifying I would be happy to sign off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 11:04:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 09:04:40 +0000 Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission checking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #22 from Benjamin Rokseth --- This a very good idea! If you reconsider on the automatic minifying of swagger made in bug 16212 I would be happy to sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 11:49:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 09:49:28 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #19 from Lari Taskula --- (In reply to Julian Maurice from comment #18) > > - /accountlines/:borrowernumber/amountpayment is confusing because of > > :borrowernumber. How about /accountlines/amountpayment?borrowernumber=X > I believe it's not a good idea to mix GET and POST parameters. What about > POST /borrowers/:borrowernumber/payment ? > Good point. That makes more sense. > > - Do you think it would be useful to return total and currency? e.g. > > GET /accountlines?borrowernumber=1 > > { > > "total": 100.00, > > "currency": "USD", > > "rows": [ > > { > > // accountline-object with amountoutstanding 25, > > // accountline-object with amountoutstanding 60, > > // accountline-object with amountoutstanding 15 > > } > > ] > > } > I think it couldn't hurt. But what currency should we return ? The default > (active) currency ? I think yes. Could there be a situation where active currency would not be the correct one, apart from misconfiguration of the active currency? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 11:51:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 09:51:41 +0000 Subject: [Koha-bugs] [Bug 16076] DBIx searches - performance issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16076 --- Comment #1 from Jacek Ablewicz --- Created attachment 53214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53214&action=edit Bug 16076 - DBIx searches - performance issues Experimental method Koha::Objects->search_all_unblessed() added for testing an impact of DBIx::Class::ResultClass::HashRefInflator on search performance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 11:51:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 09:51:45 +0000 Subject: [Koha-bugs] [Bug 16076] DBIx searches - performance issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16076 --- Comment #2 from Jacek Ablewicz --- Created attachment 53215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53215&action=edit Bug 16076 - DBIx searches - performance issues Quick & dirty test script for benchmarking database search performance using various DBI and DBIx approaches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 12:03:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 10:03:06 +0000 Subject: [Koha-bugs] [Bug 16873] Renewal error message not specific enough on self check. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 12:25:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 10:25:25 +0000 Subject: [Koha-bugs] [Bug 16079] Retrieving system preferences from database via DBIx is not fast enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079 --- Comment #15 from Jacek Ablewicz --- Apparently there is a substantial performance difference in regards of DBIx search speed between DBIx versions 0.08196 (in wheezy) and 0.082810 (in jessie). Simple DBIx searches (if we only want array of hashes as a result), with some additional tweaking (using DBIx::Class::ResultClass::HashRefInflator), are almost as fast as plain DBI in DBIx::Class v0.082810 (?). I uploaded some quick & dirty benchmarking code in Bug 16076, there seems to be quite a huge difference: # current master (08/07/2016) on Wheezy # (DBIx::Class version 0.08196, i7-3770 CPU @ 3.40GHz) # # $results = sysprefs_from_mysql(); ## 1.82 msec # $results = sysprefs_dbix_hashref_inflator(); ## 12.5 msec # $results = sysprefs_dbix_unblessed(); ## 17.6 msec # 3.22.x on Jessie (DBIx 0.082810, i7-930 CPU @ 2.80GHz) # # $results = sysprefs_from_mysql(); ## 2.52 msec # $results = sysprefs_dbix_hashref_inflator(); ## 3.51 msec # $results = sysprefs_dbix_unblessed(); ## 7.9 msec Can someone please confirm those results? I tested it on two (not exactly directly comparable) hardware setups - IMO, DBIx version is likely the most important difference, but I can't exclude the possibility that there may be some other factors involved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 12:30:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 10:30:20 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16076 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 12:30:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 10:30:20 +0000 Subject: [Koha-bugs] [Bug 16076] DBIx searches - performance issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16076 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15341 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 12:33:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 10:33:15 +0000 Subject: [Koha-bugs] [Bug 16076] DBIx searches - performance issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16076 --- Comment #3 from Jacek Ablewicz --- Benchmark results are in Bug 16079 comment #15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 12:44:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 10:44:25 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #11 from Benjamin Rokseth --- Created attachment 53216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53216&action=edit [SIGNED-OFF] Bug 16330: REST API: add routes to add, update and delete patrons This patch adds support for add, edit and delete patrons via REST API. GET /api/v1/patrons Get patron list from params GET /api/v1/patrons/ Get single patron POST /api/v1/patrons Create a new patron PUT /api/v1/patrons/ Update data about patron DEL /api/v1/patrons/ Delete a patron Test plan: 1) Apply this patch (on top of dependent bug 15126) 2) Run tests perl t/db_dependent/api/v1/patrons.t 3) Add a user with proper rights to use the REST API 4) play with your favourite REST client (curl/httpie, etc.): Authenticate with the user created above and get a CGISESSION id. Use the CGISESSION to add, edit and delete patrons via the API. Please note there is no validation of body input in PUT/POST other than branchcode,category,userid,cardnumber. Signed-off-by: Bernardo Gonzalez Kriegel On top of 15126 Tested using postman, first try with the api GET, POST, PUT and DELETE works, i.e. list, add, update, search and delete. Small errors fixed in followup. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 12:44:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 10:44:34 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #12 from Benjamin Rokseth --- Created attachment 53217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53217&action=edit [SIGNED-OFF] Bug 16330: (followup) fix spelling and number of tests Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 12:48:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 10:48:07 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51131|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 12:48:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 10:48:24 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51132|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 13:40:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 11:40:08 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported via GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 13:40:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 11:40:11 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported via GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #17 from Marcel de Rooy --- Created attachment 53218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53218&action=edit Bug 10407: Allow MARCXML records to be imported via GUI (groundwork) Patch from Olli, manual rebase by Marcel (July 7, 2016). Signed-off-by: Marcel de Rooy Needs follow-up. Test plan in the third patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 13:40:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 11:40:16 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported via GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #18 from Marcel de Rooy --- Created attachment 53219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53219&action=edit Bug 10407: Resolve warnings from child process After the staging job finishes, the child tries to print results to STDOUT (which is closed). This creates warnings like: stage-marc-import.pl: binmode() on closed filehandle STDOUT at C4/Templates.pm line 120. stage-marc-import.pl: Filehandle STDOUT reopened as FH only for input at /usr/lib/perl5/Template/Provider.pm line 964. Resolving it is simple: the child should exit after marking the job as finished. Test plan: Import a marc file. Observe that you do no longer have such warnings. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 13:40:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 11:40:20 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported via GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #19 from Marcel de Rooy --- Created attachment 53220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53220&action=edit Bug 10407: Add marcxml import (follow-up) This patch makes the following changes: [1] Based on the groundwork of the former patch, add call to RecordsFromMARCXMLFile in stage-marc-import. Use format param. [2] Add format to the template. Use file extension to determine. If you use .xml or .marcxml as extension, MARCXML is selected. [3] In stage-marc-import.tt mark UTF-8 encoding as UTF-8 not as utf8. [4] BatchStageMarcRecords: do not call plugin if you have no records. [5] RecordsFromISO2709File: also return errors in an array. [6] In misc/stage_file.pl also use UTF-8. Handling of errors from [5]. Test plan: [1] Import an empty file as MARC or MARCXML (with Tools/Stage..import). [2] Import an non-empty file with invalid contents as MARC or MARCXML. [3] Export a few records with Tools/Export as MARC and MARCXML. [4] Import these two files. Check selected format versus file extension. [5] Import a MARCXML file with misc/stage_file.pl. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 13:40:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 11:40:26 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported via GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #20 from Marcel de Rooy --- Created attachment 53221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53221&action=edit Bug 10407: Add two subtests to t/ImportBatch.t Creates a few simple tests for the two new subroutines in ImportBatch.pm. Test plan: Run t/ImportBatch.t. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 13:41:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 11:41:20 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported via GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53164|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 13:41:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 11:41:22 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported via GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53165|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 13:43:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 11:43:00 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow MARCXML records to be |Allow MARCXML records to be |imported via GUI |imported with Tools/Stage | |MARC records for import -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 13:44:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 11:44:13 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #21 from Marcel de Rooy --- Welcomes a signoff now :) Will open a new report to see if these changes are interesting for bulkmarcimport too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 13:57:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 11:57:14 +0000 Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53111|0 |1 is obsolete| | --- Comment #6 from Benjamin Rokseth --- Created attachment 53222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53222&action=edit Bug 16825: Add API route for getting an item GET /api/v1/items/{itemnumber} Gets one Item This patch adds route to get one item from koha.items table. This table has a column "itemnotes_nonpublic", which should not be returned if the user has no catalogue permission. To test: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). 2. Send GET request to http://yourlibrary/api/v1/items/YYY where YYY is an existing itemnumber. 3. Make sure the returned data is correct. 4. Run unit tests in t/db_dependent/api/v1/items.t Signed-off-by: jirislav Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 13:58:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 11:58:36 +0000 Subject: [Koha-bugs] [Bug 16879] New: Use ImportBatch routines in bulkmarcimport Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16879 Bug ID: 16879 Summary: Use ImportBatch routines in bulkmarcimport Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Bug 10407 adds two routines that are used in stage-marc-import and misc/stage_file.pl. So we could ask: wouldn't it be possible to use them too in bulkmarcimport? A quick glance thru shows that it is not a 5 minute operation :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:00:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:00:10 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16879 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:00:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:00:10 +0000 Subject: [Koha-bugs] [Bug 16879] Use ImportBatch routines in bulkmarcimport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16879 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10407 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:02:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:02:19 +0000 Subject: [Koha-bugs] [Bug 16880] New: Safe to remove stage-marc-import from apache-shared-intranet-plack.conf blacklist ? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16880 Bug ID: 16880 Summary: Safe to remove stage-marc-import from apache-shared-intranet-plack.conf blacklist? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Some changes on bug 10407 might make it possible to use it under Plack? Not sure about that yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:02:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:02:39 +0000 Subject: [Koha-bugs] [Bug 16880] Safe to remove stage-marc-import from apache-shared-intranet-plack.conf blacklist ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10407 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:02:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:02:39 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16880 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:09:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:09:09 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53221|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy --- Created attachment 53223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53223&action=edit Bug 10407: Add two subtests to t/ImportBatch.t Creates a few simple tests for the two new subroutines in ImportBatch.pm. Test plan: Run t/ImportBatch.t. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:18:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:18:38 +0000 Subject: [Koha-bugs] [Bug 16880] Safe to remove stage-marc-import from apache-shared-intranet-plack.conf blacklist ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16880 --- Comment #1 from Marcel de Rooy --- Preliminary answer: A quick test with Plack/Wheezy via misc stuff shows that the second import still goes wrong.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:22:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:22:44 +0000 Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686 --- Comment #21 from Marc V?ron --- (In reply to Jonathan Druart from comment #19) > Created attachment 53192 [details] [review] > Bug 16686: Add test for Koha::Item::Transfer[s] and Koha::Item->get_transfer Hi Jonathan, I think there is a typo in the file name: Tranfers.t (schould be Transfers.t) If I run the test, I get a syntax error on line 37 (similar typo) and other errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:42:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:42:19 +0000 Subject: [Koha-bugs] [Bug 12509] Untranslatable "Restriction added by overdues process" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Kyle M Hall --- Pushed to master for 16.11, thanks Morgane! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:44:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:44:31 +0000 Subject: [Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- Pushed to master for 16.11, thanks Lyon 3, Alex! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:46:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:46:03 +0000 Subject: [Koha-bugs] [Bug 16431] Marc subfield structure should be cached using Koha::Cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:46:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:46:46 +0000 Subject: [Koha-bugs] [Bug 16459] Adding patrons to a patron card label batch requires 'routing' permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:47:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:47:58 +0000 Subject: [Koha-bugs] [Bug 16671] Wrong itemtype picked in HoldsQueue.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16671 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #16 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:49:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:49:23 +0000 Subject: [Koha-bugs] [Bug 16760] Circulation Statistics wizard not populating itemtype correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to master for 16.11, thanks Galen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:51:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:51:12 +0000 Subject: [Koha-bugs] [Bug 16780] Specify due date always sets time as AM when using 12 hour time format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:52:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:52:02 +0000 Subject: [Koha-bugs] [Bug 16780] Specify due date always sets time as AM when using 12 hour time format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Assignee|kyle at bywatersolutions.com |koha-bugs at lists.koha-commun | |ity.org --- Comment #8 from Kyle M Hall --- Pushed to master for 16.11! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:53:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:53:17 +0000 Subject: [Koha-bugs] [Bug 16854] request.tt: Logic to display messages broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16854 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 14:56:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 12:56:04 +0000 Subject: [Koha-bugs] [Bug 16855] Poor performance due to high overhead of SQL call in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16855 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to master for Koha 16.11,t thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:01:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:01:45 +0000 Subject: [Koha-bugs] [Bug 16859] Fix wrong item field name in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to master for 16.11, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:01:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:01:52 +0000 Subject: [Koha-bugs] [Bug 16859] Fix wrong item field name in export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:03:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:03:04 +0000 Subject: [Koha-bugs] [Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- Pushed to master for 16.11, thanks Bouzid! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:03:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:03:51 +0000 Subject: [Koha-bugs] [Bug 16600] Remove some obsolete references to Greybox in some templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:05:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:05:03 +0000 Subject: [Koha-bugs] [Bug 16774] Format date on 'Transfers to receive' page to dateformat system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16774 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:06:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:06:15 +0000 Subject: [Koha-bugs] [Bug 16807] Frameworks unordered in dropdown when adding/editing a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 16.11, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:07:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:07:45 +0000 Subject: [Koha-bugs] [Bug 16562] Translatability: Issue in opac-user.tt (separated word 'item') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16562 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #15 from Kyle M Hall --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:08:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:08:33 +0000 Subject: [Koha-bugs] [Bug 16869] Silence and catch warnings in t/db_dependent/ SuggestionEngine_ExplodedTerms.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16869 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:09:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:09:23 +0000 Subject: [Koha-bugs] [Bug 15929] typo in explanation for MaxSearchResultsItemsPerRecordStatusCheck In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15929 --- Comment #6 from Kyle M Hall --- Pushed to master for 16.11, thanks Claire! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:09:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:09:31 +0000 Subject: [Koha-bugs] [Bug 15929] typo in explanation for MaxSearchResultsItemsPerRecordStatusCheck In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15929 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:10:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:10:19 +0000 Subject: [Koha-bugs] [Bug 16779] Move road type after address in US style address formatting ( main address) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16779 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:11:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:11:57 +0000 Subject: [Koha-bugs] [Bug 16793] Use Font Awesome for arrows instead of images in audio_alerts.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16793 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Hector! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:13:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:13:27 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #41 from Tom?s Cohen Arazi --- Created attachment 53224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53224&action=edit Bug 14504: (QA followup) Tidy tests This patch re-introduces the transaction into t/db_dependent/Items_DelItemCheck.t and does some cleaning on the touched tests so they raise less warnings. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:13:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:13:32 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #42 from Tom?s Cohen Arazi --- Created attachment 53225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53225&action=edit Bug 14504: (QA followup) Fix delete_records_via_leader.pl call to DelItemCheck Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:14:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:14:12 +0000 Subject: [Koha-bugs] [Bug 16781] Add Font Awesome Icons to "Select/Clear all" links to modborrows.tt and result.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16781 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 16.11, thanks Hector! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:15:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:15:09 +0000 Subject: [Koha-bugs] [Bug 16794] Revise layout for Admistration > Patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16794 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #16 from Kyle M Hall --- Pushed to master for 16.11,t hanks Hector! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:16:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:16:02 +0000 Subject: [Koha-bugs] [Bug 16795] Patron categories: Accept integers only for enrolment period and age limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16795 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:25:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:25:09 +0000 Subject: [Koha-bugs] [Bug 16864] Silence warnings in t/db_dependent/ILSDI_Services.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:25:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:25:25 +0000 Subject: [Koha-bugs] [Bug 16803] Add Font Awesome Icons to "Select/Clear all" links to shelves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16803 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for Koha 16.11, thanks Hector! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:27:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:27:07 +0000 Subject: [Koha-bugs] [Bug 16823] Comment out koha-rebuild-zebra in debian/koha-common.cron.d In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16823 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Magnus! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:29:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:29:34 +0000 Subject: [Koha-bugs] [Bug 16857] patron-attr-types.tt: Get rid of warnings "Argument "" isn' t numeric" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16857 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 16.11, thanks Marc, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:30:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:30:52 +0000 Subject: [Koha-bugs] [Bug 16860] Catch warning t/db_dependent/ClassSource.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to master for 16.11, thanks Mark, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:35:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:35:07 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #65 from Kyle M Hall --- > Beginning of the commit message, something like: > Bug 12345: [DO NOT PUSH] Schema files > That could be a topic for the next meeting, in order to clarify things for > everybody. > Kyle, any thoughts? That works for me! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:39:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:39:21 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |tomascohen at gmail.com --- Comment #43 from Tom?s Cohen Arazi --- I've tested this patches and found some issues: * Somehow, it is not deleting items: I ran this: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ misc/cronjobs/delete_items.pl --verbose --criteria 'holdingbranch="MPL"' --commit Where statement: where holdingbranch="MPL" Deleting '41' But the item is still there. I'm not sure why :-D MariaDB [koha_kohadev]> SELECT itemnumber,holdingbranch,homebranch FROM items WHERE itemnumber=41; +------------+---------------+------------+ | itemnumber | holdingbranch | homebranch | +------------+---------------+------------+ | 41 | MPL | CPL | +------------+---------------+------------+ 1 row in set (0.00 sec) * t/db_dependent/Items_DelItemCheck.t was missing the transaction, thus leaving cruft on the db (FIXED WITH A FOLLOWUP). This happened at some point when refactoring. * This is an opinionated item, and could be discussed, but I'd rather stick with --where instead of --criteria. I'd sign it if it was left as-is anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:41:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:41:58 +0000 Subject: [Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #66 from Kyle M Hall --- Pushed to master for 16.11, thanks Alex, Jonathan! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:42:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:42:38 +0000 Subject: [Koha-bugs] [Bug 16792] Add Font Awesome Icon and mini button to Keyword to MARC mapping section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16792 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Passed QA but blocked by dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:44:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:44:50 +0000 Subject: [Koha-bugs] [Bug 9259] Delete marc batches from staged marc management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #16 from Kyle M Hall --- Pushed to master for 16.11, thanks Aleisha, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:46:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:46:06 +0000 Subject: [Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #17 from Kyle M Hall --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:51:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:51:46 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #55 from Kyle M Hall --- Pushed to master for 16.11! (In reply to Jonathan Druart from comment #54) > Kyle, I have marked this patchset as Passed QA but we still need a patch to > take into account the 3 following tables: aqorders, aqbooksellers, > biblioitems. > I think this could be done on another bug report. Yes, I think that's an excellent plan. Can you file the bug report(s) for those? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:52:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:52:17 +0000 Subject: [Koha-bugs] [Bug 16881] New: Apply KohaTable and ColVis plugin on MARCdetail' s items table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Bug ID: 16881 Summary: Apply KohaTable and ColVis plugin on MARCdetail's items table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Allows to choose columns to display on items table in the MARCdetail page (cgi-bin/koha/catalogue/MARCdetail.pl). Also, the columns displayed are saved for each users in database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:54:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:54:41 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 15:56:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 13:56:59 +0000 Subject: [Koha-bugs] [Bug 14790] Link to OPAC view from within subscriptions, search and item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14790 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Kyle M Hall --- Pushed to master for 16.11! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:05:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:05:11 +0000 Subject: [Koha-bugs] [Bug 14902] Add qualifier menu to staff side "Search the Catalog" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14902 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Kyle M Hall --- Pushed to master for 16.11, thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:06:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:06:25 +0000 Subject: [Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on MARCdetail's items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 --- Comment #1 from Alex Arnaud --- Created attachment 53226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53226&action=edit Bug 16881 - Apply KohaTable and ColVis plugin on MARCdetail's items table Also, the columns displayed are saved for each users in database. Test plan: - apply this BZ, - launch perl installer/data/mysql/updatedatabase.pl - launch perl misc/devel/update_dbix_class_files.pl - go to the items tab on cgi-bin/koha/catalogue/MARCdetail.pl page you should be able to hide/show each columns. - leave this page and come back with the same koha account: You should have the same columns shown/hidden as when you left. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:09:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:09:14 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52997|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:13:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:13:22 +0000 Subject: [Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #43 from Kyle M Hall --- Pushed to master for 16.11, thanks Nick, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:13:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:13:54 +0000 Subject: [Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on MARCdetail's items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:14:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:14:23 +0000 Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/ checking in Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #18 from Kyle M Hall --- Pushed to master for 16.11, thanks Olli, Hector! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:17:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:17:32 +0000 Subject: [Koha-bugs] [Bug 16166] Improve L1 cache performance and safety In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #29 from Kyle M Hall --- Pushed to master for 16.11, thanks Jacek! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:18:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:18:46 +0000 Subject: [Koha-bugs] [Bug 16271] Allow more filters on /api/v1/holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall --- Pushed to master for 16.11, thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:24:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:24:01 +0000 Subject: [Koha-bugs] [Bug 16324] Move item search into header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16324 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall --- Pushed to master for 16.11, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:27:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:27:09 +0000 Subject: [Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:28:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:28:19 +0000 Subject: [Koha-bugs] [Bug 16677] Use abbr for authorities linked headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16677 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:31:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:31:15 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:32:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:32:24 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 --- Comment #10 from Kyle M Hall --- I believe patch will require https://packages.debian.org/sid/perl/libsereal-perl to be added to the community repo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:33:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:33:15 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|dependency | Status|Passed QA |Pushed to Master --- Comment #11 from Kyle M Hall --- Pushed to master for 16.11, thanks Jesse! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:33:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:33:19 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:39:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:39:22 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #12 from Kyle M Hall --- Cancel that, will need a rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:39:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:39:32 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:39:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:39:39 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:39:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:39:47 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:41:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:41:47 +0000 Subject: [Koha-bugs] [Bug 16730] Use member-display-address-style*-includes in moremember-brief.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16730 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:42:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:42:24 +0000 Subject: [Koha-bugs] [Bug 16778] Use Bootstrap modal for card printing on patron lists page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16778 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:42:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:42:48 +0000 Subject: [Koha-bugs] [Bug 16801] Include Font Awesome Icons to check/ unchek all in Administration > Library transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16801 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Summary|Include Font Awesome Incons |Include Font Awesome Icons |to check/unchek all in |to check/unchek all in |Administration > Library |Administration > Library |transfer limits |transfer limits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:44:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:44:06 +0000 Subject: [Koha-bugs] [Bug 16801] Include Font Awesome Icons to check/ unchek all in Administration > Library transfer limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16801 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Hector! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:47:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:47:01 +0000 Subject: [Koha-bugs] [Bug 16805] Log in with database admin user breaks OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #16 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan, Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:49:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:49:36 +0000 Subject: [Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #11 from Kyle M Hall --- Pushed to master for 16.11, thanks Tomas, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:51:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:51:02 +0000 Subject: [Koha-bugs] [Bug 16866] Catch warning t/db_dependent/Languages.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16866 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 16:55:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 14:55:22 +0000 Subject: [Koha-bugs] [Bug 16877] GetBorrowercategoryList(): $sth->fetchall_arrayref( {} ) throws an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Srdjan, I have removed this subroutine on bug 15407 which is waiting for QA. I'd prefer to see it pushed and mark this one as a duplicate instead of rewriting a patch and rebasing the patchset. Would you agree? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:00:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:00:35 +0000 Subject: [Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 16.11, thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:09:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:09:51 +0000 Subject: [Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to additem.pl causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750 --- Comment #12 from Kyle M Hall --- (In reply to Jonathan Druart from comment #11) > The problem with your patch is that it will only fix 1 page whereas we have > plenty of others with the same issue. I totally agree. I much prefer your patch except for the risk of accidentally adding data to the database. I'm sure this behavior exists not only for additem.pl, but for any cgi driven data creation that does not involve a redirect. Do you have any thoughts on how to avoid that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:11:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:11:07 +0000 Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53192|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 53227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53227&action=edit Bug 16686: Add test for Koha::Item::Transfer[s] and Koha::Item->get_transfer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:11:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:11:41 +0000 Subject: [Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686 --- Comment #23 from Jonathan Druart --- (In reply to Marc V?ron from comment #21) > (In reply to Jonathan Druart from comment #19) > > Created attachment 53192 [details] [review] [review] > > Bug 16686: Add test for Koha::Item::Transfer[s] and Koha::Item->get_transfer > > Hi Jonathan, I think there is a typo in the file name: Tranfers.t (schould > be Transfers.t) > If I run the test, I get a syntax error on line 37 (similar typo) and other > errors. Oops, sorry about that. I did not finish to write these tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:16:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:16:23 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #14 from Kyle M Hall --- (In reply to Jonathan Druart from comment #13) > Should not we adjust the description of ExpireReservesMaxPickUpDelayCharge? > It says "ExpireReservesMaxPickUpDelay is enabled, and this field has a > non-zero value, than a borrower whose waiting hold has expired will be > charged this amount". But actually this pref is used even if > ExpireReservesMaxPickUpDelay is off. > Or maybe should we use rename one of these 2 prefs? It seems odd to use the > same suffix but they are not so related. I propose we change the explantation for ExpireReservesMaxPickUpDelayCharge to: If using ExpireReservesMaxPickUpDelay, charge a borrower who allows his or her waiting hold to expire a fee of to: Charge an ammount of $amount if a waiting hold cancellation fee is to be charged. and the syspref name to be: WaitingHoldCancelationFee Does that sound good Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:16:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:16:43 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 --- Comment #8 from Owen Leonard --- I think the message should follow the pattern used when you try to delete a currency which is in use. Something like this:

Batch patrons modification

No patron card numbers given.

-- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:19:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:19:07 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:27:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:27:22 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Prevent errors if create-pdf.pl gets wrong parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38854|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:27:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:27:32 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Prevent errors if create-pdf.pl gets wrong parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:28:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:28:29 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Warn user if PDF creation fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patroncard: Prevent errors |Patroncard: Warn user if |if create-pdf.pl gets wrong |PDF creation fails |parameters | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:34:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:34:59 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Warn user if PDF creation fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 --- Comment #2 from Marc V?ron --- Created attachment 53228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53228&action=edit Bug 14138: Patroncard: Warn user if PDF creation fails First step: Change patroncards/create-pdf.pl to redirect with an an error code instead of writing an ivalid pdf. Updated patch to display error and test plan follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:37:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:37:49 +0000 Subject: [Koha-bugs] [Bug 3311] Statistical reports should error if row and column aren' t selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart --- 1/ I am not sure that it is useful to display the warning when we arrive on the page ("Information: Both row and column values must be selected."). 2/ How can be useful the changes done in the perl script? 3/ If you are submitting the form and one column is missing, the message is displayed on the top of the page, which is not necessarily visible (on relatively small screens). Why don't you just display a JS alert if at least one of the 2 infos is missing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:38:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:38:48 +0000 Subject: [Koha-bugs] [Bug 16882] New: Circ restrictions caused by long overdue should be removed when the offending item is returned Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882 Bug ID: 16882 Summary: Circ restrictions caused by long overdue should be removed when the offending item is returned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a patron is restricted due to a long voerdue and that item is returned, but they have another item overdue by a day their restriction will not be lifted. Some libraries would like to the the restriction tied to the specific item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:44:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:44:18 +0000 Subject: [Koha-bugs] [Bug 16883] New: TT syntax for notices should take aqorders, aqbooksellers , biblioitems tables into account Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16883 Bug ID: 16883 Summary: TT syntax for notices should take aqorders, aqbooksellers, biblioitems tables into account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 14757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:44:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:44:18 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16883 [Bug 16883] TT syntax for notices should take aqorders, aqbooksellers, biblioitems tables into account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 17:45:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 15:45:18 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #56 from Jonathan Druart --- (In reply to Kyle M Hall from comment #55) > Pushed to master for 16.11! > > (In reply to Jonathan Druart from comment #54) > > Kyle, I have marked this patchset as Passed QA but we still need a patch to > > take into account the 3 following tables: aqorders, aqbooksellers, > > biblioitems. > > I think this could be done on another bug report. > > Yes, I think that's an excellent plan. Can you file the bug report(s) for > those? I have opened bug 16883. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 18:21:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 16:21:34 +0000 Subject: [Koha-bugs] [Bug 16884] New: Branch transfer dialog does not appear for check-ins on check-out screen Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16884 Bug ID: 16884 Summary: Branch transfer dialog does not appear for check-ins on check-out screen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To reproduce: Given item with barcode 1234, having homebranch AAA and patron cardnumber 7890: 1/ Set library to branch AAA 2/ Check out item 1234 to Borrower 7890 3/ Change branches in the staff client (We'll call the second branch BBB). 4/ Type 7890 in the 'Check out' bar (I.e. we're going to the check out screen) for borrower 7890 5/ Click 'Show Checkouts' 6/ Check the 'Check in' box for item 1234 7/ Click 'Renew or check in selected Items' Because the item is checked in at a branch other than its home branch, this *should* trigger a branch transfer, but the item is checked in, and no branch transfer dialog appears. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 18:24:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 16:24:56 +0000 Subject: [Koha-bugs] [Bug 16884] Branch transfer dialog does not appear for check-ins on check-out screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16884 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 18:43:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 16:43:42 +0000 Subject: [Koha-bugs] [Bug 16883] TT syntax for notices should take aqorders, aqbooksellers, biblioitems tables into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16883 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 19:45:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 17:45:00 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 19:45:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 17:45:04 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #60 from Mehdi Hamidi --- Created attachment 53229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53229&action=edit Bug 11879 - updatedatabase.pl no longer adds column primary_contact_method to table borrowers Signed-off-by: mehdi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 21:31:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 19:31:19 +0000 Subject: [Koha-bugs] [Bug 16885] New: koha-stop-zebra should be more sure of stopping zebrasrv Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885 Bug ID: 16885 Summary: koha-stop-zebra should be more sure of stopping zebrasrv Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net The koha-stop-zebra command can finish without ensuring that zebrasrv is actually stopped. In particular, if there is an active query running when daemon --stop is run, the following state of affairs will occur until the query finishes or times out: - the child zebrasrv processing the query continues to run - the parent zebrasrv process becomes a zombie - the daemon(1) process continues to run -- and doesn't delete the lock file until the children go away. This is particularly problematic when a koha-stop-zebra is followed by a koha-start-zebra in quick succession, as happens during a logrotate. This is because while zebrasrv is in the half-stopped, half-started stop, the lock file still exists... and koha-start-zebra will see it and believe that zebrasrv is still running. When the query holding the child zebrasrv process finishes, the instance is left with no running Zebra. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 21:47:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 19:47:06 +0000 Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 22:16:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 20:16:52 +0000 Subject: [Koha-bugs] [Bug 16886] New: Error / success reporting in 'Upload patron images' tool is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16886 Bug ID: 16886 Summary: Error / success reporting in 'Upload patron images' tool is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The patron image tool can correctly process images, however, the variables needed for returning results are global and broken (the script itself documents this issue) and plack errors out when trying to access them. The results now are limited to 'success' for a 100% successful file and 'failed' when there is an error logs: Variable "@counts" is not available at /home/vagrant/kohaclone/tools/picture-upload.pl line 228. Variable "$filetype" is not available at /home/vagrant/kohaclone/tools/picture-upload.pl line 240. Variable "$uploadfilename" is not available at /home/vagrant/kohaclone/tools/picture-upload.pl line 241. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 22:17:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 20:17:23 +0000 Subject: [Koha-bugs] [Bug 16886] Error / success reporting in 'Upload patron images' tool is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16886 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7172 Severity|enhancement |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 [Bug 7172] Omnibus for Plack variable scoping problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 22:17:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 20:17:23 +0000 Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16886 [Bug 16886] Error / success reporting in 'Upload patron images' tool is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 22:39:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 20:39:07 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #26 from Brendan Gallagher --- Pushed to Master - Should be in the November 2016 release. thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 23:22:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 21:22:57 +0000 Subject: [Koha-bugs] [Bug 16887] New: Entering a bad date in 'Koha out on loan' field sets items.onloan to 0000-00-00. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16887 Bug ID: 16887 Summary: Entering a bad date in 'Koha out on loan' field sets items.onloan to 0000-00-00. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To re-create 1/ Go to Circulation->Fast Cataloging 2/ Add a biblio record 3/ On Add Items screen, enter a space in 'Koha out on loan' (and enter item type of course). Save the item. 4/ items.onloan will be set to 0000-00-00. ... I'm not certain whether or not this is specific to the fast add framework. Note that this causes upstream issues with search -- any item that has items.onloan set to 0000-00-00 will cause an internal server error on the search results page, with the following error in plack.error.log: Can't locate object method "ymd" via package "dateonly" (perhaps you forgot to load "dateonly"?) at /usr/share/koha/li b/Koha/DateUtils.pm line 223. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 23:27:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 21:27:10 +0000 Subject: [Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974 Eric Phetteplace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace at cca.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 23:49:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 21:49:50 +0000 Subject: [Koha-bugs] [Bug 16888] New: Add Font Awesome Icons to Members Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 Bug ID: 16888 Summary: Add Font Awesome Icons to Members Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: hector.hecaxmmx at gmail.com Reporter: hector.hecaxmmx at gmail.com QA Contact: testopia at bugs.koha-community.org Add Font Awesome Icons to: - "Select/Clear all" links to pay.tt (Pay fines tab) - "Filter icon" in "filter paid transactions" to Accout tab (boraccount.tt) - "Trash icon" to Remove option in "Manual restrictions" (borrower_debarments.inc) also add "Ban and plus icon" to "Add manual restriction" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 23:58:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 21:58:49 +0000 Subject: [Koha-bugs] [Bug 16888] Add Font Awesome Icons to Members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 8 23:58:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 21:58:51 +0000 Subject: [Koha-bugs] [Bug 16888] Add Font Awesome Icons to Members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 53230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53230&action=edit Bug 16888: Add Font Awesome Icons to Members Add Font Awesome Icons to: - "Select/Clear all" links to pay.tt (Pay fines tab) - "Filter icon" in "filter paid transactions" to Accout tab (boraccount.tt) - "Trash icon" to Remove option in "Manual restrictions" (borrower_debarments.inc) also add "Ban and plus icon" to "Add manual restriction" To test: -Apply patch -Select a patron who has fines -Go to "Fines->Pay fines" tabs and see the icons in "Select/Clear all" -Choose the "Account" tab and sse the icon in "Filter paid transactions" -Select the "Check out" tab and go to "Restrictions" -Add a manual restriction and notice about the two new icons fa-plus and fa-band -See the new button btn-mini and the fa-trash icon -Verify that all works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 00:01:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 22:01:32 +0000 Subject: [Koha-bugs] [Bug 16888] Add Font Awesome Icons to Members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53230|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 53231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53231&action=edit Bug 16888: Add Font Awesome Icons to Members Add Font Awesome Icons to: - "Select/Clear all" links to pay.tt (Pay fines tab) - "Filter icon" in "filter paid transactions" to Accout tab (boraccount.tt) - "Trash icon" to Remove option in "Manual restrictions" (borrower_debarments.inc) also add "Ban and plus icon" to "Add manual restriction" To test: -Apply patch -Select a patron who has fines -Go to "Fines->Pay fines" tabs and see the icons in "Select/Clear all" -Choose the "Account" tab and sse the icon in "Filter paid transactions" -Select the "Check out" tab and go to "Restrictions" -Add a manual restriction and notice about the two new icons fa-plus and fa-band -See the new button btn-mini and the fa-trash icon -Verify that all works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 00:02:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 22:02:26 +0000 Subject: [Koha-bugs] [Bug 16888] Add Font Awesome Icons to Members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org, | |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 00:15:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 22:15:45 +0000 Subject: [Koha-bugs] [Bug 16818] CAS redirect broken under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 00:15:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jul 2016 22:15:48 +0000 Subject: [Koha-bugs] [Bug 16818] CAS redirect broken under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818 --- Comment #2 from Jesse Weaver --- Created attachment 53232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53232&action=edit Bug 16818: External auth redirect broken under Plack Test plan: 0) Have either CAS or Shibboleth authentication enabled under Plack. 1) Hover over the authentication link on the staff client or OPAC, and notice that it has either '.../opac/...' or '.../intranet/...' instead of '.../cgi-bin/koha/...'. (This will be a complete dealbreaker for CAS authentication.) 2) Apply patch. 3) Check links again; they should now have the correct paths. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 10:45:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 08:45:47 +0000 Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 13:04:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 11:04:24 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Warn user if PDF creation fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53228|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 53233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53233&action=edit Bug 14138: Patroncard: Warn user if PDF creation fails First step: Change patroncards/create-pdf.pl to redirect with an an error code instead of writing an ivalid pdf. Updated patch to display error and test plan follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 13:48:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 11:48:27 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #15 from Jonathan Druart --- Sounds good to me :) Katrin, do you agree? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 14:11:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 12:11:58 +0000 Subject: [Koha-bugs] [Bug 16886] 'Upload patron images' tool is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16886 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Summary|Error / success reporting |'Upload patron images' tool |in 'Upload patron images' |is not plack safe |tool is broken | Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 14:18:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 12:18:51 +0000 Subject: [Koha-bugs] [Bug 16886] 'Upload patron images' tool is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16886 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 14:18:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 12:18:54 +0000 Subject: [Koha-bugs] [Bug 16886] 'Upload patron images' tool is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16886 --- Comment #1 from Jonathan Druart --- Created attachment 53234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53234&action=edit Bug 16886: Make the 'Upload patron images' tool plack safe Some vars are accessed from subroutine, but defined with my. It causes at least the 2 followings errors: Variable "$filetype" is not available at /home/koha/src/tools/picture-upload.pl line 240. Variable "$uploadfilename" is not available at /home/koha/src/tools/picture-upload.pl line 241. To avoid that, they are now declared with our. Test plan: Upload image for a patron and confirm that you get a "Result" table and the errors do not longer appear in the logs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 14:19:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 12:19:17 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 --- Comment #9 from Marc V?ron --- Created attachment 53235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53235&action=edit Bug 16682: (followup) Fix display if Batch patron modification tool does not get any patrons Format message as proposed in comment #8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 14:19:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 12:19:56 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:04:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:04:48 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:04:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:04:51 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53211|0 |1 is obsolete| | Attachment #53235|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 53236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53236&action=edit Bug 16682: Fix display if Batch patron modification tool does not get any patrons To reproduce: - Go to Tools->Batch patron modification - Submit without filling any of "Use a file", "Or use a patron list", "Or list card numbers..." or use a patron lists with zero members Result: Screen without any information To test: - Apply patch - Repeat steps above - Verify that you get a nice message - Verify that the tool works as before - with invalid card numbers only - with valid and invalid card numbers - with valid card numbers only Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:04:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:04:56 +0000 Subject: [Koha-bugs] [Bug 16682] Fix display if Batch patron modification tool does not get any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16682 --- Comment #11 from Jonathan Druart --- Created attachment 53237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53237&action=edit Bug 16682: (followup) Fix display if Batch patron modification tool does not get any patrons Format message as proposed in comment #8 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:11:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:11:28 +0000 Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53131|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 53238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53238&action=edit Bug 16849: Move IsDebarred to Koha::Patron->is_debarred In order to move IsMemberBlocked to Koha::Patron it makes sense to move the code from Koha::Patron::Debarments::IsDebarred to Koha::Patron->is_debarred. Test plan: 1/ Add a restriction to a patron 2/ make sure he is not able to checkout items any more 3/ Make sure he cannot get a discharge 4/ Put a hold and make sure you get "Patron has restrictions" Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:11:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:11:50 +0000 Subject: [Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 --- Comment #9 from Jonathan Druart --- Patch rebased against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:18:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:18:33 +0000 Subject: [Koha-bugs] [Bug 16853] Move changepassword to Koha::Patron->update_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53103|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53239&action=edit Bug 16853: Move changepassword to Koha::Patron->update_password This patch moves the code from C4::Members::changepassword to Koha::Patron->update_password Test plan: Change your password at the OPAC and the staff interface This should work as before Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:18:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:18:46 +0000 Subject: [Koha-bugs] [Bug 16853] Move changepassword to Koha::Patron->update_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853 --- Comment #4 from Jonathan Druart --- Patch rebased against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:43:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:43:57 +0000 Subject: [Koha-bugs] [Bug 16437] Automatic item modifications by age needs prettying In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16437 --- Comment #14 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > 1/ The age field is not mandatory > 2/ The right member of the substitutions is not mandatory (you could empty > it) I think that I have missed to check these 2 remarks before passing it. The age field is not mandatory (and should not) as well as the substitutions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:46:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:46:32 +0000 Subject: [Koha-bugs] [Bug 16889] New: Move the ::columns subroutines to Koha::Objects->columns Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889 Bug ID: 16889 Summary: Move the ::columns subroutines to Koha::Objects->columns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Currently we have 3 subroutines to retrieve the columns of tables: C4::Members::columns, C4::Items::columns and C4::Items::biblioitems_columns. It will be easier to have a Koha::Objects->columns method to provide the different classes to retrieve their related column names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:46:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:46:57 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16889 --- Comment #8 from Jonathan Druart --- Bug 16889 - Move the ::columns subroutines to Koha::Objects->columns Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889 [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:46:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:46:57 +0000 Subject: [Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:54:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:54:23 +0000 Subject: [Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:54:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:54:26 +0000 Subject: [Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889 --- Comment #1 from Jonathan Druart --- Created attachment 53240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53240&action=edit Bug 16889: Add Koha::Objects->columns Currently we have 3 subroutines to retrieve the columns of tables: C4::Members::columns, C4::Items::columns and C4::Items::biblioitems_columns. It is easier to have a Koha::Objects->columns method to provide the different classes to retrieve their related column names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:54:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:54:29 +0000 Subject: [Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889 --- Comment #2 from Jonathan Druart --- Created attachment 53241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53241&action=edit Bug 16889: Remove C4::Members::columns and use Koha::Patrons->columns instead Test plan: Import some patrons (tools/import_borrowers.pl) and make sure it imports the patrons correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:54:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:54:32 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Warn user if PDF creation fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53233|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 53242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53242&action=edit Bug 14138: Patroncard: Warn user if PDF creation fails First step: Change patroncards/create-pdf.pl to redirect with an an error code instead of writing an ivalid pdf. Updated patch to display error and test plan follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:54:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:54:32 +0000 Subject: [Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889 --- Comment #3 from Jonathan Druart --- Created attachment 53243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53243&action=edit Bug 16889: Remove C4::Items::columns and use Koha::Items->columns instead Test plan: Add new rule to the "Automatic item modifications by age" tools (tools/automatic_item_modification_by_age.pl) and make sure the columns of the items table are correctly displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 15:54:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 13:54:37 +0000 Subject: [Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889 --- Comment #4 from Jonathan Druart --- Created attachment 53244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53244&action=edit Bug 16889: Remove C4::Items::biblioitems_columns and use Koha::Biblioitems->columns instead Test plan: Add new rule to the "Automatic item modifications by age" tools (tools/automatic_item_modification_by_age.pl) and make sure the columns of the biblioitems table are correctly displayed in the 'Conditions' dropdown list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 16:00:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 14:00:19 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Warn user if PDF creation fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53242|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 53245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53245&action=edit Bug 14138: Patroncard: Warn user if PDF creation fails First step: Change patroncards/create-pdf.pl to redirect with an an error code instead of writing an ivalid pdf. Updated patch to display error and test plan follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 16:31:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 14:31:00 +0000 Subject: [Koha-bugs] [Bug 3311] Statistical reports should error if row and column aren' t selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 --- Comment #11 from M. Tompsett --- (In reply to Jonathan Druart from comment #10) > 1/ I am not sure that it is useful to display the warning when we arrive on > the page ("Information: Both row and column values must be selected."). It seemed to make sense to put a pre-emptive instruction, so the actual problem cases would be generally avoided. > 2/ How can be useful the changes done in the perl script? The value of $do_it is wrong without those changes, and causes nasty crashes. That is why I provided test coverage. > 3/ If you are submitting the form and one column is missing, the message is > displayed on the top of the page, which is not necessarily visible (on > relatively small screens). The whole screen looks bad on small screens. I just tried it on my phone. But the yellow at the top made me read it. > Why don't you just display a JS alert if at least one of the 2 infos is > missing? Because this is prettier? I'd prefer bootstrap in the staff client too, but that hasn't happened yet. Would this + alerts be okay? After all, it's really easy to click okay, and forget the message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 16:53:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 14:53:14 +0000 Subject: [Koha-bugs] [Bug 16809] Silence authority warnings C4::Biblio::TransformHtmlToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 16:53:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 14:53:42 +0000 Subject: [Koha-bugs] [Bug 16864] Silence warnings in t/db_dependent/ILSDI_Services.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 16:54:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 14:54:46 +0000 Subject: [Koha-bugs] [Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 16:56:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 14:56:02 +0000 Subject: [Koha-bugs] [Bug 16890] New: TestBuilder always generate datetime for dates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 Bug ID: 16890 Summary: TestBuilder always generate datetime for dates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: gmcharlt at gmail.com TestBuilder should not generate datetime for date columns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 16:58:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 14:58:18 +0000 Subject: [Koha-bugs] [Bug 16890] TestBuilder always generate datetime for dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 16:58:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 14:58:21 +0000 Subject: [Koha-bugs] [Bug 16890] TestBuilder always generate datetime for dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 --- Comment #1 from Jonathan Druart --- Created attachment 53246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53246&action=edit Bug 16890: Make TestBuilder generate date for date columns (and not datetime) TestBuilder should not generate datetime for date columns, but only for datetime and timestamp columns. Test plan: Make sure the change in t/db_dependent/TestBuilder.t are consistent. Before this patch, 1 of the 2 tests should fail. After this patch applied, they both should pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 17:08:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 15:08:17 +0000 Subject: [Koha-bugs] [Bug 16850] Move IsMemberBlocked to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53096|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53247&action=edit Bug 16850: Remove C4::Members::IsMemberBlocked This subroutine is only called once and can be replaced with a call to is_debarred and has_overdues. Note that prior to this patch, IsMemberBlocked copy/paste code from HasOverdues, which did not make sense. Test plan: Debar a patron and make sure he is not able to checkout (the librarian is asked to overwrite if OverduesBlockCirc is set to 'confirmation') Remove the debarment and add overdues to this patron, same as previously, the checkout should be blocked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 17:11:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 15:11:12 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Warn user if PDF creation fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53245|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 53248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53248&action=edit Bug 14138: Patroncard: Warn user if PDF creation fails Change patroncards/create-pdf.pl to redirect with an error message instead of writing an invalid pdf that does not open in pdf viewer. To test: - Apply patch - Test that pdf creator behaves as before (with valid batches and patron lists) - While testing, copy pdf link address from window with title 'Click the following link(s) to download...' - Open another staff client browser tab - Paste link to browser address field, change batch id rsp. patron list id to an invalid value and submit - The window should redirect to cgi-bin/koha/patroncards/create-pdf.pl and display an error message - Bonus test 1: Create an empty patron list and test patron card creation. You should get an error message as appropriate. - Bonus test 2: Use a link with params like the following: ...create-pdf.pl?borrower_number=61&template_id=2&layout_id=1&start_card=1 Verify that you can create a pdf with a valid borrower_number and that you get the error message with an invalid borrower number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 17:12:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 15:12:53 +0000 Subject: [Koha-bugs] [Bug 16891] New: Move MoveMemberToDeleted to Koha::Patron->move_to_deleted Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16891 Bug ID: 16891 Summary: Move MoveMemberToDeleted to Koha::Patron->move_to_deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 16890 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 [Bug 16890] TestBuilder always generate datetime for dates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 17:12:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 15:12:53 +0000 Subject: [Koha-bugs] [Bug 16890] TestBuilder always generate datetime for dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16891 [Bug 16891] Move MoveMemberToDeleted to Koha::Patron->move_to_deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 17:13:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 15:13:09 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16891 --- Comment #9 from Jonathan Druart --- Bug 16891 - Move MoveMemberToDeleted to Koha::Patron->move_to_deleted Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16891 [Bug 16891] Move MoveMemberToDeleted to Koha::Patron->move_to_deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 17:13:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 15:13:09 +0000 Subject: [Koha-bugs] [Bug 16891] Move MoveMemberToDeleted to Koha::Patron->move_to_deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 17:13:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 15:13:13 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Warn user if PDF creation fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 17:22:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 15:22:23 +0000 Subject: [Koha-bugs] [Bug 16891] Move MoveMemberToDeleted to Koha::Patron->move_to_deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 9 17:22:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jul 2016 15:22:26 +0000 Subject: [Koha-bugs] [Bug 16891] Move MoveMemberToDeleted to Koha::Patron->move_to_deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16891 --- Comment #1 from Jonathan Druart --- Created attachment 53249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53249&action=edit Bug 16891: Move C4::Members::MoveMemberToDeleted to Koha::Patron->move_to_deleted This patch removes the C4::Members::MoveMemberToDeleted subroutine in order to replace it with the Koha::Patron->move_to_deleted method. Next after this change, we will move C4::Members::HandleDelBorrower and C4::Members::DelMember to the same module to simplify the code in members/deletemem.pl and misc/cronjobs/delete_patrons.pl Test plan: 1/ Delete a patron from the staff interface and make sure (s)he has been moved to the deletedborrowers table. 2/ Use the "Batch patron deletion" tool (tools/cleanborrowers.pl) to remove patron. Make sure the "Permanently delete these patrons" and "Move these patrons to the trash" options work as before 3/ Same as previously but using the cronjob misc/cronjobs/delete_patrons.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 10 08:24:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jul 2016 06:24:09 +0000 Subject: [Koha-bugs] [Bug 7170] Remove use of XML::Simple In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 --- Comment #20 from Chris Cormack --- > > You can see why XML::Simple with its XMLout method is desirable. :) Except I work with the Author of XML::Simple and as David has already pointed out, he recommends no one uses it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 10 17:15:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jul 2016 15:15:40 +0000 Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885 --- Comment #1 from Marcel de Rooy --- I think this explains a case where I had a stopped zebrasrv on the day the logs rotated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 10 20:26:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jul 2016 18:26:14 +0000 Subject: [Koha-bugs] [Bug 16888] Add Font Awesome Icons to Members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53231|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 53250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53250&action=edit Bug 16888: Add Font Awesome Icons to Members Add Font Awesome Icons to: - "Select/Clear all" links to pay.tt (Pay fines tab) - "Filter icon" in "filter paid transactions" to Accout tab (boraccount.tt) - "Trash icon" to Remove option in "Manual restrictions" (borrower_debarments.inc) also add "Ban and plus icon" to "Add manual restriction" To test: -Apply patch -Select a patron who has fines -Go to "Fines->Pay fines" tabs and see the icons in "Select/Clear all" -Choose the "Account" tab and sse the icon in "Filter paid transactions" -Select the "Check out" tab and go to "Restrictions" -Add a manual restriction and notice about the two new icons fa-plus and fa-band -See the new button btn-mini and the fa-trash icon -Verify that all works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 10 20:27:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jul 2016 18:27:00 +0000 Subject: [Koha-bugs] [Bug 16888] Add Font Awesome Icons to Members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 10 20:42:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jul 2016 18:42:36 +0000 Subject: [Koha-bugs] [Bug 16875] OPAC: Removing link to records if authority is not used by any records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16875 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53209|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 53251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53251&action=edit Bug 16875: OPAC - removing link to records if authority is not used by any records To test: 1) Do an authority search. Notice that authorities not used by any records have a clickable link (under Biblio records) which redirects to a catalog search with no results 2) Go back to the authority search and click View full heading for an authority with no records. Notice that under the auth name, it says Number of records used in: 0, with a link to a catalog search 3) Apply patch 4) Repeat steps 1 and 2. Authorities not used in any records should no longer have clickable links nd authorities which have records should work as expected. Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 10 20:43:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jul 2016 18:43:39 +0000 Subject: [Koha-bugs] [Bug 16875] OPAC: Removing link to records if authority is not used by any records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16875 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 10 20:48:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jul 2016 18:48:47 +0000 Subject: [Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776 --- Comment #2 from Marc V?ron --- Still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 10 21:02:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jul 2016 19:02:56 +0000 Subject: [Koha-bugs] [Bug 16621] Translatability: Issues in opac-user.tt (sentence splitting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52216|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 53252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53252&action=edit Bug 16621: Translatability: Issues in opac-user.tt (sentence splitting) This patch fixes issues due to sentence splitting in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Note: This is a string patch. It does not add or change functionallity. To test: - Examine code and verify that the text changes remove sentence splitting and that the changes make sense. - Log in to OPAC and verify that messages look correct - with blocked /debarred user (with and without comment and date) - with user who has to much fines (needs syspref OpacRenewalAllowed and syspref OPACFineNoRenewals) - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information (with and without syspref OPACPatronDetails set to Allow) Note: Amended to make patch apply 2016-07-10 mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 10 21:11:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jul 2016 19:11:50 +0000 Subject: [Koha-bugs] [Bug 16701] Translatability: Fix problem with isolated ' in currency.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16701 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53180|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 53253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53253&action=edit Bug 16701: (follow-up) improve some changes Add missing quote in line 152 Modify title of the page and breadcrumbs section wrong "searchfield" used should be instead "currency.currency" To test -Try to delete the active and used currency, for example, my case USD, look that appear USD' with the initial single quote missing in message Confirm deletion of currency USD' -Notice about the breadcrumbs section appear: Confirm deletion of currency '' Should appear the currency -Try to delete another currency see the pharese look the same -Notice about the title in both cases, there is missing the currency name -Apply follow-up and re-test Sing-off on followup Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 10 21:12:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jul 2016 19:12:05 +0000 Subject: [Koha-bugs] [Bug 16701] Translatability: Fix problem with isolated ' in currency.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16701 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 02:11:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 00:11:46 +0000 Subject: [Koha-bugs] [Bug 16877] GetBorrowercategoryList(): $sth->fetchall_arrayref( {} ) throws an error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16877 --- Comment #6 from Srdjan Jankovic --- Totally. I should have looked at the bug list again when I decided not to go with the simple fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 03:43:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 01:43:13 +0000 Subject: [Koha-bugs] [Bug 16370] Set the record encoding to UTF8 when TransformHtmlToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16370 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea --- I can tell you how to reproduce this, it happens in the standard MARC editor as well as the authority editor. Create a framework that doesn't include the 000 in the editor (set to ignore) alternatively, import the attached framework. create or import a record that has UTF8 characters in it into that framework. I used ??????? for the title, because that's easy to spot disappearing. Edit the record, and modify any field. You'll notice that the title is no longer displayed after you save it. If you look in the database in biblioitems for this biblio, you'll spot that the MARC has the title saved, but the MARCXML does not. As C?dric says, it seems to be because the leader is set to MARC-8 in the absence of the leader, instead of UTF8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 03:43:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 01:43:42 +0000 Subject: [Koha-bugs] [Bug 16370] Set the record encoding to UTF8 when TransformHtmlToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16370 --- Comment #3 from Liz Rea --- Created attachment 53254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53254&action=edit Framework for testing, no 000 visible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 04:27:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 02:27:07 +0000 Subject: [Koha-bugs] [Bug 16370] Set the record encoding to UTF8 when TransformHtmlToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16370 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 04:27:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 02:27:10 +0000 Subject: [Koha-bugs] [Bug 16370] Set the record encoding to UTF8 when TransformHtmlToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16370 --- Comment #4 from Liz Rea --- Created attachment 53255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53255&action=edit Bug 16370 - Frameworks without 000 visible won't save UTF8 characters Create a framework that doesn't include the 000 in the editor (set to ignore) alternatively, import the attached framework. Create or import a record that has UTF8 characters in it into that framework. I used ??????? for the title, because that's easy to spot disappearing. Edit the record, and modify any field. You'll notice that the title is no longer displayed after you save it. Apply the patch, redo above, fields with UTF8 Characters will be saved correctly Note (from Liz): I have no idea if this is the right solution, but it does fix the problem, so I'm formatting this as required for testing/inclusion on behalf of C?dric. If you look in the database in biblioitems for this biblio, you'll spot that the MARC has the title saved, but the MARCXML does not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 04:29:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 02:29:15 +0000 Subject: [Koha-bugs] [Bug 16370] Set the record encoding to UTF8 when TransformHtmlToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16370 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53255|0 |1 is obsolete| | --- Comment #5 from Liz Rea --- Created attachment 53256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53256&action=edit Bug 16370 - Frameworks without 000 visible won't save UTF8 characters Create a framework that doesn't include the 000 in the editor (set to ignore) alternatively, import the attached framework. Create or import a record that has UTF8 characters in it into that framework. I used ??????? for the title, because that's easy to spot disappearing. Edit the record, and modify any field. You'll notice that the title is no longer displayed after you save it, and no longer appears in the editor. If you look in the database in biblioitems for this biblio, you'll spot that the MARC has the title saved, but the MARCXML does not. Apply the patch, redo above, fields with UTF8 Characters will be saved correctly Note (from Liz): I have no idea if this is the right solution, but it does fix the problem, so I'm formatting this as required for testing/inclusion on behalf of C?dric. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 06:39:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 04:39:36 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16892 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 06:39:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 04:39:36 +0000 Subject: [Koha-bugs] [Bug 16892] New: Add automatic patron registration via OAuth2 login Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Bug ID: 16892 Summary: Add automatic patron registration via OAuth2 login Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: mtompset at hotmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org If a patron's email address is authenticated by Google, and is not registered as a primary email address, automatically register the patron to allow login access. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 06:49:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 04:49:58 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 06:50:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 04:50:01 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #1 from M. Tompsett --- Created attachment 53257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53257&action=edit Bug 16892: Add automatic patron registration via OAuth2 login 10988 added the ability to log into the OPAC authenticating with Google Open ID Connect. This extends it, by allowing an unregistered patron to have an account automatically created with default category code and branch. This is accomplished by adding 3 system preferences. - GoogleOpenIDConnectAutoRegister whether it will attempt to auto-register the patron. - GoogleOpenIDConnectDefaultCategory This category code will be used to create Google OpenID Connect patrons. - GoogleOpenIDConnectDefaultBranch' This branch code will be used to create Google OpenID Connect patrons. Sponsored-by: Tulong Aklatan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 07:41:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 05:41:23 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51510|0 |1 is obsolete| | --- Comment #92 from David Cook --- Created attachment 53258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53258&action=edit Bug 10662 - kohastructure.sql changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 07:42:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 05:42:22 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51563|0 |1 is obsolete| | --- Comment #93 from David Cook --- Created attachment 53259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53259&action=edit Bug 10662 - Create svc/import_oai API and import management Tools > Manage OAI-PMH record imports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 07:42:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 05:42:52 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51705|0 |1 is obsolete| | --- Comment #94 from David Cook --- Created attachment 53260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53260&action=edit Bug 10662 - Icarus job server and Koha UI for it NOTE: You cannot use koha-gitify to test changes to koha-conf.xml NOTE: Check koha_perl_deps.pl; you may need to install POE.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 09:01:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 07:01:38 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #115 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #112) > Before pushing this, it could be great to execute the update DB entry on a > large DB, which has been updated from several Koha versions. > Does anyone have that on hand? I'm gone try asap -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 09:02:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 07:02:18 +0000 Subject: [Koha-bugs] [Bug 16645] Plack: Add the multi_param fix from Context in koha.psgi In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16645 --- Comment #10 from Fridolin SOMERS --- (In reply to Marcel de Rooy from comment #9) > Could be consequence of enabling the warnings again? I'd say yes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 13:20:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 11:20:35 +0000 Subject: [Koha-bugs] [Bug 16757] Add ability to pay fee by id for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52472|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 53261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53261&action=edit Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 13:33:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 11:33:10 +0000 Subject: [Koha-bugs] [Bug 16757] Add ability to pay fee by id for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52468|0 |1 is obsolete| | Attachment #53261|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 53262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53262&action=edit Bug 16757 - Add ability to pay fee by id for SIP2 The SIP protocol allows for a Fee Paid message to specify a fee identifier in the CG field. While this field is read and passed to C4::SIP::ILS::pay_fee, it is not passed along to C4::SIP::ILS::Transaction::FeePayment::pay and is thus not used. We should enable this functionality in Koha now that accountlines each have a unique identifier that can be passed along to the payment requestor via the AV field line items added by bug 14512. Test Plan: 1) Create a fee in Koha 2) Ensure your SIP2 server is running and configured correctly 3) Send a 37 Fee Paid message to Koha's SIP server with the accountlines_id for that fee in the CG fee identifier field, along with the other required fields. 4) Note that specific fee was paid in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 13:33:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 11:33:17 +0000 Subject: [Koha-bugs] [Bug 16757] Add ability to pay fee by id for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 --- Comment #6 from Kyle M Hall --- Created attachment 53263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53263&action=edit Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 14:50:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 12:50:50 +0000 Subject: [Koha-bugs] [Bug 12509] Untranslatable "Restriction added by overdues process" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 [Bug 16893] Missing closing tag disrupts patron detail page style -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 14:50:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 12:50:50 +0000 Subject: [Koha-bugs] [Bug 16893] New: Missing closing tag disrupts patron detail page style Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 Bug ID: 16893 Summary: Missing closing tag disrupts patron detail page style Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/moremember.pl?borrowernumber=X OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 12509 There is a missing closing in the moremember.tt template when the patron has a restriction message. The whole page is in italics. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509 [Bug 12509] Untranslatable "Restriction added by overdues process" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 14:53:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 12:53:33 +0000 Subject: [Koha-bugs] [Bug 16886] 'Upload patron images' tool is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16886 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 14:53:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 12:53:35 +0000 Subject: [Koha-bugs] [Bug 16886] 'Upload patron images' tool is not plack safe In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16886 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53234|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 53264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53264&action=edit Bug 16886: Make the 'Upload patron images' tool plack safe Some vars are accessed from subroutine, but defined with my. It causes at least the 2 followings errors: Variable "$filetype" is not available at /home/koha/src/tools/picture-upload.pl line 240. Variable "$uploadfilename" is not available at /home/koha/src/tools/picture-upload.pl line 241. To avoid that, they are now declared with our. Test plan: Upload image for a patron and confirm that you get a "Result" table and the errors do not longer appear in the logs. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 14:53:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 12:53:41 +0000 Subject: [Koha-bugs] [Bug 16893] Missing closing tag disrupts patron detail page style In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 14:53:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 12:53:43 +0000 Subject: [Koha-bugs] [Bug 16893] Missing closing tag disrupts patron detail page style In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 --- Comment #1 from Owen Leonard --- Created attachment 53265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53265&action=edit Bug 16893 - Missing closing tag disrupts patron detail page style A missing closing causes the the patron detail page to be in all italics if the patron has a restriction message. This patch corrects it. To test, apply the patch and locate a patron who has a restriction message. The restriction message should be in italics but the rest of the page should display normally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 14:58:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 12:58:21 +0000 Subject: [Koha-bugs] [Bug 16888] Add Font Awesome Icons to Members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Owen Leonard --- I think the addition of the "fa-ban" icon is unnecessary. At this time we use icons for actions (links, buttons), but not as decoration for other page elements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 15:12:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 13:12:57 +0000 Subject: [Koha-bugs] [Bug 16894] New: re-show email on patron search results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16894 Bug ID: 16894 Summary: re-show email on patron search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 10318 add added email in patron search results. Looks like when the result page has been transformed to use Ajax Datables, this column was forgotten. Since column visibility can now be managed, its ok to have more columns I think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 15:13:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 13:13:05 +0000 Subject: [Koha-bugs] [Bug 16894] re-show email on patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16894 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10318 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10318 [Bug 10318] show email on patron search results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 15:13:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 13:13:05 +0000 Subject: [Koha-bugs] [Bug 10318] show email on patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10318 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16894 [Bug 16894] re-show email on patron search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 15:55:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 13:55:34 +0000 Subject: [Koha-bugs] [Bug 16895] New: Allow writeoffs via SIP2 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 Bug ID: 16895 Summary: Allow writeoffs via SIP2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Many SIP2 services such as those by Comprise Technologies are able to or require that an ILS be able to accept writeoffs via SIP2. The SIP2 protocol specifies that payment type be a two digit number, but does not specify a code for writeoffs. To this end we should allow the write-off code to be specified in the SIP2 config on a per-account basis so that if different vendors use different fixed codes for write-offs we can handle that gracefully. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 15:56:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 13:56:49 +0000 Subject: [Koha-bugs] [Bug 16896] New: New entries show wrong date and audit info Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16896 Bug ID: 16896 Summary: New entries show wrong date and audit info Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: renntekk at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Kohl version 3.02.05.000 When new catalogue entries are input, the date is recorded correctly but when reviewing the audit history. The dates appear as 2014 and shows that more than one librarian edited the entry although only one person has done any editing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 16:30:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 14:30:36 +0000 Subject: [Koha-bugs] [Bug 16897] New: Re-focus on "Add item" in Lists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16897 Bug ID: 16897 Summary: Re-focus on "Add item" in Lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Bug 11325 add solved a focus on "Add item" missing in Lists page. Since revamping of this page, the add item form exists both in page. The one corrected by Bug 11325 is not visible because it checks a bad var allowaddingitem instead of can_add_biblios. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 16:30:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 14:30:53 +0000 Subject: [Koha-bugs] [Bug 16897] Re-focus on "Add item" in Lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16897 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11325 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325 [Bug 11325] Focus on "Add item" in Lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 16:30:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 14:30:53 +0000 Subject: [Koha-bugs] [Bug 11325] Focus on "Add item" in Lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16897 [Bug 16897] Re-focus on "Add item" in Lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 16:31:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 14:31:27 +0000 Subject: [Koha-bugs] [Bug 16897] Re-focus on "Add item" in Lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16897 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 16:34:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 14:34:57 +0000 Subject: [Koha-bugs] [Bug 16888] Add Font Awesome Icons to Members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 53266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53266&action=edit Bug 16888: (follow-up)Add Font Awesome Icons to Members Remove fa-ban according with QA comment 4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 16:36:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 14:36:29 +0000 Subject: [Koha-bugs] [Bug 16888] Add Font Awesome Icons to Members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16888 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from H?ctor Eduardo Castro Avalos --- Keep signed-off since just removed a icon decoration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 16:36:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 14:36:42 +0000 Subject: [Koha-bugs] [Bug 16897] Re-focus on "Add item" in Lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16897 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 16:36:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 14:36:44 +0000 Subject: [Koha-bugs] [Bug 16897] Re-focus on "Add item" in Lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16897 --- Comment #1 from Fridolin SOMERS --- Created attachment 53267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53267&action=edit Bug 16897 - Re-focus on "Add item" in Lists Bug 11325 add solved a focus on "Add item" missing in Lists page. Since revamping of this page, the add item form exists both in page. The one corrected by Bug 11325 is not visible because it checks a bad var allowaddingitem instead of can_add_biblios. This patch corrects removes the first form and corrects the second form. It moves the form at left part of page so that it is always shown (usefull when there are a lot of items). It doe not add the list name after "Add item" besause it whould be huggly for long names and because listname already exists in breadscrumbs and on top of the table. It also adds autocomplete="off" on barcode input because there can be problems with a scanning device. Test instructions: 1. Create a list 2. Make sure you have an object with an assigned barcode 3. Go to the list => The barcode entry interface should be at left and has the focus 4. Enter the barcode and press enter (or use a scanner) => The item is added to the list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 16:54:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 14:54:29 +0000 Subject: [Koha-bugs] [Bug 16895] Allow writeoffs via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 16:56:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 14:56:09 +0000 Subject: [Koha-bugs] [Bug 16895] Allow writeoffs via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 16:56:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 14:56:12 +0000 Subject: [Koha-bugs] [Bug 16895] Allow writeoffs via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 --- Comment #1 from Kyle M Hall --- Created attachment 53268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53268&action=edit Bug 16895 - Allow writeoffs via SIP2 Many SIP2 services such as those by Comprise Technologies are able to or require that an ILS be able to accept writeoffs via SIP2. The SIP2 protocol specifies that payment type be a two digit number, but does not specify a code for writeoffs. To this end we should allow the write-off code to be specified in the SIP2 config on a per-account basis so that if different vendors use different fixed codes for write-offs we can handle that gracefully. Test Plan: 1) Apply this patch 2) Modify your SIP2 config to include payment_type_writeoff="06" in the login portion of the account you will be using for the test. 3) Restart your SIP2 server 4) Create a fee for a patron 5) Send a SIP2 fee paid message specifying the payment type code we defined earlier, with a payment amount that is *not* equal to the amount outstanding for the fee. 6) Note the fee paid response indicates the payment failed 7) Repeat step 5, but this time send the amount outstanding as the payment amount 8) Note that the fee paid response indicates a successful payment 9) Note in Koha that the fee has been written off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 16:56:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 14:56:19 +0000 Subject: [Koha-bugs] [Bug 16895] Allow writeoffs via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 [Bug 16757] Add ability to pay fee by id for SIP2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 16:56:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 14:56:19 +0000 Subject: [Koha-bugs] [Bug 16757] Add ability to pay fee by id for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 [Bug 16895] Allow writeoffs via SIP2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 17:19:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 15:19:54 +0000 Subject: [Koha-bugs] [Bug 16621] Translatability: Issues in opac-user.tt (sentence splitting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 17:19:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 15:19:57 +0000 Subject: [Koha-bugs] [Bug 16621] Translatability: Issues in opac-user.tt (sentence splitting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53252|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 53269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53269&action=edit [SIGNED-OFF] Bug 16621: Translatability: Issues in opac-user.tt (sentence splitting) This patch fixes issues due to sentence splitting in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Note: This is a string patch. It does not add or change functionallity. To test: - Examine code and verify that the text changes remove sentence splitting and that the changes make sense. - Log in to OPAC and verify that messages look correct - with blocked /debarred user (with and without comment and date) - with user who has to much fines (needs syspref OpacRenewalAllowed and syspref OPACFineNoRenewals) - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information (with and without syspref OPACPatronDetails set to Allow) Note: Amended to make patch apply 2016-07-10 mv Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 17:25:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 15:25:49 +0000 Subject: [Koha-bugs] [Bug 16893] Missing closing tag disrupts patron detail page style In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53265|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 53270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53270&action=edit [SIGNED-OFF]Bug 16893: Missing closing tag disrupts patron detail page style A missing closing causes the the patron detail page to be in all italics if the patron has a restriction message. This patch corrects it. To test, apply the patch and locate a patron who has a restriction message. The restriction message should be in italics but the rest of the page should display normally. Signed-off-by: Hector Castro Rest of the page displayed normally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 17:26:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 15:26:00 +0000 Subject: [Koha-bugs] [Bug 16893] Missing closing tag disrupts patron detail page style In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 17:28:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 15:28:54 +0000 Subject: [Koha-bugs] [Bug 16898] New: Show patron restriction details on OPAC user page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16898 Bug ID: 16898 Summary: Show patron restriction details on OPAC user page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Right now if you have multiple restrictions on your account, the details of those restrictions are all string together in the message which displays in the OPAC. We should display details for each separate restriction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 17:28:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 15:28:54 +0000 Subject: [Koha-bugs] [Bug 16621] Translatability: Issues in opac-user.tt (sentence splitting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16898 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 17:33:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 15:33:57 +0000 Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 --- Comment #3 from Lari Taskula --- Created attachment 53271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53271&action=edit Bug 16826: Add API route for getting item availability GET /availability/items?itemnumber=123 GET /availability/items?itemnumber=123+456+789 GET /availability/items?biblionumber=321 GET /availability/items?biblionumber=321+654+987 This patch adds above routes for checking item availability. The route does not require login and does not consider patron status, as its purpose is to be fast and efficient in checking general availability of item(s), much like in a typical search. Because of this, this route does not tell us whether item is holdable or available for checkout for a specific patron. Patron-specific availability will be introduced in another patch. For this route, item is NOT available if: - item on loan, - item reserved, - item withdrawn, - item lost, - item restricted, - item or itemtype not for loan Depending on system preference, item may or may not be available: - item damaged (depending on AllowHoldsOnDamagedItems), The returned information is some necessary item information combined with: - available (bool) - availability_description ((array of strings) reasons for possible restrictions to availability, such as ["notforloan"]) - hold_queue_length (int) - expected_available ((string) due date if onloan) Possible values in availability_description are an empty array and any of: "onloan", "reserved", "damaged", "withdrawn", "itemlost", "restricted", "notforloan", "ordered" Patch adds $item->get_availability() in Koha::Items and introduces a new Koha::Item::Availability class where we can store item-related availability information. Includes REST tests and unit tests for new subroutines in Koha::Item and Koha::Item::Availability. To test: 1. Play around with an item. Place a hold on it, checkout, set it damaged etc. 2. Make GET requests to /api/v1/availability/items?itemnumber=YYY, where YYY is an existing itemnumber. You can also try with biblionumber=XXX query parameter, where XXX is an existing biblionumber. 3. Check that the availability status is as described in the patch description above. Also make sure reasons for unavailability are in availability_description. 4. Repeat steps 1-3 until you are confident route works as expected. 5. Run the following tests: - t/Koha/Item/Availability.t - t/db_dependent/Items.t - t/db_dependent/api/v1/availability.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 17:36:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 15:36:35 +0000 Subject: [Koha-bugs] [Bug 16899] New: Add ability to disallow overpayments Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Bug ID: 16899 Summary: Add ability to disallow overpayments Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Some SIP services ( such as Comprise ) require that an attempt at over-paying a patron's account via SIP2 should fail, rather than create a credit on the account. We should make this a configurable option on a per-login basis in the SIP2 config file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 17:36:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 15:36:44 +0000 Subject: [Koha-bugs] [Bug 16899] Add ability to disallow overpayments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 [Bug 16895] Allow writeoffs via SIP2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 17:36:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 15:36:44 +0000 Subject: [Koha-bugs] [Bug 16895] Allow writeoffs via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16899 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 [Bug 16899] Add ability to disallow overpayments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 17:40:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 15:40:06 +0000 Subject: [Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- Sorry, this isn't working for me at all. There is no change in behavior after the patch is applied. Switching language via the URL still works, but using the language-switcher afterwards still fails. The URL is not modified. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 17:49:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 15:49:36 +0000 Subject: [Koha-bugs] [Bug 15131] Give SCO separate control for AllowItemsOnHoldCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15131 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 17:55:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 15:55:12 +0000 Subject: [Koha-bugs] [Bug 16899] Add ability to disallow overpayments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 17:55:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 15:55:15 +0000 Subject: [Koha-bugs] [Bug 16899] Add ability to disallow overpayments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 --- Comment #1 from Kyle M Hall --- Created attachment 53272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53272&action=edit Bug 16899 - Add ability to disallow overpayments Some SIP services ( such as Comprise ) require that an attempt at over-paying a patron's account via SIP2 should fail, rather than create a credit on the account. We should make this a configurable option on a per-login basis in the SIP2 config file. Test Plan: 1) Apply this patch 2) Enable the new parameter disallow_overpayment="1" for the login to be used in this test. 3) Restart your SIP server 4) Create or find a patron with fines 5) Attempt to send a payment via SIP for more than what the patron's balance is 6) Note the response indicates a payment failure 7) Attempt to send a payment via SIP for the account balance or less 8) Note the response indicates the payment has succeeded 9) Verify in Koha that the payment was processed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 17:59:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 15:59:59 +0000 Subject: [Koha-bugs] [Bug 15131] Give SCO separate control for AllowItemsOnHoldCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15131 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 53273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53273&action=edit Bug 15131: Instroduce AllowItemsOnHoldCheckoutSCO syspref This patch introduces a new syspref AllowItemsOnHoldCheckoutSCO, so the current AllowItemsOnHoldCheckout syspref can be decoupled for the SCO module, giving the library more flexibility. During upgrade, it gets its value from the original AllowItemsOnHoldCheckout syspref. Sponsored-by: NEKLS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 18:00:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 16:00:02 +0000 Subject: [Koha-bugs] [Bug 15131] Give SCO separate control for AllowItemsOnHoldCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15131 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 53274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53274&action=edit Bug 15131: Make SCO use the new syspref. This patch just makes SCO use the new syspref (AllowItemsOnHoldCheckoutSCO) instead of the old one, thus making it configurable, separate from the non-SCO syspref. Sponsored-by: NEKLS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 18:00:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 16:00:25 +0000 Subject: [Koha-bugs] [Bug 15131] Give SCO separate control for AllowItemsOnHoldCheckout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15131 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 18:16:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 16:16:30 +0000 Subject: [Koha-bugs] [Bug 16899] Add ability to disallow overpayments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53272|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 53275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53275&action=edit Bug 16899 - Add ability to disallow overpayments Some SIP services ( such as Comprise ) require that an attempt at over-paying a patron's account via SIP2 should fail, rather than create a credit on the account. We should make this a configurable option on a per-login basis in the SIP2 config file. Test Plan: 1) Apply this patch 2) Enable the new parameter disallow_overpayment="1" for the login to be used in this test. 3) Restart your SIP server 4) Create or find a patron with fines 5) Attempt to send a payment via SIP for more than what the patron's balance is 6) Note the response indicates a payment failure 7) Attempt to send a payment via SIP for the account balance or less 8) Note the response indicates the payment has succeeded 9) Verify in Koha that the payment was processed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 18:21:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 16:21:27 +0000 Subject: [Koha-bugs] [Bug 16851] Move HasOverdues to Koha::Patron->has_overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- I'm getting an error when opening the circulation or patron detail pages for a patron: Template process failed: plugin error - Global symbol "$borrower" requires explicit package name at Koha/Template/Plugin/Borrowers.pm line 57. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Plugins.pm line 206. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 18:26:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 16:26:44 +0000 Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 --- Comment #4 from Lari Taskula --- (In reply to Ji?? Kozlovsk? from comment #2) > How about returning JSON with all the values possible? > > Let's say for availability: > { in_house: true, checkout: false } I think this is a good option for showing different types of availabilities. Anyway, to start pushing this feature forward, I wanted to upload a patch containing my current progress. It has the problem that I was thinking about earlier. For example the patch above considers an item with "notforloan" status as unavailable, while it could still be for reading room use. Btw, is this the definition of in-house use? Also, what other cases should we consider? I could modify this patch to better inform the different types of availabilities. Before that, it would be great to have input from others as well :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 18:29:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 16:29:24 +0000 Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53271|0 |1 is obsolete| | --- Comment #5 from Lari Taskula --- Created attachment 53276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53276&action=edit Bug 16826: Add API route for getting item availability -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 18:31:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 16:31:17 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #61 from Owen Leonard --- (In reply to Jonathan Druart from comment #40) > QA comment: > - The second patch modifies "Other phone" with "Mobile phone". "Other phone" > is used in master atm This is still true. Also, in both the OPAC and staff client the "main contact method" label is incorrectly capitalized. Template guidelines say that only the first letter should be upper case. There should also be a ":" after the label: "Main contact method:" Is there a plan for some functionality which is based on this setting? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 18:36:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 16:36:44 +0000 Subject: [Koha-bugs] [Bug 16876] Remove Full heading column in OPAC Authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16876 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 18:36:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 16:36:46 +0000 Subject: [Koha-bugs] [Bug 16876] Remove Full heading column in OPAC Authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16876 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53210|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 53277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53277&action=edit [SIGNED-OFF] Bug 16876: Remove Full Heading column from OPAC Auth search results To test: 1) Go to Authority Search and do a search 2) Notice that there is a Full Heading column that has 'View full heading' links. These take up a lot of space and don't mean a lot to the user 3) Apply patch and refresh 4) Notice that the the Full Heading column is gone and there is now a Details column next to the authorities. Confirm the link takes you to the expected authority detail page. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 19:54:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 17:54:05 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mehdi.hamidi at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 19:56:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 17:56:06 +0000 Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622 --- Comment #7 from M. Tompsett --- (In reply to Jacek Ablewicz from comment #4) > (In reply to M. Tompsett from comment #1) > > This line in C4/Auth_with_cas.pm is the culprit of all those warns: > > my $context = C4::Context->new() or die 'C4::Context->new failed'; > > ... Sadly, I believe it is necessary, even though $context is not used. > > Hm, why do you think this call is necessary in C4/Auth_with_cas.pm? I've re-evaluated whether it is necessary. I think the point of the line was to prevent further cascading errors. Auth_with_cas uses: intranetdir from the KOHA_CONF casServerUrl from the system preferences table OPACBaseURL from the system preferences table staffClientBaseURL from the system preferences table A simple use (as triggered by 00-load.t) should be fine with the line removed. A more complex use should bomb, so the problems can get fixed. :) Sorry for the worry about dragons, Jacek Ablewicz. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 11 20:24:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jul 2016 18:24:40 +0000 Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030 --- Comment #6 from Owen Leonard --- Would it be possible to return the branch to its original choice if > you choose "cancel" after changing it? I think that's a good idea. It would also be nice to have a spinner next to the pulldown while it's being updated. Right now I'm not seeing any real visual feedback that the update is in process or has completed. Take a look at the Animated Icons section here: http://fontawesome.io/examples/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 13:47:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 11:47:41 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from Marcel de Rooy --- (In reply to Liz Rea from comment #18) Hi, > However I still can't make the required hold notes work. Also was further > confused by bug 16391, which makes your plugins not show up in the list when > you go back to the page, even if they are installed. Removing method=tool > from the url makes them turn up. That's not your fault, it just caused me > trouble when I was testing. You are right. I made a remark on that report too. Could add a fake tool subroutine to make them show up, but that would not be a real solution. > The patches don't break anything that I can see. I was testing on current > master, 3692f92. Well, that is a major goal :) > Maybe you know something else I could be doing wrong? First verify that the plugin is installed etc., so we know that it is called. Pick a marc record with available item, change the leader (probably replace nam by nas), i.e. make sure that position 7 is the character s. Go to opac, place a hold on that specific record. If you unhide the options, you already should see the text line: Please enter additional information about the requested item. Pressing Place Hold should not work. Depending on the browser, the text box is marked red or something. If that is the case, you actually finished testing already (the hold note indeed is required now). Alternatively, you could also edit the plugin's Leader.pm, add a "return 1;" in the check subroutine near the top. Because we are not focusing on testing the plugin here but only the routine in Reserves calling available plugins. In that case messing with records is not needed.. Thanks again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 13:49:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 11:49:45 +0000 Subject: [Koha-bugs] [Bug 15419] Sipserver problem with stale db handles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 14:06:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 12:06:49 +0000 Subject: [Koha-bugs] [Bug 16937] Remove the use of "onclick" from the manage staged MARC records template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 14:06:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 12:06:51 +0000 Subject: [Koha-bugs] [Bug 16937] Remove the use of "onclick" from the manage staged MARC records template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53478|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 53509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53509&action=edit Bug 16937 - Remove "onclick" from the manage staged MARC records template This patch revises the manage staged MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Manage staged MARC records. - If necessary, stage a MARC file for import. - Click the name of the staged file and then the "Import this batch into the catalog" button. The batch should be correctly imported. - Return to the list of staged MARC files. - Click the name of an imported file and then the "Undo import into catalog" button. The import should be reverted. - Return to the list of staged MARC files. - Click the "Clean" button for any record. Confirm that the batch is cleaned. - For any cleaned record, click the "Delete" button. The batch should be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 14:07:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 12:07:45 +0000 Subject: [Koha-bugs] [Bug 16937] Remove the use of "onclick" from the manage staged MARC records template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 --- Comment #4 from Owen Leonard --- (In reply to H?ctor Eduardo Castro Avalos from comment #2) > Sorry but patch doesn't apply My fault: Forgot to squash all necessary commits. Please try again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 14:08:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 12:08:44 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #64 from Bouzid --- Hi H?ctor, You need apply all patch. For this conflict, I will rebase it. Bouzid. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 14:59:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 12:59:42 +0000 Subject: [Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on MARCdetail's items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 14:59:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 12:59:45 +0000 Subject: [Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on MARCdetail's items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53303|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 53510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53510&action=edit [SIGNED-OFF] Bug 16881 - Apply KohaTable and ColVis plugin on MARCdetail's items table Also, the columns displayed are saved for each users in database. Test plan: - apply this BZ, - launch perl installer/data/mysql/updatedatabase.pl - launch perl misc/devel/update_dbix_class_files.pl - go to the items tab on cgi-bin/koha/catalogue/MARCdetail.pl page you should be able to hide/show each columns. - leave this page and come back with the same koha account: You should have the same columns shown/hidden as when you left. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 15:42:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 13:42:38 +0000 Subject: [Koha-bugs] [Bug 16851] Move HasOverdues to Koha::Patron->has_overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 15:42:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 13:42:40 +0000 Subject: [Koha-bugs] [Bug 16851] Move HasOverdues to Koha::Patron->has_overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53325|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 53511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53511&action=edit Bug 16851: Move HasOverdues to Koha::Patron->has_overdues This patch just move C4::Members::HasOverdues to Koha::Patron->has_overdues and updated callers Test plan: No change in behavior is expected. 1/ If a patron is debarred and does not have overdues and AutoRemoveOverduesRestrictions is on, the debarment will be removed on checkin 2/ Add overdues and make sure the patron cannot renew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 15:44:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 13:44:26 +0000 Subject: [Koha-bugs] [Bug 16851] Move HasOverdues to Koha::Patron->has_overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 --- Comment #7 from Jonathan Druart --- Conflicts with bug 16853 fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 15:45:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 13:45:40 +0000 Subject: [Koha-bugs] [Bug 16850] Move IsMemberBlocked to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 15:45:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 13:45:42 +0000 Subject: [Koha-bugs] [Bug 16850] Move IsMemberBlocked to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53095|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 53512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53512&action=edit Bug 16850: Add test coverage for CanBookBeIssued -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 15:45:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 13:45:45 +0000 Subject: [Koha-bugs] [Bug 16850] Move IsMemberBlocked to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53247|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 53513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53513&action=edit Bug 16850: Remove C4::Members::IsMemberBlocked This subroutine is only called once and can be replaced with a call to is_debarred and has_overdues. Note that prior to this patch, IsMemberBlocked copy/paste code from HasOverdues, which did not make sense. Test plan: Debar a patron and make sure he is not able to checkout (the librarian is asked to overwrite if OverduesBlockCirc is set to 'confirmation') Remove the debarment and add overdues to this patron, same as previously, the checkout should be blocked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 15:57:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 13:57:20 +0000 Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 15:57:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 13:57:22 +0000 Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53338|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 53514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53514&action=edit Bug 16911: Koha::Patron::Categories - Add tests for ->get_expiry_date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 15:57:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 13:57:26 +0000 Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53339|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 53515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53515&action=edit Bug 16911: Koha::Patron::Categories - Move GetExpiryDate to ->get_expiry_date This patch moves the code from C4::Members::GetExpiryDate to Koha::Patron::Categories. Nothing much exiting, please follow test plan in next patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 15:57:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 13:57:30 +0000 Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53340|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 53516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53516&action=edit Bug 16911: Koha::Patrons - Add tests for ->extend_subscription -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 15:57:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 13:57:33 +0000 Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53341|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 53517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53517&action=edit Bug 16911: Koha::Patrons - Move ExtendMemberSubscriptionTo to ->extend_subscription This patch moves the code from C4::Members::ExtendMemberSubscriptionTo to Koha::Patron->extend_subscription. The expected behavior is: When a new patron is created, the enrolment period defined for the patron category is used unless an enrolment period date is defined. In that case, this date is used. When an account is renewed, the pref BorrowerRenewalPeriodBase is used to determine if the subscription is renewed from today or from the day when his/her account has expired. Test plan: Confirm that the behavior is correct before this patch and that it's still the same after this patchset applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 15:57:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 13:57:36 +0000 Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53346|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 53518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53518&action=edit Bug 16911: Rename extend_subscription with renew_account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:00:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:00:15 +0000 Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53342|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53519&action=edit Bug 16912: Koha::Patrons - Move and rewrite tests for AddEnrolmentFeeIfNeeded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:00:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:00:18 +0000 Subject: [Koha-bugs] [Bug 16912] Koha:: Patrons - Move AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53343|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 53520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53520&action=edit Bug 16912: Koha::Patrons - Move AddEnrolmentFeeIfNeeded to ->add_enrolment_fee_if_needed This patch moves the code of the C4::Members::AddEnrolmentFeeIfNeeded subroutine to the Koha::Patron->add_enrolment_fee_if_needed method. The behavior should be unchanged. Test plan: 1/ Define enrolment fee for 2 patron categories 2/ Create a patron using the first category => The patron should be charged 3/ Change the patron category to the other one => The patron should be charged again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:02:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:02:30 +0000 Subject: [Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 --- Comment #8 from Jonathan Druart --- (In reply to Liz Rea from comment #7) > Applying: Bug 16344: Add a circ rule to limit the auto renewals given a > specific > fatal: sha1 information is lacking or useless (C4/Circulation.pm). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 16344: Add a circ rule to limit the auto renewals > given a specific > > :( It applies cleanly on top of bug 15581. Please try again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:02:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:02:45 +0000 Subject: [Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:04:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:04:56 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50678|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 53521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53521&action=edit Bug 15582: Ability to block auto renewals if OPACFineNoRenewals is reached If a patron owes more than the OPACFineNoRenewals value, the issue won't be auto renewed anymore (driven by the new pref OPACFineNoRenewalsBlockAutoRenew). Test plan: Note: You will have to manually change data in your DB, make sure you have access to the sql cli. 1/ Set the OPACFineNoRenewals to 5 (for instance) 2/ Set OPACFineNoRenewalsBlockAutoRenew to block 3/ Check an item out to a patron and mark is as an auto renewal 4/ Make sure the patron does not have any fees or charges. 5/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed 6/ Create an invoice for this patron with a amount > OPACFineNoRenewals (6 for instance) 7/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has not been renewed. 8/ Set OPACFineNoRenewalsBlockAutoRenew to allow 9/ Execute the automatic renewals cronjob script (misc/cronjobs/automatic_renewals.pl) Confirm that the issue has been renewed Sponsored-by: University of the Arts London -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:06:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:06:27 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #17 from Jonathan Druart --- (In reply to Liz Rea from comment #15) > Applying: Bug 15582: Ability to block auto renewals if OPACFineNoRenewals is > reached > fatal: sha1 information is lacking or useless (C4/Circulation.pm). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 15582: Ability to block auto renewals if > OPACFineNoRenewals is reached Easy conflict in tests fixed, but did not get the sha1 error. Make sure you have applied patches from bug 15581 and bug 16344 before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:09:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:09:16 +0000 Subject: [Koha-bugs] [Bug 16891] Move MoveMemberToDeleted to Koha::Patron->move_to_deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:09:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:09:19 +0000 Subject: [Koha-bugs] [Bug 16891] Move MoveMemberToDeleted to Koha::Patron->move_to_deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53249|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 53522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53522&action=edit Bug 16891: Move C4::Members::MoveMemberToDeleted to Koha::Patron->move_to_deleted This patch removes the C4::Members::MoveMemberToDeleted subroutine in order to replace it with the Koha::Patron->move_to_deleted method. Next after this change, we will move C4::Members::HandleDelBorrower and C4::Members::DelMember to the same module to simplify the code in members/deletemem.pl and misc/cronjobs/delete_patrons.pl Test plan: 1/ Delete a patron from the staff interface and make sure (s)he has been moved to the deletedborrowers table. 2/ Use the "Batch patron deletion" tool (tools/cleanborrowers.pl) to remove patron. Make sure the "Permanently delete these patrons" and "Move these patrons to the trash" options work as before 3/ Same as previously but using the cronjob misc/cronjobs/delete_patrons.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:14:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:14:34 +0000 Subject: [Koha-bugs] [Bug 16907] Move DelMember and HandleDelBorrower to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:14:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:14:37 +0000 Subject: [Koha-bugs] [Bug 16907] Move DelMember and HandleDelBorrower to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53327|0 |1 is obsolete| | Attachment #53328|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53523&action=edit Bug 16907: Koha::Patrons - Move DelMember to ->delete This patch moves the C4::Members::DelMember subroutine to the Koha::Patron module. The delete method must be overwritten to permit handling of patron's holds. Test plan: (With the 2 patches applied) 1/ Create a patron with holds and owner of lists 2/ Delete patrons using the web interface: - More > Delete on a patron page - Batch patron deletion tools 3/ and the cronjob script - perl misc/cronjobs/delete_patrons.pl -c [more options] The patron should have been moved to the deletedborrowers table, his/her holds and lists should have been deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:14:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:14:40 +0000 Subject: [Koha-bugs] [Bug 16907] Move DelMember and HandleDelBorrower to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 --- Comment #4 from Jonathan Druart --- Created attachment 53524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53524&action=edit Bug 16907: Koha::Patrons - Move HandleDelBorrower to ->delete This job should be done each time patron data are deleted. It's better to do it just before deleting the patron than assuming the caller did the job by itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:19:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:19:27 +0000 Subject: [Koha-bugs] [Bug 16906] Add DataTables pagination and filter to top of saved SQL reports table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:19:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:19:29 +0000 Subject: [Koha-bugs] [Bug 16906] Add DataTables pagination and filter to top of saved SQL reports table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53336|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 53525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53525&action=edit Bug 16906 - Add DataTables pagination and filter to top of saved SQL reports table This patch adds a DataTables toolbar to the top of the saved SQL reports table so that pagination and filtering controls are at the top as well as the bottom. To test, apply the patch and go to Reports -> Saved reports. There should be controls at the top of the table of saved reports for setting number of results, pagination, and searching. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:19:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:19:32 +0000 Subject: [Koha-bugs] [Bug 16906] Add DataTables pagination and filter to top of saved SQL reports table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 --- Comment #6 from Jonathan Druart --- Created attachment 53526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53526&action=edit Bug 16906: Simply remove the sDom definition to use the default one Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:28:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:28:03 +0000 Subject: [Koha-bugs] [Bug 16940] Show active currency's symbol to users in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16940 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- (In reply to Katrin Fischer from comment #0) > It would be nice if we could show the currency symbol in the OPAC. > > Formatting could be another system preference or maybe be wrapped into the > existing CurrencyFormat system preference. As I said on bug 4078 comment 20, the formatting should be done at the currency table level. I planned to fix the display of the different prices when the tax rewrite stack will be pushed... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:36:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:36:08 +0000 Subject: [Koha-bugs] [Bug 16852] Remove C4::Members::GetBorrowerCategorycode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 --- Comment #3 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #2) Hi Srdjan, Yes you are right, both remarks are valid. I'd prefer to do that changes on another report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:43:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:43:40 +0000 Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 --- Comment #5 from Jonathan Druart --- I'd prefer to see a generate_csrf method than a CSRF flag. It'd be better to use instead of require the 2 modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:53:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:53:32 +0000 Subject: [Koha-bugs] [Bug 16945] New: Syspref PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16945 Bug ID: 16945 Summary: Syspref PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In OPAC, patron self registration works only when PatronSelfRegistrationDefaultCategory is set to a valid patron category. Add a note for PatronSelfRegistration on Home > Administration > System preferences. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:54:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:54:51 +0000 Subject: [Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53091|0 |1 is obsolete| | --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 53527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53527&action=edit Bug 16847: Remove C4::Members::GetTitles This subroutine just reads the content of a pref, split it, add an empty string and returns. It is not really useful and the code in the script (memberentry.pl) uses the only occurrence of CGI::popup_menu Let's remove it and build the dropdown list in the template. Test plan: 1/ Empty BorrowersTitles, edit a patron and confirm that the "Salutation" does not appear 2/ Fill BorrowersTitles with "Mr|Mrs|Miss|Ms", edit a patron and confirm that the "Salutation" dropdown list is correctly filled. The default option should be selected if you are editing a patron with a title defined. This should also be tested at the OPAC. Followed test pan, works as expected in Staff and OPAC Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:54:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:54:56 +0000 Subject: [Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53092|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 53528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53528&action=edit Bug 16847: Add empty option to Salutation/title At the OPAC there is no way to empty this value. I think it should be allowed to empty it. Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:55:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:55:19 +0000 Subject: [Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:59:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:59:02 +0000 Subject: [Koha-bugs] [Bug 16934] Cannot add notes to canceled and deleted order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934 --- Comment #4 from Kyle M Hall --- My bad, the test plan should be: Test Plan: 1) Create a basket with an orderline 2) Delete the record 3) Click the "Add internal note" link for that order line 4) Fill in a note and click "Save" 5) Note the error 6) Apply this patch 7) Repeat steps 3-4 8) Note this time the note is saved! The situation arises when the record is deleted but the order is not canceled. I also wonder why we are preventing librarian's from adding notes to a canceled order. It seems like a useful feature. Outside the scope of this bug report though. Once this bug is fixed I'll probably submit a new enhancement for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:59:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:59:24 +0000 Subject: [Koha-bugs] [Bug 16937] Remove the use of "onclick" from the manage staged MARC records template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53509|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 53529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53529&action=edit [SIGNED-OFF]Bug 16937: Remove "onclick" from the manage staged MARC records template This patch revises the manage staged MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Manage staged MARC records. - If necessary, stage a MARC file for import. - Click the name of the staged file and then the "Import this batch into the catalog" button. The batch should be correctly imported. - Return to the list of staged MARC files. - Click the name of an imported file and then the "Undo import into catalog" button. The import should be reverted. - Return to the list of staged MARC files. - Click the "Clean" button for any record. Confirm that the batch is cleaned. - For any cleaned record, click the "Delete" button. The batch should be deleted. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 16:59:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 14:59:39 +0000 Subject: [Koha-bugs] [Bug 16937] Remove the use of "onclick" from the manage staged MARC records template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 17:00:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 15:00:54 +0000 Subject: [Koha-bugs] [Bug 16945] Syspref PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16945 --- Comment #1 from Marc V?ron --- Created attachment 53530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53530&action=edit Bug 16945: PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory In OPAC, patron self registration works only when PatronSelfRegistrationDefaultCategory is set to a valid patron category. This patch adds a note for PatronSelfRegistration on Home > Administration > System preferences. To test: - Apply patch - In staff client, search system preferences for PatronSelfRegistration - Verify that note appears with PatronSelfRegistration -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 17:01:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 15:01:38 +0000 Subject: [Koha-bugs] [Bug 16945] Syspref PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16945 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 17:05:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 15:05:53 +0000 Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 --- Comment #6 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #5) > I'd prefer to see a generate_csrf method than a CSRF flag. > It'd be better to use instead of require the 2 modules. Well, we could add generate_csrf of course. The flag on itself is kind of a shortcut for type => $type. The require is just performance: no need to load it for general use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 17:07:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 15:07:23 +0000 Subject: [Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 --- Comment #18 from Owen Leonard --- (In reply to Jonathan Druart from comment #16) > Aleisha, when deleting items using the batch item deletion tools, I now get > 2 "Return to batch item deletion": 1 button and 1 link. Having both the link and the button makes sense with batch item modifications when the list of modified items is displayed. On the batch item deletion confirmation screen I think we should move the button into the [% IF ( not_deleted_loop ) %] block so that it is only shown if the page is listing items which could not be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 17:28:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 15:28:13 +0000 Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Kyle, the following test should fail without this patch: is( $prepared_letter->{content}, $hold->id(), 'Hold object used correctly' ); Could you please adapt it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 17:29:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 15:29:57 +0000 Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 --- Comment #7 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #6) > The require is just performance: no need to load it for general use. It's not recommended. For instance if the module is missing of buggy, we want to know it at the compilation step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 17:39:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 15:39:37 +0000 Subject: [Koha-bugs] [Bug 16946] New: Remove the use of "onclick" from several serials templates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Bug ID: 16946 Summary: Remove the use of "onclick" from several serials templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com There are many uses of "onclick" and other event attributes in the Serials module templates. This bug will track changes to several of them: checkexpiration.tt claims.tt result.tt routing-preview-slip.tt routing-preview.tt routing.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 17:47:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 15:47:05 +0000 Subject: [Koha-bugs] [Bug 13435] OPAC self registration can' t find OPAC_REG_VERIFY notice if it is assigned to a branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13435 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Nicole C. Engard --- We allow patrons to pick a branch now I believe - I'm sorry I didn't see this sooner :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 17:48:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 15:48:48 +0000 Subject: [Koha-bugs] [Bug 12798] 'dontmerge' syspref has incorrect usage description, in manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12798 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 17:49:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 15:49:49 +0000 Subject: [Koha-bugs] [Bug 10816] Relational operators in Search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10816 --- Comment #1 from Nicole C. Engard --- So, how should we edit this section? I didn't write this guide so I'm open to tips/suggestions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 17:59:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 15:59:36 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 17:59:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 15:59:39 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #54 from Kyle M Hall --- Created attachment 53531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53531&action=edit Bug 11360 [QA Followup] - Fix styles and button order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 18:01:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 16:01:02 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #55 from Kyle M Hall --- (In reply to Katrin Fischer from comment #53) > Long read... and I have also tested this a bit: I believe this followup should take care of your concerns! We can't do much about the buttons breaking over two lines. I believe that's just the way Bootstrap deals with it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 18:07:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 16:07:23 +0000 Subject: [Koha-bugs] [Bug 16293] Patron Card Batches documentation is incomplete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16293 --- Comment #2 from Nicole C. Engard --- This is a strange one - it's in the code for the manual - so I tried to fix this and we'll see tomorrow when the HTML is generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 18:42:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 16:42:03 +0000 Subject: [Koha-bugs] [Bug 16946] Remove the use of "onclick" from several serials templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 18:42:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 16:42:05 +0000 Subject: [Koha-bugs] [Bug 16946] Remove the use of "onclick" from several serials templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 --- Comment #1 from Owen Leonard --- Created attachment 53532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53532&action=edit Bug 16946 - Remove the use of "onclick" from several serials templates This patch modifies several serials module templates to remove the use of event attributes. Events will now be defined in JavaScript. Also changed: - In Serials -> Check expiration, custom form validation has been removed in favor of validation with the plugin. - In Serials -> Claims, the "Clear filter" button has been replaced with a link. Error messages are now styled with the standard "alert" class. - In Serials -> New subscription -> Search for record, the "choose" link is now a Bootstrap button. Pagination links are now styled like other similar links. The "Close" button is now styled as in other popup windows. The "no results found" messages is styled as an informational dialog. - In Serials -> Subscription -> Edit routing list, the "add recipients" and "delete all" controls are now links with Font Awesome icons. To test, apply the patch and: - Go to Serials -> Check expiration. - Try to submit the form without filling in a date. The form validation plugin should warn you that the date field is required. - Submit the form using data which will return results. - Click the "Renew" button for any result. The subscription renewal popup should be triggered for the correct title. - Go to Serials -> Claims. - Select a vendor with missing issues. - Confirm that the date filter works correctly, and that the "Clear filter" link works. - Select one or more result and click the "Send notification" button. The notification should be sent. - Go to Serials -> New subscription. - Click the "Search for record" link to trigger the bibliographic search popup. - Perform a search. Confirm that the "Choose" button selects the correct record and populates the fields in the parent window. - Go to Serials -> Subscription -> Edit routing list. - Confirm that the process of adding recipients to the list works correctly. - Confirm that changing the rank of any recipient works correctly. - Save the routing list and click the "Save and preview routing slip" button on the confirmation page. The slip preview should open. - In the slip preview window, test that the print button works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 18:49:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 16:49:32 +0000 Subject: [Koha-bugs] [Bug 16947] New: Can not modify patron messaging preferences Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Bug ID: 16947 Summary: Can not modify patron messaging preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It is no longer possible to modify messaging preferences for an existing patron. To verify: - Set syspref 'EnhancedMessagingPreferences' to 'Allow' - In staff client, go to a patron's detail page - Edit Patron messaging preferences (using link below table) - Save Result: Form does not save, stays open JavaScript error in intranet-tmpl/prog/js/members.js line 107 TypeError: document.form.password is undefined Note: Changing settings from OPAC works (needs EnhancedMessagingPreferencesOPAC) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 19:00:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 17:00:01 +0000 Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Owen Leonard --- This seems to work correctly with a patron category which has a fixed expiration date, but when I try to add a patron with an enrollment period defined in months I get an error: Can't locate object method "add" via package "2016-07-06" (perhaps you forgot to load "2016-07-06"?) at Koha/Patron/Category.pm line 185. "2016-07-06" is the date I entered in the "registration date" field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 20:06:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 18:06:37 +0000 Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 20:06:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 18:06:40 +0000 Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911 --- Comment #13 from Jonathan Druart --- Created attachment 53533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53533&action=edit Bug 16911: ->get_expiry_date accepts strings To make sure nothing else will be broken, it's certainly better to handle date strings in a first phase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 20:07:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 18:07:53 +0000 Subject: [Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911 --- Comment #14 from Jonathan Druart --- (In reply to Owen Leonard from comment #12) > This seems to work correctly with a patron category which has a fixed > expiration date, but when I try to add a patron with an enrollment period > defined in months I get an error: > > Can't locate object method "add" via package "2016-07-06" (perhaps you > forgot to load "2016-07-06"?) at Koha/Patron/Category.pm line 185. > > "2016-07-06" is the date I entered in the "registration date" field. Good catch Owen, I did not try that case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 21:03:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 19:03:22 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #34 from Mehdi Hamidi --- Created attachment 53534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53534&action=edit Bug 12446 - Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 21:06:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 19:06:07 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50953|0 |1 is obsolete| | Attachment #53534|0 |1 is obsolete| | --- Comment #35 from Mehdi Hamidi --- Created attachment 53535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53535&action=edit Bug 12446 - Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 21:10:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 19:10:39 +0000 Subject: [Koha-bugs] [Bug 14907] Item search: Call Numbers in Item search results are ordered alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14907 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 21:11:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 19:11:10 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |mehdi.hamidi at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 21:51:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 19:51:04 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53535|0 |1 is obsolete| | --- Comment #36 from Mehdi Hamidi --- Created attachment 53536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53536&action=edit Bug 12446 - Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 22:11:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 20:11:16 +0000 Subject: [Koha-bugs] [Bug 16934] Cannot add notes to canceled and deleted order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 22:11:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 20:11:19 +0000 Subject: [Koha-bugs] [Bug 16934] Cannot add notes to canceled and deleted order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53472|0 |1 is obsolete| | --- Comment #5 from Claire Gravely --- Created attachment 53537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53537&action=edit Bug 16934 - Cannot add notes to canceled and deleted order line Some librarians would like to be able to add notes to deleted order lines to keep track of data such as what title the order line was for. For some reason ModOrder dies if a biblionumber is passed in, even though it does not use biblionumber and does not need it to exist in any fashion! This limitation should be removed. Test Plan: 1) Create a basket with an orderline 2) Cancel the order / delete the record 3) Click the "Add internal note" link for that order line 4) Fill in a note and click "Save" 5) Note the error 6) Apply this patch 7) Repeat steps 3-4 8) Note this time the note is saved! Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 23:09:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 21:09:09 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #32 from Christopher Brannon --- What version will this feature be available in? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 23:17:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 21:17:12 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #33 from Nick Clemens --- (In reply to Christopher Brannon from comment #32) > What version will this feature be available in? Hi Christopher, This should be in 16.05 (the version following 3.22), as an enhancement it is not likely to be backported to any earlier versions. -Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 23:17:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 21:17:14 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 23:17:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 21:17:17 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53484|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 53538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53538&action=edit Bug 16939: Making all 'add to basket' actions buttons Edit: Fixing 'clas' typo in addorderiso2709.tt To test: 1) Go to Acqui -> find a vendor -> view a basket 2) Click add to basket -> fill in 'for an existing record' and hit search 3) 'View MARC' and 'Order' buttons should show under an Actions column with appropriate icons 4) Click Order 5) Click add item when you are redirected to the New order page (no need to fill in any details) 6) Confirm that 'Edit' and 'Delete' buttons now show under an Actions column with appropriate icons 7) Go back to your basket and click add to basket -> from a subscription (we are skipping from a suggestion because this already has a button before my patch) 8) Confirm that 'Order' shows as a button with appropriate icon 9) Go back to your basket and click add to basket -> from an external source 10) fill in any fields and click search to bring up results 11) 'Order' should now show as a button with appropriate icons. MARC and Card preview have been moved into a dropdown menu - confirm this works as expected. Links have not been changed when clicking on a row 12) Go back to your basket and click add to basket -> from a staged file 13) 'Add orders' should now show as a button with appropriate icon 14) Go back to your basket and click add to basket -> from titles with highest hold ratios 15) 'X to order' should now show as a button with appropriate icon Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 23:45:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 21:45:09 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #20 from Liz Rea --- Hi Marcel, I think I see what I did wrong now - I was testing this in the staff client! How very silly of me. Will give it one more go today, you know, doing it properly. :) Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 20 23:57:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 21:57:08 +0000 Subject: [Koha-bugs] [Bug 16948] New: 'Return to batch item deletion' button should only show when there are items that could not be deleted Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948 Bug ID: 16948 Summary: 'Return to batch item deletion' button should only show when there are items that could not be deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Referring to Owen Leonard's comment from Bug 15824: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824#c18 Having both the link and the button makes sense with batch item modifications when the list of modified items is displayed. On the batch item deletion confirmation screen I think we should move the button into the [% IF ( not_deleted_loop ) %] block so that it is only shown if the page is listing items which could not be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 00:04:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 22:04:55 +0000 Subject: [Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 00:04:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 22:04:59 +0000 Subject: [Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948 --- Comment #1 from Aleisha Amohia --- Created attachment 53539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53539&action=edit Bug 16948: 'Return to batch item deletion' button should only show when there are items that could not be deleted To test: 1) Go to Tools --> Batch item deletion 2) Put in an item barcode and click Continue 3) Deselect the item (so that you don't actually delete it) and click Delete selected items 4) Notice there are two links that say 'Return to batch item deletion' - one as a link and one as a button. 5) Apply patch and refresh page. You may have to go back and resend the form 6) Button should be gone, only one link shows. 7) Check out the same item that you are testing with to a patron 8) Put the barcode into batch item deletion again and follow the prompts. Do not deselect it after clicking Continue this time. (It will not be deleted as it has been checked out). 9) After clicking Delete selected items, you should be redirected and see a table with the item in it and the reason it can't be deleted. The button and the link saying 'Return to batch item deletion' should both be present. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 00:05:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 22:05:34 +0000 Subject: [Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 --- Comment #19 from Aleisha Amohia --- (In reply to Owen Leonard from comment #18) > (In reply to Jonathan Druart from comment #16) > > Aleisha, when deleting items using the batch item deletion tools, I now get > > 2 "Return to batch item deletion": 1 button and 1 link. > > Having both the link and the button makes sense with batch item > modifications when the list of modified items is displayed. > > On the batch item deletion confirmation screen I think we should move the > button into the [% IF ( not_deleted_loop ) %] block so that it is only shown > if the page is listing items which could not be deleted. See Bug 16948 for a fix for this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 00:05:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 22:05:44 +0000 Subject: [Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 00:13:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 22:13:16 +0000 Subject: [Koha-bugs] [Bug 16949] New: Batch record deletion says success when no records have been passed in Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949 Bug ID: 16949 Summary: Batch record deletion says success when no records have been passed in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: 1) Go to Tools -> Batch record deletion 2) Put in a record number and click Continue 3) Deselect the record so that it doesn't actually delete and click Delete selected records 4) Page says All records have been deleted successfully! --> Error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 00:17:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 22:17:13 +0000 Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no records have been passed in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 00:17:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 22:17:17 +0000 Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no records have been passed in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949 --- Comment #1 from Aleisha Amohia --- Created attachment 53540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53540&action=edit Bug 16949: Batch record deletion says success when no records have been passed in The reason this happens is because the page will say success when the total number of records given equals the total number of successful deletions. If you pass in no records, there are no successful deletions --> 0 = 0 --> it thinks it has been successful. This patch adds a check that, firstly, there were records to delete. To test: 1) Go to Tools -> Batch record deletion 2) Put in a record number and click Continue 3) Deselect the record so that it doesn't actually delete and click Delete selected records 4) Page says 'All records have been deleted successfully!' 5) Apply patch and refresh page. You may have to go back and resend the form 6) Page should now correctly say 'No record has been deleted. An error occurred.' Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 00:17:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 22:17:40 +0000 Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no records have been passed in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 00:48:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 22:48:45 +0000 Subject: [Koha-bugs] [Bug 16946] Remove the use of "onclick" from several serials templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 00:48:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 22:48:48 +0000 Subject: [Koha-bugs] [Bug 16946] Remove the use of "onclick" from several serials templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53532|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 53541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53541&action=edit [SIGNED-OFF] Bug 16946 - Remove the use of "onclick" from several serials templates This patch modifies several serials module templates to remove the use of event attributes. Events will now be defined in JavaScript. Also changed: - In Serials -> Check expiration, custom form validation has been removed in favor of validation with the plugin. - In Serials -> Claims, the "Clear filter" button has been replaced with a link. Error messages are now styled with the standard "alert" class. - In Serials -> New subscription -> Search for record, the "choose" link is now a Bootstrap button. Pagination links are now styled like other similar links. The "Close" button is now styled as in other popup windows. The "no results found" messages is styled as an informational dialog. - In Serials -> Subscription -> Edit routing list, the "add recipients" and "delete all" controls are now links with Font Awesome icons. To test, apply the patch and: - Go to Serials -> Check expiration. - Try to submit the form without filling in a date. The form validation plugin should warn you that the date field is required. - Submit the form using data which will return results. - Click the "Renew" button for any result. The subscription renewal popup should be triggered for the correct title. - Go to Serials -> Claims. - Select a vendor with missing issues. - Confirm that the date filter works correctly, and that the "Clear filter" link works. - Select one or more result and click the "Send notification" button. The notification should be sent. - Go to Serials -> New subscription. - Click the "Search for record" link to trigger the bibliographic search popup. - Perform a search. Confirm that the "Choose" button selects the correct record and populates the fields in the parent window. - Go to Serials -> Subscription -> Edit routing list. - Confirm that the process of adding recipients to the list works correctly. - Confirm that changing the rank of any recipient works correctly. - Save the routing list and click the "Save and preview routing slip" button on the confirmation page. The slip preview should open. - In the slip preview window, test that the print button works correctly. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 00:55:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 22:55:37 +0000 Subject: [Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 00:55:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 22:55:42 +0000 Subject: [Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974 --- Comment #3 from Jesse Weaver --- Created attachment 53542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53542&action=edit Bug 15974: Rancor: Correctly select existing authorized value Test plan: 1) Open up a record in Rancor with an itemtype besides the first in the list ('BK' in the sample itemtypes). 2) It will show "Book" instead of the correct itemtype. 3) Apply patch, reload the page. 4) The correct itemtype should now show. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 01:02:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 23:02:47 +0000 Subject: [Koha-bugs] [Bug 16874] Making serials collections actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53208|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 53543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53543&action=edit Bug 16874: Making serials collections actions buttons To test: 1) Go to serials -> Search a subscription (or make a new one) 2) Ensure that subscription has an end-date that has passed or will pass soon 3) Go to Serials collection (left sidebar menu) 4) Ensure that Subscription summary table has two buttons, Create routing list and Renew. These buttons should be bolded and the table cell highlighted 5) Ensure 'Print list' is a button in year tables below 6) Edit subscription to have a later end-date (will not expire soon) 7) Go back to serials collection 8) Ensure that table cell is no longer highlighted and buttons not bolded. Renew button should not be there. 9) Ensure that both buttons do not wrap when the browser is narrow Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 01:04:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 23:04:50 +0000 Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 01:04:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 23:04:53 +0000 Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51771|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 53544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53544&action=edit [SIGNED-OFF] Bug 16586: Koha Plugins: Limit results of GetPlugins by metadata It would be helpful if we could find a plugin based on some metadata tag as returned by the plugin. This extends the use of GetPlugins that already supports searching on method. GetPlugins is used in: admin/edi_accounts.pl, plugins/plugins-home.pl and tools/stage-marc-import.pl. The changes in these three scripts are minimal and just related to parameter passing. Test t/db_dependent/Plugins.t includes another test for GetPlugins. In this regard a metadata tag has been added to t/Koha/Plugins/Test.pm. NOTE: This adjustment will also be used in a redesign for bug 15545. Test plan: Run t/db_dependent/Plugins.t. Enable pref UseKohaPlugins and config var enable_plugins. Go to plugins-home.pl. Verify that it still lists your plugins. Bonus: Check edi_accounts or stage-marc-import.pl if you have a working plugin for that. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 01:16:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 23:16:15 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53538|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 53545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53545&action=edit Bug 16939: Making all 'add to basket' actions buttons Edit: Fixing 'clas' typo in addorderiso2709.tt Edit: Adding actions class to td To test: 1) Go to Acqui -> find a vendor -> view a basket 2) Click add to basket -> fill in 'for an existing record' and hit search 3) 'View MARC' and 'Order' buttons should show under an Actions column with appropriate icons 4) Click Order 5) Click add item when you are redirected to the New order page (no need to fill in any details) 6) Confirm that 'Edit' and 'Delete' buttons now show under an Actions column with appropriate icons 7) Go back to your basket and click add to basket -> from a subscription (we are skipping from a suggestion because this already has a button before my patch) 8) Confirm that 'Order' shows as a button with appropriate icon 9) Go back to your basket and click add to basket -> from an external source 10) fill in any fields and click search to bring up results 11) 'Order' should now show as a button with appropriate icons. MARC and Card preview have been moved into a dropdown menu - confirm this works as expected. Links have not been changed when clicking on a row 12) Go back to your basket and click add to basket -> from a staged file 13) 'Add orders' should now show as a button with appropriate icon 14) Go back to your basket and click add to basket -> from titles with highest hold ratios 15) 'X to order' should now show as a button with appropriate icon Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 01:24:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 23:24:32 +0000 Subject: [Koha-bugs] [Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Needs Signoff |Failed QA --- Comment #12 from Tom?s Cohen Arazi --- Mark, could you please do something like this instead? (grabbed from some other test and adjusted to your use). sub get_authtority_record { my $main_heading_field = ( C4::Context->preference('MARCFlavour') eq 'UNIMARC' ) ? '200' : '100'; my $auth = MARC::Record->new(); $auth->append_fields( MARC::Field->new($main_heading_field, ' ', ' ', a => 'Geisel, Theodor Seuss,', d => '1904-1991' )); return $auth; } It seems to me that the interpolated XML stuff obfuscates the code, and does unneeded XML processing. Also, the global transaction for tests was discouraged so no need to introduce Database.pm for this simple test as we just do the transaction as it is needed in the tests (think of subtests that do its own rollbacks, etc). So go for the usual: use Koha::Database; my $schema = Koha::Database->new->schema; $schema->storage->txn_begin; < tests here > $schema->storage->txn_rollback; BTW, it seems to me that this tests don't bother to launch zebra so they... don't... actually... test anything? Good examples on how to do this can be found (for C&P) on search_utf8.t <- This is not your fault and not really part of your bug report, but worth mentioning. The relevant test, is the last one, and it depends on zebra having the record indexed!! Notice C4::Headings::authorities() is calling _search() which actually triggers a Zebra search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 01:28:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 23:28:00 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 01:28:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 23:28:03 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51833|0 |1 is obsolete| | --- Comment #21 from Liz Rea --- Created attachment 53546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53546&action=edit Bug 15545: Add routine IsHoldNoteRequired to Reserves module This routine will be used to determine if a hold note is required. In the current approach this is implemented by use of Koha plugins. A former approach included a syspref. This is no longer needed. This approach is even more flexible. The routine will use all plugins it finds with metadata tag 'implements' set to 'IsHoldNoteRequired'. If one of these plugins has a check method that returns true, the hold note should be regarded as required. The plugins Rijks_HoldNoteRequired_Extent and _Leader offer an implementation where the value of the leader or MARC21 300$a determines if the hold note is required. Similarly, any other field of the bibliographic record could be used in a new plugin. Test plan: Run unit test t/db_dependent/Reserves/IsHoldNoteRequired.t. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 01:28:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 23:28:56 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #22 from Liz Rea --- Created attachment 53547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53547&action=edit Bug 15545: Use IsHoldNoteRequired in opac-reserve.pl This patch implements use of the new Reserves routine IsHoldNoteRequired, making it possible to require a note when placing a hold. Only a very small change in opac-reserve.pl is needed. As well as corresponding changes in the template. I am removing some unused template code related to a former approach. Test plan: [1] Disable UseKohaPlugins, enable OpacHoldNotes. [2] Place a hold on a serial record (leader pos 7 == s). Verify that the hold note is not required. [3] Enable UseKohaPlugins. Install the Rijks_HoldNoteRequired plugins. (Go to plugins/plugins-home.pl and upload Rijks_HoldNoteRequired.kpz. This file can be found as an attachment to this BZ report.) [4] Again place a hold on a serial record. The hold note should be required. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 01:29:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 23:29:26 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51834|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 01:39:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 23:39:19 +0000 Subject: [Koha-bugs] [Bug 16950] New: Serials subscriptions advanced search shows '0 found' pre-search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16950 Bug ID: 16950 Summary: Serials subscriptions advanced search shows '0 found' pre-search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com To reproduce: 1) Go to Serials 2) Click Advanced Search in the toolbar at the top 3) Notice heading says Serials subscriptions (0 found) before a search has even happened -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 01:40:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 23:40:54 +0000 Subject: [Koha-bugs] [Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868 --- Comment #13 from M. Tompsett --- (In reply to Tom?s Cohen Arazi from comment #12) > Mark, could you please do something like ... [SNIP] Okay... I'll adjust based on your feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 01:42:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 23:42:42 +0000 Subject: [Koha-bugs] [Bug 16950] Serials subscriptions advanced search shows '0 found' pre-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16950 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 01:42:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 23:42:45 +0000 Subject: [Koha-bugs] [Bug 16950] Serials subscriptions advanced search shows '0 found' pre-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16950 --- Comment #1 from Aleisha Amohia --- Created attachment 53548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53548&action=edit Bug 16950: Serials subscriptions advanced search shows '0 found' pre-search To test: 1) Go to Serials 2) Click Advanced Search in the toolbar at the top 3) Notice heading says Serials subscriptions (0 found) before a search has even happened 4) Apply patch and click Advanced Search again 5) Heading should now say Serials subscriptions search 6) Submit search 7) Heading should say how many subscriptions your search found (like before) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 01:42:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jul 2016 23:42:56 +0000 Subject: [Koha-bugs] [Bug 16950] Serials subscriptions advanced search shows '0 found' pre-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16950 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 02:25:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 00:25:38 +0000 Subject: [Koha-bugs] [Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 02:25:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 00:25:41 +0000 Subject: [Koha-bugs] [Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53453|0 |1 is obsolete| | Attachment #53455|0 |1 is obsolete| | --- Comment #14 from M. Tompsett --- Created attachment 53549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53549&action=edit Bug 16868: Silence error t/db_dependent/Linker_FirstMatch.t When the auth_header table has records which exclude 1xx and 2xx tags, the $bibfield doesn't match anything. This in turn sets it to undef, which triggers an error on the next line killing the test. This was completely refactored to provide the data necessary for the tests to pass, and to be more comprehensive (both MARC and UNIMARC are tested). The tests are then run. C4::Headings::authorities is mocked, so that this test is not dependent on a search engine. TEST PLAN --------- 1) back up DB 2) DELETE FROM auth_header; 3) SOURCE auth_header.sql; -- the provided file 4) prove t/db_dependent/Linker_FirstMatch.t -- should barf before running all the tests 5) apply all patches 6) prove t/db_dependent/Linker_FirstMatch.t -- should work happy 7) run koha qa test tools 8) restore your backup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 03:37:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 01:37:31 +0000 Subject: [Koha-bugs] [Bug 16951] New: Item search sorting not working properly for most columns Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Bug ID: 16951 Summary: Item search sorting not working properly for most columns Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When I pull up items in the item search and arrange by title, publication year, publisher, itemcallnumber, etc. I am getting results that don't seem to make any sense. I am seeing reports of this in 3.22.8 as well The order seems to be the same no matter what column, and it almost appears as if they are being ordered by date accessioned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 04:35:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 02:35:51 +0000 Subject: [Koha-bugs] [Bug 15975] Add Owning Library Column to Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 04:35:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 02:35:53 +0000 Subject: [Koha-bugs] [Bug 15975] Add Owning Library Column to Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53399|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 53550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53550&action=edit Bug 15975 - Add Owning Library Column to Checkouts To test: 1 - Checkout some items to a patron 2 - Note there is no 'Owning library' column 3 - Apply patch 4 - Note there IS an 'Owning library' column 5 - Use the columns configuration and ensure you can hide/display column at will Sponsored by: Coeur d'Alene Public Library (http://www.cdalibrary.org/) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 06:59:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 04:59:24 +0000 Subject: [Koha-bugs] [Bug 15975] Add Owning Library Column to Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 --- Comment #5 from Marc V?ron --- Created attachment 53551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53551&action=edit Datatable error with patch applied With patch applied, I get a datatable warning whilt checking out: "Requested unknown parameter 'homebranch' for row 0, column 7". See screenshot. Without patch, error does not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 06:59:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 04:59:41 +0000 Subject: [Koha-bugs] [Bug 15975] Add Owning Library Column to Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 07:15:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 05:15:53 +0000 Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no records have been passed in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Hi Aleisha, What do you think about having a different message if no record is selected? Maybe something like: (...) [% ELSIF op == 'report' %] [% IF report.total_records == 0 %] No records were selected for deletion! [% ELSIF report.total_records == report.total_success %] All records have been deleted successfully! [% ELSIF report.total_success == 0 %] No record has been deleted. An error occurred. [% ELSE %] (...) Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 07:19:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 05:19:10 +0000 Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no records have been passed in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949 --- Comment #3 from Marc V?ron --- (In reply to Marc V?ron from comment #2) > Hi Aleisha, > > What do you think about having a different message if no record is selected? > > Maybe something like: > (...) > [% ELSIF op == 'report' %] > [% IF report.total_records == 0 %] > No records were selected for deletion! > [% ELSIF report.total_records == report.total_success %] > All records have been deleted successfully! > [% ELSIF report.total_success == 0 %] > No record has been deleted. An error occurred. > [% ELSE %] > (...) > > Marc ...and maybe an additional link back to the previous screen to give the opportunity to select records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 07:31:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 05:31:07 +0000 Subject: [Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16949 CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 07:31:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 05:31:07 +0000 Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no records have been passed in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16948 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 07:39:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 05:39:18 +0000 Subject: [Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776 --- Comment #6 from Marc V?ron --- Still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 08:22:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 06:22:37 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #23 from Marcel de Rooy --- (In reply to Liz Rea from comment #20) > I think I see what I did wrong now - I was testing this in the staff client! > How very silly of me. Will give it one more go today, you know, doing it > properly. :) Thx Liz for your signoff. Should have mentioned opac in the latest commit message.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 08:58:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 06:58:32 +0000 Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 --- Comment #8 from Marcel de Rooy --- Created attachment 53552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53552&action=edit Bug 16929: [QA Follow-up] Shortcut methods and use statements Resolves the following comments: I'd prefer to see a generate_csrf method than a CSRF flag. It'd be better to use instead of require the 2 modules. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 09:33:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 07:33:01 +0000 Subject: [Koha-bugs] [Bug 16921] Authority Linking doesn't match to proper record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16921 --- Comment #4 from Nicholas van Oudtshoorn --- Thanks Joy and Jacek, Hmmm - I was on 2.0.58 of zebra - updated now, and things seem a lot better. ICU is enabled - will try with it disabled at some point. However, I'm still having issues. For instance, searching for "Young, Robert" returns two results. One of them has a date in $d, the other doesn't. Another example, there's a PERSO_NAME of value "T" - and it is there, but koha's returning 104 results (anyone with the intital T in their name, it looks like!). A more interesting example, searching for the TOPIC_TERM "Theology, Doctrinal" tells me there are three results: These are: Theology, Doctrinal Theology, Doctrinal-popular Works Theology, Doctrinal. Not sure what that second one is doing being brought in... Is this data not particularly nice, and in need of a tidy up? Yep! But I can't understand why the search isn't returning the right results... any ideas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 10:29:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 08:29:11 +0000 Subject: [Koha-bugs] [Bug 16947] Can not modify patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 10:29:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 08:29:32 +0000 Subject: [Koha-bugs] [Bug 16947] Can not modify patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 --- Comment #1 from Marc V?ron --- Created attachment 53553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53553&action=edit Bug 16947: Can not modify patron messaging preferences To verify: - Set syspref 'EnhancedMessagingPreferences' to 'Allow' - In staff client, go to a patron's detail page - Edit Patron messaging preferences (using link below table) - Save Result: Form does not save, stays open JavaScript error in intranet-tmpl/prog/js/members.js line 107 TypeError: document.form.password is undefined To test: - Apply patch - Repeat steps above - Verify that messaging preferences save as expected - Verify that other patron modifications work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 10:30:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 08:30:01 +0000 Subject: [Koha-bugs] [Bug 16947] Can not modify patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 10:38:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 08:38:21 +0000 Subject: [Koha-bugs] [Bug 16507] show play media tab first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |c.gravely at arts.ac.uk --- Comment #8 from Claire Gravely --- I got the following software error after creating a record: Can't locate WWW/YouTube/Download.pm in @INC (you may need to install the WWW::YouTube::Download module) (@INC contains: /home/claire/koha /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) at /home/claire/koha/C4/HTML5Media.pm line 103. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 11:02:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 09:02:23 +0000 Subject: [Koha-bugs] [Bug 16950] Serials subscriptions advanced search shows '0 found' pre-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16950 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53548|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 53554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53554&action=edit Bug 16950: Serials subscriptions advanced search shows '0 found' pre-search To test: 1) Go to Serials 2) Click Advanced Search in the toolbar at the top 3) Notice heading says Serials subscriptions (0 found) before a search has even happened 4) Apply patch and click Advanced Search again 5) Heading should now say Serials subscriptions search 6) Submit search 7) Heading should say how many subscriptions your search found (like before) Sponsored-by: Catalyst IT Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 11:02:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 09:02:43 +0000 Subject: [Koha-bugs] [Bug 16950] Serials subscriptions advanced search shows '0 found' pre-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16950 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 11:31:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 09:31:21 +0000 Subject: [Koha-bugs] [Bug 16952] New: Add sorting rules for Czech language to Zebra Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Bug ID: 16952 Summary: Add sorting rules for Czech language to Zebra Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 11:32:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 09:32:09 +0000 Subject: [Koha-bugs] [Bug 16952] Add sorting rules for Czech language to Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |black23 at gmail.com Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 11:37:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 09:37:20 +0000 Subject: [Koha-bugs] [Bug 16507] show play media tab first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 11:37:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 09:37:23 +0000 Subject: [Koha-bugs] [Bug 16507] show play media tab first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52948|0 |1 is obsolete| | --- Comment #9 from Claire Gravely --- Created attachment 53555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53555&action=edit Bug 16507: Show play media tab first if record has no holdings To test: 1) Go to Admin -> Global sysprefs 2) Turn on HTML5MediaEnabled and HTML5MediaYouTube 3) Go to Cataloging and create a new record 4) Catalogue a YouTube link in 856$u and save record. Do not add any items (click Normal tab) 5) Confirm that Play media tab is the selected tab by default 6) View record on OPAC and confirm Play media tab is selected by default 7) Go back to staff client, add an item then go back to Normal tab 8) Confirm that Holdings tab is now selected by default 9) Confirm Holdings tab is selected by default on OPAC Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 11:41:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 09:41:50 +0000 Subject: [Koha-bugs] [Bug 16953] New: Acquisitions home: Remove trailing › from breadcrumbs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953 Bug ID: 16953 Summary: Acquisitions home: Remove trailing › from breadcrumbs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org The breadcrumb on the Acquisition's home page reads: Home > Acquisitions > Remove trailing > (›) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 11:44:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 09:44:18 +0000 Subject: [Koha-bugs] [Bug 16952] Add sorting rules for Czech language to Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 11:44:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 09:44:21 +0000 Subject: [Koha-bugs] [Bug 16952] Add sorting rules for Czech language to Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 --- Comment #1 from Josef Moravec --- Created attachment 53556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53556&action=edit Bug 16952: Czech language definitions for sorting in Zebra Test plan: 1) Apply patch 2) Create new instance with parameter --zebralang cs 3) Insert some record with basic latin characters and some with "czech" characters (for example: "?" - should be sorted after "c", "?" - should be sorted after "s") 4) Try to search in katalog (staff and opac) and sort by other field then relevance - title or author for instance 5) Records should be sorted correctly by Czech rules 6) Look at code and confirm it is ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 11:45:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 09:45:35 +0000 Subject: [Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing › from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953 --- Comment #1 from Marc V?ron --- Created attachment 53557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53557&action=edit Bug 16953: Acquisitions home: Remove trailing › from breadcrumbs The breadcrumb on the Acquisition's home page reads: Home > Acquisitions > This tiny patch removes the trailing > (›) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 11:46:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 09:46:27 +0000 Subject: [Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing › from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 11:46:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 09:46:56 +0000 Subject: [Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing › from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 11:49:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 09:49:58 +0000 Subject: [Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 11:50:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 09:50:00 +0000 Subject: [Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53539|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 53558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53558&action=edit Bug 16948: 'Return to batch item deletion' button should only show when there are items that could not be deleted To test: 1) Go to Tools --> Batch item deletion 2) Put in an item barcode and click Continue 3) Deselect the item (so that you don't actually delete it) and click Delete selected items 4) Notice there are two links that say 'Return to batch item deletion' - one as a link and one as a button. 5) Apply patch and refresh page. You may have to go back and resend the form 6) Button should be gone, only one link shows. 7) Check out the same item that you are testing with to a patron 8) Put the barcode into batch item deletion again and follow the prompts. Do not deselect it after clicking Continue this time. (It will not be deleted as it has been checked out). 9) After clicking Delete selected items, you should be redirected and see a table with the item in it and the reason it can't be deleted. The button and the link saying 'Return to batch item deletion' should both be present. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 11:52:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 09:52:49 +0000 Subject: [Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing › from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53557|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 53559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53559&action=edit Bug 16953: Acquisitions home: Remove trailing › from breadcrumbs The breadcrumb on the Acquisition's home page reads: Home > Acquisitions > This tiny patch removes the trailing > (›) Amended: Remove the link on 'Acquisitions' as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 12:06:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 10:06:44 +0000 Subject: [Koha-bugs] [Bug 16941] Can not add new patron in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16909 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16909 [Bug 16909] Koha::Patrons - Remove checkuniquemember -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 12:06:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 10:06:44 +0000 Subject: [Koha-bugs] [Bug 16909] Koha::Patrons - Remove checkuniquemember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16909 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16941 [Bug 16941] Can not add new patron in staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 12:09:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 10:09:32 +0000 Subject: [Koha-bugs] [Bug 16941] Can not add new patron in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 12:09:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 10:09:35 +0000 Subject: [Koha-bugs] [Bug 16941] Can not add new patron in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53492|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53560&action=edit Bug 16941: Can not add new patron in staff client To reproduce: - Go to staff client Home > Patron - New patron - Choose a category and fill form, submit Result: Form reloads, patron data are not saved. To test: - Apply patch - Repeat steps above - Verify that patron data are saved and the new patron's detail page displays - Try to enter a duplicate patron (e.g. same surname, firstname and birthday as above) - Verify that a duplicate message appears Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 12:38:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 10:38:22 +0000 Subject: [Koha-bugs] [Bug 16874] Making serials collections actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |c.gravely at arts.ac.uk --- Comment #3 from Claire Gravely --- Hi, Sorry, I didn't get two buttons in step 4 of the test. Just the one for 'create routing list'. The line wasn't highlighted either. 'Print list' was displaying just fine as a button. Claire -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 12:48:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 10:48:06 +0000 Subject: [Koha-bugs] [Bug 16945] Syspref PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16945 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 12:48:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 10:48:08 +0000 Subject: [Koha-bugs] [Bug 16945] Syspref PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16945 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53530|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 53561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53561&action=edit Bug 16945: PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory In OPAC, patron self registration works only when PatronSelfRegistrationDefaultCategory is set to a valid patron category. This patch adds a note for PatronSelfRegistration on Home > Administration > System preferences. To test: - Apply patch - In staff client, search system preferences for PatronSelfRegistration - Verify that note appears with PatronSelfRegistration Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 14:51:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 12:51:07 +0000 Subject: [Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical Priority|P5 - low |P1 - high CC| |philippe.blouin at inlibro.com --- Comment #20 from Blou --- When adding a new member, pressing save, this returns to the same page. This broke master. Not sure what the status should be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 14:52:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 12:52:50 +0000 Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly for most columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu --- Comment #1 from Tom Misilo --- This seems to be a regression from 3.18, as we were able to sort on call numbers before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 14:55:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 12:55:08 +0000 Subject: [Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |minor Priority|P1 - high |P5 - low --- Comment #21 from Blou --- Sorry. Wrong bug, meant 16909. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 14:57:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 12:57:35 +0000 Subject: [Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |blocker --- Comment #22 from Blou --- Wrote to bug 16889 by mistake. This patch broke add new member. When pressing save, we cycle back to the page. Not sure what to do with the status and importance, but put in "blocker" since, well, it is kind of a big problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 15:14:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 13:14:29 +0000 Subject: [Koha-bugs] [Bug 16945] Syspref PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16945 --- Comment #3 from M. Tompsett --- Comment on attachment 53561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53561 Bug 16945: PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory Review of attachment 53561: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16945&attachment=53561) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref @@ +680,4 @@ > choices: > yes: Allow > no: "Don't allow" > + - "library patrons to register or modify their account via the OPAC. Note: This needs PatronSelfRegistrationDefaultCategory to be set to a valid patron categroy code." typo: category. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 15:31:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 13:31:28 +0000 Subject: [Koha-bugs] [Bug 16945] Syspref PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16945 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53561|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 53562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53562&action=edit Bug 16945: PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory In OPAC, patron self registration works only when PatronSelfRegistrationDefaultCategory is set to a valid patron category. This patch adds a note for PatronSelfRegistration on Home > Administration > System preferences. To test: - Apply patch - In staff client, search system preferences for PatronSelfRegistration - Verify that note appears with PatronSelfRegistration (Amended to fix typo, see comment #3, 2016-07-21 mv) Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 15:34:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 13:34:45 +0000 Subject: [Koha-bugs] [Bug 16945] Syspref PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16945 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53562|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 53563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53563&action=edit Bug 16945: PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory In OPAC, patron self registration works only when PatronSelfRegistrationDefaultCategory is set to a valid patron category. This patch adds a note for PatronSelfRegistration on Home > Administration > System preferences. To test: - Apply patch - In staff client, search system preferences for PatronSelfRegistration - Verify that note appears with PatronSelfRegistration (Amended to fix typo, see comment #3, 2016-07-21 mv) Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 15:49:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 13:49:22 +0000 Subject: [Koha-bugs] [Bug 16947] Can not modify patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 15:49:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 13:49:25 +0000 Subject: [Koha-bugs] [Bug 16947] Can not modify patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53553|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 53564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53564&action=edit Bug 16947: Can not modify patron messaging preferences To verify: - Set syspref 'EnhancedMessagingPreferences' to 'Allow' - In staff client, go to a patron's detail page - Edit Patron messaging preferences (using link below table) - Save Result: Form does not save, stays open JavaScript error in intranet-tmpl/prog/js/members.js line 107 TypeError: document.form.password is undefined To test: - Apply patch - Repeat steps above - Verify that messaging preferences save as expected - Verify that other patron modifications work as before NOTE: remember to force reload of the javascripts. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 15:55:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 13:55:41 +0000 Subject: [Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |minor --- Comment #23 from Blou --- ... I'm an idiot. Sorry for polluting this bug again. Going to 16909 now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 15:56:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 13:56:05 +0000 Subject: [Koha-bugs] [Bug 16909] Koha::Patrons - Remove checkuniquemember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16909 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com --- Comment #8 from Blou --- Wrote to bug 16889 by mistake. Twice. This patch broke add new member. When pressing save, we cycle back to the page. Not sure what to do with the status and importance, but put in "blocker" since, well, it is kind of a big problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 15:57:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 13:57:40 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53545|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard --- Created attachment 53565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53565&action=edit Bug 16939: Making all 'add to basket' actions buttons Edit: Fixing 'clas' typo in addorderiso2709.tt Edit: Adding actions class to td To test: 1) Go to Acqui -> find a vendor -> view a basket 2) Click add to basket -> fill in 'for an existing record' and hit search 3) 'View MARC' and 'Order' buttons should show under an Actions column with appropriate icons 4) Click Order 5) Click add item when you are redirected to the New order page (no need to fill in any details) 6) Confirm that 'Edit' and 'Delete' buttons now show under an Actions column with appropriate icons 7) Go back to your basket and click add to basket -> from a subscription (we are skipping from a suggestion because this already has a button before my patch) 8) Confirm that 'Order' shows as a button with appropriate icon 9) Go back to your basket and click add to basket -> from an external source 10) fill in any fields and click search to bring up results 11) 'Order' should now show as a button with appropriate icons. MARC and Card preview have been moved into a dropdown menu - confirm this works as expected. Links have not been changed when clicking on a row 12) Go back to your basket and click add to basket -> from a staged file 13) 'Add orders' should now show as a button with appropriate icon 14) Go back to your basket and click add to basket -> from titles with highest hold ratios 15) 'X to order' should now show as a button with appropriate icon Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 15:57:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 13:57:55 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 15:58:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 13:58:51 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:01:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:01:43 +0000 Subject: [Koha-bugs] [Bug 15975] Add Owning Library Column to Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53550|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 53566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53566&action=edit Bug 15975 - Add Owning Library Column to Checkouts To test: 1 - Checkout some items to a patron 2 - Note there is no 'Owning library' column 3 - Apply patch 4 - Note there IS an 'Owning library' column 5 - Use the columns configuration and ensure you can hide/display column at will Sponsored by: Coeur d'Alene Public Library (http://www.cdalibrary.org/) Works as expected (after clearing browser cache) Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:03:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:03:05 +0000 Subject: [Koha-bugs] [Bug 15975] Add Owning Library Column to Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Trivial patch --- Comment #7 from Marc V?ron --- Re-tested with browser cache cleared... Sorry for the noise :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:06:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:06:44 +0000 Subject: [Koha-bugs] [Bug 15975] Add Owning Library Column to Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 --- Comment #8 from Katrin Fischer --- Tiny request: please adapt commit message to new column name! I am changing the bug title too as this is used for the release notes! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:07:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:07:00 +0000 Subject: [Koha-bugs] [Bug 15975] Add Home Library Column to Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add Owning Library Column |Add Home Library Column to |to Checkouts |Checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:18:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:18:02 +0000 Subject: [Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:18:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:18:05 +0000 Subject: [Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52297|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 53567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53567&action=edit Bug 16716: Replaced wrong GROUP BY with DISTINCT Signed-off-by: Mark Tompsett NOTE: prove t/db_dependent/Koha.t triggers auth function. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:26:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:26:43 +0000 Subject: [Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- (In reply to Karl Holten from comment #1) > This is also the case for 008 dropdown on the top. It seems like both of the > dropdowns automatically default to the first alphabetical option. I can confirm this is an issue. Please make a separate bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:28:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:28:17 +0000 Subject: [Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:28:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:28:20 +0000 Subject: [Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53542|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 53568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53568&action=edit Bug 15974: Rancor: Correctly select existing authorized value Test plan: 1) Open up a record in Rancor with an itemtype besides the first in the list ('BK' in the sample itemtypes). 2) It will show "Book" instead of the correct itemtype. 3) Apply patch, reload the page. 4) The correct itemtype should now show. NOTE: The scope is only 942$c. This corrects that. The enhanced editor needs to be enabled in the system preferences. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:46:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:46:43 +0000 Subject: [Koha-bugs] [Bug 16752] Remove the use of event attributes from some acquisitions templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:46:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:46:46 +0000 Subject: [Koha-bugs] [Bug 16752] Remove the use of event attributes from some acquisitions templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16752 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52458|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 53569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53569&action=edit Bug 16752 - Remove the use of event attributes from some acquisitions templates - Transfer order This patch removes the use of 'onclick' from the acquisitions transfer order process. The patch also modifies the style of some links and buttons to conform with current guidelines. - Locate an open basket with items in it - Click the 'Transfer' link for a title in the basket - In the pop-up window: - Confirm that the 'Cancel' button at the bottom of the window is a Bootstrap-style button. - Search for a vendor; Confirm that the 'Choose' link is a Bootstrap-style button. - Choose a vendor; Confirm that the 'Choose' link on the following page is a Bootstrap-style button. - Confirm that clicking the 'Choose' button transfers the item to the correct basket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:57:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:57:34 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #65 from Bouzid --- Created attachment 53570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53570&action=edit Bug 6934 New report Cash Register Statistics This patch creates a new report that outputs cash register stats for a specific period. Changes: koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc - Added cash register report link koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash-register_stats.tt - new file koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt - Added cash register report link reports/cash-register_stats.pl - new file Testing: I Apply the patch 0) Go to reports home page (Home ? Reports); 1) Validate link << Cash Register >> under Statistics wizards; 2) Click link; 3) Validate page with three fieldsets; 4) Chose a date interval, a transaction type, a library and an output; 5) Validade the result. Signed-off-by: Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:57:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:57:38 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #66 from Bouzid --- Created attachment 53571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53571&action=edit Bug 6934: Fix code in CashRegisterStats (dataTables pagination, more accurate descriptions, add a delimiter pull down, change C4::Dates to Koha::DateUtils) I cleaned up the code according to comment #23. I got rid of DHTMLcalendar_dateformat, beacause it wasn't use in cash_register_stats.tt. C4::Dates is deprecated, Koha::DateUtils is now used. Some column names are changed and the pagination for the dataTables is fixed. Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:57:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:57:41 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #67 from Bouzid --- Created attachment 53572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53572&action=edit Bug 6934: New features, note added to transaction information, total caculated for negative types of transaction To be more specific, the column note from accountlines is now displayed in the table of the transactions. The grand total is now calculated for neagtive types like Credit or Payment and isn't counted for Write off types. Credit (return item) 'CR' has been added to drop down of transaction type Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:57:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:57:45 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #68 from Bouzid --- Created attachment 53573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53573&action=edit Bug 6934: QA Follow-up Tried to address every single thing that QA mentioned : 1)Removed isNull function 2)Changed datepicker properly 3)We have to fill in two dates not to be flooded with old entries if we don't want to. 4)The first two fieldsets are now in one bigger field set 5)Removed the use of $fullreportname variable 6)Removed the use of dt_from_string when it already recieved a DT. 7)Removed comments starting with "###" in cash_register_stats.pl 8)Used Text::CSV::Encoded to generate the CSV file (used guided_reports.pl as an example) 9)I am not sure if using C4::Reports::Guided is the right choice here. I instead used the same column names as the one recieved by the query in cash_register_stats because this report uses columns from 5 different tables in addition of using both firstname and surname twice. For the ninth point, I would like to know more about C4::Reports::Guided if you still think using it would be a better solution. Thank you! Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:57:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:57:49 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #69 from Bouzid --- Created attachment 53574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53574&action=edit Bug 6934 Fixed Calendar and removed used of unexisting and unused C4::Budgets getCurrency Signed-off-by: Hector Castro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:57:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:57:53 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #70 from Bouzid --- Created attachment 53575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53575&action=edit Bug 6934: second fix to calendars Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:57:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:57:57 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #71 from Bouzid --- Created attachment 53576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53576&action=edit Bug 6934: fixed encoding issue Signed-off-by: Hector Castro Encoding issue fixed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:58:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:58:00 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50938|0 |1 is obsolete| | --- Comment #72 from Bouzid --- Created attachment 53577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53577&action=edit Bug 6934: QA follow-up - fixed tabs - fixed capitalization on reports start page -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:58:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:58:04 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53496|0 |1 is obsolete| | --- Comment #73 from Bouzid --- Created attachment 53578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53578&action=edit Bug 6934: fix problem when export it open in LibreOffice - show values of itype and use TT plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 16:58:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 14:58:09 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53500|0 |1 is obsolete| | --- Comment #74 from Bouzid --- Created attachment 53579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53579&action=edit Bug 6934: Make CSV header column translatable and add total amounts in csv file -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:08:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:08:02 +0000 Subject: [Koha-bugs] [Bug 15975] Add Home Library Column to Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53566|0 |1 is obsolete| | --- Comment #9 from Marc V?ron --- Created attachment 53580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53580&action=edit Bug 15975 - Add Owning Library Column to Checkouts To test: 1 - Checkout some items to a patron 2 - Note there is no 'Home library' column 3 - Apply patch 4 - Note there IS an 'Home library' column 5 - Use the columns configuration and ensure you can hide/display column at will Sponsored by: Coeur d'Alene Public Library (http://www.cdalibrary.org/) Works as expected (after clearing browser cache). Commit message amended (as of comment #7) Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:13:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:13:11 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53570|0 |1 is obsolete| | Attachment #53571|0 |1 is obsolete| | Attachment #53572|0 |1 is obsolete| | Attachment #53573|0 |1 is obsolete| | Attachment #53574|0 |1 is obsolete| | Attachment #53575|0 |1 is obsolete| | Attachment #53576|0 |1 is obsolete| | Attachment #53579|0 |1 is obsolete| | --- Comment #75 from Bouzid --- Created attachment 53581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53581&action=edit Bug 6934: Make CSV header column translatable and add total amounts in csv file -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:13:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:13:17 +0000 Subject: [Koha-bugs] [Bug 16909] Koha::Patrons - Remove checkuniquemember In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16909 --- Comment #9 from Marc V?ron --- (In reply to Blou from comment #8) > Wrote to bug 16889 by mistake. Twice. > > This patch broke add new member. When pressing save, we cycle back to the > page. > > Not sure what to do with the status and importance, but put in "blocker" > since, well, it is kind of a big problem. See Bug 16941 - Can not add new patron in staff client for the solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:34:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:34:12 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #76 from Bouzid --- Created attachment 53582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53582&action=edit Bug 6934 New report Cash Register Statistics This patch creates a new report that outputs cash register stats for a specific period. Changes: koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc - Added cash register report link koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash-register_stats.tt - new file koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt - Added cash register report link reports/cash-register_stats.pl - new file Testing: I Apply the patch 0) Go to reports home page (Home ? Reports); 1) Validate link << Cash Register >> under Statistics wizards; 2) Click link; 3) Validate page with three fieldsets; 4) Chose a date interval, a transaction type, a library and an output; 5) Validade the result. Signed-off-by: Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:34:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:34:16 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #77 from Bouzid --- Created attachment 53583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53583&action=edit Bug 6934: Fix code in CashRegisterStats (dataTables pagination, more accurate descriptions, add a delimiter pull down, change C4::Dates to Koha::DateUtils) I cleaned up the code according to comment #23. I got rid of DHTMLcalendar_dateformat, beacause it wasn't use in cash_register_stats.tt. C4::Dates is deprecated, Koha::DateUtils is now used. Some column names are changed and the pagination for the dataTables is fixed. Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:34:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:34:20 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #78 from Bouzid --- Created attachment 53584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53584&action=edit Bug 6934: New features, note added to transaction information, total caculated for negative types of transaction To be more specific, the column note from accountlines is now displayed in the table of the transactions. The grand total is now calculated for neagtive types like Credit or Payment and isn't counted for Write off types. Credit (return item) 'CR' has been added to drop down of transaction type Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:34:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:34:24 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #79 from Bouzid --- Created attachment 53585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53585&action=edit Bug 6934: QA Follow-up Tried to address every single thing that QA mentioned : 1)Removed isNull function 2)Changed datepicker properly 3)We have to fill in two dates not to be flooded with old entries if we don't want to. 4)The first two fieldsets are now in one bigger field set 5)Removed the use of $fullreportname variable 6)Removed the use of dt_from_string when it already recieved a DT. 7)Removed comments starting with "###" in cash_register_stats.pl 8)Used Text::CSV::Encoded to generate the CSV file (used guided_reports.pl as an example) 9)I am not sure if using C4::Reports::Guided is the right choice here. I instead used the same column names as the one recieved by the query in cash_register_stats because this report uses columns from 5 different tables in addition of using both firstname and surname twice. For the ninth point, I would like to know more about C4::Reports::Guided if you still think using it would be a better solution. Thank you! Signed-off-by: Hector Castro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:34:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:34:27 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #80 from Bouzid --- Created attachment 53586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53586&action=edit Bug 6934 Fixed Calendar and removed used of unexisting and unused C4::Budgets getCurrency Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:34:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:34:31 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #81 from Bouzid --- Created attachment 53587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53587&action=edit Bug 6934: second fix to calendars Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:34:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:34:35 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #82 from Bouzid --- Created attachment 53588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53588&action=edit Bug 6934: fixed encoding issue Signed-off-by: Hector Castro Encoding issue fixed -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:34:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:34:39 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53577|0 |1 is obsolete| | --- Comment #83 from Bouzid --- Created attachment 53589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53589&action=edit Bug 6934: QA follow-up - fixed tabs - fixed capitalization on reports start page -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:34:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:34:43 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53578|0 |1 is obsolete| | --- Comment #84 from Bouzid --- Created attachment 53590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53590&action=edit Bug 6934: fix problem when export it open in LibreOffice - show values of itype and use TT plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:34:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:34:46 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53581|0 |1 is obsolete| | --- Comment #85 from Bouzid --- Created attachment 53591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53591&action=edit Bug 6934: Make CSV header column translatable and add total amounts in csv file -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:38:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:38:43 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53582|Bug 6934 New report Cash |[SIGNED-OFF] Bug 6934 New description|Register Statistics |report Cash Register | |Statistics Attachment #53582|Bug-6934-New-report-Cash-Re |SIGNED-OFF-Bug-6934-New-rep filename|gister-Statistics.patch |ort-Cash-Register-Statistic | |s.patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:41:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:41:21 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36476|0 |1 is obsolete| | Attachment #36476|1 |0 is patch| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:42:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:42:56 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53583|Bug-6934-Fix-code-in-CashRe |SIGNED-OFFBug-6934-Fix-code filename|gisterStats-dataTables-.pat |-in-CashRegisterStats-d.pat |ch |ch Attachment #53583|Bug 6934: Fix code in |[SIGNED-OFF]Bug 6934: Fix description|CashRegisterStats |code in CashRegisterStats |(dataTables pagination, |(dataTables pagination, |more accurate descriptions, |more accurate descriptions, |add a delimiter pull down, |add a delimiter pull down, |change C4::Dates to |change C4::Dates to |Koha::DateUtils) |Koha::DateUtils) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:43:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:43:18 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45973|0 |1 is obsolete| | Attachment #45973|1 |0 is patch| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:44:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:44:43 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53584|Bug-6934-New-features-note- |SIGNED-OFFBug-6934-New-feat filename|added-to-transaction-in.pat |ures-note-added-to-tran.pat |ch |ch Attachment #53584|Bug 6934: New features, |[SIGNED-OFF]Bug 6934: New description|note added to transaction |features, note added to |information, total |transaction information, |caculated for negative |total caculated for |types of transaction |negative types of | |transaction -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:44:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:44:56 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45974|0 |1 is obsolete| | Attachment #45974|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:46:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:46:17 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45972|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:47:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:47:46 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53585|Bug 6934: QA Follow-up |[SIGNED-OFF]Bug 6934: QA description| |Follow-up Attachment #53585|Bug-6934-QA-Follow-up.patch |SIGNED-OFFBug-6934-QA-Follo filename| |w-up.patch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:47:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:47:57 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48706|1 |0 is patch| | Attachment #48706|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:49:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:49:25 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53586|Bug 6934 Fixed Calendar and |[SIGNED-OFF]Bug 6934 Fixed description|removed used of unexisting |Calendar and removed used |and unused C4::Budgets |of unexisting and unused |getCurrency |C4::Budgets getCurrency Attachment #53586|Bug-6934-Fixed-Calendar-and |SIGNED-OFFBug-6934-Fixed-Ca filename|-removed-used-of-unexis.pat |lendar-and-removed-used.pat |ch |ch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:49:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:49:33 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48707|0 |1 is obsolete| | Attachment #48707|1 |0 is patch| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:50:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:50:43 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53587|Bug 6934: second fix to |[SIGNED-OFF]Bug 6934: description|calendars |second fix to calendars Attachment #53587|Bug-6934-second-fix-to-cale |SIGNED-OFFBug-6934-second-f filename|ndars.patch |ix-to-calendars.patch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:50:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:50:53 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48708|1 |0 is patch| | Attachment #48708|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:52:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:52:14 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53588|Bug 6934: fixed encoding |[SIGNED-OFF]Bug 6934: fixed description|issue |encoding issue -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:52:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:52:24 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50437|1 |0 is patch| | Attachment #50437|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:55:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:55:44 +0000 Subject: [Koha-bugs] [Bug 16954] New: Add the diff view to authorities in staged MARC records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16954 Bug ID: 16954 Summary: Add the diff view to authorities in staged MARC records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: hector.hecaxmmx at gmail.com Reporter: hector.hecaxmmx at gmail.com QA Contact: testopia at bugs.koha-community.org Since authorities can be imported thru staged MARC tool and a diff view has been added to the tool for bib records, it is necessary to do the diff view for authorities records. If you make a "Record matching rule" for authorities you can match one existing auth record with the batch imported. The problem is that when a match is found and you click in "View diff" the tool shows you a bib record compared with the authority record imported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 17:58:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 15:58:18 +0000 Subject: [Koha-bugs] [Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:07:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:07:45 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:08:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:08:22 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52334|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 53592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53592&action=edit Bug 16715: Proposed followup to use Sereal for serialization This manages to eke out a bit more performance on my machine. Signed-off-by: Jacek Ablewicz Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:09:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:09:39 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 --- Comment #14 from Jonathan Druart --- (In reply to Kyle M Hall from comment #12) > Cancel that, will need a rebase. Conflict in C4/Installer/PerlDependencies.pm fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:12:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:12:27 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #30 from Katrin Fischer --- Could this be revived? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:24:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:24:22 +0000 Subject: [Koha-bugs] [Bug 15705] Notify the user on auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:24:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:24:31 +0000 Subject: [Koha-bugs] [Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:24:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:24:38 +0000 Subject: [Koha-bugs] [Bug 16344] Add a circ rule to limit the auto renewals given a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:27:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:27:34 +0000 Subject: [Koha-bugs] [Bug 16947] Can not modify patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:27:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:27:56 +0000 Subject: [Koha-bugs] [Bug 16947] Can not modify patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53564|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53593&action=edit Bug 16947: Can not modify patron messaging preferences To verify: - Set syspref 'EnhancedMessagingPreferences' to 'Allow' - In staff client, go to a patron's detail page - Edit Patron messaging preferences (using link below table) - Save Result: Form does not save, stays open JavaScript error in intranet-tmpl/prog/js/members.js line 107 TypeError: document.form.password is undefined To test: - Apply patch - Repeat steps above - Verify that messaging preferences save as expected - Verify that other patron modifications work as before NOTE: remember to force reload of the javascripts. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:29:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:29:05 +0000 Subject: [Koha-bugs] [Bug 16947] Can not modify patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- This will need to be adapted for stable versions. I have not tested on 3.22.x but looking at the code the issue certainly exists. Since the bug exists for a while, I don't think it's a critical one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:29:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:29:53 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:32:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:32:36 +0000 Subject: [Koha-bugs] [Bug 16955] New: Internal Server Error while populating new framework Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955 Bug ID: 16955 Summary: Internal Server Error while populating new framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org While populating a new framework, an internal server error occurs. It happens on an installation with Plack. Steps to reproduce: - Go to Home > Administration > MARC frameworks - Add framework e.g. TEST, submit - In List of frameworks, go to framework TEST, Actions, MARC Structure - Create framework for... : Select DEFAULT Result: Internal Server Error (rest of sceen blank) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:35:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:35:28 +0000 Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955 --- Comment #1 from Marc V?ron --- Lines from plack-error.log: Variable "$cache" is not available at (...)/admin/marctagstructure.pl line 360. Variable "$frameworkcode" is not available at /home/marc/koha/admin/marctagstructure.pl line 362. Variable "$cache" is not available at (...)/admin/marctagstructure.pl line 360. Variable "$frameworkcode" is not available at (...)a/admin/marctagstructure.pl line 362. Can't call method "clear_from_cache" on an undefined value at /home/marc/koha/admin/marctagstructure.pl line 360. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:39:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:39:55 +0000 Subject: [Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on MARCdetail's items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Alex, I wanted to implement this feature for a while, but I don't understand the way you chose :) Why did not you store the value in the browser session? You are adding a new behavior but only for 1 table, it would be good to have it everywhere the columns settings are used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:40:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:40:07 +0000 Subject: [Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on MARCdetail's items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:40:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:40:40 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:40:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:40:42 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53354|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 53594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53594&action=edit Bug 15986 - Add a script for sending hold waiting reminder notices This patch adds a script for sending holds reminder notice to patrons. Essentially it is a modification of the overdue_notices.pl script To test: 1 - Create a hold reminder notice (Koha module: Holds) 2 - Set some waiting holds for patrons 3 - Run the script with various options and verify correct data is generated 4 - Verify that with 'optout' switch set only patrons who have email hold filled notices specified will recieve a reminder Sponsored by: The Hotchkiss School (http://www.hotchkiss.org/) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:44:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:44:08 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #86 from Bouzid --- fixed conflicts, patches should apply correctly. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:47:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:47:17 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #6 from Nick Clemens --- (In reply to Chris Cormack from comment #4) > Just a general comment, we have a setting where borrowers can opt in/out of > holds filled notices. > Should this script respect that preference, IE if they don't get a hold > filled notice will they be happy getting one saying it's waiting. Annoying > patrons is something libraries generally like to avoid :) Good point, I added it as a switch, some libraries charge fines for holds not picked up etc, so they may want to force the notification, I figure this way makes it flexible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:49:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:49:50 +0000 Subject: [Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:50:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:50:20 +0000 Subject: [Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53558|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53595&action=edit Bug 16948: 'Return to batch item deletion' button should only show when there are items that could not be deleted To test: 1) Go to Tools --> Batch item deletion 2) Put in an item barcode and click Continue 3) Deselect the item (so that you don't actually delete it) and click Delete selected items 4) Notice there are two links that say 'Return to batch item deletion' - one as a link and one as a button. 5) Apply patch and refresh page. You may have to go back and resend the form 6) Button should be gone, only one link shows. 7) Check out the same item that you are testing with to a patron 8) Put the barcode into batch item deletion again and follow the prompts. Do not deselect it after clicking Continue this time. (It will not be deleted as it has been checked out). 9) After clicking Delete selected items, you should be redirected and see a table with the item in it and the reason it can't be deleted. The button and the link saying 'Return to batch item deletion' should both be present. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:54:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:54:01 +0000 Subject: [Koha-bugs] [Bug 14578] Allow merging of records upon import match In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53502|0 |1 is obsolete| | --- Comment #7 from Jesse Weaver --- Created attachment 53596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53596&action=edit Bug 14578: Allow manual merging of import records on match Test plan: 1) Ensure that normal record merging still correctly functions. 2) Import a record that matches an existing record (exporting an existing record and reimporting it is an easy way to test this). 3) On the manage import batch page, there should now be a link to Merge. 4) Clicking this and going through the merge process should leave both records in place but update the import record. Sponsored-by: Rutgers School of Law Forgot sponsored-by. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 18:59:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 16:59:56 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver at bywatersolutions.co |nick at bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 19:01:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 17:01:52 +0000 Subject: [Koha-bugs] [Bug 16945] Syspref PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16945 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 19:02:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 17:02:13 +0000 Subject: [Koha-bugs] [Bug 16945] Syspref PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16945 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53563|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 53597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53597&action=edit Bug 16945: PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory In OPAC, patron self registration works only when PatronSelfRegistrationDefaultCategory is set to a valid patron category. This patch adds a note for PatronSelfRegistration on Home > Administration > System preferences. To test: - Apply patch - In staff client, search system preferences for PatronSelfRegistration - Verify that note appears with PatronSelfRegistration (Amended to fix typo, see comment #3, 2016-07-21 mv) Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 19:09:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 17:09:51 +0000 Subject: [Koha-bugs] [Bug 16937] Remove the use of "onclick" from the manage staged MARC records template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart --- I always get "Clear all reservoir records staged in this batch? This cannot be undone." even if I click on "Delete". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 19:23:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 17:23:42 +0000 Subject: [Koha-bugs] [Bug 16934] Cannot add notes to canceled and deleted order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 19:24:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 17:24:02 +0000 Subject: [Koha-bugs] [Bug 16934] Cannot add notes to canceled and deleted order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53537|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 53598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53598&action=edit Bug 16934 - Cannot add notes to canceled and deleted order line Some librarians would like to be able to add notes to deleted order lines to keep track of data such as what title the order line was for. For some reason ModOrder dies if a biblionumber is passed in, even though it does not use biblionumber and does not need it to exist in any fashion! This limitation should be removed. Test Plan: 1) Create a basket with an orderline 2) Cancel the order / delete the record 3) Click the "Add internal note" link for that order line 4) Fill in a note and click "Save" 5) Note the error 6) Apply this patch 7) Repeat steps 3-4 8) Note this time the note is saved! Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 19:24:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 17:24:24 +0000 Subject: [Koha-bugs] [Bug 16934] Cannot add notes to canceled and deleted order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934 --- Comment #7 from Jonathan Druart --- Created attachment 53599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53599&action=edit Bug 16934: Add test for ModOrder Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 19:34:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 17:34:11 +0000 Subject: [Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 19:34:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 17:34:27 +0000 Subject: [Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53567|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 53600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53600&action=edit Bug 16716: Replaced wrong GROUP BY with DISTINCT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 19:45:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 17:45:22 +0000 Subject: [Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 19:45:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 17:45:37 +0000 Subject: [Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53568|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 53601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53601&action=edit Bug 15974: Rancor: Correctly select existing authorized value Test plan: 1) Open up a record in Rancor with an itemtype besides the first in the list ('BK' in the sample itemtypes). 2) It will show "Book" instead of the correct itemtype. 3) Apply patch, reload the page. 4) The correct itemtype should now show. NOTE: The scope is only 942$c. This corrects that. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 19:57:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 17:57:02 +0000 Subject: [Koha-bugs] [Bug 15975] Add Home Library Column to Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart --- Nick, can you check the additional time added by this new join on a relatively big table (100 checkouts displayed)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 20:41:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 18:41:58 +0000 Subject: [Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amy at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 20:45:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 18:45:10 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 20:45:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 18:45:12 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53318|0 |1 is obsolete| | Attachment #53319|0 |1 is obsolete| | Attachment #53320|0 |1 is obsolete| | Attachment #53326|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 53602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53602&action=edit Bug 14826 - Update database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 20:45:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 18:45:21 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #11 from Kyle M Hall --- Created attachment 53603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53603&action=edit Bug 14826 - Update table schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 20:45:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 18:45:23 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #12 from Kyle M Hall --- Created attachment 53604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53604&action=edit Bug 14826 - Add Koha modules for offsets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 20:45:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 18:45:26 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #13 from Kyle M Hall --- Created attachment 53605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53605&action=edit Bug 14826 - Resurrect account offsets table The account offsets table should be used to track increments and decrements of fines via payments and credits, as well as fine accruals. It should be able to match fees to payments and visa versa, so we can know which fee was paid by a given payment, and which payments applied to a given fee. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Note the table accountoffsets has been renamed to account_offsets 4) Ensure fine generation creates offsets 5) Ensure creating a manual invoice creates an offset 6) Ensure a lost item charge creates an offset 7) Ensure Reverse Payment creates an offset 8) Ensure a payment creates an offset 9) Ensure a payment for multiple fees creates an offset for each 10) Ensure writeoffs create offsets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 20:45:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 18:45:28 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #14 from Kyle M Hall --- Created attachment 53606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53606&action=edit Bug 14826 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 20:47:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 18:47:27 +0000 Subject: [Koha-bugs] [Bug 13125] Total Holds does not tally holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13125 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.16 |master Severity|minor |enhancement --- Comment #1 from Owen Leonard --- (In reply to Danielle Elder from comment #0) > The items.reserves field in Koha is not working. Did this ever work? This sounds like it is an enhancement request, although I wouldn't think an item-level count of holds would be useful unless you also required item-level holds all the time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 21:04:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 19:04:46 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53606|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 53607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53607&action=edit Bug 14826 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 21:32:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 19:32:59 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48224|0 |1 is obsolete| | --- Comment #8 from Jesse Weaver --- Created attachment 53608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53608&action=edit Bug 15774: Add additional fields to order baskets This also moves the admin page for additional fields for all tables to a single common screen, and factors out display/input parsing logic. Test plan: 1. Create an additional field for a subscription (under Serials -> Add subscription fields). 2. Apply patch. 3. Visit Additional fields under administration, and verify that the field created above still shows under the list for the subscription table. 4. Create at least four fields for aqbasket for each combination of searchable/not-searchable and with/without an authorized value. 5. Create an order basket, and verify that all fields are visible and correctly save. 6. Edit the basket, verifying that changes to these additional fields are saved. 7. Add an order to the basket (contents are irrelevant). 8. Go to advanced search within acquisitions. 9. Verify that only the searchable fields show in the form, and that their contents may be searched. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 21:39:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 19:39:42 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 21:39:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 19:39:45 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #9 from Jesse Weaver --- Created attachment 53609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53609&action=edit Bug 15774: (QA followup) Make sure that tablename is correctly saved This should fix QA issues, rebasing 11844 shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 21:40:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 19:40:24 +0000 Subject: [Koha-bugs] [Bug 16954] Add the diff view to authorities in staged MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16954 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 53610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53610&action=edit MARC for personal names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 21:40:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 19:40:58 +0000 Subject: [Koha-bugs] [Bug 16954] Add the diff view to authorities in staged MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16954 --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 53611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53611&action=edit MARC for subjects term -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 21:48:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 19:48:02 +0000 Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955 --- Comment #2 from Marc V?ron --- Created attachment 53612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53612&action=edit Bug 16955: Internal Server Error while populating new framework While populating a new framework, an internal server error occurs. (Error occurs with plack enabled) Steps to reproduce: - Go to Home > Administration > MARC frameworks - Add framework e.g. TEST, submit - In List of frameworks, go to framework TEST, Actions, MARC Structure - Create framework for... : Select DEFAULT Result: Internal Server Error (rest of screen blank) This patch fixes a variable scope issue and moves 4 lines that should be inside a loop. To test: - Apply patch - Verify that code changes make sense - Try to recreate error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 21:49:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 19:49:35 +0000 Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Assignee|gmcharlt at gmail.com |veron at veron.ch Component|Architecture, internals, |Staff Client |and plumbing | Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 21:55:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 19:55:06 +0000 Subject: [Koha-bugs] [Bug 16954] Add the diff view to authorities in staged MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16954 --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 53613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53613&action=edit Bug 16954: Add the diff view to authorities in staged MARC records To test: -Update database: $ perl installer/data/mysql/updatedatabase.pl -Go to Authorities and click in New from Z39.50 -Copy the authors: (Maxwell Robert, L. | Tanenbaum, Andrew S.) from Library of Congress -Copy the subjects: Water-supply, Watering troughs from Library of Congress -Reindex zebra -Download the file personal_test_auth.mrc above in attachments -Go to Tools -> Stage MARC records for import and upload the file personal_test_auth.mrc this file provide the same authors copied before with extra data. -When upload progress is 100% chose: "Record type -> Authorities" "Record matching rule -> 100$a (Personal name)" -Click in "Stage for import" -In match details colum will match the two records, click in View and you'll see the original record and the diff with the imported. -Download the file subjects_test_auth.mrc above in attachments and stage the records -When upload progress is 100% chose: "Record type -> Authorities" "Record matching rule -> 150$a (Topical term)" -In match details colum will match the two records, click in View and you'll see the original record and the diff with the imported. Extra test: -Test with existing bib records. Verify that your records have ISBN 10 Koha convert ISBN 13 to 10 and sometimes fails. "Record type -> Bibliographic" "Record matching rule -> ISBN (020$a)" -See that diff view works as before Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 22:49:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 20:49:35 +0000 Subject: [Koha-bugs] [Bug 10855] Custom fields for subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11844 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 [Bug 11844] Additional fields for order lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 22:49:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 20:49:35 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10855, 11944, 13596 |15774 Status|Patch doesn't apply |Signed Off Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 [Bug 10855] Custom fields for subscriptions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 [Bug 11944] Cleanup Koha UTF-8 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 [Bug 15774] Additional fields for baskets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 22:49:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 20:49:35 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11844 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 [Bug 11844] Additional fields for order lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 22:49:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 20:49:35 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11844 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 [Bug 11844] Additional fields for order lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 22:49:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 20:49:35 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 [Bug 11844] Additional fields for order lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 22:49:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 20:49:43 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45915|0 |1 is obsolete| | --- Comment #22 from Jesse Weaver --- Created attachment 53614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53614&action=edit Bug 11844: Use additional fields for order lines This patch makes use of new module Koha::AdditionalField to provide additional fields to order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, then value from biblio record is retrieved at order line creation. When saving order line (at creation or modification), values in additional fields are saved into biblio record. If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for a AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category b/ no AV category, a MARC field linked to AV category c/ a AV category, no MARC field d/ a AV category, a MARC field not linked to AV category e/ a AV category, a MARC field linked to another AV category In case of (e), the additional AV category should be used, not the AV category linked to MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e) (check this is the right AV category for (e)) 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (a), (b), (d) and (e) 11/ modify the same order line, check that values you've filled is correctly retrieved. 12/ modify all values, save, and check biblio once again 13/ create a new order line on the same biblio used for previous order line. check that values are correctly retrieved from biblio Signed-off-by: Harold Dramer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 22:50:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 20:50:05 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45916|0 |1 is obsolete| | --- Comment #23 from Jesse Weaver --- Created attachment 53615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53615&action=edit Bug 11844: Copy additional fields values when transfering order Signed-off-by: Harold Dramer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 22:50:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 20:50:11 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45917|0 |1 is obsolete| | --- Comment #24 from Jesse Weaver --- Created attachment 53616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53616&action=edit Bug 11844: Fix additional field values when creating a new order line ordernumber was not correctly retrieved Signed-off-by: Harold Dramer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 22:50:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 20:50:38 +0000 Subject: [Koha-bugs] [Bug 16954] Add the diff view to authorities in staged MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16954 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 22:50:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 20:50:40 +0000 Subject: [Koha-bugs] [Bug 16954] Add the diff view to authorities in staged MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16954 --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 53617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53617&action=edit Bug 16954: Add the "record matching rules" for all languages This patch add the matching rules for all languages so diff tool works properly in all languages for new installations To test: Execute the sql: SET FOREIGN_KEY_CHECKS=0; truncate marc_matchers; truncate matchpoints; truncate matcher_matchpoints; truncate matchpoint_components; truncate matchpoint_component_norms; SET FOREIGN_KEY_CHECKS=1; mysql -ukohauser -ppassword koha < kohaclone/installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_default_matching_rules.sql Go to Tool -> Record matching rules. You will see the new data in Spanish Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 22:50:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 20:50:51 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #25 from Jesse Weaver --- Created attachment 53618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53618&action=edit Bug 11844: (followup) use new unified additional field screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 22:51:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 20:51:06 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10855, 11944, 13596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 [Bug 10855] Custom fields for subscriptions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 [Bug 11944] Cleanup Koha UTF-8 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 22:51:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 20:51:06 +0000 Subject: [Koha-bugs] [Bug 10855] Custom fields for subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 [Bug 11844] Additional fields for order lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 22:51:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 20:51:06 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 [Bug 11844] Additional fields for order lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 22:51:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 20:51:06 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 [Bug 11844] Additional fields for order lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 23:04:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 21:04:02 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #24 from Liz Rea --- to be fair it says "OpacHoldNotes" so... yeah I just wasn't putting two and two together. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 23:31:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 21:31:25 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #7 from Chris Cormack --- Yep sounds good, I'll give it a test when I'm back at work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 23:39:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 21:39:42 +0000 Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 23:55:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 21:55:01 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53618|0 |1 is obsolete| | --- Comment #26 from Jesse Weaver --- Created attachment 53619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53619&action=edit Bug 11844: (followup) use new unified additional field screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 21 23:55:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 21:55:26 +0000 Subject: [Koha-bugs] [Bug 13125] Total Holds does not tally holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13125 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hm, maybe we could use it to count how many holds a specific item has filled - it might be interesting to see. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 00:16:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 22:16:41 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #34 from Liz Rea --- Mark says not enough tests, no reason to have this in the needs SO queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 00:38:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 22:38:34 +0000 Subject: [Koha-bugs] [Bug 16918] opacmain.pl is not running under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16918 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 00:38:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 22:38:36 +0000 Subject: [Koha-bugs] [Bug 16918] opacmain.pl is not running under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16918 --- Comment #1 from Jesse Weaver --- Created attachment 53620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53620&action=edit Bug 16918: Serve OPAC/intranet homepage via Plack Test plan: 1) Shut down the Plack server. 2) The OPAC and staff side homepage should still load (as it is mistakenly being loaded via CGI). 3) Apply patch. 4) Both homepages should now not load. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 00:40:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 22:40:34 +0000 Subject: [Koha-bugs] [Bug 16918] opacmain.pl is not running under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16918 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53620|0 |1 is obsolete| | --- Comment #2 from Jesse Weaver --- Created attachment 53621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53621&action=edit Bug 16918: Serve OPAC/intranet homepage via Plack Test plan: 1) Shut down the Plack server. 2) The OPAC and staff side homepage should still load (as it is mistakenly being loaded via CGI). 3) Apply patch. 4) Both homepages should now not load. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 01:24:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 23:24:08 +0000 Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtompset at hotmail.com --- Comment #22 from M. Tompsett --- Please rebase. I was going to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 01:30:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Jul 2016 23:30:43 +0000 Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #23 from M. Tompsett --- de-DE and it-IT are the ones that fail. the zip files still apply, though whitespace issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 02:59:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 00:59:50 +0000 Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |manueltamayao at gmail.com, | |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- Sounds exactly like what we are experiencing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 06:20:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 04:20:52 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #14 from Liz Rea --- Should we expect that this local hold that has priority for a branch turn up on the hold queue? Or do we only care about what happens when an item is checked in? My instinct says that a local hold priority item should show up on the hold queue for the prioritised library/item/borrower Example, Patron from springfield has a biblio level reserve for a book that has a springfield copy, the springfield copy is available, should this turn up on the hold queue for springfield? Currently the reserve doesn't show up on any hold queue. Is that correct behaviour? How would the library know the reserve exists in this case without scanning it to trap it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 06:23:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 04:23:32 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 --- Comment #15 from Liz Rea --- *with this patch, the reserve doesn't show up on any hold queue. Without it, as you noted, it does show up on the wrong priority library's hold queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 06:42:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 04:42:38 +0000 Subject: [Koha-bugs] [Bug 16809] Silence authority warnings C4::Biblio::TransformHtmlToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea --- Hi Mark, I was unable to replicate the flooding, but the patch doesn't seem to hurt anything. Not super into change for the sake of it, can you still replicate this on current master? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 07:18:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 05:18:21 +0000 Subject: [Koha-bugs] [Bug 16956] New: Inserting null borrowernumber value in statistics table while book is checkin if book is not checkedout Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16956 Bug ID: 16956 Summary: Inserting null borrowernumber value in statistics table while book is checkin if book is not checkedout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: amitddng135 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Inserting null borrowernumber value in statistics table while book is checkin if book is not checkedout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 07:19:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 05:19:06 +0000 Subject: [Koha-bugs] [Bug 16956] Inserting null borrowernumber value in statistics table while book is checkin if book is not checkedout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16956 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 07:19:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 05:19:23 +0000 Subject: [Koha-bugs] [Bug 16956] Inserting null borrowernumber value in statistics table while book is checkin if book is not checkedout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16956 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 07:50:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 05:50:10 +0000 Subject: [Koha-bugs] [Bug 16588] libreadonly-perl (and libreadonly-xs-perl) need to be added as dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #5 from Mirko Tietgen --- Any volunteers? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 08:10:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 06:10:50 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 08:11:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 06:11:42 +0000 Subject: [Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 08:12:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 06:12:29 +0000 Subject: [Koha-bugs] [Bug 15566] Update API to allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15566 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- Depends on a PNA patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 08:22:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 06:22:49 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl --- Comment #37 from Marcel de Rooy --- QA: Looking here now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 08:24:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 06:24:20 +0000 Subject: [Koha-bugs] [Bug 16957] New: Fine amount does not display on patron checkout page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16957 Bug ID: 16957 Summary: Fine amount does not display on patron checkout page Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Dear Friends, We are using koha 16.05.1. Fine amount does not show on Patron account > Check out page. Please see the screenshot, https://s31.postimg.org/wkz8hth2z/Skitch.png But fine amount display on Patron account > Fines. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 08:28:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 06:28:32 +0000 Subject: [Koha-bugs] [Bug 16957] Fine amount does not display on patron checkout page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16957 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:26:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:26:15 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #38 from Marcel de Rooy --- Created attachment 53623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53623&action=edit Bug 15451: Add the 2 new modules Koha::CsvProfile[s] There are based on Koha::Objets. Tests provided. Signed-off-by: Bernardo Gonzalez Kriegel Test pass, no errors. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:26:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:26:19 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #39 from Marcel de Rooy --- Created attachment 53624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53624&action=edit Bug 15451: Rewrite the csv profile tool script This page was inconsistent with the other admin and tool pages. The 2 tabs 'New profile' and 'Edit existing profile' were useless, the ergonomic needs to be revisited. This patch applies the same script/page structure as others: by default a table containing all csv profiles is displayed with 2 action links: edit and delete. Test plan: 1/ Create 1+ CSV profiles, with different types (marc and sql) 2/ Update some values using the Edit link 3/ Delete a CSV profile Note: When deleting a CSV profile, it would be great to warn the user if it is used. Signed-off-by: Bernardo Gonzalez Kriegel No problems on create, update and delete. No errors Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:26:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:26:23 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #40 from Marcel de Rooy --- Created attachment 53625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53625&action=edit Bug 15451: Koha::CsvProfiles - Remove GetCsvProfilesLoop This subroutine returned the csv profiles for a given type. This could be done easily with the new Koha::CsvProfiles->search method. Test plan: To do at the OPAC and staff interface! 1/ Export a list using a CSV profile 2/ Export your CART using a CSV profile Note that only MARC profiles should be available. Signed-off-by: Bernardo Gonzalez Kriegel Tested on staff/opac & cart/list Small problem on filename extension fixed in followup. No errors Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:26:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:26:27 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #41 from Marcel de Rooy --- Created attachment 53626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53626&action=edit Bug 15451: Koha::CsvProfiles - Remove GetCsvProfiles This subroutine did the same job as GetCsvProfilesLoop, so this patch applies the same changes as the previous patch. Test plan: 1/ Claim some serials, sql profiles should be listed 2/ Export records using the export tool. MARC profiles should be listed. Signed-off-by: Bernardo Gonzalez Kriegel Listed sql & marc profiles No errors Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:26:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:26:31 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #42 from Marcel de Rooy --- Created attachment 53627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53627&action=edit Bug 15451: Koha::CsvProfiles - Remove GetCsvProfileId This subroutine returned the export_format_id for a given profile name. This can be done easily with the Koha::CsvProfiles->search method. Test plan: Export records using the misc/export_records.pl script and the export tool. If you are exporting using the MARC format, the profile filled in the pref ExportWithCsvProfile will be used (or the one passed in parameter of misc/export_records.pl). If you are exporting using the CSV format, you can choose a profile in the dropdown list. Signed-off-by: Bernardo Gonzalez Kriegel Exported using tool & cmd, marc & csv. Pref is used. No errors Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:26:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:26:34 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #43 from Marcel de Rooy --- Created attachment 53628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53628&action=edit Bug 15451: Koha::CsvProfiles - Remove GetCsvProfile This subroutine just returned a csv profile for a given id. It is replaced in this patch by a call to Koha::CsvProfiles->find. There is nothing to test here, these changes have been tested in previous patches. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:26:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:26:38 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #44 from Marcel de Rooy --- Created attachment 53629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53629&action=edit Bug 15451: Koha::CsvProfiles - Remove the residue This patch erase all traces of C4::Csv since it's not used anymore. All occurrences have been replaced by previous patches to use Koha::CsvProfiles. Note that GetMarcFieldsForCsv was not used prior this patch set. Test plan: git grep 'C4::Csv' should not return any result. Signed-off-by: Bernardo Gonzalez Kriegel No more traces of the file. This produces a koha-qa fail, due to the missing file. No other errors Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:26:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:26:42 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #45 from Marcel de Rooy --- Created attachment 53630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53630&action=edit Bug 15451: Do not considered a Resultset as a Result The previous calls were wrong, but there is something bad with the DB structure: export_format.profile should be a unique key. This patch fixes the previous calls and add a FIXME not to forget to fix the DB structure. Signed-off-by: Bernardo Gonzalez Kriegel Previous test where done with all patches applied, including this one, and all worked. No errors Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:26:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:26:46 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50985|0 |1 is obsolete| | --- Comment #46 from Marcel de Rooy --- Created attachment 53631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53631&action=edit Bug 15451: (followup) fix filename extension for csv file This patch does the same as basket/downloadcart.pl to set '.csv' as filename extension for downloadshelf.pl To test: 1) Define a CSV MARC profile 2) On staff download a list, extension is '.NN' with 'NN' the CSV profile id. 3) Apply the patch 4) Download again, check extension is now '.csv' Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:27:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:27:30 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50860|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:27:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:27:32 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50861|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:27:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:27:34 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50862|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:27:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:27:36 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50863|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:27:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:27:40 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50865|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:27:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:27:38 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50864|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:27:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:27:42 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50866|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:27:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:27:44 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50867|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:28:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:28:58 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA --- Comment #47 from Marcel de Rooy --- QA Comment (by patch number): 0002 Delete CSV Profile "Test01?" Yes, delete No, do not Delete I would suggest to change this into Yes and No. This looks weird. 0005 If you provide a wrong csv id to export_records.pl, it will generate this error: Can't call method "encoding" on an undefined value at /usr/share/koha/masterclone/C4/Record.pm line 481. This is more or less outside the scope of this report. As a side note, I think it is kind of strange to pass record id's to a script. I would have expected the profile name here. At least the validity of this csv argument could be tested somewhere. If I choose the format csv, I think it is wrong to output to a file called koha.mrc. (Yes, I did not add the filename parameter. Should be obvious here.) 0006 my $profile = Koha::CsvProfiles->find($id); This is actually the line that I refer to in my former comment. What if this find does not have any results? You cannot assume that you will find a record here. You should test. Not a blocker, but please provide a follow-up. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:51:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:51:59 +0000 Subject: [Koha-bugs] [Bug 14793] New cataloguing plugin unimarc_field_225a_bis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14793 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:52:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:52:38 +0000 Subject: [Koha-bugs] [Bug 14793] New cataloguing plugin unimarc_field_225a_bis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14793 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:52:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:52:40 +0000 Subject: [Koha-bugs] [Bug 14793] New cataloguing plugin unimarc_field_225a_bis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14793 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50993|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 53635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53635&action=edit Bug 14793: New cataloguing plugin unimarc_field_225a_bis It is similar to unimarc_field_210c_bis, but searches in biblioitems.collectiontitle instead of biblioitems.publishercode Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:53:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:53:17 +0000 Subject: [Koha-bugs] [Bug 14793] New cataloguing plugin unimarc_field_225a_bis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14793 --- Comment #7 from Marcel de Rooy --- The plugin style is still in the old format plugin_javascript instead of builder/launcher. But can be converted later (just as other unimarc plugins). I see some CSS in the template, which is not recommended. Not a big deal. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 09:55:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 07:55:58 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl --- Comment #35 from Marcel de Rooy --- QA: Looking here now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 10:07:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 08:07:31 +0000 Subject: [Koha-bugs] [Bug 16588] libreadonly-perl (and libreadonly-xs-perl) need to be added as dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 10:08:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 08:08:16 +0000 Subject: [Koha-bugs] [Bug 16588] libreadonly-perl (and libreadonly-xs-perl) need to be added as dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7736, 12478, 14066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 [Bug 7736] Edifact QUOTE and ORDER functionality https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 [Bug 14066] Koha code does not really use Readonly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 10:08:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 08:08:16 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 [Bug 16588] libreadonly-perl (and libreadonly-xs-perl) need to be added as dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 10:08:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 08:08:16 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 [Bug 16588] libreadonly-perl (and libreadonly-xs-perl) need to be added as dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 10:08:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 08:08:16 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 [Bug 16588] libreadonly-perl (and libreadonly-xs-perl) need to be added as dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 10:14:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 08:14:03 +0000 Subject: [Koha-bugs] [Bug 16588] libreadonly-perl (and libreadonly-xs-perl) need to be added as dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 10:14:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 08:14:06 +0000 Subject: [Koha-bugs] [Bug 16588] libreadonly-perl (and libreadonly-xs-perl) need to be added as dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #6 from Jonathan Druart --- Created attachment 53636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53636&action=edit Bug 16588: Remove Readonly from Edifact Bug 14066 has removed the Readonly dependency, but in the meanwhile, 2 long standing reports reintroduced it: Edifact and ElasticSearch This patchset will remove it from these 2 modules. Test plan: No idea how to test Edifact, I have not tested this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 10:14:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 08:14:09 +0000 Subject: [Koha-bugs] [Bug 16588] libreadonly-perl (and libreadonly-xs-perl) need to be added as dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #7 from Jonathan Druart --- Created attachment 53637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53637&action=edit Bug 16588: Remove Readonly from SearchEngine Test plan: Make sure you are able to reindex and search for records at the OPAC using ElasticSearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 10:14:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 08:14:12 +0000 Subject: [Koha-bugs] [Bug 16588] libreadonly-perl (and libreadonly-xs-perl) need to be added as dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #8 from Jonathan Druart --- Created attachment 53638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53638&action=edit Bug 16588: Koha::SearchEngine must return a true value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 10:14:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 08:14:59 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #36 from Marcel de Rooy --- qa tools: Processing files after patches fatal: ambiguous argument 'C4/Review.pm': unknown revision or path not in the working tree. Use '--' to separate paths from revisions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 10:32:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 08:32:12 +0000 Subject: [Koha-bugs] [Bug 16959] New: E-mail alerts for saved searches Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16959 Bug ID: 16959 Summary: E-mail alerts for saved searches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be nice if Koha allowed to send e-mails to patrons when a new record is created for a saved search. Examples: - New records are added within a specific call number range - New records where the title contains certain words It should be possible to set this up individually per patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 10:43:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 08:43:05 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #37 from Marcel de Rooy --- QA Comment: If I submit a new review, the approved status will be NULL. But reviewswaiting.pl will not show it: my $status = $query->param('status') || 0; ... my $reviews = Koha::Reviews->search( { approved => $status }, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 10:52:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 08:52:07 +0000 Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 --- Comment #10 from Jonathan Druart --- Created attachment 53639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53639&action=edit Bug 16573: Define virtualshelves.created_on as datetime for existing installs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 10:53:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 08:53:13 +0000 Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #11 from Jonathan Druart --- (In reply to M. Tompsett from comment #9) > Though, my upgrade from 3.15.x seems to be missing a created_on. :( Could you test again with this last patch (I do not have MySQL 5.7 to test). Moreover it seems that items_last_borrower.created_on should be changed as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 10:55:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 08:55:36 +0000 Subject: [Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing › from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |c.gravely at arts.ac.uk --- Comment #3 from Claire Gravely --- Hi, The trailing > has gone, but Acquisitions is still showing as a link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 11:18:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 09:18:31 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Jonathan Druart --- Global symbol "$additional_fields" requires explicit package name (did you forget to declare "my $additional_fields"?) at acqui/neworderempty.pl line 313. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 11:28:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 09:28:28 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 --- Comment #48 from Jonathan Druart --- Created attachment 53641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53641&action=edit Bug 15451: Better error handling 1/ If a librarian edit (add_validate) a non-existing csv profile, we explicitely die 2/ If you try to delete a non-existing csv profile, you will now get a nice alert box -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 11:34:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 09:34:38 +0000 Subject: [Koha-bugs] [Bug 16008] noisy "fatal" warning when new file is moved in another patch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #12 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #11) > Too bad not to see another QAer taking a look at this one. > I am going to push it anyway. No objection at all for doing so. If there would be an error, you will hear :) Fetched latest commit now.. ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 11:37:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 09:37:45 +0000 Subject: [Koha-bugs] [Bug 16008] noisy "fatal" warning when new file is moved in another patch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 --- Comment #13 from Marcel de Rooy --- Now tested again with Bug 15839 Error is gone, but I see a few 0's and 1's (debug stuff?) OK C4/Review.pm OK critic OK forbidden patterns 0 OK git manipulation OK pod SKIP spelling OK valid 0 FAIL Koha/Review.pm OK critic OK forbidden patterns 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 11:43:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 09:43:13 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #38 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #37) > QA Comment: > If I submit a new review, the approved status will be NULL. > But reviewswaiting.pl will not show it: > > my $status = $query->param('status') || 0; > ... > my $reviews = Koha::Reviews->search( > { approved => $status }, Marcel, This is fixed by "Change default value for approved to 0", please execute the updatedatabase.pl and update the schema. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 11:45:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 09:45:10 +0000 Subject: [Koha-bugs] [Bug 16008] noisy "fatal" warning when new file is moved in another patch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 --- Comment #14 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #13) > Now tested again with Bug 15839 > Error is gone, but I see a few 0's and 1's (debug stuff?) > > OK C4/Review.pm > OK critic > OK forbidden patterns > 0 > OK git manipulation > OK pod > SKIP spelling > OK valid > 0 > > FAIL Koha/Review.pm > OK critic > OK forbidden patterns > 1 Yes I have seen it too, but I think it already existed prior to this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 12:40:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 10:40:51 +0000 Subject: [Koha-bugs] [Bug 16008] noisy "fatal" warning when new file is moved in another patch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 --- Comment #15 from Jonathan Druart --- Marcel, commit 687b5cd790bbb0378a91d1896bcd947bbe76bec1 Display the errors if it's a valid error Will fix the 0 and 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 12:42:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 10:42:23 +0000 Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo" should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104 --- Comment #21 from Jonathan Druart --- FYI I have added a temporary fix to the qa tools commit d73431289d4c72d7751b006137f518851d2ee605 Do not consider "used only once: possible typo" as a warning (and make the tests pass!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 12:42:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 10:42:38 +0000 Subject: [Koha-bugs] [Bug 16104] Warnings "used only once: possible typo" should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16104 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |gmcharlt at gmail.com |ommunity.org | Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 12:55:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 10:55:10 +0000 Subject: [Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing › from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953 --- Comment #4 from Marc V?ron --- Oh, it was a wrong commit, sorry. New patch follows in the afternoon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 13:05:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 11:05:58 +0000 Subject: [Koha-bugs] [Bug 16910] Authority search plugin in cataloguing stops at 15 pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16910 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- This search is more complex than other authority searches, does it make sense to keep it like that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 13:43:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 11:43:33 +0000 Subject: [Koha-bugs] [Bug 16960] New: Patron::Modifications should be fixed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 Bug ID: 16960 Summary: Patron::Modifications should be fixed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The changes from opac-memberentry do not reach the table, since the Patron::Modifications object does not work well. Look at this from opac-memberentry: Koha::Patron::Modifications->new( borrowernumber => $borrowernumber ); Passing borrowernumber here is useless, since it is an instance of Koha::Objects. On the contrary, the following call $m->DelModifications; should have the borrowernumber passed ! So what could we add a sub new to Patron::Modifications like: +sub new { + my ( $class, $params ) = @_; + my $self = $class->SUPER::new(); + $self->{borrowernumber} = $params->{borrowernumber}; + return $self; +} And in opac-memberentry: + my $patronmod = Koha::Patron::Modifications->new({ borrowernumber => $borrowernumber }); + $patronmod->DelModifications({ borrowernumber => $borrowernumber }); + $patronmod->AddModifications(\%borrower_changes); But this is a horrible hack. We should not use a Koha::Objects like that.. And what about its unit test: t/db_dependent/Koha_borrower_modifications.t Currently fails ! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 13:43:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 11:43:57 +0000 Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16878 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 13:47:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 11:47:32 +0000 Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 --- Comment #1 from Marcel de Rooy --- Not to mention the random stuff interfering here too :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 13:53:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 11:53:01 +0000 Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16929 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 13:53:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 11:53:01 +0000 Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16960 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 13:58:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 11:58:57 +0000 Subject: [Koha-bugs] [Bug 16910] Authority search plugin in cataloguing stops at 15 pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16910 --- Comment #2 from Katrin Fischer --- Maybe we could fix the display somehow if not the search? Or did you mean about keeping the complexity? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 14:04:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 12:04:17 +0000 Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 --- Comment #2 from Jonathan Druart --- Upgrading the severity. I have completely missed that on QAing bug 14757, I focused on the notices code and did not see this part! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 14:04:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 12:04:23 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16960 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 [Bug 16960] Patron::Modifications should be fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 14:04:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 12:04:23 +0000 Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14757 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 14:07:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 12:07:11 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #57 from Jonathan Druart --- Kyle, bug 16929 has been introduced by these patches. Actually it seems that the changes made to Koha::Patron::Modification[s] were not intended. Could you confirm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 14:20:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 12:20:50 +0000 Subject: [Koha-bugs] [Bug 16910] Authority search plugin in cataloguing stops at 15 pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16910 --- Comment #3 from Jonathan Druart --- (In reply to Katrin Fischer from comment #2) > Maybe we could fix the display somehow if not the search? Or did you mean > about keeping the complexity? Please detail, I do not understand :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 14:23:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 12:23:55 +0000 Subject: [Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing › from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53559|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 53643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53643&action=edit Bug 16953: Acquisitions home: Remove trailing › from breadcrumbs The breadcrumb on the Acquisition's home page reads: Home > Acquisitions > This tiny patch removes the trailing > (›) Amended: Remove the link on 'Acquisitions' as well... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 14:31:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 12:31:03 +0000 Subject: [Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing › from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 14:31:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 12:31:05 +0000 Subject: [Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing › from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53643|0 |1 is obsolete| | --- Comment #6 from Claire Gravely --- Created attachment 53644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53644&action=edit Bug 16953: Acquisitions home: Remove trailing › from breadcrumbs The breadcrumb on the Acquisition's home page reads: Home > Acquisitions > This tiny patch removes the trailing > (›) Amended: Remove the link on 'Acquisitions' as well... Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 14:31:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 12:31:08 +0000 Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no records have been passed in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard --- I think a client-side check is also in order: Don't submit the form if no titles are checked. That's standard for similar interfaces in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 14:37:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 12:37:47 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #58 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #57) > Kyle, bug 16929 has been introduced by these patches. > Actually it seems that the changes made to Koha::Patron::Modification[s] > were not intended. Could you confirm? Should be bug 16960. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 14:55:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 12:55:56 +0000 Subject: [Koha-bugs] [Bug 16961] New: Add the Koha::Objects->update method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 Bug ID: 16961 Summary: Add the Koha::Objects->update method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org In order to update several rows in a single query, we need this new method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 14:56:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 12:56:32 +0000 Subject: [Koha-bugs] [Bug 16961] Add the Koha::Objects->update method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13019 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 [Bug 13019] Add base classes on which to build Koha objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 14:56:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 12:56:32 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 [Bug 16961] Add the Koha::Objects->update method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 15:00:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 13:00:56 +0000 Subject: [Koha-bugs] [Bug 16961] Add the Koha::Objects->update method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 15:00:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 13:00:59 +0000 Subject: [Koha-bugs] [Bug 16961] Add the Koha::Objects->update method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 --- Comment #1 from Jonathan Druart --- Created attachment 53645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53645&action=edit Bug 16961: Add Koha::Objects->update In order to update several rows in a single query, we need this new method. Test plan: Confirm that the changes in Objects.t make sense and that the tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 15:04:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 13:04:35 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver at bywatersolutions.co |kyle at bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 15:04:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 13:04:51 +0000 Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver at bywatersolutions.co |kyle at bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 15:06:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 13:06:52 +0000 Subject: [Koha-bugs] [Bug 14578] Allow merging of records upon import match In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver at bywatersolutions.co |kyle at bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 15:14:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 13:14:02 +0000 Subject: [Koha-bugs] [Bug 16937] Remove the use of "onclick" from the manage staged MARC records template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 15:14:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 13:14:04 +0000 Subject: [Koha-bugs] [Bug 16937] Remove the use of "onclick" from the manage staged MARC records template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53529|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 53646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53646&action=edit [SIGNED-OFF] Bug 16937 [Revised] Remove "onclick" from the manage staged MARC records template This patch revises the manage staged MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Manage staged MARC records. - If necessary, stage a MARC file for import. - Click the name of the staged file and then the "Import this batch into the catalog" button. The batch should be correctly imported. - Return to the list of staged MARC files. - Click the name of an imported file and then the "Undo import into catalog" button. The import should be reverted. - Return to the list of staged MARC files. - Click the "Clean" button for any record. Confirm that the batch is cleaned. - For any cleaned record, click the "Delete" button. The batch should be deleted. Signed-off-by: Hector Castro Works as advertised QA revision: Corrected class name so that "delete" button triggers the correct warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 15:18:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 13:18:09 +0000 Subject: [Koha-bugs] [Bug 16962] New: Remove the use of "onclick" from serial collection and serial edit templates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Bug ID: 16962 Summary: Remove the use of "onclick" from serial collection and serial edit templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com, testopia at bugs.koha-community.org There are many uses of "onclick" and other event attributes in the Serials module templates. This bug will track changes to serials-collection.tt and serials-edit.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 16:23:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 14:23:20 +0000 Subject: [Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection and serial edit templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 16:23:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 14:23:22 +0000 Subject: [Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection and serial edit templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 --- Comment #1 from Owen Leonard --- Created attachment 53647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53647&action=edit Bug 16962 - Remove the use of "onclick" from serial collection and serial edit templates This patch removes the use of event attributes like "onclick" from the serial collection and serial edit templates. Events are now defined in JavaScript. Also changed: Converted "create routing list," "edit routing list," and "Renew" links to Bootstrap buttons. The "select all" and "clear all" links have Font Awesome icons added. To test, apply the patch and go to Serials - Locate or create a subscription for which an item record is NOT created when receiving. - On the serial collection page for this subscription, test that the "Multi receiving" button works correctly. - For any subscription, test that the "Generate next" button works correctly. - In each tab, test that the "select all" and "clear all" links work correctly. - On a subscription which has expired, test that the "Renew" button works correctly. - On the serial collection page, select multiple issues and click the "Edit serials" button. - Testing with a subscription for which an item record is NOT created when receiving: - Changing the status to "Arrived" or "Claimed" should change the "Expected on" date to today's date. Selecting any other status should leave the "expected on" date as it was or return it to its original value. - Test that the "Multi receiving" button works correctly. - Testing with a subscription for which an item record IS created when receiving: - Changing the status of an issue should work as above but should also trigger the appearance of the item add form when the status is "Arrived" or "Claimed," and hide the form otherwise. - Cliking the "Item" link at the top of the item add form should hide it. - Clicking the "Add item" link under any issue should display the item add form. - In the item add form, test that repeatable fields are correctly duplicated when you click the "clone" button. - On the "Supplemental issue" line, changing the status to "Arrived" should work as described above. Changing the status on this line to "Claimed" should only change the "Expected on" date. - Adding regular and supplemental issues should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 16:32:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 14:32:58 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 --- Comment #4 from Colin Campbell --- (In reply to M. Tompsett from comment #2) > Comment on attachment 49907 [details] [review] > Proposed Patch > > Review of attachment 49907 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Circulation.pm > @@ +3209,5 @@ > > my $discount = _get_discount_from_rule($discount_rules, $branch, $item_type); > > $charge = ( $charge * ( 100 - $discount ) ) / 100; > > } > > + if ($charge) { > > + $charge = sprintf '%.2f', $charge; # ensure no fractions of a penny returned > > This is not identical to the %.02f from line 984 before. Please add the 0 > back. The value after the point is the number of decimal places presented the 0 is meaningless in this context see the printf/sprintf documentation where it is not used. ( 0 can be used on its own to suppress the decimal part). Using the precision as documented is less ambiguous -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 17:13:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 15:13:15 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #87 from H?ctor Eduardo Castro Avalos --- Created attachment 53648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53648&action=edit Bug 6934: Fix the href for datables in link rel stylesheet Fix the new path for 'datatables.css' -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 17:15:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 15:15:05 +0000 Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 17:29:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 15:29:47 +0000 Subject: [Koha-bugs] [Bug 16963] New: Remove the use of "onclick" from subscription add template Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963 Bug ID: 16963 Summary: Remove the use of "onclick" from subscription add template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com, testopia at bugs.koha-community.org There are many uses of "onclick" and other event attributes in the subscription add template. This bug will track changes to subscription-add.tt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 17:36:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 15:36:10 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mehdi.hamidi at inlibro.com --- Comment #29 from Mehdi Hamidi --- Hello Kyle, this patch now sends email to both the guarantor and the guarantee. The generation of the notice is still based on the guarantee messaging settings. Mehdi. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 17:37:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 15:37:06 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 17:37:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 15:37:09 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48645|0 |1 is obsolete| | --- Comment #30 from Mehdi Hamidi --- Created attachment 53649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53649&action=edit Bug 12532 - Redirect guarantee email to guarantor Fixed merge conflicts. Both the guarantor and the guarantee will receive the email now. Also fixed some log errors since the "save" button is the same one use for editing the patron details. Changed the save button "save" id whene editing only the Patron messaging preferences so we can detect where the request is comming from. Added unit tests. Added an atomicupdate file. Reordered the sysprefs in alphabetical order. Refactored some code. TEST PLAN: I Apply the patch II Run updatedatabase.pl III Run db_dependent/Letters.t and db_dependant/Members.t 0) Enable EnhancedMessagingPreferences preference; 0) Enable EnableRedirectGuaranteeEmail preference; 1) Select a patron with child; 2) Enable Item checkout -> email in patron messaging preferences; 3) Select the patron's child; 4) Checkout an item; 5) Valide child checkout message in patron's inbox; sponsored by the ville de victoriaville -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 17:39:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 15:39:20 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53589|0 |1 is obsolete| | --- Comment #88 from H?ctor Eduardo Castro Avalos --- Created attachment 53650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53650&action=edit [SIGNED-OFF]Bug 6934: QA follow-up - fixed tabs - fixed capitalization on reports start page Signed-off-by: Hector Castro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 17:39:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 15:39:33 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53590|0 |1 is obsolete| | --- Comment #89 from H?ctor Eduardo Castro Avalos --- Created attachment 53651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53651&action=edit [SIGNED-OFF]Bug 6934: fix problem when export it open in LibreOffice - show values of itype and use TT plugin Signed-off-by: Hector Castro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 17:39:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 15:39:45 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53591|0 |1 is obsolete| | --- Comment #90 from H?ctor Eduardo Castro Avalos --- Created attachment 53652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53652&action=edit [SIGNED-OFF]Bug 6934: Make CSV header column translatable and add total amounts in csv file Signed-off-by: Hector Castro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 17:39:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 15:39:55 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53648|0 |1 is obsolete| | --- Comment #91 from H?ctor Eduardo Castro Avalos --- Created attachment 53653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53653&action=edit [SIGNED-OFF]Bug 6934: Fix the href for datables in link rel stylesheet Fix the new path for 'datatables.css' Signed-off-by: Hector Castro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 17:42:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 15:42:10 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #92 from H?ctor Eduardo Castro Avalos --- Hi Bouzid For me this is Ok. Just explain what does "Active transaction" mean? QA comment 59 Regards -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:02:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:02:12 +0000 Subject: [Koha-bugs] [Bug 16964] New: Fix capitalization for "Report Plugins" in reports-home.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964 Bug ID: 16964 Summary: Fix capitalization for "Report Plugins" in reports-home.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: hector.hecaxmmx at gmail.com Reporter: hector.hecaxmmx at gmail.com QA Contact: testopia at bugs.koha-community.org Fix capitalization for "Report Plugins" in reports-home.tt according with Coding Guidelines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:03:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:03:53 +0000 Subject: [Koha-bugs] [Bug 16964] Fix capitalization for "Report Plugins" in reports-home.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 53654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53654&action=edit Bug 16964: Fix capitalization for "Report Plugins" in reports-home.tt Fix capitalization for "Report Plugins" in reports-home.tt according with Coding Guidelines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:03:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:03:51 +0000 Subject: [Koha-bugs] [Bug 16964] Fix capitalization for "Report Plugins" in reports-home.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:07:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:07:35 +0000 Subject: [Koha-bugs] [Bug 16965] New: Add the Koha::Objects->search_related method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Bug ID: 16965 Summary: Add the Koha::Objects->search_related method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 13019 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 [Bug 13019] Add base classes on which to build Koha objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:07:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:07:35 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 [Bug 16965] Add the Koha::Objects->search_related method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:07:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:07:48 +0000 Subject: [Koha-bugs] [Bug 16961] Add the Koha::Objects->update method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53645|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 53655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53655&action=edit [SIGNED-OFF]Bug 16961: Add Koha::Objects->update In order to update several rows in a single query, we need this new method. Test plan: Confirm that the changes in Objects.t make sense and that the tests pass. Signed-off-by: Hector Castro Test passed successfully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:08:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:08:09 +0000 Subject: [Koha-bugs] [Bug 16961] Add the Koha::Objects->update method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:20:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:20:21 +0000 Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 [Bug 16961] Add the Koha::Objects->update method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:20:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:20:21 +0000 Subject: [Koha-bugs] [Bug 16961] Add the Koha::Objects->update method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 [Bug 16965] Add the Koha::Objects->search_related method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:21:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:21:28 +0000 Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:21:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:21:31 +0000 Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #1 from Jonathan Druart --- Created attachment 53656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53656&action=edit Bug 16965: Add Koha::Objects->search_related In order to search on relations, we need this new method. Test plan: Confirm that the changes in Objects.t make sense and that the tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:35:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:35:48 +0000 Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 [Bug 16966] Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:35:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:35:48 +0000 Subject: [Koha-bugs] [Bug 16966] New: Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Bug ID: 16966 Summary: Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 16961, 16965 Blocks: 16846 The C4::Members::GetBorrowersWithIssuesHistoryOlderThan subroutine is supposed to return the patrons with an issue history older than a given date. It would make more sense to return a list of Koha::Patrons. On the way, the code from AnonymiseIssueHistory will be moved as well to anonymise_issue_history. Note that these 2 subroutines are strongly linked: one is used to know the number of patrons we will anonymise the history, the other one is used to anonymise the issues history. The problem is that the first one is not used to do the action, but only for displayed purpose. In some cases, these 2 values can differ, which could be confusing. Case 1: The logged in librarian is not superlibrarian and IndependentBranches is set: if 2+ patrons from different libraries match the date parameter, the interface will display "Checkout history for 2 patrons will be anonymized", when actually only 1 will be. Case 2: If 2+ patrons match the date parameter but one of them has his privacy set to forever (privacy=0), the same issue will appear. The patches provided will refactor the code and fix these 2 issues. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 [Bug 16961] Add the Koha::Objects->update method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 [Bug 16965] Add the Koha::Objects->search_related method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:35:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:35:48 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 [Bug 16966] Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:35:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:35:48 +0000 Subject: [Koha-bugs] [Bug 16961] Add the Koha::Objects->update method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 [Bug 16966] Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:36:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:36:21 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 --- Comment #16 from Jonathan Druart --- Bug 16966 - Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:45:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:45:52 +0000 Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- Shouldn't you wrap them like search does ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:47:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:47:18 +0000 Subject: [Koha-bugs] [Bug 16961] Add the Koha::Objects->update method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- Time for an AUTOLOAD ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:52:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:52:35 +0000 Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 18:52:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 16:52:38 +0000 Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 --- Comment #3 from Kyle M Hall --- Created attachment 53657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53657&action=edit Bug 16960 - Patron::Modifications should be fixed The changes from opac-memberentry do not reach the table, since the Patron::Modifications object does not work well. Test Plan: 1) Apply this patch 2) Create some patron modification requests 3) Ensure you can approve and deny modifications 4) Ensure patron self registration works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:06:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:06:12 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:06:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:06:15 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 --- Comment #1 from Jonathan Druart --- Created attachment 53658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53658&action=edit Bug 16966: GetBorrowersWithIssuesHistoryOlderThan - Highlight the existing issue in tests If IndependentBranches is set, the code is buggy. This patch only highlight the bug by providing a test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:06:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:06:18 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 --- Comment #2 from Jonathan Druart --- Created attachment 53659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53659&action=edit Bug 16966: Koha::Patrons - Move AnonymiseIssueHistory tests The next patch will move C4::Circulation::AnonymiseIssueHistory and C4::Members::GetBorrowersWithIssuesHistoryOlderThan to Koha::Patrons This patch move the history anonymisation code to the Patrons.t test file and the entire subtest related to StoreLastBorrower to StoreLastBorrower.t It just moves and add some minor adjustements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:06:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:06:21 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 --- Comment #3 from Jonathan Druart --- Created attachment 53660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53660&action=edit Bug 16966: Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise The C4::Members::GetBorrowersWithIssuesHistoryOlderThan subroutine is supposed to return the patrons with an issue history older than a given date. It would make more sense to return a list of Koha::Patrons. On the way, the code from AnonymiseIssueHistory will be moved as well to anonymise_issue_history. Note that these 2 subroutines are strongly linked: one is used to know the number of patrons we will anonymise the history, the other one is used to anonymise the issues history. The problem is that the first one is not used to do the action, but only for displayed purpose. In some cases, these 2 values can differ, which could be confusing. Case 1: The logged in librarian is not superlibrarian and IndependentBranches is set: if 2+ patrons from different libraries match the date parameter, the interface will display "Checkout history for 2 patrons will be anonymized", when actually only 1 will be. Case 2: If 2+ patrons match the date parameter but one of them has his privacy set to forever (privacy=0), the same issue will appear. This patch moves the code from C4::Members::GetBorrowersWithIssuesHistoryOlderThan to Koha::Patrons->search_patrons_to_anonymise and from C4::Circulation::AnonymiseIssueHistory to Koha::Patrons->anonymise_issue_history Test plan: 1/ Confirm the 2 issues and make sure they are fixed using the Batch patron anonymization tool (tools/cleanborrowers.pl) 2/ At the OPAC, use the 'Immediate deletion' button to delete all your reading history (regardless the setting of the privacy rule) 3/ Use the cronjob script (misc/cronjobs/batch_anonymise.pl) to anonymise patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:07:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:07:39 +0000 Subject: [Koha-bugs] [Bug 16941] Can not add new patron in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16941 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:09:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:09:08 +0000 Subject: [Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall --- Pushed to master for 16.11, thanks Jesse! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:10:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:10:29 +0000 Subject: [Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to master for 16.11, thanks Srdjan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:11:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:11:14 +0000 Subject: [Koha-bugs] [Bug 16947] Can not modify patron messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:13:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:13:17 +0000 Subject: [Koha-bugs] [Bug 16934] Cannot add notes to canceled and deleted order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 16.11, thanks for the followup Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:14:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:14:26 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53467|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:14:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:14:36 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53468|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:14:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:14:41 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53469|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:14:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:14:52 +0000 Subject: [Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53660|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 53661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53661&action=edit Bug 16966: Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise The C4::Members::GetBorrowersWithIssuesHistoryOlderThan subroutine is supposed to return the patrons with an issue history older than a given date. It would make more sense to return a list of Koha::Patrons. On the way, the code from AnonymiseIssueHistory will be moved as well to anonymise_issue_history. Note that these 2 subroutines are strongly linked: one is used to know the number of patrons we will anonymise the history, the other one is used to anonymise the issues history. The problem is that the first one is not used to do the action, but only for displayed purpose. In some cases, these 2 values can differ, which could be confusing. Case 1: The logged in librarian is not superlibrarian and IndependentBranches is set: if 2+ patrons from different libraries match the date parameter, the interface will display "Checkout history for 2 patrons will be anonymized", when actually only 1 will be. Case 2: If 2+ patrons match the date parameter but one of them has his privacy set to forever (privacy=0), the same issue will appear. This patch moves the code from C4::Members::GetBorrowersWithIssuesHistoryOlderThan to Koha::Patrons->search_patrons_to_anonymise and from C4::Circulation::AnonymiseIssueHistory to Koha::Patrons->anonymise_issue_history Test plan: 1/ Confirm the 2 issues and make sure they are fixed using the Batch patron anonymization tool (tools/cleanborrowers.pl) 2/ At the OPAC, use the 'Immediate deletion' button to delete all your reading history (regardless the setting of the privacy rule) 3/ Use the cronjob script (misc/cronjobs/batch_anonymise.pl) to anonymise patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:15:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:15:34 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #326 from Kyle M Hall --- 3 patches pushed to master for 16.11. I reset the status to assigned. If this isn't the correct status, can someone please update it? Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:16:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:16:25 +0000 Subject: [Koha-bugs] [Bug 11606] Novelist Select in Staff Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Kyle M Hall --- Pushed to master for 16.11, thanks Nick, Jesse! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:16:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:16:28 +0000 Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #3 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #2) > Shouldn't you wrap them like search does ? I don't think so: "In list context, ->all() is called implicitly on the resultset, thus returning a list of result objects instead." https://metacpan.org/pod/DBIx::Class::ResultSet#search_related -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:17:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:17:52 +0000 Subject: [Koha-bugs] [Bug 16961] Add the Koha::Objects->update method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 --- Comment #4 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #3) > Time for an AUTOLOAD ? Yes, it's in my todo list :) I have just needed it for bug 16966 and did not want to add a 'big' blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:17:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:17:58 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Kyle M Hall --- Pushed to master for 16.11, thanks Jesse! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:18:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:18:36 +0000 Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:22:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:22:33 +0000 Subject: [Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #49 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:23:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:23:51 +0000 Subject: [Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #12 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:24:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:24:41 +0000 Subject: [Koha-bugs] [Bug 16906] Add DataTables pagination and filter to top of saved SQL reports table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:25:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:25:50 +0000 Subject: [Koha-bugs] [Bug 16945] Syspref PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16945 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:26:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:26:31 +0000 Subject: [Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 16.11, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 19:27:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 17:27:44 +0000 Subject: [Koha-bugs] [Bug 14793] New cataloguing plugin unimarc_field_225a_bis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14793 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to master for 16.11, thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 20:08:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 18:08:53 +0000 Subject: [Koha-bugs] [Bug 16963] Remove the use of "onclick" from subscription add template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 20:08:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 18:08:55 +0000 Subject: [Koha-bugs] [Bug 16963] Remove the use of "onclick" from subscription add template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963 --- Comment #1 from Owen Leonard --- Created attachment 53662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53662&action=edit Bug 16963 - Remove the use of "onclick" from subscription add template This patch removes the use of event attributes from the subscription add template and the template for testing prediction patterns. Events are now defined in the JavaScript. To test, go to Serials -> New subscription. - Test that the "Search for vendor," "Search for record," and "Create record" links work correctly. - Test the "Next" button without entering a vendor or a biblionumber. You should be warned about selecting a vendor and biblionumber. - After selecting a bibliographic record to link to the subscription, click the "Next" button. The second section of the subscription add form should be displayed. - Under frequency, choose "1/day." - Confirm that the "Show advanced pattern" link correctly toggles display of the advanced pattern form. - Under the advanced pattern form, test the "Modify pattern" button. It should enable editing in the form. - Test the "Cancel modifications" and "Save as new pattern" buttons. - Test the "Test prediction pattern" button. - In the "Prediction pattern" box, test that the checkboxes next to each day of the week, when checked, trigger the corresponding issue number to be marked as "not published." - Finally, confirm that your subscription is saved correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 20:43:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 18:43:26 +0000 Subject: [Koha-bugs] [Bug 16967] New: Remove the use of "onclick" from serial frequency and numbering management Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967 Bug ID: 16967 Summary: Remove the use of "onclick" from serial frequency and numbering management Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com, testopia at bugs.koha-community.org There are several instances of "onclick" in the templates for managing serial numbering patterns and serial frequencies. These should be removed in favor of events defined in the JavaScript. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 20:58:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 18:58:25 +0000 Subject: [Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 20:58:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 18:58:27 +0000 Subject: [Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967 --- Comment #1 from Owen Leonard --- Created attachment 53663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53663&action=edit Bug 16967 - Remove the use of "onclick" from serial frequency and numbering management This patch removes instance of "onclick" from the templates for serial frequency and numbering management. Events are now defined in the JavaScript. To test, apply the patch and go to Serials -> Manage frequencies. - In the list of frequencies, click the "Delete" button for a frequency which is in use by at least one subscription. In the confirmation dialog, clicking the "Show subscriptions" link should display a list of titles. - Edit or create a frequency. - To test that the form submission validation is still working correctly, enter non-numeric data in the "issues per unit" field and submit the form. This should trigger an error. In Serials -> Manage numbering patterns: - In the list of numbering patterns, click the "Delete" button for a pattern which is in use by at least one subscription. In the confirmation dialog, clicking the "Show subscriptions" link should display a list of titles. - Edit or create a numbering pattern. - Confirm that the "Test pattern" button works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 21:22:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 19:22:50 +0000 Subject: [Koha-bugs] [Bug 16968] New: Remove the use of "onclick" from serial patron and vendor search templates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968 Bug ID: 16968 Summary: Remove the use of "onclick" from serial patron and vendor search templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com, testopia at bugs.koha-community.org There are a few instances of "onclick" in the templates for serial patron and vendor search templates. These should be removed in favor of events defined in the JavaScript. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 21:28:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 19:28:15 +0000 Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 --- Comment #12 from M. Tompsett --- Now the Elastic search upgrade stuff was bombing horribly. for 3.23.0.50. commented it out... everything else fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 21:34:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 19:34:20 +0000 Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 21:34:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 19:34:22 +0000 Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53639|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 53664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53664&action=edit Bug 16573: Define virtualshelves.created_on as datetime for existing installs Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 23:32:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 21:32:58 +0000 Subject: [Koha-bugs] [Bug 16918] opacmain.pl is not running under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16918 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 23:33:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 21:33:09 +0000 Subject: [Koha-bugs] [Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 23:33:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 21:33:20 +0000 Subject: [Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 22 23:33:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Jul 2016 21:33:41 +0000 Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 23 05:28:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jul 2016 03:28:00 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 --- Comment #5 from M. Tompsett --- (In reply to Colin Campbell from comment #4) [SNIP] > The value after the point is the number of decimal places presented the 0 is > meaningless in this context see the printf/sprintf documentation where it is > not used. ( 0 can be used on its own to suppress the decimal part). Using > the precision as documented is less ambiguous Okay, then should they not be both the same? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 23 13:27:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jul 2016 11:27:33 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #16 from Marc V?ron --- Just a note: Without Sereal, staff client crashed with a message like "missing Sereal" before it could execute C4/Installer/PerlDependencies.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 23 18:37:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jul 2016 16:37:53 +0000 Subject: [Koha-bugs] [Bug 16964] Fix capitalization for "Report Plugins" in reports-home.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53654|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 53665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53665&action=edit Bug 16964: Fix capitalization for "Report Plugins" in reports-home.tt Fix capitalization for "Report Plugins" in reports-home.tt according with Coding Guidelines Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 23 18:38:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jul 2016 16:38:07 +0000 Subject: [Koha-bugs] [Bug 16964] Fix capitalization for "Report Plugins" in reports-home.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 23 18:44:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jul 2016 16:44:20 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 23 20:33:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jul 2016 18:33:01 +0000 Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 23 20:33:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jul 2016 18:33:05 +0000 Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 --- Comment #2 from Magnus Enger --- Created attachment 53666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53666&action=edit Bug 5456 - Create a link to opac-ics.pl opac-ics.pl was added to Koha back in 2007, but there has not been a link to it from anywhere. This patch adds the link from the main view on /cgi-bin/koha/opac-user.pl, and makes some changes to opac-ics.pl itself. Changes to opac-ics.pl: - Update the code to use date and time for when a loan is due - Use dt_from_string to turn a MySQL time and date into a DateTime - Add a timestamp and a UID (these were reported as necessary by a couple of iCal validators) - Remove DTEND from events, since we now have time as well as date for when a loan is due - For loans that are overdue, set the DTSTART to now(), to avoid creating calendar events in the past - Use a template to generate text strings, to make them translatable To test: - Apply the patch - Make sure you have at least a couple of loans, including one overdue - Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as iCal/.ics file" - Inspect the file in a text editor and/or view the result in a calendar appplication. Make sure the data makes sense. - Sign off and go thee merrily on thine way. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jul 23 23:27:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Jul 2016 21:27:06 +0000 Subject: [Koha-bugs] [Bug 16566] 'Print slip' button formatting inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 24 06:21:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Jul 2016 04:21:35 +0000 Subject: [Koha-bugs] [Bug 16960] Patron::Modifications should be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Marc V?ron --- Hi Kyle, Sorry, after applying the patch, I get an "Internal server error" on Home > Patrons (members-home.pl) plack-error.log says: Can't locate object method "GetPendingModificationsCount" via package "Koha::Patron::Modifications" at /home/marc/koha/members/members-home.pl line 91. git grep GetPendingModifications members/members-home.pl: Koha::Patron::Modifications->GetPendingModificationsCount( $branch ); ^ Leads to error. If I fix this line, members-home.pl displays as expected t/db_dependent/Koha_borrower_modifications.t:'Add a new pending modification and test GetPendingModificationsCount() again' t/db_dependent/Koha_borrower_modifications.t:## Check GetPendingModifications marc at debian8vm:~/koha$ ^ Inside comments, but I think it would be fine to change them for readability Otherwise, sending an update request from OPAC and applying it from Staff client works OK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 24 07:15:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Jul 2016 05:15:40 +0000 Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 --- Comment #3 from Marc V?ron --- Nice feature! However, I can not import to thunderbird calendar. This is what I get as koha.ics: BEGIN:VCALENDAR VERSION:2.0 PRODID:Data::ICal 0.21 BEGIN:VEVENT DESCRIPTION:Your copy of ""Pf?tzen schreien so laut ihr Licht" :" (barcode 1234567890) is due back at the library today DTSTAMP:20160724T050512Z DTSTART:TZID=Europe/Zurich:20160724T235900 SUMMARY:""Pf?tzen schreien so laut ihr Licht" :" is due UID:issue-1@ END:VEVENT END:VCALENDAR If I fix the DTStart as follows, it imports OK: BEGIN:VCALENDAR VERSION:2.0 PRODID:Data::ICal 0.21 BEGIN:VEVENT DESCRIPTION:Your copy of ""Pf?tzen schreien so laut ihr Licht" :" (barcode 1234567890) is due back at the library today DTSTAMP:20160724T050512Z DTSTART:20160724T235900 TZID:Europe/Zurich SUMMARY:""Pf?tzen schreien so laut ihr Licht" :" is due UID:issue-1@ END:VEVENT END:VCALENDAR Additionally, I think there are to much quotes in DESCRIPTION -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 24 17:38:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Jul 2016 15:38:43 +0000 Subject: [Koha-bugs] [Bug 16449] unimarc_field_4XX raises a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com, | |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 00:05:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Jul 2016 22:05:16 +0000 Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53666|0 |1 is obsolete| | --- Comment #4 from Magnus Enger --- Created attachment 53670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53670&action=edit Bug 5456 - Create a link to opac-ics.pl opac-ics.pl was added to Koha back in 2007, but there has not been a link to it from anywhere. This patch adds the link from the main view on /cgi-bin/koha/opac-user.pl, and makes some changes to opac-ics.pl itself. Changes to opac-ics.pl: - Update the code to use date and time for when a loan is due - Use dt_from_string to turn a MySQL time and date into a DateTime - Add a timestamp and a UID (these were reported as necessary by a couple of iCal validators) - Remove DTEND from events, since we now have time as well as date for when a loan is due - For loans that are overdue, set the DTSTART to now(), to avoid creating calendar events in the past - Use a template to generate text strings, to make them translatable To test: - Apply the patch - Make sure you have at least a couple of loans, including one overdue - Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as iCal/.ics file" - Inspect the file in a text editor and/or view the result in a calendar appplication. Make sure the data makes sense. - Sign off and go thee merrily on thine way. Update 2016-07-25 - Force date_due to UTC to avoid problematic timezone info like this: DTSTART:TZID=Europe/Zurich:20160724T235900 - Remove quotes from summary and description -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 04:40:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 02:40:39 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #97 from M. Tompsett --- PerlDependencies issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 07:20:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 05:20:39 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #31 from Marc V?ron --- Testing: - EnableRedirectGuaranteeEmail on - Both guarantor and guarantee have valid email address Messaging preferences: - Guarantee: all on - Guarantor: all on -Trigger mail (e.g. Checkout), run process_message_queue.pl Result: Mail goes to both (as expected) Messaging preferences: - Guarantee: all on - Guarantor: all off - Trigger mail (e.g. Checkout), run process_message_queue.pl Result: Mail goes to both (as expected) Messaging preferences: - Guarantee: all off - Guarantor: all on - Trigger mail (e.g. Checkout), run process_message_queue.pl Result: No mail (as expected) Messaging preferences: - Guarantee: all off - Guarantor: all off - Trigger mail (e.g. Checkout), run process_message_queue.pl Result: No mail (as expected) Running tests: t/db_dependent/Letters.t ------------------------ # Failed test 'With EnableRedirectGuaranteeEmail on, Message is sent to the guarantor's email address.' # at t/db_dependent/Letters.t line 193. # got: 'toto at exemple.com' # expected: 'guarantor at example.com' Fake sendmail at t/db_dependent/Letters.t line 32. # Failed test 'With EnableRedirectGuaranteeEmail on, message fails if guarantor has no address.' # at t/db_dependent/Letters.t line 198. # got: 'sent' # expected: 'failed' Fake sendmail at t/db_dependent/Letters.t line 32. # Looks like you planned 74 tests but ran 80. # Looks like you failed 2 tests of 80 run. t/db_dependent/Letters.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/74 subtests Test Summary Report ------------------- t/db_dependent/Letters.t (Wstat: 512 Tests: 80 Failed: 8) Failed tests: 30-31, 75-80 Non-zero exit status: 2 Parse errors: Bad plan. You planned 74 tests but ran 80. t/db_dependent/Members.t ------------------------ t/db_dependent/Members.t .. 1/79 "my" variable $guarantee masks earlier declaration in same scope at t/db_dependent/Members.t line 331. t/db_dependent/Members.t .. 2/79 # Failed test 'GetNoticeEmailAddress returns correct value when EnableRedirectGuaranteeEmail is activated' # at t/db_dependent/Members.t line 187. # got: 'guanrantee at email.test,Marie at work.com' # expected: 'Marie at work.com' t/db_dependent/Members.t .. 79/79 # Looks like you planned 79 tests but ran 81. # Looks like you failed 1 test of 81 run. t/db_dependent/Members.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/79 subtests Test Summary Report ------------------- t/db_dependent/Members.t (Wstat: 256 Tests: 81 Failed: 3) Failed tests: 27, 80-81 Non-zero exit status: 1 Parse errors: Bad plan. You planned 79 tests but ran 81. Files=1, Tests=81, 3 wallclock secs ( 0.04 usr 0.00 sys + 1.96 cusr 0.13 csys = 2.13 CPU) Result: FAIL Setting to FQA because of the tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 07:37:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 05:37:36 +0000 Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53670|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 53671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53671&action=edit Bug 5456 - Create a link to opac-ics.pl opac-ics.pl was added to Koha back in 2007, but there has not been a link to it from anywhere. This patch adds the link from the main view on /cgi-bin/koha/opac-user.pl, and makes some changes to opac-ics.pl itself. Changes to opac-ics.pl: - Update the code to use date and time for when a loan is due - Use dt_from_string to turn a MySQL time and date into a DateTime - Add a timestamp and a UID (these were reported as necessary by a couple of iCal validators) - Remove DTEND from events, since we now have time as well as date for when a loan is due - For loans that are overdue, set the DTSTART to now(), to avoid creating calendar events in the past - Use a template to generate text strings, to make them translatable To test: - Apply the patch - Make sure you have at least a couple of loans, including one overdue - Go to /cgi-bin/koha/opac-user.pl and click on the link labeled "Download as iCal/.ics file" - Inspect the file in a text editor and/or view the result in a calendar appplication. Make sure the data makes sense. - Sign off and go thee merrily on thine way. Update 2016-07-25 - Force date_due to UTC to avoid problematic timezone info like this: DTSTART:TZID=Europe/Zurich:20160724T235900 - Remove quotes from summary and description Followed test plan, koha.ics file successfully imported to Thunderbird calendar Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 07:39:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 05:39:25 +0000 Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 08:48:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 06:48:10 +0000 Subject: [Koha-bugs] [Bug 14972] Limit by availability does not return results if *any* items are on-loan or lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14972 Wadid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thysia at live.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 08:48:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 06:48:51 +0000 Subject: [Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715 Wadid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thysia at live.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 08:50:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 06:50:18 +0000 Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > (In reply to Marcel de Rooy from comment #2) > > Shouldn't you wrap them like search does ? > > I don't think so: > "In list context, ->all() is called implicitly on the resultset, thus > returning a list of result objects instead." > https://metacpan.org/pod/DBIx::Class::ResultSet#search_related I mean the other search: sub search { my ( $self, $params, $attributes ) = @_; if (wantarray) { my @dbic_rows = $self->_resultset()->search($params, $attributes); return $self->_wrap(@dbic_rows); etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 09:12:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 07:12:49 +0000 Subject: [Koha-bugs] [Bug 16970] New: In OPAC Search results, hides a record if some of its items are available and others unavailable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16970 Bug ID: 16970 Summary: In OPAC Search results, hides a record if some of its items are available and others unavailable Change sponsored?: --- Product: Koha Version: 3.22 Hardware: PC OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: thysia at live.com QA Contact: testopia at bugs.koha-community.org This is a misleading bug for users on OPAC, as they can think that a book is not currently available when it has still available items. If we cannot solve this bug, it would be better not to give this feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:12:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:12:42 +0000 Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 --- Comment #8 from Lari Taskula --- Created attachment 53672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53672&action=edit Bug 16826: Add API route for getting item availability Fixed tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:13:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:13:27 +0000 Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53371|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:25:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:25:01 +0000 Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #5 from Jonathan Druart --- Created attachment 53673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53673&action=edit Bug 16965: search_related returns an instanciated Koha::Objects-based object Koha::Objects->search_related should return a Koha::Objects-based object. This search_related method should follow the same rules as the search method, i.e. take into account what the caller want (scalar or list). The problem here is that we do not know (in Koha::Objects) what is the kind of objects we want to instanciate. To know it, this patch adds a get_object_class, it will return the class of the object and the resultset Koha::Object-based object. The drawback of this method is that we will have to keep it up-to-date every time we add a new Koha::Object class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:33:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:33:57 +0000 Subject: [Koha-bugs] [Bug 16971] New: Missing dependency for HTML::Entities Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971 Bug ID: 16971 Summary: Missing dependency for HTML::Entities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:35:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:35:59 +0000 Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:36:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:36:01 +0000 Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971 --- Comment #1 from Marcel de Rooy --- Created attachment 53674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53674&action=edit Bug 16971: Missing dependency for HTML::Entities This module is already used in opac-password-recovery.pl. It is loaded in Acquisition, but not used (anymore?). It is not yet listed in PerlDependencies. Note: The module is packaged for Debian Wheezy and Jessie. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:36:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:36:38 +0000 Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53672|0 |1 is obsolete| | --- Comment #9 from Lari Taskula --- Created attachment 53675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53675&action=edit Bug 16826: Add API route for getting item availability Updates documentation for Koha::Item::Availability. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:37:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:37:36 +0000 Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16878 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:37:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:37:56 +0000 Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:45:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:45:07 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 --- Comment #17 from Jonathan Druart --- (In reply to Marc V?ron from comment #16) > Just a note: > Without Sereal, staff client crashed with a message like "missing Sereal" > before it could execute C4/Installer/PerlDependencies.pm Indeed, but I don't think we should try to avoid that. It's part of the upgrade job to check if all deps are installed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:48:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:48:51 +0000 Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:48:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:48:57 +0000 Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51760|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 53676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53676&action=edit Bug 16573: fix linkid value on marc_subfield_structure followup to previous patch. This patch fixes linkid value. It was set to '', but declared as tinyint. Mysql < 5.7 replaced this with nearest right value, i.e 0 Mysql 5.7 gives error here. Also some normalization, all lines with data begins with two tabs To test: On top of Bug 16572 and previous patch 1) Run webinstaller 2) Add mandatory values 3) There must be no problems on MySQL 5.7 Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:49:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:49:01 +0000 Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51761|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 53677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53677&action=edit Bug 16573: fix structure and sample data for MySQL 5.7 Web install on Ubuntu 16.04/Mysql 5.7 fails. This patch makes small changes to make installation possible to kohastructure.sql and some sample files. Sample values for quotes table can't have '0000-00-00 ...' values nor NULL values, now() is perhaps an option. Depends on Bug 16572 To test: 1) System with MySQL 5.7, for example Ubuntu 16.05 2) Apply 16572 3) Try web install, it fails 4) Apply this and next patch 5) Try again, now it succeed This is only for English install, i18n files needs revision I can do that if this is accepted. Perphaps a change is needed to updatedatabase.pl Ammended patch, 'created_on' field on virtualshelves can't be timestamp default null, mysql 5.5 complains that only one timestamp column can be defined as default not null. Changed to 'datetime' type. Can provide followup with updatedabase change, but need an opinion if this type change makes sense. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:49:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:49:10 +0000 Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53664|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 53679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53679&action=edit Bug 16573: Define virtualshelves.created_on as datetime for existing installs Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:49:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:49:06 +0000 Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51762|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 53678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53678&action=edit Bug 16573: change created_on type - atomic update This patch change 'created_on' virtualshelves column to datetime type To test: 1) Apply the patch 2) Run updatedatabase.pl 3) Verify type of 'created_on' column Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:50:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:50:10 +0000 Subject: [Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 --- Comment #18 from Jonathan Druart --- (In reply to M. Tompsett from comment #12) > Now the Elastic search upgrade stuff was bombing horribly. for 3.23.0.50. > commented it out... everything else fine. Ok thanks Mark. I think it's better to fix it on another bug report otherwise this one will never get pushed :) Could you please open a bug report for this upgrade issue and describe what the error is? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 12:58:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 10:58:34 +0000 Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 13:12:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 11:12:56 +0000 Subject: [Koha-bugs] [Bug 16576] Remove the use of "onclick" from label templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16576 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 13:13:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 11:13:00 +0000 Subject: [Koha-bugs] [Bug 16576] Remove the use of "onclick" from label templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16576 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53447|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 53680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53680&action=edit Bug 16576 [Revised] Remove the use of "onclick" from label templates This patch updates several label creator templates to remove the use of "onclick" in favor of defining click events in JavaScript. Also changed: - Replaced the non-existant element with - Removed the use of
and 'align="center"'; - In the item search results template: - The use of the checkboxes jQuery plugin has been replaced with straight jQuery for simplicity's sake. - Output of table headers has been modified so that translatable strings are in the template instead of having English strings passed from the script. - Moved the 'Add checked' and 'Done' buttons into a floating toolbar. To test, apply the patch and go to Tools -> Label creator. - Choose New -> Label batch - Click 'Add items' - Perform a search for items. - Confirm that 'select all' and 'clear all' links work. - Confirm that clicking an individual 'Add' button works. - Select multiple items and click the 'Add checked' button. Confirm that the selected items were added to your batch. - Click 'Add items' again to save the selected items to your batch. - Test that the 'Delete' and 'Export' buttons next to any item work correctly. - Choose Manage -> Label batches - Test that the 'Delete' button works correctly. - Select one or more batches and test that the 'Export selected' button works correctly. Revision: Removed changes to pagination in the item search results template since it didn't work. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 13:17:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 11:17:38 +0000 Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- QA comments: 1/ POD of the plugin is wrong (c/p and not updated from another one). 2/ Since this plugin is only used once, why did you choose to use a TT plugin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 14:06:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 12:06:46 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 14:32:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 12:32:16 +0000 Subject: [Koha-bugs] [Bug 16972] New: ./misc/ sip_cli_emulator.pl should list mandatory vs. optional command line options in its usage section. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16972 Bug ID: 16972 Summary: ./misc/sip_cli_emulator.pl should list mandatory vs. optional command line options in its usage section. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz As far as I can tell, the following options are mandatory: -a (address) -p (port) -su (sip user) -sp (sip password) -l (sip location/institution) The sip terminator (-t) is not mandatory, but getting it wrong hangs the script without warning. The usage would look like this, more or less: Usage: $0 -a
-p -su -sp -l [--patron ] [--password ] [-i ] [-fa] [-m ] [-h] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 14:32:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 12:32:40 +0000 Subject: [Koha-bugs] [Bug 16972] ./misc/ sip_cli_emulator.pl should list mandatory vs. optional command line options in its usage section. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16972 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 14:34:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 12:34:20 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- --- a/C4/Items.pm +++ b/C4/Items.pm @@ -2815,6 +2815,10 @@ sub PrepareItemrecordDisplay { my $dbh = C4::Context->dbh; $frameworkcode = &GetFrameworkCode($bibnum) if $bibnum; my ( $itemtagfield, $itemtagsubfield ) = &GetMarcFromKohaField( "items.itemnumber", $frameworkcode ); + + # it would be perhaps beneficial (?) to call GetMarcStructure with 'unsafe' parameter + # for performance reasons, but $tagslib may be passed to $plugin->build(), and there + # is no way to ensure that this structure is not getting corrupted somewhere in there my $tagslib = &GetMarcStructure( 1, $frameworkcode ); Hm. I have the strong impression that the item plugins do not even read the tagslib structure. I kept the parameter in terms of backward compatibility for custom plugins that would need it. It might be an idea to let these custom (item) plugins call GetMarcStructure itself when they really need it.. But yes, that would be another report :) The assumption that tagslib would be corrupted by a plugin is not very realistic imo; most do not even read, not to mention change. If the included plugins do not, how far should we go in protecting the author of a custom plugin from the potential threat he created himself? We can't stop him now from doing all kinds of things.. So I would not object to calling it unsafe here too. In my tests it makes a remarkable difference: 0.0015 versus 0.046 per GetMarcStructure call. Please note too that PrepareItemrecordDisplay is called twice in a for loop (in serials code: for each item or subscription). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 14:42:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 12:42:01 +0000 Subject: [Koha-bugs] [Bug 15397] Pay selected does not works as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15397 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 14:42:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 12:42:09 +0000 Subject: [Koha-bugs] [Bug 15397] Pay selected does not works as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15397 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53490|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 53681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53681&action=edit Bug 15397 - Pay selected does not works as expected When patron has more fees (account lines) and you wan't to pay just some of them, you select wanted lines a click on "pay selected" button. But the fine isn't paid, the "amountoutstandig" is not modified, but it is added new line with "pay" code an with amountoutstanding below zero. Paying one or all fine works as expected. Paying selected worked some time ago, but I don't know when it stopped working, we realize it after upgrade to 3.22. Test Plan: 1) Apply this patch 2) Pay fines using "Pay selected" 3) Note the payment and the fees outstanding balances are reduced! Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 14:53:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 12:53:06 +0000 Subject: [Koha-bugs] [Bug 16938] Remove the use of "onclick" from batch patrons modification template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16938 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 14:53:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 12:53:11 +0000 Subject: [Koha-bugs] [Bug 16938] Remove the use of "onclick" from batch patrons modification template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16938 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53495|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53682&action=edit Bug 16938: Remove the use of "onclick" from batch patrons modification template This patch revises the batch patrons modification template, removing "onclick" attributes from the markup and defining those events in the script. To test you should have at least one extended patron attribute configured. - Apply the patch and go to Tools -> Batch patron modification. - Submit a batch of patrons for modification. - Confirm that the checkbox next to any required field is disabled. - Select a date in the registration date and expiry date fields. Confirm that the "Clear" link next to each empties the correct field. - Click "New" next to a patron attibute. A copy of the patron attribute line should be created. - Click "Delete" next to a cloned patron attribute. The correct line should be removed. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 14:58:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 12:58:47 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 --- Comment #4 from Marcel de Rooy --- btw this would effectively make your patch a oneliner: just add unsafe in GetMarcStructure ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:00:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:00:31 +0000 Subject: [Koha-bugs] [Bug 16944] Add "email" and "url" classes when edit or create a vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:00:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:00:34 +0000 Subject: [Koha-bugs] [Bug 16944] Add "email" and "url" classes when edit or create a vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53504|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53683&action=edit Bug 16944: Add "email" and "url" classes when edit or create a vendor When edit or create a new vendor the two fields "email" and "website" don't test if the data provided is right. When you add a direction like "koha-community.org" without the protocol "https" the program redirect to an 404 error. To reproduce the issue: 1-Go to Acquisition and create a new Vendor 2-Fill the field Website with koha-community.org 3-Use an email without at sing (@) 4-Notice that there is no error 5-Save 6-Go to the vendor created (/cgi-bin/koha/acqui/supplier.pl?booksellerid=1) 7-Click in Website: koha-community.org -> redirect to an 404 error 8-Notice the bad mailto: To test: -Apply patch -Reproduce step 1 to 8 with the same vendor or create a new one -Enter multiple wrong and valid urls -Enter urls with and without protocols http, https, ftp -Enter wrong and valid emails NOTE: The classes used are taken from 'branches.tt' Signed-off-by: Liz Rea no longer allows entering of improper website urls or incomplete email addresses. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:09:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:09:19 +0000 Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- Why don't you use the REST API (bug 13903)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:17:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:17:13 +0000 Subject: [Koha-bugs] [Bug 16968] Remove the use of "onclick" from serial patron and vendor search templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:17:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:17:16 +0000 Subject: [Koha-bugs] [Bug 16968] Remove the use of "onclick" from serial patron and vendor search templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968 --- Comment #1 from Owen Leonard --- Created attachment 53684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53684&action=edit Bug 16968 - Remove the use of "onclick" from serial patron and vendor search templates This patch removes instances of "onclick" from the serials templates for patron and vendor search. To test, go to Serials and click "New subscription." - In the new subscription form, click the "Search for a vendor" link. - In the popup, search for a vendor. Confirm that clicking "Choose" selects the correct vendor. - From the detail page of an existing subscription, click "Create routing list." - Search for a patron and test that the "Add" button in search results works correctly to add patrons to the routing list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:19:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:19:20 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #18 from Mirko Tietgen --- It looks like it needs libsereal-perl libsereal-encoder-perl libsereal-decoder-perl The first is not in Jessie, the others are. So I wonder if it's necessary to get libsereal-perl backported or if it's enough to use the encoder and decoder directly. Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:22:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:22:44 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 --- Comment #19 from Mirko Tietgen --- > This Sereal module is a very thin wrapper around both Sereal::Encoder and Sereal::Decoder. It depends on both and loads both. So if you have a user of both encoder and decoder, it is enough to depend on a particular version of Sereal and you'll get the most recent released versions of Sereal::Encoder and Sereal::Decoder. If that is all it does, it does not make much sense for Debian, IMHO. The real modules are there, just the wrapper isn't. I don't see a benefit of backporting this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:23:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:23:23 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 --- Comment #20 from Mirko Tietgen --- > This Sereal module is a very thin wrapper around both Sereal::Encoder > and Sereal::Decoder. It depends on both and loads both. So if you have > a user of both encoder and decoder, it is enough to depend on a particular > version of Sereal and you'll get the most recent released versions of > Sereal::Encoder and Sereal::Decoder. If that is all it does, it does not make much sense for Debian, IMHO. The real modules are there, just the wrapper isn't. I don't see a benefit of backporting this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:38:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:38:15 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 --- Comment #21 from Marc V?ron --- Oh, I see that the module is experimental (or am I missing something?): http://search.cpan.org/~yves/Sereal-0.330/lib/Sereal.pm DESCRIPTION This is an experimental module. Before using it in production, please get in touch with the authors! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:41:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:41:58 +0000 Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:46:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:46:47 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #56 from Jonathan Druart --- (In reply to Katrin Fischer from comment #53) Everything looks good to me (you will need bug 16942 to test this patch). > BTW - do we need to repeat all that code for those 2 similar cases? (sep > bug..) Existed before this patch, but yes it would be nice to refactor stuffs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:47:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:47:04 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942 [Bug 16942] Confirm hold results in ugly error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:47:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:47:04 +0000 Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11360 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 [Bug 11360] Disable barcode field and submit button when a hold is found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:47:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:47:44 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53205|0 |1 is obsolete| | Attachment #53531|0 |1 is obsolete| | --- Comment #57 from Jonathan Druart --- Created attachment 53685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53685&action=edit Bug 11360 - Disable barcode field and submit button when a hold is found At the moment when scanning in returns, it can be easy to miss a hold trap due to the fact that the barcode and submit are still active and the barcode field is focused on. A librarian who is focused on scanning can easily scan another item and pass over the form, which is equivalent to clicking the "ignore" button. Test Plan: 1) Apply this patch 2) Trap a hold, note the new modal 3) Check the hold in a second time 4) Note the new modal 5) For each modal, test each button Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:47:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:47:48 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #58 from Jonathan Druart --- Created attachment 53686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53686&action=edit Bug 11360 [QA Followup] - Fix styles and button order Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 15:59:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 13:59:54 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 --- Comment #22 from Jonathan Druart --- (In reply to Marc V?ron from comment #21) > Oh, I see that the module is experimental (or am I missing something?): > http://search.cpan.org/~yves/Sereal-0.330/lib/Sereal.pm Not, it's http://search.cpan.org/~yves/Sereal-3.014/lib/Sereal.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 16:06:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 14:06:42 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 --- Comment #23 from Jonathan Druart --- (In reply to Mirko Tietgen from comment #20) > > This Sereal module is a very thin wrapper around both Sereal::Encoder > > and Sereal::Decoder. It depends on both and loads both. So if you have > > a user of both encoder and decoder, it is enough to depend on a particular > > version of Sereal and you'll get the most recent released versions of > > Sereal::Encoder and Sereal::Decoder. > > If that is all it does, it does not make much sense for Debian, IMHO. The > real modules are there, just the wrapper isn't. I don't see a benefit of > backporting this. I have quickly tried this diff --git a/Koha/Cache.pm b/Koha/Cache.pm index 0f85ed1..fa4f136 100644 --- a/Koha/Cache.pm +++ b/Koha/Cache.pm @@ -40,7 +40,8 @@ use warnings; use Carp; use Module::Load::Conditional qw(can_load); use Koha::Cache::Object; -use Sereal; +use Sereal::Encoder; +use Sereal::Decoder; use base qw(Class::Accessor); And it seems to work correctly. I can provide a patch if you need it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 16:20:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 14:20:49 +0000 Subject: [Koha-bugs] [Bug 16919] Problems with cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16919 rkuiper at roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov --- Comment #1 from rkuiper at roundrocktexas.gov --- Created attachment 53687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53687&action=edit This is a screen capture of deleting 2 items from the Cart (notepad on our system) and not working. This is an example of a problem with the Cart feature. I have 2 items in my Cart (Notepad on our system) and I tried to remove them from the Notepad. After multiple tries the items are still there. Rhonda K. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 16:22:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 14:22:43 +0000 Subject: [Koha-bugs] [Bug 16946] Remove the use of "onclick" from several serials templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart --- - serials/claims.pl "clear filter" does not blank from and to dates. - serials/routing-preview.tt and serials/routing.tt you removed Otherwise, looks good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:00:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:00:37 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52618|0 |1 is obsolete| | --- Comment #62 from Mehdi Hamidi --- Created attachment 53688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53688&action=edit Bug 11879 - QA Follow-up Fixed tests, they now work without any fails -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:01:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:01:43 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #63 from Mehdi Hamidi --- Please discard my last comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:04:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:04:33 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:04:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:04:36 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #32 from Mehdi Hamidi --- Created attachment 53689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53689&action=edit Bug 11879 - QA Follow-up Fixed tests, they now work without any fails -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:06:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:06:45 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 --- Comment #24 from Mirko Tietgen --- Excellent! Can you also change PerlDependencies.pm please? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:07:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:07:22 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53689|0 |1 is obsolete| | --- Comment #33 from Mehdi Hamidi --- Created attachment 53690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53690&action=edit Bug 12532 - QA Follow-up Fixed tests, they now work without any fails Corrected commit message from Bug 11879 to Bug 12532. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:11:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:11:31 +0000 Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:11:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:11:36 +0000 Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53544|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53691&action=edit Bug 16586: Koha Plugins: Limit results of GetPlugins by metadata It would be helpful if we could find a plugin based on some metadata tag as returned by the plugin. This extends the use of GetPlugins that already supports searching on method. GetPlugins is used in: admin/edi_accounts.pl, plugins/plugins-home.pl and tools/stage-marc-import.pl. The changes in these three scripts are minimal and just related to parameter passing. Test t/db_dependent/Plugins.t includes another test for GetPlugins. In this regard a metadata tag has been added to t/Koha/Plugins/Test.pm. NOTE: This adjustment will also be used in a redesign for bug 15545. Test plan: Run t/db_dependent/Plugins.t. Enable pref UseKohaPlugins and config var enable_plugins. Go to plugins-home.pl. Verify that it still lists your plugins. Bonus: Check edi_accounts or stage-marc-import.pl if you have a working plugin for that. Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:11:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:11:41 +0000 Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 --- Comment #4 from Jonathan Druart --- Created attachment 53692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53692&action=edit Bug 16586: Simplify code using none Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:20:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:20:29 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|simith.doliveira at inlibro.co |mehdi.hamidi at inlibro.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:26:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:26:37 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|remi.mayrand-provencher at inL | |ibro.com, | |simith.doliveira at inlibro.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:27:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:27:07 +0000 Subject: [Koha-bugs] [Bug 16973] New: Cannot upload cover images under plack Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16973 Bug ID: 16973 Summary: Cannot upload cover images under plack Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: - Have a clean 3.22 packages install - Create an instance, with plack enabled: $ koha-create --create-db test - Go through the webinstaller $ koha-plack --enable test $ koha-plack --start test - Have a record - Try attaching a cover image to it. => FAIL: "Denied" error message shows -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:28:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:28:07 +0000 Subject: [Koha-bugs] [Bug 16973] Cannot upload cover images under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16973 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:38:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:38:57 +0000 Subject: [Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:39:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:39:03 +0000 Subject: [Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776 --- Comment #7 from Jonathan Druart --- Created attachment 53693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53693&action=edit [ALT] Bug 16776: Do not forget external language choice in language switcher If language is set by external link language switcher does not work To reproduce: - Have a multilingual koha installation, let's say en, de-CH, fr-FR and it-IT - Create external links e.g. from your multilingual library website to each language variant of OPAC: ...cgi-bin/koha/opac-main.pl?language=en ...cgi-bin/koha/opac-main.pl?language=de-CH ...cgi-bin/koha/opac-main.pl?language=fr-FR ...cgi-bin/koha/opac-main.pl?language=it-IT Each link opens fine displaying the language as appropriate. Now try to switch language on the page you just opened via the external link. It won't work, it will always stay on the language defined by the external link. To test: - Apply patch - Repeat steps above - Verify that the language switcher works - Verify in browser address field that after switching language, the param 'language= 'has vanished from url string - Try links with multiple params and with params containing 'language', e.g. ...cgi-bin/koha/opac-search.pl?language=fr-FR&q=language&mylanguage=test - Verify that only the parameter 'language=' vanishes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:39:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:39:39 +0000 Subject: [Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Marc, could you take a look at this counter-patch? Using regex seems easier to resolve this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:40:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:40:32 +0000 Subject: [Koha-bugs] [Bug 16973] Cannot upload cover images under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16973 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:43:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:43:19 +0000 Subject: [Koha-bugs] [Bug 16950] Serials subscriptions advanced search shows '0 found' pre-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16950 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:43:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:43:23 +0000 Subject: [Koha-bugs] [Bug 16950] Serials subscriptions advanced search shows '0 found' pre-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16950 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53554|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53694&action=edit Bug 16950: Serials subscriptions advanced search shows '0 found' pre-search To test: 1) Go to Serials 2) Click Advanced Search in the toolbar at the top 3) Notice heading says Serials subscriptions (0 found) before a search has even happened 4) Apply patch and click Advanced Search again 5) Heading should now say Serials subscriptions search 6) Submit search 7) Heading should say how many subscriptions your search found (like before) Sponsored-by: Catalyst IT Signed-off-by: Marc Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:45:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:45:39 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50433|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:45:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:45:58 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53688|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:48:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:48:00 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:48:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:48:03 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53229|0 |1 is obsolete| | --- Comment #64 from Mehdi Hamidi --- Created attachment 53695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53695&action=edit Bug 11879 - QA Follow-up updatedatabase.pl no longer adds column primary_contact_method to table borrowers Fixed the incorrectly capitalized label and added the ':' in front of it(opac and intranet). Changed mobile phone to other phone in intranet and added a switch case in moremember.tt to display the correct label. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:49:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:49:55 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|maxime.beaulieu at inlibro.com | |, | |remi.mayrand-provencher at inL | |ibro.com, | |simith.doliveira at inlibro.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:52:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:52:29 +0000 Subject: [Koha-bugs] [Bug 16507] show play media tab first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 17:52:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 15:52:34 +0000 Subject: [Koha-bugs] [Bug 16507] show play media tab first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16507 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53555|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 53696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53696&action=edit Bug 16507: Show play media tab first if record has no holdings To test: 1) Go to Admin -> Global sysprefs 2) Turn on HTML5MediaEnabled and HTML5MediaYouTube 3) Go to Cataloging and create a new record 4) Catalogue a YouTube link in 856$u and save record. Do not add any items (click Normal tab) 5) Confirm that Play media tab is the selected tab by default 6) View record on OPAC and confirm Play media tab is selected by default 7) Go back to staff client, add an item then go back to Normal tab 8) Confirm that Holdings tab is now selected by default 9) Confirm Holdings tab is selected by default on OPAC Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:02:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:02:17 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ahmed.sfayhi at inlibro.com, | |maxime.beaulieu at inlibro.com | |, | |remi.mayrand-provencher at inL | |ibro.com, | |simith.doliveira at inlibro.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:02:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:02:39 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ahmed.sfayhi at inlibro.com, | |maxime.beaulieu at inlibro.com | |, | |simith.doliveira at inlibro.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:03:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:03:08 +0000 Subject: [Koha-bugs] [Bug 10937] Advanced search: Hide itemtypes from search form & Group itemtypes together into one search option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ahmed.sfayhi at inlibro.com, | |maxime.beaulieu at inlibro.com | |, | |simith.doliveira at inlibro.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:03:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:03:26 +0000 Subject: [Koha-bugs] [Bug 11055] Add 'minutes' as a load period unit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11055 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ahmed.sfayhi at inlibro.com, | |maxime.beaulieu at inlibro.com | |, | |simith.doliveira at inlibro.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:03:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:03:46 +0000 Subject: [Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ahmed.sfayhi at inlibro.com, | |maxime.beaulieu at inlibro.com | |, | |simith.doliveira at inlibro.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:04:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:04:58 +0000 Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53674|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 53697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53697&action=edit [SIGNED-OFF]Bug 16971: Missing dependency for HTML::Entities This module is already used in opac-password-recovery.pl. It is loaded in Acquisition, but not used (anymore?). It is not yet listed in PerlDependencies. Note: The module is packaged for Debian Wheezy and Jessie. Signed-off-by: Marcel de Rooy Signed-off-by: Hector Castro Good catch. HTML::Entities added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:05:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:05:09 +0000 Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:13:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:13:57 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Jonathan Druart --- The sidebar does not appear on "Pending on-site checkouts", I guess it should. I think the pref should be named CircSidebar instead of circSidebar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:15:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:15:15 +0000 Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:15:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:15:18 +0000 Subject: [Koha-bugs] [Bug 16971] Missing dependency for HTML::Entities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16971 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53697|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53698&action=edit Bug 16971: Missing dependency for HTML::Entities This module is already used in opac-password-recovery.pl. It is loaded in Acquisition, but not used (anymore?). It is not yet listed in PerlDependencies. Note: The module is packaged for Debian Wheezy and Jessie. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:24:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:24:14 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- You are using quote inside a quoted string, I get a JS error when creating a new order: SyntaxError: missing ; before statement result += "" + edit_link + " " + del_link + ""; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:40:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:40:25 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53649|0 |1 is obsolete| | --- Comment #34 from Marc V?ron --- Created attachment 53699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53699&action=edit Bug 12532 - Redirect guarantee email to guarantor Fixed merge conflicts. Both the guarantor and the guarantee will receive the email now. Also fixed some log errors since the "save" button is the same one use for editing the patron details. Changed the save button "save" id whene editing only the Patron messaging preferences so we can detect where the request is comming from. Added unit tests. Added an atomicupdate file. Reordered the sysprefs in alphabetical order. Refactored some code. TEST PLAN: I Apply the patch II Run updatedatabase.pl III Run db_dependent/Letters.t and db_dependant/Members.t 0) Enable EnhancedMessagingPreferences preference; 0) Enable EnableRedirectGuaranteeEmail preference; 1) Select a patron with child; 2) Enable Item checkout -> email in patron messaging preferences; 3) Select the patron's child; 4) Checkout an item; 5) Valide child checkout message in patron's inbox; sponsored by the ville de victoriaville Tested together with follow-up works as expected. Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:41:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:41:40 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53690|0 |1 is obsolete| | --- Comment #35 from Marc V?ron --- Created attachment 53700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53700&action=edit Bug 12532 - QA Follow-up Fixed tests, they now work without any fails https://bugs.koha-community.org/show_bug.cgi?id=12532 Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:42:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:42:03 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:42:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:42:44 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #25 from Jonathan Druart --- I don't think I am ready to QA this one. Julian has announced a new plugin system few weeks ago and this patch will adds a precedent for the existing plugin system. Do you have in mind other uses case? Did you plan to extend it to other behaviors? It would be great to ping koha-devel to get other dev opinions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:45:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:45:13 +0000 Subject: [Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing › from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:45:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:45:16 +0000 Subject: [Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing › from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53644|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 53701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53701&action=edit Bug 16953: Acquisitions home: Remove trailing › from breadcrumbs The breadcrumb on the Acquisition's home page reads: Home > Acquisitions > This tiny patch removes the trailing > (›) Amended: Remove the link on 'Acquisitions' as well... Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:45:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:45:28 +0000 Subject: [Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing › from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Trivial patch CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:48:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:48:02 +0000 Subject: [Koha-bugs] [Bug 16937] Remove the use of "onclick" from the manage staged MARC records template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:48:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:48:05 +0000 Subject: [Koha-bugs] [Bug 16937] Remove the use of "onclick" from the manage staged MARC records template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53646|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 53702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53702&action=edit Bug 16937 [Revised] Remove "onclick" from the manage staged MARC records template This patch revises the manage staged MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Manage staged MARC records. - If necessary, stage a MARC file for import. - Click the name of the staged file and then the "Import this batch into the catalog" button. The batch should be correctly imported. - Return to the list of staged MARC files. - Click the name of an imported file and then the "Undo import into catalog" button. The import should be reverted. - Return to the list of staged MARC files. - Click the "Clean" button for any record. Confirm that the batch is cleaned. - For any cleaned record, click the "Delete" button. The batch should be deleted. Signed-off-by: Hector Castro Works as advertised QA revision: Corrected class name so that "delete" button triggers the correct warning. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:50:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:50:29 +0000 Subject: [Koha-bugs] [Bug 16964] Fix capitalization for "Report Plugins" in reports-home.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:50:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:50:32 +0000 Subject: [Koha-bugs] [Bug 16964] Fix capitalization for "Report Plugins" in reports-home.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53665|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53703&action=edit Bug 16964: Fix capitalization for "Report Plugins" in reports-home.tt Fix capitalization for "Report Plugins" in reports-home.tt according with Coding Guidelines Signed-off-by: Marc Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:58:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:58:12 +0000 Subject: [Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776 --- Comment #9 from Marc V?ron --- I tested, the counter patch works as well. That is the most important thing, I will sign-off. Hmm, patch title schuld say: Forget external language choice in language switcher (i.e. language switcher should not take care of language set by external link) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:59:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:59:18 +0000 Subject: [Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776 --- Comment #10 from Marc V?ron --- Created attachment 53704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53704&action=edit Bug 16776: Do not forget external language choice in language switcher If language is set by external link language switcher does not work To reproduce: - Have a multilingual koha installation, let's say en, de-CH, fr-FR and it-IT - Create external links e.g. from your multilingual library website to each language variant of OPAC: ...cgi-bin/koha/opac-main.pl?language=en ...cgi-bin/koha/opac-main.pl?language=de-CH ...cgi-bin/koha/opac-main.pl?language=fr-FR ...cgi-bin/koha/opac-main.pl?language=it-IT Each link opens fine displaying the language as appropriate. Now try to switch language on the page you just opened via the external link. It won't work, it will always stay on the language defined by the external link. To test: - Apply patch - Repeat steps above - Verify that the language switcher works - Verify in browser address field that after switching language, the param 'language= 'has vanished from url string - Try links with multiple params and with params containing 'language', e.g. ...cgi-bin/koha/opac-search.pl?language=fr-FR&q=language&mylanguage=test - Verify that only the parameter 'language=' vanishes Tested counter patch, works as well. Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 18:59:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 16:59:47 +0000 Subject: [Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53693|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:00:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:00:25 +0000 Subject: [Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53473|0 |1 is obsolete| | --- Comment #11 from Marc V?ron --- Comment on attachment 53473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53473 [SIGNED-OFF] Bug 16776 - If language is set by external link language switcher does not work Obsoelted in favour of Jonathan's counter patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:00:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:00:53 +0000 Subject: [Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53693|0 |1 is obsolete| | Attachment #53693|0 |1 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:10:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:10:07 +0000 Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- (In reply to Marc V?ron from comment #5) > Update 2016-07-25 > - Force date_due to UTC to avoid problematic timezone info like this: > DTSTART:TZID=Europe/Zurich:20160724T235900 I am not sure this is correct. >From https://metacpan.org/pod/DateTime::Format::ICal: "The iCal spec requires that datetimes be formatted either as floating times (no time zone), UTC (with a 'Z' suffix) or with a time zone id at the beginning ('TZID=America/Chicago;...'). If this method is asked to format a DateTime object that has an offset-only time zone, then the object will be converted to the UTC time zone internally before formatting." So the TZID should be handled correctly by Thunderbird (I did not try). I think we should either use a floating TZ or the tz returned by C4::Context->tz, but not arbitrarily set it to UTC -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:27:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:27:56 +0000 Subject: [Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776 --- Comment #12 from Jonathan Druart --- (In reply to Marc V?ron from comment #9) > I tested, the counter patch works as well. That is the most important thing, > I will sign-off. > Hmm, patch title schuld say: Forget external language choice in language > switcher (i.e. language switcher should not take care of language set by > external link) Well, it depends on how you see things actually :) I wanted to say: Do not forget what has been passed in url when you click on the language switcher. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:35:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:35:58 +0000 Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix related sentence splitting in catalogue/detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- 1/ Looking at the logic it seems that reservedate could be missing (?) 2/ Before the patch the string was "waiting at LIBRARY since DATE", now it's "waiting since DATE at LIBRARY". I don't think it represents a big change but I would prefer to get the opinion of English native speakers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:43:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:43:20 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #65 from Mehdi Hamidi --- Created attachment 53705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53705&action=edit Bug 11879 - Add a new borrower field : main contact method Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:44:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:44:08 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53705|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:44:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:44:19 +0000 Subject: [Koha-bugs] [Bug 16875] OPAC: Removing link to records if authority is not used by any records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16875 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:44:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:44:23 +0000 Subject: [Koha-bugs] [Bug 16875] OPAC: Removing link to records if authority is not used by any records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16875 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53251|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 53706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53706&action=edit Bug 16875: OPAC - removing link to records if authority is not used by any records To test: 1) Do an authority search. Notice that authorities not used by any records have a clickable link (under Biblio records) which redirects to a catalog search with no results 2) Go back to the authority search and click View full heading for an authority with no records. Notice that under the auth name, it says Number of records used in: 0, with a link to a catalog search 3) Apply patch 4) Repeat steps 1 and 2. Authorities not used in any records should no longer have clickable links nd authorities which have records should work as expected. Sponsored-by: Catalyst IT Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:44:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:44:59 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50433|0 |1 is obsolete| | Attachment #52616|0 |1 is obsolete| | Attachment #52617|0 |1 is obsolete| | Attachment #52619|0 |1 is obsolete| | Attachment #52620|0 |1 is obsolete| | Attachment #53695|0 |1 is obsolete| | --- Comment #66 from Mehdi Hamidi --- Created attachment 53707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53707&action=edit Bug 11879 - Add a new borrower field : main contact method Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:53:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:53:49 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53707|1 |0 is patch| | Attachment #53707|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:59:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:59:18 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #67 from Mehdi Hamidi --- Created attachment 53708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53708&action=edit Bug 11879 - Update BDIx schema and show main contact method in moremember.pl Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:59:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:59:22 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #68 from Mehdi Hamidi --- Created attachment 53709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53709&action=edit Bug 11879 QA follow-up Changed "Mobile Phone" to Other Phone, modified deletedborrowers table structute and added the field in opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:59:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:59:26 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #69 from Mehdi Hamidi --- Created attachment 53710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53710&action=edit Bug 11879 - QA Follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:59:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:59:30 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #70 from Mehdi Hamidi --- Created attachment 53711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53711&action=edit Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on current master for testing) http://bugs.koha-community.org/show_bug.cgi?id=11879 To test this patch: Update database Edit a borrower's informations. The "Main Contact Method" selectbox appears in the form and its value is correctly. Works as expected. For handling of syspref BorrowerUnwantedField use second patch- Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:59:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:59:34 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #71 from Mehdi Hamidi --- Created attachment 53712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53712&action=edit Bug 11879 - Fix syspref BorrowerUnwantedField How I tested: Apply 1st patch Apply this patch Edit syspref BorrowerUnwantedField to exclude fields Edit patron's contact information Make sure that fields do not longer appear in drop down for Main contact Wors as expected http://bugs.koha-community.org/show_bug.cgi?id=11879 Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 19:59:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 17:59:38 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #72 from Mehdi Hamidi --- Created attachment 53713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53713&action=edit Bug 11879 - QA Follow-up updatedatabase.pl no longer adds column primary_contact_method to table borrowers Fixed the incorrectly capitalized label and added the ':' in front of it(opac and intranet). Changed mobile phone to other phone in intranet and added a switch case in moremember.tt to display the correct label. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 20:07:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 18:07:17 +0000 Subject: [Koha-bugs] [Bug 16974] New: koha-plack should check and fix log files permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974 Bug ID: 16974 Summary: koha-plack should check and fix log files permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz It is not checking permissions and makes Koha fail badly if it cannot write the logs. This could happen on logrotate, on koha-plack --start|--restart. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 20:07:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 18:07:29 +0000 Subject: [Koha-bugs] [Bug 16974] koha-plack should check and fix log files permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 20:13:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 18:13:48 +0000 Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |oleonard at myacpl.org --- Comment #11 from Jonathan Druart --- I don't think we have found the best formatting for the fee sentence. It shows: Renew Fee for VHS 5.00 (2 of 3 renewals remaining) I think it's a bit confusing. Owen, any ideas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 20:16:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 18:16:42 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|maxime.beaulieu at inlibro.com | |, | |remi.mayrand-provencher at inL | |ibro.com, | |simith.doliveira at inlibro.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 20:16:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 18:16:58 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|genevieve.plantin at inlibro.c | |om, | |remi.mayrand-provencher at inL | |ibro.com, | |simith.doliveira at inlibro.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 20:17:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 18:17:12 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|maxime.beaulieu at inlibro.com | |, | |remi.mayrand-provencher at inL | |ibro.com, | |simith.doliveira at inlibro.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 20:17:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 18:17:30 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|maxime.beaulieu at inlibro.com |eric.begin at inLibro.com |, | |remi.mayrand-provencher at inL | |ibro.com, | |simith.doliveira at inlibro.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 20:17:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 18:17:47 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|maxime.beaulieu at inlibro.com |eric.begin at inLibro.com |, | |remi.mayrand-provencher at inL | |ibro.com, | |simith.doliveira at inlibro.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 20:18:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 18:18:05 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Eric B?gin changed: What |Removed |Added ---------------------------------------------------------------------------- CC|remi.mayrand-provencher at inL | |ibro.com, | |simith.doliveira at inlibro.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 20:21:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 18:21:05 +0000 Subject: [Koha-bugs] [Bug 16974] koha-plack should check and fix log files permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 20:21:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 18:21:08 +0000 Subject: [Koha-bugs] [Bug 16974] koha-plack should check and fix log files permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 53714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53714&action=edit Bug 16974: Make koha-plack should check and fix log files permissions This patch adds a function to the koha-plack script so it checks for log file existence and its permissions. This function is called from the start_plack function. If some of this conditions are not fulfilled, it solves the situation by either touching and/or changing the permissions accordingly for the instances' plack log files. To test: - Run (on kohadevbox): $ cd kohaclone $ debian/scripts/koha-plack --start kohadev $ debian/scripts/koha-plack --stop kohadev $ ls /var/log/koha/kohadev/plack* - Verify ownership of the created files (they might belong to the root user) - Apply the patch - Run: $ chown root:root /var/log/koha/kohadev/plack* $ debian/scripts/koha-plack --start kohadev $ ls /var/log/koha/kohadev/plack* => SUCCESS: Files belong to kohadev-koha:kohadev-koha - Run: $ debian/scripts/koha-plack --stop kohadev $ rm /var/log/koha/kohadev/plack* $ debian/scripts/koha-plack --start kohadev $ ls /var/log/koha/kohadev/plack* => SUCCESS: Files are created and belong to kohadev-koha:kohadev-koha - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 20:21:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 18:21:28 +0000 Subject: [Koha-bugs] [Bug 16974] koha-plack should check and fix log files permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16138 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 20:21:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 18:21:28 +0000 Subject: [Koha-bugs] [Bug 16138] Restart plack when rotating logfiles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16138 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16974 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 20:27:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 18:27:47 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #26 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #25) > I don't think I am ready to QA this one. > Julian has announced a new plugin system few weeks ago and this patch will > adds a precedent for the existing plugin system. > Do you have in mind other uses case? Did you plan to extend it to other > behaviors? > It would be great to ping koha-devel to get other dev opinions. Please follow the trace in the see also bug and see that it is already three years under way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 21:11:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 19:11:12 +0000 Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 --- Comment #7 from Marc V?ron --- Hi Jonathan, I tested Magnus' newest patch again (with 2 checkouts), that's what I get: BEGIN:VCALENDAR VERSION:2.0 PRODID:Data::ICal 0.21 BEGIN:VEVENT DESCRIPTION:Your copy of Pf?tzen schreien so laut ihr Licht (barcode glaupf u-01) is due back at the library today DTSTAMP:20160725T185113Z DTSTART:20160725T215900Z SUMMARY:Pf?tzen schreien so laut ihr Licht is due UID:issue-9@ END:VEVENT BEGIN:VEVENT DESCRIPTION:Your copy of Der Rattenk?nig : (barcode rakoe-01) is due back a t the library today DTSTAMP:20160725T185113Z DTSTART:20160725T215900Z SUMMARY:Der Rattenk?nig : is due UID:issue-10@ END:VEVENT END:VCALENDAR If I pass it through http://icalendar.org/validator.html#results, it gives no errors (warnings though about the length of 2 lines). I can import it to Thunderbird Calendar without problem, and Thunderbird shows what I expect regarding time (25.07.2016 23:59 local time) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 25 22:39:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 20:39:23 +0000 Subject: [Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451 Billy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |billiambag at gmail.com --- Comment #12 from Billy --- i figured i should chime in here because i have been having this problem for years. The only time i try to print something in Firefox is when Google Chrome won't print my class schedule and i think the problems are related. In Chrome, Safari, and Opera the printout and print preview is all goofy looking. It has shrunken frames and visible scrollbars and is unusable. And it is like this on every computer i try it on. So i always try to do it in Firefox, but i always get this problem where Firefox will only print the first page! Whatever HTML my school's website is using for displaying both regular class schedule and a "printable" version of the class schedule isn't rendering properly for these browsers. And i have to say it is SUPER annoying. I end up just printing screenshots. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 00:05:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 22:05:52 +0000 Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- Hm, also keep an eye on capitalisation please! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 00:49:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Jul 2016 22:49:50 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |nowheezy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 03:46:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 01:46:24 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mtompset at hotmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 03:48:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 01:48:30 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mtompset at hotmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 05:39:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 03:39:10 +0000 Subject: [Koha-bugs] [Bug 16370] Set the record encoding to UTF8 when TransformHtmlToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16370 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50819|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Comment on attachment 50819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50819 TransformHtmlToMarc-UTF8.patch Liz Rea's patch is identical and git-friendlier for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 05:41:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 03:41:22 +0000 Subject: [Koha-bugs] [Bug 16370] Set the record encoding to UTF8 when TransformHtmlToMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16370 --- Comment #7 from Liz Rea --- I even kept the attribution! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 06:00:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 04:00:58 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |ASSIGNED --- Comment #25 from Chris Cormack --- Yep we definitely need a patch, at least for jessie, libsereal-perl is in stretch, but it won't be backported for jessie. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 06:38:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 04:38:51 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 06:38:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 04:38:54 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53565|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia --- Created attachment 53716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53716&action=edit Bug 16939: Making all 'add to basket' actions buttons Edit: Fixing 'clas' typo in addorderiso2709.tt Edit: Adding actions class to td Edit: Fixing js error To test: 1) Go to Acqui -> find a vendor -> view a basket 2) Click add to basket -> fill in 'for an existing record' and hit search 3) 'View MARC' and 'Order' buttons should show under an Actions column with appropriate icons 4) Click Order 5) Click add item when you are redirected to the New order page (no need to fill in any details) 6) Confirm that 'Edit' and 'Delete' buttons now show under an Actions column with appropriate icons 7) Go back to your basket and click add to basket -> from a subscription (we are skipping from a suggestion because this already has a button before my patch) 8) Confirm that 'Order' shows as a button with appropriate icon 9) Go back to your basket and click add to basket -> from an external source 10) fill in any fields and click search to bring up results 11) 'Order' should now show as a button with appropriate icons. MARC and Card preview have been moved into a dropdown menu - confirm this works as expected. Links have not been changed when clicking on a row 12) Go back to your basket and click add to basket -> from a staged file 13) 'Add orders' should now show as a button with appropriate icon 14) Go back to your basket and click add to basket -> from titles with highest hold ratios 15) 'X to order' should now show as a button with appropriate icon Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 06:45:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 04:45:19 +0000 Subject: [Koha-bugs] [Bug 16874] Making serials collections actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 --- Comment #4 from Aleisha Amohia --- (In reply to Claire Gravely from comment #3) > Hi, > Sorry, I didn't get two buttons in step 4 of the test. Just the one for > 'create routing list'. The line wasn't highlighted either. > > 'Print list' was displaying just fine as a button. > > Claire Sorry, I should've added that the Renew button and row highlighting will only show if the subscription is about to expire or has expired. Could you please retest? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 08:02:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 06:02:49 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #16 from Katrin Fischer --- Yes, I agree. Just having a go at the sys pref description too - pick what you like best :) Charge an ammount of $amount when a hold is cancelled, that has been waiting more days than defined by ReservesMaxPickUpDelay. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 08:03:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 06:03:49 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Katrin Fischer --- Putting into 'failed qa' just for the follow up for the description/syspref naming - please put back to 'signed off' once there is a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 08:25:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 06:25:27 +0000 Subject: [Koha-bugs] [Bug 15023] Allow patron anonymize/ bulk delete tool to be limited by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- My patron's homebranch is Midway. IndependentBranches is turned off. I am trying to anonymize the checkout history older than yesterday for Springfield patrons. I have one entry in old_issues, where the patron is from Springfield. -> The tool reports: 0 patron's checkout histories will be anonymized. When I choose Midway it reports it will delete the checkout histories of 5 people. When I check old_issues, there seem to be only 4 people with checkout histories to delete: select count(distinct borrowernumber) from old_issues where borrowernumber in (select borrowernumber from borrowers where branchcode = "MPL") Can you please check, what's going on here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 08:40:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 06:40:13 +0000 Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796 --- Comment #13 from Marc V?ron --- Thinking about wording. Prerequisites: Readability. As short as possible (we are in a table column). Translation friendly (no sentence splitting). Rules for capitalization (normally, item type name is capitalized). Word 'Renew' is a link (blue), rest is text (black). Without renewal fee (as is) --------------------------- Renew (10 of 10 renewals remaining) With renewal fee: ----------------- Variant I (as proposed by patch): Renew Fee for Books 5.00 (2 of 3 renewals remaining) Renew Fee for VHS 5.00 (2 of 3 renewals remaining)) Variant II: Renew. Fee for item type 'Books': 5.55. (10 of 10 renewals remaining) Renew. Fee for item type 'VHS': 5.55. (10 of 10 renewals remaining) Variant III: Renew (10 of 10 renewals remaining) Fee for item type 'Books': 3.75 Renew (10 of 10 renewals remaining) Fee for item type 'VHS': 3.75 Variant IV: Renew (10 of 10 renewals remaining) Fee (item type 'Books'): 3.75 Renew (10 of 10 renewals remaining) Fee (item type 'VHS'): 3.75 Variant V: Renew (10 of 10 renewals remaining) A fee of 4.25 will be added for item type 'Books' Renew (10 of 10 renewals remaining) A fee of 4.25 will be added for item type 'VHS' Variant VI: Renew (10 of 10 renewals remaining) NOTE: A fee of 4.25 will be added for item type 'Books' Renew (10 of 10 renewals remaining) NOTE: A fee of 4.25 will be added for item type 'VHS' Other propositions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 10:04:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 08:04:43 +0000 Subject: [Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715 --- Comment #26 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #23) > > I have quickly tried this > > diff --git a/Koha/Cache.pm b/Koha/Cache.pm > index 0f85ed1..fa4f136 100644 > --- a/Koha/Cache.pm > +++ b/Koha/Cache.pm > @@ -40,7 +40,8 @@ use warnings; > use Carp; > use Module::Load::Conditional qw(can_load); > use Koha::Cache::Object; > -use Sereal; > +use Sereal::Encoder; > +use Sereal::Decoder; > > use base qw(Class::Accessor); > > > And it seems to work correctly. > I can provide a patch if you need it. That should work just fine, I used that variant for speed differences comparisons vs Storable (I think it was on jessie, not entirely sure) without encountering any problems. Speaking of dependencies: what about some other files (debian/control*, install_misc/*.packages) in the source tree which are referencing required packages? I don't know if they may need some tweaking as well or not - or maybe it's only being done en masse before releasing next packaged version? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 10:51:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 08:51:17 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger at biblibr | |e.com --- Comment #3 from Matthias Meusburger --- Test plan: Test plan: 1) Edit the MarcItemFieldsToOrder syspref. For example: homebranch: 975$a holdingbranch: 975$b itype: 975$9|975$z nonpublic_note: 975$x public_note: 975$y loc: 975$8 ccode: 975$c notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 969$h budget_code: 922$a price: 975$p 2) Create some sample records in koha with values in these fields, then save them as Unicode-UTF-8 Example: 922 _aBudget_code_1 922 _aBudget_code_2 969 _h3 969 _h1 975 _71 _8loc _9CD _aHomebranch_1 _bHoldingbranch_1 _cccode_1 _ncopyno _uuri _xnonpublic_note _ypublic_note _p12.5 975 _70 _8loc2 _aHomebranch_2 _bHoldingbranch_2 _cccode_2 _ncopyno2 _uuri2 _xnonpublic_note2 _ypublic_note2 _zDVD _p22 3) Import your test records with the import tool (Stage MARC records for import) 4) Choose a basket, then click on "Add to basket" => "From a staged file" 5) Choose the file you have imported. For each record that had item informations, you will have a preview of the item that will be created on the left side of the screen. Values can still be modified at this point. Save. 6) Check that the items and corresponding order lines have been created. Notes: You will have to select a budget for each item before being able to save. If items informations are spread across different fields (like in my example) and the number of said fields is not even, an error message will be displayed. If the budget code or price is missing in the item informations, it will be gathered from record level information (MarcFieldsToOrder) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 11:04:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 09:04:07 +0000 Subject: [Koha-bugs] [Bug 16976] New: Authorities searches with double quotes gives ZOOM error 20003 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Bug ID: 16976 Summary: Authorities searches with double quotes gives ZOOM error 20003 Change sponsored?: --- Product: Koha Version: 16.05 Hardware: PC OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: miguel.tuimil at xercode.es QA Contact: testopia at bugs.koha-community.org Any search on authorities(authorities/authorities-home.pl) that includes double quotes, for example "Enrico Fermi" gives: Software error: ZOOM error 20003 "can't set prefix query" (addinfo: "@or @attr 7=1 @attr 1=Heading 0 @attr 1=Heading-Main @attr 5=1 @attr 4=6 "\\"Enrico Fermi\\""") from diag-set 'ZOOM' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 11:04:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 09:04:32 +0000 Subject: [Koha-bugs] [Bug 16079] Retrieving system preferences from database via DBIx is not fast enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079 --- Comment #17 from Jacek Ablewicz --- (In reply to Marcel de Rooy from comment #16) > DBIx::Class 0.08196 vs 0.082810 > WHEEZY WITHOUT 16079 > Mysql > real 0m1.966s > Hash ref inflator > real 0m16.663s > Unblessed > real 0m20.411s > === JESSIE WITHOUT 16079 > Mysql > real 0m2.092s > Hashref inflator > real 0m2.991s > Unblessed > real 0m6.603s Thanks Marcel, good to know that speed improvements (both DBIx::Class 0.08196 vs 0.082810, and unblessed vs hashref inflator) are real, not just some weird local artefacts. I see that wheezy support got just depreciated, as of 16.11, in the last IRC dev meeting (unanimously :), so the possibly insufficient performance of the older DBIx::Class is most likely not to be a problem in the long term. Hashref inflator seems to be a lot better then unblessed (over 2x faster, almost as fast as pure DBI) especially in jessie; using it instead of unblessed may be well worth it in speed-sensitive places. Any ideas how to implement hashref inflator method / variant inside Koha::Object[s] without violating (too much ;) the underlying principles of Koha::Objects? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 11:31:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 09:31:59 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 --- Comment #5 from Jacek Ablewicz --- (In reply to Marcel de Rooy from comment #4) > btw this would effectively make your patch a oneliner: just add unsafe in > GetMarcStructure ? You mean that with this patch all GetMarcStructure() calls remaining in the code (including the call in PrepareItemrecordDisplay()) will be 'unsafe => 1' ones? Hm, it's possible - it's been a while since I reviewed those calls, and I was only having a closer look at those of them that were called repeatedly. Also in the meantime there was hopefully some progress with eliminating unneeded / most offending ones in the other bug reports. I'll need to have a look.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 12:01:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 10:01:05 +0000 Subject: [Koha-bugs] [Bug 16977] New: REST tests cleanup ineffective Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16977 Bug ID: 16977 Summary: REST tests cleanup ineffective Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: larit at student.uef.fi QA Contact: gmcharlt at gmail.com I'm having issues with REST tests. It seems that whenever the test uses authentication, e.g. my $tx = $t->ua->build_tx(GET => '/api/v1/patrons'); $tx->req->cookies({name => 'CGISESSID', value => $session->id}); $t->request_ok($tx) ... the test does not cleanup database correctly. This can be currently seen in t/db_dependent/api/v1/patrons.t. For holds.t (the other REST test in master at the time of reporting this bug) there is at the moment no authentication and it seems to cleanup nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 12:04:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 10:04:00 +0000 Subject: [Koha-bugs] [Bug 16977] REST tests cleanup ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16977 --- Comment #1 from Lari Taskula --- Duplicate issue: 1. Run t/db_dependent/api/v1/patrons.t 2. Have a look at borrowers table. The test data did not cleanup. Compare to holds.t: 3. Run t/db_dependent/api/v1/holds.t 4. Have a look at borrowers table. The test borrowers from holds.t are cleaned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 13:51:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 11:51:15 +0000 Subject: [Koha-bugs] [Bug 16776] If language is set by external link language switcher does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16776 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Marc V?ron --- Setting to signed-off (for counter patch, tested 2016-07-26 - comment #10) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 14:04:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 12:04:24 +0000 Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53692|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 53717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53717&action=edit Bug 16586: [QA Follow-up] Add test for two metadata conditions Run the test and see.. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 14:04:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 12:04:27 +0000 Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 --- Comment #6 from Marcel de Rooy --- Created attachment 53718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53718&action=edit Bug 16586: Simplify code using none Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 14:05:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 12:05:38 +0000 Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 --- Comment #7 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #4) > Created attachment 53692 [details] [review] > Bug 16586: Simplify code using none > > Signed-off-by: Jonathan Druart Thx for QAing. I have the impression that your follow-up slightly changes behavior. It appears to be not as simple after all :) Check the code for the situation that %$req_metadata is empty. The additional unit test in my follow-up will prove it for you: run this test with and without your last patch. Please correct.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 14:06:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 12:06:26 +0000 Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 --- Comment #8 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #7) > Check the code for the situation that %$req_metadata is empty. Sorry this line makes no sense. Just run the test.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 14:28:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 12:28:59 +0000 Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix related sentence splitting in catalogue/detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 --- Comment #4 from Marc V?ron --- (In reply to Jonathan Druart from comment #3) > 1/ Looking at the logic it seems that reservedate could be missing (?) (...) We had two conditions [% IF ( item.waitingdate ) %] at the same level (line 693ff and 707ff before patch). I merged them (line 693ff with patch), including reservedate. > 2/ Before the patch the string was "waiting at LIBRARY since DATE", now it's > "waiting since DATE at LIBRARY". I don't think it represents a big change > but I would prefer to get the opinion of English native speakers. I will ask on IRC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 14:44:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 12:44:19 +0000 Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix related sentence splitting in catalogue/detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |c.gravely at arts.ac.uk --- Comment #5 from Claire Gravely --- Responding from IRC conversation: You would want to use "waiting at LIBRARY since DATE". The other sentence structure doesn't sound right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 14:58:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 12:58:46 +0000 Subject: [Koha-bugs] [Bug 16973] Cannot upload cover images under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16973 --- Comment #1 from Marcel de Rooy --- Tested with 3.22.x commit 978f8aedf3dddb26cbbc44455c239ab10d3f7dd2 and just a few custom patches on top of that (not related to Upload). Yes it is a clean package dev install :) But cannot yet reproduce your problem. I could upload several files one after another. Could you check the temporary upload folder in /tmp: owner, permissions? For this test instance called upgrade, I have: drwxr-xr-x 2 upgrade-koha upgrade-koha 4096 Jul 26 14:55 koha_upgrade_upload What happens if you remove the folder and upload another file or two? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 15:00:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 13:00:24 +0000 Subject: [Koha-bugs] [Bug 16973] Cannot upload cover images under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16973 --- Comment #2 from Marcel de Rooy --- Forgot to say: Yes, it is with plack and memcache. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 15:00:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 13:00:49 +0000 Subject: [Koha-bugs] [Bug 16871] Translatability: Avoid [ %%-problem and fix related sentence splitting in catalogue/detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16871 --- Comment #6 from Marc V?ron --- Created attachment 53719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53719&action=edit Bug 16871: Translatability: Avoid [%%-problem and fix related sentence splitting in catalogue/detail.tt In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt, fix line splitted TT directives and sentence splitting leading to translatability problems. (See first comment). To test: - Apply patch - Go to detail pages of biblios with waiting holds - Verify that messages in column 'Status' are OK - Examine code in patch to make sure that the simplification in logic makes sense and that no TT directive is splitted - Bonus test: - Go to folder misc/translator. Run perl translate create xx-XX - Verify that monster mentioned in first comment no longer exists (in po/xx-XX-staff-prog.po) Signed-off-by: Hector Castro Works as advertised Amended for wording (comment #5) 2016-07-26 mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 15:03:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 13:03:19 +0000 Subject: [Koha-bugs] [Bug 16973] Cannot upload cover images under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16973 --- Comment #3 from Marcel de Rooy --- And with: ProxyPass "/cgi-bin/koha/tools/upload-cover-image.pl" "!" I am wondering: It seems like koha-plack does not restart apache. Is that the source of the problem? Is your problem solved with a restart of apache ?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 15:26:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 13:26:59 +0000 Subject: [Koha-bugs] [Bug 16818] CAS redirect broken under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger at biblibr | |e.com --- Comment #3 from Matthias Meusburger --- Tested ok with the patch on a previously broken CAS-Plack installation. Signing-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 15:30:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 13:30:08 +0000 Subject: [Koha-bugs] [Bug 16822] koha-common init.d script should run koha-plack without quiet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 15:30:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 13:30:12 +0000 Subject: [Koha-bugs] [Bug 16822] koha-common init.d script should run koha-plack without quiet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 53720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53720&action=edit Bug 16822: Make koha-common call koha-plack without --quiet This patch removes the --quiet option switch in koha-common.init so problem information is not hidden for sysadmin users. To test: - Have plack enabled for a koha instance: $ sudo koha-plack --enable kohadev $ sudo koha-plack --start kohadev - Run: $ cd kohaclone $ debian/koha-common.init {start|stop|restart} => SUCCESS: No behaviour change - Disable the 'cgi' apache module: $ sudo a2dismod cgi - Run: $ debian/koha-common.init {start|stop|restart} => FAIL: No warning is shown - Apply the patch - Run: $ debian/koha-common.init {start|stop|restart} => SUCCESS: Warnings show up - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 15:34:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 13:34:01 +0000 Subject: [Koha-bugs] [Bug 16822] koha-common init.d script should run koha-plack without quiet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 15:36:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 13:36:51 +0000 Subject: [Koha-bugs] [Bug 16818] CAS redirect broken under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53232|0 |1 is obsolete| | --- Comment #4 from Matthias Meusburger --- Created attachment 53721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53721&action=edit [SIGNED-OFF] Bug 16818: External auth redirect broken under Plack Test plan: 0) Have either CAS or Shibboleth authentication enabled under Plack. 1) Hover over the authentication link on the staff client or OPAC, and notice that it has either '.../opac/...' or '.../intranet/...' instead of '.../cgi-bin/koha/...'. (This will be a complete dealbreaker for CAS authentication.) 2) Apply patch. 3) Check links again; they should now have the correct paths. Signed-off-by: Matthias Meusburger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 15:37:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 13:37:17 +0000 Subject: [Koha-bugs] [Bug 16818] CAS redirect broken under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16818 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 15:37:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 13:37:53 +0000 Subject: [Koha-bugs] [Bug 16968] Remove the use of "onclick" from serial patron and vendor search templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53684|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 53722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53722&action=edit Bug 16968 - Remove the use of "onclick" from serial patron and vendor search templates This patch removes instances of "onclick" from the serials templates for patron and vendor search. To test, go to Serials and click "New subscription." - In the new subscription form, click the "Search for a vendor" link. - In the popup, search for a vendor. Confirm that clicking "Choose" selects the correct vendor. - From the detail page of an existing subscription, click "Create routing list." - Search for a patron and test that the "Add" button in search results works correctly to add patrons to the routing list. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 15:37:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 13:37:51 +0000 Subject: [Koha-bugs] [Bug 16968] Remove the use of "onclick" from serial patron and vendor search templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 15:50:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 13:50:33 +0000 Subject: [Koha-bugs] [Bug 16978] New: Add delete reports user permission Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 Bug ID: 16978 Summary: Add delete reports user permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org Split the create reports permission further, so that delete reports is separated out. This will administratively prevent accidental deletions by removing the capability from those who do so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 15:57:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 13:57:28 +0000 Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 15:57:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 13:57:30 +0000 Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 --- Comment #1 from M. Tompsett --- Created attachment 53723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53723&action=edit Bug 16978: Add delete reports user permission This splits off the delete capability from the create reports permission. >From a UI perspective there were CSS issues, that this patch set hackily bypasses. Perhaps someone else can amend this enhancement with the required changes so that the extra column at the beginning of the table can be removed when the user does not have delete capability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 16:00:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 14:00:19 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jkpattison at gmail.com, | |manueltamayao at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 16:13:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 14:13:42 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 16:13:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 14:13:44 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #18 from Kyle M Hall --- Created attachment 53724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53724&action=edit Bug 15561 [QA Followup] - Rename ExpireReservesMaxPickUpDelayCharge to WaitingHoldCancelationFee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 16:35:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 14:35:49 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #59 from Kyle M Hall --- (In reply to Jonathan Druart from comment #58) > Created attachment 53686 [details] [review] > Bug 11360 [QA Followup] - Fix styles and button order > > Signed-off-by: Jonathan Druart Jonathan did you intend to pass qa on this patch set, or did you just add an additional sign-off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 16:54:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 14:54:42 +0000 Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for 16.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 16:54:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 14:54:45 +0000 Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for 16.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51836|0 |1 is obsolete| | Attachment #51837|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 53725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53725&action=edit Bug 16585: Update Italian installer sample files for 16.05 With this patch all sample/defintions .sql files are updated and translated into Italian (if you select italian during web installation). NOTE: Squashed both patches. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 16:58:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 14:58:33 +0000 Subject: [Koha-bugs] [Bug 16585] Update Italian installer sample files for 16.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16585 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- This is not an enhancement. This is a bug fix, as many of the strings in the Italian SQL files were English to start with. Marking it as such. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 17:03:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 15:03:03 +0000 Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 17:03:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 15:03:06 +0000 Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942 --- Comment #5 from Kyle M Hall --- Created attachment 53726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53726&action=edit Bug 16942 [QA Followup] - Add unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 17:27:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 15:27:34 +0000 Subject: [Koha-bugs] [Bug 16979] New: Search for barcode containing parentheses fails Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16979 Bug ID: 16979 Summary: Search for barcode containing parentheses fails Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: jyorio at esilibrary.com QA Contact: testopia at bugs.koha-community.org Searching for a call number containing parentheses, similar to: 1234567890 (text) or 1234(5678)90 fails to return any results, either in the staff interface or OPAC. For the first barcode, leaving off "(text)" will return the expected result, but removing the parentheses from the latter still does not. The issue (and I suspect the solution) seems similar to 15468 and 12405 in that, if I modify the URL to include %22 around the barcode, I get the expected result. To reproduce : 1) Set up an item with a barcode with the form: 1234567890 (text) 2) In the staff interface, perform a barcode search for the exact barcode 3) No results are returned 4) Modify the search URL to include %22 around barcode e.g.: .../cgi-bin/koha/catalogue/search.pl?idx=bc&q=1234567890+(text)&op=and&idx=kw&op=and&idx=kw&sort_by=relevance becomes: cgi-bin/koha/catalogue/search.pl?idx=bc&q=%221234567890+(text)%22&op=and&idx=kw&op=and&idx=kw&sort_by=relevance 5) Press enter 6) The expected result is returned 7) Setup an item with a barcode with the form: 1234(5678)90 8) In the staff interface, perform a barcode search for the exact barcode 9) No results are returned 10) Modify the result URL to include %22 around barcode e.g. .../cgi-bin/koha/catalogue/search.pl?idx=bc&q=1234(5678)90&op=and&idx=kw&op=and&idx=kw&sort_by=relevance becomes: .../cgi-bin/koha/catalogue/search.pl?idx=bc&q=%221234(5678)90%22&op=and&idx=kw&op=and&idx=kw&sort_by=relevance 11) Press enter 12) The expected result is returned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 17:45:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 15:45:45 +0000 Subject: [Koha-bugs] [Bug 16980] New: link to vendor broken on edi accounts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16980 Bug ID: 16980 Summary: link to vendor broken on edi accounts Change sponsored?: --- Product: Koha Version: master Hardware: All URL: cgi-bin/koha/admin/edi_accounts.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org The link to the vendor has a broken link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 17:51:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 15:51:41 +0000 Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 17:53:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 15:53:01 +0000 Subject: [Koha-bugs] [Bug 16980] link to vendor broken on edi accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16980 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Nicole C. Engard --- Nevermind, this is fixed in master ;) hehe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 18:02:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 16:02:17 +0000 Subject: [Koha-bugs] [Bug 16981] New: add EDI admin to acq menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16981 Bug ID: 16981 Summary: add EDI admin to acq menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org You have to add a vendor before you can add an EDI account for that vendor and I find myself clicking a whole lot to get back and forth. This patch will add the EDI admin links to the left menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 18:04:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 16:04:04 +0000 Subject: [Koha-bugs] [Bug 16981] add EDI admin to acq menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16981 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 18:04:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 16:04:06 +0000 Subject: [Koha-bugs] [Bug 16981] add EDI admin to acq menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16981 --- Comment #1 from Nicole C. Engard --- Created attachment 53727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53727&action=edit Bug 16981: Add EDI Admin to Acq Menu This patch adds the links to EDI Accounts and Library EANs to the menu on the left of the Acq module. To test: * Log in to Koha * Visit Acquisitions * Confirm that EDI links show on the menu on the right if you have permissions to access EDI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 18:10:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 16:10:15 +0000 Subject: [Koha-bugs] [Bug 16982] New: add edi account to new menu on vendor page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16982 Bug ID: 16982 Summary: add edi account to new menu on vendor page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be great if you could jump to creating a vendor account from the vendor menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 18:12:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 16:12:04 +0000 Subject: [Koha-bugs] [Bug 16982] add edi account to new menu on vendor page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16982 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 18:12:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 16:12:06 +0000 Subject: [Koha-bugs] [Bug 16982] add edi account to new menu on vendor page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16982 --- Comment #1 from Nicole C. Engard --- Created attachment 53728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53728&action=edit Bug 16982: Add EDI Account to Vendor New Menu This patch adds a new option under the 'New' button on the vendor page to take you to EDI Accounts management. To test: * Log in to Koha * Visit Acquisitions * Add a new vendor (or search for a vendor) * Click 'New' * See link to EDI Accounts (if you have permission) * Click and it should take you to the EDI Accounts area -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 18:24:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 16:24:55 +0000 Subject: [Koha-bugs] [Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53549|0 |1 is obsolete| | --- Comment #15 from Marc V?ron --- Created attachment 53729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53729&action=edit Bug 16868: Silence error t/db_dependent/Linker_FirstMatch.t When the auth_header table has records which exclude 1xx and 2xx tags, the $bibfield doesn't match anything. This in turn sets it to undef, which triggers an error on the next line killing the test. This was completely refactored to provide the data necessary for the tests to pass, and to be more comprehensive (both MARC and UNIMARC are tested). The tests are then run. C4::Headings::authorities is mocked, so that this test is not dependent on a search engine. TEST PLAN --------- 1) back up DB 2) DELETE FROM auth_header; 3) SOURCE auth_header.sql; -- the provided file 4) prove t/db_dependent/Linker_FirstMatch.t -- should barf before running all the tests 5) apply all patches 6) prove t/db_dependent/Linker_FirstMatch.t -- should work happy 7) run koha qa test tools 8) restore your backup Followed test plan, behaves as expected. Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 18:25:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 16:25:10 +0000 Subject: [Koha-bugs] [Bug 16868] Silence error t/db_dependent/Linker_FirstMatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16868 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 19:07:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 17:07:15 +0000 Subject: [Koha-bugs] [Bug 16973] Cannot upload cover images under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16973 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #4 from Tom?s Cohen Arazi --- It might be a local problem. It vanished now and couldn't reproduce on kohadevbox yet. Will re-open if I manage to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 19:17:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 17:17:29 +0000 Subject: [Koha-bugs] [Bug 16984] New: Acquisitions broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984 Bug ID: 16984 Summary: Acquisitions broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In acquisitions, even if AcqCreateItem is set to create an item at the time of ordering, the item creation form does not display. Instead, this JavaScript error shows in the console: additem.js:176 Uncaught TypeError: window[events[i]] is not a function I believe this regression was introduced by bug 15531. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 19:28:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 17:28:08 +0000 Subject: [Koha-bugs] [Bug 16984] Acquisitions broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Can't reproduce this on my installation - the item form shows ok for me. - ACQ framework exists - items are created while ordering - order i tested with was with a new record and 'not standing' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 19:39:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 17:39:33 +0000 Subject: [Koha-bugs] [Bug 16984] Acquisitions broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Kyle M Hall --- Starting with a fresh database, I could not reproduce the issue! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 19:51:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 17:51:34 +0000 Subject: [Koha-bugs] [Bug 13313] RecordLocalUseOnReturn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13313 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Barton Chittenden --- *** This bug has been marked as a duplicate of bug 9717 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 19:51:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 17:51:34 +0000 Subject: [Koha-bugs] [Bug 9717] localuse recorded for holds/transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9717 --- Comment #16 from Barton Chittenden --- *** Bug 13313 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 19:59:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 17:59:49 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #17 from Marc V?ron --- I tested and got follwoing results: Staff client - detail page: http://www.amazon.com/gp/reader/3257217358?tag=TEST&ref=sib_dp_pt/002-7879865-0184864#reader-link OPAC: Detail page: http://www.amazon.com/dp/3907142330?tag=TEST& Checked out: http://www.amazon.com/gp/reader/3907142330?tag=TEST&ref=sib_dp_pt/002-7879865-0184864#reader-link Reading history: http://www.amazon.com/gp/reader/3907142330?tag=TEST&ref=sib_dp_pt/002-7879865-0184864#reader-link Fazit: tag=TEST& added to all links, but on OPAC detail page the reminder of the link is missing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 20:06:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 18:06:10 +0000 Subject: [Koha-bugs] [Bug 16864] Silence warnings in t/db_dependent/ILSDI_Services.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53151|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 53730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53730&action=edit Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t prove t/db_dependent/ILSDI_Services.t generates noisy output as a result of the ambiguous context of two $cgi->param() calls. By storing into scalar variables, and then using the scalar variables, the code maintains readability and fixes the problem. TEST PLAN --------- 1) prove t/db_dependent/ILSDI_Services.t -- noisy. 2) apply patch 3) prove t/db_dependent/ILSDI_Services.t -- not noisy 4) run koha qa test tools Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 20:06:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 18:06:26 +0000 Subject: [Koha-bugs] [Bug 16864] Silence warnings in t/db_dependent/ILSDI_Services.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 20:11:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 18:11:57 +0000 Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53279|0 |1 is obsolete| | --- Comment #9 from Marc V?ron --- Created attachment 53731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53731&action=edit Bug 16622: some tests triggered by prove t fail for unset KOHA_CONF TEST PLAN --------- 1) unset KOHA_CONF 2) prove t -- 00-load.t dies miserably 3) prove t/Creators.t -- fails 4) apply patch 5) prove t -- noisy, but all tests successful 6) prove -v t/Creators.t -- 2 skipped tests 7) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 20:12:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 18:12:10 +0000 Subject: [Koha-bugs] [Bug 16622] some tests triggered by prove t fail for unset KOHA_CONF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 20:30:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 18:30:10 +0000 Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Wanted to test, but sorry: - atomicupdate is missing, so I have no delete_reports in table permissions - a test plan would be nice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 20:49:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 18:49:52 +0000 Subject: [Koha-bugs] [Bug 16981] add EDI admin to acq menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16981 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53727|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 53732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53732&action=edit Bug 16981: Add EDI Admin to Acq Menu This patch adds the links to EDI Accounts and Library EANs to the menu on the left of the Acq module. To test: * Log in to Koha * Visit Acquisitions * Confirm that EDI links show on the menu on the right if you have permissions to access EDI. Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 20:50:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 18:50:08 +0000 Subject: [Koha-bugs] [Bug 16981] add EDI admin to acq menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16981 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 20:54:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 18:54:11 +0000 Subject: [Koha-bugs] [Bug 16982] add edi account to new menu on vendor page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16982 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53728|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 53733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53733&action=edit Bug 16982: Add EDI Account to Vendor New Menu This patch adds a new option under the 'New' button on the vendor page to take you to EDI Accounts management. To test: * Log in to Koha * Visit Acquisitions * Add a new vendor (or search for a vendor) * Click 'New' * See link to EDI Accounts (if you have permission) * Click and it should take you to the EDI Accounts area Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 20:54:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 18:54:36 +0000 Subject: [Koha-bugs] [Bug 16982] add edi account to new menu on vendor page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16982 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 20:56:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 18:56:12 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #29 from Tom?s Cohen Arazi --- (In reply to Marcel de Rooy from comment #28) > (In reply to M. Tompsett from comment #27) > > Why did you change everything to the hashref references? > > my ($parameters) = @_; > > my $format = $parameters->{format}; > > ... > > block at the top and all the other code wouldn't need to be changed. > > Only a few vars are referenced more than once or twice. Even without > comparison etc. What is the status of this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 21:01:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 19:01:45 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52824|1 |0 is obsolete| | --- Comment #17 from Tom?s Cohen Arazi --- Comment on attachment 52824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52824 Bug 14642: Add HoldsLog syspref >From 133621157e8fe90cd4728970c23a4869d3212f43 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi >Date: Fri, 24 Jun 2016 11:34:01 -0300 >Subject: [PATCH] Bug 14642: Add HoldsLog syspref > >This patch introduces a new syspref 'HoldsLog' which is to be used for controlling >holds actions logs. > >Sponsored-by: NEKLS >--- > .../data/mysql/atomicupdate/bug_14642_holds_logging.sql | 13 +++++++++++++ > installer/data/mysql/sysprefs.sql | 1 + > .../prog/en/modules/admin/preferences/logs.pref | 6 ++++++ > 3 files changed, 20 insertions(+) > create mode 100644 installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql > >diff --git a/installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql b/installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql >new file mode 100644 >index 0000000..aca2ee3 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql >@@ -0,0 +1,13 @@ >+INSERT IGNORE INTO systempreferences ( variable, value, options, explanation, type ) VALUES >+('HoldsLog','1',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'); >+ >+-- $DBversion = "16.06.00.XXX"; >+-- if ( CheckVersion($DBversion) ) { >+-- $dbh->do(q{ >+-- INSERT IGNORE INTO systempreferences ( variable, value, options, explanation, type ) VALUES >+-- ('HoldsLog','1',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'); >+-- }); >+ >+-- print "Upgrade to $DBversion done (Bug 14642: Add logging of hold modifications)\n"; >+-- SetVersion($DBversion); >+-- } >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index cd0f8bf..099db56 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -167,6 +167,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('HighlightOwnItemsOnOPAC','0','','If on, and a patron is logged into the OPAC, items from his or her home library will be emphasized and shown first in search results and item details.','YesNo'), > ('HighlightOwnItemsOnOPACWhich','PatronBranch','PatronBranch|OpacURLBranch','Decides which branch\'s items to emphasize. If PatronBranch, emphasize the logged in user\'s library\'s items. If OpacURLBranch, highlight the items of the Apache var BRANCHCODE defined in Koha\'s Apache configuration file.','Choice'), > ('HoldFeeMode','not_always','always|not_always','Set the hold fee mode','Choice'), >+('HoldsLog','1',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'), > ('HoldsQueueSkipClosed', '0', NULL, 'If enabled, any libraries that are closed when the holds queue is built will be ignored for the purpose of filling holds.', 'YesNo'), > ('HoldsToPullStartDate','2',NULL,'Set the default start date for the Holds to pull list to this many days ago','Integer'), > ('HomeOrHoldingBranch','holdingbranch','holdingbranch|homebranch','Used by Circulation to determine which branch of an item to check with independent branches on, and by search to determine which branch to choose for availability ','Choice'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref >index 8d6c4c8..4aa5790 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref >@@ -31,6 +31,12 @@ Logging: > off: "Don't log" > - when fines are charged, paid, or forgiven. > - >+ - pref: HoldsLog >+ choices: >+ on: Log >+ off: "Don't log" >+ - any actions on holds (create, cancel, suspend, resume, etc). >+ - > - pref: IssueLog > choices: > on: Log >-- >2.9.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 21:02:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 19:02:24 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 --- Comment #18 from Tom?s Cohen Arazi --- I'm not sure why the patch that introduces the syspref got obsoleted! Reverting it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 21:06:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 19:06:27 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 --- Comment #19 from Tom?s Cohen Arazi --- Created attachment 53734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53734&action=edit Bug 14642: (QA followup) Make HoldsLog default to 0 After a couple comments regarding the default value I picked for the new syspref, I've decided to set it 0, as libraries interested on the fetarue will just enable it. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 21:10:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 19:10:30 +0000 Subject: [Koha-bugs] [Bug 16650] Add script to clear report caches manually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16650 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 21:14:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 19:14:48 +0000 Subject: [Koha-bugs] [Bug 16685] Use eval instead of do for .perl atomicupdates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16685 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Nice one Kyle, can u please rebase? I'd put the new dep somewhere alphabetically. Is it packaged already? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 21:42:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 19:42:26 +0000 Subject: [Koha-bugs] [Bug 15023] Allow patron anonymize/ bulk delete tool to be limited by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 --- Comment #6 from Katrin Fischer --- We found out: while deleting patrons works by the patron's homebranch, anonymizing uses the checkout branch. As this is the existing behaviour with independent branches turned on, the new behaviour is consistent. Maybe this could be added as a note to documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 21:43:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 19:43:21 +0000 Subject: [Koha-bugs] [Bug 15023] Allow patron anonymize/ bulk delete tool to be limited by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 21:43:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 19:43:24 +0000 Subject: [Koha-bugs] [Bug 15023] Allow patron anonymize/ bulk delete tool to be limited by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53463|0 |1 is obsolete| | Attachment #53464|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 53735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53735&action=edit [PASSED QA] Bug 15023: Allow patron anonymize/bulk delete tool to be limited by branch This patch makes the bulk patron delete/anonymize functionality be limited by branch. It does so by adding a branch selection dropdown and using the already defined APIs for filtering by branch. It makes use of C4::Branches::onlymine for the IndependentBranches use case and it adds a way to call it from the Branches template plugin. To test: - Apply the patch 1) Have a superlibrarian user - Go to Tools > Batch patron deletion/anonymization => SUCCESS: Verify you can pick a branch (or all of them) - Try doing some operations => SUCCESS: Verify the selection is respected, and carried around all steps 2) Have a user with tools/delete_anonymize_patrons permissions - Set IndependentBranches on - Go to Tools > Batch patron deletion/anonymization => SUCCESS: It picks the librarian's branch and doesn't let us choose another one - Try doing some operations => SUCCESS: Verify the user's branch is respected, and carried around all steps - Sign off :-D Sponsored-by: VOKAL Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 21:45:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 19:45:05 +0000 Subject: [Koha-bugs] [Bug 15023] Allow patron anonymize/ bulk delete tool to be limited by branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 --- Comment #8 from Katrin Fischer --- Created attachment 53736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53736&action=edit [PASSED QA] Bug 15023: (followup) Remove warnings By setting 'use Modern::Perl' some previously hidden warnings arised. This patch removes them by testing the variable $balance for undef before using it in a comparisson. Sponsored-by: VOKAL Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 21:54:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 19:54:33 +0000 Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 21:54:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 19:54:36 +0000 Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53499|0 |1 is obsolete| | Attachment #53726|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 53737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53737&action=edit [PASSED QA] Bug 16942 - Confirm hold results in ugly error Confirming a hold to set it to waiting will result in an DBIC error in master. Test Plan: 1) Attempt to check in an item on hold and confirm the hold 2) Note the error 3) Apply this patch 4) Repeat step 1 5) Note there is no error! Signed-off-by: Mirko Tietgen https://bugs.koha-community.org/show_bug.cgi?id=14942 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 21:55:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 19:55:25 +0000 Subject: [Koha-bugs] [Bug 16942] Confirm hold results in ugly error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942 --- Comment #7 from Katrin Fischer --- Created attachment 53738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53738&action=edit [PASSED QA] Bug 16942 [QA Followup] - Add unit test Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 22:12:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 20:12:38 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion Severity|enhancement |minor --- Comment #7 from Katrin Fischer --- I am ok with the new sentence, but I have a general question about the buttons vs icons: Example 1: Make payment and Pay all fines are buttons: Fees & Charges: Patron has outstanding fees & charges of 0,01. Make payment Pay all fines Example 2: Delete and Add a new message are Links with icons: 06/01/2016 Midway "WAAH" [Delete] Add a new message Should we not pick one or the other? Owen, could you take a look? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 22:26:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 20:26:31 +0000 Subject: [Koha-bugs] [Bug 15561] Add ability to charge cancelation fee from "Holds over" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer --- Hi Kyle, can you please add an atomicupdate for the syspref renaming? Also 2 more tiny thing: - correct alphabetic sorting in syspref.sql - Sypref description has "if a waiting hold cancellation fee is to be charged" instead of cancelation with one l (consistency! :) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 22:31:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 20:31:22 +0000 Subject: [Koha-bugs] [Bug 15975] Add Home Library Column to Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- With this patch there is a small display error in the table of checkouts: the new column leaves a gap at the end of the last grey line holding the totals and renewal due date. This happens on the checkouts and the details tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 23:27:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 21:27:36 +0000 Subject: [Koha-bugs] [Bug 16985] New: Self registration verification e-mail is broken - no token at the end of the URL Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985 Bug ID: 16985 Summary: Self registration verification e-mail is broken - no token at the end of the URL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: kyle.m.hall at gmail.com When using PatronSelfRegistrationVerifyByEmail with the patron self registration the patron is sent an email with a confirmation URL to confirm his/her e-mail address before the registration is finished. The URL ends with a token. The token is now missing. I have tried git bisecting it, but I ran into general problems with patron modifications being broken - but I suspect this might be related to bug 14757 as it works right before this was added. Adding Kyle in hope he can see what's going wrong there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 23:31:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 21:31:59 +0000 Subject: [Koha-bugs] [Bug 16985] Self registration verification e-mail is broken - no token at the end of the URL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 23:31:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 21:31:59 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985 [Bug 16985] Self registration verification e-mail is broken - no token at the end of the URL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 23:38:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 21:38:33 +0000 Subject: [Koha-bugs] [Bug 16275] Prevent patron creation if the email already filled in borrowers.email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16985 CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- In general this seems to work nicely without enforcing email verification (PatronSelfRegistrationVerifyByEmail). I ran into problems testing with email verification, because of bug 16985. It seems you can register as many patrons as you want with the same e-mail as long as they are not confirmed. I wanted to test to the second patron to use the confirmation link, but can't right now. Jonathan, can you describe what should happen? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985 [Bug 16985] Self registration verification e-mail is broken - no token at the end of the URL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 26 23:38:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 21:38:33 +0000 Subject: [Koha-bugs] [Bug 16985] Self registration verification e-mail is broken - no token at the end of the URL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16275 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 [Bug 16275] Prevent patron creation if the email already filled in borrowers.email -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 01:58:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Jul 2016 23:58:54 +0000 Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53723|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 53739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53739&action=edit Bug 16978: Add delete reports user permission This splits off the delete capability from the create reports permission. >From a UI perspective there were CSS issues, that this patch set hackily bypasses. Perhaps someone else can amend this enhancement with the required changes so that the extra column at the beginning of the table can be removed when the user does not have delete capability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 02:11:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 00:11:03 +0000 Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from M. Tompsett --- TEST PLAN --------- 1) back up db 2) apply patch 3) ./installer/data/mysql/updatedatabase.pl -- should run without issue. 4) in mysql: > drop database ... > create database ... -- totally blanks it for fresh web install 5) run web install -- installing should have no issues 6) go to a patron 7) set permissions 8) expand the reports permission -- should have delete reports now 9) click help and scroll down to 'Granular Reports Permissions' right at the bottom. -- there should be a new delete_reports section 10) Head over to guided reports and build a few reports. -- as system account user, delete stuff should all be visible. 11) Find a patron, set all permissions, except delete reports. 12) log out and then log in as the modified patron 13) Head over the save reports -- none of the delete options should be available to the user. 14) run koha qa test tools 15) restore db -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 03:03:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 01:03:12 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle field to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.sekjal at gmail.com --- Comment #2 from Liz Rea --- *** Bug 7715 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 03:03:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 01:03:12 +0000 Subject: [Koha-bugs] [Bug 7715] Add biblio.subtitle and appropriate mappings to MARC frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7715 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Liz Rea --- *** This bug has been marked as a duplicate of bug 11529 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 05:16:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 03:16:55 +0000 Subject: [Koha-bugs] [Bug 16986] New: Index 035$a as OCLC-Number, Identifier-standard Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986 Bug ID: 16986 Summary: Index 035$a as OCLC-Number,Identifier-standard Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: srdjan at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 05:20:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 03:20:26 +0000 Subject: [Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number, Identifier-standard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 05:20:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 03:20:28 +0000 Subject: [Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number, Identifier-standard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986 --- Comment #1 from Srdjan Jankovic --- Created attachment 53740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53740&action=edit Bug 16986: Added 035 $a tag to search index as OCLC-Number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 05:24:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 03:24:17 +0000 Subject: [Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number, Identifier-standard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- To test: * Pick a record and populate 035$a with something * Reindex * Search for that something - the record above should be found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 05:42:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 03:42:42 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 --- Comment #18 from M. Tompsett --- (In reply to Marc V?ron from comment #17) > Fazit: tag=TEST& added to all links, but on OPAC detail page the reminder of > the link is missing. Sucky. Will attempt to fix. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 07:06:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 05:06:38 +0000 Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53739|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 53741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53741&action=edit Bug 16978: Add delete reports user permission This splits off the delete capability from the create reports permission. >From a UI perspective there were CSS issues, that this patch set hackily bypasses. Perhaps someone else can amend this enhancement with the required changes so that the extra column at the beginning of the table can be removed when the user does not have delete capability. TEST PLAN --------- 1) back up db 2) apply patch 3) ./installer/data/mysql/updatedatabase.pl -- should run without issue. 4) in mysql: > drop database ... > create database ... -- totally blanks it for fresh web install 5) run web install -- installing should have no issues 6) go to a patron 7) set permissions 8) expand the reports permission -- should have delete reports now 9) click help and scroll down to 'Granular Reports Permissions' right at the bottom. -- there should be a new delete_reports section 10) Head over to guided reports and build a few reports. -- as system account user, delete stuff should all be visible. 11) Find a patron, set all permissions, except delete reports. 12) log out and then log in as the modified patron 13) Head over the save reports -- none of the delete options should be available to the user. 14) run koha qa test tools 15) restore db Followed test plan. Additionally tried to delete using params in URL (not possible, OK) Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 07:07:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 05:07:13 +0000 Subject: [Koha-bugs] [Bug 16978] Add delete reports user permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16978 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 07:16:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 05:16:12 +0000 Subject: [Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number, Identifier-standard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #3 from Katrin Fischer --- Hi Srdjan, please take a look at the discussion at bug 6499 - it's an index on the same field currently in failed qa, but could probably be saved easily. 035 can be all kinds of numbers - so we chose a more general name there. *** This bug has been marked as a duplicate of bug 6499 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 07:16:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 05:16:12 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #22 from Katrin Fischer --- *** Bug 16986 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 07:20:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 05:20:11 +0000 Subject: [Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number, Identifier-standard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986 --- Comment #4 from Katrin Fischer --- Hm, your patch seems more complete - we could also also use yours an turn the duplicate around. But I think having a more general name would be good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 07:22:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 05:22:07 +0000 Subject: [Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number, Identifier-standard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 07:22:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 05:22:15 +0000 Subject: [Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number, Identifier-standard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 07:31:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 05:31:47 +0000 Subject: [Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number, Identifier-standard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986 --- Comment #5 from Katrin Fischer --- Maybe the easiest would be to have a more general alias (or however you'd call that with Zebra) for the index name? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 07:37:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 05:37:42 +0000 Subject: [Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number, Identifier-standard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986 --- Comment #6 from Srdjan Jankovic --- Well I'm not sure how I missed that one when searching. Apologies. I'm happy to change it to whatever name/label is more appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 07:41:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 05:41:15 +0000 Subject: [Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number, Identifier-standard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986 --- Comment #7 from Katrin Fischer --- hi Srdjan, I feel like my early morning comments might not always make full sense :) See here for the documentation of the field: http://www.loc.gov/marc/bibliographic/bd035.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 07:58:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 05:58:10 +0000 Subject: [Koha-bugs] [Bug 16986] Index 035$a as OCLC-Number, Identifier-standard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16986 --- Comment #8 from Srdjan Jankovic --- Right, from that I take: 1. We may want to index $z subfield as well (as the other patch does) 2. a) We want to name it "System-control-number" rather than OCLC-Number, or alternatively 2. b) We drop new name all together and leave it as Identifier-standard, and include Identifier-standard in searched index list ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 07:59:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 05:59:52 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #30 from Marcel de Rooy --- (In reply to Tom?s Cohen Arazi from comment #29) > (In reply to Marcel de Rooy from comment #28) > > (In reply to M. Tompsett from comment #27) > > > Why did you change everything to the hashref references? > > > my ($parameters) = @_; > > > my $format = $parameters->{format}; > > > ... > > > block at the top and all the other code wouldn't need to be changed. > > > > Only a few vars are referenced more than once or twice. Even without > > comparison etc. > > What is the status of this one? Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 11:07:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 09:07:40 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #19 from Josef Moravec --- I've just tested it. Exporting works as expected, but Importing doesn't. After selecting file and confirming it, it takes me to auth_tag_structure.pl as expected, but the newly created authtype is still empty - nothing is imported. Exporting and importing bibliographics frameworks works fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 11:34:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 09:34:09 +0000 Subject: [Koha-bugs] [Bug 16987] New: sub duplicate_framework in admin/marctagstructure.pl can' t see variable $cache Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16987 Bug ID: 16987 Summary: sub duplicate_framework in admin/marctagstructure.pl can't see variable $cache Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org When creating new framework and copying the base from another existing bibliographic framework, the action end with internal server error, although the new framework is filled with the fields. The reason is the calling clear_from_cache on the end of sub duplicate_framework I am on plack. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 11:34:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 09:34:16 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 --- Comment #6 from Jacek Ablewicz --- (In reply to Marcel de Rooy from comment #3) > --- a/C4/Items.pm > +++ b/C4/Items.pm > > @@ -2815,6 +2815,10 @@ sub PrepareItemrecordDisplay { > my $dbh = C4::Context->dbh; > $frameworkcode = &GetFrameworkCode($bibnum) if $bibnum; > my ( $itemtagfield, $itemtagsubfield ) = &GetMarcFromKohaField( > "items.itemnumber", $frameworkcode ); > + > + # it would be perhaps beneficial (?) to call GetMarcStructure with > 'unsafe' parameter > + # for performance reasons, but $tagslib may be passed to > $plugin->build(), and there > + # is no way to ensure that this structure is not getting corrupted > somewhere in there > my $tagslib = &GetMarcStructure( 1, $frameworkcode ); > > Hm. I have the strong impression that the item plugins do not even read the > tagslib structure. I kept the parameter in terms of backward compatibility > for custom plugins that would need it. It might be an idea to let these > custom (item) plugins call GetMarcStructure itself when they really need > it.. But yes, that would be another report :) > > The assumption that tagslib would be corrupted by a plugin is not very > realistic imo; most do not even read, not to mention change. If the included > plugins do not, how far should we go in protecting the author of a custom > plugin from the potential threat he created himself? We can't stop him now > from doing all kinds of things.. +1, overcautiousness is not always a virtue ;). I'll post a follow-up. > So I would not object to calling it unsafe here too. In my tests it makes a > remarkable difference: 0.0015 versus 0.046 per GetMarcStructure call. Please > note too that PrepareItemrecordDisplay is called twice in a for loop (in > serials code: for each item or subscription). Ouch, for serial subscriptions with 'serialsadditems' enabled, it might be called a lot of times for a single subscription. This is seriously unoptimized function btw, traverses a whole MARC structure while it only needs 33 or so entries, and also generates a lot of unneeded database traffic. But that's outside the scope of this report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 11:34:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 09:34:45 +0000 Subject: [Koha-bugs] [Bug 16987] sub duplicate_framework in admin/marctagstructure.pl can' t see variable $cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16987 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 11:37:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 09:37:33 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50094|0 |1 is obsolete| | --- Comment #20 from Benjamin Rokseth --- Created attachment 53742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53742&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 11:37:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 09:37:42 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50095|0 |1 is obsolete| | --- Comment #21 from Benjamin Rokseth --- Created attachment 53743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53743&action=edit Bug 15516 - Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 11:37:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 09:37:50 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50096|0 |1 is obsolete| | --- Comment #22 from Benjamin Rokseth --- Created attachment 53744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53744&action=edit Bug 15516: Update old_reserves (reserve_group_id) Without it, deletion of reserves will fail Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 11:38:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 09:38:52 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #23 from Benjamin Rokseth --- Rebased against master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 11:45:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 09:45:32 +0000 Subject: [Koha-bugs] [Bug 16987] sub duplicate_framework in admin/marctagstructure.pl can' t see variable $cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16987 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 11:45:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 09:45:34 +0000 Subject: [Koha-bugs] [Bug 16987] sub duplicate_framework in admin/marctagstructure.pl can' t see variable $cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16987 --- Comment #1 from Josef Moravec --- Created attachment 53745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53745&action=edit Bug 16987: Sub duplicate_framework in admin/marctagstructure.pl can't see variable $cache Test plan: 0) Ensure you are running on plack 1) Create new bibliographic framework 2) Go to Marc structure and select some existing framework to duplicate it to this new framework 3) You see internal server error (and there is a log in plack-error.log) 4) Go to biblioframeworks administration and MARC structure for that new framework, you see the fields are filled up 5) Apply the patch 6) Repeat 1 and 2 7) Everything should work fine this time - no error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 11:52:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 09:52:30 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 --- Comment #7 from Jacek Ablewicz --- Created attachment 53746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53746&action=edit Bug 16365 - GetMarcStructure() "unsafe" variant in PrepareItemrecordDisplay() This sub is a good candidate for the "unsafe" treatment too, it doesn't modyfy nor autovivify anything in the marc structure. Added a warning in the code regarding the $tagslib usage by the custom item plugins, plus a small change to prevent possible "Use of uninitialized value" warnings in the future. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 12:52:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 10:52:32 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #9 from Marcel de Rooy --- Some preliminary questions: Did Jesse test with an OverDrive account? Noting such info in the signoff line could be helpful. You seem to be adding an optional dependency. I am missing PerlDependencies? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 13:04:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 11:04:56 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 --- Comment #8 from Jacek Ablewicz --- (In reply to Jacek Ablewicz from comment #5) > (In reply to Marcel de Rooy from comment #4) > > btw this would effectively make your patch a oneliner: just add unsafe in > > GetMarcStructure ? > > You mean that with this patch all GetMarcStructure() calls remaining in the > code (including the call in PrepareItemrecordDisplay()) will be 'unsafe => > 1' ones? > > Hm, it's possible - it's been a while since I reviewed those calls, and I > was only having a closer look at those of them that were called repeatedly. > Also in the meantime there was hopefully some progress with eliminating > unneeded / most offending ones in the other bug reports. I'll need to have a > look.. Hm, in a way - yes, with the PrepareItemrecordDisplay() sorted out, there are hardly any "safe" calls left in the modules (only one in C4/Acquisition.pm ?). There is a bunch of them left in the scripts though. I skipped "safety audit" for the scripts (only checked that there are no repeated direct calls in there). Right now, if the given script calls GetMarcStructure() only once, and it's doing it directly, adding 'unsafe' flag globally (i.e. oneliner variant) would not benefit this script speed-wise (script starts with empty L1 cache and for the 1st call it needs to fetch a framework structure from L2 anyway). If any of those scripts is fetching the same framework 2nd+ time indirectly (via some functions from the modules), with the oneliner there would be a small speed benefit (10-15 msec), but now there is a possibility that direct (unaudited) unsafe call will interfere with the further unsafe (audited) indirect call and vice versa. This is purely theoretical, I have no idea if there may really be such problems in some of those scripts or not - I didn't checked, remember that by design this patch is an limited, lazy approach ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 13:09:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 11:09:53 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 --- Comment #9 from Marcel de Rooy --- (In reply to Jacek Ablewicz from comment #8) > I didn't > checked, remember that by design this patch is an limited, lazy approach ;) My lazy approach was: why not change only one line ;) Will have a look soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 13:16:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 11:16:42 +0000 Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53718|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 53747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53747&action=edit Bug 16586: Simplify code using none Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Amended this patch: Replaced none by any. Exists test adjusted. This effectively makes the test pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 13:17:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 11:17:29 +0000 Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53747|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 53748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53748&action=edit Bug 16586: [QA Follow-up] Simplify code Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Amended this patch: Replaced none by any. Exists test adjusted. This effectively makes the test pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 13:18:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 11:18:47 +0000 Subject: [Koha-bugs] [Bug 16586] Koha Plugins: Limit results of GetPlugins by metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16586 --- Comment #11 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #7) > (In reply to Jonathan Druart from comment #4) > Please correct.. Done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 14:15:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 12:15:47 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 --- Comment #10 from Marcel de Rooy --- Just a side note: dcloning a structure would be safe, but is slower than decode with Sereal: dclone 0.0350 decode 0.0200 For a call to GetMarcStructure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 14:58:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 12:58:53 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #8 from Owen Leonard --- We don't have a firm rule for this, though it's something we should consider for the interface guidelines. In general I like to use a link when it's part of a block of text like this. I don't think it's an issue which should hold up this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 15:15:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 13:15:53 +0000 Subject: [Koha-bugs] [Bug 14084] order date language in Koha inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14084 --- Comment #1 from Nicole C. Engard --- I'll happily fix this, but would love to hear some ideas on what it should say. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 15:29:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 13:29:55 +0000 Subject: [Koha-bugs] [Bug 16727] Upload tool needs better warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16727 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 15:29:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 13:29:57 +0000 Subject: [Koha-bugs] [Bug 16727] Upload tool needs better warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16727 --- Comment #1 from Nicole C. Engard --- Created attachment 53749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53749&action=edit Bug 16727: Clarify upload category note This patch clarifies the note on the upload tool that states that no categories are defined. To test: * Log in to Koha * Confirm that you have no values set for the UPLOAD authorized value category * Visit Tools > Upload * Check the warning note for typos * Add a authorized value category for UPLOAD * Visit Tools > Upload * Confirm that note is replaced -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 15:52:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 13:52:20 +0000 Subject: [Koha-bugs] [Bug 16727] Upload tool needs better warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16727 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 15:55:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 13:55:39 +0000 Subject: [Koha-bugs] [Bug 16727] Upload tool needs better warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16727 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 15:55:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 13:55:41 +0000 Subject: [Koha-bugs] [Bug 16727] Upload tool needs better warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16727 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53749|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 53750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53750&action=edit [SIGNED-OFF] Bug 16727: Clarify upload category note This patch clarifies the note on the upload tool that states that no categories are defined. To test: * Log in to Koha * Confirm that you have no values set for the UPLOAD authorized value category * Visit Tools > Upload * Check the warning note for typos * Add a authorized value category for UPLOAD * Visit Tools > Upload * Confirm that note is replaced Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 16:16:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 14:16:36 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #9 from Owen Leonard --- Please update circ/reserveratios.tt so that the "plus" icon is not shown when there is no link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 16:17:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 14:17:47 +0000 Subject: [Koha-bugs] [Bug 16769] Koha::Cache->set_in_cache calls need to be standardised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52512|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy --- Created attachment 53751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53751&action=edit Bug 16769: Uniformise calls to Koha::Cache->set_in_cache >From the POD of Koha::Cache->set_in_cache: # This is a bit of a hack to support the old API in case things still use it Let's remove this hack and update old calls. Test plan: Look at the results of git grep set_in_cache and confirm that there are no more version of the old call (without hashref as third param) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 16:17:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 14:17:51 +0000 Subject: [Koha-bugs] [Bug 16769] Koha::Cache->set_in_cache calls need to be standardised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 --- Comment #3 from Marcel de Rooy --- Created attachment 53752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53752&action=edit Bug 16769: [QA Follow-up] Still found an occurrence Script svc/report did contain one old-style call. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 16:17:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 14:17:54 +0000 Subject: [Koha-bugs] [Bug 16769] Koha::Cache->set_in_cache calls need to be standardised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 --- Comment #4 from Marcel de Rooy --- Created attachment 53753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53753&action=edit Bug 16769: [QA Follow-up] Remove unsupported deepcopy parameter Routine C4/Koha/GetAuthorisedValues adds deepcopy => 1 to the options of set_in_cache. This makes no sense (anymore?). Is not supported or passed further. So better remove it. Test plan: Run t/db_dependent/Koha.t (with Test::Deep available to minimize confusion) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 16:18:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 14:18:11 +0000 Subject: [Koha-bugs] [Bug 16769] Koha::Cache->set_in_cache calls need to be standardised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 16:18:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 14:18:20 +0000 Subject: [Koha-bugs] [Bug 16769] Koha::Cache->set_in_cache calls need to be standardised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16769 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 16:28:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 14:28:54 +0000 Subject: [Koha-bugs] [Bug 16727] Upload tool needs better warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16727 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 16:28:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 14:28:57 +0000 Subject: [Koha-bugs] [Bug 16727] Upload tool needs better warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16727 --- Comment #3 from Marcel de Rooy --- Created attachment 53754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53754&action=edit Bug 16727: Clarify upload category note This patch clarifies the note on the upload tool that states that no categories are defined. To test: * Log in to Koha * Confirm that you have no values set for the UPLOAD authorized value category * Visit Tools > Upload * Check the warning note for typos * Add a authorized value category for UPLOAD * Visit Tools > Upload * Confirm that note is replaced Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 16:29:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 14:29:26 +0000 Subject: [Koha-bugs] [Bug 16727] Upload tool needs better warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16727 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 16:55:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 14:55:38 +0000 Subject: [Koha-bugs] [Bug 14156] Add id tags to each marc note in the display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14156 --- Comment #3 from Nicole C. Engard --- This would still be very helpful - I could do the template changes, but need help on GetMarcNotes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 16:55:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 14:55:41 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 --- Comment #11 from Marcel de Rooy --- Still working on this one. Coming back here tomorrow.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 17:00:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 15:00:08 +0000 Subject: [Koha-bugs] [Bug 9344] download report links at top and bottom In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9344 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 18:24:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 16:24:34 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 George Williams/Heather Braum (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gwilliams at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 18:32:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 16:32:30 +0000 Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and minification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 --- Comment #27 from Lari Taskula --- Hey Benjamin, thanks for the interest! I'm glad we share a desire to split our specification :) (In reply to Benjamin Rokseth from comment #26) > Also I'm not sure of the need to minify swagger at all. If the only reason > is for the online validation, I would argue that the online validation is > the problem. More important is `mojo swagger2 validate`. Our spec in master is not a valid Swagger spec, even if `mojo swagger2 validate` says so. Swagger specification does not support a reference whole Definitions-object in swagger.json like this: "definitions": { "$ref": "./definitions/index.json" } That is super annoying, but I think we also want to validate against the online validator because it spots this issue. `mojo swagger2 validate` works (for now), but what if the plugin's validator is updated to consider this type of $ref invalid (as Swagger specification says)? We would have to place all definitions and paths in swagger.json, and at maximum $ref individual paths and definitions to external files, not the whole Paths / Definitions-object. I think Olli-Antti also encountered some other issues that this minifier fixes. Maybe he can comment more about it. Btw, I have opened an issue to Swagger2 plugin's GitHub to initiate some more discussion: https://github.com/jhthorsen/swagger2/issues/89 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 19:45:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 17:45:16 +0000 Subject: [Koha-bugs] [Bug 16527] Sticky due date calendar unexpected behaviour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 19:45:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 17:45:58 +0000 Subject: [Koha-bugs] [Bug 16780] Specify due date always sets time as AM when using 12 hour time format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 19:53:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 17:53:56 +0000 Subject: [Koha-bugs] [Bug 16780] Specify due date always sets time as AM when using 12 hour time format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 --- Comment #9 from J Schmidt --- Can we have this backported to 3.22? One of our branches has hourly equipment and it impacts a great portion of their checkout transactions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 20:00:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 18:00:30 +0000 Subject: [Koha-bugs] [Bug 16988] New: Suspending a hold with AutoResumeSuspendedHolds disabled results in error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 Bug ID: 16988 Summary: Suspending a hold with AutoResumeSuspendedHolds disabled results in error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Unless AutoResumeSuspendedHolds is enabled, attempting to suspend a hold from reserve/request.pl results in the following error: The given date (undefined) does not match the date format (us) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 152. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 20:00:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 18:00:38 +0000 Subject: [Koha-bugs] [Bug 16988] Suspending a hold with AutoResumeSuspendedHolds disabled results in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 20:04:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 18:04:05 +0000 Subject: [Koha-bugs] [Bug 16988] Suspending a hold with AutoResumeSuspendedHolds disabled results in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 20:04:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 18:04:07 +0000 Subject: [Koha-bugs] [Bug 16988] Suspending a hold with AutoResumeSuspendedHolds disabled results in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 --- Comment #1 from Kyle M Hall --- Created attachment 53755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53755&action=edit Bug 16988 - Suspending a hold with AutoResumeSuspendedHolds disabled results in error iUnless AutoResumeSuspendedHolds is enabled, attempting to suspend a hold from reserve/request.pl results in the following error: The given date (undefined) does not match the date format (us) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 152. Test Plan: 1) Enable SuspendHoldsIntranet 2) Disable AutoResumeSuspendedHolds 3) Attempt to suspend or unsuspend a hold 4) Note the error 5) Apply this patch 6) Repeat step 3 7) The hold should suspend or resume correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 20:43:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 18:43:51 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #37 from M. Tompsett --- Comment on attachment 53536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53536 Bug 12446 - Enable an adult to have a guarantor Review of attachment 53536: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12446&attachment=53536) ----------------------------------------------------------------- ::: installer/data/mysql/kohastructure.sql @@ -318,5 @@ > `hidelostitems` tinyint(1) NOT NULL default '0', -- are lost items shown to this category (1 for yes, 0 for no) > `category_type` varchar(1) NOT NULL default 'A', -- type of Koha patron (Adult, Child, Professional, Organizational, Statistical, Staff) > `BlockExpiredPatronOpacActions` tinyint(1) NOT NULL default '-1', -- wheither or not a patron of this category can renew books or place holds once their card has expired. 0 means they can, 1 means they cannot, -1 means use syspref BlockExpiredPatronOpacActions > - `default_privacy` ENUM( 'default', 'never', 'forever' ) NOT NULL DEFAULT 'default', -- Default privacy setting for this patron category > - `checkprevcheckout` varchar(7) NOT NULL default 'inherit', -- produce a warning for this patron category if this item has previously been checked out to this patron if 'yes', not if 'no', defer to syspref setting if 'inherit'. Where did this go? ::: installer/data/mysql/sysprefs.sql @@ +544,4 @@ > ('XSLTListsDisplay','default','','Enable XSLT stylesheet control over lists pages display on intranet','Free'), > ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over results page display on intranet','Free'), > ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'), > +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'), No to the comma! ::: koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-us.inc @@ +8,4 @@ > > + Potential cut and paste error. Nice catch. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ +1019,4 @@ >
  • > > > + If you have the code, why the description? ::: koha-tmpl/intranet-tmpl/prog/js/members.js @@ -357,5 @@ > - "bottom": "3%", > - "position": "fixed", > - "right": "1%", > - "width": "150px", > - } ); Why did you cut this? ::: members/memberentry.pl @@ +236,5 @@ > } > } > > +#recover all data from guarantor address phone ,fax... > +if ( $guarantorid and ( $category_type eq 'C' || $category_type eq 'P')) { Why did you add category type? Should not any patron be able to be a guarantor for another? If there is a guarantorid, that should be enough, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 21:14:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 19:14:09 +0000 Subject: [Koha-bugs] [Bug 16989] New: Advanced search form does not display translated itemtype Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16989 Bug ID: 16989 Summary: Advanced search form does not display translated itemtype Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In Staff client, the advanced serach form does not display the translations item types. (Note: It is not necessary to have translations installed to verify this bug.) Prerequisites: - Go to Home > Administration > Item types administration - Edit e.g. item type "BK" (Book) - Near "Description", click link "Translate into other languages - If you have other languaes installed, add translatons for those - If you have an Englis only installation, add a "translation" for English, make sure that you can identify it while testing (I used "BOOOOOOOOOOOOKS") Verify: - Go to Home ? Advanced search - Verify near "Limit to any of the following" that the description for itemtype BK reads "Book" instead of "BOOOOOOOOOOOOKS" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 21:25:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 19:25:24 +0000 Subject: [Koha-bugs] [Bug 16989] Advanced search form does not display translated itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16989 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 21:26:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 19:26:13 +0000 Subject: [Koha-bugs] [Bug 16989] Advanced search form does not display translated itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16989 --- Comment #1 from Marc V?ron --- Created attachment 53756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53756&action=edit Bug 16989 - Advanced search form does not display translated itemtype In Staff client, the advanced serach form does not display the translations of item types. (Note: It is not necessary to have translations installed to verify this bug.) Prerequisites: - Go to Home > Administration > Item types administration - Edit e.g. item type "BK" (Book) - Near "Description", click link "Translate into other languages - If you have other languaes installed, add translatons for those - If you have an Englis only installation, add a "translation" for English, make sure that you can identify it while testing (I used "BOOOOOOOOOOOOKS") Verify: - Go to Home ? Advanced search - Verify near "Limit to any of the following" that the description for itemtype BK reads "Book" instead of "BOOOOOOOOOOOOKS" Test: - Apply patch - Verify that the item type description now reads ""BOOOOOOOOOOOOKS" - If you have a multi language installaton, verify that item types you translated display as appropriate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 21:32:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 19:32:28 +0000 Subject: [Koha-bugs] [Bug 16989] Advanced search form does not display translated itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16989 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Depends on| |14100 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 [Bug 14100] Add base to make item types, branch names, sysprefs values and authorised values translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 21:32:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 19:32:28 +0000 Subject: [Koha-bugs] [Bug 14100] Add base to make item types, branch names, sysprefs values and authorised values translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16989 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16989 [Bug 16989] Advanced search form does not display translated itemtype -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 22:30:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 20:30:42 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 22:30:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 20:30:46 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53150|0 |1 is obsolete| | Attachment #53193|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 53757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53757&action=edit [PASSED QA] Bug 16861: Translatability: Fix separated "below" in circulation.tt This patch propose to fix this two entries in PO files: "See highlighted items" and "below" Also add some Font Awesome Icons To test: -Apply patch 16810 on top and this patch -Go to a patron who has overdues -See the link "See highlighted items below" with a hand down icon -Look the new plus icon to "Add a new message" to the patron. -Add a few messages and notice about the trash icon in "Delete" links Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 22:31:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 20:31:58 +0000 Subject: [Koha-bugs] [Bug 16861] Translatability: Fix separated "below" in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 --- Comment #10 from Katrin Fischer --- Created attachment 53758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53758&action=edit [PASSED QA] Bug 16861: (followup)Translatability: remove fa-hand-o-down icon Remove fa-hand-o-down icon accoring with QA comment 5 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 27 23:23:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 21:23:06 +0000 Subject: [Koha-bugs] [Bug 16990] New: Show branch name instead of branch code when managing patron modification requests Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16990 Bug ID: 16990 Summary: Show branch name instead of branch code when managing patron modification requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To test: - change your homebranch in the OPAC, submit - change patron modification request in the staff client - Verify that it shows the old and new branch code instead of the descripton/name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 00:00:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 22:00:58 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #93 from Katrin Fischer --- Miraculously, this still applies :) Can you please answer the question asked in comment#92? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 00:06:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 22:06:34 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #94 from Katrin Fischer --- Please also fix these errors pointed out by the QA script. Other problems can be ignored for now ("Tie::Hash::FIELDS"...) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt FAIL forbidden patterns forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 31) forbidden pattern: tab char (line 36) forbidden pattern: tab char (line 32) forbidden pattern: tab char (line 34) forbidden pattern: tab char (line 37) forbidden pattern: tab char (line 33) forbidden pattern: tab char (line 35) OK spelling OK tt_valid OK valid_template FAIL reports/cash_register_stats.pl FAIL critic "$q_errors" is declared but not used at line 140, column 9. Unused variables clutter code and make it harder to read. "$content" is declared but not used at line 146, column 9. Unused variables clutter code and make it harder to read. I will keep an eye on this and try to continue as soon as the follow up is there. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 00:11:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Jul 2016 22:11:04 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #95 from Katrin Fischer --- Tiny thing: the total amount in the last grey line of the table is not formatted. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 02:59:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 00:59:06 +0000 Subject: [Koha-bugs] [Bug 16212] Swagger specification separation and minification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 --- Comment #28 from Benjamin Rokseth --- (In reply to Lari Taskula from comment #27) > Hey Benjamin, thanks for the interest! I'm glad we share a desire to split > our specification :) > > (In reply to Benjamin Rokseth from comment #26) > > Also I'm not sure of the need to minify swagger at all. If the only reason > > is for the online validation, I would argue that the online validation is > > the problem. More important is `mojo swagger2 validate`. > Our spec in master is not a valid Swagger spec, even if `mojo swagger2 > validate` says so. Swagger specification does not support a reference whole > Definitions-object in swagger.json like this: > > "definitions": { > "$ref": "./definitions/index.json" > } > > That is super annoying, but I think we also want to validate against the > online validator because it spots this issue. `mojo swagger2 validate` works > (for now), but what if the plugin's validator is updated to consider this > type of $ref invalid (as Swagger specification says)? We would have to place > all definitions and paths in swagger.json, and at maximum $ref individual > paths and definitions to external files, not the whole Paths / > Definitions-object. > > I think Olli-Antti also encountered some other issues that this minifier > fixes. Maybe he can comment more about it. > > Btw, I have opened an issue to Swagger2 plugin's GitHub to initiate some > more discussion: https://github.com/jhthorsen/swagger2/issues/89 Lari, I engaged in your discussion at github, but to be sure, are we talking about the same thing? I test the swagger definitions at the online swagger validator and it obviously fails at relative and URI, as they are not resolvable to the validator. This is to be expected, but does not mean the definition is invalid. The only way to validate online in any case would be to first resolve all refs to one single json document. You refer to invalid refs in swagger specifications, but I only find this discussion in the swagger-ui -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 04:08:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 02:08:16 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #10 from Srdjan Jankovic --- Yes, you must have an OverDrive account to use this, and even set up the return url with them. It's a process. I apologise, I did not update PerlDependencies, I thought it was only for mandatory deps. Do you want me to add it to the first patch, or write a follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 06:15:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 04:15:41 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51813|0 |1 is obsolete| | --- Comment #23 from Nicholas van Oudtshoorn --- Created attachment 53760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53760&action=edit New patch, addressing the SQL bug Hi Marc, Thanks for taking a look. What a silly mistake! :-) Updated patch should fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 07:32:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 05:32:51 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #24 from Marc V?ron --- Quick test: SQL error is gone. However, I get an 'Internal Server Error' plack-error.log says: Could not compile (...)/opac/sco/sco-main.pl: "in_ipset" is not exported by the C4::Auth module Can't continue after import errors at (...)/opac/sco/sco-main.pl line 40. (I have not to much time for testing until mid August.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 07:52:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 05:52:12 +0000 Subject: [Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer --- Nick, can you please take a look at the questions and comments? Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 08:01:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 06:01:18 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|oleonard at myacpl.org |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 08:20:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 06:20:31 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #11 from Marcel de Rooy --- (In reply to Srdjan Jankovic from comment #10) > Yes, you must have an OverDrive account to use this, and even set up the > return url with them. It's a process. I assumed so. But my question was: Did the signoffer (Jesse) actually test with an Overdrive account? > I apologise, I did not update PerlDependencies, I thought it was only for > mandatory deps. Do you want me to add it to the first patch, or write a > follow-up? Since you already have a SO, you'd better write a follow-up. No need to change status for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 11:25:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 09:25:08 +0000 Subject: [Koha-bugs] [Bug 15922] Show authorized value description in staff client search results for lost , withdrawn, and damaged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- We have a library asking for the exact status in the result lists as well - is there a way to get this moving again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 11:41:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 09:41:40 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 11:41:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 09:41:42 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52409|0 |1 is obsolete| | Attachment #53746|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 53761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53761&action=edit Bug 16365: Selectively introduce GetMarcStructure() "unsafe" variant for better performance GetMarcStructure() currently uses Koha::Cache in the "safe" mode (returning deep copy of the result data structure by default), which causes numerous performance issues in many Koha scripts. Switching it to the "unsafe" mode globally (2nd patch from Bug 16140) resolves those issues, but ensuring that it is regression-free (and that it will stay that way in the future) is far from easy. This patch proposes a bit more manageable solution, it introduces a possibility to use "unsafe" variant selectively (only in those places in the code where GetMarcStructure() is called repetitively). That way, amount of the code that needs to be audited for possible problems gets vastly reduced, without any performance trade-offs. Test plan: 1) Have a look at the code and audit the parts affected by this patch for possible regressions Signed-off-by: Marcel de Rooy Amended the POD of GetMarcStructure, removing a TODO. NOTE: GetAuthorisedValueDesc, as called in C4::XSLT::transformMARCXML4XSLT and by GetISBDView, GetMarcAuthors in C4::Biblio, may autovivify some hash entries in tagslib. Same for Koha/Filter/MARC/ViewPolicy.pm, sub filter. No reason however to worry; our use of this structure in Koha does not depend on the existence of intermediate hash keys. (We seem to be safe as long as $tagslib->{$tag}->{$subfield}->{tab} and/or hidden are not filled.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 11:41:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 09:41:46 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 --- Comment #13 from Marcel de Rooy --- Created attachment 53762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53762&action=edit Bug 16365 - GetMarcStructure() "unsafe" variant in PrepareItemrecordDisplay() This sub is a good candidate for the "unsafe" treatment too, it doesn't modify nor autovivify anything in the marc structure. Added a warning in the code regarding the $tagslib usage by the custom item plugins, plus a small change to prevent possible "Use of uninitialized value" warnings in the future. Signed-off-by: Marcel de Rooy Tested with neworderempty.pl and itemrecorddisplay.pl. Amended slightly: Made warning less dramatic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 11:41:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 09:41:50 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 --- Comment #14 from Marcel de Rooy --- Created attachment 53763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53763&action=edit Bug 16365: Adding additional unsafe call-candidates from Acquisition [1] Candidate 1 is FillWithDefaultValues. This routine in Acquisition.pm does not autovivify the tagslib structure but first collects the keys at tag and subfield level. So, unsafe can be safely added here :) [2] Candidate 2 is script acqui/neworderempty.pl. It only (!) uses GetMarcStructure to know if there is a ACQ framework. There should be cheaper ways to do it, but when we use the fast cache, it does not matter that much anymore. [3] Candidate 3 is script acqui/orderreceive.pl. Same reason as [2]. Signed-off-by: Marcel de Rooy Tested with neworderempty.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 11:41:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 09:41:54 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 --- Comment #15 from Marcel de Rooy --- Created attachment 53764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53764&action=edit Bug 16365: [QA Follow-up] Add some comment lines to Cache.pm Resolve typo inifinite too. Adds a few lines in order to stress that the thawed key of the L1 cache SHOULD ONLY be used for unsafe calls, and not be mixed with regular (safe) calls. Test plan: Nothing to test, but verify the quality of the added comments. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 11:43:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 09:43:17 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 --- Comment #16 from Marcel de Rooy --- Did not touch: catalogue/MARCdetail.pl:my $tagslib = &GetMarcStructure(1,$frameworkcode); catalogue/getitem-ajax.pl: my $acq_fw = GetMarcStructure(1, 'ACQ'); catalogue/labeledMARCdetail.pl:my $tagslib = GetMarcStructure(1,$frameworkcode); cataloguing/addbiblio.pl:$tagslib = &GetMarcStructure( 1, $frameworkcode cataloguing/additem.pl:my $tagslib = &GetMarcStructure(1,$frameworkcode); cataloguing/merge.pl: my $tagslib = GetMarcStructure(1, $framework); cataloguing/merge_ajax.pl:my $tagslib = GetMarcStructure(1, $framework); circ/branchoverdues.pl:my $tagslib = &GetMarcStructure(1,''); misc/batchDeleteUnusedSubfields.pl:my $tags = GetMarcStructure(1); opac/opac-MARCdetail.pl:my $tagslib = &GetMarcStructure( 0, $itemtype ); svc/cataloguing/framework:my $tagslib = GetMarcStructure( 1, $frameworkcode ); t/db_dependent/Biblio.t: my $tagslib = GetMarcStructure(); tools/batchMod.pl:our $tagslib = &GetMarcStructure(1); For another report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 11:52:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 09:52:53 +0000 Subject: [Koha-bugs] [Bug 16140] Only clear L1 cache when needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #29 from Marcel de Rooy --- What is the current status of this discussion? ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 12:11:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 10:11:28 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 12:11:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 10:11:31 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53218|0 |1 is obsolete| | --- Comment #31 from Josef Moravec --- Created attachment 53765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53765&action=edit Bug 10407: Allow MARCXML records to be imported via GUI (groundwork) Patch from Olli, manual rebase by Marcel (July 7, 2016). Signed-off-by: Marcel de Rooy Needs follow-up. Test plan in the third patch. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 12:11:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 10:11:43 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53219|0 |1 is obsolete| | --- Comment #32 from Josef Moravec --- Created attachment 53766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53766&action=edit Bug 10407: Resolve warnings from child process After the staging job finishes, the child tries to print results to STDOUT (which is closed). This creates warnings like: stage-marc-import.pl: binmode() on closed filehandle STDOUT at C4/Templates.pm line 120. stage-marc-import.pl: Filehandle STDOUT reopened as FH only for input at /usr/lib/perl5/Template/Provider.pm line 964. Resolving it is simple: the child should exit after marking the job as finished. Test plan: Import a marc file. Observe that you do no longer have such warnings. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 12:11:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 10:11:53 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53220|0 |1 is obsolete| | --- Comment #33 from Josef Moravec --- Created attachment 53767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53767&action=edit Bug 10407: Add marcxml import (follow-up) This patch makes the following changes: [1] Based on the groundwork of the former patch, add call to RecordsFromMARCXMLFile in stage-marc-import. Use format param. [2] Add format to the template. Use file extension to determine. If you use .xml or .marcxml as extension, MARCXML is selected. [3] In stage-marc-import.tt mark UTF-8 encoding as UTF-8 not as utf8. [4] BatchStageMarcRecords: do not call plugin if you have no records. [5] RecordsFromISO2709File: also return errors in an array. [6] In misc/stage_file.pl also use UTF-8. Handling of errors from [5]. Test plan: [1] Import an empty file as MARC or MARCXML (with Tools/Stage..import). [2] Import an non-empty file with invalid contents as MARC or MARCXML. [3] Export a few records with Tools/Export as MARC and MARCXML. [4] Import these two files. Check selected format versus file extension. [5] Import a MARCXML file with misc/stage_file.pl. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 12:12:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 10:12:08 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53306|0 |1 is obsolete| | --- Comment #35 from Josef Moravec --- Created attachment 53769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53769&action=edit Bug 10407: [QA Follow-up] Hashref process_batch params As requested by Mark Tompsett. Hope this guarantees a signoff now.. Note: For consistency four additional parameters were needed to no longer use file level vars in this subroutine. Test plan: Import a file with stage_file.pl. Signed-off-by: Marcel de Rooy Imported a marc file and a marcxml file with stage_file.pl. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 12:12:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 10:12:02 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53223|0 |1 is obsolete| | --- Comment #34 from Josef Moravec --- Created attachment 53768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53768&action=edit Bug 10407: Add two subtests to t/ImportBatch.t Creates a few simple tests for the two new subroutines in ImportBatch.pm. Test plan: Run t/ImportBatch.t. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 12:19:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 10:19:33 +0000 Subject: [Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #36 from Marcel de Rooy --- (In reply to Josef Moravec from comment #35) > Signed-off-by: Josef Moravec Thx Josef ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 12:43:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 10:43:49 +0000 Subject: [Koha-bugs] [Bug 16079] Retrieving system preferences from database via DBIx is not fast enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16079 --- Comment #18 from Marcel de Rooy --- (In reply to Jacek Ablewicz from comment #17) > Any ideas how to implement hashref inflator method / variant inside > Koha::Object[s] without violating (too much ;) the underlying principles of > Koha::Objects? Good question :) I will be very interested in seeing an implementation of that.. Looks like especially Objects.pm would need some intelligent handling of both variants where it now just wraps DBIx result sets. But it would be interesting in cases where we would now rightaway call search, find and unbless. If the current design really allows that is another one. In terms of code maintenance it might become harder. The object in _resultset would probably beg for another layer? Or just replace the search( )->unbless by some new search_inflated( ) ? What about it, Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 13:00:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 11:00:23 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53742|0 |1 is obsolete| | --- Comment #24 from Benjamin Rokseth --- Created attachment 53770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53770&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 13:00:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 11:00:32 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53743|0 |1 is obsolete| | --- Comment #25 from Benjamin Rokseth --- Created attachment 53771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53771&action=edit Bug 15516 - Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 13:00:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 11:00:39 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53744|0 |1 is obsolete| | --- Comment #26 from Benjamin Rokseth --- Created attachment 53772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53772&action=edit Bug 15516: Update old_reserves (reserve_group_id) Without it, deletion of reserves will fail Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 13:01:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 11:01:26 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #27 from Benjamin Rokseth --- Rebased to update foreign keys -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 13:06:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 11:06:31 +0000 Subject: [Koha-bugs] [Bug 16988] Suspending a hold with AutoResumeSuspendedHolds disabled results in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 13:06:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 11:06:34 +0000 Subject: [Koha-bugs] [Bug 16988] Suspending a hold with AutoResumeSuspendedHolds disabled results in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16988 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53755|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 53773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53773&action=edit Bug 16988 - Suspending a hold with AutoResumeSuspendedHolds disabled results in error iUnless AutoResumeSuspendedHolds is enabled, attempting to suspend a hold from reserve/request.pl results in the following error: The given date (undefined) does not match the date format (us) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 152. Test Plan: 1) Enable SuspendHoldsIntranet 2) Disable AutoResumeSuspendedHolds 3) Attempt to suspend or unsuspend a hold 4) Note the error 5) Apply this patch 6) Repeat step 3 7) The hold should suspend or resume correctly Signed-off-by: Kyle M Hall Signed-off-by: Megan Wianecki -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 14:20:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 12:20:51 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53770|0 |1 is obsolete| | --- Comment #28 from Benjamin Rokseth --- Created attachment 53774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53774&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 14:21:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 12:21:00 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53771|0 |1 is obsolete| | --- Comment #29 from Benjamin Rokseth --- Created attachment 53775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53775&action=edit Bug 15516 - Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 14:21:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 12:21:08 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53772|0 |1 is obsolete| | --- Comment #30 from Benjamin Rokseth --- Created attachment 53776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53776&action=edit Bug 15516: Update old_reserves (reserve_group_id) Without it, deletion of reserves will fail Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 14:25:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 12:25:31 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #31 from Benjamin Rokseth --- Now rebased against pushed Bug 15533 - Allow patrons and librarians to select itemtype when placing hold. Tested to be working as before this patch was pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 14:52:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 12:52:32 +0000 Subject: [Koha-bugs] [Bug 15922] Show authorized value description in staff client search results for lost , withdrawn, and damaged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 --- Comment #9 from Owen Leonard --- I'm happy to pick this up again if there are no objections to my initial approach. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 14:54:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 12:54:46 +0000 Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #6 from Marcel de Rooy --- Created attachment 53777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53777&action=edit Bug 16965: [Follow-up] Adjust get_object_class In many cases it should be possible to derive the Koha::Objects class name from the DBIx result class name in a trivial manner. If not, the DBIx result class should have a class method called koha_objects_class providing that non-trivial name, such as Libraries for Branch. Note: We are only interested in the plural form here (Koha::Objects). Test plan: Run t/db_dependent/Koha/Objects.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 14:55:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 12:55:24 +0000 Subject: [Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #7 from Marcel de Rooy --- Jonathan: What do you think of the approach in the third patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 15:16:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 13:16:35 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #96 from Francois Charbonnier --- (In reply to Katrin Fischer from comment #59) > - What is the definition of an "Active transaction"? (was not clear to me, > so asking :) ) The idea behind "Active transactions" is to help balance cash register transactions. In other words, how much goes in or how much goes out the cash register. The active transactions group what patrons paid or gave as credit to the library, which means what went IN the register. The code works this way : it takes all transactions where account types are NOT "F" (Fine), "FU" (Fine unpaid), "FOR" (Forgiven), "M" (Sundry), "L" (Lost). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 15:39:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 13:39:00 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #97 from Bouzid --- Created attachment 53778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53778&action=edit Bug6934 - fix errors pointed out by the QA script -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 15:39:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 13:39:46 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 15:46:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 13:46:17 +0000 Subject: [Koha-bugs] [Bug 2635] Adding non-digit chars to cost fields in items causes data corruption In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2635 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #4 from Jesse Maseto --- Wondering if this is part of this bug? We are seeing when we put a price in for the original purchase price it gets saved as a 1 when the value has a comma in it. For example Edit an item, add 1,345.80 and click save. It gets saved as a 1. If you enter 1345.80 it saves correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 15:48:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 13:48:34 +0000 Subject: [Koha-bugs] [Bug 2635] Adding non-digit chars to cost fields in items causes data corruption In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2635 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 16:13:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 14:13:56 +0000 Subject: [Koha-bugs] [Bug 16974] koha-plack should check and fix log files permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 16:31:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 14:31:28 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #98 from H?ctor Eduardo Castro Avalos --- Hi Bouzid One comment: In bug 16964 I fix the capitalization up for "Report Plugins", right now the bug is in Passed QA. I will try to fix it again in your last patch. Regards -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 16:35:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 14:35:05 +0000 Subject: [Koha-bugs] [Bug 14844] Corrupted storable string. When adding/editing an Item, cookie LastCreatedItem might be corrupted. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14844 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 16:35:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 14:35:10 +0000 Subject: [Koha-bugs] [Bug 14844] Corrupted storable string. When adding/editing an Item, cookie LastCreatedItem might be corrupted. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14844 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42644|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 53779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53779&action=edit Bug 14844: Corrupted storable string. When adding/editing an Item, cookie LastCreatedItem might be corrupted. No idea how to replicate this issue but we have been getting several reports about the following error: Software error: Corrupted storable string (binary v2.9) at /usr/lib/perl/5.18/Storable.pm line 417, at /home/koha/kohaclone/cataloguing/additem.pl line 375. TEST PLAN: 1. Add or modify an Item. 2. No observed changes. ?. We don't know what causes this but we know that add/modify Item occasionally crashes due to failure of a cookie thawing. This patch prevents the whole program from dying, because this error is not critical enough to warrant dying. Also there is no centralized mechanism in Koha for showing messages to the user, so there is no easy and convenient way to warn the user that the: 'LastCreatedItem'-cookie or the systempreference 'PrefillItem' is malfunctioning. So we instead just warn to the server logs with the malfunctioning cookie in hopes of nailing down what causes the issues. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 16:51:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 14:51:47 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #99 from Bouzid --- Hi H?ctor, ok, thanks. Regards -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 16:57:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 14:57:15 +0000 Subject: [Koha-bugs] [Bug 16991] New: need subtitle on holds to pull Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16991 Bug ID: 16991 Summary: need subtitle on holds to pull Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org The subtitle should show on the holds to pull list. I recommend adding the keyword to marc mapping to this page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 17:28:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 15:28:31 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #100 from H?ctor Eduardo Castro Avalos --- Passing QA-Test Tool I got: FAIL reports/cash_register_stats.pl OK critic OK forbidden patterns OK pod OK spelling 0 FAIL valid Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo Name "Tie::Hash::FIELDS" used only once: possible typo Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo Use of uninitialized value $_[0] in lc But I think this is a problem caused for bug 11998 and explained for Jonathan in bug 16104 if you test with: $ perl -cw reports/cash_register_stats.pl you obtain: Use of uninitialized value $_[0] in lc at /usr/share/perl5/Cache.pm line 485. Use of uninitialized value $_[0] in lc at /usr/share/perl5/Cache.pm line 485. Use of uninitialized value $_[0] in lc at /usr/share/perl5/Cache.pm line 485. Name "Tie::Hash::FIELDS" used only once: possible typo at /usr/share/perl/5.14/fields.pm line 135. Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo at /usr/share/perl/5.14/fields.pm line 135. Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo at /usr/share/perl/5.14/fields.pm line 135. reports/cash_register_stats.pl syntax OK But all this errors are from bug 11998 Still FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt FAIL forbidden patterns forbidden pattern: tab char (line 36) forbidden pattern: tab char (line 37) forbidden pattern: tab char (line 35) forbidden pattern: tab char (line 34) forbidden pattern: tab char (line 31) forbidden pattern: tab char (line 33) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 32) But I will fix it up in the last patch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 17:35:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 15:35:08 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53778|0 |1 is obsolete| | --- Comment #101 from H?ctor Eduardo Castro Avalos --- Created attachment 53780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53780&action=edit [SIGNED-OFF]Bug6934: fix errors pointed out by the QA script Also fix forbidden patterns in koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt Signed-off-by: Hector Castro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 17:35:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 15:35:41 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 17:50:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 15:50:57 +0000 Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16992 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 17:58:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 15:58:26 +0000 Subject: [Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 17:58:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 15:58:29 +0000 Subject: [Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 --- Comment #12 from Josef Moravec --- Created attachment 53782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53782&action=edit Bug 15895 - Add Koha::Account module, use Koha::Account::pay internally for recordpayment This is the first patch in a series to unify all payment functions into a single method. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay amount" button Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 17:58:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 15:58:38 +0000 Subject: [Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53314|0 |1 is obsolete| | --- Comment #13 from Josef Moravec --- Created attachment 53783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53783&action=edit Bug 15896 - Use Koha::Account::pay internally for makepayment This is the second patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 17:59:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 15:59:36 +0000 Subject: [Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51920|0 |1 is obsolete| | --- Comment #14 from Josef Moravec --- Created attachment 53784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53784&action=edit bug 15896 - A few tests for Koha::Account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 17:59:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 15:59:40 +0000 Subject: [Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53782|0 |1 is obsolete| | --- Comment #15 from Josef Moravec --- Created attachment 53785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53785&action=edit Bug 15895 - Add Koha::Account module, use Koha::Account::pay internally for recordpayment This is the first patch in a series to unify all payment functions into a single method. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay amount" button Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 17:59:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 15:59:45 +0000 Subject: [Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53783|0 |1 is obsolete| | --- Comment #16 from Josef Moravec --- Created attachment 53786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53786&action=edit Bug 15896 - Use Koha::Account::pay internally for makepayment This is the second patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 18:00:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 16:00:09 +0000 Subject: [Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53785|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 18:04:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 16:04:45 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51595|0 |1 is obsolete| | --- Comment #16 from Barton Chittenden --- Created attachment 53787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53787&action=edit [SIGNED-OFF] Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each other It appears that the LocalHoldsPriority feature and the Holds Queue are fundamentally at odds with each other. The problem appears to be that both are attempting to choose the best way to fill holds. When you are using the holds queue and you check in an item that has been selected by the holds queue builder, that part of Koha where the LocalHoldsPriority feature lives doesn't get to see all the holds in order to pick the best one. Instead only the hold selected by the holds queue builder is returned so to the LocalHoldsPriority feature, that is only one hold to pick from! Test Plan: 1) Apply this patch 2) prove t/db_dependent/HoldsQueue.t 3) All tests should pass Signed-off-by: Barton Chittenden barton at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 18:15:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 16:15:15 +0000 Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16993 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 19:27:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 17:27:34 +0000 Subject: [Koha-bugs] [Bug 16994] New: Import and export MARC modification templates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16994 Bug ID: 16994 Summary: Import and export MARC modification templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Configuring a complicated MARC modification template can be a tedious job, so it would be nice to be able to import and export them the way we can with MARC frameworks. This would also facilitate sharing between libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 19:41:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 17:41:26 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 --- Comment #17 from Kyle M Hall --- (In reply to Liz Rea from comment #14) > Should we expect that this local hold that has priority for a branch turn up > on the hold queue? Or do we only care about what happens when an item is > checked in? > > My instinct says that a local hold priority item should show up on the hold > queue for the prioritised library/item/borrower > > Example, Patron from springfield has a biblio level reserve for a book that > has a springfield copy, the springfield copy is available, should this turn > up on the hold queue for springfield? > > Currently the reserve doesn't show up on any hold queue. Is that correct > behaviour? How would the library know the reserve exists in this case > without scanning it to trap it? Yes, the hold should show up in the holds queue. That's all this patch is supposed to do is to select the same patron for the holds queue that would be selected if the item in question was not already in the holds queue. The problem right now is the holds queue is choosing the wrong patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 19:42:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 17:42:37 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 --- Comment #18 from Kyle M Hall --- (In reply to Liz Rea from comment #15) > *with this patch, the reserve doesn't show up on any hold queue. Without it, > as you noted, it does show up on the wrong priority library's hold queue. Do you have Local Holds Priority enabled? Can you try again with it switched both on and off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 20:11:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 18:11:05 +0000 Subject: [Koha-bugs] [Bug 16989] Advanced search form does not display translated itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16989 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 20:11:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 18:11:08 +0000 Subject: [Koha-bugs] [Bug 16989] Advanced search form does not display translated itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16989 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53756|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 53789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53789&action=edit [SIGNED-OFF] Bug 16989 - Advanced search form does not display translated itemtype In Staff client, the advanced serach form does not display the translations of item types. (Note: It is not necessary to have translations installed to verify this bug.) Prerequisites: - Go to Home > Administration > Item types administration - Edit e.g. item type "BK" (Book) - Near "Description", click link "Translate into other languages - If you have other languaes installed, add translatons for those - If you have an Englis only installation, add a "translation" for English, make sure that you can identify it while testing (I used "BOOOOOOOOOOOOKS") Verify: - Go to Home ? Advanced search - Verify near "Limit to any of the following" that the description for itemtype BK reads "Book" instead of "BOOOOOOOOOOOOKS" Test: - Apply patch - Verify that the item type description now reads ""BOOOOOOOOOOOOKS" - If you have a multi language installaton, verify that item types you translated display as appropriate Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 20:11:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 18:11:49 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 20:32:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 18:32:20 +0000 Subject: [Koha-bugs] [Bug 16995] New: Remove event attributes from two include files Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16995 Bug ID: 16995 Summary: Remove event attributes from two include files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org cat-toolbar.inc and members-toolbar.inc contain event attributes which should be removed in favor of defining events in JavaScript. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 20:37:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 18:37:41 +0000 Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 --- Comment #8 from Magnus Enger --- First of all let me say that I am no iCal expert! I created a small test script: --- #!/usr/bin/perl use Modern::Perl; use DateTime::Format::ICal; use Koha::DateUtils; my $datestring = '2016-03-10 23:59:00'; my $dt = dt_from_string( $datestring ); say DateTime::Format::ICal->format_datetime( $dt ); my $dt2 = dt_from_string( $datestring ); $dt2->set_time_zone( C4::Context->tz ); say DateTime::Format::ICal->format_datetime( $dt2 ); my $dt3 = dt_from_string( $datestring ); $dt3->set_time_zone( 'UTC' ); say DateTime::Format::ICal->format_datetime( $dt3 ); --- This gives the following output: TZID=Europe/Oslo:20160310T235900 TZID=Europe/Oslo:20160310T235900 20160310T225900Z I tested the output from Koha in a couple of different validators. When I have a date like TZID=Europe/Oslo:20160310T235900 in the ICS I get errors from the validators: Error: Error was: Error at line 15:[DTSTART] Unparseable date: "TZID=Europe/Oslo:20160810T235900" Cause: Caused by: [DTSTART] Unparseable date: "TZID=Europe/Oslo:20160810T235900" http://severinghaus.org/projects/icv/ Invalid DTSTART value, must be a date or date-time value near line # 11 http://icalendar.org/validator.html When I change the script so all dates look like 20160310T225900Z, I get no errors from the same validators. In addition, Marc has said that Thunderbird accepts this (but not TZID=Europe/Oslo:20160310T235900) *and* interprets the date and time correctly. My pragmatic side tells me this should be good enough. :-) >From https://metacpan.org/pod/DateTime::Format::ICal: "The iCal spec requires that datetimes be formatted either as floating times (no time zone), UTC (with a 'Z' suffix) or with a time zone id at the beginning ('TZID=America/Chicago;...')." The way I read this, "formatting as UTC" is just as good as having a "time zone id at the beginning". -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 20:38:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 18:38:01 +0000 Subject: [Koha-bugs] [Bug 16995] Remove event attributes from two include files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16995 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 20:38:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 18:38:04 +0000 Subject: [Koha-bugs] [Bug 16995] Remove event attributes from two include files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16995 --- Comment #1 from Owen Leonard --- Created attachment 53790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53790&action=edit Bug 16995 - Remove event attributes from two include files This patch removes event attributes from two include files: cat-toolbar.inc and members-toolbar.inc. In cat-toolbar.inc an unused
    tag with an "onsubmit" attribute has been removed. To test, apply the patch and: - View the detail page for any bibliographic record. All toolbar buttons ("New," "Edit," "Save," etc.) should work as expected. - View the detail page for any patron. Click the "Add message" button in the toolbar. Selecting a predefined note should correctly populate the textarea with your selected message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 22:46:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 20:46:40 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 22:46:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 20:46:43 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53716|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia --- Created attachment 53791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53791&action=edit Bug 16939: Making all 'add to basket' actions buttons Edit: Fixing 'clas' typo in addorderiso2709.tt Edit: Adding actions class to td Edit: Fixing js error Edit: circ/reserveratios.tt updated so that the plus icon doesn't show if there is no link To test: 1) Go to Acqui -> find a vendor -> view a basket 2) Click add to basket -> fill in 'for an existing record' and hit search 3) 'View MARC' and 'Order' buttons should show under an Actions column with appropriate icons 4) Click Order 5) Click add item when you are redirected to the New order page (no need to fill in any details) 6) Confirm that 'Edit' and 'Delete' buttons now show under an Actions column with appropriate icons 7) Go back to your basket and click add to basket -> from a subscription (we are skipping from a suggestion because this already has a button before my patch) 8) Confirm that 'Order' shows as a button with appropriate icon 9) Go back to your basket and click add to basket -> from an external source 10) fill in any fields and click search to bring up results 11) 'Order' should now show as a button with appropriate icons. MARC and Card preview have been moved into a dropdown menu - confirm this works as expected. Links have not been changed when clicking on a row 12) Go back to your basket and click add to basket -> from a staged file 13) 'Add orders' should now show as a button with appropriate icon 14) Go back to your basket and click add to basket -> from titles with highest hold ratios 15) 'X to order' should now show as a button with appropriate icon Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 22:59:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 20:59:20 +0000 Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no records have been passed in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949 --- Comment #5 from Aleisha Amohia --- (In reply to Marc V?ron from comment #3) > ...and maybe an additional link back to the previous screen to give the > opportunity to select records. There is already a link there that says 'New batch record deletion' after the form has been submitted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 23:22:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 21:22:50 +0000 Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no records have been passed in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 28 23:22:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Jul 2016 21:22:53 +0000 Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no records have been passed in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53540|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia --- Created attachment 53792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53792&action=edit Bug 16949: Batch record deletion says success when no records have been passed in The reason this happens is because the page will say success when the total number of records given equals the total number of successful deletions. If you pass in no records, there are no successful deletions --> 0 = 0 --> it thinks it has been successful. This patch adds a check that validates if any checkboxes were selected before submitting the final form. I have removed the check for if any records were selected AFTER the form has been submitted because it seemed unnecessary if the form can't be submitted without selection of records anyway. To test: 1) Go to Tools -> Batch record deletion 2) Put in a record number and click Continue 3) Deselect the record so that it doesn't actually delete and click Delete selected records 4) Page says 'All records have been deleted successfully!' 5) Apply patch. Go back and repeat step 3 6) Form should not submit and you should receive an alert saying that no records have been selected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 02:45:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 00:45:11 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #12 from Srdjan Jankovic --- Created attachment 53793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53793&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 02:49:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 00:49:13 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #13 from Srdjan Jankovic --- I will confirm on Jesse's behalf, I believe they even implemented it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 09:06:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 07:06:09 +0000 Subject: [Koha-bugs] [Bug 16996] New: Template process failed: undef error - Can't call method "description" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16996 Bug ID: 16996 Summary: Template process failed: undef error - Can't call method "description" Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: miguel.tuimil at xercode.es QA Contact: testopia at bugs.koha-community.org This problem occurs in special conditions with some preferences settings related to the Patron CategoryCode and edit the personal details in the OPAC: 1. Make sure that the categorycode is not hidden in the OPAC in: PatronSelfRegistrationBorrowerUnwantedField or PatronSelfModificationBorrowerUnwantedField 2. Add a required field in PatronSelfRegistrationBorrowerMandatoryField, for example email. 3. Go to Your Personal Details in the OPAC (opac-memberentry.pl) and leave blank the required field of point 2 4. Press "Submit update request" It should display: Software error: Template process failed: undef Error - Can not call method "description" on an undefined value at /usr/share/koha/lib/Koha/Template/Plugin/Categories.pm line 29. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 09:45:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 07:45:07 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #39 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #38) > (In reply to Marcel de Rooy from comment #37) > > QA Comment: > > If I submit a new review, the approved status will be NULL. > > But reviewswaiting.pl will not show it: > > > > my $status = $query->param('status') || 0; > > ... > > my $reviews = Koha::Reviews->search( > > { approved => $status }, > > Marcel, > This is fixed by "Change default value for approved to 0", please execute > the updatedatabase.pl and update the schema. QA: Looking again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:43:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:43:40 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #40 from Marcel de Rooy --- Marc, The ? in V?ron still makes me crazy. Especially in 11 patches :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:44:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:44:12 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51197|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy --- Created attachment 53794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53794&action=edit Bug 15839: Koha::Reviews - Add Koha::Review[s] classes The subroutines in C4::Reviews are only doing CRUD operations. This patch set moves them to 2 new Koha::Review[s] classes. Test plan for the whole patch set: 0/ Set the reviewson syspref 1/ At the OPAC, create a couple of reviews for a record Try and create a review without html tags different that br b i em big small strong: You should get a warning. 2/ Edit a review 3/ On the Staff interface, you should see a "Comments pending approval" link on the mainpage 4/ Approve 1 review and delete the other 5/ At the OPAC you should only see 1 review (the approved one) in the "Comments" tab 6/ Modify the review 7/ The review should appear again in the "comments awaiting moderation" tab. Note that even the comment has not been changed, it will have to be reapproved (FIXME later). This behavior already existed prior to this patch. Tested all patches together (with database updated) Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:44:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:44:16 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51198|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy --- Created attachment 53795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53795&action=edit Bug 15839: Koha::Reviews - Remove getreviews The C4::Reviews::getreviews subroutine retrieved the reviews for a given record, depending on their status. This can be achieve with a call to Koha::Reviews->search. There were 2 calls to this subroutine. The one from opac-ISBDdetail.pl does not look in used: the reviews are not display on this page. It certainly comes from an old copy/paste from opac-detail.pl. The one from opac-detail only asked for the approved reviews. So the logged in user does not see its own review if it is pending approval. Actually this pending approval review is only displayed when the user submits it (because of a unecessary complex text replacement done in JS). With this patch, the approved reviews AND the unaproved review from the logged in user will be displayed. It will allow a future enhancement to add a way to delete our own reviews. Moreover, the reviews were retrieved even if they were not displayed (if reviewson is off), it's now fixed. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:44:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:44:20 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51199|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy --- Created attachment 53796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53796&action=edit Bug 15839: Koha::Reviews - Remove getallreviews Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:44:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:44:24 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51200|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy --- Created attachment 53797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53797&action=edit Bug 15839: Koha::Reviews - Remove approvereview & unapprovereview This patch adds 2 new methods to Koha::Review: approve and unapprove. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:44:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:44:28 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51201|0 |1 is obsolete| | --- Comment #45 from Marcel de Rooy --- Created attachment 53798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53798&action=edit Bug 15839: Koha::Reviews - Change default value for approved to 0 The reviews.approved column had a default value set to NULL. It does not make sense, the default value should be 0, this will avoid to have to specify the approved value when creating a new review. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:44:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:44:36 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51203|0 |1 is obsolete| | --- Comment #47 from Marcel de Rooy --- Created attachment 53800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53800&action=edit Bug 15839: Koha::Reviews - Remove getreview Note that this (biblionumber, borrowernumber) pair should be defined as a unique key at the DB level (FIXME added) Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:44:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:44:32 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51202|0 |1 is obsolete| | --- Comment #46 from Marcel de Rooy --- Created attachment 53799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53799&action=edit Bug 15839: Koha::Reviews - Remove deletereview Note that a future enhancement should take into account the possible error returned by ->approve, ->unapprove and ->delete Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:44:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:44:40 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51204|0 |1 is obsolete| | --- Comment #48 from Marcel de Rooy --- Created attachment 53801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53801&action=edit Bug 15839: Koha::Reviews - Remove getnumberofreviews Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:44:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:44:44 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51205|0 |1 is obsolete| | --- Comment #49 from Marcel de Rooy --- Created attachment 53802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53802&action=edit Bug 15839: Koha::Reviews - Remove updatereview Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:44:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:44:48 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51206|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy --- Created attachment 53803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53803&action=edit Bug 15839: Koha::Reviews - Remove savereview Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:44:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:44:52 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51207|0 |1 is obsolete| | --- Comment #51 from Marcel de Rooy --- Created attachment 53804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53804&action=edit Bug 15839: Koha::Reviews - Remove C4::Review residue Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:44:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:44:57 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #52 from Marcel de Rooy --- Created attachment 53805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53805&action=edit Bug 15839: [QA Follow-up] Update existing rows in dbrev Adding the default is fine for new records; we also should take care of the pending existing ones. Trivial addition to atomic update file. Signed-off-by: Marcel de Rooy Tested the dbrev again with existing unapproved reviews. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:45:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:45:02 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #53 from Marcel de Rooy --- Created attachment 53806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53806&action=edit Bug 15839: [QA Follow-up] Paging on opac-showreviews Paging is kind of messy here. This patch at least improves somewhat. The page number should be rounded. The results per page should be passed to the template too. Signed-off-by: Marcel de Rooy Tested a number of reviews and played with count parameter in URL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:45:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:45:07 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 --- Comment #54 from Marcel de Rooy --- Created attachment 53807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53807&action=edit Bug 15839: [QA Follow-up] Error checking in opac-review.pl [1] Adds a check on biblionumber. (Prevents a DBIx error.) [2] If you have a reviewid, search on that and check results. Add an unauthorized error in template. [3] If you add a new review, check that there is no review yet. If so, edit the existing one. This supports the added FIXME on a unique constraint. Note: This script could receive further attention. Signed-off-by: Marcel de Rooy Tested all crud ops with opac-review.pl (incl URL manipulation). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 11:46:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 09:46:10 +0000 Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to Koha::Reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #55 from Marcel de Rooy --- qa tools: OK t/db_dependent/Koha/Reviews.t OK Added a follow-up for db rev Loop in opac-detail repeatedly calls GetMember for possibly same borrower? Enabled ShowRecentComments opac-showreviews: Improved paging in a small follow-up. (The count parameter is not kept when paging.) reviewswaiting: When I delete an approved review, the display jumps back to awaiting moderation. Just to mention: If I have two comments on a book, these two icons are weird imo. (Even one, but that is personal taste. :) opac-review: See follow-up Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 12:26:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 10:26:52 +0000 Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency, nowheezy CC| |mirko at abunchofthings.net --- Comment #9 from Mirko Tietgen --- Bytes::Random::Secure should be added to PerlDependencies.pm. libbytes-random-secure-perl is not available for Debian Wheezy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 12:39:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 10:39:33 +0000 Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 --- Comment #10 from Marcel de Rooy --- (In reply to Mirko Tietgen from comment #9) > Bytes::Random::Secure should be added to PerlDependencies.pm. > > libbytes-random-secure-perl is not available for Debian Wheezy. It actually came with WWW::CSRF. It loads Bytes::Random::Secure. Is there a package for that one? Will add a follow-up for B::R::S -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 12:43:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 10:43:35 +0000 Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 --- Comment #11 from Marcel de Rooy --- Created attachment 53809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53809&action=edit Bug 16929: [QA Follow-up] Add dependency for Bytes::Random::Secure Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 12:53:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 10:53:41 +0000 Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 --- Comment #12 from Mirko Tietgen --- > It actually came with WWW::CSRF. It loads Bytes::Random::Secure. Is there a > package for that one? If it is used directly, I think it should be in PerlDependencies. There is no package for WWW:CSRF in Wheezy. I created packages for it and dependencies for the unstable branch for bug 16591. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16591#c7 I did not get any feedback regarding Wheezy so far and did not have time to try it myself, so I have not added them to oldstable yet. > Will add a follow-up for B::R::S Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 13:35:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 11:35:19 +0000 Subject: [Koha-bugs] [Bug 16997] New: Xbox Tech Live 1 855 338 0710 Xbox Customer Support Number Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16997 Bug ID: 16997 Summary: Xbox Tech Live 1 855 338 0710 Xbox Customer Support Number Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: samitasinha67 at gmail.com QA Contact: testopia at bugs.koha-community.org xbox one tech support phone number xbox live support phone xbox live account support number xbox support phone xbox service phone number xbox live account phone number xbox com support number xbox 360 tech support phone number call xbox customer support xbox one customer service phone number xbox live billing phone number xbox live troubleshooting customer service xbox 1800 for my xbox xbox live support telephone number xbox live problems call xbox live support xbox live 800 number xbox number call xbox one tech support number support xbox live xbox one customer support phone number xbox one helpline number xbox one help number xbox contact support xbox billing phone number contact xbox phone number xbox customer service telephone number xbox 1 customer support xbox one 1800 number xbox phone number customer service 1800 my xbox xbox 1 phone number xbox live account support contact xbox live customer service xbox support call xbox live service -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 13:36:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 11:36:21 +0000 Subject: [Koha-bugs] [Bug 16997] Xbox Tech Live 1 855 338 0710 Xbox Customer Support Number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16997 Jason Dave changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion Keywords| |NeedsMoreQA URL| |https://java.net/bugzilla/e | |nter_bug.cgi?product=a3 --- Comment #1 from Jason Dave --- xbox one tech support phone number xbox live support phone xbox live account support number xbox support phone xbox service phone number xbox live account phone number xbox com support number xbox 360 tech support phone number call xbox customer support xbox one customer service phone number xbox live billing phone number xbox live troubleshooting customer service xbox 1800 for my xbox xbox live support telephone number xbox live problems call xbox live support xbox live 800 number xbox number call xbox one tech support number support xbox live xbox one customer support phone number xbox one helpline number xbox one help number xbox contact support xbox billing phone number contact xbox phone number xbox customer service telephone number xbox 1 customer support xbox one 1800 number xbox phone number customer service 1800 my xbox xbox 1 phone number xbox live account support contact xbox live customer service xbox support call xbox live service -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 15:39:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 13:39:16 +0000 Subject: [Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov --- Comment #3 from Peggy Thrasher --- This would be helpful for us. We have a location for "Download" where we put all of our Overdrive titles. Recently we have had patrons put a hold on a physical book and change the pickup location to "Download". We'd like to be able to take "Download" off the list of pickup locations that they can choose from. It would be sufficient for us if there was a choice when you were defining the library (Administration/Libraries and Groups) for Pickup location - yes or no. Thanks! Peggy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 15:52:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 13:52:37 +0000 Subject: [Koha-bugs] [Bug 16995] Remove event attributes from two include files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16995 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 15:52:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 13:52:39 +0000 Subject: [Koha-bugs] [Bug 16995] Remove event attributes from two include files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16995 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53790|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 53812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53812&action=edit Bug 16995 - Remove event attributes from two include files This patch removes event attributes from two include files: cat-toolbar.inc and members-toolbar.inc. In cat-toolbar.inc an unused tag with an "onsubmit" attribute has been removed. To test, apply the patch and: - View the detail page for any bibliographic record. All toolbar buttons ("New," "Edit," "Save," etc.) should work as expected. - View the detail page for any patron. Click the "Add message" button in the toolbar. Selecting a predefined note should correctly populate the textarea with your selected message. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 16:36:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 14:36:34 +0000 Subject: [Koha-bugs] [Bug 16874] Making serials collections actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874 --- Comment #5 from Claire Gravely --- (In reply to Aleisha Amohia from comment #4) > (In reply to Claire Gravely from comment #3) > > Hi, > > Sorry, I didn't get two buttons in step 4 of the test. Just the one for > > 'create routing list'. The line wasn't highlighted either. > > > > 'Print list' was displaying just fine as a button. > > > > Claire > > Sorry, I should've added that the Renew button and row highlighting will > only show if the subscription is about to expire or has expired. Could you > please retest? Hi, I just tried again. Same result. I set the expiration date in the past, today and in the future and saw the same results each time with no renew button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 17:20:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 15:20:22 +0000 Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53675|0 |1 is obsolete| | --- Comment #10 from Lari Taskula --- Created attachment 53813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53813&action=edit Bug 16826: Add API route for getting item availability Reverts some small unintended changes (unneccessary e.g. line breaks) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 17:22:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 15:22:12 +0000 Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|nowheezy | --- Comment #13 from Mirko Tietgen --- libbytes-random-secure-perl is in the Koha stable and olstable repositories now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 17:52:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 15:52:35 +0000 Subject: [Koha-bugs] [Bug 16998] New: Xbox Tech Live 1 855 338 0710 Xbox Customer Support Number Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16998 Bug ID: 16998 Summary: Xbox Tech Live 1 855 338 0710 Xbox Customer Support Number Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Project website Assignee: wizzyrea at gmail.com Reporter: samitasinha67 at gmail.com xbox one tech support phone number xbox live support phone xbox live account support number xbox support phone xbox service phone number xbox live account phone number xbox com support number xbox 360 tech support phone number call xbox customer support xbox one customer service phone number xbox live billing phone number xbox live troubleshooting customer service xbox 1800 for my xbox xbox live support telephone number xbox live problems call xbox live support xbox live 800 number xbox number call xbox one tech support number support xbox live xbox one customer support phone number xbox one helpline number xbox one help number xbox contact support xbox billing phone number contact xbox phone number xbox customer service telephone number xbox 1 customer support xbox one 1800 number xbox phone number customer service 1800 my xbox xbox 1 phone number xbox live account support contact xbox live customer service xbox support call xbox live service **? ??? ??? ???? ? Xbox Live Support Number ++++1-855-338-0710 Xbox Live Support Number** [Xbox Live Support Number 1 855 338 0710][1] We're happy to help you 24/7 call us 1 855 338 0710 Xbox Live Support Number 1 855 338 0710 [1]: http://xboxlivesupportnume.site123.me/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 17:54:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 15:54:07 +0000 Subject: [Koha-bugs] [Bug 16999] New: Xbox Number 1 855 338 0710 Xbox Customer Support Number Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16999 Bug ID: 16999 Summary: Xbox Number 1 855 338 0710 Xbox Customer Support Number Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: samitasinha67 at gmail.com QA Contact: testopia at bugs.koha-community.org xbox one tech support phone number xbox live support phone xbox live account support number xbox support phone xbox service phone number xbox live account phone number xbox com support number xbox 360 tech support phone number call xbox customer support xbox one customer service phone number xbox live billing phone number xbox live troubleshooting customer service xbox 1800 for my xbox xbox live support telephone number xbox live problems call xbox live support xbox live 800 number xbox number call xbox one tech support number support xbox live xbox one customer support phone number xbox one helpline number xbox one help number xbox contact support xbox billing phone number contact xbox phone number xbox customer service telephone number xbox 1 customer support xbox one 1800 number xbox phone number customer service 1800 my xbox xbox 1 phone number xbox live account support contact xbox live customer service xbox support call xbox live service **? ??? ??? ???? ? Xbox Live Support Number ++++1-855-338-0710 Xbox Live Support Number** [Xbox Live Support Number 1 855 338 0710][1] We're happy to help you 24/7 call us 1 855 338 0710 Xbox Live Support Number 1 855 338 0710 [1]: http://xboxlivesupportnume.site123.me/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 22:10:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 20:10:09 +0000 Subject: [Koha-bugs] [Bug 16997] Spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16997 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de Summary|Xbox Tech Live 1 855 338 |Spam |0710 Xbox Customer Support | |Number | Status|In Discussion |RESOLVED --- Comment #2 from Katrin Fischer --- Spam -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 22:11:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 20:11:32 +0000 Subject: [Koha-bugs] [Bug 16999] Spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16999 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Xbox Number 1 855 338 0710 |Spam |Xbox Customer Support | |Number | Status|NEW |RESOLVED Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 22:11:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 20:11:48 +0000 Subject: [Koha-bugs] [Bug 17000] New: Patron Modification log access permission Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17000 Bug ID: 17000 Summary: Patron Modification log access permission Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: ed.veal at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com You can only see patron modification log when viewing a patron record if you have one or both of the ?parameters Manage Koha system settings (Administration panel)? permissions. This is good information for the circulation staff to be able to access. Ed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 22:12:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 20:12:06 +0000 Subject: [Koha-bugs] [Bug 16998] Spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16998 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Xbox Tech Live 1 855 338 |Spam |0710 Xbox Customer Support | |Number | Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 22:38:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 20:38:34 +0000 Subject: [Koha-bugs] [Bug 17001] New: filtering overdue report by due date can fail if TimeFormat is 12hr Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001 Bug ID: 17001 Summary: filtering overdue report by due date can fail if TimeFormat is 12hr Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When using the overdue report circ/overdue.pl, if the TimeFormat system preference is set to 12-hour, setting a filter on the due date range can result in zero overdue loans being displayed, even if there are ones that fall in the range. This happens because the date/time that gets passed to the SQL is formatted incorrectly; rather than '2016-07-29 23:59', it gets passed as '2016-07-29 11:59 PM'; on many MySQL and MariaDB versions, that becomes NULL when cast to a datetime. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 23:07:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 21:07:04 +0000 Subject: [Koha-bugs] [Bug 17001] filtering overdue report by due date can fail if TimeFormat is 12hr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 29 23:07:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Jul 2016 21:07:06 +0000 Subject: [Koha-bugs] [Bug 17001] filtering overdue report by due date can fail if TimeFormat is 12hr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001 --- Comment #1 from Galen Charlton --- Created attachment 53814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53814&action=edit Bug 17001: fix due date filter on the overdue report When the TimeFormat system preference is set to "12 hour", setting a filter on the due date can result in: - no overdue loans being reported, even if there are some that meet the criteria OR - overdue loans being omitted from the report if they are due on the "until" date in the filter This patch fixes this by replacing output_pref() with DateTime::Format::MySQL to format the date filter values to pass to the SQL query. To test ------- [1] Run the overdue report (circ/overdue.pl) and set a filter on due date, using values that should bring up one or more overdue loans. [2] Note that zero overdue loans are returned (if using MySQL 5.5, 5.6, or 5.7 or MariaDB 5) or that loans due on the "until" date are omitted (if using MarioDB 10). [3] Apply the patch and repeat step 1. This time, the correct set of overdue loans should be reported. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 30 07:25:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jul 2016 05:25:35 +0000 Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16987 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 30 07:25:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jul 2016 05:25:35 +0000 Subject: [Koha-bugs] [Bug 16987] sub duplicate_framework in admin/marctagstructure.pl can' t see variable $cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16987 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16955 CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Hi Josef, Can you please have a look at Bug 16955 - Internal Server Error while populating new framework ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 30 07:51:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jul 2016 05:51:53 +0000 Subject: [Koha-bugs] [Bug 16949] Batch record deletion says success when no records have been passed in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949 --- Comment #7 from Marc V?ron --- Hi ALeisha, I applied the patch, cleared the browser cache and tested. Now I get always "No records have been selected" (with or withot items selected in checkboxes). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 30 10:55:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jul 2016 08:55:48 +0000 Subject: [Koha-bugs] [Bug 16987] sub duplicate_framework in admin/marctagstructure.pl can' t see variable $cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16987 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #3 from Josef Moravec --- It's definitely duplicate, I'm closing this. *** This bug has been marked as a duplicate of bug 16955 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 30 10:55:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jul 2016 08:55:48 +0000 Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #3 from Josef Moravec --- *** Bug 16987 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 30 11:01:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jul 2016 09:01:38 +0000 Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 30 11:01:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jul 2016 09:01:40 +0000 Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53612|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 53815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53815&action=edit Bug 16955: Internal Server Error while populating new framework While populating a new framework, an internal server error occurs. (Error occurs with plack enabled) Steps to reproduce: - Go to Home > Administration > MARC frameworks - Add framework e.g. TEST, submit - In List of frameworks, go to framework TEST, Actions, MARC Structure - Create framework for... : Select DEFAULT Result: Internal Server Error (rest of screen blank) This patch fixes a variable scope issue and moves 4 lines that should be inside a loop. To test: - Apply patch - Verify that code changes make sense - Try to recreate error Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 30 11:08:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jul 2016 09:08:18 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 30 11:58:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jul 2016 09:58:55 +0000 Subject: [Koha-bugs] [Bug 17002] New: HP printer 1 888 883 1066 HP printer support number Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17002 Bug ID: 17002 Summary: HP printer 1 888 883 1066 HP printer support number Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Project website Assignee: wizzyrea at gmail.com Reporter: samitasinha67 at gmail.com hp printer support phone,, customer service hp printer,, hp printer phone number customer service,, hp printer support number,, hp printer one number,, call hp printer customer support,, hp printer 360 help number,, hp printer customer service hours,, hp printer live support telephone number,, hp printer live problems,, hp printer live 800 number,, hp printer number call,, support hp printer live,, number for hp printer support,, contact hp printer live customer service,, 1800 for my hp printer,, hp printer one help number,, hp printer live account phone number,, call hp printer customer service,, hp printer live support phone hp printer customer service line,, hp printer customer service telephone number,, hp printer 1 customer support,, hp printer support number,, call hp printer live support,, hp printer contact support,, hp printer one customer service phone number,, hp printer live billing phone number,, hp printer one tech support number,, hp printer 1 phone number,, hp printer live account support number,, hp printer one helpline number,, hp printer support call,, hp printer live accounts,, hp printer service phone number,, hp printer live troubleshooting,, hp printer.com phone number,, hp printer one 1800 number,, hp printer live technical support phone number ? ??? ??? ???? ? HP Printer Support Number ++++1-888-883-1066 HP printer support number HP printer support number 1 888 883 1066 http://hpprintersupportnumber.site123.me/ We're happy to help you 24/7 call us 1 888 883 1066 HP printer support number 1 888 883 1066 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 30 11:59:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jul 2016 09:59:33 +0000 Subject: [Koha-bugs] [Bug 17002] HP printer 1 888 883 1066 HP printer support number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17002 Jason Dave changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17002 Status|NEW |In Discussion --- Comment #1 from Jason Dave --- hp printer support phone,, customer service hp printer,, hp printer phone number customer service,, hp printer support number,, hp printer one number,, call hp printer customer support,, hp printer 360 help number,, hp printer customer service hours,, hp printer live support telephone number,, hp printer live problems,, hp printer live 800 number,, hp printer number call,, support hp printer live,, number for hp printer support,, contact hp printer live customer service,, 1800 for my hp printer,, hp printer one help number,, hp printer live account phone number,, call hp printer customer service,, hp printer live support phone hp printer customer service line,, hp printer customer service telephone number,, hp printer 1 customer support,, hp printer support number,, call hp printer live support,, hp printer contact support,, hp printer one customer service phone number,, hp printer live billing phone number,, hp printer one tech support number,, hp printer 1 phone number,, hp printer live account support number,, hp printer one helpline number,, hp printer support call,, hp printer live accounts,, hp printer service phone number,, hp printer live troubleshooting,, hp printer.com phone number,, hp printer one 1800 number,, hp printer live technical support phone number ? ??? ??? ???? ? HP Printer Support Number ++++1-888-883-1066 HP printer support number HP printer support number 1 888 883 1066 http://hpprintersupportnumber.site123.me/ We're happy to help you 24/7 call us 1 888 883 1066 HP printer support number 1 888 883 1066 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 30 13:12:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jul 2016 11:12:15 +0000 Subject: [Koha-bugs] [Bug 16952] Add sorting rules for Czech language to Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 30 13:15:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jul 2016 11:15:20 +0000 Subject: [Koha-bugs] [Bug 16952] Add sorting rules for Czech language to Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 00:19:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Jul 2016 22:19:57 +0000 Subject: [Koha-bugs] [Bug 15906] Remove use of makepayment in paycollect.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15906 Michael Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik at adminkuhn.ch --- Comment #4 from Michael Kuhn --- In a user account some reasons for payments were created. Then a click on "Make payment" shows these individual fines & charges. One ist selected, then the button "Pay" is clicked. The payment does not work. Instead the following message appears: Software error: Can't locate object method "new" via package "Koha::Account" at /home/koha/src/members/paycollect.pl line 114. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 02:33:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 00:33:20 +0000 Subject: [Koha-bugs] [Bug 16955] Internal Server Error while populating new framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16955 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 11:19:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 09:19:57 +0000 Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #20 from Ji?? Kozlovsk? --- Created attachment 53816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53816&action=edit Fixed QA demands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 11:22:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 09:22:38 +0000 Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 11:22:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 09:22:41 +0000 Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53816|0 |1 is obsolete| | --- Comment #21 from Ji?? Kozlovsk? --- Created attachment 53817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53817&action=edit Fixed QA demands https://bugs.koha-community.org/show_bug.cgi?id=13895 Signed-off-by: Ji?? Kozlovsk? Test plan still working -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 11:38:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 09:38:06 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #3 from Ji?? Kozlovsk? --- Created attachment 53818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53818&action=edit Bug 14793: New cataloguing plugin unimarc_field_225a_bis It is similar to unimarc_field_210c_bis, but searches in biblioitems.collectiontitle instead of biblioitems.publishercode Signed-off-by: Laurence Rault Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 11:49:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 09:49:26 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52905|0 |1 is obsolete| | --- Comment #4 from Ji?? Kozlovsk? --- Created attachment 53819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53819&action=edit Bug 16497 - REST API: add routes to list libraries Simple routes to list all or get one Library GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl Signed-off-by: Lari Taskula Signed-off-by: Ji?? Kozlovsk? Works as expected. Nice work! :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 11:50:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 09:50:21 +0000 Subject: [Koha-bugs] [Bug 16497] REST API: add routes to list libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mail at jkozlovsky.cz Attachment #53818|0 |1 is obsolete| | --- Comment #5 from Ji?? Kozlovsk? --- Comment on attachment 53818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53818 Bug 14793: New cataloguing plugin unimarc_field_225a_bis Sorry about this patch, my git bz did not function correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 11:58:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 09:58:33 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #13 from Ji?? Kozlovsk? --- Created attachment 53820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53820&action=edit Bug 16330: (followup) fix spelling and number of tests Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Benjamin Rokseth Signed-off-by: Ji?? Kozlovsk? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 12:05:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 10:05:01 +0000 Subject: [Koha-bugs] [Bug 13927] Add API route to check hold capabilities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13927 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mail at jkozlovsky.cz --- Comment #2 from Ji?? Kozlovsk? --- Well, the bug 13903 changed in the meanwhile. How about changing the route to: GET /holds?borrowernumber=X&biblionumber=X GET /holds?borrowernumber=X&itemnumber=X -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 12:13:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 10:13:33 +0000 Subject: [Koha-bugs] [Bug 14096] Licences on About page not consistently linked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14096 Michael Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik at adminkuhn.ch --- Comment #2 from Michael Kuhn --- In (sandbox) Koha 3.23.00.018 all given components in Koha menu "About > Licenses" do contain valid links. One exception: the jQuery insertAtCaret Plugin - but I couldn't find a valid URL to that plugin by the phpMyAdmin devel team either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 12:17:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 10:17:25 +0000 Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13927 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 12:17:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 10:17:25 +0000 Subject: [Koha-bugs] [Bug 13927] Add API route to check hold capabilities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13927 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16826 Status|Needs Signoff |In Discussion --- Comment #3 from Ji?? Kozlovsk? --- Or even better to do it same way as is bug 16826: GET /availability/items?borrowernumber=&itemnumber=123 GET /availability/items?borrowernumber=&biblionumber=123 Could be quite good if the output was the same as in mentioned bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 12:27:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 10:27:38 +0000 Subject: [Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 --- Comment #11 from Ji?? Kozlovsk? --- It works for me so far. Are you going to do any further changes to this bug or you are willing to mark it as Needs Signoff? All tests passed for me, so I could sign this off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 12:59:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 10:59:55 +0000 Subject: [Koha-bugs] [Bug 17003] New: REST API: add route to get checkout's renewability Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Bug ID: 17003 Summary: REST API: add route to get checkout's renewability Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: mail at jkozlovsky.cz QA Contact: testopia at bugs.koha-community.org Depends on: 13895 Add API route for checking renewability of an checkedout item. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 [Bug 13895] Add API routes for checkouts retrieval and renewal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 12:59:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 10:59:55 +0000 Subject: [Koha-bugs] [Bug 13895] Add API routes for checkouts retrieval and renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 [Bug 17003] REST API: add route to get checkout's renewability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:03:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:03:45 +0000 Subject: [Koha-bugs] [Bug 17004] New: REST API: add route to authenticate patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004 Bug ID: 17004 Summary: REST API: add route to authenticate patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: mail at jkozlovsky.cz QA Contact: testopia at bugs.koha-community.org Add API route to authenticate patron. This would be very useful for 3rd party applications, such as NCIP's LookupUser service or simpleSAMLphp IdP for eduGAIN. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:06:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:06:01 +0000 Subject: [Koha-bugs] [Bug 17005] New: REST API: add routes to list checkouts history Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Bug ID: 17005 Summary: REST API: add routes to list checkouts history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: mail at jkozlovsky.cz QA Contact: testopia at bugs.koha-community.org Add API to list checkouts history for a user. This is very useful for use with VuFind. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:06:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:06:29 +0000 Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16825, 17003, 17004, 17005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 [Bug 16825] Add API route for getting an item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 [Bug 17003] REST API: add route to get checkout's renewability https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004 [Bug 17004] REST API: add route to authenticate patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 [Bug 17005] REST API: add routes to list checkouts history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:06:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:06:29 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:06:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:06:29 +0000 Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:06:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:06:29 +0000 Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:06:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:06:29 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:17:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:17:22 +0000 Subject: [Koha-bugs] [Bug 17006] New: REST API: add route to change patron's password Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Bug ID: 17006 Summary: REST API: add route to change patron's password Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: mail at jkozlovsky.cz QA Contact: testopia at bugs.koha-community.org Add API to change patron's password. This is useful especially for 3rd party applications like VuFind. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:20:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:20:22 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |black23 at gmail.com, | |josef.moravec at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:22:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:22:16 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sposored by Ministry of release notes| |Culture Czech | |Republic/Minucipal Libray | |Ceska Trebova -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:24:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:24:00 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sposored by Ministry of release notes| |Culture Czech | |Republic/Minucipal Libray | |Ceska Trebova Change sponsored?|--- |Sponsored CC| |black23 at gmail.com, | |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:25:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:25:32 +0000 Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Text to go in the| |Sposored by Ministry of release notes| |Culture Czech | |Republic/Minucipal Libray | |Ceska Trebova Change sponsored?|--- |Sponsored CC| |black23 at gmail.com, | |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:27:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:27:34 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Text to go in the| |Minucipal Libray Ceska release notes| |Trebova CC| |black23 at gmail.com, | |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:27:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:27:58 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sposored by Ministry of |Minucipal Libray Ceska release notes|Culture Czech |Trebova |Republic/Minucipal Libray | |Ceska Trebova | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:28:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:28:33 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sposored by Ministry of |Municipal Libray Ceska release notes|Culture Czech |Trebova |Republic/Minucipal Libray | |Ceska Trebova | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:28:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:28:52 +0000 Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sposored by Ministry of |Municipal Libray Ceska release notes|Culture Czech |Trebova |Republic/Minucipal Libray | |Ceska Trebova | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:29:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:29:12 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Minucipal Libray Ceska |Municipal Libray Ceska release notes|Trebova |Trebova -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:29:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:29:27 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Minucipal Libray Ceska |Municipal Libray Ceska release notes|Trebova |Trebova -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:32:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:32:28 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 13:32:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 11:32:28 +0000 Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 [Bug 17006] REST API: add route to change patron's password -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 16:47:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 14:47:21 +0000 Subject: [Koha-bugs] [Bug 17002] Spam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17002 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de Status|In Discussion |RESOLVED Summary|HP printer 1 888 883 1066 |Spam |HP printer support number | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 21:59:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 19:59:26 +0000 Subject: [Koha-bugs] [Bug 14084] order date language in Koha inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hm, in aqbasket there are 2 date fiels: creationdate and closedate. As the order status switches to 'ordered' when you close the basket, I think order date makes sense there. When the creationdate is displayed it should be creation date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 23:26:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 21:26:46 +0000 Subject: [Koha-bugs] [Bug 16989] Advanced search form does not display translated itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16989 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 23:26:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 21:26:49 +0000 Subject: [Koha-bugs] [Bug 16989] Advanced search form does not display translated itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16989 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53789|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 53821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53821&action=edit [PASSED QA] Bug 16989 - Advanced search form does not display translated itemtype In Staff client, the advanced serach form does not display the translations of item types. (Note: It is not necessary to have translations installed to verify this bug.) Prerequisites: - Go to Home > Administration > Item types administration - Edit e.g. item type "BK" (Book) - Near "Description", click link "Translate into other languages - If you have other languaes installed, add translatons for those - If you have an Englis only installation, add a "translation" for English, make sure that you can identify it while testing (I used "BOOOOOOOOOOOOKS") Verify: - Go to Home ? Advanced search - Verify near "Limit to any of the following" that the description for itemtype BK reads "Book" instead of "BOOOOOOOOOOOOKS" Test: - Apply patch - Verify that the item type description now reads ""BOOOOOOOOOOOOKS" - If you have a multi language installaton, verify that item types you translated display as appropriate Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 23:37:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 21:37:03 +0000 Subject: [Koha-bugs] [Bug 16995] Remove event attributes from two include files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16995 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 31 23:37:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jul 2016 21:37:06 +0000 Subject: [Koha-bugs] [Bug 16995] Remove event attributes from two include files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16995 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53812|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 53822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53822&action=edit [PASSED QA] Bug 16995 - Remove event attributes from two include files This patch removes event attributes from two include files: cat-toolbar.inc and members-toolbar.inc. In cat-toolbar.inc an unused tag with an "onsubmit" attribute has been removed. To test, apply the patch and: - View the detail page for any bibliographic record. All toolbar buttons ("New," "Edit," "Save," etc.) should work as expected. - View the detail page for any patron. Click the "Add message" button in the toolbar. Selecting a predefined note should correctly populate the textarea with your selected message. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes.