[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #49 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Comment on attachment 53013
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53013
Bug 15006: Add timeout and strikes to raw_transport

This is unnecessary - The bogus 3 strikes was already removed in commit 
078ce11e113b172726f9ab3180e52a06334d4aab


Test plan is ambiguous this routine is not called when using "telnet"
authentication. On a raw connection session is started when a sip login is
received. If that login fails, the session is terminated. (The login is from
the client machine's config so it wont try again with different values) and
sends a failed login response before shutting down. If the input is not a login
message or a random string it does not respond or login the session but falls
through to sip_protocol_loop and times out on the time out set there. I think
this should be considered a bug. Its probably the reason why adding a timeout
to that had an effect on building up sip sessions as that is meant to be an
endless (until logout or connection drop) loop - I think this a bug and that if
a connection is not established raw_transport should exit without entering
sip_loop

-- 
You are receiving this mail because:
You are watching all bug changes.