[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #52 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to Marcel de Rooy from comment #51)
> (In reply to Colin Campbell from comment #49)
> > Comment on attachment 53013 [details] [review] [review]
> > Bug 15006: Add timeout and strikes to raw_transport
> > 
> > This is unnecessary - The bogus 3 strikes was already removed in commit 
> > 078ce11e113b172726f9ab3180e52a06334d4aab
> > 
> > 
> > Test plan is ambiguous this routine is not called when using "telnet"
> > authentication. On a raw connection session is started when a sip login is
> > received. If that login fails, the session is terminated. (The login is from
> > the client machine's config so it wont try again with different values) and
> > sends a failed login response before shutting down. If the input is not a
> > login message or a random string it does not respond or login the session
> > but falls through to sip_protocol_loop and times out on the time out set
> > there. I think this should be considered a bug. Its probably the reason why
> > adding a timeout to that had an effect on building up sip sessions as that
> > is meant to be an endless (until logout or connection drop) loop - I think
> > this a bug and that if a connection is not established raw_transport should
> > exit without entering sip_loop
> 
> From testing i recall seeing that raw_transport does respond to requests;
> one of the reasons that I made it more restrict in a previous patch (relaxed
> it later again for minimal behavior changes).

Been doing some extensive testing and the raw_transport routine going some
things very differently than I think we all imagine. Will post the patch when
final element merged. We need the timeout to escape the while if anyone can
engineer us into an infinite loop there (I've not been able to do that
...but..)

-- 
You are receiving this mail because:
You are watching all bug changes.