[Koha-bugs] [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849

--- Comment #5 from Marc Véron <veron at veron.ch> ---
(In reply to Jonathan Druart from comment #4)
> (In reply to Marc Véron from comment #3)
> > Regarding /3 Make sure he cannot get a discharge
> > 
> > I added a manual restriction to a patron, and I can discharge her with and
> > without patch.
> > Should discharges be blocked by restrictions?
> 
> Actually it's a bit tricky :)
> The expected behavior is:
> Discharge a patron for the first time will debar the patron and generate a
> discharge.
> Click on discharge again: no new discharge will be generated (the pdf will,
> but no new entries in the discharges table).
> Remove the debarment and generate a new discharge will create a new entry in
> the discharges table.

Thanks, Jonathan, for the explanation.

Patch works as described and I will sign off.

For the records: 
IMO the behavior (with and without patch) is not optimal: 
- As far as I understand a patron who has got a discharge should not be able to
check out items again (adding a restriction that never expires).
- However, if I put a manual restriction to this patron that expires let's say
tomorrow, discharging will not add it's own restriction. The day after
tomorrow, the patron will be able to check out again (but she has got a
discharge).

What do you think about? Is that intended or is it a Bug?

-- 
You are receiving this mail because:
You are watching all bug changes.