[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

--- Comment #57 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #52)
> (In reply to Alex Sassmannshausen from comment #49)
> > * t/db_dependent/Patron/CheckPrevCheckout.t: Renamed to...
> > * t/db_dependent/Patron/Borrower_PrevCheckout.t: ...this.
> 
> Why? :)

It struck me there was a pattern to the naming of the test files, I decided to
stick with that.

> (In reply to Alex Sassmannshausen from comment #51)
> > - One patch now adds updated schema files for dbic.  This will fix the test
> > error (previously I assumed the tester would do this, but since the last
> > hackfest I no longer make that assumption).
> 
> AFAIK that is still the case.
> Actually I personally submit a patch with a DONT_PUSH pattern in the commit
> message and let the RM generate the schema by himself.

Interesting — I see the reason why you'd add DONT_PUSH — presumably to make it
clear to the RM that they should generate the schema files themselves…

To clarify: do you literally just dump DONT_PUSH somewhere in the commit
message?

Or is it part of the subject line or has a special location?

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.