[Koha-bugs] [Bug 16212] Swagger specification separation and minification

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no

--- Comment #26 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Hi,
as much as I would like to sign off this patch, I'm afraid I cannot agree on
the notion of automatic minifying. It is an anti-pattern of production code,
and requires too much quirks to my liking.

a) It allows for inconsistency between apache/plack and minified/not minified
b) It requires cgi/apache rights to write to swagger definitions, not a good
idea.
c) Plack also needs restarting/cache invalidation, since it caches swagger.json
d) What is the problem of minifying before deploy anyways?

Also I'm not sure of the need to minify swagger at all. If the only reason is
for the online validation, I would argue that the online validation is the
problem. More important is `mojo swagger2 validate`. Minifying swagger gives no
extra performance opposed to http gzipped, probably the opposite. And it is
unreadable.

Hate to be the party killer, but if you consider removing the patch
"Automatically minify swagger.json" I will sign off. Certainly if it means the
splitting of definition and paths can be signed off, which I consider a very
good idea.

I don't consider the online validation an issue, but I do consider the
problematic patching of large json files an issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.