[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

--- Comment #19 from Lari Taskula <larit at student.uef.fi> ---
(In reply to Julian Maurice from comment #18)
> > - /accountlines/:borrowernumber/amountpayment is confusing because of
> >   :borrowernumber. How about /accountlines/amountpayment?borrowernumber=X
> I believe it's not a good idea to mix GET and POST parameters. What about
> POST /borrowers/:borrowernumber/payment ?
> 
Good point. That makes more sense.

> > - Do you think it would be useful to return total and currency? e.g.
> >   GET /accountlines?borrowernumber=1
> >   {
> >   	"total": 100.00,
> > 	"currency": "USD",
> > 	"rows": [
> > 	  {
> > 		// accountline-object with amountoutstanding 25,
> > 		// accountline-object with amountoutstanding 60,
> > 		// accountline-object with amountoutstanding 15
> > 	  }
> > 	]
> >   }
> I think it couldn't hurt. But what currency should we return ? The default
> (active) currency ?
I think yes. Could there be a situation where active currency would not be the
correct one, apart from misconfiguration of the active currency?

-- 
You are receiving this mail because:
You are watching all bug changes.