[Koha-bugs] [Bug 16889] Move the ::columns subroutines to Koha::Objects->columns

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jul 12 03:36:20 CEST 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16889

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #7 from M. Tompsett <mtompset at hotmail.com> ---
Commit #1: Test in patch is sufficient to test.

Commit #2: Yes, I can get into Tools->Import Patrons just fine.
Couldn't find any other instance of C4::Members::columns, so this patch has it
covered as far as I can tell.

Commit #3&#4: The Items.pm change is tested enough by
prove t/db_dependent/Items/AutomaticItemModificationByAge.t
The automatic item modification by age tool removing a rule is unintuitive.

Code eyeballs well enough.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list