[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53310|0                           |1
        is obsolete|                            |

--- Comment #70 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 53358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53358&action=edit
[SIGNED-OFF] Bug 15006: Centralize timeout logic and allow zero client timeout

Moving timeout logic to one routine in Sip.pm (with unit test).

This further implements two suggestions from Kyle and Larry:

[1] You could use a client_timeout of 0 to specify no timeout at all.
[2] Have the client_timeout default to the timeout if not defined.

Test plan:
[1] Run t/SIP_Sip.t
[2] Test login timeout for raw and telnet.
[3] Check ACS status message for timeout value. Should match policy
    timeout from institution.
[4] Test client timeout (zero and non-zero).
[5] Remove client timeout. Test fallback to service.
[6] Remove service timeout too. Test fallback to 30 at login.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.