[Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #27 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Marcel de Rooy from comment #26)
> (In reply to M. Tompsett from comment #23)
> > ::: misc/stage_file.pl
> > @@ +85,4 @@
> > >  
> > >  my $dbh = C4::Context->dbh;
> > >  $dbh->{AutoCommit} = 0;
> > > +process_batch($format, $input_file, $record_type, $match, $add_items, $batch_comment);
> > 
> > Could we hashref this, please?
> 
> We should not per se hashref to hashref imo. This is just a local sub of one
> script. But seeing the mix of parameters and file level vars, I decided to
> do it after all. Hopefully a slight improvement of the code.

Why did you change everything to the hashref references?
my ($parameters) = @_;
my $format = $parameters->{format};
...
block at the top and all the other code wouldn't need to be changed.

-- 
You are receiving this mail because:
You are watching all bug changes.