[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Liz Rea from comment #18)

Hi,

> However I still can't make the required hold notes work. Also was further
> confused by bug 16391, which makes your plugins not show up in the list when
> you go back to the page, even if they are installed. Removing method=tool
> from the url makes them turn up. That's not your fault, it just caused me
> trouble when I was testing.
You are right. I made a remark on that report too. Could add a fake tool
subroutine to make them show up, but that would not be a real solution.

> The patches don't break anything that I can see. I was testing on current
> master, 3692f92.
Well, that is a major goal :)

> Maybe you know something else I could be doing wrong?
First verify that the plugin is installed etc., so we know that it is called.
Pick a marc record with available item, change the leader (probably replace nam
by nas), i.e. make sure that position 7 is the character s.
Go to opac, place a hold on that specific record. If you unhide the options,
you already should see the text line: Please enter additional information about
the requested item. Pressing Place Hold should not work. Depending on the
browser, the text box is marked red or something. If that is the case, you
actually finished testing already (the hold note indeed is required now).

Alternatively, you could also edit the plugin's Leader.pm, add a "return 1;" in
the check subroutine near the top. Because we are not focusing on testing the
plugin here but only the routine in Reserves calling available plugins. In that
case messing with records is not needed..

Thanks again.

-- 
You are receiving this mail because:
You are watching all bug changes.